#(joshjustga) Update for smithing recipe changes

30 messages · Page 1 of 1 (latest)

dreamy berry
magic brookBOT
#

(joshjustga) Fixing a broken smithing script due to 1.20 changes

#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.
You can block this bot if you don't want to see these messages, I won't mind.
<@&525394568410038282>

magic brookBOT
dreamy berry
#

You 'used' to just drop a netherite item + this token in to get the tempered version

silver pulsar
#

Yeah, inventory scripts need to be updated for the new smithing recipes

peak sluiceBOT
#
Changed to Feature

Thread is now a Feature thread. This indicates a request for a new feature to the plugin, that both (A) does not already exist and (B) reasonably can be added. If you are unsure whether this applies, use </helpthread:1028674284870180883> to change back to a normal help thread.

silver pulsar
#

(joshjustga) Update for smithing recipe changes

dreamy berry
#

Ah

#

Wait so the features are already implemented? just no docs?

silver pulsar
#

It's currently still trying to use the old format, and needs to be updated to use the new one

#

(in the code itself)

dreamy berry
#

Ah oki pokey will hold off until updated 🙂

dreamy berry
#

Hey! Any Updates to this? 😄

slate cedar
#

It might be handy to let denizen handle the slots in the prepares smithing item event and add <context.ingredient>, <context.template> and <context.base>, slot numbers might have changed from 1.19.4 -> 1.20.1, so the version check won't have to be made in script and material based recipes that checking by inventory.slot won't necessarily break

fast gyro
#

i would like to see if i can try and update this for 1.19.4/1.20.1. it seems like a complicated PR but i think i'll be able to manage it. if it is too difficult i'll say so here and someone else can probably take over this

fast gyro
slate cedar
#

It's a nice feeling if you write something and it just works right

fast gyro
#

just merged, see #commit-log

peak sluiceBOT
#
Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@dreamy berry

dreamy berry