(masecla22) Issues with Citizens API | Denizen and Citizens | Page 1

stray matrix Jun 11, 2023, 12:05 PM

#

Hey!

I'm having a couple troubles with the Citizens API. Specifically, when the NPC gets stuck, I added a .stuckAction on the NPC, in which I cancel the navigation and then teleport the NPC. But for some reason, the stuckAction method gets called multiple times and also doesn't teleport the NPC! Any ideas?

rustic sirenBOT Jun 11, 2023, 12:05 PM

#

(masecla22) Issues with Citizens API

rustic sirenBOT Jun 11, 2023, 12:05 PM

#

stray matrix Hey! I'm having a couple troubles with the Citizens API. Specifically, when the...

#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.
You can block this bot if you don't want to see these messages, I won't mind.
<@&525394568410038282>

#

stray matrix Jun 11, 2023, 12:06 PM

#

This here is my stuck action

#

#

validateSpawnLocation finds a correct spawn location

#

moveTo teleports the NPC

#

#

But I end up with this

orchid orchid Jun 11, 2023, 12:27 PM

#

https://jd.citizensnpcs.co/net/citizensnpcs/api/ai/StuckAction.html

StuckAction (citizens-main 2.0.32-SNAPSHOT API)

declaration: package: net.citizensnpcs.api.ai, interface: StuckAction

#

you need to return true if you want to continue navigation

#

cancelNavigation shouldn't be called again

#

@stray matrix

stray matrix Jun 11, 2023, 12:42 PM

#

orchid orchid you need to return true if you want to continue navigation

Yeah I want to cancel the navigation

#

#

I've tried returning true,

#

I've tried returning false

#

I've tried not calling cancelNavigation

#

If I return true, I get this NPE

#

#

And if i return true without cancelling it, it still hangs in a loop

orchid orchid Jun 11, 2023, 12:56 PM

#

@stray matrix what's the rest of the code look like? TeleportStuckAction (the default one) is similar, and has no issue so must be somewhere else

stray matrix Jun 11, 2023, 12:56 PM

#

So the spawn location thing

#

Is this,

#

#

I'm using it to slightly vary the spawn location everytime the NPC gets stuck,

#

Since no NPE's are showing up, it seems like the location is not null

orchid orchid Jun 11, 2023, 12:57 PM

#

I mean the setTarget call

stray matrix Jun 11, 2023, 12:58 PM

#

I never set navigation,

#

It's invoked by BlockBreaker

#

#

I also modified some of the BlockBreaker methods so I could intercept them

#

#

Though this should not cause an issue

#

I added it so I could move the NPC closer

#

And I still use the Citizens method

orchid orchid Jun 11, 2023, 1:00 PM

#

what is moveTo

stray matrix Jun 11, 2023, 1:00 PM

#

#

Move to simply teleports, never invokes pathfinding

orchid orchid Jun 11, 2023, 1:01 PM

#

ok so it doesn't teleport?

stray matrix Jun 11, 2023, 1:01 PM

#

No,

#

It simply gets stuck in place and calls stuckAction 100 times (after which I despawn it)

orchid orchid Jun 11, 2023, 1:01 PM

#

what if you call the npc method

#

npc.teleport(location, TeleportCause.PLUGIN)

stray matrix Jun 11, 2023, 1:02 PM

#

Let me see

#

#

Still seems to call repeatedly

#

Weird thing is, isNavigating is returning false

orchid orchid Jun 11, 2023, 1:09 PM

#

does it teleport

stray matrix Jun 11, 2023, 1:09 PM

#

It now seems to have teleported

#

But I don't see why stuckAction would be called when navigator.isNavigating returns false

orchid orchid Jun 11, 2023, 1:10 PM

#

if it can't find a path that is also stuck

stray matrix Jun 11, 2023, 1:10 PM

#

But wouldn't isNavigating return true?

orchid orchid Jun 11, 2023, 1:11 PM

#

no, because it couldn't find a path

#

it immediately becomes stuck

low vesselBOT Jun 11, 2023, 1:12 PM

#

Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@stray matrix

#(masecla22) Issues with Citizens API