(Wahrheit) NBT checking without deprecation warnings | Denizen and Citizens | Page 1

sharp fern May 10, 2023, 1:49 PM

#

The NBT fixer script I worked on before now appears to be working great, although of course it results in script checker errors because the NBT tags are deprecated. Is there a reasonable way to write the script in such a way that it doesn't leave errors in my editor (and, ideally, is forward-compatible more or less indefinitely)?

Item_Tier_Fixer:
    type: task
    debug: false
    script:
    - foreach <player.inventory.map_slots> key:slot as:item:
        - foreach next if:<[item].has_flag[item_tier]>
        - if <[item].lore.filter[contains_text[Veteran]].is_truthy>:
            - inventory flag slot:<[slot]> item_tier:Veteran
        - else if <[value].lore.filter[contains_text[Elite]].is_truthy>:
            - inventory flag slot:<[slot]> item_tier:Elite
        - else if <[value].lore.filter[contains_text[Champion]].is_truthy>:
            - inventory flag slot:<[slot]> item_tier:Champion
    - foreach <player.inventory.map_slots.filter_tag[<[filter_value].nbt.exists>].filter_tag[<[filter_value].has_flag[nbt_converted].not>]> key:slot as:item:
        - foreach <[item].nbt.to_map> as:nbt:
            - inventory flag slot:<[slot]> <[key]>:<[nbt]>
        - inventory adjust slot:<[slot]> remove_nbt
        - inventory flag slot:<[slot]> nbt_converted

woeful timberBOT May 10, 2023, 1:49 PM

#

(Wahrheit) NBT checking without deprecation warnings

#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.
You can block this bot if you don't want to see these messages, I won't mind.
<@&525394568410038282>

woeful timberBOT May 10, 2023, 1:49 PM

#

sharp fern The NBT fixer script I worked on before now appears to be working great, althoug...

#

gleaming fractal May 10, 2023, 1:51 PM

#

Could probably use the new/modern NBT tags? will need a bit more manual parsing but will be a lot more future proof

#

!t raw_nbt

untold oysterBOT May 10, 2023, 1:52 PM

#

gleaming fractal !t raw_nbt

Cannot Specify Searched Tag

Multiple possible tags: <ItemTag.raw_nbt>, <ItemTag.all_raw_nbt>.

gleaming fractal May 10, 2023, 1:52 PM

#

These ^

sharp fern May 10, 2023, 1:53 PM

#

yeahhhhhh I figured raw_nbt might have to be the move but I don't love it, it seemingly adds way more complexity

#

lol shit I don't know if I have any copies of old nbt items

silent berry May 10, 2023, 2:10 PM

#

sharp fern The NBT fixer script I worked on before now appears to be working great, althoug...

i get typically get berated every time i suggest this, but i trust you could use this option responsibly, if at all:
#changelog message
you can remove the warning entirely with the ##ignorewarning comment at the top of the script - given youd be using it to fix outdated content from nbt to flags

gleaming fractal May 10, 2023, 2:10 PM

#

silent berry i get typically get berated every time i suggest this, but i trust you could use...

I assume he meant the in-game warnings?

silent berry May 10, 2023, 2:10 PM

#

otherwise, the raw_nbt is really the only reasonable option

sharp fern May 10, 2023, 2:10 PM

#

gleaming fractal I assume he meant the in-game warnings?

no I only care about the editor lol

silent berry May 10, 2023, 2:10 PM

#

gleaming fractal I assume he meant the in-game warnings?

isnt that only sent to ops?

#

oh

sharp fern May 10, 2023, 2:11 PM

#

I did not know that feature existed

gleaming fractal May 10, 2023, 2:11 PM

#

Ah

sharp fern May 10, 2023, 2:11 PM

#

@wicked vortex seeking secondary opinion, is this a reasonable case for using ignorewarning

silent berry May 10, 2023, 2:11 PM

#

i dont believe he's going to say yes because it falls under ignoring critical errors, he didnt like me mentioning it to xeane even lol

sharp fern May 10, 2023, 2:12 PM

#

realistically if we get to a point where the nbt stuff is removed and my players have nbt items I can probably fix them on a case by case basis or otherwise deal with the problem when it arises

#

technically it's a tag tracer error

#

the tag does exist the editor just doesn't recognize it because it got removed before we started doing deprecation warnings

silent berry May 10, 2023, 2:12 PM

#

OH

sharp fern May 10, 2023, 2:13 PM

#

if you use itemtag.nbt in game on an item with denizen nbt you will get a result

#

otherwise the script would not work

silent berry May 10, 2023, 2:13 PM

#

yeah, it's not removed, it's just deprecated - actually i redact my comment becuase that does make sense

#

you can disable the in-game warning (as aya was starting to get to), but the editor is something totally different; for the case of fixing deprecated scripts to be modern, that absolutely sounds appropriate

#

but we can wait on his response

sharp fern May 10, 2023, 2:14 PM

#

if monkey has a genius alternative, as he often does, I will be happy to use that

silent berry May 10, 2023, 2:15 PM

#

that'd be an interesting extension add-on, to reflect the same concept with deprecated tags like our config lets us do for in-game

gleaming fractal May 10, 2023, 2:15 PM

#

Reading it with the modern tags isn't that bad, something like /ex narrate <player.item_in_hand.all_raw_nbt.get[Denizen NBT].parse_value_tag[<[parse_value].after[string:]>]> gets you a map

sharp fern May 10, 2023, 2:15 PM

#

this code is literally only here to handle updating legacy items so it's not like I'm hard depending on shit that's been removed

gleaming fractal May 10, 2023, 2:15 PM

#

The old NBT system was before my time so not super familiar with it, but I think that should cover all cases of it

sharp fern May 10, 2023, 2:16 PM

#

I don't think I have any items left that have denizen nbt on them

#

and I forget how the format goes for putting in the mechanism on an item script

gleaming fractal May 10, 2023, 2:17 PM

#

I just adjusted it in-game, nbt:key/value|key2/value2

gleaming fractal May 10, 2023, 2:17 PM

#

sharp fern I don't think I have any items left that have denizen nbt on them

In that case, could maybe change it into just a warning using the modern NBT tag?

#

I.e. Your item has outdated data, please ask staff to update it or whatever?

sharp fern May 10, 2023, 2:19 PM

#

well but if we're writing code to check whether the item exists using modern nbt tags we might as well just replace the data

#

spinning up localhost to test an item script

silent berry May 10, 2023, 2:22 PM

#

!tag itemtag.nbt

untold oysterBOT May 10, 2023, 2:22 PM

#

silent berry !tag itemtag.nbt

Cannot Find Searched Tag

Unknown tag.

#

Possible Confusion

Did you mean to search for elementtag.not?

sharp fern May 10, 2023, 2:24 PM

#

gleaming fractal Reading it with the modern tags isn't _that bad_, something like `/ex narrate <p...

this actually appears to work great

#

Item_Tier_Fixer:
    type: task
    debug: false
    script:
    - foreach <player.inventory.map_slots> key:slot as:item:
        - foreach next if:<[item].has_flag[item_tier]>
        - if <[item].lore.filter[contains_text[Veteran]].is_truthy>:
            - inventory flag slot:<[slot]> item_tier:Veteran
        - else if <[value].lore.filter[contains_text[Elite]].is_truthy>:
            - inventory flag slot:<[slot]> item_tier:Elite
        - else if <[value].lore.filter[contains_text[Champion]].is_truthy>:
            - inventory flag slot:<[slot]> item_tier:Champion
    - foreach <player.inventory.map_slots.filter_tag[<[filter_value].all_raw_nbt.get[Denizen NBT].exists>].filter_tag[<[filter_value].has_flag[nbt_converted].not>]> key:slot as:item:
        - foreach <[item].all_raw_nbt.get[Denizen NBT].parse_value_tag[<[parse_value].after[string:]>]> as:nbt:
            - inventory flag slot:<[slot]> <[key]>:<[nbt]>
        - inventory adjust slot:<[slot]> remove_nbt
        - inventory flag slot:<[slot]> nbt_converted

#

the script of course becomes a fucking lolcow

silent berry May 10, 2023, 2:25 PM

#

so um, .nbt either isnt documented anymore because it was before we left deprecated tags with deprecation notices, like uh

sharp fern May 10, 2023, 2:25 PM

#

silent berry so um, .nbt either isnt documented anymore because it was before we left depreca...

correct

silent berry May 10, 2023, 2:25 PM

#

like these

sharp fern May 10, 2023, 2:25 PM

#

dumb_test_item:
    type: item
    material: diamond_sword
    mechanisms:
        nbt: key_1/value_1```

#

/ex narrate <player.item_in_hand.nbt>

#

it works lol

silent berry May 10, 2023, 2:26 PM

#

nbt uses the old key/value map format right?

gleaming fractal May 10, 2023, 2:26 PM

#

filter_tag[<[filter_value].all_raw_nbt.get[Denizen NBT].exists>] can be filter[all_raw_nbt.contains[Denizen NBT]]

silent berry May 10, 2023, 2:26 PM

#

ah, yeah

#

!tag all_raw_nbt

untold oysterBOT May 10, 2023, 2:26 PM

#

silent berry !tag all_raw_nbt

Tag: <ItemTag.all_raw_nbt>

Returns a map of all raw NBT on this item, including default values.
Refer to format details at !language Raw NBT Encoding.

Group

properties

Returns

MapTag

Mechanism

ItemTag.raw_nbt

silent berry May 10, 2023, 2:26 PM

#

!lang raw nbt encoding

untold oysterBOT May 10, 2023, 2:26 PM

#

silent berry !lang raw nbt encoding

Language: Raw NBT Encoding

The item Raw_NBT property encodes and decodes raw NBT data.
For the sake of inter-compatibility, a special standard format is used to preserve data types.
This system exists in Denizen primarily for the sake of compatibility with external plugins.
It should not be used in any scripts that don't rely on data from external plugins.

NBT Tags are encoded as follows:
CompoundTag: (a fully formed MapTag)
ListTag: list:(NBT type-code):(a fully formed ListTag)
ByteArrayTag: byte_array:(a pipe-separated list of numbers)
IntArrayTag: int_array:(a pipe-separated list of numbers)
ByteTag: byte:(#)
ShortTag: short:(#)
IntTag: int:(#)
LongTag: long:(#)
FloatTag: float:(#)
DoubleTag: double:(#)
StringTag: string:(text here)
EndTag: end

Group

Useful Lists

silent berry May 10, 2023, 2:26 PM

#

ow

sharp fern May 10, 2023, 2:27 PM

#

gleaming fractal `filter_tag[<[filter_value].all_raw_nbt.get[Denizen NBT].exists>]` can be `filte...

I do not think it can

#

.filter does not exist for maptags

silent berry May 10, 2023, 2:27 PM

#

!tag maptag.filt

untold oysterBOT May 10, 2023, 2:27 PM

#

silent berry !tag maptag.filt

Tag: <MapTag.filter_tag[<parseable-boolean>]>

Returns a copy of the map with all its contents parsed through the given input tag and only including ones that returned 'true'.
This requires a fully formed tag as input, making use of the 'filter_key' and 'filter_value' definition.

Returns

MapTag

Examples

# Narrates a map of '[c=3;d=4;e=5]'
- narrate <map[a=1;b=2;c=3;d=4;e=5].filter_tag[<[filter_value].is[or_more].than[3]>]>

silent berry May 10, 2023, 2:27 PM

#

only for the values, but not keys

#

er, i guess kind of the keys

gleaming fractal May 10, 2023, 2:27 PM

#

Oh yeah, my bad

sharp fern May 10, 2023, 2:28 PM

#

this will work fine

#

I still want to wait to see if monkey has a mad genius idea that is more efficient

gleaming fractal May 10, 2023, 2:30 PM

#

sharp fern ```yaml Item_Tier_Fixer: type: task debug: false script: - forea...

Since you read it in the loop anyway could probably move the filter to the loop which would make it a bit cleaner, but other then that yeah

sharp fern May 10, 2023, 2:31 PM

#

I think it's technically more efficient to do it in the initial check

#

I don't anticipate it being a problem either way

silent berry May 10, 2023, 2:32 PM

#

you're probably going to hate this alternative but

#

!tag listtag.to_map

untold oysterBOT May 10, 2023, 2:32 PM

#

silent berry !tag listtag.to_map

Tag: <ListTag.to_map[(<separator>)]>

Interprets a list of "key/value" pairs as a map, and returns the resulting MapTag.
Optionally specify the map separator symbol, by default '/'.
Inverted by !tag MapTag.to_list

Returns

MapTag

gleaming fractal May 10, 2023, 2:32 PM

#

I mean, that's a level of efficiency that doesn't really matter, but either way might not be because this way it has to convert the item's NBT to Denizen format twice

sharp fern May 10, 2023, 2:33 PM

#

oh that's true

#

so I could just chop the second .filter_tag entirely right

gleaming fractal May 10, 2023, 2:34 PM

#

Yeah I'd say move the has-Denizen-NBT filtering into the loop entirely

sharp fern May 10, 2023, 2:36 PM

#

well actually

#

not every item is going to have this nbt converted tag

#

flag

#

we need to know that the item has denizen nbt to know whether to fuck with it

#

unless I'm missing something it has to work like this

gleaming fractal May 10, 2023, 2:37 PM

#

Also unrelated, but a tag inspired by your last post about this was added - the lore checks can now use contains_match

#

<player.inventory.map_slots.filter_tag[<[filter_value].all_raw_nbt.get[Denizen NBT].exists>].filter_tag[<[filter_value].has_flag[nbt_converted].not>]>
It's already <player.inventory.map_slots.filter[has Denizen NBT].filter[Doesn't have NBT converted flag]>, I.e. the flag check is already ran for every item, isn't it?

#

The only difference would be the order of the checks

sharp fern May 10, 2023, 2:40 PM

#

gleaming fractal Also unrelated, but a tag inspired by your last post about this was added - the ...

look at me being useful

#

!t contains_match

untold oysterBOT May 10, 2023, 2:41 PM

#

sharp fern !t contains_match

Tag: <ListTag.contains_match[<matcher>]>

Returns whether the list contains an object that matches the specified matcher,
using the system behind !language Advanced Object Matching.

Returns

ElementTag(Boolean)

gleaming fractal May 10, 2023, 2:42 PM

#

Also might be missing something, but why is that flag needed? you remove all of the Denizen NBT from the item after converting it to flags, so just a check for the item having Denizen NBT should be enough?

sharp fern May 10, 2023, 2:42 PM

#

I am notorious for over-futureproofing

#

I think you might be right though

#

I think I added it when I wasn't sure whether the remove nbt thing was still present

#

Item_Tier_Fixer:
    type: task
    debug: false
    script:
    - foreach <player.inventory.map_slots> key:slot as:item:
        - foreach next if:<[item].has_flag[item_tier]>
        - if <[item].lore.contains_match[Veteran].is_truthy>:
            - inventory flag slot:<[slot]> item_tier:Veteran
        - else if <[value].lore.contains_match[Elite].is_truthy>:
            - inventory flag slot:<[slot]> item_tier:Elite
        - else if <[value].lore.contains_match[Champion].is_truthy>:
            - inventory flag slot:<[slot]> item_tier:Champion
    - foreach <player.inventory.map_slots.filter_tag[<[filter_value].all_raw_nbt.get[Denizen NBT].exists>]> key:slot as:item:
        - foreach <[item].all_raw_nbt.get[Denizen NBT].parse_value_tag[<[parse_value].after[string:]>]> as:nbt:
            - inventory flag slot:<[slot]> <[key]>:<[nbt]>
        - inventory adjust slot:<[slot]> remove_nbt

#

I can probably condense this again now

#

right?

#

the recursion always breaks my brain

wicked vortex May 10, 2023, 2:45 PM

#

The most efficient and most long-term sustainable option is to do it inefficiently, once, and then delete the script

sharp fern May 10, 2023, 2:46 PM

#

ha!

wicked vortex May 10, 2023, 2:46 PM

#

might not be an option if your world file is so big that scanning chests takes more than a day

sharp fern May 10, 2023, 2:46 PM

#

unfortunately that would require loading every chest that has ever existed

#

yeah

wicked vortex May 10, 2023, 2:46 PM

#

would be a pretty big world

sharp fern May 10, 2023, 2:46 PM

#

my server tar is 27gb every time I back it up

#

so!

wicked vortex May 10, 2023, 2:46 PM

#

ow

#

how

sharp fern May 10, 2023, 2:46 PM

#

that's across several worlds mind you

#

lotsa big maps

#

actually maybe I do need the nested foreaches

#

currently I only run this task on player join so it's not a huge deal

gleaming fractal May 10, 2023, 2:48 PM

#

I'd probably still do that check in the foreach, even if just for the sake of cleaner code

sharp fern May 10, 2023, 2:58 PM

#

I think I prefer it this way for my own understanding

gleaming fractal May 10, 2023, 2:59 PM

#

gleaming fractal I'd probably still do that check in the foreach, even if just for the sake of cl...

(And the double-reading thing still applies, ofc)

#

But yeah whatever way you prefer ofc

sacred quiverBOT May 10, 2023, 3:20 PM

#

Resolved

Thread closed as resolved.

gleaming fractal May 10, 2023, 3:51 PM

#

sharp fern ```yaml Item_Tier_Fixer: type: task debug: false script: - forea...

Forgot to say earlier, but I think you'd need * in that contains_match

sacred quiverBOT May 10, 2023, 3:52 PM

#

Thread Reopened

Thread was manually reopened by @gleaming fractal.

gleaming fractal May 10, 2023, 3:52 PM

#

And the is_truthy shouldn't be needed anymore I think? as it's already a boolean

sharp fern May 10, 2023, 3:53 PM

#

ah shit you're right lol

gleaming fractal May 10, 2023, 3:53 PM

#

Oh wait that's a fallback for the item not having lore, isn't it?

sharp fern May 10, 2023, 3:54 PM

#

no it's a fallback for the item not having a flag

#

you're right

#

fixed

#

Item_Tier_Fixer_Join:
    type: world
    debug: false
    events:
        after player joins:
        - inject Item_Tier_Fixer

Item_Tier_Fixer:
    type: task
    debug: false
    script:
    - foreach <player.inventory.map_slots> key:slot as:item:
        - foreach next if:<[item].has_flag[item_tier]>
        - if <[item].lore.contains_match[*Veteran*]>:
            - inventory flag slot:<[slot]> item_tier:Veteran
        - else if <[value].lore.contains_match[*Elite*]>:
            - inventory flag slot:<[slot]> item_tier:Elite
        - else if <[value].lore.contains_match[*Champion*]>:
            - inventory flag slot:<[slot]> item_tier:Champion
    - foreach <player.inventory.map_slots.filter_tag[<[filter_value].all_raw_nbt.get[Denizen NBT].exists>]> key:slot as:item:
        - foreach <[item].all_raw_nbt.get[Denizen NBT].parse_value_tag[<[parse_value].after[string:]>]> as:nbt:
            - inventory flag slot:<[slot]> <[key]>:<[nbt]>
        - inventory adjust slot:<[slot]> remove_nbt

gleaming fractal May 10, 2023, 3:55 PM

#

.get[Denizen NBT].exists can use contains

sharp fern May 10, 2023, 3:56 PM

#

true

gleaming fractal May 10, 2023, 3:56 PM

#

Also I'd probably move the .parse_value_tag[<[parse_value].after[string:]>] into a <[nbt].after[string:]> in the loop as that's cleaner/more readable imo, but that's mostly personal preference

sharp fern May 10, 2023, 3:58 PM

#

meh

#

this is not code that is getting repeated anywhere

#

an extra def seems useless

gleaming fractal May 10, 2023, 3:59 PM

#

You already have a def from the loop, I meant just - inventory flag slot:<[slot]> <[key]>:<[nbt].after[string:]> which makes it a bit easier to understand what's going on (imo) & makes the loop shorter

#

But either way yeah that looks good, mainly wanted to point out the matcher thing

sharp fern May 10, 2023, 4:01 PM

#

ty

#(Wahrheit) NBT checking without deprecation warnings