#(Ayano) Citizens shop Reset after some time

1 messages · Page 1 of 1 (latest)

ashen wind
#

The Citizens NPC Shops (10 on the server) keep resetting after some time, They are filled with various things (e.g. Mob Loot, Ores, Player Heads, Potions) and after some server restarts The Npc Shops just automatically Delete themselves. Help is Appreciated

fickle moonBOT
#

(Ayano) Citizens shop Reset after some time

fickle moonBOT
#

Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.
You can block this bot if you don't want to see these messages, I won't mind.
<@&525394568410038282>

olive glacier
fossil prawnBOT
# olive glacier !logs
Info: logs

Please post your full latest log file.

Background Info: One of the most helpful tools to identifying the source of a problem is your server logs file! Logs contain all sorts of important information like server and plugin versions, any error messages, and a lot more important information (More Info).

How To: Your log can be found in the logs folder within your server folder. The most recent log is a text file labeled latest.log. To get help using these logs, please open that file in a text editor and copy all of the text, then open https://paste.denizenscript.com/New/Log and paste the text into the box on the page. Then click "Submit" and copy the URL and paste that back into this channel.

Please do not upload the file to Discord or to other pastebin services, use the log pastebin linked above.

ashen wind
#

Its always in like intervals they work perfect for 1 week and then randomly They empty their shops
(possible problem could be that we are using items from other plugins and putting them into the shops, maybe that confuses the plugin because its not a base minecraft item)

barren cedar
#

Is there any error

barren cedar
ashen wind
#

This is the latest log

ashen wind
barren cedar
#

If you save with citizens save?

ashen wind
#

What exactly is a citizens save ?

grand nexus
ashen wind
#

thanks looking it up

jolly swallow
#

don't think this is the right answer contextually

#

fullwall was referring to /citizens save

ashen wind
#

Whats the difference between a filezilla save and a citizens save ?

grand nexus
barren cedar
#

I just want to know if there’s an error when you use /citizens save which results in shops.yml being empty

#

E.g after you put a custom item in the shop

ashen wind
#

oh i was waiting till the shops cleared again

#

gonna do that tomorrow

ashen wind
#

Shops cleared again.
Created a new npc and filled his shop, used /citizens save

#

2 days since he is up and his shop didnt clear

barren cedar
#

@ashen wind so is it a specific item that causes it?

ashen wind
#

i dont think so

#

because we set up multiple shops
and shops with player heads always corrupted first
but after that every shop slowly cleared itself

#

we tried not using player heads and reinstalling the plugin

#

but once we use more than one shop
the npcs just clear the shops

barren cedar
#

More than one shop… hm

#

So there’s no errors in log

#

I’ll investigate that today

barren cedar
#

still unable to replicate

grand nexus
#

@ashen wind can you please elaborate a step-by-step method of replicating this issue? an MCVE if you will:

#

!mcve

fossil prawnBOT
# grand nexus !mcve
Info: mcve

Please create a Minimal, Complete, and Verifiable Example of the problem you're reporting.
Minimal: contains nothing other than the part that's broken (and bare minimum structure).
Complete: contains everything needed to demonstrate the issue.
Verifiable: Anybody should be able to throw it on their own server and see the problem happen for themselves, without any needed tinkering.

ashen wind
#

Will do. but please keep in mind, The shops reset randomly
sometimes it took us 2 days
sometimes 2 weeks
sometimes mere minutes

ashen wind
#
  1. Create a NPC
  2. Select and Edit the Shop
  3. /Citizens Save
  4. Server Restart
  5. Empty Shop
covert pawn
fossil prawnBOT
# covert pawn !checklog https://paste.denizenscript.com/View/105805
Log Check Results
Server Version

Paper version git-Paper-279 (MC: 1.19.2)-- (:warning: Outdated build, behind by 107... Current build is 386)

Plugin Version(s)

Citizens v2.0.30-SNAPSHOT (build 2793) -- (:warning:Outdated build, behind by 108)

Checked For

@covert pawn

UUID Version

4 (:white_check_mark: Online)

Java Version

17 or newer (based on stack trace content) :white_check_mark:

Other Noteworthy Plugin(s)

WorldGuard v7.0.8-beta-01+cbb2ba7, MythicMobs v5.2.1-fd1d0777, ProtocolLib v5.0.0-SNAPSHOT-b607

Possibly Relevant Plugin(s)

TAB v3.1.5 - This plugin adds Below_Name scoreboards to NPCs.
ViaVersion v4.5.1 - Mixed client vs server versions can sometimes cause packet-related issues.
ModelEngine vR3.1.3 - ModelEngine has Citizens support, but that support is known to be buggy. Issues related to NPCs that use ModelEngine should be reported to ModelEngine support, not Citizens.

Potentially Bad Line(s)

[21:50:27] [Craft Scheduler Thread - 11 - DecentHolograms/WARN]: Caused by: while scanning a simple key :warning: Log contains error messages.

covert pawn
#

@ashen wind You're 100~ builds behind, should update and see if you still encounter this issue

#

!update Citizens

fossil prawnBOT
covert pawn
#

Also test on paper 1.19.3

#

You'll have to update eitherway

#

!update paper

fossil prawnBOT
# covert pawn !update paper
Update Paper

Paper is a higher-performance alternative to Spigot that is 100% compatible with the equivalent Spigot version. It's much easier to update than Spigot itself, and carries a lot of performance and quality-of-life benefits.

Latest Paper builds are at https://papermc.io/downloads.

(If you would prefer to use a Spigot build, refer to !update spigot).

ashen wind
#

Well thanks will do.

ashen wind
#

!log

fossil prawnBOT
# ashen wind !log
Info: log

Please post your full latest log file.

Background Info: One of the most helpful tools to identifying the source of a problem is your server logs file! Logs contain all sorts of important information like server and plugin versions, any error messages, and a lot more important information (More Info).

How To: Your log can be found in the logs folder within your server folder. The most recent log is a text file labeled latest.log. To get help using these logs, please open that file in a text editor and copy all of the text, then open https://paste.denizenscript.com/New/Log and paste the text into the box on the page. Then click "Submit" and copy the URL and paste that back into this channel.

Please do not upload the file to Discord or to other pastebin services, use the log pastebin linked above.

ashen wind
jolly swallow
fossil prawnBOT
# jolly swallow !logcheck https://paste.denizenscript.com/View/105981
Log Check Results
Server Version

Paper version git-Paper-386 (MC: 1.19.3)-- (Current build :white_check_mark:)

Plugin Version(s)

Citizens v2.0.30-SNAPSHOT (build 2901) -- (Current build :white_check_mark:)

Checked For

@jolly swallow

UUID Version

4 (:white_check_mark: Online)

Java Version

17 or newer (based on stack trace content) :white_check_mark:

Other Noteworthy Plugin(s)

MythicMobs v5.2.1-fd1d0777, ProtocolLib v5.0.0-SNAPSHOT-b607

Possibly Relevant Plugin(s)

TAB v3.2.4 - This plugin adds Below_Name scoreboards to NPCs.
ViaVersion v4.5.1 - Mixed client vs server versions can sometimes cause packet-related issues.
ModelEngine vR3.1.4 - ModelEngine has Citizens support, but that support is known to be buggy. Issues related to NPCs that use ModelEngine should be reported to ModelEngine support, not Citizens.

Potentially Bad Line(s)

Caused by: java.util.zip.ZipException: zip END header not found :warning: Log contains error messages.

ashen wind
#

The shops still reset after a restart

barren cedar
#

so I followed the steps in your video exactly but I could not replicate the error

#

perhaps you could include the stopping part of your server log?

ashen wind
#

Sorry, where do i find the stopping part in my server log ?

covert pawn
ashen wind
#

Ah okay, thanks

#

The reproduce the bug i have to restart the server

#

should i stop the server send you the first log
then join on the server (probably) see the bug
and then stop the server and send you the second log ?

#

!log

fossil prawnBOT
# ashen wind !log
Info: log

Please post your full latest log file.

Background Info: One of the most helpful tools to identifying the source of a problem is your server logs file! Logs contain all sorts of important information like server and plugin versions, any error messages, and a lot more important information (More Info).

How To: Your log can be found in the logs folder within your server folder. The most recent log is a text file labeled latest.log. To get help using these logs, please open that file in a text editor and copy all of the text, then open https://paste.denizenscript.com/New/Log and paste the text into the box on the page. Then click "Submit" and copy the URL and paste that back into this channel.

Please do not upload the file to Discord or to other pastebin services, use the log pastebin linked above.

ashen wind
#
  • Shops have been created
#
  • Shops are empty after restart (stop/start)
barren cedar
#

hmm, can anyone else reproduce this? I still can't.

#

not sure if it's related to a plugin conflict or error or something

ashen wind
#

If it helps I can send the config.yml

#

Because there is a limit for NPC I remember
And might have a conflict with that

young prism
#

Looking through this channel here to find a solution, I don't think it's something due to the plugin itself upon researching a bit and looking into configs/whatnot.

grand nexus
#

it would help if we could establish a step-by-step guide on how to replicate it exactly, but it's vague as to when it resets

#

what happens inbetween that time?

young prism
#

Ok, so, I JUST restart my server and here's how it goes:

1.) Create NPC Shop
2.) Populate shop
3.) Save citizens
4.) Restart server
5.) NPC shop isn't populated, BUT, the NPC still has the shop trait + its requisite values (open shop on right click, 'players buy items' etc) but no items

barren cedar
#

Which plugins are you using?

young prism
barren cedar
#

Do you think it’d be possible to cut down plugins?

#

I do wonder if it’s vault/essentialsx related

ashen wind
#

Even if we don’t use balance/economy as currency for the shops and as an example use iron ingots the shops still reset
So prolly not vault but could be essentialsX

young prism
ashen wind
#

@young prism do your logs maybe provide more information on that topic?

limber shore
#

I have this problem too, if it can help find a solution ask me anything

covert pawn
#

@ashen wind @young prism @limber shore
What's your host?

covert pawn
limber shore
covert pawn
#

@limber shore could you provide logs, trying to replicate that problem

#

!pastelog

fossil prawnBOT
limber shore
#

I think in a few hours

covert pawn
#

cool

young prism
covert pawn
fossil prawnBOT
# covert pawn !checklog https://paste.denizenscript.com/View/106156
Log Check Results
Server Version

Paper version git-Paper-388 (MC: 1.19.3)-- (Outdated build, behind by 5... Current build is 393)

Plugin Version(s)

Citizens v2.0.30-SNAPSHOT (build 2875) -- (:warning:Outdated build, behind by 38)
Denizen v1.2.5-SNAPSHOT (build 1775-REL) -- (:warning:Outdated build, behind by 8)

Checked For

@covert pawn

Java Version

17.0.5 :white_check_mark:

Other Noteworthy Plugin(s)

WorldGuard v7.0.7+216b061, ProtocolLib v5.0.0-SNAPSHOT-b602, Quests v3.13.2-d709ab4

Problematic Plugin(s)

Geyser-Spigot v2.1.0-SNAPSHOT - Bedrock clients are unsupportable. Please do all testing with a Java Edition client.
floodgate v2.2.0-SNAPSHOT (b74-4f36112)

Possibly Relevant Plugin(s)

TAB v3.2.1 - This plugin adds Below_Name scoreboards to NPCs.
GriefDefender v2.3.2 - GriefDefender v2.2.2 has been seen to mistake NPCs for players in some cases, and may interfere with NPC teleporting.

Potentially Bad Line(s)

Caused by: java.lang.ClassNotFoundException: org.bukkit.craftbukkit.v1_19_R1.inventory.CraftItemStack :warning: Log contains error messages.

covert pawn
#

@young prism your denizen is heavily outdated , but you're also using essentials as economy?

young prism
#

No, I'm using vault.

#

I'll update denizens asap

covert pawn
#

(Vault is the link between plugins and the economy)

#

[16:00:40] [Server thread/INFO]: [Vault] [Economy] Essentials Economy found: Waiting

#

essentials provides the money

young prism
#

Oh, right, yes, is that a problem?

covert pawn
#

no, just a question

young prism
#

Gotcha

#

I thought it was for a moment

ashen wind
covert pawn
#

!pasteconfig

fossil prawnBOT
ashen wind
#

Shops is empty due to the reset/clear

#

to double check thats the config

limber shore
#

Ok here i am sorry to be late. I updated citizens since i still had an old version and tried to do a test shop for the logs but now, when i restarted the server, the shop was still there and it wasn't emptied. I think i will wait a little before saying that this is resolved since sometimes it takes more time but i'll let you know that maybe updating has worked for me

ashen wind
limber shore
# ashen wind What plugins are you using?

Hey, sorry for the late response again but in my timezone it was night.
I’m using a lot of plugins since I play with my friends in a big server and I don’t have my pc on now so I can’t tell you all of them. Btw I’m going to play in about 1 hour so when I turn on again i’ll tell you I’d the problem is still there or if I fixed

limber shore
#

I tried again now and my shops aren't resetting anymore (as for now).
@ashen wind i've seen someone was talking about essentials might be the problem, i am using it in my world so i don't think it is the problem

ashen wind
#

Thanks

limber shore
ashen wind
#

So,
Any fixes?

barren cedar
#

Still don’t have replication steps

#

Maybe I can add a build with debug for you tomorrow

barren cedar
#

@ashen wind can you update to the new build and enable citizens debug and send the output please

ashen wind
#

will do

#

thanks

limber shore
#

For now, my shops aren't resetting anymore, if it will happen again i am gonna try to replicate it

indigo driftBOT
#
Thread Closing Reminder

Has your issue been resolved, or your question been answered?
If so, please use the </resolved:1028673926114594866> command to close your thread.
Or </invalid:1028673926898909185> if it's not possible to resolve.

If not yet resolved, please reply below to tell us what you still need.

(Note that if there is no reply for a few days, this thread will eventually close itself.)

#

@ashen wind

indigo driftBOT
#
Resolved

Thread closed as resolved.

barren cedar
#

@ashen wind is it resolved or not?

ashen wind
#

yes it is

#

idk what actually fixed it
but latest build seems like it fixed it

barren cedar
#

ok thanks