Hey there! When making a citizens shop, I've found that NPCs are able to sell items with NBT data to players, but if a player tries to sell an item with NBT data to an NPC, it doesn't check the NBT data, and it will take any item of the same type, as far as I can tell anyway. Is this something that I can fix, or a feature planned for the future? Especially difficult since if I use ItemJoin to give permanent items to a player's inventory, if any NPC sells items of the same type they can sell these permanent items off. Thanks in advance!
#(Sophie) Citizens Shop NBT Sell Check
lunar zephyr
near jackalBOT
(Sophie) Citizens Shop NBT Sell Check
near jackalBOT
Hey there! When making a citizens shop, I've found that NPCs are able to sell it...
Hi I'm AutoThreadBot! Don't mind me, I'll just be adding the helper team to this thread so they can see it. A human will get to you soon.
You can block this bot if you don't want to see these messages, I won't mind.
<@&525394568410038282>
elder drum
yes, there's a setting in the new build
lunar zephyr
ah, awesome! what is it?
elder drum
oh actually that's something different
lunar zephyr
ah dang! no worries
round sluiceBOT
elder drum
do you think it would need to be specific NBT that needs to match / not match or just a blanket has NBT / doesn't have NBT toggle
lunar zephyr
Definitely gonna need to match, for example I've got a bunch of custom items and they all use the Heart of the Sea as the base with custom model data added to make them all look different
Under the current system they'd all be considered the same item
I appreciate the help a ton btw, yall have been awesome
elder drum
what about specifying only a single NBT that matches as opposed to everything matching
lunar zephyr
Might break compatibility with items from certain plugins like MythicCrucible or CustomCrafting, since those use multiple NBT tags to apply their data
Not to mention depending on how the NBT check works, it could just verify something like the name which would open the door for exploits from players with anvils
elder drum
what I mean is sometimes the items will differ only in one or two NBT attributes but you might want them to match anyway
like ignoring name matching but matching some custom NBT
lunar zephyr
That's a good point, yeah
I think that should work in that case
I think the most widespread appeal to this would probably be MythicCrucible item compatibility and ItemJoin items that get used as GUI elements, the latter which wouldnt change much between items but the former could be modified by the player in a number of ways
Not to say it needs to check for those plugins in particular, but I think whichever solution you choose would do best to keep those NBT additions in mind. I'm not sure what it looks like under the hood so i'm not sure what that would look like
elder drum
I've added a basic way to do this
lunar zephyr
Awesome! Thanks!