Updating my resource pack from 1.21.1 to 1.21.8

[solid bison]

Hey, I decided to finally update my rp. But ran into a few issues when trying to see my models. I use a damage property .json to view my models on a diamond pickacxe but I've seen mixed stuff on this format being removed in 1.21.4 and that I need to use a new items folder within the rp too now? I am a little confused on what I actualy need to do in order to update the pack.

[golden steeple]

Welcome to the help forum!

Please make sure to read #1029373817119838218 as it may answer your question!

Once your question has been resolved, please mark the post as closed by using the </close:1163944441741049897> command.

[frozen kettle]

Oh wow, damage predicates are really old school (most people swapped to custom_model_data back when 1.14 came out).

Would you still wanna use damage predicates?
Do you wanna swap to custom_model_data?
Or would you wanna swap to the item_model component?
Or a mix of those?

Personally I'd suggest item_model, but the decision is up to you ofc.

[solid bison]

Yea I did mess up starting with damage properties, I'm willing to switch but I need the models placed around my world to stay as the model with a new format (if thats even possible)

I like the simplicity of typing in a number connected to a model than a name typed out if theres a system like that

My biggest worries about updating to a new format is that I rather not spend a few hours retyping every model into something else unless there happens to be a quick generator or something, if I dont have to retype but replacing every model is the cost I would be willing to do it

[frozen kettle]

Well, in that case you'd need to stay with damage checks

And I know there is a converter but idk if that works for anything but custom_model_data predicates.

[solid bison]

Is there a way to do the damage properties in 1.21.8?

[frozen kettle]

Yes, but I don't seem to be able to find a converter for it specifically.
But manually it's doable, yeah

[solid bison]

would manually require typing out every model lol

One thing online mentioned that but idk if it was referring to damage

like every model in models/items gets another .json in minecraft/items

[frozen kettle]

well, if you use damage predicates it would be one diamond_sword.json file with all the damage checks

if you use item_model then you'd have one .json per model

-# in the minecraft/items folder

[solid bison]

so all i have to do is copy the diamond_pickaxe.json into minecraft/items?

[frozen kettle]

not quite

You still have to rewrite everything to the new system.
You can use this generator to make it a bit easier: https://misode.github.io/assets/item/?share=WCbz6ZiSyD
-# made a small example that shows how to assign models for 1 and 2 damage

threshold = damage

oh, forgot to put "Normalize" to false

set "Normalize" to true if you want values from 0.0 to 1.0

set it to false to have values from 0 to 1561 (or however many durability values a diamond sword has)

_ _
Going forward I'd suggest you use item_model for new models though, cause all that would be would be:

• a .json model in minecraft/item that looks like this:

example.json

{
  "model": {
    "type": "model",
    "model": "item/feather"
  }
}```
and ingame you can then give any item that model via `/give @s stick[item_model=example]`
-# if you use a custom namespace it you would use `namespace:example` as value in the give command)

[solid bison]

so either way I would have to type every model data somehow in someway

I'm heavly debating switching to the item_model but I have alot of animated models and armor stands that would have to be remade so I might be stuck with the minecraft/items stuff

But for any new model I can use the item_model system right? I can run both at the same time?

[frozen kettle]

yeah
the item_model component basically tells the item "use this item definition file instead (item definition file = the files in the "items" folder)

for the old predicates (damage, custom_model_data etc.) you overwrite the default item's definition file, for the item_model component you write a new item definition file.

You could have damage predicates etc. in that new item definition file too. So you could have custom swords that change the model when they get damaged enough etc.

[solid bison]

thank you this has been very helpful, one more question tho, before I get too far and have to redo alot. On the converter I put the damage in the threshold, but do I also have to type the name of the model anywhere? does that go in the model type box? I assume so but I don't wanna mess anything up

[frozen kettle]

it goes where I put a and b as placeholders for now

[solid bison]

okay thank you, Ill probably keep this open overnight incase I run into any other issues but I think I got it from here thank you

[frozen kettle]

ofc those would be proper model paths, not just the model name (so like item/custom/whatever, not just whatever)

[solid bison]

I got all my old damage models to start working again. I'm trying to work out the item_models now. Would the .json in the items folder be called the item I want it on or the model name? and in your example does the model name go in the /feather?

[frozen kettle]

Whatever you name your item definition file will be what you reference in the command ingame later.
The model path in the item definition file points to your custom model the same way you did it for the ones with the damage checks.

[solid bison]

so is this correct?

[frozen kettle]

if your model is assets/minecraft/models/item/model1example.json and you reference model1example in the command later, then yes.

-# The item defintion file and the model do not necessarily need to be the same name.

[solid bison]

Once I input the command with the name and everything the model doesn't output onto the item

[frozen kettle]

is it just an error cube? or does nothing change?

[solid bison]

yea error cube

[frozen kettle]

And model1example.json exists in models/item?

[solid bison]

yup

[frozen kettle]

and this is in minecraft/items ?

oh, you forgot a comma

actually, I did

and you copied it

[solid bison]

oh lol.

[frozen kettle]

comma at the end of the "type" line

[solid bison]

yup that fixed it, thank you so much for all this