Trouble with custom models for potions in 1.21.4

[stuck bronze]

Hi! I've been trying to update my texture pack for 1.21.4 and have had a little bit of success with using ZenithKnight's custom model data converter to work. The trouble is it doesn't work for potions, and I have broken textures/models for the potions.

I've tried plugging what I have into https://misode.github.io/assets/item/ but the potion textures are still broken.

Would anyone be able to take a look and see what I might be doing wrong?

Thanks!

[sage light]

Welcome to the help forum!

Please make sure to read #1029373817119838218 as it may answer your question!

Once your question has been resolved, please mark the post as closed by using the </close:1163944441741049897> command.

[uneven knoll]

Are all potions broken? (no matter the custom_model_data)
Also, it should be item/potion instead of block/poton for the fallback

---

also, where in your pack did you put that potion.json you sent?

[stuck bronze]

Okay I think I'm making progress, Regular potions were broken until I changed to item/potion. So that's fixed now.

potion.json is in assets > items

[uneven knoll]

hmm, and all your custom potion models are in assets/minecraft/models/item 🤔 ?

(the boba.json etc.)

[stuck bronze]

no, those are in assets > minecraft > models > item

oh i mean yes

sorry!

wait you're right they are missing

oof

[uneven knoll]

on another note, "BBQ Crown" will not work with that name (in a vanilla resource pack, files and folders cannot contain capital letters nor spaces)

[stuck bronze]

This is good to know, I was wondering why I was getting this

[uneven knoll]

but yeah, if the potion models are somewhere else you either move them to models/item or adjust the model path in the potion.json to fix it

[stuck bronze]

they were previously saved in models > item > custom from my old pack which was different from everything else. I guess they can all just go into the same place now?

[uneven knoll]

As I said, you either move the models or adjust the model path in the potion.json
Either method is equally valid and you can decide which one you like better

[stuck bronze]

all fixed thanks!!