#NeoForge extensions to the ManagementApi

43 messages · Page 1 of 1 (latest)

gloomy zinc
#

@rough plover, you want schemas to be registered in an event but it is really not easy. People need the reference to the SchemaComponent at registration time for the rpc methods but the static register method currently also contains creating the SchemaComponent containing the id and the schema which makes moving the register method into the event impossible without requiring another static helper to create an unregistered SchemaComponent.

rough plover
#

you can do new SchemaComponent(...)?...

#

you can even add a second constructor with the ref url being ReferenceUtil.createLocalReference(name) to make it easier

#

I'm not sure what the problem is

gloomy zinc
#

because we need a way to force people to use ResourceLocations or else it could lead to conflicts

rough plover
#

that is... not related to having or not having an event

gloomy zinc
#

also the "registry" for SchemaComponent is a list and there are no concurrent implementations of List

rough plover
#

deprecate the primary constructor, add another one with a RL instead of a strings and that's all you can do. if you add a static register method you don't force people any more than you do by doing that

gloomy zinc
#

How do I deprecate just the primary constructor of a record without deprecating the record?

rough plover
# 
record R(...) {
  @Deprecated
  public R {

  }
}
sleek ridge
gloomy zinc
#

no json schema

sleek ridge
gloomy zinc
#

@rough plover review pls

spice aspenBOT
spice aspenBOT
gloomy zinc
#

@rough plover it's that time again

nova egret
#

it's the most wonderful time of the year _music_note

gloomy zinc
#

@rough plover stabolb

nova egret
#

@rough plover stabolb stabolb

rough plover
#

@rough plover stabolb stabolb stabolb

austere mica
astral sundial
#

It is way to early for christmas

vagrant vector
#

Youuuhoououuouuuuu- 're right

gloomy zinc
gloomy zinc
#

@rough plover finally got arround to doing the stuff you requested

orchid arch
hazy mango
#

Christmas is now

gloomy zinc
austere mica
astral sundial
karmic oxide
#

people can we atleast let halloween happen first

gloomy zinc
#

gotta give mariah some time to defrost

winged hollow
gloomy zinc
austere mica
upbeat sentinel
#

All I want for Christmas is yoghurt

sleek ridge
gloomy zinc
#

@rough plover stabolb

gloomy zinc
#

@rough plover this should be it