#mojira message nice
#1.21.2 Snapshots
toxic river
tacit arrow
so turns out it was a vanilla issue after all?
toxic river
yeap
Strange that they haven't been reported before, by the way.
apparently, there is some bug like this in the snapshot
haughty raven
<@&1067092163520909374>
https://www.minecraft.net/en-us/article/minecraft-1-21-2-release-candidate-2
RC2 oh no
drowsy python
At this time of year???
inland vaultBOT
New version detected: 1.21.2-rc2.
clear urchin
At this time of year???
Yes
Be happy they didn't do it on Christmas
But fuck I lost the one and only bet
inland vaultBOT
New version detected: 1.21.2-rc2.
hallow basin
At this time of year???
Localised entirely within your launcher?
prisma pawn
what
prisma pawn
inland vaultBOT
lunar dagger
steamed hams
i believe that's an Albany expression
grand crypt
i believe that's an Albany expression
it is
lunar dagger
If no other critical issues are found, this will be the version for 1.21.2 that can be expected to be released later this week.
fuck, Snowman had the troubles again
haughty raven
at this point snowman is "working"
would feel weird for it to not decompile everything again 
+49, -29
very few changes, mostly just version number bumps xD
lunar dagger
i really need to set aside time and fix that bug in Snowblower
haughty raven
curious, what causes snowblower to break?
its been running fine in my own local git runner
lunar dagger
n8n is triggering twice
because it triggers twice, the Action that runs Snowblower runs twice
and when that Action is triggered while it's already running, it cancels the current run and begins anew
ripe drum
so what if you change that 
lunar dagger
the problem is, if Snowblower had already pulled the repo by then, and then started (force-)pushing commits in batches in 10, then the commits on the main repo will be incomplete if Snowblower is killed midway
so the second invocation sees the incomplete repo, and has to rebuild all the commits again
lunar dagger
so what if you change that <:harold:932605815406342174>
in what way
ripe drum
don't cancel in-progress runs
haughty raven
yeah, is it not possible to queue them up
wait for existing to finish then run kind of thing
2nd run should zoom through as previous did all the work
lunar dagger
perhaps, perhaps
let's try it at least
it is done
IIRC it'll 'zoom' by relatively quickly, but it will mean that as the 2nd run is progressing, the latest of the dev branch will be constantly moving since it still repushes all the commits in batches of 10
red jungle
maty did you not set it up? why don't you fix it? 😛
ripe drum
it wasn't me that set up snowman
smh
besides i tried fixing n8n, and i at least managed to get it to a better state of triggering twice not thrice but i'm out of ideas
i enabled saving of the executions to see if i can debug it better this way
haughty raven
dapper pendant
Since ExplosionEvent takes ServerExplosion, and is thus only called on the server-side, it should also probably take ServerLevel instead of Level
cosmic acorn
oh wow the snapshot arrived quite late today
inland vaultBOT
New version detected: 1.21.2.
inland vaultBOT
New version detected: 1.21.2.
toxic river
Technically... one day, since it's 1.21.2 rc2
timber jolt
still takes some time to release
kind spade
There we go 😄
inland vaultBOT
lucid totem
<@&1067092163520909374>
sleek merlin
toxic river
Release alarm xd
wise mica
1.21.2 neoforge when ‼️
clear urchin
wym????!!!!!
neo people are fastest!111!!1!
/s
bronze crescent
oh god it's happening
haughty raven
oh no
obtuse marlin
Not really a shapshot alarm...
wise mica
It's been at least one minute yall fell off
clear urchin
there is no other alarm XD
haughty raven
mc release during factorio 2.0 times
well thats not being worked on 
timber jolt
wait, the redstone torches are only 1.21.2?
I thought they're already available
wise mica
This is excellent this is my favorite update
It comes with essentially custom items
You can give a stick any name and model u want and functions for custom behavior
Per world items have arrived
toxic river
You can give a stick any name and model u want and functions for custom behavior
Like the debug stick?
wise mica
I used the stick as an example
timber jolt
idk why, but that's funny to me
haughty raven
Release article: https://www.minecraft.net/en-us/article/minecraft-java-edition-1-21-2
Update Video: https://www.youtube.com/watch?v=7UE7M1-XbPk
Snowman: https://github.com/neoforged/Snowman/commit/6b33626412447ea35d5f88442647884364636f61
Primer: https://github.com/neoforged/.github/blob/main/primers/1.21.2/index.md
wise mica
Any item can have any model and name
drowsy python
wise mica
Components my beloved
timber jolt
peak
toxic river
Now it's time to wait for the hotfix
haughty raven
Release article: https://www.minecraft.net/en-us/article/minecraft-java-edition-...
for later comers, heres all the relevant links, your welcome 
-# is it worth pinning this?
lunar dagger
IT BEGINS
lunar dagger
for later comers, heres all the relevant links, your welcome <:blobsmiley:396521...
sure
you should have ping powers in 'ere
err. pin powers
haughty raven
oh i do, i must have missed that when i quickly glanced over the context menu just now xD
-# still better to ask than assume imo though
lunar dagger
for the record, all Team Members have manage messages (which include managing pins) in this forum
Moderators, because duh
Maintainers, because this space is primarily for maintainers' use
err. 'benefit' may be a better term
toxic river
#mojira nice /j
wise mica
1.21.3 here we come
haughty raven
well now that the release is over back to my factorio grind
-# the factory must GROW
sand raven
Time to update every project page version range
red jungle
oh god it's time
@kind spade @lunar dagger @ripe drum can one of you lift the branch protection rules temporarily?
into space!
lunar dagger
ah yes, I remember why I don't like branch protection rules -- no way to safely disable them temporarily
red jungle
and it was reported in the pre so they definitely don't care enough to fix it urgently
lunar dagger
<@304594425286361088> <@607058472709652501> <@561254664750891009> can one of you...
rule disabled -- don't muck it up, I disabled it for all branches 
the fun of
(the original is 1.*)
lunar dagger
rulesets can be disabled
branch protection rules -- the thing before rulesets -- cannot
red jungle
ah I see
lunar dagger
there are no more (active) rules or rulesets governing our repo 
i'm sure this'll be fine
red jungle
haughty raven
i'm sure this'll be fine
$ cd /mnt/p/development/neoforge-21.2
$ rm -rf ./src/main ./tests
$ git push --force
*whoops*
red jungle
short irisBOT
wither.tm referenced
grand crypt
interesting
red jungle
a single compilation failure because of a lambda parameter getting renamed 🤔
haughty raven
good thing theres a handy "restore branch" button
haughty raven
ooh ping me if you do, so i can update my pinned message with merged primer link
red jungle
well nevermind I don't have permissions on that repo anyway
wheat mango
https://github.com/neoforged/.github/pull/8
F3 + F now toggles fog rendering
pretty sure this is a chunk debug key, might want to note that; it's not enabled in production
lunar dagger
@red jungle pong me when you're ready to get the rule back up
red jungle
👍
let me restore the PRs then I think we're good
(we should already be good)
all good @lunar dagger, thanks
lunar dagger
the rule is back online 👍
red jungle
this thread can be locked now
spiral tapir
I'll miss you, snapshots thread, until next time tomorrow
cosmic acorn
oooh, I was right! rc on thursday and release tuesday. nice.
clear urchin
azure bane
wheat mango
drifting ice
<@207184927236554752> can I merge the primer?
I object!
Sorry, in a meeting
Give me a moment
red jungle
Don't worry I can't merge it anyway
lunar dagger
merged
lunar dagger
you had me confused there for a sec, Ash -- your PR title "Update Primer to 1.21.2" had me parsing it in the usual manner for commit messages, where the first word is a verb
which made me think it was erroneous
clear urchin
lunar dagger
my thought was "wait, you're adding a primer, not updating an existing one"
lunar dagger
"...ah, it's a primer for an update, hence 'update primer'; that makes more sense"
drifting ice
yep yep
I wonder how long it'll take emi and jei to update
Although it'll probably just be hacky workarounds for a bit
mystic kernel
yucky
drifting ice
It is if you use the block registrar specific methods
wise mica
It should automatically pull from the registry if no id was passed
wise mica
oh i suppose the block doesnt know its id
lunar dagger
the problem is that a Block has (or at least, ideally should have) no idea about how its registered to a registry, the same as any other registrable object (ideally)
wise mica
helper methods about to go brr
lunar dagger
eh, the Block shouldn't still be pulling info about itself from the registry in my opinion
i wonder why the Block takes in its ID though
wise mica
yeah this entire system is weird
its like self referencing but i dont think internals should refer to the registry that defeats the purpose of the registry system
lunar dagger
alright, who wants to volunteer to go work for Mojang and report back to us in a few years' time when their NDA expires /j
round perch
i wonder why the Block takes in its ID though
For loot table and translation
lunar dagger
hmmmm
red jungle
This new system actually removes some supplier jankyness
drifting ice
Personally, I don't mind the DependentName system, and it isn't that hard to build a method around the addition
And since DeferredRegister can now take in a ResourceLocation -> RegistryObject, it's fine
manic crescent
lmao remember when forge patched blocks to have an internal id field
manic crescent
the problem is that a Block has (or at least, ideally should have) no idea about...
have they got rid of intrusive holders?
vapid drum
It's part of Neo/Forge's design of using events for everything, which I personally don't agree with and I prefer Fabric's approach, but I also don't think this will ever change
drowsy python
Sooooo
As the god of this place
I feel like the end is nigh
Let's see....
1.21.2 is released...
NeoForge is in beta by the looks of it...
This thread is already long enought
We had 5251 messages in here
For both 1.21.1 and .2
toxic river
Before the hotfix
drowsy python
are we expecting one?
toxic river
not at the moment, but since they've changed a lot of things, there'll probably be one.
drifting ice
@round perch Give me a ping once your equipment renderer changes are done so I can document
round perch
Will do 👍
bronze crescent
🔒 ?
drowsy python
ripe drum
<@&1067092163520909374>
toxic river
xd
drowsy python
prisma pawn
at this time of year, at this time of day, etc etc
clear urchin
https://tenor.com/view/well-its-been-a-nice-run-nice-run-good-run-good-times-nic...
it sure was!
prisma pawn
did they fix the creaking softlock
toxic river
No
prisma pawn
amazing
ancient frost
- realms broken
- salmon shrinking
mystic kernel
1.21.3 is out
What did that change
sand raven
* realms broken
* salmon shrinking
We call that shrinkage. Happens when in the pool
ripe drum
did you just link the german localisation
dapper pendant
The German localization is in English
ripe drum
mystic kernel
Salmon from 1.21.1 or before shrink when updating to 1.21.2
okay what lol
sand raven
/s
dapper pendant
The article itself is English
ripe drum
german is banned on my christian minecraft server
the joys of waiting for neoform to update
fun fact, 1.21.2 was so close to being a mc version with exactly one neo release
lol this was almost the entire version
but they also put in a datafixer
sand raven
Salmonfixer
dapper pendant
I think this is the first release in... quite a while without a single RC
The previous hotfixes have all had rc1, followed by a release the next day
ripe drum
i have started the local update 
ripe drum
red jungle
remember to update the next snapshot version to 21.4
ripe drum
hardest update ever
jaunty zodiac
what an update !
well I mean it's okay to say that .2 and .3 can basically run a single mod jar, similar to 21.0 and .1 right ?!
tidal siren
Until you start relying on changes Neo introduces in .3, yes
jaunty zodiac
oh so there are some notable Neo changes in .3 ?! I see, unless maybe my brain stops working then I got what ya mean
tidal siren
I mean, not yet, or confirmed. But we've literally just updated
I'm fairly sure there's going to be people who want to make API changes during this Breaking Changes period
jaunty zodiac
i see
ripe drum
now it's finally time to retire this thread