fiction and the like
#1.21 Snapshots
hard ivy
hard ivy
does it say the same for the Snowman triggers
jagged stag
no
well actually
no idea
it didn't fail the neoform one
the snowman one it didn't get to
is your repo scope not including gmcdeps and snowman
hard ivy
that PAT is a classic one with repo scope
and I did add the Bots team to the Snowman repo, and iirc the GMCDeps one too
hard ivy
...screm
jagged stag
ok let's see if it works now
weary moon
Likely resources, we filter out a lot of stuff that changes constantly due to version bumps
jagged stag
snowman has started
fiery galleon
Likely resources, we filter out a lot of stuff that changes constantly due to ve...
ah yes, that would make sense, i also filter out the png/nbt files during decomp
makes viewing in github easier as its not loading all those files
jagged stag
also saved a bit of carbon yay
yes
2 endpoints
one for patch notes and one for the version
weary moon
ah yes, that would make sense, i also filter out the png/nbt files during decomp
Yep, --exclude "**.nbt" --exclude "**.png" are the current excludes we pass in on the Action
jagged stag
lol what
why does it still think that's latest
ah i think i know why
yeah i know, the order stored got messed up
eh it's fine
it's only an issue in testing
anyway @hard ivy after all i don't think you broke anything 
the only changes i've did was to include the if-modified-since header correctly (doesn't affect this) and renamed that yaml to yml
the cache bust was probably made it smart again
remote void
Play Subnautia
hard ivy
Play Subnautia
laptop not powerful enough, I believe
hard ivy
anyway <@607058472709652501> after all i don't think you broke anything <:thinki...
maybe
agile canyon
No primer changes, just bug fixes
jagged stag
can IJ migrations turn new ResourceLocation into ResourceLocation#parse
obsidian tide
didn't someone already create a regex for that?
white pond
can IJ migrations turn `new ResourceLocation` into `ResourceLocation#parse`
Don't think so
viscid crane
Jokes on y’all, I just have a MainModclass.id(path) function anyway
So minimal changes for me
obsidian tide
laptop not powerful enough, I believe
When new laptop?
hard ivy
next month
white pond
<:hahayes:391010900858896405>
Regex! Regex! Regex!
jagged stag
no u
obsidian tide
next month
That one should be powerful enough
hard ivy
boop
queen fog
well, my only use is games, so the proprietary ones do the job, but I can see the issue
unreal timber
gonna put in my guess for RC1 as <t:1718024400:f>
austere ocean
noted
lone tree
turbid hatch
Was gonna say, is mcp still a thing?
crystal umbra
And even if it was, it isn’t something mojang releases
obsidian tide
Was gonna say, is mcp still a thing?
there are forks afaik, but yeah, nothing anybody should use and definitely not from mojang
obsidian tide
well yes, either that, mcp mappings or mojmaps (for some reason)
lone tree
Providing mcp is not conducive to the security of the Java edition. Please stop providing mcp to the community.
austere ocean
how much you wanna bet this person downloaded a malicious mod, googled "how do mods work", and put the first thing that came up into the report
austere ocean
not us though, we're different
austere ocean
true :p
twilit slate
I as well include you in that statement/s
austere ocean
I'm not a good programmer, but I play one on TV
digital scaffold
This is also the first thing they've done on Mojira
red sigil
I include myself in that statement 😄
thanks for the inspiration, got a tiny little bit of writing out of it.
Five men are in a room, arguing.
One sighs, tired of each of them refusing to concede. "Everyone in this room is an idiot," he says, calmly, but loud enough for the rest to hear.
Offended, one of the other men straightens up and throws him a hateful glance. "How arrogant, to presume yourself superior to us!"
He pinches his nose, seeing the others nodding in agreement. "I believe, Sir, that you have proven my point."
fallow horizon
only one reject on Kits going from pre2->pre4
fallow horizon
What should we do with GetEnchantmentLevelEvent, it's basically impossible to retrieve enchantments on items without a RegistryAccess now, and the event doesn't provide one
late sentinel
can it get one from the firing site?
its only fired upon enchantment level retrieval
Which I imagine always has RA context
fallow horizon
IItemStackExtension.getAllEnchantments would need to take an RA
late sentinel
It probably should
fallow horizon
alright
late sentinel
The way mojang is going something like 80% of the methods in the game are going to need an RA param, lol
fallow horizon
It probably should
Heh, it's used in ItemEnchantmentsPredicate which doesn't have RegistryAccess context 
late sentinel
Heh, it's used in `ItemEnchantmentsPredicate` which doesn't have `RegistryAccess...
How does it work at all then?
Wouldn't it be unable to resolve the enchantments without the RA?
fallow horizon
It probably has holders already or something
the EnchantmentPredicate objects appear to have HolderSets inside
I suppose one option is for everyone to pre-resolve their holders, but not sure how that works with the client/server having separate registry accesses... do they also have separate Holder objects?
late sentinel
I suppose one option is for everyone to pre-resolve their holders, but not sure ...
Presumably, yes; at least by instance equality
Theoretically everything has to be done by name (holder or key) anyway
balmy estuary
https://bugs.mojang.com/browse/MC-273073 <:thinkies:932605814995292192>
Like what? If Mojang did do that, it would piss off the modding community 
oblique socket
late sentinel
If anyone thinks that the mappings have the slightest thing to do with security they are clueless
sinful hazel
The way mojang is going something like 80% of the methods in the game are going ...
in an ideal world, only serialisation/deserialisation paths should need it. all references to dynamic content should exist in data too
fast lotus
But this is not an ideal world 🙂
remote void
You’re an ideal world!
jagged stag
we're 103 commits oudated on kits
that's an annoying rebase
that'll have to happen after a squash
remote void
this is the part where I become conveniently unavailable
unreal timber
white pond
I'd volunteer if I wasn't neck deep in Elephant excrement
uncut river
Elephant what now?
steep copper
uncut river
ohhh
jagged stag
i'm trying to update some tests and see if the new ng update works so i can squash, push to public, and then do the painful rebase
mighty prawnBOT
Quote #1834 added: #1233004919322054678 message
jagged stag
okay GetEnchantmentLevelEvent is a bit of a problem
to modify the enchantments you need their holders
and to do that you need a reg access
our own events now require modders to statically get levels
@late sentinel 
jagged stag
christ how do you patch a holderlookup for datagen
unreal timber
like the block lookup for an itemtag generator or something else?
jagged stag
[17:27:09] [Server thread/INFO] [minecraft/GameTestServer]: ========= 102 GAME TESTS COMPLETE IN 13.57 s ======================
[17:27:09] [Server thread/INFO] [minecraft/GameTestServer]: 6 required tests failed :(
[17:27:09] [Server thread/INFO] [minecraft/GameTestServer]: - levelSensitiveLight
[17:27:09] [Server thread/INFO] [minecraft/GameTestServer]: - glm_dungeonLootTest
[17:27:09] [Server thread/INFO] [minecraft/GameTestServer]: - glm_wheatSeedReplacerTest
[17:27:09] [Server thread/INFO] [minecraft/GameTestServer]: - conditionalOverlay
[17:27:09] [Server thread/INFO] [minecraft/GameTestServer]: - packOverlay
[17:27:09] [Server thread/INFO] [minecraft/GameTestServer]: - strictNBTIngredient
progress!
the tests don't crash
hey @vapid gale want some fun with the light engine?
jagged stag
[18:00:31] [Server thread/INFO] [minecraft/GameTestServer]: ========= 102 GAME TESTS COMPLETE IN 16.79 s ======================
[18:00:31] [Server thread/INFO] [minecraft/GameTestServer]: 3 required tests failed :(
[18:00:31] [Server thread/INFO] [minecraft/GameTestServer]: - glm_dungeonLootTest
[18:00:31] [Server thread/INFO] [minecraft/GameTestServer]: - conditionalOverlay
[18:00:31] [Server thread/INFO] [minecraft/GameTestServer]: - strictNBTIngredient
vapid gale
hey <@165621075642679297> want some fun with the light engine?
Maybe
jagged stag
ah, and one of the failures was also fixed in the 100 commits
actually, both the glm and ingredient ones have since been changed
so uhm
squash, push, fun time?
digital scaffold
They had partial mappings for their server
viscid crane
pdbs are debug symbols for executables
unreal timber
The comments make my brain hurt.
viscid crane
They make binary patching and creating hooks a lot easier
lone tree
tacit oxide
lmao
theyre crying over losing mappings
somebody tell them that java went years without them
they dont even have to start from scratch
they just have to determine new ones
true totem
the java community still actively chooses to use its own mappings sometimes, eg fabric with yarn
jagged stag
ah I was wrong, kits isn't 107 commits behind, it's 107 ahead lol
squash in progress
damn it that's a failed squash what the heck
wait no it's fine
gh desktop was reporting mc source files being the squash
isn't this with fixed jst?..
oh I see I think I know why
late sentinel
to modify the enchantments you need their holders
Is the only context where the RA is unavailable the enchantment predicate?
jagged stag
Is the only context where the RA is unavailable the enchantment predicate?
getEnchantmentLevel has no registry access param
late sentinel
Is that our method or the vanilla onw
jagged stag
the vanilla one
fiery galleon
am i safe to say first /s 
obsidian tide
fast lotus
I would already start to port my 160+ mods if I had access
jagged stag
laptop battery is dying so i'll post here a few things to do before pushing to publi c(i'll get to doing them in a couple of hours if no one does)
-
SessionSearchTrees fields & Key need an AT
-
BlockModel#bakeFaceAT,ServerPlayer#RespawnPosAngle,SwordItem#createToolPropertiesis making public AT to private -
patch back
ServerStatusctor -
MushroomCow,SnowGolemtag check for shears (check all patched shears stuff, since there's a tag in vanilla now) -
restore
Boggedpatch
light arrow
<:darkoA:1238960729697030217> I would already start to port my 160+ mods if I ha...
we will make a port branch when we can
jagged stag
there also seem to be some jetbrains Nullable to javax Nullable changes in patches
those don't matter, but just noting them
with that said, laptop battery ded
fiery galleon
we will make a port branch when we can
yeah i was just playing around testing various things locally and wondered if i could publish to maven local
it published and got curious how much of my mods i could port.. turned out to be everything xD
jagged stag
changing ATs in neo takes 40 seconds now
yay jst
skipping that decomp does so much for porting
fallow horizon
idk why incremental recomp is still so slow
jagged stag
depends on scale
if you have big classes incremental is worth it
if you have tonnes of small ones
it's meh
but javac is still slow, so not inovking it is better than invoking it
fallow horizon
wdym, does it spend most of the time computing the graph of what to rebuild?
magic estuary
Is neo's userdev recomp actually incremental now? Last I remember it wasn't doing proper incremental recomp due to some other input changing
jagged stag
well yeah when there's 5000 files it will definitely take a while
jagged stag
Is neo's userdev recomp actually incremental now? Last I remember it wasn't doin...
it is yes
we're talking neodev tho
which has native gradle comp cause all classes are in the same srcset
magic estuary
Right, should be incremental by default
magic estuary
On errors? Looks like you want whatever eclipse's wacky compiler is
magic estuary
Hmm. Does javac pay attention if you @SuppressWarning a package-info.java file? Can you do that?
jagged stag
well it won't help us even if it worked
or hmm
are we the ones generating the package-infos for MC
although at the same time, that shuts up the IDE too
which is bad™️
i only want the javac build warnings to warn just code that's actually ours
WARN StatusConsoleListener The use of package scanning to locate plugins is deprecated and will be removed in a future release ugh
why does this appear 8 times now
jagged stag
no thanks
magic estuary
i only want the javac build warnings to warn just code that's actually ours
javac plugin? /j
light arrow
maty doing actual (porting) work 👀
fallow horizon
is it just me or did we have a lot of new faces this porting round
compared to the normal crew
twilit slate
jagged stag
is it just me or did we have a lot of new faces this porting round
you and apex? lol
fiery galleon
you and apex? lol
yeah i did some work more towards the very start
not pushed much since then,
gradle stuffs got borked and i dont know much gradle rly, so didnt wanna touch stuff and potentially bork it even more
jagged stag
god what is the recipe test code
it's a graph?
the strict component ingredient test doesn't work and i have no idea why
jagged stag
Let me know if I can help out
you can rebase the branch on the latest commit
white pond
I can do that, yes. Everything pushed?
jagged stag
I just realised I merged shadows pr after the rebase not before lol
yes
it's all on port/1.21
white pond
Ok
jagged stag
also for the record, I disabled 2 ingredient tests with the crafters, something was really fucky with both the ingredients and the crafters
white pond
Ok, I ported the block drop event (that took me longer than I'd like to admit) and will force-push the port-branch now
white pond
Sorry for another force push to the port branch @fiery galleon 😅
Had to fix this patch issue.
fiery galleon
yay it got a 
now
half plaza
for the blockTagIngredient test data gen needs to be rerun
jagged stag
somebody lost the keybind patches
@crystal umbra with the new shears tag, we can't keep patching out the shear code in entity#interact
@white pond how did you rebase, why did you remove the silktouchlevel and fortunelevel params from the extension method
white pond
<@84313704874663936> how did you rebase, why did you remove the silktouchlevel a...
Hm?
Be more specific, which method
jagged stag
IBlockExtension#getExpDrop
white pond
WDYM remove? the 1.21 way was passing it through that EnchantmentUtil thing
Check the comparision between before and after the rebase: https://github.com/neoforged/NeoForge/compare/9565597a6133c60eeb86ebac3325bed89c063781..b6429b3e1968e1acd76e1ed74ab6ee350c5c238a
Specifically, this was 1.21 before rebasing... note what is passed to EnchantmentHelper:
jagged stag
oh right, all the enchantment component stuff
white pond
But as I said, this really took me longer than I had hoped since it interacted with a bunch of stuff changed in 1.21 heh
But Shadows PR of the actual event didn't add those two params to getExpDrop, so I didn't keep them in the rebase either:
https://github.com/neoforged/NeoForge/commit/ef52a013d85b1b713904f80c121bf061e9596079#diff-09f61acff7451e91d7cc165e3359e1a6d23e9757efc2a569f9727c869c06a70bR349
jagged stag
you fix a test and 2 more break
great
well, i'll leave the ingredient stuff for later
it's a mess
crystal umbra
<@107837977081720832> with the new shears tag, we can't keep patching out the sh...
Tool action and then perhaps have cases like machines do the capture drops part themselves (would still need the patch to mooshrooms probably to make them support capture drops in how they drop things)? Idk, my mind is in a really really bad spot right now so I probably won’t be able to help or provide more than that
blissful nebula
https://github.com/neoforged/FancyModLoader/pull/161
Fix your formatting and it is good to go IMHO
jagged stag
hmm failing test
blissful nebula
Also that
jagged stag
Had two comments on the FML one
do you want me to wrap the setActiveContainer in the try finally too
half plaza
for the `blockTagIngredient` test data gen needs to be rerun
Did you rerun the data gen for tests?
jagged stag
yes
white pond
do you want me to wrap the `setActiveContainer` in the try finally too
Wdym.just make sure it's reset to null even in case of exceptions
half plaza
rerunning the test data gen moves the data/neotests_block_tag_ingredient/recipes/block_tag.json to data/neotests_block_tag_ingredient/recipe/block_tag.json file location for me
jagged stag
Wdym.just make sure it's reset to null even in case of exceptions
done
jagged stag
rerunning the test data gen moves the `data/neotests_block_tag_ingredient/recipe...
huh, I'll try again
lone tree
fiery galleon
think i just found a saving bug in 1.21
loaded up a world, closed the window and game is hung at a black screen seemingly trying to save
also seemingly hangs when saving and qutting to main menu
Nvm.. could just call new Type myself... 
fallow horizon
think i just found a saving bug in 1.21
loaded up a world, closed the window and...
how long did you wait
it often takes a minute or two for me
fiery galleon
good 5 mins or so i belive
fast lotus
lone tree
think i just found a saving bug in 1.21
loaded up a world, closed the window and...
in dev env?
If so, it's a known bug
fiery galleon
yeah in userdev, it just sits at either black screen (if closed window) or "saving" screen (if quit to main menu)
white pond
Hm why would this work in neodev but not userdev?
lone tree
If so, it's a known bug
It's just a bug in Minecraft's “Offline” mode.
fallow horizon
is there a mojira for that?
white pond
Yes and what is the actual bug? Why does it not happen in NeoDev? 🤔
lone tree
Yes and what is the actual bug? Why does it not happen in NeoDev? 🤔
¯_(ツ)_/¯
fiery galleon
Yes and what is the actual bug? Why does it not happen in NeoDev? 🤔
can confirm, bug is in userdev and not neodev
(just tried saving world in my rendertype pr, worked perfectly fine)
lone tree
The bug report is invalid... um...
The bug report that seems to be the same is MC-265543
digital scaffold
@agile canyon Btw the RL constructor is private, not protected
It was protected when you initially wrote that, but it's private now
agile canyon
The ResourceLocation is final and its constructor is private. There are alternatives depending on your usecase:
I changed that? Where are you looking
@digital scaffold
digital scaffold
Yeah, the heading
fiery galleon
are cheats working for anyone else in 21.0, when creating a new world?
any world i create always has them disabled, have to open to lan to enable cheats
even if i set world to creative and cheats enabled, i spawn in creative but cant use cheaty commands
world list shows cheats as enabled but loading the world they are not
even looking into nbt data via nbt-edit shows them enabled too
seems to be caused by DevLogin and is also happening on 20.6
my authed account cant use commands for what ever reason but normal neo Dev account can
jagged stag
unless the effect cures PR is merged by tomorrow ( ssshhh @vapid gale @late sentinel @primal spade reach a conclusion 😛), i'll start work on the 1.21 blog post, it'll have to be a bit longer than just "what did 1.21 change" since it should mention the important and impactful changes since 1.20.1 in a centralised place for modders skipping versions
primal spade
You mean blog post right?
red sigil
yeah 1.20.1 -> 1.21 sounds important, even if it doesn't affect most of us
primal spade
I think you can just link our other posts for previous changes
They already try to limit themselves to essential information
jagged stag
yeah, and a few PRs that didn't get a blog post (like the event result )
primal spade
Yeah I had event results in mind as well, good idea
uncut river
what happened to QuadBakingVertexConsumer.Buffered?
uncut river
what happened to overlayCoords??
vapid gale
That was renamed in vanilla
vapid gale
to?
setUv1() or setOverlay() depending on what you pass in. All of this is mentioned in the pinned primer
vapid gale
also whats the alt for endVertex now?
Gone, vertices are "auto-terminated" now
vapid gale
This is getting very deep into modder support territory now
white pond
Could you be more specific 😄
lone tree
I'll take a screenshot
wait... maybe it's also a bug in 1.20.6
ok, it's also broken with 1.20.6
lone tree
RC today?
odd flare
who knows
red sigil
likely, if not today then tomorrow
they'd want at least a couple days before the final release
unreal timber
I hope so. i picked a time that I hope i'm the guesser for
red sigil
i wonder if they'll "fix" the issue with how their change to fire protection and blast protection basically makes the enchantments useless
meaning people will ignore those enchantments even more and will just get plain old Protection
alpine pelicanBOT
New version detected: 1.21-rc1.
blissful nebula
<@&1067092163520909374> 1.21-rc1
twilit slate
queen fog
i wonder if they'll "fix" the issue with how their change to fire protection and...
they heard you
hard ivy
checked the manifest in my browser, and voila
@austere ocean aight, who's getting the guesser role
(if you're willing to crunch the numbers)
jagged stag
I love how we have so many indicators of new releases
jagged stag
#builds #neoforge #minecraft-updates (twice), this channel
alpine pelicanBOT
hard ivy
alright, I'm introducing a 10s delay before running the NeoForm check action
hard ivy
because for NeoForm, it ran the action, but the action didn't see the updated manifest
jagged stag
hmm, thonk
hard ivy
so either I make it run it twice, or I delay it
or I run it twice and delay it
delightfully devilish, Seymour sciwhiz
hard ivy
hmmmm
btw maty, do you know of a way to make it run a node twice without actually duplicating the node
jagged stag
use a loop?
humble salmon
hard ivy
i have no idea how to use the loop
so I'm duplicating the node for now, and leave it to you to poke it
agile canyon
No interesting code changes in the primer
red sigil
they heard you
no they heard PhoenixSC :P
weary moon
:3 13 changed files
agile canyon
I want to kick all the nbt files that pump up the changes
weary moon
I want to kick all the nbt files that pump up the changes
What tool are you using again?
agile canyon
VanillaGradle + IDEA diff
austere ocean
<@1008434572310093926> aight, who's getting the guesser role
uuuugh I was asleep
need to set an alarm for friday
gimme a minute
weary moon
VanillaGradle + IDEA diff
Isn't there a filter on IJ diff, you should be able to set it to something like !**/*.nbt?
agile canyon
There is, but I need to set it up each time, so I've just gone with the infinite scroll approach
hard ivy
gimme a minute
take yer time, the role can be passed off in due time
weary moon
excluding png changes (which we don't care about) and the whole lot of noise from structure versions being bumped is worth it imo
white pond
alright, I'm introducing a 10s delay before running the NeoForm check action
We might actually wanna add that via GradleMinecraftDependencies since NeoForm now requires these
So we could do a workflow->workflow dispatch or just do a ~1m delay?
primal spade
I'd just do a slightly longer delay
jagged stag
weary moon
Codecs do be
jagged stag
ah the generic
god i hate rebasing patches
there, squashed and rebased 1.21rc1 is done
now no more squash
can finally do actual changes
@fickle atlas you managed to get yourself into a porting commit 
fickle atlas
jagged stag
i volunteer someone to fix the sizedingredient test
uncut river
jagged stag
i also want to propose the removal of getenchantmentlevelevent considering that to be able to get an enchantment(holder) one would need a registry which is not available in stack#getEnchantmentLevel calls
that, or we continue the route of ugly patching to not provide mutable enchantment data and then add some other system on top that uses resourcekeys and somehow is compatible with the vanilla holder methods and contracts
unreal timber
take yer time, the role can be passed off in due time <:thinkies:932605814995292...
my guess was 20min before the alarm. not sure if anyone else guessed closer
primal spade
i also want to propose the removal of getenchantmentlevelevent considering that ...
Well... People can always grab the current server's RA
It's ugly but it seems possible™️
I wonder if it could be grabbed using some item component trickery
steep copper
I primarily defer to @late sentinel for enchantment stuff, but isn't the level event mostly used for faking/amplification?
jagged stag
Well... People can always grab the current server's RA
doesn't help on the client
primal spade
Well then they can grab the clients 
late sentinel
i also want to propose the removal of getenchantmentlevelevent considering that ...
Just leave it there for now, I'll figure out what to do with it once the initial porting is done
fathom vessel
why was FMLJavaModLodingContext removed?
late sentinel
Because its a hack
unreal timber
did anyone really use it for anything other than getting the event bus anyways?
primal spade
The mod bus is now accessible via 1) mod ctor injection or 2) ModContainer
unreal timber
right, which negated the need for FMLJavaModLoadingContext for most users.
primal spade
Precisely
austere ocean
@unreal timber did you make a bet? I can't seem to find one :p
unreal timber
<@179625893822464000> did you make a bet? I can't seem to find one :p
#1233004919322054678 message
austere ocean
ah, I'm blind
austere ocean
<@1008434572310093926> aight, who's getting the guesser role
caltinor wins this week 
gonna ask that people ping me with their bets in the future, since I apparently cannot read :p
jagged stag
putting my bets on a release on June 13th
austere ocean
you'll both have to specify a date and time :p
opal niche
If we were to get an RC2, it would have to be tomorrow, with activity in #mojira sometime today
(If they wanted to do rc2 in the morning tomorrow, though they could go for a late window)
But bh, I dont see rc2 happening unless a major bug occurs and needs fixing.
For the most part, everything that would be queued now is going towards 1.21.1, which they already confirmed they have internally.
unreal timber
how close can we get to the release time on the 13th. that'll be a close race i bet since we aren't guessing date really
I feel like the snapshot guesser thing could easily be a bot command to set your guess then when the snapshot releases a webhook to post the winner.
opal niche
I'd probably place my guess two hours after yours, since that puts it closer to the end of the release window rather then earlier.
opal niche
Referencing this, but for the 13th
lone tree
next snapshot (1.21.1) <t:1718803500:F>
austere ocean
I feel like the snapshot guesser thing could easily be a bot command to set your...
yeah, I might make a website or something for it lmao
or a PR to camelot
austere ocean
:3c
austere ocean
yeah, I might make a website or something for it lmao
doing this for funny
dyou think sci would let me add a webhook
primal spade
has anyone seen this before?
happens when loading a 1.20.5 pre world, could be my fault™️
jagged stag
yes
you can check #maintenance-talk xfact commented on it
we need to change the loot tables event
fortunately it doesn't crash
it just logs
primal spade
👍
austere ocean
how does oauth work 
austere ocean
I got it working :p
primal spade
does anyone want to have a quick look at this PR? https://github.com/neoforged/NeoForge/pull/1087
white pond
Hm having that allocation there sucks
primal spade
you're saying we could cache it in the CraftingInput?
white pond
Hard to say, but my gut says this will be called a lot
primal spade
that's already checked earlier in the recipe
white pond
Oh it's too generic to know if something is empty or not blergh
white pond
ah ingredientCount() is the non-empty item count or what?
primal spade
yes
white pond
then use that as the capacity arg to the arraylist
austere ocean
nailing down the particulars of the betting system is proving to be difficult
I think I should not include a field for what the next release will be, since we have no way of knowing
@hard ivy what happens if two people place the same bet :3c
do they both get the role
hard ivy
ideally, there aren't duplicates but if there are, then i'm torn on either giving it to both, or tossing a coin to decide
austere ocean
I wasn't going to keep the bets hidden, since they're not hidden in Discord
either way the system will only tell us who won (or perhaps send a message here if I can get a webhook :3), it's up to yall to assign the roles
so it's a Problem For Future Sci™️
hard ivy
future sci™️ indeed
austere ocean
yes, this system is really just a fancy spreadsheet; but it's an opportunity for me to mess with mongodb some more, and I love doing that
well, "love"
it's a learning experience every time
hard ivy
We might actually wanna add that via GradleMinecraftDependencies since NeoForm n...
i'll add a minute's delay between running GDepsMC and NeoForm, and consider a more webhook-controlled workflow in the (near?) future
white pond
It's something to look out for in case NeoForm fails on check and says it can't find minecraft-dependencies
but I also noticed it's possible it doesn't even need to access it at all
since it just declares a transitive dep and never uses it itself. not sure
austere ocean
I think the implementation will look something like:
- have a "release" model with a nullable date field
- have a "bet" model which has a parent user and a release
when a release happens we find the single release model with a null date, fill the date in, find the closest bet and mark it as the winner, and create a new release model for the next one
hard ivy
neat
austere ocean
mhm, assuming we never end up with two release models with a null date :3
hard ivy
I'm sure it'll be fine
austere ocean
austere ocean
I think the implementation will look something like:
- have a "release" model wi...
shocking: it has turned out to be more complicated than that
what might make more sense is having the bets have a nullable release field instead
yeah that means I can query for every bet with that field as null
austere ocean
progress!
late sentinel
@jagged stag I think we can solve our GetEnchantmentLevelEvent with DeferredHolder
Even though you cannot create a "real" holder against the RA, you can create something that is equivalent to one for the purposes of messing with the map
Since everything boils down to the ResourceKey
alternatively
you can just exploit loopholes™️ to pull the RA out of any of the Holder.Reference objects containing an Enchantment
Let me poke around with the debugger
If my assumptions are right, we can just expose the underlying HolderOwner<T> from Holder.Reference<T>, and downcast to its real implementation, RegistryLookup<T>
Since RegistryLookup<T> has Optional<Holder.Reference<T>> get(ResourceKey<T> p_255624_), we're basically done
austere ocean
would adding a leaderboard be a good idea
late sentinel
ngl storing Holder-backed data (i.e. ItemEnchantments) on an itemstack seems like memory leak hell
Since the holder captures a reference to the HolderOwner, which is going to be a RegistryLookup with a captured reference to the Registry
Nonsense like this is why the registries should just be statically accessible
austere ocean
I have to deal with timezones
austere ocean
of course. of course. of c
hard ivy
fallow horizon
Since the holder captures a reference to the `HolderOwner`, which is going to be...
late sentinel
memory usage intensifies
fallow horizon
that's going to be a major problem for packdevs running /reload if you're right
also how does that even function correctly after the registry is reloaded
late sentinel
Badly, I presume
fallow horizon
I thought the entire premise of holders was to not do this
late sentinel
Since it will not have a way to retroactively update the enchantments
This is why in my own system my DynamicHolder is managed by the registry and will be forcefully unbound on reload
mojang has hit the same wall
Based on my experience, if you setup a data enchantment, apply it to an item, and then change it and reload, the original will persist on that already created stack
hard ivy
the solution is obvious
send Shadows to Mojang to fix the problem /jk
fallow horizon
This is why in my own system my `DynamicHolder` is managed by the registry and w...
I thought holders did this by themselves
I am learning that holders were a lie
late sentinel
Unless there's a new version of Holder that is basically what my DynamicHolder is... I doubt it
It might work
but that would require that mojang calls bindKey / bindValue with null (the params are not @Nullable)
to un-bind the Holder.Reference<T>'s
Which... yeah it doesn't do that
So yes, this problem will be quite evident 
(and the memory leaks)
fallow horizon
does mojang recreate the registry or just empty it and repopulate it?
fallow horizon
yeah then we're in trouble
late sentinel
My registry system was done with static registries that empty on reload instead of being recreated
because I encountered this exact problem
I don't really see how you could rectify it while recreating the registries from scratch without adding a bunch of extra transitional logic
See RegistryDataLoader.load for where it rebuilds all of them
List<RegistryDataLoader.Loader<?>> list = p_321856_.stream()
.map(p_321410_ -> p_321410_.create(Lifecycle.stable(), map))
.collect(Collectors.toUnmodifiableList());
makes a new one for each key
crystal umbra
I thought holders did this by themselves
Iirc rebinds on reload but if no longer exists doesn’t unbind
late sentinel
austere ocean
bet = datetime.fromisoformat(form["time"]).replace(tzinfo=ZoneInfo(form["timezone"])).astimezone(UTC).replace(tzinfo=None)
hooray, placing bets seems to work :D
now I just need to do all the other stuff
tomorrow, though; it's almost midnight here
light arrow
no altering bets, submission ends 1 hour before the first guessed time or at the start of mojang working hours, whichever is later
torn notch
wait, so if I guessed that it releases in an hour I can lock submissions? :p
light arrow
#modder-1․21․1-support message who broke?
mighty prawnBOT
jagged stag
latest NG
light arrow
huh do I need to update or do we need to update in neo
unreal timber
<@607058472709652501> what happens if two people place the same bet :3c
Does your DB store when the entry was submitted? The oldest guess could win in that case.
light arrow
well we could just make it illegal to submit the same time as someone else... also timezones are a thing what timezone is it using?
jagged stag
austere ocean
Does your DB store when the entry was submitted? The oldest guess could win in ...
it does, actually
austere ocean
no altering bets, submission ends 1 hour before the first guessed time or at the...
right, idk about the locking thing though
austere ocean
well we could just make it illegal to submit the same time as someone else... al...
the db stores everything in UTC, but the page has code for displaying everything in the user's timezone (and includes a drop-down to change what timezone that is)
odd flare
wait
when was it asked to make that
since I would have given a shot at it
odd flare
now to figure out how to display past wins
just make a new DB table with the wins
austere ocean
nobody asked, I just went and did it :p
austere ocean
just make a new DB table with the wins
like, UI
I've already got the DB stuff sorted
odd flare
just a new page with a table, and then make it infinitely long
or add pagination, but that is hell
austere ocean
I think I'll have a "last game" thing on the main page and a separate history page with every game
opal niche
just a new page with a table, and then make it infinitely long <:harold:93260581...
Agreed, make it a leaderboard for who has the most correct guesses, or overall accuracy percentage
austere ocean
the annoying part is that I can't test the system until a release actually happens, and I am one hundred percent sure it'll immediately explode in my face
agile canyon
Why not just make a fake one to test it out?
opal niche
Also true, Im surprised as well that Mojang chose not do do an RC2 today either
I expected them to at least have 1-2 major bug fixes left on their list, but it seems not
austere ocean
Why not just make a fake one to test it out?
I'm going to, but I'm sure even after that it'll still fail somehow
agile canyon
¯_(ツ)_/¯
austere ocean
that's Just The Way It Is
odd flare
I wonder how fast I can make one, with Laravel
austere ocean
austere ocean
I think this was a good use of my time :3
primal spade
Mixin prepare for mod neotests failed preparing InterfaceTestMixin in neotests.mixins.json: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException The specified mixin 'net.neoforged.neoforge.debug.mixin.InterfaceTestMixin' was not found org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: The specified mixin 'net.neoforged.neoforge.debug.mixin.InterfaceTestMixin' was not found
has anyone encountered that?
austere ocean
four bets, very nice
digital scaffold
https://ginger.rto.community/snapshotbets, have at thee
Does it link with @mighty prawn, or does someone have to manually set the role?
Also 502
austere ocean
try again lol, I just restarted it to fix a bug
austere ocean
Does it link with <@1143579035423744073>, or does someone have to manually set t...
no linking
yet
digital scaffold
Mine is the furthest from now, wow
austere ocean
considering that 1.21 is confirmed for the 13th I'm a little surprised :p
I'm betting that we won't get an RC tomorrow
austere ocean
perhaps, but since we know 1.21 will happen on the 13th your bet will be moot anyway
what I'm saying is that you threw away a perfectly good bet lol
digital scaffold
Oh for some reason I wasn't thinking non snapshots counted
Idk why I thought that
austere ocean
"snapshot bets" may be a slightly misleading name lol
congrats to caltinor for starting a thing :p
austere ocean
all bets are logged in perpetuity, so in the future I could add a leaderboard or smth
unreal timber
aw. no recognition lol
unreal timber
congrats to caltinor for starting a thing :p
the real thanks goes to you for whipping this whole thing up. major kudos
austere ocean
happy to do it 
austere ocean
aw. no recognition lol
you'll just have to win again, I suppose
hard ivy
firefox is blocking the Discord images because they're 'tracking content'
austere ocean
pfft
I'm on FF too and they load fine, I guess your settings are a bit more aggressive lol
hard ivy
maybe just a tad more aggressive
remote void
Inb4 ginger added tracking pixels and such
austere ocean
no takesies backsies! :3
hard ivy
alright, time to call Mojang and ask them to release MC 1.21 way earlier /jk
austere ocean
problem causers ping in 3
opal niche
I'm betting that we won't get an RC tomorrow
Its pretty much guaranteed we won't see another RC or any type of release tomorrow.
Only way it can happen is if #mojira updates sometime tonight, which would cut things insanely close.
light arrow
@austere ocean please change the display format for the times to something non americans understand (24h clock)
obsidian tide
or a toggle, although I do expect everyone here to understand 24h time
hallow mantle
I hope everyone understands 12h time too
obsidian tide
Well mostly, but 12 still confuses me
hallow mantle
12 format or the hour 12?
odd flare
"I expect you to here at 11!"
11 in the morning? for a sleep party?
wow, thats
obsidian tide
Yeah, that's also a problem
hallow mantle
Dunno, we have 24h time but always use 12h in conversation
obsidian tide
Sure, but there I don't have to know if it's AM or PM and the 12 is not a problem
odd flare
AM "After midnight"
and PM "past midnight"
I confuse them, always
no matter how many times I google it
jagged stag
you confuse them because you're using the wrong abbreviations
after and past are the same thing
hard ivy
AM means 'ante meridian', and PM means 'post meridian'
jagged stag
the A in AM stands for ante
hard ivy
'ante' meaning "before" and 'post' meaning "after"
and 'meridian' meaning "noon"
so AM = ante meridian = before noon
and PM = post meridian = after noon
err, meridiem, meaning "mid day"
(like how "carpe diem" means "seize the day")
i'd like to say it's not that difficult, but I am aware that where I live, AM/PM is still the common notation
odd flare
I mean... if I used it more, sure, I would remembe
I only needs it like once a year to remember (or more like once every few months)
not even our support ticket system uses it
next thing you will say is that we need to use imperial here as well /s
obsidian tide
@austere ocean does the website use the version manifest?
austere ocean
<@1008434572310093926> please change the display format for the times to somethi...
it's supposed to do that automatically depending on your locale, I'll investigate
austere ocean
<@1008434572310093926> does the website use the version manifest?
yes
digital scaffold
it's supposed to do that automatically depending on your locale, I'll investigat...
Which often doesn't match the system settings I think. It's just what's standard for the locale
For example, I use yyyy-mm-dd date, but things often show mm/dd/yyyy because of my locale
austere ocean
well, I happen to like 12-hour time, so I'm not changing it for everyone
what I can probably do is add an persistent override switch
hard ivy
beside the timezone?
austere ocean
yeah (which also doesn't persist, I need to fix that too)
more code in the spaghetti pile!
odd flare
(if only Laravel had a easy to use function to just convert between timezones )
austere ocean
my deep dark secret is that the backend is a single 500-line file named app.py which also controls the rest of my website
hard ivy
also, btw, just as a smol addendum to this game of ours: bets informed by insider information (like, say, if one were a Mojangsta) shan't be counted
that will probably never trigger, but best to head that off
austere ocean
I don't think the permissions I'm requesting for oauth allow me to see what roles someone has in this server
odd flare
my deep dark secret is that the backend is a single 500-line file named `app.py`...
I hope you are joking....
if not....
you will get all the one day
austere ocean
but I watch the bets, so if a problem causer happens to make one I'll. reprimand them I guess
hard ivy
can I ask you to strike bets from people manually?
nah, just poke me and I'll poke them with a finger-wag and also a
austere ocean
I hope you are joking....
if not....
you will get all the <:stabolb:837125030479...
I'm not, but it was already too late for me to avoid 
odd flare
no wonder it took you so long to make it /s /j
digital scaffold
can you remove my bet because I didn't understand the rules
austere ocean
oops ping
austere ocean
~~can you remove my bet because I didn't understand the rules~~
no :3
I will only anneal bets if they're illicit (sock, problem causer)
hard ivy
sounds fine to me
austere ocean
the sanctity of the joke must be upheld
digital scaffold
My bet is also messed up from what I meant because I made it in the wrong timezone
odd flare
(now I wonder if I can crash your DM by generating a few thousand discord accounts, and using that nice link of yours /s /j)
digital scaffold
Though that mistake will actually make my bet closer to the actual answer
red sigil
I haven't seen any activity in #mojira so I guess no rc2 today and straight to release tomorrow
digital scaffold
@austere ocean Suggestion: add an option to sort by time bet on (since it's currently only time bet placed)
obsidian tide
no :3
I will only anneal bets if they're illicit (sock, problem causer)
🧦?
odd flare
I was just about to ask "why no release today giga?"
but then I remembered it was the 13th it should be released....
hard ivy
🧦?
sockpuppets
alt accounts operated by the same person but pretending to be different people
like a sockpuppet
austere ocean
<@1008434572310093926> Suggestion: add an option to sort by time bet on (since i...
bold of you to assume I'm sorting at all :p
I'll see what I can do
austere ocean
(now I wonder if I can crash your DM by generating a few thousand discord accoun...
it's already storing a few million entries, a bit more won't hurt :3
(for a different project, I just use the same database software for all my stuff)
odd flare
austere ocean
chat-archive> db.message.countDocuments()
57839612
sorry, did I say a few million?
unreal timber
also, btw, just as a smol addendum to this game of ours: bets informed by inside...
i feel like if someone like Gegy made a bet it would literally break the internet with everyone online going wild about the "leak"
austere ocean
bold of you to assume it would ever escape these hallowed halls
weary moon
i feel like if someone like Gegy made a bet it would literally break the interne...
they should, but make it ridiculous like sometime next year
unreal timber
~~they should, but make it ridiculous like sometime next year~~
I was thinking about that too. like just to troll
obsidian tide
~~they should, but make it ridiculous like sometime next year~~
28.07.2461 23:58
unreal timber
like if they made a bet today that the next release would be a week from tomorrow. and everyone thinks 1.21 is delayed a week
unreal timber
oh wow. that's quite a few bets. nice!
austere ocean
including at least one duplicate
hard ivy
i'm half-tempted to announce it in #project-talk
austere ocean
I'm fairly sure I set up the win checker so it prioritizes older bets? let me check
austere ocean
it would be super funny for everyone except me if I made a mistake and it selects the wrong winner
unreal timber
surprise it's random!
austere ocean
...I think I'm going to look over the win checker again
bets = sorted([i async for i in engine.find(SBBet, SBBet.release == None, sort=SBBet.created.asc())], key=lambda bet: abs(bet.bet - releasedAt).total_seconds())
winner = bets[0] if len(bets) else None
that looks about right
obsidian tide
ah yes
odd flare
```py
bets = sorted([i async for i in engine.find(SBBet, SBBet.release == None, ...
ok, I should do some actual work again
austere ocean
:3c
unreal timber
```py
bets = sorted([i async for i in engine.find(SBBet, SBBet.release == None, ...
yeah that looks good. ||list comprehension still hurts my brain tho||
austere ocean
the listcomp is because find returns an asynchronous iterator
and there's no other way to consume those, they don't work with list
austere ocean
<:bolb:837121148395323423>
in Kotlin this would look something like engine.find(SBBet::class, { it.release == null }, Sort.by("created").ascending()).sortBy { Duration.between(it.bet, releasedAt).getSeconds().absoluteValue }.singleOrNull()
unreal timber
oh, it's super common in python because it's powerful. it's just one of those things i don't find intuitive to read. If I worked more with python on the regular it might click, but for now...
austere ocean
yeah, my point is that in this specific case it's not actually doing anything except consuming the iterator
because apparently we weren't worthy of an alist() method :p
unreal timber
which backend framework did you use?
unreal timber
neat. I've dabled in Flask and Django, but haven't heard of Quart
austere ocean
its API is basically Flask with a little bit of await
it's made by the same developers and I think uses a lot of parts of Flask internally
digital scaffold
I prefer Django personally
Because it has a builtin database ORM with migrations and such
viscid crane
people underestimate using databases for large data storage
Certainly better and more space efficient than 100 megabyte JSON files
obsidian tide
it's got funky math
unreal timber
Certainly better and more space efficient than 100 megabyte JSON files
but..but..SQL is scary. how will i edit my data? /s
hard ivy
is Excel a database
viscid crane
SQL is easy
Manifold actually has a fancy inline sql query interpreter
It's as cursed as the rest of manifold, but still cool
weary moon
No Excel isn't, although it can be used as if it was in certain scenarios /integrates with actual DBs
viscid crane
https://github.com/manifold-systems/manifold/blob/master/manifold-deps-parent/manifold-sql/readme.md
Manifold is great, wish it wasn't paid
weary moon
It isn't?
viscid crane
It will also make people that dislike lombok explode
agile canyon
No Excel isn't, although it can be used as if it was in certain scenarios /integ...
You can definitely use excel at a database. It'll just give up after 10,000 rows :p /s
weary moon
It isn't?
It used to be the plugin had a nag dialog but would work without payment, now they just removed the whole payment side
viscid crane
Oh
That is actually excellent
Time to make a manifold mod that can hotload dark java
digital scaffold
https://github.com/manifold-systems/manifold/blob/master/manifold-deps-parent/ma...
Ooh new logo
weary moon
I think it was Platin who did some work on getting Manifold's Jailbreak working with reobf (and found a bug with shorts), although now we have runtime mojmap that isn't needed anymore
I also regularly shilled manifold
weary moon
why is that in the past tense
cause I haven't done it in a while
hard ivy
digital scaffold
I just use Kotlin tbh
viscid crane
Unit Expressions are also great
weary moon
operator overloading my beloved
Extension Methods and the no more Checked Exceptions are just so useful
https://github.com/manifold-systems/manifold/tree/master/manifold-deps-parent/manifold-exceptions
viscid crane
You can define custom units like F and U
I made a px unit for rendering code
5px = 1 / 16 * 5
digital scaffold
Yeah Manifold is pretty neat
I don't want to force contributors to my stuff to use IntelliJ, so I can't use Manifold
viscid crane
Time to make LDTC a manifold mod
infact, I think I am going to test it out again when I'll make my DE energy core mod
Do we have a 1.21 working prerelease for NF yet
austere ocean
but..but..SQL is scary. how will i edit my data? /s
simply don't use SQL 
mongodb forever
digital scaffold
simply don't use SQL <:sunglassesmoment:1204426246134571018>
Use SQL DBs through Django's ORM
obsidian tide
I think it was Platin who did some work on getting Manifold's Jailbreak working ...
yeah
viscid crane
This is the first java community that doesn't react to manifold like a vampire being confronted with a silver cross
obsidian tide
we love cursed stuff
viscid crane
Cursed or not, if it's useful it's useful
digital scaffold
This is the first java community that doesn't react to manifold like a vampire b...
I'm the one whose implemented ?. in javac
austere ocean
https://github.com/manifold-systems/manifold/blob/master/manifold-deps-parent/ma...
wow! this is just Kotlin
austere ocean
java developers will literally implement kotlin in java instead of using kotlin
:p
weary moon
wow! this is just Kotlin
It's actually Gosu
viscid crane
Kotlin hurts my brain when I look at it
It's as if someone took the sentence "JavaScript (sometimes shortened to just java)" seriously
austere ocean
try looking at it instead of looking like it? 
weary moon
The Author of Gosu realised that getting Java devs to change to a new language wasn't the way forward, so instead ported the improvements they made from their own language to just a javac plugin
Gosu existed pre Kotlin iirc
austere ocean
It's as if someone took the sentence "JavaScript (sometimes shortened to just ja...
this is a declaration of war 
viscid crane
Well iirc manifold is just a massive preprocessor, is it not
weary moon
Well iirc manifold is just a massive preprocessor, is it not
It's not
It is mostly syntax sugar overtop javac + some runtime components but I wouldn't call it a preprocessor
viscid crane
Huh
That reminds me, I wanted to look into their properties system
All my homies hate getter setters
weary moon
Gosu existed pre Kotlin iirc
Ah yes, 2002 for the inital GScript which morphed into Gosu arround 2010.
Kotlin was released arround 2011
magic estuary
wow! this is just Kotlin
It looks like something halfway between kotlin and groovy honestly
obsidian tide
It is mostly syntax sugar overtop javac + some runtime components but I wouldn't...
it does have a preprocessor tho
it's very cursed
weary moon
Yep, I never actually really found a use for it, theres a few things I can think of but doing it this way would be just cursed
Saying that when I literally just made a preprocessor for a language because
magic estuary
Manifold's jailbreak is what inspired OpenSesame, originally
obsidian tide
Well, there is the one multi version mod, that uses something like that to have all the code in the same file for some fucking reason
magic estuary
...but then I found even more cursed stuff I could do with OpenSesame, and here I am
weary moon
I have also just realised this is the 1.21 thread for some reason I thought we were in squirrels
austere ocean
there are no accidents
check on squirrels
arranged marriage
I think I will stay here
so anyway I don't think we're getting an rc today
lapis pawn
I tried 1.21 snapshot with neoforge 21.0.0-alpha.1.21-rc1.20240610.155935(pullrequest version)
and success for my mod.... but Trial Chamber's loot table seems empty
red sigil
any errors loading loot tables?
lapis pawn
let's me see
lapis pawn
any errors loading loot tables?
nope. not have error. Instead I can open with spectator mode even not open yet
red sigil
so the loot table value has been lost, then
but if you already opened that chest in creative
then that's done
make sure it's a chest you didn't open yet
weary moon
Wasn’t there some talk of LootTable issues?
lapis pawn
make sure it's a chest you didn't open yet
It's already empty when I open first
oh wait
It's 1.21 rc1(non modded) in game too
sorry my misunderstand
red sigil
dunno the loot seems fine right now. (the netherite armor was spawned in in creative)
oh this chest is empty
huh now all the chests are empty 
obsidian tide
obsidian tide
dunno the loot seems fine right now. (the netherite armor was spawned in in crea...
are they really that full?
lone tree
is it normal?
obsidian tide
lone tree
If some chests are empty in the trial chambers, that's normal.
unreal timber
is that seriously a naturally spawning trident in a trial chamber chest/barrel?
austere ocean
timezone selections now persist
jagged stag
can someone give me the resourcelocation regexes for find and replace
to note them in the blog post
austere ocean
amused that giga made the same bet I did lmao
obsidian tide
god fucking damnit, why did it do 12th
unreal timber
to give everyone a fighting chance lol
obsidian tide
opal niche
god fucking damnit, why did it do 12th <:screm:980923567833219093>
At least it didn't mark it as the 14th xD
I'm still half-expecting to possibly screw it up from timezone differences haha
austere ocean
At least it didn't mark it as the 14th xD
I'm still half-expecting to possibly s...
nah, everything's stored in UTC and the frontend handles timezones
so as long as you didn't select the wrong timezone, your bet is as it appears
unreal timber
does anyone have the link explaining how to use the 1.21 snapshots to build in dev?
I thought i found the PR but it's draft and the description was erased
vapid gale
The info is in the comment from the neoforged-pr-publishing bot on https://github.com/neoforged/NeoForge/pull/1076
unreal timber
ah. didn't notice the collapsible section. 
austere ocean
wait, should I have used server nicks?
do the scopes I request even allow me to read server nicks??
who knows
light arrow
reminder bets close in a few minutes (office hours start at mojang)
viscid rune
AM "After midnight"
and PM "past midnight"
I confuse them, always
no matter how ...
I thought of BN "before noon" for AM and AN "after noon" for PM
obsidian tide
unreal timber
I thought of BN "before noon" for AM and AN "after noon" for PM
DayTimeEvent.Pre and DayTimeEvent.Post
hard ivy
NoonEvent
light arrow
judging by the timestamp floating around in the MC discord either ginger or sci will win today's bet
odd flare
hmmm
hard ivy
I can't win because I had the wrong AM/PM
digital scaffold
Was about to say...
digital scaffold
I might've won had I had the right day
crimson hazel
<t:1718296200:t>
Will it be on 1.21 release? Half hour later? We don't know!
median agate
<t:1718296200:t>
Will it be on 1.21 release? Half hour later? We don't know!
maybe its 10 but that person is gonna review it
or is that a dev?
crimson hazel
It's a Minecraft employer
median agate
oh
median agate
also do you guys think there will be a ton of bugs since there was only 1 RC
remote void
Why would the amount of RC have any relation to the bugginess of full release?
Well, if they were doing an RC every day, that would probably indicate the code is spaghetti nightmare and extra buggy and likely not all fixed. Low amount of rcs likely means the game is in a stable state to Mojang
crimson hazel
"Too buggy, won't fix before releasing"
median agate
Well, if they were doing an RC every day, that would probably indicate the code ...
ah ok
odd flare
they likely just did tree changes again /s
viscid crane
Can't wait for the .1 change that revamps everything internal about the game
lone tree
Minecraft 1.21.1 will fix trial chamber generation
crimson hazel
and remove herobrine
hard ivy
austere ocean
reminder bets close in a few minutes (office hours start at mojang)
(they don't actually, I never implemented this)
woops, ping
but we can all say that the bets close ig
oh yknow I should add a display for bets which are already wrong
hard ivy
when do I get to say the phrase "all bets are off" /jk
austere ocean
oh yknow I should add a display for bets which are already wrong
I'm gonna go ahead and add this (or I'll try to)
lone tree
1.21?
agile canyon
just imagine we get rc2
austere ocean
I'm gonna go ahead and add this (or I'll try to)
done, that's a lot of red
fresh stirrup
I think we're certainly getting 1.21.1 tomorrow
austere ocean
probably should change the styling to something easier on the eyes
austere ocean
and it's not actually that accurate either, since the time comparison is absolute
light arrow
~~just imagine we get rc2~~
they wouldn't they would release and make a hotfix on monday
hard ivy
and we all know only Siths deal in absolutes
crystal umbra
they wouldn't they would release and make a hotfix on monday
or friday
austere ocean
removed
austere ocean
tomorrow for me is about 2 hours from now <:kek:1134098707869073408>
at some point after the farthest bet :p
might be interesting to make a graph of when it actually releases vs when we all thought it would release
I'm bad at graphs, but I can probably make a way to download the bets as json or something
lone tree
I don't see why Minecraft 1.21 should have a hotfix.
weary moon
It shouldn’t but it likely will
lone tree
why?
viscid crane
Minecraft's been needing a lot of hotfixes lately
weary moon
I think most of the recent versions have had a hotfix soonish afterwards?
red sigil
rule #1 of software deployment: as soon as it reaches the public, people find random shit none of the testers thoght to try
digital scaffold
1.20.2 is the last one I can think of that didn't need one
Before that it was 1.19.4
viscid crane
That's rule 2 actually
viscid crane
Rule 1 is "If it works, don't touch it, don't even look at it"
red sigil
and rule 3 is: don't publish on friday
austere ocean
rule #1 of software deployment: as soon as it reaches the public, people find ra...
this is why I'm worried about the betting site :p
it's worked great so far
red sigil
"great" except that it shows 12hr time despite having my pc (and phone) set to 24hr time :P
austere ocean
but the backend is duct tape and popsicle sticks and I don't trust it to not explode when the release happens
digital scaffold
and rule 3 is: don't publish on friday
Thursday's not much better
austere ocean
"great" except that it shows 12hr time despite having my pc (and phone) set to 2...
that's a skill issue on your browser's part, my time formatting respects locale :p
weary moon
Rule 4 is don't touch rendering
red sigil
locale != time choice
austere ocean
if I can figure out how I'll add an override switch later
digital scaffold
locale != time choice
A lot of things don't offer an API for this unfortunately
viscid crane
Rule 4 doesn't exist for me
austere ocean
the library was supposed to handle it for me 
red sigil
yeah that's one of the things that annoy me
viscid crane
I love 3D Graphics
digital scaffold
I have the same issue with dates
viscid crane
I will rework rendering as many times as I can
austere ocean
stupid humans and their inconsistent preferences
lone tree
Rule 4 is don't touch rendering
Mojang are not aware of this rule