1.20.5/6 Snapshots | The NeoForged Project | Page 11

elder swallow Apr 20, 2024, 1:54 PM

#

the problem with registering components in neoforge is that they get the neoforge namespace

#

it would be better for mods to register their own component in their own namespace

fallen igloo Apr 20, 2024, 1:55 PM

#

elder swallow the problem with registering components in neoforge is that they get the `neofor...

that should not be a problem if we are the ones providing it

elder swallow Apr 20, 2024, 1:56 PM

#

it would potentially be weird for mods to have a few random neoforge-namespaced components and then other components in their own namespace

#

on the other hand we're already doing that for ingredients and nobody complains 😛

#

I suppose that ingredients such as neoforge:compound are a very generic concept, whereas data components are necessarily centered on a specific use case (e.g. storing the contents of a tank)

fallen igloo Apr 20, 2024, 2:00 PM

#

elder swallow I suppose that ingredients such as `neoforge:compound` are a very generic concep...

the components we provide are generic they are not things every mod author should do themselves (that is the entire point of (neo)forge)

elder swallow Apr 20, 2024, 2:00 PM

#

right now we do not provide any

#

do you have specific ones in mind?

fallen igloo Apr 20, 2024, 2:04 PM

#

huh? I thought we moved the itemstack attachments to components

elder swallow Apr 20, 2024, 2:04 PM

#

we did not provide AttachmentTypes before (as far as I know?)

fallen igloo Apr 20, 2024, 2:05 PM

#

hmmm....

#

why did we have the discussion about needing a milk fluid like thing at all? (not today but before)

elder swallow Apr 20, 2024, 2:07 PM

#

for FluidHandlerItemStack and FluidHandlerItemStackSimple

#

this is now solved by requiring a Supplier<DataComponentType<SimpleFluidContent>> componentType to be passed in the constructor 😉

#

@wild pine getOrDefault shouldn't be nullable 😄

misty crow Apr 20, 2024, 2:08 PM

#

fallen igloo why did we have the discussion about needing a milk fluid like thing at all? (no...

That discussion was related to the file path regex stuff with structure saving/loading

elder swallow Apr 20, 2024, 2:08 PM

#

we also had the discussion for the fluid handler item stack helpers

#

I didn't follow the structure one

fallen igloo Apr 20, 2024, 2:09 PM

#

elder swallow <@201070433280196608> `getOrDefault` shouldn't be nullable 😄

well it should because the default could be null

elder swallow Apr 20, 2024, 2:09 PM

#

it can't, it's not nullable

fallen igloo Apr 20, 2024, 2:09 PM

#

but then the param needs to be nullable too

elder swallow Apr 20, 2024, 2:09 PM

#

furthermore, compare:

fallen igloo Apr 20, 2024, 2:09 PM

#

so either both are or none

elder swallow Apr 20, 2024, 2:09 PM

#

making the return nullable is stupid

misty crow Apr 20, 2024, 2:09 PM

#

Agreed

elder swallow Apr 20, 2024, 2:09 PM

#

the entire point of getOrDefault is to avoid the nullable return

#

I wonder if T can be @Nullable Something though thonk

#

say we had <T extends @Nullable Object> T getOrDefault(..., T defaultValue)

#

technically that should be generic over nullability

fallen igloo Apr 20, 2024, 2:14 PM

#

T can't be nullable in the component type

elder swallow Apr 20, 2024, 2:15 PM

#

maybe you could clear the nullability away using <? extends @NotNull T>

fallen igloo Apr 20, 2024, 2:19 PM

#

please no

wild pine Apr 20, 2024, 3:10 PM

#

elder swallow <@201070433280196608> `getOrDefault` shouldn't be nullable 😄

ah yeah, my mistake, i believe thats a copy paste error
pasted the supplier get and just gave it the T defaultValue param forgot to remove the anno

well it should because the default could be null
also while yes tecthinicly true, default value is not supposed to be null
guess its rly @UnknownNull or could use the
@Contract anno to have be null if default val is null but im unsure how that annos params works tbh

elder swallow Apr 20, 2024, 3:25 PM

#

It's best to keep things simple IMO

#

Nullable objects and codecs generally don't play nice together anyway

wild pine Apr 20, 2024, 3:31 PM

#

fairly simple fix though

median wasp Apr 20, 2024, 4:45 PM

#

How do I depend on any version of a dependency? I don't want to have to deal with snapshot version IDs

#

I'll just use [20,) for neoforge and [1,) for Minecraft

prisma locust Apr 20, 2024, 5:22 PM

#

median wasp How do I depend on any version of a dependency? I don't want to have to deal wit...

don't specify the dependency

slow prism Apr 20, 2024, 5:24 PM

#

median wasp How do I depend on any version of a dependency? I don't want to have to deal wit...

*

frail hatch Apr 20, 2024, 7:28 PM

#

I may look at it at some point before the RB/release, but I still think we should move the attachment in IAttachmentCopyHandler to the first parameter, and the lookup provider in IAttachmentComparator to the last parameter so that it is easier to just do method references

elder swallow Apr 20, 2024, 7:30 PM

#

Sounds reasonable yeah

frail hatch Apr 20, 2024, 7:32 PM

#

also IAttachmentSerializer didn't lose the deprecated for removal method and make the other read method non defaulted yet

#

I will try to look at the proposed ingredient changes sometime in the next couple days

elder swallow Apr 20, 2024, 7:37 PM

#

Also I haven't deleted the comparison logic yet

frail hatch Apr 20, 2024, 7:57 PM

#

why is IDataComponentHolderExtension#getOrDefault marked nullable??

wild pine Apr 20, 2024, 8:01 PM

#

it shouldnt be now, tech merged the pr to fix that, didnt he?

#

yep, merged https://github.com/neoforged/NeoForge/pull/827

frail hatch Apr 20, 2024, 8:07 PM

#

ah think I checked it out just before that was merged

slow prism Apr 20, 2024, 8:18 PM

#

i'll collect a list of interaction events and open a brainstorming thread

boreal flint Apr 20, 2024, 8:37 PM

#

if you're gona do that I'd appreciate some consideration for what the return values do in each situation

#

https://github.com/Tslat/Advent-Of-Ascension/blob/1.20/source/util/InteractionResults.java

#

cus atm it's basicaly just magic values with an arbitrary name attached

#

and modders have no idea what to return half the time

#

maybe some helper overload return methods or something idk
or just better javadocs

slow prism Apr 20, 2024, 8:39 PM

#

boreal flint if you're gona do that I'd appreciate some consideration for what the return val...

https://hackmd.io/UO4kdTlZSbSJP5d7pOw1Jw this is how i'm doing it thinkies

#

abolbstare

#

why does that have its own event..

true jacinth Apr 20, 2024, 9:08 PM

#

arrow events are a bit of a mess

#

they're necessary for custom arrow functionality

#

but holy shit are they a clown fiesta

frail hatch Apr 20, 2024, 9:19 PM

#

am I correct in assuming nothing changed from initially and data components are still immutable? And if so what is the way we are recommending for people to implement caps on their items. Given at least in 1.20.4 the cleanest way was to attach the cap with the data and then provide it as a capability for other mods to interact with

slow prism Apr 20, 2024, 9:20 PM

#

i put a pls remove next to ArrowNockEvent as that's actually useless

summer furnace Apr 20, 2024, 9:24 PM

#

frail hatch am I correct in assuming nothing changed from initially and data components are ...

I believe the ongoing assumption was that all item attachments would have to be refactored into immutable components, or use a separate storage system you manage yourself and only store the "id" in the item

#

you can use capabilities still, as a means to provide an API that understands the components and the data they hold

frail hatch Apr 20, 2024, 9:31 PM

#

hmm I will think on it more. Not sure how feasible it is to wrap it for my uses given how far down it would go. Though maybe... will be a bit messy though

#

and we may want to consider exposing wrappers in neo

slow prism Apr 20, 2024, 9:37 PM

#

starting to regret this

summer furnace Apr 20, 2024, 9:41 PM

#

frail hatch and we may want to consider exposing wrappers in neo

the issue is that minecraft doesn't copy the components, it just transfers over the SAME instance of the components when duplicating stacks, so you can't rely on the contents not being entangled

#

that's why we need immutability, or at least pseudo-immutability

#

(eg you can have a mutable object that ONLY gets mutated in response to loading configuration data / datapack data)

frail hatch Apr 20, 2024, 9:43 PM

#

I understand why

#

it just causes the api to be taking a few steps back after having taken a ton of steps forward in 1.20.3 with attachments and the cap rework

#

so caps for item stacks are back to being pretty bleh

summer furnace Apr 20, 2024, 9:44 PM

#

yeah I was hoping we'd have BOTH components and attachments on itemstacks

slow prism Apr 20, 2024, 9:49 PM

#

and when i thought i got through the bad part (right clicks), THE LEFT CLICKS ARE EVEN WORSE

#

this is such a mess

slow prism Apr 20, 2024, 10:05 PM

#

welp, i'm done

elder swallow Apr 20, 2024, 10:09 PM

#

frail hatch so caps for item stacks are back to being pretty bleh

Not really

#

The tradeoff is that item stacks become much cheaper to copy

#

Which I personally find a massive step forward hehe

prisma locust Apr 20, 2024, 10:13 PM

#

frail hatch it just causes the api to be taking a few steps back after having taken a ton of...

The immutability is not that verbose if your component works nicely with the pattern of ItemStack#update(), take a look at SetPotionFunction for example

#

this only applies to attachment-style use cases, I don't know what components on itemstacks were like before so I can't comment on that

lime galleon Apr 21, 2024, 1:41 AM

#

so previously, caps did implement copies (via serialize + deserialize, which is slow in this own right), now they implement explicit copy functions, but are immutable. so really the question is copy() being called more, or are item stacks' components' being mutated more, because the intensive operation moved from the former to the latter with immutability.

true jacinth Apr 21, 2024, 1:50 AM

#

copy is being called more

#

like way way way way more

#

data mutation only happens when something changes, copy happens transiently for tons of operations

fallen igloo Apr 21, 2024, 7:02 AM

#

to clarify the component itself is not copied but passed as an instance when the stack is copied

true jacinth Apr 21, 2024, 7:03 AM

#

Yes, rather ItemStack#copy is being called substantially, which transiently means that (prior to components) capability copy was happening just as often

#

data mutation (cheaper on a capability) requires a full copy of the immutable component, but this operation is less frequent

fallen igloo Apr 21, 2024, 7:07 AM

#

also with the size of the biggest components it is negligible

true jacinth Apr 21, 2024, 7:07 AM

#

Realistically some of the largest modded components would have previously been large backpacks storing many items

#

Since you have to copy all the itemstacks to copy the component [for mutation], it sounds expensive, but since itemstack copy is now "free", its actually cheap

#

You would need to end up with a huge component composed of non-cheap-to-copy types

#

and be mutating it very frequently (say on all items on inventory tick or something) before you even think about the component system being less performant

stray bay Apr 21, 2024, 8:27 AM

#

you mostly wouldn't even need to copy the itemstacks in the backpack case

#

like, unless you're making a copy of the whole backpack itself, it should be safe to just copy the list [and keep the references to the current itemstacks in all the slots you're not mutating], so you're spared even the cheap copy

#

hmm no, you'd... you could do that but you'd have to copy them whenever mutating one of the itemstacks inside?

#

now i'm having trouble reasoning about this at 4am

#

yeah you couldn't allow mutating an itemstack inside anyway [without also making a copy of the list] on the principle that the component is deeply immutable, but given nothing ever does that you'd be safe to do a shallow copy of the list when mutating the component

#

you would have to make a copy when extracting an itemstack from the list, and while mutating the stack returned by getStackInSlot is technically ill-defined now, that'd become a real concern for item handlers backed by data components attached to itemstacks

#

[and god knows what the gui code does]

fallen igloo Apr 21, 2024, 10:05 AM

#

Todo before merge to 1.20.x:

Fix/address porting todos
Check removal deprecations
Finish and merge critical refactors

elder swallow Apr 21, 2024, 4:40 PM

#

If we miss a few todos it's fine

blazing valve Apr 21, 2024, 8:10 PM

#

@elder swallow remember to put the eventbussubscriber and bus.forge->bus.game change in the blog

misty crow Apr 21, 2024, 9:37 PM

#

@true jacinth https://github.com/neoforged/NeoForge/pull/825 (packet distributor) rebased on the network rework, should be good to go unless you have further comments on the error handling

true jacinth Apr 21, 2024, 9:41 PM

#

kk, looking over it now

#

lgtm, I have some stylistic nitpicks I might apply but they aren't super relevant

#

i.e. in makeClientboundPacket the list creation can just be Arrays.asList

misty crow Apr 21, 2024, 9:48 PM

#

How would that work? The loop wraps the payloads in ClientboundCustomPayloadPacket

true jacinth Apr 21, 2024, 9:52 PM

#

oh right it does do that

#

I guess you could do a stream transform

#

Arrays.stream().map().toList()

misty crow Apr 21, 2024, 9:53 PM

#

That would work, yes

slow prism Apr 21, 2024, 9:59 PM

#

misty crow <@171447165128802316> <https://github.com/neoforged/NeoForge/pull/825> (packet d...

small comment, but I can't say I love being able to provide an empty vararg.. can you not CustomPayload payload, CustomPayload... payloads so that it's effectively at least 1

misty crow Apr 21, 2024, 10:02 PM

#

Hmm, yeah, that's a good point. That should be doable, give me a second

blazing valve Apr 21, 2024, 10:02 PM

#

I really don't see the point of the vararg anyway

#

How often do you send multiple statically?

misty crow Apr 21, 2024, 10:02 PM

#

The vararg allows you to send multiple payloads as a bundle

blazing valve Apr 21, 2024, 10:03 PM

#

Wait, it only batches in that case?

misty crow Apr 21, 2024, 10:03 PM

#

Yes, that's the only case where it can batch

blazing valve Apr 21, 2024, 10:03 PM

#

That makes no sense

#

you are just calling listener.send(payload); 😄

#

Ah

#

In the playerbound case

elder swallow Apr 21, 2024, 10:03 PM

#

clientbound*

blazing valve Apr 21, 2024, 10:04 PM

#

yeah yeah the method is called sendToPlaeyr 😛

#

not send to client 😉

misty crow Apr 21, 2024, 10:04 PM

#

Yeah, the serverbound helper is "special" since there is no serverbound bundle packet

blazing valve Apr 21, 2024, 10:04 PM

#

Okay, IDK. My personal take is:

either you send one
or you send a dynamic amount of packets

#

So, I'd personally prefer

send(X)
send(Collection<X>)

true jacinth Apr 21, 2024, 10:05 PM

#

Having to manually make the collection is fairly clunky though

#

plus it means you need 2x methods

#

for the overloads

slow prism Apr 21, 2024, 10:05 PM

#

it's blegh

elder swallow Apr 21, 2024, 10:05 PM

#

yeah 2x the methods is ugly 😛

blazing valve Apr 21, 2024, 10:05 PM

#

Well, as I said -> if you have a dynamic amount

#

vararg sucks

elder swallow Apr 21, 2024, 10:05 PM

#

it's just an array 😄

true jacinth Apr 21, 2024, 10:05 PM

#

vararg is fine, the entire thing is currently vararg, lol

blazing valve Apr 21, 2024, 10:05 PM

#

yes, meaning you first make a list, then do the godawful .toArray(BlahBlah[]::new) 😛

#

Anyway. I gave ma 2ct, now you can ignore me 😄

slow prism Apr 21, 2024, 10:06 PM

#

~~should just be std::vector& obviously~~

blazing valve Apr 21, 2024, 10:06 PM

#

Ahem. &&?

true jacinth Apr 21, 2024, 10:06 PM

#

stabs in c++

blazing valve Apr 21, 2024, 10:06 PM

#

Or maybe not? Who knows! I gotta sacrifice a goat to be blessed with the knowledge

elder swallow Apr 21, 2024, 10:07 PM

#

nah just do std::vector const&

#

everything can bind to const& even rvalues

misty crow Apr 21, 2024, 10:15 PM

#

slow prism small comment, but I can't say I love being able to provide an empty vararg.. ca...

Adding this would be easy and has the benefit that I can remove the exception from makeClientboundPacket()

summer furnace Apr 21, 2024, 10:16 PM

#

why are you all talking about C++ stuff in the 1.20.5 channel, should I be concerned about 1.20.5? XD

slow prism Apr 21, 2024, 10:16 PM

#

it's the C update

#

the Components update

misty crow Apr 21, 2024, 10:18 PM

#

misty crow Adding this would be easy and has the benefit that I can remove the exception fr...

I'm gonna let y'all decide about that and get some much needed sleep 😄
Good night

true jacinth Apr 21, 2024, 10:21 PM

#

Moving to A a, A... extras is fine

#

it makes handling it a bit weird though

#

since the data comes in as <obj> + <obj[]> instead of one <obj[]>

#

That said, it should reason that the single vararg parameter with an exception if empty may be beneficial for code flow

wild pine Apr 22, 2024, 1:39 AM

#

just pulled in the new networking changes via pr published jar
i noticed RegisterPayloadHandlersEvent.register takes in a version now (used to tbe the namespace/modid)
how is this version different from calling PayloadRegistrar.versioned?

true jacinth Apr 22, 2024, 1:39 AM

#

versions are mandatory

wild pine Apr 22, 2024, 1:40 AM

#

feels like .versioned is pointless now if the main register takes in the version

true jacinth Apr 22, 2024, 1:40 AM

#

.versioned lets you change it

#

since versions are recorded on the individual payload level

#

you can do

registrar(1.0.0)
<payload 1>
<payload 2>
versioned(1.1.0)
<payload 3>

#

Does it make a ton of sense? Not really; but declared network versions are more or less a stopgap until the handshake protocol can be implemented

wild pine Apr 22, 2024, 1:42 AM

#

sounds neat and could see a usecase but id just make all my payloads use the same version

magic sierra Apr 22, 2024, 1:58 PM

#

RC 3?

#

#mojira

fallen igloo Apr 22, 2024, 1:59 PM

#

probably rc3 today and release tomorrow or wednesday

restive raft Apr 22, 2024, 2:00 PM

#

~~what if they roll that into the actual release~~ thinkies

magic sierra Apr 22, 2024, 2:04 PM

#

Bad idea

restive raft Apr 22, 2024, 2:05 PM

#

what's the worst that could happen? ~~1.20.6~~

clear bane Apr 22, 2024, 2:17 PM

#

~~1.20.10~~

solar zephyr Apr 22, 2024, 2:18 PM

#

Ship it!

edgy arrow Apr 22, 2024, 2:18 PM

#

restive raft ~~what if they roll that into the actual release~~ <:thinkies:932605814995292192...

it even says the version name on mojira already i think?

clear bane Apr 22, 2024, 2:19 PM

#

RC3 ot

plucky brook Apr 22, 2024, 2:19 PM

#

kek

edgy arrow Apr 22, 2024, 2:20 PM

#

yeah that would explain why it doesnt say future version

clear bane Apr 22, 2024, 2:21 PM

#

#minecraft-updates its out 😛

summer furnace Apr 22, 2024, 2:22 PM

#

rc3 :P

restive raft Apr 22, 2024, 2:23 PM

#

<@&1067092163520909374> 1.20.5-rc3
https://mdcfe.dev/mc-changes?ver=1.20.5-rc3
https://www.minecraft.net/en-us/article/minecraft-1-20-5-release-candidate-3
https://github.com/neoforged/Snowman/commit/9a43af6200675d1f8683e73e2a2fb16ac335870f

fallen igloo Apr 22, 2024, 2:23 PM

#

called it

restive raft Apr 22, 2024, 2:23 PM

#

Oh look, it's finally Monday! Since we haven't shipped something for several hours, we thought we'd kick the week off with a third and (fingers crossed!) final Release Candidate for Minecraft: Java Edition 1.20.5.

one bug fixed

open kindle Apr 22, 2024, 2:23 PM

#

single bugfix, this shouldn't be too bad

fallen igloo Apr 22, 2024, 2:23 PM

#

sooo how long until 🐸 after the release?

river zephyr Apr 22, 2024, 2:24 PM

#

Reminds me of another two versions with very little fixes between the two

restive raft Apr 22, 2024, 2:24 PM

#

https://tenor.com/view/do-you-have-any-idea-how-little-that-narrows-it-down-that-narrows-it-down-clear-now-its-clear-now-i-understand-now-gif-21256627

Tenor

elder swallow Apr 22, 2024, 2:38 PM

#

https://github.com/neoforged/Snowman/commit/9a43af6200675d1f8683e73e2a2fb16ac335870f

#

Only the bugfix for that one bug

#

Not sure I understand the cause though

stiff galleon Apr 22, 2024, 2:42 PM

#

it sounds like can_break/can_place block predicates in mcfunction jsons were invoking getOrCreateTag offthread, creating tags offthread

spiral radish Apr 22, 2024, 2:43 PM

#

hmmm why do I get the feeling this might fix that intermittent tag/crafting issue as well

misty crow Apr 22, 2024, 3:35 PM

#

true jacinth Moving to `A a, A... extras` is fine

I've pushed the change, it's not that bad to handle the split <obj> + <obj[]>

magic sierra Apr 22, 2024, 5:08 PM

#

https://www.youtube.com/watch?v=j1tSUVbUMOQ

YouTube

slicedlime

News in Minecraft 1.20.5 Release Candidate 3

Third time's a Candidate... wait, was that the right proverb? Anyway, here's a quick video about Release Candidate 3 for 1.20.5! #minecraftemployee

slicedlime works as a Tech Lead for Minecraft at Mojang, but the YouTube and Twitch channels are personal projects run entirely in his spare time. This is an unofficial update video that aims to be ...

▶ Play video

prisma locust Apr 22, 2024, 6:44 PM

#

spiral radish <a:hmmm:867570087119814676> why do I get the feeling this might fix that intermi...

Thing is, if that were the case then why wasn't it an issue on 1.20.1? The last time Mojang touched getOrCreateTag was in 1.18/1.19 based on Snowman

#

unless can_break/can_place are newer than 20.1

stiff galleon Apr 22, 2024, 6:46 PM

#

they might have changed something in function loading

#

err

#

can_break and can_place are itemstack components, so yes, they are newer than 1.20.1 harold

prisma locust Apr 22, 2024, 6:51 PM

#

I'm trying to figure out what that fix is actually fixing

#

the map is already COW but I guess there are some race conditions that can occur if the same tag is created multiple times or something

slow prism Apr 22, 2024, 6:53 PM

#

🐮

azure sparrow Apr 22, 2024, 8:12 PM

#

fwiw RegistryOps is the main fix here

royal stone Apr 23, 2024, 2:58 PM

#

It's here (spotted by the fabric bot)

spiral radish Apr 23, 2024, 2:58 PM

#

<@&1067092163520909374> Sound the Alarms
https://mdcfe.dev/mc-changes?ver=1.20.5
https://www.minecraft.net/en-us/article/minecraft-java-edition-1-20-5
https://github.com/neoforged/Snowman/commit/1a6c9fb0ae538cbd84a9c48bd2468c92f2fd9c03

restive raft Apr 23, 2024, 2:59 PM

#

SQUIRR

clear bane Apr 23, 2024, 2:59 PM

#

https://tenor.com/view/pirómano-meme-jeje-odio-bomberos-gif-15722930

Tenor

last briar Apr 23, 2024, 2:59 PM

#

!!!!!!!

stiff galleon Apr 23, 2024, 2:59 PM

#

beat the warning, the sound of the drums

clear bane Apr 23, 2024, 2:59 PM

#

imma go back to work now
harold

errant lion Apr 23, 2024, 2:59 PM

#

Nothing new I can see from Minecraft.net, last was 4/22

clear bane Apr 23, 2024, 3:00 PM

#

becasue the site updates a slight bit later apparently
likely some cache

#

#minecraft-updates

errant lion Apr 23, 2024, 3:00 PM

#

Ah

#

Ohh

kind sable Apr 23, 2024, 3:00 PM

#

https://tenor.com/view/lotr-gondor-call-fires-fire-gif-13706821

Tenor

spiral radish Apr 23, 2024, 3:01 PM

#

I wonder if Snowblower is going finish before the blog post get's published harold

errant lion Apr 23, 2024, 3:02 PM

#

harold

last briar Apr 23, 2024, 3:02 PM

#

🪮

spiral radish Apr 23, 2024, 3:03 PM

#

https://github.com/neoforged/Snowman/commit/1a6c9fb0ae538cbd84a9c48bd2468c92f2fd9c03

#

Blogpost is up https://www.minecraft.net/en-us/article/minecraft-java-edition-1-20-5

bright night Apr 23, 2024, 3:06 PM

#

ono

lean anchor Apr 23, 2024, 3:08 PM

#

oh shi-

errant lion Apr 23, 2024, 3:09 PM

#

Nano whats the repo for Gander?

lean anchor Apr 23, 2024, 3:11 PM

#

https://github.com/CompactMods/Gander still very WIP, currently tearing apart the levels to flatten that package

summer furnace Apr 23, 2024, 3:18 PM

#

oh shit it's out

#

https://tenor.com/view/caos-bob-esponja-crisis-patricio-gif-23199341

Tenor

blazing valve Apr 23, 2024, 3:25 PM

#

https://github.com/neoforged/NeoForm/actions/runs/8802821359

lean anchor Apr 23, 2024, 3:26 PM

#

welp. what's the state of the pre-release ports?

summer furnace Apr 23, 2024, 3:28 PM

#

they were far enough along to be usable for development

stiff galleon Apr 23, 2024, 3:30 PM

#

that's a sentence

lean anchor Apr 23, 2024, 3:31 PM

#

is it?

summer furnace Apr 23, 2024, 3:33 PM

#

I accidentally a word

fallen igloo Apr 23, 2024, 3:35 PM

#

We have a milestone on github

#

I will do some porting fixes and check removal deprecations later

#

If someone wants to help with the porting todos it would be appreciated

kind sable Apr 23, 2024, 3:39 PM

#

hmm
hOw Do i MaKe MoDS fOR 1.20.5?

fallen igloo Apr 23, 2024, 3:40 PM

#

kind sable hmm hOw Do i MaKe MoDS fOR 1.20.5?

Use the prerelease version published by the PR publishing workflow

kind sable Apr 23, 2024, 3:41 PM

#

https://discordapp.com/channels/313125603924639766/1095820991189487737/1232355488692441139
oh no...
1.20.6 incoming??

dry stumpBOT Apr 23, 2024, 3:41 PM

#

[Reference to](#mojira message) #mojira [➤ ](#mojira message)This ticket has just been resolved as Fixed!

bdm68

[MC-215144] A re-created "Default" world has world type of "Custom"

When re-creating a world that was created in the 21w06a snapshot, the world type cannot be changed. It is set to "Custom" and greyed out, regardless of the actual world type.

Create a new world with the "Default" world type.

Status

Resolved as Fixed <t:1713886796:R>

Fix Version

Future Update

Assignee

[Mojang] etanaratsastaja

Votes

19

Comments

6

Duplicates

1

Created

<t:1613079755:R>

summer furnace Apr 23, 2024, 3:41 PM

#

depends on how critical they think this is

#

I don't think 1.20.6 will be released right now

fallen igloo Apr 23, 2024, 3:42 PM

#

🐸 tomorrow?

summer furnace Apr 23, 2024, 3:42 PM

#

if this is the only bug, maybe in a week

spiral radish Apr 23, 2024, 3:42 PM

#

Snapshot / RC on Thursday prehaps?

summer furnace Apr 23, 2024, 3:42 PM

#

to wait for more bug reports

#

it's not a data loss issue

#

so it's not super critical to hotfix right now

lean anchor Apr 23, 2024, 3:45 PM

#

TBF it's also "re-created from a snapshot"

inner veldt Apr 23, 2024, 3:45 PM

#

Created 3 years ago
Yeah, not very critical.

lean anchor Apr 23, 2024, 3:46 PM

#

If it isn't affecting full release versions, it might wait a while.. maybe even 1.21

digital drum Apr 23, 2024, 3:49 PM

#

spiral radish <@&1067092163520909374> Sound the Alarms <https://mdcfe.dev/mc-changes?ver=1.20....

this is live now

summer furnace Apr 23, 2024, 3:58 PM

#

oh right it says 21w lol

#

I didn't even read the year

#

so it's not a 1.20.5 snapshot at all

#

it's just low-hanging fruit someone picked in the "post-release" wait

spiral radish Apr 23, 2024, 3:59 PM

#

thinkies

lean anchor Apr 23, 2024, 4:00 PM

#

I wonder what Mojang's triage/priority process looks like

#

Half curious if it's just a big ol' whiteboard with stickies on it for "filler" work

magic sierra Apr 23, 2024, 4:01 PM

#

Imagine, a snapshot tomorrow...

summer furnace Apr 23, 2024, 4:01 PM

#

doubtful, unless there's critical fixes

lean anchor Apr 23, 2024, 4:01 PM

#

kek "so it turns out we have an addiction to releasing stuff, so here's another thing"

dry stumpBOT Apr 23, 2024, 4:23 PM

#

technici4n

[Reference to](#maintenance-talk message) #maintenance-talk [➤ ](#maintenance-talk message)In any case we'll have to go on without some of the milestone changes

foggy steeple Apr 23, 2024, 4:24 PM

#

Don’t forget the tag fixes pr I have up too. Want to make sure that’s in for the release so people build against the right tags

lean anchor Apr 23, 2024, 4:31 PM

#

So, given the huge changes involved.. #modder-support-20.5 please

#

Because there's gonna be SO MANY questions

reef parcel Apr 23, 2024, 4:32 PM

#

would also make it neo-only, no more forge questions harold

summer furnace Apr 23, 2024, 4:40 PM

#

if someone asks, assume neo

#

if they are actually using forge, then you can just say "oh, I don't know then"

#

:P

elder swallow Apr 23, 2024, 4:40 PM

#

foggy steeple Don’t forget the tag fixes pr I have up too. Want to make sure that’s in for the...

I'll have a look when I get home

summer furnace Apr 23, 2024, 4:40 PM

#

making the server neo-only would just make the atmosphere less welcoming

reef parcel Apr 23, 2024, 4:43 PM

#

well yeah :p not saying make everything neo only, but the automatic assumption for a "20.5" channel would be "you're using neo". atm in 1.20 I usually ask "neo or forge" since there's around equal number of people asking for help on either

#

and one person was using fabric!

#

and then they realized they clicked the wrong server :p

lean anchor Apr 23, 2024, 4:44 PM

#

Also, changing the channel naming to be 20.5/21.0/21.1 will help with all these technical releases :P

#

There's decent changesets between every version now

summer furnace Apr 23, 2024, 4:48 PM

#

that would mean having a lot more channels

foggy steeple Apr 23, 2024, 4:48 PM

#

reef parcel and one person was using fabric!

Need help with rift code

summer furnace Apr 23, 2024, 4:48 PM

#

unless we disallow older versions in the main channels :P

foggy steeple Apr 23, 2024, 4:48 PM

#

1.20.X channel and 1.20.5 channel

#

Just due to how significantly different 1.20.5 is

reef parcel Apr 23, 2024, 4:49 PM

#

#modder-support-[1.20,1.20.5) and #modder-support-1.20.5

foggy steeple Apr 23, 2024, 4:50 PM

#

Using version range like that is gonna confuse people

reef parcel Apr 23, 2024, 4:50 PM

#

#modder-support-[1.20,1.20.4] :p

#

or even better #modder-support-1.20.X-where-1.20<=X<=1.20.4

sand heron Apr 23, 2024, 4:52 PM

#

make it regex 🤩

reef parcel Apr 23, 2024, 4:52 PM

#

the perfect solution

#

everybody can read regex

lean anchor Apr 23, 2024, 4:55 PM

#

summer furnace unless we disallow older versions in the main channels :P

Onboarding: "Are you on an older Minecraft version (2+ releases behind)?" --> Mod Development (Community)

then rename "For Mod Developers" to "Mod Development (LTS + Current MC)"

#

Anyone who isn't on a "legacy" version can then collapse/mute the category

foggy steeple Apr 23, 2024, 4:58 PM

#

reef parcel `#modder-support-[1.20,1.20.4]` \:p

#modder-support-1.20-to-1.20.4

reef parcel Apr 23, 2024, 4:59 PM

#

that's too easy to read :p

sand heron Apr 23, 2024, 4:59 PM

#

#modder-support-one-dot-twenty-dot-x-where-x-is-a-positive-integer-such-that-x-is-less-than-or-equal-to-four

stiff galleon Apr 23, 2024, 4:59 PM

#

#legacy-modder-support-gradle evilpatrick

sand heron Apr 23, 2024, 5:00 PM

#

just mix every channel into a single one and watch the chaos descend

#

then give everyone admin

stiff galleon Apr 23, 2024, 5:09 PM

#

sand heron just mix every channel into a single one and watch the chaos descend

that briefly happened to All the Mods after their server got hacked

lean anchor Apr 23, 2024, 5:19 PM

#

So, you could go the fun route and make all of modder support a forum.. with each forum post a MC version

sand heron Apr 23, 2024, 5:46 PM

#

Make every message a new forum post

median wasp Apr 23, 2024, 6:00 PM

#

Will 20.5.1-beta release today?

summer furnace Apr 23, 2024, 6:01 PM

#

maybe, for varying definitions of "today"

fallen igloo Apr 23, 2024, 6:03 PM

#

median wasp Will 20.5.1-beta release today?

Not within the next few hours

#

#builds message is this the right one for doing the update?

dry stumpBOT Apr 23, 2024, 6:04 PM

#

[Jump to referenced message](#builds message) in #builds

NeoForm

Build Successful

Version

1.20.5-20240423.152201

Build Branch

main

Minecraft Version

1.20.5

blazing valve Apr 23, 2024, 6:06 PM

#

Oh since it passed, it actually pushed one?

#

Interesting

#

So I'd say you can go with that

fallen igloo Apr 23, 2024, 6:19 PM

#

Eh doesn't the other branch contain fixed missing lambda bodies?

blazing valve Apr 23, 2024, 6:19 PM

#

I was wondering too, but it looks like the update branch copied over the content from 1.20.5-dev

#

#

https://github.com/neoforged/NeoForm/actions/runs/8802821359/job/24159486318

#

"update branch". I meant update action

fallen igloo Apr 23, 2024, 6:21 PM

#

Hmmm OK will do when I get home (if you want you can run the workflow)

blazing valve Apr 23, 2024, 6:22 PM

#

Done

#

I am trying to iron out the FML refactor

blazing valve Apr 23, 2024, 6:40 PM

#

Hm. Okay?

* What went wrong:
A problem occurred evaluating root project 'actions'.
> Could not find method getTagOffsetVersion() for arguments [] on extension 'gradleutils' of type net.neoforged.gradleutils.GradleUtilsExtension.

fallen igloo Apr 23, 2024, 6:45 PM

#

@elder swallow @slow prism @restive raft who of you is responsible for that

elder swallow Apr 23, 2024, 6:45 PM

#

No idea

#

Now fix it:P

restive raft Apr 23, 2024, 6:47 PM

#

thonk

#

where is this

#

explain

blazing valve Apr 23, 2024, 6:48 PM

#

Kits

restive raft Apr 23, 2024, 6:49 PM

#

which branch of Kits

blazing valve Apr 23, 2024, 6:49 PM

#

Hm

#

I think this is my fault, I'll look into it

fallen igloo Apr 23, 2024, 6:50 PM

#

elder swallow Now fix it:P

I'm not at home yet

blazing valve Apr 23, 2024, 6:50 PM

#

Is there no way to actually see the params used to launch the job?

#

I did this (still had these in auto fill) and it checked out 1.20.2 on kits. Hm

#

restive raft Apr 23, 2024, 6:51 PM

#

looks like this commit https://github.com/neoforged/Kits/commit/916bfcbc540abf1a1b1ba4162905a28aa754894d
changed the project version to use gradleutils.getTagOffsetVersion

#

and I can't fathom why

#

anyway, user error: use gradleutils.version, or gradleutils.version.toString() if you must
getTagOffsetVersion on the extension was yeeted on the outset of GradleUtils 3

#

as to which user did it, I'm not going hunting for kek

blazing valve Apr 23, 2024, 6:54 PM

#

Oh you mean it's no longer going into the non-pre-release branch of that if heh

elder swallow Apr 23, 2024, 6:54 PM

#

Why tf would I have done that thonk

blazing valve Apr 23, 2024, 6:55 PM

#

copy pasta?

restive raft Apr 23, 2024, 6:55 PM

#

it looks to be a squash commit

blazing valve Apr 23, 2024, 6:55 PM

#

Tech did the initial versioning for snapshots I think

#

https://github.com/neoforged/NeoForge/pull/837

elder swallow Apr 23, 2024, 6:57 PM

#

https://github.com/neoforged/Kits/pull/5/files

#

Weird

blazing valve Apr 23, 2024, 7:20 PM

#

rerunning kits

elder swallow Apr 23, 2024, 7:20 PM

#

I deleted the branch

#

👍

blazing valve Apr 23, 2024, 7:20 PM

#

Did it even create one?

#

I thought it didnt get to the commit step

elder swallow Apr 23, 2024, 7:20 PM

#

well it did push stuff

#

see #neoforge-private

blazing valve Apr 23, 2024, 7:21 PM

#

huh

elder swallow Apr 23, 2024, 7:23 PM

#

it commits the mc sources for the previous version

#

I think we'll just merge the two non-draft PRs in the initial release milestone and go for the public release

#

have you started the kits run yet?

blazing valve Apr 23, 2024, 7:25 PM

#

i retried the previous one

elder swallow Apr 23, 2024, 7:25 PM

#

smart move, I was gonna do the same

#

ok it's having fun with gradle

blazing valve Apr 23, 2024, 7:33 PM

#

Succeeded

elder swallow Apr 23, 2024, 7:45 PM

#

nice

#

no rejects or patch updates then?

blazing valve Apr 23, 2024, 7:48 PM

#

One update to mappedregistry

elder swallow Apr 23, 2024, 7:48 PM

#

that didn't get committed?

#

ah yeah no I'm stupid

blazing valve Apr 23, 2024, 7:49 PM

#

pushed the updated 1.20.5 branch, making squashed now

elder swallow Apr 23, 2024, 7:49 PM

#

ok good

blazing valve Apr 23, 2024, 7:51 PM

#

Should I update neoforge_snapshot_next_stable=20.6?

elder swallow Apr 23, 2024, 7:51 PM

#

might be 21.0 so probably not

#

we'll do it in the next snapshot fun™️

blazing valve Apr 23, 2024, 7:51 PM

#

you never know beforehand, so 20.6 😛

#

It'd be wrong to keep the current line with 20.5 in there

elder swallow Apr 23, 2024, 7:51 PM

#

well it doesn't matter

blazing valve Apr 23, 2024, 7:52 PM

#

I think it does 😄

elder swallow Apr 23, 2024, 7:52 PM

#

it only matters on snapshot versions? 🤨

blazing valve Apr 23, 2024, 7:52 PM

#

After snapshot is before the next snapshot 😄

elder swallow Apr 23, 2024, 7:52 PM

#

it's pointless but feel free to do it 😛

blazing valve Apr 23, 2024, 7:53 PM

#

https://github.com/neoforged/NeoForge/tree/port/1.20.5

elder swallow Apr 23, 2024, 7:54 PM

#

ok I'll merge in a few things and do the release

#

wat

fallen igloo Apr 23, 2024, 7:58 PM

#

tech stop rushing things give the PR authors at least 24 hours

elder swallow Apr 23, 2024, 7:58 PM

#

?

#

breaking changes can come later

#

as for the 3 PRs I just merged, they've been open for more than 24 hours 😛

fallen igloo Apr 23, 2024, 7:59 PM

#

stuff like the events and porting todos are not normal breaking changes

elder swallow Apr 23, 2024, 8:00 PM

#

the event result is the more annoying of the two but it should not prevent people from already having fun with all the stream codec and component changes

#

the porting todos can be done over time, and even broken up into different PRs if necessary

fallen igloo Apr 23, 2024, 8:01 PM

#

elder swallow the event result is the more annoying of the two but it should not prevent peopl...

they can and should still use the pr published alpha version until we are actually ready for beta

true jacinth Apr 23, 2024, 8:01 PM

#

Schurli where did you get this weird definition of what beta means

#

if the release is "available" in any capacity it can be promoted to beta

#

beta does not guarantee any additional semantics vs alpha, they are both BC window

fallen igloo Apr 23, 2024, 8:03 PM

#

alpha is what previously happened in the private repo and beta is everything in the BC period after

#

and porting todos and refactors to core systems like events happened on the private repo previously

summer furnace Apr 23, 2024, 8:03 PM

#

alpha is public commits built from the porting branch, beta is anything after it has been put in the main branch

elder swallow Apr 23, 2024, 8:03 PM

#

there have been many changes such as the registry rework or caps that have happened on the public repo

summer furnace Apr 23, 2024, 8:04 PM

#

so whenever you are ready to move porting to 1.20.x, that becomes beta, if we want to be consistent

fallen igloo Apr 23, 2024, 8:04 PM

#

elder swallow there have been many changes such as the registry rework or caps that have happe...

because those were long running PRs that got ported

elder swallow Apr 23, 2024, 8:04 PM

#

would it have been better to have them already? yes; is it worth delaying the update for everyone? no

true jacinth Apr 23, 2024, 8:04 PM

#

major refactors to events should have never happened on the private repo, lol

elder swallow Apr 23, 2024, 8:04 PM

#

that too

fallen igloo Apr 23, 2024, 8:06 PM

#

true jacinth major refactors to events should have never happened on the private repo, lol

stuff like event bus bumps were always done either before or right after the squash

elder swallow Apr 23, 2024, 8:06 PM

#

the only thing this shows is that we are not necessarily consistent

#

I would see it as: the things that can be done before the first release are done before

#

the things that cannot be done come later 🤷

fallen igloo Apr 23, 2024, 8:10 PM

#

ffs I just came home and didn't even have time since the release to do anything just stop stressing

blazing valve Apr 23, 2024, 8:10 PM

#

We have a working version, no?

elder swallow Apr 23, 2024, 8:10 PM

#

the time to do things was before today 😛

fallen igloo Apr 23, 2024, 8:11 PM

#

I want the forRemoval deprecations and at least some porting todos done in the first beta

elder swallow Apr 23, 2024, 8:11 PM

#

IMO: too late, they will come when they are ready

#

better than rushing things now

#

and better than delaying the release for a few days

fallen igloo Apr 23, 2024, 8:12 PM

#

tech we literally only had 1 time that we released the day of the mc release so chill we don't have to release today

elder swallow Apr 23, 2024, 8:12 PM

#

just do your stuff and it will be merged when it's ready

#

release the day of the mc release is the standard not the exception

fallen igloo Apr 23, 2024, 8:13 PM

#

elder swallow release the day of the mc release is the standard not the exception

no it NEVER was

true jacinth Apr 23, 2024, 8:13 PM

#

There's no effective difference against holding beta. It's already available via alpha and the changes will still be made

elder swallow Apr 23, 2024, 8:13 PM

#

more people will use beta than alpha

#

tbh we just want more people to find issues ASAP

fallen igloo Apr 23, 2024, 8:13 PM

#

alpha will not be released via installers for users beta will

elder swallow Apr 23, 2024, 8:14 PM

#

it's a beta for a reason

fallen igloo Apr 23, 2024, 8:15 PM

#

elder swallow it's a beta for a reason

since when do users care about the beta label?

true jacinth Apr 23, 2024, 8:15 PM

#

alpha as a classifier should be reserved for snapshot/pre/rc mc releases, beta for actual mc releases
both are BC-window and identical to a user perspective. We have a beta now, so we can promote it to that

misty crow Apr 23, 2024, 8:16 PM

#

fallen igloo alpha will not be released via installers for users beta will

The first few days are completely irrelevant for the average user because there are no mods yet, so that's a non-issue for the most part. And while the PR publishing is nice and convenient, it's still a barrier compared to a released version, so people won't bother unless they have a good reason to

true jacinth Apr 23, 2024, 8:16 PM

#

The difference from prior is that alpha was unreachable to the public

fallen igloo Apr 23, 2024, 8:17 PM

#

well now alpha is only reachable for modders and beta for everyone

elder swallow Apr 23, 2024, 8:18 PM

#

there's only you against the release and 3+ maintainers in favor of it so let's do it

blazing valve Apr 23, 2024, 8:19 PM

#

wait we do not have PR installers? 🤔

fallen igloo Apr 23, 2024, 8:19 PM

#

blazing valve wait we do not have PR installers? 🤔

we have them on the maven but not on the website

#

that was already possible for some time

blazing valve Apr 23, 2024, 8:21 PM

#

If we had any closer definition of what beta means, it'd be different

#

But given the massive changes that landed in beta in 20.4

#

I really don't see why we should hold a release for changes of the same significance?

boreal flint Apr 23, 2024, 8:22 PM

#

why would someone be against release at this point?

fallen igloo Apr 23, 2024, 8:22 PM

#

we do via the PR publishing on the porting PR

boreal flint Apr 23, 2024, 8:22 PM

#

is it not ready?

misty crow Apr 23, 2024, 8:22 PM

#

The port was already available through PR publishing for a bit. But as I mentioned above, that's an additional barrier compared to a release so most people wouldn't bother using it

blazing valve Apr 23, 2024, 8:23 PM

#

We might wanna revisit the alpha-beta-stable progression. OTOH the transition of alpha->beta is such a muddy thing

fallen igloo Apr 23, 2024, 8:23 PM

#

boreal flint why would someone be against release at this point?

because a few things that are normally part of the porting workflow were not done yet

boreal flint Apr 23, 2024, 8:23 PM

#

such as?

magic sierra Apr 23, 2024, 8:23 PM

#

#neoforge wtf

true jacinth Apr 23, 2024, 8:23 PM

#

blazing valve We might wanna revisit the alpha-beta-stable progression. OTOH the transition of...

Did we even formally define it?

blazing valve Apr 23, 2024, 8:23 PM

#

I wasn't here, so no idea? 😄

elder swallow Apr 23, 2024, 8:24 PM

#

EPIC FAIL

magic sierra Apr 23, 2024, 8:24 PM

#

Yeah

elder swallow Apr 23, 2024, 8:24 PM

#

the tag didn't go through

true jacinth Apr 23, 2024, 8:24 PM

#

Deleting the target also broke all of those prs rip

#

I can go reset them to 1.20.x and reopen I guess

blazing valve Apr 23, 2024, 8:24 PM

#

Oh ffs Tech

true jacinth Apr 23, 2024, 8:25 PM

#

Actually can I even do that thonk

elder swallow Apr 23, 2024, 8:25 PM

#

that's hilarious actually 😛

blazing valve Apr 23, 2024, 8:25 PM

#

That one's gona haunt ya

#

Didn't we want to also branch out 1.20.4?

#

blergbelbrglgr

elder swallow Apr 23, 2024, 8:25 PM

#

well it sucks

#

@wooden tendon @slow prism can you please lift the branch protection rules on the repo?

blazing valve Apr 23, 2024, 8:26 PM

#

Well. No release soon, Techs gonna take all day fixing this mess 😄

elder swallow Apr 23, 2024, 8:26 PM

#

it takes 2 seconds but I don't have the perms to do it

true jacinth Apr 23, 2024, 8:26 PM

#

It doesn't look like (at least from the web UI) that I can retarget a closed PR against the new branch

#

we would have to re-branch-out port/1.20.5 and reopen, then retarget

elder swallow Apr 23, 2024, 8:26 PM

#

well it's annoying that they are closed, but it would suck to merge them in the port branch thonk

#

we could have retargeted before merging?

blazing valve Apr 23, 2024, 8:27 PM

#

Yes apparently

true jacinth Apr 23, 2024, 8:27 PM

#

Well we can retarget whenever

blazing valve Apr 23, 2024, 8:27 PM

#

https://tenor.com/view/learning-learnding-funny-the-simpsons-dumb-gif-5270072

Tenor

education is key

▶ Play video

elder swallow Apr 23, 2024, 8:27 PM

#

elder swallow <@304594425286361088> <@561254664750891009> can you please lift the branch prote...

or maybe @austere canopy or @cloud raven if you are there

true jacinth Apr 23, 2024, 8:27 PM

#

the issue is that I can't move the target while its closed

#

(which might be an oversight on github's part, idk)

misty crow Apr 23, 2024, 8:27 PM

#

true jacinth we would have to re-branch-out `port/1.20.5` and reopen, then retarget

You can restore the branch on the 20.5 port PR, re-open, re-target and delete the branch again

restive raft Apr 23, 2024, 8:27 PM

#

hello

elder swallow Apr 23, 2024, 8:27 PM

#

hi sci

restive raft Apr 23, 2024, 8:28 PM

#

what seems to be the problem, officers

elder swallow Apr 23, 2024, 8:28 PM

#

the branch protection rules

#

can you temporarily disable them so I set the branches and tags correctly for the 1.20.5 release?

blazing valve Apr 23, 2024, 8:28 PM

#

define "correctly"

elder swallow Apr 23, 2024, 8:28 PM

#

I need to repush the 20.5 tag and also create the 1.20.4 branch

blazing valve Apr 23, 2024, 8:29 PM

#

very well

true jacinth Apr 23, 2024, 8:29 PM

#

We also need to remake port/1.20.5 off of 1.20.x so we can unfuck the prs

restive raft Apr 23, 2024, 8:30 PM

#

to be clear, temporarily disabling our three branch protection rulesets -- deletion/force-push, status checks, and PRs?

elder swallow Apr 23, 2024, 8:30 PM

#

yes

blazing valve Apr 23, 2024, 8:30 PM

#

@true jacinth done https://github.com/neoforged/NeoForge/tree/port/1.20.5

true jacinth Apr 23, 2024, 8:30 PM

#

kk, let me go fix the closed prs

fallen igloo Apr 23, 2024, 8:31 PM

#

restive raft to be clear, temporarily disabling our three branch protection rulesets -- delet...

we definitely need to have something better than needing to lift protection rules

restive raft Apr 23, 2024, 8:31 PM

#

@elder swallow rules disabled -- go ham

blazing valve Apr 23, 2024, 8:31 PM

#

Yeah, agreed

restive raft Apr 23, 2024, 8:31 PM

#

ping me once finished

blazing valve Apr 23, 2024, 8:31 PM

#

This needs some action

elder swallow Apr 23, 2024, 8:32 PM

#

thank you good sir

true jacinth Apr 23, 2024, 8:32 PM

#

oh dear I have to rebase things against 1.20.x

#

screm

#

I think they should apply cleanly

#

but scREM

elder swallow Apr 23, 2024, 8:32 PM

#

yeah they should apply cleanly, it's just a fast forward merge

restive raft Apr 23, 2024, 8:32 PM

#

someone write up the concrete list of things that happen that require lifting branch protections, so we can work on making automations and documenting these things for the future™️

elder swallow Apr 23, 2024, 8:33 PM

#

omg github did a rebase

#

dead_tater

blazing valve Apr 23, 2024, 8:33 PM

#

No, you did 😄

restive raft Apr 23, 2024, 8:33 PM

#

also, as a fun side-note: if the 1.20.5 port PR were merged into the default branch, all PRs targetting that PR branch would have been changed to target the default branch

blazing valve Apr 23, 2024, 8:33 PM

#

Hah, Tech's the grand rebaser

elder swallow Apr 23, 2024, 8:33 PM

#

that's unexpected...

restive raft Apr 23, 2024, 8:34 PM

#

squirr

elder swallow Apr 23, 2024, 8:34 PM

#

now this explains why the tag vanished

#

well ok fuck me

true jacinth Apr 23, 2024, 8:34 PM

#

Well we're stuck with that change for now

#

is the status of the branch fine beyond the history mess?

blazing valve Apr 23, 2024, 8:34 PM

#

If no release or action was built, he can in theory forcepush it

elder swallow Apr 23, 2024, 8:35 PM

#

should I though?

#

it's probably for the best idk

shut wraith Apr 23, 2024, 8:35 PM

#

Oh god that was a rebase. Updating PRs is gonna suck

blazing valve Apr 23, 2024, 8:35 PM

#

We had a history, we agreed to not fuck that history up 😅

elder swallow Apr 23, 2024, 8:35 PM

#

ok fine I'll force push

#

fuck me 10 times

restive raft Apr 23, 2024, 8:35 PM

#

what about stabs instead stabolb

true jacinth Apr 23, 2024, 8:35 PM

#

You can either un-rebase and do a merge or I have to fix all the prs; though the fix is "clean" in theory its just some manual labor

blazing valve Apr 23, 2024, 8:36 PM

#

did anything land on maven is my thought... if it didn't, he can probably force push the last tip of port/1.20.5

shut wraith Apr 23, 2024, 8:36 PM

#

Fix isn't too bad... lemme test on my own PR and see how much is sucks

digital drum Apr 23, 2024, 8:36 PM

#

tag delete, tag create, tag delete, tag create so far in #neoforge

elder swallow Apr 23, 2024, 8:36 PM

#

blazing valve did anything land on maven is my thought... if it didn't, he can probably force ...

I canceled the the build

true jacinth Apr 23, 2024, 8:37 PM

#

shut wraith Fix isn't _too_ bad... lemme test on my own PR and see how much is sucks

The rebase was immediate with no conflicts for the tick events, it should cleanly apply to all of them

#

but if we're undoing the rebase i would hold on that

#

since now I have to re-re-rebase the tick events LUL

blazing valve Apr 23, 2024, 8:37 PM

#

You'll live 😛

elder swallow Apr 23, 2024, 8:37 PM

#

ok I fixed the history

blazing valve Apr 23, 2024, 8:37 PM

#

But aaaah yes. Learning and improving process from mistakes

#

I am so happy 😄

shut wraith Apr 23, 2024, 8:38 PM

#

true jacinth The rebase was immediate with no conflicts for the tick events, it should cleanl...

Cool, wasn't sure if that would still work if I'd merged the port/1.20.5 branch into my PR branch during PR development but I'll hold off for now

restive raft Apr 23, 2024, 8:38 PM

#

once it's all patched up and neat, poke me so I can reenable our rulesets again

true jacinth Apr 23, 2024, 8:38 PM

#

With the history fixed you should be good to just flip the target on the PR and nothing else

elder swallow Apr 23, 2024, 8:38 PM

#

ok thanks a lot sci

true jacinth Apr 23, 2024, 8:38 PM

#

I can do that myself

blazing valve Apr 23, 2024, 8:38 PM

#

@elder swallow you fixed 1.20.x, yes?

elder swallow Apr 23, 2024, 8:38 PM

#

just give it a few hours in case something else needs fixing

elder swallow Apr 23, 2024, 8:38 PM

#

blazing valve <@298082405745426433> you fixed 1.20.x, yes?

yes

#

1.20.4 is created as well

blazing valve Apr 23, 2024, 8:38 PM

#

If that is the case, I will force-push that HEAD to port/1.20.5 now to fix the PRs

#

Or rather, I really don't have to, TBH

#

since they have to be retargeted anyway

analog ledge Apr 23, 2024, 8:38 PM

#

git blame-someone-else

elder swallow Apr 23, 2024, 8:38 PM

#

meh you can all blame me 😄

#

I'll take it

blazing valve Apr 23, 2024, 8:39 PM

#

Ah I'll do it anyway

shut wraith Apr 23, 2024, 8:39 PM

#

Erm... my PR is funky now

#

Ah wait

#

Thanks Shadows

true jacinth Apr 23, 2024, 8:39 PM

#

it should be fixed™️

blazing valve Apr 23, 2024, 8:40 PM

#

916bfcbc5..feee2a226 port/1.20.5 -> port/1.20.5

true jacinth Apr 23, 2024, 8:40 PM

#

Its just really wonky since port/1.20.5 is now the "broken" history

blazing valve Apr 23, 2024, 8:40 PM

#

Not anymore

#

Sadly no way to search for PRs that target a branch

#

Oh wait, you can search for the target branch

#

https://github.com/neoforged/NeoForge/pulls?q=is%3Apr+base%3Aport%2F1.20.5+

true jacinth Apr 23, 2024, 8:42 PM

#

Well we know all the PRs targetting port/1.20.5

#

they're listed nicely in #neoforge bc they all got closed

blazing valve Apr 23, 2024, 8:42 PM

#

Ah true

true jacinth Apr 23, 2024, 8:42 PM

#

they should all be fixed and retargetted

#

crisis averted™️

blazing valve Apr 23, 2024, 8:43 PM

#

We might really wanna consider just starting 1.20.5 earlier next time and not calling stuff port/ or whatever? IDK 😄

#

And just avoid the branch Rochade

#

I should clarify, starting a branch named 1.20.5

elder swallow Apr 23, 2024, 8:43 PM

#

I tried to bypass the branch protection with a rebase-merge, that was the big issue

digital drum Apr 23, 2024, 8:44 PM

#

Could someone be bothered to fix this? This was a mistake on my end

true jacinth Apr 23, 2024, 8:44 PM

#

I think port/nextmcversion is fine, the spaghetti is that we had a port/ for each snapshot which now needs to be cleaned up

blazing valve Apr 23, 2024, 8:44 PM

#

There is just no way for you without disabling anything to actually get the branch as-is moved into place of 1.20.x

elder swallow Apr 23, 2024, 8:44 PM

#

I think that a standard merge would have worked

#

because it would have been a fast-forward and the tag was there on the port/1.20.5 branch

blazing valve Apr 23, 2024, 8:44 PM

#

yeah but if we had named it 1.20.5 to begin with, it would just have been a switch in default branch for the rep

shut wraith Apr 23, 2024, 8:44 PM

#

blazing valve There is just no way for you without disabling anything to actually get the bran...

Rename 1.20.x to 1.20.4, rename port/1.20.5 to 1.20.x? But that might run afoul of protectin rules, no clue

blazing valve Apr 23, 2024, 8:45 PM

#

Ofcourse it would, there is no real "rename"

#

you are pushing stuff around

#

We'd need an action for that

elder swallow Apr 23, 2024, 8:45 PM

#

blazing valve yeah but if we had named it `1.20.5` to begin with, it would just have been a sw...

sure but then we'd have been publishing the 1.20.5 alphas to our maven

shut wraith Apr 23, 2024, 8:46 PM

#

blazing valve Ofcourse it would, there is no real "rename"

I mean yeah, the "rename" is just a fancy force push that the github GUI has a nice tool for, yeah. But presumably something an action could do, good point

blazing valve Apr 23, 2024, 8:46 PM

#

Well that's the other question... how do we determine that. Could just be a prop that makes it alphas and pushes it to /snapshots

digital drum Apr 23, 2024, 8:49 PM

#

release seems to be done

#

Live on the maven too

elder swallow Apr 23, 2024, 8:50 PM

#

cool

#

then let's get the blog post out too

digital drum Apr 23, 2024, 8:51 PM

#

elder swallow then let's get the blog post out too

IPayloadRegistrar -> PayloadRegistrar pls

elder swallow Apr 23, 2024, 8:51 PM

#

already done, see #side-projects

blazing valve Apr 23, 2024, 8:52 PM

#

Tell me when (or if even lol) you stopped sweating from the grand rebase, Tech 😄

#

I gotta bounce something off of ya for FML

restive raft Apr 23, 2024, 8:54 PM

#

it's a rite of passage for anyone who does the first push for an MC release to the main repo, that one messes something up (and either claws it back or lives with it) kek

blazing valve Apr 23, 2024, 8:54 PM

#

Just glad it wasn't me lol

digital drum Apr 23, 2024, 8:54 PM

#

https://github.com/orgs/neoforged/projects/3/views/1

GitHub

1.20.5 TODO list • neoforged

Things to do during the 1.20.5 port

#

what was this even for ^

elder swallow Apr 23, 2024, 8:56 PM

#

blazing valve Tell me when (or if even lol) you stopped sweating from the grand rebase, Tech �...

thanks to our good sir sci I didn't have to sweat for long

#

however give me a break anyway 😄

restive raft Apr 23, 2024, 8:56 PM

#

thankfully I'm still awake at this hour kek

elder swallow Apr 23, 2024, 8:56 PM

#

you're the only org owner I didn't ping lol

fallen igloo Apr 23, 2024, 8:56 PM

#

I removed most of the deprecated for removal methods that had a since < 1.20.5 (the only 1.20.4 I left was onArmorTick)

restive raft Apr 23, 2024, 8:57 PM

#

kek

digital drum Apr 23, 2024, 8:57 PM

#

tech, whens the blog post out?

restive raft Apr 23, 2024, 8:58 PM

#

elder swallow you're the only org owner I didn't ping lol

well, me and Shrimp, who is apparently still retains ownership from his tenure as Steering

teal epoch Apr 23, 2024, 8:59 PM

#

gg on the release guys

restive raft Apr 23, 2024, 8:59 PM

#

now, the churn begins

elder swallow Apr 23, 2024, 8:59 PM

#

digital drum tech, whens the blog post out?

give me a sec lol

digital drum Apr 23, 2024, 8:59 PM

#

srryy

restive raft Apr 23, 2024, 9:00 PM

#

as all the mod developers start hopping on the new release train, and we start seeing bug reports

digital drum Apr 23, 2024, 9:00 PM

#

can someone from here merge the parchment mappings for 20.5?

restive raft Apr 23, 2024, 9:00 PM

#

that PR will take a smol while

#

just a wee bit

elder swallow Apr 23, 2024, 9:00 PM

#

someone should update the MDK for neoforge.mods.toml ASAP 😄

digital drum Apr 23, 2024, 9:01 PM

#

elder swallow someone should update the MDK for neoforge.mods.toml ASAP 😄

i might just

misty crow Apr 23, 2024, 9:01 PM

#

restive raft as all the mod developers start hopping on the new release train, and we start s...

Meanwhile I'm sitting here playing around with this thing in an attempt to make something vaguely similar myself kek

digital drum Apr 23, 2024, 9:01 PM

#

nvm take that back

blazing valve Apr 23, 2024, 9:01 PM

#

elder swallow someone should update the MDK for neoforge.mods.toml ASAP 😄

I am partially redesigning that damn locator stuff again since that fell through our cracks

#

Locators can't specify if a candidate is actually high or low confidence

fallen igloo Apr 23, 2024, 9:01 PM

#

elder swallow someone should update the MDK for neoforge.mods.toml ASAP 😄

that should have been ready before release IMO

elder swallow Apr 23, 2024, 9:02 PM

#

one day I'll go live in a country called Theory; because in Theory everything is always ready right on time

restive raft Apr 23, 2024, 9:03 PM

#

kek

dense mica Apr 23, 2024, 9:03 PM

#

just become a wizard, a wizard is never late ^.-

elder swallow Apr 23, 2024, 9:03 PM

#

nor early for that matter

blazing valve Apr 23, 2024, 9:04 PM

#

Okay, the PacketDistributor changes make it actually nice to use

#

time to ditch my own wrapper

fallen igloo Apr 23, 2024, 9:04 PM

#

fallen igloo I removed most of the deprecated for removal methods that had a since < 1.20.5 (...

what should I do with the methods that have a since of 1.20.5? (and why did we mark onArmorTick as for removal)

fallen nymph Apr 23, 2024, 9:04 PM

#

restive raft as all the mod developers start hopping on the new release train, and we start s...

Already had my port ready 🙂 (One of 100+)

restive raft Apr 23, 2024, 9:05 PM

#

IT BEGINS

fallen nymph Apr 23, 2024, 9:05 PM

#

elder swallow one day I'll go live in a country called Theory; because in Theory everything is...

But hey... That's just a Theory

elder swallow Apr 23, 2024, 9:05 PM

#

fallen igloo what should I do with the methods that have a since of 1.20.5? (and why did we m...

keep the 1.20.5 methods, I left them to help modders migrate

vale holly Apr 23, 2024, 9:05 PM

#

CraftPresence is also ready, except for unimined likely being broken since it threw checksum errors

blazing valve Apr 23, 2024, 9:05 PM

#

I am ready to go for 1.20.5 with AE2, but can't release due to the damn shadow plugin being borked for J21

#

I might try to bump asm manually

elder swallow Apr 23, 2024, 9:05 PM

#

onArmorTick is debatable - ask shadows 😄

fallen nymph Apr 23, 2024, 9:06 PM

#

restive raft **IT BEGINS**

It depends if CurseForgeGradle plays nice with Java 21 or not

#

I'm not hand uploading jars again... NOPERS

#

POGGIES IT WORKED

summer furnace Apr 23, 2024, 9:08 PM

#

misty crow Meanwhile I'm sitting here playing around with this thing in an attempt to make ...

fun

fallen nymph Apr 23, 2024, 9:09 PM

#

Thonk What do I port first

fallen igloo Apr 23, 2024, 9:09 PM

#

ok which of the porting todos do we want to also have in this pr (if none pls review and merge tech) https://github.com/neoforged/NeoForge/pull/820

summer furnace Apr 23, 2024, 9:10 PM

#

something small that makes use of itemstack components

#

for me, that's Packing Tape :P

#

we should probably move the offtopic away from here though

#

this is not #general

restive raft Apr 23, 2024, 9:11 PM

#

at what point should we close down this thread and move dev. discussion to #neoforge-github

elder swallow Apr 23, 2024, 9:11 PM

#

do it now it's a good time

summer furnace Apr 23, 2024, 9:11 PM

#

I would say at the point the beta became available

#

which is some minutes ago

#

to be reopened if a snapshot appears

blazing valve Apr 23, 2024, 9:12 PM

#

It was a fun time 😄

fallen nymph Apr 23, 2024, 9:13 PM

#

restive raft **IT BEGINS**

https://tenor.com/byhLM.gif

Tenor

restive raft Apr 23, 2024, 9:14 PM

#

aight folks, it's time to move discussions on 1.20.5 to #neoforge-github now that 20.5.0-beta is out

if this thread needs reopening, poke one of our Team Members

spiral radish Apr 26, 2024, 1:04 PM

#

<@&1067092163520909374> 1.20.6 RC1
https://www.minecraft.net/en-us/article/minecraft-1-20-6-release-candidate-1
https://mdcfe.dev/mc-changes?ver=1.20.6-rc1
https://github.com/neoforged/Snowman/commit/bd9ef3c1fb2614500070747edd89e64f208dac97

(Reopening this Thread since it's a hotfix)

kind sable Apr 26, 2024, 1:04 PM

#

(One day I will be the one makign the thread for the update... XD)

solid lake Apr 26, 2024, 1:06 PM

#

I'm sorry is 1.20.6 releasing for literally 1-3 bugs?

last briar Apr 26, 2024, 1:07 PM

#

Zam big content update

#

Just like.5

solid lake Apr 26, 2024, 1:07 PM

#

ok no .5 was actually big technical wise

#

they added all the breaking changes from 1.21

spiral radish Apr 26, 2024, 1:07 PM

#

solid lake I'm sorry is 1.20.6 releasing for literally 1-3 bugs?

Yes, because one of them caused data loss

clear bane Apr 26, 2024, 1:07 PM

#

solid lake I'm sorry is 1.20.6 releasing for literally 1-3 bugs?

hot fixes, aka bugs that have to be fixed

plucky brook Apr 26, 2024, 1:07 PM

#

"a few critical issues", lists one issue

clear bane Apr 26, 2024, 1:08 PM

#

I love breaking releases harold

spiral radish Apr 26, 2024, 1:08 PM

#

plucky brook "a few critical issues", lists one issue

They've done a few other fixes related to data

wild pine Apr 26, 2024, 1:09 PM

#

thats a nice little utility thats been added to BlockEntity

 @Nullable
    public static Component parseCustomNameSafe(String $$0, HolderLookup.Provider $$1) {
        try {
            return Component.Serializer.fromJson($$0, $$1);
        } catch (Exception var3) {
            LOGGER.warn("Failed to parse custom name from string '{}', discarding", $$0, var3);
            return null;
        }
    }

plucky brook Apr 26, 2024, 1:09 PM

#

plucky brook "a few critical issues", lists one issue

might be secret issue too tho

spiral radish Apr 26, 2024, 1:09 PM

#

CustomNames for Containers, now call a parseCustomNameSafe quacksnipe

plucky brook Apr 26, 2024, 1:09 PM

#

spiral radish They've done a few other fixes related to data

A fair enough, if those didn't have reports

spiral radish Apr 26, 2024, 1:10 PM

#

They also made a change to CustomData to add rollback on failure

boreal flint Apr 26, 2024, 1:13 PM

#

psh this channel is old news

#

https://www.minecraft.net/en-us/article/minecraft-1-20-6-release-candidate-1

#

1.20.6 is where it's at

spiral radish Apr 26, 2024, 1:16 PM

#

1.20.5/6 Snapshots

boreal flint Apr 26, 2024, 1:24 PM

#

crisis averted

magic pivot Apr 26, 2024, 1:45 PM

#

Mini primer time: https://gist.github.com/ChampionAsh5357/53b04132e292aa12638d339abfabf955#minecraft-1205---1206-mod-mini-primer

#

Literally the method Apex mentioned is the only real change

blazing valve Apr 26, 2024, 11:05 PM

#

okay the 1.20.5 loading screen in the launcher rocks

summer furnace Apr 26, 2024, 11:06 PM

#

it is nice that the launcher opens quickly and shows a loading animation

blazing valve Apr 26, 2024, 11:07 PM

#

I just love the visual 😄

#

last briar Apr 27, 2024, 12:18 AM

#

a fox should be chasing it

naive hound Apr 28, 2024, 12:07 PM

#

I noticed with Neo 1.20.5 when you break clay pots, you get the whole pot, but when i play pure vanilla i breaks into clay bricks and sherds (if present). Before I make a bug report, is this intended?

restive raft Apr 28, 2024, 12:08 PM

#

that sounds unintended

elder swallow Apr 28, 2024, 12:08 PM

#

Behavior changes are usually not intended 😄

naive hound Apr 28, 2024, 12:09 PM

#

well yes, lol. I was just trying to figure out if it was a Neo bug or a vanilla bug so i put the report in the correct place.

fallen igloo Apr 28, 2024, 12:09 PM

#

did you use a tool or your hand

naive hound Apr 28, 2024, 12:09 PM

#

sword in all cases

#

I was testing trial chambers in both versions

fallen igloo Apr 28, 2024, 12:09 PM

#

hmm could be a tool action patch

naive hound Apr 28, 2024, 12:10 PM

#

let me switch back to neo and see if i get different behavior with diffent tools

#

okay, hands, pickaxe, another pot, and sword all break the pots instantly and drop the whole pot

#

what's another block that breaks into things instead of the whole thing?

#

bonus if it varies by tool

#

Things tried that dropped the same thing every time (not sure if they are supposed to)

amethyst clusters (always dropped amethyst shards)
campfires (always dropped charcoal)
I broke each with itself, bare hand, sword, and pickaxe (and axe for the campfire)

fallen igloo Apr 28, 2024, 12:49 PM

#

campfire and amethyst cluster is silktouch so that is expected

magic sierra Apr 28, 2024, 12:50 PM

#

It's weird, because the behavior when you break a cobweb with shears is correct.

foggy steeple Apr 28, 2024, 12:57 PM

#

naive hound I noticed with Neo 1.20.5 when you break clay pots, you get the whole pot, but w...

What does the loot table json show

#

This testing in game doesn’t really mean much since the loot table is what should say exactly what is intended. (Unless there’s special handling in the block itself for its drops)

#

https://github.com/misode/mcmeta/blob/data-json/data/minecraft/loot_tables/blocks/decorated_pot.json

#

If pot is cracked, drops sherds. If pot is not cracked, drops pot

inner veldt Apr 28, 2024, 2:23 PM

#

foggy steeple This testing in game doesn’t really mean much since the loot table is what shoul...

The decorated pot does have special handling in the block itself. When you break a decorated pot with an item that is in the #minecraft:breaks_decorated_pots item tag, then the cracked blockstate is set to true before the loot table is used.

naive hound Apr 28, 2024, 3:25 PM

#

so, sounds like that tag is emptied in NF because there was no case in my NF run where the pot dropped anything other than itself

open kindle Apr 28, 2024, 3:39 PM

#

magic sierra It's weird, because the behavior when you break a cobweb with shears is correct.

Cobwebs are special-cased in vanilla iirc

summer furnace Apr 29, 2024, 9:44 AM

#

thinkies there have been no more critical issues since rc1... anyone else thinks 1.20.6 is likely to release today?

fallen igloo Apr 29, 2024, 10:13 AM

#

rc2 today release tomorrow

summer furnace Apr 29, 2024, 10:14 AM

#

you think there's more bugs?

fallen igloo Apr 29, 2024, 10:15 AM

#

they fixed something today so they won't directly release that

jagged yoke Apr 29, 2024, 10:44 AM

#

Those fixes are for a future update, not hotfix

fallen igloo Apr 29, 2024, 10:47 AM

#

all of the fixes since rc1? if so we are gonna get the release today and maybe first 1.21 snapshot on wednesday or next week

summer furnace Apr 29, 2024, 11:05 AM

#

yeah the only thing marked "Future Hotfix" or "1.20.6" or similar, is the one that was already in rc1

#

the rest are "Future Update" instead

elder swallow Apr 29, 2024, 12:14 PM

#

A hotfix seems likely today but we'll see

digital drum Apr 29, 2024, 2:53 PM

#

1.20,6 IS OUTTTTTT

#

@restive raft

prisma locust Apr 29, 2024, 2:56 PM

#

one ping is enough

digital drum Apr 29, 2024, 2:56 PM

#

srry srry

restive raft Apr 29, 2024, 2:57 PM

#

<@&1067092163520909374> 1.20.6
https://mdcfe.dev/mc-changes?ver=1.20.6
https://www.minecraft.net/en-us/article/minecraft-java-edition-1-20-6

#

only one fix https://bugs.mojang.com/browse/MC-271109 "Trader llama inventory shifted, partially lost during upgrade"

plucky brook Apr 29, 2024, 2:58 PM

#

So rc1 but renamed?

clear bane Apr 29, 2024, 2:58 PM

#

Where release alarm thinkies

digital drum Apr 29, 2024, 2:58 PM

#

plucky brook So rc1 but renamed?

idts

restive raft Apr 29, 2024, 2:58 PM

#

shush /jk

clear bane Apr 29, 2024, 2:58 PM

#

No

#

median wasp Apr 29, 2024, 2:58 PM

#

plucky brook So rc1 but renamed?

That's always how rcs work

plucky brook Apr 29, 2024, 2:58 PM

#

is it?

clear bane Apr 29, 2024, 2:58 PM

#

No?
It's always a new jar

median wasp Apr 29, 2024, 2:58 PM

#

Yes

clear bane Apr 29, 2024, 2:58 PM

#

Not a rename

median wasp Apr 29, 2024, 2:58 PM

#

It's always a new jar, but it's just a rename

#

Pretty much just updates to stuff like SharedConstants and version.json

#

So just a rename

summer furnace Apr 29, 2024, 2:59 PM

#

they always do a new build

#

with different flags

#

but same code

digital drum Apr 29, 2024, 2:59 PM

#

is someone kick-starting neoform?

median wasp Apr 29, 2024, 2:59 PM

#

Yeah, but no code changes

restive raft Apr 29, 2024, 3:01 PM

#

shartte did it

#

(kick-starting neoform)

blazing valve Apr 29, 2024, 3:14 PM

#

*retrying.

A failure occurred while executing de.undercouch.gradle.tasks.download.internal.DefaultWorkerExecutorHelper$DefaultWorkAction
java.net.SocketException: Connection reset

#

Assuming downloadServer hit an intermittent failure

solid lake Apr 29, 2024, 3:19 PM

#

restive raft only one fix <https://bugs.mojang.com/browse/MC-271109> "Trader llama inventory ...

I'm assuming there are more fixes that were hidden because they were stuff like corruption/dupes...

vale holly Apr 29, 2024, 3:19 PM

#

solid lake I'm assuming there are more fixes that were hidden because they were stuff like ...

Not really, its just the one method change + the data fixer changes from code diff

Method change was in relation to applying/rolling back custom blockEntity data, and proper exception catching for CustomName parsing

solid lake Apr 29, 2024, 3:20 PM

#

then why was it so critical

restive raft Apr 29, 2024, 3:21 PM

#

you mean the Mojang Priority?

#

Mojang prioritizes two things quite a lot: ensuring nothing crashes, and ensuring no level data is lost

blazing valve Apr 29, 2024, 3:22 PM

#

Urgh it broke mid update

vale holly Apr 29, 2024, 3:23 PM

#

restive raft Mojang prioritizes two things quite a lot: ensuring nothing crashes, and ensurin...

both of which occured in 1.20.5 (Edited my message for what the method change was)

magic pivot Apr 29, 2024, 3:23 PM

#

No changes needed to the primer

median wasp Apr 29, 2024, 3:24 PM

#

Yeah there were actually like three fixes in 1.20.6

#

Only one of them was actually on Mojira though

blazing valve Apr 29, 2024, 3:30 PM

#

Running release workflow

#

Done

#

Doing Kits

digital drum Apr 29, 2024, 3:41 PM

#

is a PR needed for neo update to 20.6?

#

or should someone make a new branch

blazing valve Apr 29, 2024, 3:42 PM

#

I'll just go through the motions

digital drum Apr 29, 2024, 3:42 PM

#

ok

blazing valve Apr 29, 2024, 3:42 PM

#

No one will maintain 1.20.5, let's be real

digital drum Apr 29, 2024, 3:42 PM

#

true

#

I will go poke the gander devs

elder swallow Apr 29, 2024, 3:51 PM

#

A maintainer will do the update, please don't send a PR

kind sable Apr 29, 2024, 3:51 PM

#

Awesome so my freshly made mod is already on an abandoned version notlikebolb /s

blazing valve Apr 29, 2024, 3:56 PM

#

Vintage

reef parcel Apr 29, 2024, 3:59 PM

#

Story? thinkies

blazing valve Apr 29, 2024, 4:11 PM

#

On Kits: https://github.com/neoforged/Kits/commit/d52e50338e1a29bfc7bbea47b57822118ebfbcfa

#

Now to figure out how to get that onto a new 20.6 tag 😄

thick jay Apr 29, 2024, 4:35 PM

#

oh, this is the snapshot thread
wasted five minutes poking around the thread list for the other channels :p

wild pine Apr 29, 2024, 5:45 PM

#

safe to say first!(?) lol quickest update ever blobxd

stiff galleon Apr 29, 2024, 5:52 PM

#

thinkies we're still using the MCP banner

lean anchor Apr 29, 2024, 5:53 PM

#

Crazy ask: why is Minecraft even in this list anymore? I feel like it's super outdated (MCP is dead, right?) and would be better off hidden

#

Since.. you can see the version on the main menu

#

And ofc MC is loaded. You're in the menu.

prisma locust Apr 29, 2024, 5:54 PM

#

historically minecraft is useful to have as a mod for dependency purposes, but arguably the Neo version conveys the same info nowadays

summer furnace Apr 29, 2024, 5:54 PM

#

we have a mod container for minecraft, no?

#

so that we can have dependency on it in mods.toml

lean anchor Apr 29, 2024, 5:54 PM

#

I'm saying keep the mod container, but don't show it in UI

summer furnace Apr 29, 2024, 5:54 PM

#

but I think it's nice to have there, because so many modpacks like to replace branding

lean anchor Apr 29, 2024, 5:55 PM

#

But.. you know which MC version you're playing

#

Even in a modpack

#

The only real useful info here is the credits/authors, but that's outdated/misleading

blazing valve Apr 29, 2024, 5:58 PM

#

I stripped down that info in the FML locator PR

#

And personally I'd rather have it embedded in NeoForm itself, but... later

median wasp Apr 29, 2024, 5:58 PM

#

I think Minecraft should be in the list, but definitely shouldn't say MCP

#

I think it should just say Minecraft

blazing valve Apr 29, 2024, 5:58 PM

#

https://github.com/neoforged/FancyModLoader/pull/112/files#diff-b82a112aad9e58d1e127c9753c2729d66836463bf97b5ae155a13f5ab787d130

#

I hope that link deep-links to the file... Just check out MinecraftModInfo.java in that PR for the new info

fallen igloo Apr 29, 2024, 6:02 PM

#

I would list all mojangsters here in this discord as credits

#

most importantly gegy, boq, fry

blazing valve Apr 29, 2024, 6:03 PM

#

There's an explicit Mojang credits screen that also includes all the people who work on it that we don't immediately know

#

If anything, we should special case this and link to it

stiff galleon Apr 29, 2024, 6:05 PM

#

${file.mojang_credits}

blazing valve Apr 29, 2024, 6:06 PM

#

It's really all a bit pointless

#

People playing Minecraft know who made Minecraft

#

Personally, I'd not show minecraft in the mods list at all

#

Previously it credited the people who actually worked on MCP/Neoform in that entry, by the way. Not the developers of Minecraft itself

shut wraith Apr 29, 2024, 7:02 PM

#

I think the weird bit is the MCP banner combined with the minecraft info. Especially as, well, vineflower is not MCP technology. And I'm not sure the deobfuscation stuff used any more is either, to speak of?

thick jay Apr 29, 2024, 7:03 PM

#

neoforM deComPiler 👍

stiff galleon Apr 29, 2024, 7:05 PM

#

mini-canid project

thick jay Apr 29, 2024, 7:06 PM

#

semi-relatedly, it seems weird that Neo doesn't automatically make a basic configuration GUI for mods, or at least provide functionality to enable one
unless it does and I missed that option :p

stiff galleon Apr 29, 2024, 7:06 PM

#

the story there is

slow prism Apr 29, 2024, 7:06 PM

#

restive raft only one fix <https://bugs.mojang.com/browse/MC-271109> "Trader llama inventory ...

there were some private issues tii

stiff galleon Apr 29, 2024, 7:06 PM

#

up through 1.12.2, there was a basic configuration gui api for forge

elder swallow Apr 29, 2024, 7:06 PM

#

alright can someone lock this thread now? 😛

stiff galleon Apr 29, 2024, 7:07 PM

#

and after the 1.13 rewrite nobody wanted to rewrite the gui stuff

thick jay Apr 29, 2024, 7:07 PM

#

kek

#1.20.5/6 Snapshots