1.20.2 | The NeoForged Project | Page 9

dull bison Oct 11, 2023, 3:56 PM

#

yes ... clean is the pure decompiled source and base is the compilable source with neoform patches

arctic sphinx Oct 11, 2023, 3:57 PM

#

kek saw that

stray scroll Oct 11, 2023, 3:57 PM

#

is there a reason to keep around the clean source

#

given that looking at it is an exercise of "errors, errors everywhere"

#

has work been done on the dedi-server in NF?

#

since I've not seen a reference to server_files in the forge buildscript

mental carbon Oct 11, 2023, 4:42 PM

#

stray scroll since I've not seen a reference to `server_files` in the forge buildscript

It is taking care of by ng7

mental carbon Oct 11, 2023, 4:49 PM

#

stray scroll since I've not seen a reference to `server_files` in the forge buildscript

Basically all infrastructure components are in ng7

dull bison Oct 11, 2023, 4:59 PM

#

orion we don't need any of the component stuff because if we just disable the gradle module metadata it works

mental carbon Oct 11, 2023, 5:00 PM

#

That still publishes the jar......

#

I need it to stop publishing the jar

dull bison Oct 11, 2023, 5:04 PM

#

does it?

mental carbon Oct 11, 2023, 5:04 PM

#

He?!?!

#

Push it

#

I need to see that

#

That is so weird

#

@dull bison

tranquil salmon Oct 11, 2023, 6:18 PM

#

So no changes to patches were needed

mental carbon Oct 11, 2023, 6:24 PM

#

@dull bison It is working perfectly!

dull bison Oct 11, 2023, 6:39 PM

#

and now we also have sources

#

ok so ... recompile in userdev is broken

stray scroll Oct 11, 2023, 6:49 PM

#

mental carbon It is taking care of by ng7

sounds a bit... fragile

#

in that it's not clear what uses that folder

#

or how the folder is used

#

we're going to need a lot of documentation on NG7 if everything's done in it

#

because I don't really want another situation of only one person having all the design decisions and operating knowledge in their head for something as complex as NG7

#

(if it's not clear, I'm obliquely referring to Lex and his knack of writing things singlehandedly without any documentation, and relying on people either reading the code again and again or asking him to understand what's going on)

quiet talon Oct 11, 2023, 6:58 PM

#

what in the...

mental carbon Oct 11, 2023, 6:58 PM

#

stray scroll in that it's not clear _what_ uses that folder

What folder are you talking about?

#

Ahh

#

I just realised what folder you referred to

fallow sundial Oct 11, 2023, 6:59 PM

#

quiet talon what in the...

who do you want to scream at

mental carbon Oct 11, 2023, 6:59 PM

#

It implements the same behaviour as forge did

stray scroll Oct 11, 2023, 6:59 PM

#

yeah, but in a way which is inherently not obvious as to what's doing that

quiet talon Oct 11, 2023, 6:59 PM

#

didn't they add a reach attribute though? Is it just a shitty half baked impl?

muted hemlock Oct 11, 2023, 7:00 PM

#

armadillos aren't in yet

stray scroll Oct 11, 2023, 7:00 PM

#

can't Ctrl+F for it, since it's in the plugin
and unless you have the NeoGradle repository includeBuilded (which won't be the case once it's properly released), you also don't have access to either the source or the binary for the plugin to Ctrl+F as well

muted hemlock Oct 11, 2023, 7:00 PM

#

or crabs I guess

mental carbon Oct 11, 2023, 7:01 PM

#

stray scroll can't Ctrl+F for it, since it's in the plugin and unless you have the NeoGradle ...

You never need to do that. NG7 specifies the platform and system implementation. Forge is just a consumer of that platform

#

Just like FoxLauncher will eventually be

#

And once you run it from a maven and not includeBuild the DSL and extensions should allow you to navigate to the implementing type

stray scroll Oct 11, 2023, 7:02 PM

#

again, I repeat: unless you know enough of NG7, you wouldn't have any clue that server_files as a folder under the project root is an important™️ folder, which gets consumed... somewhere

mental carbon Oct 11, 2023, 7:03 PM

#

Yes I am aware of this

#

But as I said now for the tenth time, the current state is only to get it to fly, an MVP

#

I already said that I need to create a DSL for the platform module

fossil ore Oct 11, 2023, 7:03 PM

#

dull bison ok so ... recompile in userdev is broken

You got me excited for a second : (

mental carbon Oct 11, 2023, 7:04 PM

#

Which should create a much much much better insight into how forge uses the spec

mental carbon Oct 11, 2023, 7:04 PM

#

dull bison ok so ... recompile in userdev is broken

Error? Log?

#

But for now sci, I made the executive decision to hardcode port over a bunch of changes

stray scroll Oct 11, 2023, 7:04 PM

#

and the DSL for the platform module would presumably allow the consuming project to define its own 'platform'/'system implementation'?

mental carbon Oct 11, 2023, 7:04 PM

#

Yes

#

It would allow a signifcant amount of modification

#

But it would still be up to NG7 to deal with the nitty gritty and manage the underlying stuff like the jar specs

#

And the contained systems

dull bison Oct 11, 2023, 7:05 PM

#

mental carbon Error? Log?

the log would be a lot of compile errors due to a missing dependency (something from fml)

mental carbon Oct 11, 2023, 7:05 PM

#

dull bison the log would be a lot of compile errors due to a missing dependency (something ...

Hmm okey

#

Let's let it rest for today

dull bison Oct 11, 2023, 7:05 PM

#

net.minecraftforge.fml.common.Mod
net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext

mental carbon Oct 11, 2023, 7:05 PM

#

Likely something related to the dep tree not being managed properly

#

I will check on that later

#

Unless you know how to debug configuration resolving

#

😄

#

But right now

#

I had a very very very long day

mental carbon Oct 11, 2023, 7:07 PM

#

stray scroll and the DSL for the platform module would presumably allow the consuming project...

An example would be the data files for the server jar. That would be configurable in said DSL.

stray scroll Oct 11, 2023, 7:07 PM

#

hmmm. i'll be keeping an eye on this, since I am concerned that this temporary solution (to achieve a minimum viable product) might become more... permanent than originally intended

#

and I think many here know of my feelings regarding documentation, and lack thereof thinkies

mental carbon Oct 11, 2023, 7:08 PM

#

It cant

dull bison Oct 11, 2023, 7:08 PM

#

mental carbon Unless you know how to debug configuration resolving

yesn't I did once but can't remember how I did it

mental carbon Oct 11, 2023, 7:08 PM

#

Then start helping!

#

Instead of complaining

#

Read the code, and help write down what Ng 7 does

#

It is pretty straight forward

#

Allthough not everything is visible

#

For example the file for forge needs to named forge-<mcversion>-<forgeversion>-universal.jar

#

For no apparent reason in NG7

#

However it needs to be called that because of FML

fossil ore Oct 11, 2023, 7:13 PM

#

@dull bison @long cobalt @fallow sundial Hi definitely curle clones.

#

curlebolb

stray scroll Oct 11, 2023, 7:13 PM

#

the problem is that you're still busy writing and fleshing out NG7, which means

what I write might become outdated as solutions are found and rewrites are done at each turn for each obstacle
asking for explanations on how certain parts function would drag you away from finishing NG7 (as an MVP)
getting those in the repo would also be a hassle for the same reason (if we go through the route of PR review, because you have to take time to review what I've written)
I'm also juggling some other things at the moment (but that's not new )

#

i'm still having trouble what exactly to prioritize at the moment

dull bison Oct 11, 2023, 7:14 PM

#

fossil ore <@213343613583622144> <@535059714162032640> <@561254664750891009> Hi definitely ...

if you want to be off-topic do it in #squirrels-🦊 and without pinging

kindred fractal Oct 11, 2023, 7:26 PM

#

stray scroll i'm still having trouble what exactly to prioritize at the moment

Cap, eventbus and registry reworks stabolb

mental carbon Oct 11, 2023, 7:28 PM

#

kindred fractal Cap, eventbus and registry reworks <:stabolb:837125030479134730>

None of those he is actively involved in, or am I misinformed

mental carbon Oct 11, 2023, 7:28 PM

#

dull bison yesn't I did once but can't remember how I did it

Can you push

#

Maybe I can do a test run

stray scroll Oct 11, 2023, 7:28 PM

#

insofar as I am involved in some capacity: gradleutils, package renames, PR/issue triaging (both doing that and setting up the project board), translations, READMEs (which were assigned to me by Curle), etc.

mental carbon Oct 11, 2023, 7:29 PM

#

stray scroll insofar as I am involved in some capacity: gradleutils, package renames, PR/issu...

Let me help you prioritize this then:

#

GradleUtils first and foremost

#

We need that to do proper versioning for 20.2

#

Then and only then, package renames

#

After that PR/Issue triaging and on the same priority WebLate testing

stray scroll Oct 11, 2023, 7:29 PM

#

there's also the issue of making some sort of proper organizational system so we know what exactly is still missing and who's working on filling it in
which is useful both now and the future

mental carbon Oct 11, 2023, 7:29 PM

#

After that Readmes

#

@stray scroll Does that help you?

stray scroll Oct 11, 2023, 7:30 PM

#

somewhat, yea

dull bison Oct 11, 2023, 7:30 PM

#

mental carbon Can you push

everything is already pushed

mental carbon Oct 11, 2023, 7:30 PM

#

Okey

#

is now updating the MDK

stray scroll Oct 11, 2023, 7:30 PM

#

though I'm not fully sure what in GradleUtils needs changing, outside of what I know for configuration cache

dull bison Oct 11, 2023, 7:31 PM

#

I just use the examples in NG

stray scroll Oct 11, 2023, 7:31 PM

#

also, Shrimp is heavily involved in GradleUtils, so anything I do there has to pass by him (which he has explicitly said to me to do via PRs)

mental carbon Oct 11, 2023, 7:31 PM

#

stray scroll though I'm not fully sure what in GradleUtils *needs* changing, outside of what ...

We need code to deal with the new versioning scheme

#

And the configuration changes

mental carbon Oct 11, 2023, 7:32 PM

#

stray scroll also, Shrimp is heavily involved in GradleUtils, so anything I do there has to p...

Okey, for now start with it in a PR, just simply start the work so we get something on the table.

If it takes to long I will help you / overrule shrimp on the need of a PR. We simply need to get that going cause we are actually close to a release for this weekend and then this needs to be standing!

stray scroll Oct 11, 2023, 7:32 PM

#

so I also have to contend with piecemealing my changes into separate PRs, and figuring out how to best stagger my changes because GradleUtils still publishes per commit
which also involves coordinating how to push the next major version tag and what changes go along with it

dull bison Oct 11, 2023, 7:32 PM

#

Orion I think I know the problem ... it only contains these 3 fml deps:
net.neoforged.fancymodloader:core:47.1.47
net.neoforged.fancymodloader:earlydisplay:47.1.47
net.neoforged.fancymodloader:loader:47.1.47

stray scroll Oct 11, 2023, 7:35 PM

#

I also have to contend on determining what exactly in GradleUtils is considered as 'public API' for the purposes of breaking changes, because classes like GradleUtils are public

#

what I wanted to do is switch over GradleUtils to manual versioning (or a pinned previously-published version) instead of this cursed buildSrc-copying-to-main-sourceset witchcraft that was implemented long ago to make GradleUtils self-sufficient
but I believe Shrimp rejected that notion and preferred going with the current structure (or at least, so I believe)

dull bison Oct 11, 2023, 7:38 PM

#

dull bison Orion I think I know the problem ... it only contains these 3 fml deps: net.neof...

because it only includes the installerLibraries configuration in the libraries

mental carbon Oct 11, 2023, 7:39 PM

#

Yeah but it worked before

#

I need to check why it does not now

stray scroll Oct 11, 2023, 7:40 PM

#

and it's difficult to communicate on what exactly should be done next because I'm so far away in timezones that either I have to sacrifice my sleep (which I am already doing now), try to hold Discord conversations long-term (which is very difficult given the real-time nature of the platform), or try to get people to move to a more asynchronous platform of discussion that isn't Discord (real-time) chat (which was already previously soundly rejected)

mental carbon Oct 11, 2023, 7:41 PM

#

stray scroll and it's difficult to communicate on what exactly should be done next because I'...

For now I would be fine with you making it work........

dull bison Oct 11, 2023, 7:41 PM

#

mental carbon Yeah but it worked before

userdev worked? we only tested the installer and that includes more in the libraries

mental carbon Oct 11, 2023, 7:41 PM

#

dull bison userdev worked? we only tested the installer and that includes more in the libra...

It worked before the switch to 20.2

#

It worked on 20.1

stray scroll Oct 11, 2023, 7:42 PM

#

...upon reflection and writing that out, I'm starting to realize that I might be starting to build frustration, which I fear might cause my burnout

mental carbon Oct 11, 2023, 7:42 PM

#

Okey

#

Do you mind if me and schurli take over then

dull bison Oct 11, 2023, 7:43 PM

#

mental carbon It worked before the switch to 20.2

well yea but the profile included the other missing fml deps

mental carbon Oct 11, 2023, 7:43 PM

#

dull bison well yea but the profile included the other missing fml deps

But why

#

It was not a transitive resolve for that

#

Well the MDK is loading XD

dull bison Oct 11, 2023, 7:44 PM

#

because we forgot to add them to the libraries for the userdev
the missing deps are in the pluginLayerLibrary and gameLayerLibrary configurations

mental carbon Oct 11, 2023, 7:45 PM

#

What?

#

dull bison Oct 11, 2023, 7:45 PM

#

mental carbon Well the MDK is loading XD

it will until the recompile step

mental carbon Oct 11, 2023, 7:46 PM

#

Shit you are right

dull bison Oct 11, 2023, 7:46 PM

#

I'll add the missing configurations

mental carbon Oct 11, 2023, 7:46 PM

#

Already done

dull bison Oct 11, 2023, 7:46 PM

#

ok

tranquil salmon Oct 11, 2023, 7:52 PM

#

A couple of ecj exclusive compile errors

dull bison Oct 11, 2023, 7:53 PM

#

mental carbon Already done

can you push

tranquil salmon Oct 11, 2023, 7:55 PM

#

21 classes have been added in the net.minecraft.commands package along with one 1 class being removed

#

new constant in CommonColors: SOFT_RED=0xFFDF5050

mental carbon Oct 11, 2023, 8:02 PM

#

dull bison can you push

Done

#

For fucks sake

#

@dull bison Stuff that I just pushed is somehow broken

dull bison Oct 11, 2023, 8:11 PM

#

how broken?

mental carbon Oct 11, 2023, 8:11 PM

#

Line not working AT ALL broken

#

It is not finding the dependency

tranquil salmon Oct 11, 2023, 8:14 PM

#

tranquil salmon A couple of ecj exclusive compile errors

Nevermind it seems there is an issue with testCompileClientHotSpot17 not recognizing source files

mental carbon Oct 11, 2023, 8:14 PM

#

@dull bison What is the dep spec for forge you use in your tests?

dull bison Oct 11, 2023, 8:15 PM

#

mental carbon <@213343613583622144> What is the dep spec for forge you use in your tests?

you mean the old one I used?

mental carbon Oct 11, 2023, 8:16 PM

#

Yeah

#

I tried net.neoforged:forge:20.2.1

dull bison Oct 11, 2023, 8:16 PM

#

📎 config.json

mental carbon Oct 11, 2023, 8:16 PM

#

No I mean the dep string

#

in the build.gradle

#

Figured it out

#

Was missing the mavenLocal()

dull bison Oct 11, 2023, 8:17 PM

#

for the new one I use net.neoforged:forge:20.2.1 for the old one I used the one that was in the runs example at that point

dull bison Oct 11, 2023, 8:18 PM

#

mental carbon Was missing the mavenLocal()

ah yea that is kinda important when using maven local

mental carbon Oct 11, 2023, 8:20 PM

#

3

#

That is looking good

#

#

That is looking even better

#

#

But that is a problem

#

#

Yeah jar is named wrongly

#

Question becomes how do we fix that

#

Because that is hardcoded into FML

#

Okey I need to fix those in FML

#

But amazing to see

#

compiled a test mod

#

Creating an installer now

#

Hopefully this runs

tranquil salmon Oct 11, 2023, 8:29 PM

#

Why would gradle be complaining about there being no source files for this: https://github.com/neoforged/NeoForm/actions/runs/6484468495/job/17609002940#step:9:211 ?

mental carbon Oct 11, 2023, 8:33 PM

#

@dull bison

dull bison Oct 11, 2023, 8:34 PM

#

time to give it to covers and have him port a chickenbones mod /s

mental carbon Oct 11, 2023, 8:36 PM

#

#

Assets is missing

#

Yeah I can't get datagen to work

#

Need to patch FML

#

Will do that tomorrow morning

dull bison Oct 11, 2023, 8:38 PM

#

So plan for tomorrow:

fml
mixin

#

Argh I hate mixin Unable to locate obfuscation mapping for @Inject target neighborChanged

mental carbon Oct 11, 2023, 8:52 PM

#

dull bison So plan for tomorrow: - fml - mixin

Assets and fml are the same

#

The mdk has all its assets in datagen

#

But that can't be ran

#

Because it expects a different version there

dull bison Oct 11, 2023, 9:04 PM

#

welp that's the possibility to use a mixin for multiple loaders out of the window ... you now need to add remap=false to all mixins

mental carbon Oct 11, 2023, 9:06 PM

#

Why?

#

Can we not just generate a refMap that holds the mappings?

kindred fractal Oct 11, 2023, 9:07 PM

#

Can't we disable the refmap generation step / generate a trivial refmap?

fallow sundial Oct 11, 2023, 9:07 PM

#

dull bison welp that's the possibility to use a mixin for multiple loaders out of the windo...

uhoh, can you just please uhm, feed it a moj to moj tsrg

#

I'd argue that a good thing some refmap generation involved was basic errors when trying to target inexistant methods

dull bison Oct 11, 2023, 9:10 PM

#

fallow sundial uhoh, can you just please uhm, feed it a moj to moj tsrg

this could work

dull bison Oct 11, 2023, 9:11 PM

#

kindred fractal Can't we disable the refmap generation step / generate a trivial refmap?

the refmap is created by the AP which is the thing throwing that missing mapping error

tranquil salmon Oct 11, 2023, 10:14 PM

#

tranquil salmon Why would gradle be complaining about there being no source files for this: http...

It seems to only happen on clean builds @mental carbon

mossy bobcat Oct 12, 2023, 12:06 AM

#

dull bison welp that's the possibility to use a mixin for multiple loaders out of the windo...

If no refmap is found, it won't error

#

Just... don't generate one on forge

#

And suppress the "no refmap; this is fine if you're in dev but bad otherwise" warning somehow - does mixin have a setting you can enable for that?

#

Also, the AP shouldn't error if it can't remap stuff, right? I thought it only warned?

dull bison Oct 12, 2023, 5:49 AM

#

mossy bobcat Also, the AP shouldn't error if it can't remap stuff, right? I thought it only w...

that error is from the AP and you don't generate the refmap yourself that is also done by the AP

kindred fractal Oct 12, 2023, 6:00 AM

#

#

I don't see the difference, what am I missing?

keen hearth Oct 12, 2023, 6:02 AM

#

the lv store is gone?

tranquil salmon Oct 12, 2023, 6:03 AM

#

the inner class access is protected so I removed the direct reference to it

mental carbon Oct 12, 2023, 6:03 AM

#

Yeah

kindred fractal Oct 12, 2023, 6:07 AM

#

tranquil salmon the inner class access is `protected` so I removed the direct reference to it

Ahhh I see

#

Was just curious, can't see that from the patch heh

fallow sundial Oct 12, 2023, 7:03 AM

#

I'm going to work on stripping neo-added docs from the final patches so they can be inserted via javadoctor.. this will be fun

mental carbon Oct 12, 2023, 7:04 AM

#

fallow sundial I'm going to work on stripping neo-added docs from the final patches so they can...

Can you do that in a seperate branch please?

fallow sundial Oct 12, 2023, 7:08 AM

#

sure

mossy bobcat Oct 12, 2023, 7:23 AM

#

dull bison that error is from the AP and you don't generate the refmap yourself that is als...

Is there no option just to universally tell the AP not to remap? Heck, what's the AP even needed for if stuff isn't being remapped? I suspect there's something but I'm not sure what

mossy bobcat Oct 12, 2023, 7:24 AM

#

fallow sundial I'm going to work on stripping neo-added docs from the final patches so they can...

Might want to look at what I do in docpatcher to strip out javadocs

quiet talon Oct 12, 2023, 7:24 AM

#

honestly i'm not sure what it does if refmaps are gone

mossy bobcat Oct 12, 2023, 7:26 AM

#

quiet talon honestly i'm not sure what it does if refmaps are gone

Gives you a log warning and that's it. Mixin at least. The AP apparently needs mapping information to not error out

#

Ideally there'd be a way to configure that log warning

#

Can we check what sponge does here?

#

After all, don't they have runtime Mojmaps already?

#

So in theory they have the same scenario of not needing mixins remapped, and I think they support mixins?

#

Heck, I suspect that we could just not run the AP. Does it run at all before runs in userdev? I think the answer is no, in which case it would be perfectly safe to leave out, except for that warning, which I suspect there has to be a way to configure somewhere

#

Otherwise we just feed it dummy remapping data

quiet talon Oct 12, 2023, 7:30 AM

#

if it only handles the refmap we could just discard it yeah

mossy bobcat Oct 12, 2023, 7:54 AM

#

This seems like a question for sponge though as they also do runtime Mojmaps. Has anyone asked folks there?

dull bison Oct 12, 2023, 7:56 AM

#

@formal flower do we still need the AP if we do runtime mojmaps?

kindred fractal Oct 12, 2023, 8:09 AM

#

does he even see this channel?

tranquil salmon Oct 12, 2023, 8:12 AM

#

I think they made it so that they only see #mixin

arctic sphinx Oct 12, 2023, 8:13 AM

#

dull bison <@235556733639065600> do we still need the AP if we do runtime mojmaps?

It handles some validation as well iirc

#

And afaik I don't believe they can see this channel due to the client he uses for Discord

mental carbon Oct 12, 2023, 8:14 AM

#

They can't

#

I will reping him in the right one

mental carbon Oct 12, 2023, 9:23 AM

#

Damn fixed FML

#

Got a different error

#

Okey the events file is broken

kindred fractal Oct 12, 2023, 9:32 AM

#

careful with FML, it's still using 20.1 versioning

#

we'll have to break

dull bison Oct 12, 2023, 9:34 AM

#

can someone compare the mod discovery output from 20.1 with this:

[main] INFO net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer - Found mod file "events-47.1.55.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4cfbaf4
[main] INFO net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer - Found mod file "forge-20.2.1.jar" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4cfbaf4
[main] INFO net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer - Found mod file "main" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4cfbaf4
[main] INFO net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer - Found mod file "" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4cfbaf4
[main] INFO net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer - Found mod file "language-minecraft-47.1.55.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.BuiltinGameLibraryLocator@3b8ee898
[main] INFO net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer - Found mod file "language-lowcode-47.1.55.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.BuiltinGameLibraryLocator@3b8ee898
[main] INFO net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer - Found mod file "core-47.1.55.jar" of type LIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.BuiltinGameLibraryLocator@3b8ee898
[main] INFO net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer - Found mod file "language-java-47.1.55.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.BuiltinGameLibraryLocator@3b8ee898

kindred fractal Oct 12, 2023, 9:38 AM

#

[11:37:58.160] [main/INFO] [loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "language-java-47.1.41.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4a325eb9 
[11:37:58.161] [main/INFO] [loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "language-lowcode-47.1.41.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4a325eb9 
[11:37:58.161] [main/INFO] [loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "language-minecraft-47.1.41.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4a325eb9 
[11:37:58.161] [main/INFO] [loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "core-47.1.41.jar" of type LIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4a325eb9 
[11:37:58.161] [main/INFO] [loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "main" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4a325eb9 
[11:37:58.161] [main/INFO] [loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "test" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4a325eb9 
[11:37:58.162] [main/INFO] [loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@4a325eb9 
[11:37:58.351] [main/INFO] [loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "events-47.1.41.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.BuiltinGameLibraryLocator@400d912a

#

^ 20.1

mental carbon Oct 12, 2023, 9:39 AM

#

The events jar is a problem

kindred fractal Oct 12, 2023, 9:39 AM

#

what is it?

mental carbon Oct 12, 2023, 9:39 AM

#

The FML Loading events 😄

#

It is for some reason treated as a mod

#

And not as a lib

#

Need to check why

kindred fractal Oct 12, 2023, 9:40 AM

#

it's treated as a lib on both

mental carbon Oct 12, 2023, 9:40 AM

#

But it is not

#

Because right now it crashes with a missing mods.toml

#

On 20.2

kindred fractal Oct 12, 2023, 9:41 AM

#

wait, schurli is loading it with the MinecraftLocator

#

I am loading it with the BuiltinGameLibraryLocator

#

idk if that matters though

mental carbon Oct 12, 2023, 9:43 AM

#

That matters!

dull bison Oct 12, 2023, 9:47 AM

#

it uses the wrong locator that is the problem

mental carbon Oct 12, 2023, 9:47 AM

#

I will check it out then

dull bison Oct 12, 2023, 9:59 AM

#

it loads all of them with the wrong one

#

these should load with MinecraftLocator but load with BuiltinGameLibraryLocator
language-java
language-lowcode
language-minecraft
core
and events should load with BuiltinGameLibraryLocator but loads with MinecraftLocator
it also now tries to load forge as a mod with MinecraftLocator

mental carbon Oct 12, 2023, 10:08 AM

#

Okey I need to check that then 😄

#

WIll debug after lunch

dull bison Oct 12, 2023, 10:09 AM

#

kindred fractal ``` [11:37:58.160] [main/INFO] [loading.moddiscovery.ModDiscoverer/SCAN]: Found ...

tech did you get that from forgedev or userdev?

mental carbon Oct 12, 2023, 10:48 AM

#

dull bison these should load with `MinecraftLocator` but load with `BuiltinGameLibraryLocat...

did you make a typo with th locators?

dull bison Oct 12, 2023, 10:49 AM

#

a typo where exactly?

kindred fractal Oct 12, 2023, 10:55 AM

#

dull bison tech did you get that from forgedev or userdev?

forgedev

mental carbon Oct 12, 2023, 10:56 AM

#

We need one from userdev

#

They use different locators

arctic sphinx Oct 12, 2023, 11:00 AM

#

[12:03:46] [main/INFO]: Found mod file "language-java-47.1.41.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@775594f2
[12:03:46] [main/INFO]: Found mod file "language-lowcode-47.1.41.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@775594f2
[12:03:46] [main/INFO]: Found mod file "language-minecraft-47.1.41.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@775594f2
[12:03:46] [main/INFO]: Found mod file "core-47.1.41.jar" of type LIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@775594f2
[12:03:46] [main/INFO]: Found mod file "forge-1.20.1-47.1.54_mapped_parchment_2023.07.23-1.20.1-recomp.jar" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@775594f2
[12:03:46] [main/INFO]: Found mod file "main" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@775594f2
[12:03:46] [main/INFO]: Found mod file "" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@775594f2
[12:03:46] [main/INFO]: Found mod file "events-47.1.41.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.BuiltinGameLibraryLocator@5ffc5491

#

Oh wait I have rubidium on there, one sec

dull bison Oct 12, 2023, 11:06 AM

#

Ok same difference

arctic sphinx Oct 12, 2023, 11:07 AM

#

Semi interesting that having it on there added additional forge locator resolves, I assume for handling the mods.toml dep info?

[11:59:27] [main/INFO]: Found mod file "rubidium-574856-4573226_mapped_parchment_2023.07.23-1.20.1.jar" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.ClasspathLocator@3b8ee898
[11:59:27] [main/INFO]: Found mod file "forge-1.20.1-47.1.54_mapped_parchment_2023.07.23-1.20.1-recomp.jar" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.ClasspathLocator@3b8ee898

mental carbon Oct 12, 2023, 11:28 AM

#

arctic sphinx ``` [12:03:46] [main/INFO]: Found mod file "language-java-47.1.41.jar" of type L...

Is that for 20.1?

arctic sphinx Oct 12, 2023, 11:29 AM

#

Yes, NeoForge 47.1.54 1.20.1

mental carbon Oct 12, 2023, 11:29 AM

#

Okey thanks

dull bison Oct 12, 2023, 11:46 AM

#

could this be an issue of the classpath order?

mental carbon Oct 12, 2023, 11:49 AM

#

Nah

#

They are actually located by just looping the entire classpath and looking for the file

#

The order is completely irrelevant

dull bison Oct 12, 2023, 11:55 AM

#

I mean the order of the locators themselves ... they are loaded via ServiceLoader which should result in classpath order

mental carbon Oct 12, 2023, 11:55 AM

#

Should not matter....

#

Because they operate actually independently

#

I think I got it

#

Nope nevermind

dull bison Oct 12, 2023, 12:32 PM

#

afaict the logger configuration is broken I can't set the debug flag (I need to change the level of the logger via the debugger)

dull bison Oct 12, 2023, 1:05 PM

#

why are parts of fml using slf4j and some log4j?

stray scroll Oct 12, 2023, 1:09 PM

#

new code is likely to use SLF4J

dull bison Oct 12, 2023, 1:11 PM

#

yes but something is broken in that slf4j is not using the log4j backend

mental carbon Oct 12, 2023, 1:11 PM

#

Hmm weird

#

Because there is nothing else on the classpath

#

As far as I can see

arctic sphinx Oct 12, 2023, 1:12 PM

#

It's not that service loader issue with MML?

dull bison Oct 12, 2023, 1:12 PM

#

it uses its default impl SimpleLogger

mental carbon Oct 12, 2023, 1:12 PM

#

Maybe

#

I mean untill the system loads up properly it is hard to say

dull bison Oct 12, 2023, 1:12 PM

#

not just maybe I checked with the debugger

mental carbon Oct 12, 2023, 1:12 PM

#

That was in response to the MML question

#

I understood that you tested it 😄

dull bison Oct 12, 2023, 1:14 PM

#

and debugging slf4j is not possible atm because I have a problem with source does not match bytecode

mental carbon Oct 12, 2023, 1:19 PM

#

This is the basic problem:

#

MC 20.1:

#

#

MC 20.2:

#

#

The other Artifacts collection is not correct at the moment

stray scroll Oct 12, 2023, 1:20 PM

#

so, the question is now, what populates otherArtifacts thinkies

mental carbon Oct 12, 2023, 1:20 PM

#

getFmlPaths(legacyCP)

dull bison Oct 12, 2023, 1:21 PM

#

mental carbon The other Artifacts collection is not correct at the moment

I knew that 2 hours ago already (didn't know you didn't)

mental carbon Oct 12, 2023, 1:21 PM

#

The plugin layer is as such not properly setup on the class path 😄

mental carbon Oct 12, 2023, 1:21 PM

#

dull bison I knew that 2 hours ago already (didn't know you didn't)

I only just now got out of most of my work calls (still in one) and could debug it now

dull bison Oct 12, 2023, 1:21 PM

#

ah

mental carbon Oct 12, 2023, 1:22 PM

#

20.2 Plugin libraries:

#

#

20.1 Plugin libraries:

#

So yes I configured something wrongly

#

Let me check

dull bison Oct 12, 2023, 1:24 PM

#

you switched pluginLayerLibrary and gameLayerLibrary

mental carbon Oct 12, 2023, 1:24 PM

#

dull bison you switched pluginLayerLibrary and gameLayerLibrary

I did

#

I just realised it

#

XD

#

Testing the fix

#

After fix:

#

#

Logging is indeed still an issue

#

Applying a fix for the gameDir option

dull bison Oct 12, 2023, 1:48 PM

#

can you commit and push the fix

mental carbon Oct 12, 2023, 2:01 PM

#

2 Seconds

#

Was still in a call

#

@dull bison I will push now, and the game starts. But I think it does not run the MDK yet, because of 1 reason: resourceProcessing with respect to the IDE.....

Additionally logging is indeed f'ed up.

#

Pushed

#

Remember to republish neogradle

#

Because I made some changes to the runs

dull bison Oct 12, 2023, 3:16 PM

#

mixin is done and works

#

todo:

fix logging
fix resources
cleanup NG
make fml use slf4j consistently
repackage and bump dependencies that still use net.minecraftforge

mental carbon Oct 12, 2023, 3:23 PM

#

Yeah I don't really understand the logging issue

#

Aan far as I can see this only happens in userdev

#

So likely something with the classpath?

mossy bobcat Oct 12, 2023, 3:34 PM

#

arctic sphinx It's not that service loader issue with MML?

That seems very likely to me, if it uses a service to find the backend. @nova sundial had a fix to that I believe which you may want to look at

#

Unless it's some completely different classpath/module/service-discovery issue, which I suppose isn't impossible as this is FML we're talking about

dull bison Oct 12, 2023, 3:51 PM

#

you mean that a bug in MML is causing the logger issue?

mossy bobcat Oct 12, 2023, 3:53 PM

#

Maybe™️

mental carbon Oct 12, 2023, 3:53 PM

#

The problem is that none of that has changed between 20.2 and 20.1

#

So it can't be mml

#

Or fml

dull bison Oct 12, 2023, 3:57 PM

#

could it be some kind of version mismatch issue ... that we are overriding a dependency that we shouldn't

nova sundial Oct 12, 2023, 3:57 PM

#

mental carbon So it can't be mml

Yeah I think so, unless the logger fix broke somehow

feral moat Oct 12, 2023, 4:08 PM

#

Isn’t there something (or was) regarding the hashing of how things are added to a map that it picking the correct logger was dependent on?

#coordination message

Can’t find the exact discussion I was looking for but those are semi close? Maybe

#

But basically my point is if it didn’t get fixed to be more stable (I forget if it did or didn’t) then it could be something changed the relative hashes

mental carbon Oct 12, 2023, 4:12 PM

#

dull bison could it be some kind of version mismatch issue ... that we are overriding a dep...

Possible something I will debug in a biy

#

Weird stuff

#

It works in production

#

Just not in userdev

#

So classpath order?

feral moat Oct 12, 2023, 4:36 PM

#

Didn’t @tacit vale write something to fix that previously

tacit vale Oct 12, 2023, 4:36 PM

#

Hi

#

What did I do?

feral moat Oct 12, 2023, 4:37 PM

#

Fix logger in userdev when it works fine in prod

tacit vale Oct 12, 2023, 4:37 PM

#

yeah

#

I did

#

it required code to enforce which logger configuration gets loaded

#

Since the env differences caused the classpath to sort differently

#

In userdev vs prod

#

Prioritizing a different log config

mental carbon Oct 12, 2023, 4:43 PM

#

Link?

dull bison Oct 12, 2023, 4:49 PM

#

it's not the logger config that gets loaded fine it is that it uses the default impl instead of log4j

dull bison Oct 12, 2023, 5:23 PM

#

sooo... its not the classpath order

mental carbon Oct 12, 2023, 5:30 PM

#

You up for a call?

dull bison Oct 12, 2023, 5:30 PM

#

yup

mental carbon Oct 12, 2023, 5:31 PM

#

I will visit the loo and then I am around

#

@dull bison I am around now

mental carbon Oct 12, 2023, 6:29 PM

#

Logging problem fixed

dull bison Oct 12, 2023, 7:36 PM

#

existing files for datagen is not working yet

mental carbon Oct 12, 2023, 7:43 PM

#

dull bison existing files for datagen is not working yet

Were?

#

--existing should be there

#

But I might have missed it

dull bison Oct 12, 2023, 7:45 PM

#

yesn't it needs to see the vanilla resources because it uses a few vanilla sound files for the milk fluid sounds

mental carbon Oct 12, 2023, 7:56 PM

#

Weird

#

I can't seem to find a link to those existing ones

#

So yeah we still need the forge datagen then

dull bison Oct 12, 2023, 8:10 PM

#

I think it is because the files are still in the assets format (hash as filename and index file says what it is)

mental carbon Oct 12, 2023, 8:16 PM

#

dull bison I think it is because the files are still in the assets format (hash as filename...

What do you mean? Assets format should be fine

dull bison Oct 12, 2023, 8:17 PM

#

for ExistingFileHelper

mental carbon Oct 12, 2023, 8:18 PM

#

Weird

#

I can't even find a way the existing vanilla stuff is passed in / detected

dull bison Oct 12, 2023, 8:21 PM

#

maybe that is the problem it is not passed

feral moat Oct 12, 2023, 8:36 PM

#

Iirc the datagenmodloader or whatever class instantiates the existing file helper adds vanilla (and if appropriate forge) resources to it

#

Rather than everyone having to specify them in their build.gradles

dull bison Oct 13, 2023, 6:10 AM

#

yea but this is the datagen in forgedev that we have problems with

dull bison Oct 13, 2023, 8:05 AM

#

ok the problem is that the resource manager does not have the vanilla assets

mental carbon Oct 13, 2023, 8:05 AM

#

What?

#

Is the client extra jar on the class path?

dull bison Oct 13, 2023, 8:12 AM

#

does the forgedev run use the classpath.txt? then yes

mental carbon Oct 13, 2023, 8:13 AM

#

Unsure

#

Check the BSL launch code

#

To see if it is contained

dull bison Oct 13, 2023, 8:19 AM

#

yes but it uses the legacyClassPath instead of the legacyClassPath.file

#

which is also the cause for me having to edit the run config because the commandline is too long

mental carbon Oct 13, 2023, 8:22 AM

#

Ah okey

#

We can fix that

dull bison Oct 13, 2023, 8:23 AM

#

just checked it should be there but it is also in the ignoreList

mental carbon Oct 13, 2023, 8:23 AM

#

Yeah that is fine

dull bison Oct 13, 2023, 8:25 AM

#

it is on the classpath

mental carbon Oct 13, 2023, 8:25 AM

#

dull bison it is on the classpath

Check if that file contains the relevant assets

dull bison Oct 13, 2023, 8:29 AM

#

nope it is missing the sounds

arctic sphinx Oct 13, 2023, 8:34 AM

#

Just the sounds? Because isn't that normal

mental carbon Oct 13, 2023, 8:35 AM

#

dull bison nope it is missing the sounds

Just the sounds

#

Wtf

#

Are they in the client jar that you download from mojang?

dull bison Oct 13, 2023, 8:36 AM

#

mental carbon Oct 13, 2023, 8:36 AM

#

Is that the downloaded jar

#

Or the extra jar?

dull bison Oct 13, 2023, 8:36 AM

#

that is client-extras

arctic sphinx Oct 13, 2023, 8:37 AM

#

That's correct then

#

It's the same as 1.20.1

mental carbon Oct 13, 2023, 8:37 AM

#

Then how does it deal with sound

arctic sphinx Oct 13, 2023, 8:37 AM

#

They're stored externally

#

It's why we have that downloadAssets task

mental carbon Oct 13, 2023, 8:38 AM

#

That is for sure running

#

I saw that run on my end

dull bison Oct 13, 2023, 8:40 AM

#

yes but those assets don't land in the resource manager

arctic sphinx Oct 13, 2023, 8:41 AM

#

The directory they're in should be passed in by the command line --assetIndex 5 --assetsDir C:\Users\<user>\.gradle\caches\forge_gradle\assets (1.20.1)

tranquil salmon Oct 13, 2023, 8:43 AM

#

for 1.20.2 the asset index is 8

mental carbon Oct 13, 2023, 8:44 AM

#

Let me check

#

Nop I did not add those

#

@dull bison Pushed a fixed

#

Ah download assets does not exist

#

Stupid me

#

Hold on need to wire up the task

dull bison Oct 13, 2023, 9:02 AM

#

the asset index is wrong...

mental carbon Oct 13, 2023, 9:02 AM

#

#

It is not

#

I just pushed a fix

#

Pull and reimport

#

It should fix the setup

#

With both fixes applied

#

It is now properly working for me

dull bison Oct 13, 2023, 9:11 AM

#

we still need to put the legacyClassPath into a file because the commandline is too large

mental carbon Oct 13, 2023, 9:11 AM

#

dull bison we still need to put the legacyClassPath into a file because the commandline is ...

Okey I need to code that into the runtime then

#

Will take me a bit

#

The code exists in userdev

#

but not yet in dyn project because they are hardcoded there

tranquil salmon Oct 13, 2023, 9:23 AM

#

I am getting Caused by: java.lang.NullPointerException: Cannot get property 'sourceSets' on null object still

mental carbon Oct 13, 2023, 9:23 AM

#

tranquil salmon I am getting `Caused by: java.lang.NullPointerException: Cannot get property 'so...

You need to pull

#

Cause that was fixed several days ago

tranquil salmon Oct 13, 2023, 9:24 AM

#

I did pull both Kits and NeoGradle

mental carbon Oct 13, 2023, 9:25 AM

#

Run a ./gradlew build --stacktrace for me please

#

Potentially with the bat

#

Outside of the IDE please

#

Are you importing into eclipse?

tranquil salmon Oct 13, 2023, 9:26 AM

#

Yes

#

Also it seems to only happen when refreshing the gradle project with eclipse
\NeoForge\projects\forge\build.gradle:152

mental carbon Oct 13, 2023, 9:31 AM

#

Yeah

#

Need to fix that

#

The idea extension is not applied currently when running in eclipse mode

#

Wil fix that

dull bison Oct 13, 2023, 9:33 AM

#

in eclipe mode it should use a dummy

mental carbon Oct 13, 2023, 9:35 AM

#

@tranquil salmon Pull

#

NG7 Now applies the run extension

dull bison Oct 13, 2023, 9:39 AM

#

agenda is:

move legacyClassPath to a file for forgedev
merge mixin
do eclipse stuff
did I forget anything?

mental carbon Oct 13, 2023, 9:39 AM

#

No

#

Already on the eclipse stuff

tranquil salmon Oct 13, 2023, 9:39 AM

#

It now get's past the configuration phase when importing into eclipse

mental carbon Oct 13, 2023, 9:39 AM

#

Will do the LCP File stuff in a minute as well
As it is trivial to imple,emnt

mental carbon Oct 13, 2023, 9:39 AM

#

tranquil salmon It now get's past the configuration phase when importing into eclipse

Let me know if / where it hands next

tranquil salmon Oct 13, 2023, 9:50 AM

#

It successfully finishes

mental carbon Oct 13, 2023, 9:50 AM

#

Okey coolk

#

I am about to publish ELC

#

So I can generate launch files from there

mental carbon Oct 13, 2023, 9:51 AM

#

tranquil salmon It successfully finishes

Did it run the post import tasks?

tranquil salmon Oct 13, 2023, 9:51 AM

#

It ran :forge:idePostSync

mental carbon Oct 13, 2023, 9:51 AM

#

dull bison agenda is: - move legacyClassPath to a file for forgedev - merge mixin - do ecli...

Versioning is missing from this

mental carbon Oct 13, 2023, 9:51 AM

#

tranquil salmon It ran `:forge:idePostSync`

That is correct that is all it needed to do,

dull bison Oct 13, 2023, 9:52 AM

#

mental carbon Versioning is missing from this

yes but te question there is do we need the changes in GU for that first?

mental carbon Oct 13, 2023, 9:52 AM

#

Yeah we do

#

So that is still on the docket

#

I am working as fast as I can to get NG7 Eclipse ready

#

And then we can get to the rest

#

Running the build for ELC now

#

So that I can build the launch configs

dull bison Oct 13, 2023, 9:54 AM

#

mental carbon Yeah we do

then we are still blocked until shrimp reviews what sci did

mental carbon Oct 13, 2023, 9:54 AM

#

I can do that too

#

We are only blocked untill we solved the rest

#

Versioning is the last issue I tackle

#

For fucks sake the tag apply failed again

stray scroll Oct 13, 2023, 10:02 AM

#

dull bison then we are still blocked until shrimp reviews what sci did

i've not done anything yet, since I'm still waiting for Shrimp to thumbs-up-or-down my suggestion of manual versioning for GradleUtils to get rid of the cursed self-feeding structure in GU

mental carbon Oct 13, 2023, 10:03 AM

#

stray scroll i've not done anything yet, since I'm still waiting for Shrimp to thumbs-up-or-d...

Technically that is the only supported architecture for plugins that need themselves

#

So......

stray scroll Oct 13, 2023, 10:04 AM

#

what?

#

could you clarify what you mean by "that"

#

also, the plugin could also use a past version of itself, pinned to a particular version

#

which I also noted in the issue I filed on the GU repo

#

I also do that same thing in my own versioning plugin (simplversion)

mental carbon Oct 13, 2023, 10:06 AM

#

stray scroll could you clarify what you mean by "that"

By doing the copy

mental carbon Oct 13, 2023, 10:07 AM

#

stray scroll also, the plugin could also use a past version of itself, pinned to a particular...

Sure that is possible, but not recommended since that requires at least two commits to update the plugin

stray scroll Oct 13, 2023, 10:07 AM

#

stray scroll i've not done anything yet, since I'm still waiting for Shrimp to thumbs-up-or-d...

since his answer would inform how I make my next PRs, particularly on how much breaking changes I have to pack into a single commit vs spread out over a few PRs

mental carbon Oct 13, 2023, 10:08 AM

#

Technically it suffices to do something like:

stray scroll Oct 13, 2023, 10:08 AM

#

I firmly am against that sort of self-copying behavior, because I find it an offense against nature

mossy bobcat Oct 13, 2023, 10:08 AM

#

Wait why is the copy necessary? What stops you from adding the buildSrc folder to the main source set? Does gradle crap out on that?

mental carbon Oct 13, 2023, 10:08 AM

#

apply plugin: "groovy"
  dependencies {
 compile gradleApi()
 compile localGroovy()
}
  sourceSets {
 main {
  groovy {
   srcDir '../src/main/groovy'
  }
 }
}

#

As the only file in the buildSrc

#

And it will take the plugins own sources

arctic sphinx Oct 13, 2023, 10:09 AM

#

Doesn't IJ throw a fit at that iirc?

mental carbon Oct 13, 2023, 10:09 AM

#

Nope

arctic sphinx Oct 13, 2023, 10:09 AM

#

Which is why we went with symlinks with FML?

stray scroll Oct 13, 2023, 10:10 AM

#

regardless, I'm pushing for GU to move to manual versioning

mental carbon Oct 13, 2023, 10:10 AM

#

arctic sphinx Which is why we went with symlinks with FML?

BuildSrc is treated differently

#

As far as I know

stray scroll Oct 13, 2023, 10:10 AM

#

if that's denied, then my work is going to be more difficult, as I have to weave all my breaking changes into a single commit

mental carbon Oct 13, 2023, 10:10 AM

#

because it is not part of the same project module

arctic sphinx Oct 13, 2023, 10:10 AM

#

Ah kk

mental carbon Oct 13, 2023, 10:11 AM

#

If I remember properly

mossy bobcat Oct 13, 2023, 10:11 AM

#

Regardless, I don't really see issues with manual versioning

#

Especially for this sort of thing where updates will generally be fairly uncommon

mental carbon Oct 13, 2023, 10:13 AM

#

I do: the fact that GU uses it self for versioning and other components

#

So that means any update and fix applied to it in that area

#

needs at least 2 commits

#

With a PR each

#

Because it needs to be build and published in between

#

That is one major downside

mossy bobcat Oct 13, 2023, 10:13 AM

#

mental carbon I do: the fact that GU uses it self for versioning and other components

...how does that follow from it using manual versioning?

#

(that that issue would pop up, that is)

mental carbon Oct 13, 2023, 10:14 AM

#

Isn't that obvious.....

#

say I need to update the versioning mechanic or update it

#

That same update needs to be applied to GU

stray scroll Oct 13, 2023, 10:14 AM

#

Orion, what do you think "manual versioning" is

mossy bobcat Oct 13, 2023, 10:14 AM

#

mental carbon That same update needs to be applied to GU

No? What?

mental carbon Oct 13, 2023, 10:14 AM

#

Literally what the name is

#

Manual versioning

mossy bobcat Oct 13, 2023, 10:14 AM

#

Manual versioning means you manually set the version

mental carbon Oct 13, 2023, 10:14 AM

#

Ahh

#

No

#

We are not making manual versions

mossy bobcat Oct 13, 2023, 10:15 AM

#

Of the GU that's getting published

mental carbon Oct 13, 2023, 10:15 AM

#

We already discussed this internally more then once

#

And real manual versionsing is not something we do

#

The way I interpretted manual versioning here

#

Is that you pinned the version of GU in use within GU to a manually picked version

mossy bobcat Oct 13, 2023, 10:16 AM

#

mental carbon We already discussed this internally more then once

When? Was there a vote on this? I think sci has a good point in terms of it making breaking changes pretty difficult to merge cleanly for certain bits

#

What's the reasoning behind that decision beyond "we discussed it and decided on no"?

stray scroll Oct 13, 2023, 10:17 AM

#

if there would be any project in NF that would use manual versioning, it would be the one plugin we have that does versioning, so it isn't reliant on itself

dull bison Oct 13, 2023, 10:17 AM

#

please don't discuss this here and not now as we all have better things to do

stray scroll Oct 13, 2023, 10:17 AM

#

(either by self-copying, sourceset-sharing, or pinned version)

mental carbon Oct 13, 2023, 10:17 AM

#

mossy bobcat When? Was there a vote on this? I think sci has a good point in terms of it maki...

Several times already, even within the SC! I am on my phone but I will look this up when I get home.......

mental carbon Oct 13, 2023, 10:17 AM

#

stray scroll if there would be any project in NF that would use manual versioning, it would b...

I am not in principal against pinning one version

#

Of GU that it is supposed to use for it self

#

But no manual versioning is not happening

#

LIke aktual manual versioning

stray scroll Oct 13, 2023, 10:18 AM

#

regardless, I've already made the issue on this topic on the GU repo, so anyone have strong thoughts should put those on the issue

#

(or #neogradle-dev, but I much prefer the issue)

kindred fractal Oct 13, 2023, 11:28 AM

#

stray scroll if that's denied, then my work is going to be more difficult, as I have to weave...

Not necessarily, no

#

You can make breaking changes in the minor versions

mental carbon Oct 13, 2023, 11:28 AM

#

Yeah, you can also make everything in multiple commits

#

And Squash the PR with a Tag

#

There are many different solutions to this problems

stray scroll Oct 13, 2023, 12:29 PM

#

kindred fractal You can make breaking changes in the minor versions

i'd prefer not to

#

and remember that my problem isn't just with the breaking changes part, but also the part of GU self-feeding itself by copying files from buildSrc to root

#

which I intend to eliminate, either with manual versioning or with a pinned plugin version

stray scroll Oct 13, 2023, 12:32 PM

#

mental carbon And Squash the PR with a Tag

with the plans I have in mind, that would almost necessarily mean rewriting GU in a single PR and getting that reviewed
and I myself would be reluctant to review such a PR

dull bison Oct 13, 2023, 1:03 PM

#

please just do the work and figure out the semantics afterwards I want 20.2 to be available for PR rebaseing before 20.3 lands

#

if you are not gonna do it I'm gonna do a lazy PR just wrapping the git stuff with ValueSource

mossy bobcat Oct 13, 2023, 1:12 PM

#

Can you make a "upcoming major version" branch of GU, do your PRs to there, merge them as they're reviewed, and then merge that branch to the main one to actually have a release? If that's really worry

stray scroll Oct 13, 2023, 1:16 PM

#

dull bison if you are not gonna do it I'm gonna do a lazy PR just wrapping the git stuff wi...

~~if you think that's easy, you've got another think coming~~

stray scroll Oct 13, 2023, 1:18 PM

#

mossy bobcat Can you make a "upcoming major version" branch of GU, do your PRs to there, merg...

hmmmmm

#

still, I've already said above that my problem is also the whole self-copying part of GU

dull bison Oct 13, 2023, 1:23 PM

#

stray scroll ~~if you think that's easy, you've got another think coming~~

or I'm gonna rewrite it using ValueSource in java (cause fuck groovy)

kindred fractal Oct 13, 2023, 1:42 PM

#

Imo GU itself could use manual versioning

#

Just because self-versioning it sounds like a recipe for disaster 😛

#

However now we just need to get 20.2 going, however hacky

dull bison Oct 13, 2023, 4:26 PM

#

uhm do we change to the new eventbus before or after the initial release?

kindred fractal Oct 13, 2023, 4:27 PM

#

Before

dull bison Oct 13, 2023, 4:29 PM

#

so is that pr in #1136448404495532133 the last one or do you have something coming up?

kindred fractal Oct 13, 2023, 4:31 PM

#

I have that PR (LMF), unlistenable (that will be changed to abstract), and a change to make phases work with mod busses

#

LMF is enough for our first release, the others will follow quickly

#

LMF has the jvm args so better do it before release

fallow sundial Oct 13, 2023, 5:18 PM

#

    private static Patch modify(Patch patch) {
        final var itr = patch.diffs.iterator();
        boolean isInsideDoc = false;
        while (itr.hasNext()) {
            final var next = itr.next();
            if (isInsideDoc) {
                if (next.op == Operation.INSERT && next.text.stripLeading().startsWith("*")) {
                    itr.remove();
                    if (next.text.stripLeading().startsWith("*/")) {
                        break;
                    }
                }
            } else {
                if (next.op == Operation.INSERT && next.text.stripLeading().startsWith("/**")) {
                    itr.remove();
                    isInsideDoc = true;
                }
            }
        }
        patch.recalculateLength();
        return patch;
    }

hmm

#

that should just do it theoretically

fallow sundial Oct 13, 2023, 7:38 PM

#

that looks quite stripped to me

📎 stripped.jar

mental carbon Oct 14, 2023, 8:33 AM

#

For fucks sake

#

I can not seem to create a tag which TeamCity recognizes

#

I forgot what the command is

#

Any combination I am trying is not working

kindred fractal Oct 14, 2023, 8:37 AM

#

You need a remote tag or stg

mental carbon Oct 14, 2023, 8:37 AM

#

?!?

fallow sundial Oct 14, 2023, 8:38 AM

#

you need an annotated tag

mental carbon Oct 14, 2023, 8:38 AM

#

Already tried maty

#

Not working

fallow sundial Oct 14, 2023, 8:38 AM

#

not a lightweight one

mental carbon Oct 14, 2023, 8:38 AM

#

annotated tags are not detected by JGit for some reason

kindred fractal Oct 14, 2023, 8:38 AM

#

Did you push the tag?

#

git push isn't enough

mental carbon Oct 14, 2023, 8:38 AM

#

Yes

#

I did

#

They appear perfectly fine on the webpage

dull bison Oct 14, 2023, 8:40 AM

#

https://github.com/neoforged/EclipseLaunchConfigs/tags

mental carbon Oct 14, 2023, 8:40 AM

#

Yeah that is an annotated tag

#

No dice

#

dull bison Oct 14, 2023, 8:41 AM

#

try manually deleting the tag first

mental carbon Oct 14, 2023, 8:41 AM

#

Already did

dull bison Oct 14, 2023, 8:43 AM

#

is this an issue of TC or GU

mental carbon Oct 14, 2023, 8:43 AM

#

It is a me issue XD

#

All other builds work

#

I just forgot how to make the damn tag

#

And how to push it properly

dull bison Oct 14, 2023, 8:43 AM

#

is there someone else that knows?

mental carbon Oct 14, 2023, 8:44 AM

#

cpw for sure

#

Probably any git guru

#

Because I am stupid

dull bison Oct 14, 2023, 8:47 AM

#

well problem is for cpw it's the middle of the night

mental carbon Oct 14, 2023, 8:50 AM

#

I will go grocery shopping and then I try it out properly one by one

tranquil salmon Oct 14, 2023, 9:14 AM

#

mental carbon I will go grocery shopping and then I try it out properly one by one

Maybe pushing a new commit fixes it

dull bison Oct 14, 2023, 9:39 AM

#

TODO:

eclipse
"rebase"
bus
(AT?)
GU
in this order

kindred fractal Oct 14, 2023, 10:04 AM

#

FML needs a new branch

mental carbon Oct 14, 2023, 10:04 AM

#

kindred fractal FML needs a new branch

Why?

kindred fractal Oct 14, 2023, 10:04 AM

#

Cause we want to keep maintaining it for 20.1 as well, don't we?

mental carbon Oct 14, 2023, 10:05 AM

#

kindred fractal Cause we want to keep maintaining it for 20.1 as well, don't we?

Until now there are no breaking changes in FML

kindred fractal Oct 14, 2023, 10:05 AM

#

We need to change the package name

#

And to update eventbus

#

And there's a mod bus-related breaking change that we'll need as well

mental carbon Oct 14, 2023, 10:06 AM

#

Okey

#

Eclipse just build and published

#

I indeed needed another commit after the annotation some how

tranquil salmon Oct 14, 2023, 10:09 AM

#

It seems like it didn't receive the git tag because it didn't do any fetching because it already had the required commit

mental carbon Oct 14, 2023, 10:09 AM

#

Yeah probably

#

I forgot to check

mossy bobcat Oct 14, 2023, 10:13 AM

#

If GU works anything like SimpleCI does, you need to make an annotated tag and then push the tag and commit at the same time with --follow-tags

mental carbon Oct 14, 2023, 10:14 AM

#

mossy bobcat If GU works anything like SimpleCI does, you need to make an annotated tag and t...

Nah it does not

#

It was just me being stupid

#

I pushed the commit first

#

Then tagged

#

Then pushed

#

The result was that TC already had build the commitz

mossy bobcat Oct 14, 2023, 10:14 AM

#

Yeah okay so not too different, just subtract the annotated tag bit

mental carbon Oct 14, 2023, 10:14 AM

#

And now did not pull new changes

#

So pushing the empty commit

#

Made it repull

#

And as such the tag followed suit

dull bison Oct 15, 2023, 7:42 PM

#

orion I just checked the results of the IDE survey we did on github and it seems that about as much people use vscode as those that use eclipse

#

do you know if we can support vscode runs too

mental carbon Oct 15, 2023, 8:14 PM

#

Sure, if somebody writes a wrapper for it

kindred fractal Oct 15, 2023, 8:20 PM

#

does it not work nicely with gradle?

dim sonnet Oct 15, 2023, 8:24 PM

#

The Java plugin for VS Code uses Eclipse Buildship iirc

mental carbon Oct 15, 2023, 8:24 PM

#

dim sonnet The Java plugin for VS Code uses Eclipse Buildship iirc

Not anymore

dim sonnet Oct 15, 2023, 8:25 PM

#

yeah, just saw and was about to link it https://devblogs.microsoft.com/java/new-build-server-for-gradle/

Microsoft for Java Developers

Nick Zhu

Elevating Java Development in Visual Studio Code: Experience the ne...

Introducing Build Server for Gradle In recent years, Gradle has become one of the most popular Java build tools due to its flexibility in configuring build processes and its powerful extensibility. In Visual Studio Code, users can import Gradle projects into their workspace for development.

#

using a "Build server protocol" now

mental carbon Oct 15, 2023, 8:58 PM

#

Closer to getting eclipse to work 😄

kindred fractal Oct 15, 2023, 9:08 PM

#

great

kindred fractal Oct 15, 2023, 9:09 PM

#

dull bison TODO: - eclipse - "rebase" - bus - (AT?) - GU in this order

ok still at the first item then

#

we need to repackage as well, I'll give it a shot tomorrow if nobody does it by then

mental carbon Oct 15, 2023, 9:09 PM

#

But I can tell you this much

#

The experience is completely useless:

kindred fractal Oct 15, 2023, 9:10 PM

#

why does it error xD

mental carbon Oct 15, 2023, 9:10 PM

#

No clue

#

I think groovy

tranquil salmon Oct 15, 2023, 9:11 PM

#

mental carbon No clue

Because you're missing the groovy plugin

mental carbon Oct 15, 2023, 9:11 PM

#

Yeah

#

But it is just completely ignoring everything else

#

Right now it has problems writing the damn launch config files....

#

So I am stuck

mental carbon Oct 15, 2023, 9:18 PM

#

tranquil salmon Because you're missing the groovy plugin

Added the plugin:

#

No dice

#

Same error count

fallow sundial Oct 15, 2023, 9:20 PM

#

groovy în eclipse is trash

#

don't even try

mental carbon Oct 15, 2023, 9:20 PM

#

The problem is i need to

#

It is hiding fucking errors in gradle

#

At this point, I am about to say F you to this IDE

#

I have been stuck at a screen which disappears on me when it completes

#

Does not indicate if it completes with an error or not

#

And if an error happens it hides wtf the error is, because it is like error #2915

#

So I don't see it

fallow sundial Oct 15, 2023, 9:22 PM

#

why did you import NG?

mental carbon Oct 15, 2023, 9:22 PM

#

It does automatically

fallow sundial Oct 15, 2023, 9:22 PM

#

well close the projects

mental carbon Oct 15, 2023, 9:23 PM

#

I already did that a minute ago

#

Turns out

#

It is not actually broken

#

it is just hiding the output directory

#

I could fucking puke

#

#

And there we go

#

#

So close yet so far...

#

#

Eclipse go home you are drunk

#

I am pulling the project name

#

FRom the eclipse model it self!

#

Arg

#

I am of to b ed

#

This IDE is the must frustrating piece of software i have seen in a couple of yeats

jagged agate Oct 15, 2023, 9:28 PM

#

Yet somehow, people are preferring it for deving thinkies

#

masochism or preference hmmm

cedar echo Oct 15, 2023, 9:30 PM

#

I have days where Eclipse is more forgiving than IntelliJ and I have days where Eclipse is such a thorn in my side that I never want to use it again.

#

Recently found out that Eclipse has been the cause of a majority of my audio issues with Linux while IntelliJ works mostly flawlessly. While I’m annoyed at Jet Brains for shoving CLion & PHPStorm behind a paywall, I can’t deny that they make the better IDEs.

tranquil salmon Oct 15, 2023, 10:09 PM

#

mental carbon FRom the eclipse model it self!

Did you try pulling the eclipse model from the subproject and not the root project?

tranquil salmon Oct 15, 2023, 10:16 PM

#

tranquil salmon Did you try pulling the eclipse model from the subproject and not the root proje...

I just tried it and it pulls the sub project name if you pull the eclipse model from the sub project whereas if you pull it from the root project it gives you the name of the root project

tranquil salmon Oct 15, 2023, 11:36 PM

#

mental carbon It is hiding fucking errors in gradle

You can also select the filter button in the problems view

mental carbon Oct 16, 2023, 7:23 AM

#

tranquil salmon Did you try pulling the eclipse model from the subproject and not the root proje...

I debug it again later, but yes I did

#

I was 100% sure in the Forge Subproject

#

Pulled the EclipseModel

#

And got "Kits" as the project name

tranquil salmon Oct 16, 2023, 7:25 AM

#

mental carbon And got "Kits" as the project name

I tried the same thing earlier and got the name of the subproject

dull bison Oct 16, 2023, 8:17 AM

#

I just remembered that I forgot the test mods in my todo list

mental carbon Oct 16, 2023, 8:17 AM

#

#

Support for loading in eclipse has been added to NG7

#

All components are generated natively

#

And are tested now

#

This was a massively major pain

#

But it is working

mental carbon Oct 16, 2023, 8:18 AM

#

tranquil salmon I tried the same thing earlier and got the name of the subproject

Yeah I derped 😄 I grabed the wrong project and passed it along when getting the eclipse model

#

At this point I need a working GradleUtils

#

@stray scroll or @tacit vale Any progress on GU? Or can I port it to be capable of Config Caching?

dull bison Oct 16, 2023, 8:21 AM

#

orion while they are working on GU you could have a look at the test mods

mental carbon Oct 16, 2023, 8:21 AM

#

dull bison orion while they are working on GU you could have a look at the test mods

I could, but I won't

#

As I said before

#

Right now NG7 does not support multi mod in one project workflows

#

It would need to be a multi mod environment in a multi project environment

#

And I am not sure how to engineer that properly.....

dull bison Oct 16, 2023, 8:23 AM

#

so we would need a testmods folder containing a sub-project per testmod

mental carbon Oct 16, 2023, 8:24 AM

#

Yes that would be the trivial answer

#

I am still trying to determine how to make that neatly

#

I will do some engineering / testing to figure out what we need 😄

#

But I am looking for a different name for test mods

#

Any ideas?

#

Validators?

#

Gates?

kindred fractal Oct 16, 2023, 8:25 AM

#

¯_(ツ)_/¯

mental carbon Oct 16, 2023, 8:36 AM

#

Validators

#

It is :d

dull bison Oct 16, 2023, 8:42 AM

#

functionality verifier

#

but validators is also fine (because it's short)

mental carbon Oct 16, 2023, 8:44 AM

#

Okey I am going to try starting with one

#

Lets see 😄

mental carbon Oct 16, 2023, 9:22 AM

#

So: Problem one:
Platform only exposes the dependencies as runtime dep

#

Not as compile time dep

#

Why o why

#

Okey

#

Fixed that

#

Was because of the use of the implementation config

#

And not the api config

#

Now DFU is F'ing me over

tranquil salmon Oct 16, 2023, 9:34 AM

#

#builds

stray scroll Oct 16, 2023, 9:35 AM

#

mental carbon <@607058472709652501> or <@277525077669445632> Any progress on GU? Or can I port...

i'll be working on it later this evening
on your end, we will need to look into modifying GU's build config to publish only on tagged commits (or perhaps, even a manually triggered publish instead?)
later on, I'll be disabling the build config so we don't publish 3.0.0-SNAPSHOTs

mental carbon Oct 16, 2023, 9:36 AM

#

I can make a new template in TC with a different trigger

#

That looks for a tag with a specific format for sure

#

Or one without a trigger at all

#

But IMHO

#

The manual one is basically useless

#

Because it requires way to many steps

#

Personal opinion: I don't hink that changing the release strategy is needed

#

But I will add the template

#

Just tell me what route you want

stray scroll Oct 16, 2023, 9:38 AM

#

probably a trigger for tags which match a regex of ^v?\d+\.\d+ (numbers followed by dot followed by numbers, optionally beginning with a v)

mental carbon Oct 16, 2023, 9:38 AM

#

That is not possible

#

I can do v(*)

#

TC Does not have regex support for those kinds of triggers

#

Only remainging capture

stray scroll Oct 16, 2023, 9:39 AM

#

ah, you're right

#

then v followed by anything, yeah

mental carbon Oct 16, 2023, 9:43 AM

#

Step one:

#

#

Make a test mod compile is working 😄

dim sonnet Oct 16, 2023, 9:53 AM

#

@stray scroll for the CompileStatic migration part of GradleUtils, I've done a small bit upstream and can offer a hand with the rest if you want

tranquil salmon Oct 16, 2023, 9:54 AM

#

@mental carbon #builds

stray scroll Oct 16, 2023, 9:54 AM

#

hmmm, gimme a few hours, once I'm chewing through GU

mental carbon Oct 16, 2023, 9:54 AM

#

tranquil salmon <@304594425286361088> <#911717039079579708>

Okey

#

Thanks

kindred fractal Oct 16, 2023, 10:02 AM

#

accesstransformer tests don't run anymore, interesting

#

seems like ModLauncher does not support launching on a classpath 🤔

#

I think I know... since we're launching from a legacy classpath, securejarhandler is unnamed module and I need ALL-UNNAMED in the jvmargs

mental carbon Oct 16, 2023, 10:03 AM

#

No it does not 😄

#

That is correct

#

If I remember correctly

kindred fractal Oct 16, 2023, 10:15 AM

#

Module cpw.mods.securejarhandler not found, required by cpw.mods.bootstraplauncher wtf

#

BSL normally excludes the SJH jar

#

I wonder if I need to un-exclude it

#

yeah that doesn't work, now it can't find the Consumer service from BSL thonk

kindred fractal Oct 16, 2023, 10:45 AM

#

I feel like something is wrong... it shouldn't be this complicated

#

java.lang.IllegalArgumentException: java.net.MalformedURLException: unknown protocol: union

#

:/

stray scroll Oct 16, 2023, 11:01 AM

#

~~ya love to see it~~

kindred fractal Oct 16, 2023, 11:03 AM

#

this shit is brittle AF

mental carbon Oct 16, 2023, 11:03 AM

#

You are trying to fight two different forces

#

JUnit especially likes to be the classloader in charge

#

But that is incompatible with ML

#

Which needs the module layer and its classloader

#

Testing it is pretty difficult because of that

kindred fractal Oct 16, 2023, 11:06 AM

#

SJH seems to die if it's loaded via classpath

#

then the modules are unnamed and the layer handling logic breaks down (because unnamed modules do not have a layer)

mental carbon Oct 16, 2023, 11:07 AM

#

kindred fractal SJH seems to die if it's loaded via classpath

Yes because it is not supposed to be

#

Try this:

#

tasks.withType(Test.class, { task ->
    task.doFirst {
        task.jvmArgs = [
                '--add-opens', 'java.base/java.util.stream=ALL-UNNAMED',
                '--add-opens', 'java.base/java.io=ALL-UNNAMED',
                '--add-opens', 'java.xml/jdk.xml.internal=ALL-UNNAMED'
        ]
    }
})

#

This is what I have in my mods unit test environment

kindred fractal Oct 16, 2023, 11:08 AM

#

that won't make SJH load via module path though hmm

mental carbon Oct 16, 2023, 11:09 AM

#

Not sure if it is needed

#

If you want to test the classloader within the unit test of AT

#

then you are shit out of luck

#

Because that is not directly possible as far as I know

#

Shit I need to test a FML modification that allows directories from the classpath to be loaded

kindred fractal Oct 16, 2023, 11:11 AM

#

it should work correctly with SJH provided I manage to load SJH on the module path

#

there should be a setting in gradle

mental carbon Oct 16, 2023, 11:11 AM

#

I would suggest: Take a look at BSL And build yourself a module class path

#

But no there is not a setting in gradle

#

Because JUnit AFAIK only runs on the legacy path

kindred fractal Oct 16, 2023, 11:12 AM

#

there's a chance that the org.javamodularity.moduleplugin plugin messes things up

#

should something call modularity.inferModulePath.set(false) then SJH will load on the classpath

mental carbon Oct 16, 2023, 11:16 AM

#

What determines the damn module name again?

kindred fractal Oct 16, 2023, 11:18 AM

#

yeah the module path is empty... damn it

mental carbon Oct 16, 2023, 11:22 AM

#

DAmnit

#

Detecting the Forge module does not work via the classpath

#

It only finds the directory

#

Not the relevant sources.3

#

Somebody up for a call

#

I am stuck in a issue with respects to the tests mods

#

And the discovery of Forge

#

While under that test environment

kindred fractal Oct 16, 2023, 11:24 AM

#

I'm in a train :/

mental carbon Oct 16, 2023, 11:25 AM

#

For the test mods we previously injected multiple mods

#

but NG7 does not support that

#

So I tried using a project dependency

#

that however has the issue that neither the Minecraftlocator

#

Nor the ClasspathLocator see forge

kindred fractal Oct 16, 2023, 11:26 AM

#

wdym it doesn't support that? why does NG care?

#

isn't it just a matter of adding some stuff to the classpath?

mental carbon Oct 16, 2023, 11:26 AM

#

It has no support for multiple distinct mods in its runs

#

It supports exactly one mod

#

And one mod only

#

If you want multiple mods, you need to go mutli project

#

But multi project userdev

#

And multi project forgedev

#

Are two massively different beasts

kindred fractal Oct 16, 2023, 11:27 AM

#

yeah ofc

#

why does NG need to know about the testmods?

mental carbon Oct 16, 2023, 11:27 AM

#

And for forgedev that is were I am stuck

kindred fractal Oct 16, 2023, 11:27 AM

#

can't it just put the extra files on the CP?

mental carbon Oct 16, 2023, 11:27 AM

#

kindred fractal why does NG need to know about the testmods?

It needs to create modules for them

mental carbon Oct 16, 2023, 11:27 AM

#

kindred fractal can't it just put the extra files on the CP?

No

#

that is the point

#

In the old days (NG6<) we injected test mods and forge together into the MOD_SOURCES

#

And then FML unfucked them all into seperate modules

#

But that injection system does not exist on NG7, kind of on purpose, so that we actually start using proper gradle stuff

#

Instead of hacks like that

#

The problem now is

#

That because Forge is now not part of MOD_SOURCES anymore, but on the classpath

#

It falls over

#

It just plainly fails to discover it

#

I added a fix so that it at least discovers the module

#

But the sources are just not there

#

Like the class I mean

#

Because the discoverer loads the resources via a file

#

But that does not work in "gradle" land

kindred fractal Oct 16, 2023, 11:30 AM

#

ah yeah it just doesn't know that it should compile the testmods?

mental carbon Oct 16, 2023, 11:30 AM

#

It does

#

Everything is technically on the classpath or the module path

#

It just does not discover them

#

#

Like that is the code that is used

#

To discover from the classpath

#

And that finds forge

#

But only the "build/resources/META-INF/mods.toml" part of forge (and as such the "build/resources" directory), not the build/classes directory

kindred fractal Oct 16, 2023, 11:31 AM

#

what is the String resource here?

mental carbon Oct 16, 2023, 11:32 AM

#

Meaning that allthough the test mod is found because it is part MOD_CLASSES/MOD_SOURCES, forge it self has only its resources discovered

mental carbon Oct 16, 2023, 11:32 AM

#

kindred fractal what is the `String resource` here?

META-INF/mods.toml or META-INF/Manifest.mf

#

Depending on if it is searching for mods or libraries

kindred fractal Oct 16, 2023, 11:33 AM

#

I see

#

so it does find the mods.toml of the testmods?

#

which is in a different directory than their class files?

mental carbon Oct 16, 2023, 11:34 AM

#

Yes and of forge

#

And it finds the test mod classes

#

Just not forge classes

kindred fractal Oct 16, 2023, 11:34 AM

#

oh

mental carbon Oct 16, 2023, 11:34 AM

#

Ignore the testmod, that is a redhearing here

#

The testmod is loading

#

Because we are in the testmods project

#

Which references the forge project

#

Which contains all the source and classes for minecraft it self

#

This works on a compiler level

#

But at runtime

#

FML has no idea how to construct the classpath

kindred fractal Oct 16, 2023, 11:36 AM

#

does forge not have a mods.toml or Manifest.ml?

mental carbon Oct 16, 2023, 11:36 AM

#

That is the problem

#

Those two directories are seperate on the CP

#

It sees the mods.toml in the build/resoources/main directory

kindred fractal Oct 16, 2023, 11:36 AM

#

ahh yeah

mental carbon Oct 16, 2023, 11:36 AM

#

But it has no idea that the build/classes/java/main also belongs to that

#

So it only creates a module with the resources directory

#

And not a combined one

#

And I don't know how to solve that

#

Unless I fallback to making multi mod support in a single project possible again

#

But I don't really want that

kindred fractal Oct 16, 2023, 11:38 AM

#

how does mod locating work when launching the forge project?

mental carbon Oct 16, 2023, 11:38 AM

#

It works there

kindred fractal Oct 16, 2023, 11:38 AM

#

shouldn't there also be two different folders

mental carbon Oct 16, 2023, 11:38 AM

#

Because then forge is in the MOD_CLASSES variable

#

And FML just combines the two listed directories

#

And calls it a day

#

But NG7 only puts the active project in there

#

Not any other

kindred fractal Oct 16, 2023, 11:39 AM

#

can't you override it via jvm args?

mental carbon Oct 16, 2023, 11:39 AM

#

That would mean manually managing all directories

#

Which is not something I personally enjoy

#

And which is rather sensitive

#

I will need to think about this for a minute

kindred fractal Oct 16, 2023, 11:41 AM

#

if you can get the directories from gradle in a reasonable way that might not be too painful

tranquil salmon Oct 16, 2023, 11:42 AM

#

Seems like the wait for termination option in launch groups when running a gradle task is a bug with buildship

mental carbon Oct 16, 2023, 11:43 AM

#

tranquil salmon Seems like the wait for termination option in launch groups when running a gradl...

Hmm?

tranquil salmon Oct 16, 2023, 11:45 AM

#

When running a gradle task from a launch group the launch group sees the gradle task has terminated so the wait for termination post launch action waits forever

mental carbon Oct 16, 2023, 11:46 AM

#

Oef

tranquil salmon Oct 16, 2023, 11:50 AM

#

Want to make a bug report to buildship? (that will probably never get looked at)

mental carbon Oct 16, 2023, 11:55 AM

#

tranquil salmon Want to make a bug report to buildship? (that will probably never get looked at)

Go ahead, I am not touching buildship / eclipse more then I need to

kindred fractal Oct 16, 2023, 12:15 PM

#

ok I figured out WHY this is happening

#

there is no nice way to tell gradle to use modules even if the current project does not use them

#

fuck gradle really

dull bison Oct 16, 2023, 12:22 PM

#

gradle and java modules are not friends ... gradle was not designed for that

dim sonnet Oct 16, 2023, 12:24 PM

#

It should be - JPMS is the default since Java 16

kindred fractal Oct 16, 2023, 12:25 PM

#

if your project is not modular there's no easy way you can use the module path from gradle

dim sonnet Oct 16, 2023, 12:25 PM

#

Can you configure a javacompile or run task to manually tell it to do so?

kindred fractal Oct 16, 2023, 12:25 PM

#

hard to bring the dependencies there

dim sonnet Oct 16, 2023, 12:26 PM

#

:/ the other option is make the project use Java modules

kindred fractal Oct 16, 2023, 12:27 PM

#

yeah

mental carbon Oct 16, 2023, 12:35 PM

#

So I don't really know how to solve the run mapping issue when it comes to multiple projects.......

kindred fractal Oct 16, 2023, 12:42 PM

#

@mental carbon do you think it's ok to make AT modular?

mental carbon Oct 16, 2023, 12:43 PM

#

No clue

kindred fractal Oct 16, 2023, 12:43 PM

#

it should be ok from what I can tell, but idk how to test it

mental carbon Oct 16, 2023, 12:43 PM

#

Take the existing stack in Kits

#

Update AT

#

And see what fucking happens 😄

kindred fractal Oct 16, 2023, 12:43 PM

#

help_me

#

it's still on java 8 heh

kindred fractal Oct 16, 2023, 1:16 PM

#

ok making progress

#

I managed to build the module path manually

#

now I need to deal with the usual classloader shenanigans

mental carbon Oct 16, 2023, 1:17 PM

#

I am reimplementing ClasspathLocator

#

To support discovery of common project outputs

#

Lets see if it works 😄

dull bison Oct 16, 2023, 1:20 PM

#

I'll be able to help in ~1hour

mental carbon Oct 16, 2023, 1:21 PM

#

I just realised that my technique likely won't work

#

Why the fuck is there no way to know what in the classpath belongs to gether

#

And what not....

nova sundial Oct 16, 2023, 1:24 PM

#

kindred fractal there is no nice way to tell gradle to use modules even if the current project d...

there is, it just needs a bit of convincing. You have to manually configure a javaExec task by moving the classpath to the module path variable

#

well, not necessarily nice but it works

stray scroll Oct 16, 2023, 1:25 PM

#

it just needs a bit of... 'motivation' selfstabolb

kindred fractal Oct 16, 2023, 1:28 PM

#

is this too aggressive? it works 😛

#

I'll first fix these tests and then let someone come up with something better if they want to 😄

dim sonnet Oct 16, 2023, 1:34 PM

#

Nitpick: use var instead of def for variables that stay as a single type, or ideally final

#

But aside from that, looks good enough for now 🙂

mental carbon Oct 16, 2023, 2:12 PM

#

#

BAM

#

This allows the ModSources option in the DSL to scan for other projects

#

So you still need a multi project setup if you want to run mutliple forge mods in a single environment

#

But, but but you can now create a master over arching build

#

And reference source sets from different projects

#

And it will work 😄

#

@dull bison Does that solve your wish for the test mods?

#

@stray scroll How far along are you with GU?

stray scroll Oct 16, 2023, 2:16 PM

#

uh... lemme get back to you in about 30 minutes

mental carbon Oct 16, 2023, 2:16 PM

#

mental carbon <@213343613583622144> Does that solve your wish for the test mods?

Right now, I only have a Client run for a test mod, but we can easily add others

mental carbon Oct 16, 2023, 2:16 PM

#

stray scroll uh... lemme get back to you in about 30 minutes

Perfect, will 2,5 hours work for you? I need to go to the gym to loose some more fat 😄 And clear my brain from this madness today

stray scroll Oct 16, 2023, 2:17 PM

#

wait a minute, there's no pause button on the TC menu...?

mental carbon Oct 16, 2023, 2:17 PM

#

There is

stray scroll Oct 16, 2023, 2:17 PM

#

there doesn't seem to be, for the Build config under GU

#

https://teamcity.neoforged.net/buildConfiguration/MinecraftForge_GradleUtils_GradleUtils__Build?buildTypeTab=buildTypeSettings

mental carbon Oct 16, 2023, 2:18 PM

#

Give me a second

#

#

It is in the project

stray scroll Oct 16, 2023, 2:18 PM

#

ah, project-wide

mental carbon Oct 16, 2023, 2:18 PM

#

Not in the build settings

stray scroll Oct 16, 2023, 2:21 PM

#

paused, thanks

#

ah, my mistake was looking on the Actions dropdown on the build config main view, rather than from the build config's settings page

#

well, that's a lesson learned

mental carbon Oct 16, 2023, 2:28 PM

#

@stray scroll With respect to the build config, if you look at the settings.kts, you will see it referencing the build template: MinecraftForge_BuildMainBranches a bunch of times, which is what defines the branches to build. If you replace this with BuildMainBranchesTriggerOnVersionTag (note without the MinecraftForge_-prefix now, as it is a new template), CI will only trigger on builds with tags in the form of v*

stray scroll Oct 16, 2023, 2:28 PM

#

I shall do that on next commit to main

#

actually, hmmm

#

@mental carbon is it possible to make a custom publish template, which gates the publish build step behind a regex matching the ref (i.e. branch/tag)?

#

so it still builds the branch for every commit, but only publishes for certain refs (branches/tags)

mental carbon Oct 16, 2023, 2:39 PM

#

No not directly, but we can make a seperate build configuration

#

That does not publish

#

Well it is possible

#

But a seperate configuration like the "Secondary branches" one would be much easier to implement

#

And configure

stray scroll Oct 16, 2023, 2:39 PM

#

my understanding is it should be possible, with a granular execution condition on the step which does a regex match against the parameter that TeamCity exposes for the VCS branch

keen hearth Oct 16, 2023, 2:40 PM

#

Hacky solution: you can enable/disable the publish task in the build script depending on the branch name

stray scroll Oct 16, 2023, 2:41 PM

#

hmmm. need to think on this for a few more minutes
i'd ask you to continue looking into it, though

mental carbon Oct 16, 2023, 2:41 PM

#

stray scroll hmmm. need to think on this for a few more minutes i'd ask you to continue looki...

No problem

stray scroll Oct 16, 2023, 2:42 PM

#

Orion, what is the publication_branches_regex parameter?

#

it doesn't seem to be used

mental carbon Oct 16, 2023, 2:43 PM

#

I am on the move sci, I can't remember now, would you pin the question please so that I can get back to you?

stray scroll Oct 16, 2023, 2:43 PM

#

stray scroll Orion, what is the `publication_branches_regex` parameter?

#

pinned

kindred fractal Oct 16, 2023, 3:03 PM

#

holy shit

#

only took like 5 hours xD

mental carbon Oct 16, 2023, 3:05 PM

#

kindred fractal only took like 5 hours xD

Welcome to the club

#

That is why this port is taking so long

#

All these little fucking things

kindred fractal Oct 16, 2023, 3:07 PM

#

yeah...

feral moat Oct 16, 2023, 3:11 PM

#

Wait Orion does your latest commit means it supports one project multi sourcesets as long as there is only one mod per sourceset? Or is that not supported at all anymore and I will need to refactor all my projects to being multi project

mental carbon Oct 16, 2023, 3:22 PM

#

feral moat Wait Orion does your latest commit means it supports one project multi sourceset...

Right now a given project can only hold a single mods.toml

#

But can be made up out of many source sets

feral moat Oct 16, 2023, 3:23 PM

#

Sad

#

But understood

mental carbon Oct 16, 2023, 3:24 PM

#

I am working on a design for better dealing with this

#

More akin to dynproj for userdev

#

But I have not gotten there yet

#

Other things have a higher priority

feral moat Oct 16, 2023, 3:28 PM

#

Ah fair enough, so it is possible if I wait long enough before porting my mods past 1.20.1 then I may be able to get away with not having to massively restructure my buildscripts. But I do agree that getting a 1.20.2 version out and functioning is definitely more important than supporting some of the edge case multi project setups for the initial release

kindred fractal Oct 16, 2023, 3:41 PM

#

coremods also has a testmod setup... I wonder if that one will give me a headache too 🙃

stray scroll Oct 16, 2023, 3:43 PM

#

first PR for GradleUtils is up

#1.20.2