1.20.2 | The NeoForged Project | Page 7

frail oriole Sep 23, 2023, 9:58 PM

#

so it was super cursed

quiet talon Sep 23, 2023, 9:58 PM

#

The last time I touched it it basically just did a bit of fiddling to run runClient and that was it, the game booted but you don't get debugging or anything that you get from the run config

#

and it took ages to boot, because it was doing all the spaghetti that runClient did and not using the ide's capabilities

frail oriole Sep 23, 2023, 9:59 PM

#

i was debugging the runs using runClient in idea too

#

until this started working today heh

mental carbon Sep 23, 2023, 9:59 PM

#

frail oriole i was debugging the runs using runClient in idea too

Yeah but idea supports that natively

#

It adds the --debug-jvm under the hood

#

And then attaches the jvm

#

Which eclipse seems not to do

frail oriole Sep 23, 2023, 9:59 PM

#

ah. does buildship not?

#

buildship sounds like buildshit

mental carbon Sep 23, 2023, 9:59 PM

#

As far as I can tell no

quiet talon Sep 23, 2023, 10:00 PM

#

it is total garbage, yes

mental carbon Sep 23, 2023, 10:00 PM

#

shadows is right on that end

frail oriole Sep 23, 2023, 10:00 PM

#

heh ok

#

anyway orion

quiet talon Sep 23, 2023, 10:00 PM

#

Yeah, executing the task from the Gradle Executions pane does not launch debugging capabilities or anything of the sort

mental carbon Sep 23, 2023, 10:00 PM

#

@quiet talon If you can find me a working specification anywhere on paper, I will look at it

#

But I won't implement the garbage that we have in NG/FG 6 without a specification of what I am supposed to write and where

frail oriole Sep 23, 2023, 10:00 PM

#

i think the point is orion, that doesn't exist

quiet talon Sep 23, 2023, 10:00 PM

#

^

mental carbon Sep 23, 2023, 10:00 PM

#

WTF

frail oriole Sep 23, 2023, 10:00 PM

#

eclipse has been hot garbage for 20+ years. why stop now?

quiet talon Sep 23, 2023, 10:00 PM

#

everything points to nothing, even buildship has no documentation

#

There might be something in the source code of eclipse for the launch file parser

frail oriole Sep 23, 2023, 10:01 PM

#

however, the launch profile spec is basically static and hasn't changed in about that long either

quiet talon Sep 23, 2023, 10:01 PM

#

but there certainly isn't a formal spec doc

mental carbon Sep 23, 2023, 10:01 PM

#

quiet talon but there certainly isn't a formal spec doc

I am fine with it not being a formal spec doc

#

I just want a source file, that tells me: read X for the main class, read Y for the jvm args

#

Etc

#

So that I know WHAT to write were

quiet talon Sep 23, 2023, 10:02 PM

#

Well its somewhere in here https://git.eclipse.org/c/

mental carbon Sep 23, 2023, 10:02 PM

#

I am willing to copy garbage code, but not willing to copy and maintain garbage code that I do not understand

frail oriole Sep 23, 2023, 10:02 PM

#

that's so helpful LUL

mental carbon Sep 23, 2023, 10:02 PM

#

Like even the tiniest scrap suffices to get me to add it

#

But I need something

#

To hold on to

frail oriole Sep 23, 2023, 10:03 PM

#

is the gradle eclipse plugin fubar then?

#

as a referent?

quiet talon Sep 23, 2023, 10:03 PM

#

https://github.com/eclipse/buildship/blob/master/org.eclipse.buildship.core/src/main/java/org/eclipse/buildship/core/internal/launch/GradleLaunchConfigurationManager.java

#

maybe™️

#

problem is I don't know what I'm looking for entirely

#

or how you even work off of buildship

#

Contains the attributes that describe a Gradle run configuration.

#

see that sounds useful

#

https://github.com/eclipse/buildship/blob/master/org.eclipse.buildship.core/src/main/java/org/eclipse/buildship/core/internal/launch/GradleRunConfigurationAttributes.java

#

but what do you do with this

#

I don't know if this makes eclipse launch configs or its for launching eclipse from gradle tasks

frail oriole Sep 23, 2023, 10:05 PM

#

former for sure

quiet talon Sep 23, 2023, 10:07 PM

#

ILaunchConfiguration is an eclipse src file

#

so lets see if I can go hunt that one down

#

https://git.eclipse.org/c/platform/eclipse.platform.debug.git/tree/org.eclipse.debug.core/core/org/eclipse/debug/core/ILaunchConfiguration.java

frail oriole Sep 23, 2023, 10:08 PM

#

so orion, somehow we need to defer configuration of runs until the type has been fully realized, right?

#

ProjectUtils.afterEvaluate guessing that didn't do the trick?

mental carbon Sep 23, 2023, 10:11 PM

#

It will

#

But then I need to also reconfigure the run

#

Which is fine

#

I will try that in the morning

frail oriole Sep 23, 2023, 10:11 PM

#

ok no worries

#

i'm out for a bit, but i'll take a look at eclipse in a bit

#

it seems that you can get the realized state in teh configure, but i can see why you could get into SOF tangles here. you need to stash it somewhere you can act on it later.

quiet talon Sep 23, 2023, 10:32 PM

#

Gonna fiddle around eclipse.debug.core and see what can be deciphered there

#

this is horrible

stray scroll Sep 23, 2023, 10:46 PM

#

shadows discovering the code powering his IDE of choice kek

quiet talon Sep 23, 2023, 10:48 PM

#

I cannot fathom how this is transformed from xml into the actual launch object

#

I see nothing that would be doing that

tranquil salmon Sep 23, 2023, 10:52 PM

#

https://github.com/eclipse-platform/eclipse.platform/blob/master/debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchConfigurationInfo.java#L603-L671

lethal bane Sep 23, 2023, 10:53 PM

#

those names feel very enterprise thinkies

quiet talon Sep 23, 2023, 10:55 PM

#

I see

#

this is even worse than I had imagined, isn't it

#

it doesn't deserialize anything to an object, it just keeps it in this big fuckfest of a string->obj map from the xml

#

scrim

frail oriole Sep 24, 2023, 12:00 AM

#

LOL

quiet talon Sep 24, 2023, 12:03 AM

#

Eclipse runs (.launch files) are declared as XML files with the outermost element being named launchConfiguration. The launchConfiguration must declare a type attribute, where the type is any launchConfigurationType declared by an Eclipse extension.

The sub-elements of a launchConfiguration are a series of entries eclipse has confusingly named Attributes (not to be confused with XML attributes). The possible Attributes are declared here https://github.com/eclipse-platform/eclipse.platform/blob/master/debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchConfigurationInfo.java#L62-L67

Each attribute has a type, a key, and a value. For primitive attributes (booleanAttribute, intAttribute, stringAttribute), the value is inlined in the object.
For example:
<booleanAttribute key="test_bool" value=false/>
<intAttribute key="hello" value="goodbye"/>
<stringAttribute key="hello" value="goodbye"/>

For complex attributes (setAttribute, mapAttribute, listAttribute), the value is composed of the child elements of the attribute element.
These child elements must be of the correct type for the specific collection:

setEntry for setAttribute
- Has attribute value
mapEntry for mapAttribute
- Has attributes key and value
listEntry for listAttribute
- Has attribute value

The value attribute of a collection sub-element should be any XML primitive but is usually always a string. The key attribute of a mapEntry is always a string.

Buildship provides the following launchConfigurationTypes:

org.eclipse.buildship.core.launch.runconfiguration
- Delegates to https://github.com/eclipse/buildship/blob/master/org.eclipse.buildship.core/src/main/java/org/eclipse/buildship/core/internal/launch/GradleRunConfigurationDelegate.java
org.eclipse.buildship.core.launch.test.runconfiguration
- Delegates to https://github.com/eclipse/buildship/blob/master/org.eclipse.buildship.core/src/main/java/org/eclipse/buildship/core/internal/launch/GradleTestRunConfigurationDelegate.java

Eclipse's JDT Debug module provides the following launchConfigurationTypes:

org.eclipse.debug.core.groups.GroupLaunchConfigurationType
- Delegates to (I think) https://github.com/eclipse-platform/eclipse.platform/blob/master/debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/groups/GroupLaunchConfigurationDelegate.java
- Doesn't declare that it delegates to this in the plugin.xml file, so idk, but the name matches

Eclipse natively provides the following launchConfigurationTypes:

org.eclipse.jdt.launching.localJavaApplication
org.eclipse.jdt.junit.launchconfig

#

So we have a list of types, I guess

#

The definitions of the components of the types is still a mystery to me™️

#

Of these FG6 used the buildship runconfiguration, the JDT GroupLaunchConfiguration, and the eclipse localJavaApplication runs

tranquil salmon Sep 24, 2023, 12:10 AM

#

https://github.com/eclipse-jdt/eclipse.jdt.debug/blob/master/org.eclipse.jdt.launching/launching/org/eclipse/jdt/launching/IJavaLaunchConfigurationConstants.java
Here's the constants class which includes attribute names for localJavaApplication
And here's the definition in plugin.xml: https://github.com/eclipse-jdt/eclipse.jdt.debug/blob/master/org.eclipse.jdt.launching/plugin.xml#L50-L63

quiet talon Sep 24, 2023, 12:11 AM

#

The delegate thing seems to be worthless

#

whats of relevance are those constant files

frail oriole Sep 24, 2023, 12:11 AM

#

my speculation is that we can just write the right xml files we'll be ok

quiet talon Sep 24, 2023, 12:12 AM

#

so we'll need to source those for each type

frail oriole Sep 24, 2023, 12:13 AM

#

i don't think we'll find what orion was lookign for tho, a library that does this shit for us

#

so we're probably going to have to just bitbang it

quiet talon Sep 24, 2023, 12:13 AM

#

yeah, no such library exists whatsoever

frail oriole Sep 24, 2023, 12:13 AM

#

guess we have to write one 😦

quiet talon Sep 24, 2023, 12:13 AM

#

so it'll be a lot of splicing together what we have and what we can piece together

frail oriole Sep 24, 2023, 12:16 AM

#

gimme a minute. i'm going to see what orion is using to do the intellij stuffs

tranquil salmon Sep 24, 2023, 12:16 AM

#

quiet talon yeah, no such library exists whatsoever

We could also make a pr to buildship and gradle

quiet talon Sep 24, 2023, 12:16 AM

#

I can't even get buildship's environment working, lol

#

the installer doesn't run

frail oriole Sep 24, 2023, 12:21 AM

#

this is what orion is using to do the IDEA integration: https://docs.gradle.org/current/javadoc/org/gradle/plugins/ide/idea/package-summary.html

#

this is the equivalent for eclipse: https://docs.gradle.org/current/javadoc/org/gradle/plugins/ide/eclipse/package-summary.html

quiet talon Sep 24, 2023, 12:22 AM

#

I have the slightest feeling that if the eclipse gradle plugin could generate runs we'd be doing that

frail oriole Sep 24, 2023, 12:22 AM

#

it seems it can

#

https://github.com/gradle/gradle/tree/master/subprojects/ide/src/main/java/org/gradle/plugins/ide

#

but iirc this shit was borked in eclipse

#

ah i see what he's doing

#

for intellij he's using the custom extension - ``` final TaskTriggersConfig taskTriggers = ((ExtensionAware) ideaExtension).getExtensions().getByType(TaskTriggersConfig.class);
taskTriggers.afterSync(idePostSyncTask);

#

no such thing exists for eclipse i expect

#

right

#

lets find an eclipse

#

this shit used to be SO cursed

quiet talon Sep 24, 2023, 12:26 AM

#

this xml syntax is garbage wtf

#

they have types for outer objects (booleanAttribute, intAttribute, stringAttribute) and then collections

frail oriole Sep 24, 2023, 12:26 AM

#

yeah

quiet talon Sep 24, 2023, 12:26 AM

#

but if you use a collection you don't declare the type of the collection objects

frail oriole Sep 24, 2023, 12:26 AM

#

xml is so fucking cursed

quiet talon Sep 24, 2023, 12:26 AM

#

just that its an entry in the collection

frail oriole Sep 24, 2023, 12:26 AM

#

as i said tho. this shit was defined in about 2001 and hasn't changed.

#

i believe, if you look hard enough you can even see the IBM fingerprints when they split off the visual age crowd who went on to make eclipse

#

The installation process is taking longer than usual: Downloading org.eclipse.ui.navigator.resources

#

ohno

#

eclipse have been working hard on making their install process as smooth as possible I see

#

that's literally shown up doing the install. 💯

#

it looks like the theme is still superborked on gnome. 💯

#

quiet talon Sep 24, 2023, 12:31 AM

#

quiet talon Eclipse runs (`.launch` files) are declared as XML files with the outermost elem...

frail oriole Sep 24, 2023, 12:31 AM

#

love how the elements don't show up properly.

quiet talon Sep 24, 2023, 12:31 AM

#

Yeah I just install DevStyle and try to forget that eclipse's default theme exists

frail oriole Sep 24, 2023, 12:32 AM

#

the problem is that the fonts are all borked

quiet talon Sep 24, 2023, 12:32 AM

#

Finished writing a description of eclipse's XML xyzAttribute system up there

#

now just to decipher all the keys for the known run types, I guess

frail oriole Sep 24, 2023, 12:38 AM

#

ok. this is quite quite shit isn't it

#

you can't debug gradle at all

quiet talon Sep 24, 2023, 12:38 AM

#

nop

frail oriole Sep 24, 2023, 12:39 AM

#

i have no idea how i can help 😦

#

cos i can't debug into gradle to see what i can do

quiet talon Sep 24, 2023, 12:39 AM

#

I think we can give up trying to get gradle to do things for us, we just need to find the constants for each of the run configs we care about and write what they mean somewhere

#

Maybe write a little library to emit xml in eclipse's shitty attribute format

frail oriole Sep 24, 2023, 12:41 AM

#

sad, because the new intellij integration is amazing

quiet talon Sep 24, 2023, 12:41 AM

#

Yes well intellij in general is amazing compared to eclipse :p
eclipse is a 20+ year old hellscape of misery

frail oriole Sep 24, 2023, 12:41 AM

#

i know 😦

#

it was amazing. in 2003

#

it blew everyone's mind

#

and also jbuilder, visualcafe and togetherj out of the water.

quiet talon Sep 24, 2023, 12:42 AM

#

I'm working on translating what I have in that message to a gist and will then work on specifying each of the relevant configs

frail oriole Sep 24, 2023, 12:42 AM

#

k

quiet talon Sep 24, 2023, 12:42 AM

#

Coeh linked the constants for the eclipse "normal" run config, and I have the one for buildships's gradle task one (granted its undocumented, but I have it)

#

the GroupLaunch is another beast, as I don't see constants for it, but it looks like it might be autogenerated as a list of runs and not much more

#

i.e.

<launchConfiguration type="org.eclipse.debug.core.groups.GroupLaunchConfigurationType">
  <stringAttribute key="org.eclipse.debug.core.launchGroup.0.action" value="NONE"/>
  <booleanAttribute key="org.eclipse.debug.core.launchGroup.0.adoptIfRunning" value="false"/>
  <booleanAttribute key="org.eclipse.debug.core.launchGroup.0.enabled" value="true"/>
  <stringAttribute key="org.eclipse.debug.core.launchGroup.0.mode" value="run"/>
  <stringAttribute key="org.eclipse.debug.core.launchGroup.0.name" value="Apotheosis - prepareRunClient"/>
  <stringAttribute key="org.eclipse.debug.core.launchGroup.1.action" value="NONE"/>
  <booleanAttribute key="org.eclipse.debug.core.launchGroup.1.adoptIfRunning" value="false"/>
  <booleanAttribute key="org.eclipse.debug.core.launchGroup.1.enabled" value="true"/>
  <stringAttribute key="org.eclipse.debug.core.launchGroup.1.mode" value="inherit"/>
  <stringAttribute key="org.eclipse.debug.core.launchGroup.1.name" value="Apotheosis - runClientSlim"/>
</launchConfiguration>

frail oriole Sep 24, 2023, 12:43 AM

#

yeah it is

#

i think it's supposed to be a launch sequence

quiet talon Sep 24, 2023, 12:44 AM

#

Probably. I was looking into the history of it and it was never documented. It was originally written for Eclipse CDT and then randomly ported to JDT at some point

#

idk what lunatics use eclipse for C/C++

true pivot Sep 24, 2023, 1:09 AM

#

is there a good reason to support eclipse if intellij does stuff better?

frail oriole Sep 24, 2023, 1:24 AM

#

because people want it. see coeh and shadows

mental carbon Sep 24, 2023, 5:42 AM

#

Yeah

#

This is also part of the core of ngnext

#

Like this is not limited to forge dev

#

The run system is part of common

#

And w need a solution for thus

#

I have no problem writing xml files

#

But h need some form of spec or documentation so that I can understand the code

quiet talon Sep 24, 2023, 5:52 AM

#

I'm working on it

#

its just a very lengthy process

mental carbon Sep 24, 2023, 5:57 AM

#

I know

#

Which is why I added a comment

#

Thank you for tackling this

quiet talon Sep 24, 2023, 6:00 AM

#

I almost have a formal spec for the shitty eclipse xml attribute garbage

#

alright, basic intro and E-Attributes done https://gist.github.com/Shadows-of-Fire/3c7dd1bacdcddd9476b7b4eafb9f37a9

#

now I just need to write down all the keys for the run types

mental carbon Sep 24, 2023, 6:32 AM

#

quiet talon alright, basic intro and E-Attributes done <https://gist.github.com/Shadows-of-F...

Nice!

quiet talon Sep 24, 2023, 8:11 AM

#

@mental carbon how readable is this https://gist.github.com/Shadows-of-Fire/3c7dd1bacdcddd9476b7b4eafb9f37a9#local-java-application

mental carbon Sep 24, 2023, 8:19 AM

#

quiet talon <@304594425286361088> how readable is this <https://gist.github.com/Shadows-of-F...

That is very readable. Question: When I generate one today with NG6, I get however a different file structure with groups etc..... Do you know how that works

quiet talon Sep 24, 2023, 8:20 AM

#

So there are three launches of relevance to us

#

org.eclipse.jdt.launching.localJavaApplication (the one I have detailed thus far)

#

org.eclipse.buildship.core.launch.runconfiguration (which can run gradle tasks)

#

and org.eclipse.debug.core.groups.GroupLaunchConfigurationType (the one you're talking about)

#

The first one is the type which actually launches a main class and starts a JVM

#

the second runs gradle tasks and is provided by buildship

mental carbon Sep 24, 2023, 8:22 AM

#

Ahhh, I am starting to see a picture here 😄

#

So group then runs one after the other?

quiet talon Sep 24, 2023, 8:22 AM

#

the third chains together multiple runs, executing them in sequence. We use that one to run a org.eclipse.buildship.core.launch.runconfiguration to do the preparation of resources

#

and then run a org.eclipse.jdt.launching.localJavaApplication to boot the game

mental carbon Sep 24, 2023, 8:22 AM

#

Aaaah

#

Now I am starting to understand

quiet talon Sep 24, 2023, 8:23 AM

#

I have ample documentation on the buildship runconfiguration and the JDT localJavaApplication to make this doc for them

#

But GroupLaunchConfigurationType I have yet to find the constants class for

#

Granted, it can't be that complicated

#

it just delegates to other runs

#

  <stringAttribute key="org.eclipse.debug.core.launchGroup.1.action" value="NONE"/>
  <booleanAttribute key="org.eclipse.debug.core.launchGroup.1.adoptIfRunning" value="false"/>
  <booleanAttribute key="org.eclipse.debug.core.launchGroup.1.enabled" value="true"/>
  <stringAttribute key="org.eclipse.debug.core.launchGroup.1.mode" value="inherit"/>
  <stringAttribute key="org.eclipse.debug.core.launchGroup.1.name" value="Apotheosis - runClientSlim"/>

#

but I'm not sure of what the keys there actually mean
FG6 has NONE/false/true for the first three in all cases, and then run/inherit for the .mode option
Granted, the .name and .enabled keys are self explanatory

#

but .action, .adoptIfRunning, and .mode are a mystery

#

it is likely that .mode is one of run / debug / inherit

mental carbon Sep 24, 2023, 8:26 AM

#

I don't understand how eclipse maintains this

#

This is horrible

quiet talon Sep 24, 2023, 8:27 AM

#

they don't, lol
this shit has probably been untouched for 20 years

fallow sundial Sep 24, 2023, 8:27 AM

#

does ngnext have a copy ide resources thing

mental carbon Sep 24, 2023, 8:27 AM

#

It invokes processResources for now

#

So what ever that works

quiet talon Sep 24, 2023, 8:28 AM

#

the code is scattered across ten thousand repos and is all kinds of haunted

mental carbon Sep 24, 2023, 8:28 AM

#

No wonder that I had no idea what this was doing

frozen vapor Sep 24, 2023, 8:28 AM

#

it sounds to me like eclipse is just a monolithic microservices application

fallow sundial Sep 24, 2023, 8:29 AM

#

mental carbon It invokes processResources for now

well that doesn't help

mental carbon Sep 24, 2023, 8:29 AM

#

Why not?

#

It works for idea and as far as I can tell also eclipse

#

But it might not work with the new eclipse integration

#

So we need to research that accordingly

fallow sundial Sep 24, 2023, 8:30 AM

#

just process resources does nothing if you run with the IJ runner or eclipse

#

the part where the resources are copied to the out/bin dir is the "functional" part

quiet talon Sep 24, 2023, 8:30 AM

#

Yeah you have to copy the stuff from /build to /bin for eclipse

mental carbon Sep 24, 2023, 8:31 AM

#

Okey

#

Well that is trivial to add later

#

One step at a time

#

Lets get eclipse runs working

#

Before we look at that

#

I knwowe had the code

#

And that part is okey to understand

#

So it should be rather trivial to port over

quiet talon Sep 24, 2023, 8:31 AM

#

Ultimately we'll be doing mostly the same thing fg6 was doing before

#

Maybe we can clean up the xml writer a bit

mental carbon Sep 24, 2023, 8:32 AM

#

We sure as hell well

#

I will be putting this all in a seperate library

#

Cause I think that the eclipse and gradle community can take advantage of that

#

NGNext will just be the primary consumer

tranquil salmon Sep 24, 2023, 8:32 AM

#

quiet talon but `.action`, `.adoptIfRunning`, and `.mode` are a mystery

.action is either NONE, WAIT_FOR_TERMINATION, DELAY, or OUTPUT_REGEXP
if .action is DELAY then .actionParam is how many seconds to wait
if .action is OUTPUT_REGEXP then .actionParam is the regex to wait for in the console

quiet talon Sep 24, 2023, 8:32 AM

#

There's more keys I didn't document but most of them are esoteric gibberish

#

Like you can pass in a custom classpath if you can somehow figure out what format eclipse wants it to be in

tranquil salmon Sep 24, 2023, 8:34 AM

#

.adoptIfRunning is whether to use the currently executing instance if the run config is already running

#

.mode is either inherit, profile, coverage, debug, or run

quiet talon Sep 24, 2023, 8:36 AM

#

idk where you're hunting all these things down but i'll take it

mental carbon Sep 24, 2023, 8:37 AM

#

Yes please

tranquil salmon Sep 24, 2023, 8:37 AM

#

Through a group launch configuration I already have

mental carbon Sep 24, 2023, 8:37 AM

#

@tranquil salmon do you know where the docu on this shit is?

quiet talon Sep 24, 2023, 8:37 AM

#

There are no docs 🙃

#

I've been reading through random bits of eclipse source code and random stackoverflow pages all day lmao

mental carbon Sep 24, 2023, 8:37 AM

#

.......

quiet talon Sep 24, 2023, 8:38 AM

#

Most of the stuff relevant to group launches just lives in GroupLaunchConfigurationDelegate which is... idk

#

i think its only on the eclipse git repo, it wasn't on the one coeh linked earlier (the github one)

mental carbon Sep 24, 2023, 8:38 AM

#

quiet talon I've been reading through random bits of eclipse source code and random stackove...

Thank you for doing that!

quiet talon Sep 24, 2023, 8:39 AM

#

https://git.eclipse.org/c/platform/eclipse.platform.debug.git/tree/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/groups/GroupLaunchConfigurationDelegate.java for groups

tranquil salmon Sep 24, 2023, 8:39 AM

#

Here's the parsing code for group launches: https://github.com/eclipse-platform/eclipse.platform/blob/master/debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/groups/GroupLaunchConfigurationDelegate.java#L318-L381

tranquil salmon Sep 24, 2023, 8:40 AM

#

quiet talon <https://git.eclipse.org/c/platform/eclipse.platform.debug.git/tree/org.eclipse....

eclipse platform has already migrated to github

quiet talon Sep 24, 2023, 8:40 AM

#

Weird, I tried a file search for GroupLaunch on the github repo and nothing came up

fallow sundial Sep 24, 2023, 8:42 AM

#

the only sane way to figure out what the properties do is to make a launch config with the gui and play with it

tranquil salmon Sep 24, 2023, 8:43 AM

#

I have contributed to eclipse multiple times

quiet talon Sep 24, 2023, 8:43 AM

#

fallow sundial the only sane way to figure out what the properties do is to make a launch confi...

except for the ones not exposed in the gui 🙃

#

anyhow I'll do buildship before detailing the group

#

Granted buildship has decided to also not leave any documentation on their shit

#

but at least they didn't fucking prefix all their internal keys with org.what.the.mcfuck.blah

#

imagine a json file where your type is org.blah.myland.MyType and then you also prefix all your values as "org.blah.myland.MY_VALUE": "the_value"

fallow sundial Sep 24, 2023, 8:46 AM

#

https://github.com/neoforged/EclipseLaunchConfigs hm

GitHub

GitHub - neoforged/EclipseLaunchConfigs: A Java library for generat...

A Java library for generating Eclipse launch configurations - GitHub - neoforged/EclipseLaunchConfigs: A Java library for generating Eclipse launch configurations

tranquil salmon Sep 24, 2023, 8:46 AM

#

Personally I don't use the gradle tasks view since to use it I have to wait for it to load gradle tasks for every gradle project

quiet talon Sep 24, 2023, 8:47 AM

#

yeah I don't touch it either

#

but the launch group doing the copy resources thing is neat

#

prior to that I was running processResources manually to copy keys which depended on replacement, and I had procR copying everything from /build to /bin

#

which is... slow? Apparently?
According to maty anyway

#

I never noticed it being slow :p

fallow sundial Sep 24, 2023, 8:48 AM

#

it's slower than not doing it

quiet talon Sep 24, 2023, 8:49 AM

#

oh no my 3 ms of file IO

#

it only needs to be done for files with replacements on them

fallow sundial Sep 24, 2023, 8:50 AM

#

anyways feel free to push your gist to that repo

quiet talon Sep 24, 2023, 8:50 AM

#

and in my case my mixins.json and my coremods.json files, because I autogenerate those :p

#

I'll upload it once I finish writing at least the parts relevant to us (so the buildship and group launch specs)

tranquil salmon Sep 24, 2023, 8:56 AM

#

quiet talon Granted buildship has decided to also not leave any documentation on their shit

Probably because there is only 1 main developer of buildship

#

Problem with setting up the dev environment for buildship is it requires the groovy compiler for groovy 2.5 which is no longer being distributed on the default update site

quiet talon Sep 24, 2023, 9:01 AM

#

That's the root cause of that cryptic error?

#

I thought I was losing my mind

#

since the actual error text is just like "internal artifact requires org.codehaus.groovy.blah version 0.0.0"

mossy bobcat Sep 24, 2023, 9:01 AM

#

tranquil salmon Problem with setting up the dev environment for buildship is it requires the gro...

Oh god why is anyone still using groovy 2. Groovy 2 sucked

tranquil salmon Sep 24, 2023, 9:03 AM

#

https://github.com/eclipse/buildship/blob/master/buildship.setup#L22-L23
This is looking for the groovy 2.5 compiler but not finding it since it is no longer on the default update site so it errors when trying to find it

mental carbon Sep 24, 2023, 9:06 AM

#

fallow sundial https://github.com/neoforged/EclipseLaunchConfigs hm

Could we create a gradle / java library combo somehow?

fallow sundial Sep 24, 2023, 9:06 AM

#

"gradle / java"?

quiet talon Sep 24, 2023, 9:06 AM

#

Ah, yes, gradle / java library
alternatively: Gravy

#

scrim I hate trying to dig through layers on layers of interfaces to find shit

tranquil salmon Sep 24, 2023, 9:10 AM

#

Seems like gradle forked buildship https://github.com/gradle/buildship/ sometime recently

quiet talon Sep 24, 2023, 9:11 AM

#

they might be better off just rewriting something from scratch lol

quiet talon Sep 24, 2023, 9:47 AM

#

@mental carbon gist updated to include buildship's Gradle Task launch config. https://gist.github.com/Shadows-of-Fire/3c7dd1bacdcddd9476b7b4eafb9f37a9#buildship-launches
Going to go pass out now, this has been exhausting :p

mental carbon Sep 24, 2023, 9:48 AM

#

quiet talon <@304594425286361088> gist updated to include buildship's Gradle Task launch con...

Thank you for the hard work man!

quiet talon Sep 24, 2023, 9:48 AM

#

Will hopefully get group launches written down tomorrowish

mental carbon Sep 24, 2023, 9:48 AM

#

I will do my best to get this added to ngnext as fast as I can

quiet talon Sep 24, 2023, 9:48 AM

#

good luck :p

#

One thing of note that will probably simply some things is that we can just emit eclipse variables in most file paths

#

i.e. <stringAttribute key="working_dir" value="${workspace_loc:MyProjectName}"/>

#

instead of figuring out the real project directory

#

(currently FG6 emits the full path of wherever the prepare eclipse runs task is called)

mental carbon Sep 24, 2023, 9:50 AM

#

The full path is trivial

#

And is what is stored in the Run object itself

#

So it is easier to write

#

Because else NGNext somehow needs to know the inner workings of eclipse

#

And if this exercise has shown me one thing, it is that we need to stay away of that as far as humanly possible

fallow sundial Sep 24, 2023, 10:29 AM

#

@mental carbon are you working on the lib or do you want me to?

mental carbon Sep 24, 2023, 10:29 AM

#

No i am not, go ahead

#

Currently messing with runs

fallow sundial Sep 24, 2023, 10:30 AM

#

do you need it to parse or just generate? only generating would reduce complexity

mental carbon Sep 24, 2023, 10:30 AM

#

Only generate

#

IDEA only supports generation too

fallow sundial Sep 24, 2023, 11:57 AM

#

<?xml version="1.0" ?><launchConfiguration type="org.eclipse.debug.core.groups.GroupLaunchConfigurationType"><stringAttribute key="org.eclipse.debug.core.launchGroup.0.action" value="NONE"></stringAttribute><stringAttribute key="org.eclipse.debug.core.launchGroup.0.name" value="abcd"></stringAttribute><booleanAttribute key="org.eclipse.debug.core.launchGroup.0.enabled" value="true"></booleanAttribute><booleanAttribute key="org.eclipse.debug.core.launchGroup.0.adoptIfRunning" value="true"></booleanAttribute><stringAttribute key="org.eclipse.debug.core.launchGroup.0.mode" value="inherit"></stringAttribute></launchConfiguration>

new GroupLaunchConfig()
        .addEntry(GroupLaunchConfig.GroupEntry.builder()
                .adoptIfRunning(true)
                .mode(GroupLaunchConfig.Mode.INHERIT)
                .name("abcd")
                .enabled(true)
                .build())
        .write(stringWriter);

#

getting somewhere

stray scroll Sep 24, 2023, 11:57 AM

#

majick

#

burn the witch

fallow sundial Sep 24, 2023, 11:57 AM

#

#

public List<SimpleAttribute<?>> build() {
    final List<SimpleAttribute<?>> list = new ArrayList<>();
    action.build(list);
    list.add(ELCAttribute.string("name", name));
    list.add(ELCAttribute.bool("enabled", enabled));
    list.add(ELCAttribute.bool("adoptIfRunning", adoptIfRunning));
    list.add(ELCAttribute.enumAttribute("mode", mode));
    return list;
}

much magic

#

(I'm using lombok for now so I have something that's usable (wrt builders and getters and all of that). can switch to "normal" java later but for now to save time)

frail oriole Sep 24, 2023, 12:32 PM

#

frozen vapor it sounds to me like eclipse is just a monolithic microservices application

OSGi baby! That shit is nightmare fuel

mental carbon Sep 24, 2023, 12:34 PM

#

@fallow sundial You there?

fallow sundial Sep 24, 2023, 12:34 PM

#

hi

mental carbon Sep 24, 2023, 12:34 PM

#

I have an issue with GDI not generating stuff

#

Let me push

#

I added these methods: https://github.com/neoforged/NeoGradle/blob/4cffe1c17499609febb61767175d62b543804bca/dsl/common/src/main/groovy/net/neoforged/gradle/dsl/common/runs/type/Type.groovy#L54-L88

GitHub

NeoGradle/dsl/common/src/main/groovy/net/neoforged/gradle/dsl/commo...

Gradle plugin for NeoForge development. Contribute to neoforged/NeoGradle development by creating an account on GitHub.

#

But for some reason GDI is not generating the setters for it

#

It is for example giving me: https://gist.github.com/marchermans/ed783cc76472bc8890cbebc71d80f03f#file-gistfile1-txt-L191

#

When I ever I look at the compiled .class files

#

It also does not contain them

#

So I don't understand

#

It works on other types

#

Just not on Run / Type

stiff plank Sep 24, 2023, 12:43 PM

#

completely blind guess (its long time since last me and gradle) but getIsGameTest is not same as gameTest with regards to +-get/set, not sure if the "is" makes difference

mental carbon Sep 24, 2023, 12:44 PM

#

stiff plank completely blind guess (its long time since last me and gradle) but getIsGameTes...

Yes, which is why GDI exists, it is supposed to generate them for me

fallow sundial Sep 24, 2023, 12:44 PM

#

mental carbon It also does not contain them

hmmm

#

wait so Property<Boolean> isX works in other types?

mental carbon Sep 24, 2023, 12:45 PM

#

Interesting

#

Some work

#

If i set them to: isConfigurable = false

#

Actaully never mind

#

Yes it works for boolean

#

Because getIsSingleInstance() is working

fallow sundial Sep 24, 2023, 12:47 PM

#

wait do those work if you set configurable to false explicitly?

mental carbon Sep 24, 2023, 12:47 PM

#

So I figured it out

#

@Input is the issue

#

Once I mark a @DSLProperty as an @Input it stops processing it

fallow sundial Sep 24, 2023, 12:48 PM

#

hyperthonk

mental carbon Sep 24, 2023, 12:48 PM

#

Yeah I just ripped @Input of the ones in Type

fallow sundial Sep 24, 2023, 12:48 PM

#

this makes very little sense.. why gradle

mental carbon Sep 24, 2023, 12:48 PM

#

And they instantly generate

fallow sundial Sep 24, 2023, 12:49 PM

#

that is extremely weird and I'm not even sure if it's my fault

mental carbon Sep 24, 2023, 12:49 PM

#

The problem is that i need @Input for sure

#

Because I need them on Run

#

Since it is a nested input there

fallow sundial Sep 24, 2023, 12:50 PM

#

well a last resort solution is to make a custom annotation that adds @Input. and if that custom annotation works then I doubt it's my fault hmmm

mental carbon Sep 24, 2023, 12:52 PM

#

fallow sundial well a last resort solution is to make a custom annotation that adds `@Input`. a...

What do you mean?

fallow sundial Sep 24, 2023, 12:56 PM

#

I mean a custom @AddInput annotation can be made that simply adds the @Input annotation in a transformer.. or just add a addInputAnnotation boolean property to DSLProperty that does that

#

<?xml version='1.0' encoding='UTF-8'?>
<launchConfiguration type="org.eclipse.buildship.core.launch.runconfiguration">
    <listAttribute key="tasks">
        <listEntry value=":prepareResources"/>
    </listAttribute>
    <listAttribute key="arguments">
        <listEntry value="--help"/>
        <listEntry value="-P&quot;updating&quot;=&quot;true&quot;"/>
    </listAttribute>
    <listAttribute key="jvm_arguments">
        <listEntry value="-Xmx1G"/>
    </listAttribute>
    <stringAttribute key="working_dir" value=""/>
    <booleanAttribute key="offline_mode" value="true"/>
    <booleanAttribute key="show_console_view" value="false"/>
    <booleanAttribute key="show_execution_view" value="false"/>
</launchConfiguration>

GradleLaunchConfig.builder()
        .task(":prepareResources")
        .showConsoleView(false)
        .offlineMode(true)
        .argument("--help")
        .gradleProperty("updating", true)
        .jvmArgument("-Xmx1G")
        .build().write(stringWriter);

#

nice

mental carbon Sep 24, 2023, 12:57 PM

#

Nice

#

That is getting some where

#

For sure on the java side

#

I found it

#

@fallow sundial It is the @DefaultMethods

#

If you put that on an interface

#

Then it fails

fallow sundial Sep 24, 2023, 12:59 PM

#

hm

#

I hate groovy 3

#

why didn't you update to groovy 4 gradle screm

mental carbon Sep 24, 2023, 1:01 PM

#

It is working now

fallow sundial Sep 24, 2023, 1:01 PM

#

but that interface doesn't have @defaultmethods? thinkies

mental carbon Sep 24, 2023, 1:01 PM

#

No

#

But Run did

#

It had a default method

#

So I added it

fallow sundial Sep 24, 2023, 1:31 PM

#

<?xml version='1.0' encoding='UTF-8'?>
<launchConfiguration type="org.eclipse.jdt.launching.localJavaApplication">
    <stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value=""/>
    <stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="&quot;-Dmixin.env.remapRefMap=true&quot;"/>
    <listAttribute key="org.eclipse.jdt.launching.MODULEPATH">
        <listEntry value="C:Users/X/cp.jar"/>
    </listAttribute>
    <stringAttribute key="org.eclipse.jdt.launching.WORKING_DIRECTORY" value=""/>
    <stringAttribute key="org.eclipse.jdt.launching.PROJECT_ATTR" value="MyProject"/>
    <stringAttribute key="org.eclipse.jdt.launching.MAIN_TYPE" value="net.me.you.Main"/>
    <booleanAttribute key="org.eclipse.jdt.launching.STOP_IN_MAIN" value="false"/>
    <mapAttribute key="org.eclipse.debug.core.environmentVariables">
        <mapEntry key="MOD_CLASSES" value="modId%%C:/Users/X"/>
        <mapEntry key="MC_VERSION" value="1.18.2"/>
    </mapAttribute>
</launchConfiguration>

#

JavaApplicationLaunchConfig.builder()
        .projectAttribution("MyProject")
        .envVar("MC_VERSION", "1.18.2")
        .envVar("MOD_CLASSES", "modId%%C:/Users/X")
        .vmArgument("-Dmixin.env.remapRefMap=true")
        .classpath(Arrays.asList("C:Users/X/cp.jar"))
        .workingDirectory("")
        .mainClass("net.me.you.Main")
        .build().write(stringWriter);

#

@mental carbon https://github.com/neoforged/EclipseLaunchConfigs/blob/main/src/main/java/net/neoforged/elc/Test.java the dsl is kind of done

mental carbon Sep 24, 2023, 1:37 PM

#

Okey that java DSL is nice

#

But we need some way to make this work with Gradle

#

How does group BTW work?

#

Aah

#

You can pass multiple entries

#

Okey

fallow sundial Sep 24, 2023, 1:37 PM

#

yes, it identifies which launch config to run based on the name

#

if you want to run a gradle taks in a group you will want to use the RUN mode as inherit will fail in debug mode

fallow sundial Sep 24, 2023, 1:39 PM

#

mental carbon But we need some way to make this work with Gradle

elaborate

mental carbon Sep 24, 2023, 1:41 PM

#

Well this does not accept Providers etc

#

And those objects are actually exposed in the DSL

#

Somewhat

#

If you dig properly enough

#

But I guess that does not matter to me that much for now

stray scroll Sep 24, 2023, 1:42 PM

#

just have an ultra-zip of all the providers kekw

#

the zip line

dull bison Sep 24, 2023, 1:42 PM

#

frail oriole OSGi baby! That shit is nightmare fuel

it is (the company I work at uses it, which means I have to use it)

frail oriole Sep 24, 2023, 3:54 PM

#

Ok. How's it going people?

#

What can I dip into today

mental carbon Sep 24, 2023, 4:13 PM

#

I got all run types

#

Except for tests working

#

Due to the way the new run engine is setup

#

It considers the current system a single run

#

There is a system to replace that with

#

but currently that won't work

#

Cause they are all in a single source set

#

@frail oriole Currently running tests on NGNext

frail oriole Sep 24, 2023, 4:20 PM

#

Cool stuff

#

What can I look at. How did you end up solving the backwards problem?

mental carbon Sep 24, 2023, 4:20 PM

#

Once those pass I will push that online

mental carbon Sep 24, 2023, 4:20 PM

#

frail oriole What can I look at. How did you end up solving the backwards problem?

I made a proper API for it

#

A Type can now have a run adapter added to it

frail oriole Sep 24, 2023, 4:21 PM

#

Ah ok

mental carbon Sep 24, 2023, 4:21 PM

#

Which gets automatically triggered when it is applied to a run

#

Since that happens in an afterEval

#

The problem is sovled

frail oriole Sep 24, 2023, 4:21 PM

#

Ok

mental carbon Sep 24, 2023, 4:21 PM

#

And works nciely

#

@dull bison On what branch did you do the update to 20.2?

frail oriole Sep 24, 2023, 4:22 PM

#

I thought we were already on 20.2 lol

mental carbon Sep 24, 2023, 4:22 PM

#

Yeah I am just asking on what branch he did that

frail oriole Sep 24, 2023, 4:22 PM

#

Let's get the list of activities built

mental carbon Sep 24, 2023, 4:23 PM

#

Did we not have a HackMD team?

frail oriole Sep 24, 2023, 4:23 PM

#

I have no idea

mental carbon Sep 24, 2023, 4:23 PM

#

@stray scroll or @fallow sundial That would be your department

frail oriole Sep 24, 2023, 4:24 PM

#

We should probably build a project on GH

mental carbon Sep 24, 2023, 4:24 PM

#

We do 😄

#

@frail oriole Can you invite me to this: https://hackmd.io/@neoforged

HackMD

HackMD - Collaborative Markdown Knowledge Base

Best way to write and share your knowledge in markdown.

#

So I can add a document

frail oriole Sep 24, 2023, 4:24 PM

#

Hang on

#

Grrrr

#

Give me 20minutes

mental carbon Sep 24, 2023, 4:27 PM

#

Take your time 😄

frail oriole Sep 24, 2023, 4:41 PM

#

ok. should be fixed now

mental carbon Sep 24, 2023, 4:49 PM

#

@frail oriole https://hackmd.io/@neoforged/SyPzw1Ryp

HackMD

Worklist for 20.2 - HackMD

Publish first version of NGNext as FG7.

frail oriole Sep 24, 2023, 4:49 PM

#

yup. was watching you type 😄

unkempt fern Sep 24, 2023, 4:49 PM

#

always watching...

frail oriole Sep 24, 2023, 4:49 PM

#

ok

mental carbon Sep 24, 2023, 4:49 PM

#

frail oriole yup. was watching you type 😄

NG Tests are still failing

frail oriole Sep 24, 2023, 4:49 PM

#

heh

mental carbon Sep 24, 2023, 4:49 PM

#

But I will fix them later today

frail oriole Sep 24, 2023, 4:49 PM

#

why?

#

ah ok

mental carbon Sep 24, 2023, 4:50 PM

#

Toolchain problem

#

Aha

frail oriole Sep 24, 2023, 4:50 PM

#

ah

mental carbon Sep 24, 2023, 4:50 PM

#

That is a trivial fix

frail oriole Sep 24, 2023, 4:50 PM

#

fun

#

right

#

what should i start in on

mental carbon Sep 24, 2023, 4:50 PM

#

CI runs on J8

frail oriole Sep 24, 2023, 4:50 PM

#

yeah. not sure why you still target J8

mental carbon Sep 24, 2023, 4:51 PM

#

@prime quest ^

#

Because people do not want me to write the plugin for J17

#

I did that

#

And got shafted for it

frail oriole Sep 24, 2023, 4:51 PM

#

tho i notice that gradle itself is j8

#

even j6 in spots

#

i wonder

mental carbon Sep 24, 2023, 4:51 PM

#

Yep

frail oriole Sep 24, 2023, 4:52 PM

#

could we borrow gradlew and gradlew.bat for our installer problem

prime quest Sep 24, 2023, 4:52 PM

#

the vast majority of our tooling is j8 compatible, and breaks on j9

frail oriole Sep 24, 2023, 4:52 PM

#

what tooling is left curle?

prime quest Sep 24, 2023, 4:52 PM

#

frail oriole could we borrow gradlew and gradlew.bat for our installer problem

that only works if there's already a java on the system

#

it uses an existing java to download a compatible java

frail oriole Sep 24, 2023, 4:52 PM

#

gradlew doesn't require a JVM i think?

mossy bobcat Sep 24, 2023, 4:52 PM

#

frail oriole gradlew doesn't require a JVM i think?

It does. It just can install others if you have the wrong one

mental carbon Sep 24, 2023, 4:52 PM

#

Check the script I would say

prime quest Sep 24, 2023, 4:52 PM

#

it's a wrapper that uses a system JVM to download a compatible one

#

if not present

frail oriole Sep 24, 2023, 4:53 PM

#

ok. nevermind then

mossy bobcat Sep 24, 2023, 4:53 PM

#

Gradle itself needs Java, and gradlew is just using that to get the right Java if it doesn't exist

fallow sundial Sep 24, 2023, 4:56 PM

#

frail oriole yeah. not sure why you still target J8

because that's what gradle ships

#

for gradle plugins we should target the version gradle ships not the MC version because the JVM you run gradle with and the one you run MC with can be different as toolchains exist

frail oriole Sep 24, 2023, 5:02 PM

#

that's fair

quiet talon Sep 24, 2023, 6:25 PM

#

fallow sundial

Ah, yes, ELCAttribute, short for
"Elcipse" Attribute

mental carbon Sep 24, 2023, 6:27 PM

#

Shit

#

I missed that

#

Funny

#

😄

fallow sundial Sep 24, 2023, 6:44 PM

#

it's short for eclipselaunchconfig stab

lethal bane Sep 24, 2023, 6:45 PM

#

where's the stab?

#

should be ELCS then

quiet talon Sep 24, 2023, 6:54 PM

#

Elcipse attribute stabolb

dull bison Sep 24, 2023, 7:23 PM

#

mental carbon <@213343613583622144> On what branch did you do the update to 20.2?

sorry for the late answer: on the 1.20.2-ngnext

mental carbon Sep 24, 2023, 7:24 PM

#

good 😄

mental carbon Sep 24, 2023, 7:49 PM

#

First full build of NG7.0 is now coming online

stray scroll Sep 24, 2023, 7:52 PM

#

TC says, "sike"

mental carbon Sep 24, 2023, 7:54 PM

#

Yeah it has the problem with a damn tag

mental carbon Sep 24, 2023, 8:10 PM

#

FINALLY

#

NG 7.0.0-SNAPSHOT is published!

#

Okey I am tired

#

Task for tomorrow

#

Installer 😄 publishing from NGNext

sterile idol Sep 24, 2023, 8:43 PM

#

Please let it be a normal field trip.

unkempt fern Sep 24, 2023, 8:44 PM

#

With the Friz?

tacit vale Sep 24, 2023, 9:28 PM

#

mental carbon NG 7.0.0-SNAPSHOT is published!

We should rework NG's branch layout

#

You named the branch FG_7.0, which is the standard, but we should move everything to 7.x, 6.x, 5.x, 5.0, etc. with no prefix

mental carbon Sep 24, 2023, 9:29 PM

#

tacit vale You named the branch FG_7.0, which is the standard, but we should move everythin...

We really should 😄

#

But you know Time

tacit vale Sep 24, 2023, 9:29 PM

#

Agreed

#

Just something we could do and it's pretty easy I think

#

@stray scroll perfect ur here

stray scroll Sep 24, 2023, 9:29 PM

#

hello

#

what'r'we doing today

mental carbon Sep 24, 2023, 9:30 PM

#

Renaming branches

#

You will need to deal with it on every single branch though

#

Cause all that use GU have it hardcoded in the buildscript

#

And in the settings.gradle for TC

tacit vale Sep 24, 2023, 9:30 PM

#

Rename all the branches to fit modern standards. If it's the latest minor of a major -> A.x. If it's not latest minor of a major -> A.B

#

Same as how we do on NF repo

#

besides the 1. prefix

mental carbon Sep 24, 2023, 9:31 PM

#

Yeah but that also requires commits

tacit vale Sep 24, 2023, 9:31 PM

#

?

stray scroll Sep 24, 2023, 9:31 PM

#

should my pushes cause builds

tacit vale Sep 24, 2023, 9:31 PM

#

no

mental carbon Sep 24, 2023, 9:31 PM

#

stray scroll should my pushes cause builds

Not if you can prevent it

stray scroll Sep 24, 2023, 9:31 PM

#

what happens if we pause the build config from the TC interface

mental carbon Sep 24, 2023, 9:31 PM

#

tacit vale ?

The current branching structure is hardcoded in both TC as well as the buildscript for versioning

tacit vale Sep 24, 2023, 9:31 PM

#

Ah yes

mental carbon Sep 24, 2023, 9:31 PM

#

stray scroll what happens if we pause the build config from the TC interface

When you reenable it, then it will trigger

tacit vale Sep 24, 2023, 9:32 PM

#

Damn

mental carbon Sep 24, 2023, 9:32 PM

#

To be honest shrimp

#

This is starting to feel like a none issue

#

I don't mind renaming 7

#

That is a trivial change

#

But the others are bit a dicy

stray scroll Sep 24, 2023, 9:32 PM

#

mental carbon When you reenable it, then it will trigger

does it queue up the builds when paused (so we can stop them), or does it do the checking after unpausing

tacit vale Sep 24, 2023, 9:32 PM

#

I would say rename them all but only actually add commits to 7.x and 6.x

mental carbon Sep 24, 2023, 9:33 PM

#

Okey

mental carbon Sep 24, 2023, 9:33 PM

#

stray scroll does it queue up the builds when paused (so we can stop them), or does it do the...

checking after

#

A paused build config

#

Stops the poll/webhook for the change tracker

quiet talon Sep 25, 2023, 3:01 AM

#

spec updated for Launch Groups

#

https://gist.github.com/Shadows-of-Fire/3c7dd1bacdcddd9476b7b4eafb9f37a9#launch-groups

#

Should I do any of the other ones or can I retire from looking at the eclipse source code for now

quiet talon Sep 25, 2023, 3:17 AM

#

@fallow sundial I'm gonna de-lombok the run configs repo and document some things™️
I'm also going to move it from j8 to j17 for records, unless there's some weird magic reason that shouldn't be done

quiet talon Sep 25, 2023, 4:40 AM

#

I'm also just going to nuke the classpath and modulepath entries, because this is what the format looks like and its very "spaghetti of eclipse internals"

    <listAttribute key="org.eclipse.jdt.launching.CLASSPATH">
        <listEntry value="&lt;?xml version=&quot;1.0&quot; encoding=&quot;UTF-8&quot; standalone=&quot;no&quot;?&gt;&#13;&#10;&lt;runtimeClasspathEntry path=&quot;5&quot; projectName=&quot;Apotheosis&quot; type=&quot;1&quot;/&gt;&#13;&#10;"/>
        <listEntry value="&lt;?xml version=&quot;1.0&quot; encoding=&quot;UTF-8&quot; standalone=&quot;no&quot;?&gt;&#13;&#10;&lt;runtimeClasspathEntry path=&quot;5&quot; projectName=&quot;Testing&quot; type=&quot;1&quot;/&gt;&#13;&#10;"/>
        <listEntry value="&lt;?xml version=&quot;1.0&quot; encoding=&quot;UTF-8&quot; standalone=&quot;no&quot;?&gt;&#13;&#10;&lt;runtimeClasspathEntry containerPath=&quot;org.eclipse.buildship.core.gradleclasspathcontainer&quot; javaProject=&quot;Testing&quot; path=&quot;5&quot; type=&quot;4&quot;/&gt;&#13;&#10;"/>
    </listAttribute>

#

like wtf is that, fucking inlined xml inside an xml document

fallow sundial Sep 25, 2023, 4:47 AM

#

quiet talon <@561254664750891009> I'm gonna de-lombok the run configs repo and document some...

keep it on 8,we need to use it directly inside a gradle plugin

quiet talon Sep 25, 2023, 4:48 AM

#

is gradle still 8?

#

bleh

#

is that written down anywhere? It seems weird that gradle supports 17+ but would limit plugins to 8

#

Yeah I don't think 8 is a limitation

#

There's even an example in the gradle docs using 11

fallow sundial Sep 25, 2023, 4:55 AM

#

https://docs.gradle.org/current/userguide/compatibility.html#java

#

8 is the lowest version

quiet talon Sep 25, 2023, 4:56 AM

#

so what thonk

#

do we support running gradle 2? no™️

fallow sundial Sep 25, 2023, 4:57 AM

#

hwat. you know there's a difference between gradle toolchains, the path and Java home env var, and the java gradle runs on?

#

gradlew will download 8 by default, and you aren't required to have Java 17 on the path and neither set as the java home to run mc 1.18+

quiet talon Sep 25, 2023, 4:59 AM

#

what thonk

#

doesn't mc require 17?

fallow sundial Sep 25, 2023, 4:59 AM

#

using anything other than Java 8 in a gradle plugin causes cryptic errors and a requirement of manually installing a version higher than the default and setting it up on the path and the java home

#

yes but gradle has the toolchain system for that

#

gradle doesn't need to run on Java 17 and neither does the system have to have 17 installed for gradle to run an app with j17

quiet talon Sep 25, 2023, 5:00 AM

#

I feel like this is a solvable problem

#

Like can we not just make mods set their toolchain version to 17?

#

because we already do that https://github.com/neoforged/MDK/blob/main/build.gradle#L17

fallow sundial Sep 25, 2023, 5:09 AM

#

quiet talon Like can we not just make mods set their toolchain version to 17?

again, that doesn't change the version you run gradle with

#

gradle runs with the java on the java home, and nothing in your toolchain or in the mc launcher requires Java 17 on the global path

#

it's not a solvable "problem", gradle recommends compiling plugins with Java 11,thats the most you get and you're going to like it, otherwise you're going to use lombok or groovy and you're going to like it

quiet talon Sep 25, 2023, 5:11 AM

#

or I can use this thinkies https://github.com/bsideup/jabel

#

which transpiles j16 source to j8

#

and they have records, so that's good enough™️

#

I wonder how well this thing works™️

tawny iron Sep 25, 2023, 5:22 AM

#

I cant seem to find any comments or announcements about it so I’ll just ask here
How we looking for 1.20.2 at the moment?

quiet talon Sep 25, 2023, 5:23 AM

#

I believe it works, or something. You'd have to ask Orion

#

lotta internal changes aside from the actual upcoming breaking API changes

tawny iron Sep 25, 2023, 5:24 AM

#

Oh just not released?

mental carbon Sep 25, 2023, 5:25 AM

#

It is running

mental carbon Sep 25, 2023, 5:25 AM

#

mental carbon <@104313475756466176> https://hackmd.io/@neoforged/SyPzw1Ryp

#

The pinned message is out current Todo list

mental carbon Sep 25, 2023, 5:26 AM

#

tawny iron Oh just not released?

But yeah it is running

tawny iron Sep 25, 2023, 5:27 AM

#

Still a while off release it looks like though

mental carbon Sep 25, 2023, 5:27 AM

#

quiet talon is gradle still 8?

Tell me about it, ngnext would 100 times cleaner if I had records

mental carbon Sep 25, 2023, 5:27 AM

#

tawny iron Still a while off release it looks like though

This will go really quick

quiet talon Sep 25, 2023, 5:27 AM

#

Well you could try that haunted little thing I linked

#

Since it claims to be able to compile records to j8 bytecode

mental carbon Sep 25, 2023, 5:28 AM

#

Mah with Ng next I tried to not do any weird stuff like that, it is tempting. But meh

quiet talon Sep 25, 2023, 5:28 AM

#

Better than lombok :p

tawny iron Sep 25, 2023, 5:28 AM

#

Should I continue waiting for neo for porting ml projects or just port the fabric/forge versions now and leave neo to wait?

#

Trying to get a rough idea on timing

mental carbon Sep 25, 2023, 5:29 AM

#

If I get my way the first release will happen this week

#

But it won't be a stable Build

quiet talon Sep 25, 2023, 5:29 AM

#

ML projects will likely need toolchain changes from the intermediate APIs (arch/ML template)

mental carbon Sep 25, 2023, 5:29 AM

#

Lots of changes then com up

tawny iron Sep 25, 2023, 5:30 AM

#

Mmk other loaders first then

#

Thanks guys

dull bison Sep 25, 2023, 6:20 AM

#

orion when you have time today we could do a brainstorming session about the networking changes (regs to config phase etc.)

#

maybe modmuss would join us too (if we have questions about his proposal)

dull bison Sep 25, 2023, 8:59 AM

#

@mental carbon ^

mental carbon Sep 25, 2023, 8:59 AM

#

Sure

#

I am at work untill like 3 PM hour time

#

But yeah

frosty axle Sep 25, 2023, 11:40 AM

#

heyo, updating my mods to 1.20.2 sigh networking .. i have it working again but its complaining i should not use ServerLifecycleHooks.getCurrentServer() when processing packets from client to server ... so what is the intended way to get the server object? from context somehow?

mental carbon Sep 25, 2023, 11:42 AM

#

frosty axle heyo, updating my mods to 1.20.2 sigh networking .. i have it working again but ...

We have not released anything yet.....

jagged agate Sep 25, 2023, 11:42 AM

#

Are you updating to 1.20.2 forge? If so, you’ll have to ask forge discord

#

This channel is for discussion about neoforge’s work to get onto 1.20.2

frosty axle Sep 25, 2023, 11:42 AM

#

oh, im sorry, i searched for forge discord and it put me here

#

saw cpw and thought this was the place

#

did they change servers or something

jagged agate Sep 25, 2023, 11:43 AM

#

This was the old forge discord rebranded to NeoForge. Lex made his own discord. Link might be in announcement

#

https://discord.minecraftforge.net/ I think this is it

Discord

Join the Minecraft Forge Official Discord Server!

Official MinecraftForge Discord | 1612 members

dull bison Sep 25, 2023, 2:17 PM

#

ohno do we get the first 1.20.3 snapshot this week? #mojira

frigid mountain Sep 25, 2023, 2:17 PM

#

My guess is nothing till after Minecraft Live

dull bison Sep 25, 2023, 2:18 PM

#

I mean it seems like 1.20.3 will be pure bugfix

mental carbon Sep 25, 2023, 2:22 PM

#

I will be around in 30 to 40 minutes

#

Need to clean the bathroom

dull bison Sep 25, 2023, 2:23 PM

#

no problem

inland mesa Sep 25, 2023, 2:58 PM

#

if it's a hotfix release, maybe, but probably just working toward 1.20.3 later in the year

dull bison Sep 25, 2023, 4:35 PM

#

mental carbon I will be around in 30 to 40 minutes

did the bathroom take longer?

mental carbon Sep 25, 2023, 4:37 PM

#

Yeah

#

I need to walk the dog

#

And then I have some time

dull bison Sep 25, 2023, 4:37 PM

#

ok

kindred fractal Sep 25, 2023, 4:40 PM

#

Crossloader tags won't be for 20.2 (as TG said in his PR), you can remove those from the hackmd

jagged agate Sep 25, 2023, 4:41 PM

#

1.21 yeah

#

gives enough time for feedback and prevent rushing and time crunch

dull bison Sep 25, 2023, 4:43 PM

#

removed

prime quest Sep 25, 2023, 5:02 PM

#

mental carbon I need to walk the dog

You're a professional yo-yoer too!?

#

Truly a man of many talents

kindred fractal Sep 25, 2023, 5:03 PM

#

btw, networking can be left for post-release if we want

prime quest Sep 25, 2023, 5:03 PM

#

Ye probably best that we do, so that modmuss and gang can double check it all lines up.

#

Don't want to accidentally have it broken because nobody noticed

kindred fractal Sep 25, 2023, 5:04 PM

#

yeah

mental carbon Sep 25, 2023, 5:35 PM

#

@dull bison I am around now

mental carbon Sep 25, 2023, 7:28 PM

#

Okey progress today:

#

I created the internal code for dealing with the Installer stuff

#

Currently strugling to deal with file handling of libraries

frail oriole Sep 26, 2023, 12:44 PM

#

Yo

mental carbon Sep 26, 2023, 12:44 PM

#

Yo

#

Today is installer day 😄

#

I am actually pretty far already

frail oriole Sep 26, 2023, 12:45 PM

#

Yay!

sterile idol Sep 26, 2023, 4:03 PM

#

I think 1.20.3 will just be a bugfix release, most likely. Won't break mods.

rich void Sep 26, 2023, 4:21 PM

#

looks like it, with that and the fact that a few old bugs are fixed, looks like a good update

rich void Sep 26, 2023, 4:21 PM

#

sterile idol I think 1.20.3 will just be a bugfix release, most likely. Won't break mods.

||~~^reply to this~~||

dull bison Sep 27, 2023, 3:55 PM

#

how did installer day go yesterday?

prime quest Sep 27, 2023, 4:04 PM

#

#project-talk

dull bison Sep 27, 2023, 4:06 PM

#

is there anything that can be done in parallel to the installer?

mental carbon Sep 27, 2023, 4:07 PM

#

Not really

#

I am currently doing this in parallel

#

I am making the data structures in the DSL for both systems

#

And with both I mean the UserDev and the Installer

dull bison Sep 27, 2023, 4:07 PM

#

what about the testmods

mental carbon Sep 27, 2023, 4:08 PM

#

Currently not really working

#

It is compiling

#

But NGNext has no ability to load them at the moment

#

You could try to refactor them in such a way that they are all subprojects....

#

Somehow

#

Okey LauncherProfile done

#

Now the Installer config

lean warren Sep 27, 2023, 6:06 PM

#

Am I completely blind or does NG7 not have maven publish tasks yet?

mental carbon Sep 27, 2023, 6:23 PM

#

It does....

#

It should have published

#

But it might be missing too

#

But it does have them

#

Because I used them to publish pre releases

lean warren Sep 27, 2023, 6:26 PM

#

Strange. I cloned 1.20.2-ngnext and NeoGradle on the NG_7 branch, published the latter to mavenLocal and set up Forge dev but can't find the option to publish Forge to mavenLocal

#

Worth noting that I also can't start the client in Forge dev, I get Exception in thread "main" joptsimple.OptionArgumentConversionException: Cannot parse argument 'H:\Hobby\Programmierung\Minecraft\Forks\NeoForge-Private\projects\forge\build\neoForm\neoFormJoined1.20.2-20230921.152923\steps\downloadAssets' of option assetsDir (https://gist.github.com/XFactHD/7274a42ec6318f434707df2525e1d972) when running the Forge: Client run config. Running the NeoForm and NeoForge setup tasks doesn't help either

mental carbon Sep 27, 2023, 6:37 PM

#

Ah yeah

#

No forge won't be publishing yet

rich void Sep 27, 2023, 6:38 PM

#

still called Forge dev?

lethal bane Sep 27, 2023, 8:49 PM

#

Does the configuration phase also exist on singleplayer worlds or only on multiplayer servers?

kindred fractal Sep 27, 2023, 9:09 PM

#

Exists on both

#

No point in making SP different

lethal bane Sep 27, 2023, 9:10 PM

#

Good

#

iirc, the idea of allowing mods to send players back into the configuration phase was dismissed, but can mods keep players in the config phase longer?

kindred fractal Sep 27, 2023, 9:12 PM

#

I'd like to have a similar API as fabric

#

Where mods can add configuration "tasks" to run

lethal bane Sep 27, 2023, 9:13 PM

#

yeah, that sounds like a good idea

pine ember Sep 28, 2023, 8:13 AM

#

lethal bane iirc, the idea of allowing mods to send players back into the configuration phas...

This is basically already present in vanilla, there is a (disabled by default) test command for this. It would be fundamentally broken to not support going back into configuration, its kinda the whole point of it.

inland mesa Sep 28, 2023, 8:15 AM

#

it was more about not having an explicit API for mods to do so

tacit vale Sep 28, 2023, 8:16 AM

#

well the proxy services need to take advantage of it somehow but I guess they would already be at a layer inbetween the forge server and client so they can send the packet whenever they want 🤷

inland mesa Sep 28, 2023, 8:17 AM

#

yeah so long as neo itself can handle someone doing it

#

then it doesn't matter if someone does whatever vanilla has available

stray scroll Sep 28, 2023, 8:18 AM

#

~~ServerPlayer.getConnection().banishToConfigurationRealm()~~

pine ember Sep 28, 2023, 8:22 AM

#

stray scroll ~~`ServerPlayer.getConnection().banishToConfigurationRealm()`~~

I think this basically exists, so yeah there isn't anything you need to add for this. Just make sure that you can handle re-configuring (such as applying regsync again)

dull bison Sep 28, 2023, 9:00 AM

#

should the datapack sync event be moved to the config phase too (and as such the packets sent by mods during it)?

kindred fractal Sep 28, 2023, 9:01 AM

#

@pine ember did you move it? 😛

#

(this: https://github.com/FabricMC/fabric/blob/3ccb77f2a4dd0bde504de1ca0ae4862afb616870/fabric-lifecycle-events-v1/src/main/java/net/fabricmc/fabric/api/event/lifecycle/v1/ServerLifecycleEvents.java#L131)

kindred fractal Sep 28, 2023, 9:02 AM

#

dull bison should the datapack sync event be moved to the config phase too (and as such the...

it should be called right before recipe and tags are sent

pine ember Sep 28, 2023, 9:44 AM

#

kindred fractal <@98473211301212160> did you move it? 😛

No 😆

#

Ill fix later

kindred fractal Sep 28, 2023, 9:45 AM

#

maybe the injection points are still fine, idk

pine ember Sep 28, 2023, 9:45 AM

#

Recipes are still sent during play it seems, so might be ok

#

Ill double check it in detail later

#

there are new configuration events, so its possible it doesnt need to move.

lethal bane Sep 28, 2023, 9:55 AM

#

pine ember This is basically already present in vanilla, there is a (disabled by default) t...

Good to know, but I've kind of decided to not support /reload, so I don't need that, but maybe I'll add it again.
As long as I can keep the player in the "original" config phase until I'm done, I'm happy

pine ember Sep 28, 2023, 10:18 AM

#

The config phase has a basic concept of tasks, that the client must respond to before continuing. So if you have a lot of data to transfer or whatever thats not a problem.

dull bison Sep 28, 2023, 10:58 AM

#

orion have you pushed any of your work from the last few days?

dull bison Sep 28, 2023, 12:08 PM

#

@mental carbon ^

mental carbon Sep 28, 2023, 12:08 PM

#

I know

#

Currently at work

#

Can't remember

tranquil salmon Sep 28, 2023, 8:41 PM

#

quiet talon I can't even get buildship's environment working, lol

They just fixed the issue with the setup for the buildship dev environment

quiet talon Sep 28, 2023, 8:41 PM

#

neat™️

mental carbon Sep 30, 2023, 9:04 PM

#

Finally I got the largest of the needed metadata and json files generating.....

#

The damn launcher json 😄

#

Okey tomorrow I should get the installer and hopefully the userdev artifacts working

mental carbon Oct 1, 2023, 7:34 PM

#

Okey update:

#

universal jar is generating

#

And most of the jsons as well

#

UserDev is the last missing one

#

Because it required the universal jar to be present

mental carbon Oct 1, 2023, 8:53 PM

#

Oke implemented Signing

#

That old code was JANK AF

fallow sundial Oct 1, 2023, 8:56 PM

#

why exactly do we need special code to sign jars

#

does the signing plugin not suffice or?..

arctic sphinx Oct 1, 2023, 9:15 PM

#

From memory, the plugin does maven signing with separate external files containing the signatures, our custom task does Java’s jarsigner which adds the signatures into the jar (+ updating the Manifest / META-INF)

quiet talon Oct 1, 2023, 9:28 PM

#

do eclipse runs generate yet?

mossy bobcat Oct 1, 2023, 9:38 PM

#

arctic sphinx From memory, the plugin does maven signing with separate external files containi...

Yeah, the signing plugin does sensible out of jar signing which is what gradle supports for dependencies, and what folks like maven central expect for publishing, instead of java's cursed stuff. If you don't release signature files of the maven sort for neo stuff, note that people will not be able to take advantage of gradle dependency verification for that, though I guess NG probably makes that appreciably harder anyways

stray scroll Oct 1, 2023, 10:42 PM

#

outside of Minecraft itself and Forge, what other projects use Java's built-in jarsigner for signing?

tranquil salmon Oct 1, 2023, 11:20 PM

#

Seems like eclipse does

stray scroll Oct 1, 2023, 11:22 PM

#

should've expected that, those dinosaurs of open-source hospice /jk kek

keen hearth Oct 2, 2023, 6:37 AM

#

I sign my jars, Mods sign their jars, its the whole point of SecureJarHandler existing, to validate jar signatures signed by jarsigner.

mental carbon Oct 2, 2023, 6:45 AM

#

mossy bobcat Yeah, the signing plugin does sensible out of jar signing which is what gradle s...

It is not really that simple, currently no system in the user environment wants to support external jar signatures......

Yes it would be the simplest approach for us modders, but no existing system (curse, ftb, modrinth, fabric, fml securejar, or any other that I am aware of) knows how to deal with this.

On top of this right now, regardless of signed or unsigned, the user needs to copy exactly 1 file to install a mod, which is optimal. If we adapt PGP signing with its external signing files, that amount will double, if not triple, when hash files with their signatures get involved.

All in all, in jar signing is currently the best option we have, yes it has downsides, but the upsides currently outweight those.

stray scroll Oct 2, 2023, 6:48 AM

#

keen hearth I sign my jars, Mods sign their jars, its the whole point of SecureJarHandler ex...

i wonder how many mod developers know about jarsigning in the traditional jarsigner way, and actually implement it in their builds

#

I know it's larger than 2-3, at least (present company -- i.e. covers -- included)

keen hearth Oct 2, 2023, 6:49 AM

#

a few, it was notoriously tricky to configure with FG, i just wrote my own plugin for it

mental carbon Oct 2, 2023, 6:49 AM

#

stray scroll i wonder how many mod developers know about jarsigning in the traditional `jarsi...

I am at least looking to implement it by default, so that the tasks are there and they just need to set the keystore etc

#

For NGNext it is trivial to do

keen hearth Oct 2, 2023, 6:50 AM

#

fantastic

mental carbon Oct 2, 2023, 6:50 AM

#

With a single extra task execution

stray scroll Oct 2, 2023, 6:50 AM

#

i assume docs will be forthcoming on setting up said plugin and associated secrets (keystore, etc.)

keen hearth Oct 2, 2023, 6:50 AM

#

Doesn't help the people who wish to sign jars without NG though, so unfortunately, can't yeet my plugin

mental carbon Oct 2, 2023, 6:50 AM

#

#

That or its gradle alternative is all you need

#

Allthough right now the task is still in Platform

#

Not in common

stray scroll Oct 2, 2023, 6:50 AM

#

does the task still do the sign-in-place thing

mental carbon Oct 2, 2023, 6:51 AM

#

No

#

It never did

#

It could

keen hearth Oct 2, 2023, 6:51 AM

#

it always did

mental carbon Oct 2, 2023, 6:51 AM

#

But it never required you to do it in place

stray scroll Oct 2, 2023, 6:51 AM

#

why is it named PotentiallySignJar thonk

mental carbon Oct 2, 2023, 6:51 AM

#

If you do not set the keystore etc, it won't do anything

#

And just copy

#

For now

stray scroll Oct 2, 2023, 6:51 AM

#

it should either sign it, or not and throw

mental carbon Oct 2, 2023, 6:51 AM

#

It is so that the setup for DynProj is easier

mental carbon Oct 2, 2023, 6:51 AM

#

stray scroll it should either sign it, or not and throw

That would require complicated processing logic in the buildscript

#

Instead it is a trivial build chain right now

stray scroll Oct 2, 2023, 6:52 AM

#

it sounds wrong to me that such a sensitive operation could perhaps do nothing and slip by undetected as having done nothing

keen hearth Oct 2, 2023, 6:52 AM

#

^

mental carbon Oct 2, 2023, 6:52 AM

#

Yeah it for sure needs to log something

#

But it does not for now

#

Given that I am still trying to get everything wired up

stray scroll Oct 2, 2023, 6:53 AM

#

or a property which controls whether to throw or log silently

mental carbon Oct 2, 2023, 6:53 AM

#

All in time my good padawan would starwars say 😄

stray scroll Oct 2, 2023, 6:53 AM

#

kekw

#

in other news
how goes the NF buildscript wrangling

#

I see there's a big block of installers in one of the buildscripts, which makes me itch

mental carbon Oct 2, 2023, 6:54 AM

#

https://gist.github.com/marchermans/aedb9fd82865c59918e3595e789ec242

stray scroll Oct 2, 2023, 6:55 AM

#

when are we using version catalogs

mental carbon Oct 2, 2023, 6:55 AM

#

There is no reason too....

stray scroll Oct 2, 2023, 6:55 AM

#

also, q: does NG7's design permit things like dependency verification and dependency locking

mental carbon Oct 2, 2023, 6:55 AM

#

This is the only place that defines the version

mental carbon Oct 2, 2023, 6:56 AM

#

stray scroll also, q: does NG7's design permit things like dependency verification and depend...

It should yeah, if there are some issues, I think we can work around most of them

stray scroll Oct 2, 2023, 6:56 AM

#

sounds like something to make into a functional test sometime in the future

mental carbon Oct 2, 2023, 6:56 AM

#

Like catalogs are nice if you reuse the same deps over and over again

#

But this is literally the only place in the script where they are defined

mental carbon Oct 2, 2023, 6:56 AM

#

stray scroll *sounds like something to make into a functional test sometime in the future*

Yep

#

So I see no reason to make this into a catalog

#

Which reduces visibility

stray scroll Oct 2, 2023, 6:58 AM

#

hmmmm

#

there is at least the case of the ASM block of dependencies

#

but perhaps something to think again in the future

#

q: why does the installer configuration exist?

mental carbon Oct 2, 2023, 6:59 AM

#

It is all the tools, classpath components, and libraries the installer needs to download

#

At the moment this is all done via configurations

#

It is not perfect

stray scroll Oct 2, 2023, 7:00 AM

#

can we not automatically derive that from the dependency graph?

mental carbon Oct 2, 2023, 7:00 AM

#

No not at the moment

stray scroll Oct 2, 2023, 7:01 AM

#

it always seemed a bit off to me that we define all of those manually

mental carbon Oct 2, 2023, 7:01 AM

#

Maybe in the future

#

But at the moment I am focusing on getting this bird to fly

#

I am so damn close

rich void Oct 2, 2023, 7:06 AM

#

close to a 20.2 release?

stray scroll Oct 2, 2023, 7:07 AM

#

mayhaps, mayhaps not

rich void Oct 2, 2023, 7:08 AM

#

that works for me :)

mental carbon Oct 2, 2023, 7:23 AM

#

Wtf

#

I just ran into a snag

#

WTF is the downloadServerExtra task doing

#

I know of the downloadClientExta which downloads the client-extra jar

#

But server extra -.-

inland mesa Oct 2, 2023, 7:25 AM

#

I have never heard of a server extra

mental carbon Oct 2, 2023, 7:25 AM

#

It is the same as the client

#

Just based on the server jar

#

But that requires some work to make

stray scroll Oct 2, 2023, 7:27 AM

#

extra, meaning IIRC anything not a class file or under META-INF (i.e. not related to code)

mental carbon Oct 2, 2023, 7:28 AM

#

META-INF is actually in cluded

#

Only class files are processed

#

Okey implemented

#

Back to my regular scheduled business of dealing with lexes json files

cedar echo Oct 2, 2023, 10:09 AM

#

stray scroll *mayhaps, mayhaps not*

🫠

#

Ima just hope that it’ll come sometime this week.

rich void Oct 2, 2023, 10:21 AM

#

we can only hope (I mean, us two, the staff can only work on it)

prime quest Oct 2, 2023, 3:39 PM

#

we can hope AND work on it

kindred fractal Oct 2, 2023, 3:52 PM

#

we hope, Orion works

glacial rain Oct 2, 2023, 4:02 PM

#

assault_pray

cedar echo Oct 2, 2023, 8:24 PM

#

Don’t worry guys no pressure :P

dull bison Oct 3, 2023, 7:52 AM

#

mental carbon Back to my regular scheduled business of dealing with lexes json files

how are the json files going

mental carbon Oct 3, 2023, 8:01 AM

#

I ran into a snag with the installer

#

It wants stupid extra files and their hashes...

mental carbon Oct 3, 2023, 9:39 PM

#

Close but no cookie yet

mental carbon Oct 4, 2023, 1:19 PM

#

WTF I have a task that I can not find

#

makeClasspathFiles

#

Does anybody know where that is defined in the existing code

#

?

#

Found it.....

arctic sphinx Oct 4, 2023, 1:25 PM

#

harold just as I did

stray scroll Oct 4, 2023, 3:35 PM

#

mental carbon WTF I have a task that I can not find

a terrifying problem to have kekw

stray scroll Oct 4, 2023, 5:02 PM

#

<@&1067092163520909374> wee woo, 23w40 for 1.20.3
https://www.minecraft.net/en-us/article/minecraft-snapshot-23w40a

arctic sphinx Oct 4, 2023, 5:02 PM

#

You just beat me to it kek

mossy bobcat Oct 4, 2023, 5:02 PM

#

Oh shoot, already?

stray scroll Oct 4, 2023, 5:02 PM

#

arctic sphinx You just beat me to it <:kek:1134098707869073408>

i love the parchment notifier kekw

wise forge Oct 4, 2023, 5:02 PM

#

Bug fixes ftw

dull bison Oct 4, 2023, 5:03 PM

#

oh lawd it comin

inland mesa Oct 4, 2023, 5:04 PM

#

snapshot :o

mossy bobcat Oct 4, 2023, 5:04 PM

#

Oh, a tag for damage types that kill armor stands? Fun

lethal bane Oct 4, 2023, 5:08 PM

#

mossy bobcat Oh shoot, already?

well, we did expect it

formal plume Oct 4, 2023, 5:09 PM

#

i guess we are gonna start getting new stuff in the 20.3 cycle for 21.0?

mossy bobcat Oct 4, 2023, 5:09 PM

#

I thought there'd be another couple of weeks at least

mossy bobcat Oct 4, 2023, 5:09 PM

#

formal plume i guess we are gonna start getting new stuff in the 20.3 cycle for 21.0?

That would be my guess

formal plume Oct 4, 2023, 5:09 PM

#

they might want to release new snapshot with 21.0 stuff on ~minecon~ minecraft:earth

frigid bolt Oct 4, 2023, 5:10 PM

#

unlikely. Theyd have to rush out 1.20.3 then, OR do something never done since the experimental snapshots (Running two snapshot pipelines at the same time, one for 1.20.3 and one for 1.21)

formal plume Oct 4, 2023, 5:10 PM

#

?? that is what the feature flags are for

frigid bolt Oct 4, 2023, 5:11 PM

#

They could stuff it all into experimental flags, yes, but I dont think they'd be ones to shove that much content into it, unless 1.21 atm doesn't contain much content at all

formal plume Oct 4, 2023, 5:12 PM

#

what?
all i didn't say they would put all of 21.0 in there. just some stuff that they are fine with promissing

#

a new wood type... maybe some new blocks

frigid bolt Oct 4, 2023, 5:12 PM

#

I know, thats why I said 1.21 atm as in 1.21 in its current state
If 1.21 at the moment doesnt contain much, then sure, itll make sense to put it into feature flags in 1.20.3

formal plume Oct 4, 2023, 5:12 PM

#

they are most likely not gonna show anything at the event based on how the community treated them in the past

frigid bolt Oct 4, 2023, 5:13 PM

#

formal plume they are most likely not gonna show anything at the event based on how the commu...

This too, plus I think the mob vote was changes based on community treatment as well, as a lot of the past votes were not exactly net-positive reactions

#

So they've done all cute animals, so that no matter what option gets picked, there isn't really any room to complain about any of the options

formal plume Oct 4, 2023, 5:14 PM

#

they most likely have a bunch of plans of what to do but they are not sure what version they will be ready for.

rich void Oct 4, 2023, 5:27 PM

#

stray scroll <@&1067092163520909374> wee woo, **23w40** for 1.20.3 <https://www.minecraft.net...

new brainstorming thread?

#

also they removed [] and null from jsons

lethal bane Oct 4, 2023, 5:29 PM

#

wat

#

you can't just remove lists

#

ah, empty list

rich void Oct 4, 2023, 5:30 PM

#

knotty harness Oct 4, 2023, 5:30 PM

#

rich void also they removed [] and null from jsons

for chat component serialization only though?
as its under the chat components > serialization section

rich void Oct 4, 2023, 5:31 PM

#

yeah

fallow sundial Oct 4, 2023, 5:41 PM

#

1.20.2.. sigh I mean 1.20.3

rich void Oct 4, 2023, 5:44 PM

#

thx maty

frail oriole Oct 4, 2023, 5:48 PM

#

why maty?

arctic sphinx Oct 4, 2023, 5:53 PM

#

Mojang just released a new snapshot

frail oriole Oct 4, 2023, 6:02 PM

#

yeah i saw

#

but this is still focused on 20.2 right?

mental carbon Oct 4, 2023, 6:11 PM

#

@tacit vale GradleUtils implements rsplit on string correct?

fallow sundial Oct 4, 2023, 6:11 PM

#

I mean yeah, but doens't make sense to make a new thread for 1.20.3 after 1.20.2 (assuming they take a few weeks to release that)

#

and if it just so happens that they release 1.20.3 tomorrow, 1.20.2 is rendered useless harold

rich void Oct 4, 2023, 6:45 PM

#

frail oriole why maty?

caused he changed the title?

tranquil salmon Oct 4, 2023, 6:50 PM

#

https://github.com/neoforged/NeoForm/actions/runs/6410242042

GitHub

Update to snapshot/1.20/23w40a from release/1.20.2 · neoforged/NeoF...

Contribute to neoforged/NeoForm development by creating an account on GitHub.

#

10 days before minecraft live

dull bison Oct 4, 2023, 7:11 PM

#

5 hunks of patch failures in NeoForm for the new snapshot:

Failed to apply: /home/runner/work/NeoForm/NeoForm/versions/snapshot/1.20/23w40a/patches/shared/net/minecraft/network/chat/HoverEvent.java.patch
    Cannot apply hunk @@ 7
Failed to apply: /home/runner/work/NeoForm/NeoForm/versions/snapshot/1.20/23w40a/patches/shared/net/minecraft/util/StringRepresentable.java.patch
    Cannot apply hunk @@ 7
Failed to apply: /home/runner/work/NeoForm/NeoForm/versions/snapshot/1.20/23w40a/patches/shared/net/minecraft/world/level/block/entity/SkullBlockEntity.java.patch
    Cannot apply hunk @@ 7
Failed to apply: /home/runner/work/NeoForm/NeoForm/versions/snapshot/1.20/23w40a/patches/shared/net/minecraft/core/registries/BuiltInRegistries.java.patch
    Cannot apply hunk @@ 19
Failed to apply: /home/runner/work/NeoForm/NeoForm/versions/snapshot/1.20/23w40a/patches/shared/net/minecraft/Util.java.patch
    Cannot apply hunk @@ 7

fallow sundial Oct 4, 2023, 7:14 PM

#

suspicious

#

hmm

dull bison Oct 4, 2023, 7:15 PM

#

fallow sundial <:suspicious:872520970315903117>

OH NO

quiet talon Oct 4, 2023, 7:17 PM

#

oh dear

#

what the mcfuck is that

fallow sundial Oct 4, 2023, 7:17 PM

#

it's not used anywhere fro what I can tell

quiet talon Oct 4, 2023, 7:17 PM

#

for now

fallow sundial Oct 4, 2023, 7:17 PM

#

yes

muted hemlock Oct 4, 2023, 7:17 PM

#

I assume it means

each block class has its own codec (similar to Features)
in the future, block instances will be datadriven, only the block type/codec will be registered

quiet talon Oct 4, 2023, 7:18 PM

#

mfw json file for each block

#

screm

muted hemlock Oct 4, 2023, 7:18 PM

#

so BasicAssBlock will be a registered block type and dirt will be a configuredblock

muted hemlock Oct 4, 2023, 7:18 PM

#

quiet talon mfw json file for each block

you already make json files for each block

#

you'll just have, like, eight files per block instead of seven or whatever we're at now

fallow sundial Oct 4, 2023, 7:19 PM

#

LOL

muted hemlock Oct 4, 2023, 7:19 PM

#

thinkies

#

omg yes though please make block properties data drove

quiet talon Oct 4, 2023, 7:22 PM

#

fallow sundial LOL

#

gud codec

tranquil salmon Oct 4, 2023, 7:25 PM

#

fallow sundial it's not used anywhere fro what I can tell

There is also a class named "BlockTypes"

fallow sundial Oct 4, 2023, 7:26 PM

#

yeah, I meant outside that

#

muted hemlock Oct 4, 2023, 7:27 PM

#

wip snapshot is wip

fallow sundial Oct 4, 2023, 7:28 PM

#

@mossy bobcat you're going to love this LUL

tranquil salmon Oct 4, 2023, 7:40 PM

#

new option for gametests: rerun until failed

muted hemlock Oct 4, 2023, 7:40 PM

#

that sounds like a halting problem

#

"if it never halts, it passes"

tranquil salmon Oct 4, 2023, 7:45 PM

#

public static final Codec<Object> JAVA = converter(JavaOps.INSTANCE);

JavaOps got added

frozen vapor Oct 4, 2023, 7:45 PM

#

oh no it's ObjectInputStream but codec edition

fallow sundial Oct 4, 2023, 7:45 PM

#

tranquil salmon ```java public static final Codec<Object> JAVA = converter(JavaOps.INSTANCE); ``...

oh yes

#

finally

muted hemlock Oct 4, 2023, 7:45 PM

#

tranquil salmon ```java public static final Codec<Object> JAVA = converter(JavaOps.INSTANCE); ``...

vibraeye

drowsy condor Oct 4, 2023, 7:46 PM

#

Oh god not java serialization

muted hemlock Oct 4, 2023, 7:46 PM

#

~~buried lede: it's just ObjectInputStream~~

fallow sundial Oct 4, 2023, 7:47 PM

#

nah

#

there's no java serialization

#

it just does plain maps / lists

frozen vapor Oct 4, 2023, 7:47 PM

#

of what though? thonk

#

like, if that were the case couldn't they just use the existing list/map codecs they have?

fallow sundial Oct 4, 2023, 7:48 PM

#

no as in

quiet talon Oct 4, 2023, 7:49 PM

#

cursed

lethal bane Oct 4, 2023, 7:49 PM

#

conecern

quiet talon Oct 4, 2023, 7:49 PM

#

wtf is that even for

muted hemlock Oct 4, 2023, 7:49 PM

#

fallow sundial no as in

okay so it's basically my TomlOps thinkies

#

would benefit from instanceof switches in java 21

fallow sundial Oct 4, 2023, 7:49 PM

#

components

tranquil salmon Oct 4, 2023, 7:49 PM

#

private static final Codec<Object> PRIMITIVE_ARG_CODEC = ExtraCodecs.validate(ExtraCodecs.JAVA, TranslatableContents::filterAllowedArguments);

fallow sundial Oct 4, 2023, 7:50 PM

#

   private static DataResult<Object> filterAllowedArguments(@Nullable Object object) {
      return !isAllowedPrimitiveArgument(object) ? DataResult.error(() -> {
         return "This value needs to be parsed as component";
      }) : DataResult.success(object);
   }

muted hemlock Oct 4, 2023, 7:50 PM

#

!x ? error : success screm

wise forge Oct 4, 2023, 7:51 PM

#

ew...

muted hemlock Oct 4, 2023, 7:51 PM

#

was that the same guy who turned all the isPresents to !isEmpty

wise forge Oct 4, 2023, 7:51 PM

#

lol

fallow sundial Oct 4, 2023, 7:51 PM

#

decompiler moment

#

anyways

#

cool start to 1.20.3

wise forge Oct 4, 2023, 7:59 PM

#

Anything in terms of major changes in the diff?

tranquil salmon Oct 4, 2023, 7:59 PM

#

TreeGrower now has a codec

wise forge Oct 4, 2023, 8:01 PM

#

That's the ones for saplings right? Where is it used?

muted hemlock Oct 4, 2023, 8:01 PM

#

probably in the sapling block codec

inland mesa Oct 4, 2023, 8:01 PM

#

so is neo skipping 1.20.2 now?

wise forge Oct 4, 2023, 8:02 PM

#

Now I'm slightly more confused

#

Why would a sapling need a codec?

muted hemlock Oct 4, 2023, 8:03 PM

#

mojang is doing the thing we kept speculating they would and getting blocks ready to be data-driven

#

they aren't yet

#

but each block class has a codec now, like Features

inland mesa Oct 4, 2023, 8:03 PM

#

soon

muted hemlock Oct 4, 2023, 8:03 PM

#

https://ih1.redbubble.net/image.3011793532.4722/raf,750x1000,075,t,heather_grey.jpg

wise forge Oct 4, 2023, 8:03 PM

#

Oh, like the behavior back stuff in java edition?

muted hemlock Oct 4, 2023, 8:04 PM

#

what

inland mesa Oct 4, 2023, 8:04 PM

#

Json Things will be able to yeet a lot of code

wise forge Oct 4, 2023, 8:04 PM

#

Behavior packs from bedrock in java

#

Also giga's thing too

inland mesa Oct 4, 2023, 8:04 PM

#

they can add blocks ?

wise forge Oct 4, 2023, 8:04 PM

#

I thought they could?

#

Am I misremembering things again?

inland mesa Oct 4, 2023, 8:05 PM

#

no idea

sturdy phoenix Oct 4, 2023, 8:05 PM

#

iirc yeah, but it's just like a cosmetic cover over an existing block

inland mesa Oct 4, 2023, 8:05 PM

#

I don't touch bedrock

wise forge Oct 4, 2023, 8:05 PM

#

sturdy phoenix iirc yeah, but it's just like a cosmetic cover over an existing block

ah, that makes sense

inland mesa Oct 4, 2023, 8:05 PM

#

I have been saying for years that mojang should have added a placeholder block/item that allows linking uses to commands

#

I guess that will not be needed in the future

sturdy phoenix Oct 4, 2023, 8:07 PM

#

yeah, ig with data-driven blocks and interaction entities, you kind of have it all

tranquil salmon Oct 4, 2023, 8:07 PM

#

There is a codec for block properties but it is currently

public static final Codec<BlockBehaviour.Properties> CODEC = Codec.unit(() -> of());

wise forge Oct 4, 2023, 8:08 PM

#

sturdy phoenix yeah, ig with data-driven blocks and interaction entities, you kind of have it a...

~~i shudder at fluids~~

wise forge Oct 4, 2023, 8:08 PM

#

tranquil salmon There is a codec for block properties but it is currently ```java public static ...

I wonder how copying will work with that

rich void Oct 4, 2023, 8:12 PM

#

muted hemlock mojang is doing the thing we kept speculating they would and getting blocks read...

wouldn't they make items data-driven too?

sturdy phoenix Oct 4, 2023, 8:13 PM

#

one thing at a time :p

jagged agate Oct 4, 2023, 8:15 PM

#

Considering blockitems exist, I would imagine both have to be done together or at least the items modified to reference the correct datadriven created block

tacit vale Oct 4, 2023, 8:26 PM

#

mental carbon <@277525077669445632> GradleUtils implements rsplit on string correct?

idk why

kindred fractal Oct 4, 2023, 8:35 PM

#

I wonder if 20.3 will take a long time or not

#

I guess we'll have to focus on 20.2 for now

fallow sundial Oct 4, 2023, 8:39 PM

#

kindred fractal I wonder if 20.3 will take a long time or not

it definitely doesn't seem to be an easy update

tranquil salmon Oct 4, 2023, 8:41 PM

#

They also mentioned that they would readd the return run and execute if function commands sometime early in this snapshot series

muted hemlock Oct 4, 2023, 8:42 PM

#

challenge accepted harold

kindred fractal Oct 4, 2023, 8:44 PM

#

So this might take a few weeks at least

#

At this rate we'll have to pick "long term" mc versions

mental carbon Oct 4, 2023, 8:48 PM

#

tacit vale idk why

Already foiund it, it is used in several places in the buildscript

mossy bobcat Oct 4, 2023, 8:50 PM

#

fallow sundial <@824138021854117939> you're going to love this <:LUL:577908625666867200>

Finally!

#

I'm interested to see where it goes

tawny iron Oct 4, 2023, 8:53 PM

#

so no 1.20.2 release?

dim sonnet Oct 4, 2023, 8:55 PM

#

Looks unlikely. If you want one stick to Forge for now

fallow sundial Oct 4, 2023, 8:56 PM

#

I'm not sure how you got to that conclusion

dim sonnet Oct 4, 2023, 8:56 PM

#

Kits has started work updating to 1.20.3 before NeoForge 1.20.2 has released

tawny iron Oct 4, 2023, 8:56 PM

#

seems pretty simple

#

mental carbon Oct 4, 2023, 8:57 PM

#

[1.20.2,)

tawny iron Oct 4, 2023, 8:57 PM

#

current latest: 1.20.1
Current channel focussed on 1.20.2: Oops, maybe 1.20.3

fallow sundial Oct 4, 2023, 8:57 PM

#

dim sonnet Kits has started work updating to 1.20.3 before NeoForge 1.20.2 has released

no?

tawny iron Oct 4, 2023, 8:57 PM

#

logical conclusion: Maybe 1.20.3?

fallow sundial Oct 4, 2023, 8:57 PM

#

neoform releases are automated

mental carbon Oct 4, 2023, 8:57 PM

#

dim sonnet Kits has started work updating to 1.20.3 before NeoForge 1.20.2 has released

No

#

NF Releases are fully automatic

#

I am currently in the middle of dealing with the damn fucking installer

#

It is such a stupidly annoyingly undocumented piece of shit

dim sonnet Oct 4, 2023, 8:58 PM

#

"The code is the documentation" -some random arsehole

fallow sundial Oct 4, 2023, 8:59 PM

#

1.20.3 is VERY FAR from a releasable state considering the code in the snapshot kek

mental carbon Oct 4, 2023, 8:59 PM

#

Like the fact that it requires what feels like 20 different tiny things to be exactly right

#

Is soooooo annoying

fallow sundial Oct 4, 2023, 8:59 PM

#

this is 2 months if luck strikes us

dim sonnet Oct 4, 2023, 8:59 PM

#

Installer's terrible, I fully agree. I tried documenting and rewriting it ages ago and gave up entirely

#

If you look on the FCW you'll probably see a rambling post on my profile somewhere, although it's probably not useful at your stage

fallow sundial Oct 4, 2023, 9:00 PM

#

fallow sundial 1.20.3 is VERY FAR from a releasable state considering the code in the snapshot ...

unused registry, unit codecs, if they started to write stuff for datapack blocks they won't release 1.20.3 until they finish it more than likely. which means datapack items and all of that too

#

so it's going to be a while

mental carbon Oct 4, 2023, 9:00 PM

#

dim sonnet Installer's terrible, I fully agree. I tried documenting and rewriting it ages a...

The problem is not actually the installer

#

It is all the combinations of tasks in the build.gradle, the buildSrc in Forge and NeoGradle all some fucking how working undocumented together

#

Without there being a link to anything

fallow sundial Oct 4, 2023, 9:01 PM

#

[1.20.2,1.21)

#

best thread title

mental carbon Oct 4, 2023, 9:01 PM

#

Like all of a suddon String#rsplit appears

#

And it send me into a tail spin for an hour

dim sonnet Oct 4, 2023, 9:02 PM

#

Oh yeah the gradleutils dynamic methods are annoying harold

mental carbon Oct 4, 2023, 9:02 PM

#

Trying to figure out, what the holy mother of fuck is rsplit

fallow sundial Oct 4, 2023, 9:02 PM

#

that metaclass injection is a sin

mental carbon Oct 4, 2023, 9:02 PM

#

Untill I remembered it in GU

#

And then it was trivial

fallow sundial Oct 4, 2023, 9:02 PM

#

mental carbon Trying to figure out, what the holy mother of fuck is rsplit

that's obviously the reverse spin of an electron

mental carbon Oct 4, 2023, 9:02 PM

#

XD

#

Typo

dim sonnet Oct 4, 2023, 9:03 PM

#

Hey @stray scroll, how's the compilestatic going for that? I remember you saying you were removing rsplit from the string metaclass and making it as static method instead as you couldn't find external usages of it

#

(That being gradleutils)

mental carbon Oct 4, 2023, 9:03 PM

#

Yeah but NGNext does not depend on GU for good reasons

#

So I had to reimplement from it what I needed

rich void Oct 4, 2023, 9:04 PM

#

So Neo will be skipping 20.2?

dim sonnet Oct 4, 2023, 9:04 PM

#

fallow sundial this is 2 months if luck strikes us

"this" being 1.20.3 or neoforge for 1.20.2?

mental carbon Oct 4, 2023, 9:05 PM

#

#

And then there is shit like this

#

Where I can't pass in a lazy map in gradle.....

#

Like what the actual f

mossy bobcat Oct 4, 2023, 9:06 PM

#

fallow sundial <:suspicious:872520970315903117>

Interesting that it's a map codec too. That'll make combining or extending stuff easier to a degree

#

Though still curious if they come up with a solution to polymorphic codecs that's less cursed than what I did

#

I bet they'll probably do what they did with the tree stuff

kindred fractal Oct 4, 2023, 9:09 PM

#

rsplit is like split but starting from the right

kindred fractal Oct 4, 2023, 9:09 PM

#

fallow sundial so it's going to be a while

Yeah

fallow sundial Oct 4, 2023, 9:10 PM

#

dim sonnet "this" being 1.20.3 or neoforge for 1.20.2?

I was talking about 1.20.3, i very much hope that neo 1.20.2 doesn't take two more months

dim sonnet Oct 4, 2023, 9:10 PM

#

Wait, 1.20.2 came out two months ago? Wow time flies o.O

jagged agate Oct 4, 2023, 9:11 PM

#

September 21, 2023 for 1.20.2

#

Maty was saying Mojang working on 1.20.3 will take two months

#

Assuming Mojang doesn’t have dev branches already with the block data driven stuff more fleshed out

dim sonnet Oct 4, 2023, 9:12 PM

#

Derp, sleepy me took "two more months" as implying it's already been two months and hoping it won't take another two

fallow sundial Oct 4, 2023, 9:12 PM

#

to that I say

#

sleep

#

I'm very curious how mojang is going about this.. it doesn't seem like they're reusing datapack registries for blocks. now is the time they either make something good and it will benefit everyone a lot or it's a good idea with a bad implementation

jagged agate Oct 4, 2023, 9:21 PM

#

Enum for every block codec

#

Like no registry. Just one giant enum for every block

mental carbon Oct 4, 2023, 9:22 PM

#

The worry I have are the more complex blocks....

#

How are they going to deal with those

#1.20.2