1.20.2 | The NeoForged Project | Page 2

inland mesa Sep 6, 2023, 2:24 PM

#

then use a boring name

#

it was only a suggestion

#

I didn't even imply that it had to be that name, i just said "something like Greenhouse"

winged hull Sep 6, 2023, 4:13 PM

#

idk just call it like USB-Neo-3.1-10G, because usb is a type of port and this repo is for porting

mental carbon Sep 6, 2023, 6:23 PM

#

Okey

#

Now in Official mappigns

#

And two rejects down

#

106 to go

rich void Sep 6, 2023, 6:38 PM

#

winged hull idk just call it like USB-Neo-3.1-10G, because usb is a type of port and this re...

USB Type N

#

||Whoops I turned the ping off @winged hull ||

winged hull Sep 6, 2023, 6:45 PM

#

USB type NF

muted hemlock Sep 6, 2023, 6:46 PM

#

non-fungible USB, like we had before USBC

winged hull Sep 6, 2023, 6:49 PM

#

non forge USB!

dim sonnet Sep 6, 2023, 6:56 PM

#

Neo 3.1 Gen 2x2

winged hull Sep 6, 2023, 6:56 PM

#

10 gigs

dim sonnet Sep 6, 2023, 6:57 PM

#

Next MC version all previous Neo releases are rebranded to Neo 3.2 Gen 1

fallow sundial Sep 6, 2023, 7:07 PM

#

topic guys

winged hull Sep 6, 2023, 7:38 PM

#

we're coming up with names for the private repo!

muted hemlock Sep 6, 2023, 7:43 PM

#

porge

winged hull Sep 6, 2023, 7:50 PM

#

that sound like a brand of porridge, I vote yes

rich void Sep 6, 2023, 7:57 PM

#

norge

mental carbon Sep 6, 2023, 7:57 PM

#

Okey porting started

rich void Sep 6, 2023, 7:57 PM

#

nice!

mental carbon Sep 6, 2023, 7:58 PM

#

If somebody wants to help you need the features/neoform_defaulted branch of NG pushed to maven local to get started.

#

There is 102 patch files remaining

#

And the switch to vineflower, is really annoying

#

Cause a lot of our lambda injections are broken because of the different decompilation

dull bison Sep 6, 2023, 8:18 PM

#

Has a decision been made on volunteers? I have time to do some porting tomorrow

mental carbon Sep 6, 2023, 8:29 PM

#

Not for patch problems

#

PATCH 1.20.2: xxxxx is my current pattern for tracking patches which were applied but that are currently broken

winged hull Sep 6, 2023, 8:50 PM

#

dull bison Has a decision been made on volunteers? I have time to do some porting tomorrow

if we accept volunteers, I have alot of time free tomorrow

kindred fractal Sep 6, 2023, 9:05 PM

#

I honestly don't know if you are competent enough to update Neo

winged hull Sep 6, 2023, 9:11 PM

#

lol probably not

tawny iron Sep 6, 2023, 9:21 PM

#

damn, what a statement lol

winged hull Sep 6, 2023, 9:22 PM

#

it's true

fallow sundial Sep 6, 2023, 9:22 PM

#

competent is arguable, having the patience and nerves to do so is probably no lmao

winged hull Sep 6, 2023, 9:22 PM

#

I am good at coding but have little knowledge of mc ¯_(ツ)_/¯

winged hull Sep 6, 2023, 9:23 PM

#

fallow sundial competent is arguable, having the patience and nerves to do so is probably no lm...

from making a game in pure opengl in c++. Trust me. I have alot of patience

tacit vale Sep 6, 2023, 10:06 PM

#

Webhook is still missing

arctic sphinx Sep 6, 2023, 10:32 PM

#

Poke Maty or Sci

winged hull Sep 6, 2023, 10:40 PM

#

maty or sci👈There you go.

stray scroll Sep 7, 2023, 2:55 AM

#

webhook should now be active

dull bison Sep 7, 2023, 4:54 AM

#

If I'm allowed to I could do some porting, I have the knowhow from watching many porting streams in the voice channel. I can also stream here in discord so you can check what I'm doing.

mental carbon Sep 7, 2023, 7:26 AM

#

Ah great block colors and item color impl has changed

#

Nvm

#

Mis read the patch

dull bison Sep 7, 2023, 8:34 AM

#

is anyone besides orion working on porting? If not you should think about letting volunteers with experience in neo/forge help with porting. Because as I see it nobody from the team has actually got time to do it.

fallow sundial Sep 7, 2023, 8:34 AM

#

stray scroll webhook should now be active

how did you add the webhook

dull bison Sep 7, 2023, 9:36 AM

#

what's the number of patches remaining?

mental carbon Sep 7, 2023, 9:36 AM

#

Patches no clue?

#

Patch files 100 roughly

#

But that is not actually the biggest time sink

#

We switch to VineFlower

#

And that broke soooo many patches because of bull shit with brackets..........

stray scroll Sep 7, 2023, 10:00 AM

#

fallow sundial how did you add the webhook

uhhh... normally?

stray scroll Sep 7, 2023, 10:00 AM

#

dull bison is anyone besides orion working on porting? If not you should think about lettin...

hmmmm.

#

<@&1128776937410670663>s react with 👍 or 👎 on allowing selected community members to be onboarded as porters for this porting cycle (and possibly future ones, if they're not Maintainers by them)
if you 👍, then also react with 💡if you're okay with the selection process being: nominated by a Maintainer, and approved by two others (so three Maintainers in total)

open for 24 hours, <t:1694167200:f> (<t:1694167200:R>) or until 11 members vote for either way

#

note to self: make voting bot

inland mesa Sep 7, 2023, 10:03 AM

#

blobping

#

Hmm, I'm personally ok with that as a temporary thing, but I think it may be more useful to have some sort of "Helper" role that people can be invited into, and to say that any Helper is implicitly allowed to request to join the porting work

stray scroll Sep 7, 2023, 10:10 AM

#

we do have the Helper role (originally named superhelper), to which Triage Team members in the past were added to when they left the team voluntarily
but using that role would need more thought, since it is a publicly pingable role (and was intended for "@superhelper help" situations)

#

this current topic of porters will likely cease once governance is established and we can onboard more Maintainers

inland mesa Sep 7, 2023, 10:12 AM

#

it's always going to be good to have provisions for when an update happens at the same time the existing maintainers happen to be busy

#

but anyhow, sounds good

stray scroll Sep 7, 2023, 10:14 AM

#

we do have to be a tad careful with giving people access to porting, because that implicitly means they can push through changes to the code which may go unreviewed come the final release (unless we start making it policy/culture to review each other's pushes to the private repo)

#

which is why I suggest three maintainers (one nominator, two approvers) to approve a new porter

#

on the basis that they'll only nominate/approve if they know the person to be trustworthy

#

and three, partly because of that implicit permission I mentioned earlier, since it usually takes one Maintainer to approve a PR, so three strikes a balance of enough eyes while not being totally cumbersome

fallow sundial Sep 7, 2023, 10:25 AM

#

stray scroll uhhh... normally?

use the action stabolb

stray scroll Sep 7, 2023, 10:26 AM

#

...oh right, we have an action for that
I didn't remember, and I don't even know now where that is kek

stray scroll Sep 7, 2023, 10:26 AM

#

stray scroll <@&1128776937410670663>s react with 👍 or 👎 on allowing selected community memb...

fallow sundial Sep 7, 2023, 10:27 AM

#

stray scroll ...oh right, we have an action for that I didn't remember, and I don't even know...

https://github.com/neoforged/actions

GitHub

GitHub - neoforged/actions: A collection of GitHub actions that do ...

A collection of GitHub actions that do various tasks - GitHub - neoforged/actions: A collection of GitHub actions that do various tasks

true pivot Sep 7, 2023, 11:42 AM

#

mental carbon We switch to VineFlower

VF is ready? I thought that would be postponed

mental carbon Sep 7, 2023, 11:42 AM

#

No it got ready in time

#

Okey custom networking got fucked

#

We kind of need a custom payload processing system

#

But that is burried deep in FML

wise forge Sep 7, 2023, 12:10 PM

#

stray scroll <@&1128776937410670663>s react with 👍 or 👎 on allowing selected community memb...

I’m fine with this, especially since I’m a computer short

tawny iron Sep 7, 2023, 12:14 PM

#

The problem being that if you dont allow people to at least start to be involved, you eventually end up in a situation where the only people remaining arent involved anymore and the whole thing goes stale

#

Maintaining at least a somewhat healthy avenue for new contributors is important for the longevity of the project

dull bison Sep 7, 2023, 12:15 PM

#

this is only about porting (for this cycle) everything else will be handled by the governance docs

wise forge Sep 7, 2023, 12:18 PM

#

~~now if only someone would take up the temporary role of making the porting guide so that we don’t have to rely on apple’s guide for fabric~~

dull bison Sep 7, 2023, 12:19 PM

#

~~me do code me no writey~~

kindred fractal Sep 7, 2023, 12:55 PM

#

I think porting is particularly tricky

#

Especially here... The networking stuff alone took Fabric a week

pine ember Sep 7, 2023, 1:06 PM

#

Do let me know if you need someone to bounce ideas off for the networking stuff, I spent a whole week of my life doing nothing but networking 😄

#

I know we already spoke about some parts of it a while back, but im quite happy to go over it again.

mental carbon Sep 7, 2023, 1:09 PM

#

pine ember Do let me know if you need someone to bounce ideas off for the networking stuff,...

Currently I am just trying to fix the patches

#

The new system for custom packets works with records, etc

#

And our FML networking layer was not designed for that

pine ember Sep 7, 2023, 1:11 PM

#

Neither was ours, I ended up implementing our old APIs on-top of the vanilla vanilla system.

mental carbon Sep 7, 2023, 1:11 PM

#

Yeah

#

I just literally do the same

#

Created a custom implementation of the weird customquerypayload interface

#

Which just holds the FriendlyByteBuf

#

And then reads / writes it properly

pine ember Sep 7, 2023, 1:12 PM

#

Yes, exact same as what we did

tacit vale Sep 7, 2023, 1:23 PM

#

stray scroll we do have to be a tad careful with giving people access to porting, because tha...

We should be reviewing all code anyways

shadow widget Sep 7, 2023, 2:02 PM

#

PRE 2 squirr

dull bison Sep 7, 2023, 2:02 PM

#

sound the alarm

#

🚨

arctic sphinx Sep 7, 2023, 2:06 PM

#

<@&1067092163520909374>
https://mdcfe.dev/mc-changes?ver=1.20.2-pre2
https://www.minecraft.net/en-us/article/minecraft-1-20-2-pre-release-1

fallow sundial Sep 7, 2023, 2:08 PM

#

I feel like they're reverting everything this update

dull bison Sep 7, 2023, 2:08 PM

#

tl;dr
they reverted the recipe book search changes and made some bugfixes

tranquil salmon Sep 7, 2023, 2:09 PM

#

fallow sundial I feel like they're reverting everything this update

1.20.2: the revert update

dull bison Sep 7, 2023, 2:09 PM

#

1.20.3: revert all changes since 1.8

dull bison Sep 7, 2023, 2:10 PM

#

stray scroll <@&1128776937410670663>s react with 👍 or 👎 on allowing selected community memb...

btw coehlrich you haven't voted here yet

tacit vale Sep 7, 2023, 2:38 PM

#

@stray scroll your conditions have been meet

arctic sphinx Sep 7, 2023, 2:40 PM

#

?

tacit vale Sep 7, 2023, 2:42 PM

#

wait nvm

#

sorry lol

#

I just added 7 thumbs up + 4 light bulbs to get 11 but it's only actually 7 votes

muted hemlock Sep 7, 2023, 2:44 PM

#

tacit vale <@607058472709652501> your conditions have been meet

https://i.imgur.com/yg4KswH.png

Imgur

fallow sundial Sep 7, 2023, 2:47 PM

#

maths with shirmp

kindred fractal Sep 7, 2023, 2:52 PM

#

Also, some votes are from non team members

#

Suggestion: rename #neoforge-private to #neoforge-porting and add neoform to it

dull bison Sep 7, 2023, 2:52 PM

#

kindred fractal Also, some votes are from non team members

nope those got removed

#

@inland mesa I think you voted before and your vote got removed

inland mesa Sep 7, 2023, 3:11 PM

#

oh just noticed pre2 is out. RIP recipe book search changes.

#

(in my defense I was napping -- I literally couldn't have known earlier :P)

mental carbon Sep 7, 2023, 6:22 PM

#

I am starting to hate vineflower:

fallow sundial Sep 7, 2023, 6:25 PM

#

lol

tacit vale Sep 7, 2023, 6:34 PM

#

I don't think it makes sense to do vineflower and porting at the same time

#

we should have either ported first then switched to vineflower or done vineflower before porting

#

Both at once is a bit much

mental carbon Sep 7, 2023, 6:44 PM

#

Yep

#

But that is not what happened

#

And it is actually going pretty good at the moment

#

I patched most of the big issues

fallow sundial Sep 7, 2023, 6:44 PM

#

it has to happen at some point harold

mental carbon Sep 7, 2023, 6:44 PM

#

And this is the first one in like 20 rejects where it really fucked up the patch

#

But I patched the networking system already

#

Because I needed to....

#

Goodbye ICustomPacket<?> it was nice knowing you

#

Fuck

#

ChunkRenderDispatcher is gone........

#

Well that is crap

lean warren Sep 7, 2023, 6:55 PM

#

Wasn't that just renamed to SectionRenderDispatcher along a few other things going from ChunkX to SectionX?

mental carbon Sep 7, 2023, 6:56 PM

#

Yeah

#

but its implementation is not exactly line up the same so that I can try to reapply the patch...... 😦

mental carbon Sep 7, 2023, 7:13 PM

#

Fixed

#

They changed Sprite loading again....

rich void Sep 7, 2023, 8:35 PM

#

Mojang likes to change everything every update xD

mental carbon Sep 7, 2023, 8:52 PM

#

27% done

muted hemlock Sep 7, 2023, 8:56 PM

#

rich void Mojang likes to change everything every update xD

🤷‍♀️ I do the same thing in my mods, I can't blame them

winged hull Sep 7, 2023, 8:57 PM

#

same

tacit vale Sep 7, 2023, 8:59 PM

#

mental carbon 27% done

Where's the commits?

inland mesa Sep 7, 2023, 8:59 PM

#

I don't change everything every update

tacit vale Sep 7, 2023, 8:59 PM

#

Nvm

mental carbon Sep 7, 2023, 8:59 PM

#

tacit vale Where's the commits?

In the repo?

inland mesa Sep 7, 2023, 8:59 PM

#

but I do not have any personal "rules" wrt breaking changes -- if something is worth refactoring then I refactor

tacit vale Sep 7, 2023, 9:00 PM

#

mental carbon In the repo?

Yeah I'm just blind

mental carbon Sep 7, 2023, 9:09 PM

#

And another 2 patches down

#

All client patches are complete now

mossy bobcat Sep 7, 2023, 9:10 PM

#

mental carbon They changed Sprite loading again....

screm

#

I just finished getting DynAssetGen to support that system

mental carbon Sep 7, 2023, 9:10 PM

#

Wellll

#

Not sure if it is functionally different

#

But its implementation was significantly different

#

And cleaned up IMHO

#

But it took me a good second to figure out where out code needs to hook XD

tacit vale Sep 7, 2023, 9:13 PM

#

Force push?

#

What happened

mental carbon Sep 7, 2023, 9:13 PM

#

I needed to ammend a broken commit

#

Nothing happened......

tacit vale Sep 7, 2023, 9:14 PM

#

what do you mean needed to amend

#

you just push a fixup /shrug

#

I used to overuse forcepush during porting so I was curious why you were that's all

mental carbon Sep 7, 2023, 9:18 PM

#

The point is: If I push a commit which is either logically broken, because i derped and forgot to add all the needed files, or because I signed with the wrong account, and I see it within seconds of me pushing the original commit then I will force push a ammended commit which fixes it

#

I rather not have a set of broken commits in the history

kindred hatchBOT Sep 7, 2023, 9:18 PM

#

[Jump to referenced message.](#builds message)

tacit vale Sep 7, 2023, 9:18 PM

#

mental carbon I rather not have a set of broken commits in the history

I mean sure but it's internal history but k

mental carbon Sep 7, 2023, 9:18 PM

#

Yeah it is internal

#

Why dopes camelot do that?!?

kindred hatchBOT Sep 7, 2023, 9:19 PM

#

oriononline

[Reference ➤ ](#1136320550168436798 message)The point is: If I push a commit which is either logically broken, because i derped and forgot to add all the needed files, or because I signed with the wrong account, and I see it within seconds of me pushing the original commit then I will force push a ammended commit which fixes it

mental carbon Sep 7, 2023, 9:19 PM

#

WTF?

#

Who though that was a great idea for a bot?

#

Test: #1136320550168436798 message

#

Okey it leaves it if I type something

kindred hatchBOT Sep 7, 2023, 9:20 PM

#

oriononline

[Reference ➤ ](#1136320550168436798 message)The point is: If I push a commit which is either logically broken, because i derped and forgot to add all the needed files, or because I signed with the wrong account, and I see it within seconds of me pushing the original commit then I will force push a ammended commit which fixes it

mental carbon Sep 7, 2023, 9:20 PM

#

@fallow sundial Can we please disable this: ^

#

This is really obnoxious

tacit vale Sep 7, 2023, 9:21 PM

#

It's not really

#

That's like a standard thing that bots can do

#

And it is convenient

fallow sundial Sep 7, 2023, 9:23 PM

#

mental carbon <@561254664750891009> Can we please disable this: ^

no, it only happens when you send a message starting with exactly a message link (you can wrap it in <> to surpress it) and your message is only deleted if you only sent the link. it exists because mobile has a very hard time sending you to correct messages when they're older than 10 minutes and when you have poor internet connection

tacit vale Sep 7, 2023, 9:25 PM

#

OMG so true

#

honestly forgot about that awful shit

fallow sundial Sep 7, 2023, 9:26 PM

#

what awful shit? mobile? harold

wise forge Sep 7, 2023, 9:26 PM

#

Always a fun time having to click the link three times to be sent to the wrong location

fallow sundial Sep 7, 2023, 9:26 PM

#

(plus this way of referencing messages actually comes with the benefit of not interrupting the flow of the chat)

#

the conversation remains linear

#

which is good because discord is linear

#

having to click 4 links and jump through messages is horrendous

tranquil salmon Sep 7, 2023, 9:40 PM

#

I updated the username for #builds message for the finish message to capitalize the H but forgot to update the start message

fallow sundial Sep 7, 2023, 9:40 PM

#

tbh I hate the fact that github is actually GitHub with the H capitalized lol

tranquil salmon Sep 7, 2023, 9:41 PM

#

Also don't you love when the github actions runner randomly loses connection for no apparent reason

winged hull Sep 7, 2023, 9:44 PM

#

fallow sundial no, it only happens when you send a message starting with exactly a message link...

and when you accidentally click on something after you clicked on the message you wanted to go to, it will deposit you like halfway there

tranquil salmon Sep 7, 2023, 9:48 PM

#

#builds message

winged hull Sep 7, 2023, 10:01 PM

#

you use canary?

tawny iron Sep 7, 2023, 10:07 PM

#

he works in a coal mine

winged hull Sep 7, 2023, 10:09 PM

#

is my internet shit or does coel have a blank pfp

#

everytime I read his name, I think of coelacanth!

tacit vale Sep 7, 2023, 10:23 PM

#

tranquil salmon I updated the username for https://canary.discord.com/channels/31312560392463976...

:fixit :

tranquil salmon Sep 8, 2023, 12:27 AM

#

fallow sundial no, it only happens when you send a message starting with exactly a message link...

Seemingly mobile also can't process channel renames

tacit vale Sep 8, 2023, 12:34 AM

#

It does but it takes a while

#

my mobile channels only just recently got the memo that brainstorming is called brainstorming

winged hull Sep 8, 2023, 12:35 AM

#

mine gor the memo like awhile ago

inland mesa Sep 8, 2023, 12:41 AM

#

some weeks back my phone took a few hours to realize #mixin was no longer called non-api, and was no longer in the archive

winged hull Sep 8, 2023, 1:02 AM

#

I just restarted discord and it now recognizes #tooling-dev!

stray scroll Sep 8, 2023, 4:54 AM

#

as I check the vote message I have pinned, I realize I forgot to cast my own vote, even though the count of Maintainers I have in the message includes myself thinkies

#

coughs @quiet talon don't forget to also react with 👍

warm root Sep 8, 2023, 5:57 AM

#

Will it be necessary to change the code after the release of 1.20.2?

dull bison Sep 8, 2023, 6:07 AM

#

which code?

warm root Sep 8, 2023, 6:17 AM

#

Code for mods

dull bison Sep 8, 2023, 6:19 AM

#

depends on what you use

#

I think the whole networking stuff needs to be changed on neos end since mojang fu**d with it

rich void Sep 8, 2023, 7:34 AM

#

muted hemlock 🤷‍♀️ I do the same thing in my mods, I can't blame them

I mean, if it's a good change...

wise forge Sep 8, 2023, 8:50 AM

#

I would say it’s somewhat likely

dull bison Sep 8, 2023, 9:35 AM

#

ok 25 minutes left on the vote and 1 upvote left for an early accept I think that is a pretty clear result

dull bison Sep 8, 2023, 10:00 AM

#

stray scroll <@&1128776937410670663>s react with 👍 or 👎 on allowing selected community memb...

Vote is over 10 👍 and 5 💡

mental carbon Sep 8, 2023, 10:48 AM

#

Core and Data patches are now applied

#

Next up for me are the Network patches

stray scroll Sep 8, 2023, 11:07 AM

#

stray scroll <@&1128776937410670663>s react with 👍 or 👎 on allowing selected community memb...

all positive and no negative votes, so it's clear that the question on community porters is agreed to
the proposed selection process fell one vote short of the majority of people who voted (10 votes meaning 6 is a majority), but it's a draw

<@&1128776748666978355> given the second question -- on the proposed selection process -- resulted in an tie of votes, I'm asking for the council's decision on whether it'll go through (as a casting vote), or if we need to figure out another selection process

stray scroll Sep 8, 2023, 11:07 AM

#

stray scroll all positive and no negative votes, so it's clear that the question on community...

mental carbon Sep 8, 2023, 11:42 AM

#

stray scroll all positive and no negative votes, so it's clear that the question on community...

It has my vote on the selection process. 1 Recommeder + 2 Approvals is sufficient

stray scroll Sep 8, 2023, 11:44 AM

#

👍 just need the confirmation of either Shrimp or cpw

mental carbon Sep 8, 2023, 11:44 AM

#

Recommender != Approver

#

That way three distinct people are needed

mental carbon Sep 8, 2023, 11:44 AM

#

stray scroll 👍 just need the confirmation of either Shrimp or cpw

Do you want to somehow deal with rejection votes?

stray scroll Sep 8, 2023, 11:49 AM

#

I mean, waiting for the confirmation of Shrimp or cpw on the council deciding to proceed with the proposed selection process

#

since this is a council decision

#

i'm just a lowly secretary 🗒️

kindred fractal Sep 8, 2023, 12:16 PM

#

For networking, remember the agreed-upon scheme (https://github.com/FabricMC/fabric/pull/3244)

GitHub

[1.20.2] Support common registration packets. Add configuration tas...

There is more! The original port was very rough, this is hopefully a better longer term solution!
Common channel registration packets
Previously we sent the play packet channels in a custom packet ...

#

Also what does it have to do with FML? concern

fallow sundial Sep 8, 2023, 12:19 PM

#

networking is fml

mental carbon Sep 8, 2023, 12:21 PM

#

kindred fractal For networking, remember the agreed-upon scheme (https://github.com/FabricMC/fab...

At the moment I am not looking at that, right now I am just reimplementing ICustomPacket

#

What packets get send when I have not dealth with

kindred fractal Sep 8, 2023, 12:22 PM

#

fallow sundial networking is fml

Shouldn't it be moved to Forge?

mental carbon Sep 8, 2023, 12:22 PM

#

No, part of FML deals with networking

stray scroll Sep 8, 2023, 12:23 PM

#

good ol' handshakes

mental carbon Sep 8, 2023, 12:23 PM

#

Particularly handshakes, and like none payload data are done by FML

kindred fractal Sep 8, 2023, 12:23 PM

#

Why split everything up :/

mental carbon Sep 8, 2023, 12:23 PM

#

Because Forge is supposed ot be for the the content

#

I don't understand why Fabric and not Fabrics loader deals with the handshake

#

Are normal fabric mods supposed to deal with the handshake?!?

kindred fractal Sep 8, 2023, 12:23 PM

#

Because floader is mc version agnostic

mental carbon Sep 8, 2023, 12:25 PM

#

Well there you have it then

#

It is a conceptual philosy difference

kindred fractal Sep 8, 2023, 12:25 PM

#

It just sounds annoying to have to update 2 repos

mental carbon Sep 8, 2023, 12:25 PM

#

We don't......

kindred fractal Sep 8, 2023, 12:25 PM

#

I assume FML has its own patches too for networking

mental carbon Sep 8, 2023, 12:25 PM

#

As long as you implement the loading contract with packets in Forge

#

The system will work

#

Regardless of what underpins it

mental carbon Sep 8, 2023, 12:26 PM

#

kindred fractal I assume FML has its own patches too for networking

No

#

FML has no patches

kindred fractal Sep 8, 2023, 12:26 PM

#

Ah well that's fine then, basic handshake helper functions in FML make sense... As long as the patches to use them are in Forge

stray scroll Sep 8, 2023, 12:27 PM

#

FML only has a handful of hooks into vanilla code, iirc (ones I remember off the top of my head are the ones for invoking the mod loading start)
(and currently all implemented using ASM coremods)

pine ember Sep 8, 2023, 12:27 PM

#

When I ported fabric I first got it all working as it was previously, using the login phase

#

and then created the configuration APIs later, and moved reg sync and the handshakes over.

mental carbon Sep 8, 2023, 12:28 PM

#

^

kindred fractal Sep 8, 2023, 12:28 PM

#

Sounds reasonable yes

mental carbon Sep 8, 2023, 12:28 PM

#

I want to get the game bootiung in pre1

#

Then pre2

#

And then I can deal with what ever is needed

#

Including moving things across layers

#

And potentially making more use of the new payloads system

#

I am also pretty sure I need to deal with payload discarding

#

To prevent memory leaks

#

Because that got ripped out

#

But that needs research later on

#

To be hoenst

#

I wish we had a "remap" mode for patches

#

Cause this is sometimes really problematic

kindred fractal Sep 8, 2023, 12:31 PM

#

Could move them to plain mojmap, imo

mental carbon Sep 8, 2023, 12:31 PM

#

Nope

#

Because the patches have to be intermediary

#

To support NG mapping channels

kindred fractal Sep 8, 2023, 12:32 PM

#

I am talking about full runtime mojmap

mental carbon Sep 8, 2023, 12:32 PM

#

And to support efficient cross mapping channel apply in forgedev

kindred fractal Sep 8, 2023, 12:32 PM

#

Anyway I'll stop distracting you 😛

mental carbon Sep 8, 2023, 12:34 PM

#

network patches complete

#

started resource patches

mental carbon Sep 8, 2023, 12:34 PM

#

kindred fractal Anyway I'll stop distracting you 😛

You can come sit in voice chat XD

#

resource patches complete

#

started server patches

stray scroll Sep 8, 2023, 12:37 PM

#

proper distraction comes in the form of discussion of a suitably interesting topic alongside applications of suitable cute animal pictures at regular intervals

kindred fractal Sep 8, 2023, 12:38 PM

#

mental carbon You can come sit in voice chat XD

Sure

mental carbon Sep 8, 2023, 12:42 PM

#

@kindred fractal #1136320550168436798 message

mental carbon Sep 8, 2023, 1:32 PM

#

@muted hemlock You around?

#

I need some CODEC advice 😄

#

I have an object like this:

#

{
  ...,
  "forge": {
    "versions": {
      "client_resources": 16
      "server_data": 12
    }
  },
  ...

#

I have the codec for the inner versions

#

But how do I deal with the "forge" outer section

#

Without making a secondary object?

muted hemlock Sep 8, 2023, 1:38 PM

#

Is the top-level object being read by a codec?

mental carbon Sep 8, 2023, 1:38 PM

#

Yeah the outer root object already has a codec

#

I am trying to patch it so that it can read additional data

#

But for now I only need the "versions" section

#

But I do not want to lock out that we need additional data in the future

#

So I wanted to put it in a nice "forge" subsection / group

kindred fractal Sep 8, 2023, 1:39 PM

#

You could make a trivial record

muted hemlock Sep 8, 2023, 1:39 PM

#

yeah a properly formed codec would have a codec for the "forge" section which has field codecs for its fields

#

^

mental carbon Sep 8, 2023, 1:40 PM

#

Okey hold on 😄

true pivot Sep 8, 2023, 1:40 PM

#

mental carbon Because the patches have to be intermediary

you port the patches as intermediary files?

mental carbon Sep 8, 2023, 1:41 PM

#

SRG mostly

#

Makes finding the right methods trivial with a search command

true pivot Sep 8, 2023, 1:41 PM

#

meant SRG whoops

tacit vale Sep 8, 2023, 1:41 PM

#

mental carbon So I wanted to put it in a nice "forge" subsection / group

are you making breaking changes to the pack.mcmeta spec? We kinda need that to be able to parse the layouts already in production

kindred fractal Sep 8, 2023, 1:41 PM

#

true pivot meant SRG whoops

Yes the rejects are SRG

tacit vale Sep 8, 2023, 1:41 PM

#

more importantly just everything is srg

true pivot Sep 8, 2023, 1:41 PM

#

wow

tacit vale Sep 8, 2023, 1:42 PM

#

A patch can successfully apply but have a srg name be red cuz the method the patch uses got deleted

mental carbon Sep 8, 2023, 1:42 PM

#

tacit vale are you making breaking changes to the pack.mcmeta spec? We kinda need that to b...

Kind of, I am still trying to determine what to do here, the entire serializer is gone

#

And the way it was implemented will really not work

tacit vale Sep 8, 2023, 1:42 PM

#

Being able to parse a pack.mcmeta from any mc version is kinda super important

mental carbon Sep 8, 2023, 1:42 PM

#

tacit vale Being able to parse a pack.mcmeta from any mc version is kinda super important

.......... It won't crash

#

It just won't have the version per packtype property

kindred fractal Sep 8, 2023, 1:43 PM

#

Pack version is just a warning if it's outdated, but what if it's entirely missing?

mental carbon Sep 8, 2023, 1:43 PM

#

tacit vale Being able to parse a pack.mcmeta from any mc version is kinda super important

The way it was previously implemented is just not future proof and not handleable with codecs

mental carbon Sep 8, 2023, 1:43 PM

#

kindred fractal Pack version is just a warning if it's outdated, but what if it's entirely missi...

The pack version can not be missing

#

We only added two fields

#

To differentiate between data and asset versions that the pack containeed

tacit vale Sep 8, 2023, 1:43 PM

#

mental carbon The way it was previously implemented is just not future proof and not handleabl...

How do you know? If you are asking for help with codecs...

#

Why do you think it is not possible to reimplement with codecs

muted hemlock Sep 8, 2023, 1:44 PM

#

public record ForgeData(Versions versions)
{
  public static final Codec<ForgeData> CODEC = Versions.CODEC.fieldOf("versions").forGetter(ForgeData::versions);


  public static record Versions(int clientResources, int serverResources)
  {
    public static final Codec<Versions> CODEC = RecordCodecBuilder.create(builder -> builder.group(
        Codec.INT.fieldOf("client_resources").forGetter(Versions::clientResources),
        Codec.INT.fieldOf("server_resources").forGetter(Versions::serverResources)
      ).apply(builder, Versions::new));
  }
}

mental carbon Sep 8, 2023, 1:44 PM

#

tacit vale How do you know? If you are asking for help with codecs...

Because I can read the code...... And know enough of codecs to know that.

I just did not know if there was a simple "subgroup" option, outside of the additional codec

#

The route via an additional codec is known

stray scroll Sep 8, 2023, 1:44 PM

#

shrimp! 👀 pls reply to the message I ponged the council for

muted hemlock Sep 8, 2023, 1:45 PM

#

also aren't we removing the requirement for mods to have a pack.mcmeta

stray scroll Sep 8, 2023, 1:45 PM

#

someone should write up an issue for that, so we don't forget

#

unless we have one already

kindred fractal Sep 8, 2023, 1:45 PM

#

Should really minimize changes ^^

tacit vale Sep 8, 2023, 1:46 PM

#

stray scroll all positive and no negative votes, so it's clear that the question on community...

What Orion said looks fine

stray scroll Sep 8, 2023, 1:47 PM

#

so that's a yes, I take it

#

Shrimp, Orion: should we wait for cpw's opinion on this? (disregarding Curle ATM because she's inactive) or go through with it since both of you have agreed to the proposed selection process

mental carbon Sep 8, 2023, 1:49 PM

#

We can continue from my part

#

That is the rule is it not?

#

2:x where x is guaranteed to be less

#

Means the council accepts?

stray scroll Sep 8, 2023, 1:50 PM

#

usually, you'd want everyone in a body which makes decisions to know a decision is going to be made

#

like, you'd want to have your say if the council makes a decision, and you possibly wouldn't like it if the others on the council pushed through something without you having the chance to say something

#

i'm leaning towards that, but since we know cpw has some issues preventing his timely participation (his back issues), I'd be okay if both of you are okay with cpw not being involved in this one because of those issues

mental carbon Sep 8, 2023, 1:53 PM

#

Given that we are on a bit of a time crunch 😄

stray scroll Sep 8, 2023, 1:53 PM

#

also, we should probably gently suggest cpw name someone in his place, since he's likely going to be inactive due to said back issues

mental carbon Sep 8, 2023, 1:53 PM

#

Okey PackMetadataSection is now patched

stray scroll Sep 8, 2023, 1:54 PM

#

i am but a humble functionary, and beholden to implement the council's decisions rather than substitute my judgement for the council's thinkies

stray scroll Sep 8, 2023, 1:55 PM

#

stray scroll Shrimp, Orion: should we wait for cpw's opinion on this? (disregarding Curle ATM...

(psst @tacit vale)

kindred fractal Sep 8, 2023, 2:13 PM

#

Don't get too bureaucratic

mental carbon Sep 8, 2023, 2:14 PM

#

Server complete

#

Stats started

stray scroll Sep 8, 2023, 2:14 PM

#

kindred fractal Don't get too bureaucratic

~~but but~~

kindred fractal Sep 8, 2023, 2:15 PM

#

I already don't like this

stray scroll Sep 8, 2023, 2:16 PM

#

there's needless bureaucracy, and there's bureaucracy for the sake of being fair thinkies (as in, the fairness of cpw having a say in what the council decides)

mental carbon Sep 8, 2023, 2:16 PM

#

@stray scroll I am likely going to give schurli access later today

#

I do not want to do this alone

#

And we need to get it done

#

Stats complete

#

Tags started

stray scroll Sep 8, 2023, 2:17 PM

#

fair enough, then
I'll make a message in #internal-private to inform Maintainers about this (and to have it as a record there, instead of just in this thread)

mental carbon Sep 8, 2023, 2:20 PM

#

Tags complete

#

Util Started

stray scroll Sep 8, 2023, 2:24 PM

#

stray scroll all positive and no negative votes, so it's clear that the question on community...

both questions have been agreed to

#

time to make myself a role test dummy

#

community porter role icon

lethal bane Sep 8, 2023, 2:33 PM

#

the Beer, right?

kindred fractal Sep 8, 2023, 2:43 PM

#

Does this need a discord role lol

stray scroll Sep 8, 2023, 2:53 PM

#

so we know who can actively do porting work without needing to look at the repository's permissions tab (which requires Admin permission on the repo)

kindred fractal Sep 8, 2023, 2:54 PM

#

Ok

tacit vale Sep 8, 2023, 2:59 PM

#

stray scroll Shrimp, Orion: should we wait for cpw's opinion on this? (disregarding Curle ATM...

meh

#

it's not that huge of a deal to me. We should be auditing everything everyone is doing anyways

mental carbon Sep 8, 2023, 3:14 PM

#

Util complete

#

Last package: world started

mental carbon Sep 8, 2023, 4:41 PM

#

@muted hemlock I have dispatch codecs working, but is there a way to define a fallback, in case no type property is present?

muted hemlock Sep 8, 2023, 4:41 PM

#

you could use an either codec

mental carbon Sep 8, 2023, 4:41 PM

#

Okey

#

That was what I thought

#

Just checking

muted hemlock Sep 8, 2023, 4:41 PM

#

use the dispatch codec as the first codec, so it tries to read the "type" first

mental carbon Sep 8, 2023, 4:41 PM

#

Yeah

#

For the new recipe system I need to rewrite the ingredient and recipe serializer stuff

#

Because that all works in json objects

#

And is now all codecs

#

But for now I just added a comment

muted hemlock Sep 8, 2023, 4:42 PM

#

expanded holdersets use a type-dispatch and an either too, analogously

mental carbon Sep 8, 2023, 4:42 PM

#

Yeah

#

I knew I seen it somewhere

#

Could just not remember where

#

And the whole result parsing is broken......

#

Creat

mental carbon Sep 8, 2023, 5:01 PM

#

Okey down to just world/level

mental carbon Sep 8, 2023, 6:10 PM

#

Okey LootDataType patches are completely reverted......

#

I am not even sure what I am looking at even

#

Last patch reject: Level

mental carbon Sep 8, 2023, 7:11 PM

#

All patches fix

#

100+ compile errors to go

dull bison Sep 8, 2023, 9:34 PM

#

mental carbon <@607058472709652501> I am likely going to give schurli access later today

did you get the 2 approvals?

tacit vale Sep 8, 2023, 10:45 PM

#

I would tentatively approve but with the condition that everything is reviewed well

fallow sundial Sep 8, 2023, 10:45 PM

#

I approve too

#

that makes two

#

so gg?

tacit vale Sep 8, 2023, 10:46 PM

#

Lol

wise forge Sep 8, 2023, 10:48 PM

#

I'm okay approving schurli as well, though let's get a vote going properly

fallow sundial Sep 8, 2023, 10:48 PM

#

well your approval did mark an actual success funnily enough

#

this doesn't really need a whole vote since it only requires 2 approvals

wise forge Sep 8, 2023, 10:49 PM

#

¯_(ツ)_/¯

#

I don't know the governance rules in its entirety

fallow sundial Sep 8, 2023, 10:50 PM

#

look, yall approved this 2 approval system yesterday

#

I'm just the messager

wise forge Sep 8, 2023, 10:51 PM

#

I did? I guess I did

#

~~what did I even do yesterday~~

tacit vale Sep 8, 2023, 10:52 PM

#

Did you give access maty

fallow sundial Sep 8, 2023, 10:52 PM

#

no I'm working on it

tacit vale Sep 8, 2023, 10:52 PM

#

I'm gonna beat u

fallow sundial Sep 8, 2023, 10:52 PM

#

github on mobile is a fuck

tacit vale Sep 8, 2023, 10:53 PM

#

jk u got it surely

fallow sundial Sep 8, 2023, 10:53 PM

#

I need to make a team for it too

#

this isn't that simple stab

#

hmm if I make it under the neo team it's probably going to give push access to neoforge as well

#

or is it hmmm

#

child teams are fun

#

yes it will, ig it goes under maintainers then

#

@dull bison welcome to the fun club

#

check your email

#

side note, I hate github management on mobile

#

one of the worst experiences possible, sometimes I wonder how they manage to make mobile so bad

#

a very important rule you should remember is to commit often. you can batch commits and push once you're done with something as a whole, but for the purposes of reviewing pls commit often

#

also don't leave stuff locally not pushed overnight

#

you might screw yourself or others the next day

jagged agate Sep 8, 2023, 11:03 PM

#

fallow sundial a very important rule you should remember is to commit often. you can batch comm...

so squash all commits into a monster one for every PR? got it!

fallow sundial Sep 8, 2023, 11:05 PM

#

stab

fallow sundial Sep 9, 2023, 8:25 AM

#

@tacit vale i assume you won't have time to implement the registry rework in 1.20.2

dull bison Sep 9, 2023, 8:26 AM

#

isn't that 99% done already?

stray scroll Sep 9, 2023, 8:35 AM

#

eyyyy, a porter!

dull bison Sep 9, 2023, 8:36 AM

#

yessir

mental carbon Sep 9, 2023, 8:37 AM

#

222 Compile errors remaining

#

127 Compile errors remaining, thanks @dull bison 😄

#

wtf happened to tagfile.....

dull bison Sep 9, 2023, 8:41 AM

#

huh I just found that the patch for ItemTagsProvider was not using the modid and EFH parameters for the other constructor

mental carbon Sep 9, 2023, 8:41 AM

#

I fixed that

#

At least I fixed the class

#

Maybe the callers are still wrong

#

But I patched that through properly 😄

quiet talon Sep 9, 2023, 8:42 AM

#

fallow sundial <@277525077669445632> i assume you won't have time to implement the registry rew...

I was under the impression it was mostly complete, but it will need a bit of rebasing after defholder is merged

mental carbon Sep 9, 2023, 8:44 AM

#

ResourceKey + TagFile are done

mental carbon Sep 9, 2023, 8:45 AM

#

dull bison huh I just found that the patch for ItemTagsProvider was not using the modid and...

What are you currently looking at?

dull bison Sep 9, 2023, 8:45 AM

#

I'm currently pulling and rebuilding to see what's left

mental carbon Sep 9, 2023, 8:47 AM

#

MoveControl done

dull bison Sep 9, 2023, 8:48 AM

#

which ones of these are you doing?

mental carbon Sep 9, 2023, 8:48 AM

#

ArmorStand done

#

You can start at the bottom

#

If you want

#

Given that I have enabled like all of the errors to be shown

#

Just keep me up to date as to which file you are

#

So that we meet in the middle

dull bison Sep 9, 2023, 8:50 AM

#

can a patch replace a lambda with a method reference?

mental carbon Sep 9, 2023, 8:50 AM

#

Sure

#

A patch can do anything

#

Also: for now, don't worry about imports

#

Simply import

#

And also don't worry about empty lines

#

If it makes the patch more readable and gives the patcher more information as to its surrounding then I am okey with that for now

dull bison Sep 9, 2023, 8:52 AM

#

PortalShape done

#

are you doing MobCategory?

mental carbon Sep 9, 2023, 8:57 AM

#

I would say start at the bottom

#

Given that they are in alphabetical order

#

Actually nvm

#

They are not

#

Just call out on which file you are working XD

#

And that is then that

#

FishingHook in Progresse

dull bison Sep 9, 2023, 8:57 AM

#

NaturalSpawner in progress

mental carbon Sep 9, 2023, 8:58 AM

#

FishingHook Done

#

Push after every file you update

stray scroll Sep 9, 2023, 8:58 AM

#

still fixing compile errors?

mental carbon Sep 9, 2023, 8:58 AM

#

Yes

#

We had 400 initially on the first pass

#

We are down to like 100 something

stray scroll Sep 9, 2023, 8:59 AM

#

neat

mental carbon Sep 9, 2023, 8:59 AM

#

The current major cause of compile errors is VineFlower

#

And its formatting

#

Our patches and patcher don't expect it

#

Boat in Progress

stray scroll Sep 9, 2023, 9:00 AM

#

ah yes, because VF iirc uses a sensible formatting that isn't the cursed 3 spaces

#

and also linewrapping I believe

mental carbon Sep 9, 2023, 9:00 AM

#

It is the cursed 3 space.....

#

But yeah line wrapping

#

And most noteably its better handling of lambdas

#

Which are causing massive issues

#

Boat done

#

ItemEntity in progress

stray scroll Sep 9, 2023, 9:01 AM

#

huh. perhaps the spacing is configurable

#

probably should poke coeh to look into that thinkies

mental carbon Sep 9, 2023, 9:01 AM

#

ItemEntity Done

#

That and we are making the patches much bigger

#

Giving the patcher much more to work with

#

So that the fuzzy patch does not fail so easily

stray scroll Sep 9, 2023, 9:02 AM

#

sounds fine to me

mental carbon Sep 9, 2023, 9:02 AM

#

Yep

#

For now I am adding imports where needed

#

And cleaning up the context of the patch so that the inlines much better

#

Instead of stupid one line patches cramming a single if-switch into a place

#

And the patcher then going: Well this looks kind like it, and putting the if switch in the middle of a method header that is now on multiple lines

#

Mob In Progress

#

@dull bison Are you doing MobCategory?

#

I have a tangent patch in Mob that needs it to be fixed

dull bison Sep 9, 2023, 9:04 AM

#

no I am starting on LightEngine

mental carbon Sep 9, 2023, 9:04 AM

#

Okey

#

MobCategory in Progress

#

Mob, MobCategory Done

#

@dull bison Remember to push 😄

#

EnderMan Started

dull bison Sep 9, 2023, 9:08 AM

#

LevelSettings started

mental carbon Sep 9, 2023, 9:10 AM

#

EnderMan Complete

#

BrewingStandMenu Started

#

BrewingStandMenu Completed.

#

ArmorItem Started

#

ArmorItem Completed

#

BlockItem Started

dull bison Sep 9, 2023, 9:13 AM

#

RedStoneWireBlock started

mental carbon Sep 9, 2023, 9:13 AM

#

BlockItem Completed

#

MinecartItem Started

#

MinecartItem Completed

#

41 Errors remaining 😄

#

FrostWalkerEnchantment started

#

FrostWalkerEnchantment completed

#

RecipeManager Started

#

@dull bison You still on the redstonewireblock?

#

EnchantmentTableBlock started

#

EnchantmentTableBlock completed

tranquil salmon Sep 9, 2023, 9:23 AM

#

stray scroll probably should poke coeh to look into that <:thinkies:932605814995292192>

Wouldn't that break basically every patch?

dull bison Sep 9, 2023, 9:23 AM

#

mental carbon <@213343613583622144> You still on the redstonewireblock?

no started on PistonStructureResolver

#

done

mental carbon Sep 9, 2023, 9:24 AM

#

So flowerblock is the last one?

#

I will take that one then

tranquil salmon Sep 9, 2023, 9:26 AM

#

I can see a lot more than FlowerBlock

mental carbon Sep 9, 2023, 9:26 AM

#

At the moment they are not listed yet on IDEA

dull bison Sep 9, 2023, 9:27 AM

#

idea shows them in batches so if one batch is completed it shows the next

mental carbon Sep 9, 2023, 9:27 AM

#

FlowerBlock completed

kindred fractal Sep 9, 2023, 9:28 AM

#

mental carbon At the moment they are not listed yet on IDEA

Enable project wide scan, if you haven't yet

mental carbon Sep 9, 2023, 9:28 AM

#

I have that enabled

#

There we go

#

Back up to 249 😄

#

Okey

#

I need to go grocery shopping 😄

tranquil salmon Sep 9, 2023, 9:30 AM

#

For the whole project eclipse reports 346 errors

kindred fractal Sep 9, 2023, 9:30 AM

#

fallow sundial <@277525077669445632> i assume you won't have time to implement the registry rew...

Can we do that via normal PR?

#

During the BC period

stray scroll Sep 9, 2023, 9:30 AM

#

tranquil salmon Wouldn't that break basically every patch?

~~i believe in the fuzzy patcher~~

tranquil salmon Sep 9, 2023, 9:31 AM

#

stray scroll ~~i believe in the fuzzy patcher~~

~~replace all " " with " "~~

kindred fractal Sep 9, 2023, 9:31 AM

#

Imo we should have a longer BC period than usual to land a few important changes

#

(registries, caps, events)

inland mesa Sep 9, 2023, 9:33 AM

#

is 1.20.2 the best time to have all those massive changes?

dull bison Sep 9, 2023, 9:34 AM

#

inland mesa is 1.20.2 the best time to have all those massive changes?

since there are breaking changes in MC anyway yes

kindred fractal Sep 9, 2023, 9:34 AM

#

Assuming most mods stay on 1.20.1 it is the best time yes

inland mesa Sep 9, 2023, 9:34 AM

#

or let me rephrase: considering that people already complain about mojang doing breaking changes during minor version bumps, do we want to make that worse ourselves?

kindred fractal Sep 9, 2023, 9:35 AM

#

IMO we should encourage stability of 1.20.1 over .2

inland mesa Sep 9, 2023, 9:35 AM

#

dull bison since there are breaking changes in MC anyway yes

how breaking are those changes? I didn't fully keep track of the internals, did things change that much that it will already affect mod developers in major breaking ways?

quiet talon Sep 9, 2023, 9:36 AM

#

very breaking

inland mesa Sep 9, 2023, 9:36 AM

#

kindred fractal IMO we should encourage stability of 1.20.1 over .2

well, I always port and maintain for the latest version, and I always like to see development move to the latest version. I disagree with anyone saying "just stay in <version>" as a matter of principle.

quiet talon Sep 9, 2023, 9:36 AM

#

Mojang's new "minor versions" are fake snapshots

#

they should really be treated accordingly

dull bison Sep 9, 2023, 9:37 AM

#

inland mesa how breaking are those changes? I didn't fully keep track of the internals, did ...

networking so very

inland mesa Sep 9, 2023, 9:39 AM

#

quiet talon they should really be treated accordingly

Eh, sorry but no, I can't agree. Are they preview versions? sure, but I wouldn't call them snapshots. They have gone through the development cycle and have had their "QA" phase.

#

I do not agree with any "this is an unfinished version so it's not worth porting to it or playing on it" sentiment

#

I didn't in 1.17.x, and I don't now.

#

if people have limited time and choose not to port, that's fine, it's their choice to make

quiet talon Sep 9, 2023, 9:41 AM

#

unless I'm mistaken the decision to give stability to 1.20.1 and bc window until 1.21 was already made

kindred fractal Sep 9, 2023, 9:41 AM

#

giga I'm sorry but modpacks disagree with you

inland mesa Sep 9, 2023, 9:41 AM

#

I don't care what modpacks do

quiet talon Sep 9, 2023, 9:41 AM

#

then you don't need stability, lol

inland mesa Sep 9, 2023, 9:41 AM

#

what I'm asking is: is this the right time to do additional breaking changes?

quiet talon Sep 9, 2023, 9:41 AM

#

modpacks need stability, the ecosystem needs stability, and it cannot come on a preview version

kindred fractal Sep 9, 2023, 9:41 AM

#

quiet talon unless I'm mistaken the decision to give stability to 1.20.1 and bc window until...

Imo full bc window is excessive

#

I propose a bc window for a few weeks after each "minor" release

inland mesa Sep 9, 2023, 9:42 AM

#

sighs

#

let me try to rephrase

kindred fractal Sep 9, 2023, 9:42 AM

#

To ensure a minimal level of stability

inland mesa Sep 9, 2023, 9:43 AM

#

1.19.3 was a huge fucking breaking change, might as well have been called 1.20.-2 because it was definitely no longer 1.19 so far as the code went.
is 1.20.2 a similarly large breaking change such that attempting to make porting easier for people would be a pointless waste of time?

quiet talon Sep 9, 2023, 9:43 AM

#

yes

inland mesa Sep 9, 2023, 9:43 AM

#

that's my real question

quiet talon Sep 9, 2023, 9:44 AM

#

that's how all of these "preview" versions are

jagged agate Sep 9, 2023, 9:44 AM

#

How many 1.20.1 mods would break in 1.20.2 if Neo didn’t do breaking changes. Like how breaking is vanilla itself

quiet talon Sep 9, 2023, 9:44 AM

#

moreso the first than the last, but still
(in that the first preview version of a cycle seems to come with the most changes)

inland mesa Sep 9, 2023, 9:44 AM

#

well the changelogs don't look that big. they don't have huge preview features hidden behind feature flags and so on

#

it doesn't feel, at a glance, like another 1.19.3

#

but I haven't looked at the code diffs

#

hence the question

jagged agate Sep 9, 2023, 9:45 AM

#

Doesn’t the codec recipe mean all mods with custom recipes breaks?

quiet talon Sep 9, 2023, 9:45 AM

#

yep

#

all mods with networking will likely break as well

inland mesa Sep 9, 2023, 9:45 AM

#

how did they change networking?

#

I knew of the configuration phase

#

but I don't know what else they have done

jagged agate Sep 9, 2023, 9:46 AM

#

Then it is likely that modpacks are going to lock onto 1.20.1 and not update

pine ember Sep 9, 2023, 9:46 AM

#

We managed to keep our networking apis intact, for mods I don't think networking is that big of a deal.

inland mesa Sep 9, 2023, 9:46 AM

#

the configuration phase didn't feel like it was a huge breaking change for mods

quiet talon Sep 9, 2023, 9:46 AM

#

jagged agate Then it is likely that modpacks are going to lock onto 1.20.1 and not update

its more than likely, its already been declared, lol

jagged agate Sep 9, 2023, 9:46 AM

#

Which packmakers said they will not update?

inland mesa Sep 9, 2023, 9:46 AM

#

oh it was assumed

#

given the new update schedule

#

it is to be expected for modpacks to stick to 1.<update>.<hotfix>

#

and not update to 1.<update>.<preview>

#

I don't see a point for them to make packs on 1.20.2+

#

but in the past there have been minor updates that are sorta not that minor but not hugely breaking

#

like 1.19.1/2 which changed chat and a few things more

jagged agate Sep 9, 2023, 9:49 AM

#

1.19.2 was breaking for all mods with structures lol (it was that or 1.19 that redid structures)

inland mesa Sep 9, 2023, 9:49 AM

#

maybe but it was still reasonable to shift packs to 1.19.2

#

unlike 1.19.3 or .4

#

so yeah

#

my question was, is 1.20.2 more like1.19.3/.4, or more like 1.19.1/.2

#

if it's a big break under the hood then yeah whatever breaking change away

#

I just really wouldn't want this feeling of "all updates are snapshots now, stability is gone" to eliminate the possibility of smoothing out the bump and making minor versions an option like it has been done in the past

#

I'm going to port regardless, and I'll continue maintaining 1.20.1 and 1.19.2.
if 1.20.2 was actually not that bad and it was mostly compatible and only broke some mods, then I might instead shift my efforts to 1.19.2+1.20.2

quiet talon Sep 9, 2023, 9:54 AM

#

Well we know for certain it will immediately break any mod with custom recipes

#

due to the codec change

#

networking might break if we can't re-implement our api as-is (someone would need to check with orion on that, it may have already been done)

inland mesa Sep 9, 2023, 9:56 AM

#

yeah the custom recipe thing might affect ... 2 of my mods

#

maybe 3

kindred fractal Sep 9, 2023, 10:03 AM

#

I think the changes are quite small for many mods but nonzero

mental carbon Sep 9, 2023, 10:06 AM

#

Chunk Watch and Unwatch are dead for the moment

dull bison Sep 9, 2023, 10:14 AM

#

Force push was just fixing a wrong commit message

mossy bobcat Sep 9, 2023, 10:43 AM

#

inland mesa is 1.20.2 the best time to have all those massive changes?

Yes, because it's when many modders are planning to drop forge support in favor of neoforged with that version. I, for one, would rather do all my big changes all at once

dull bison Sep 9, 2023, 10:45 AM

#

I believe 1.20.1 will be the big divergence between forge and neo so yea

mossy bobcat Sep 9, 2023, 10:45 AM

#

That was basically my thoughts. If you're going to be diverging from forge in 1.20.2 - best, imo, to get all the big divergences in at once so people only have one version of "shit everything changed"

inland mesa Sep 9, 2023, 10:58 AM

#

yes but also kills the entire purpose of saying "this is still forge just without lex"

#

it becomes a different loader

#

which I'm not against, mind you

#

I did suggest early on that NeoForge should be a temporary name only to help people find it, but that once the team has figured out what the long term goals should be, the name should be changed to reflect that

mossy bobcat Sep 9, 2023, 11:02 AM

#

inland mesa yes but also kills the entire purpose of saying "this is still forge just withou...

I mean I'd argue that, as communicated to modders, that has always been the case - folks made a point early on of saying that the "forge minus Lex" bit was just as important as the new technical changes that could be made with a different attitude to development and all of that stuff

#

It's not fundamentally changing what the goals of (neo)forge are; it's just implementing them better

#

The registry changes and capability changes are a great example of that

#

These are larger breaking changes that should have already happened

jagged agate Sep 9, 2023, 11:08 AM

#

Is there even enough time before 1.20.2 to get in the giant breaking changes anyway or is this about rolling it out while in 1.20.2 lifetime

fallow sundial Sep 9, 2023, 11:10 AM

#

the changes are likely to be done with PRs

#

it's also likely we're going to go runtime mojmaps become if we don't it's going to be a horrible time with forge incompatibilities

inland mesa Sep 9, 2023, 11:12 AM

#

this may be too late to say at this point but IMO, these kinds of big redesigns should have been already made and be waiting in their rfc type PRs

#

anything that isn't "feature-complete" and just waiting to be ported to the target version, probably shouldn't be considered for that version

fallow sundial Sep 9, 2023, 11:13 AM

#

well that happened depending on which changes you're talking about

inland mesa Sep 9, 2023, 11:14 AM

#

yeah I mean in terms of

fallow sundial Sep 9, 2023, 11:14 AM

#

registry rework has been sitting on shrimp's fork with some of the changes in shadows' PR

inland mesa Sep 9, 2023, 11:14 AM

#

anything that is currently not yet a RFC PR and has gone through preliminary community review and opinion

#

should have 2-3 weeks to get to that stage (however long mojang takes to release 1.20.2) and a couple weeks on top of that to finish porting

#

and I'd consider anything beyond that "too late" for anything that wasn't a surprise breaking change from mojang's side

#

(IMO this is why it would be good to have builds for pre-releases published -- specifically to be able to port upcoming changes ahead of time)

mossy bobcat Sep 9, 2023, 11:21 AM

#

I'd say the biggest candidates for 1.20.2 major changes are the capability stuff and the registry stuff - both of which are at or pretty close to that state

#

Maybe TelepathicGrunt's new tag stuff, depending? Not sure, but this would be the easiest time to get that in and accepted for certain

jagged agate Sep 9, 2023, 11:24 AM

#

no, tag is 1.21

#

you aint going to cut through the bikeshed enough for that and it has to sync with fabric as well

fallow sundial Sep 9, 2023, 11:25 AM

#

tags are going to be such a lot of drama

#

can't wait for it

#

speaking of mappings tho, need to make a list of what changes we need to make to go runtime mojmaps

mossy bobcat Sep 9, 2023, 11:31 AM

#

Fair point. But yeah, the big changes imo that should be pushed for 1.20.2 are registry stuff, runtime Mojmaps, and maybe capability changes, as they're the ones likely to affect people the most, they've had a good bit of work done, and they have huge benefits for getting in sooner rather than later

#

...also runtime Mojmaps will make life generally 200x more pleasant for groovy modders, but that's just a benefit for me and a few others specifically, so I might be biased

inland mesa Sep 9, 2023, 11:42 AM

#

runtime mojmap would mean I can finally have full scripting support in Json Things lol

#

cos I can't be arsed to embed translation mappings in the mod

rich void Sep 9, 2023, 11:43 AM

#

jagged agate you aint going to cut through the bikeshed enough for that and it has to sync wi...

sorry to jump in unannounced, but what is a bikeshed?

mossy bobcat Sep 9, 2023, 11:43 AM

#

inland mesa cos I can't be arsed to embed translation mappings in the mod

We just download them at runtime from Mojang for groovy modding

inland mesa Sep 9, 2023, 11:43 AM

#

nono it's not the data

#

it's implementing the translation system into the javascript engine :P

mossy bobcat Sep 9, 2023, 11:43 AM

#

...we do that to groovy too

inland mesa Sep 9, 2023, 11:44 AM

#

yeah I don't have the time/energy/motivation to write that code :p

mossy bobcat Sep 9, 2023, 11:44 AM

#

By embedding the remapping data into custom metaclasses for every mojang class that gets referenced by groovy stuff

jagged agate Sep 9, 2023, 11:44 AM

#

rich void sorry to jump in unannounced, but what is a bikeshed?

why care about a $324376746437643 nuclear project when we can argue about the roof color of this shed for bikes

inland mesa Sep 9, 2023, 11:45 AM

#

so bikeshedding

#

the story is like this

#

some people were discussing a brand new factory

#

they had very long meetings arguing about the layout and the requirements for optimizing the manufacturing and such

#

eventually, the discussion shifted to less complicated things

#

and they became focused not on making their building

#

but rather arguing about the color of the bikeshed

stray scroll Sep 9, 2023, 12:09 PM

#

it's becoming too focused on small details when there's bigger-picture stuff that still needs to be focused on

#

i'd like to note that becoming focused on small details isn't a bad thing -- for example, in parliamentary bodies, bills go through a literal clause-by-clause debate in a smaller committee, or in companies where VPs delegate to directors who delegate to managers on the finer details of the business
it's within the context of "there's literally bigger fish on the grill that you should be focusing on first" that makes bikeshedding bad

#

(it grinds my gears to see a discussion of the fine details of something being immediately called as bikeshedding)

inland mesa Sep 9, 2023, 12:27 PM

#

yeah

#

and it's sometimes hard to know if people don't care about those details and want to hurry the discussion along, or they actually don't like where the conversation is going and would rather people skipped that so that they don't end up going in a different direction than the one they personally like

stray scroll Sep 9, 2023, 3:49 PM

#

@mental carbon how are both of you running the repo at the moment? I can't seem to get it setup, on account of NG not resolving...?

mental carbon Sep 9, 2023, 3:49 PM

#

You need to publish my test branch for NG

stray scroll Sep 9, 2023, 3:50 PM

#

test branch?

#

you'll need to specify here

#

preferrably, in a single message to be pinned

mental carbon Sep 9, 2023, 3:51 PM

#

It is

stray scroll Sep 9, 2023, 3:51 PM

#

thonk what do you mean

mental carbon Sep 9, 2023, 3:52 PM

#

mental carbon If somebody wants to help you need the `features/neoform_defaulted` branch of NG...

#

Well it was

#

I repinnednit

stray scroll Sep 9, 2023, 3:53 PM

#

it was never pinned

#

I checked the audit log

mental carbon Sep 9, 2023, 3:56 PM

#

I could have sworn that I pinned it

#

Well what ever

#

There it is

#

Okey were are we currently

stray scroll Sep 9, 2023, 4:10 PM

#

i am stuck in setup hell

#

so have fun

mental carbon Sep 9, 2023, 4:10 PM

#

?

#

Push the new NG next version to your maven local

#

And import in IDEA
That is all you need

#

No setup

#

No nothing

stray scroll Sep 9, 2023, 4:11 PM

#

...oh right

mental carbon Sep 9, 2023, 4:11 PM

#

If you run setup now

#

You break the entire repo

stray scroll Sep 9, 2023, 4:11 PM

#

I'm too used to doing setup each time

#

nothing a good ol' restore can't fix

#

perhaps a clean

mental carbon Sep 9, 2023, 4:12 PM

#

git reset --hard will do

stray scroll Sep 9, 2023, 4:12 PM

#

git restore does the job as well

dull bison Sep 9, 2023, 4:12 PM

#

you need to also manually tag the ng version before you publish to maven local

mental carbon Sep 9, 2023, 4:12 PM

#

Right

#

Allthough I pushed the tag

#

I am not sure if that clones normally

stray scroll Sep 9, 2023, 4:13 PM

#

I just did my favorite technique of includeBuild in the pluginManagement block of the settings.gradle

#

sure, it means I have this perpetual change in the settings.gradle that I need to never commit

#

but it also means I don't have to push something to my maven local

#

and that's a win for me

mossy bobcat Sep 9, 2023, 4:44 PM

#

mental carbon I am not sure if that clones normally

Tags clone normally but they're sometimes weird if you have it checked out locally already

dull bison Sep 9, 2023, 4:46 PM

#

mossy bobcat Tags clone normally but they're sometimes weird if you have it checked out local...

they don't if you check out a fork (like I have for work on NGNext)

mossy bobcat Sep 9, 2023, 4:46 PM

#

thonk GH why...

#

oh unless the fork is missing some upstream tags, which can happen

#

As syncing a fork to upstream doesn't sync tags generally

dull bison Sep 9, 2023, 5:14 PM

#

just recompiled 155 errors remaining

mental carbon Sep 9, 2023, 5:26 PM

#

Nice

#

I am also back atm

#

Can you push so we can sync up?

mental carbon Sep 9, 2023, 5:36 PM

#

dull bison just recompiled 155 errors remaining

I am at 192, with project wide analysis

#

Were are you currently at with regards to what you are working on?

dull bison Sep 9, 2023, 5:37 PM

#

I'm doing User rn

tacit vale Sep 9, 2023, 5:42 PM

#

dull bison isn't that 99% done already?

Yes/no. It needs porting of course and also I needed to change how it works to still load and store ids for MobEffects for now for compatibility AND also store a list of resource locations for all registries so that we can show a popup on the client warning if entries are deleted

#

I'm thinking we could have three buttons: "Cancel", "Backup and Continue", "I'm Neo"

stray scroll Sep 9, 2023, 5:43 PM

#

~~from the Matrix?!~~

dull bison Sep 9, 2023, 5:43 PM

#

nah the 3rd should be "there is no spoon"

lethal bane Sep 9, 2023, 5:43 PM

#

follow the white rabbit

mental carbon Sep 9, 2023, 5:51 PM

#

tacit vale Yes/no. It needs porting of course and also I needed to change how it works to s...

The mobeffect stuff has been removed

#

It is now completly in codecs

tacit vale Sep 9, 2023, 5:51 PM

#

what?

mental carbon Sep 9, 2023, 5:52 PM

#

Yeah

#

The whole mobeffect additional saving that we were doing

#

On things like the mushroom cows

dull bison Sep 9, 2023, 5:52 PM

#

numeric ids are gone

mental carbon Sep 9, 2023, 5:52 PM

#

And the suspicous stew

#

That is all gone

#

They first of all can now have multiple effects (allthough the stew does not use it)

#

And second of all they use names now

#

Not ids

tacit vale Sep 9, 2023, 5:52 PM

#

Ok that helps me remember more: for mob effects, we still have to load the int ids from disk if they exist and patch the data fixer to use those ids

mental carbon Sep 9, 2023, 5:52 PM

#

And third are completely implemented in codecs

mental carbon Sep 9, 2023, 5:53 PM

#

tacit vale Ok that helps me remember more: for mob effects, we still have to load the int i...

There are no int ids

tacit vale Sep 9, 2023, 5:53 PM

#

you are not understanding me

mental carbon Sep 9, 2023, 5:53 PM

#

You mean the old ones?

tacit vale Sep 9, 2023, 5:53 PM

#

When a world is upgraded from 1.20.1

#

There are int ids

#

we must keep those and use them in the data fixer

mental carbon Sep 9, 2023, 5:53 PM

#

Ooooooeff

#

That is going to be majorly difficult

tacit vale Sep 9, 2023, 5:53 PM

#

have fun

dull bison Sep 9, 2023, 5:53 PM

#

stabolb

kindred fractal Sep 9, 2023, 5:54 PM

#

tacit vale we must keep those and use them in the data fixer

"must"?

tacit vale Sep 9, 2023, 5:54 PM

#

the alternative is fucking up all mob effects?

#

the int ids are afaik hardcoded in a map in the datafixer right now

mental carbon Sep 9, 2023, 5:55 PM

#

tacit vale the alternative is fucking up all mob effects?

As far as I can see vanilla wrote the same int as we did?!ß

#

So are they really broken then?

tacit vale Sep 9, 2023, 5:56 PM

#

what about modded effects

#

those don't even have ids in the datafixer

mental carbon Sep 9, 2023, 5:56 PM

#

I will check 😄

#

Given that the registries don't exist when this initializes

#

It is a mood point probably

fallow sundial Sep 9, 2023, 5:56 PM

#

no it's not as long as you can grab the forge dat file

mental carbon Sep 9, 2023, 5:57 PM

#

You can't 😄

#

But yes they are hardcoded......

#

So.....

#

How do we want to approach this?!?

fallow sundial Sep 9, 2023, 5:58 PM

#

well first check if serverlifecyclehooks#curentserver is null

mental carbon Sep 9, 2023, 5:58 PM

#

It is on world load.......

#

I think

#

Actually it does not matter

#

DFU optimizes the fix anyway

kindred fractal Sep 9, 2023, 5:59 PM

#

Is updating modded world generally supported?

mental carbon Sep 9, 2023, 5:59 PM

#

Yes

#

I tend to make my mods that you can do it

#

But this is a tricky one

fallow sundial Sep 9, 2023, 5:59 PM

#

mental carbon I think

that's why I said "check", assumptions are good but practice is better 😛

mental carbon Sep 9, 2023, 6:00 PM

#

We can't

#

Does not compile yet

tacit vale Sep 9, 2023, 6:01 PM

#

ok work on that first then

#

but it would be nice if all modded effects didn't just disappear if we can get that to work in the future 🤷‍♂️

mental carbon Sep 9, 2023, 6:01 PM

#

😛

mental carbon Sep 9, 2023, 6:51 PM

#

@dull bison You still on it?

dull bison Sep 9, 2023, 6:52 PM

#

my current state is pushed and I took a little break

mental carbon Sep 9, 2023, 6:52 PM

#

Good

#

😄

dull bison Sep 9, 2023, 6:59 PM

#

130 on compile 310 on analysis and only 2 in the patched mc source

mental carbon Sep 9, 2023, 7:34 PM

#

I took care of the custom ingredient stuff now

#

Wrote registry glue code

#

And a set of codecs

dull bison Sep 9, 2023, 7:39 PM

#

there is still a bunch of network stuff todo so I'll leave that part to you

mental carbon Sep 9, 2023, 9:34 PM

#

Okey got through most of the custom ingredients forge added

#

Refactored two completely already

#

And cleaned up nearly all jank that was in that system

#

ByeBye AbstractIngredient

kindred fractal Sep 9, 2023, 9:35 PM

#

Uh it was added for a reason

#

(Namely to make ingredients less error prone to use)

#

E.g. TagIngredient.of(xxx) calling the static vanilla Ingredient.of method

dull bison Sep 9, 2023, 9:44 PM

#

@mental carbon you didn't push stabolb

mental carbon Sep 9, 2023, 10:02 PM

#

kindred fractal E.g. TagIngredient.of(xxx) calling the static vanilla Ingredient.of method

I know they still exist in the relevant classe

mental carbon Sep 9, 2023, 10:03 PM

#

dull bison <@304594425286361088> you didn't push <:stabolb:837125030479134730>

I know

#

I feel a sleep at my desk

fallow sundial Sep 9, 2023, 10:03 PM

#

that is not healthy

tranquil salmon Sep 10, 2023, 12:15 AM

#

mental carbon I feel a sleep at my desk

Are you planning on pushing sometime soon?

tranquil salmon Sep 10, 2023, 1:04 AM

#

0 isn't a valid uuid anymore

tranquil salmon Sep 10, 2023, 1:44 AM

#

anyone want to tell me how line 99 calls getModelBlock()?

#

nevermind it's a coremod

tacit vale Sep 10, 2023, 2:03 AM

#

tranquil salmon `0` isn't a valid uuid anymore

again?

tranquil salmon Sep 10, 2023, 3:11 AM

#

I don't think the Minecraft Realms button should be that big (not all compile errors are fixed but eclipse allows running an application until it runs into a compile error)

#

@mental carbon You do know that the buffer method isn't overriding anything right?

mental carbon Sep 10, 2023, 3:46 AM

#

Yes

#

I am still working on that

#

See the other packets

tranquil salmon Sep 10, 2023, 5:35 AM

#

It would be nice if Orion pushed their changes before going to sleep

mental carbon Sep 10, 2023, 6:12 AM

#

I am so sorry man

#

My wife shut the PC doen

#

And I just stumbled into ved

dull bison Sep 10, 2023, 7:30 AM

#

fun we have to rework the datagen for conditional stuff

mental carbon Sep 10, 2023, 7:31 AM

#

I am around now

tranquil salmon Sep 10, 2023, 7:31 AM

#

Can you start by pushing?

dull bison Sep 10, 2023, 8:07 AM

#

fixed a bunch of tests 135 errors remaining

mental carbon Sep 10, 2023, 8:16 AM

#

Schurli you around?

#

Can you hop in voice?

#

I need some feedback

#

@dull bison ^

dull bison Sep 10, 2023, 8:17 AM

#

sure

fallow sundial Sep 10, 2023, 8:24 AM

#

mental carbon I need some feedback

first push stabolb

mental carbon Sep 10, 2023, 8:24 AM

#

Already done

#

Or no not yet

fallow sundial Sep 10, 2023, 8:25 AM

#

I see no push in #neoforge-private

mental carbon Sep 10, 2023, 8:25 AM

#

As i said not yet

#

I am debating something

#

Two seconds

#

It is not like you depend on the ingredient changes to do what ever the fuck the 135 errors need

fallow sundial Sep 10, 2023, 8:33 AM

#

I want to see the changes and give feedback smh

dull bison Sep 10, 2023, 8:40 AM

#

    public static <T> MapCodec<Set<T>> singularOrPluralCodec(Codec<T> codec, String singularName, String pluralName)
    {
        return Codec.mapEither(codec.fieldOf(singularName), setOf(codec).fieldOf(pluralName)).xmap(
                either -> either.map(ImmutableSet::of, ImmutableSet::copyOf),
                set -> set.size() == 1 ? Either.left(set.iterator().next()) : Either.right(set)
        );
    }

    public static <T> Codec<Set<T>> setOf(Codec<T> codec)
    {
        return Codec.list(codec).xmap(ImmutableSet::copyOf, ImmutableList::copyOf);
    }

#

@mental carbon ^

fallow sundial Sep 10, 2023, 8:53 AM

#

why do you have dynamic field names

mental carbon Sep 10, 2023, 8:55 AM

#

It is a util

fallow sundial Sep 10, 2023, 9:45 AM

#

if ingredients are a synced registry then you are making forge clients incompatible with vanilla servers and vice versa

mental carbon Sep 10, 2023, 9:48 AM

#

fallow sundial if ingredients are a synced registry then you are making forge clients incompati...

Fixed

fallow sundial Sep 10, 2023, 10:24 AM

#

well looking further into this there's a bigger issue, you're breaking all vanilla compatibility by writing to network buffers with the codec

mental carbon Sep 10, 2023, 10:25 AM

#

Well we need to, given that we have custom types......

fallow sundial Sep 10, 2023, 10:26 AM

#

vanilla wants a list of stacks, you're always giving it a list of objects

mental carbon Sep 10, 2023, 10:26 AM

#

Hmm, I can possibly code an exception for an Ingredient

fallow sundial Sep 10, 2023, 10:26 AM

#

emphasis on always

mental carbon Sep 10, 2023, 10:27 AM

#

Emphasis on getting it to work...

#

But it is a much better solution then we had, cause that did not compile at all...

#

I am fully aware that my solution is not perfe t

#

I mean for the network

#

We could send the itemstack list

fallow sundial Sep 10, 2023, 10:35 AM

#

I don't see the problem with letting the ingredient handle network i/o as before.. it's same as with recipes being codecs only for json de/serialization, codecs for network stuff aren't exactly efficient en masse

mental carbon Sep 10, 2023, 11:06 AM

#

fallow sundial I don't see the problem with letting the ingredient handle network i/o as before...

I made it use getItems() again

#

And that should solve it

fallow sundial Sep 10, 2023, 11:10 AM

#

but it doesn't really solve it, it makes the client not know about any custom ingredient, as a point of custom ingredients is custom testing.. I don't see the problem with continuing to do it like before with custom network serializers

mental carbon Sep 10, 2023, 11:11 AM

#

fallow sundial but it doesn't really solve it, it makes the client not know about any custom in...

Because it needs custom serialization logic, which we are exactly trying to prevent

#

The serialization logic is defined as the codec

#

The codec determines which items match

#

And that is literally all the client needs to know

#

Which items are valid for what slots

mental carbon Sep 10, 2023, 11:14 AM

#

fallow sundial but it doesn't really solve it, it makes the client not know about any custom in...

In other words: The client can never return a different result from getItems() then the server, as such the only thing that matters is that the client knows which items are valid.

The custom logic works perfectly fine, but it can only be executed on the server side

quiet talon Sep 10, 2023, 11:17 AM

#

the codec determines which items match

what thonk

mental carbon Sep 10, 2023, 11:17 AM

#

quiet talon > the codec determines which items match what <:thonk:932605815221788672>

In the end yes

#

The codec deserializes the ingredient from json

#

Yes the Ingredient can have different value implementations

#

But what ever it returns matters for the value.

quiet talon Sep 10, 2023, 11:19 AM

#

mental carbon In other words: The client can never return a different result from `getItems()`...

Not all ingredients return anything from getItems (dynamic ingredients) and are needed on the client for slot validation

mental carbon Sep 10, 2023, 11:19 AM

#

quiet talon Not all ingredients return anything from getItems (dynamic ingredients) and are ...

That is not possible anymore

#

The way it is implemented requires the server to have getItems() to work properly

#

And the server is leading

quiet talon Sep 10, 2023, 11:20 AM

#

That is insufficient for modded scenarios

mental carbon Sep 10, 2023, 11:20 AM

#

?

#

Which ones?

quiet talon Sep 10, 2023, 11:20 AM

#

Anything that cannot predetermine the items?

mental carbon Sep 10, 2023, 11:20 AM

#

AFAIK the concept of "dynamic" ingredients has been dead for ever

mental carbon Sep 10, 2023, 11:20 AM

#

quiet talon Anything that cannot predetermine the items?

Like what?

lean warren Sep 10, 2023, 11:20 AM

#

NBT ingredients have an infinite list of possible items and have worked previously

quiet talon Sep 10, 2023, 11:20 AM

#

^

mental carbon Sep 10, 2023, 11:20 AM

#

lean warren NBT ingredients have an infinite list of possible items and have worked previous...

All NBT Ingredients provided by Forge still work

#

Custom serialization logic breaks vanilla

#

So .......

lean warren Sep 10, 2023, 11:22 AM

#

mental carbon All NBT Ingredients provided by Forge still work

They can't be working when they are tested on the client, which breaks anything using a selected recipe's ingredient for inventory slot validation (which is not an unusual use case)

quiet talon Sep 10, 2023, 11:22 AM

#

It would probably break in the recipe book as well

mental carbon Sep 10, 2023, 11:22 AM

#

lean warren They can't be working when they are tested on the client, which breaks anything ...

Example please., cause from the code that existed before, this would not work now either

quiet talon Sep 10, 2023, 11:23 AM

#

Since it does client tests

quiet talon Sep 10, 2023, 11:23 AM

#

mental carbon Example please., cause from the code that existed before, this would not work no...

why not? The full ingredient was sent over in the 20.1- code

#

It has full operation on the client

mental carbon Sep 10, 2023, 11:24 AM

#

quiet talon why not? The full ingredient was sent over in the 20.1- code

Okey I can make that work

#

I figured it out

#

It hacks the reading of the count and anything negative is considered a custom value.....

lean warren Sep 10, 2023, 11:25 AM

#

mental carbon Example please., cause from the code that existed before, this would not work no...

I don't have a specific example with custom ingredients as my own crafting system specifically doesn't support them at the moment

mental carbon Sep 10, 2023, 11:25 AM

#

Actually

#

The existing code breaks vanilla!

#

So yeah, this never worked and crashed all vanilla clients that tried to connect as soon as a custom ingredient is used

#

Because it sends a -1 for the list size

#

Which immediatly crashes the client when it tries to parse its itemstack list

#

in the ingredient

#

So no

quiet talon Sep 10, 2023, 11:28 AM

#

Well, yes, custom ingredients cannot be used with vanilla

mental carbon Sep 10, 2023, 11:28 AM

#

Okey

#

So we are in a stalemate

#

Cause the new system allows us to use them in vanilla

#

But the server needs to know what the value is at a given time

quiet talon Sep 10, 2023, 11:29 AM

#

so it allows some of them to be used

#

But that must not mandate that all of them are vanilla compatible

mental carbon Sep 10, 2023, 11:29 AM

#

It always allows all of those that do not need to execute any custom logic on the client

fallow sundial Sep 10, 2023, 11:29 AM

#

mental carbon Cause the new system allows us to use them in vanilla

it always did? ingredients were always sent as a list of stacks.. but the decision to not allow custom ingredients with vanilla was made because it's detrimental to modded environments

lean warren Sep 10, 2023, 11:34 AM

#

mental carbon It always allows all of those that do not need to execute any custom logic on th...

If you don't need custom logic, then you don't need a custom ingredient but merely a custom IIngredientSerializer that spits out a vanilla ingredient. In other words, truly custom ingredients don't work

mental carbon Sep 10, 2023, 11:35 AM

#

I added it back in

#

It is via the CODEC now

#

but the logic now works exactly the same as it did before

#

It will write -1, then the CODEC

#

If it is not a vanilla ingredient type

#

If it is a vanilla type

#

The old logic is used with the itemstack list

#

So no custom serializer

#

But sill client side execution logic

quiet talon Sep 10, 2023, 11:39 AM

#

That sounds fine, I'll look over it tomorrow

fallow sundial Sep 10, 2023, 11:40 AM

#

I love how the conditions stuff is basically shadows pr to which lex said no

mental carbon Sep 10, 2023, 11:41 AM

#

I ripped all lex stuff out

fallow sundial Sep 10, 2023, 11:42 AM

#

https://github.com/MinecraftForge/MinecraftForge/pull/9185

GitHub

[1.20] Refactor and document ICondition by Shadows-of-Fire · Pull R...

This PR moves conditions out of the crafting package, updates the javadocs on ICondition, and moves related helper code out of CraftingHelper to ConditionHelper.
There are also a couple rider refac...

mental carbon Sep 10, 2023, 11:42 AM

#

Well yeah

#

I even started on the conditions

#

They will all become codecs

#

This whole subsystem is codec driven now

#

And to be honest

#

I don't want to see and new custom serialization logic in forge

#

This is 100 times nicer

quiet talon Sep 10, 2023, 11:44 AM

#

codec v good

#

bit shitty with networking but eh such is tradeoffs

fallow sundial Sep 10, 2023, 11:46 AM

#

I mean.. If you know the order of the components of a RCB you can optimise the serialized version for networking

#

by using a list with explcitit null values

quiet talon Sep 10, 2023, 11:47 AM

#

In theory, yes, but it would probably require it be implemented in dfu

fallow sundial Sep 10, 2023, 11:47 AM

#

not with enough reflection

#

hahayes

kindred fractal Sep 10, 2023, 11:47 AM

#

At Fabric we sync the stack list to clients that don't support the ingredient

#

And we sync the ingredient using the ingredient serializer if the client supports it

dull bison Sep 10, 2023, 11:48 AM

#

fallow sundial not with enough reflection

are you volunteering to do it?

kindred fractal Sep 10, 2023, 11:48 AM

#

This means that AND/OR ingredients also work for vanilla clients

fallow sundial Sep 10, 2023, 11:48 AM

#

I'm not making any more commitments

dull bison Sep 10, 2023, 11:52 AM

#

the rest of the errors can mostly be grouped in 3 groups

Condition
Networking
GUI

dull bison Sep 10, 2023, 12:46 PM

#

@tranquil salmon the renderBackground method you used is not the correct replacement it is renderTransparentBackground

mental carbon Sep 10, 2023, 12:49 PM

#

kindred fractal At Fabric we sync the stack list to clients that don't support the ingredient

Yep I just added that

fallow sundial Sep 10, 2023, 1:17 PM

#

@mental carbon I assume you meant to name that record component nonEmptyCodec https://github.com/neoforged/Kits/commit/c5ee87483112551b1ec65457ae63976e4e7f4bfc#diff-54ad89a74b631ada43dda397575afc1b22bd2313f2ba2b1b0b3f1534330d4383R11

mental carbon Sep 10, 2023, 1:17 PM

#

Yeah

dull bison Sep 10, 2023, 1:23 PM

#

dull bison <@239615312352247809> the renderBackground method you used is not the correct re...

nvm it is called inderect by the method you used

winged hull Sep 10, 2023, 4:01 PM

#

mental carbon My wife shut the PC doen

rare footage of a programmer having a life

dull bison Sep 10, 2023, 4:12 PM

#

winged hull rare footage of a programmer having a life

no his wife did it after he fell asleep at the computer

inland mesa Sep 10, 2023, 4:25 PM

#

I think they are talking about having a wife, and implying that programmers don't normally have wives

rich void Sep 10, 2023, 4:40 PM

#

inland mesa I think they are talking about having a wife, and implying that programmers don'...

very good news for gay programmers :)

mental carbon Sep 10, 2023, 4:40 PM

#

😄

#

Okey we just made a huge push towards Codec based recipes

#

All conditional logic (both reading and writing) is now codec based

#

We refactored the JsonCodecProvider to be more sane, and side effect free (for the most part)

#

ConditionalAdvancement is gone

dull bison Sep 10, 2023, 4:44 PM

#

rich void very good news for gay programmers :)

not if they are female

rich void Sep 10, 2023, 4:44 PM

#

dull bison not if they are female

frick, forgot about those people

#

also, are these changes just improvement or needed for porting?

fallow sundial Sep 10, 2023, 4:45 PM

#

reminder to make recipeoutput#provider defaulted

rich void Sep 10, 2023, 4:47 PM

#

rich void also, are these changes just improvement or needed for porting?

(I mean the changes Orion and others are making)

dull bison Sep 10, 2023, 4:47 PM

#

rich void also, are these changes just improvement or needed for porting?

both

#

the decision was improve or remove

rich void Sep 10, 2023, 4:50 PM

#

nice!

fallow sundial Sep 10, 2023, 4:53 PM

#

fallow sundial reminder to make recipeoutput#provider defaulted

(the advancement method too)

#

also is it too late to point out how not caring about imports in patches is a mistake because they're going to make 1.20.3 porting worse

quiet talon Sep 10, 2023, 5:00 PM

#

mental carbon All conditional logic (both reading and writing) is now codec based

Should we do the rest of the refactors from my old codec condition pr (or did you do that already)

mossy bobcat Sep 10, 2023, 5:01 PM

#

fallow sundial also is it too late to point out how not caring about imports in patches is a mi...

I feel like some sort of automated tool to inline imports in patches shouldn't be that hard. Hmm

fallow sundial Sep 10, 2023, 5:02 PM

#

that's not the bad part, the bad part is that patches now contain wildcard reordered imports

#

maybe some more thought should have been put into that decision

mossy bobcat Sep 10, 2023, 5:04 PM

#

Yeah I mean, could we make a tool that post-processes patches to inline imports for patches areas, including wildcards?

mental carbon Sep 10, 2023, 5:40 PM

#

fallow sundial reminder to make recipeoutput#provider defaulted

Why?

#

We are in a BC and all vanilla uses are patched

#

Plus it is always needed

fallow sundial Sep 10, 2023, 5:41 PM

#

mental carbon We are in a BC and all vanilla uses are patched

because it's a vanilla interface?

mental carbon Sep 10, 2023, 5:41 PM

#

So what?

fallow sundial Sep 10, 2023, 5:42 PM

#

you're breaking vanilla binary compatibility

mental carbon Sep 10, 2023, 5:42 PM

#

With what?

#

What expects that interface to binary compatible

fallow sundial Sep 10, 2023, 5:42 PM

#

multiloader mods?..

mental carbon Sep 10, 2023, 5:43 PM

#

What?

#

They have to pick a loader

#

So the relevant multiloader mod, damn well knows on what platform it runs

#

And what kind of adaptations that platform makes to its environment

inland mesa Sep 10, 2023, 5:44 PM

#

IMO it's not reasonable to attempt to maintain binary compat with code written for the unpatched version of the classes

mental carbon Sep 10, 2023, 5:44 PM

#

^

inland mesa Sep 10, 2023, 5:45 PM

#

it would preclude like 90% of the features

mental carbon Sep 10, 2023, 5:45 PM

#

We have never done that BTW

#

Not for optifine

#

Not for compat mods

#

Never

#

We patch were we need it too

#

To allow for the functionality to work

#1.20.2