#Which guild members should have access to mail?

1 messages · Page 1 of 1 (latest)

sacred narwhal
#

I'm working on a virtual mailbox system, allowing players and guilds to send items to each other without requiring guest access to plots or for both participants to be online at once. Should all guild members be allowed to interact with the guild's mail, or only managers and up? If the vote is split enough, I'll try to make this an option that guilds can adjust as they see fit. Note that player to player mail is also available, and that sent mail can be taken back by the player or guild that sent it in case there was a mistake.

🇦 All guild members can access mail
🇧 Only guild managers and up can access mail
🇨 Let guilds decide if members can access mail, or only managers and up (this is harder to implement, but still doable)

rugged hearth
#

Holy fish batman

tawny lotus
#

"You got mail! "

#

all members having access to mail would be nice, I would love to give (and recieve) gifts from guilds I respect

sacred narwhal
#

So far the actual sending of mail works, but there's a lot of other stuff that needs to be implemented:

  • There's no notifications yet
  • There's no check for if a guild is on lockdown, or you were demoted/kicked from a guild with the GUI open (I'm currently working on this)
  • There's no option for moderators to access mail, such as if someone committed mass theft and is distributing relevant items this way (though there are logs at least)
    etc
gilded current
#

I think it would be nice to be able to change the permissions for it too, like having it accessible to members at default, but the perms revokable

rugged hearth
#

My extended reasoning for voting B is that if you wanted to send something to a specific person, you can just do that with this system, but if you wanted to send something to an entire guild, it's safer and doesn't present a large problem if only a trusted subset of that guild can access it

It also causes a lot less hassle to have to ping a manager to get on (who theoretically would be active if they're a manager) than if some random new guild member happens to look at the mail, takes something out that wasn't intended for them, only for the intended recipient to have to figure that out through logs, potentially getting the mod team involved etc

true kite
#

I rather have mail system with a way for people to not steal stuff from the mailbox if they are intended to give/receive gifts to/from someone

#

But yea, I would rather have option to allow/revoke perm for individuals

#

Instead of perm for all guild members

#

Wait a min

#

Is there a mailbox before the player plot in plot shard being moved to Playerplot?

sacred narwhal
#

Player plots did have a physical mailbox before they were moved to playerplots, yes

#

I was going to have a way to change the permission for if members can access mail be a last resort if there's something pretty close to a tie because adding mailboxes is complicated enough as it is, but I guess I'll make it an official option 🇨

true kite
#

At least make it an option for individual perm as well as the guild members perm

rugged hearth
#

Making it editable would be the ideal solution, if guilds want to be more open and let anyone take mail they can, if guilds want to be more secure and only let trusted members take it they can, but obviously would require more work so

sacred narwhal
true kite
#

yikes probably not those two?

#

I mean individual that are guild members and not a guest?

sacred narwhal
#

Yup, though it'd be some intermediate difficulty to set up a new sort of guild permissions that apply to members instead of guests.

rigid tundra
#

is there a way to add like

#

a message

sacred narwhal
#

(And the default would still be for members to have those permissions and guests not to have them, so if either of those weird things happens, it's because a guild thought it'd be good/funny)

sacred narwhal
# rigid tundra a message

From a certain point of view 🙂 You can send shulker boxes, carriers of emotion, written books, etc. Not exactly the same as mailing a chat message, but it works.

#

(Also I need to reconsider the GUI titles a bit so they don't go outside the GUI like that)

#

Can't forget signs copied from other signs 🙂

rigid tundra
#

dolabra enjoyer 🙏

gritty halo
#

Anyway this is cool 👍

sacred narwhal
#

(It can also be opened as a guild to another player or guild)

gritty halo
#

Maybe "F: <entity_1> To: <entity_2>" ?

#

Feels like it'd be short enough even with long names

sacred narwhal
#
/mail send <guild <guild name>|player <player name>> [from guild]
/mail <mailbox|inbox|outbox> [player|guild]
onyx wren
#

c would be good since i perfer able to toggle each memeber's perm

#

But I'm a bit confused, what is the difference between a player sending mail to a player and a guild member sending mail to a guild member, from the screenshot it looks like the content of the mail from the guild member to the guild member will appear in an gui for all those who have the permission to take it?

sacred narwhal
#

There isn't really a difference between player->player, guild->guild, player->guild, and guild->player - if a player is involved, they'll be able to access the mail, and if a guild is involved, anyone with permission in the guild can access the mail. The screenshots I sent of the guild mail includes mail both to the guild (first two columns), and from the guild (last two columns), which is the same as /mail mailbox [player|guild]. If you only want to see the mail you sent/received, you can instead use /mail <outbox|inbox> [player|guild]

#

(Stuff in <> is required, pick one; stuff in [] is optional; | is a separator between valid options)

onyx wren
#

What does outbox/inbox do here, sorry not English user, I guess it mean take item out/put item in ?

sacred narwhal
#

Real world definitions for context:

Inbox:

  1. a box or tray (as on a desk) for holding incoming interoffice mail
  2. a computer folder devoted to incoming email

Outbox:

  1. a box or tray (as on a desk) for holding outgoing interoffice mail
  2. a computer folder for outgoing email messages that have not yet been sent

For the example we're using, the outbox contains mail that actually has been sent. Though with that said, the default view combines both, first the mail you've received, then the mail you've sent - and since both the person sending and receiving the mail can access the same mailbox, you can actually use it the "wrong" way around.

true kite
#

So basically outbox (a person sending) & inbox (a person receiving) kinda stuff?

sacred narwhal
#

outbox (you sent it) inbox (someone sent it to you)

#

This used to update visually for both players at once; I'll need to fix that, but even if it looks incorrect it still keeps track of where the item actually is and won't let you dupe anything.

onyx wren
#

from i see, it seems mailbox has limit about how much mail u can save?

true kite
#

I don’t remember this window and taskbar?

#

Besides that, will there be more than one page of mailbox?

sacred narwhal
sacred narwhal
# true kite Is this Linux?

It's the Linux Mate desktop from Linux Mint:

  • Controls are Adwaita-dark
  • Window borders are CBlack
  • Icons are MATE-Faenza-Dark (I think I had this on something blue before? That other icon set must have been removed, or maybe I'm thinking Cinnamon)
  • Pointer is MATE (Black)
sacred narwhal
# true kite Besides that, will there be more than one page of mailbox?

There will probably be more than one page - exact limits TBD, starting with:

    // These limits can be adjusted if needed; only MAX_SLOTS requires a GUI update
    public static final int MAX_SLOTS = 3;
    private static final int MAX_RECIPIENTS_PER_SENDER = 27;
    // TODO Add max senders per recipient (54 to start?)
faint mauve
#

Can shulkers be sent?

#

Is there a limit on the data I can send to someone else? Could I book ban someone’s mailbox?

#

(As in, opening the mailbox kicks you)

#

Are items contained in the mailbox checked for weekly update item replacements?

#

Can signs with text be sent? Might need to be banned for the same reason market banned signs.

#

(I still don’t get why they were banned from market, but eh)

sacred narwhal
#
  • Attempting to interact with a mailbox slot always checks what's actually stored instead of the item that's shown to you, so even if it shows an item that's no longer there, it'll give you the item that is actually in that slot. I'll fix it so that it shows the right version again, so you know what item you're actually getting.
  • This actually uses the market plugin under the hood so that it item replacements can run on it without too much extra work, taking each item stack and giving it a numeric ID that can be converted back later. Identical stacks get the same numeric ID, saving a ton of space.
  • The market plugin disallows containers of items because that would result in too much space being used for each combination of what's inside a container. The mail system gets around this by getting the numeric ID for an empty version of the container, then storing the ID and count of each of its contents next to that ID. Mailing a firmament full of a single type of blocks would result in sending the ID of an empty firmament, and the same block ID repeated by however many slots are used. This also supports nested containers like a firmament inside an equipment case.
  • I should double check, but I'm pretty sure signs/books/etc are not allowed on the market because of moderation and advertising items outside the market plugin. This isn't a concern for mail, so I'm allowing it for now - though I'll double check before it ships.
  • No clue on book banning yet. If it turns out this is possible, I'll put a size limit on items you can add to mailboxes. I'll make sure the size limit is still high enough for most items, though.
faint mauve
#

Is there somehow a limit on mailing beyond mail slots? If the moderation concern is there, why can’t I mail signs with whatever the mods don’t like to whoever’s online until my slots fill?

#

I feel like that’s the main concern, a secondary chat method that isn’t easily modable

#

(Also, the reason I don’t get the no signs in market is because 1. If I’m posting insults, I’m not completing 3 dungeons and then using the market, I’m using the chat while no mods are on and 2. It really isn’t much different from regular chat with no mods online. But I do get the idea of volunteer time being low. And if the goal is to stop WTB listings and ads then that’s a separate unrelated to moderation issue, but truthfully I could just filter out signs)

#

(This is unrelated to the topic at hand though)

faint mauve
#

I just thought; if you ban books, secret Santa will not be possible using this system.

sacred narwhal
#

It might also end up being that allowing custom text in the market was a storage space concern - I really need to check.

#

Sounds like it's probably the moderation thing - I'll add a hook for items to go through the chat filters and see if that reassures anyone.

crystal cove
#

Is there a reason this system is being isolated to guilds? I would imagine a two Tiered system, where one tier is individual mailboxes, and one is a permissioned guild mailbox accessible to managers+, would work nicely.

rugged hearth
#

Note that player to player mail is also available

In the original post. This is just polling for guild permissions

crystal cove
#

Ah I see