Hooking up another mod to make a custom item

[uneven edge]

I want to add a custom spear for Rose Gold from Additional Additions and use arguments and base from Backported Spears. I know that you can do it, but how?

[fresh hill]

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

[uneven edge]

Hooking up another mod to make a custom item

[rapid ibex]

probably spamming JavaAdapter to override the methods to create your own item

take a look at my script I did for custom armors variants #1473465876534657024

[uneven edge]

Basically, I need to search for all classes that Backported Spears have for Type, Resource Location and Properties, then I am creating a custom item, that hooked up to the existed model and overriding it using JavaAdapter?

kinda lost here tbh

[rapid ibex]

not exactly see if you can extend their SpearItem and see if it has a constructor for materials and what not

[uneven edge]

Elaborate

[rapid ibex]

I mean that's it

[cerulean mica]

The Backported Spears do it in a really jank way

Because they create their spears using an inline anonymous class that extends ToolItem:
https://github.com/Unknowneth/Backported-Spears/blob/ccf8b121c201f01cd04960b9d98710157f0e7cb3/common/src/main/java/com/notunanancyowen/spears/Spears.java#L215

[uneven edge]

[rapid ibex]

nvm I do see a register spear static function

You could try that out

[cerulean mica]

Yeah

But watch out! The code is using Yarn mappings, not official Mojang mappings!

KubeJS uses and resolves Mojang mappings

[uneven edge]

Ok that means it is impossible?

[cerulean mica]

No

It's just you can't just copy-paste the code and expect it to work

[uneven edge]

That makes things worse

As a person who just getting along with Java and JavaScript it seems that this task is out of my reach

ok this mod already have some integrations

not with mod I use tho

[rapid ibex]

nah it's not hard to translate mappings

just use a translator

and some of them you can already guess

[cerulean mica]

https://wagyourtail.xyz/Projects/MinecraftMappingViewer/App

This is really helpful

[rapid ibex]

I was going to suggest linkie but their translator has been down for a while now

[mint vortex]

I'm also actually interested in doing this, as well. The furthest I've gotten so far is finding a handful of potential Java.loadClass entries with arg0 as $Tier,3 other numerical entries and $Item.Internal (If memory serves) Don't know how else to progress, though.

[rapid ibex]

Just call this function and see what happens

there shouldn't be any issues because it's a public static

[mint vortex]

So, I attemped to call it during item creation and this is what happens:

``let Spear = Java.loadClass('com.spearsplus.item.SpearItem')
let Trident = Java.loadClass('net.minecraft.world.item.TridentItem')
const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')
const $TEST = Java.loadClass('dev.latvian.mods.kubejs.item.ItemBuilder')
const $Tier = Java.loadClass('net.minecraft.world.item.Tiers')

StartupEvents.registry('item', event => {
event.create('electrum_spear', Spear).displayName("Electrum Spear").tier("diamond")
}) ``

[rapid ibex]

where are you calling the register spear function?

[mint vortex]

I could be trying to call it wrong, but this is what I've attempted so far

These are the only ones available through ProbeJs:

[rapid ibex]

ProbeJS doesn't dump all the classes and can't dump some

[mint vortex]

dang..

[rapid ibex]

don't blindly trust probejs

trust the source code more

[mint vortex]

the reason I was trying to call that bit of code is because of this part within that .class file:

I assumed it was the key to registering a new spear item, but I'm unsure at this point.

[rapid ibex]

try this and see what happens

[mint vortex]

wait, I think I see the problem. I was using a different Spears backport mod, Spears +. Just installed the one I believe you're using in this case.

I have something more cohesive, but there's one entry that confuses me:

The only bit in the source code that I can see that refrences 'settings' is this: Item.Properties settings

[cerulean mica]

https://www.curseforge.com/minecraft/mc-mods/spears-spears-plus
Hooray, ARR with no source code

Load the Item$Properties class and pass an instance of it to the parameter

[mint vortex]

like this?

[cerulean mica]

new Item$Properties()

You want to pass in an instance, not a class

Also, after you construct it, you can chain some methods to set up the item properties

Like, make it stack to 1:

new $ItemProperties().stacksTo(1)

[mint vortex]

Just to make sure, I'd add instance in place of class, right?

[cerulean mica]

No

[mint vortex]

What passes it as an instance? I'm only aware of let and class.

[rapid ibex]

new

[cerulean mica]

Using Java.loadClass, you get a reference to a class - an object, that can construct derived objects called instances by using new on the class and passing in constructor parameters.

const $ItemProperties = Java.loadClass("net.minecraft.world.item.Item$Properties")

Item.Properties has no parameters for its constructor, so no parameters passed.

const properties = new $ItemProperties()

Here, properties is an instance of the Item.Properties class.
And that's what you want to pass in.

Think of a class as a "car factory" and instances as "cars"

[mint vortex]

Duly noted

[mint vortex]

YESSSS finally got it working, albeit untextured.

[cerulean mica]

Then give your item a texture and a model

[mint vortex]

Yea, I figured.

I was more worried about making it acutally exist first lol

[cerulean mica]

Normally, KubeJS does give your item a model automatically, but if you create an item with createCustom you have to add a model manually

[mint vortex]

Since we're using createCustom, would the model and inventory sprite have to be added via a datapack?

[cerulean mica]

Resourcepack - yes

[mint vortex]

gotcha

[cerulean mica]

Lucky for you, assets folder inside the kubejs folder is a global resource pack

[uneven edge]

Can you pass the code please? 🙏

oh wait you are on Spear+?

[mint vortex]

Sorry, just woke up. Lemme get you the code.

[mint vortex]

  const itemProperties = new $ItemProperties

let spear = Java.loadClass('com.notunanancyowen.spears.items.SpearItem')

let $KubeJSItemTier = Java.loadClass('dev.latvian.mods.kubejs.item.MutableToolTier')
let $ItemTier = Java.loadClass('net.minecraft.world.item.Tiers')

  const Brass = new $KubeJSItemTier('brass')
  const Steel = new $KubeJSItemTier('steel')

const spearRegistry = (
                        name, tier, swingAnimationTicks, chargeDamageMultiplier, ChargeDelay, 
                        maxDurationForDismount, minSpeedForDismount, maxDurationForChargeKnockback, minSpeedForChargeKnockback,
                        maxDurationForChargeDamage, minRelativeSpeedForChargeDamage, hitSound, attackSound, 
                        useSound, settings
                      ) => {

StartupEvents.registry('item', event => {
    event.createCustom(name, () => new spear(
      /*material*/                          tier, //Use $ItemTier for vanilla tiers, $KubeJSItemTier for custom tiers
      /*swingAnimationTicks*/               swingAnimationTicks,
      /*chargeDamageMultiplier*/            chargeDamageMultiplier,
      /*ChargeDelay(s)*/                    ChargeDelay,
      /*maxDurationForDismount(s)*/         maxDurationForDismount,
      /*minSpeedForDismount*/               minSpeedForDismount,
      /*maxDurationForChargeKnockback(s)*/  maxDurationForChargeKnockback,
      /*minSpeedForChargeKnockback*/        minSpeedForChargeKnockback,
      /*maxDurationForChargeDamage(s)*/     maxDurationForChargeDamage,
      /*minRelativeSpeedForChargeDamage*/   minRelativeSpeedForChargeDamage,
      /*hitSound*/                          hitSound,
      /*attackSound*/                       attackSound,
      /*useSound*/                          useSound,
      /*settings*/                          settings //based off of Item$Properties, create a new one with data attached
    ))
})
}```

It does include some custom tiers I made for my own project, so please ignore that. Also, I'm using "Backported Spears" since that's what this topic was originally about.

And since I condensed this registry into a constant, you can just type in spearRegistry(... and just fill in the fields with values that match what you want your spear to be like.

[daring glen]

You can write your code in a codeblock by typing it between the codeblock delimiters:
Note that these are backticks, not apostrophes

```js :arrow_left:

ServerEvents.recipes(event => {
event.smelting('minecraft:glass', '#forge:sand').xp(.1)
})

``` :arrow_left:

This example will look like this:

ServerEvents.recipes(event => {
  event.smelting('minecraft:glass', '#forge:sand').xp(.1)
})

[cerulean mica]

Use three backticks, not one

[uneven edge]

So, it IS working properly, right?

[mint vortex]

Whoops, I keep using two lol. Thanks.

[cerulean mica]

Also insert js after first set

For syntax highlighting

[mint vortex]

Yes, and I'm still trying to get the spear model working properly. It's working mostly right, but textures aren't loading and the inventory icon is the spear model itself.

[uneven edge]

I see...

[uneven edge]

To make them work in your code I need to create a tier for each material type?

[cerulean mica]

Yes, unless you want to reuse vanilla tiers

[mint vortex]

If you want to make a tier that isn't a vanilla tier yea

[uneven edge]

For example, in my modpack I need to make spears for every Aether material

I need to assign them to Aether tiers?

[cerulean mica]

Find the class in the Aether mod that has tiers, and load that class

[uneven edge]

let $ItemTierAether = Java.loadClass('aether.class')?

[cerulean mica]

Not quite

Look through the Aether source code

[uneven edge]

Easier said than done

[mint vortex]

I actually use a program that lets me view .class files. Lemme see what it's called.

I'd also reccomend installing WinRaR if you haven't already.

[uneven edge]

ofc I have lol

But i'm scouting through their github

maybe it will be easier to make KubeJS tiers at this point

[stoic fossil]

JD-GUI?

[mint vortex]

IntelliJ IDEA

[uneven edge]

Yeah, I'm thinking that making custom tiers will benefit

I have so much materials to do spears for

16, to be exact

From different mods, so, it will be far easier to make KubeJS tiers from all of them, plus, it will hook nicely with Harvest Level Tweaker

[mint vortex]

Just keep in mind that if certain materials have passive benefits, like Electrum from Oreganized, you'll have to find a way to add those traits manually.

I'll update this thread if I get the model working 100%

[uneven edge]

yeah, Enderum from Majrusz's Progressive Difficulty have passive benefits, but for armor only

[stoic fossil]

oreganzied uses attributes

[uneven edge]

🔥

[mint vortex]

Really? Because the only way I've been able to add its Kinetic Damage attribute is through item tags. Unless that's what you mean?

[rapid ibex]

Please drop the working script in #1048591172165189632 when you guys get it to work

[mint vortex]

I'm pretty stumped as to how to apply my spear's texture file to the model since this is being created through createCustom :/ It seems no matter where I put it, the spear remains untextured, but the model loads in just fine.

[cerulean mica]

What texture is your model referencing?

[mint vortex]

Are you asking if it's a .png file?

[cerulean mica]

No

A model JSON

[mint vortex]

Ohhhh that. The model's file is located at kubejs/assets/kubejs/models/item/steel_spear.json

[cerulean mica]

And its contents are... ?

(paste the contents here)

[daring glen]

Paste version of steel_spear.json from @mint vortex

[mint vortex]

Nevermind, I finally got it working

You gave me the idea to look into the model's json file lol. It worked!

https://discordapp.com/channels/303440391124942858/1474451428897722610

The only other issue that I have is that the inventory icon is just the spear model itself, but other than that it works just fine.

[rapid ibex]

you can override that with a texture pack

that is default behavior unless specificed otherwise

[cerulean mica]

You can change that in the model as well

[mint vortex]

If anyone can help with making unsupported item types allow for their item attributes to be modified, I would like to kindly redirect you to my help ticket: https://discordapp.com/channels/303440391124942858/1474525293271056484

[uneven edge]

@mint vortex You are the best, holy, I owe you now 🙏

Closing the ticket!

[fresh hill]

Ticket re-opened!

[uneven edge]

nvm I need some additional help LOL

[stoic fossil]

No you can directly change the attributes

[mint vortex]

Whatcha need help with?

[uneven edge]

About spear models

I'm kinda lost with them

[mint vortex]

Soooo have you created one yet?

I'm using Blockbench for mine.

[uneven edge]

That's where I stuck - how?

Can you pass .bbmodel of your model?

[mint vortex]

I just learned recently that you can actually drag a .png of your sprite into blockbench!

It'll automatically create a model based on the sprite.

Also, for Java, you'll need your model to be exported as a .json file.

[uneven edge]

Since WHEN

[mint vortex]

IDK MAN

I was shocked as soon as I saw that was a thing.

[uneven edge]

Ok, I need to test it out. I suppose I need to re-create the animation itself or?..

[mint vortex]

Nope! But you will need to pose it for left hand, right hand, item frames, and dropped items.

Though I think you may be able to bypass some of that by setting the parent to minecraft:item/held

[uneven edge]

for the love of please send me a template for this 🙏

I will go insane to make it for 16 spears

[daring glen]

Paste version of steel_spear_model.json from @mint vortex

[mint vortex]

You will have to create a sprite for it though.

[uneven edge]

ofc

[mint vortex]

I made mine 32 x 32

There is a little bit of wonkiness when the spears charge animation gets exhausted, as it moves up and away instead of down and out of view.

[uneven edge]

Same here

[mint vortex]

Other than that, it should function just fine.

[mint vortex]

Oh hell yeah

[uneven edge]

Skystone spear

[mint vortex]

Steel spear

Unfortunately, since you can't modify spears' stats atm like you can with tools and armor, its damage is going to default to whatever tier you set it to if memory serves.

Since my steel, brass, lead and silver spears all have a base attack damage of 3.

So at the moment, the only way you can influence their damage is by changing their charge damage multiplier. The jab attack will still only deal 3 damage regarless.

[uneven edge]

In the script itself?

[mint vortex]

yeah

It's the second number after "material" when adding in a new spear.

Like i said, it has no effect on base damage, but only the "jousting" damage.

[uneven edge]

Gotcha

But hold on what's the problem with setting up custom damage?

It acts like a melee, no?

Why you can't change the damage controls in tiers?

[uneven edge]

And I see the problem number 2: hotbar render

[mint vortex]

Yeahhh I haven't been able to figure out how to have it display as a different sprite other than the model itself

[uneven edge]

[uneven edge]

How it renders model in hotbar even?

[mint vortex]

Only info I'm working with is from a dump of 1.20.1:

[uneven edge]

hold on I might have an idea

[mint vortex]

And from 1.21.11, there's 3 separate .json files for a single spear entry; the spear, its held-in-hand file, and a general "spear-in-hand" file

[uneven edge]

From the mod itself

[mint vortex]

I'm assuming that's from the- yep

I tried that already

[uneven edge]

What's wrong with it then?

oh I can see what actually

[mint vortex]

something to do with "spears: in_gui"

since the spears we're making are from kubejs, not spears

[uneven edge]

I guess it is from the mod itself

And we need to hook it to the script

somehow

And it will work

[mint vortex]

yep

that's the working theory anyway

So unless there's a different way to do that same exact function in the .json file, I'm stumped.

I'm currently browsing 1.21.11 assets regarding spears, so I might find something there.

Okay so now the item's gui sprite is correct, but not the held model

[mint vortex]

No matter what I do, it seems like it'll only display one texture or the other...

[uneven edge]

We need to figure out what class is rendering the spear in GUI

#1445468987394887800 message
@mint vortex

[daring glen]

➤ KonSola5

[➤](#1445468987394887800 message)
In KJS 1.20.1,

• attackDamage setter on Item in the callback is broken (game doesn't launch),
• attackSpeed setter on Item adds a completely new attribute, that's why it doesn't look right.

So that's why you need to use addAttribute instead to modify those.

Credit: @still furnace:
<#1407522304543559810 message>
-# There you can see that the implicit conversion of a string representing an attribute to an Attribute is also possible.

Please note:

Attribute modification is only possible on classes that implement ModifiableItemKJS, that is:

• ArmorItem,
• SwordItem,
• DiggerItem,
• TridentItem
• and any classes extending one of above classes.

const $Attributes = Java.loadClass("net.minecraft.world.entity.ai.attributes.Attributes");

ItemEvents.modification((event) => {
  /**
   * @param {Internal.Item} item
   * @param {Internal.Attribute_} attribute
   * @param {number} value
   */
  function modifyAttribute(item, attribute, value) {
    const attributeToModify = item.getAttributes(attribute).get(0);
    item.removeAttribute(attribute, attributeToModify.id);
    item.addAttribute(
      attribute,
      attributeToModify.id,
      attributeToModify.name,
      value,
      attributeToModify.operation
    );
  }
  
  event.modify("minecraft:iron_pickaxe", (item) => {
    item.maxDamage = 2813;
    item.digSpeed = 12;
    modifyAttribute(item, $Attributes.ATTACK_DAMAGE, 5);
    modifyAttribute(item, $Attributes.ATTACK_SPEED, -2.8);
  });
});

LolsShow (Podcasting ARC) quoted

[uneven edge]

Isn't that we are looking for?

For attack attribute?

[mint vortex]

already have that script and it didn't work

That's the main issue; Backported Spears' spears items, and by extension the new KubeJS spears are deemed as "unsupported"

I don't know whether it's because their attack damage isn't directly stated when building one or whatever, but it doesn't work 🤷‍♂️

Even with trying to add stats through item.addAttribute doesn't work for the same reason.

I'm starting to think maybe it's because the backported spears' IDs are minecraft:///spear instead of backported_spears:///spears. Maybe it messes with how the item is registered?

[mint vortex]

Okay, I'm getting somewhere; I just tried to add attack damage and extra jumps to a stick and it also gave the same error. I think this problem has to do something with how the item is registered, or what is declared when creating the item.

[uneven edge]

🤔

[cerulean mica]

The spear most likely doesn't implement the ModifiableItemKJS interface

Which is injected into SwordItem, ArmorItem, DiggerItem and TridentItem

[rapid ibex]

you'll probably need to check how they implement attributes values for the "spear"s when registered

[mint vortex]

Yeah, I'm trying to mess around with those to see if I can do something with it.

Buuuuut I'm kinda stumped as to what to do either way.

[rapid ibex]

Then might have a place where they pull default values to assign to the spears

because you mentioned something about all the spears have the same attribute values

[mint vortex]

I think it's because of the custom tiers I made. I made another test_spear with vanilla minecraft's wood tier and it set that item's attack damage to 1 as it should.

[rapid ibex]

and it worked?

[mint vortex]

Yea, but I'm assuming its durability went down to that of the wooden spear, as well.

Lemme double-check

Okay, this is weird as heck... The wooden spear has a durability of 59, but the test_spear has a durability of 250.

A netherite spear has a durability of 2031, but the steel spear also still has only 250 durability, when it should have 215.

[cerulean mica]

I think that's because custom tiers are broken in general in KubeJS

[mint vortex]

Honestly I wouldn't be upset about that if it werent for the fact that we currently can't modify their stats until this is resolved.

[rapid ibex]

I mean you could do this. Remove their attribute tooltips and replace it with your own

then on the LivingHurtEvent modify the damage

[mint vortex]

Remove their attribute tooltips?

[rapid ibex]

yes

someone made a script

and I think I posted that in #1474144029435367576

or maybe not. but it is in this server

[mint vortex]

I did find something regarding Alembic, if that's what you're talking about.

[rapid ibex]

nah I'll find it give me a moment if this is the method you really want to do

#1474144029435367576 message

[mint vortex]

So basically, you want me to remove the stats from the spears and replace them? Just making sure I'm understanding.

[rapid ibex]

hide the attribute stats and replace them with the tooltips you want

IF thats how you want to work around attributes not working correctly

[mint vortex]

Let me see if it works

[rapid ibex]

it should work since the example script works with everything

[mint vortex]

So...... I removed attack damage and attack speed, but that doesn't seem like it did anything.

    "minecraft:generic.attack_damage",
    "minecraft:generic.attack_speed"
];```

that's the only part I modified, I made the whole script as its own file in the startup script folder, and nothing seemed to change.

[rapid ibex]

It should remove the attribute tooltip not the actual values

[mint vortex]

So is it purely visual?

[rapid ibex]

yes ...

[mint vortex]

oh.....

[mint vortex]

Ohhhhhh now I get what you were trying to say

I'm gonna see if I can get Alembic to change anything instead.

Unless something else pops up that we can try.

[mint vortex]

I'm also trying to see if I can add onto my current script to try and do something with it.

[rapid ibex]

I dont think any normal attribute modifcation is possible

[mint vortex]

The funny thing is that with Alembic, the damage of the spears indirectly changed due to that mod adding resistances and weaknesses to damage types. Not what I'm looking for, just a happy accident.

[mint vortex]

OKAY, so I did find one workaround regarding durability. You can set the custom spear's durability in the itemProperties section by typing itemProperties.defaultDurability(...)

Also, it seems like installing Alembic messes with the charge damage code, as it's the same as the jab damage.

[mint vortex]

Just a theory, but if we could somehow classify those spears as an item type that's supported by KubeJS like SwordItem or TridentItem, I wonder if it could also be modified..?

[rapid ibex]

there is no somehow

you can't cast item types I think in KubeJS

[mint vortex]

Oop-

[mint vortex]

I suppose another solution would be just to make an addon that supports the spears as an item type in the KubeJS item builder...

[uneven edge]

[cerulean mica]

Or inject the ModifiableItemKJS interface into them, but still - that requires a mixin, so a mod

[cerulean mica]

Even in Java you couldn't if the wasn't already extending/modifying the class.
Java ensures type safety, but there are some unsafe casts in Java:

• unchecked upcasts (TridentItem) item
• cast to Object ("any" type), then to anything (ModifiableItemKJS) (Object) item, this is actually seen in mixins where you have to sometimes bypass the type safety

[uneven edge]

@mint vortex This script can help us to make custom stab damage

It needs to be modified tho

[uneven edge]

@mint vortex ok here is the solution for the hotbar sprite render

[uneven edge]

literally my face

THE CUSTOM SPEAR SCRIPT CAN BE FINISHED

[mint vortex]

Okay, good news and bad news. Good news! That script functions as intended. Bad news #1: The spear's jousting attack is also set to the value you put in. Bad news #2: That script doesn't (currently?) function with Better Combat.

At least the script is useful for changing the damage of usually unmodifiable items/weapons.

[mint vortex]

The ironic part is that installing Better Combat actually fixes the jab attack's double damage bug

[uneven edge]

[mint vortex]

When trying to load the game with these changes, the game crashes before getting to the main menu ;w;

[uneven edge]

[daring glen]

Paste version of crash-2026-02-23_09.58.48-client.txt from @mint vortex

[mint vortex]

Okay, it's not crashing now, but it doesn't work...

The model itself is fine, but the gui part is still just the model and not the given sprite

[rapid ibex]

just search up a spartan weaponry texture pack

as far as I'm aware there are only two that modify the texture in gui

waccyy fantasia texture tweaks and icedmi's spartan weaponry

[stoic fossil]

I have this too with some of the weapons in spartan weaponry it's Soo annoying

[wooden flower]

lol that title

[uneven edge]

bump

[mint vortex]

You know, I did find a way to still technically add onto these spears without modifying their item attributes

Basically, I essentially coded in a very basic "Apply status on hit" mechanic and applied it to anything that had a specific tag.

Specifically, I added the ability for "holy-type" weapons to inflict only undead enemies with Slowed III from Iron's Spells.

Just posting my thoughts here, but maybe I can use that same script to either change the damage value of specific items only when it hits an entity, since we can already control almost all the basic stats of spears.

[rapid ibex]

probably a good idea

[uneven edge]

🔥

[mint vortex]

Wonderful development, ladies and gentlemen! I've found a way to modify the base damage of the custom spears!!

[mint vortex]

Just wanna ping you real quick regarding this.

[uneven edge]

Omg, I commissioned a mod in desperation

[mint vortex]

Oh?

Does it allow for the spears to be registered as a modifiable item through KubeJS or smth?

[uneven edge]

I just asked to add spears and gloves I need

[mint vortex]

What kinda gloves we talking about? Like, slapping gloves? Accessories?

[uneven edge]

aether gloves

[mint vortex]

Ohhhhhh nice!

[fiery quiver]

what is going on in this thread? 300+ messages and the original problem is still not fixed? ;o

[rapid ibex]

nah it should be fixed now