Persistent Data not really persisting? | latcord | Page 1

grim anvil Sep 19, 2025, 3:52 PM

#

const $Winscreen = Java.loadClass('net.minecraft.client.gui.screens.WinScreen');

ClientEvents.tick((event) => {
    if (
        $ModSavedData.getSaveData().getHordeState().toString() == 'DEFEATED' &&
        event.player.persistentData.defeatedHorde != true
    ) {
        Client.setCurrentScreen(
            new $Winscreen(true, () => {
                Client.setCurrentScreen(null);
            })
        );

        event.player.persistentData.defeatedHorde = true;
    }
});

Every time I load into a world where the horde state is defeated, it rolls the credits once.

supple archBOT Sep 19, 2025, 3:52 PM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

mellow iglooBOT Sep 19, 2025, 4:04 PM

#

Please send your KubeJS client log. It can be found at /minecraft/logs/kubejs/client.log.
If you are on 1.18 or 1.16 it will be called client.txt.
Please send the file directly, without links or snippets.

grim anvil Sep 20, 2025, 1:18 AM

#

Apologies for the delay, @solemn nexus, I also put extra prints.

const $Winscreen = Java.loadClass('net.minecraft.client.gui.screens.WinScreen');

ClientEvents.tick((event) => {
        console.info("Has defeated horde?")
        console.info($ModSavedData.getSaveData().getHordeState().toString() == 'DEFEATED')
        console.info('Credits already played?')
        console.info(event.player.persistentData.defeatedHorde)
    
    if (
        $ModSavedData.getSaveData().getHordeState().toString() == 'DEFEATED' &&
        event.player.persistentData.defeatedHorde != true
    ) {
        console.info("Playing credits")
        Client.setCurrentScreen(
            new $Winscreen(true, () => {
                Client.setCurrentScreen(null);
            })
        );

        event.player.persistentData.defeatedHorde = true;
    }
});

📎 client.log

mellow iglooBOT Sep 20, 2025, 1:18 AM

#

Paste version of client.log from @grim anvil

solemn nexus Sep 20, 2025, 12:32 PM

#

did you know that if the persistentData is undefined then js if (!event.player.persistentData.defeatedHorde) will pass as true?

#

instead you might wanna try either making it a 0/1 check or try stages if you're running into the same issue after relogging

#

stages being ```js
player.stages.has("someStageTag")

grim anvil Sep 20, 2025, 2:15 PM

#

solemn nexus did you know that if the persistentData is undefined then ```js if (!event.playe...

RIIIIGHT

#

Thank you

#

Ok, tried stages and the result is the same - it doesn't seem to be saving between sessions.

The checks themselves work, the problem is that defeatedHorde persistent data is undefined at the start, and the stage is set back to false.

#

Is there a way to check advancements client-side?

solemn nexus Sep 20, 2025, 2:34 PM

#

grim anvil Ok, tried stages and the result is the same - it doesn't seem to be saving betwe...

hmm, send code

grim anvil Sep 20, 2025, 2:42 PM

#

const $ModSavedData = Java.loadClass('com.github.sculkhorde.core.ModSavedData');
const $Winscreen = Java.loadClass('net.minecraft.client.gui.screens.WinScreen');

ClientEvents.tick((event) => {
    console.info('Has defeated horde?');
    console.info(
        $ModSavedData.getSaveData().getHordeState().toString() == 'DEFEATED'
    );
    console.info('Credits already played?');
    console.info(event.player.stages.has('creditsPlayed'));

    if (
        $ModSavedData.getSaveData().getHordeState().toString() == 'DEFEATED' &&
        !event.player.stages.has('creditsPlayed')
    ) {
        console.info('Playing credits');
        Client.setCurrentScreen(
            new $Winscreen(true, () => {
                Client.setCurrentScreen(null);
            })
        );

        event.player.stages.add('creditsPlayed')
    }
});

solemn nexus Sep 20, 2025, 2:57 PM

#

instead of clientevents.tick try PlayerEvents.tick

grim anvil Sep 20, 2025, 3:11 PM

#

nothin'

solemn nexus Sep 20, 2025, 4:47 PM

#

hmm

grim anvil Sep 20, 2025, 5:21 PM

#

Hmm. Respawning resets the stages as well.

solemn nexus Sep 20, 2025, 6:56 PM

#

it definately shouldnt be doing that

#

try installing only kubejs and testing outside your modpack

lone lotus Sep 20, 2025, 7:12 PM

#

if you have this in a client script folder PlayerEvent.tick won't work that's a server script

#

if you use ClientEvent.tick then you can't edit data that stored on server side e.g. stages or persistendData

#

atleast that is what I would assume

#

you would need to use PlayerEvents.tick and then send the data to the client to play the Display

#

using NetworkEvents.dataReceived

solemn nexus Sep 20, 2025, 7:29 PM

#

lone lotus if you have this in a client script folder PlayerEvent.tick won't work that's a ...

playerevent.tick is both server and client

#

lone lotus Sep 20, 2025, 7:30 PM

#

ok, I absolutely hate that the wiki isn't up to date

solemn nexus Sep 20, 2025, 7:30 PM

#

lol i feel that

#

should get don on that tbh

lone lotus Sep 20, 2025, 7:30 PM

#

it just says server

#

but does this then automatically handle sending the data to the server? if in client script

solemn nexus Sep 20, 2025, 7:31 PM

#

that being said im not sure about this issue, if its resetting even on respawn then something is very wrong, which is why i think he should try with only kjs, maybe some mod is doing something funky

solemn nexus Sep 20, 2025, 7:31 PM

#

lone lotus but does this then automatically handle sending the data to the server? if in cl...

nope

#

will only fire on client side level

lone lotus Sep 20, 2025, 7:32 PM

#

are there stages that are only client specifc?

#

causes that would sound like something new

solemn nexus Sep 20, 2025, 7:33 PM

#

i know persistentData should work on client though maybe its not saving through sessions because it isnt saving to the world nbt?

solemn nexus Sep 20, 2025, 7:33 PM

#

lone lotus you would need to use PlayerEvents.tick and then send the data to the client to ...

if thats the case then this might be his best bet

lone lotus Sep 20, 2025, 7:33 PM

#

why would it save to world nbt? on a dedicated server it also wouldn't

solemn nexus Sep 20, 2025, 7:33 PM

#

it wouldnt, thats what im saying

#

stages would be in the same boat

lone lotus Sep 20, 2025, 7:34 PM

#

yeah then that's the issue

solemn nexus Sep 20, 2025, 7:34 PM

#

so really he should do a network events in client scripts and player tick in server scripts

lone lotus Sep 20, 2025, 7:34 PM

#

yeah

grim anvil Sep 20, 2025, 10:23 PM

#

Ah, that's a rabbit hole I didn't want to go down, but its a learning experience, I suppose.

#Persistent Data not really persisting?