Cant add tags to fluids | latcord | Page 1

autumn spruce Jan 9, 2025, 10:02 PM

#

ServerEvents.tags('block', event => {
    const path_array = ['rnr:base_course', 'tfc:salt_water', 'tfc:river_water', 'minecraft:water']

    path_array.forEach(block => {
        event.add('via_romana:path_block', block)
        event.add('tfc:paths', block)
    })
})

Trying to add path tags to these blocks. Tags are not showing up in JEI and seemingly not working in via romana either. First time using kubejs. This is located in server_scripts. Using neoforge not forge. Reloads without errors.

ionic vergeBOT Jan 9, 2025, 10:02 PM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

west tangle Jan 9, 2025, 10:06 PM

#

you don’t have to do it like that

#

ServerEvents.tags('block', event => {
    const path_array = ['rnr:base_course', 'tfc:salt_water', 'tfc:river_water', 'minecraft:water']

    event.add('via_romana:path_block', path_array)
    event.add('tfc:paths', path_array)

})

#

anyhow tags are kindof broken

autumn spruce Jan 9, 2025, 10:09 PM

#

west tangle you don’t have to do it like that

i tried adding them with basically this loop but unrolled before and it did not work either as far as i could tell

#

but let me double check to make sure it doesnt work like that either

west tangle Jan 9, 2025, 10:09 PM

#

either ways makes no difference but that forEach is inefficient

autumn spruce Jan 9, 2025, 10:10 PM

#

yeah it did not make a difference

west tangle Jan 9, 2025, 10:10 PM

#

try reloading twice

#

or re-join world and /reload

#

and they should work but never on first world load 😒

#

kubejs has some issues

autumn spruce Jan 9, 2025, 10:11 PM

#

tried restarting the entire game already

west tangle Jan 9, 2025, 10:12 PM

#

may be better off making a datapack of tags

#

for now

autumn spruce Jan 9, 2025, 10:13 PM

#

absolutely no idea how to do that

#

ah ok seems straightforward

autumn spruce Jan 9, 2025, 10:18 PM

#

west tangle may be better off making a datapack of tags

just to make sure to add the tag via_romana:path_block i need to create datapacks/via_romana/tags/items/path_block.json

west tangle Jan 9, 2025, 10:19 PM

#

kubejs/data/via_romana/tags/blocks/path_block.json

kubejs/data/tfc/tags/blocks/paths.json

{
  "replace": false,
  "values": [
    "rnr:base_course",
    "tfc:salt_water",
    "tfc:river_water",
    "minecraft:water"
  ]
}

#

you’re adding block tags, so tags/blocks

autumn spruce Jan 9, 2025, 10:20 PM

#

ah right

#

ok got it thanks

west tangle Jan 9, 2025, 10:21 PM

#

also note that

#

if those 2 tags already exist, you’ll be replacing it with just those

#

i forgot exactly how to not have tags be replaced

autumn spruce Jan 9, 2025, 10:23 PM

#

you pass "replace": false

west tangle Jan 9, 2025, 10:23 PM

#

right

autumn spruce Jan 9, 2025, 10:24 PM

#

can i just /reload datapacks ?

west tangle Jan 9, 2025, 10:24 PM

#

yea

autumn spruce Jan 9, 2025, 10:25 PM

#

doesnt seem to be working 😃

west tangle Jan 9, 2025, 10:25 PM

#

atleast i thought 😅

autumn spruce Jan 9, 2025, 10:25 PM

#

trying restarting

west tangle Jan 9, 2025, 10:27 PM

#

also hmm, second thought, i wonder if they’re supposed to blocks and not fluid

autumn spruce Jan 9, 2025, 10:27 PM

#

yeah no still no luck

#

well the base course block doesnt get the tag either

west tangle Jan 9, 2025, 10:27 PM

#

or items instead

#

hmm

#

weird

autumn spruce Jan 9, 2025, 10:28 PM

#

ill try with fluids

#

nope lol

west tangle Jan 9, 2025, 10:29 PM

#

i honestly had given up trying to use tags with kubejs because what i’m doing is more complicated

#

getting tags from items and mix/matching them around with other items dynamically, hard to do datapacks lol

#

especially since getting tags on items first load doesn’t work until after you reload 😔

#

and some items won’t even give tags

#

it’s a mess, and i can’t figure out why tags are acting like this

#

though i haven’t had an issue adding tags normally

autumn spruce Jan 9, 2025, 10:32 PM

#

hmm im not sure im using this correctly but using /kubejs list_tags forge:fluid_type lists 0 fluids so maybe theyre not registered correctly

#

but ive got no idea how this works nowadays 🥲

#

ah it is a minecraft fluid

#

so let me try this

I guess now I know For anybody wondering, Fluid tags go in datapacks\yourdatapackfolder\data\minecraft\tags\fluids\

#

https://www.minecraftforum.net/forums/minecraft-java-edition/recent-updates-and-snapshots/2921676-1-13-datapack-fluid-tags

[1.13] datapack fluid tags - Recent Updates and Snapshots - Minecr...

I'm trying to add water.json and lava.json into my custom datapack.

I've copied the two jsons into my data\time\tags\fluids folder in my datapack, but thi...

west tangle Jan 9, 2025, 10:33 PM

#

didn’t you just try fluids and it didn’t work?

#

you used kubejs event or renamed datapack folder?

autumn spruce Jan 9, 2025, 10:34 PM

#

renamed folder

west tangle Jan 9, 2025, 10:35 PM

#

oh you moved to minecraft namespace

#

if you did /kubejs list_tags tfc:fluids

#

it should’ve showed there

autumn spruce Jan 9, 2025, 10:35 PM

#

tfc:fluids doesnt exist

#

it shows in minecraft:fluids though

#

ah

west tangle Jan 9, 2025, 10:36 PM

#

but you created that datapack entry so it should’ve existed

#

i’m so confused

autumn spruce Jan 9, 2025, 10:36 PM

#

west tangle but you created that datapack entry so it should’ve existed

should've would've

#

would be huge if things just worked

west tangle Jan 9, 2025, 10:37 PM

#

yea such a headache

autumn spruce Jan 9, 2025, 10:38 PM

#

ok so tfc has a different tag for flowing fluids

#

so it got tfc:salt_water and tfc:flowing_salt_water

#

so i will just add both to my via_romana allowed blocks list

autumn spruce Jan 9, 2025, 10:43 PM

#

autumn spruce so i will just add both to my via_romana allowed blocks list

doesnt work, unsurprisingly

#

ok stupid question

#

if kubejs list_tags minecraft:fluid gives me the tag tfc:any_water

#

do i reference it via tfc:any_water ?

west tangle Jan 9, 2025, 10:49 PM

#

#tfc:any_water

autumn spruce Jan 9, 2025, 10:49 PM

#

yeah via romana config omits the # unless there is a distinction between including # and without # but given that the tag tfc:paths worked i wouldnt assume so

west tangle Jan 9, 2025, 10:50 PM

#

you can only reference from same tag type

autumn spruce Jan 9, 2025, 10:50 PM

#

using minecraft:fluid doesnt work either

autumn spruce Jan 9, 2025, 10:50 PM

#

west tangle you can only reference from same tag type

dont know what that means

#

Cant add tags to fluids

west tangle Jan 9, 2025, 10:51 PM

#

like if you have tags in romana/tags/fluids/path_blocks.json

you can’t reference that in minecraft/tags/blocks/, only minecraft/tags/fluids

autumn spruce Jan 9, 2025, 10:51 PM

#

ah ok

west tangle Jan 9, 2025, 10:52 PM

#

you would have to put path_blocks in each fluids, items, blocks to be referenced in fluids, items, blocks, etc

#

that was my message i deleted cause i second doubted myself if you can reference but yea you can

#

just gotta make sure it’s tagged with prefix #

#

https://github.com/TerraFirmaCraft/TerraFirmaCraft/blob/1.20.x/src/main/resources/data/tfc/tags/fluids/any_water.json

GitHub

TerraFirmaCraft/src/main/resources/data/tfc/tags/fluids/any_water.j...

Survival Mode as it Should've Been. Contribute to TerraFirmaCraft/TerraFirmaCraft development by creating an account on GitHub.

#

may be helpful looking at these tags too

autumn spruce Jan 9, 2025, 10:57 PM

#

sorry, im super unfamiliar with how minecraft works

#

if i have the tfc:any_water tag listed under minecraft:fluid

#

const water_blocks = event.get('tfc:any_water').getObjectIds()
Do i get all fluid blocks like this ?

west tangle Jan 9, 2025, 11:01 PM

#

if #tfc:any_water is reference under #minecraft:fluid, tfc:any_fluid would all be minecraft:fluid, so #minecraft:fluid would have all tfc:any_water tags

autumn spruce Jan 9, 2025, 11:01 PM

#

can you give me an example of how i would do the above? Im not sure i follow

west tangle Jan 9, 2025, 11:02 PM

#

if you want all minecraft fluids to be tfc fluid, you’ll reference #minecraft:fluid in #tfc:any_fluids

autumn spruce Jan 9, 2025, 11:03 PM

#

no i just want to get all object ids of objects/blocks/fluids listed under #tfc:any_fluids

west tangle Jan 9, 2025, 11:03 PM

#

oh

autumn spruce Jan 9, 2025, 11:04 PM

#

ServerEvents.tags('fluid', event => {
         const add_tags_to = event.get('tfc:any_water').getObjectIds()
      event.add('via_romana:path_block', add_tags_to)
})

figured i should try changing the 'block' argument to fluid maybe

#

not sure that fixes anything

#

but minecraft just freezes

west tangle Jan 9, 2025, 11:06 PM

#

in your script, you’ll be getting all id’s and tags from tfc:any_fluds and adding it to via_romana:path_blocks

autumn spruce Jan 9, 2025, 11:07 PM

#

is that not what i want to do

west tangle Jan 9, 2025, 11:08 PM

#

yes you asked and was correcting that’s right

autumn spruce Jan 9, 2025, 11:08 PM

#

ok great -- it still doesnt work lol

#

ServerEvents.tags('fluid', event => {
         const add_tags_to = event.get('tfc:any_water').getObjectIds()
      event.add('via_romana:path_block', add_tags_to)
    event.add('tfc:paths', add_tags_to)
})
ServerEvents.tags('block', event => {
         const add_tags_to = event.get('tfc:any_water').getObjectIds()
      event.add('via_romana:path_block', add_tags_to)
    event.add('tfc:paths', add_tags_to)
})
ServerEvents.tags('item', event => {
         const add_tags_to = event.get('tfc:any_water').getObjectIds()
      event.add('via_romana:path_block', add_tags_to)
    event.add('tfc:paths', add_tags_to)
})

doesnt either

west tangle Jan 9, 2025, 11:09 PM

#

after you add tags you can check them:

console.log(event.get('via_romana:path_block').getObjectIds())

#

and look in logs/kubejs/server.log for output

#

and or do /kubejs list_tags via_romana:path_block

autumn spruce Jan 9, 2025, 11:11 PM

#

empty array 🤔

west tangle Jan 9, 2025, 11:11 PM

#

blame kubejs

#

it might not be getting the tags from tfc:any_water

autumn spruce Jan 9, 2025, 11:11 PM

#

west tangle and or do /kubejs list_tags via_romana:path_block

no registry

west tangle Jan 9, 2025, 11:11 PM

#

that has been my issue, even just getting tags from an ItemStack. always an empty array

autumn spruce Jan 9, 2025, 11:12 PM

#

in general only forge, minecraft and moonlight have a registry

west tangle Jan 9, 2025, 11:14 PM

#

check

console.log(event.get('tfc:any_water').getObjectIds())

autumn spruce Jan 9, 2025, 11:14 PM

#

tfc any water:[minecraft:water, minecraft:flowing_water, tfc:river_water, tfc:salt_water, tfc:flowing_salt_water, tfc:spring_water, tfc:flowing_spring_water]

#

looks correct

west tangle Jan 9, 2025, 11:15 PM

#

weird so tags aren’t being added at all

autumn spruce Jan 9, 2025, 11:16 PM

#

stupid question

#

do i need to move the server startup script folder to my world folder

#

given it logs correctly i wouldnt assume so

west tangle Jan 9, 2025, 11:16 PM

#

lol no

#

i wonder if it’s because it’s a list and not an array? try this

ServerEvents.tags('fluid', event => {
         const add_tags_to = event.get('tfc:any_water').getObjectIds().toArray()
      event.add('via_romana:path_block', add_tags_to)
})

west tangle Jan 9, 2025, 11:18 PM

#

west tangle ```js ServerEvents.tags('block', event => { const path_array = ['rnr:base_co...

i doubt though cause this didn’t even work

#

i really don’t know anymore. i gave up on using kubejs with tags for now until it’s fixed, for the 11th time lol

autumn spruce Jan 9, 2025, 11:20 PM

#

already tried with a foreach over it instead of an iterable

#

toArray conversion doesnt work either

#

#

HUH

#

🙏 please let the restart work

#

Assuming it is a via romana issue now since it is tagged

#Cant add tags to fluids