is there any way to check if a player is in a certain structure? | latcord | Page 1

marsh gale Oct 7, 2024, 8:51 PM

#

Im trying code from this one and it works on 1.20.1 but not 1.19.2, which is needed https://discord.com/channels/303440391124942858/1290668963143090207

glass hingeBOT Oct 7, 2024, 8:51 PM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

marsh gale Oct 7, 2024, 8:51 PM

#

here is logs

📎 server.log

cobalt wedgeBOT Oct 7, 2024, 8:51 PM

#

Paste version of server.log from @marsh gale

marsh gale Oct 7, 2024, 8:55 PM

#

here is my code

const $ResourceKey = Java.loadClass("net.minecraft.resources.ResourceKey");
const structureName = "minecraft:mineshaft";
const structure = $ResourceKey.create($ResourceKey.createRegistryKey("worldgen/structure"), structureName);

BlockEvents.rightClicked((event) => {
    const { player, level } = event;
    if (level.structureManager().getStructureWithPieceAt(player.blockPosition(), structure).isValid()) {
        player.tell ('aa')
    }
    else player.tell ('bb')
});

drifting nexus Oct 8, 2024, 4:53 AM

#

https://discord.com/channels/303440391124942858/1258734844452667423

marsh gale Oct 8, 2024, 6:46 AM

#

drifting nexus https://discord.com/channels/303440391124942858/1258734844452667423

It looks interesting. But I have a question: does this method cause lags? And the second question is maybe there is a way to check the player's location in a needed structure only at the moment of activation of the events like item right click or block right click

drifting nexus Oct 8, 2024, 6:48 AM

#

no, and idk

marsh gale Oct 8, 2024, 7:30 AM

#

Ok, thank you.
I will wait for another method if it exists

marsh gale Oct 8, 2024, 12:20 PM

#

@still frigate sorry for ping, but may be you know is it a bug or something? because everything works great on 1.20.1, but for some reason it gives this error on 1.19.2

marsh gale Oct 10, 2024, 7:55 PM

#

hmmm

half canyon Oct 10, 2024, 7:58 PM

#

maybe try this one @marsh gale https://discord.com/channels/303440391124942858/1234946395132133458

marsh gale Oct 10, 2024, 8:09 PM

#

half canyon maybe try this one <@452883842580217866> <https://discord.com/channels/303440391...

[23:07:41] [ERROR] ! a.js#3: Error loading KubeJS script: server_scripts:a.js': Failed to load Java class 'net.minecraft.core.RegistryAccess.RegistryEntry': Class could not be found!
do you know what class should I use instead of this

#

and there is another problem

📎 server.log

cobalt wedgeBOT Oct 10, 2024, 8:13 PM

#

Paste version of server.log from @marsh gale

half canyon Oct 10, 2024, 9:31 PM

#

hmmm

half canyon Oct 10, 2024, 9:33 PM

#

marsh gale and there is another problem

for this just do js server.getLevel(dimension)

half canyon Oct 10, 2024, 9:36 PM

#

marsh gale `[23:07:41] [ERROR] ! a.js#3: Error loading KubeJS script: server_scripts:a.js':...

also do you have the actual error report for this?

marsh gale Oct 11, 2024, 9:42 AM

#

half canyon also do you have the actual error report for this?

yeah.
here is code that I use

let ServerLevel = Java.loadClass("net.minecraft.server.level.ServerLevel")
let ChunkStatus = Java.loadClass("net.minecraft.world.level.chunk.ChunkStatus")
let Registries = Java.loadClass("net.minecraft.core.RegistryAccess")
/**
 * 
 * @param {Internal.Entity} entity
 * @param {String} structure 
 * @returns 
 */
function isInStructure(entity, structure) {
    let pos = entity.block.pos
    let dimension = entity.getLevel().dimensionKey;
    let sw = entity.server.getLevel(dimension)
    if (sw instanceof ServerLevel) {
        let chunk = sw.getChunk(pos.x >> 4, pos.z >> 4, ChunkStatus.STRUCTURE_REFERENCES, false);
        if (chunk == null) {
            return false;
        }
        let references = chunk.getAllReferences();
        for (references of references.entrySet()) {
            let e = references
            let longs = e.getValue();
            if (!longs.isEmpty()) {
                let struct = e.getKey();
                let key = sw.registryAccess().registryOrThrow(Registries.STRUCTURE).getKey(struct);
                
                if (key.toString() == structure) {
                    return true;
                } else {
                    return false;
                }
            }
        }
    }
    return false;

}
ItemEvents.rightClicked(event => {
    event.player.tell(isInStructure(event.entity, "minecraft:pillager_outpost"))
})

#

and here is log

📎 server.log

cobalt wedgeBOT Oct 11, 2024, 9:42 AM

#

Paste version of server.log from @marsh gale

half canyon Oct 11, 2024, 4:16 PM

#

ok try this js let dimension = entity.getLevel().dimension let sw = entity.server["getLevel(net.minecraft.resources.ResourceLocation)"](dimension)

marsh gale Oct 11, 2024, 4:33 PM

#

half canyon ok try this ```js let dimension = entity.getLevel().dimension let sw = entit...

📎 server.log

cobalt wedgeBOT Oct 11, 2024, 4:33 PM

#

Paste version of server.log from @marsh gale

marsh gale Oct 11, 2024, 4:33 PM

#

let ServerLevel = Java.loadClass("net.minecraft.server.level.ServerLevel")
let ChunkStatus = Java.loadClass("net.minecraft.world.level.chunk.ChunkStatus")
let Registries = Java.loadClass("net.minecraft.core.RegistryAccess")
/**
 * 
 * @param {Internal.Entity} entity
 * @param {String} structure 
 * @returns 
 */
function isInStructure(entity, structure) {
    let pos = entity.block.pos
    let dimension = entity.getLevel().dimension
    let sw = entity.server["getLevel(net.minecraft.resources.ResourceLocation)"](dimension)
    if (sw instanceof ServerLevel) {
        let chunk = sw.getChunk(pos.x >> 4, pos.z >> 4, ChunkStatus.STRUCTURE_REFERENCES, false);
        if (chunk == null) {
            return false;
        }
        let references = chunk.getAllReferences();
        for (references of references.entrySet()) {
            let e = references
            let longs = e.getValue();
            if (!longs.isEmpty()) {
                let struct = e.getKey();
                let key = sw.registryAccess().registryOrThrow(Registries.STRUCTURE).getKey(struct);
                
                if (key.toString() == structure) {
                    return true;
                } else {
                    return false;
                }
            }
        }
    }
    return false;

}
ItemEvents.rightClicked(event => {
    event.player.tell(isInStructure(event.entity, "minecraft:pillager_outpost"))
})

half canyon Oct 11, 2024, 4:34 PM

#

alright hold on

#

ah i see what it is

half canyon Oct 11, 2024, 4:36 PM

#

marsh gale ```js let ServerLevel = Java.loadClass("net.minecraft.server.level.ServerLevel")...

try this js let dimension = entity.getLevel().dimensionKey let sw = null entity.server.getAllLevels().forEach(serverLevel => { if (serverLevel.dimensionKey != dimension) return sw = serverLevel })

marsh gale Oct 11, 2024, 4:47 PM

#

half canyon try this ```js let dimension = entity.getLevel().dimensionKey let sw = null ...

📎 server.log

cobalt wedgeBOT Oct 11, 2024, 4:47 PM

#

Paste version of server.log from @marsh gale

half canyon Oct 11, 2024, 4:47 PM

#

ok good, progress

#

this means we finally have the server level

#

lemme check the registryaccess class now

marsh gale Oct 11, 2024, 4:47 PM

#

thank you

half canyon Oct 11, 2024, 4:52 PM

#

ok change the Registries keyword at the top to this js let Registries = Java.loadClass("net.minecraft.data.BuiltinRegistries")
and halfway through the script change the registry access key line to this js let key = sw.registryAccess().registryOrThrow(Registries.STRUCTURES).getKey(struct);

#

we're gonna try going off builtinregistries for the STRUCTURES resource key instead since they moved it since 1.19

marsh gale Oct 11, 2024, 4:54 PM

#

📎 server.log

cobalt wedgeBOT Oct 11, 2024, 4:54 PM

#

Paste version of server.log from @marsh gale

marsh gale Oct 11, 2024, 4:58 PM

#

half canyon we're gonna try going off builtinregistries for the STRUCTURES resource key inst...

let ServerLevel = Java.loadClass("net.minecraft.server.level.ServerLevel")
let ChunkStatus = Java.loadClass("net.minecraft.world.level.chunk.ChunkStatus")
let Registries = Java.loadClass("net.minecraft.data.BuiltinRegistries")
/**
 * 
 * @param {Internal.Entity} entity
 * @param {String} structure 
 * @returns 
 */
function isInStructure(entity, structure) {
    let pos = entity.block.pos
    let dimension = entity.getLevel().dimensionKey
    let sw = null
    entity.server.getAllLevels().forEach(serverLevel => {
        if (serverLevel.dimensionKey != dimension) return
        sw = serverLevel
    })
    if (sw instanceof ServerLevel) {
        let chunk = sw.getChunk(pos.x >> 4, pos.z >> 4, ChunkStatus.STRUCTURE_REFERENCES, false);
        if (chunk == null) {
            return false;
        }
        let references = chunk.getAllReferences();
        for (references of references.entrySet()) {
            let e = references
            let longs = e.getValue();
            if (!longs.isEmpty()) {
                let struct = e.getKey();
                let key = sw.registryAccess().registryOrThrow(Registries.STRUCTURES).getKey(struct);
                
                if (key.toString() == structure) {
                    return true;
                } else {
                    return false;
                }
            }
        }
    }
    return false;

}
ItemEvents.rightClicked(event => {
    event.player.tell(isInStructure(event.entity, "minecraft:pillager_outpost"))
})

half canyon Oct 11, 2024, 5:02 PM

#

change this part to grab the key instead js Registries.STRUCTURES.key

#

so like js let key = sw.registryAccess().registryOrThrow(Registries.STRUCTURES.key).getKey(struct);

marsh gale Oct 11, 2024, 5:06 PM

#

📎 server.log

cobalt wedgeBOT Oct 11, 2024, 5:06 PM

#

Paste version of server.log from @marsh gale

marsh gale Oct 11, 2024, 5:07 PM

#

smae problem I guess

half canyon Oct 11, 2024, 5:08 PM

#

yeah sec

#

ok try this js let Registries = Java.loadClass("net.minecraft.core.Registry")

then halfway down like last time js let key = sw.registryAccess().registryOrThrow(Registries.STRUCTURE_REGISTRY).getKey(struct);

#

pretty sure this is the fix

#

🤞

marsh gale Oct 11, 2024, 5:11 PM

#

half canyon ok try this ```js let Registries = Java.loadClass("net.minecraft.core.Registry")...

should I replace or just add it?

half canyon Oct 11, 2024, 5:11 PM

#

replace it

marsh gale Oct 11, 2024, 5:11 PM

#

this one

half canyon Oct 11, 2024, 5:11 PM

#

so instead of this js let Registries = Java.loadClass("net.minecraft.data.BuiltinRegistries")

marsh gale Oct 11, 2024, 5:11 PM

#

yeah

#

thats work. pretty gratefull

half canyon Oct 11, 2024, 5:12 PM

#

post the final script for others before you close this

marsh gale Oct 11, 2024, 5:13 PM

#

let ServerLevel = Java.loadClass("net.minecraft.server.level.ServerLevel")
let ChunkStatus = Java.loadClass("net.minecraft.world.level.chunk.ChunkStatus")
let Registries = Java.loadClass("net.minecraft.core.Registry")
/**
 * 
 * @param {Internal.Entity} entity
 * @param {String} structure 
 * @returns 
 */
function isInStructure(entity, structure) {
    let pos = entity.block.pos
    let dimension = entity.getLevel().dimensionKey
    let sw = null
    entity.server.getAllLevels().forEach(serverLevel => {
        if (serverLevel.dimensionKey != dimension) return
        sw = serverLevel
    })
    if (sw instanceof ServerLevel) {
        let chunk = sw.getChunk(pos.x >> 4, pos.z >> 4, ChunkStatus.STRUCTURE_REFERENCES, false);
        if (chunk == null) {
            return false;
        }
        let references = chunk.getAllReferences();
        for (references of references.entrySet()) {
            let e = references
            let longs = e.getValue();
            if (!longs.isEmpty()) {
                let struct = e.getKey();
                let key = sw.registryAccess().registryOrThrow(Registries.STRUCTURE_REGISTRY).getKey(struct);
                
                if (key.toString() == structure) {
                    return true;
                } else {
                    return false;
                }
            }
        }
    }
    return false;

}

half canyon Oct 11, 2024, 5:14 PM

#

aight gonna add this to the example scripts page as the 1.19 version

marsh gale Oct 11, 2024, 5:14 PM

#

🙏

#is there any way to check if a player is in a certain structure?