block.left_click event executing twice | latcord | Page 1

light furnace Mar 25, 2024, 9:38 AM

#

Hello, the following code seems to be executing twice and I'm not sure why and how to change that to a single time. Instead of popping one pebble, the left-click interaction pops 2 at a time.

function handleLeftClick(event, expectedBlock, toolId) {
    if (event.getBlock() !== expectedBlock || event.item.id !== toolId) return;
    event.block.popItem('expcaves:stone_pebble');
    event.player.damageHeldItem(event.hand, 1);
}
onEvent('block.left_click', event => {
    handleLeftClick(event, "rankine:dark_gravel", "kubejs:wooden_rake")
    handleLeftClick(event, "minecraft:gravel", "kubejs:wooden_rake")
    handleLeftClick(event, "rankine:dark_gravel", "kubejs:steel_rake")
    handleLeftClick(event, "minecraft:gravel", "kubejs:steel_rake")
    handleLeftClick(event, "rankine:light_gravel", "kubejs:wooden_rake")
    handleLeftClick(event, "rankine:light_gravel", "kubejs:steel_rake")
});

cosmic thunderBOT Mar 25, 2024, 9:38 AM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

light furnace Mar 25, 2024, 9:38 AM

#

...also it seems to not damage the tool

#

I adapted this code from a block.right_click event script so probably the events are not as similar as I thought in terms of methods?

elfin mural Mar 25, 2024, 9:39 AM

#

it happens on client & server.

#

though idk how you got the server only stuff to happen twice...

light furnace Mar 25, 2024, 9:39 AM

#

O.o

#

so I didn't have this issue with the right-click code

elfin mural Mar 25, 2024, 9:40 AM

#

oh, hm

light furnace Mar 25, 2024, 9:42 AM

#

hang on

#

you can left-click with both hands, can you not?

#

only right-click is unique to the main-hand

#

wait no..

elfin mural Mar 25, 2024, 9:50 AM

#

oh it might also be that yes

light furnace Mar 25, 2024, 9:54 AM

#

y'know I still don't understand why there's no methods list for each event in the wiki

#

like probejs dumps a file that doesn't generate all events, you first have to use them; in this case it refuses to generate the methods for block.left_click

#

and the file is already too big, even while not having what I need

#

it has quarter of a million columns and it crashes VSC

#

so it's unusable

#

can we not just get a brief list of methods in the wiki's event list?

#

like, the events dump listed the event itself, but the globals file doesn't contain it

still crypt Mar 25, 2024, 10:07 AM

#

light furnace and the file is already too big, even while not having what I need

increase the ram usage of VSC for typescript definitions or switch to 1.20 where ProbeJS generates multiple files

still crypt Mar 25, 2024, 10:07 AM

#

light furnace y'know I still don't understand why there's no methods list for each event in th...

Feel free to contribute to the wiki for future versions

#

You also can check the github sources directly https://github.com/KubeJS-Mods/KubeJS/blob/1802/common/src/main/java/dev/latvian/mods/kubejs/block/BlockLeftClickEventJS.java

#

And yes, the event gets triggered for each hand

light furnace Mar 25, 2024, 10:10 AM

#

any way to limit triggering to main-hand?

still crypt Mar 25, 2024, 10:12 AM

#

the hand is private ... idk why lol.

light furnace Mar 25, 2024, 10:13 AM

#

..so wait, no matter what, any and all block.left_click interactions trigger twice?

still crypt Mar 25, 2024, 10:14 AM

#

if(event.player.mainHandItem.equals(event.item)) {}

or

if(event.player.mainHandItem == event.item) {}

could do it

#

would go with first one

light furnace Mar 25, 2024, 10:28 AM

#

onEvent('block.left_click', event => {
    if (event.player.mainHandItem.equals(event.item)) {
        if (event.getBlock() !== "minecraft:gravel" || event.item.id !== "kubejs:steel_rake") return;
        event.block.popItem('expcaves:stone_pebble');
        event.player.damageHeldItem(event.hand, 1);
    }
}

#

something like this?

#

nah it still pops 2.

still crypt Mar 25, 2024, 11:40 AM

#

can you console log the item

bold flicker Mar 25, 2024, 11:45 AM

#

to give a quick update on some support on another server, right click has been figured out (it was main hand off hand running for both) but it seems 1.18 doesnt have a method to distinguish which hand the left click event is running on. But yeah printing the item only returns the main hand item twice

#

my current cursed af solution i was about to suggest is giving the player a stage on the first event trigger, then removing it on the next kekw

light furnace Mar 25, 2024, 11:48 AM

#

function handleLeftClick(event, expectedBlock, toolId) {
    if (event.getBlock() !== expectedBlock || event.item.id !== toolId) return;
    event.block.popItem('expcaves:stone_pebble');
    event.server.tell(event.getItem());
    //event.player.damageHeldItem(event.hand, 1);
}
onEvent('block.left_click', event => {
    handleLeftClick(event, "rankine:dark_gravel", "kubejs:wooden_rake")
    handleLeftClick(event, "minecraft:gravel", "kubejs:wooden_rake")
    handleLeftClick(event, "rankine:dark_gravel", "kubejs:steel_rake")
    handleLeftClick(event, "minecraft:gravel", "kubejs:steel_rake")
    handleLeftClick(event, "rankine:light_gravel", "kubejs:wooden_rake")
    handleLeftClick(event, "rankine:light_gravel", "kubejs:steel_rake")
});

so this is the code that I have currently; commented out the damageHeldItem line as it doesn't work in this event (it worked for the right_click one) so perhaps you could assist with the correct method for the left_click

also included the log output in the codeblock.

#

that being this

#

ignore the existing damage values on the item, those were from testing the right-click

still crypt Mar 25, 2024, 11:48 AM

#

But this code does not have the mainhand check...

light furnace Mar 25, 2024, 11:49 AM

#

that didn't work

#

let me include it again but it didn't work

still crypt Mar 25, 2024, 11:49 AM

#

have you tried to log the items inside the if etc?

bold flicker Mar 25, 2024, 11:49 AM

#

wouldnt the item be in main hand for both event triggers? still triggering it twice?

still crypt Mar 25, 2024, 11:49 AM

#

When the event is fired with the offhand, the item should be difference than the mainhand

#

The main event would be triggered twice yes

bold flicker Mar 25, 2024, 11:51 AM

#

still crypt When the event is fired with the offhand, the item should be difference than the...

i thought so too but the logs werent supporting that, see the pic above aomegablobsweats

#

almost leads me to believe its not firing for off hand main hand and something else is going on

light furnace Mar 25, 2024, 11:52 AM

#

function handleLeftClick(event, expectedBlock, toolId) {
    if(event.player.mainHandItem.equals(event.item)) {
        if (event.getBlock() !== expectedBlock || event.item.id !== toolId) return;
        event.block.popItem('expcaves:stone_pebble');
        event.server.tell(event.getItem());
        //event.player.damageHeldItem(event.hand, 1);
}}
onEvent('block.left_click', event => {
    handleLeftClick(event, "rankine:dark_gravel", "kubejs:wooden_rake")
    handleLeftClick(event, "minecraft:gravel", "kubejs:wooden_rake")
    handleLeftClick(event, "rankine:dark_gravel", "kubejs:steel_rake")
    handleLeftClick(event, "minecraft:gravel", "kubejs:steel_rake")
    handleLeftClick(event, "rankine:light_gravel", "kubejs:wooden_rake")
    handleLeftClick(event, "rankine:light_gravel", "kubejs:steel_rake")
});

#

this has same behavior, same log output, no errors in log

bold flicker Mar 25, 2024, 11:59 AM

#

BigEyes is it triggering once for pressing down left click and once for lifting up right click?

light furnace Mar 25, 2024, 11:59 AM

#

what

#

oh

#

lmfao

bold flicker Mar 25, 2024, 12:00 PM

#

was able to finally reproduce in 1.20

still crypt Mar 25, 2024, 12:00 PM

#

interesting lol

bold flicker Mar 25, 2024, 12:05 PM

#

rip they actually spotted it in 1.19 back in august but nothing has been done: <#1145432143347060756 message>. Time for some hacky workarounds lmao

#

BlockEvents.leftClicked(event => {
    if(event.block !== "minecraft:sandstone" || event.item !== "minecraft:diamond_sword") return
    if(event.player.stages.has("cooling_down")) return

    event.player.stages.add("cooling_down")
    /* do stuff */

    event.server.scheduleInTicks(20, callback => {
        event.player.stages.remove("cooling_down")
    })
})

heres some 1.20 code you can adapt, idk 1.18 syntax. Essentially what im doing is cancelling the event if they're calling this event again within 20 ticks of a successful left click. Should fix your problem of damaging items spamming the left click event too

light furnace Mar 25, 2024, 12:30 PM

#

this worked, thank you;
last issue would be getting the item's durability down

#

damageHeldItem worked for right_click, doesn't work for left_click, clearly there's a different method for it or once again a workaround is necessary

light furnace Mar 25, 2024, 2:12 PM

#

this was fixed

#

it occured to me that instead of event.player.damageHeldItem(event.hand, 1) I could do event.player.damageHeldItem(MAIN_HAND, 1)

#

and that works.

#

thanks for the help everyone

#block.left_click event executing twice