#AlmostUnified warning on multiple preffered tags
137 messages · Page 1 of 1 (latest)
Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!
why are you posting this in kjs discord xd
This is not the Discord server for any mod or modpack itself.
This server is for LatvianModder's mods. For mod/modpack questions, look for their Discord server, or ask in https://discord.gg/moddedmc
Only if they tell you it isn't their issue, come back here.
I agree with the question above
Whatever
It means that there is an item that has two tags that are configured to be unify tags.
wtf LOL I just woke up
AU doesn't know which tag to pick to unify the item
It is not, yea. It only exposes a utility binding for it.
You can fix this by removing the sheets tag from the unify json config. But in case there are items that have the sheets tag but not the plates tag, they won't be unified.
You can work around this tho by using the tag ownership feature.
interesting
It allows you to convert a specific tag to another one https://github.com/AlmostReliable/almostunified/wiki/Unification-Config#tag-ownerships
Usually used when mods can't decide on a conventional tag format.
https://discord.com/invite/ThFnwZCyYY
Here is an invite unless if you have run out of server slots
Next step would be to insult the mod author who decided to tag their items with a sheets tag.
"tagOwnerships": {
"forge:plates/invar": [
"forge:sheets/invar"
]
}
so would be like this?
yes but you still have to remove the sheets tag from the unify tag list
or it won't work
what about mod pack dev error cuz he doesn't understand his tools correctly? 

Did you create the sheets tag yourself?
lol
Sheets is just a different name for plates usually. Create also named their plates sheets but still added them to the plates tag.
no, but I/we wanted sheet and plates to be interchangeable
prob someone added sheets to the list
on the config file let me see
i have never touched the AU config file
The tag ownership feature is the perfect solution then. All sheets will be accepted by the plate tag then
that is not default
yeah someone on out team added
our*
so, remove sheet from that and add on ownership, will test that
yep
can also be reloaded
What the feature does is it adds all items from the sheet tag to the plate tag and then replaces every occurence of that tag in recipes.
GTCEU doesn't tag its plates with the sheet tag 
that may be a bug in AU then
yea I may be stupid
eww tfc really tags their stuff as sheets instead of plates
err, someone did this on our script
yeah cuz plate is not a thing in tfc
so it is a job for modpack dev if he want to unify or not
well, for the problem I had, removing the sheet from the tag solved the original issue, the ownership stuff was "already" made via scripts
that explains a lot, so it is not an issue in AU lol
and since the KJS tag event runs before the unification, it will convert them back 
so it looks like it is not needed
The ownership stuff is not done in scripts
The ownership system replaces the occurence of the tags in recipes with the owner tag.
Yeah, I see that. It's not the same as the tag ownership feature tho
There is more to it
hmm
But it doesn't matter because plate is the default tag on GTCEU
oh I think I can see now, with ownership it also would replace on the output and individual items, not only where it is tagged as such
no

Let's say you want to unify tag:a and tag:b manually because they cover similar items but are a different tag because some modders couldn't decide on a tag convention.
What most people would do is to add all items of tag:b to tag:a so every recipe that accepts tag:a as an input would also accept all items from tag:b.
The problem with that is that there are still recipes with tag:b that wouldn't accept items from tag:a. To solve this, you could also add all items from tag:a to tag:b so they essentially become the same.
Tag ownerships from AU on the other hand merge the two tags into one. So all items from tag:b are also copied to tag:a. But at the same time it replaces all occurences of tag:b in recipes to tag:a. Meaning that all recipes with any of those tags will now only accept tag:a but still allow all items because the tag got merged.
At the same time it doesn't unintentionally break any tag-dependent behavior. There are some gameplay mechanics that depend on tags. Since all items keep their original tag, they will still work.
Hm, it may have some disadvantages tho. If there is a recipe type that is not covered by AU, we can't replace the occurence of the tag. But that would be a general problem since these recipes are not being unified at all and would need to be reported.
"recipe not covered by AU" it is like those not covered by replaceInput/Output that happens in kube?
or AU have some more recipe schemas-like stuff that identifies more inputs/outputs
from other mods
Not really. AU is based on JSON transformation. We have a generic unifier that is applied on all recipe types but some recipe types use really specific keys that we don't cover by default so we have a few unifiers that are applied to specific recipe types.
Or if their JSON structure is really odd.
You can see some of them here: https://github.com/AlmostReliable/almostunified/tree/1.20.1/Common/src/main/java/com/almostreliable/unified/compat
and here are some Forge only ones: https://github.com/AlmostReliable/almostunified/tree/1.20.1/Forge/src/main/java/com/almostreliable/unified/compat
Most mods use something like "input" or result" but some mods use "input_x" or "result_A"
so for TFC, if we have the recipe schemas on kube side, it will work?
No, Almost Unified has nothing to do with KubeJS
thought you would use kubejs to expand compat
I guess AU could hook schemas if there are any present but I'd like to prevent to depend on KubeJS again. Too many frequent breaking changes, dependency issues, remapping problems.
Also it's far simpler to write a unifier than a schema because we don't need that many information
cuz you basically needs input and output key from said serializer, and don't care about other fields
?
yep
and the structure of the inputs and outputs, if they are nested, support tags etc
Do you have any idea if TFC falls into a generic unifier or needs some custom?
they use like this for input
https://terrafirmacraft.github.io/Documentation/1.20.x/data/common-types/#item-stack-ingredients
and this for output
https://terrafirmacraft.github.io/Documentation/1.20.x/data/common-types/#item-stack-providers
using stack as the key 
yea, I need to add support for it then
I'll do that tomorrow
stack is arbitrary name they chose lol
is it used somewhere?
the key stack
also
how does it work when there is other mods that share that too, for example there are TFC addons that use same recipes
like Firmalife
they use same structure
you would have to add another compat for that?
We can apply the same unifier to multiple mods. We did that for Ars Nouveau and its countless addons as well
If you can give me a list of all necessary addons so I don't forget them, it would be appreciated
Interesting that there have already been two ATM packs that use TFC and they never reported the unsupported recipe types.
hehe
and yes I'm from ATM now, and digging how it should really work
The addons that use some TFC's serializer
https://www.curseforge.com/minecraft/mc-mods/advanced-tfc-tech-unofficial
https://www.curseforge.com/minecraft/mc-mods/firmacivilization
https://www.curseforge.com/minecraft/mc-mods/firmalife
https://www.curseforge.com/minecraft/mc-mods/precision-prospecting (from our boy NotEnoughMail)
https://www.curseforge.com/minecraft/mc-mods/tfc-ambiental-second-edition
https://www.curseforge.com/minecraft/mc-mods/tfc-cast-iron-grill
https://www.curseforge.com/minecraft/mc-mods/tfc-casting-with-channels
https://www.curseforge.com/minecraft/mc-mods/tfc-thermal-deposits
https://www.curseforge.com/minecraft/mc-mods/water-flasks
https://www.curseforge.com/minecraft/mc-mods/wooden-cog
you need each modid, right?

priority is (mod id)
tfc
firmalife
tfcchannelcasting
woodencog
I will play a bit on the dev env and see IF i can make anything helpful
that's a lot of addons

I think the more annoying part would be to write tests for all of them 
I started doing something, not sure if will help 😢
ngl I have no idea what i'm doing :p
lol

Enigma also PRed some of the ars compat, it always helps. But don't be angry if I change stuff in the PR 
lol for sure i wont





?