fix ugly code | latcord | Page 1

sinful condor Feb 1, 2024, 9:30 AM

#

I think my code is ugly.
i am using kube js!!! why i make these with commends
i think there must be a way to do the same thing using only kube js
does it?
help fix my code plz

ItemEvents.entityInteracted('minecraft:wolf', event => {
    if (event.item.id != 'kubejs:test_food') return;
    event.item.count--;
    event.player.giveInHand('bone');
    event.target.playSound('entity.wolf.howl');
    event.server.runCommand(`execute as ${event.target.uuid} run say YUMMY!!!`);
    event.server.runCommand(`effect give ${event.target.uuid} minecraft:absorption 180 2`);
    event.server.runCommand(`effect give ${event.target.uuid} minecraft:strength 180 2`);
    event.server.runCommand(`effect give ${event.target.uuid} minecraft:regeneration 180 2`);
    event.server.runCommand(`effect give ${event.target.uuid} minecraft:speed 180 2`);
    event.server.runCommand(`effect give ${event.target.uuid} minecraft:health_boost 180 2`);
})

whole mantleBOT Feb 1, 2024, 9:30 AM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

violet sluice Feb 1, 2024, 9:38 AM

#

In most cases, there is no need to use runCommand. You have other better options.

normal pond Feb 1, 2024, 9:53 AM

#

try this:

const buffs = {
    'minecraft:absorption': {duration: 180,amplifier: 2},
    'minecraft:strength': { duration: 180, amplifier: 2},
    'minecraft:regeneration': { duration: 180, amplifier: 2},
    'minecraft:speed': { duration: 180, amplifier: 2},
    'minecraft:health_boost': { duration: 180, amplifier: 2}
}
ItemEvents.entityInteracted('minecraft:wolf', event => {
    const { player, target, item, server } = event;
    if (item.id != 'kubejs:test_food') return;
    item.count--;
    player.giveInHand('minecraft:bone');
    target.playSound('entity.wolf.howl');
    target.tell('Yummy!!!')
    
    Object.values(buffs).forEach(buff => {
        target.potionEffects.add(buff, buff.duration, buff.amplifier)
    })
    
})```

sinful condor Feb 1, 2024, 9:56 AM

#

thanks

whole mantleBOT Feb 1, 2024, 9:57 AM

#

whole mantle Once your ticket has been resolved, please close it with </ticket close:10547715...

Ticket re-opened!

sinful condor Feb 1, 2024, 10:00 AM

#

wait
it didn't work

normal pond Feb 1, 2024, 10:22 AM

#

what didnt?

tepid kernelBOT Feb 1, 2024, 10:22 AM

#

You can find your KubeJS server log in /minecraft/logs/kubejs/server.log.
If you are on 1.18 or below it will be called server.txt.
Please send it if asked, as it contains helpful information.

normal pond Feb 1, 2024, 10:23 AM

#

i assume it didn't output the potioneffects

#

Object.entries(buffs).forEach(([key, buff]) => {
    target.potionEffects.add(key, buff.duration, buff.amplifier)
})```

violet sluice Feb 1, 2024, 10:36 AM

#

const buffs = {
  "minecraft:absorption": { duration: 180, amplifier: 2 },
  "minecraft:strength": { duration: 180, amplifier: 2 },
  "minecraft:regeneration": { duration: 180, amplifier: 2 },
  "minecraft:speed": { duration: 180, amplifier: 2 },
  "minecraft:health_boost": { duration: 180, amplifier: 2 },
};
ItemEvents.entityInteracted("minecraft:wolf", (event) => {
  const { player, target, item, server } = event;
  if (item.id !== "kubejs:test_food") return;

  item.count--;
  player.giveInHand("minecraft:bone");
  target.playSound("entity.wolf.howl");
  
  server.runCommandSilent(`execute as ${target.stringUuid} say YUMMY!!!`)

  Object.entries(buffs).forEach(([buff, data]) => {
    target.potionEffects.add(buff, data.duration, data.amplifier);
  });
});

normal pond Feb 1, 2024, 10:39 AM

#

oh; yea, entity.tell would only tell it to the entity eDerpy
wouldn't a player.tell suffice? as i assume you don't need to output the yummy to all players
if you do, you could also use
server.tell

public void tell(Component message) {
    getMinecraftServer().sendMessage(message, Util.NIL_UUID);

    for (var player : getMinecraftServer().getPlayerList().getPlayers()) {
        player.sendMessage(message, Util.NIL_UUID);
    }
}```

sinful condor Feb 1, 2024, 10:49 AM

#

idk how
but i can feed this to creeper and even ender dragon

#

#

const buffs = {
    "minecraft:absorption": { duration: 180, amplifier: 2 },
    "minecraft:strength": { duration: 180, amplifier: 2 },
    "minecraft:regeneration": { duration: 180, amplifier: 2 },
    "minecraft:speed": { duration: 180, amplifier: 2 },
    "minecraft:health_boost": { duration: 180, amplifier: 2 },
};
ItemEvents.entityInteracted("minecraft:wolf", (event) => {
    const { player, target, item, server } = event;
    if (item.id !== "kubejs:test_food") return;
    console.log(target.name)
    item.count--;
    player.giveInHand("minecraft:bone");
    target.playSound("entity.wolf.howl");

    server.runCommandSilent(`execute as ${target.uuid} run say YUMMY!!!`)

    Object.entries(buffs).forEach(([buff, data]) => {
        target.potionEffects.add(buff, data.duration, data.amplifier);
    });
});

#

log:

#

.

📎 message.txt

tepid kernelBOT Feb 1, 2024, 10:55 AM

#

Paste version of message.txt from @sinful condor

normal pond Feb 1, 2024, 11:50 AM

#

just add an entity check in your script... seems that adding it as an event argument doesn't work

if(target.type != 'minecraft:wolf') return

frigid garnet Feb 1, 2024, 10:27 PM

#

because its an item event that filter should be for items

#

so its weird that its still triggerivg

sinful condor Feb 2, 2024, 11:55 PM

#

so what's the correct code?
tell me plz

sinful condor Feb 4, 2024, 12:36 PM

#

.

#

there is still one problem

#fix ugly code