How do I change a Vanilla Rarity's color? | latcord | Page 1

eager nimbus Jan 24, 2024, 10:48 AM

#

I have this (next message) script to make new rarities, but I wanna change pre-existing ones. is that doable with kubejs?

tawdry nicheBOT Jan 24, 2024, 10:48 AM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

eager nimbus Jan 24, 2024, 10:48 AM

#

const rarityName = $Rarity.create("Name", Color.WHITE)

chrome cairn Jan 24, 2024, 10:55 AM

#

var color = $Rarity.getClass().getDeclaredField("color"); // could be also directly  $Rarity.getDeclaredField("color")
color.setAccessible(true);
color.set(Rarity.COMMON, Color.WHITE); // if color is a chatformatting, idk you have to check

#

not tested, but reflection should work on enums too

eager nimbus Jan 24, 2024, 11:26 AM

#

maneeeee,,, it ain wokr

river grail Jan 24, 2024, 11:31 AM

#

??neversay

vernal stagBOT Jan 24, 2024, 11:31 AM

#

river grail ??neversay

Never say 'it crashed', 'it errored', or 'it didn't work' without providing the full crash report, log, and scripts!

eager nimbus Jan 24, 2024, 11:35 AM

#

yea ik hold on im loading up the thjng gain

#

const $Rarity = Java.loadClass("net.minecraft.world.item.Rarity")
const rarityLegendary = $Rarity.create("Legendary", Color.GOLD)
const rarityMythical = $Rarity.create("Mythical", Color.RED)
const rarityUnknown = $Rarity.create("Unknown", Color.BLACK)


var color = $Rarity.getClass().getDeclaredField("color"); // could be also directly  $Rarity.getDeclaredField("color")
color.setAccessible(true);
color.set(Rarity.COMMON, Color.GRAY); // if color is a chatformatting, idk you have to check

// Rarity.set("COMMON", Color.GRAY); // if color is a chatformatting, idk you have to check

This is the full code

📎 message.txt

vernal stagBOT Jan 24, 2024, 11:39 AM

#

Paste version of message.txt from @eager nimbus

chrome cairn Jan 24, 2024, 11:40 AM

#

did you tried what I also wrote in the comment? $Rarity.getDeclaredField("color") ?

eager nimbus Jan 24, 2024, 11:43 AM

#

ye also gave an error i think

chrome cairn Jan 24, 2024, 11:44 AM

#

which error?

#

cmon please KekDoggo

eager nimbus Jan 24, 2024, 11:44 AM

#

1 sec

river grail Jan 24, 2024, 11:44 AM

#

eager nimbus ye also gave an error i think

??neversay heh

vernal stagBOT Jan 24, 2024, 11:44 AM

#

river grail ??neversay <:heh:504730156792021002>

Never say 'it crashed', 'it errored', or 'it didn't work' without providing the full crash report, log, and scripts!

eager nimbus Jan 24, 2024, 11:46 AM

#

??ok

#

#

📎 message.txt

vernal stagBOT Jan 24, 2024, 11:47 AM

#

Paste version of message.txt from @eager nimbus

chrome cairn Jan 24, 2024, 11:53 AM

#

Interesting. With this, the .getClass() should have worked at least hmm

#

can you do console.log(Object.keys($Rarity)) and give the the output from it?

eager nimbus Jan 24, 2024, 12:03 PM

#

chrome cairn can you do `console.log(Object.keys($Rarity))` and give the the output from it?

yop

#

wwhat does it output tho

chrome cairn Jan 24, 2024, 12:03 PM

#

nvm i got it

#

at least for fabric

#

forge has probably a patch for that hmm

eager nimbus Jan 24, 2024, 12:04 PM

#

despair

#

aw mane

#

if you figure it out let me know tho

uncut kestrel Jan 24, 2024, 12:27 PM

#

Oh classic stuff
@chrome cairn I remember I had to load Class and later use $Class.forName()
to actually have the class

chrome cairn Jan 24, 2024, 12:28 PM

#

but shouldnt load class load the class? susge

uncut kestrel Jan 24, 2024, 12:28 PM

#

exactly

#

but it doesn't

#

maybe it is is some Rhino wrapped class?

chrome cairn Jan 24, 2024, 12:30 PM

#

recipe.js#4: Failed to load Java class 'java.lang.reflect.Proxy': Class is not allowed by class filter!

#

sad

chrome cairn Jan 24, 2024, 12:30 PM

#

uncut kestrel Oh classic stuff <@341852930447638528> I remember I had to load Class and later ...

lemme try dis

#

fuck you rhino. It does not let me cast Function to UnaryOperator

uncut kestrel Jan 24, 2024, 12:32 PM

#

O.o

#

you can try a helper method

#

UtilsJS.makeFunction? or something

#

let me check

#

UtilsJS.makeFunctionProxy

chrome cairn Jan 24, 2024, 12:35 PM

#

how do I get the ScriptType?

uncut kestrel Jan 24, 2024, 12:35 PM

#

https://github.com/AllTheMods/Gravitas2/blob/cc6181a6dc93103d2b6e46a75e2f05974e2bd06b/kubejs/startup_scripts/main_startup.js#L4

#

it is an enum

#

just type

chrome cairn Jan 24, 2024, 12:35 PM

#

oh yeah I forgot

#

lol

uncut kestrel Jan 24, 2024, 12:37 PM

#

i wonder how you endup on unary stuff for this Rarity stuff pepethink

chrome cairn Jan 24, 2024, 12:38 PM

#

Cannot find function makeFunctionProxy in object class dev.latvian.mods.kubejs.util.UtilsJS. fuck u rhino

uncut kestrel Jan 24, 2024, 12:38 PM

#

the f?

#

did you miss the args?

chrome cairn Jan 24, 2024, 12:39 PM

#

Oh wait I load utilsjs via forName. Maybe now it needs loadClass :')

uncut kestrel Jan 24, 2024, 12:39 PM

#

yes, UtilsJS just do normally

#

also the class I passed as arg I also loaded normally

#

didnt use forName

chrome cairn Jan 24, 2024, 12:40 PM

#

okay now fixing ambiguous calls because of type wrapping. U remember the format I have to put it to select specific methods?

uncut kestrel Jan 24, 2024, 12:41 PM

#

grab from the error message and use

#

["what you grabbed"]

#

paste the ambiguous msg

chrome cairn Jan 24, 2024, 12:42 PM

#

function setColor(rarity, color) {
    let field = rarity.getClass().getDeclaredField("styleModifier")
    field.setAccessible(true);
    field.set(rarity, $UtilsJS.makeFunctionProxy("server", UnaryOperator, (style) => {
        return style["withColor(net.minecraft.ChatFormatting)"](color);
    }));
}

#

lets test

uncut kestrel Jan 24, 2024, 12:42 PM

#

pepethink

chrome cairn Jan 24, 2024, 12:43 PM

#

No errors but no color changes mmh

#

nvm

#

okay I made everything inside server, I should probably move it to a good client side event

uncut kestrel Jan 24, 2024, 12:47 PM

#

if nothing works you/he can just loop on the items at like, item modification event and grab the rarity of common and just set the "new" common color

chrome cairn Jan 24, 2024, 12:48 PM

#

I mean, I just modify classes directly. SHould be valid to not even use any event

#

const Rarity = Java.loadClass("net.minecraft.world.item.Rarity");
const UnaryOperator = Java.loadClass("java.util.function.UnaryOperator");
const UtilsJS = Java.loadClass("dev.latvian.mods.kubejs.util.UtilsJS");

function setColor(rarity, color) {
    let field = rarity.getClass().getDeclaredField("styleModifier")
    field.setAccessible(true);
    field.set(rarity, UtilsJS.makeFunctionProxy("client", UnaryOperator, (style) => {
        return style["withColor(net.minecraft.ChatFormatting)"](color);
    }));
}

setColor(Rarity.COMMON, Color.RED)
setColor(Rarity.UNCOMMON, Color.BLACK)
setColor(Rarity.RARE, Color.GOLD)
setColor(Rarity.EPIC, Color.BLUE)

#

just in client scripts @eager nimbus

#

ty @uncut kestrel

uncut kestrel Jan 24, 2024, 12:50 PM

#

pepepoggers

#

mad lad

chrome cairn Jan 24, 2024, 12:51 PM

#

with the style thing you can also do italic, bold etc.

eager nimbus Jan 24, 2024, 12:52 PM

#

Neat, Thank you. I will try it right now

chrome cairn Jan 24, 2024, 12:55 PM

#

#

const Rarity = Java.loadClass("net.minecraft.world.item.Rarity");
const UnaryOperator = Java.loadClass("java.util.function.UnaryOperator");
const UtilsJS = Java.loadClass("dev.latvian.mods.kubejs.util.UtilsJS");

function colorStyle(style, color) {
    return style["withColor(net.minecraft.ChatFormatting)"](color);
}

function setStyle(rarity, styleCallback) {
    let field = rarity.getClass().getDeclaredField("styleModifier")
    field.setAccessible(true);
    field.set(rarity, UtilsJS.makeFunctionProxy("client", UnaryOperator, styleCallback));
}

function setColor(rarity, color) {
    setStyle(rarity, style => colorStyle(style, color));
}

setStyle(Rarity.COMMON, (style) => colorStyle(style, Color.RED).withObfuscated(true))
setColor(Rarity.UNCOMMON, Color.BLACK)
setColor(Rarity.RARE, Color.GOLD)
setColor(Rarity.EPIC, Color.BLUE)

eager nimbus Jan 24, 2024, 1:00 PM

#

My game's crashing for some reason idk

#

📎 crash-2024-01-24_16.58.25-server.txt

vernal stagBOT Jan 24, 2024, 1:00 PM

#

Paste version of crash-2024-01-24_16.58.25-server.txt from @eager nimbus

chrome cairn Jan 24, 2024, 1:00 PM

#

how does your code looks like?

#

because u are passing an empty object somewhere

#

line 9

eager nimbus Jan 24, 2024, 1:01 PM

#

oh

#

this?

chrome cairn Jan 24, 2024, 1:01 PM

#

show the full code, or did you just copied mine without changes?

eager nimbus Jan 24, 2024, 1:01 PM

#

yeah..

#

const Rarity = Java.loadClass("net.minecraft.world.item.Rarity");
const UnaryOperator = Java.loadClass("java.util.function.UnaryOperator");
const UtilsJS = Java.loadClass("dev.latvian.mods.kubejs.util.UtilsJS");

function setColor(rarity, color) {
    let field = rarity.getClass().getDeclaredField("styleModifier")
    field.setAccessible(true);
    field.set(rarity, UtilsJS.makeFunctionProxy("client", UnaryOperator, (style) => {
        return style["withColor(net.minecraft.ChatFormatting)"](color);
    }));
}

setColor(Rarity.COMMON, Color.GRAY)
// setColor(Rarity.UNCOMMON, Color.BLACK)
// setColor(Rarity.RARE, Color.GOLD)
// setColor(Rarity.EPIC, Color.BLUE)```

chrome cairn Jan 24, 2024, 1:02 PM

#

when does it crash? and is it a client script?

eager nimbus Jan 24, 2024, 1:02 PM

#

chrome cairn when does it crash? and is it a client script?

World loading and yes

river grail Jan 24, 2024, 1:03 PM

#

I feel like it might be Color.GREY then hmmm

#

pepeshrug

chrome cairn Jan 24, 2024, 1:03 PM

#

Color exist from what I see

uncut kestrel Jan 24, 2024, 1:03 PM

#

pepethink

eager nimbus Jan 24, 2024, 1:03 PM

#

river grail I feel like it might be `Color.GREY` then <:hmmm:609911633078124558>

idk bout dat

chrome cairn Jan 24, 2024, 1:03 PM

#

oh it's GRAY

eager nimbus Jan 24, 2024, 1:03 PM

#

its written gray

#

ye

river grail Jan 24, 2024, 1:04 PM

#

nvm then heh

chrome cairn Jan 24, 2024, 1:04 PM

#

is it some UK US thing?

eager nimbus Jan 24, 2024, 1:04 PM

#

its... the one in minecraft

river grail Jan 24, 2024, 1:04 PM

#

chrome cairn is it some UK US thing?

ye, like color/colour heh

eager nimbus Jan 24, 2024, 1:04 PM

#

why do them brits gotta try to be different!!

river grail Jan 24, 2024, 1:04 PM

#

gray is in america and grey is in britain

manic lantern Jan 24, 2024, 1:05 PM

#

grei

uncut kestrel Jan 24, 2024, 1:05 PM

#

@eager nimbus kubejs version and rhino are all up to latest?

eager nimbus Jan 24, 2024, 1:05 PM

#

Yes

#

Rhino 2001.2.2-build.18+forge

KubeJS 2001.6.4-build.127+forge

chrome cairn Jan 24, 2024, 1:07 PM

#

does it work now?

eager nimbus Jan 24, 2024, 1:07 PM

#

?

#

I didn't change anything

#

It was always gray

chrome cairn Jan 24, 2024, 1:08 PM

#

oh

#

donald confuses me ASmadDannii

eager nimbus Jan 24, 2024, 1:08 PM

#

@donald stop confusing him please

chrome cairn Jan 24, 2024, 1:10 PM

#

my versions but I doubt thats the reason

river grail Jan 24, 2024, 1:10 PM

#

chrome cairn donald confuses me <:ASmadDannii:965252417170075739>

my bad hoh

manic lantern Jan 24, 2024, 1:10 PM

#

its not because he doesnt have Color class imported is it?

#

or is that a constant already in base kubejs

chrome cairn Jan 24, 2024, 1:11 PM

#

Color is bound

manic lantern Jan 24, 2024, 1:11 PM

#

fair

uncut kestrel Jan 24, 2024, 1:11 PM

#

I'm trying on my instance

chrome cairn Jan 24, 2024, 1:11 PM

#

I mean im in dev environment so I dont have obfuscation. But I doubt this is the problem too because forge does not obfs classes

#

oh wait

#

but it obfuscates fields

uncut kestrel Jan 24, 2024, 1:12 PM

#

yeah crashed too

#

when I was about to hover the item

chrome cairn Jan 24, 2024, 1:13 PM

#

uncut kestrel yeah crashed too

can u try using style.method_10977(color), then u also dont need to handle ambigthingy

#

https://linkie.shedaniel.dev/mappings?namespace=mojang&version=1.20.1&search=withColor

#

at least what I see from here

manic lantern Jan 24, 2024, 1:14 PM

#

thats what i was gonna say next too^

#

style.withColor

chrome cairn Jan 24, 2024, 1:15 PM

#

but wait², that shoul not matter because its a call through rhino. The reflection part is calling a forge field which should not be obfuscated

#

Otherwise the exception should be FieldNotFound

uncut kestrel Jan 24, 2024, 1:16 PM

#

console.printObject(style)
doing this to test

#

to see wtf is this

chrome cairn Jan 24, 2024, 1:17 PM

#

PRESS ENTER TO ENABLE THE NARRATOR

#

pls mojang

#

always heart attack

uncut kestrel Jan 24, 2024, 1:18 PM

#

 === net.minecraft.network.chat.Style ===
 = toString() =
 > {}
 = hashCode() =
 > f449711f
 
 === net.minecraft.network.chat.Style ===
 = Parent class =
 > java.lang.Object
 = Variables and Functions =
 > function equals(Object): boolean
 > function hashCode(): int
 > function m_131135_(): TextColor
 > function m_131136_(Boolean): Style
 > function m_131138_(String): Style
 > function m_131140_(ChatFormatting): Style
 > function m_131142_(ClickEvent): Style
 > function m_131144_(HoverEvent): Style
 > function m_131146_(Style): Style
 > function m_131148_(TextColor): Style
 > function m_131150_(ResourceLocation): Style
 > function m_131152_(ChatFormatting): Style
 > function m_131154_(): boolean
 > function m_131155_(Boolean): Style
 > function m_131157_(ChatFormatting): Style
 > function m_131161_(): boolean
 > function m_131162_(Boolean): Style
 > function m_131164_(ChatFormatting): Style
 > function m_131168_(): boolean
 > function m_131171_(): boolean
 > function m_131176_(): boolean
 > function m_131179_(): boolean
 > function m_131182_(): ClickEvent
 > function m_131186_(): HoverEvent
 > function m_131189_(): String
 > function m_131192_(): ResourceLocation
 > function m_178520_(int): Style
 > function m_178522_(Boolean): Style
 > function m_178524_(Boolean): Style
 > function toString(): String

chrome cairn Jan 24, 2024, 1:19 PM

#

why the heck is style {}

#

and why the fields are obfuscated

#

rhino should map them Madge

#

okay it can't even find m_131152_ in it

river grail Jan 24, 2024, 1:21 PM

#

did you expect rhino to work pepelaugh

chrome cairn Jan 24, 2024, 1:21 PM

#

am I dumb, what do i miss

#

class net.minecraft.network.chat.Style [java.lang.Class] its the correct class

#

interesting

#

style["withColor(net.minecraft.ChatFormatting)"](color); the typed call seems to be invalid here

#

style["withColor"](color); gives me back the ambig call, but using them will result into can't find NotLikeDuck

uncut kestrel Jan 24, 2024, 1:29 PM

#

TypeError: Cannot find function m_131140_(net.minecraft.ChatFormatting) in object {}.

#

rhino pls

chrome cairn Jan 24, 2024, 1:29 PM

#

also why it does cry only about the two methods, when there are more methods for color

#

~~wait is it because with this, rhino does not type wrap anymore?~~

uncut kestrel Jan 24, 2024, 1:39 PM

#

chrome cairn Jan 24, 2024, 1:39 PM

#

what was the error?

uncut kestrel Jan 24, 2024, 1:40 PM

#

Rhino ? dunno

chrome cairn Jan 24, 2024, 1:41 PM

#

but what did you change confused

uncut kestrel Jan 24, 2024, 1:41 PM

#

const Rarity = Java.loadClass("net.minecraft.world.item.Rarity");
const UnaryOperator = Java.loadClass("java.util.function.UnaryOperator");
const UtilsJS = Java.loadClass("dev.latvian.mods.kubejs.util.UtilsJS");

function setColor(rarity, color) {
    
    let field = rarity.getClass().getDeclaredField("styleModifier")
    field.setAccessible(true);
    field.set(rarity, UtilsJS.makeFunctionProxy("client", UnaryOperator, (style) => {
        let method = style.getClass().getDeclaredMethod("m_131140_", color.getClass())
        return method.invoke(style, color);
    }));
}

setColor(Rarity.COMMON, Color.GRAY)

chrome cairn Jan 24, 2024, 1:42 PM

#

yes was going to do the same. Hopefully style here is always a new style heh

#

otherwise u are changing some global stuff

#

Wrapped java.lang.NoSuchMethodException: net.minecraft.network.chat.Style.m_131140_() now it's joking

uncut kestrel Jan 24, 2024, 1:43 PM

#

😐

chrome cairn Jan 24, 2024, 1:45 PM

#

 public net.minecraft.network.chat.Style net.minecraft.network.chat.Style.m_131157_(net.minecraft.ChatFormatting) [java.lang.reflect.Method]
[14:44:04] [INFO] example.js#9: public net.minecraft.network.chat.Style net.minecraft.network.chat.Style.m_131152_(net.minecraft.ChatFormatting[]) [java.lang.reflect.Method]
public net.minecraft.network.chat.Style net.minecraft.network.chat.Style.m_131140_(net.minecraft.ChatFormatting) [java.lang.reflect.Method]

#

I wonder where the other two come from

#

ah it's applyFormat

uncut kestrel Jan 24, 2024, 1:45 PM

#

i think it was applyFormat and some others

chrome cairn Jan 24, 2024, 1:46 PM

#

applyFormat actually works

uncut kestrel Jan 24, 2024, 1:46 PM

#

no reflection bs needed?

chrome cairn Jan 24, 2024, 1:47 PM

#


function setColor(rarity, color) {
    let field = rarity.getClass().getDeclaredField("styleModifier")
    field.setAccessible(true);
    field.set(rarity, UtilsJS.makeFunctionProxy("client", UnaryOperator, (style) => {
        return style.applyFormat(color);
    }));
}
// setColor(Rarity.COMMON, Color.GRAY)

// let style = createStyle(ChatFormatting.GOLD);
setColor(Rarity.COMMON, Color.BLACK);
// setColor(Rarity.UNCOMMON, Color.BLACK)
// setColor(Rarity.RARE, Color.GOLD)
// setColor(Rarity.EPIC, Color.BLUE)

#

I would probably go with creating a new style directly and store it, instead of apply in the callback

const Rarity = Java.loadClass("net.minecraft.world.item.Rarity");
const UnaryOperator = Java.loadClass("java.util.function.UnaryOperator");
const UtilsJS = Java.loadClass("dev.latvian.mods.kubejs.util.UtilsJS");
const ChatFormatting = Java.loadClass("net.minecraft.ChatFormatting");
const Style = Java.loadClass("net.minecraft.network.chat.Style");

function setStyle(rarity, style) {
    let field = rarity.getClass().getDeclaredField("styleModifier")
    field.setAccessible(true);
    field.set(rarity, UtilsJS.makeFunctionProxy("client", UnaryOperator, ($) => {
        return style;
    }));
}


setStyle(Rarity.COMMON, Style.EMPTY.applyFormat(Color.BLUE));
setStyle(Rarity.UNCOMMON, Style.EMPTY.applyFormat(Color.GOLD).withObfuscated(true));

#

gives u a bit more freedom to directly apply more styles to it if wanted

uncut kestrel Jan 24, 2024, 1:53 PM

#

👏

eager nimbus Jan 24, 2024, 2:53 PM

#

pogy. thank you for the help

tawdry nicheBOT Jan 24, 2024, 3:33 PM

#

Ticket closed!

acoustic wigeon Feb 4, 2024, 1:35 PM

#

The startup seems to run into a roadblock when i use this script

const UnaryOperator = Java.loadClass("java.util.function.UnaryOperator");
const UtilsJS = Java.loadClass("dev.latvian.mods.kubejs.util.UtilsJS");
const Style = Java.loadClass("net.minecraft.network.chat.Style");

function setColor(rarity, color) {
    setStyle(rarity, Style.EMPTY.applyFormat(color));
}

function setStyle(rarity, style) {
    let field = rarity.getClass().getDeclaredField("styleModifier");
    field.setAccessible(true);
    field.set(
        rarity,
        UtilsJS.makeFunctionProxy("client", UnaryOperator, ($) => {
            return style;
        })
    );
}

setColor(Rarity.UNCOMMON, Color.GREEN);
setColor(Rarity.RARE, Color.BLUE);```

#

📎 message.txt

vernal stagBOT Feb 4, 2024, 1:43 PM

#

Paste version of message.txt from @acoustic wigeon

acoustic wigeon Feb 4, 2024, 1:43 PM

#

latest.log

uncut kestrel Feb 4, 2024, 1:54 PM

#

@acoustic wigeon this is client only, not startup

#

https://discord.com/channels/303440391124942858/1199714587952549959

#How do I change a Vanilla Rarity's color?