custom bow / ranged weapon | latcord | Page 1

frosty plume Dec 9, 2023, 5:09 PM

#

how would iu go about making a custom ranged weapon that uses its own ammo type, and or customise most aspects, from looking at a different post

const $bowItem = Java.loadClass('net.minecraft.world.item.BowItem')
const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')
StartupEvents.registry('item', event => {
    event.create('dart_chute', () => new $bowItem(new $ItemProperties().defaultDurability(23)))
})
```dont work, either because BowItem isnt a thing or some other random thing

warm bronzeBOT Dec 9, 2023, 5:09 PM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

sly stone Dec 9, 2023, 5:12 PM

#

what does the log say

frosty plume Dec 9, 2023, 5:19 PM

#

it crashes on startup

#

getting screenshotr

#

#

idk how i would go about creating a new item with all the same properties as a bow but with its own ammo from scratch

#

and idk how to copy an item using the above method, as it broke

idle portalBOT Dec 9, 2023, 5:25 PM

#

chiefarug

[Quote ➤](#1098163110747050055 message) this is how you do it

StartupEvents.registry('item', event => {
    const $SandPaperItem = Java.loadClass('com.simibubi.create.content.curiosities.tools.SandPaperItem')
    const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')

    event.custom('diamond_sandpaper', new $SandPaperItem(new $ItemProperties().defaultDurability(2000)))
})

You need to get the items class for the first import, which requires some code diving

sly stone Dec 9, 2023, 5:25 PM

#

wait

frosty plume Dec 9, 2023, 5:25 PM

#

thats where i got the code from in the first place

idle portalBOT Dec 9, 2023, 5:25 PM

#

aidan.com

[Quote ➤](#1149564801891192962 message) I'm getting around to learning how to use Java.loadClass and I can at least say that my brain is now some sort of sludge that was fried on the highest setting. I was able to at least get to this point by scavenging this discord for anything and I found this post #1098163110747050055 messagewhich helped me initially create the bow but I am now lost.
I know next to nothing about java

StartupEvents.registry('item', event => {
    const $BowItem = Java.loadClass(`net.minecraft.world.item.BowItem`)
    const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')

    event.custom('custom_bow', new $BowItem(new $ItemProperties().defaultDurability(500)))
})

sly stone Dec 9, 2023, 5:26 PM

#

yeah but you used it incorrectly

frosty plume Dec 9, 2023, 5:26 PM

#

ok, howso

sly stone Dec 9, 2023, 5:26 PM

#

you need to use event.custom()

#

and dont need an arrow function

#

So this

const $bowItem = Java.loadClass('net.minecraft.world.item.BowItem')
const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')
StartupEvents.registry('item', event => {
    event.custom('dart_chute', new $bowItem(new $ItemProperties().defaultDurability(23)))
})

frosty plume Dec 9, 2023, 5:27 PM

#

ah

#

lemme try

frosty plume Dec 9, 2023, 5:28 PM

#

idle portal

that still leaves modeling which i read about in the same quote post

idle portalBOT Dec 9, 2023, 5:28 PM

#

https://gnomebot.dev/assets/replyping.png

frosty plume Dec 9, 2023, 5:29 PM

#

and ammo

#

so it wont use regular arrows as that kinda defeats the purpose of a custom ranged weapon

#

item works, just with wrong ammo, no model and not in kubejs tab

#

#

but the other post had a fix for the tab thing

sleek wigeon Dec 9, 2023, 5:34 PM

#

isnt it createcustom?

midnight topaz Dec 9, 2023, 5:34 PM

#

it is

#

custom is legacy, and not recommended to use

#

you should use createCustom instead

#

heh

sleek wigeon Dec 9, 2023, 5:35 PM

#

i thought so

frosty plume Dec 9, 2023, 5:36 PM

#

legacy?

sleek wigeon Dec 9, 2023, 5:37 PM

#

in other words its outdated

frosty plume Dec 9, 2023, 5:38 PM

#

but it works?

sleek wigeon Dec 9, 2023, 5:38 PM

#

sure but how well is the real question

frosty plume Dec 9, 2023, 5:38 PM

#

changed it

#

ah ok

#

now how to prevent it using arrows and make a custom item[s] to use instead

sleek wigeon Dec 9, 2023, 5:39 PM

#

frosty plume Dec 9, 2023, 5:39 PM

#

optional poison status effect like tipped arrows

sleek wigeon Dec 9, 2023, 5:39 PM

#

mine works like a regular bow

frosty plume Dec 9, 2023, 5:40 PM

#

same

sleek wigeon Dec 9, 2023, 5:40 PM

#

const $BowItem = Java.loadClass('net.minecraft.world.item.BowItem')
const $Properties = Java.loadClass('net.minecraft.world.item.Item$Properties')
const $Tab = Java.loadClass('net.minecraft.world.item.CreativeModeTab')

let bow_props = new $Properties().tab($Tab.TAB_MISC)

let customBow

StartupEvents.registry('item', items => {
    customBow = items.createCustom("modid:custom_bow", () => new $BowItem(bow_props))
})```

#

nice

#

make sure you add it to a tab like this as well

frosty plume Dec 9, 2023, 5:40 PM

#

const $bowItem = Java.loadClass('net.minecraft.world.item.BowItem')
const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')

const $kubejs = Java.loadClass('dev.latvian.mods.kubejs.KubeJS')
StartupEvents.registry('item', event => {
    event.createCustom('dart_chute', new $bowItem(new $ItemProperties().tab($kubejs.tab).defaultDurability(23)))
})

#

its in a tab currently, firable and has the same enchants a bow does

sleek wigeon Dec 9, 2023, 5:41 PM

#

oh fr?

#

fair enough

#

so whats the issue

#

oh custom arrows? hmmm

frosty plume Dec 9, 2023, 5:41 PM

#

still need a way to:
custom ammo / prevent arrows from being used
change sound, projectile texture and model

#

yes

#

thats the main reason for this ticket

#

custom ranged weapon + ammo

#

nope

#

changing event.custom to event.createCustom breaks it

#

adding the () => back makes it work??

#

ye

#

either ```js
event.createCustom('dart_chute', () => new $bowItem(new $ItemProperties().tab($kubejs.tab).defaultDurability(23)))

or ```js
event.custom('dart_chute', new $bowItem(new $ItemProperties().tab($kubejs.tab).defaultDurability(23)))
```

sleek wigeon Dec 9, 2023, 5:50 PM

#

with createcustom you need the callback function

frosty plume Dec 9, 2023, 5:51 PM

#

alr

#

ammo how?

#

and making sure regular + tipped arrows cant be fired from it

sleek wigeon Dec 9, 2023, 5:52 PM

#

might need to extend the class to do that this way

#

which currently rhino does not do

#

lats working on a new javascript engine called ichor which can extend classes i believe

#

though im sure you could somehow mimic this in some weird way with other events

frosty plume Dec 9, 2023, 5:53 PM

#

how tho

#

am almost a complete beginner

#

to kubejs and js/java/json

sleek wigeon Dec 9, 2023, 5:54 PM

#

hmmm

#

im trying something

#

dont get your hopes up tho

frosty plume Dec 9, 2023, 6:08 PM

#

iwont [began playing a diff game]

sleek wigeon Dec 9, 2023, 6:08 PM

#

lol

frosty plume Dec 9, 2023, 6:08 PM

#

it would be neat to create a custom texture / sound for said projectile
but if ammo is the least possible i'd be happi

#

if not im gonna have to make a simpler recipe for poison arrows, just use them and model the ranged weapon / blowpipe

#

its [although not preferred] atleast an option

sleek wigeon Dec 9, 2023, 6:45 PM

#

frosty plume it would be neat to create a custom texture / sound for said projectile but if a...

ok i seemed to figure out a workaround here

#

this is a startup script going off the forge LivingGetProjectileEvent which basically changes the itemstack used depending on the item used to fire it

ForgeEvents.onEvent('net.minecraftforge.event.entity.living.LivingGetProjectileEvent', event => {
    global.projectile(event);
});
/**
 * 
 * @param {Internal.LivingGetProjectileEvent} event 
 */
global.projectile = event => {
    // Check if the entity is a living entity
    if (event.entity.living) {
        const livingEntity = event.entity;

        // Check if the projectile is being requested by a specific weapon (modify this condition as needed)
        if (event.projectileWeaponItemStack.id == 'minecraft:bow') {
            event.setProjectileItemStack('minecraft:spectral_arrow')
        }
    }
};``` you can modify anything in that global function and run /kubejs reload startup_scripts to reload it without having to restart the entire game

#

as long as youve loaded it up at least once

#

frosty plume Dec 9, 2023, 6:48 PM

#

wait so, whats this for

#

effect?

sleek wigeon Dec 9, 2023, 6:48 PM

#

you would replace 'minecraft:bow' with your custom bow name

sleek wigeon Dec 9, 2023, 6:48 PM

#

frosty plume effect?

?

#

wym whats this for

frosty plume Dec 9, 2023, 6:48 PM

#

what does this do?

sleek wigeon Dec 9, 2023, 6:48 PM

#

BigEyes

#

uh

midnight topaz Dec 9, 2023, 6:49 PM

#

despair

sleek wigeon Dec 9, 2023, 6:49 PM

#

lol hey don

midnight topaz Dec 9, 2023, 6:49 PM

#

sleek wigeon lol hey don

https://cdn.discordapp.com/emojis/1173695042632826941.gif?size=48&name=ablobwave&quality=lossless

sleek wigeon Dec 9, 2023, 6:49 PM

#

tabby you wanted to use different arrows by default with your custom bow correct?

frosty plume Dec 9, 2023, 6:49 PM

#

no

sleek wigeon Dec 9, 2023, 6:49 PM

#

whatcat

frosty plume Dec 9, 2023, 6:49 PM

#

well

#

partly

#

to use a different custom item as ammo

#

INSTEAD of arrows

sleek wigeon Dec 9, 2023, 6:49 PM

#

well yeah

#

you would then just replace 'minecraft:spectral_arrow' with your custom item

#

despair

#

thats the whole point of this

frosty plume Dec 9, 2023, 6:50 PM

#

ah ok

#

brain fog

sleek wigeon Dec 9, 2023, 6:50 PM

#

💀

#

all g

frosty plume Dec 9, 2023, 6:50 PM

#

💀 ikr

#

so this would consume said item?

#

im gonna have to test that one

sleek wigeon Dec 9, 2023, 6:55 PM

#

let me ask a question just so i understand what youre trying to do a little bit better here

#

do you want it to default to firing a custom projectile, or do you only want it to be able to fire certain projectiles(like the potato gun)

frosty plume Dec 9, 2023, 6:56 PM

#

/**
 * 
 * @param {Internal.LivingGetProjectileEvent} event 
 */
``` is this part useful?

#

-new to js- am assuming its a comment

sleek wigeon Dec 9, 2023, 6:57 PM

#

if you have probejs it supplies information on what methods are available

frosty plume Dec 9, 2023, 6:57 PM

#

ah ok

#

no probejs though ive heard of it

sleek wigeon Dec 9, 2023, 6:57 PM

#

you should def get it

#

its a lifesaver

#

??tutori

#

woops

#

??tutorial

idle portalBOT Dec 9, 2023, 6:57 PM

#

sleek wigeon ??tutorial

📼Youtube Tutorials📼

sleek wigeon Dec 9, 2023, 6:57 PM

#

watch the first one skip to 30 seconds in

midnight topaz Dec 9, 2023, 6:58 PM

#

despair

sleek wigeon Dec 9, 2023, 6:58 PM

#

it explains how to install it(45 seconds to explain)

sleek wigeon Dec 9, 2023, 6:58 PM

#

midnight topaz <:despair:996357458169692230>

dont despair me, its a useful guide

#

smugava

midnight topaz Dec 9, 2023, 6:58 PM

#

https://cdn.discordapp.com/emojis/1165651299317063700.webp?size=48&name=true&quality=lossless

#

eh, fair enough

frosty plume Dec 9, 2023, 6:59 PM

#

is useful but requires aditional programs to work

sleek wigeon Dec 9, 2023, 6:59 PM

#

you mean..

frosty plume Dec 9, 2023, 6:59 PM

#

like a non notepad++ editor

sleek wigeon Dec 9, 2023, 6:59 PM

#

youre not using vsc?

#

BigEyes

frosty plume Dec 9, 2023, 6:59 PM

#

no 💀

sleek wigeon Dec 9, 2023, 6:59 PM

#

breh

frosty plume Dec 9, 2023, 6:59 PM

#

notepad++ baby!

sleek wigeon Dec 9, 2023, 6:59 PM

#

notepad++ is so bad for js

midnight topaz Dec 9, 2023, 6:59 PM

#

breh

sleek wigeon Dec 9, 2023, 6:59 PM

#

get vsc

midnight topaz Dec 9, 2023, 6:59 PM

#

??editor

idle portalBOT Dec 9, 2023, 6:59 PM

#

midnight topaz ??editor

If you're working with KubeJS scripts, config files, or similar things, we generally recommend using an actual IDE rather than just Notepad++ and its various siblings.
In a lot of cases, it can help you find errors in your code faster and also gives you neat features like syntax highlighting, automatic formatting, etc!
We recommend Visual Studio Code, since it's lightweight(-ish) and works very well with JavaScript files out-of-the-box.

midnight topaz Dec 9, 2023, 6:59 PM

#

please

sleek wigeon Dec 9, 2023, 7:00 PM

#

sooo much better, especially if youre serious about coding

frosty plume Dec 9, 2023, 7:00 PM

#

m maybe

sleek wigeon Dec 9, 2023, 7:00 PM

#

in any case

frosty plume Dec 9, 2023, 7:00 PM

#

btw curious code question

midnight topaz Dec 9, 2023, 7:00 PM

#

pepeshrug

sleek wigeon Dec 9, 2023, 7:00 PM

#

answer this please 🥺 #1183093106384576602 message

idle portalBOT Dec 9, 2023, 7:00 PM

#

liopyu

[Quote ➤](#1183093106384576602 message) do you want it to default to firing a custom projectile, or do you only want it to be able to fire certain projectiles(like the potato gun)

frosty plume Dec 9, 2023, 7:00 PM

#

ForgeEvents.onEvent('net.minecraftforge.event.entity.living.LivingGetProjectileEvent', event => {
    global.projectile(event);
});

#

and below that

global.projectile = event => {

sleek wigeon Dec 9, 2023, 7:01 PM

#

yeah thats a global function usage

frosty plume Dec 9, 2023, 7:01 PM

#

is there a reason the bottom doesnt go in the top function

sleek wigeon Dec 9, 2023, 7:01 PM

#

yes

frosty plume Dec 9, 2023, 7:01 PM

#

ellaborate [ifyouwant]

sleek wigeon Dec 9, 2023, 7:01 PM

#

ForgeEvents.onEvent('net.minecraftforge.event.entity.living.LivingGetProjectileEvent', event => {
   //anything in here requires a full game restart
});```

#

global functions can be used across script types however and lets us run /kubejs reload startup_scripts

midnight topaz Dec 9, 2023, 7:02 PM

#

that's called "the global trick"™️

sleek wigeon Dec 9, 2023, 7:03 PM

#

she still hasnt answered my question btw

#

angerysad

midnight topaz Dec 9, 2023, 7:03 PM

#

skilletissue

idle portalBOT Dec 9, 2023, 7:03 PM

#

liopyu

[Quote ➤](#1183093106384576602 message) do you want it to default to firing a custom projectile, or do you only want it to be able to fire certain projectiles(like the potato gun)

midnight topaz Dec 9, 2023, 7:03 PM

#

@frosty plume heh

sleek wigeon Dec 9, 2023, 7:04 PM

#

we'll see if it works a third time

#

heh

midnight topaz Dec 9, 2023, 7:04 PM

#

as they say, third time's the charm

#

https://cdn.discordapp.com/emojis/983755127116677180.webp?size=48&name=clueless~2&quality=lossless

sleek wigeon Dec 9, 2023, 7:04 PM

#

lmao

frosty plume Dec 9, 2023, 7:04 PM

#

sleek wigeon she still hasnt answered my question btw

whos he?

sleek wigeon Dec 9, 2023, 7:04 PM

#

you

#

breh

midnight topaz Dec 9, 2023, 7:05 PM

#

despair

sleek wigeon Dec 9, 2023, 7:05 PM

#

https://cdn.discordapp.com/emojis/657638114126331915.gif?size=48&name=blobbongoree&quality=lossless

frosty plume Dec 9, 2023, 7:05 PM

#

sleek wigeon do you want it to default to firing a custom projectile, *or* do you only want i...

default to firing custom projectiles

#

sorry did not see that

frosty plume Dec 9, 2023, 7:05 PM

#

sleek wigeon *you*

=checkmate= check bio

sleek wigeon Dec 9, 2023, 7:05 PM

#

ah ok then this script is the right one then

#

oh mb

#

she*

#

hmm as for consuming the itemstack ill look into that

frosty plume Dec 9, 2023, 7:06 PM

#

now if this only fires spectral arrows, the script works and thats another one off the list

sleek wigeon Dec 9, 2023, 7:06 PM

#

should

frosty plume Dec 9, 2023, 7:06 PM

#

consuming itemstack yeah but also

#

if i were to make a custom arrow item

sleek wigeon Dec 9, 2023, 7:06 PM

#

shouldnt matter if you have other projectiles in your inv

frosty plume Dec 9, 2023, 7:06 PM

#

how make the projectile texture

sleek wigeon Dec 9, 2023, 7:06 PM

#

you probably want to do it the same way vanilla did

frosty plume Dec 9, 2023, 7:07 PM

#

its able to use a regular arrow

#

const $bowItem = Java.loadClass('net.minecraft.world.item.BowItem')
const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')

const $kubejs = Java.loadClass('dev.latvian.mods.kubejs.KubeJS')
StartupEvents.registry('item', event => {
    event.createCustom('dart_chute', () => new $bowItem(new $ItemProperties().tab($kubejs.tab).defaultDurability(23)))
})

ForgeEvents.onEvent('net.minecraftforge.event.entity.living.LivingGetProjectileEvent', event => {
    global.projectile(event)
})
global.projectile = event => {
    if (event.entity.living) {
        const livingEntity = event.entity
        if (event.projectileWeaponItemStack.id == 'kubejs: dart_chute') {
            event.setProjectileItemStack('minecraft:spectral_arrow')
        }
    }
}

#

the whole script thusfar

#

wait

#

theres a space in there

sleek wigeon Dec 9, 2023, 7:08 PM

#

was gonna say lol

#

frosty plume Dec 9, 2023, 7:08 PM

#

ok so it fires spectral arrows

#

but even without them in your inventory

sleek wigeon Dec 9, 2023, 7:08 PM

#

yeah

frosty plume Dec 9, 2023, 7:08 PM

#

which is a "consume item" problem

sleek wigeon Dec 9, 2023, 7:08 PM

#

like i said imma look into it

frosty plume Dec 9, 2023, 7:08 PM

#

as it dont check if theres such items in your inventory, let alone deduct from a stack

#

alr

#

been a great help sofar man

sleek wigeon Dec 9, 2023, 7:09 PM

#

np lol, always glad to figure things like this out

frosty plume Dec 9, 2023, 7:09 PM

#

ok problem

#

im gonna send log

#

but sometimes it doesnt fire an arrow

#

and spamming it crashes the ganme

#

📎 message.txt

idle portalBOT Dec 9, 2023, 7:12 PM

#

Paste version of message.txt from @frosty plume

frosty plume Dec 9, 2023, 7:12 PM

#

2100 lines of error

#

somewhere something went bad

sleek wigeon Dec 9, 2023, 7:24 PM

#

hmm

#

yeah im working on the null check as well on my end

frosty plume Dec 9, 2023, 7:27 PM

#

im gonna try get the model to work

#

just with some random bamboo textures to see IF the model changes / renders

#

if that somehow all works, making a custom texture but thats longtermgoals[tm]

#

this sadly doesnt work according to that website

{
  "parent": "minecraft:item/generated",
  "textures": {
    "layer0": "kubejs:item/bamboo_singleleaf"
  },
  "overrides": [
    {
      "predicate": {
        "pulling": 1
      },
      "model": "kubejs:item/dart_chute_pulling_0"
    },
    {
      "predicate": {
        "pulling": 1,
        "pull": 0.65
      },
      "model": "kubejs:item/dart_chute_pulling_0"
    },
    {
      "predicate": {
        "pulling": 1,
        "pull": 0.9
      },
      "model": "kubejs:item/dart_chute_pulling_0"
    }
  ]
}

#

pulling_0 being

{
  "parent": "kubejs:item/dart_chute",
  "textures": {
    "layer0": "kubejs:item/dart_chute_pulling_0"
  }
}

#

https://misode.github.io/assets/model/?version=1.19&preset=item/bow

sleek wigeon Dec 9, 2023, 8:36 PM

#

you need the other 3 .json models as well

#

oh you have them hmmm

frosty plume Dec 9, 2023, 8:50 PM

#

they're the same file

#

just to test if it would even change but it doesnt

#

doesnt display missing texture so thats not a fault of texture misnaming

#

it just shows the first texture but pulling it back

#

gonna try it with just 1

#

the crashing issue is purely when underdrawing the bow i think

#

issue might be in the item creation not being able to bear overrides

#

"some"

frosty plume Dec 9, 2023, 9:05 PM

#

frosty plume issue might be in the item creation not being able to bear overrides

for the model / texture

sleek wigeon Dec 9, 2023, 9:26 PM

#

i fixed that null bug btw

#

im working on getting it to only shoot the specified item, gonna be a sec but i think it's possible

frosty plume Dec 9, 2023, 9:57 PM

#

nice

#

the model is also borke

#

some other person also had this problem

sleek wigeon Dec 9, 2023, 10:01 PM

#

got it working

#

though theres a couple things to note

kind cape Dec 9, 2023, 10:02 PM

#

frosty plume some other person also had this problem

think that was me, hope yall can figure it out lol

sleek wigeon Dec 9, 2023, 10:05 PM

#

ForgeEvents.onEvent('net.minecraftforge.event.entity.living.LivingGetProjectileEvent', event => {
    global.projectile(event);
});

/**
 * @param {Internal.LivingGetProjectileEvent} event 
 */
global.projectile = event => {
    if (event.entity.level.clientSide) return
    if (event.projectileWeaponItemStack.id != 'minecraft:bow') return
    event.setProjectileItemStack('minecraft:spectral_arrow')

};
ForgeEvents.onEvent('net.minecraftforge.event.entity.player.ArrowLooseEvent', event => {
    global.shoot(event)
})
/**
 * 
 * @param {Internal.ArrowLooseEvent} event 
 */
global.shoot = event => {
    if (event.entity.level.clientSide) return
    if (event.bow.id != 'minecraft:bow') return
    let entity = event.entity;
    let maxSlots = 41;
    for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
        let slot = entity.getSlot(slotIndex);
        let itemStack = slot.get();

        if (!itemStack.count <= 0) {
            // Access the item ID directly
            let itemId = itemStack.id;
            if (itemId === 'minecraft:spectral_arrow') {
                itemStack.count--
                return
            }
        }

    }
    event.setCanceled(true)
}```
Here we have to utilize 2 forge events, one to change the projectile of your weapon to your custom projectile item (here we're using spectral arrows and a normal bow as examples) and one to cancel the arrowloose forge event if you dont have the right arrow in your inventory. The arrow loose event also acts as a trigger to decrease the stack of the arrow by 1 when the bow shoots

#

this is one big startup script

frosty plume Dec 9, 2023, 10:11 PM

#

gonna test it

sleek wigeon Dec 9, 2023, 10:12 PM

#

the only issue is client desync when you have normal arrows in your inventory and it cancels the event
though im sure you could maybe open up another ticket and someone will know how to fix that

#

makes it look like youre using normal arrows when youre not, til you update it in your inv that is

frosty plume Dec 9, 2023, 10:14 PM

#

hmm odd

sleek wigeon Dec 9, 2023, 10:20 PM

#

is it working for you?

frosty plume Dec 9, 2023, 10:20 PM

#

testing now

sleek wigeon Dec 9, 2023, 10:20 PM

#

besides the client desync?

frosty plume Dec 9, 2023, 10:20 PM

#

i hope that client desync gets fixers

#

does the client desync occur when having 0 items?

sleek wigeon Dec 9, 2023, 10:21 PM

#

aight, i would open up a ticket labeled "client desync in forge event" for someone who knows about the subject to see

#

nah

frosty plume Dec 9, 2023, 10:21 PM

#

alr

#

if this works

#

-new ticket
-texture+model for arrow entity and just item
-the model for bow / texture being broken

#

there is probably a way around that issue

#

as in creative mode it also deletes items and wont work if none are present

#

it also draws the bow

#

maybe somehow check for item BEFORE it even draws bow

#

that sounds very dumb

#

E

#

idont think this is a "next ticket" issue

#

it ties in with it not working in creative mode

#

nope it straight up crashed with normal arrows

#

in creative mode

#

📎 latest.log

idle portalBOT Dec 9, 2023, 10:26 PM

#

Paste version of latest.log from @frosty plume

frosty plume Dec 9, 2023, 10:26 PM

#

const $bowItem = Java.loadClass('net.minecraft.world.item.BowItem')
const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')

const $kubejs = Java.loadClass('dev.latvian.mods.kubejs.KubeJS')
StartupEvents.registry('item', event => {
    event.createCustom('dart_chute', () => new $bowItem(new $ItemProperties().tab($kubejs.tab).defaultDurability(23)))
})

ForgeEvents.onEvent('net.minecraftforge.event.entity.living.LivingGetProjectileEvent', event => {
    global.projectile(event)
});    ForgeEvents.onEvent('net.minecraftforge.event.entity.player.ArrowLooseEvent', event => {
        global.shoot(event)
})
global.projectile = event => {
    if (event.entity.level.clientSide) return
    if (event.projectileWeaponItemStack.id == 'kubejs:dart_chute') return
    event.setProjectileItemStack('minecraft:spectral_arrow')
}
global.shoot = event => {
    if (event.entity.level.clientSide) return
    if (event.bow.id != 'kubejs:dart_chute') return
    
    let entity = event.entity
    let maxSlots = 41
    for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
        let slot = entity.getSlot(slotIndex)
        let itemStack = slot.get()

        if (!itemStack.count <= 0) {
            // Access the item ID directly
            let itemId = itemStack.id
            if (itemId === 'minecraft:spectral_arrow') {
                itemStack.count--
                return
            }
        }

    }
    event.setCanceled(true)
}

#

dont mind the cursed arranging of code

#

its very late, thanks forall the help thusfar

#

if you find a fix, tomorrow, somewhere next week
for it crashing / not working in ccreative / just straight up ghost animation with no arrows

#

lmk

sleek wigeon Dec 9, 2023, 10:36 PM

#

hmm odd its not crashing for me, ill have to test your code out tomorrow

#

did you restart the full game?

sleek wigeon Dec 9, 2023, 10:38 PM

#

frosty plume ```js const $bowItem = Java.loadClass('net.minecraft.world.item.BowItem') const ...

you need to restart the full game at least once to update it to read from the new forge event

sleek wigeon Dec 9, 2023, 10:47 PM

#

frosty plume it also draws the bow

to avoid this just put this in both a client event script as well as a server event script ```js
ItemEvents.rightClicked('minecraft:bow', event => {

let entity = event.entity;
let maxSlots = 41;
for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
    let slot = entity.getSlot(slotIndex);
    let itemStack = slot.get();

    if (!itemStack.count <= 0) {
        // Access the item ID directly
        let itemId = itemStack.id;
        if (itemId === 'minecraft:spectral_arrow') {
            return
        }
    }
}
event.cancel()

})``` this prevents it from drawing the bow if you dont have the correct arrows in your inventory

#

the desync issue is probably just as simple(though i must be missing something here)

frosty plume Dec 9, 2023, 11:22 PM

#

sleek wigeon you need to restart the full game at least once to update it to read from the ne...

am already restarting game between every one

sleek wigeon Dec 9, 2023, 11:23 PM

#

ah kk

#

ill test your script out tomorrow then

sleek wigeon Dec 10, 2023, 12:51 PM

#

@frosty plume your first issue i see is youre returning if youre weilding the correct weapon which is not what i sent up there

#

make sure you copy this exactly and only change the 'minecraft:bow' to your kubejs:dart_chute#1183093106384576602 message

idle portalBOT Dec 10, 2023, 12:51 PM

#

liopyu

[Quote ➤](#1183093106384576602 message) ```js
ForgeEvents.onEvent('net.minecraftforge.event.entity.living.LivingGetProjectileEvent', event => {
global.projectile(event);
});

/**

@param {Internal.LivingGetProjectileEvent} event
*/
global.projectile = event => {
if (event.entity.level.clientSide) return
if (event.projectileWeaponItemStack.id != 'minecraft:bow') return
event.setProjectileItemStack('minecraft:spectral_arrow')

};
ForgeEvents.onEvent('net.minecraftforge.event.entity.player.ArrowLooseEvent', event => {
global.shoot(event)
})
/**
*

@param {Internal.ArrowLooseEvent} event
*/
global.shoot = event => {
if (event.entity.level.clientSide) return
if (event.bow.id != 'minecraft:bow') return
let entity = event.entity;
let maxSlots = 41;
for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
let slot = entity.getSlot(slotIndex);
let itemStack = slot.get();
```
 if (!itemStack.count <= 0) {
     // Access the item ID directly
     let itemId = itemStack.id;
     if (itemId === 'minecraft:spectral_arrow') {
         itemStack.count--
         return
     }
 }
```
}
event.setCanceled(true)
}```
Here we have to utilize 2 forge events, one to change the projectile of your weapon to your custom projectile item (here we're using spectral arrows and a normal bow as examples) and one to cancel the arrowloose forge event if you dont have the right arrow in your inventory. The arrow loose event also acts as a trigger to decrease the stack of the arrow by 1 when the bow shoots

sleek wigeon Dec 10, 2023, 12:52 PM

#

if (event.projectileWeaponItemStack.id != 'kubejs:dart_chute') return``` should be this

frosty plume Dec 10, 2023, 12:52 PM

#

Will change once fully awake

sleek wigeon Dec 10, 2023, 12:52 PM

#

ill keep testing to see if i can recreate the crash

#

np

#

doesnt look like im crashing thus far

#

hmmm

frosty plume Dec 10, 2023, 12:56 PM

#

Nice

#

Does adding it to both server AND startup fix visual bug?

#

Like firing both when no arrow And wrong arrow

#

Drawing*

sleek wigeon Dec 10, 2023, 12:59 PM

#

you mean the forge events?

#

or the ItemEvents.rightclicked

frosty plume Dec 10, 2023, 2:52 PM

#

ok am back, what exactly needs to be re-added to the file

#

i fixed the != part

sleek wigeon Dec 10, 2023, 2:55 PM

#

sleek wigeon to avoid this just put this in both a client event script as well as a server ev...

start from here

#

you wanna add that script to both client and server

#

this will prevent you from pulling the bow if you dont have the correct ammo

#

then it should work

frosty plume Dec 10, 2023, 2:55 PM

#

sleek wigeon to avoid this just put this in both a client event script as well as a server ev...

you said this

#

holup

#

client and sertver?

#

theres startup and server

sleek wigeon Dec 10, 2023, 2:56 PM

#

mhmm

#

uh

#

no

frosty plume Dec 10, 2023, 2:56 PM

#

oh holdon

sleek wigeon Dec 10, 2023, 2:56 PM

#

you see this item right click event?

idle portalBOT Dec 10, 2023, 2:56 PM

#

liopyu

[Quote ➤](#1183093106384576602 message) to avoid this just put this in both a client event script as well as a server event script ```js
ItemEvents.rightClicked('minecraft:bow', event => {

let entity = event.entity;
let maxSlots = 41;
for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
    let slot = entity.getSlot(slotIndex);
    let itemStack = slot.get();

    if (!itemStack.count <= 0) {
        // Access the item ID directly
        let itemId = itemStack.id;
        if (itemId === 'minecraft:spectral_arrow') {
            return
        }
    }
}
event.cancel()

})``` this prevents it from drawing the bow if you dont have the correct arrows in your inventory

frosty plume Dec 10, 2023, 2:56 PM

#

i see

sleek wigeon Dec 10, 2023, 2:57 PM

#

put it in kubejs>client_scripts and kubejs>server_scripts

frosty plume Dec 10, 2023, 2:57 PM

#

ah ok

#

wil ldo

sleek wigeon Dec 10, 2023, 2:57 PM

#

if it crashes again lemme know and send your latest.logs

#

it wasnt crashing for me as far as i've tested

frosty plume Dec 10, 2023, 3:00 PM

#

ItemEvents.rightClicked('kubejs:dart_chute', event => {

    let entity = event.entity
    let maxSlots = 41
    for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
        let slot = entity.getSlot(slotIndex)
        let itemStack = slot.get()

        if (!itemStack.count <= 0) {
            let itemId = itemStack.id
            if (itemId === 'minecraft:spectral_arrow') {
                return
            }
        }
    }
    event.cancel()
})

``` both client and server have this

#

startup has:

#

const $bowItem = Java.loadClass('net.minecraft.world.item.BowItem')
const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')

const $kubejs = Java.loadClass('dev.latvian.mods.kubejs.KubeJS')
StartupEvents.registry('item', event => {
    event.createCustom('dart_chute', () => new $bowItem(new $ItemProperties().tab($kubejs.tab).defaultDurability(23)))
})

ForgeEvents.onEvent('net.minecraftforge.event.entity.living.LivingGetProjectileEvent', event => {
    global.projectile(event)
});    ForgeEvents.onEvent('net.minecraftforge.event.entity.player.ArrowLooseEvent', event => {
        global.shoot(event)
})
global.projectile = event => {
    if (event.entity.level.clientSide) return
    if (event.projectileWeaponItemStack.id != 'kubejs:dart_chute') return
    event.setProjectileItemStack('minecraft:spectral_arrow')
}
global.shoot = event => {
    if (event.entity.level.clientSide) return
    if (event.bow.id != 'kubejs:dart_chute') return
    
    let entity = event.entity
    let maxSlots = 41
    for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
        let slot = entity.getSlot(slotIndex)
        let itemStack = slot.get()

        if (!itemStack.count <= 0) {
            // Access the item ID directly
            let itemId = itemStack.id
            if (itemId === 'minecraft:spectral_arrow') {
                itemStack.count--
                return
            }
        }

    }
    event.setCanceled(true)
}

sleek wigeon Dec 10, 2023, 3:03 PM

#

yes

#

keep in mind if you do end up registering a new type of arrow item it has to be a projectile

#

i tried firing non projectiles and it didnt work

frosty plume Dec 10, 2023, 3:06 PM

#

ok so

#

it didnt fire without arrows / regular arrows

#

BUT

#

when firing the spectral arrow it crashed, getting log now

sleek wigeon Dec 10, 2023, 3:06 PM

#

kk

frosty plume Dec 10, 2023, 3:06 PM

#

📎 latest.log

idle portalBOT Dec 10, 2023, 3:06 PM

#

Paste version of latest.log from @frosty plume

frosty plume Dec 10, 2023, 3:06 PM

#

i posted scripts above

sleek wigeon Dec 10, 2023, 3:06 PM

#

also send the startup_scripts log

frosty plume Dec 10, 2023, 3:07 PM

#

frosty plume ```js ItemEvents.rightClicked('kubejs:dart_chute', event => { let entity = ...

these are server/client

#

startup scripts log whats that

sleek wigeon Dec 10, 2023, 3:07 PM

#

??kjslogs

idle portalBOT Dec 10, 2023, 3:07 PM

#

sleek wigeon ??kjslogs

You can find your KubeJS startup log in /minecraft/logs/kubejs/startup.log.
If you are on 1.18 or below it will be called startup.txt.
Please send it if asked, as it contains helpful information.

frosty plume Dec 10, 2023, 3:07 PM

#

📎 startup.log

idle portalBOT Dec 10, 2023, 3:07 PM

#

Paste version of startup.log from @frosty plume

sleek wigeon Dec 10, 2023, 3:07 PM

#

also whats your kubejs version

#

nvm it says there

frosty plume Dec 10, 2023, 3:08 PM

#

ìt doenst draw atleast

#

thats a start

#

like what you're doing atm is 100% what i needed

sleek wigeon Dec 10, 2023, 3:08 PM

#

hmmm

frosty plume Dec 10, 2023, 3:08 PM

#

bow + custom ammo

#

just it crashes and model file is borke

sleek wigeon Dec 10, 2023, 3:08 PM

#

the weird part is it doesnt crash for me

frosty plume Dec 10, 2023, 3:08 PM

#

nasa

sleek wigeon Dec 10, 2023, 3:08 PM

#

lemme copy this exact code again

frosty plume Dec 10, 2023, 3:08 PM

#

yes

#

the top one was in server/client, bottom in startup

#

i defo mistyped something in startup or smthn

sleek wigeon Dec 10, 2023, 3:11 PM

#

while im doing that i want you to update kubejs

frosty plume Dec 10, 2023, 3:11 PM

#

ue

#

to which version

sleek wigeon Dec 10, 2023, 3:11 PM

#

latest

#

build 45

frosty plume Dec 10, 2023, 3:11 PM

#

send download

#

or link

sleek wigeon Dec 10, 2023, 3:12 PM

#

you use curseforge?

frosty plume Dec 10, 2023, 3:12 PM

#

no

sleek wigeon Dec 10, 2023, 3:12 PM

#

what you use

frosty plume Dec 10, 2023, 3:12 PM

#

idk

sleek wigeon Dec 10, 2023, 3:12 PM

#

nothing?

frosty plume Dec 10, 2023, 3:12 PM

#

any link people send

sleek wigeon Dec 10, 2023, 3:12 PM

#

i mean your launcher

#

you just have a forge profile setup or something?

frosty plume Dec 10, 2023, 3:12 PM

#

prismlauncher for this

sleek wigeon Dec 10, 2023, 3:12 PM

#

ah

frosty plume Dec 10, 2023, 3:12 PM

#

someone sent a pack

#

like as a zip sent a whole pack

sleek wigeon Dec 10, 2023, 3:13 PM

#

youre not able to update on prism?

frosty plume Dec 10, 2023, 3:13 PM

#

i feel like the issue is the startup script

#

idk

#

which version is latest kubejs

sleek wigeon Dec 10, 2023, 3:13 PM

#

https://www.curseforge.com/minecraft/mc-mods/kubejs/files/4931520

frosty plume Dec 10, 2023, 3:13 PM

#

ima go search on modrinth

sleek wigeon Dec 10, 2023, 3:13 PM

#

or that

#

we're about to find out

frosty plume Dec 10, 2023, 3:14 PM

#

wha

#

type the version you want me to download

#

am skeptical of curseforge

sleek wigeon Dec 10, 2023, 3:14 PM

#

breh

#

build 45

#

1.19

#

kubejs

frosty plume Dec 10, 2023, 3:14 PM

#

am on 1.19.2 btw

sleek wigeon Dec 10, 2023, 3:15 PM

#

same here

#

also its not crashing for me

#

im gonna try your build which is 42

frosty plume Dec 10, 2023, 3:15 PM

#

kk

sleek wigeon Dec 10, 2023, 3:15 PM

#

also you dont need to use curse launcher just download

frosty plume Dec 10, 2023, 3:15 PM

#

check startup script i sent to be sure

sleek wigeon Dec 10, 2023, 3:15 PM

#

sleek wigeon Dec 10, 2023, 3:15 PM

#

frosty plume check startup script i sent to be sure

i literally copy+ pasted

frosty plume Dec 10, 2023, 3:15 PM

#

kk

sleek wigeon Dec 10, 2023, 3:17 PM

#

testing build 42 now

frosty plume Dec 10, 2023, 3:17 PM

#

installed, updated

sleek wigeon Dec 10, 2023, 3:17 PM

#

if it works here then what i suggest you start a new prism instance with only kubejs installed and try the script there

frosty plume Dec 10, 2023, 3:17 PM

#

i hope some of my older scripts dont break

#

or the person who made the pack's scripts

frosty plume Dec 10, 2023, 3:17 PM

#

sleek wigeon if it works here then what i suggest you start a new prism instance with only ku...

na

#

too much work for a script

sleek wigeon Dec 10, 2023, 3:17 PM

#

frosty plume i hope some of my older scripts dont break

if they do then they should be changed anyways

frosty plume Dec 10, 2023, 3:18 PM

#

i can send some over if any are broken

#

they should all work

#

the bow without items: dont fire = correct

sleek wigeon Dec 10, 2023, 3:18 PM

#

works for me

#

then i would temporarily remove every other script besides this one

frosty plume Dec 10, 2023, 3:19 PM

#

with arrow doesnt fire either which is good

#

btw maybe add a creative mode exception

#

since yk

sleek wigeon Dec 10, 2023, 3:19 PM

#

and make sure that script is the only thing kubejs is running and test it

#

works fine in creative too

frosty plume Dec 10, 2023, 3:19 PM

#

yep same

#

in /cr it consumes the arrow tho

#

script works perfectly now thanks

sleek wigeon Dec 10, 2023, 3:19 PM

#

whats your inventory look like

#

oh its working now?

#

maybe the update worked then

frosty plume Dec 10, 2023, 3:20 PM

#

this is on a world with many a test items / prior playthrough

#

before firing:

#

#

after firing once

#

#

bow is next to the arrow the little green thing

#

it works

sleek wigeon Dec 10, 2023, 3:21 PM

#

nice

frosty plume Dec 10, 2023, 3:21 PM

#

just gotta add creative mode unlimited arrow exception

#

then only projectile item / texture and model files

#

and everything will work

#

nice

#

oh no

#

i found an error

#

spamming it breaks it

sleek wigeon Dec 10, 2023, 3:21 PM

#

oh?

#

ah lemme test

frosty plume Dec 10, 2023, 3:21 PM

#

like the arrows dont fire

#

click 0.1 seconds and dont hold it

sleek wigeon Dec 10, 2023, 3:21 PM

#

oh

frosty plume Dec 10, 2023, 3:21 PM

#

just tap oit

sleek wigeon Dec 10, 2023, 3:22 PM

#

ah good catch

#

lemme fix that

frosty plume Dec 10, 2023, 3:22 PM

#

so there needs to be a checkk to see IIF it actually fired

#

THEN delete the item

#

and a creative mode bypass of no need for an item

#

if creative mode (just heccing fire)

#

how do i mark a new item as projectile btw

#

lemme check documentation

sleek wigeon Dec 10, 2023, 3:25 PM

#

Startup Script:

global.shoot = event => {
    if (event.entity.level.clientSide) return
    if (event.bow.id != 'kubejs:dart_chute') return

    let entity = event.entity
    let maxSlots = 41
    for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
        let slot = entity.getSlot(slotIndex)
        let itemStack = slot.get()

        if (!itemStack.count <= 0) {
            // Access the item ID directly
            let itemId = itemStack.id
            if (itemId === 'minecraft:spectral_arrow') {
                if (event.charge <= 2 || event.entity.isCreative()) return
                itemStack.count--
                return
            }
        }

    }
    if (!entity.isCreative()) {
        event.setCanceled(true)
    }
}```
Server/Client Script:```js
ItemEvents.rightClicked('kubejs:dart_chute', event => {

    let entity = event.entity
    let maxSlots = 41
    for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
        let slot = entity.getSlot(slotIndex)
        let itemStack = slot.get()

        if (!itemStack.count <= 0) {
            let itemId = itemStack.id
            if (itemId === 'minecraft:spectral_arrow') {
                return
            }
        }
    }
    if (!event.player.isCreative()) {
        event.cancel()
    }
})```

#

change your global to that

sleek wigeon Dec 10, 2023, 3:26 PM

#

frosty plume so there needs to be a checkk to see IIF it actually fired

the main thing here is we're returning if the charge is smaller or equal to 2

frosty plume Dec 10, 2023, 3:26 PM

#

that doesnt accomodate creative mode but does for the glitch?

sleek wigeon Dec 10, 2023, 3:26 PM

#

anything 3 and above fires the arrow

#

yea

#

as for the creative thing thats easy, sec

#

if (event.charge <= 2 || event.entity.isCreative()) return```

#

there edited it

#

shouldnt consume in creative anymore

frosty plume Dec 10, 2023, 3:29 PM

#

wait

sleek wigeon Dec 10, 2023, 3:29 PM

#

?

frosty plume Dec 10, 2023, 3:29 PM

#

you are makiing it not consume in creative

sleek wigeon Dec 10, 2023, 3:29 PM

#

yeah thats what you wanted right

frosty plume Dec 10, 2023, 3:29 PM

#

but does it still then fire an arrow if NONE are present

sleek wigeon Dec 10, 2023, 3:29 PM

#

hmm

#

true, sec

frosty plume Dec 10, 2023, 3:29 PM

#

should being in creative bypass the entire check for arrows

sleek wigeon Dec 10, 2023, 3:29 PM

#

ill add that as well

frosty plume Dec 10, 2023, 3:30 PM

#

im not good at js

#

but ive got logical thinking and pickyness from here to 東京

frosty plume Dec 10, 2023, 3:30 PM

#

sleek wigeon Startup Script: ```js global.shoot = event => { if (event.entity.level.clien...

it crashed using

#

this

#

📎 latest.log

idle portalBOT Dec 10, 2023, 3:30 PM

#

Paste version of latest.log from @frosty plume

frosty plume Dec 10, 2023, 3:31 PM

#

📎 startup.log

idle portalBOT Dec 10, 2023, 3:31 PM

#

Paste version of startup.log from @frosty plume

frosty plume Dec 10, 2023, 3:31 PM

#

when in /cr and firing it crashed

#

you sure the extra line makes sure it doenst consume arrow, AND doesnt fire / cancels event

sleek wigeon Dec 10, 2023, 3:32 PM

#

whats /cr

frosty plume Dec 10, 2023, 3:32 PM

#

/gamemode creative

#

creative mode

#

i use shorthand /cr

sleek wigeon Dec 10, 2023, 3:32 PM

#

ah

#

hmm sec

sleek wigeon Dec 10, 2023, 3:34 PM

#

sleek wigeon Startup Script: ```js global.shoot = event => { if (event.entity.level.clien...

ok edited, try it now

#

also are you running /kubejs reload startup_scripts /kubejs reload client_scripts and /kubejs reload server_scripts?

#

or you just /reload ing?

frosty plume Dec 10, 2023, 3:35 PM

#

im hard resetting minecraft

#

quit game, restartup

#

to make sure its fresh each time

#

ive got a new beefy computer, with beefy ram and cpu

sleek wigeon Dec 10, 2023, 3:36 PM

#

uh

frosty plume Dec 10, 2023, 3:36 PM

#

modded loads in 20 seconds

sleek wigeon Dec 10, 2023, 3:36 PM

#

you dont have to do that

#

since we're running a global event you can just do /kubejs reload startup_scripts

#

instant reload

frosty plume Dec 10, 2023, 3:36 PM

#

im using to having to wait 15 minutes for minecraft to load fully when modded

#

20 seconds is fine

sleek wigeon Dec 10, 2023, 3:36 PM

#

1 second is better tho

frosty plume Dec 10, 2023, 3:37 PM

#

but it didnt work before tho

sleek wigeon Dec 10, 2023, 3:37 PM

#

what

#

/kubejs reload startup_scripts?

frosty plume Dec 10, 2023, 3:37 PM

#

like i once did /kubejs reload startuo_scripts

#

and it just didnt work

sleek wigeon Dec 10, 2023, 3:37 PM

#

well now itll work

frosty plume Dec 10, 2023, 3:37 PM

#

ok so

sleek wigeon Dec 10, 2023, 3:37 PM

#

it wont work if you dont use global functions

frosty plume Dec 10, 2023, 3:37 PM

#

in creative it behaves exacly like a bow

sleek wigeon Dec 10, 2023, 3:37 PM

#

oh hmm

frosty plume Dec 10, 2023, 3:38 PM

#

doesnt consume arrows (good

sleek wigeon Dec 10, 2023, 3:38 PM

#

what

frosty plume Dec 10, 2023, 3:38 PM

#

can be spammed without breaking

#

in creative gamemode 0

sleek wigeon Dec 10, 2023, 3:38 PM

#

how many scripts do you have in your kubejs folders

#

a lot?

frosty plume Dec 10, 2023, 3:38 PM

#

wait

#

it works well

#

lemme test /survival

sleek wigeon Dec 10, 2023, 3:38 PM

#

im lost

frosty plume Dec 10, 2023, 3:39 PM

#

in creative mode: doesnt consume arrows for 0 reason, can be spammed without crashing, works fine

#

in survival mode: ddoesnt crash either, doesnt consume arrows when spammed, works fine

#

it works perfectly

#

doesnt draw back when no arrows are present

#

it just works perfectly now

#

now the projectile

#

gonna try find which tag im suppose to give it

#

handy website im using: https://wiki.latvian.dev/books/kubejs/page/custom-items

Custom Items | latvian.dev Wiki

The custom item event is a startup event.
Custom items are created in a startup script. They cannot...

sleek wigeon Dec 10, 2023, 3:44 PM

#

frosty plume it just works perfectly now

🪄

frosty plume Dec 10, 2023, 3:44 PM

#

gonna close this for now and make a new ticket for the projectile/model files being borke

#

but im gonna paste the code for anyone wanting a bow

#

const $bowItem = Java.loadClass('net.minecraft.world.item.BowItem')
const $ItemProperties = Java.loadClass('net.minecraft.world.item.Item$Properties')

const $kubejs = Java.loadClass('dev.latvian.mods.kubejs.KubeJS')
StartupEvents.registry('item', event => {
    event.createCustom('YOUR_BOW_HERE', () => new $bowItem(new $ItemProperties().tab($kubejs.tab).defaultDurability(23)))
})


ForgeEvents.onEvent('net.minecraftforge.event.entity.living.LivingGetProjectileEvent', event => {
    global.projectile(event)});    ForgeEvents.onEvent('net.minecraftforge.event.entity.player.ArrowLooseEvent', event => {
        global.shoot(event)
})

global.projectile = event => {
    if (event.entity.level.clientSide) return
    if (event.projectileWeaponItemStack.id != 'kubejs:YOUR_BOW_HERE') return
    event.setProjectileItemStack('minecraft:spectral_arrow')
}

global.shoot = event => {
    if (event.entity.level.clientSide) return
    if (event.bow.id != 'kubejs:YOUR_BOW_HERE') return

    let entity = event.entity
    let maxSlots = 41
    for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
        let slot = entity.getSlot(slotIndex)
        let itemStack = slot.get()

        if (!itemStack.count <= 0) {
            let itemId = itemStack.id
            if (itemId === 'minecraft:spectral_arrow') {
                if (event.charge <= 2 || event.entity.isCreative()) return
                itemStack.count--
                return
            }
        }

    }
    if (!entity.isCreative()) {
        event.setCanceled(true)
    }
}

#

in startup events

#

ItemEvents.rightClicked('kubejs:YOUR_BOW_HERE', event => {

    let entity = event.entity
    let maxSlots = 41
    for (let slotIndex = 0; slotIndex < maxSlots; slotIndex++) {
        let slot = entity.getSlot(slotIndex)
        let itemStack = slot.get()

        if (!itemStack.count <= 0) {
            let itemId = itemStack.id
            if (itemId === 'minecraft:spectral_arrow') {
                return
            }
        }
    }
    if (!event.player.isCreative()) {
        event.cancel()
    }
})

#

in both client and server events

#

scripts*

#

this makes a bow-like item, that fires spectral arrows [replace with custom projectile if aplicable], fires infinitely in creative mode, can be spammed without client-server desync

#

and doesnt use regular arrows accidentally

#custom bow / ranged weapon

📼Youtube Tutorials📼