custom item use

[stark nebula]

im trying to make a gravescroll that will stretch when used and upon finishing use will run the event to teleport the player to their last death, the death teleport part is easy enough but for some reason its not being used on right click and obviously is not running any events either. i posted an example of what im basically going for

StartupEvents.registry('item', event => {
    event.create('grave_scroll').displayName('Grave Scroll')
    .useAnimation("bow")
    .useDuration((itemstack) => 64)
    .finishUsing((Utils, entity, player, event) => {
        if (entity.player) 
        {
        global.gravescroll(entity)
        }
    })
})
global.gravescroll = (entity) => {
    Utils.server.runCommand(`tell ${entity.player.name} Hi`)
}```this is the script so far

[high plaza]

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

[stark nebula]

ignore my music playing in the background, had no idea it recorded that too

[honest plover]

what is that formatting

[stark nebula]

lmao

i whipped it up quickly

there

[elfin depot]

=.=

[honest plover]

...

[stark nebula]

???

[gritty lichen]

[honest plover]

[elfin depot]

where did you get this .finishUsing((Utils, entity, player, event) => {

[honest plover]

good question

[stark nebula]

sec ill link the discord thing

[honest plover]

[gritty lichen]

pietheniceguy

[Quote ➤](#1127292324897112135 message) All you needed to do was swap event with entity.

.finishUsing((Utils, entity, player) => {
if (entity.player) 
{
Utils.server.runCommand(`tell ${entity.player.name} Hi`)
}})

liopyu quoted · Jul 8, 2023, 8:41 PM

[elfin depot]

@FunctionalInterface
public interface FinishUsingCallback {
    ItemStack finishUsingItem(ItemStack itemStack, Level level, LivingEntity livingEntity);
}

[stark nebula]

ah

[honest plover]

as probejs says

[elfin depot]

https://github1s.com/KubeJS-Mods/KubeJS/blob/1902/common/src/main/java/dev/latvian/mods/kubejs/item/ItemBuilder.java#L483

[stark nebula]

it doesnt even use tho

i right click and no animation

[honest plover]

use what?

[elfin depot]

probably because the callback is wrong

[stark nebula]

the item

ah

[elfin depot]

so its erroring somewhere

[stark nebula]

lemme fix it sec

so itd be something like this then? js .finishUsing((entity, server) => { if (entity.player) { global.gravescroll(entity) } })
then in the global js global.gravescroll = (entity) => { Utils.server.runCommand(`tell ${entity.player.name} Hi`) } would utils still be fine?

[honest plover]

no

[stark nebula]

oh

[honest plover]

use what lexxie sent

[stark nebula]

level?

[elfin depot]

you need all 3 args

[stark nebula]

ah

[honest plover]

StartupEvents.registry('item', e => {
    e.create('grave_scroll').displayName('Grave Scroll')
    .useAnimation("bow")
    .useDuration((itemstack) => 64)
    .finishUsing((itemstack, level, entity) => {
        if (entity.player) global.gravescroll(entity)
    })
})

global.gravescroll = entity => {
    Utils.server.runCommand(`tell ${entity.player.name} Hi`)
}

[elfin depot]

.finishUsing((item, level, entity) => {
  if (entity.player) global.gravescroll(entity)
})

[honest plover]

I was faster

[elfin depot]

nu

[honest plover]

huh

[elfin depot]

ez proof

[stark nebula]

.finishUsing((level, entity, itemstack) => {
        if (entity.player) 
        {
        global.gravescroll(entity)
        }
    })```

[honest plover]

DISCORD

[elfin depot]

photoshop

[honest plover]

no...

[elfin depot]

https://tenor.com/view/caught-in-4k-caught-in4k-chungus-gif-19840038

[honest plover]

also no

I'm not using photoshop

it's just discord being

[stark nebula]

oh i didnt even see your messages rofl

[honest plover]

[elfin depot]

wha

[stark nebula]

yall so fast

[stark nebula]

ill try this one sec

[honest plover]

[elfin depot]

[honest plover]

https://tenor.com/view/mcqueen-gif-25874245

yes, this is an r154 reference

[elfin depot]

a what now

[honest plover]

...

you don't play antimatter dimensions

[stark nebula]

lmao

[elfin depot]

havent in months

[stark nebula]

still nothing lol

[elfin depot]

show logussy

[stark nebula]

kk

[gritty lichen]

Paste version of startup.log, latest.log from @stark nebula

[elfin depot]

weird

[stark nebula]

yea

me spamming right click

i saw somewhere someone had .use but that was 1.18 i think

nvm its 1.19 too i guess

[elfin depot]

just to make sure youre not doing derpy things, did you restart the game since the changes?

[stark nebula]

yea

[honest plover]

try adding a console.log before the runCommand

just for debugging

[stark nebula]

aight

[honest plover]

they don't have to

[elfin depot]

they do

[honest plover]

they're exploiting using the global trick

[elfin depot]

??

[honest plover]

[elfin depot]

no

wat

[honest plover]

[elfin depot]

the changes werent to global

they were to the registry

[stark nebula]

imma do this ```js
StartupEvents.registry('item', e => {
e.create('grave_scroll').displayName('Grave Scroll')
.useAnimation("bow")
.useDuration((itemstack) => 64)
.finishUsing((itemstack, level, entity) => {
console.log('this runs before the global')
if (entity.player) global.gravescroll(entity)
})
})

global.gravescroll = entity => {
console.log('this runs before the command')
Utils.server.runCommand(tell ${entity.player.name} Hi)
console.log('this runs after the command')
}```

[elfin depot]

id try commenting out the finishUsing completely

[stark nebula]

and do full restart

ah ok

[elfin depot]

and see if the animation starts

[stark nebula]

ill do that first then

[elfin depot]

start with the basics first

[stark nebula]

wow its the same deal with this js StartupEvents.registry('item', e => { e.create('grave_scroll').displayName('Grave Scroll') .useAnimation("bow") .useDuration((itemstack) => 64) /*.finishUsing((itemstack, level, entity) => { console.log('this runs before the global') if (entity.player) global.gravescroll(entity) })*/ })

do i comment out useduration next then?

[elfin depot]

dunno the rest look normal to me

[stark nebula]

right

yeah its the same deal with useduration commented so useanimation just isnt working i guess

unless

i need .use

[elfin depot]

any chance you can put everything back, rightclick, then show server log

[stark nebula]

bet

[elfin depot]

im clueless at this point

[stark nebula]

lol same

[honest plover]

oh

my bad

[stark nebula]

i did find this ```js
.use((level, player, hand) => true)

oooo

wait i started it up with .use and it uses now

tho the event didnt fire

sec ill post logs

wait the console logs fired

[gritty lichen]

Paste version of latest.log from @stark nebula

[stark nebula]

says no player was found in the command event i think

StartupEvents.registry('item', e => {
    e.create('grave_scroll').displayName('Grave Scroll')
    .use((level, player, hand) => true)
    .useAnimation("bow")
    .useDuration((itemstack) => 64)
    .finishUsing((itemstack, level, entity) => {
        console.log('this runs before the global')
        if (entity.player) global.gravescroll(entity)
    })
})

global.gravescroll = entity => {
    console.log('this runs before the command')
    Utils.server.runCommand(`tell ${entity.player.name} Hi`)
    console.log('this runs after the command')
}```

[elfin depot]

its entity.name most likely

entity.player is not a thing, its a boolean

[stark nebula]

ah

[elfin depot]

its beans for entity.isPlayer()

[stark nebula]

its wierd also because when i do this /tell Liopyu hi in game it errors in logs

aight ill try it

[elfin depot]

might be entity.username not sure

[stark nebula]

btw heres the log for when it errors

[gritty lichen]

Paste version of latest.log from @stark nebula

[stark nebula]

yeah probably username

[gritty lichen]

Paste version of crash-2023-10-16_13.53.52-server.txt from @stark nebula

[stark nebula]

global.gravescroll = entity => {
    console.log('this runs before the command')
    server.runCommand(`tell ${entity.username} Hi`)
    console.log('this runs after the command')
}```

ill try name i guess

[elfin depot]

you deleted Utils.

[stark nebula]

yeah

and thats the problem lol sec

[elfin depot]

do you have server defined anywhere

[stark nebula]

oh duh

i was going off of the old script

[elfin depot]

[honest plover]

[stark nebula]

i did this for better testing purposes js global.gravescroll = entity => { console.log('this runs before the command') Utils.server.runCommand(`scoreboard players add ${entity.name} test 1`) console.log('this runs after the command') }

trying username next i guess

oo yeah its username

though it runs the command twice

progress tho lets goo lmao

how do i not make it consume the whole item stack?

cause every time i use it it takes the whole thing lol

oh im not returning the itemstack maybe?

[elfin depot]

ye

you need to return

[stark nebula]

ah

where do i return it?

[elfin depot]

use

i think

[stark nebula]

ah ok ill try that

wait how do i do that lol

[elfin depot]

or actually finishusing maybe

im reading the thing

[stark nebula]

ah ok

[elfin depot]

return item thats it

[stark nebula]

ooo kk sec

ty

[elfin depot]

https://github1s.com/KubeJS-Mods/KubeJS/blob/1902/common/src/main/java/dev/latvian/mods/kubejs/item/ItemBuilder.java#L421-L423

pretty sure its finishusing

[stark nebula]

so like this? js StartupEvents.registry('item', e => { e.create('grave_scroll').displayName('Grave Scroll') .use((level, player, hand) => true) .useAnimation("bow") .useDuration((itemstack) => 64) .finishUsing((itemstack, level, entity) => { console.log('this runs before the global') if (entity.player) global.gravescroll(entity) return item; }) })

right

ah that crashed me

[gritty lichen]

Paste version of crash-2023-10-16_14.07.38-server.txt from @stark nebula

[elfin depot]

well itemstack in your example

:v

[stark nebula]

ahh

XD

what about this? js Object.keys(itemstack).forEach(field => { console.log(field) }); return itemstack;

[elfin depot]

tho make sure you lower the count by 1 if you want it to be used

[stark nebula]

oh nvm thats the same thing

right right

[stark nebula]

ayyy it worked tysm also thanks donald

not sure if that pinged him

[honest plover]

:DonaldHahaYes:

[stark nebula]

oh guess it did

[honest plover]

it didn't

[stark nebula]

lmao fair enough

[honest plover]

pings don't work in forums

[stark nebula]

rofl

uwu