Get source entity in LivingAttackEvent | latcord | Page 1

glacial matrix Oct 5, 2023, 12:19 AM

#

With the mixin that KubeJS does on DamageSource, which adds actual, it seems the event doesn't recognize that source has that parameter, and therefore does not run the code at all because event.source.actual is null/undefined.

const $LivingEntity = java('net.minecraft.world.entity.LivingEntity')
const $EntityDamageSource = java('net.minecraft.world.damagesource.EntityDamageSource')

global.LivingAttackEventIndicator = function (/** @type {Internal.LivingAttackEvent} */ event) {
    if (!event.source) return
    if (!event.source.actual) return
    if (!event.entity) return
    if (!event.entity.asKJS().isPlayer()) return
    if (Platform.isClientEnvironment()) return
    event.setCanceled(true)
    let entity = event.entity.asKJS()
    let source = event.source.actual.asKJS()
    source.playSound('paucal:pet.bwop', 1, 1.2)
    entity.tell('test')
    Utils.server.scheduleInTicks(2, cb => {
        entity.tell('test2')
        entity.attack(new $EntityDamageSource(event.source.toString(), source.minecraftEntity), event.amount)
    })
}
onForgeEvent('net.minecraftforge.event.entity.living.LivingAttackEvent', event => {
    global.LivingAttackEventIndicator(event)
})

My goal is to delay the attack of an entity on a player and indicate an attack before the damage goes through (therefore making PvE better).

crystal cometBOT Oct 5, 2023, 12:19 AM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

strong gazelle Oct 5, 2023, 2:31 AM

#

so what you are telling is it event.source.actual will never exists?

glacial matrix Oct 5, 2023, 2:32 AM

#

actual doesn't exist for some reason

strong gazelle Oct 5, 2023, 2:32 AM

#

can you console.log(Object.keys(event.source))

#

just to be sure?

#

also

glacial matrix Oct 5, 2023, 2:33 AM

#

i'm trying source.entity
https://linkie.shedaniel.dev/mappings?namespace=mojang&version=1.18.2&search=damagesource.entity

strong gazelle Oct 5, 2023, 2:33 AM

#

console.log(event.source.class.simpleName)

#

what actual were supposed to be?

glacial matrix Oct 5, 2023, 2:38 AM

#

[21:38:29] [Server thread/INFO] [KubeJS Startup/]: EntityDamageSource
[21:38:29] [Render thread/INFO] [KubeJS Startup/]: DamageSource

glacial matrix Oct 5, 2023, 2:41 AM

#

strong gazelle console.log(event.source.class.simpleName)

it logs this

strong gazelle Oct 5, 2023, 2:46 AM

#

and the Object.keys?

#

can you link the mixin?

#

you are talking about

glacial matrix Oct 5, 2023, 2:49 AM

#

https://github.com/KubeJS-Mods/KubeJS/blob/1802/common/src/main/java/dev/latvian/mods/kubejs/mixin/common/DamageSourceMixin.java

GitHub

KubeJS/common/src/main/java/dev/latvian/mods/kubejs/mixin/common/Da...

Contribute to KubeJS-Mods/KubeJS development by creating an account on GitHub.

#

[21:49:55] [Render thread/INFO] [KubeJS Startup/]: [magic,getClass,getPlayer,callBypassArmor,creativePlayer,getImmediate,type,setProjectile,isBypassMagic,isCreativePlayer,fire,setNoAggro,actual,isFire,noAggro,bypassInvul,setIsFall,sourcePosition,isExplosion,setMagic,getType,isMagic,immediate,isNoAggro,getSourcePosition,bypassMagic,isBypassArmor,getActual,wait,notifyAll,msgId,setScalesWithDifficulty,isProjectile,notify,foodExhaustion,bypassArmor,fall,hashCode,class,player,botania_setBypassArmor,isFall,isBypassInvul,isDamageHelmet,setIsFire,scalesWithDifficulty,callBypassInvul,damageHelmet,explosion,setExplosion,equals,localizedDeathMessage,getFoodExhaustion,callBypassMagic,toString,getLocalizedDeathMessage,projectile] [dev.latvian.mods.kubejs.util.ListJS]

#

actual is a method....

strong gazelle Oct 5, 2023, 2:50 AM

#

so it is there

glacial matrix Oct 5, 2023, 2:50 AM

#

but if i try to call event.source.actual then it crashes

#

The game crashed whilst ticking entity
Error: dev.latvian.mods.rhino.EcmaError: TypeError: Cannot convert null to an object. (startup_scripts:AttackIndicator.js#7)

#

null

strong gazelle Oct 5, 2023, 2:55 AM

#

it is not saying the method doesn't exists

#

the actual code runs, but tries to do something that is doing null

#

    public EntityJS getActualKJS() {
        return AsKJS.wrapSafe(getEntity());
    }

something here maybe null

glacial matrix Oct 5, 2023, 2:56 AM

#

line 7 is console.log(Object.keys(event.source.actual))

strong gazelle Oct 5, 2023, 2:56 AM

#

like getEntity()

#

if you filter only for EntityDamageSource is enough for you or you need DamageSource?

glacial matrix Oct 5, 2023, 2:57 AM

#

i don't need DamageSource, i could try doing that

strong gazelle Oct 5, 2023, 2:57 AM

#

so use:

#

if (event.source instanceof $EntityDamageSource){
  // runs all your code here
}

#

despair

glacial matrix Oct 5, 2023, 3:08 AM

#

const $LivingEntity = java('net.minecraft.world.entity.LivingEntity')
const $EntityDamageSource = java('net.minecraft.world.damagesource.EntityDamageSource')

global.LivingAttackEventIndicator = function (/** @type {Internal.LivingAttackEvent} */ event) {
    if (!event.source) return
    console.log(event.source.class.simpleName)
    if (event.source instanceof $EntityDamageSource) {
        console.log(`${event.source.class.simpleName}, ${console.scriptLine}`)
        if (!event.source.entity) return
        console.log(event.source.entity)
        if (!event.entity) return
        if (!event.entity.asKJS().isPlayer()) return
        if (Platform.isClientEnvironment()) return
        event.setCanceled(true)
        let entity = event.entity.asKJS()
        let source = event.source.entity.asKJS()
        source.playSound('paucal:pet.bwop', 1, 1.2)
        entity.tell('test')
        Utils.server.scheduleInTicks(10, cb => {
            entity.tell('test2')
            entity.attack(new $EntityDamageSource(event.source.toString(), source.minecraftEntity), event.amount)
        })
    }
}
onForgeEvent('net.minecraftforge.event.entity.living.LivingAttackEvent', event => {
    global.LivingAttackEventIndicator(event)
})

#

got this so far

#

it won't go past if (!event.source.entity) return

strong gazelle Oct 5, 2023, 3:09 AM

#

glacial matrix ``` [21:49:55] [Render thread/INFO] [KubeJS Startup/]: [magic,getClass,getPlayer...

is there any getEntity here? i cant ctrl+f sorry

glacial matrix Oct 5, 2023, 3:10 AM

#

that crashes the game but yes

strong gazelle Oct 5, 2023, 3:11 AM

#

are you sure? can't find looking

#

can you point?

glacial matrix Oct 5, 2023, 3:14 AM

#

#

ingame it says that it doesn't exist

[22:10:21] [Server thread/ERROR] [ne.mi.ev.EventBus/EVENTBUS]: Exception caught during firing event: TypeError: Cannot find function getEntity in object EntityDamageSource (Zombie['Zombie'/137, l='ServerLevel[fml]', x=0.04, y=77.00, z=5.85]). (startup_scripts:AttackIndicator.js#9)

strong gazelle Oct 5, 2023, 3:14 AM

#

glacial matrix ``` [21:49:55] [Render thread/INFO] [KubeJS Startup/]: [magic,getClass,getPlayer...

talking about this

glacial matrix Oct 5, 2023, 3:14 AM

#

oh

#

no it doesn't seem there is one

strong gazelle Oct 5, 2023, 3:14 AM

#

so stop trying to call

glacial matrix Oct 5, 2023, 3:15 AM

#

but that's on DamageSource, not EntityDamageSOurce

strong gazelle Oct 5, 2023, 3:15 AM

#

the mixin is on damagesource, shouldn't be there too?

glacial matrix Oct 5, 2023, 3:16 AM

#

getentity seems to hide from js

#

so i'll see if getEntityKJS() works

#

well

#

getActualKJS()

strong gazelle Oct 5, 2023, 3:16 AM

#

wait, the actual is the entity bro

#

#

what are you trying to get anyway, i'm not familiar with this event

#

what do you NEED

glacial matrix Oct 5, 2023, 3:19 AM

#

i explained it at the bottom of the post

strong gazelle Oct 5, 2023, 3:20 AM

#

why are you doing source.entity

#

and not event.entity?

glacial matrix Oct 5, 2023, 3:22 AM

#

event.entity links to the hurt entity

strong gazelle Oct 5, 2023, 3:31 AM

#

are you testing this on single player?

strong gazelle Oct 5, 2023, 3:32 AM

#

glacial matrix event.entity links to the hurt entity

so? you get player from source.player and entity from event.entity, what else you need?

glacial matrix Oct 5, 2023, 3:32 AM

#

the problem is stopping the entity's attack on the player, and yes this is on singleplayer

strong gazelle Oct 5, 2023, 3:33 AM

#

that Platform stuff is returned on single player, stop using that, that is only for dedicated server

glacial matrix Oct 5, 2023, 3:33 AM

#

hm

strong gazelle Oct 5, 2023, 3:37 AM

#

do more console.logs to check where it is stoping

glacial matrix Oct 5, 2023, 6:19 AM

#

it seems event.source.actual works but i just was having issues with the platform stuff

#

attack indicators are working as intended

#Get source entity in LivingAttackEvent