Well, I don't really know how to explain this bug because it's rather strange. When a script to modify a recipe is active, almost all the recipes of Valhelsia Furniture are modified. In the screenshots, the sticks are missing.
#Valhelsia Furniture conflict
drifting jewel
torpid wadiBOT
Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!
potent steppe
??code
frank steppeBOT
??code
🗒️**Send the code!**🗒️
You may have an issue with a KubeJS script and you explain it to the best of your ability yet without the actual code in question we have very little to go off of in trying to assist you.
drifting jewel
It's 100% certain that this didn't come from the code, because even a script to remove recipes changes those of Valhelsia Furniture
frank steppeBOT
Paste version of shapeless.js, remove.js, replace.js, shaped.js from @drifting jewel
drifting jewel
Yep, just making a fresh logs
potent steppe
sure
drifting jewel
frank steppeBOT
Paste version of server.log, latest.log from @drifting jewel
potent steppe
hmm
@low kettle is this a bug?
not to just ping you out of no-where
its looking to be a similar bug we've encountered earlier where the recipe event will break things in 1.20
im not entirely sure if this matters but this is what one of the json recipes look like js { "type": "minecraft:crafting_shaped", "category": "misc", "group": "valhelsia_furniture:chair", "key": { "#": { "item": "minecraft:acacia_planks" }, "X": { "fabric_value": { "item": "minecraft:stick" }, "forge_value": { "tag": "forge:rods/wooden" } } }, "pattern": [ "X ", "###", "X X" ], "result": { "count": 2, "item": "valhelsia_furniture:acacia_chair" }, "show_notification": true }
apparently its the same as this issue here #1147323205518893177 message
potent steppe
@drifting jewel so ive seemed to got it working by replacing the above recipe json format with one that does not contain a tag in it
what i think is going on is that tags are loading in after recipes in this case so to combat this you may want to change the mod's forge version recipes to be something like this js { "type": "minecraft:crafting_shaped", "category": "misc", "group": "valhelsia_furniture:chair", "key": { "#": { "item": "minecraft:acacia_planks" }, "X": { "item": "minecraft:stick" } }, "pattern": [ "X ", "###", "X X" ], "result": { "count": 2, "item": "valhelsia_furniture:acacia_chair" }, "show_notification": true }
i did it via datapack ofcourse, just using the minecraft item with no forge:rods/wooden tag
which you could also do instead of changing the actual mod itself
low kettle
I just noticed you have
"X": {
"fabric_value": {
"item": "minecraft:stick"
},
"forge_value": {
"tag": "forge:rods/wooden"
}
}
the heck is that syntax
low kettle
what i think is going on is that tags are loading in after recipes in this case ...
I think you're missing a } after X stick
steady island
I just noticed you have
```json
"X": {
"fabric_value": {
"item": "...
Stal's way of handling Forge + Fabric ingredient differences without making multiple recipes or new tags.
potent steppe
I think you're missing a `}` after X stick
yeah i edited it in here
thanks for catching that
low kettle
https://github.com/ValhelsiaTeam/Valhelsia-Core/blob/6e095f9857a8c454a69b89187c5...
Wow that is bad 
purely because this could have been done without mixin
wraith sequoia
prob kubejs mixin + valhelsia mixin incompatibility?
potent steppe
this was a thing with spelunkery too but with right clicking on a grindstone(not entirely sure its the same fix tho)
but yeah removing the tag from the json seems to fix it i guess lmao
wraith sequoia
anyway, he can fix this by redoing those recipes
potent steppe
exactly
wraith sequoia
so it wont fill the mixin check
potent steppe
this is good to know for future issues as well
noble sigil
We now changed our custom ingredient implementation to use the register methods provided by the loaders.
https://github.com/ValhelsiaTeam/Valhelsia-Core/commit/04a673a92e5b9577317090325cdd864798b7dd34
However, the issue still persists. Is there anything else we'd need to do to become compatible with kubejs?
ingredients in the recipe jsons now have the type tag
{
"type": "minecraft:crafting_shaped",
"category": "misc",
"group": "valhelsia_furniture:upholstered_birch_stool",
"key": {
"#": {
"item": "minecraft:birch_slab"
},
"W": {
"item": "minecraft:pink_wool"
},
"X": {
"type": "valhelsia_core:platform_dependent",
"fabric_value": {
"item": "minecraft:stick"
},
"forge_value": {
"tag": "forge:rods/wooden"
}
}
},
"pattern": [
"#W#",
"X X"
],
"result": {
"count": 2,
"item": "valhelsia_furniture:pink_upholstered_birch_stool"
},
"show_notification": true
}
bump
noble sigil
No, the mod itself does not depend on KubeJS
It's just that any kubejs server recipe script seems to prevent our custom ingredient from working
noble sigil
This is still an issue. Would be awesome if you could take a look at it again.
steady island
This also breaks some recipes from PneumaticCraft that use a type tag in their ingredients, too. It removes the fluids from recipes such as this one: https://github.com/TeamPneumatic/pnc-repressurized/blob/1.20.1/src/generated/resources/data/pneumaticcraft/recipes/speed_upgrade.json
It can be reproduced with just PneumaticCraft, KubeJS, the dependencies, and a recipe script added to the server_scripts folder (any will work, doesn't need to be related to any of the recipes broken).
@low kettle I'd prefer not to ping people, but this has been an ongoing issue for a few months and is one of the support questions that people ask us about the most, since removing the sticks from the Valhelsia Furniture recipes causes them to be identical to slab recipes. >.<
Hopefully the above context helps you narrow down the cause, now that we're aware that it impacts multiple mods. I wonder if it always breaks when recipes use "type" in ingredients? (oh, and this is all tested with MC 1.20.1)
ruby wedge
hot plank