#need help removing recipes (getting error)
75 messages · Page 1 of 1 (latest)
Paste version of recipes.js, server.txt from @faint radish
Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!
@dawn eagle was there a recent kjs update?
we are getting an influx of people today with exactly this issue
Not that I know
I wonder if it's a bad recipe somewhere. As it's happening when it's iterating through all the recipes trying to find an output that matches the inputed thing
could it be something with a mod i have installed?
Or bad item
ItemStack.m_41619()
I assume thats the default instance method
item being null shouldnt be possible
I can add debugging for this tho
isEmpty()
do you have anything that changes the base game? like that mod that changes the stack limit to be "infinite"
not that i know of, no
hmm
now that i think of it, it did seem to begin to happen after updating a mod i've had in the list
let me try disabling the mods that were updated
if you do figure out which mod is doing it, please do share it, will help figuring out the exact issue
well i got it to where it didnt error out, now its just figuring out which of these 3 mods it is
its apotheosis
@dawn eagle @clever kindle ^^
something with the 2 latest updates for 1.19
what did shadows do now lol.....
wait did you update apoth again? cause I know shadows did another update this morning for some broken stuff
yeah i did
i did that before anything else
just in case it was fixed, not knowing at the time that the problem was apoth the entire time
Does rolling back to previous update fix it?
guessing it might be in salvaging Lat as that's what was added
https://github.com/Shadows-of-Fire/Apotheosis/blob/1.19/src/main/java/shadows/apotheosis/adventure/affix/salvaging/SalvagingRecipe.java
JsonRecipeJS.hasOutput is recipe.getResultItem() which is returning null in salvage
I'm guessing that shouldn't be null, but ItemStack.EMPTY?
other answer would be a null check as a backup here
https://github.com/KubeJS-Mods/KubeJS/blob/1.19/main/common/src/main/java/dev/latvian/mods/kubejs/recipe/JsonRecipeJS.java#L45
but I'm still not sure if getResultItem() can be/should be nullable
yikes, how did this happen lol
even i know about itemstack.empty
and that says a lot
lol
yeah not sure how that happens or what it actually means lol
probably an IDE shortcut
definitely not github, cuz it usually looks for signs, and theres nothing to indicate null
copilot*
copilot looks deep inside
its an override
mixin override?
public class SalvagingRecipe implements Recipe<Container>
or mixins
@Override
@Deprecated
public ItemStack getResultItem() {
return null;
}
so this will override the getResultItem() from Recipe
oh wait i think they mean this
and recipe is an interface, so its just this
by autofill
that kind of autofill doesnt apply here
ah
ye
probably used implement methods in IntelliJ
that might actually be the case
let me try
hmmm
by default when generating an override, it defaults to super.originalMethod()
Try this https://www.curseforge.com/minecraft/mc-mods/apotheosis/files/4453685 @severe marsh
