Is there any way I can better optimize this code? | latcord | Page 1

calm ember Dec 24, 2022, 9:43 AM

#

I can't use the code from the line above, due to a spelling error in the mod I'm working with

robust fjordBOT Dec 24, 2022, 9:43 AM

#

Once your ticket has been resolved, please close it with </ticket close:1054771505520717835> command!

calm ember Dec 24, 2022, 9:45 AM

#

paste for the code, if anyone needs a better look

📎 message.txt

lament pewterBOT Dec 24, 2022, 9:45 AM

#

Paste version of message.txt from @lilac robin

keen bison Dec 24, 2022, 11:12 AM

#

@calm ember


const colors = ['white','orange','magenta','light_blue','yellow','lime','pink','gray','light_gray','cyan','purple','blue','brown','green']
colors.forEach(color => {
        //Steel Tanks
        event.shapeless(DB(`${color}_gilded_steel_tank`), [DB(`${color}_steel_tank`), MC('gold_ingot')])  
        event.shapeless(DB('red_guilded_steel_tank'), [DB('red_steel_tank'), MC('gold_ingot')])
        event.shapeless(DB('black_guilder_steel_tank'), [DB('black_steel_tank'), MC('gold_ingot')])
        //Boilers
        event.shapeless(DB(`${color}_gilded_boiler`), [DB(`${color}_boiler`), MC('gold_ingot')])
        event.shapeless(DB('red_guilded_boiler'), [DB('red_boiler'), MC('gold_ingot')])
        event.shapeless(DB('black_guilded_boiler'), [DB('black_boiler'), MC('gold_ingot')])

})```

i don't know why red and black are called diffrent, but thats why i left them out of the color list

wanton quail Dec 24, 2022, 12:43 PM

#

Use Color.DYE instead colors

lament pewterBOT Dec 24, 2022, 12:43 PM

#

max.

[Quote ➤](#1018480575079784548 message) since colour only has a set amount of values, you can use Color.DYE and iterate over that

elfin hull Dec 24, 2022, 5:32 PM

#

could also do something like

// before your foreach function define
const steel_tank_errors = {
  red: 'guilded',
  black: 'guilder'
}
const boiler_errors = {
  red: 'guilded',
  black: 'guilded'
}
//then add into your colours forEach
//colours.forEach(c => {
  event.shapeless(DB(`${c}_${steel_tank_errors[c] ?? 'gilded'}_steel_tank`), [DB(c + '_steel_tank'), MC('gold_ingot')])
  event.shapeless(DB(`${c}_${boiler_errors[c] ?? 'gilded'}_boiler`), [DB(c + '_boiler'), MC('gold_ingot')])
//})

what this does is if the color is defined in the maps above, use the data from it, or use 'gilded' if it's not

vernal folio Dec 24, 2022, 7:53 PM

#

so Dave doesn't know how to mod properly OR spell properly? man

calm ember Dec 24, 2022, 8:33 PM

#

elfin hull could also do something like ```js // before your foreach function define const ...

thanks for this! this is actually super helpful

#Is there any way I can better optimize this code?