Joy of Sailing

[placid spindle]

Oh that sounds dreadful.

I hate when languages want you to do something like put an _ first.

I had a friend that thought it was funny to name his variables stuff like 🍕 just because it’s technically possible and I would 100% have supported that because it would be hilarious (and he mostly worked solo anyway).

But to me having _ at the start for publicly accessible code would make it so much harder to read!

[strange goblet]

Except it doesn't make it more difficult.

It explicitly is done because how often have you accidentally typed _?

The goal is to ensure that all private variables are only accessed through public properties. _ is used for private variables to ensure they're never reset by accident.

It's also better than setting something public readonly just because you want it to be able to retrieved and not set.

[placid spindle]

I mean, that’s just for me.

It’s not impossible to read.

But it would be like a novel having a period after every word.

[strange goblet]

I think if you're accessing it with _ every time, you're doing it wrong.

[placid spindle]

I get what you’re saying but it’s not relevant to reading it.

[strange goblet]

You shouldn't be using _variable in your method calls/etc outside of the class it's in. And if you're retrieving the information, you should be going through the property even inside the class.

[placid spindle]

I mean, you’d wanna use the private version inside the file where it’s private at least, right?

[placid spindle]

Mm. Interesting.

[strange goblet]

Usually the "get" is either a straight return, or it has some kind of logic controlling what happens when it's retrieved.

[placid spindle]

True.

[strange goblet]

Which means inside the class, you're also only using the _ to set it, which makes not only its access modifier clear, but it makes it clear what you're doing with it at a glance.

[placid spindle]

That’s fair.

And that does mean it’s more readable in a way.

But it’s not what I meant when I said readable.

Either way this is off topic.

[strange goblet]

True. <fades out>

[plain galleon]

you have to remember everything locally in your head to maintain it,
what

Sounds insane

[languid folio]

What was that other mod, to link with this mod to make sailing nicer, like better winds or something?

[void shore]

https://mods.vintagestory.at/pelaguswinds

This one, I think?

[languid folio]

Thaks mate after sailing for a bit i can confirm the vanilla wind aint that great

hopefully this is better

[proper moon]

How's progress?

[charred viper]

What's up dudes

[warm cloak]

almost there
it's not going to look perfect, it might not be balanced or bug-free, but i'm pretty close to having something that works

[warm cloak]

@here
Released Joy of Sailing 1.4.0-rc.1 :

• Now compatible with 1.20
• Doesn't add its own sailboats (will have a legacy sailboats pack in the future), modifies the vanilla sailboat
• Now implements square sails instead of triangle sails (triangle sails will come in the future)
• Multiplayer should work but is untested

Now keep in mind: this is mostly untested and might be severely bugged
Animations are broken, for instance (the rudder doesn't move for some reason)

ok well, apparently it's not really working

it worked in the first test, but not anymore somehow

also holy shit it is way too fast

[warm cloak]

rc.2 to fix that

[jolly orbit]

I am definitely looking forward to the legacy sailboat pack. My current (ly paused) world is an ocean world, in which I was barely able to scrape together enough flax for one of your sail boats.

[warm cloak]

yeah, that's precisely the use case of the legacy sailboat pack x)

[placid spindle]

You’ve got some kinda wind power thing?

I’m not sure how much progress has been made for 1.21 sailing stuff yet.

[warm cloak]

Yeah, sail positioning relative to wind direction, and wind speed affects how fast the sailboat goes

Since it's a square sail, it's basically a matter of putting the sail as close to perpendicular to the wind as possible

[placid spindle]

Neat!

[dim flicker]

so this mod is still really buggy i presume?

[warm cloak]

I have no idea
I didn't notice anything besides relatively minor cosmetic bugs (the rudder animation)

I have code to handle MP compatibility but can't really test it right now

So it should be good

[warm cloak]

So, for the (very near) future:

• rc.3 will add extra tolerance when going against the wind (I tried to go against the wind, it's really hard for now), and worldconfig options
• rc.4 will fix animation issues
• 1.4.0 full release if it's confirmed to be mostly bug-free

I also want to figure out how to draw cordage, but I tried already and couldn't make it work so there's no guarantee on that

[warm cloak]

Joy of sailing 1.4.0-rc.3:

• Added config options
• Made it easier to sail against the wind (more tolerance to sail positioning against the wind, meaning you can sail closer to the wind)
• Fixed a bug, exiting a sailboat now properly stops it

[sharp bison]

Brother I can't seem to see any of the worldconfig/config options? what were they suppose to configure?

[warm cloak]

you have to create them using commands, unfortunately it's not easy to add config options that show up before the mod is loaded

I gave the commands on the mod page

it's gonna be like /worldconfigcreate float joyofsailing.sailspeedmul 2 to double the speed of sailboats or something

[sharp bison]

Oh I didn't see that, I went and download right away. sorry

[warm cloak]

no problem 😄

also re-read the sailing guide (also on the modpage) if you used Joy of Sailing in 1.19 or before, it changed since then

[sharp bison]

Moby, please consider fixing the vanilla sailboat's tendency to pitch up while sailing. the speed and visual weight of the boat don't match. Most of the time it kinda looks like a speedboat while moving.

[warm cloak]

yeah it's already fixed in the in-dev rc4 build

I haven't made it less strong, but I capped it at 15°

rc.4 right now has:

• rudder animations
• not-so-strong pitching up
• partial implementation of cordage rendering
• partial implementation of world interaction sailing (like, controlling the sail by clicking on the tacks on the boat instead of pressing keybinds)

[sharp bison]

holy shit that was quick Thanks man!!!

[warm cloak]

I noticed it too and fixed it this morning 😄

[warm cloak]

released rc.4 to fix rudder animations and the sailship tilting back too much

[sharp bison]

Sailing the boat actually feels right now! no more speedboat pitching. Thanks!!
Also this sculling motion with the rudder animation reminds me of those river sampan, Nice!!

[dim flicker]

what wind mod works best on servers with this

[sharp bison]

Speaking of river sampan...

I can't help myself but make it look like this. Oh boy this might be a long day...

[warm cloak]

Pelagus winds

[sharp bison]

These gentle curves takes some patience.

(That wool is a placeholder for the elk)

[warm cloak]

omg nice!

btw if you want to use joy of sailing as a library and not have a sail, you could just give it a wind speed multiplier of 0 and only keep sculling

(i'm also going to add auto-sculling in the next update, since that was requested and would be very useful)

[warm cloak]

so, upcoming for rc.5 (probably today or tomorrow if I get to it):

• auto-sculling
• key configuration (some players who got used to Joy of Sailing find it more convenient to move the sail with W and S, while raising and lowering it with ctrl and space)

[warm cloak]

btw has anyone found non-cosmetic bugs?

(and that don't involve configs, because these suckers are broken, i'll redo them entirely)

[sharp bison]

The wool cubes are placeholders for the storage jars.

Soon were gonna be sculling the high seas friends!!

(I'm going after the rugged/homeless look of the 1800s river sampan housboats)

(not to mention, they also had squared junk sails)

[warm cloak]

hot damn this looks so cool

I think there's a scull speed modifier in the sail attributes?
You could make it scull much faster than the sailboat

[sharp bison]

Yeah I think I saw that on one of the .json files

[sharp bison]

Moby, the pitching might still be to high tho

I already toned down both the sailspeed and windspeed via config. Even multipliers on the .json has been toned down yet the pitching still make it seem it's going fast

[warm cloak]

alright, i'll make it configurable

btw your boat looks amazing!

[sharp bison]

Thanks a lot moby, i'll drop the shapes file here once I've polished everything

[warm cloak]

you should publish it as a sailboat pack

[warm cloak]

Joy of Sailing 1.4.0-rc.5:

• Added auto-sculling (hold left+right for a second to activate)
• Made it possible to configure speed-related pitching in the json api

[warm cloak]

also updated the github repo to have the 1.4 code (all rights reserved but that way you guys can look at how it works under the hood, and if i suddently disappear people won't have to decompile it to upkeep it)

[paper heath]

Wow thats so cool

How do you have the patience to use the modeling app?

[sharp bison]

Thanks!! I scale things up to 2.5 times, then it's a lot easier to align things up. (a larger model also help with the jank camera navigation)

[sharp bison]

then I scale things down by trial and error until the proportions matches everything together.

[paper heath]

They should really update that thing its so hard to us
I dont have the patience to do it :(

[coral quest]

little dumb question : what is the modeling app ? :3

[paper heath]

Fogor the name but you can get it in the client page of the vintage story website

Its the app with an anvil

[warm cloak]

VS ModelCreator, and yeah it's not great
It works, but is far from intuitive

[languid folio]

Did you add any new features to 1.19 or is it all 1.20 now?

[warm cloak]

I'm just updating 1.20

I consider 1.19 to be pretty much done, well, as done as it can be
It's pretty much bug-free and feature-complete, and the last meaningful (non-bugfix or microfeature) update to Joy of Sailing was over a year ago

Of course, 1.19 JoS can still make sailboat packs, and I'm still at work to bringing feature parity to 1.20 (essentially add the features required to remake the legacy sailboats)

[low saffron]

I noticed that joy of sailing doesnt have a mod config, is it still possible to change river flow affecting boats down as the boat just floats away if I lag out and get thrown out of the pilot seat

[warm cloak]

that would be solved in the Rivers config

Rivers modifies the vanilla boat code, which Joy of Sailing is using

[low saffron]

I see, damn. Even setting river speed to 0 it still has some movement

Thanks though

[warm cloak]

Joy of sailing just broke 100k downloads!
Thank you everyone for your support! ❤️

[grave flare]

https://tenor.com/view/independence-day-fourth-of-july-4th-of-july-fireworks-celebration-gif-16840663

[brittle atlas]

I'm excited to give it a try once I build my first boat

[twin snow]

Make sure to create a world with a sea

[drowsy field]

may server seems to be having problems with the mod

[twin snow]

How come?

[drowsy field]

dont know

[brittle atlas]

i did luckily, 60% land with 140% scale so the oceans are def big and worthwile to sail, i also have rivers with the pegasus winds so i'm excited for the day i can sail the rivers up and down 🙂

[warm cloak]

what kind of problems?
I didn't really get many bug reports (besides mechanics that should be adjusted), I need them to fix the bugs x)

[drowsy field]

Ill ask the server owner

[drowsy field]

welp cant get a answer

[warm cloak]

welp, can't bugfix then
thank you for asking them tho 😄

[drowsy field]

I could make give you the server mod list?

[warm cloak]

yeah that could help, thanks!
i don't really have a server to test it on tho so if it's multiplayer issues i don't know if i could fix it

[drowsy field]

um question, how do yo reverse now

[warm cloak]

hm

i

hadn't thought about that

good point

i'll probably do what Savrs has been asking for and overhaul the control schemes to remove sculling (well, keep it as an option, maybe something you can do to go a bit faster) and reintroduce the vanilla WASD controls for when the sail is fully folded

which however means that we'll be moving the sail left and right using W and S, which feels kinda weird

[warm cloak]

that, or leveraging selection boxes interactions

[slim anvil]

lol Raft Tugboats

[placid spindle]

Add oars and allow use of oars when the sail is up.

[drowsy field]

i like the fishtailing

maybe it where you can push the boat with your body

[coral quest]

Or with a rope ?

If you can pull your ship very slowly with a Rope

[drowsy field]

something because right now i cant turn my boat around

[drowsy field]

unless i dissmantle my warf :<

[slim anvil]

I'll thank you for saving me from this problem, I was just building a dock in my world XD

Now I know to make it wide so I can come in sideways and wiggle out

[warm cloak]

if it's an emergency you could temporarily disable the mod, the new joy of sailing should be able to be turned on and off without much of an issue (test it in another world first maybe)

i'll try and change the control scheme but i still have to figure out something that works, and doesn't use W and S to turn the sail left and right

[drowsy field]

Just make the boats pushable thats all you got to do

[untold raven]

I am trying this mod for the first time and am pretty confused

I get that using control and space controls the sail's direction

and that you are meant to point it towards where the flag is pointing?

I'm using pelagus winds as the wind mod

The thing is that it seems to just have the boat be stopped dead 90% of the time and when it does move, it is really slow

I don't know how hard this is supposed to be to control

[untold raven]

This is how it is for me

[warm cloak]

your sail positioning looks fine, my guess is that the wind is pretty still
You can check that with the /weather command

if the wind isn't actually still, then there's a bug that i should fix

In low-speed winds you can boost yourself with sculling (that is, going left, right, left, right)

i'll add rowing at some point but it's not in the mod rn

[drowsy field]

One issue ill have is the boat will just stop dead with the sail fi4led and i have to constantly start again

[wary steppe]

Looks like you're just suffering from low wind speeds.

[untold raven]

Oh that actually makes sense. So the speed of the wind itself matters... I guess for my own preference I would make it so the wind is always at least a certain minimum speed, I did see that was a command.

I'm glad to know my positioning wasn't the thing that was off, I was really confused by that

[untold raven]

Thank you for the clarification & I will say the mechanics of the mod itself are super appealing, it certainly adds a nice amount of depth to it beyond holding forward, I'll just tinker around with the numbers 🫡

[pure anchor]

i confused, dont find any sail boat after downloading this mod

maybe i missing some other mods&

?

[wary mountain]

the sailboat is part of the core game

[pure anchor]

Yea I know

But I saw that in 1.2 version mod was added sail-raft and other

[warm cloak]

They were removed during the update to VS 1.20

I'll add them back sometime in the future (as a separate mod) but rn they're not available

[drowsy field]

Maybe with more detaiked hulls?

[warm cloak]

yeah absolutely
now we can have hollow hulls too

that actually go under the water line

[coral sundial]

Is the mod creator aware of the large frame drops when looking at sailboats with the mod installed?

framerate drops from 140 to 80 only when looking at a sailboat

[warm cloak]

I wasn't but it makes sense, the redraw of the ship (to make it possible to update the sail angle n' stuff) is pretty computation intensive

I'll try to ether make a custom entity renderer or try to figure something out with animations to mitigate it when i get back to the mod

[coral sundial]

I hope you get to fix it soon, the performance impact is pretty harsh. You can see on the graph the exact moment I turn towards the boat. And since you cant pickk the boat up there's no way to stop it.

[coral sundial]

Before and after looking at the boat

I can jitter my camera back n forth to make it constantly jump up and down in framerate, going from 141 to 80 avg fps

[spring stream]

My message about this was getting buried in another channel and will get buried again in other appropriate channels, but i'm on 1.20.10 and I can't seem to control boats anymore, but rafts still work. I was attempting to test this mod but it wouldn't activate and thought that was causing boats to not work, so I disabled it, but they still won't move. Could it still be an issue from this mod somehow? It shouldn't be. I'm not sure why this mod won't activate either.

[warm cloak]

What exactly was happening?
Couldn't raise or lower the sail? Couldn't turn?
Do you have logs by any chance?

[spring stream]

I'll see if I have any relevant logs when I get on my pc later. Did you modify what the sail looks like at rest? Because that looks the same as in vanilla and I couldn't move the boat or cause anything to happen, besides the rudder moving the tiniest bit only when trying to turn and sitting on the starboard seat. Sometimes. Usually not even that moved. Ctrl still makes me dismount and no other keys did anything besides what you can normally do when sitting down. It doesn't matter if I have this mod on or not, it's exactly the same.

If I sent a video of me trying to use a boat you wouldn't be able to tell I was pressing any keys at all.

[warm cloak]

Ctrl shouldn't make you dismount, shift should, unless i'm forgetting something

Did you change your key binds, by any chance?
It's supposed to support it, but maybe there's an issue with that

(also yeah, iirc you can only control boats when sitting on the starboard seat)

[spring stream]

My keybinds are default and although the mod should change them, it doesn't.

If the mod adds any keybinds to the keybind settings, it doesn't for me.

And as I said several times, even sitting in the starboard seat does nothing besides the rudder tilting maybe 1 degree when turning one time somehow, but turning doesn't do anything besides that.

I have this log that shows me opening the same world several times and loading your mod. I also have configlib and gui lib but they shouldn't be causing any issues and I tried without them first too.

These two logs are the only ones that seemed to be relevant, if there's another you want I can post it. If it says something about deleting sailboats that's because I kept turning the mod off and on again and reloading the same world.

[cold verge]

Now that base game has sail boat is this mod still worth it?

[wary steppe]

If you like the sailing mechanics of the mod, then yes. If you like to just hold W to sail, then no.

[cold verge]

just built first sailboat. cant get sail to come down

[warm cloak]

What version of the game are you using?

[cold verge]

1.20.12 I think it might be a vanilla winter thing because I found a thread about another having it. Resetting game a few times fixed it

[fast owl]

Pls add surfboard with sail
Look up "Windsurfing" to see what I mean
Here is a wiki link: https://en.wikipedia.org/wiki/Windsurfing

[strange goblet]

Any chance of a pennant we can put on the sail that will show the winds direction?

[warm cloak]

Like, have compatibility with Dana's banner mod?
Could be cool, yeah!

[strange goblet]

.... I mean, I didn't say that.

It's something I'd prefer to be native to joy of selling.

Not that I have an issue with Dana or their mod. But I prefer to have choices in what I use 😉

[warm cloak]

alright, i'll look into it x)

(well, when I update the mod and go back to adding triangle sails)

[ancient ore]

sailboarding would be so fun, I would imagine it be much faster than sailboats but hold absolutely no cargo, just the player

[slim anvil]

Perhaps drains hunger more too since you'd be physically active instead of sitting in a boat.

[warm cloak]

(pinging @fast owl too)

ooh yeah I didn't see that, it sounds really cool!
Early JoS sailboats were kind of like that, but there wasn't the massive cargo option, they were just fast transportation. I gave them an inventory later on, and will keep it that way, but adding sailboards, yeah that sounds like something I'd want to do
(might be a little odd to implement when it comes to animations, but I'll figure it out)

[warm cloak]

I might make it similar in hunger depletion to either walking or running

[fast owl]

I'm glad the idea was thought of positivly. If it does indeed get added, or made into a seperate mod, I would love to use it when playing.

[ancient ore]

it'd be a little complicated but I imagine an animation of the player sort of standing like they would on a snowboard or something, with the left hand holding the mast of the sailboard

and then have the head and torso lean left or right for turning

or I guess they'd technically be leaning forward and backwards

[winter yew]

Hey, what about making boat "solid"? Like, you could ride an invisible entity, which can move only inside boats borders. It's still a rough idea, but what do you think?

[karmic lotus]

how do i move? been stuck here for 4 days. . .

[slim anvil]

Wind not in your favor?

Hold left & right for a second and it'll start auto-sculling the rudder back and forth for a slow speed forward

[karmic lotus]

i have ct.
im aware of that but can not do that.

[warm cloak]

My guess is that you don't have a wind direction mod (or that wind direction mods aren't really working anymore), and in vanilla the wind always blows from west to east. Because it's impossible to sail directly against the wind, you end up not being able to sail westward.

To go west, you can scull but if that's not working (or if you want to go faster), you'll need to tack. That is, go in zig zags at a ~45° angle against the wind (you can tack closer to the wind but it's going to be harder or slower)

[karmic lotus]

guess im changing the wind mod im using. .
i did have one but i guess its not working if thats the case 🙃

[karmic lotus]

also, would it be possible for you to make a 2nd version of the boat that has the sail inline with the boat?
the type of sail boat we have in game now is not the best type of sail boat for how we use it.

[warm cloak]

What version of the game are you running?

[karmic lotus]

current stable.

[warm cloak]

Actually, next time I update the mod chances are triangle rigs are the only ones which will be left
Square rigs are way too much of a hassle to make fun

[warm cloak]

Yeah, it's not really supported, the devs changed the way sailboats work and the way the wind works afaik

Tbf I'm surprised the mod still works at all

[karmic lotus]

oh, so its not me 🙃

[warm cloak]

(other reason why I'll be moving to adding my own sailboats instead of editing the vanilla one is I'm a little tired of having to rewrite the entire thing every major update while the devs keep not fully implementing sailing mechanics)

[karmic lotus]

well, your doing amazing work and i cant wait will your boat is out lol

if i may. . . Junk sails??

[warm cloak]

Former sail raft was pretty close to that

[karmic lotus]

ive always loved how Junk sails look!!!

[warm cloak]

Finally found the old steam raft pictures

@karmic lotus

[karmic lotus]

Oh that's cute lol
Would love to see a larger boat with that kind of sail!!

[slim anvil]

Yeah... it is a shame, had a lot of fun moments when it worked out but damn is it rough when it works against you

[karmic lotus]

soo. . . there is a crash when you put a fence in a boat. . 🙃

[karmic lotus]

😉

(if i can get get the mods i want to work, ill be able to model more ships lol )

[minor edge]

Greetings, enjoying the mod thus far

Tho, wind does not seem to change direction, how do i solve this?

[plush rose]

Wind direction included separately i think

Go to the mod page, there's links to the wind mods there

[minor edge]

did it

thanks

[graceful blaze]

why are they called junk sails? I'd call it a dragon sail cause it looks like dragon wings ot those stylized dragon ears

they don't look like junk to me

[karmic lotus]

"junk" in that since is the english meaning.

[graceful blaze]

I always thought they were dragon sails

[graceful blaze]

anyways I love some of the old designs from those screenshots and am excited to see new ship designs post 1.20! would look great in my oceans server

[warm cloak]

because the ships with that type of sail are called "Junks", apparently from Malay "Jong" x)

[graceful blaze]

I see

I'm not sure what your future plans are for this mod but it would be neat to see different classes of ships, the vanilla one is like a cargo boat as it can hold a lot of material but doesn't go very fast, great for exploration and resource runs, then a faster boat with sleeker hull has maybe half the storage and is used to travel between places, a catamaran style that would have an intermediate storage and speed and finally smaller boats like the sail raft or canoe that are meant for personal transport

Or maybe the catamaran is fastest with least storage?

Anyways you already got all the very pretty models as I've seen by scrolling this chat it would just be giving each one its unique uses and features

[warm cloak]

My plan is to probably drop support for sailing mechanics for the vanilla boat and go back to the much easier to implement and much more satisfying to use triangle sails.

I'll probably add a handful of smaller boats, like I did before

(at the same time, I've been tinkering with multiblock ships, although I'm missing a few things to make them actually usable)

[graceful blaze]

Oh neat!

But why drop sailing mechanics for the vanilla boat instead of integrating it?

[warm cloak]

Because I'm tired of it

Every update it changes something in a major way that makes it so I have to rewrite everything if I want it to keep working

It should be in vanilla, I offered help, wasn't taken up on the offer, I'm not really willing to do the work for free anymore (especially if I have to redo it from scratch every year)

[graceful blaze]

So would the vanilla boat be disabled? Or remodeled to be one of the joy of sailing versions?

[warm cloak]

Unchanged

Just, a motorboat controlled by folding the sail, like it is currently

[graceful blaze]

Ah ok

[warm cloak]

I'll add my own boats, my own way

[graceful blaze]

It may be good to have an option to disable the vanilla boat in a config then since it would look a little out of place

[warm cloak]

It's so hard to make that I feel like you could just avoid it easily

But yeah, for servers, maybe I'll push something like that

Tbf the vanilla boat absolutely has a niche, for massive exodus
I'm probably not going to add boats that are that big

[graceful blaze]

Fair, it is an absolute unit for hauling cargo though

[warm cloak]

Eh, on multiplayer you can fill it out pretty fast

(or when going on a dungeon expedition)

On my survival server we went to the coal mine thing from better ruins, the boat is half filled and we're nowhere near done with it

[graceful blaze]

Yeah, I usually fill all slots with either crates or chests, it does some pretty good runs for clay

But I'm fine making multiple trips if I need that much resources

[graceful blaze]

That's when you get your friend to bring their own boat and you fill both of them

I'm just not sure a wooden boat of that size could fit much more without sinking

Well then again if you fill a full hull with rocks it realistically should sink but ehh, minor detsils lol

[graceful blaze]

Is this mod being developed still?

[proper moon]

Oh, that’s sad. I really like the vanilla boat.

[minor edge]

This mod still alive?

[graceful blaze]

no I dont think so but shipwright just released

https://discord.com/channels/302152934249070593/1450892911980970095

[minor edge]

Aye i know

[warm cloak]

I dropped square sail support a while back, I'll redo the old triangle sails which were MUCH more enjoyable

(also weren't changed beyond compatibility by the devs every other update)

[minor edge]

Isee

Was askin cuz i love this mod

[warm cloak]

Yeah, me too, but I've grown tired of doing the work (when it should be vanilla), only for the devs to release updates that break the mod regularly

[proper moon]

Very frustrating

Looping compatibility into Shipwright shouldn't be too crazy right?

[warm cloak]

Yeah, I was planning to have compatibility with the triangle sail boat from shipwright

[knotty surge]

nice mod does it still work

[warm cloak]

Nope
I'll redo the OG triangle sail dinghies at some point but I got fed up with vanilla square sails

A handful of people got my permission to use the square sail code though so that might happen

[graceful blaze]

honestly I'm wondering if it would be better to combine yours and shipwright as one big ship mod since it would save you the trouble of testing compatibility if freakyuser is already doing that, and you could just focus on the designs and mechanics that you want to add

I guess its up to them though

I could imagine they would be happy to have more help

[granite agate]

@warm cloak if you're interested, I can take over keeping this alive for new versions. I'm interested in a vanilla+ sailboat experience that supports wind direction. Shipwright is a bit much for me.

Reading back through, it seems like you're thinking about moving away from the vanilla integrated experience altogether. Let me know what your thoughts are. I think there's still a lot of potential in building on the vanilla boats now that things are a bit more stable.

I've already ported to 1.21 and 1.22 and spent the past couple of days add climbable ratlines that accurately position the player and the camera with the sway of the boat. That was WAY more maths than I was prepared for.

[warm cloak]

alright so first of all your ratlines look amazing

If you want to keep Joy of Sailing up to date, I can add you as an editor on the modpage (and I'll create a separate Joy of Sailing Legacy mod)

I wanted to add more to sailing, namely have furling/unfurling be properly controlled by the mast thing like in Vanilla, and maybe have the sail rotation be handled with tacks on each side of the boat (by right-clicking, therefore reducing the need for keybinds. That's the biggest issue people had with the mod)
That and keeping furled sail controls, which I currently have to some extent but it's impossible to reverse

There's also the issue of model redrawing being very poorly optimized, I'll have to work on it for other mods anyways

I could probably help with the mod a little if you need, but yeah I'm down for you taking over. Been looking for someone to take over for a while, as a matter of fact

[granite agate]

Thanks!

I would definitely be keen. I am already working on wiring up the sail controls. I don't love the shift and space keybinds. But I do love the forward and backward ones, so I would likely just have them as optional bindings in the normal controls menu.

When you talk about the model redrawing issues, do you mean like when the sails are rotated?

But, yeah, super keen to take over. I would definitely be doing a lot of testing before a release. Would be a couple of weeks or so I would think. I need to check if there are any wind direction mods these days too.

[warm cloak]

Yeah, keeping some keybinds but offering in-world control would be the way to go imo, that way people have a choice

Basically the model gets recalculated every frame (could be every time something changes but stuff can change very often), there's probably a way to handle it with animations or better rendering practices

I sent you an invite to get added to the mod page, feel free to do whatever with it

[halcyon sand]

Really looking forward to seeing this one return

[drowsy field]

yeeess please!

[void radish]

Running a server for my friends that's lower landcover, excited to use this mod when it's updated for 1.22!

[subtle sky]

There is a forked version for now