Not with that negative prompt 😂
#development
bold pivot
rancid marten
i think you basically have no understanding of what it is you are talking about
restive garnet
Well, you seem to be an expert in the field, we'll wait for your PR to fix the problems 😄
bold pivot
I think you have zero information to reach that conclusion
heady pond
drop a Make no mistakes too
bold pivot
I know you're new to this but it sounds like you don't much about it
sinful lava
to clarify, the pr you linked provides an AGENTS.md file for use by a developer's AI agent when they develop a plugin. it would be used to provide context when a developer asks "make me a plugin that does X"
bold pivot
Yeah that's attempting to be a skills file but the whole file is structured to be an adversarial review agent
rancid marten
ok, write us a better one
upper valve
what you're saying makes sense on a surface level and we even talked about that a little bit internally, but empirically a handful of us tested it and we got good results on plugins so idk
bold pivot
I would gladly help out I'd appreciate if you were a bit nicer to me
That makes sense, from a technical perspective you liked the output, is that fair to say or was there a different heuristic you judged it by?
heady pond
problem with a skill approach is you're rolling the die whether the agent decides it's relevant to read the file
upper valve
more or less, it was very informally tested (at least by me i am sure moses hammered it a lot more)
bold pivot
That's handled at the harness level
rancid marten
I think the file is always read into the context right
upper valve
it depends on the tool
rancid marten
well yea
heady pond
with skills, just the description at the top is guaranteed to be in context
agents.md is handled separately
rancid marten
moses is probably the best person to ask about this
restive garnet
most of them should match on AGENTS.md but claude is stupid
Claude thinks it's special 😄
bold pivot
Skills files aren't always fed into context but they can be programmatically read with a hook
heady pond
i dont want to write hooks for every model provider
bold pivot
In theory I think the file works great as a review. Before sending a pr, do an adversarial review of the code that's been generated against these standards refractor when directed etc.
upper valve
it might be good if we went and found all the vibecoded submissions (so you know all of them) and found the ones that were doing stuff we don't really like (net http, thread sleeps etc) and left a comment that said "hey please pull this into your agent and make any changes it recommends"
i think we already did that for one or two submissions
bold pivot
Yeah I think that's a good approach.
I also wanted to say I think this is an awesome step to handle this problem, which all FOSS are currently struggling with. I don't mean to detract from the work that's been done
Something that may be a valuable add is forcing this review before a submission even hits prs by setting a blank review.md file and have that agent write to review.md (intended to be called before submitting pr) if it passes. If the review.md is blank the pr is put in waiting for author state instructing the user to run the agentic review on their. Human submittions just enter "I am human" in the review.md file
rancid marten
wouldnt that mean everyone submitting prs would have to have an agent review it first?
bold pivot
There's room for improvement and not a foolproof method by any stretch
No, humans just type I am human
rancid marten
i dont want to do that
bold pivot
Any reason?
rancid marten
i dont want to force people to do that
bold pivot
Maybe there's a simpler verification loop that I'm not aware of
rancid marten
the purpose of this whole agents.md is not for our security or for our review of plugins directly, it is to reduce the amount of bad code submitted to us so that when we do our actual review there are less problems
rancid marten
i dont want to force people to do that
more specifically, what you are proposing here is degrading the human pr submission process in exchange for maybe getting less bad automatically generated AI submissions, which is just a tradeoff im super uninterested in doing really and seems like a bad idea
bold pivot
I get that, and it makes sense to not raise that bar. I did jump the gun on the intent of this but it became clear later on. I think there is a clean solution with some more iteration. generally 100% the right line of thinking here though
wet tendon
When items are in the inventory they get a little drop shadow, anyone know what widget setting controls that? I have bordertype = 1 for the nice black outline but wanted that drop shadow too
late hare
When items are in the inventory they get a little drop shadow, anyone know what ...
no api exposed to set it
wet tendon
no api exposed to set it
ahh damn, ill just have to draw my own
rancid marten
for real this time
late hare
didn't take long before someone managed to get the bot to merge something it shouldn't have lol
rancid marten
i just forgot about that totally
late hare
i didn't even know about it
rancid marten
its also only 6mb
upper valve
i'm guessing their ai recommended they do it so they can embed more static translation data
late hare
they added a 16mb json to the repo, but ofc that gets compressed when put into the jar
rancid marten
oh, not sure if the thing we have limits the uncompressed or compressed size
late hare
i'd assume it's just the jar itself
but in that case, not sure why they added that property or even knew to look for it due to having a large file lol
without even knowing the size of the jar
rancid marten
its all just ai
late hare
guess that'd make sense
remote snow
The positive prompts will be what you’re actually prompting it to do. Do build me a plugin that tracks data about flipping but totally different this time
untold isle
i'm guessing their ai recommended they do it so they can embed more static trans...
My AI suggested adding that setting because of the larger translations file, but I understand now that it was not needed. Sorry if I did something wrong there.
I opened a new PR with the correction, without that setting, and with the updated plugin source aligned properly.
remote snow
Does the AI reviewer do changes to existing plugins as well or just new ones?
worthy sparrow
yes
grizzled aspen
yours isnt checked automatically right now because the ai cant be trusted with it
untold isle
It's ok?
rancid marten
i think so, is there a reason it wouldnt be?
untold isle
I was just worried there might have been another issue with the automated approval, since the previous PR was reverted right after merge. That's all. Thanks.
grave siren
Is the PR backlog longer than normal these days
rancid marten
grave siren
What the zuck
shy pine
One sec, we're celebrating having dropped to only 168 open PRs
rancid marten
we need an updated graph
sharp knot
The current one almost warrants a pin
grave siren
Are that many plugin developers really using it
I ain't heard of Codex until just now
dusty anvil
Yeah, I would have figured it would have spiked earlier with claude code etc. But I guess it really got bad when it wasnt a CLI
glass sandal
grave siren
Yeah, I would have figured it would have spiked earlier with claude code etc. Bu...
Reminds me of a quote by a wise old programmer about command lines
grave siren
We're so back
hollow lintel
Every dip in this graph is Rikten X waking up in the morning
(jk i appreciate all reviewers equally)
odd oasis
Did the place that the version number for plugins get drawn from change? Its just showing the commit hash for my plugins now instead of the version in the gradle file.
Looked at another plugin and found that it's in the plugin properties now.
amber rampart
if you use build=standard it doesn't read your build.gradle at all, so it has to go in runelite-plugin.properties
dim wraith
How does the automated review work?
odd oasis
Ahhh okay that makes sense
Is there any way to read the version number from the runelite-plugin.properties file at runtime?
amber rampart
ExternalPluginManager.getDisplayData
it won't work for dev since its not external in the dev environment
ember flareBOT
grave siren
What is the proper way to check if a trade window has opened/closed after WidgetID is deprecated
sinful lava
You can use net.runelite.api.gameval.InterfaceID instead
If you're in development mode and use the widget explorer, it will usually give you something inside InterfaceID you can use (e.g. Tradeconfirm.FRAME or something similar)
grave siren
Ehhhh interesting thank you
odd oasis
If I have two plugins to update at the same time, I should keep the PR's separate, correct?
amber rampart
yes
odd oasis
gotcha, thanks for the help abex
ember flareBOT
grave siren
Is there any solution to having accidentally turned off my code formatter at some point and now wanting to turn it back on which would cause a massive pointless PR diff
or is this just my life now
sinful lava
if you make a PR with only formatting changes, I can review it no problem. just ping me in here with the PR when you've made it
topaz pierBOT
The RuneLite Wiki: https://github.com/runelite/runelite/wiki
low hatch
You can build RuneLite locally using JDK 11. We recommend installing the JDK through IntelliJ and selecting vendor Eclipse Temurin (AdoptOpenJDK HotSpot) version 11. The codebase supports language features up to Java 11.
up to Java 11: Does this still hold to be true?
amber rampart
yes
low hatch
Thanks
restive garnet
🔥
arctic surge
In LlemonDuck's Tombs of Amascut plugin, there is a "Swarmer Overlay" config option under the Kephri section, which overlays the swarm spawn number on top of each swarm. This is very useful to know when you can stop blowpiping swarms.
The final swarm that heals on 1st down is normally 14th, and on 2nd down is normally 18th. However, rarely one extra swarm can heal the boss (being 15th on 1st down, or 19th on 2nd down). My current understanding is that this is due to NPC index rollover, where the dynamic instance npc index goes over the ~65k max and wraps back around. This affects sub-tick processing order, which causes them to heal kephri. I would want to confirm this with some clips having NPC ID plugin enabled to prove that theory, but this is the current understanding. Same kind of thing happens with Vorkath flinch timing & zombie spawn index, for reference
Would it be allowed to add a special highlight if this situation is detected (based on Kephri's NPC index vs. swarm NPC index), to indicate to the player that they need to kill #15/#19?
One way of implementing it would be to highlight all swarms that need to be killed a special color (instead of the player just having to "know" and look at the numbers). That would be a separate enhancement. Then, the swarmer overlay could be made index-aware and detect the #15/#19 situation, and include those in the special color highlight should the situation arise
Not sure if that is within plugin rules
quick path
I'd think so, you should talk to llemon about it
arctic surge
@tulip wagon What do you think about that? My explanation ended up being two ideas:
- Highlight swarms that need to be killed a special color, instead of just numbers and having to understand what the numbers mean
- Detect the rare #15/#19 swarm index rollover situation, and include in above highlight
If you think it would be acceptable/within rules, but you're not interested in investing time in this, I could work on a PR for it as well
tulip wagon
That's all fine, yeah
There's actually a similar thing already in I think tob qol which alerts when you are likely to get a NPC index rollover at maiden
To warm about scuffed crab spawn
cinder fable
@tulip wagon Ive accepted the changes you made in my PR 11535. Wanted to update you on that one
arctic surge
looks like it is indeed index rollover, like folks in the summit said
ill work on a PR to enhance the plugin sometime this week perhaps
ember flareBOT
ember flareBOT
arctic surge
That's all fine, yeah
I created the changes for this Kephri swarm discussion from earlier in this PR here, with some video examples of it working. Let me know if any changes are necessary: https://github.com/LlemonDuck/tombs-of-amascut/pull/139
upper valve
@twin rover is there a way you could encode all this static data / mappings in json somehow, that way you wouldn't have to have the big diff
worthy sparrow
late hare
not even using gamevals for the npcs 😭
twin rover
hmm never done that before, ill look into it though for sure
upper valve
claude/codex/w/e would probably be able to just scan it and figure out how to turn it into json w/ a loader
twin rover
oh that might be easier, ill test that out later. thanks 🙂
twin rover
Ill also work on using gamevals, was learning by examples - not my fault all my examples didnt use it 😂
little sky
you should first ask codex / claude to evaluate some plugins that have been approved and the entire repo of the runelite master and plugintemplate that way it can understand the gamevals more properly. - usually newer models have enough context to take this in.
little sky
tbh adam, no, I had my model just copy the git locally and rip through it
rancid marten
we only added it i think yesterday'
twin rover
Ehh ill prolly just do that part manually, just the json part with claude/codex
little sky
instead of wasting context, have it write a py script to write it locally maybe, just food for thought - take one file in, then can do many, rather than the agent doing it.
valid wave
when I was looking for this, everyone said it wasn't possible
glass sandal
How long ago were you looking? It was added like 2 years ago
valid wave
I was looking just this year, around april. I needed a setting-dependent toggle to hide/show relevant settings
rancid marten
that is a custom panel built into the config plugin, its not something you can make in a plugin
quick path
We don't support arbitrary setting panels, that is specific to notifications
valid wave
yes, but this accomplishes what I'm looking to do
https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/plugins/woodcutting/WoodcuttingOverlay.java
Ah, I see how they did it now
rancid marten
?
valid wave
wait, is this not the custom swing panel?
rancid marten
not even a little. and even if it was, we are they
valid wave
how do you create the sub config swing panel?
rancid marten
that is a custom panel built into the config plugin, its not something you can m...
?
ember flareBOT
valid wave
then I guess I'm still confused. If this is baked into the config plugin, is it only the Notification class that has access to this type of sub menu?
rancid marten
yes
rancid marten
look at the config plugin
latent shoal
Hey Team, this is a proximity voice chat plugin that I have created for OSRS. I don't think I can capture/play user voice data with Runelite's limited API. https://github.com/runelite/plugin-hub/pull/11729/checks?check_run_id=73893732286 Any help or exceptions that can be made?
scenic cedar
Hey, I'm interested in getting into contributing to some plugins or making my own, but I've always been curious about any involved 'risk' for my account? How does Jagex differentiate between me just developing, or if i'm running some unauthorized version of the client? If it somehow sees my account on a test client, how does it know i'm not abusing a test client to run unauthorized plugins in the name of 'development'? Or am i just worrying pointlessly? Apologies if this is already explained somewhere
twin rover
just dont develop anything against the rules ^
twin rover
is it normal to fail the plugin hub check using the json method? first time on it, passed the usual build.yml and it runs fine in IDE
latent shoal
is it normal to fail the plugin hub check using the json method? first time on i...
Had to change like 4/5 things before it accepted the code.
worthy sparrow
grizzled aspen
is it normal to fail the plugin hub check using the json method? first time on i...
you can't use reflection
latent shoal
https://runelite.net/plugin-hub/show/blue-prox-chat ?
Mine is a bit different.
twin rover
Success 🙂 at least that AI conversion advice saved me lots of manual editing lol
ember flareBOT
ember flareBOT
upper valve
Hey Team, this is a proximity voice chat plugin that I have created for OSRS. I ...
using the javax sound stuff isn't strictly forbidden, that feedback is largely a mechanism to get people just playing clips to use AudioPlayer. for this usecase you'd have to use javax sound
so your submission is fine as-is and you'll just need to wait for someone to review it
latent shoal
@upper valve thanks brother. I don’t need donations or anything. I’ll sponsor the dedicated server myself. I just want to see how far it’ll go. This will force me to start streaming OSRS again lol.
Trying to land another pentesting contract so it’ll continue to fund this thing and I’ll donate more to RL.
silver flame
Y'hello, whats the process to adopt an unsupported plugin?
https://github.com/Nerdpuff/max-skill-trim
I was in brief contact with the dev 2 months ago and they expressed some interest in handing it over but then did not respond further
@lean nova Pinging you in-case you happen to be available directly
topaz pierBOT
sinful lava
That's the standard procedure
silver flame
Is something like this good/clear enough?
https://github.com/Nerdpuff/max-skill-trim/issues/29
sinful lava
i think that's a fine step for 1.
glass sandal
I can't remember if this ever worked but the highlight for MOKI_AGIL_SHORTCUT_OP does not work. Only one pillar has the Jump-To op. Highlighting MOKI_AGIL_SHORTCUT_NORTH and MOKI_AGIL_SHORTCUT_SOUTH does work but it highlights both of them when you only need to click the one on the opposite side from you.
And MOKI_AGIL_SHORTCUT_MIDDLE highlights the actual pillar object
remote snow
https://github.com/runelite/plugin-hub/pull/11678
any further changes needed for this or do I just have to wait through the whole PR review queue again
sinful lava
https://github.com/runelite/plugin-hub/pull/11678
any further changes needed fo...
howdy - we'll ping you here or ask you in the linked PR when we need more information
remote snow
it's not ID based through the UI, they have to right click hide each individual object like ground object hider
upper valve
that is essentially a user-provided id list though
heavy bobcat
I think the thing with IDs is that people could target null objects
Like things you can't actually click or that don't have names
remote snow
it's the same way previously plugins have implemented it, more or less
ground object hider is storing a list of IDs in the config
solid shadow
that plugin wouldnt be accepted if it was submitted today
it predates the no id based plugin rule
remote snow
i guess we should remove it then
heavy bobcat
AI reviewer strikes again
grizzled aspen
i'm sure its better for everyone that it gets a proper review instead of your plugin getting bonked every time a rule breaking part of it is found
low jacinth
Are people who do config surgery disregarded in these cases? Because despite having to manually click the object to hide it, being ID/config based people could still hide null entities that way
arctic surge
what's an example of a null entity that's a no-no to hide?
low jacinth
iirc you werent allowed hiding something at bloat at some point
idr if still the case
a null npc that was bad to do something with(mark in this case) was vents at duke
low jacinth
i think it was the center chamber in bloat
because hide chains is still in tob qol
but yeah at any rate; im just saying even if you dont have a way to manually type IDs if it's saved in a way the user can config-edit it theres no real diff.
see : people highlighting all exhumes at xarpus without ever seeing all the variants
deft hatch
null entries need to be excluded in code
arctic surge
but wait a sec, if the center chamber is in the banned IDs list, how could they get around it in the config?
deft hatch
does not matter what people mark through config or in-game
low jacinth
im not saying they can, generalizing and was asking a question here regarding id based plugins. but yes you cant bypass those lists or null checks
arctic surge
yea, so looking at that code, I believe if they were to put the banned id in their config directly, when that function reads the config file it would get excluded
arctic surge
but yeah at any rate; im just saying even if you dont have a way to manually typ...
not fighting it, but imo this is such a weird line in the sand "you have to manually see the exhumed in each location before you're allowed to have them marked, but then it's OK"
never rly made sense to me
glass sandal
It's just a very literal interpretation of
Anything that automatically indicates where to stand, or not to stand. This applies to only automatic indicators, and not tiles which have been manually marked.
arctic surge
yea i see, I think jagex could use to refine that rule a little more 😂
I think the intention behind that is like, showing the AoE radius of some AoE attack, which requires understanding
low jacinth
Maybe miscomm here, it was just an example to show something requiring the user to manually mark it doesn't exactly prevent you from doing so via config-surgery which as seen people will do
arctic surge
My understanding is that you can do config surgery for both Object Marker and Custom Object Hider, so in that aspect, they are the same. As for banned things to hide, those can be disabled in the banned list (and manual config editting can't circumvent it)
low jacinth
The problem with ID plugins is new cases that were unnoticed, or only come up because of new content being released can result in doing something against Jagex rules. I assume thats why only old plugins that already had it were grandfathered in, so there's less plugins that can cause said issues to manage/keep track of.
Idk, assuming here but the specified reasoning on the rejected feature page is "moderation issues and outcomes that break Jagex's plugin rules"
Maybe I'm wrong, I'm not a contributor so more or less speculation on my part as to the reasoning.
cinder fable
@tulip wagon Ive added the deleted file back the pr was 11535
ember flareBOT
ember flareBOT
ember flareBOT
ember flareBOT
ember flareBOT
rancid marten
@chrome crest@turbid turtle@novel stirrup fyi there is an api change next week where isTradeable() will mean tradeable between players and there is a new method isGeTradeable() for tradeable on the ge
turbid turtle
Thanks for the notice! I'll make sure to update the plugin asap
chrome crest
<@179568888495734785><@132946096828710914><@1115732979508072489> fyi there is an...
Great thanks for the heads up!
upper valve
oh the people that write loot filters will actually probably like that change
quiet raven
i didnt even know there were items that are tradeable that arent on the ge
novel stirrup
<@179568888495734785><@132946096828710914><@1115732979508072489> fyi there is an...
Thanks for letting us know!
novel stirrup
i didnt even know there were items that are tradeable that arent on the ge
Burnt food among other things
ember flareBOT
rugged pivot
oh the people that write loot filters will actually probably like that change
My prefix will benefit 😂
glass sandal
I can't remember if this ever worked but the highlight for `MOKI_AGIL_SHORTCUT_O...
@rancid marten or @amber rampart do you know why the existing highlight for MOKI_AGIL_SHORTCUT_OP doesn't highlight?
rancid marten
is it a multiloc?
glass sandal
Probably
native notch
When having the 'Press Enter to Chat' function enabled, the spacebar still works which is good, however it would be nice for the shift key to be active as well to e.g. drop items and tag stuff. Any opinions on adding that small feature?
glass sandal
It works just fine. You probably have another plugin that is stealing your shift key
topaz pierBOT
If one of your keys isn't working in game, you've most likely bound it to a feature of a plugin. The Debug Helper hub plugin can show what keys are bound to what plugins.
reef badger
(it's probably tasks tracker)
rose void
im trying to figure out what happened to my plugin which hooked script 2701 to do stuff with the prayer tooltip before it rendered.
it looks like it got abstracted into script 9444, but neither 2701 or 9444 fire when i mouse over a prayer to spawn the tooltip
what does fire is 8213 https://github.com/runelite/cs2-scripts/blob/master/scripts/[clientscript%2Cdeltooltip_timer].cs2 but using this, the full tool tip flashes before my plugin removes any of the text in the tooltip.
Any ideas whats going on here?
i just noticed 526 is also firing, using that seemed to work. i have no idea how that change happened or why it works though
pseudo rapids
what are you doing to change the text? prescriptfired?
rose void
onScriptPostFired
maybe pre fire would work for 8213
na same result for 8213 pre or post. ill just submit with 526 i guess
sonic quest
Quick question about an issue that was raised on one of my plugins (https://github.com/mhollink/bankstanding-plugin/issues/25)
When a player uses the !command, is it possible to show some data regarding the sender rather than the receiver?
rancid marten
we have a !kc service you can send an int through, but if you use it too heavily i might ask you to stop
sonic quest
Its for users to send and broadcast their bankstanding level... Not sure how often its used.
rancid marten
as long as its not automated in some way its probably fine
it looks like it has 393 installs so "almost never"
sonic quest
It currently prints the same message as !lvl <skill>. And is basically just that
Player types !bankstanding, thats the trigger
Is there an example which I can have a look at 😳
rancid marten
the !kc code
ember flareBOT
barren aurora
Isn't this already a vanilla game setting
glass sandal
It is for spells but not prayers
barren aurora
?
ember flareBOT
ember flareBOT
silver flame
Y'hello, Im running into some issues trying to start my plugins
Looks like its not starting a graphical environment and then erroring out when theres no graphics
Any idea of where i should start looking?
My setup used to work a few months ago iirc
edit: tags for searchability [HeadlessException x11 wayland SplashScreen]
sinful lava
Y'hello, Im running into some issues trying to start my plugins
Looks like its ...
are you on a wayland wm/dm without xwayland installed/setup?
sinful lava
in a terminal:
echo "$WAYLAND_DISPLAY - $DISPLAY"
sinful lava
that looks correct
you can try restarting intellij through your terminal and see if that works, that might make intellij inherit your environment variables for now
if that doesn't work, in the intellij run configuration you can manually set the DISPLAY environment variable
silver flame
gimme a secnond, turns out its been a while sine i ran apt upgrade xD
And i gotta make sure i patch copyfail while im at it
quick path
And i gotta make sure i patch copyfail while im at it
Are you building runelite on a server?
silver flame
Nope, and i regurarly run rando scripts i find on the internet as root
But it still feels off to leave it unpatched
quick path
Maybe just don't run random scripts you found on the internet and you'll be fine until your distro has a patched kernel build ready to go 
(but also even without root, random internet scripts can cause a lot of trouble so maybe generally don't do that)
silver flame
Fair fair
silver flame
Y'hello, Im running into some issues trying to start my plugins
Looks like its ...
Same issue when running through flatpak from the terminal btw
silver flame
if that doesn't work, in the intellij run configuration you can manually set the...
Trying this now
That results in an immediate exit 1
sinful lava
can you try running intellij without flatpak?
silver flame
It's installed through flatpak, i dont actually know how to run it without it 😅
sinful lava
i mean install without flatpak and run that instead. i suspect you're having flatpak issues - IDEs in flatpak are generally rough unless you know what you're doing
silver flame
am i remembering correctly that idea community and the licenced one got merged into the same installation?
amber rampart
yes
silver flame
Yo, we got a splashscreen, Thanks for the help everyone :D
silver flame
I feel like im doing something wrong, trudging through the flatpak sandbox of the jagexlauncher is a liminal experience and a half.
How are you actually supposed to get the credentials.properties on linux
stuck shale
If it’s not in .runelite folder in ~/.runelite then it’s some where else
You may want to use bolt launcher, it makes a real file but also not in that folder location
silver flame
It's more, how do i --configure runelite from a jagexlauncher install
I've found the exe (cursed thing to say when running linux) but its failing to start in --configure mode with a similar issue as above (DISPLAY settings)
stuck shale
https://github.com/runelite/runelite/wiki/RuneLite-Launcher-Configuration#runelite-launcher-configuration it should be done like this?
silver flame
That only works with legacy accounts, no?
How do i get the jagexlauncher to run this instance of runelite?
sharp knot
The configure window works for Jagex accounts
rugged pivot
How do i get the jagexlauncher to run this instance of runelite?
broadly speaking you don't
you get the credentials.properties file so a non-jagex launcher client can use a jagex account
silver flame
Yeah i get that, but how do i configure the instance of runelite that jagexlauncher actually starts
rugged pivot
find where the installed version of runelite lives, run its executable with --configure, then run the jagex launcher and launch runelite from there to write the credentials
silver flame
Wait a second, do i just have an incredibly cursed install of the jagex launcher 🤔
rugged pivot
its linux so probably
stuck shale
The “best” is just bolt launcher
late sedge
bolt makes it a little less annoying
ember flareBOT
ocean tangle
I've just noticed that my plugin "prestige-mode" is marked as broken and unavailable. (Commit reference: https://github.com/runelite/plugin-hub/commit/3664e60528036e743a9910dcadff05dd056d6742)
Running locally I don't see any issues, I'd like to try and understand why it's been disabled and what I can do to fix any issues that have been seen. Somebody has raised an issue in the github repo about RL crashing when checking a kebbit deadfall trap but I can't reproduce that locally. Any advice here would be very much appreciated!
rancid marten
opal jay
Hi I'm super new to this, but I'd like to merge my plugin #11417.. Can anyone tell me what I need to do?
sinful lava
Hi I'm super new to this, but I'd like to merge my plugin #11417.. Can anyone te...
just gotta wait for someone to review it
opal jay
ahh okay thank you!
sinful lava
we'll poke you in the PR itself or in discord if we have any questions
ocean tangle
https://discord.com/channels/301497432909414422/419891709883973642/1489988985001...
Thanks for sending that. Is there anywhere documented what needs to be run using clientThread.invoke - I did a quick search on google but couldn't find anything useful. I have a bunch of calls to client which seem to be okay (client.getWidget, client.getSpriteOverrides) but the call to client.queueChangedSkill seems to be causing the issue. Moving this inside a callback via clientThread.invoke appears to solve the problem.
rancid marten
not really. mostly its anything which mutates the client
native notch
I have just made a new PR https://github.com/runelite/plugin-hub/pull/11763 for a new plugin and I'm wondering if it is eligible for the new method of PR reviews based on the build=standard in the properties. I am confused why it says 'Requires maintainer review' in my PR, but not in a PR https://github.com/runelite/plugin-hub/pull/11754 for example that was added a bit before
glass sandal
Certain APIs can't be reviewed by the bot and still need maintainer review
native notch
What can I do to fix that?
sinful lava
for now, nothing
glass sandal
Wait for a reviewer
native notch
With my previous PR it was eligible for the automated review, seems like a bug in Github then? I will test to make a new PR to see if that fixes it. It makes a big difference to have it automated or having to wait a long time for a review
grizzled aspen
no, as stated you are using apis that need manual review
with what your plugin is doing you are not going to be able to get around the required maintainer review for now
reef badger
also the automated review is broken right now so u really can't do anything to get it
native notch
I've found a similar functionality in key-remapping-plus, however that code also has the issue I ran into that both the spacebar and the rebind-button activate the click-here-to-continue. Whenever I rebind spacebar to something else, it completely stops working. I will try to fix that in key-remapping-plus
granite quest
when are varps set by the client? is it after the gamestate is set to LOGGED_IN?
glass sandal
When the server sends them which is after LOGGED_IN
granite quest
Thats what i thought, just confirmed looking at var inspector as well, ty
granite quest
Regarding the above issue, when going about fixing this would the below be appropriate?
clientThread.invokeLater(() ->
{
final var localPlayer = client.getLocalPlayer();
if (localPlayer == null)
{
return false;
}
processInfobox();
return true;
});
gray rover
Building RL on a new pc and running into this error: ```A problem occurred configuring project ':runelite-api'.
Could not resolve all dependencies for configuration ':runelite-api:classpath'.
Could not resolve project :runelite-gradle-plugin.
Required by:
project :runelite-api
Dependency requires at least JVM runtime version 11. This build uses a Java 8 JVM.```
I think I have it set to Java 11 in the project structure, not sure where it would be getting java 8 from
oak rock
do you have a JAVA_HOME set perhaps
gray rover
I don't think so, it's a relatively fresh windows install
gray rover
do you have a JAVA_HOME set perhaps
do I need to set that to something reasonable? Or is that just a potential cause of the issue?
oak rock
no, just it could be getting picked up somewhere and using that instead
gray rover
I don't think I have JAVA_HOME set anywhere
stuck shale
Did you install Java11 from chocolately?
I think that app can set the Java home path but i don’t see it there either
gray rover
Did you install Java11 from chocolately?
I don't think so but I don't remember, I just followed the instructions in https://github.com/runelite/runelite/wiki/Building-with-IntelliJ-IDEA and in theory that should have downloaded the proper JDK?
stuck shale
In command prompt you type java -version you get 11? Or is it 8
Idk why it would let you pick 11 and then default to 8 in IntelliJ
gray rover
well that's interesting
stuck shale
Thats sorta normal if its not set in path, idk if it needs to be for IntelliJ
You can set the path for jdk 11’s bin folder and see if it behaves but idk
Was just trying some stuff
gray rover
do I need to install java separately from downloading the jdk through intellij?
stuck shale
Not in my experience no
gray rover
how can I tell if I have java installed? Should I have a C:\Program Files\Java folder or is that not necessary? I can see a C:\Users\bigdi\.jdks\temurin-11.0.31 folder
stuck shale
IntelliJ puts it in that second spot I think
And no it doesn’t matter where it is, you install it anywhere and then your programs are told where to look for it. IntelliJ should be doing that automagically
gray rover
I don't see that .jdks folder in my PATH, should I add that somewhere?
stuck shale
You can try that yeah
Don’t see why not
I think you want the bin folder
Java/version11/bin
gray rover
like so?
stuck shale
If you reload cmd and type Java -version it should show 11 then
and you may want the system env, not user?
gray rover
alright cool, looks like that's a bit happier
stuck shale
lol
sinful lava
@shy pine see https://github.com/runelite/plugin-hub/pull/11776#issuecomment-4379378151 for your next release if you care
gray rover
Still running into some errors, I'm following the "how to build" guide, I get to the section that says "Select Run RuneLite.main() and wait a while for the client to build and start." but I don't see those options, where should I be looking?
stuck shale
reload gradle project is next thing i would try
rancid marten
in build execution deployment -> build tools -> gradle make sure it looks like
neon haven
The gradle jvm is a separate setting, (from memory) something like: settings -> build tools -> gradle -> Adams screenshot above
gray rover
oh yeah we're cooking now
well that doesn't seem great, but at least it's a new thing
stuck shale
Your gradle still looks odd in that picture
gray rover
gradle settings look okay?
arctic surge
I created the PR to takeover the scrollboxcounter plugin, changing the git repo to mine but leaving the commit hash the same. I noticed that the build is failing, did I do something wrong here? https://github.com/runelite/plugin-hub/pull/11777
stuck shale
gradle settings look okay?
The right side is blank
stuck shale
well that doesn't seem great, but at least it's a new thing
In the picture of the build
gray rover
I see that, how do I get it to not be that
sinful lava
I created the PR to takeover the scrollboxcounter plugin, changing the git repo ...
You've followed the instructions correctly - for older plugins you'll need to actually change the commit hash at the same time to update the runelite-plugin.properties file to include the build= option
shy pine
<@171762382685732865> see <https://github.com/runelite/plugin-hub/pull/11776#iss...
Hmm, is that true? Seems to look ok here. Thanks for the review btw
sinful lava
Hmm, is that true? Seems to look ok here. Thanks for the review btw
oh 
maybe i'm dank
shy pine
I do see some folks putting their build version in their runelite-plugin.properties file but this seems very inconsistent
sinful lava
oh yeah nvm you're using build=gradle, not build=standard, you're all good
i think you should be able to use build=standard going forward, but it would require you to rethink the version.txt feature. i think abex was looking to expose the version that's included in runelite-plugin.properties file
shy pine
I was just about to ask specifically about that hahaha
arctic surge
You've followed the instructions correctly - for older plugins you'll need to ac...
I already have a bug fix on my fork, do I need to force push to remove that to include the build= option? Or can I ship both at once
sinful lava
I already have a bug fix on my fork, do I need to force push to remove that to i...
I would strongly prefer if you only push the build= option commit
arctic surge
What do I specifically need after the build= btw?
sinful lava
You can make a new branch off the 98c1ec30e075be7b37a01be53081908746dc1db3 commit and include the build=standard change and push the commit hash from that branch, that way you don't have to do a force push
shy pine
i think you should be able to use `build=standard` going forward, but it would r...
Yeah it's important for me to track the version for compatibility checks on older saved files in Creator's Kit. Would be very nice if it weren't this... strange to accomplish that
sinful lava
as long as you're not doing anything weird with your build.gradle file, like including dependencies that aren't in the template file or adding additional build steps.you can use build=standard
arctic surge
You can make a new branch off the `98c1ec30e075be7b37a01be53081908746dc1db3` com...
so like this: https://github.com/RonnyTommy548/scrollboxcounter/commits/build-fix/ and also change commit hash in my plugin hub PR to 9b4071e39dc40d6d120fbdb58be3287bf1154026, despite what the takeover instructions say, as a special exception due to old plugin?
sinful lava
Yeah it's important for me to track the version for compatibility checks on olde...
i would've personally included a String VERSION = "1.2.3"; in your main plugin java file and add a workflow/document to ensure you update it in tandem with plugin updates
sinful lava
so like this: https://github.com/RonnyTommy548/scrollboxcounter/commits/build-fi...
yep!
shy pine
i would've personally included a `String VERSION = "1.2.3";` in your main plugin...
Ah yeah that's something I wanted to avoid, but was probably the best route from the beginning. Especially so now with RuneliteGPT
sinful lava
i think just keep build=gradle as-is for now until you can read the version from one place 
i know others would like to be able to read it from their plugins too
shy pine
Sounds good
autumn star
related to dayohs takeover request, any opinions on this to avoid one more misdirection from happening? https://github.com/runelite/wiki/issues/173
rancid marten
I think at one point there was a problem where we couldn't reliably diff plugins between repos if the repo + also plugin changed at the same time, is that still a thing?
sinful lava
It's not, no. I think it's still clean to keep the transfer PR separate from any unimportant changes
sinful lava
related to dayohs takeover request, any opinions on this to avoid one more misdi...
The support URL in the runelite-plugin.properties is not used iirc, we always link to the github repo's issues page.
I'm not sure updating the author field is really correct - the original plugin owner is still the author/an author.
autumn star
support url pointed to the old repo until i changed that file when i took over protect-item-notify 🤔
sinful lava
As in, in the plugin sidebar, you right-clicked & clicked "Support"? or on the plugin hub website https://runelite.net/plugin-hub/show/quest-helper
autumn star
website, cant remember if i tried from the sidebar
stuck shale
probably because in take overs people didn't change it 😄
autumn star
gray rover
back from lunch and trying to get dev to build again 😄 how do I get the gradle thing to actually do its thing?
topaz pierBOT
[ https://github.com/damencs ] [ @tidal stag 241037329408458752 ] damen#0
rancid marten
@tidal stag seen a few people report some new issue with 238 and tob-qol, can you look into it now?
tulip wagon
back from lunch and trying to get dev to build again 😄 how do I get the gradle ...
close the project, delete the .idea folder in it, re-open, it should auto-detect gradle and load correctly
gray rover
close the project, delete the .idea folder in it, re-open, it should auto-detect...
gave that a spin but now it's running into a dependency issue, I think?
tidal stag
<@241037329408458752> seen a few people report some new issue with 238 and tob-q...
I can take a look. Any general direction of issue? Doesn't load at ALL or? I haven't seen any reports personally.
rancid marten
bloat chains not being removed
I think it might be something with removeGameObject() not working
glass sandal
tidal stag
Thanks Coop.
rancid marten
I think we see the issue and it is just removeGameObject() isnt working
tidal stag
I think we see the issue and it is just removeGameObject() isnt working
I'm talking to someone that is already taking a peek and it is successfully removing chains, but there are 4 that aren't. I'm watching a fresh TOB run to see comparison of it.
rancid marten
it would only happen with gpu on i think
tidal stag
it would only happen with gpu on i think
The method is working WITHOUT gpu.
rancid marten
yeah
tidal stag
This was written an eternity ago, so I am happy to realign to necessary approaches.. if you guys are refactoring things intentionally around this area.
rancid marten
its definitely a client bug i just didnt know what was wrong with it
tidal stag
Let me know if you need any additional information or want testing again on a new version.
tidal stag
its definitely a client bug i just didnt know what was wrong with it
Nylo Pillars are NPCs, so that should be treated differently.. so it spans beyond Game Objects - fyi.
tidal stag
Sorry.. refreshing myself a splash. The pillars are "npcs" but also game objects. The pillars are hidden as a game object.. with the same method as the bloat chains.
amber rampart
are you sure they aren't game objects with an invisible npc for the healthbar?
rancid marten
Sorry.. refreshing myself a splash. The pillars are "npcs" but also game objects...
to be clear you are getting the GameObject which has .getRenderable() instanceof NPC?
and removing that?
amber rampart
he is removing the loc TOB_NYLOCAS_SUPPORT_PRISTINE
ember flareBOT
amber rampart
so its the same thing as the bloat chains
rancid marten
yeah, ok
tidal stag
Correct.
It is just odd that SOME of them are removed.. but not all.
With GPU off.. NONE of them show.
rancid marten
gpu off uses a different renderer
tidal stag
GPU is on for that screenshot above.
Just trying to give you information that maybe is useful. I'm not even sure what has been changed between the versions.
rancid marten
@tidal stag can you test latest.integration in like 10 minutes?
tidal stag
Pulling and building. Will keep you posted.
rancid marten
Pulling and building. Will keep you posted.
make sure it says patch 25397377789.125
tidal stag
It's working now.
For bloat. Testing Nylo as well after bloat.
Nylo is good as well.
rancid marten
ty
tidal stag
Anytime. Thanks for the ping.
silver flame
If i have a minor code change to a plugin, and documentation changes, is it preferred to update the plugin in two steps (one with just code, one with documentation) to make it easier to review, or keep it as one review to not spam?
sinful lava
if it's code change + documentation change, feel free to leave it as a single PR
ashen idol
doing some more experimenting with rlobjects tonight, drawing them isn't expensive right? lets say just some random model from cache, cloning it and maybe modifying the transparency of specific vertices
cant test yet but just curious if they behave whole lot differently compared to java2d ^^
tulip wagon
doing some more experimenting with rlobjects tonight, drawing them isn't expensi...
They're rendered in the same way that other in-game objects are so, they're not more costly than any other object in the scene
The API around them (including animations) are pretty thin wrappers around the corresponding internals
ember flareBOT
ember flareBOT
fierce chasm
I'm attempting to use this method to play positional sound effects: https://static.runelite.net/runelite-api/apidocs/net/runelite/api/Client.html#playSoundEffect(int,int,int,int,int)
But I've had no success, so far. I've even tried manually passing in coords from the debug menu to originate from my players location. I'm hoping I'm just passing in incorrect values, and that's why it isn't working.
The docs say @param x the ground coordinate on the x axis I'm not sure which coordinate system it means, I must be missing something
I tried Local, World, and Base coodinates, but there's still no audio. If I use playSoundEffect(id, volume) it works, it's just no longer positional audio
If anyone has any ideas, please let me know
amber rampart
they are scene coords I think
fierce chasm
That doesn't seem to work either
I'm using public void onAreaSoundEffectPlayed(AreaSoundEffectPlayed event) and logging the event's scene x and y, and they come out as 54, 49. Trying to replay the sound with the coords does not work
I'm assuming the api isn't broken, but I feel like I've exhausted my options
amber rampart
it works for me
fierce chasm
What are you passing in for range and delay?
amber rampart
1, 0
muted bone
would someone be able to check this hot fix for me please?
https://github.com/runelite/plugin-hub/pull/11780
fierce chasm
Maybe it has something to do with the event being consumed before I try playing the sound? This is strange
amber rampart
you aren't consuming your own sound are you?
muted bone
ty Abex ❤️
fierce chasm
you aren't consuming your own sound are you?
Maybe I am if this doesn't behave the same way normal sound events work? I have it simplified down to this for debugging:
@Subscribe
public void onAreaSoundEffectPlayed(AreaSoundEffectPlayed event) {
event.consume();
client.playSoundEffect(2562, 50, 65, 1, 0);
}
But if I change that line to client.playSoundEffect(2562, 127); I can hear the sound just fine
Maybe if it's like queuing the sound effect when you use positional audio, it actually cancels the sound?
amber rampart
you have area sounds unmuted right?
fierce chasm
Good idea I'll try that out after dinner. Thanks
amber rampart
and you are going to be consuming your own soundPlayed event
fierce chasm
Right it'll trigger this function again, interesting
Curious how that should be handled
amber rampart
probably just set a flag in your plugin to ignore the next event
its guaranteed to be synchronous
ember flareBOT
rancid marten
hmm bridges
low hatch
Oh still on the old profile, works on ground level but not when you step up to the stone floor @ GE - still thinks you're on ground. Same with the new profile.
glass sandal
At some point in the past the distance which you could see NPCs was decreased. Although I've noticed at tempoross you can see the jumping fish animation although the fishing plugin doesn't highlight it and onNpcSpawned events don't fire until you get closer. Is there a restriction in npc events? Or does the client know about animations from a further distance compared to NPCs?
ember flareBOT
rancid marten
At some point in the past the distance which you could see NPCs was decreased. A...
i dont think the distance you can see npcs has ever changed in the history of osrs
glass sandal
I don't know the exact date but NPC Idle Timer used to show on the barb fishing spots when you banked at CoX bank. But now when you run that same distance the NPCs unload
rancid marten
weird
ember flareBOT
serene wharf
the tile height change in 1.12.26.1 seems to have broken quite a few things
rancid marten
i blame @low hatch
rancid marten
does it affect ground items?
serene wharf
Yeah
the text clips through the item model
I am watching a stream people complaining to me about this
serene wharf
Might be unrelated then or a hub plugin I can’t tell
The player indicators though is quite annoying though
I don’t remember if that is core or not
it does seem like a regression
rancid marten
looks pretty ok at least not on a bridge
serene wharf
yeah looks good in sote room
except on the stairs before the room
Elevated surfaces i guess
rancid marten
id believe that, i dont believe ground items are broken
glass sandal
It just seems odd to me you can see the leaping fish which is TEMPOROSS_HARPOONFISH_FISHINGSPOT_SPECIAL but it isn't tracked as an NPC. But maybe that is expected
rancid marten
devtools overlay might be culling it
serene wharf
@rancid marten if u push to maven i can test
glass sandal
But the fishing plugin doesn't highlight it either. Neither does the Tempoross plugin notify for it
rancid marten
maybe its a spotanim or loc or something
serene wharf
fixes it for NPCs too ^ (previously nylos walking down the lane would have a similar bug)
ember flareBOT
low hatch
i blame <@108379014145511424>
Hey hey I didn't ask to make the changes 😏
ember flareBOT
sharp hawk
Dont want to be a pest but any update on the camera issues? Its rather annoying 😅
rancid marten
can you be more specific?
sharp hawk
The top down one and the jitter when doing certain leagues animations, tbf im still at work so im unaware if its been addressed
rancid marten
i think that was fixed yesterday, have you checked since yesterday?
glass sandal
Barb gathering calcified rocks looks fine for me
sharp hawk
I have not, sorry if it was a stupid question 😅
frigid bronze
I don't know if this is a Jagex client or runelite issue, but Actor#getInteracting() appears to never clear after today's update
stuck shale
yeah jagex broke sometihng
glass sandal
Jagex issue
serene wharf
i think that was fixed yesterday, have you checked since yesterday?
Camera is still forced to like an up-down angle at bridges
even with extended pitch limit off
it's different to what it used to be
rancid marten
i dont really believe that / if you want me to do anything other than tell you to go away, provide specific evidence
serene wharf
Maybe it's the pitch limit being off
It just felt weird the entire day but I guess it might have been the pitch limit extension being off
ember flareBOT
sharp hawk
all seems normal now on 1.12.26.1, regarding both the extreme pitch angles and the camera snapping down on certain animations
ember flareBOT
rancid marten
i am also fixing the facing moonwalking thing with this i think but I am not very super confident in it
so I guess lmk
ember flareBOT
deft hatch
Could you please make an updated graph?
rancid marten
deft hatch
bit hard to tell, but PRs are going up again?
faster review, so maybe people submit more PRs?
rancid marten
yeah a lot of people cant think more than a few minutes ahead and will submit multiple a day
also it was offline for like 3 days earlier this week due to an issue
hoary spindle
induced demand strikes again
arctic surge
I opened a relatively small PR on lemon duck's ToA plugin 1 week ago, which we briefly discussed & agreed on in discord. I've been looking forward to a review on that. However, I'm starting to realize that this is pitted against all of lemon duck's other work, like reviewing runelite plugin hub PRs, and other plugins that lemon owns, other longer-standing or more important issues/PRs within those plugins. I was thinking about pinging lemon about my PR but I don't want to come off as a nuisance, seeing how my request is one of many.
What do people normally do in this kind of development scenario? This one is a little different than my situation with scrollboxcounter plugin, where that guy is MIA and I had to initiate the takeover process to get my fix through. Lemon duck just seems to have a lot of work going on. Is there a way to see if there are other collaborators on the ToA plugin I could ask? If not I guess I just have to wait patiently, maybe remind after multiple weeks incase it's forgotten. Just thinking out loud here
rancid marten
yes ping llemon, she is around
arctic surge
@tulip wagon Do you know when I might expect a review on PR #139 for Tombs of Amascut plugin? It's that idea I brought up last week for only labelling healing swarms (w/ index rollover logic), fairly small/straightforward diff ~50 lines. All good if you're not able to get around to it for a while, just looking to understand/make sure it wasn't forgotten
late hare
Is this part actually a jagex bug or just getInteracting() not accounting for when it's reset
rancid marten
people keep saying its a jagex bug but the character isnt visibly facing the thing
so i dont understand that really
glass sandal
With fishing spots the character turns to face the fishing spot after it has moved
stuck shale
With fishing spots the character turns to face the fishing spot after it has mov...
a rapid way to see this is at minnows
rancid marten
glass sandal
rancid marten
the fishing thing seems like it would be unrelated
if you arent facing it then you just arent facing it
rancid marten
like theres no way that this explanation makes sense
stuck shale
i thought it was because you're interacting with it without moving towards it, like you can interact with players by using a spell on them when at the ge
#support message this guy had an opinion but idk who he is
glass sandal
Well then there's a runelite API bug with interacting but I'm not able to determine if that's the case
rancid marten
who the fuck is this
glass sandal
[[Isles]]
Another example, after unnoting bones on Virilis and then blessing them on the exposed altar it still shows you're interacting with the NPC
rancid marten
Is this part actually a jagex bug or just `getInteracting()` not accounting for ...
do you know what it does when it resets
late hare
uhm yeah sec
bb.ag is set to lf.ak, but the other fields are not cleared which is why it's broken atm
rancid marten
oh i see
late hare
lol yeah idk who that is
glass sandal
Given artefact lures were broken I just assumed it was all NPC-player interactions and not a runelite api issue
rancid marten
there is a mix of rl api broken and also the server is broken atm
which makes everything confusing
and also the clientis broken
basically, everything is broken in different ways
late hare
`bb.ag` is set to `lf.ak`, but the other fields are not cleared which is why it'...
actually to clarify, it's set to lf.ak when facing an entity so really just need to check if that field is equal to it in the api I guess
late hare
perfect then
rancid marten
i dont understand why this is so complicated
late hare
yeah these facing changes are def something
the server also faces objects incorrectly since it says the size of them are always 1x1 for some reason (though that was broken in 237 server sided too)
so you just always face SW tile
rancid marten
was it broken in 237 or did you just notice it there
late hare
it was broken in 237 too, but they calced the angle server sided
late hare
pretty sure it broke in 237
rancid marten
do you have a good example
glass sandal
Would that be the odd pathing problem people noticed?
late hare
i assume it broke in 237 as prep work for these facing changes, but somehow they ended up discarding the size of objects along the way
but who knows lol
rancid marten
we never got a repro for the pathing thing did we
idk im being gaslit pretty hard i think the last day or two
yday someone in #support tried to convince me you are supposed to be able to move your camera below terrain
i looked into it a bit and i really dont see anything wrong
late hare
below... idk about that lol
late hare
even if you could, why would someone want to do that
late hare
would this be a good time to tell you another bug (cache related) to pass on
rancid marten
sure
late hare
for some reason there's some sounds being repacked every update since 237
with new ids
while keeping the old
rancid marten
so its duplicating the sounds?
late hare
yup
rancid marten
do you know which ids
late hare
the latest ones are 11505 11506
i have a theory that it's because they both end the name with a space
rancid marten
that sounds stupid enough to be true
late hare
they have these dbrows that i assume are generated from disk somehow at one point
and this entry (and another one) keep changing ids
and notice the space at the end.. 😄
rancid marten
yeah
late hare
rancid marten
ive been discovered
late hare
we never got a repro for the pathing thing did we
do you have more info on this? like what the issue actually is
rancid marten
no i think its not real
essentially every day we have people come into #support and make fucking insane claims
and occasionally they do that on the same day as engine updates
and it makes my life hard
late hare
because there is a weird one if you do an interaction then spam click to do another on some other thing
but idk if it's referring to that
glass sandal
do you have more info on this? like what the issue actually is
This was what I was thinking of https://reddit.com/r/2007scape/comments/1t5f1ut/new_vorkath_pathing_issues/
rancid marten
but some of the other people were insisting its been happening for over a week which means it not related to 238
but ive not been able to get an actual info about it
late hare
oh maybe not, that vid is from yesterday
ember flareBOT
late hare
yup, is fixed
rancid marten
i liked it more when everything was just ints
late hare
yeah i feel like their refactors are moving things to new objects and using enums a lot more
rancid marten
https://www.reddit.com/r/2007scape/comments/1t6egf6/jagex_priorities/ even this says pathing is broken since leagues ?? what does that mean
Reddit
glass sandal
I’ve also seen this about follow pathing. But suhdude in the replies says it’s been happening since Brutus or Sailing so idk https://x.com/eliopdagod/status/2050075510789882216
stuck shale
I’ve also seen this about follow pathing. But suhdude in the replies says it’s b...
it happpened a lot in dmm
i noticed this exact pathing in dmm
thojught it was a pvp thing lol
ember flareBOT
tulip wagon
<@138318226181324800> Do you know when I might expect a review on PR #139 for To...
thanks for the reminder, i'll try to look at it today
low hatch
Thank you
reef badger
what was the conclusion on this u and polar started talking in symbols so i stopped reading
glass sandal
It's actually a runelite internal bug that Adam fixed
reef badger
litty
reef badger
that guy really said do not speak to me apple scum
late hare
dont think there's been another release with the fix yet either lol
late hare
@rancid marten did you add the same check to Actor#isInteracting too?
late hare
idk it's unused in core, you added it 😛
rancid marten
idk
glass sandal
Leave it to the plugins to implement haha https://github.com/m0bilebtw/c-engineer-completed/blob/1afd76d4a06cb9b904fe67436dd6953ca8b11371/src/main/java/com/github/m0bilebtw/player/CEngineerPlayer.java#L140-L148
rancid marten
well this returns true if you are interacting with something you cant see
which idk if that happens
maybe
ember flareBOT
sharp hawk
clicking an object and npc in a very short time span causes interact highlight to get confused and highlight both
ember flareBOT
shadow stirrup
https://github.com/runelite/runelite/pull/19978 Anyone able to take a quick look at this sometime?
ember flareBOT
ember flareBOT
ember flareBOT
tight loom
is it allowed to store a click that failed due to things such as animations/cooldowns and display that to the player so they know the click never registered?
oak rock
sounds fine to show feedback like that
you just cant store it and fire it off again when it would have worked
tight loom
also question about prayer flicking helper
if I could detect the pattern of attack per enemy and display that as a indicator when to click the prayer would that be allowed?
grizzled aspen
No
topaz pierBOT
Jagex's third party client guidelines: https://secure.runescape.com/m=news/third-party-client-guidelines?oldschool=1
Additionally, these features have been rejected or removed from RuneLite: https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features
glass sandal
Indicates what prayers to use in what order, for example in the Cerberus boss fight
tight loom
it seems to be boss focused, but im guessing its just the example they used and it applies to all enemies as well?
glass sandal
Indicates what prayers to use in what order
Does not say its a boss restriction, it says combat
tight loom
cool, well thats good
so even if it didnt state what prayer to use and only gave you a window of time indicator it would still be disallowed?
restive garnet
Cerb was just a good example since most people know about that effect
oak rock
yes
restive garnet
I'd say that's still bad
tight loom
gotcha
- Next attack prediction (timing or attack style)
Yeah looks like this covers it
oak rock
entity hider can hide 2d
dusky prism
Normally don't call out plugin PRs, but we had an aggressive default keybind that I've removed (shift + space), among other very small changes.
Sorry about that ...
https://github.com/runelite/plugin-hub/pull/11833
oak rock
this is gonna reset it for everyone that changed it themselves though
sinful lava
i merged 
oak rock
but that still would be better than how it currently is
solid shadow
this is gonna reset it for everyone that changed it themselves though
I think thats a good thing in this case
sinful lava
that was my thought too
dusky prism
yeah that was my opinion as well
tight loom
yeah I was thinking the same thing (i wasnt)
dusky prism
its when i went to type S I T that i realized how bad it really was
oak rock
the ol lesser of two evils play
solid shadow
the people that changed the keybind know its a keybind so they will find it again 
glass sandal
Could've written a migration if the config wasn't shift+space but oh well
tight loom
am I supposed to have a role once my plugin is approved and on runelite?
restive garnet
It requires a certain number of commits to the plugin-hub repository for the dark purple name colour
glass sandal
Github API only returns the top 500 contributors by commit count
restive garnet
I think the barrier is... 7 commits at the moment?
tight loom
oh thats odd lol
restive garnet
They can't help the Github API's limitations in that regard
tight loom
would kinda be cool to have roles based on how many active users their plugins had
upper valve
lol
ember flareBOT
ember flareBOT
ember flareBOT
ember flareBOT
low hatch
Lowkey wish the feature was in core 😔
glass sandal
The problem is getting someone to test all of the exact areas as opposed to just using the worldpoint from cache
reef badger
yes putting info that the plugin is "not sure about" is not a valid option for core plugins
low hatch
yes putting info that the plugin is "not sure about" is not a valid option for c...
Obviously 😂 I didn't mean that plugin in its state. I meant the boundaries feature generally 👍
low hatch
The problem is getting someone to test all of the exact areas as opposed to just...
True true