@misty meteor i've created a pull request that fixes the build error for the Cox External Scouter. I can see that you've approved quite a few the past year for other fixes but never pull requested these onto plugin hub itself, so if you do merge it please remember to create a plugin hub PR
#development
brisk sedge
misty meteor
I have not yet tested the changes and am not comfortable making a PR without testing
brisk sedge
i did a test run with the latest changes in the repo and can confirm that the olm overlay fix does work atleast
misty meteor
so I'll try to make time today to do so
ember flareBOT
sand wing
Will resolve later today for hunter rumours, thanks
timber cairn
Was this ever answered or figured out? An additional odd behavior is if you manually send a message with an effect, using setOverheadText will then keep using that effect.
dry oriole
Was this ever answered or figured out? An additional odd behavior is if you manu...
i just dropped it iirc since it didn't look like there was a quick solution
you could try this i guess, though personally I don't really know what it'd entail
glgl
worthy sparrow
I'm guessing scale isn't just (percentage, min, max) ?
if ($int0 < 60) {
cc_settrans(scale($int0, 60, 200));
} else {
cc_settrans(scale(calc(120 - $int0), 60, 200));
}```
rancid marten
long var14 = (long)class48.intStack[ItemContainer.intStackSize];
long var10 = (long)class48.intStack[ItemContainer.intStackSize + 1];
long var12 = (long)class48.intStack[ItemContainer.intStackSize + 2];
class48.intStack[++ItemContainer.intStackSize - 1] = (int)(var12 * var14 / var10);
so $int0 * 200 / 60
worthy sparrow
o, ty
prime bane
since last update there's an issue with the fixed mode hide chat plugin. Based on the amount of open issues from long ago, it seems the plugin owner will probably not fix it. Any idea how to fix this?
rancid marten
if someone wants to maintain it they can step up and fix it
reef badger
riktenx has collab
rancid marten
it looks like ritken has writen access though
reef badger
ye
rancid marten
so.. its fine
clever basin
fixed and sent pr for unmutedjingles 
hollow sonnet
since last update there's an issue with the fixed mode hide chat plugin. Based o...
The Fixed Resizable Hybrid plugin has almost the same functionality and is somewhat maintained (the author's last update was 4 months ago). It's also broken, but I submitted a PR with a fix, hopefully the author checks it soon. Mentioning it in case it gets fixed first and you wanna check it out.
rancid marten
I think ritken maintains the other one, its not really unmaintained
upper valve
ok i may have time to check towards the end of work, but if not then later tonight
sonic quest
Quick question.... am i allowed to drop an F bom in here?
oak rock
Never know till you try
sonic quest
Cause holy .... I got the jagex account working with the whole flatpack/snap situation...
sonic quest
Never know till you try
best response i could have hoped for ❤️
Thanks everyone who helped this morning! Had to traverse my entire pc to find the files that were playing a part in this all
Long story short;
I magically found the RuneLite.jar in ~/.local/share/flatpak/runtime/com.jagex.Launcher.ThirdParty.RuneLite/x86_64/stable/<some-hash>/files
Then i ran said jar using java -jar RuneLite.jar --configure and set the required flag as described on the wiki.
This gave me a settings.json in the exact folder (deep in .local) which i had to move to ~/.var/app/com.jagex.Launcher/.runelite
Now running the flatpacked Launcher with flatpak run --verbose com.jagex.Launcher showed the flag being passed when starting RuneLite. The credentials when then written inside said .var folder.
Finally moving the credentials to my ~/.runelite folder fixed it and allowed me to use my JagexAccount for plugin development
Im not even running Arch
worthy sparrow
there's like a 20% chance if I hot reload now my client just dies
rancid marten
Do we need to do anything for the 2006 style?
worthy sparrow
no
topaz pierBOT
Search for raiynl returned no results.
glass sandal
That’s @worthy sparrow
rancid marten
at some point one of these many github outages is going to align with a game update
rancid marten
im not sure i would try and merge stuff while it is still red
upper valve
i guess yeah
twin rover
hey guys quick question, since i have a newish github acc, i was told thats why my plugin doesnt run the workflow unless manually, do you guys know how long github takes to let me test workflows or is it just after i (hopefully) get my plugin added it works?
worthy sparrow
which one
twin rover
mazchna skip
worthy sparrow
i need a link or pr number
upper valve
i think after you merge one pr it doesn't require manual approval anymore. i don't ever recall having to press the button for an update plugin
twin rover
that will be nice and save a little time for reviewers once i do it auto, thanks rikten
upper valve
keyword i think
twin rover
we will see in a few weeks :p
lavish ice
at some point one of these many github outages is going to align with a game upd...
I think it has once
rancid marten
has anyone tried this ij local llm thing? (not the paid one)
sonic quest
I believe I had full line code completion enabled for some time...
rugged pivot
if its anything like the local one pycharm had during my free trial it will make my fans go brrr
still sounds like its paid though?
(it was competent for python at least)
rancid marten
yeah its part of ultimate, there is a separate junie thing that you pay for tokens I think separate
rugged pivot
ah I see
sonic quest
Mine gave some very weird responses sometimes... Even switches to French strings from time to time. Had to disable it since going with standard completion was faster for me
rancid marten
lol
rugged pivot
weird
neon haven
has anyone tried this ij local llm thing? (not the paid one)
Generally been good when I've used it. That's mostly for spring boot stuff though so lots of training material
I'd say at least half the time it suggests exactly what I was about to type anyway
rose void
I haven't tried plugin development with a paid model like sonnet or opus (they are good for my day job at least)
But any free tier subscription has been absolutely horrible at runelite plugin development
rugged pivot
there's a difference between free tier of a cloud AI and a local model for line completion
rose void
I have done both
rancid marten
I dont want it to write an entire plugin, just for completing a few lines
lavish ice
has anyone tried this ij local llm thing? (not the paid one)
Yeah, it’s pretty decent
ember flareBOT
quick path
augh, my least favorite bug about config
reef badger
i hate bugs where the workaround is objectively simple
worthy sparrow
Right click set to empty and it fills it with "empty"
native harbor
What would be the best appropriate way to attribute on the LICENSE file?
reef badger
what does the license say to do
native harbor
what does the license say to do
I've clearly read the license, but it's not computing in my head the exact layout in which it should be described, else I wouldn't be asking >.>
I guess a condescending helper was a brilliant idea.
sinful lava
what is it you're trying to do? it's hard to tell what type of attribution would be useful
Are you forking/massively copying from another plugin? you probably want to include their original copyright / augment it in the LICENSE file https://github.com/pajlads/DinkPlugin/blob/master/LICENSE#L3-L4
Jake Barter in this example is the original creator of the plugin that we forked from
native harbor
I apologize if I was too vague. The license layout - Do I add attributions to the bottom of the specific license layout, or add the copyright with name (link) at the very top?
sinful lava
I don't know what you mean with "the license layout"
native harbor
So, if I made a plugin, but used source code from another plugin that I modified would it be:
BSD 2-Clause License
Copyright (c) 2026, Kalsupes
All rights reserved
Copyright (c) 2023, User1 (Profile/Plugin)
Copyright (c) 2021, User2 (Profile/Plugin)
Redistri.......etc..
sinful lava
that seems reasonable if you're copying major parts of a plugin yeah, similar to the example i linked here #development message
native harbor
Or do I add their license agreement in it completely (multiple licensing agreement) with their copyright at the top?
sinful lava
I think both options are fine
make sure to keep their copyright notices at the top of source files
native harbor
Okay - I made it the second way, but wanted to simplify it, but wanted to ensure it was acceptable to do so.
thorn grotto
no, you cant remove the license from top of the file if it's there originally
native harbor
Thank you @sinful lava
fluid stump
https://github.com/runelite/runelite/discussions/17089 is discussions even used ,or is it mostly issues? still kind of looking for this 🙂
rotund pier
A small question about bronzeman unleashed, it was mentioned during the PR that ideally we should be replacing another plugin with the idea of having BU exist temporarily alongside another one of these plugins,. Where we would be deprecating one of them and having their users migrate over, as well as providing an easy way to do so.
Is this still something you would want us to do?
We are planning of at least already providing some migration tools for players that want to do so themselves already.
Could for example fork one of the existing bronzeman plugins, only adding a small but clear message during login that states that the plugin is deprecated in favor of, and suggesting them to migrate over.
My suggestion would be then to take the place of dekvall's bronzeman plugin since it is abandoned, and it should be relatively easy to do a migration for (all data also lives locally for it).
sinful lava
A small question about bronzeman unleashed, it was mentioned during the PR that ...
I don't think you don't have to do anything more with other bronzeman plugins. it was more in the scenario where you would be able to let current bronzeman players just keep playing but with a better experience (so improving an old plugin instead of making your own plugin).
If the current maintainer of an old bronzeman plugin allows you to place the deprecation notice with migration hints in their plugin, that's perfectly fine. it would go through the normal plugin hub update process.
I don't like the idea of doing a takeover of an unmaintained plugin only to put a deprecation notice in it personally.
rotund pier
I don't think you don't *have* to do anything more with other bronzeman plugins....
Alright, thanks for the quick response 😄 .
ember flareBOT
ember flareBOT
languid iron
^^
rose void
for anyone in the future dealing with vscode on windows saying your repo is not a java project, I finally managed to fix mine doing this:
- nuked
C:\Users\{user}\.gradle(dont know if this actually helped) - nuked
C:\Users\{user}\AppData\Roaming\Code\User\workspaceStorage(also unsure if this helped) - ensured
$env:JAVA_HOMEreturned a value in powershell and if not set it in the windows env vars - downloaded/installed the latest jdk 11 and added these lines to the vscode user settings.json
"java.jdt.ls.java.home": "C:\\Program Files\\Eclipse Adoptium\\jdk-11.0.30.7-hotspot",
"java.configuration.runtimes": [
{
"name": "JavaSE-11",
"path": "C:\\Program Files\\Eclipse Adoptium\\jdk-11.0.30.7-hotspot",
"default": true
}
],
"java.import.gradle.java.home": "C:\\Program Files\\Eclipse Adoptium\\jdk-11.0.30.7-hotspot"
the vscode plugin seems incapable of making smart decisions and you must force it to your will
random kraken
https://github.com/runelite/runelite/discussions/17089 is discussions even used ...
This would be awesome, it'd let me fix a certain kinda broken plugin with wayyyy less code and debugging
bitter chasm
What's the proper way of checking whether a player bought something from X store? Is there a specific event for something like this? Including reward shops like Mixology Rewards, Mage Training Arena shop, etc
stuck shale
they'd trigger a collection log screenshot/ their collection log would show they've gotten it
bitter chasm
What if it's a regular shop for example? Or a second purchase of an item that wouldn't trigger a collection anymore?
glad ermine
Is runeprofile hosted by a volunteer out of pocket?
sharp knot
What if it's a regular shop for example? Or a second purchase of an item that wo...
You can probably look at MenuOptionClicked and maybe also ItemContainerChanged events
heavy bobcat
Is runeprofile hosted by a volunteer out of pocket?
Looks like they have a discord. Probably better to ask there
bitter chasm
You can probably look at MenuOptionClicked and maybe also ItemContainerChanged e...
Tried that currently, yep. But didn't work for Mixology Rewards shop as expected currently. Will keep digging. Seems like I'm on the right path then I guess.
ember flareBOT
native harbor
I am new to GitHub - I am submitting my Plugin to Runelite following the direction. After comitting the changes:
"Sorry, we had to truncate this directory to 1,000 files. 582 entries were omitted from the list. Latest commit info may be omitted."
I misread - It's rferring to the plugins directly, not my actual files. - Ignore me.
split lava
Sorry if this message belongs in #support , but I think its more developer based. I want to find and download the sprites for these sorts of images that show up in the hiscores plugin sidepanel, for a separate OSRS project (not a runelite plugin). How would I go about finding and downloading those images?
reef badger
they're in the games cache https://abextm.github.io/cache2/#/viewer/sprite
look at what numbers the hiscore plugin is pulling to match the sprite there
amber rampart
grabbing a dump from here might be easier if you just want pngs https://github.com/abextm/osrs-cache/releases
reef badger
o ya that's true
split lava
I had that link saved in my projects README (but i failed to describe what to actually do with it when I added it in there previously lol) so I forgot how to actually extract the stuff from there
I downloaded the .tar.gz file but looking inside I just see a bunch of .flatcache files that I am not sure what to do with
amber rampart
download the dump not the source code
split lava
ahh thank you! thats what I was missing 🤦♂️
appreciate your work on that repo it is a godsend
So I looked at the hiscores plugin and it seems to be referring to this https://github.com/runelite/runelite/blob/master/runelite-api/src/main/java/net/runelite/api/gameval/SpriteID.java
Is my understanding correct that - for example, to get the new cow boss Brutus image - I search in that SpriteID.java file for "brutus", I see that within the IconBoss25x25 class, Brutus is mapped to _69, which _69 is mapped to 6352. So in this cache viewer here https://abextm.github.io/cache2/#/viewer/sprite I just search for 6352 and then boom I find the picture and I can do whatever I want with it
Is that all correct?
(I could also download the cache and go to dump/sprites/6352.png as well, yea?)
amber rampart
yup
split lava
Sweet. My old bookmark I had led me to this different SpriteID.java file, that seems to have not been updated in 9 months https://github.com/runelite/runelite/blob/master/runelite-api/src/main/java/net/runelite/api/SpriteID.java
Just for my own curiosity, what is the difference between that one (/runelite/api/SpriteID.java) and the new one I found (/runelite/api/gameval/SpriteID.java) ?
late hare
gameval one is generated from the names jagex supplies + some manually done
amber rampart
the non gameval one is old and just there for phub api compat
split lava
gotcha. thanks!
pastel tree
Hi. I noticed runelite cpu-usage can get pretty high on initial startup these days. Can anyone explain why?
Like upon logging in, cpu usage spikes for a bit, before coming down.
low hatch
Shot at the dark here, perhaps it's all the plugins registering to the event bus?
Or plugins writing to disk, lately I've learned io options are not fun when it comes to performance 😬 (looking at you bank tracking plugins)
upper valve
@shy pine i think we might have to amend the hub bingo to replace bingo plugins with flipping
rancid marten
Did something happen to cause the influx of flipping plugins lately?
also if a few people could try out the new gpue plugin on the pluginhub that would be helpful
quick path
Did something happen to cause the influx of flipping plugins lately?
Critical mass of claude code users combined with a void of creativity
restive garnet
And given the prevalence of 'premium' versions, probably a bit of a cash grab too
stuck shale
And given the prevalence of 'premium' versions, probably a bit of a cash grab to...
Yeah that’s probably what it is.
shy pine
<@171762382685732865> i think we might have to amend the hub bingo to replace b...
Yooo gz on unlocking Better Bingo, the free DLC!
rugged pivot
my white whale is dev-ing a plugin that ticks off "should just be core" and "actually just breaks TOS"
shy pine
my white whale is dev-ing a plugin that ticks off "should just be core" and "act...
Already working on something similar. The long term plan to bring Creator's Kit to core includes requiring it to be installed and enabled in order for Wyrmscraig (the player designed island) to even render
low hatch
Did something happen to cause the influx of flipping plugins lately?
Idk how y'all maintainers don't just rip your hair out after seeing the 10th ___ plugin be PRed
kindred rampart
Uhhh it's been like many months since I made this PR #19249. Is there any chance it can get reviewed? I'd imagine it'll have to be updated a bit but the work was already done and I know some people appreciated the addition.
topaz pierBOT
neat wyvern
Yooo gz on unlocking Better Bingo, the free DLC!
I'd look for "Wicked sound playing code" on a bingo
chrome grove
what size icon for side bar is good?
reef badger
check the size of a default plugin, with an icon would be the easiest, i dont remember off hand
if nobody answers before u do that
chrome grove
alright
low hatch
Loot Tracker is 20x20
Dev Tools is 16x16
Should be fine anywhere between 16x16 to 32x32? Just make sure it's 1:1 I reckon.
ember flareBOT
tulip wagon
very likely!
grizzled aspen
I’m on kalshi betting on custom anchors vs reorderable sidebar merging first
low hatch
Thanks
knotty lintel
also if a few people could try out the new gpue plugin on the pluginhub that wou...
worked well on macOS 🙂 300 FPS 🚀
reef badger
i believe usually when it comes to GPU plugins he just wants you to play the game with it
to see if u run into issues (assuming you didnt already do that)*
kindred rampart
Me when ignored completely 😮
reef badger
that wont be looked at by anyone other than Adam and he's always got a billion things to do
so idk
maybe abex but probably not
kindred rampart
Rip
amber rampart
I was thinking about that the other day, maybe we could synthesize mouse >3 as special key events
if we could synthesize them globally we wouldn't have to worry about compat issues from plugins not using mouse listeners, and we wouldn't need 2 new keybind classes
I'm not sure we could remap middle click like that, idk if anyone cares about that
knotty lintel
i believe usually when it comes to GPU plugins he just wants you to play the gam...
I'm testing the 117 HD stuff atm so I can't properly daily drive it 🙁
knotty lintel
Me when ignored completely 😮
If your changeset was smaller you might have better luck getting it reviewed, can't imagine many people are excited to read +741 lines
low hatch
I want to go test the new GPU changes at Royal Titans cause that's the only place I had a crash at, but I don't want to pay 500K to find out 😂 my broke ass
kindred rampart
I'm not sure we could remap middle click like that, idk if anyone cares about th...
Hmm yeah probably not necessary. I’ll look into doing it that way. Thanks for the input!
kindred rampart
If your changeset was smaller you might have better luck getting it reviewed, ca...
Lol valid
restive garnet
If your changeset was smaller you might have better luck getting it reviewed, ca...
700 lines is not a huge PR
desert fulcrum
if it means i can remap m4 to m3 in runelite its a lgtm
tardy pecan
tip for anyone who runs into this: often when working with scripts, you'll see e.g. an 8 digit integer as an argument to the script, and searching runelite source code will not yield this integer, so you just hardcode it into your plugin.
some IDs, e.g. InterfaceIDs, are expressed in hex in runelite source code 🤷♂️ https://github.com/runelite/runelite/blob/f63280e34fdbcbbc9b9af6ec07511b250aa25455/runelite-api/src/main/java/net/runelite/api/gameval/InterfaceID.java#L3409
if you convert those mysterious large integer script arguments to hex, you will likely find them as an ID somewhere in the runelite source code, and be able to use that ID directly to avoid having to hardcode it and fix it whenever the ID changes. e.g. https://github.com/96jonesa/chatbox-scroll-to-zoom/commit/7b9d43deb279ff3ef783e61c0a25d6d9b5c57e98#diff-d790c316436cdda585cdfe4aff2c9b40940111c35d42186aa011f7b0e1a05074L88-R87
^ for discoverability it could be nice to have comments next to these hex values showing their decimal values. (it seems the value of expressing them as hex is that the upper 16 bits specify the group, and the lower 16 bits specify the child index, so it conveys some hierarchical information as-is)
thorn grotto
and why would you want that?
sidebuttons are easier to press than mmb
i have bound one of my sidebuttons to mmb for YEARS
but i compromised on my mouse choice because of that
amber rampart
maybe middle click yeah
he asked for m4 to right click tho
and seems like something you would want to do os-wide
desert fulcrum
and why would you want that?
mouse4 has better durability than mouse3
remapping off m3 makes a mouse last longer
stuck shale
umer do you know the region id for hmt sote so i can fix ground object hider for you
i know the varbit for the raid but i imagine people wouldn't like if their "i dont want to see the art" plugin not work in the place where they want it to lol
desert fulcrum
umer do you know the region id for hmt sote so i can fix ground object hider for...
let me check whether my hunch for it not working is true
hmm im surprised it doesn't work, if you check plugin & callback class, they should both be checking
ember flareBOT
low hatch
RL always fixing Jagex' mistakes
rancid marten
RL always fixing Jagex' mistakes <:nullstare:1397699690778329178>
can you get more info on this titans assert?
oak ermine
Is there a guide for getting a plugin off the plugin hub to run in a developer environment?
rancid marten
what are you trying to do?
oak ermine
the poison plugin does not register max hits
This one
Trynna see if I can add it myself
rancid marten
you should just run the test provided in the repo
oak ermine
That's what I was looking for haha tyty
spiral badge
Anyone happen to know how you can check what darts are within a blowpipe?
quick path
programmatically? you can't
best you can do is read chat messages and hope your user isn't trying to trick you with multiple bps loaded with different darts in the inventory at once
spiral badge
Well shit.
ember flareBOT
rose void
programmatically? you can't
I wonder if you could at least tell if it's using ddarts since the projectile for those are different. First idea that comes to mind as a work around @spiral badge
spiral badge
sadly doesn't apply to my use case, I may just not worry about blowpipe condition for now.
I assume that would work though, I don't see why not. Just that in the plugin I am working on its trying to validate certain items etc before entering a pvm encounter, in this case it was inferno.
Forever haunted by the time I went in there with blowpipe iron darts
autumn star
could add a manual "check your blowpipe" req and let them go in when a matching game message has been found near the entrance 🤷♂️
topaz pierBOT
[ https://github.com/adrocic ] [ @frosty canopy 278895103123128330 ] adrocic#0
rare crescent
hihi, is there a way to debug on live-time changes while i run runelite? Let's say I add/change on someone's plugin to add an info or icon, etc. Like besides the --debug, is there something I should look into?
(Just started recently to kinda get my toes wet and finally give a try in contributing lol)
worthy sparrow
what
rare crescent
so like you want to see the changes you do live
topaz pierBOT
dusty anvil
<https://www.jetbrains.com/help/idea/altering-the-program-s-execution-flow.html#...
@rare crescent
rare crescent
So I tried the HotSwap and it works in-game changes! However, it doesn't change anything in the RuneLite plugin sidebar info. I wanted to do like a small change like a text and it doesn't update it instantly. I guess it has to do with recompiling the whole class with the client first?
e.g from the action-progress-bar plugin, I was changing the "Cooking actions" text purely for example purposes. I tried to add "(this is just a test of hot reload)". Is there something I'm missing out?
(I had to rerun the program)
glass sandal
Not everything can be hotreloaded, intellij should tell you if it can't
rare crescent
What are things that can be hotreloaded then besides the in-game changes?
glass sandal
Changing the logic in a function can. But adding new globals or new functions can't. Its just a java thing, not runelite specific. So intellij probably has an article about it
rare crescent
this will be a journey of questions for me using Java hahaha. Thanks again!
rare crescent
Is this normal when changing a bit of logic?
Just added new items to the action-progress plugin
sharp knot
That would be something you can't hot reload
There's probably something you can do with bucket but that's something you should really ask about in the api-discussion channel in the wiki's server
But it also sounds from that question like you're trying to do something that a dozen other people have done fwiw
edgy spade
But it also sounds from that question like you're trying to do something that a ...
I'd imagine so, I'll ask in Wiki server
hollow stratus
Is this normal when changing a bit of logic?
usually you can't change if you're adding methods, changing method signatures, etc. where the expected vars/arguments are changed
low hatch
It's finally happening 
||I hope||
chrome crest
That is sick! really looking forward to it as my sidebar is very cluttered 😂
worthy sparrow
What's up with the comment changes
ember flareBOT
hollow parrot
@heady pond thanks
heady pond
np fam
ember flareBOT
quick path
hmm
reef badger
should just be able to region check them right
cuz inside is probably millions of miles away
oh wait im thinking of clues having existing region checking not slayer
quick path
we could, we just haven't had to region check any other npc thus far
reef badger
ye
topaz pierBOT
glass sandal
Somewhat related but maybe too complex
quick path
hm, I forgot that PR was open. I remember the discussion we had on the issue it's addressing
I'll take a look at that later today
rugged pivot
while you're looking at slayer PRs 👉 👈
topaz pierBOT
twin rover
just wondering, is it possible my submitted plugin was overlooked? or did it submit wrong? doubled checked avg time and seems im above it lost on pg3 with some failed ones around it 
grizzled aspen
no nothing is overlooked
twin rover
good good, just wanted to make sure i didnt fk up lol
grizzled aspen
its just like waiting in a regular line. there's still others that were opened first
upper valve
you pushed it to the back of the queue when you updated it
twin rover
ahh thats why, makes more sense, thanks guys for letting me know ❤️
upper valve
best bet for getting something reviewed is always to not touch it until changes are requested
twin rover
is that for all future plugins added or just for the first one?
upper valve
any pr whatsoever
twin rover
okay ill remember that, had no choice for the update, my ocd was bugging me if i pushed an imcomplete project haha
reef badger
also while what rikten is saying is true, ignoring last updated there's still a few new plugins older than yours
grizzled aspen
idk if everyone else uses last updated since i use open time instead, but i don't regularly review new ones
oak rock
Mines on last updated too
twin rover
didnt even notice i could order by updates, i was scrolling through the pages like a noob lol
upper valve
diff: is:pr is:open label:"plugin change" sort:updated-asc -label:"waiting for author" -label:"build failed" -label:"size-xl" -label:"hold for release"
new: is:pr is:open label:"plugin added" sort:updated-asc -label:"waiting for author" -label:"build failed"
rugged pivot
so we should rename size-xl to too-big-pls-split
upper valve
i would like to work on tooling that helps accelerate my review process so PR size is not an issue anymore
but IRL time is scarce
snow needle
I feel like I'm missing something crucial with how RuneLite renders Jagex HSL.
In this example I chose a red hue, max saturation, max lightness, and hslToRgb outputs pure white.
ObjExporter uses a brightness adjustment of 0.9 which, if I apply, only makes the colors even brighter, so I don't think that's it related to this.
I've read through the GPU plugin frag & vert shaders but I can't find anything obvious about brightness adjustments.
Is this caused purely by in-game lighting lowering the brightness of stuff? How can I make my color picker's hslToRgb more accurately reflect the color seen in-game?
rancid marten
https://github.com/runelite/runelite/blob/master/runelite-client/src/main/resources/net/runelite/client/plugins/gpu/hsl_to_rgb.glsl this does hsl->rgb conversion and includes brightness
snow needle
I converted that to Java and it looks the same as net.runelite.cache.models.JagexColor.HSLtoRGB. That's what I'm confused about; there appears to be something lowering the brightness during the rendering process that makes the in-game appearance so different from a pure HSL to RGB conversion, but I'm not sure what it is.
rancid marten
oh yeah
are you seeing the shading maybe?
like how it goes from darker red -> lighter red
snow needle
Sort of, like the brightest part of the shield is almost white, but most of it is darker red.
rancid marten
that just looks like one of your face colors is white and the other is red
do you want the entire shield white?
snow needle
No, I want my color picker to show a color that more accurately represents what's on the shield.
rancid marten
when you replace the colors for the shield, what code are you using for that?
its the ColorTextureOverride stuff right?
snow needle
For the player yes, also I'm doing item color replacement too.
and it's setting the replace value to 1023
rancid marten
ether way the colors you are messing with is the pre-shaded colors
snow needle
I guess so? What is shading?
rancid marten
this effect where it goes from darker to lighter
the shield face is actually just 1 color red
the shading makes it not
rancid marten
its something the client does, i dont think you can disable it for items like that
snow needle
I don't want to disable it, I want to replicate it
rancid marten
tbh idk how it works really, there is code in the cache module for it I think
snow needle
I think my color picker should show a shaded value instead of pre-shaded.
Ok thanks hopefully I can figure it out
rancid marten
turbid turtle
Hey folks!
I have a question on varbits and interfaces events, as well as to ensure it's game compliant.
I want to display a chart on the GE interface and have the user be able to update the new offer price by clicking on the chart, updating the price to the currently selected Y axis position.
I've identified the varbits and code to update the interface, but this is client-side only.
While I'm not too familiar with writing data to the client, I'm wondering if it's possible for a plugin to update the price this way.
I think it might be impossible as varbits are stored server-side, and submitting the offer uses the server variable instead.
Any insights?
Thanks!
rare crescent
How did you enable these little features?
rare crescent
let me double check everything then
stable mural
#github message i allow this pr. Mobile app keeps crashing when i try to comment under the pr
reef badger
sounds about right
rare crescent
<https://github.com/runelite/runelite/wiki/Using-the-client-developer-tools>
Works now. For some reason it wasn't working because I wasn't editting it through Intelij. Mostly directly from the terminal and thinking it would just work with just that
Holy flashbang
torpid dagger
sounds about right
Thank you guys o7
rare crescent
I'm trying to add some of the new potion to the action-progress-bar plugin, but I don't seem to get it working. For now, I'm doing the extended stamina potions variants. I have added new recipe requirements, but it doesn't show the progress bar. Is it maybe because it uses stamina potion AND marlin scales as an ingredient?
Maybe not the best screenshots, but I'm happy to share anything needed
sinful lava
I'm trying to add some of the new potion to the `action-progress-bar` plugin, bu...
This might be a question better suited to the action progress developer in their discord / their github issues
rare crescent
ty
rare crescent
Are there formats according to Runelite like opening an issue to follow/best practice?
sinful lava
Are there formats according to Runelite like opening an issue to follow/best pra...
opening an issue on the runelite/runelite repo gives you a template to follow (if the submitter reads)
rare crescent
probably because i chose blank template lol
pastel tree
Is the a plugin that can export the scene as a model. I thought there would be but suprisingly I cant find one.
rare crescent
Is the a plugin that can export the scene as a model. I thought there would be b...
wdym scene
glass sandal
There's an external program to export a region's terrain as a 3d model
pastel tree
wdym scene
The scene is what contains all the static tile objects.
pastel tree
There's an external program to export a region's terrain as a 3d model
yeah I saw one. I thought thered be a plugin, but now that I think about it, an external program sounds more practical.
since it can export any region rather than just the ones you visit in game
rare crescent
like the osrsmap 3d site? let me find the link
restive garnet
https://osrs.world is that the one
rare crescent
yee that one
rare crescent
when you are choosing a module, is there a big difference between choosing *.test and *.main?
pastel tree
does anyone know how the model.getUnlitFaceColors() works? Will it always work for any model, or are there certain restrictions I should know about?
worthy sparrow
when you are choosing a module, is there a big difference between choosing `*.te...
you won't be able to run the test if you don't choose test
rare crescent
so when it comes to new plugins, you always want to run the test one? idk if that makes sense
glass sandal
If you use the plugin template or auto-generator it should generate the test for you automatically
reef badger
Cool cool
stuck shale
Say the line
oak rock
Wtf is that even supposed to mean
reef badger
Yippee
oak rock
Type crash or hang
heady pond
Type crash or hang
Type: user crash out
red rapids
Shoutout to the Creator Kit dev. I've learned a ton on how to do stuff in Swing by referencing that plugin
worthy sparrow
Anyone want to train an llm on it
rare crescent
Shoutout to the Creator Kit dev. I've learned a ton on how to do stuff in Swing ...
whats swing?
i saw it today on the dev tool, but i have no idea what it is
red rapids
whats swing?
its the lib used for UI of a plugin. For any plugin wanting more advanced UI, you're going to get neck deep in Swing
rare crescent
or ull regret it
no i want to know now
reef badger
no you dont
rare crescent
ok maybe not... yet
sharp knot
Not later either
rare crescent
give me documentation of Swing
reef badger
the what
red rapids
I love the oracle docs I love the oracle docs I love the oracle docs I love the oracle docs I love the oracle docs 🙃
rare crescent
speaking of documentation, as a learner and want to make a plugin (not another flipping utility), would you suggest going through the runelite api documentation? nothing in particular yet
rare crescent
I love the oracle docs I love the oracle docs I love the oracle docs I love the ...
oh god
quick path
speaking of documentation, as a learner and want to make a plugin (not another f...
generally the best way to go about it is to find a (core) plugin which does similar things to what you want to do, and use that code as a baseline
rare crescent
i lowkey prefer to read the man man or any UNIX man or c++ or something that is not Java
rare crescent
generally the best way to go about it is to find a (core) plugin which does simi...
fair yeah
quick path
our API docs range from good, to ok, to nonexistent for some methods, so usage isn't always clear just from the docs
red rapids
speaking of documentation, as a learner and want to make a plugin (not another f...
A few useful things to get you started that I've learned along the way:
Logging - Use @Slf4j, you dont need to roll your own logger class
Sending a notification chat message in game: Reference the Examine plugin https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/plugins/examine/ExaminePlugin.java
As I referenced above, https://github.com/ScreteMonge/creators-kit is an incredible reference option for more complicated UI.
rare crescent
our API docs range from good, to ok, to nonexistent for some methods, so usage i...
so you are saying to annoy someone in here until you get your answer in regards how to use something? got it
quick path
if you're using something which isn't well-documented, yes
a majority of the API is either documented, or has core usage which shows how to use it
rare crescent
my error i did when i was learning programming, is that i would read a lot, but not writing a lot. So trying to avoid it when im writing code
Right now I'm chill so i just wanna read
hollow stratus
quick question, when I'm loading in plugins in a dev build of runelite and I switch profiles, sometimes it loads my other profile's plugins and other times it doesn't. Is this usual behavior?
I'm trying to test changing profiles properly loads the saved custom plugin order but I'm running into this issue, which makes it hard to test since new plugins from profile 2 don't load in
rare crescent
probably because you didnt link it with the acc profile
i definitely had that issue earlier today where i load some plugins, but it wouldn't link right away
hollow stratus
I've done that, I believe. I'm double checking runelite docs to confirm, but here's my project settings with vm flags
rare crescent
where it says cp runelite.client.main, do you have one that says test instead of main ?
hollow stratus
I'm doing core work, not plugin work, sorry should've specified!
heavy bobcat
oh always?
Yes cause you just launch the RuneLite class which is in main
rare crescent
I'm doing core work, not plugin work, sorry should've specified!
all g!
rare crescent
I'm trying to test changing profiles properly loads the saved custom plugin orde...
oh you referring to swirle13's order changes/additions?
hollow stratus
oh you referring to swirle13's order changes/additions?
that's me!
hollow stratus
oh weird, when I uninstall a plugin on profile B, it then suddenly loads all of the extra plugins. Hmm... gonna test dev build of main runelite and see if this behaves the same
worthy sparrow
use --profile=name
worthy sparrow
i think so
hollow stratus
that worked, thanks Ron
snow needle
In what cases does Client.createItemSprite return null? Is it always retriable?
hollow stratus
still trying to figure out why switching profiles in debug mode seems to lazy load plugins upon a new plugin change event. It seems onProfileChanged() isn't getting triggered when switching profiles. Is that still the right subscriber to use?
okay, the behavior is the same even with the newest upstream runelite, none of my work in there
rare crescent
In what cases does `Client.createItemSprite` return null? Is it always retriable...
I don't think there is a null type return from the document itself
correct me if im in the wrong though
snow needle
What do you mean "from the document itself"? It is annotated @Nullable. Why?
rare crescent
oh i see, im not sure exactly the @Nullable portion. I was looking more on the return value
hollow stratus
example, if anyone is curious of the behavior. Seems this is just how things are, so I'm not sure how accurately I can test my change's behavior
snow needle
oh i see, im not sure exactly the `@Nullable` portion. I was looking more on the...
The source is not available right? Are you looking at decomp?
rare crescent
not looking at decomp
snow needle
Oh you mean you were looking at the javadoc?
Yeah javadoc doesn't mention it, but the @Nullable annotation and I think I just saw it happen. Unfortunately I didn't have logging in place for it so I am not sure if it returned null or something else failed.
rare crescent
Oh you mean you were looking at the javadoc?
ye
i see in other methods having the @Nullable too, but it is weird for me how to tell what exactly does without testing
rare crescent
example, if anyone is curious of the behavior. Seems this is just how things ar...
oh thats hella cursed
what's this Huze @MagicConstant(valuesFromClass = ItemQuantityMode.class) int stackable
how the fuck you read this lmao
rancid marten
hmm?
snow needle
it's just saying the values should come from ItemQuantityMode instead of using magic numbers
rancid marten
did you figure out that shading thing btw?
snow needle
Yes I did, thank you! It looks a lot better after my changes.
I'll tweak it some more, but now I can actually show what the color will look like on the model after shading in the picker.
(left is before, other two are new)
Now I'm trying to debug a case where one of the item icons I generated with Client.createItemSprite is empty. I'm wondering if it returned null because the function is annotated @Nullable, but I don't know if or when it actually returns null.
Is the client effectively running the same code as https://github.com/runelite/runelite/blob/c7ebe1f362e1cd794813afc0be848d09f01f3d16/cache/src/main/java/net/runelite/cache/item/ItemSpriteFactory.java#L41 for generating the icon?
rancid marten
@Nullable just means it can return null
rare crescent
so like a void function kinda?
snow needle
Yeah I know that, but I want to figure out why it returns null because I don't know if I should always retry when it's null.
rancid marten
except for giving it bad item ids it only returns null if the model cant be loaded
just retry it later then
rare crescent
i noticed today when messing with dev tool, you can see like an id of the inv sprite being nothing. dunno if related
snow needle
Any particular timeframe I should retry after, or should I reset the cache or anything?
rancid marten
ItemManager returns an AsyncBufferedImage for this reason, you can use that
fading iris
@noble hearth Are you the owner of the Deep Sea Trawling plugin? I'm working on a new feature for a trip summary with infoboxes showing the totals of each fish caught before disembarking. This would be controlled by a new config option, disabled by default.
The use case is for boats with multiple crew members doing trawling. Being able to see your contributions makes splits much more straightforward. The captain can still benefit from having crew and other players can expect to get the fish they caught.
I'll spin up a pull request if you're open to this.
reef hound
Updating a plugin's readme and nothing else still follows the standard review process, right?
upper valve
yes
covert marlin
Is there any available api's to view level requirements to make an item? Such as 53 fletching to make a blowpipe, 86 crafting to combine a rancour, etc. Thanks 🙂
reef badger
the client script for each* skill menu exists, but it's also just wrong sometimes so maybe that's not consistent
amber rampart
they are dbtables now, so you can probably use that
glass sandal
(It also has issues like saying runite requires 92 mining)
hollow stratus
when trying to store config values per RuneLite profile, it seems configmanager.setRSProfileConfiguration() isn't the right method to use, as it uses the current player name, not the runelite profile, which is a bit confusing.
I'm trying to store the custom sidebar order per runelite profile as I'm testing loading between two profiles with different plugins installed (same runescape profile) and I'm not sure the right path to take for this. I'm currently combing through plugins to see how they handle this
any advice?
rancid marten
just use setConfiguration()
rancid marten
https://www.reddit.com/r/2007scape/comments/1rqfb84/most_of_what_makes_this_game_great_doesnt_even/o9rwc44/ why is this a thing that people think? is 21 that much better?
i dont see it
hollow lintel
It's a very common thing to do in minecraft and gives a reasonable performance boost for say speedrunning. I do not see it mattering much for runelite though
rancid marten
I mean like I can run RL with 21 and I dont see a difference
or 17 even
do you know what jdk changes were made in 21 to make it faster?
maybe he upgraded to 21 and then also switched gcs or something?
maybe hes lying?
idk
hollow lintel
I do not, sorry. Just thinking globally, where might one pick up this piece of advice from. I've never seen it before for RL but often for mc
frosty canopy
If I recall, those 13th and 14th gen intels had notable instability yeah?
upper valve
maybe hes lying?
i don't think this person actually has any idea what they are doing and the claim that java 21 is a performance boost is just a placebo effect thing
rancid marten
maybe
rancid marten
If I recall, those 13th and 14th gen intels had notable instability yeah?
they do but it isnt for specific java versions afaik?
like they are unstable on 11
heady pond
maybe he upgraded to 21 and then also switched gcs or something?
both 11 & 21 default to G1, but in benchmarks, G1 has gotten better over time (higher throughput, slightly lower pause time)
rancid marten
they typically backport those kind of things dont they? I think
like almost all of each 11 release is just backports
heady pond
yeah, think they would backport bigger optimizations https://bugs.openjdk.org/browse/JDK-8232533
rancid marten
this is backported
heady pond
yup
heady pond
some changes appear to not be backported (e.g. https://bugs.openjdk.org/browse/JDK-8275056), but no idea if the cumulative effect is significant
rancid marten
we should do the 21 update at some point
we sort of botched the 8->11 migration so bad in like several different ways when we did it I dont want to try it again really lmao
but now we know i guess
like we were still fixing bugs related to the 11 migration years later
heady pond
fwiw i exclusively play on jdk 21 & haven't had issues on either windows or linux
but had swing issues on 22/23
upper valve
aside from that being obvious AI, does GDPR even apply to runelite at all
it's not a commercial project
amber rampart
afaik gdpr applies to everything
late hare
yeah, pretty sure if you allow people in the EU to use your site or w/e it might be you are meant to follow GDPR
misty hornet
yeah, pretty sure if you allow people in the EU to use your site or w/e it might...
Easy solution
No more European runelite users
upper valve
i get that if you're a US-based business operating in the EU** you have to follow it but like
late hare
it's not UK, it's EU
upper valve
how could you enforce gdpr on runelite, you can't, can you? there's nobody to fine
reef badger
i wish ai was any good at scraping
if it was it would know about the --disable-telemetry param
late hare
in theory you'd just have the EU people coming after you, but im not sure they really do that for things like this lol
misty hornet
Quoting the man quoting the AI
upper valve
tonight at 10: john runelite named in GDPR lawsuit
misty hornet
Pretty sure there’s been cases of the data processors for open source projects being sued for GDPR related “issues” but no idea how they actually turned out
It’s probably a nonissue but there is precedent
hollow stratus
when trying to store config values per RuneLite profile, it seems `configmanager...
From Adam: just use setConfiguration()
that's what I was using, but it's not performing how I thought it would.
Turns out it was due to null plugin tab nav buttons not removing properly in removeNavigation(), leaving plugin tabs for plugins that were uninstalled when switching profiles.
hollow stratus
I think this PR is finally ready for a proper review 😮💨
rare crescent
<https://www.reddit.com/r/2007scape/comments/1rqfb84/most_of_what_makes_this_gam...
Odd take (and crazy to time to optimize with that hardware)
rare crescent
it's not a commercial project
Unless you pay premium for better flipping tools and insights!
rare crescent
if it was it would know about the `--disable-telemetry` param
Just add a robots.txt and be like “shoo shoo”
low hatch
In case anyone else needs this to extract POH Portal Nexus available teleports from the cache (using Abex's Cache Viewer): https://gist.github.com/Infinitay/b661ad3428bf8bee13bcfb795d881730
quiet kettle
It seems like the location of POH rooms on the map may have changed with this update 🤔
restive garnet
I wonder what they need that space for... 😄
rocky imp
@dusk ridge Sorry for the ping, wondering if you can check out this PR the next time you get a chance https://github.com/ThePharros/chat-sounds/pull/11
dusk ridge
<@271834746776977408> Sorry for the ping, wondering if you can check out this PR...
sorry havent been around RL dev much and am currently taking a hiatus from the game. I trust you in co-maintaining the plugin though. if that's something you'd be interested in, I can add you as a collab
rocky imp
Sure I'm happy to help out with it
dusk ridge
sent the inv :)
rocky imp
Thanks!
rare crescent
Any way to find tabs such as "Combat Options", "Skills", "Inventory", etc?
stuck shale
What do you mean find
rare crescent
like search up whenever you are in the skilltab section (or whatever tab)
restive garnet
think there's an event you can subscribe to when a user opens a specific UI
I forget the name
rare crescent
like the information the client has at the moment (e.g. I want to know what is my current skill total level through the skill tab)
rare crescent
think there's an event you can subscribe to when a user opens a specific UI
ye this is what i was wondering
stuck shale
like the information the client has at the moment (e.g. I want to know what is m...
you dont need to go to the skill tab for this information fwiw
a human has to open it to see it, the client knows it
rare crescent
but lets say I want to hide the xp remaining when i hover the mouse on a particular skill. I don't want to see how much xp is left for next level
so i want to know like what is the behavior called and tinker a bit from there
stuck shale
its some script that executes to prop that information up i imagine
rare crescent
what is a good way to like dig and see where it gets triggered after changing tabs? Varbits w/ dev mode?
dusk ridge
sometimes you gotta let the PR marinate 🤤
rancid marten
pretty sure github is on fire but their status page says ok so idk
quick path
because their status page is always honest and up-to-date
simple cipher
I need to find a way to find & change text in all widgets, how exactly do the child Ids work? Is there any other way of traversing all widgets loaded (obviously some filtering mechanisms), without brute forcing the child Ids?
worthy sparrow
is it a translation plugin
simple cipher
No
It's a plugin to replace text in game, so for example any mention of "karamja" can become "shitty ass island"
sharp knot
I think you can just use meepspeak to do that already
worthy sparrow
or reword manager maybe
simple cipher
I think you can just use meepspeak to do that already
For ingame menus like this?
sharp knot
Oh reword manager was maybe the one I was thinking of
worthy sparrow
otherwise you are iterating the widget tree
simple cipher
otherwise you are iterating the widget tree
Yeah and that causes lag
simple cipher
Oh reword manager was maybe the one I was thinking of
Hmm no, seems to do everything but widget text renaming
quick path
you can consider working with them to have it affect specific interfaces as well (to avoid iterating every widget), if that'd suit your needs
simple cipher
you can consider working with them to have it affect specific interfaces as well...
Do you mean checking groupId to be equal to something like col log loading, and then only changing stuff in the col log? How would i iterate through all childids in this example?
quick path
ideally they'd either be children of the widget (in which case you could recurse through them) or they'd have some know group id, where you'd do the same for their parent widget
reef badger
cool cool
ember flareBOT
simple cipher
ideally they'd either be children of the widget (in which case you could recurse...
Just for clarification, with recurse through them, you mean check children with ids 0 to x, stopping when one is null?
quick path
check the widget and its children, then check those children for further children
rare crescent
is there a way to stop the script inspector firing nonstop messages? it is constantly filling the screen
quick path
add the noisy script IDs to the blacklist
sharp knot
Woah I forgot about that one
sharp knot
Oh this means I get to go to "organize the regions file without actually adding anything" jail next
quick path
lmao
sharp knot
(it is one of many tabs I've had open for over a year in firefox now lmao)
This is such a me sort of thing you have no idea
(I think you said you'd be ok with that sort of PR right?)
quick path
I've been trying very hard to get back to unchecking the "Open previous windows and tabs" setting
idk if I'd said that
organizing it would be fine I guess? I'm not that worried about it either way
sharp knot
I mostly wanted to do it for my own benefit since I was the one messing with it the most really
Make it a bit easier to keep track of what was already in there
quick path
If we've got any other open PRs against that file I can look over those first, otherwise go for it ig
sharp knot
I think I was just trying to keep it to the one at a time but I'll double check before I start doing anything
quick path
appreciate it!
rugged pivot
this is all extremely reasonable but have you considered that its cool and I want it now 😂
rugged pivot
Its actually painful for me to do that as I can not get razer's shitty software to recognise the dev build as a process to switch my mouse bindings to my OSRS profile
but yes
rugged pivot
that is extremely a me problem
sharp knot
I think razer is your problem
reef badger
osrs-but-its-under-javaexe-i-just-wont-play-minecraft
rugged pivot
it only likes distinct exes so I'll have to fork and build my own launcher of course
quick path
of course
rugged pivot
pointing it at the jre exe may work but I remember having issues with that years back
sharp knot
But can I somehow get force feedback on my sim wheel for sailing?
rugged pivot
it only likes distinct exes so I'll have to fork and build my own launcher of co...
this is working nowadays, pog
rose void
anyone making a plugin to make the arceuus spellbook have 5 spells per row again if you hide the minigame tele its fine
ember flareBOT
rugged pivot
Damn why doesn’t runelite run on my kindle? It’s the latest generation!
reef badger
this is so sad
reef badger
so many people play muted anyway audio is irrelevant
rugged pivot
gpu failed to start, crazy
amber rampart
is it even arm64?
rugged pivot
it most certainly is not
surprised its running at all
obviously its because i switched to java 21, which we all know is superior
reef badger
that's what i heard
hollow stratus
while I wait patiently for my turn for my PR to be reviewed, I wanted to start on a plugin that I don't believe exists. Is anyone aware of a plugin that tracks the most recent time an item in your bank was interacted with?
I'm trying to do a heatmap of sorts to identify what items are never accessed in my bank and get rid of them. I liked Wasted Bank Space plugin for identifying items taht can be stored somewhere (so much so, I contributed some performance improvements to it), but I'm looking to take the bank space saving further and practice more java dev with this idea. Just don't want to spend the time if the plugin already exists
rugged pivot
I don’t think it exists, and I’ve thought about that idea in the past
I vaguely remember thinking “ugh I’m gonna have to wait 6 months after developing it to see all the stuff I haven’t used in 6 months” and then just not doing it
And here we are, way more than 6 months later, with no plugin and no data 😂
So i say go for it, I’d use it
hollow stratus
sweet, thanks for the encouragement Hannah
as I'm trying to start from the easiest point and not reinvent the wheel, any suggestions on existing plugins to use functionality for a starting point? I'm thinking maybe Bank Heatmap (for GE/HA prices, not item use) https://github.com/raiyni/example-plugin/tree/heatmap
flat furnace
https://github.com/runelite/plugin-hub/pull/11014 Not sure why this didn't get tags when I opened the PR, was the pipeline changed or something? Wanted to give a heads up, because I don't believe this is intended activity.
reef badger
i turned it off and on again and it didn't fix it, i'm out of ideas
flat furnace
Was the pipeline changed recently? (Last few weeks)
grizzled aspen
nothing's changed, but github has been having a lot of outages recently
reef badger
i dont think so
flat furnace
Hopefully it's a one off then
Do you guys have access to check what happened in the pipeline? I don't
reef badger
abex might but thats about it for awake people
flat furnace
No rush, was just gonna help troubleshoot
reef badger
idk i'm sure someone will open an AI pr in the next hour
and we'll know if it was a 1off
grizzled aspen
reef badger
yippee
grizzled aspen
github team is vibing too hard
flat furnace
ty for the fix @tulip wagon
tardy pecan
shot in the dark but does anyone know the pathing algorithm used when a player is using an item on a (moving) NPC?
quick path
I'd guess it is similar to attacking an NPC while wielding a melee weapon, which is that you path to its location at the time of clicking, then path to its position anew once you reach that location, and repeat until you reach it
rare crescent
add the noisy script IDs to the blacklist
lit
ember flareBOT
rare crescent
remind me again what is the document to make changes on a plugin from plugin-hub?
oak rock
The manifest?
rare crescent
umm like the git commit etc to the branch of the plugin for action-bar-progress
so like updating the plugin, and having the maintainer to review it and make a PR review
heavy bobcat
The file is just the name of the plugin so probably action-bar-progress
rare crescent
right but im trying to do my git push and im getting this (im typing my password correctly)
restive garnet
Did ya read it?
rugged pivot
if thats not your repo you can't just push to it. You have to fork it, commit to your fork, then PR to them on github
rare crescent
if thats not your repo you can't just push to it. You have to fork it, commit to...
right, i was trying to find the documentation for the forking process. Like after forking and doing the changes, isnt there something with -D upstream etc?
ngl, i forgot about the fork too lol
rugged pivot
we don't have documentation for how github works
restive garnet
You push changes to your fork, then do a pull request to the original author's repository
and it's then their responsibility to do the PR to the hub
Can you imagine the carnage if just anyone could do changes to hub plugins without going through the original authors first? 😄
rare crescent
lol yeah i can imagine
but i swear i saw a document that explains how to contribute on someone's plugin from plugin hub
thats why i was feeling a bit lost lol
restive garnet
Yea you can't just directly write to someone else's repo
The usual way is fork it, change on your fork, PR it back to the original repo
rugged pivot
its possible some hub plugin has contribution instructions in its readme, but as far as I know we only have guides for contributing to core, and making your own plugin
restive garnet
Other way is to get the original author to allow you to commit directly
and they have every right to tell you to piss off 😄
rare crescent
oops then lol, let me do these changes on my fork then
rare crescent
i did the fork, commit, and push on the fork, but aint letting me 😢 . I will try again later and see what I'm doing wrong. As for now, I will just make the commit directly to my forked repo site, and submit a PR
rare crescent
Oh this is what I referring as the document: https://github.com/runelite/plugin-hub
sharp knot
Committing to your fork and then opening a PR on the upstream is what you want to be doing
rare crescent
I’m away from my pc, but basically i have to upstream first from the main runelite repo, then fork and do changes i want?
topaz pierBOT
Run gradle shadowJar to generate a runnable jar in build/libs/*-all.jar. You can run the jar with java -jar -ea jarName.jar. If you run into problems, update build.gradle to the latest plugin template version.
rare crescent
Run ``gradle shadowJar`` to generate a runnable jar in ``build/libs/*-all.jar``....
Does this has to be always updated whenever I make a new contribution to a plugin/ making a new plugin?
Soz so many questions
rare crescent
What a hash number. Unlucky the last two digits
sharp knot
That wasn't for you
twin rover
hey guys got two questions for ya guy,- is there an src for the dev mode plugin? think it would help a bit picking a few things up with it.
also side question, anyone know if theres a way to download a copy of the entire runelite api on static.runelite? last pre osrs project was some llm stuff, debating if training a coding llm to fine tune for runelite api might be interesting
fluid stump
hey guys got two questions for ya guy,- is there an src for the dev mode plugin?...
api docs
twin rover
thanks mark ❤️
ember flareBOT
upper valve
pastel tree
Hey, is there a chance any of you runelite devs could expose the "pitch" field on projectiles? Also known as the Z rotation, the thing that dictates how slanted the projectile is.
Im asking because I need it for my graphics plugin.
upper valve
@chrome crest i'll merge your thing later just keep em size-l or under. i filter out xl i didnt even know your pr existed
chrome crest
<@179568888495734785> i'll merge your thing later just keep em size-l or under. ...
Oh good to know, I assumed it was just on the back of your priority list which is fine and didn’t want to bother you
ember flareBOT
native harbor
So, I have submitted my PR #11015 - If I just make little updates, such as to the README this shouldn't be an issue, yes? It's official, just didn't want to change it to a draft. I made a couple changes and updates the hash and checked successfully. I assume only major updates during the process should be drafted otherwise it's okay?
sinful lava
So, I have submitted my PR #11015 - If I just make little updates, such as to th...
Pushing changes to your already-open PR (as you've already done) is perfectly fine, yes.
Depending on the reviewer, this might put your PR a bit further down in the queue, but don't let this stop you from making your plugin polished if you notice issues with it.
native harbor
Thank you!
quick path
go to random github repo, click on issues, try to read some issue,
gh has really been going through it lately
upper valve
grok fix my prod deployment
hollow stratus
thats exactly what I thought was happening 😂 like the aws outages being due to AI
quick path
would make sense considering the pushes at both companies to go all-in on AI
amber rampart
The constant for the top level world view is changing in an upcoming game update, scheduled for Monday the 23rd of this month. If you have it hardcoded as -1 your plugin will break, please change your code to explicitly reference WorldView.TOPLEVEL.
friend-live-locations
region-locker
tob-utilities
osrs-wiki-crowdsourcing
gemstone-crab-timer
port-tasks
cg-recolor
vitality
companion-pet
old-school-snitch
shortest-path
ha-exporter
group-ironmen-tracker
bearycuda-trials
gim-hub
loot-filters
deepseatrawling
deep-delve-pacer
cox-additions
@velvet haven @lone crow @unique tusk @misty belfry @kindred token @sinful crest @tiny cloak @valid wave @long vessel @dusty anvil @deft hatch @empty nexus @remote ice @latent snow @inner ledge @upper valve @signal cave @misty belfry
upper valve
is that scan from presence of -1 constant?
amber rampart
I searched for (wv|we\.|worldView|worldEntity).*-1
misty belfry
The constant for the top level world view is changing in an upcoming game update...
Hm am I getting double pinged because there are two plugins w me on it? I only recognize the osrs wiki cs one
amber rampart
I think I just added you manually to the wiki one then forgot and manually added you a second time
misty belfry
Sg, i can take care of the osw one. Thanks for the heads up 🫡
hollow stratus
would make sense considering the pushes at both companies to go all-in on AI
yeah, shortly after I left AWS, they had a huge push for everyone to get their new AI Certification, which I'm glad I left at that time, about a year and a half ago now
empty nexus
The constant for the top level world view is changing in an upcoming game update...
Alright I will make the change to ha-exporter asap thanks for the headsup
dusty anvil
The constant for the top level world view is changing in an upcoming game update...
Thanks for the heads up!
ember flareBOT
quick path
lunar yarrow
Is it common for plugin panel UI to break when merged?
I'm struggling to replicate it in my dev build, I've tried removing --debug program flag, is there something else I can do to bring the behavior inline with the live client?
rancid marten
the most common mistake i see is people load resources, like images, off of their local filesystem or something
lunar yarrow
Nothing from local, but should the first argument be my plugin class instead? I can't remember why I used PluginPanel here.
ImageUtil.loadImageResource(PluginPanel.class, "/delete_icon.png")
paper silo
the most common mistake i see is people load resources, like images, off of thei...
I’m guilty 😅
heavy bobcat
Nothing from local, but should the first argument be my plugin class instead? I...
I think technically it should be anything in your own package, and the resources would be under that package as well
So using PluginPanel which is presumably from the RuneLite package probably won't load your resources, although I'd think it wouldn't work locally either...
lunar yarrow
That's what I thought, but it does work locally for some reason.
upper valve
link your code probably
lunar yarrow
Should I just drop the github project, or do you want snippets?
upper valve
github link is fine
lunar yarrow
https://github.com/CodyLyttle/group-item-tracker
Image is loaded in sidebar/TrackedItemPanel
heavy bobcat
I think you need to use your plugin class + put your image under resources/com/groupitemtracker
upper valve
yeah the resource path is incorrect
idk if this is the best way but this works on hub so maybe just follow it https://github.com/riktenx/loot-filters/blob/main/src/main/java/com/lootfilters/Icons.java#L17
lunar yarrow
Okay, thanks! What a silly mistake.
upper valve
mainly the issue is that it's not under resources/com/groupitemtracker like shaggy said
glass sandal
I'm not at a PC to check but I think if you use IntelliJ to add the resource it puts it in the correct path
upper valve
I think that if they're in the same package path you don't have to give the full path?
but giving the full one works
lunar yarrow
I think I'll just be explicit like the example here. Just to be safe.
glass sandal
Yea if the path is right you only need the filename https://github.com/coopermor/prayer-markers/blob/0fe023c8d6f5e19127057f86d799fa839c449b21/src/main/java/com/coopermor/prayermarkers/ui/PrayerMarkersPanel.java#L84
trail marten
Is there any way to have right-click options without it showing up as "x more options" in the top left text, and with having the menu entries there the entire time so they can be swapped with a menu swapper (i.e. not added only in onmenuopened)?
I want to have right-click options in empty spaces, without it feeling like there's something there due to the mouseover text changing.
lunar yarrow
Yea if the path is right you only need the filename <https://github.com/coopermo...
Thanks. This is what I was going for but I clearly didn't read the instructions properly.
upper valve
it is sort of weird that your thing worked locally at all
i remember it being null until i got the paths right
lunar yarrow
Agreed, thanks for helping me diagnose that quickly. I'll make a pull request shortly.
brisk plover
Getting the deprecated warning about
'net.runelite.api.InventoryID' is deprecated
Searching through this discord, I saw that people said to use import net.runelite.api.InventoryID;
, but where did you learn that? Are docs somewhere?
glass sandal
It’s still fine to use. But gamevals are preferred to use
brisk plover
Ah, but like where can I see what the prefered method is. Usually when something is deprecated, the comment docs mention what to use instead, but I don't think I see that?
glass sandal
The gamevals had to be excluded from API docs because it made the files too large for github. So that might be the reason there's no link
brisk plover
Ah makes sense! Thank you!
rustic canyon
Got a question.
I’m trying to make a plugin which hides the 0 damage hitsplats. But I'm not sure where to start.
I tried looking at the "Entity Hider" code, which is able to hide all local 2D elements, but I don't fully understand how the plugin is actually hiding these Elements.
Only reference (outside of config updates) I found of hideLocalPlayer2D within EntityHiderPlugin.java is:
@VisibleForTesting
boolean shouldDraw(Renderable renderable, boolean drawingUI)
{
if (renderable instanceof Player)
{
Player player = (Player) renderable;
Player local = client.getLocalPlayer();
...
...
...
// Allow hiding local self in pvp, which is an established meta.
// It is more advantageous than renderself due to being able to still render local player 2d
if (player == local)
{
return !(drawingUI ? hideLocalPlayer2D : hideLocalPlayer);
}```
Which I don't exactly follow.
I would really appreciate if someone could point me in the right direction. 🙂This wouldn't be possible without exposing new API methods
rustic canyon
Ah so its all or nothing?
tulip wagon
correct
rustic canyon
ight happy I asked before I spent more time on it
tulip wagon
we don't expose the hitsplats that are currently on an entity, nor a control to render/not render hitsplats individually from other 2d elements
rustic canyon
thats fair, just wanted to see if I could remove them as a accessibility feature, since a ton of 0s hides everything under your character.
rustic canyon
Question regarding Resource Packs.
Went digging into the code in hope of adding the ability to recolor hitsplats, and noticed the code already exists, just commented out.
Is the recoloring of hitsplats something that is rejected/unallowed to be implemented in runelite?
I checked the following page, but didn't see anything speaking against the implementation of such a feature.
reef badger
did you look at the diff to see if the reason was in the commit
rustic canyon
did you look at the diff to see if the reason was in the commit
I did not let me check that.
rugged pivot
they were commented out in the commit that added them 2 years ago :L
reef badger
amazin
rustic canyon
So they were just implemented commented out. Interesting. Wonder if I could just complete the implementation by getting the sprites and doing a PR.
Since the logic is already there, just need to populate the folder.
tulip wagon
i can't think of a reason why it would violate a rejected feature / rule
try uncommenting i guess
rustic canyon
yeah thats what im doing 🙂
tulip wagon
it might be because the hitsplat icons are not handled through sprite manager
idr their internal implementation, but it might be one of the sprites that's loaded once on startup and not refreshed
rustic canyon
I'll start by uncommenting then go from there
late hare
not on startup, but they have a cache that probably isn't exposed in the public api
rustic canyon
Not sure why almost every plugin I fork doesnt seem build which leads me to editing build.gradle and the "test" script heavily
rustic canyon
If anyone has the time and is willing to assist, I cant get this plugin to launch into runelite, I managed to get it to build, but it did not launch runelite.
https://github.com/melkypie/resource-packs/tree/master
Ive had success before, but this time, I think its beyond my experience.
Added -DspriteFolder="C:/path/to/sprites" -DpackFolder="C:/path/to/output" to VM Options, which did fill in the folders it required, but there were further errors.
(I did populate the paths with correct folders)
Going to take a break for now, see what tomorrow brings.
rare crescent
Is there any particular schedule whenever runelite gets updated? (e.g. every 2 weeks, 10 times a quarter, etc)
amber rampart
no, its mostly just when we need to
rare crescent
ty
rare crescent
is Mavin build like an old thing these days and replaced with Gradle?
heavy bobcat
Yes
rare crescent
o cool then, also: when making a new plugin or using example-plugin, do you include all branches?
amber rampart
it doesn't matter, there is only one branch
rare crescent
kk
ember flareBOT