Apply middleware to Custom HTTP Error Pages | Laravel | Page 1

wet hill Oct 4, 2023, 9:47 PM

#

Since laravel handles exceptions automatically when creating a errors folder in views, I can't really apply any middlewares

fiery void Oct 4, 2023, 9:48 PM

#

The link you posted literally tells you how to do this - unless i don't get the question

#

You can create your own exception and throw it - you can create your own middleware and throw said exception if you wish

#

php artisan vendor:publish --tag=laravel-errors from the link you posted means you can edit this page to be whatever you want

wet hill Oct 4, 2023, 9:51 PM

#

So what I'm doing is, including navbar/footer which use the custom locale middleware to translate the text

#

Wrapping the 404.blade.php in a guest layout

minor rampart Oct 4, 2023, 9:52 PM

#

@wet hill What if a middleware is the cause of the error…?

wet hill Oct 4, 2023, 9:52 PM

#

The issue here is that I can't apply any middlewares to 404.blade.php

#

Let me show you

fiery void Oct 4, 2023, 9:53 PM

#

indeed you can't middleware a middleware that's already thrown the exception in the first place??

wet hill Oct 4, 2023, 9:53 PM

#

I have this inside my 404.blade.php

<x-guest-layout>
    //whatever 404 error message
</x-guest-layout>

fiery void Oct 4, 2023, 9:53 PM

#

No because it's already thrown

wet hill Oct 4, 2023, 9:53 PM

#

Am I unable to overwrite this?

fiery void Oct 4, 2023, 9:53 PM

#

you can overwrite whats displayed to the user

#

see above and your link you shared

wet hill Oct 4, 2023, 9:54 PM

#

Right, but translatable strings won't work without my custom locale middleware

fiery void Oct 4, 2023, 9:54 PM

#

ok... so pass the request through your middleware in the first place

wet hill Oct 4, 2023, 9:55 PM

#

How could I pass the request through my own middleware when laravel handles the errors folder

#

Do I overwrite through handler.php?

fiery void Oct 4, 2023, 9:55 PM

#

no

#

in your route define the middleware

wet hill Oct 4, 2023, 9:56 PM

#

Route::middleware('locale')->group(function () {
    //
});

#

Right

fiery void Oct 4, 2023, 9:56 PM

#

wet hill Right, but translatable strings won't work without my custom locale middleware

This part is a bit strange though

#

actually not quite my apologies

wet hill Oct 4, 2023, 9:57 PM

#

That's the thing

#

public function handle(Request $request, Closure $next): Response
    {
        if (session()->has('locale')) {
            App::setLocale(session()->get('locale'));
        }

        return $next($request);
    }

#

This is the custom locale middleware that I'm using

fiery void Oct 4, 2023, 9:58 PM

#

sorry lets slow down I was a bit confused

wet hill Oct 4, 2023, 9:58 PM

#

Not quite custom, just basic but it's not a default middleware given with breeze

fiery void Oct 4, 2023, 9:59 PM

#

your picture was indeed correct - so if you get a 404 here and you've published the 404 how are you telling that blade to use new text

#

that's the problem to solve - that 404 is totally yours to play with if you've published it

wet hill Oct 4, 2023, 10:00 PM

#

You mean publish laravel's default error pages?

fiery void Oct 4, 2023, 10:00 PM

#

it's the same as any other blade file in your app

#

yes as per your original link

#

php artisan vendor:publish --tag=laravel-errors

#

they will be published and you can do what you want with them - i haven't used blade in a little while but if i remember righty something like {{__value}} to use translations

#

**don't change the filenames after publish or Laravel will use the default - it's just an override

wet hill Oct 4, 2023, 10:04 PM

#

That still doesn't work

#

My current locale is set to NL (dutch) but it still shows EN (english)

fiery void Oct 4, 2023, 10:04 PM

#

did you change the blade?

#

i mean in the same way you change it for all other translation pages

wet hill Oct 4, 2023, 10:05 PM

#

Yup

#

It uses the fallback instead of what I currently have set

fiery void Oct 4, 2023, 10:06 PM

#

there is something missing..

#

#

bit consufed in whats not working - i mean after publish did you stop and restart the server

#

I mean that and vite

wet hill Oct 4, 2023, 10:07 PM

#

Yeah that isn't the issue though

#

I believe translatable strings aren't working due to the fact I can't assign my locale middleware

fiery void Oct 4, 2023, 10:08 PM

#

in the end that page will render if you published it and edited it

#

did you try changing the text just to see if it's rendering your page

wet hill Oct 4, 2023, 10:08 PM

#

Yes that works

fiery void Oct 4, 2023, 10:09 PM

#

ok so it does all work it's just the translation part that doesn't

wet hill Oct 4, 2023, 10:09 PM

#

Exactly

fiery void Oct 4, 2023, 10:11 PM

#

hmm i mean when you set locale for the app (in your other pages) - from where do you get the translated text?

wet hill Oct 4, 2023, 10:12 PM

#

lang directory

fiery void Oct 4, 2023, 10:12 PM

#

ok so in there did you define the translations for the words in the 404

wet hill Oct 4, 2023, 10:12 PM

#

i'm pretty sure you are aware that you need a middleware to display the correct locale right

wet hill Oct 4, 2023, 10:13 PM

#

fiery void ok so in there did you define the translations for the words in the 404

i have

fiery void Oct 4, 2023, 10:17 PM

#

hmm i wonder if there is a conflicting translation entry - i mean if you are actually in NL then local should come as correct from the browser i guess - i mean i'm impressed that it took you 4 minutes to publish then find the file and modify that then again modify the guest-layout component

#

I run out of ideas on it really, I mean now you have the file in your control which was the first question, I don't know why doesn't translate maybe others have suggestions...

wet hill Oct 4, 2023, 10:19 PM

#

I have had past experience with this, however I haven't gotten as deep as translating the error pages, which makes sense if the user preferes dutch for example

#

Thanks though

fiery void Oct 4, 2023, 10:24 PM

#

Well that's always a debate, I mean I'm in DE working with NL speaking BE folks and I'm from GB but in the end the browser handles all of this these days...i tend not to spend too much time on it development wise for that reason - but yeah always nice if a site can use the users locale (except for me where chrome always makes it from DE to English) - in the end you can also assume that NL users will understand 'not found' in English - but i totally get it, that's not really ideal when rest of the site is in Dutch...sorry i couldn't be more help but lets see i'm curious on this now too tbh

wet hill Oct 4, 2023, 10:28 PM

#

Haha all good, appreciate the effort 👍

fiery void Oct 4, 2023, 10:28 PM

#

I'm working on a small side project i'm going to try this sh*t out

wet hill Oct 4, 2023, 10:29 PM

#

😂

#

it returns the 'locale' key in config/app.php unfortunately not the current locale tho 🥹

fiery void Oct 4, 2023, 10:31 PM

#

this would be ok aside from the rest of your site working correct

#

ahh

wet hill Oct 4, 2023, 10:32 PM

#

yup

fiery void Oct 4, 2023, 10:33 PM

#

so you know what to do now right?

#

did you DD your session locale - this literally should work if you have a correct value in translation...maybe change fallback to NL or some other and see what happens

#

At least then you'd know it IS using the fallback which means something is off in your nl.json

wet hill Oct 4, 2023, 10:41 PM

#

it doesn't use the fallback

wet hill Oct 4, 2023, 10:41 PM

#

wet hill it returns the 'locale' key in config/app.php unfortunately not the current loca...

it uses the default locale as previously mentioned

fiery void Oct 4, 2023, 10:41 PM

#

yeah but your default is set in any given request by the set locale you do in the middleware

#

...normally

#

Can it just be that you need to clear cache or something or at least dd the result of getLocale

wet hill Oct 4, 2023, 10:43 PM

#

wet hill ```php public function handle(Request $request, Closure $next): Response { ...

The current middleware checks if a session has a locale set, if it doesn't it uses the fallback

fiery void Oct 4, 2023, 10:43 PM

#

yeah that's what i meant before about dumping out the locale maybe it's not set

wet hill Oct 4, 2023, 10:43 PM

#

The isssue here is that the 404.blade.php that laravel generates doesn't use this middleware

#

So it never sets the preferred locale and instead goes straight to fallback

fiery void Oct 4, 2023, 10:44 PM

#

i think it's using it - i think it's more about the locale

#

**but hey i'm guessing now

wet hill Oct 4, 2023, 10:44 PM

#

I dumped just now, it didn't set it just went back to fallback :/

#

I tried

public function register(): void
    {
        $this->renderable(function (NotFoundHttpException $e, Request $request) {
            if (session()->has('locale')) {
                App::setLocale(session()->get('locale'));
            }
        });
    }

#

But that doesn't work either

#

(in handler.php

fiery void Oct 4, 2023, 10:45 PM

#

that's progress

#

paybe dump the whole session - if there's no locale then there's the answer - but i don't know why it's not set when you say it is set for other pages

wet hill Oct 4, 2023, 10:47 PM

#

The other pages utilize my custom middleware

wet hill Oct 4, 2023, 10:47 PM

#

minor rampart <@1066091114861437039> What if a middleware is the cause of the error…?

I'm losing braincells

fiery void Oct 4, 2023, 10:48 PM

#

sorry i meant /nl/messages.php

#

aswell as nl.json

#

also don't forget should be nl_NL or nl_BE

split ibex Nov 10, 2023, 4:37 PM

#

Sorry for posting on a slightly dead thread - but this is my issue and unfortunately the original link as been deleted, anyone got what it is?

#Apply middleware to Custom HTTP Error Pages