Downloading from "private" Folder in Laravel (Nova) | Laravel | Page 1

granite oxide Feb 7, 2023, 5:53 AM

#

Have you tried to response to a stream instead of a download URL?

#

Route::get('/stream', function () {
    return response()->streamDownload(function () {
        echo file_get_contents("your_file_path");
    }, 'responsed_file_name.ext');
});

dry spoke Feb 7, 2023, 11:48 AM

#

        $downloadableFile = response()->streamDownload('app/private/applications.pdf');
        Log::debug($downloadableFile);
        $filename = 'bewerbungen_lans ' . Carbon::today();
        $extension = '.pdf';
        return Action::download($downloadableFile, $filename . $extension);```
that gives me no file as well

orchid marsh Feb 7, 2023, 11:56 AM

#

you tried streaming ? to see what happening?

dry spoke Feb 7, 2023, 11:56 AM

#

yeah, [2023-02-06 12:47:29] local.DEBUG: HTTP/1.0 200 OK Cache-Control: no-cache, private Date: Mon, 06 Feb 2023 12:47:29 GMT

#

that's the log of the stream

#

but on "download" in the browser it always returns no file

#

maybe i have to ask is it generally possible to download a file if it's not in the public folder at all?

orchid marsh Feb 7, 2023, 11:58 AM

#

dry spoke maybe i have to ask is it generally possible to download a file if it's not in t...

yes... thats the exact purpose of the "private" storage

dry spoke Feb 7, 2023, 11:58 AM

#

i c

orchid marsh Feb 7, 2023, 11:58 AM

#

but you have permission setted correctly right?

dry spoke Feb 7, 2023, 11:58 AM

#

which permission? folder?

orchid marsh Feb 7, 2023, 11:59 AM

#

yes.. i mean the file is correctly written in that folder right?

dry spoke Feb 7, 2023, 11:59 AM

#

yep

#

the file exists

#

definetly

orchid marsh Feb 7, 2023, 11:59 AM

#

and if you open the file you see it correctly?

#

i mean.. manully open that file

dry spoke Feb 7, 2023, 11:59 AM

#

yep

#

everythings fine with this

orchid marsh Feb 7, 2023, 12:01 PM

#

try an exists and see what happen

#

$downloadableFile = Storage::disk('private')->exists('applications.pdf');

#

i think you are misspelling the correct path

#

check also in your filesystem to see what "private" disk link to

#

@dry spoke ? still there?

dry spoke Feb 7, 2023, 12:06 PM

#

yes, just in a meeting 😄

orchid marsh Feb 7, 2023, 12:07 PM

#

oki lemme know when you can try

dry spoke Feb 7, 2023, 12:52 PM

#

@orchid marsh log says [2023-02-06 13:43:26] local.DEBUG: 1 and browser says again, no file

#

            'driver' => 'local',
            'root' => storage_path('app/private'),
            'url' => env('APP_URL').'/storage',
            'visibility' => 'private',
            'throw' => false,
        ],```

#

that's what it filesystem looks like

orchid marsh Feb 7, 2023, 12:57 PM

#

oh.. isee now..

#

its not only called "private" .. the visibility is set to private

#

so the permissions will be 0600 for files.. you will not be able to "download" that file

#

when you store something "outside" the public folder you can already consider that as NOT public accessible. but if you set the visibility as "private" the file uploaded in that disk will be chmodded to 0600 so only the "owner" can read and write. useful if you want these files be accessible by your owner. but in this case youre trying to "serve" the files to public and the group doesnt have access.

#

you get what i mean?

dry spoke Feb 7, 2023, 1:03 PM

#

ok

#

so it should not be private?

orchid marsh Feb 7, 2023, 1:04 PM

#

btw if you set the "throw" to true you will probably can see the exact error..

dry spoke Feb 7, 2023, 1:04 PM

#

ok, changed to public

#

no change at all

#

as well as no error in log

#

[2023-02-06 13:57:27] local.DEBUG: 1

#

only my own log again

orchid marsh Feb 7, 2023, 1:05 PM

#

you need to

try{
} catch(Exception $e){
return $e;
}

dry spoke Feb 7, 2023, 1:06 PM

#

ok

#

just put the $downloadableFile = Storage::disk('private')->exists('applications.pdf'); in the try and catch?

orchid marsh Feb 7, 2023, 1:06 PM

#

->get

dry spoke Feb 7, 2023, 1:07 PM

#

so if i do get, i get the same error as before again

#

so he want's to download, but can't somehow

orchid marsh Feb 7, 2023, 1:09 PM

#

i think we need to try streaming that file correctly.. and then try the download

dry spoke Feb 7, 2023, 1:09 PM

#

but how to 😄

#

in the meantime wanna thank you for your help already 😉

orchid marsh Feb 7, 2023, 1:15 PM

#

public function handle(ActionFields $fields, Collection $models)
    {
        $file = Excel::store(new MultipleSheetsApplications($models), 'applications.pdf', 'private');
        $downloadableFile = Storage::disk('private')->get('applications.pdf');
        $filename = "test.pdf"; //here your carbon date things.. but lets try with simple test
        $headers = [
            'Content-Type'        => 'application/octet-stream',
            'Content-Disposition' => 'attachment; filename=' . $fileName,
        ];
        
        return response( $downloadableFile, 200 , $headers);
    }

dry spoke Feb 7, 2023, 1:16 PM

#

i think that approach wont work.. because if it's no nova action, there won't be any response at all

#

but i test of course

#

yeah, as assumed, nothing happens if i press the according button

#

it just says, action was executed successfully

orchid marsh Feb 7, 2023, 1:18 PM

#

damn forget you were on nova

dry spoke Feb 7, 2023, 1:18 PM

#

yes m8, that's the problem 😄

orchid marsh Feb 7, 2023, 1:20 PM

#

try catch a response()->streamDownload('app/private/applications.pdf');

dry spoke Feb 7, 2023, 1:20 PM

#

instead of the storage::disk part?

orchid marsh Feb 7, 2023, 1:20 PM

#

yes

dry spoke Feb 7, 2023, 1:21 PM

#

ok

orchid marsh Feb 7, 2023, 1:23 PM

#

wait mate... wondering another thing... you changed visibility to "public" but the file has been re-uploaded? could you verify that chmod of that file are 0664 or 0644 ?

dry spoke Feb 7, 2023, 1:24 PM

#

drwx------ 2 tobi tobi 4096 Feb 6 20:47 private

#

that's the folder...

#

that's the file -rw-r--r-- 1 tobi tobi 50348 Feb 6 22:12 applications.pdf

orchid marsh Feb 7, 2023, 1:25 PM

#

yep .. its correct

dry spoke Feb 7, 2023, 1:25 PM

#

can you just help me with the correct syntax for the try catch?

#

i barely use try catch

orchid marsh Feb 7, 2023, 1:26 PM

#

yep

dry spoke Feb 7, 2023, 1:26 PM

#

i think i have it

#

        try {
            $downloadableFile = response()->streamDownload('app/private/applications.pdf');
        } catch (Exception $e) {
            return $e;
        }
        // Log::debug($downloadableFile);
        $filename = 'bewerbungen_lans ' . Carbon::today();
        $extension = '.pdf';
        return Action::download($downloadableFile, $filename . $extension);```

#

right?

orchid marsh Feb 7, 2023, 1:27 PM

#

yep---

dry spoke Feb 7, 2023, 1:27 PM

#

ok, no change, no error, nothing

orchid marsh Feb 7, 2023, 1:27 PM

#

i dont know if nova use throwable...

dry spoke Feb 7, 2023, 1:27 PM

#

orchid marsh i dont know if nova use throwable...

i think so

#

afaik it does

#

m8 brb...

orchid marsh Feb 7, 2023, 1:28 PM

#

}catch (\Throwable $error){
return $error
}

dry spoke Feb 7, 2023, 1:36 PM

#

ok re

#

        try {
            $downloadableFile = response()->streamDownload('app/private/applications.pdf');
        } catch (\Throwable $error) {
            return $error;
        }
        // Log::debug($downloadableFile);
        $filename = 'bewerbungen_lans ' . Carbon::today();
        $extension = '.pdf';
        return Action::download($downloadableFile, $filename . $extension);```
like this, right?

#

unfortunately no error log

orchid marsh Feb 7, 2023, 1:39 PM

#

ok latest one

#

put everything in the try

#

also the return:Action etc

dry spoke Feb 7, 2023, 1:40 PM

#

ok

orchid marsh Feb 7, 2023, 1:40 PM

#

did you set Throw to true in filesystem right?

dry spoke Feb 7, 2023, 1:41 PM

#

yep

orchid marsh Feb 7, 2023, 1:41 PM

#

and please set $filename to some test string like "test.pdf"

dry spoke Feb 7, 2023, 1:42 PM

#

        try {
            $downloadableFile = response()->streamDownload('app/private/applications.pdf');
            $filename = 'testfile.pdf';
            // $extension = '.pdf';
            return Action::download($downloadableFile, $filename);
        } catch (\Throwable $error) {
            return $error;
        }```
that's the actual code right now

orchid marsh Feb 7, 2023, 1:42 PM

#

yep

dry spoke Feb 7, 2023, 1:43 PM

#

no change at all

orchid marsh Feb 7, 2023, 1:43 PM

#

and ?

dry spoke Feb 7, 2023, 1:43 PM

#

no error nothing

#

browser just throws

#

german for, could not download, no file

orchid marsh Feb 7, 2023, 1:44 PM

#

no wait..

#

the $downloadableFile need to be the file.. not the stream

dry spoke Feb 7, 2023, 1:45 PM

#

ah ok

#

sry

orchid marsh Feb 7, 2023, 1:45 PM

#

the stream was for the previous test

dry spoke Feb 7, 2023, 1:46 PM

#

i tried this now $file = Excel::store(new MultipleSheetsApplications($models), 'applications.pdf', 'private'); try { $downloadableFile = 'testfile.pdf'; // $filename = 'testfile.pdf'; // $extension = '.pdf'; return Action::download($downloadableFile, 'test.pdf'); } catch (\Throwable $error) { return $error; }

#

but no change at all

orchid marsh Feb 7, 2023, 1:46 PM

#

no.

#

again wrong.

dry spoke Feb 7, 2023, 1:47 PM

#

you mean the applications.pdf?

orchid marsh Feb 7, 2023, 1:47 PM

#

wait

dry spoke Feb 7, 2023, 1:47 PM

#

k

orchid marsh Feb 7, 2023, 1:50 PM

#

$file = Excel::store(new MultipleSheetsApplications($models), 'applications.pdf', 'private');
try {
   $thefilepath = Storage::disk('private')->path('applications.pdf');
   return Action::download($thefilepath , 'test.pdf');
} catch (\Throwable $error) {
   return $error;
}

#

path* not url

dry spoke Feb 7, 2023, 1:51 PM

#

#

😄

orchid marsh Feb 7, 2023, 1:51 PM

#

you changed with path?

dry spoke Feb 7, 2023, 1:52 PM

#

sry

#

same error, nevertheless

#

could not download file

orchid marsh Feb 7, 2023, 1:53 PM

#

return $thefilepath and see what is it

#

$file = Excel::store(new MultipleSheetsApplications($models), 'applications.pdf', 'private');
try {
   $thefilepath = Storage::disk('private')->path('applications.pdf');
   //return Action::download($thefilepath , 'test.pdf');
   return $thefilepath;
} catch (\Throwable $error) {
   return $error;
}

dry spoke Feb 7, 2023, 1:53 PM

#

where should the return appear?

orchid marsh Feb 7, 2023, 1:54 PM

#

depends on where you call it---

#

do a die and dump

dry spoke Feb 7, 2023, 1:54 PM

#

in the browser

#

the dd doesn't work

#

        try {
           $thefilepath = Storage::disk('private')->path('applications.pdf');
           dd($thefilepath);
        } catch (\Throwable $error) {
           return $error;
        }``` like this, correct?

orchid marsh Feb 7, 2023, 1:56 PM

#

it seems so...

#

shrug out of ideas here

dry spoke Feb 7, 2023, 1:56 PM

#

yeah, no dd in nova

dry spoke Feb 7, 2023, 1:56 PM

#

orchid marsh <:shrug:332268181517238272> out of ideas here

thanks anyways..

#

that's some crazy stuff, right

#

sometimes i hate my client requested nova

#

there's so many restrictions

orchid marsh Feb 7, 2023, 1:58 PM

#

are you in Debug mode right?

dry spoke Feb 7, 2023, 1:58 PM

#

yeah

orchid marsh Feb 7, 2023, 2:00 PM

#

just for curiosity sake ... var_dump() that variable what happen?

dry spoke Feb 7, 2023, 2:02 PM

#

the var_dump should appear in the browser window as well, right?

orchid marsh Feb 7, 2023, 2:02 PM

#

ye

dry spoke Feb 7, 2023, 2:02 PM

#

no output 😄

#

i really suuuuuucks

#

i'm already working on a solution for 1 1/2 days

#

that's really impossible...

orchid marsh Feb 7, 2023, 2:04 PM

#

this sound really weird

dry spoke Feb 7, 2023, 2:04 PM

#

if the file is in public, everythings easy

#

but as soon it is in a private folder, nothing works anymore

orchid marsh Feb 7, 2023, 2:05 PM

#

$file = Excel::store(new MultipleSheetsApplications($models), 'applications.pdf', 'private');
try {
   $thefilepath = Storage::disk('private')->path('applications.pdf');
   //return Action::download($thefilepath , 'test.pdf');
   var_dump($thefilepath);
   exit;
} catch (\Throwable $error) {
   return $error;
}

#

if it correctly upload/create the file in that disk.. its weird that it doesnt even show you the path to that file

#

with no error..

dry spoke Feb 7, 2023, 2:07 PM

#

but the file is there, 4 sure

orchid marsh Feb 7, 2023, 2:07 PM

#

but probably im missing something ,, or its something Nova related..

dry spoke Feb 7, 2023, 2:07 PM

#

i see it with my own eyes 😄

dry spoke Feb 7, 2023, 2:07 PM

#

orchid marsh ```php $file = Excel::store(new MultipleSheetsApplications($models), 'applicatio...

unfortunately no dump at all

orchid marsh Feb 7, 2023, 2:11 PM

#

i think you have to ask some more skilled help then mine bruh!

dry spoke Feb 7, 2023, 2:11 PM

#

nevertheless, thanks for your effort

#

for how long are you coding already?

orchid marsh Feb 7, 2023, 2:13 PM

#

in laravel? approx 4/5 months

dry spoke Feb 7, 2023, 2:13 PM

#

generally?

orchid marsh Feb 7, 2023, 2:14 PM

#

dry spoke generally?

my whole life... lol.. approx 20 years

dry spoke Feb 7, 2023, 2:14 PM

#

lol, i c

#

so you're way more experienced than me, i just started out 2 years ago finally pursuing my lifelong dream 😄

orchid marsh Feb 7, 2023, 2:18 PM

#

lol i see..

desert raptor Feb 7, 2023, 2:24 PM

#

I think the problem is, you're trying to return the PDF from the Nova API.php in a custom tool or action right?

#

The steaming approach should work perfectly as that's what it's good at

dry spoke Feb 7, 2023, 2:25 PM

#

desert raptor I think the problem is, you're trying to return the PDF from the Nova API.php in...

yes

desert raptor Feb 7, 2023, 2:25 PM

#

Is it a custom tool, or action?

dry spoke Feb 7, 2023, 2:25 PM

#

desert raptor The steaming approach should work perfectly as that's what it's good at

custom action yes

#

you mean like this response()->streamDownload('app/private/applications.pdf');

desert raptor Feb 7, 2023, 2:26 PM

#

Ok, so the problem is, Nova sends the request from your browser to the API, then returns the response to your browser, so any response you send, won't actually send the value back to you

dry spoke Feb 7, 2023, 2:27 PM

#

ok

desert raptor Feb 7, 2023, 2:27 PM

#

I'm not sure you can do it with a custom action to be honest, you need a way to return a URL that you can redirect the browser to, which will then download the PDF

dry spoke Feb 7, 2023, 2:27 PM

#

ok, can you think about another approach which might work in this case?

orchid marsh Feb 7, 2023, 2:28 PM

#

@dry spoke : that's what a skilled developer looks like -> @desert raptor

desert raptor Feb 7, 2023, 2:28 PM

#

I would:

Define an endpoint in your normal laravel routes that takes the id of your model.
In the controller, grab the model id and load it, and return the PDF file from storage using the Response::stream method mentioned above

#

this should download it for you and not store it anywhere

#

then to secure it, add something like either:

Laravel signed routes (https://laravel.com/docs/9.x/urls#signed-urls)
or a password / something

If you use signed routes, you can replace your custom action with a custom field, that just generates a signed URL to that endpoint you've defined

Laravel - The PHP Framework For Web Artisans

Laravel is a PHP web application framework with expressive, elegant syntax. We’ve already laid the foundation — freeing you to create without sweating the small things.

#

And people can just click "download" and it will download, and if someone hits it without a signing token, it'll 403

#

you just have to lock down who can see that "download" custom field

dry spoke Feb 7, 2023, 2:31 PM

#

the problem, what i just think of is, how do i get the "custom" download link into the nova backend?

#

you get my point?

#

ah i see, you mean by that custom field, right?

desert raptor Feb 7, 2023, 2:34 PM

#

Yeah!

dry spoke Feb 7, 2023, 2:35 PM

#

ok

#

gotta consider that approach

#

thanks for that hint

desert raptor Feb 7, 2023, 2:36 PM

#

Np

dry spoke Feb 7, 2023, 3:15 PM

#

@desert raptor i just thought of another possibility.. in the source of Nova Actions i found there's some callback after the execution of the action.. ```` /**
* Register a callback that should be invoked after the action is finished executing.
*
* @param callable(\Illuminate\Support\Collection):mixed $callback
* @return $this
*/
public function then($callback)
{
$this->thenCallback = $callback;

    return $this;
}```

but i'm not sure how / where to execute this callback, can you give me a hint?

#

i thought of, generating the file, put it into the public, and after the file has been downloaded and the action "finished" executing, deleting the file immediately in the callback

desert raptor Feb 7, 2023, 3:29 PM

#

Yeah you could do that, but there's no guarantee that the user has downloaded the whole file before it's been deleted, and you'd have to be pretty sure that it's deleting them for it to be secure.

dry spoke Feb 7, 2023, 3:30 PM

#

yeah, ok

#

agree, but how to call this callback?

#

this is what i still stumble upon

desert raptor Feb 7, 2023, 3:36 PM

#

The one in the example above?

dry spoke Feb 7, 2023, 3:36 PM

#

yes

desert raptor Feb 7, 2023, 3:37 PM

#

not 100% sure as i can't see it in the documentation

dry spoke Feb 7, 2023, 3:37 PM

#

where and how to call this callback?

desert raptor Feb 7, 2023, 3:37 PM

#

but i think it's when you register it

dry spoke Feb 7, 2023, 3:37 PM

#

ah ok

desert raptor Feb 7, 2023, 3:37 PM

#

{
    return [
        Actions\EmailAccountProfile::make()->then(function() {
            // Your stuff here
        });
    ];
}

#

but that's purely a guess

dry spoke Feb 7, 2023, 3:37 PM

#

ok

#

otherwise i'm gonna check back in the nova specific discord channel

#

but i try your approach first

#

thanks 🙂

desert raptor Feb 7, 2023, 3:38 PM

#

np, good luck

granite oxide Feb 7, 2023, 3:56 PM

#

Have you tried the code I provided?
Perhaps you should modify the file_get_contents to storage and I ensure the code is working well whether it runs in Laravel
@dry spoke

dry spoke Feb 8, 2023, 3:23 AM

#

granite oxide Have you tried the code I provided? Perhaps you should modify the `file_get_cont...

so your approach is, to create a route and in the nova action on return redirect to that laravel route?

#

do i understand you right?

granite oxide Feb 8, 2023, 7:21 AM

#

dry spoke so your approach is, to create a route and in the nova action on return redirect...

Just a sample code, you could create a test route for it and then you can move some code to your controllers or action

dry spoke Feb 8, 2023, 7:37 AM

#

granite oxide Just a sample code, you could create a test route for it and then you can move s...

but what's your general approach? because i can't use the stream in DIRECTLY the nova action, it's not working

#

ok, found a solution according to all your hints, i created a protected route and make a redirect in the custom action to the download

#

thanks a lot for your help guys

#Downloading from "private" Folder in Laravel (Nova)