#docs-website

1 messages · Page 17 of 1

lean venture
#

is it just a decompiler?

#

or am I missing smt

random pollen
#

theres docs linked in one of the info things in the action menu

drowsy zinc
#

$lib/tab and $lib/components/pane/pane.svelte

#

wouldn't take an example of that code lol

lean venture
#

god, whoever said kotlin sucked to reverse engineer was not joking

random pollen
#

you might notice that actually has quite a bit of resugaring lol

drowsy zinc
#

$lib/tab not task bruh

random pollen
#

yeah I figured lol

drowsy zinc
#

any other decompiler would output a java approximation but that's vineflower which has a kotlin plugin, so it outputs kotlin-ish

drowsy zinc
lean venture
#

xD

jagged pecan
random pollen
#

funny how I looked in your package json and half the libs is stuff I normally use

drowsy zinc
#

it started to lag with minecraft loaded in

random pollen
#

didn't add anything like the tabs in slicer yet but I got sidebar resizing working pretty good

#

one thing I wish paneforge had was the ability to make a pane avoid resizing when the container resizes

#

so that if I shrink or grow the window the sidebar won't change size to keep proportion

#

it would only shrink if the window got smaller than it

random pollen
drowsy zinc
#

looks cool

#

I think we're pushing what paneforge was designed for a little bit

random pollen
#

yeah maybe

#

I actually found kind of a cursed solution

#
// Maintain sidebar size when resizing window
watch.pre(
    () => this.windowInnerWidth,
    (newValue, oldValue) => {
        if (oldValue !== undefined && newValue !== undefined && this.sidebarPane) {
            const oldPx = (this.sidebarPane.getSize() / 100) * oldValue;
            const newProportion = this.getProportion(oldPx, newValue);
            this.sidebarPane.resize(newProportion);
        }
    },
);
#

it still glitches a little bit but by using pre it doesn't lag at least

#

actually it's pretty much perfect when sidebar is on the left, only glitchy on the right the sidebar fidgets when you resize the window from the opposite side it's docked to

random pollen
#

but I think I can live with it for now

pliant canopy
#

Is there any way we can make these messages not appear? I know that on the docs github they don't; maybe apply the same change to the website webhook? Idk how that is managed

burnt ice
#

@opal flare

wispy python
#

?

lean venture
drifting flume
#

Hey, what can be contributed to the paper docs?
I think this section could use a little more info on database frameworks/libraries like jooq or exposed for a more type-safe approach or help with auto-generated code, instead of handling everything with raw java.sql
Is that something that would fit into the docs?
https://docs.papermc.io/paper/dev/using-databases/

fair river
drifting flume
#

Sure based

wispy python
#

Read the conv

spice temple
#

I think mentioning them and explaining them with like a sentence or two is fine, I wouldn't explain how to use them, only link to relevant documentation

#

might aswell explains ORMs and mention hibernate and throw jdbi into the mix, but can always be expanded

pliant canopy
#

Indeed, I share Mini's opinion. We don't really want to go in-depth into not Paper specific concepts since there are plenty of docs explaining how to use databases with Java already and there is no need to clutter our docs with that. But mentioning it so that people become aware is good

#

They can do their own research afterwards and find much more specific docs on those subjects if they were to just look it up themselves

eager plover
#

Most of the goal of the "using a DB" page was just to provide a simple "getting started" type of deal, documenting 3rd party projects in there is just extra burden especially when those providers already have good docs, would generally lean more towards noting some of the caveats of using a DB in paper, "it works just like a normal java app but you might want to be mindful of were you do your IO" type stuff

pointing towards common solutions is fine, if we ever get an example repo running we might even allow contributions for such (but, such does come with the fear of this stuff falling out of date)

drifting flume
#

Yh, the idea I had was to basically mention those tools, the advantages over java.sql and provide a snippet comparing how a query looks, enough for people to know the existence of said tools before forwarding them to the actual documentation
It think it would be slightly shorter than the SQL Injection section

eager plover
#

I suck at english, I'm generally concerned over the wording of the PR for ^ in that it feels somewhat loaded and maybe kinda vague; I worry it's maybe overly pushy for tools we can't really support?

#

In wider terms of that page, the nature of being useful for beginners, I think a fair pressing need for expansion exists in ecosystem specifics, such as avoiding your IO on the main thread, but it also feels that every few months I have a discussion of "you should probably avoid caching eco" type discussions

drifting flume
#

I made it somewhat vague to not make it sound like advertising for those tools

#

Plus trying to explain the context of those tools, but at the same time not diving too much into it

eager plover
#

I'm semi worried that the way in which it's worded kinda makes it feel like it's an imperative for developers to start using those tools

drifting flume
#

And I tried to avoid sounding like that despair

eager plover
#

I did ask chatgpt because I suck at language, it generally suggested this which feels a bit more natural;

When working with SQL, developers often need to balance security, type-safety, and code readability. Using a library can help handle these concerns automatically, letting you focus on the business logic rather than the low-level SQL details.

Libraries take different approaches, such as SQL builders or ORMs. Popular options in Java include JDBI and JOOQ.
drifting flume
#

For example, I avoided terms like "popular" because I truly don't know how popular these tools are amongst plugins devs

#

Referring to the last line btw

eager plover
#

I mean, those are popular options for people wanting to use those types of tools in java

drifting flume
#

The first paragraph does look better, I'll try to word something like that

eager plover
#

I'm not 100% on the chatgpt output, but I think it leans in a nicer direction, I'm generally pondering what the other docs people think as my English made my English teacher upset 😄

drifting flume
#

I mean, in general yh, those tools are definitely popular, I'm just not so sure how much they are in the context of minecraft plugins
Plugins I know using jooq are relatively few, can't say much about jdbi tho, didn't payed much attention to it

#

I'll also wait what the rest of the team says. but will be trying to follow a similar structure to the sample you sent 🫡

serene vault
#

We also mention Hikari and even have an example for it.
I feel like mentioning some commonly used tools is fine, but I would remove the JOOQ example - that is something people can then look up if they decide on a tool. e.g. I would prefer JDBI there

#

And maybe remove the " leaving the developer with clean, secure and readable code." part. that sounds too much like ChatGPT

drifting flume
#

Don't tell me I talk like chatgpt despair

#

I'll have to look at some jdbi examples, I mostly use jooq and exposed

#

-# ^ Forget it I just understood what you meant about jdbi

#

I guess providing an example for both would bloat the doc, so that's out of question. I'll see if I can figure out a way to give a peek into how tools reduce the code compared to plain jdbc

serene vault
#

Yeah I didn't mean that you should add more examples, I think just directing people to the tools should be good enough. e.g. they all have some examples in their docs or similar

drifting flume
#

Dw, I understood I should remove them

drifting flume
#

I took a different approach this time.
I removed the part mentioning sql-builders and orm, plus focused on the advantages of these tools in the context of what is already on the docs (connecting with hikari, building queries, keeping an eye for sql injections) and added a bit about parsing, since what is fetched from the db will most likely be used in an object.
It is extremely short this time (this is the whole section), what do you think? I also tried following a similar wording to the example from ecat

## Database tools

Given the complexity of working with databases (managing connections, building and securing queries, or just parsing the data) several tools
exist in the world of Java to leverage this work.

Some plugin developers use tools like [JDBI](https://jdbi.org/) or [JOOQ](https://www.jooq.org/doc/latest/manual/), which are lightweight
and easy to use.
#

Since there are no examples this time, maybe I could mentioned exposed as well

#

Small fix because I felt it ended up too dry

## Database tools

Given the complexity of working with databases (managing connections, building and securing queries, or just parsing the data) several tools
exist in the world of Java to leverage this work.

Some plugin developers use lightweight tools like [JDBI](https://jdbi.org/), [JOOQ](https://www.jooq.org/doc/latest/manual/) 
or [Exposed](https://www.jetbrains.com/help/exposed/get-started-with-exposed.html), which take care of all the heavy lifting, 
allowing the developers to focus on their plugins rather than the database.
blissful nebula
#

what is paper mc

twilit fog
pliant canopy
#

How do you even end up here if you have no idea what it is

#

And this description here is basically everywhere where you can get the invite link from

jaunty garnet
scenic gull
#

Let's keep on topic.

hearty briar
#

now that adventure and paper docs are merged, perhaps it would be good to merge the GlobalTranslator docs in the Paper docs and the MiniMessage translator ones under an Adventure i18n section

#

I always end up linking the two when people ask about server-side translations so I feel like they should just be one honestly

lean venture
odd harborBOT
rain ocean
#

Is it just me or does every doc page switch cause the entire page to reload and the sidebar has to redo its long animation? I tried disabling my extensions, and even switch browsers. I haven't seen other starlight astro docs have this issue

drowsy zinc
#

the entire page reloads because it's navigating, it's not a spa

#

the animation is us scrolling to the active page because the sidebar is too long

rain ocean
#

Also on slower internet, it seems the font isnt being cached, cause the entire page content is twitching every single time u switch pages

rain ocean
drowsy zinc
#

they don't scroll?

rain ocean
#

?

#

i just tested it on the starlight official docs

#

and made my window small

#

they dont have this problem

#

the scroll animation is cool for very first page load, but should not be a thing when switching pages

lean venture
#

yeah the font issue is indeed bad

drowsy zinc
# rain ocean they dont have this problem

they don't have this problem because they don't scroll the sidebar programmatically, the shift depends on your browser's handling of scrollIntoView when the element is actually visible, I would accept a PR to manually check for that

drowsy zinc
rain ocean
#

and they dont have crappy internet, but its not fiber or anything

drowsy zinc
#

I'll try to reproduce it

rain ocean
#

im assuming this is caused by font loading

#

and my guess is the browser is not caching it

drowsy zinc
#

I don't see any shift on my default connection speed in my firefox instance since the font & logo have been preloaded

#

if you don't have the issue on the main site that also uses the poppins font, just embedding the font into the stylesheet might be our best bet

rain ocean
#

well the mainsite, u dont click around on pages with the same page structure as u would on the docs site, so its much harder to notice

#

but the mainsite also has the problem

#

the issue is on the font assests ur giving a no cache header, there shouldnt be a need to redownload the font on every single page loads, or well any of these assests on every page load

drowsy zinc
#

yea the main site doesn't have the same rules as docs do

#

I thought it embedded the fonts in the stylesheet though, might be pre-astro rewrite behavior

spice temple
# rain ocean

That is a request header, you set that. I cant check myself right now, but by default devtools disable caching if open

wispy python
#
[07:17:27 ERROR]: [StarRaid] Uncaught exception in scheduled task
java.lang.IllegalStateException: Asynchronous getNearbyEntities!
at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:10) ~[paper-1.21.10.jar:1.21.10-113-9fc21bc]
at org.bukkit.craftbukkit.CraftWorld.getNearbyEntities(CraftWorld.java:979) ~[paper-1.21.10.jar:1.21.10-113-9fc21bc]
at org.bukkit.craftbukkit.CraftWorld.getNearbyEntities(CraftWorld.java:974) ~[paper-1.21.10.jar:1.21.10-113-9fc21bc]
at org.bukkit.World.getNearbyEntities(World.java:1681) ~[paper-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at org.bukkit.World.getNearbyEntitiesByType(World.java:1114) ~[paper-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at org.bukkit.World.getNearbyEntitiesByType(World.java:1068) ~[paper-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at org.bukkit.World.getNearbyPlayers(World.java:987) ~[paper-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at com.destroystokyo.paper.ParticleBuilder.receivers(ParticleBuilder.java:247) ~[paper-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at com.destroystokyo.paper.ParticleBuilder.receivers(ParticleBuilder.java:194) ~[paper-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at com.destroystokyo.paper.ParticleBuilder.receivers(ParticleBuilder.java:148) ~[paper-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at StarRaid-1.0.jar/dev.threeadd.feature.emp.EMPManager.lambda$startEMPTicker$1(EMPManager.java:67) ~[StarRaid-1.0.jar:?]
at StarRaid-1.0.jar/dev.threeadd.core.util.ScheduleUtil.lambda$wrap$0(ScheduleUtil.java:88) ~[StarRaid-1.0.jar:?]
at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78) ~[paper-1.21.10.jar:1.21.10-113-9fc21bc]
at org.bukkit.craftbukkit.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[paper-1.21.10.jar:1.21.10-113-9fc21bc]
at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[paper-1.21.10.jar:?]
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]```
```Sends the particle to all receiving players (or all). This method is safe to use Asynchronously
Returns:
a reference to this object.```Wrongly documented as thread safe?
twilit fog
wispy python
#

okay

twilit fog
#

also what is ScheduleUtil

#

@wispy python your problem is you are using non async thread safe methods (namely receivers) on the ParticleBuilder in async

#

only spawn() method is async safe

#
    private static void spawnParticle(final Location someLocation) {
        ParticleBuilder explosionParticleBuilder = Particle.HAPPY_VILLAGER.builder()
            .location(someLocation)
            .offset(0, 10, 0)
            .count(0)
            .receivers(32, true);
        Bukkit.getAsyncScheduler().runNow(ParticleTest.getPlugin(ParticleTest.class), task -> {
                explosionParticleBuilder.spawn();
        });
    }

My method works fine

wispy python
twilit fog
wispy python
#

When running async it lags out my connection, we’re talking bout it in #paper-dev

twilit fog
#

how is that documented wrong

#

the docs are factually correct, there is no mention of performance of what you're talking about

scenic gull
wispy python
#

oh mb

random pollen
#

if someone wants to figure out how to make an action that comments a link to look at a diff-viewer PR diff in the PR's preview deployment that would be cool omegaroll

vocal halo
#

I think the wording is a bit weird

#

But nice idea

#

Makes perfect sense to have this imo

#

Although using a random paper commit could also be funny

pliant canopy
#

I very much struggled with how I wanted to word it

lilac edge
#

i'm surprised that refined cloudflare pages action doesn't give you control over the content of the comment

personally i would incorporate it within the cloudflare deployment message and include it as another column, e.g. "PR Diff Preview"?

The PR itself looks good, maybe "Click here to preview this PR's diff using it's deployment URL"?

pliant canopy
#

And thinking about it, I could probably also just straight up modify the comment

#

That actually sounds like a fun idea

neon epoch
#

Be nicer if this was an action on the repo u wanted it to do

#

But generally a nice idea

lilac edge
#

wouldn't make sense with the deployment url part since that's specifically for diff-viewer PRs

#

but in general using the diff-viewer website yeah i'd agree

vocal halo
#

but yeah it would be nice to customize the message

south thunder
#

I'm planning to make an extension to the troubleshooting guide with something along the lines of "I/someone can't join the server"
Is it fair game to copy a factoid into there if I point this out?
#paper-help message

jagged pecan
random pollen
#

maybe

#

(probably)

#

it's supposed to respond to head requests

opal flare
#

that is the wrong line for sure

jagged pecan
#

Head: not-present (France)

wintry flint
pliant canopy
vocal halo
wintry flint
scenic gull
#

https://docs.papermc.io/misc/downloads-service/

You should always serve & use the stable builds. Experimental builds are prone to error and do not receive support.

  • Ampersand instead of and?
  • Experimental builds don't get support? But... we do help fix issues with them, that's how we fix many bugs!
  • Should this be modified from always serve to always offer by default (or similar phrasing) to encourage stable but acknowledge beta and alpha exist and some users might want to try beta at the very least?
eager plover
#

Yea, the wording there looks kinda weird; Experimental builds come with a higher expectation on the user to know what they're doing,is I guess what is trying to be conveyed there

drowsy zinc
#

the sentence should probably just be scrapped in favor of an entire section on the channel nomenclature

pliant canopy
#

@sharp pivot is that property already inside of Paper, meaning it could be merged right now?

#

I cannot be bothered to validate it atm

sharp pivot
#

it is

pliant canopy
#

Great, all I needed to hear

timid cedar
#

might it be worth not having the word "stable" in the tagline for experimental paper builds?

vocal halo
#

experimental […]. proceed with caution

#

I don’t think paper provides support or guarantees it’s 100% stable so people can’t sue papermc for it.

humble perch
#

can i ask questions in here if i have trouble wit paperMC plugins? >My core i use on my server is paperMC, where can i get help?

#

im new to this server

drowsy zinc
#

this server is generally not the place for seeking help with plugin administration, you can try helpchat from #community-guilds

humble perch
#

okay thank you sir!

opal flare
#

<@&1190722804849582152> https://docs.papermc.io/misc/downloads-service/ needs updating, did not get updated after the pagination change to GraphQL endpoint. Also, the "lastest stable build" ones don't work if the most recent version has no STABLE channel downloads - those need adjusting

eager plover
#

somebody borked docs deployment?

pliant canopy
#

A re-run of the action fixed it

random pollen
#

outlines on this type of icon button or no

#

(the color is changed as part of a broader change where I'm reducing the blue-500 spam PepeLa)

vocal halo
#

what did blue-500 do?

random pollen
#

(no outline won)

vocal halo
#

Looks weird at first glance without the blue

opal flare
#

the blue is too much imo

vocal halo
#

Text was better readable with the blue imo

#

At least the selects

clever basalt
#

i love the second version

#

if you use a color for everything then it's kinda noisy

brazen moon
#

Looks like diff viewer can't read initial commit from github without parent

fair river
#

@random pollen fix it Pout

random pollen
#

might also be an issue idr

random pollen
#

@slate scarab

slate scarab
#

get out of my head

#

add file extension filters sir

timid mulch
#

And a filter for moved files without content changes?

pliant canopy
#

@violet bough sooo, regarding PaperMC/docs#697, which talks about the removal of the project setup using the MCDev plugin, I'd like to talk to you as a representative of MCDev.

To be frank with you, I fully agree. The default plugin template is really not that great. There are some unnecessary parts in the build script and generally also some straight up wrong stuff (I don't know if that is relevant anymore, but I remember that the default setup did not work the config cache; maybe that has changed since the last time I've used it, which has been ages frankly).

But I think this being the case is sad, as the plugin has other great uses as well, which are lesser known (like the event method generator, which I have seen nobody use). Instead, I wanted to directly ask you, whether you would accept a direct contribution to the template itself to modernise and fix it in order to keep that plugin as part of our Paper docs.

I realise I could've simply opened an issue on your repo, but I think having this in discussion openly like this could be nicer and more reachable.

vocal halo
#

only real thing is that the templates aren't kotlin scripts, which kinda sucks a bunch
rage bait 😆

eager plover
#

Not really rage bait, the community is moving away from groovy

vocal halo
#

poor groovy.

violet bough
pliant canopy
#

Alright very well, I will shoot up a PR and you can tell me what you think of it

#

I think that's the nicer option to just completely nuke it off the docs site

violet bough
#

Planning on getting rid of all the groovy build scripts too

pliant canopy
#

Great, we should encourage people to use kts Gradle anyways

violet bough
#

only use groovy since those templates were originally put together prior to when kotlin build scripts even existed

pliant canopy
#

Fair enough

#

Never done any IJ templates, how do I test these?

#

Oh well, it is explained in the README, fair enough

violet bough
#

unfortunately if you go to test this the local repo is currently broken because jetbrains did what jetbrains does

#

So, just give us some time to fix that

#

Unrelated but I am a bit taken aback by how you worded your original message, if I would "accept a direct contribution to the template" - mcdev has been an open source project since day 1, over 10 years ago. I've never been antagonistic towards accepting contributions, the way you presented the message feels as if you expected some kind of push back from me. I assume that isn't what you meant, but it was jarring for me to read that, confused by the tone I perceived

pliant canopy
violet bough
#

it's all good, just a classic case of tone coming across wrong via text. It happens, and sorry I read it that way

pliant canopy
#

I just wrote that on a whim, so maybe re-reading that could've been a good idea

vocal halo
pliant canopy
pliant canopy
vocal halo
#

I read it as we can do this and that

#

And not yeah this is a better alternative

#

Sorry

pliant canopy
#

Yeah, I've been kinda wanting to improve the mcdev templates for a while now, I just kinda never got the push I needed

hearty briar
pliant canopy
#

The clicking buttons part, perhaps

hearty briar
#

a recommendation to use mcdev on the top as an alternative to manual setup would've been enough

pliant canopy
#

But the mcdev template project setup step is fine I believe

#

Remember, this is for people who have never made a plugin before and might have very little Gradle knowledge

hearty briar
#

I don't think that's productive given we will in fact just send people to learn java if they don't know how to follow that guide

pliant canopy
#

Knowing Java is a different topic from knowing Gradle

hearty briar
#

but well, it is already part of the documentation so there's no harm in just leaving it there at this point, I am not that against it

pliant canopy
#

You can know Java without having tooling knowledge

hearty briar
#

I would disagree, you need to be able to understand the tooling at least on a basic level in order to understand java on a basic level

pliant canopy
#

Or you might come from a different background, like C#, meaning you are not entirely lost when doing Java dev, but might still not have any Gradle knowledge

hearty briar
#

like, I don't need to understand Gradle to just add compileOnly("...") to my build script

pliant canopy
pliant canopy
hearty briar
#

that is not necessary to get your plugin going, it is just a nice to have

pliant canopy
#

I am also planning to include the run-paper plugin as a clickable button as that's kinda nice

#

So what? Are we not allowed to include nice to haves for people wanting to start plugin dev?

#

I don't see how having a QoL step will hurt anyone

hearty briar
#

the point is that they have to understand that, and they don't

pliant canopy
#

You just said it is easy to understand

hearty briar
#

???, I said they need to understand it on a basic level, at least to the point they can understand where to place the compileOnly

#

if they can't understand that, then they'll be severly lost when doing anything else

pliant canopy
#

I am completely lost in what your point even is

#

What are you trying to prove

pliant canopy
#

Again, Gradle != Java

hearty briar
#

and again, it doesn't matter

hearty briar
#

they don't need to know how to make gradle plugins to understand how to add a dependency to the dependencies block

vocal halo
#

99% of gradle features you dont need for basic plugins

pliant canopy
#

Why exactly does it matter then? Again, is there anything actively bad about us recommending to use the mcdev wizard for project setup?

hearty briar
#

Alright, I'll be abundantly clear so as to not cause more confusion. As mentioned above, I don't think it is bad to recommend the mcdev plugin, the plugin itself is fine regardless of the templates being "outdated", but I think it is redundant if not counter-productive to the people reading the project setup documentation to tell them how to setup the project manually, then go on to tell them how to do the same thing but with an IntelliJ addon. If they understand how to install the plugin, I don't believe they need help to know how to use the wizard, and if they do that'd be up to MCDev's documentation and not Paper's. The only reason I see it as counter productive is because people often follow guides on a step-by-step basis, and I've helped people who have followed that guide setup a project twice just because the project setup guide explains how to do the same thing twice

#

the recommendation to the plugin could just be a note on the top of that guide, but the way it is now feels redundant if not hard to understand

vocal halo
#

i dont see it

hearty briar
#

well, you don't have to agree with me, that's just the way I see it

vocal halo
#

if it says

Alternatively, you can...
how is that confusing or hard to understand?

#

And if people cant read docs that not papers fault

neon atlas
#

I am semi certain most positions in this have been stated 😅

hearty briar
#

I am not going to argue this point any more than I have, so yeah ^

spice temple
#

I just wanted to complain about fill-ui looking awful but that was just dark reader, wtf

vocal halo
#

I think it looks a bit weird. But I can’t tell why.

lean venture
pliant canopy
brazen moon
random pollen
#

if you want to see it look bad then check out the loading animations on iOS

pliant canopy
random pollen
#

~~not sure why it's showing the AT diff though omegaroll~~fixed

steady fulcrum
scenic gull
#

Related, the graphql playground's starting example doesn't work.

steady fulcrum
#

I blame riley

#

Lemme figure out where that even exists lol

fair river
#

CC: @pliant canopy as riley is currently busy. yes

pliant canopy
#

hi idk graphql

#

lgtm

#

@steady fulcrum mergable?

steady fulcrum
#

ya

pliant canopy
#

Great, all I needed to hear

steady fulcrum
#

it's just the new pagination stuff and a more robust shell script

#

pagination is just the standard graphql shiz

drowsy zinc
#

is the sort needed

steady fulcrum
#

yeah probably

#

no it's not

#

it was when I was doing query dumbly

drowsy zinc
#

very cringe

#

org banned

#

❤️

steady fulcrum
#

you can thank gemini 3 for that

neon epoch
#

Thought we were being replaced

#

I guess Scorps job is safe

drowsy zinc
#

oops accidentally pushed a local branch

pliant canopy
#

lol

steady fulcrum
#

smh scorp

subtle cloak
#

Hello

ocean void
subtle cloak
#

I need paper file 1.20.4

outer elkBOT
river geyser
#

is there reason downloading the .bat n running it in a file w server.jar it says 'java is not a internal or external command'

#

(on windows 11)

#

it worked on windows 10

scenic gull
#

This is the channel for discussing our documentation and website. Follow these directions and if you need more help, visit #paper-help

outer elkBOT
river geyser
#

oh am I an idiot and forgot to install java on new pc 🤦‍♂️

spice temple
hard quartz
#

the cache is not a cloudflare thing?

spice temple
#

thats ontop

sharp pivot
brazen moon
#

that restart command was more a spigot command (might need a new section) but looking at it there's several missing command permissions here such as:
/spigot reload (spigot)
/mspt (paper)
/tps (spigot)

pliant canopy
#

Docs channel got demoted below build-tooling-help :(
-# (I noticed earlier, but only now thought of something funny to write)

fair river
#

I actually don’t know if it’s intentional

#

Or some core team just fat fingered

pliant canopy
#

@ cat stop fat fingering

#

It certainly messed up my workflow

#

This caused my plugin to not compile

#

Because it depends on the position of the docs-website channel in my channel list for sha generation

ocean void
#

I mean build-tooling-help is probably more active / needs more prominence for help topics.

#

But yeah I'm guessing it was an accident.

fallow hedge
#

another famous cat drag and drop

pliant canopy
fallow hedge
#

or mbax and his “occasional hand tremor thing” PES3_Sus

scenic gull
scenic gull
fallow hedge
last bear
#

plugin messaging could use a section on how those custom payloads work outside of bungee stuff

#

that a modded client or whatever puts what it wants to receive into a minecraft:register custom payload, and only then can you send on that channel via player.sendPluginMessage

nimble marlin
drowsy zinc
#

it's been happening on and off on the ci for a while and I haven't gotten to looking into it

#

I re-ran the job and it should be fine I think

opal flare
#

I blame @scenic gull

#

he infected github actions with kittens

#

and they are eating the pages

#

what do you have to say for yourself @scenic gull!

scenic gull
#

._.

nimble marlin
#

can you infect my house with kittens instead?

scenic gull
nimble marlin
#

:(

pliant canopy
#

I blame scorp

#

No other possibility

#

He's the astro guy

#

The frontend dev of us

#

The typescript enjoyer

drowsy zinc
#

5 ignored messages

jagged pecan
drowsy zinc
sharp pivot
#

my bad, didn't think anyone else ran into it yet

drowsy zinc
#

I could merge it if you think it's good

#

I don't know maven so I left it for comments

sharp pivot
#

already approved but, maybe having separate tabs for maven 3 and 4 would be good

#

i could see someone not reading and copying the whole thing into their pom.xml

drowsy zinc
#

will do

lapis gust
#

dont be stupid like this guy

mental sleetBOT
sacred musk
scenic gull
sacred musk
#

It was an accident i think

pliant trail
#

hello

vocal halo
vocal halo
#

Yes

hard quartz
#

that can be another PR if wanna rephrase that

limpid oriole
#

How do you change the version of the Minecraft server? I wanted to set it to 1.21.1

limpid oriole
#

thanks friend

vocal halo
#

i just tried to access adventure JD and as usual went to jd.papermc.io but couldnt find it there. Did you already discuss/think about adding it? Is there any reason to not add it, now that is is part of papermc?

drowsy zinc
#

it's probably on the bottom of someone's todo list, given the various random changes that would be necessary post-migration and the fact that it works fine

eager plover
#

adventures JDs are a lot more split out vs the primary platforms we have, I think it's sorta on the todo list but not a high priority and we'd need to figure out how to deal with 20 dozen artifacts

timid cedar
#

we could just add a button that links to jd.advntr.dev

vocal halo
#

that's what i meant ^^

hard quartz
vocal halo
#

i decided to ask here first to find out if this has already been discussed. I didn't want to open an unnecessary issue

supple burrow
#

dude Strokkur24 was just acting like an ass wipe in my pr rn to me

#

bro didn't even bother to check

#

closed it and thats it

neon atlas
#

strokk is sometimes stupid

#

and cannot read two lines above

#

where LiteCommands is also in that table

supple burrow
#

yep

#

bro should at least bother to ask

#

if too lazy to check

#

am i supposed to open it again?

neon atlas
#

Yea please do 👍

supple burrow
#

oh i have to make it again

#

i can't reopen

sharp pivot
#

pressed the button for you

supple burrow
#

🙏

#

is there ANYBODY other than Strokk that reviews docs? 😭

pliant canopy
#

Look, I made a mistake, no need to be personal about it

supple burrow
#

thats not it

pliant canopy
#

I didn't notice the exact section you PRed it to

supple burrow
#

i sent this on 2 lines

#

he said you cant read 2 lines

#

ok jokes are done now

#

🤝

#

im sorry for calling you an asswipe tho, you seem cool

#

today was not my best day is all

#

mb

pliant canopy
#

Yeah, it apparently wasn't my best day either

#

Glad we got it figured out, and sorry for closing your PR

supple burrow
#

its okay, it happens ig

#

it it normal for checks to be cancelled?

pliant canopy
#

GitHub actions seems to be down

#

The main branch is also not having any luck atm

supple burrow
#

@_@

vocal halo
#

For transparency you should really provide a reason why you don’t accept their PR

#

Since there seems to be another command framework present there as well

ocean void
vocal halo
#

I know, but I would like to know why

#

It seems pretty unfair

opal flare
vocal halo
#

Okay I see thanks for clarification

mighty dirge
pliant canopy
#

I think that page could use some general love with an example or two anyways

mighty dirge
brazen moon
#

that's kinda what the registries and datapack discovery page are for but not sure if they are linked?

pliant canopy
#

They aren't really linked directly

#

I think it needs a cleanup anyways

#

Also need to add in the tag flattening things

scenic gull
#

Just popping in to note --add-plugin-dir seems missing from live docs 🙂

neon atlas
#

I don't think we have any docs on the jar args actually?

fair river
neon atlas
#

That's system properties

brazen moon
whole oar
#

my docs where is code

south thunder
#

?

whole oar
south thunder
#

You want #hangar-help instead, you should write your plugin description in Markdown

mighty dirge
#

Maybe note in the Velocity docs that the annotation processor only works for java and for kotlin you have to manually use the velocity-plugin.json or kapt

eager plover
#

falls into that "and what about scala?" territory; Annoyingly, for as niche as kotlin is in this community, it seems to pop up a lot, especially with fairly common traps and kotlins documentation last I rember wasn't the most amazing here

timid cedar
#

kotlin is not that niche considering how often i see people ask about kapt

#

not even in the same ocean as scala for plugins haha

eager plover
#

niche was maybe a bit harsh; it's used but I rarely see it here; we have 152 results for kapt

random pollen
#

I still don't understand why anyone would use the AP, it's more complicated and annoying to setup than just generating the file especially if you want to substitute any values from your build script

mighty dirge
#

yea I think we should prefer the ap in the docs if not deprecate it

random pollen
#

once someone does get the AP working, their next thought will be "ok now how do I insert the version number from my project" and with the AP the answer is you need to use source code templating or preprocessing

#

which is super over the top

eager plover
#

I mean, the AP does feel kinda cludgy, like it's often come up especially with stuff like maven no longer scanning for them anymore

nimble marlin
#

(also kapt sucks, if people actually want to care about the AP I had a PR adding KSP support a while back)

eager plover
#

honestly, it's more in a area where the json file is basically undocumented and the AP is the only documented way to do it

nimble marlin
#

probably better to document the json file at this point tbh

eager plover
#

Yea

random pollen
#

yeah I had to open the velocity src to figure it out when I implemented resource factory

timid cedar
#

i agree with documenting the json file

pliant canopy
#

That sounds sane

#

Perhaps we should also update... uh... the mcdev templates

#

@violet bough god damnit

#

Either someone gets to it relatively soon-ish, or I will fix it whenever I have my next docs writing spree and go through some of the issues

violet bough
pliant canopy
# violet bough fill me in on context I ain't readin up

The Velocity @Plugin annotation, which combined with the Velocity annotation processor used to generate the plugin sjon file (basically a bukkit plugin.yml, but it's a json file) should no longer be the main recommended way in the docs, and for that reason the mcdev template needs updating to instead generate a json file which should be edited manually. Basically this issue: minecraft-dev/templates#46

pliant canopy
#

@drowsy zinc opinion on removing the status: accepted label, as I don't have a feeling it does anything?

twilit fog
#

don't know if my opinion matters, but if you want to make a PR for an issue it's surely better to see maintainers agree with it

hearty briar
#

if a maintainer disagrees with whatever the issue poses then it'd just be closed, feels redundant

twilit fog
nimble marlin
#

you can...ask?

#

which is generally encouraged if you want to pr something

pliant canopy
#

Currently, all issues which are open would be accepted, at least to some extend. And if an issue is labelled in general, you can already treat it as accepted, as that is a sort of maintainer comment itself

#

I guess the one issue not accepted how it was posted was that mcdev plugin removal issue, but that was dealt with already (including a discussion in the comments)

#

And as abby said, if you are unsure, it takes about 10 seconds to open this channel, link the issue, and ask if you may open a PR for it

twilit fog
#

fair enough

mighty dirge
trail jasper
#

<@&748618676189528155>

mental sleetBOT
hard quartz
eager plover
#

part of the reason for moving stuff to the new URLs is because adding redirects in the new infra is a bit of a headache, especially if you're wanting them to be smart

#

I guess maybe with our cloudflare plan we can get away with it now

slate arrow
scenic gull
#

Yes, probably a good idea. Open an issue!

pliant canopy
#

Does this work in terms of rephrase (cc @scenic gull)

Up until 1.20.5, Paper retained full compatibility with all Spigot plugins. However, Spigot plugins made after that version may not fully work. Such plugins may often provide Paper-compatible builds. If they do not do that, you may need to look for an alternative.

spice temple
#

I would be more specific, as in, spigot plugins that use spigot api released after 1.20.5 will not work on paper

#

but additionally something like most plugins are written for paper? idk

pliant canopy
#

Up until 1.20.5, Paper retained full compatibility with all Spigot plugins. However, plugins using Spigot API added after 1.20.5 version will not work. Such plugins may often provide Paper-compatible builds. If they do not do that, you will need to look for alternatives.

twilit fog
#

Look for*

scenic gull
#

Probably a final remark that most plugins are built and tested against paper these days?

pliant canopy
#

Up until 1.20.5, Paper retained full compatibility with all Spigot plugins. However, plugins using Spigot API added after 1.20.5 version will not work. Such plugins may often provide Paper-compatible builds. If they do not do that, you will need to look for alternatives. However, nowadays most plugins are built and tested against Paper, so you typically will not encounter incompatible plugins.

#

Now it's lengthy

spice temple
#

people dont need to read it, its like a side note

pliant canopy
#

Please don't need to read it
Docs

scenic gull
#

Docs are for the second pass at learning 😂

vocal halo
#

maybe "many" and not "most"? or do we know that?

#

nvm just saw the commit

spice temple
#

I see it as a, hey, we told you to double check! When somebody complains about some plugin by some of the backwards thinking people that go out of their way to break paper compat

#

But since the fast majority of servers run paper derivstes, not spigot, any self respecting plugin dev tests on paper

pliant canopy
#

I mean yeah, if it took this long to even notice, this probably isn't too often looked at anyways

spice temple
#

Well, or it does it's job of not discouraging paper usage ^^

fair river
#

I think the paragraph should start by saying most modern and up-to-date plugins all already depend on Paper. I agree with mini that we should probsbly not even go into too much details about Spig*t

brazen moon
pliant canopy
#

Will look at it sometime

brazen moon
#

take your time but tbh this page feels clunky I think people would get the gist with a single example.

#

also I want to expose the tag argument at some point so that would duplicate everything

pliant canopy
#

Yeahh, it was fine when I initially wrote the docs, but I forgot that it'd need pretty constant maintanance

#

I will probably indeed simplify it to just one single example and simply list them in a table

#

Will do that on my 26.1 update branch, where I will update them to the registry entries exposed in 26.1 as well (idk if 26.1 adds anything, but might as well)

brazen moon
#

bunch of new sound variant registries iirc

pliant canopy
#

Does that add new registries though?

brazen moon
#

well like wolf currently

vocal halo
pliant canopy
#

What's the stance on having some very basic NMS description page, which gives a rough overview of, for example, bukkit <-> nms object conversion (cast+handle), maybe some help on how packets generally work, perhaps with reference to the multiversion paperweight example plugin, and just generally a guide what to watch out for? I know the whole NMS trickery is super unsupported and docs don't exist as concrete implementations are prone to breaking quickly, but some of the more stable internal things I believe could be useful; also in view of, for example, data components not representable in API or reusing internal logic not exposed

neon atlas
#

Not much of a fan on my end

trail jasper
# pliant canopy What's the stance on having some very basic NMS description page, which gives a ...

i never touch the docs for anything apart the configs anyway let alone do i contribute there so my opinion is probably not worth much
i think people who would profit from such docs the most are those who dont even know the api itself well enough to even consider diving down the internals rabbit hole – which means either they dont read much code and are in some kind of tutorial hell or they just started working with paper/minecraft and shouldnt touch nms until they actually know the code/api a bit
for the people who have a valid use case for using nms that probably would add much value since they most certainly already know how to work with it and how to accomplish certain things with nms

#

holy macaroni
sorry for the wall of text, didnt realize my two cents are that long

pliant canopy
trail jasper
#

i just have a lot of opinions on a lot of stuff
i cant even keep up documenting my own sht 😄

#

also you already covered everything anyone could ever dream of
so no idea what i would even document

mighty dirge
#

yea, thank you Strokkur

pliant canopy
#

Just check the issues tab, surely you would find something

scenic gull
#

I think anyone capable of working with NMS can, trivially, identify the things you're proposing documenting. If they cannot, they are not ready to poke the bear.

serene vault
fair river
#

It's time for Strokkur.dev blog

dreamy radish
#

add the kotlin version of the examples

pliant canopy
#

Paper does not use Kotlin anywhere in the codebase, and the API is also written purely for Java. Kotlin is not a directly supported language, so we probably won't add Kotlin examples anytime soon

dreamy radish
#

at least i tried

timid cedar
#

also not necessary bc you can just paste java code into IDEA and it'll auto convert it to kotlin code

supple comet
#

<@&748618676189528155>

drowsy zinc
#

going to pull the trigger on the dependency updates, if anything breaks I blame it on the lack of reviews 😛

pliant canopy
hoary oriole
#

when will they update for 26.1

outer elkBOT
twilit fog
#

as I expected it fails to build if the version header is set to 26.1 since it expects it to start with 1

twilit fog
#

omg I think I know what is going on, it parses it as a float

#

26.1

#

what in the YAML like bullshit is this

#
[InvalidContentEntryDataError] docs → paper/dev/particles data does not match collection schema.

  **: [
  {
    "expected": "string",
    "code": "invalid_type",
    "path": [
      "version"
    ],
    "message": "version: Expected type `\"string\"`, received `\"number\"`"
  }
]
#

ye error message seems to confirm that

drowsy zinc
#

the frontmatter is yaml yes

#

you have to put it in quotes

twilit fog
#

version: "26.1"
I guess this'll have to do

#

ye

#

YAML strikes again

timid cedar
#

it all looks fine to me

#

is the branch just out of date or smth?

#

yes it might be

pliant canopy
#

Re-running the job (which happened with your update) typically fixes it

timid cedar
#

fab

#

okay the pr is all good to go! everything is up to date and all good and happy

pliant canopy
#

@timid cedar wouldn't you perhaps also want to include the MiniMessage presets in there?

#

Could be a great chance to do so

timid cedar
#

yeah good shout

timid cedar
#

@pliant canopy was just thinking the docs update to 5.0.0 but that isn't released yet

#

do you wanna maybe hold off for now or should we update them to 5.0.0-SNAPSHOT or smth

pliant canopy
#

I'd just merge it once the first Adventure 5.0 release goes online

timid cedar
#

fab

drowsy zinc
pliant canopy
#

Everything I say is wrong

#

The universe is an egg

drowsy zinc
#

the d2 plugin uses d2 in wasm pulled in by a normal npm dependency now so the d2 binaries are no longer installed in the workflow

pliant canopy
#

Ah, did you do that with your dependency up PR?

drowsy zinc
#

yes

pliant canopy
#

Well, that's great

last solar
#

Theoretically I'm a Contributor cause I PRed and got merged

lilac edge
#

it's that easy thinksmart

vocal halo
#

Yup

#

But it’s on a case by case basis to get contributor role. I also contributed a few PRs and didn’t get the role 🤷🏼‍♂️

pliant canopy
#

I also never got the role, even after multiple Paper PRs

hearty briar
#

isn't that one just added for people who aren't in the team to speak in #paper-contrib

pliant canopy
#

Contributor role is for someone who has continuously contributed for a while now

pliant canopy
hearty briar
#

I see

smoky granite
#

I never got contributor role either >:(

pliant canopy
#

And he is not that great at it

pliant canopy
#

God our build times are abysmal

#

Almost all of that is just image preprocessing

#

Anyways, @mighty dirge, if you have time, I'd greatly appreciate if you'd check over #735 again. I did some changes based on your comment

#

If you sign off on it, I'd prolly merge it soon

mighty dirge
pliant canopy
#

I think it's fine as-is now. The duplicate entries across the MC dev plugin and the velocity plugin json reference is not really a problem imo. Also that MCdev creator thing will be outdated anyways once my Velocity template PR goes through, so that's something to fix for then I guess

#

@drowsy zinc if you'd like to give #735 one last look over, I'd appreciate it. Will merge it afterwards

#

scorp, do you think this looks fine or is that too much text?

pliant canopy
#

There's also ofc the alternative of just saying "the marked fields are required", idk which is better

twilit fog
#

perhaps make both and see which looks better?

#

not really a fan of the current setup, but if it looks better than the second, why not

random pollen
#

For whoever wants to update docs about world storage, the new procedure for going back to vanilla is to move these data files from <level-name (world default)>/dimensions/minecraft/overworld/data/minecraft to <level name>/data/minecraft

#
GameRuleMap.TYPE);
WeatherData.TYPE);
TimerQueue.TYPE);
WanderingTraderData.TYPE);```
#

and feel free to ping me with questions about it generally

pliant canopy
#

We can drop documentation about the pre-26.1 world migration, right?

#

What about migrating to Spigot? Is that something we should remove from the docs page as well?

scenic gull
#

Worth keeping up the older vanilla bit at least until we have 26 stable imo.

pliant canopy
#

Fair, will move them under a new header, similar to how userdev has the pre-mappings one

brazen moon
#

there's a new system property too

pliant canopy
#

Hell yeah

pliant canopy
#

Okay so I need a simple yes or no: remove the migration docs for Spigot, both from and to?

#

Well, I guess from Spigot might still be useful, but I have no idea how their world structure stuff works, it might be so widly different that migrating might just be impossible?

eager plover
#

We don't support migration from spigot

ocean void
#

^

#

So remove them.

eager plover
#

Like, and the versions we do support there are generally going to be older versions where we aligned so that's just akin to a paper upgrade as usual

ocean void
#

It may be worthwhile to make a note that specifically mentions that we don't support migrations from Spigot, especially after 26.1 due to the difference in world structure.

pliant canopy
#

Yeah, will do that

scenic gull
#

Could mention users would need to migrate from spigot to vanilla for it. So nobody misses out on being able to enjoy paper?

pliant canopy
#

That's a pretty good point, but does Spigot even offer any tutorials on that?

#

Or do we just say "figure it out on your own"?

scenic gull
#

I dunno. I hope they have info on it somewhere.

pliant canopy
scenic gull
#

Maybe it doesn't happen until you get one?

pliant canopy
#

Sure, but I am not gonna wait around until I get one

eager plover
#

often the case with world data, that stuff is lazily populated for many parts iirc

random pollen
#

did you stop the server yet

pliant canopy
#

I did

random pollen
#

did you login

pliant canopy
#

Nope

#

I don't have a 26.1 mc instance on me atm

#

Lemme do that rq

random pollen
#

I think it's needed for spawners to tick

#

after logging it it saved on shutdown

pliant canopy
#

Thank you jmp

pliant canopy
ocean void
pliant canopy
#

@drowsy zinc we really need to do something against these abysmal build times

#

I have no idea what to do, so I'll let you look into it MahiruHeart

pliant canopy
#

In case you just happen to know, if not, I'll look into it shortly

#

Alright @random pollen, I've updated the project setup page: https://papermc-update-26-1.papermc-docs.pages.dev/paper/dev/project-setup/. Done a bit more than just the versioning, also got rid of the groovy dsl because no one should use that + removed the mention of mappings, since it is not needed there. Anyways, mind checking over the dependency declaration stuff if that's all correct?

neon epoch
#

It’s like 4 minutes from cold

pliant canopy
#

Well, it's 4 minutes always

#

I get insane waiting for it

neon epoch
#

I will try and remember to take a look tomorrow cause I think it’s just image processing

pliant canopy
#

Yeah it is. Thank you

neon epoch
#

I think you can cache it

pliant canopy
#

We theoretically do

#

But I feel like scorp's D2 update might've caused it to be un-cached again

neon epoch
#

👀

#

That’s odd

timid mulch
#

As a note, the commits in the experimental tab lead to the Paper-Archive repo instead the Paper repo.

pliant canopy
#

What experimental tab?

timid mulch
#

*At the Downloads page

hearty briar
#

if it is an old enough build then that would make sense

pliant canopy
#

Oh yeah I see

#

@hard quartz do something about it, thx

#

I need to look through Paper source code in search of a newly added system propery sigh

neon epoch
#

Get AI to do it

hearty briar
pliant canopy
#

I genuinely don't even know where to start looking

#

If someone just knows, please tell me

eager plover
#

if !beginsWith 1; isBelow = false

#

make it somebody elses issue

eager plover
#

the logic is hardcoded for 1.x; needs to be updated to support 26.X

pliant canopy
#

Okay from my side I'd be done with updating the docs for 26.1. If people would be so kind as to look over that (dw I will rephrase that one thing, ocelot), I would greatly appreciate it

#

I might merge it somewhen tomorrow unless something else comes up

drowsy zinc
pliant canopy
#

Cool

#

That's what happens when I touch CI

#

Anyways, I am off to bed

neon epoch
#

ah thanks for looking at the cache scorp looks good, there are a fair few warnings with cached remote assets but they are just warnings and it looks to be handled gracefully so should be fine

drowsy zinc
#

fixed

spice temple
#

looks like astro 6 breaks bun?

spice temple
hard quartz
#

Any issue if use mojira.dev over the attlasian portal in the docs?
the bugs-legacy throw issues by expired SSL and link to comments works bad a few times.

spice temple
hard quartz
spice temple
#

Well, it breaks under node with pnpm too, see my PR

hard quartz
#

i see i try check things like this breaking change... but still cannot find what other thing is broken for even load dev in local...

#

also try set in adapter the new config for the old behaviour (v5) and just make the error change xd

#

@spice temple
sorry the ping.. i make "run" with errors but now the site has a preview xd

spice temple
#

Does it build? Lol

hard quartz
#

yep

hard quartz
# spice temple Does it build? Lol

i ask now the IA in astro Discord for fix the last error because terminal and player count use the env removed... the IDE warns but now "works"

spice temple
#

You can push to my branch, that seems like an improvement, lol

hard quartz
spice temple
#

Idk do you have push perms on that repo?

#

Else just another PR, ye

hard quartz
hard quartz
#

green and also happy to remember i "patch" in the work a prettier for avoid mess with break lines xd
(because most of the people use WSL for touch code.. i use windows and every time touch that project the prettier change all)

spice temple
#

You just need to disable core.autocrlf in git

#

Fuck that setting

#

Always input, always lf

hard quartz
random pollen
spice temple
#

If you change that setting you need to reclone

#

Or renormalize I guess, not sure if that's enough

hard quartz
#

working 😄 (i take that for reference in the work xd)
thanks

#

now only need wait for merge and known if cloudflare not fails in deploy a preview

viscid thistle
#

Oooo Astro 6 update. Nice work.

random pollen
#

why are we switching package manager though

viscid thistle
#

That's a good question.

pliant canopy
#

From what to what?

#

Hasn't the website been bun before as well?

hard quartz
pliant canopy
#

Ohh

#

Rip

hard quartz
#

Astro also mention bun but its like "if you found issues go to bun repo and report" also a similar report in astro end with.

random pollen
#

bun runtime is different from bun package manager

#

in prod it uses the workers runtime anyways

#

so idk why we would need to switch package manager, just don't pass --bun or set bun runtime in the bunfig.toml

hard quartz
#

not sure why in the start the --bun was added.. how all start with the "bun and astro v6 mess with the web" i try first change from bun and later try to read the whole changelog for cloudflare workers

#

and how docs already use that

steady fulcrum
#

forwarding it here so it doesn't get lost

eager plover
#

already known

steady fulcrum
deft verge
#

Ohh..

hard quartz
eager plover
#

I mean, idk who on docs team usually merges stuff, can hit the button if nobody else minds

steady fulcrum
#

oh the old way we did that check is cursed OMEGALUL

hard quartz
steady fulcrum
#

This is website yea

pliant canopy
#

Last time I merged something on the website, lynx hit me with the eyes_roll emoji

steady fulcrum
#

fwiw doc's changes are trivial and really can't break anything lol

pliant canopy
#

I was just about to merge it

#

Thanks cat

steady fulcrum
pliant canopy
#

I was already hovering over the green button

eager plover
#

Yea, I thought it was on the docs thing 😄

pliant canopy
#

cat, did you just do a merge commit

eager plover
#

I hit the green button in my face

#

annoying

pliant canopy
#

Lynx is gonna hunt you

eager plover
#

bleh, can't force push it out either

pliant canopy
#

Yeah, that's stuck there now

hard quartz
#

ConterJuguito thanks for the merge

steady fulcrum
pliant canopy
#

True

#

riley slacking

hard quartz
#

xd
apply for web maintainer

pliant canopy
#

I mean, I have the same perms on website as on docs to my knowledge

#

I've just learned to not merge on website

hard quartz
#

i only in docs but i avoid touch that only for make PR

pliant canopy
#

very good

steady fulcrum
#

Is lynx a squasher?

pliant canopy
#

We're all squashers

steady fulcrum
#

very based

hard quartz
#

but in website can be good for merge this and check if deploy a preview xd
that thing about cloudflare where PR created in forks are ignored for previews...

pliant canopy
#

Testing on prod

steady fulcrum
#

oh yeah forks can't deploy to preview PEPW

pliant canopy
#

Btw don't you have perms to open a branch on the main repo lol?

#

Why not do that

hard quartz
pliant canopy
#

Huh, the more you know

#

I know you have commit perms on there though

#

Did you ever try it out?

hard quartz
pliant canopy
#

Well rip

steady fulcrum
#

mfw I gotta taint my system with bun to do anything with website

pliant canopy
#

Well, you know what

#

Doc

#

If mini will be mad

#

It's your fault

#

The build failed

hard quartz
fair river
#

riley will show up beside your bed tonight and look at you angrily.

pliant canopy
#

Ofc it was squash

#

Gotta take revenge on cat not doing a squash

hard quartz
#

well maybe fails for the change of the package manager... need wait mini or any with access to cloudflare for the logs xd

pliant canopy
#

There's a very good chance that's true

steady fulcrum
#

It's the build that fails. Vite struggles to rollup some astro related stuff.

#

Good news is with a little tweaks it builds fine and works fine in wrangler LUL

pliant canopy
#

well, PR those tweaks

#

I am not afraid of lynx anymore

steady fulcrum
#

I need to make sure they're actually sound and not dumb

pliant canopy
#

He can eyes_roll me as much as he likes

neon atlas
pliant canopy
#

Aren't you like on vacation or something

neon atlas
#

Technically

steady fulcrum
#

Yeah

pliant canopy
#

It might just not work anyways

hard quartz
#

you change the packagemanager or just run dev?

steady fulcrum
#

You can npx wrangler dev to force wrangler to run

#

probably can bunx it too

hard quartz
#

well i feel fine if keep the same packagemanager than docs site...

pliant canopy
#

I've been wanting to replace docs with bun for a while now too, but if astro breaks anyways, what's the point

steady fulcrum
#

I'm pretty sure it's just broken from weird astro 5 -> 6 things

hard quartz
#

well i dont try what jmp says about change configs.. but if astro add warnings for bun...

steady fulcrum
#

bunx wrangler dev also worked fine

hard quartz
#

i dont like changes in web things every version has many breaking changes..

steady fulcrum
#

You'll have to build first or wrangler will probably bitch

hard quartz
#

well if wanna try move again to bun and make a PR can test if the mini PR finally deploy xd

pliant canopy
#

Go ahead

steady fulcrum
#

I'll make a quick PR to mini's branch

pliant canopy
#

Well, let's see

steady fulcrum
#

brother

#

it failed the lint

pliant canopy
#

Incredible

steady fulcrum
#

but not locally

#

wtf

pliant canopy
#

The build seems to be in progress though

#

Wtf it worked

steady fulcrum
#

it was just a type error

#

so it'll compile fine

pliant canopy
#

Okay that's great

#

Lemme quickly fix the lint issues

#

So are we using bun or pnpm now?

steady fulcrum
#

bun just calls pnpm

pliant canopy
#

So should I use the bun or the pnpm command?

steady fulcrum
#

I've been using bun

#

but the readme says pnpm

pliant canopy
#

I'll probably go with pnpm

steady fulcrum
#

so probably follow that

hard quartz
#

so context has a env... i was sure was removed

steady fulcrum
#

The type errors are probably a bad import from workers or something

pliant canopy
#

So, the thing does not build for me

#

Oh wait

#

I didn't pnpm i

#

Oh yeah interesting, some runtime missing

steady fulcrum
#

I think it's a bad import on my end

pliant canopy
#

Lemme work my magic on this

#

Hm, now that's interesting

steady fulcrum
#

okay weird the way mini did KV access originally is correct

pliant canopy
#

Just gotta declare it in env.d.ts

steady fulcrum
#

why did it not build then

junior galleon
#

because u didnt do it correctly

pliant canopy
#

Well, env is still missing

#

Fixed it 👍

scenic gull
#

@junior galleon let's stick to helpful remarks, thanks

steady fulcrum
#

Unsure why it didn't

pliant canopy
#

I mean, the thing I did there should hopefully be fine now, we'll see what cf says about it though

steady fulcrum
#

It'll be fine, it was solely a type error failing

pliant canopy
#

Yeah

#

Also why is the build cache just straight up disabled

steady fulcrum
#

That whole check workflow is kinda flawed

#

It just runs a lint and type check, doesn't even build LUL

pliant canopy
#

Only run on PRs if the source branch is on someone else's repo
What does that mean

#

So we just don't get linting if it's the same repo?

#

Lol

steady fulcrum
#

yes for some reason

pliant canopy
#

Let's maybe not do that, that smells like bad design

steady fulcrum
#

Oh apparently we do cache, just kinda not really

pliant canopy
#

Well, we don't cache sharp

steady fulcrum
#

So that cache toggle is for images

#

Yeah

pliant canopy
#

Which feels kinda important I feel like

steady fulcrum
#

It would be if the action ran a build

#

But since it doesn't it doesn't really do anything OMEGALUL

pliant canopy
#

So what's the point of that then

steady fulcrum
#

It should probably also pnpm run build in a 2nd job after the lint and checks pass.

#

Then it'd be a full workflow for testing

pliant canopy
#

Hm, I would almost put that in a separate workflow

#

linting and building are two things

steady fulcrum
#

Can you cross workflow depends Hmm

pliant canopy
#

I believe so, yes

#

But we can run build and check separately

steady fulcrum
#

I mostly meant it so you could not build unless the tests pass since there's no point in building what is bad to begin with

pliant canopy
#

I am not sure, that'd probably be a CF configuration then

#

I don't have access to that

steady fulcrum
#

I can PR it LUL

pliant canopy
#

Hm?

#

The previews are done by CF, not by a workflow

steady fulcrum
#

Yes but you can still build

pliant canopy
#

Yes I can

#

And I intend to do that

#

But I cannot make it so that the preview doesn't happen if the build fails

steady fulcrum
#

this is why you put the deploy in as a workflow too ez

pliant canopy
#

I believe we do that in the docs

#

Eh, this is something that needn't be part of the astro 6 branch

random pollen
#

still don't get why we're changing package managers

pliant canopy
#

No idea either

#

I thought bun worked fine

random pollen
#

it does, it was wrongly switched due to confusion of bun runtime vs bun package manager

pliant canopy
#

I remember that convo. However, do local dev previews work with bun?

#

Because I kinda feel like that was one problem with astro 6 and bun

hard quartz
#

when take the mini branch no

random pollen
#

you just need to remove this if bun runtime doesn't work anymore in v6

pliant canopy
#

Hm, lemme test this

#

Oh yeah

#

Nice

#

Okay lemme undo the bun->pnpm move

#

Oh woops, needs node anyways

#

Since it's not using the bun runtime

#

Okay there we go, that should do it

hard quartz
#

if Ci use node 24 then the package.json can declare min 24 too?

pliant canopy
#

Yeah

#

Lol bun run build froze at prerendering paper-1-19 news

hard quartz
#

xd

pliant canopy
#

Okay fixed itself after a restart

hard quartz
#

i hope can have write acces...
but you can change also the packageManager in package.json and the runtime in devEngines?

pliant canopy
#

Right

#

devEngine I already did

#

(Locally)

#

need packagemanager

#

Bun is not technically accepted into the packageManager field

#

So I guess just remove that field

hard quartz
#

and now why Cloudflare is angry again ._.

pliant canopy
#

I am guessing node version

#

Yep

#

Well whatever

#

@spice temple we did some changes to your PR. It's back to bun as the package manager, just using node as the runtime, and everything compiles now correctly

hard quartz
#

the only change can be if wanna touch the worker for make run in node 24
not sure if worker allow define in a file like pages

pliant canopy
#

Honestly, doesn't look like it

hard quartz
pliant canopy
#

At least I canoot find the setting for it on my site

#

Okay cool

#

But like where?

hard quartz
#

in General

steady fulcrum
pliant canopy
#

Yes

#

At least to my knowledge

spice temple
#

That's not enough certainty for me to merge it on my phone kekwhyper

pliant canopy
#

Clicking through the preview site looks fine

steady fulcrum
#

it looks and works fine from my brief testing

spice temple
#

Am still stuck at my parents but I wanna boot my PC once I am at home anyways, gotta do some accounting, woo

pliant canopy
#

Take your time, not like merging this is critical

steady fulcrum
#

it is

#

I will die without it

pliant canopy
#

Oh okay

#

Let's wait for a few months then

hard quartz
#

is, give perms and i merge and also close the renovate PR xd

pliant canopy
#

I mean I can merge it too, no problem

#

We are not exactly short of mergers

#

But I think mini should at least look over it once

eager parcel
#

Are the 26.1.1 javadocs broken for anyone else? My browser doesn't want to connect

random pollen
#

yes its not working yet

eager parcel
#

Oh alright. The link to the javadocs was already updated to 26.1.1, so I expected it to work

spice temple
#

thats done automatically

spice temple
viscid thistle
#

Great work all!

frail valley
#

https://docs.papermc.io/paper/dev/project-setup/#the-main-class

The main class
The way this section is worded ever so slightly implies that you should have a class named main, even though the example shows a different entry class name.

Since naming a class "main" is usually considered bad practice in bukkit-derivative development, is this something which should be edited? If so, I'm willing to make a PR.

serene vault
#

the entry in plugin.yml is called main:, so I think that naming is generally fine. But maybe sentence about not naming it literally Main could be added there

frail valley
#

Yeah I was more talking about editing the section, not changing the title

neon epoch
#

Is this just because it’s not actually the entrypoint for the program & also could be class path clashes if every plugin has a Main.java?

spice temple
#

it makes reading code and strack traces/logs a bit meh

#

no technical reason

pliant canopy
#

I mean, if others add your plugin as a dependency, CryptoScamPlugin is much more descriptive than Main

#

I see it more as a "Class names should be somewhat descriptive"

spice temple
#

that was the "reading code" part 😛

pliant canopy
#

I'll let that one slide

hard quartz
#

Design is my passion xd
i try the guide for tags in content... not like the design but the logic for take tags from news and make lists or show posts with that works xd

thorn brook
sharp pivot
#

cloudflare caches a bad response sometimes

thorn brook
#

ah

#

yea it cached a 304 not modified, it works now

hard quartz
viscid thistle
#

Pulled the latest updates locally and I'm realizing that the image optimization isn't actually working. While it creates multiple copies of the image for different device sizes, they are all the same size as the original. Our dist folder is over 250MB because of this 😛

pliant canopy
viscid thistle
#

Been trying to debug it, but I can't really figure out why.

#

Opening a PR with a temp fix. I'll make sure to note it.

#

Oh jk. It doesn't actually apply the fix in the CI for workers, only locally.

hard quartz
viscid thistle
#

I confirmed what I was going to PR does apply the image optimizations locally, but when done in the worker CI environment, it doesn't apply it. I think we might just have to wait for fixes.

hard quartz
viscid thistle
#

I can if you'd like. It'll probably be merged in with @astrojs/cloudflare@13.1.9 / 13.2.0 and it'll auto pick up when we update dependencies and fix itself 🙂

viscid thistle
#

Alright, opened an issue for tracking.

hard quartz
#

added reference, thanks Github for allow that 🙂

viscid thistle
#

Didn't know that was a thing. Cool.

hard quartz
#

yeah very useful for that things

spice temple
#

At work I would take this chance to write unit tests for bundle size and image size, do we care about that here too?

#

Maybe just one script that checks the size of the dist folder as a safeguard is enough

hard quartz
#

Why not jeb_curious