fuck off
#docs-website
spice temple
still apex
so on the top one
dropdownArrow?.addEventListener("click", () => {
dropdownContent?.classList.toggle("hidden");
dropdownContent?.classList.toggle("block");
console.log("Line 107")
});
``` always gets calledbut the other ones only call
document.addEventListener("click", (event) => {
if (dropdownContent && !dropdownContent.contains(event.target as Node) && !dropdownArrow?.contains(event.target as Node)) {
dropdownContent.classList.add("hidden");
console.log("Line 113")
dropdownContent.classList.remove("block");
}
});
is it really a good call to do everything in vanilla js?
still apex
¯_(ツ)_/¯
eager plover
I mean, it looks like you have to do vanilla js for astro?
spice temple
no
eager plover
hm?
eager plover
Well, any recs? as astro's docs are just like "scripts and event handling? oh, script tags!"
spice temple
it uses an island architecture, you can have interactive islands that use whatever lib you want
i.e. we could use something small like solid
its like 4kb gzipped iirc
spice temple
neither have I, just mentioned it because its small, svelte is sub 10kb too iirc
maybe this is an excuse for me to finally try qwik
been meaning to do that ever since I drank a beer with the creator at devoxx couple years ago, lmao
he randomly mentioned he created angular, that was fun
oh they released 2.0 today
like this looks super simple https://github.com/QwikDev/astro
eager plover
Yea, for what we're doing there that looks pretty simple
still apex
Could that also be used for the build explorer page then?
eager plover
Yes
spice temple
why are the astro error messages so bad
idk this seems a mess
revert
we can just write vanillajs that isnt stupid
eager plover
Well, the issue there is that we're using ids, and getElementById will just fetch the first one
spice temple
i.e. using IDs is stupid
eager plover
The quick ez fix would be to just have some form of generated id
still apex
https://i.imgur.com/GeLdWJi.png works a little, the "copied" from the sha only appears on the top one thanks to copilot
spice temple
let me do it
holy hell I make the dumbest copy paste errors
oh just saw you have similar code to me with the nextElementSibling
meh my animation doesnt work
SoftwareDownloadButton.astro:131
Uncaught TypeError: console.log is not a function
wat
eager plover
lol
I tried to svelte and it just blew up in my face
and then complained about react jsx missing
still apex
can only use console.log in the script section i believe
spice temple
no webstorm imported console from node
eager plover
I ponder if react really would be so bad
spice temple
yes
eager plover
psh
spice temple
I wonder if astro is the best choice for what we are doing
eager plover
I mean, that's what I was starting to question
Well, given that 90% of our site is static, it would work; but, we really need a component framework of some form
spice temple
like, when we start pulling in react or any framework, then those components cant import astro stuff
so we would move more and more stuff away from astro anyways
eager plover
can't you at least pass in props into them?
Well, yea
or, well, idk how it handles that
neon atlas
-# || would have been done eons ago with just html and two .js files, change my mind ||
spice temple
we had that before
eager plover
Well, yea, I mean, you can do that
neon atlas
I can't xD
spice temple
and I mean, astro is basically that
eager plover
It's the longevity of maintaining it which is the headache when you do that
spice temple
its a templating engine with now frontend logic part
neon atlas
ah
eager plover
Well, yea, "templating engine" is great if we were just templating
interactivety, at least for certain parts, is bleh
still apex
Couldn't you just have done this? https://pastes.dev/Ki4YDkoz2J
eager plover
I mean, that is basically what he did?
still apex
with a bunch of more code ig
spice temple
wanted to have accessibility
eager plover
doing this with JS is generally kinda bleh anyways, no matter what the way you navigate stuff is less than ideal
still apex
so my pr can probably be closed then..?
supple comet
scenic gull
got it
viscid thistle
@spice temple @still apex I'm fine with adding in some SolidJS, we just didn't need NextJS.
If it makes it easier to have some components in Solid, I'm all for it.
It's still going to be eons more optimized than how NextJS was performing.
spice temple
I tried adding qwik to the component but then I saw it uses some other component and stuff would basically cascade
spice temple
Software download button
It uses skeleton
Or something
Idk something was using skeleton that I wanted to turn into a qwik component
viscid thistle
Skeleton is literally just <div class={clsx("rounded-md bg-gray-400/40 animate-pulse h-6 w-auto", className)}></div>
So you can just push that into qwik
still apex
so my pr can probably be closed then..?
.
viscid thistle
Probably
viscid thistle
Idk something was using skeleton that I wanted to turn into a qwik component
If you have a base setup with qwik integrated, can you push that to another branch and draft PR it to the astro branch? I'll pull and play with it.
Or if it's not worth those changes, I can just look at adding in solid myself?
spice temple
I reverted it
Prolly still in my local history somewhere, but I am in bed
Stuff was strange anyways, svelte or solid are prolly better choices
Just was interested because of the no hydration part
eager plover
I had a look at svelte and it blew up because jsx
viscid thistle
Oh?
eager plover
I might just need to mess around with some settings or something
viscid thistle
Do you care if I give solid a shot?
eager plover
I mean, I don't mind whatever is used
I'm not really somebody who looks after the site, so, doesn't entirely affect me 😄
spice temple
I would prefer to have something without jsx but I realize I am prolly a minority
viscid thistle
What would that be, Svelte?
eager plover
Well, I added svelte and it blew up about some react-jsx-somethingorother not being there
I might just need to mess with the config files
viscid thistle
Did you do pnpm astro add svelte?
eager plover
Yes
eager plover
I mean, I did abrupty try to change that entire download button into a functional return, so, I might have induced something through that
I did say that tonight I was going to not be on the PC as I just finished my bootcamp and am dead from the final week project
still apex
which page?
eager plover
the all downloads thingamabob
To be fair, as I said, I might have just screwed up converting the thing to a component
spice temple
What would that be, Svelte?
Not much experience with that but yeah, I prefer a traditional syntax like that to jsx
But don't value my opinion too highly
eager plover
svelte is also jsx?
okay, I have done something cursed, never mind me, I guess; I think I misread the docs
viscid thistle
Got Svelte working for the downloads page kinda.
spice temple
No, svelte is a traditional template engine
Like, it looks close to free marker
But it's really powerful and has some features I miss in Vue rn
(some of that was only added with svelte 5)
eager plover
I think I was being partially cursed because I made it a .svelte.ts file
viscid thistle
Ahh
spice temple
That is meant for util files I think
So you can use runes
They need compiler magic, so they aren't as flexible as vues reactive system
eager plover
god, this takes me back to php
viscid thistle
Okay I lied I don't have time to fiddle with it tonight
drowsy zinc
What would that be, Svelte?
+1 for svelte
still apex
no (just disagreeing with scarp)
drowsy zinc
eager plover
22:43:37 [ERROR] Cannot find module '@/utils/api.js' imported from '/Users/shane/work/paper/website/src/components/SoftwareDownloadButton.svelte'
Stack trace:
at nodeImport (file:///Users/shane/work/paper/website/node_modules/.pnpm/vite@5.4.9_@types+node@22.7.7/node_modules/vite/dist/node/chunks/dep-Cyk9bIUq.js:53036:19)
at eval (/Users/shane/work/paper/website/src/components/SoftwareDownloadButton.svelte:4:37)
I have it on the page, but, I can't get the click button thing to work
eager plover
Okay, I have the click working
I have no idea why I spent so long working on this
vocal halo
why even a drop down? only for the hash copy?
eager plover
Well
We have things like waterfall which offers multiple assets
older versions of paper which has multiple assets
astra
vocal halo
oh true, I knew about the paper things but i forgot its still relevant
eager plover
I'm going to crack open a can of lager and plant my ass on the couch
still apex
There's a pr that supposedly has a workaround but either i'm doing something wrong since I have no idea how to 'publish' it locally or i'ts not working
viscid thistle
Just lmk how I can be of help. It's looking good so far Cat.
languid prawn
yeah fr
viscid thistle
So it looks like Purpur went that route that I had kind of talked about. They have a URL parameter for each version to pull all the builds.
neon epoch
Docusaurus 3.6 has released with 3x quicker site builds. I have a couple job interviews this week but will look when I have a chance
fair river
Good luck on interview!! 
neon atlas
Good luck 
drowsy zinc
I'm skeptical that it'll be 3 times faster
still apex
Are you calling ollie a liar
viscid thistle
still apex
what was the reason for going with astro-icon?
eager plover
it's astro
I'd imagine that that was purely it
i.e. they flat converted from next and didn't consider we'd need to deal with interactivety there
drowsy zinc
middle approximate value
neon epoch
React native is 3.04
eager plover
Rspack
and some other faster tools in the pipeline too, so, doesn't sound unreasonable
viscid thistle
what was the reason for going with astro-icon?
Pretty much cat's response. I know there's the unplugin icon package. We could probably use that instead as long as it tree-shakes and allows local icons.
ocean void
@dense acorn Not sure what that was but it doesn't appear to be related to the documentation website.
dense acorn
Oops
neon epoch
olive oil 0n goes hard
last bear
I think google translate was still trying to translate the page after I came from another non-english gh page 
empty grove
Danish apparently
hearty musk
https://papermc.io
is this normal?
hearty musk
hold on let me make a video to show you cause its hard to explain
eager plover
your browser probably blocked the CSS or something stupid
hearty musk
css?
eager plover
yes, the styling info for the website
hearty musk
do you know any way on how to fix it?
eager plover
First step would generally be to check the dev tools and see if the request failed or something
I can't really advise there for random browsers
hearty musk
First step would generally be to check the dev tools and see if the request fail...
sorry im not really that good with these type of stuff can you give me step guide?
eager plover
No
spice temple
Try a private browser tab
eager plover
- it's not a trival thing to write a step by step for
- I have no idea what that browser is
- I'm far too full of covid to wanna deal with that
hearty musk
this?
eager plover
probably
hearty musk
let me try edge
spice temple
that looks like that stupid opera gaming browser with that sketchy marketing
hearty musk
that looks like that stupid opera gaming browser with that sketchy marketing
it is 😭
oh sorry ping
spice temple
but you want to open the network tab of the dev tools
hearty musk
on edge works but not Opera Gx
spice temple
reload and find the red request
hearty musk
and now randomly it starts to work, i did not even reloaded the page
spice temple
🤷♂️
hearty musk
Well i guess thank you for helping and sorry if i wasted your time
spice temple
np
still apex
vanilla or Vanilla what was it
drowsy zinc
the latter
still apex
i’ll ask the same question next time lynx does it wrong
eager plover
VaNIllA
viscid thistle
Interesting. The latest Astro beta does automatic responsive build-time images. Going to play with it.
viscid thistle
Hmm. On the latest beta, the teams page broke with __vite_ssr_import_4__.default.map is not a function. Idk what would've changed with importing that json data. I can confirm it loads, it just doesn't want to map it. No IDE errors other than the runtime.
hoary thistle
thought it was Allinav
Vanilla ice cream?
viscid thistle
Hmm. On the latest beta, the teams page broke with `__vite_ssr_import_4__.defaul...
I fixed this. It was a brief vite issue, just had to override the dependency until Astro bumps it again.
Pushed it to a separate branch for the time being - https://github.com/PaperMC/website/commit/879eb720bab3bf44b2c4ebc549b4c85fe7709fb9
mental sleetBOT
(6741ad936ed5010734cf19f8) // @crisp inlet (@lochefmassi / 241888213004713985) has been banned by @radiant summit (451779815415218177)
Reason: Quick-banned for sending a message in #docs-website
drifting slate
I believe I may have found a possible typo in the docs, but want to make sure I'm not wrong before PRing.
The Scheduler page for paper mentions ..., you can simply use the this.cancel() method: for Using BukkitRunnable, but the example has task.cancel(); which by the looks of it wouldn't make sense...
So I assume this may be wrong?
Link to the section in question: https://docs.papermc.io/paper/dev/scheduler#using-bukkitrunnable
drowsy zinc
yeah that seems like a copy-paste error
drifting slate
Paper copy pasting?!
My world is in shambles. D:
sonic plaza
It's more related to the forum post: https://forums.papermc.io/threads/paper-velocity-1-20-6.1152/
The links is redirecting to "https://docs.papermc.io/paper/dev/commands-api/commands" instead of "https://docs.papermc.io/paper/dev/command-api/commands" which results in "Page Not Found"
drowsy zinc
should be fixed once the CI goes through, thank you for reporting that
heady bronze
The Javadocs page for Velocity at https://papermc.io/javadocs is still linking to Velocity 3.0/3.3 (https://jd.papermc.io/velocity/3.0.0/) and gives you the warning that it's outdated and to go to Velocity 3.4.0 Javadocs
Also should the Waterfall docs indicate the EOL status like the downloads page does?
spice temple
We are aware of that
Fixing that is slightly annoying
And the website is currently being rewritten in another framework, so idk if anyone cares enough to fix it in the old stuff
I personally am fine with how it is since the javadocs page has that banner now, but I can see that it can also be annoying
heady bronze
If it's in the middle of being redone anyway it's not a big enough deal to bother with, it's one more click to get to the 3.4 docs
spice temple
I think the banner could be made a bit nicer
I always miss click, lol
(and I was the idiot who wrote the banner...)
pliant canopy
I always miss click, lol
same 😭
eager plover
I always miss click, lol
was actually going to ask, can you make the whole banner, or, maybe even just the whole text, clickable
spice temple
this was nicer than I remember
yes that should be easily possible, I am about to run tho
found 5 minutes
good enough?
eager plover
was literally just clicking fork, but, yea
spice temple
am sorry 😄
eager plover
my eye is irritating me af anyways, so, doing me a favor;
spice temple
still apex
tests
spice temple
didnt actually see that they failed, lol
fixed now
@opal flare when you have a minute please take a look at https://github.com/seiama/javaducks/pull/24, makes the banner less confusing
still apex
@drowsy zinc how do you link https://jd.papermc.io/velocity/3.4.0/com/velocitypowered/api/event/Subscribe.html#priority() the #priority() part in the javadoc component thing
drowsy zinc
exactly the same
still apex
nah i mean like https://i.imgur.com/2Mr747L.png
can't be bothered to open up ij to test
drowsy zinc
yes
opal flare
<@105923848263753728> when you have a minute please take a look at https://githu...
done
minor bone
Best version for paper?
1.20.1 or 1.20.4 or 1.21.1???
ocean void
Best version for paper?
1.20.1 or 1.20.4 or 1.21.1???
You want #paper-help
winged summit
Can someone tell me which theme is used to highlight code on the paper docs website?
drowsy zinc
vscode light & dark
left egret
annoying bukkit components, is it possible to hide them?
radiant summit
annoying bukkit components, is it possible to hide them?
In the Javadoc? No?
echo canyon
I mean it's possible to hide them from the javadocs, but it'd be for everyone. You can use an @hidden tag in the javadoc itself, but idk if we want to do that since they aren't deprecated
winged summit
vscode light & dark
Thank you. 🙂
last bear
Some help on how to migrate to gradle might be helpful for those that need paperweight and are still on maven
like a simple example and links to gradle/other docs and the auto migration command (though gradle docs specifically can be really overwhelming, I honestly don't like using them)
neon epoch
I thought we pointed to that somewhere
drowsy zinc
I've got a free weekend so I could do it later if necessary
last bear
There's a link in the project setup, but its own page with some more details/handholding would be good, I sure know I would need it 
serene vault
maybe also mention how to get IJ to recognize it as a gradle project afterwards too, I found that the hardest part in my experience 
vocal halo
Lmao
fair river
LOVE SCORP
still apex
who
scenic gull
"What to do when the auto migration fails" would be helpful. Such as maven shade to gradleup shadow.
I think that's the most likely issue people would run into
small harbor
fabric's documentation pages have this in the sidebar
perhaps we could do something similar?
small harbor
fabric's documentation pages have this in the sidebar
eager plover
reminds me of the NHS website where they have like a "last checked" thing
pliant canopy
We kinda already have that?
small harbor
We kinda already have that?
not really the same
take e.g. https://docs.papermc.io/paper/dev/pdc a example
this page was maybe written in 1.18 and hasn't updated in 1.21
pliant canopy
I don't think a lot has changes with pdcs
small harbor
it's a random example
eager plover
Sometimes, api doesn't change and doesn't need much other than a glance over
small harbor
the point being is that it'd a be good indicator of when the document has been written
as maybe a page shows outdated info by accident
eager plover
Like, I'd imagine that if somebody gave it a skim over for .21, they'd update the version?
small harbor
right
it's basically more of a user friendly indicator of when the page has last been updated
scenic gull
I'd worry that we'd get users complaining our docs are outdated for any stable API
small harbor
yeah that is a fair concern and is something i'm thinking of aswell
neon epoch
Would it be automatically updated or something we do manually
lilac edge
i'm all for manual - could just be a thing that's defined at the top of the file in the front matter
vocal halo
if its automatic we kina have something already:
but unfortunately this also updates when updating docusaurus for example
drowsy zinc
manual seems nice
I'd also be in favor of ditching the current versioning system, since it's just bad
people add new stuff to some pages that also applies to older versions, so you have people looking at the older versions' pages and they don't see the possibly helpful additions
eager plover
See, last edited only accounts for "last time the file was changed", as said, fixing a spelling issue or updating a link would mark the file as just changed
vocal halo
Yep
neon epoch
https://github.com/PaperMC/docs/pull/508 threw this together
neon epoch
No
still apex
bad
neon epoch
Add a comment on GH and I’ll do it another time
vocal halo
why arent we using the version badge?
anyways, i would make it more visible. I don't think the end of the page is the best spot for that.
neon epoch
why arent we using the version badge?
Version badge?
neon epoch
Hmm.
still apex
meh
neon epoch
I feel like this may be too strict for our usecase
vocal halo
evan did remove it because "its ugly"
still apex
i agree with evan
neon epoch
Yeah
vocal halo
i mean it doesnt have to be this exact thing
neon epoch
Yeah, could be designed like that tho
mental sleetBOT
(67613c756ed5010734cf1a44) // @flat moss (@osblaze / 237788729467600898) has been banned by @rugged bay (404882575543238656)
Reason: Quick-banned for sending a message in #docs-website
pliant canopy
I'd like to get some feedback on the overview for the build-in Brigadier argument types from Paper. If somebody could take a few looks and tell me things they notice that are negative, make sure to ping me:
https://strokkur424-improve-brigadie.papermc-docs.pages.dev/paper/dev/command-api/arguments/minecraft-arguments
vocal halo
I don't know about the "quick link" column
i definitely like the idea of having them but idk if a column is the best way to do it.
pliant canopy
i definitely like the idea of having them but idk if a column is the best way to...
Do you have an idea what it could be instead?
lilac edge
i think it's fine for now in the initial PR. if someone thinks of a better way to format it then it can be PR'd in the future
neon epoch
Amazing PR, great work and super well documented. The only thing I fear is that some of the explanations are quite wordy, and I know an ADHD brain like mine is gonna see some of these blocks of text and panic
vocal halo
yeah, its a great PR i was surprised how much it adds to the current version.
great job
jagged pecan
only suggestion is having return value linkified to javadocs too
oh also entity argument selectors are not just behind op, the permissions minecraft.command.selector works too
current seems undocumented on the permissions page tho
fair river
I think having guide like those are nice as hardfork is coming 
jagged pecan
remove older command api /s
maybe for https://strokkur424-improve-brigadie.papermc-docs.pages.dev/paper/dev/command-api/minecraft-arguments#adventure-key-argument
show the validation in the video?
so an invalid key could have 2 colons, or a "/" in the namespace or smth
(or uppercase characters literally anywhere iirc)
edit: nvm thats shown in the namespaced key video a couple more down.
fair river
Maybe a beginner guide to setup everything for someone who wanna make paper plugin? 
jagged pecan
also https://strokkur424-improve-brigadie.papermc-docs.pages.dev/paper/dev/command-api/minecraft-arguments#named-color-argument
breaks the pattern of all i have seen so far, of only having the single argument.
you could have a hardcoded message that gets coloured instead?
idk
eager plover
I think that streamlining the initial setup for the basic plugins would be good; paper plugin stuff would be really great too, but, I feel that there are still some sore points
Would be nice if we had a means of collating this kinda stuff; I say that as if I'm ever going to get around to working on documentation
fair river
yeah like a guide that someone new (but know Java) can follow and set up their intellj to start making Paper plugin 
jagged pecan
i mean currently, even with all the ide plugins etc, there is still a bit of friction, right?
eager plover
yea
eager plover
Somebody, please, courage to add kotlin build templates
fair river
my encouragement
eager plover
that's just good ol family entertainment
fair river
I think @pliant canopy is very good with those detailed stuff so he would be perfect to make the beginner's guide on how to set up ide for making Paper plugin 
eager plover
well, I have a whole bunch of VMs to migrate by EOD thursday, weekend, might be some recovering, but, I might be able to look over stuff, I'd probably just need a reminder
fair river
pliant canopy
I think <@813141164281692170> is very good with those detailed stuff so he would...
You know what, that sounds like a thing I would have done some time anyways. Maybe after this PR is done.
Thank you all for the kind feedback, it means alot to me
pliant canopy
I think <@813141164281692170> is very good with those detailed stuff so he would...
In fact, I was thinking of maybe adding a whole tutorial series right into the paper docs. Usually, the only resources you can learn plugin dev on are on random forum posts or 10 year old (still great) youtube videos. Having some readable, unified beginners tutorial might be extremly useful, also for the softspoon that is happening, as the API drifts further and further apart
vocal halo
yeah like a guide that someone new (but know Java) can follow and set up their i...
There is a guide already?
pliant canopy
There is a guide already?
It could be extended. It doesn't cover any of the IntelliJ stuff except for that one plugin
still apex
what intellij stuff
vocal halo
Yeah what IntelliJ stuff?
pliant canopy
what intellij stuff
Just a quick overview on the UI of IntelliJ, maybe a new page that deacribes the installation and setup of IJ for various platforms, maybe also mention Toolbox, mention the importance of keeping your IDE up to date, that sorta stuff
pliant canopy
Amazing PR, great work and super well documented. The only thing I fear is that ...
I've been thinking about that, and do you think it could help seperating these arguments into seperate pages? Like I'd have /commands/arguments/ and in there I'd put everything argument related
scenic gull
Does jetbrains academy not cover IDE basics?
pliant canopy
And then also have like entity arguments, registry arguments, etc
pliant canopy
Does jetbrains academy not cover IDE basics?
No idea, never looked at that tbh
still apex
we should refer to JB first if they have it
inland nova
This word is without the link 😮
https://strokkur424-improve-brigadie.papermc-docs.pages.dev/paper/dev/command-api/command-tree
pliant canopy
Well aware. I haven't setup links or JavaDocs yet
I am not entirely done with the structure of the pages, so setting up links would be pointless
It even says (WIP) next to it 
scenic gull
As resident party pooper and grumpy old man, my concern is that we get a lot of great contributions and then end up with a bunch of outdated material better updated by other resources online that have the person power
pliant canopy
Yeah very valid
We might link the JBA for learning about the IDE though
If we don't do that already
eager plover
Yea, JBA is to my understanding pretty darn good
They also have a YT channel which I've picked up some cool little tricks here and there over the years
(Like, I don't have editor tabs enabled in my IDE cos keyboard go brr)
mighty dirge
As resident party pooper and grumpy old man, my concern is that we get a lot of ...
speaking of outdated
would anyone update this to say 1.20.5-1.21.1
(don't want to make a pr for such a nitpick)
eager plover
if you can PR it I can just insta-merge it
jagged pecan
Time to let it sit for a couple of years
vocal halo
I don’t really understand why we need to explain the IDE in the first place. Earlier we said „people should assume how to code java“, for me that either includes IntelliJ knowledge or they use another IDE they are already familiar with.
Yes, Paper recommends IntelliJ but I don’t think this tutorial should give the impression that people have to switch to IntelliJ which imo will be implicitly said if we include a tutorial from JBA.
I also think the docs need improvements for Velocity before trying to „10 star“ the Paper section.
eager plover
Somebody got to it before me, I got distracted because cloudflare is refusing to cloudflare for me
I just wanna rewrite the velocity docs
their flow is just, inexistent
neon epoch
lol real
pliant canopy
I also think the docs need improvements for Velocity before trying to „10 star“ ...
Well, not me that's for sure. I suck at velocity. I will probably stay with the Paper section 
pliant canopy
Amazing PR, great work and super well documented. The only thing I fear is that ...
Based on the possibly problematic attention span issues, I have decided to split up the pages into seperate categories. For the arguments this means that they are grouped together in a slightly more logical manner. The Minecraft Arguments page now only serves as a kind of introduction and quick-links page to find arguments quicker.
The change is not public yet, as I first wanna sort out some issues. Just wanted to document that here
vocal halo
well now you could add something to the "Arguments and Literals" page under the "Minecraft arguments" section that shows all available aruments and have links to the respective page#header
pliant canopy
I am actually thinking about converting the now empty "Minecraft Arguments" into a sort-of argument overview and even splitting up the Arguments and Literals
spice temple
I have started to toy around a bit with the docs around the whole "paper plugin" issue. we talked internally and want to rebrand them as lifecycle plugins, as that makes way more sense, our future goals isnt to replace the existing plugin loading with the lifecycle loading, its something you can opt into to take more control over your plugins lifecycle, which is required for datapack stuff for example.
ill put up a draft shortly, but what do people think about moving the lifecycle plugin page and the userdev page into an advance directory?
eager plover
Sounds fair
organisation is always one of those issues that we've had with the docs
(reasons why I wanted a wiki 103)
spice temple
I hate docusaurus/react/webpack
vocal halo
lifecycle plugins sounds good
vocal halo
smh.... time to move to astro docs (idk if they do it)
spice temple
vocal halo
nice joke
pliant canopy
I have started to toy around a bit with the docs around the whole "paper plugin"...
It would definetely give more "fullness" to the whole lifecycle thing
still apex
i think scorpio was looking into astro but for docs
pliant canopy
does docusaurus really not validate dead links
They do. At least for internal links. Only on build, not on dev though
still apex
starlight
spice temple
I am not touching the versioned pages, that seems stupid
vocal halo
i think the plan is to ditch them anyways so 🤷
eager plover
Yea, they make no sense as they're not maintained
Like, they're mostly just a "point in time" snapshot of then, they're not really maintained as such
wouldn't care so much if we had a better way of dealing with that such as on a branch basis, but, it seems like an annoying overhead
spice temple
nor do we want to support stuff like that
vocal halo
wouldn't care so much if we had a better way of dealing with that such as on a b...
i mean for internal use maybe but it shouldnt be public
eager plover
I mean, maintaining a history of stuff is good for prosperity
spice temple
its a git repo
vocal halo
"shouldnt be public" means it shouldnt be accessible via the docs website
eager plover
We offer older resources for a lot of other things
not supporing something doesn't mean that we need to cast it 100000 miles off the face of the earth
though, migrating all of this stuff to a better means of handling it would be a pita
so, I mean, I agree on the front of not putting effort into shuffling it around, but, idk, maybe in the future worth doing it, just for stuff like the config ref type things
vocal halo
fair point
vocal halo
does this also intend a rename of the paper-plugin.yml file?
pliant canopy
Btw, wouldn't brigadier commands count under the advanced tab as well?
Because they are also somewhat complex and also use lifecycle events
vocal halo
i dont think so
spice temple
its under API, thats a different category and more like a reference
vocal halo
should we add some hardfork admonition? That Spigot API past 1.20.3 might not exist on newer paper verisons?
spice temple
meh
we dont need to keep references to spigot forever
its mentioned in the announcement, thats enough, no?
pliant canopy
I mean
vocal halo
idk it was just an idea
pliant canopy
There is probably a few plugin devs who are not in the discord
Who just use the docs
and suddenly, they plugin stop working on spigot, and they have no idea why
vocal halo
i mean if we want to reach the highest amount of userbase we need to add a warning log in the server console 
pliant canopy
vocal halo
and even then people would come into the discord and ask why their spigot plugin doesnt work on paper
spice temple
ill add something similar to the docs, gimme a sec
ill link mbaxs goodbye bukkit post I guess
scenic gull
Eh, unnecessary reading link for a docs page IMO.
spice temple
I guess this would be a better one anyways https://bukkit.org/threads/bukkit-its-time-to-say.305106/
scenic gull
That one causes extra confusion with luke's edit at the bottom, made before 99% of the drama occurred. I think it's easier to just say what you say there, without elaboration.
spice temple
ye
gib feedback plz https://github.com/PaperMC/docs/pull/511
no rush tho, it will most likely sit for a while until the changes in paper have been made
what needs a bit more work I think is the difference between https://papermc-lifecycle-plugins.papermc-docs.pages.dev/paper/dev/advanced/userdev and https://papermc-lifecycle-plugins.papermc-docs.pages.dev/paper/dev/internals
vocal halo
the whole "What is a Bukkit plugin?" section is weird
scenic gull
Weird why? It's the last in a chain of clarifying naming that naturally would extend back chronologically to what a lot of people still call their plugins.
vocal halo
I don't know. A Bukkit plugin can also be a spigot plugin.
eager plover
I mean, that's a bit of needless disambiguety
the bukkit plugin loader is the topic there, not the "what variant did you build against"
scenic gull
a bukkit plugin could be called a paper plugin. I think it's useful to clarify that a plugin page you see that says "bukkit plugin" can still probably run fine on paper, and that section does a nice job of it.
vocal halo
maybe
also why "but plugins that use Spigot API introduced after Minecraft 1.21.4 may not work correctly." What if Spigot adds api in 1.21.4, at this point paper already split. Or will you pull everything that they add until 1.21.5/1.22 into hardfork?
eager plover
I mean, spigot no longer supports 1.20.4, it would be pretty weird and out of character for them to go back and add API to it
eager plover
yea, was just about to say
We've already announced that we plan to pull API for a while
vocal halo
ah i see
timid mulch
I really appreciate to change the naming of that topic, especially with the soft spoon and the growing attention to difference (and well, it was a confusing naming from begin on :/)
Changing the name of paper-plugin.yml to lifecycle-plugin.yml is not planned as far as I can see?
It would be an unnecessary break I guess but would terminate the last confusion (I would hope it at least).
vocal halo
i mean you could still keep the paper-plugin.yml naming for compatability but the whole Lifecycle plugin stiff is experimental and thus subject to break anytime.
neon atlas
I am barely convinced lifecycle-plugin is a good rename but that shall be internally fought out
timid mulch
Yeah, I mean more streamlining it with the commonly used name, although when it sounds not great as file name
eager plover
DING DING DING, ROUND 1, FIGHT
still apex
I am barely convinced lifecycle-plugin is a good rename but that shall be intern...
owen plugin
spice temple
Stuff will be changing, ye
pliant canopy
Call it Extended Spigot Plugin With Access To Paper-Internal Functionality
I think that's a very good and memorable name
mighty dirge
Since when is the bootstrap api internal?
pliant canopy
Since when is the bootstrap api internal?
Well, it is for spigot plugins
mighty dirge
But plugin.yml != spigot plugin
pliant canopy
Well, yes
but what else to call it
What is a way to say both spigot and bukkit plugins?
Traditional Plugins?
mighty dirge
Legacy Plugins :P
pliant canopy
Yeah that's a good one
eager plover
I mean, I generally just tend to confer on the base platform
pliant canopy
Extended Legacy Plugin With Access To Paper-Only Functionality
There
fixed all issues
eager plover
plugin.yml is the bukkit plugin system way of loading plugins
mighty dirge
But they already exist, I mean legacy plugins as without any api version in the plugin.yml
still apex
has my new name recommendadtion been noted internally????? ||(#docs-website message)||
neon atlas
has my new name recommendadtion been noted internally????? ||(https://discord.co...
yes, we are considering the correct punishment rn
scenic gull
This is going in your file.
still apex
how many pages is it
vocal halo
still apex
maybe a good idea to add the beta version of PW now?
since it’s required for .4 afaict
still apex
and the required gradle version
fair river
stop playing gta and fix it powercash 
still apex
i died
neon atlas
finally money
mental sleetBOT
(676ae0c76ed5010734cf1a6c) // @earnest umbra (@jiajun9028 / 884967776907837450) has been banned by @neon atlas (202850073812402177)
Reason: Quick-banned for sending a message in #docs-website
neon epoch
Someone needs to shoot me if I don’t review PRs today
lone pine
🫡
pliant canopy
Someone needs to shoot me if I don’t review PRs today
Sure 
/s
pliant canopy
Regarding the many questions, I did a quick PR to address userdev usage on 1.21.4. If somebody could look over that really quickly, that'd be great, https://github.com/PaperMC/docs/pull/513
Once userdev goes out of beta, I will make another PR to remove that warning again and to just say that it requires 8.11.2 of gradle now. But until that is not the case, I think this should suffice
still apex
my review still stands
the fact that 8.11 or older doesn’t work should be self explanatory
still apex
Someone needs to shoot me if I don’t review PRs today
what’s your address
vocal halo
the fact that 8.11 or older doesn’t work should be self explanatory
Why is it self explanatory?
small harbor
considering we've had one person in paper-help earlier who tried to use gradle 8.11 instead of 8.11.2
doesn't hurt keeping it in there
scenic gull
I agree with Michael. It's short enough to not be worth worrying about.
fair river
Surprisingly amount of plugin dev who doenst read the error message lol
spice temple
its a big error message and it requires interpretation
its not "this is wrong, do this". its "you requested this but we only found this" and you need to diff it yourself
spice temple
Someone needs to shoot me if I don’t review PRs today
4 hours left :whip:
😛
oh I guess you just merged one
spice temple
👀
neon epoch
I think season 2 started slow but I’m really enjoying it now
neon epoch
What’s this that you use?
vocal halo
oh I guess you just merged one
He saw you typing
neon epoch
Ive given the brig docs a read through
im a fan but they are still a WIP
once they are complete ill review it
neon epoch
👍 fairs
also for redirects with removing versioning, do we reckon this:
/paper/:version/* /paper/*
/paper/:version /paper
Why?
drowsy zinc
some of them are pretty big
neon epoch
Think that’s all the stuff I can review
drowsy zinc
and gifs are used elsewhere in the docs already
the argument for having mp4s is the ability to pause the video, which you can't do with gifs
still apex
invent a new format like gif but with pausing
neon epoch
small docs sidequest
spice temple
Can you pause animated webps?
drowsy zinc
no I don't think so
spice temple
But you can also change the fps on mp4s, no? To make them smaller?
drowsy zinc
and compress them yes
spice temple
Ah ffmpeg can change the frame rate and reencode
still apex
i saw that
wheat arch
Yeah sorry i did not read all messages
neon atlas
finally
mental sleetBOT
(67706fac6ed5010734cf1a82) // @high pulsar (@zetaaxc / 1240818657274105940) has been banned by @neon atlas (202850073812402177)
Reason: Quick-banned for sending a message in #docs-website
neon epoch
Yeah sorry i did not read all messages
What custom component
coral gulch
For compatibility, GIF would be best option, but it fails at any other standards, like functionality, file size etc.
MP4 is better option, but I think WebM is also good.
Nowadays, most of web browser supports WebM, and the file size of WebM would be smaller than MP4 because of higher compression.
Compatibility: GIF wins (but not a big deal)
Functionality(pause, playback speed etc.): MP4, WebM wins
File Size: MP4, WebM wins
Sometimes, file size of MP4 is smaller than WebM file. So I would suggest encoding the video to both MP4 and WebM to see which one has smaller file size.
I don't know the condition of MP4 become smaller than WebM 😦
eager plover
Well, mp4 and webm are both containers, what matters is the codecs
coral gulch
Many (or, most) MP4 file uses H.264 as video codec which is supported by (almost, except for Opera Mini) every web browsers.
MP4 file that uses H.265(HEVC) as video codec exists, but not that 'popular' because it requires hardware support which may not be available in many video cards.
WebM uses VP8 or VP9 video codec which are supported by (almost, except for IE and Opera Mini) every web browser.
From what I know about WebM is, it is basically Matroska that uses VP8/9.
eager plover
Yea, but while H.254 is mostly used for MP4, it does support 265 and even AV1; ofc, I would probably just go for VP9 on my relatively primitive knowledge; We could maybe consider messing with something like youtube if we wanted to embed videos on the docs, rather than dealing with that front ourselves
coral gulch
I also support on using WebM/VP9 for this.
But I think using YouTube will create 'security concerns' like securing YT channel account. I've seen many famous YT channels got compromised and changed into cryptocurrency billboard or famous electronic car company billboard.
eager plover
Which is generally done through click stealing of some form, we're not a high risk target with a bunch of staffers logged into privilaged accounts as such
wheat arch
What custom component
So like i send a message containing a component of a docusaurus docs. I later read at the top that this discussion was about the brig docs.
Recap of message:
I have been using a custom player component with webm videos(Message contained an image).(Or something like that)
(Sorry for later response)
terse magnet
spice temple
echo canyon
isn't there a v2 literally in the url?
eager plover
Different version
random pollen
I think the userdev page should just recommend the latest beta in general - the bit pointing people to beta 8 is outdated already, and v2 also includes fixes for older dev bundles breaking due to the old repo endpoint closing
pliant canopy
I think the userdev page should just recommend the latest beta in general - the ...
Very well. I will do a PR to remove the removal of beta versions and just generally recommend running the latest gradle version
random pollen
thanks
pliant canopy
still apex
ollie....
still apex
merge a pr without proper review
still apex
solve
neon epoch
Get in the bin
still apex
good thing it wasn't your pr
neon epoch
That one I did read more thoroughly…
pliant canopy
Well, the better that it had no issues
still apex
yet
mental sleetBOT
(67785e386ed5010734cf1a9d) // @junior burrow (@leishybo / 951592203610882110) has been banned by @neon atlas (202850073812402177)
Reason: Quick-banned for sending a message in #docs-website
outer elkBOT
pliant canopy
#bot-spam
pliant canopy
Damn. That's crazy
drowsy zinc
consult the contributing guide for the only good english flavor
spice temple
English not British pls
pliant canopy
Alright, the PR is done. I'd love some feedback (and as many nitpicks as possible!!) for the current state of the improved Brigadier command api documentation: https://strokkur424-improve-brigadie.papermc-docs.pages.dev/paper/dev/command-api/basics/introduction. Otherwise, this is pretty much mergable from my side
If some stuff is missing that's because this PR is big enough as-is already, so most of the more advanced stuff (forks/redirects, custom arguments, and similar) will be content of their own PRs
drowsy zinc
just finish it so you're happy with it and I'll review it when it's mergeable
I don't want to go over the PR more times than I have to
pliant canopy
I mainly want people to look over it to find some weird inconsistencies or bad grammar or stuff. Or if somebody thinks that the structure needs a change. Not forcing you specifically to read it
neon epoch
What I had read before was good, but like scorp I’ll wait until it’s complete before leaving reviews. One thing I will say though is to keep unnecessary rambles out. Some paragraphs got quite lengthy
pliant canopy
Very well, I think I am happy with it now @drowsy zinc @neon epoch
still apex
no
neon epoch
Very well, I think I am happy with it now <@504916819987922954> <@39234788164802...
Ok! As I said I’m on holiday but I’ll look at it when I get a moment
pliant canopy
Yeah no worries! It's not like there is a ticking bomb on that PR and it deletes itself after 3 hours
still apex
Ok! As I said I’m on holiday but I’ll look at it when I get a moment
just enter a random office building
neon epoch
just enter a random office building
True why didn’t I think of that
You’re just smarter than me I guess
still apex
yeah
neon epoch
@pliant canopy the file size is very large. 20mb assets take a noticeable amount of time to load on a page. I thought we discussed this in the past when we were talking about gifs / mp4
pliant canopy
Might have missed that part in that case
neon epoch
Sure. These can be compressed though
pliant canopy
I could reduce it by like half or even a quarter
Just want to make sure it remains readable
pliant canopy
@neon epoch I tried decreasing the file sizes a bit, and here is how it looks:
I feel like the 50% compressed one looks alright enough that it can be put there. the 1/3rd one might be a bit too much.
With this, a 12 megabyte video is compressed down to just 3.4 megabytes. Do you think that's enough?
(File sizes for reference)
neon epoch
I guess the question is also, do we need the full screen for the demo?
Can we get away with the chat box
Just a thought, but yeah. Cut it down as much as you see reasonable
pliant canopy
I guess the question is also, do we need the full screen for the demo?
I mean, there is only like 2 or 3 full screen demos
the rest are just text boxes
vocal halo
What happened to the idea of using gifs?
pliant canopy
What happened to the idea of using gifs?
The way I have it currently is so that it is pausable. You can't exactly pause a gif
That's why it has to be a video
vocal halo
Are there videos that need to be paused?
pliant canopy
I find it more convenient so.
serene vault
I would crop them to just the chat though, otherwise the actual important part is really tiny
pliant canopy
I would crop them to just the chat though, otherwise the actual important part i...
It is cropped to just the important part lol
They are usually cropped to about this, sometimes slightly smaller depending on how big the tab completion actually looks like
still apex
for the databases page, is there a reason we're showing a really old version of hikari?
a 4 year old version
neon epoch
No
drowsy zinc
I don't think we need to do automatic latest versions for every random library mentioned in the docs, just place a placeholder and a link where the latest one can be found
lilac edge
neon epoch
Has the webhook killed itself?
Who knows
Anyways, gone thru all prs that needed looking at
brazen moon
https://github.com/PaperMC/Paper/pull/11822#issuecomment-2563033985 <@2201808416...
done
pliant canopy
Anyways, gone thru all prs that needed looking at
Absolute legend
still apex
skipping yours
spice temple
Has the webhook killed itself?
huh
disgit successfully executed webhook
wait checked wrong repo
no I am ocnfused
@neon epoch which webhook doesnt work?
eager plover
stuff like the review on there is missing from the gh posts channel
or, that's request changages, nvm?
https://github.com/PaperMC/docs/pull/520 - has a comment on a request
still apex
<@392347881648029696> which webhook doesnt work?
the preview
wait that's a paper pr
not docs
drowsy zinc
none of the review comments or the regular PR comments on the brigadier PR went through
spice temple
I dont get it
vocal halo
None on my PR either
spice temple
its def configured properly
eager plover
is disgit doing some filtering or other?
spice temple
then the response is different
restarted it, no change
and since paper is going thru it cant be a rate limiting
no clue what else I can try
@slate scarab ever encountered this before? a webhook is showing no error, response to github says it was successful, but nothing shows up in discord even tho the I tripple checked the webhook id and secret and thread id and stuff?
does "fetch" throw if status != 200?
. A fetch() promise does not reject if the server responds with HTTP status codes that indicate errors (404, 504, etc.)
maybe thats worth catching and logging
brazen moon
on paper PR description are not shown anymore too
spice temple
Got 400 from discord: {"message": "Webhooks posted to forum channels must have a thread_name or thread_id", "code": 220001}
wat
ooooooh
yeah ok I had /github?thread_id=blah, need just ?thread_id=blah
my fault when moving from discord to disgit
lemme know if you notice anything else
@slate scarab this should help idiots like me to not misconfigure stuff https://github.com/JRoy/disgit/pull/10
lemme know if anything else is wrong with the hooks
slate scarab
lol will take a look later
pliant canopy
@drowsy zinc fixed all your issues. I hope I didn't overlook any of them, but thank you so much for the reviews. You spend a ton of time looking through all of it, so I am very grateful for it
It should be mergeable now, as Ollie previously commented
neon atlas
hmm so I should read it huh
pliant canopy
Oh no
Then you will merge-block it
But hey, I am on 109 commits now
That's probably the most commited PR I have ever done
(full commitment here 😂)
neon atlas
if whoever merges this does not squash, I'll haunt them
pliant canopy
if whoever merges this does not squash, I'll haunt them
Ahahahahahahah
still apex
i’ll force ollie not to
still apex
}
else {
neon atlas
also like, early returns pls, we gotta teach semi good code style xD
also adventure components
pliant canopy
Literally using those elsewhere
pliant canopy
also like, early returns pls, we gotta teach semi good code style xD
Fine whatever. Wanted to make sure users understand the flow
Will "fix" it when I get home
daring wren
Quick note for https://strokkur424-improve-brigadie.papermc-docs.pages.dev/paper/dev/command-api/basics/arguments-and-literals#string-arguments - underscore isn't the only allowed character, allowed are 0-9, a-z, A-Z, _, -, + and .
vocal halo
But hey, I am on 109 commits now
Force push my beloved
drowsy zinc
it's going to be squashed on merge, squashing locally and force pushing makes it harder for me to incrementally review your changes :)
pliant canopy
Quick note for <https://strokkur424-improve-brigadie.papermc-docs.pages.dev/pape...
I mean, yeah. I had it updated in the table but I overlooked it in the more extensive description
vocal halo
Didn’t know people do that. But I guess it’s fair with such a large PR.
GitHub only showing „this file has changed since last view“ doesn’t really help either.
pliant canopy
also like, early returns pls, we gotta teach semi good code style xD
Not sure what adventure components really make sense here, since it is just very simple String concats. If it were slightly more complicated, which in some other place it is, where I btw do use sendRichMessage and tagresolvers, I'd definitely use sendRichMessage. Just in this one specific place it makes little sense I think
neon atlas
I mean, just generally components are nice to use consistently
just wrap it in text and call it a day pretty much
pliant canopy
Yeah but
neon atlas
but also, CommandSender#name exists
neon atlas
but also, CommandSender#name exists
^
still apex
wouldn’t it make sense to do that
pliant canopy
but also, CommandSender#name exists
Yeahhhhhhh ahhhhhh
pliant canopy
wouldn’t it make sense to do that
That is the executor page
I dont want to mix concepts
Its mentioned here though https://strokkur424-improve-brigadie.papermc-docs.pages.dev/paper/dev/command-api/basics/requirements#defining-more-advanced-predicates
neon epoch
if whoever merges this does not squash, I'll haunt them
I could be down for haunting
neon atlas
👻
pliant canopy
I could be down for haunting
Great. Then time to yolomerge this before I have time to do whatever lynx is saying
neon atlas
Thank god I can push straight to main 
pliant canopy
Also yes, screw you lynx, let me update that one example, you have won
neon atlas
but yea, pls switch to components. Even if you technically don't need them here.
Just so we have a consistent usage of components across the wiki
still apex
no PDA!!
pliant canopy
Thi make you happy? ```cpp
if (sender == executor) {
// If the player executed the command themselves
player.sendMessage(Component.text("Successfully set your flight speed to " + speed));
}
else {
// If the speed was set by a different sender (Like using /execute)
sender.sendRichMessage("Successfully set <playername>'s flight speed to " + speed, Placeholder.component("playername", player.name()));
player.sendMessage(Component.text("Your flight speed has been set to " + speed));
}
This fine?
(cc: @neon atlas)
neon atlas
Yea 👍
pliant canopy
Yay
pushed
I guess it is now actually mergable, assuming no one else has anything to say?
still apex
i have something to say
pliant canopy
i have something to say
your opinion doesnt count
neon epoch
I guess it is now actually mergable, assuming no one else has anything to say?
I got 20 mins before work, no time to check today
Maybe tomorrow morning around packing for uni
pliant canopy
Aight. Take your time
No need to stress it. PR has been in development for just about over a month now after all, so one or two days longer will not matter
brazen moon
can you remove the NotNull annotation and migrate to jspecify? you also use the obsolete CommandSender#sendMessage method if you only want a string you can use sendPlainMessage
mental sleetBOT
(6787d1326ed5010734cf1adb) // @ionic finch (@eusoufelipefg / 937426544954056834) has been banned by @neon atlas (202850073812402177)
Reason: Quick-banned for sending a message in #docs-website
pliant canopy
can you remove the NotNull annotation and migrate to jspecify? you also use the ...
alright, I migrated to jspecify and replaced all of the obselete sendMessage
brazen moon
thanks i will review the PR further now
pliant canopy
Nice, very much appreciated
still apex
pliant canopy
lol
pliant canopy
Yeah uh no. I am not moving the elses to the closing braces
still apex
yes you are
vocal halo
yes you are
+1
pliant canopy
@still apex the _redirects dont work
not even the predefined ones
(this is a build instance, run with pnpm run serve)
pliant canopy
that's annoying smh
cant even test on local
@still apex why is cloudflare broken
still apex
there’s this great button
pliant canopy
The thing compiles just fine on local, and gh actions also compiles successfully
still apex
it says view logs
pliant canopy
there’s this great button
This great button shows all green
smh
The logs themselves seem to be clean as well
Cloudflare just broke
still apex
@opal flare (idk who else has cf access) could you look at logs?
pliant canopy
Probably Mini too, no?
opal flare
I'll peek
Cloudflare API returned non-200: 503
API returned: upstream connect error or disconnect/reset before headers. reset reason: connection termination
not your problem
opal flare
re-running in case it was a one-off error
pliant canopy
That'd be great, thanks!
opal flare
it deployed is what I mean :3
pliant canopy
But yeah, it's up-to-date now
Thank you very much
Riley for the win!
yeah okay redirects work fine over cloudflare
that's handy
pliant canopy
yes you are
I absolutely refuse to, which is why I got rid of all elses entirely
still apex
still here https://i.imgur.com/9KpGEAo.png
pliant canopy
perhaps vsc is lying to me then
but there is no other instance of else in the entire documentation
pliant canopy
still here https://i.imgur.com/9KpGEAo.png
Probably out-of-date deployment
brazen moon
it's really too big for a pr, split them more if you can next time so it's easier to review
opal flare
I hate prettier
pliant canopy
it's really too big for a pr, split them more if you can next time so it's easie...
Yeah I am planning to do that for the next ones
I already cut out a lot of stuff I wanted to add anyways
The next ones will all have a PR each
vocal halo
Looooong disclaimer
spice temple
if you dont like the limit, change the limit?
pliant canopy
Alright, I have addressed all of the issues you have pointed out @brazen moon. Thank you so much for taking the time to review my PR. It definitely helped a lot
brazen moon
great and what happened to the second video there https://24ad8e40.papermc-docs.pages.dev/paper/dev/command-api/arguments/registry#resource-key-argument why you have an error?
still apex
The only difference is that using ArgumentTypes.resourceKey does not provide error checking. We can visualize this using RegistryKey.ITEM
oh wait nvm misread
pliant canopy
great and what happened to the second video there https://24ad8e40.papermc-docs....
When trying to retrieve the registry value, it cannot do it, since yk, that key doesn't exist. That might be fixed by that RegistryResolver thingy, I am not sure. Will test that tomorrow
brazen moon
i don't think that will solve your issue Registry#get is nullable and will be null for invalid keys but it's the plugin responsibility to just not NPE like that (which you do fine in the next snippet)
pliant canopy
I feel like it is fine to show in the preview that not properly checking the registry will result in an NPE and it should be handled by the developer
Perhaps I should add a note regarding that, if I haven't already
eager plover
The duality of this stuff is "how much do you go full beginner"
pliant canopy
I mean, these parts of the docs are aimed at fairly novice developers
At least that's how I tried to write them
brazen moon
yea it's fair but people can't guess the issue since it throw the generic exception message rn but still feels weird when the next snippet properly check that
pliant canopy
I will just add something below the video to clearify that something like that should definitely be checked
Somehow smooth it over I guess
still apex
it's the year 2032 and paper still has no brigadier documentation as that's still stuck in review
pliant canopy
neon atlas
contributing a 2.5k line change in a single PR usually gets you thrown in prison and then tortured
serene vault
contributing a 2.5k line change in a single PR usually gets you thrown in prison...
unless your name is Spottedleaf
pliant canopy
The new commits are not even showing up
Somebody please merge this
GitHub might be sending out assassins right now
FUTURE!!!!!
I WILL BE COMMENTING
WHAT THE HELL
Does that happen for anybody else?
still apex
pliant canopy
AHHH LEAKAGE
brazen moon
you have duplicated the painting variant overview
pliant canopy
fixed
brazen moon
can you remove all the trailing whitespaces too?
brazen moon
what i mean for entity argument was more that for all methods you have "<argument type name>Argument" except for the entity arguments. Also noticed you dropped the experimental warning of the api
pliant canopy
what i mean for entity argument was more that for all methods you have "<argumen...
I mean, I fixed that, didn't I? Or did I forget to modify one. Also I will readd the experimental warning, though to me it seems pretty much stable already. Afaik somebody from the paper team also noted that it might as well be stable
neon atlas
Well very thankful to not have stabilised brig yet given our upcoming alias changes
brazen moon
that's fair but still not the case in the api.
pliant canopy
alias changes? Well color me surprised
brazen moon
i mean you have singleEntityArgument and playerArgument for the names
pliant canopy
but yeah, will re-add the warning
pliant canopy
i mean you have singleEntityArgument and playerArgument for the names
I mean, that's what you wanted me to fix? Because before it was just singleEntity() and player
Or I misunderstood you again, in which case I am very sorry 😅
brazen moon
yeah but why you have single and multiple before only for the entity ones
pliant canopy
yeah but why you have single and multiple before only for the entity ones
Because entity and entities has so little difference, so I had originally added it. I probably just forgot to add it to the player ones, though I do agree that it sounds a bit silly with single and multiple, so I might just remove those parts
pliant canopy
but yeah, will re-add the warning
brazen moon
can also probably add it to the comparison page since it's a little bit standalone
brazen moon
nope everything should be good
pliant canopy
Great, very glad to hear that
If you notice anything afterwards, we can always fix it anyways
left egret
tidal inlet
That's not the docs page and just PR a fix
pliant canopy
That's not the docs page and just PR a fix
It wouldn't be accepted
tidal inlet
why
pliant canopy
Paper doesn't currently accept random spelling or style fixes
Please refrain from simple cleanup PRs 👍
neon atlas
Javadocs are fine, a spelling mistake isn't a cleanup. Cleanup is like, removing a public from an interface method or adding a final to a variable
Things like, don't have any effect
pliant canopy
Smh lynx sending me mixed signals
pliant canopy
You're just saying that because you hate me 
hard quartz
Javadocs are fine, a spelling mistake isn't a cleanup. Cleanup is like, removing...
then free PR for me xd
rancid yacht
You're just saying that because you hate me <a:PhosSad:592956259599253506>
my 3 javadocs pr would have definitely got a comment if they didn't accept javadocs prs at this moment
pliant canopy
my 3 javadocs pr would have definitely got a comment if they didn't accept javad...
Yes, I know now . I had assumed "cleanup prs" to also mean jd prs
eager plover
The general gist is that such cleanup PRs are often relatively valueless and get in the way of working on other things; changing a JD is generally not going to cause such conflicts, so it's not a huge concern; ofc, if we had 20 dozen people submitting such PRs, it would become a sustainability issue
mental sleetBOT
(678fc61c6ed5010734cf1afb) // @jolly marlin (@v1mkss / 541507485471735810) has been banned by @eager plover (126975485493248000)
Reason: Quick-banned for sending a message in #docs-website
neon epoch
Magic
still apex
i think you should revert it
pliant canopy
Lesgoooo
Thank you kindly @neon epoch
I can finally sleep in peace and continue writing more documentation hehe
hard quartz
Was large path? XD
pliant canopy
Took 5 weeks and like 140 commits 😂
hard quartz
Not sure why i feel this is not break any record for docs PR xd
pliant canopy
I think it is the most commented on PR with the most co-authors
Whether it is the one with the most commits, I do not know
pliant canopy
Lol, @mighty dirge, because you co-authored on the Brig docs PR, you also got attributed the 2.6k line additions. So you have a lot of changes now 
(This is also true for Ollie, cas, and scorp, but they already had a ton of changes anyways)
That seems kinda weird though. I would've expected that GitHub actually goes by changed lines, not by PR. But maybe because it was squashed, git doesn't actually know who wrote which line?
spice temple
ye, git just sees the commit and all the authors
vocal halo
I mean those people reviewed your 2.7k PR so see it as credit for that.
pliant canopy
Not complaining
If I didn't want co-authors, I wouldn't have commited their suggestions. But I did want this to be a community project, so I am completely fine with it
pliant canopy
For #530 I want to collect some more points that one could put into the FAQ or Common Issues pages. If somebody has questions or ideas, make sure to submit them so they can be covered there
neon epoch
I mean those people reviewed your 2.7k PR so see it as credit for that.
I mean, it’s not a competition 😂
You were busy with issues
pliant canopy
I mean, it’s not a competition 😂
I mean... there is a leaderboard...
vocal halo
Not really a leaderboard but more statistics
neon atlas
wtf is this discussion 
vocal halo
I don’t know
pliant canopy
smh it's all Ollie's fault
vocal halo
Why?
pliant canopy
No reason
still apex
usually is ollie's fault
pliant canopy
For [#530](<https://github.com/PaperMC/docs/issues/530>) I want to collect some ...
Welp, this became off topic, so I just want to bump this in case other people look into this channel
trail jasper
btw do br tags still dont work for the same stupid reason?
pliant canopy
btw do br tags still dont work for the same stupid reason?
<br> tags work fine, idk what you mean
jagged pecan
Make sure they are self-closing
Ie
<br/>
mighty dirge
Lol, <@602488872542273567>, because you co-authored on the Brig docs PR, you als...
Interesting, what is weird about this is that when I myself squashed a pr (which was dumb) where Scorp co-authored, he didn't get any credit for it.
https://github.com/PaperMC/docs/pull/466/commits/b5c353e9ebc53c3270882a2b037f5a816132a9e9
-# And why do I get attributed the lines, when they only show the commits I authored in the commit overview?
lilac edge
Interesting, what is weird about this is that when I myself squashed a pr (which...
co-authored-by needs to be at the end of a commit message for it to be "parsed"
brazen moon
Strokkur AdventureComponent is part of internal, the recommended way is to use the right serializer (MessageComponentSerializer)
pliant canopy
Strokkur AdventureComponent is part of internal, the recommended way is to use t...
Oops, my very bad 💀
The project I am testing it on has userdev, so I have internals access. Didn't realize it was internal, since it is under the io.papermc package smh
Will fix it
Fixed 👍
spice temple
this was a "I am blind issue"? https://github.com/PaperMC/docs/issues/538
pliant canopy
this was a "I am blind issue"? https://github.com/PaperMC/docs/issues/538
PLEASE DON'T MENTION IT
I have a big monitor