docs-website

[lilac edge]

good luck

[spice temple]

oh god

why do people do this and not do components right away

I know the answer, because doing stuff in react is a pain

but still

[last bear]

Yeah that's looking nicer

except https://i.imgur.com/hT4XpNv.png

[lilac edge]

.

[spice temple]

^

[last bear]

ah

and "Mode:" doesn't look centered and should be closer to it

[spice temple]

its centered vertically

I guess the line height doesnt match perfectly

line height doesnt change anything 🤷‍♂️

[last bear]

It's off by 2 pixels

or just one, depending on how it should be aligned with the dropdown text

[spice temple]

ok, fuck this, I am adding scss

[lilac edge]

it just needs some margin

not margin - but the text in the dropdown is just slightly smaller than the label text, which fucks with the vertical alignment just a bit

[spice temple]

today is "lets distract martin" day at work, even tho I am not even in office yet (its raining)

but I pushed, I am happy with stuff now I think

https://docs-g301izjao-papermc.vercel.app/misc/tools/item-command-converter

gonna get my ass into office for lunch now, can take a final look at stuff after work

[lilac edge]

not sure what the scope is now, but one thing to note is the custom dropdown isn't a11y friendly

same with the start script toggle buttons

[spice temple]

Now that they are components that's easier to fix down the line

All custom UI stuff should be a component

[spice temple]

any complains or can we merge?

[eager plover]

You mean that site thing? I mean, it, er, works?

Okay, well

can you like, fix the drop down?

would be nice if it just had a constant size if that was viable

[spice temple]

thats pretty hard to do

since its absolutely positioned

[vocal halo]

What about this?

[eager plover]

SOmebody else can do that

:L

[vocal halo]

Just want to know if it would be a good change.

[eager plover]

Okay, so, I hate the way that UI is implemented

[neon epoch]

What would be a good change?

[eager plover]

but, you know what

ollie can kiss my machiester

Okay, I have no idea how you'd spell what I was thinking in a translable manner, but, ilyollie

but, yea, I don't care about the UI dropdown enough to do anything about it myself, so, lgtm

[vocal halo]

Ah he was talking to Martin

[spice temple]

I saw it earlier too, fucked around with it a bit but only made it worse (i.e., went off screen, text went outside the container, etc)

scaling absolute positioned stuff is fun

[neon epoch]

Looks good to me, lemme merge it

[eager plover]

I recall there being some flex tricks you can pull off, but, like, it's friday

[spice temple]

be my guest, lol

I hate flexbox

friendship with flexbox ended

grid is now my best friend

[vocal halo]

Let Martin work on the important things again.

[eager plover]

I get the feeling that going on a web dev course is going to be my undoing

[vocal halo]

I opened an issue

Regarding this.

[neon epoch]

Thanks

[green kernel]

Until the next ui concept comes.

[spice temple]

grid took us a hot minute to implement, lol

iirc it was experimental in chrome for 5 years

which is part why its so good, its just so well thought out

[still apex]

@neon epoch !!! emergency!!! https://i.imgur.com/nN8yOIC.png help

[drowsy zinc]

you broke the front matter

[neon epoch]

I panicked and thought this was production

Have fun with that

[still apex]

https://i.imgur.com/uK4nMIR.png

[echo canyon]

I thought the terminal was interactable now, wasn't that merged?

[drowsy zinc]

imports can go after front matter

[spice temple]

Website doesn't deploy automatically

[echo canyon]

oh right, I thought it did. why isn't it automatic?

[spice temple]

Maybe I'll get my ass up later

It runs on the legacy server

We are in the progress of moving shit

(i.e. Riley moved java ducks while I was way)

well,m the deploy script broke

but it did deploy

I blame @drowsy zinc full name

error! {
"message": "The request body contains invalid JSON.",
"code": 50109
}

[drowsy zinc]

[still apex]

where?

bc under it doesnt work

[spice temple]

Check any other file, lol

I.e the tools I just added

[still apex]

oh refresh was broken

[drowsy zinc]

also double quotes please

prettier doesn't run for doc files so it's me who's gonna poke you

[still apex]

https://i.imgur.com/V5oveO9.gif

oh wait

gotta do

thing

[drowsy zinc]

%%_MAJ_MIN_MC_%%

[still apex]

yes that

[drowsy zinc]

is it the same indentation by the way

because that looks off

[still apex]

idk

https://github.com/PaperMC/docs/compare/main...powercasgamer:papermc-docs:maven-example-start?expand=1

[spice temple]

since I just fixed a similar bug in hangar by just setting w-max on the container, this is how it would look like for docs:

hangar can get away with w-max since we use a bunch of JS (in form of a lib, popper) to position the popup

[eager plover]

No

maintaining 20 dozen different versions of a piece of ever evovling piece of documentation is generally just not viable

i18n in general is a royale headache in the first place in anything that isn't just raw text + placeholders

We'd also then need like 20 people on the ball to deal with updating stuff within a day or so

like, it's a commitment rabbithole

[spice temple]

I do want to fix i18n for hangar tho, thats easier to maintain since its just words or maybe a sentence at most

[eager plover]

Yea, but t'is hangar, not docs

for stuff like hangar where you generally have a predefinable list of strings and templating, it works

there is a reason why wikipedia basically just maintains full pages for every article of different languages

they're not even translated in a 1:1 manner, sometimes the pages content can just be wildely different

[drowsy zinc]

@still apex ur welcome to review my pr

[still apex]

no

[drowsy zinc]

rude

[neon epoch]

Wow

I guess I’m not welcome

[drowsy zinc]

you are

very welcome

it's only a small diff

[neon epoch]

I’ve seen worse

Maybe do adventure as well?

[drowsy zinc]

I thought about that but adventure has a latest tag, so it's pointless to version it manually

[neon epoch]

ok sure

[drowsy zinc]

I could make it work with the component and the latest tag, but I found it shorter with just plain markdown links

[vocal halo]

this also probably needs some rewriting.... I did not know it existed so i didn't cover it xd
https://docs.papermc.io/paper/dev/internals

[neon epoch]

oh yeah. if you could chuck a PR or issue that way, would be appreciated

[last bear]

The final missing thing was added for the converter (is also why I blocked before): /convert-entity-argument endpoint with an additional entityType request param, so that mode needs an additional input box

Could even make that a proper select/search for the existing entity types, but that'd just be a nice to have

[spice temple]

I'll take a look

Do you have an example input @last bear @random pollen?

[spice temple]

meh ill add popper for the selects

https://popper.js.org

lmfao

https://github.com/floating-ui/popper.js.org/commit/f72c93116d58f7ab7626b2a0dcbb668c0f86c81e

[last bear]

/summon armor_stand ~ ~ ~ {ShowArms:1b,HandItems:[{id:firework_rocket,tag:{Fireworks:{Explosions:[{Type:1,Flicker:1b,Trail:1b,Colors:[I;11743532,4312372,14602026,8073150],FadeColors:[I;4408131,2651799]}]}},Count:1}],HandDropChances:[0f]}

Copy the nbt part from that, /convert-entity-argument?entityType=armor_stand

[spice temple]

thanks

that works

just need to fix this

[spice temple]

now lets see if I can give the select the same popper treatment

exuse me, floating ui treatment

ayyy https://i.imgur.com/78BUuMH.gif

lemme see if I can get keyboard navigation working on the select

autocomplete already works

[spice temple]

ok now am happy

https://i.imgur.com/VsJX6uF.gif

did I spend too much time on this? maybe

would this have been easier in vue? absolutely

[last bear]

lol

but yeah looking nice

[spice temple]

https://github.com/PaperMC/docs/pull/375

mfw thats hundreds of lines of code

https://docs-6ry1xcelm-papermc.vercel.app/misc/tools/item-command-converter

[spice temple]

@vocal halo what kinda masochist are you that you use arrays with mixed data types instead of objects, lol

like who is supposed to understand this code? 😄

[vocal halo]

Eh

See the comment I wrote

[spice temple]

oh so its not your fault

[vocal halo]

I thought it was the way to go since it got merged before

[spice temple]

does a git blame

[vocal halo]

I think git blame will show my name all over the place?

Since I renamed the file

[spice temple]

there was a comment but it was ignored it seems

I remember the comment

well, I am fine with merging your stuff as is, but it should really be cleaned up afterwards

its tedious work, I can do that if nobody wants to

[vocal halo]

Well it is an interface no?

[spice temple]

I want proper fields, lol

[vocal halo]

But the comment wasn’t ignored per se

[spice temple]

yeah I guess

in IDE you see the tsdoc if you hover, thats def an improvememtn

[vocal halo]

I’ll try to change stuff later. It’s my first time with this stuff so can take a while but I gotta learn this shit anyway

[spice temple]

basically just stuff like

export interface CommandData {
  /** The permission node prefix. */
  [0]: string;
  /** List of all commands under the prefix*/
  [1]: Command[];
}

// to

export interface CommandData {
  prefix: string;
  commands: Command[];
}

which then means changing stuff like this

export const bukkitCommands: CommandData = {
  "0": "bukkit.command",
  "1": [
    ["help", ["?"], 0],
    ["plugins", ["pl"], 0],
    ["reload", ["rl"], 4],
    ["timings", [], 4],
    ["version", ["ver", "about"], 0],
  ],
};
// to
export const bukkitCommands: CommandData = {
  prefix: "bukkit.command",
  commands: [
    {name: "help", alias: ["?"], opLevel: 0],
  ],
};

with multi cursor editing doing all the changes shouldnt be too bad

[vocal halo]

Alright

I’m going out now but I’ll change it later

Thanks for the review 😂

[green kernel]

Holy cow is the second one an improvement. No doc needed to understand.

[spice temple]

self documenting code is amazing, isnt it? 😄

[fair river]

[spice temple]

so thats where the masocistic behavior comes from 😄

[fair river]

No kink shaming Mini.

[green kernel]

Yeah, that's my way as well. Clean Code! I even add a local record in java to avoid anonymous Tupels. Instead of using a fairly big lambda I extract it into a method. 🙂

[spice temple]

I am not! before we had no docs on this, so the PR is appreciated no matter what

[green kernel]

Oh Janet..

[fair river]

[spice temple]

the hard part is listing out all the data, changing the data into another structure is easy

[drowsy zinc]

ya that's what I meant with the comment originally

[eager plover]

jds page needs to link to https://jd.papermc.io/paper/1.20.6/ now

[vocal halo]

New?

(I guess that’s what cas meant the other day?)

[neon epoch]

what page

[eager plover]

software/paper page

[neon epoch]

does it have to? why doesnt /1.20/ just point to .6?

[vocal halo]

True lol

[eager plover]

iirc we where seperating from that

ask riley

[neon epoch]

#paper-dev message

[eager plover]

I guess he just forgot? @opal flare

[still apex]

?

[still apex]

there’s an issue

[vocal halo]

#general message

This no?

Were you not talking about ui?

[still apex]

no the javadoc itself got a slight change in java 21

[spice temple]

We wanted to change 1.20 to redirect to 1.20.6 I think

Serving the same content under two urls is bad for SEO and bad for caching

[still apex]

https://github.com/seiama/javaducks/issues/5

[spice temple]

Best Michael

[still apex]

I had an idea for it but not really sure how to properly implement it, first though was something like version groups like the API has or somehow with regex ors omething

[vocal halo]

@spice temple i converted the interfaces to proper fields now.

[spice temple]

Looking nice!

[vocal halo]

wym with the review

[spice temple]

opLevel as a string doesn't make much sense, idk what that text represents, am on mobile, but I would put that into its own field

I remember the tsdoc having come kinda if it's a number it's this, if it's a string it's this, just have two fields for that

[vocal halo]

can we somehow make them mutual exclusion?

[spice temple]

Uuuhm, most likely

There isn't much you can't do with type gymnastics

Is it worth it? I don't know, lol

Oh can just use two subtypes

And the an union

https://stackoverflow.com/a/61281828

This doesn't look too bad

[neon epoch]

Can we resize this @spice temple , so that Component Doesnt get wrapped? It looks fine when the others are selected as the box changes size

[eager plover]

There is probably some manner of turning taking advantage of the min width to try to limit it expanding

[spice temple]

oh right I wanted to try that now that I use popper

excuse me floating-ui

lemme put out this fire at work and ill take a look

[vocal halo]

I could swear that I run prettier before it pushed

[neon epoch]

haha, if I get round to merging it before you do, ill just do it myself dw

[spice temple]

ok microsoft isnt doing anything so might as well look at this again now

[vocal halo]

Thanks ollie 🤝🏻

[spice temple]

if not enough space it will align end

good enough?

[vocal halo]

Perfect

[eager plover]

Woo

[spice temple]

pushed

lol oli too fast

[neon epoch]

Too fast and CI failed, or...

[spice temple]

well, idk if anybody wanted to look at stuff ^^

[last bear]

Just in time so that you can do the next (and hopefully last) pr

[neon epoch]

im gonna go on strike from merging things

[spice temple]

u did the backend?

[last bear]

Yeah but I pushed most of the work onto you™️

/convert-commands takes a json input {commands: <list of strings>} and returns a list of strings

you need to trim input lines and skip them if they start with # or $, but here's the fun part:

[neon epoch]

do i need to rollback

[last bear]

nah this is a separate thing

[neon epoch]

ok cool

ill let you cook, and ill go cook dinner

[last bear]

Check CommandFunction.fromLines, mcfunctions support multi-line commands via \

I don't think we care enough to output them split again, but it might be nice to be able to at least take them as input

[spice temple]

wooo

but I can just replace \ + \n with nothing, right?

[last bear]

So basically this block https://i.imgur.com/ywxZfrO.png

[spice temple]

oh its indented?

[last bear]

no clue™️

I cannot find any documentation on this on either the mc wiki or microsoft's own docs

and context on the other symbols is that # marks a comment and $ a macro (should also skip empty lines), but we don't handle macros

you could send them anyways if it makes output easier, but it'd be wasted processing on the backend

also also, it's worth nothing that the file you sent me would barely be converted at all because the only entity argument in a full command we can convert is summon, otherwise we don't know the entity type, but

[spice temple]

we ruin any whitespace I guess

good enough for today https://github.com/PaperMC/docs/pull/376

will think about stuff

kinda meh that we cant infer the entity type somehow

[last bear]

Storing the indexes of (non)whitespace lines should be simple enough

[spice temple]

yeah

[last bear]

but yeah I think we can merge without multi line handling and maybe worry about that later

[spice temple]

I asked the guy for an example

[drowsy zinc]

ollie is ruining my beautiful pr names

[spice temple]

its

execute as MiniDigger at @s \
    run say hi

https://twitter.com/slicedlime/status/1787201326394302596

slicedlime 💙💛 (@slicedlime) on X

Nice tool! https://t.co/TpV1ef9FoK

Twitter · May 5, 2024, 7:22 PM

Lol

[neon epoch]

Love it

[neon epoch]

Yeah real.

[still apex]

rare

also their name lol

[spice temple]

Avg idiot

[lilac edge]

the reply from @CarolDa35756982 goes hard

i love twitter

[spice temple]

Without looking it up I know what it is, lol

[neon atlas]

[spice temple]

Thankfully the ad removal mod I use for twitter breaks replies

So I can't view them unless I open the tweet in the browser

[last bear]

There's another https://x.com/Roark_Cats/status/1787306914701021247

RoarkCats (@Roark_Cats) on X

@slicedlime Misode made one as well

https://t.co/GlfaqCH36f

Twitter · May 6, 2024, 2:22 AM

except it doesn't seem to handle commands, entity data, text components, or most item-specific nbt?

[ancient quiver]

they also just implemented the migration stuff themselves; https://github.com/misode/nbt2components/blob/main/src/components.ts

[neon epoch]

interesting

[fair river]

We gonna need Ollie to make monthly Infograph on how our traffic is looking like on the doc site

[neon epoch]

its trending down

[lean venture]

Hell I saw this and I can't unsee it xD

Can someone update this to the new dropdown?

aka the one used in the converter

Also, slight visual bug, it shows Enter your 1.20.4 command here... in all modes

[spice temple]

Not true, for the new function mode I changed it ^^

[lean venture]

you sure?

[cosmic idol]

what is this?

[lean venture]

https://imgur.com/K5wslE9

[lean venture]

https://docs.papermc.io/misc/tools/start-script-gen

[spice temple]

Not merged yet

[spice temple]

Good first PR 😛

Should be easy

[drowsy zinc]

i'm not sure ollie

that API is literally just the TeleportFlag class and the teleport methods, it's quite obvious if you read the doc on those imo

[lean venture]

Hell, I suppose xD

it seems to be already in github lol

probs not pushed to production

[spice temple]

Mmh?

Docs auto deploy

[lean venture]

Well then I am confused lol because the Select component used in the start script gen is the same as the one in the converter

lol

[still apex]

do we have a command api page yet

[lean venture]

confusion

[spice temple]

It's not used for the platform yet tho

[still apex]

for CommandExecutor, Command(CommandMap) & in the future the brigadier command api + maybe mention a few libs?

[spice temple]

Isn't that the only issue?

[lean venture]

oh shit ye, gonna PR it

Does the Select component require the value?

I suppose I will just set the default to linux

like it is.

[vocal halo]

Ollie wants to wait for brig

[lean venture]

Can anyone check if this looks good? https://github.com/xMrAfonso/papermc-docs/blob/main/src/components/StartScriptGenerator.tsx#L220 I honestly have 0 knowledge with react

lol

[still apex]

can you make a pr

for preview

(or send a screenshot)

[lean venture]

Gtg eat but will do it afterwards

[lean venture]

just checked preview and page crashed oof

[lean venture]

yeah noticed, although I didn't add anything related to label so I am confused lol

only modified this

And added the PLATFORMS const

[drowsy zinc]

a couple more changes had to be made: https://pastes.dev/2DDgaBknFh

[lean venture]

what did you change? or am I just blind

[still apex]

string -> Option

[lean venture]

ooh

yeah

me dumb

just added the changes to the PR, thanks! Waiting for the preview

to make sure

works, should I add some spacing between the auto-restart and select menu?

or is it fine like this

[raw breach]

seems a bit tall any way to make it smaller?

[drowsy zinc]

it's as tall as the fields above it

[raw breach]

yeah but it doesn't fit that well here imo

waht about puttin the select menu into a seperate line?

maybe even add it next to flags and filename

[drowsy zinc]

something like this maybe?

[raw breach]

yeah that looks pretty nice

[lean venture]

like it

seems quite nice

[raw breach]

is the auto-restart centered?

[drowsy zinc]

yes

[lean venture]

what if both toggles were on the left

and platform on the left?

[drowsy zinc]

yeah I also thought about that but I'm editing this in devtools :p

[raw breach]

lol

[lean venture]

oof xD

[raw breach]

i think i would still prefer having it next to the other selection menus though. so we have 3 selection menus next to each other and the toggles below

[vocal halo]

What if we make gui and auto-restart to a button?

Would that look good?

[raw breach]

you mean like when toggled on it has a blue background otherwise black/grey one?

[vocal halo]

Something like that

Then you could put those 2 on the left and platform on the right and it would not look weird

maybe

[raw breach]

i like the idea though i am unsure if that's intuitive for the user

[serene vault]

Button for toggles aren't great imo

[serene vault]

I think this looks pretty great

[raw breach]

i think it's kinda odd though because how do we decide what comes into this upper portion of the gen

and what comes down here

because platform is even more important then flags so that should be up there aswell right?

[lean venture]

💡

[serene vault]

Can platform auto-detect the users platform?

[drowsy zinc]

no

[serene vault]

And default to that? then it wouldn't need to be changed a lot

[raw breach]

i mean what if they just ssh onto the linux server

[drowsy zinc]

I mean it could use the user agent or something, it doesn't right now

[serene vault]

linux users are hopefully smart enough to find that dropdown

[lean venture]

why is that useful though? it's probably not going to be used in the user's machine...

[raw breach]

i mean yeah but it still seems weird

[lean venture]

like 98% of the time

[lean venture]

isn't linux literally the default?

[serene vault]

I feel like 90% of the time that pages is used by people who otherwise double click the jar on Windows

[lean venture]

oof

[serene vault]

at least 90% of that page being linked in the help channels here is that

[lean venture]

so how we feeling about this one?

[lean venture]

or this one

whatever

[raw breach]

i really like the toggles on the right but the platform still seems kinda out of place

[lean venture]

xD

[lean venture]

do we actually need the platform label? xD

[spice temple]

Labels are important for accessibility

[lean venture]

just for testing

[raw breach]

could you try adding it next to the filename and flags i wanna see what that looks like

because having all that area for 2 selections already seems pretty emtpy

[lean venture]

so, have filename, flags and platform in the same row?

[raw breach]

yeah

[lean venture]

if I do that, isn't it going to be even more empty?

[raw breach]

i mean all that area here

[lean venture]

AH

okay

well inspect can't really move divs around xD

1s

[raw breach]

maybe try keeping the gui and auto-restart in 1 line aswell

that seems really nice

might be too compact though

[lean venture]

I will just push it to the PR and see what happens lol

[raw breach]

[lean venture]

although me and naming classes sucks, what should I call that row with the autorestart, etc.

since I can't modify config-section since all of them use it

[raw breach]

hmm call it "toggles" for now ig

[spice temple]

It can tho?

Literally can drag and drop them in the elements tab ^^

But why don't you start stuff locally?

[drowsy zinc]

this looks pretty good imo

[lean venture]

cause... uhm... I didn't think that far lol

[vocal halo]

eh

[raw breach]

yeah i expected it to look a bit better

[lean venture]

https://docs-js0lcv3pc-papermc.vercel.app/misc/tools/start-script-gen

[still apex]

toggle boxes should be aligned

[vocal halo]

this looks good

[raw breach]

yeah i didn't realize afonso pushed so i just did it in inspect rq after mini said you could drag and drop

[vocal halo]

well this also looks good

[raw breach]

yeah this is best one imo

[lean venture]

god damn prettier lol

[spice temple]

I like how there's like 5 of you bike shedding the location of 3 inputs

[drowsy zinc]

real ui design

[lean venture]

frfr

[raw breach]

hehe

[vocal halo]

why is server configuration so big?

[lean venture]

UX is very important

[vocal halo]

shouldnt there be another header for the output?

[lean venture]

because it's the title?

xD

[spice temple]

I am so happy I have a professional doing it for me at work, lol

[lean venture]

tbh yeah

[vocal halo]

like generated command is not really a server configuration

[spice temple]

She's a god send

[still apex]

someone should probably add a githook that checks before you commit

[lean venture]

lmao

ye

[vocal halo]

just yeet that shit

everybody complains about it anyway

[drowsy zinc]

because no one can keep the code consistent

[raw breach]

oh have i had my fun with ci complaining about formatting in the past

[spice temple]

It's important to have consistency plus it reduces diff

[inner kestrel]

i simply do not struggle to keep my code in the right style

💅

[spice temple]

Just configure your IDE to automatically run it?

[inner kestrel]

(format on save)

[spice temple]

Right click on the package.json -> apply prettier code style in intellij

Then your normal format shortcut will run prettier

[vocal halo]

too much effort compared to deleting a single file

[still apex]

https://prettier.io/docs/en/precommit.html

[raw breach]

do that on a codebase that doesn't use formatters and you got yourself a 100 line pr consisting of formatting changes lol

[spice temple]

I hate pre commit hooks, they slow everything down

[lean venture]

Running it locally rn btw

[inner kestrel]

that's just a skill issue on behalf of the hook writer

[spice temple]

One team at work put the unit tests into a pre commit hooks

Like wtf

That's what we have CI for, I ain't got time to run that stuff locally

[inner kestrel]

unit tests are for losers just do everything as formal proofs

[lean venture]

hell my pc is slow

still running npm install

lol

[drowsy zinc]

should have used pnpm

[inner kestrel]

isnt the docs website pnpm

[raw breach]

where is difference between pnpm and npm again?

[inner kestrel]

they're different package managers

[lean venture]

don't have it lol

[inner kestrel]

but who knows

[raw breach]

but pnpm is based on npm right?

[drowsy zinc]

enable corepack and your runtime should download it

[inner kestrel]

node ecosystem loves duplicating a bajillion package managers

[raw breach]

so it must have something to offer that npm doesn't

[drowsy zinc]

performance

[raw breach]

makes sense

[lean venture]

th is that

[inner kestrel]

using npm in the docs repo is going to be slow because it has to resolve from scratch without a package lock json

[raw breach]

oh yeah

[drowsy zinc]

https://pnpm.io/installation#using-corepack

[vocal halo]

faster

[raw breach]

i remember seeing some rust repo that had the cargo.lock file in their gitignore 💀

[vocal halo]

why not?

[raw breach]

faster

[inner kestrel]

https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control

[vocal halo]

i honestly also thought that .lock files shouldnt be tracked but i dont really have node stuff anyways

even less rust projects

[lean venture]

hell wait that button spacing at the bottom is triggering me

[eager plover]

the lock files "lock" the dependency versions

[vocal halo]

i guess this is a TIL moment

[eager plover]

bearing in mind that the standard way that you note versions in some of these tools is generally far too open for build reproducability

[raw breach]

wait are you going with that design?

[raw breach]

i personally like this proposal more though that one also looks good

[lean venture]

idk, I am asking lol

this is what I have rn

ALSO, why in the world are we using pixels?!

[raw breach]

for what exactly?

[drowsy zinc]

ollie

[lean venture]

using px for dimensions should be illegal

[vocal halo]

make server configuration smaller

pls

[raw breach]

afaik pixels as measurement are used all around the place at least on the website

[lean venture]

tbh it shouldn't

[vocal halo]

doesn't look bad

[lean venture]

rem should always be used

way better for accessability

[raw breach]

hmm interesting didn't know that. though i ain't a css expert

[lean venture]

1rem = 1 * fontSize

so people that use bigger font sizes, everything would adapt to it

[raw breach]

could we make the copy to clipboard and download button into little buttons in the top right corner of the text field?

[lean venture]

time to find out where I can change their size

lol

[raw breach]

no

i meant like tiny icons

not sure if text there would look that good

[inner kestrel]

why should they be

[raw breach]

i remember seing that on stackoverflow or mozilla docs somewhere

[inner kestrel]

they're the primary reason you're going to the page

[raw breach]

yeah but they kinda look disconnected from the text field

(i am just brain storming here, just trying to find out if stuff looks good)

also i think you might need to repurpose your pr into something more generic lol

^ from mozilla docs

we could move the Generated Command to where the JS is

[lean venture]

hell too much work to know if it looks good lmao

[inner kestrel]

they are placed in proximity to the text field

[raw breach]

fair

might try that if i find time to

[lean venture]

this how it looks rn

any changes?

[raw breach]

looks good imo. up to your to decide which proposal you wanna go with

[vocal halo]

i suggested that all the way back when the generator was proposed for the first time

[lean venture]

completely forgot about this part, looks okay

[raw breach]

and what did ollie say?

[vocal halo]

ah no

i suggested that clicking the text box automatically copies it

[raw breach]

ohh that might be a problem

[lean venture]

mhee

depends on the pov

[raw breach]

having the warning in 2 lines in middle of the screen seems kinda weird

[lean venture]

we could actually use the descriptions in the dropdown to say that linux is recommended?

[raw breach]

oh yeah

[lean venture]

question is... would it have the same effect?

[raw breach]

hmm can you make the text in there red . is probably going to look shitty but who knows

[vocal halo]

i dont know if we even have to add this red text

[lean venture]

uh don't think I can directly, it's a component

[vocal halo]

like if you want to generate a start script you most likely already decided what platform you want it to run

[raw breach]

yeah that's fair

[vocal halo]

good idea

[lean venture]

(is my grammar good there? lol)

[vocal halo]

but windows needs to have a different text

[lean venture]

looks weird

[lean venture]

any suggestions?

those were generated by copilot xd

[ancient quiver]

you could just leave the text out

[vocal halo]

yea

leave it out

[ancient quiver]

we don't recommend mac for optimal performance

[vocal halo]

and that

[lean venture]

good point

so no descriptions and no text, right?

[raw breach]

also am i tripping or is the bottom white darker then the one on the side?

[vocal halo]

but if thats the case than the solution before didn't really make sense either, since it doesn't show when selected linux/mac

and you could still have generated it for mac

and would not have the "warning"

[inner kestrel]

also /bin/bash shebang is wrong

#!/usr/bin/env bash is correct

i should probably PR that in

[ancient quiver]

you are in fact tripping

they are the exact same

[raw breach]

tf they look different

[ancient quiver]

oh the white

[raw breach]

yeah

[lean venture]

was gonna say that I can probs fix it with this PR but probably best to not merge unrelated PRs I would assume

[inner kestrel]

what am i looking at

[vocal halo]

are you high

[lean venture]

I swear it's the same

lol

[ancient quiver]

those are the same

so yes, you are tripping

[raw breach]

wait the closer i get to the monitor the brighter the bottom one becomes and the darker the side on becomes

[neon epoch]

I agree they look different

[vocal halo]

i think you monitor is broken

[inner kestrel]

those are the same hex value

you might be seeing pixel color order shenaniganery

[lean venture]

bro

[neon epoch]

I’m looking on my phone and they look slightly different, but not enough to care

[inner kestrel]

also your two whites are over different backgrounds

[raw breach]

also why is this still a pixel off 💀

[neon epoch]

Speak to the person that made the font

[lean venture]

they are indeed the same

[still apex]

@neon epoch fix it

[raw breach]

this is going to haunt me for the rest of my life

[lean venture]

lmao

[raw breach]

well whatever it is time for me to go. cya

[neon epoch]

No

[lean venture]

so we good with this?

https://docs-m7uqkgpjj-papermc.vercel.app/misc/tools/start-script-gen

yeah looks good

although prettier check failed again although I ran prettier?!

lol

[vocal halo]

yeah happens

can gh actions not commit the changed files to the branch?

[lean venture]

We areee the champiooonnnssss

[neon epoch]

Have you tested the user linking @drowsy zinc

[drowsy zinc]

I mean you can see it on the preview

it should work™️

[neon epoch]

no

its disabled on preview

[drowsy zinc]

huh

I can see it

never mind I got confused

[neon epoch]

nice

k thats them all merged

time for bed

[drowsy zinc]

what if it breaks

[fair river]

Good night

[fair river]

That’s for tomorrow Ollie not tonight Ollie

[eager plover]

All I know is that knowing that it's ollies problem and not mine makes me happy

[drowsy zinc]

it didn't break

[fair river]

[neon epoch]

Bahhh it would have rolled back

[neon epoch]

1.20.6 is now stable (I’m editing this now to just mention this was a joke at the time)

[neon atlas]

[raw breach]

any reason we don't show how to get the lastest minecraft version there?

[neon epoch]

What like that?

[raw breach]

no i meant like in addition to showing how to get the latest build also show how to get the latest mc version

so basically just replace the "1.20.6" with a curl request to that api endpoint

[neon epoch]

well it needs to be adjusted somewhat anyways

it should filter by the highest stable version, and then return that, but yes in essence it shoukd

[raw breach]

does api return if a version is stable?

[neon epoch]

major? i think it just returns if a minor is stable

build that is

^

it returns for builds iirc

[raw breach]

ah yeah it does

might be a bit too much for a simple example of the api then

[drowsy zinc]

it is technically correct, because it prints Latest build is null :p

[raw breach]

so it's broken?

[drowsy zinc]

there's no latest stable build, so it's null

could modify the script to print a different message

[raw breach]

i mean sure ig lol

[neon atlas]

I mean, it is fair. Even if you auto update you are not mad enough to auto update minecraft versions

[raw breach]

hmmm.... surely nobody would do that

[neon atlas]

We can change the "for the given project" to "the given project and version. If no stable build for said version is available, null is yielded"

[drowsy zinc]

i'll modify the script as well to make it pretty :)

[shut delta]

Ohh, you sure about that? Because I am not

[fair river]

Next up in paper 1.21, an .exe jar that automatically download, install java21 then create the folder and start script for the enduser

[distant swan]

give me my .exe! Smelly devs!!!!!

[drowsy zinc]

I was bored, so I made a script for searching for the latest stable version, but I don't think it should be incorporated into the docs 😛

#!/usr/bin/env sh

PROJECT="paper"

while read -r VERSION; do
    if [[ "$(curl -s https://api.papermc.io/v2/projects/${PROJECT}/versions/${VERSION}/builds | \
        jq 'any(.builds[]; .channel == "default")')" = true ]]; then break; fi
done <<< $(curl -s https://api.papermc.io/v2/projects/${PROJECT} | \
    jq -r ".versions | reverse | .[]")

echo "Latest version with a stable build is $VERSION"

[opal flare]

API v3 will be changing things too :3

[lilac edge]

oh? 👀

[echo canyon]

what's up with this PR to make paper javadoc point to latest version? It looks like it already does?

this button points to 1.20 which is latest version in the 1.20 family

[neon epoch]

So basically, I’m not sure why this was suggested to do, but 1.20 points to 1.20.5 instead of .6. I thought we were just gonna update it to point to .6 but idk what’s happening with that

[neon atlas]

that is a javaducks issue no? certainly nothing we'd want to fix on docs or the website

[echo canyon]

oh you're right, it does point to .5

I thought 1.20 was just supposed to automatically point to latest

yeah, I don't think this is a website issue then, shouldn't be "fixed" there

[neon epoch]

Yeah, that’s why I haven’t done this before. I think we pinged Riley about it but I’m not sure he saw

[spice temple]

the PR for redirects was merged

did nobody configure stuff yet?

[vocal halo]

aha

ok

well I did look around for a bit but i guess i didn't look in the correct repo out of the 50 you have

[spice temple]

lemme try to conf this locally before I commit

the infra repo with the config isnt public (yet)

the world isn't ready for it yet

and it doesnt even count yaml

[vocal halo]

well i see it positive, without my PR people would still have not talked about it

[spice temple]

infra is 14k lines of yaml, lmfao

thoughts @small harbor

[vocal halo]

and 15k of those are k8s

[spice temple]

like, its half a mb of yaml

[vocal halo]

thats funny

[small harbor]

to be fair

[vocal halo]

ah yes javaducks is also on that one account

[small harbor]

90% of that is just flux generated kustomizations

[vocal halo]

the fix is probably somewhere there

[spice temple]

as I said, we just need to configure javaducks

ok ez, figured it out

cool its broken 😄

[vocal halo]

[spice temple]

its just ignoring the 1.20 javadocks now

like the redirect works but nothing else

[still apex]

how’d you configure it

[spice temple]

(reverted prod)

[still apex]

iirc the link has to be a full url so https://jd.papermc.io/paper/….

at least that worked for me

[spice temple]

nah it worked without that

1.20 > 1.20.7 works

[still apex]

the sha255 errors can be ignored if they don’t have a .sha256 file

[spice temple]

its doing dum stuff somewhere

[still apex]

it’ll fallback to sha1 if configured properly

can’t remember what the default was lol

[spice temple]

thats not my issue

the logic is wonky somewhere

the redirect needs to be last

else it ignores the stuff after it

redirect last:

redirect before the other 1.20 versions:

found it

and this ladies and gentleman and everyone in between and outside is why we don't like long as methods with tons of control flow statements

[still apex]

Where was it?

[spice temple]

found another one

mfw I have no perms

oh its not on the paper org

https://github.com/seiama/javaducks/pull/13

[still apex]

in my defense, it worked locally for me

[spice temple]

@opal flare when you get around to merging you can revert my revert on infra, lol
https://github.com/PaperMC/infra/commit/06dcd3f775233250cc8b4c0cca9ccce3a92a2ab0

[spice temple]

yeah, it worked when I tried too, thats why I pushed to prod

its subtle, it will just stop parsing

after a release or redirect

I blame the code, not you, nobody saw it in review either

[eager plover]

I mean

git blame says that I blame powercas, soooo

||<3||

[spice temple]

haha installed a plugin to calc code complexity

it doesnt like the method

[vocal halo]

ha

we actually had to use this plugin once in homework

keep everything below 7

we had a legacy application having the whole code in main and we had to use solid and patterns to split it up

[spice temple]

tried to split stuff a bit and also added tests

[neon epoch]

Why is it British

[still apex]

should also work on your other pr (:

[spice temple]

will rebase that once this fix is merged

not me taking a million force pushes to fix the tests on gh

dum race condition

[spice temple]

riley merged my PR and reverted the revert of the config, now paper/1.20 redirects to paper/1.20.6

[opal flare]

https://jd.papermc.io/paper/1.20/ now redirects to the latest version in the 1.20 family
https://jd.papermc.io/paper/1.20.5/
https://jd.papermc.io/paper/1.20.6/

Other older versions are unchanged.

[spice temple]

oh I should rebase the injection PR now

[still apex]

(did you read my comment?)

[spice temple]

where?

oh, now I have

🦆

[spice temple]

idk if thats necessary, we can just let it 404, no?

if we dont add the injection, its gonna 404 anyways

no harm in doing the injection

[still apex]

From my testing if a favicon doesn't exists the whole page throws an error

[spice temple]

yeah that I am fixing rn

I kinda wanna add an injection that adds a banner ontop saying "you are viewing javadocs for X which is outdated, click here for Y, which is latest"

but thats a different PR

raised https://github.com/seiama/javaducks/issues/14 for discussion

added tests to https://github.com/seiama/javaducks/pull/4, rebased, fixed the 500 on missing favicons, its ready to merge now

[still apex]

straight to prod

[neon epoch]

having read all example code provided, it has now occurred to me that paper's api is too complex to understand just from looking at it anymore

[south thunder]

Shorten to "DANGER: Owen wrote this"

[neon epoch]

https://github.com/PaperMC/docs/pull/307 If anyone wants to work on this, feel free! would be useful to have in place before Brig docs :)

Just PR to my branch, or supersede and cherry pick my commit

[echo canyon]

@neon epoch can u update the feat/lifecycle-api branch? I'll add to it, but it should either have main merged into it or rebased on main

[neon epoch]

Tada 🎉

(There is a button on GitHub for it)

[vocal halo]

Isn’t that refined GitHub?

[drowsy zinc]

no

as long as it can be merged cleanly, github can do it

[vocal halo]

Oh ok

[echo canyon]

ok, so https://jd.papermc.io/paper/1.20/io/papermc/paper/plugin/bootstrap/BootstrapContext.html doesn't work

@spice temple halp

that link doesn't work, you need the full version. https://jd.papermc.io/paper/1.20.6/io/papermc/paper/plugin/bootstrap/BootstrapContext.html

[spice temple]

oh

mmmh

[eager plover]

oof

[spice temple]

will fix

[still apex]

kinda is a WAI no?

[spice temple]

no

[eager plover]

I mean, not retaining path is generally dumb if the sole goal of the redirect it for linking stuff over

like, it breaks the site, for ex

[spice temple]

Expected :/paper/1.20.4/org/bukkit/UnsafeValues.html#checkSupported(org.bukkit.plugin.PluginDescriptionFile)
Actual :/paper/1.20.4/org/bukkit/UnsafeValues.html

mmmmh

guess redirects cant contain those?

oh wait my fault

ah wait the fragment never reaches the server

[eager plover]

was gonna say

pretty sure that # only exists on the client

you'd need to do a JS redirect to handle that afaik

[spice temple]

meh

do we care about that

[echo canyon]

well... probably

for the auto linking from the docs

[eager plover]

Well, the big issue is, what are we using on the website?

[spice temple]

mmh

[echo canyon]

I don't know if we are doing method/field references direct yet

just types so far I think

but that shouldn't be the end all be all of that

[spice temple]

well, guess JS shit it is then

[vocal halo]

Many people here are linking directly to methods

[spice temple]

that isnt an issue, if the link is fresh

[opal flare]

I mean the docs should just use the current version, not the family versoin

https://github.com/PaperMC/docs/blob/main/src/components/versioning/Javadoc.tsx#L7-L16

should just be updated to special-case for paper

[drowsy zinc]

the majorOnly parameter is also a weird special case for velocity

I didn't look at it too closely when I refactored that file

the entire versioning thing (SoftwareVersionFetcher) should be looked at

[echo canyon]

I was thinking there would be some cool stuff we could do to make it way easier to inject javadoc links

like at build time, it resolved the full package of a type or the full url for a method
so instead of having to do <Javadoc name="some.super.long.package.Type">Type</Javadoc>, it could do <Javadoc name="Type">Type</Javadoc>

[still apex]

the majorOnly could probably be removed and just make a if statement for the different versions?

[opal flare]

classes with the same name can exist, I don't really like that

[echo canyon]

yeah, ik they can, but that could just be an error on build or smth

it just makes it way nicer to work with when writing docs so I don't have to look up full packages

it's not that common that there are collisions anyways

[opal flare]

I'd rather keep it simple and just use full packages, guesswork for docs is meh

[still apex]

https://i.imgur.com/TTYDKgZ.png ?

[spice temple]

even added darkmode, lol

[echo canyon]

WOW

[eager plover]

man just wanted to avoid being flashbanged

[echo canyon]

next up... there could to be a header on the javadoc page to change versions

[spice temple]

raised an issue for that already

https://github.com/seiama/javaducks/pull/15

[echo canyon]

ok, I'm good with the lifecycle api docs

[neon epoch]

Cool lemme look

Thanks MM - I changed some of your wording cause it seemed like a bit of a ramble at points

[echo canyon]

Hehe, that’s fine. That bit blurb on the bottom I just copied and pasted from the gist I wrote months ago

[neon epoch]

yeah it seemed like it, especially when it was in the first person lol. Thanks for doing it though ;)

thanks lynx, lol

[neon atlas]

just no one check how many force pushes that was

maybe I should look into setting up a dev container for docs

installing node bs on my system pains me too much

[eager plover]

#paper-help message

[lilac edge]

that page in itself seems flawed compared to just redirecting to the script generator from the start

[vocal halo]

nah its an explaination page

so its fine i guess

[neon atlas]

Maybe we should make the start script thing a note

instead of a tiny line

beyond that, we can quickly fix the bash script with a couple of \ s

[neon epoch]

how many force pushes does it take lynx to do that :P

[neon atlas]

I-

[vocal halo]

yeah bout to do that right now

[neon atlas]

[eager plover]

considering the person who took the charge with managing the docs site

[lilac edge]

why not omit the flags from that page completely?

[eager plover]

I'm guessing it's a leadership issue

it's an explanation page for them, I don't think that the UX issue with the specific impl there really nececitates neutering the docs page here

[vocal halo]

to be fair

their issue wont be fixed with adding \

[neon atlas]

personal issue

[vocal halo]

xd

[lilac edge]

if the note successfully stops the end-user from blindly copying the flags then i digress

[neon atlas]

I mean, we can instead yank the paper.jar --nogui thing and replace it with .....

hammer home that this is not a real command

[lilac edge]

could make it possible to select the flags, but not everything around it? e.g. make paper.jar --nogui non-selectable

[neon atlas]

oh yea, that might be a vibe. Tho, maybe not selectable at all?

[lilac edge]

i can see the ease of use of just triple clicking the codeblock for the flags

[vocal halo]

i think we are making this too big

honestly

[drowsy zinc]

that sounds rather overengineered

[neon atlas]

what is copying the flags going to help you if they have new lines

I don't mind the non-selectable

[vocal halo]

make it an image xD

[neon atlas]

makes it pretty clear they are not to be copied

[lilac edge]

ssshhh i wasn't able to be a part of the bike shedding from earlier

it's my turn to nitpick little things /s

[neon atlas]

[lilac edge]

agreed

[eager plover]

add a copy overlay which copies the correct string?

can we not set the overflow behavior to deal with that without newlines?

[neon epoch]

🤓

[neon atlas]

We could yea

[eager plover]

I don't think that making the site UX there worse is the solution here

people are going to want to copy it because it's just a common ref point

[lilac edge]

on hover, add a clickable overlay that sends you to the generator 👀 /kidding,not kidding

[lilac edge]

works for me

[neon epoch]

Who the fuck knows how that works

[drowsy zinc]

docusaurus has an open issue about setting the initial word wrap state on code blocks, not possible right now though

[vocal halo]

yea

[neon epoch]

yeah, just replace newlines with a long string and then let the user use the automatic wrapping in the docs

my issue got fixed pretty quick tbf, but it was a simple fix

[opal flare]

are you working on something for javaducks again @spice temple?

[spice temple]

no, I am distracting myself with other stuff rn, will get back to my open PRs next week

[opal flare]

well, only asking because of

it was at 22 hours before

lmao

[spice temple]

the rich presence stuff is super buggy when you have multiple IJ windows open :/

[echo canyon]

so https://jd.papermc.io/paper/1.20/org/bukkit/plugin/java/JavaPlugin.html#onEnable() still doesn't work

it keeps the #onEnable(), but it doesn't keep the org/bukkit/plugin/java/JavaPlugin part. @spice temple

oh wait, was your PR not merged? I thought it was since the #onEnable() part was being kept

[echo canyon]

ok, I think this is a good bit for brig API docs https://docs-cmvikok3y-papermc.vercel.app/paper/dev/commands

[drowsy zinc]

I submitted a docs pr that uses the version without redirects

[spice temple]

wat

why

how

well, yeah, lol

my PR isnt merged yet ^^

will work on my open PRs for javaducks and docs later today

[shut delta]

Should there be an example of how to add an argument to the command? That isn't shown in an example yet and I would think an example could be useful.

[spice temple]

already added a review command about that earlier ^^

https://github.com/PaperMC/docs/pull/386 in case you wanna add anything else

[shut delta]

Hmm alright, only saw the review about the BasicCommand example (https://github.com/PaperMC/docs/pull/386#discussion_r1597991624) but nothing about arguments. Maybe I misunderstood this comment though

[spice temple]

oh maybe I missunderstood

I guess my comment below that goes into that direction, but doesnt hurt to add another comment 🙂

[still apex]

ollie breaking docs

[neon epoch]

No, Riley merged it

[neon atlas]

Sounds like Owen is breaking docs

[still apex]

how exactly is it broken

[neon epoch]

so its not broken, but when we version for 1.21 it will not work and place 1.21 versions into the 1.20 docs

[drowsy zinc]

iirc it didn't do that before either

[neon epoch]

Pretty sure it did, i remember testing it at the time

[drowsy zinc]

there was some logic to extract the version from the current url but it was never used

[neon epoch]

https://github.com/PaperMC/docs/pull/387/files#diff-b81ee8e042db5d517db6b6ff8387946d280ec7bad456bde240ab78b8cb61b3b6L52-L73

I mean it worked at one point when i tested it

I extract the version from the URL (definitely a better way of doing this i think) and then if it matches, take the highest from that version group

[drowsy zinc]

I see it now

I was looking at this.currentURLVersion

[spice temple]

so we dont need to revert?

if its gonna be an issue in the future, we need an issue on the repo so we dont forget

[neon epoch]

I mean in an ideal world the repo would be reset to bba4d0416132280e370f24eed4f5c158494bea27 and then scorp could reopen their PR, but i can't force push last time i tried so if you wanna do that Mini you are welcome to

its not an imminent issue though, just needed some more work before merging

[neon atlas]

just push a revert commit?

[neon epoch]

ugh just the idea of 5 stupid commits cause of the revert annoys me

[neon atlas]

idk, force push to master sounds like a not smart move

[neon epoch]

hey, i do it all the time

[spice temple]

I don't mind force pushing

[neon epoch]

cool

[spice temple]

Gimme a sec

Need to mentally prepare leaving my couch

[neon epoch]

Yeah no worries lol, i'm in the library till tonight

[neon epoch]

isn't it monday? :P

[spice temple]

I left work at 1 today because I didn't feel like doing stuff, lol

I did get my car cleaned and I did chill in the park tho

[neon epoch]

they don't care that you just leave?

[spice temple]

No?

I work whenever I want, lol

[neon atlas]

ollie with the american grindset

[neon epoch]

is it more of a "as long as x hours are done it doesn't matter?"

[spice temple]

I clock in and out, my contract says I need to work 7.6 hours per day, but I can go down -20h and +50h

[neon atlas]

I mean, usually its more like "is feature x done"

at least on my end. Results matter more than the time you put in

[spice temple]

You don't track time? That's illegal in the EU, just fyi, lol

[neon atlas]

I do xD

but like when that time happens is not really important, at least to me

[spice temple]

Oh, yeah

[neon epoch]

ah ok fairs. my only real work experience is (1) mcdonalds (2) a web dev company that did 9-5 mon-fri

[spice temple]

I can work from 6 to 22 and if I ask nicely I could even work on Saturdays

I can also work wherever, I have a coworker that sometimes rents a cabin in the woods and works from there, lol

On my last vacation I met a girl who worked for a bank in London, did half days for her whole vacation, lol

She would chill in meetings next to me at the pool

I wouldn't recommend doing that, that's not what work life balance means, but still, perks of working in IT

man I hate non linear history

pushed

[echo canyon]

Wait why a force push?

[neon epoch]

to remove a PR merge

[spice temple]

to revert

@drowsy zinc you can reopen your PR

[ancient quiver]

cant you just do a revert commit?

[neon epoch]

^

[ancient quiver]

ah

[lean venture]

what's being reverted?

[neon epoch]

https://github.com/PaperMC/docs/pull/387

[ancient quiver]

can't you just revert the merge commit only?

[spice temple]

idk, I don't know how non linear history works

[neon epoch]

probably it just fucks up the commit history

[spice temple]

plus its fixed

time to look at my javaducks PRs again

[drowsy zinc]

my fork's main branch is done for

[drowsy zinc]

reopened as draft, I'll actually fix it in a few hours

[spice temple]

just delete it and check it out again

[drowsy zinc]

i'll just hard reset it and force push

[spice temple]

both https://github.com/seiama/javaducks/pull/15 and https://github.com/seiama/javaducks/pull/4 should be good to go now

[lean venture]

th is javaducks

[spice temple]

the software serving the javadocs

[lean venture]

OH

ok

that reminds me again I still haven't worked on BetterJDocs 💀

[spice temple]

thoughts?

now to actually implement that, lol

[raw breach]

looks nice another thing i could imagine looking nice would be having it be "pop up" on the header bar

[spice temple]

that would look weird on mobile I assume

[raw breach]

oh yeah

didn't think about mobile

[spice temple]

its also harder injection wise, harder to look good, etc

[gilded sparrow]

What's with the rounded border?

[spice temple]

edge

[gilded sparrow]

ah