docs-website

[drowsy zinc]

https://docs.papermc.io/paper/dev/userdev#why-this-is-useful

The Paper server jars we provide on the downloads page through the API are paperclip jars. These use Spigot's mappings, which are essentially some type names, but fully obfuscated fields and methods. This can make it hard to work with in a development environment.

shouldn't this mention that you can't even shove a paperclip jar onto your development classpath?
since you'd have to run it first, get the patched jar and whatnot to even access the reobfuscated classes

[still apex]

Maybe an idea to somewhere note how to download the javadoc if it's not automatically downloaded

[eager plover]

Yea, probably something to slap on the general project setup page

[neon epoch]

Make an issue please 🙏

[still apex]

make me

[jagged pecan]

sudo -u powercas_gamer gh issue create --title "add info on how to download javadoc" --body "from discord"

[neon epoch]

Ew

[jagged pecan]

what bit

gh cli?

[lilac edge]

oh hey it worked

[neon atlas]

[neon epoch]

Yeah lol

[lilac edge]

gh pr checkout <pull-request-number> my beloved

[neon atlas]

🙏

[jagged pecan]

now there is just a ghost ping here probably

[sinful hare]

shh

[lean venture]

just got an answer after 1h of my response, they escalated the ticket priority into one of the internal teams

not bad for discord support...

5min initial response and then 1h

not bad

[jagged pecan]

wrong channel? @lean venture

[lean venture]

yes hahaha

[drowsy zinc]

enjoy ollie

[still apex]

it broke my github

https://i.imgur.com/slEwYNS.gif

[neon epoch]

It also fails CI @drowsy zinc lol

[still apex]

JARs looks weird

[drowsy zinc]

oop

I didn't get errors locally

[neon epoch]

yeah it doesnt unless you build

thanks for fixing it, we are debating the capitalisation of Vanilla

[drowsy zinc]

lots of things are debatable yea

[still apex]

You've used it yourself in your prs https://github.com/PaperMC/docs/pull/289/files

[neon epoch]

just cause i did i, doesnt mean it is right 😂

[still apex]

@neon epoch JAR is correct

nerd

https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jarGuide.html

[neon epoch]

cool

resolved those

[still apex]

github needs a nerd emote

[still apex]

I broke something https://i.imgur.com/gwhDiu2.png

[rigid bluff]

feature ?

[still apex]

stealing my idea smh /s

[lilac edge]

:P i was thinking about how to do it this way since i saw you messing with patches

eventually i was looking at facebook/docusaurus/#3592 where i stumbled upon facebook/docusaurus/#6218 where one of the maintainers left a comment explaining exactly how to add new metadata

i can give you perms to my repo if you'd like to tackle the patches again lol

or even anything else - i've been experimenting with this for longer than i wanted

[still apex]

@lilac edge not sure turning the author into a hyperlink would work

unless there’s a way to get the github account

[cursive portal]

https://github.com/PaperMC/docs/pull/348

[still apex]

is that the vanilla default resource pack?

[cursive portal]

what resource pack?

[still apex]

in the screenshot

[cursive portal]

yeah

[spice temple]

the font?

that doesntlook vanilla and its kinda hard to read

[cursive portal]

wdym

[still apex]

it’s hard to read

the screenshot the font

[young matrix]

this screenshot https://raw.githubusercontent.com/PaperMC/docs/7185d6b2c6f337c01ce31429d6192542faedba74/docs/paper/admin/reference/assets/example-item-dump.png

[cursive portal]

Ohhhh. I forgot abt that ss

This is the pack https://www.curseforge.com/minecraft/texture-packs/mythic-a-pixel-art-journey

it makes mc very diffrent

[still apex]

make a screenshot with the default resource pack

[cursive portal]

Ill do it tomorrow. Its 1 am. I need to sleep

[lilac edge]

oh you're so right

[lilac edge]

looks like there's a way to hit the gh api with someone's email & gh will return a user that has that email registered to their account https://stackoverflow.com/a/44888528

[neon epoch]

This is fine if it’s done at static build time as I suspect it probably is. Otherwise that’s gonna be pretty hot. Something to consider I suppose. Obviously we would cache them

[neon epoch]

Looks like a good start, thanks!

[lilac edge]

grabbing github username from commits is done; i've also implemented a basic cache but it doesn't seem to be actually doing anything lol

if it did work we'd still need to use a github token of some kind cause ratelimit is 60 requests per hour and 42 are needed with a working cache

here's the log after running yarn dev with the logs shown in this image (not commented out and with the env check removed) https://pastes.dev/g8Ls72rFCS

without the cache that'd be around ~129 requests..

[still apex]

could also be more requests if multiple prs get merged right

could also fallback to the git name if we hit a rate limit

[lilac edge]

not necessarily - just checked both failed builds and they're on different ip addresses (default is 60 requests per hour per ip address)

[vocal halo]

Is this all for usernames or for commits?

[lilac edge]

solely usernames

[vocal halo]

Do we really need that? If we have a link to the commit the username will be there.

[lilac edge]

that'd probably be the smart thing to do yeah

everything about getting the gh usernames is over the top for what we want

[vocal halo]

Can’t we only fetch those usernames if the site is loaded for the first time? Not directly on build.

[still apex]

would mean every user would request it no?

[vocal halo]

It probably wouldn’t work since it’s a static page anyway

[lilac edge]

fetching dynamically seems to be working really well tbh

i'll push that as the solution for now until/unless we decide to scrap hyperlinking the author

deployed: https://docs-ogji0fvji-papermc.vercel.app/

[vocal halo]

Every page has been updated by Ollie in the docusaurus update commit

[lilac edge]

which doesn't make any sense

let me start up the dev again.. i remember it showing properly for each page when i flipped the dev env check

[vocal halo]

I mean if there are changes internally it’s probably because of that

[lilac edge]

it should be looking at the file changes specifically

like commits that change a file

https://docs-ogji0fvji-papermc.vercel.app/paper/dev/how-do-plugins-work someone that isn't ollie lol

[vocal halo]

It’s also the case on the prod

[lilac edge]

yup - works properly when disabling the dev check

so it's a bug when building for prod

[vocal halo]

Is the dev check in prod?

[vocal halo]

Where exactly do you see that it works?

[lilac edge]

local

[vocal halo]

„It says simulated during dev“ on the one and shows Ollie on the other

[lilac edge]

cause i didn't flip this check

[vocal halo]

I see

[lilac edge]

hold on i'm building locally as well

running the build command locally has it showing properly...

oooh i have a theory

nevermind, i already busted that theory

i wonder if it happens on github actions as well

[vocal halo]

Did you already push the changes?

[lilac edge]

which ones? the ones in the last 3 images i sent?

[vocal halo]

Yes

Didn’t you say it works for you now?

[lilac edge]

i can see why you're confused

pushing that change won't fix the issue

[vocal halo]

So you say the build works locally but not on vercel?

[lilac edge]

yes

[neon epoch]

Mmm this is weird. I think remove the ping to GitHub API - could even make the name just link to the commit?

[lilac edge]

you don't like the current solution of dynamically updating the username by having the end-user hit the github api?

[neon epoch]

personally it’s better, sure. Idk lemme have a think about it

[lilac edge]

on another note, figured out why the last updated isn't accurate - apparently vercel only fetches the git history at a depth of like the past 3 commits. that makes the last updated feature not accurate at all. Setting an VERCEL_DEEP_CLONE environment variable to true should fix it.

[eager plover]

I've just set that on the docs repo

[lilac edge]

worked in the PR preview 🎉

really weird how hidden that variable is

[eager plover]

vercel in general has a lot of weird edges

I don't want to crap on people who give us free stuff, but, sometimes their platform is just weird

[neon epoch]

is it not possible to generate this statically at build? What was the issue with that again?

[lilac edge]

• github ratelimit for unauthenticated requests is limited to 60 requests per hour
• with a working username cache, each build would only use ~42 requests
• the username cache i created didn't work... #docs-website message - without a cache it'd be around 129 requests on every build

if we want to continue with generating this statically at build, then the only viable solutions are

1. get the cache working somehow (optimal, technically not required)
2. use a PAT GitHub token that's set through a vercel environment variable

PAT tokens have a rate limit of 5,000 requests per hour, so that would mean you could

• push around 38 commits in an hour with no issues (without username cache)
• push around 119 commits in an hour with no issues (with username cache)

[neon epoch]

is this a free token?

[still apex]

yes

[lilac edge]

you could probably create a PAT token with no scopes set and it'd be fine

using the classic route you can create a token with no expiration (GitHub's trying to push their new token creation page that's in beta where expiration is required)

on another, another note, should i remove the octokit package and replace it with a basic axios http request? do you see any chance of using octokit in the future?

[lilac edge]

i don't like how big yarn.lock got from adding it so i'm debating on removing it

[neon epoch]

yeah thats fair, it should be a fairly simple axios request

[still apex]

is it possible to edit an existing yarn patch

[lilac edge]

when i tried it ended up just creating a new patch that based off of the existing one

[still apex]

i turned the git thing into a patch no clue if it works though

git util

[lilac edge]

fingers crossed

[still apex]

is docusaurus utils exposed? vscode can’t find the function

[lilac edge]

yarn patch @docusaurus/utils@npm:3.2.1 should work

[still apex]

nah i got the patch

[lilac edge]

oh you mean internal

yeah

[still apex]

i meant in the config

where you use it rn

[lilac edge]

uuuh let me remember what the import is

import { getFileCommitDate } from "@docusaurus/utils/src/gitUtils"; would be to get the pre-existing getFileCommitDate method

[shut delta]

Am I missing something or why is the API request necessary to fetch the GitHub account? Couldn’t you just take the commit author and turn that into a GitHub link?

[still apex]

not everyone’s git name is their github username

[shut delta]

Didn’t realize that

[still apex]

9/10 chance it breaks

(saving this here for later) /tmp/xfs-aef6ca5c/user

works

[lilac edge]

hell yeah

[still apex]

how do you want to do

split the shell execution out into it's own method to make it easier to recreate getFileCommitHash`

also do we need to do translations for it? Since nothing else on the wiki is translated

[lilac edge]

i think i have an idea; let me try something

[lilac edge]

technically no - i only added it for consistency sake with the other components

[still apex]

Could probably split this out into it's own function and add a arg thing

if (!hasGit()) {
    throw new GitNotFoundError(
      `Failed to retrieve git history for "${file}" because git is not installed.`
    );
  }

  if (!(await fs.pathExists(file))) {
    throw new Error(
      `Failed to retrieve git history for "${file}" because the file does not exist.`
    );
  }

  // We add a "RESULT:" prefix to make parsing easier
  // See why: https://github.com/facebook/docusaurus/pull/10022
  const resultFormat = "RESULT:%h";

// make this an arg
  const args = [`--format=${resultFormat}`, "--max-count=1"].filter(Boolean).join(" ");

  const command = `git -c log.showSignature=false log ${args} -- "${path.basename(file)}"`;

  const result = await new Promise<{
    code: number;
    stdout: string;
    stderr: string;
  }>((resolve) => {
    shell.exec(
      command,
      {
        // Setting cwd is important, see: https://github.com/facebook/docusaurus/pull/5048
        cwd: path.dirname(file),
        silent: true,
      },
      (code, stdout, stderr) => {
        resolve({ code, stdout, stderr });
      }
    );
  });

  if (result.code !== 0) {
    throw new Error(
      `Failed to retrieve the git history for file "${file}" with exit code ${result.code}: ${result.stderr}`
    );
  }

[lilac edge]

that's what i was thinking

[still apex]

https://yarnpkg.com/features/patching

--update

[neon epoch]

yeah but only on newer yarn

[still apex]

what's stopping us from updating

[neon epoch]

i just mean

than i have locally

but, nothing

[still apex]

what yarn version

[neon epoch]

idk i think its like 4+

[still apex]

is that stable

their docs suck

[neon epoch]

no clue, but probs

[still apex]

https://github.com/yarnpkg/berry/releases/tag/%40yarnpkg%2Fcli%2F4.1.1

[lilac edge]

https://github.com/PaperMC/docs/pull/347/commits/f4923cc81518689843e7d24ae87c9060b8a1b77f

https://tenor.com/bxvUX.gif

[fair river]

Thank you for taking an interesting in contributing

[still apex]

where is my thank you???

[south thunder]

You're welcome powercas

[fair river]

You get a kiss from Ollie

[eager plover]

using the standard javadoc task as provided with gradle

no, yes

it's just the javadoc tool, if you wanted anything else, you'd need a different tool

[neon epoch]

What the fuck eternity

[still apex]

@lilac edge did --update work for you?

for the patch

[still apex]

replaced octokit

[young matrix]

is there a reason to not do it at build?

because calling the github API on every page load is... not ideal

[lilac edge]

this message and the one below it

ugh

wait

#docs-website message and the one below it @young matrix

[lilac edge]

nope

[young matrix]

would definitely go for token in build env and just use dummy data if the environment variable isn't set

and you can even just have it run on commits to main if you're concerned about hitting 5000

[lilac edge]

sounds good to me

i want to fix the caching as well but i'm kind of stumped w/ it

[still apex]

Whats wrong with the cache?

[lilac edge]

the first console log runs for every page, then it seems like all the gh api requests get batched & finally the second console log runs. since the gh api requests are batched together, they don't end up waiting for the previous page to process the gh request before running so the cache doesn't end up working

i want to sleep for more than 4 hours but i can't go back to bed because i thought about this too much

[lilac edge]

some changes

• uses custom axios instance instead of fetch
• uses octokit typing instead of custom GitHubStuff class
• moved username fetch back into parseFrontMatter
• no longer crashes deployment if hitting ratelimit; currently spams an error but it can be ignored

1. will probably give up with the username cache if moving it into the axios interceptor doesn't work
2. do references to env variables in docusaurus.config.ts get embedded into the build somewhere? can i safely call e.g. process.env.GITHUB_TOKEN inside parseFrontMatter()?

[neon epoch]

Sounds good, as to the last point I do not know. Someone else may tho

[rigid bluff]

Ollie how complicated would it be to make a starter for Paper like Spring ?

Ex: https://start.spring.io/

Or rather, is there interest in something like this for paper for 3Party Dependencies? Or is this rather a project for hangar

[neon epoch]

I mean, not super hard, but like again not sure where this sort of tooling belongs

With the MCdev plugin though, this seems somewhat redundant

Oh but this would be for server creation

[lilac edge]

oh i also thought this was for paper plugin creation

[neon epoch]

Oh maybe idk im running low on brain

[lilac edge]

nah i'm saying i thought so as well

them asking in regards to server creation does make more sense

[rigid bluff]

It's just a draft idea for plugin creator or sever creation

[jagged pecan]

if it was for server creation, it would end up recommending plugins (indirectly?) and probably be a no-go?

although it would be cool to use chromes fs api

to like generate the stuff directly

[lilac edge]

server creation might make sense with the template config discussion

[neon epoch]

For server creation I was just thinking you could use hangar api to allow the auto-adding of plugins from hangar directly.

[jagged pecan]

ah true

[rigid bluff]

That nice with a search

Maybe at hangar a plugin creation tool for the developers

[vocal halo]

Dont see the need of a paper starter website

I understand that we need to provide the user the best experience but if they are even too unfamiliar with how to download plugins and put them in the correct folder they might not be ready for this.

[lilac edge]

axios interceptor on request doesn't work

[lilac edge]

nevermind it works :)

[still apex]

@drowsy zinc

How do you add a ignored word to the stupid spellcheck

[lilac edge]

it's case insensitive

we have canceled = "cancelled" which takes priority

[still apex]

https://github.com/PaperMC/docs/pull/347/files#diff-cc8abb6104e21d495dc8f64639c7b03419226d920d1c545df51be9b0b73b2784R148

ah

[lilac edge]

why was gitattributes removed

[still apex]

idk some random thing added it in my commit

https://github.com/PaperMC/docs/pull/347/commits/67d9ad9152d64d0f94f6542d11352ea0eda91895

[lilac edge]

weird

~42 cached commits with ~47 requests isn't too bad

some requests end up ignoring the cache

[still apex]

could always just add some token if needed right?

[drowsy zinc]

it should be an identifier, not a word

[lilac edge]

yuppers, some random PAT token with no scope assigned to GITHUB_TOKEN in vercel should work

[lilac edge]

oooh i understand

doing ID = "ID" feels weird but i'm sure there's a reason behind it

[drowsy zinc]

it's just how the spell checker's configuration works

[still apex]

@lilac edge it's [ci skip] btw

[lilac edge]

bleugh

[neon epoch]

Looks like I have a lot to review

[lilac edge]

dw i realized i was being stupid with the caching stuff - it'll work properly once i push my changes

[neon epoch]

Oke

[lilac edge]

caching seems to work properly

impl now creates an array of all md/x files, loops through them to get the commits for each page, removes duplicate commits, then parses the username from each commit

i updated the todo list in the PR description with more items

[still apex]

yarn run build gets me ratelimited

[still apex]

Not quite working for me

nvm? @radiant summit is broken

[neon epoch]

Yeah prod got rate limited it seemed

We just need a key

[still apex]

nah it's just his profile

http://127.0.0.1:3001/paper/anti-xray on this page
http://127.0.0.1:3001/velocity/built-in-commands and this

can you reproduce locally?

[jagged pecan]

where do you specify the github key?

[still apex]

it’s only on nacio’s conmits

[jagged pecan]

ah its just an env var

yeah ive got the pr checked out

[jagged pecan]

or is that its not fully pushed?

[still apex]

wdym

[jagged pecan]

nvm ive confused myself

[still apex]

I'm using the latest commit except I remvoed some debug calls

okay wtf? now it's fine

may have been ratelimited ig, even though afaik it should've had the token

unless the IJ terminal didn't refresh for my token

stupid prettier

[drowsy zinc]

my actions work so good

[still apex]

not spellcheck

[drowsy zinc]

both are mine :p

[still apex]

how do I properly setup a precommit hook for this

oh they have docs on it

[jagged pecan]

looks like its doing a weird thing (im not on very latest commit), where its fetching from cache before the cache has been built? idek

[drowsy zinc]

why is the function at the end of the patch doubly declared like that

and what's up with the patch being applied for @docusaurus/utils@3.1.0

[still apex]

that's where gitutils is in

[still apex]

wdym

[drowsy zinc]

in both @docusaurus/utils@3.1.0 and @docusaurus/utils@3.2.1?

https://github.com/PaperMC/docs/pull/347/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R74-R75

[still apex]

that's what yarn does 🤷‍♂️

[drowsy zinc]

that seems wrong

[still apex]

talk to yarn

[drowsy zinc]

https://github.com/PaperMC/docs/pull/347/files#diff-cfaf8b4775beb3eee67c7323282dc55b8e4d33285630b9caab43a7e7342a9722R104-R128

[still apex]

no clue

is there anything stopping us from updating yarn

[drowsy zinc]

don't think so

[still apex]

https://i.imgur.com/iikVQJN.png

[eager plover]

Think somebody would need to bump it on vercel?

I forgot what the thing was

[drowsy zinc]

I mean it's defined in package.json

[eager plover]

oh, yea, should be fine

I thought that there was something that needed to be hit on vercel but apparently not

[drowsy zinc]

that doesn't look like you're updating only yarn

[still apex]

idk i did yarn set version stable and yarn install

https://yarnpkg.com/getting-started/install

[drowsy zinc]

you can probably also yeet yarnPath from yarnrc and the .yarn/releases folder, since corepack is the preferred distribution method now

[still apex]

i may have fucked up the rebase

[green kernel]

git reflog at your service.

[lilac edge]

it is

[still apex]

yarn automatically does that every time I create a patch for that thing

[lilac edge]

huh

weird

[lilac edge]

i redid the rebase and made it a merge instead

[still apex]

vercel failed

[lilac edge]

i think it's cause i regen'd the yarn.lock instead of taking the one from main

built

[lilac edge]

it's cause we run the cache in docusaurus.config.ts, and docusaurus grabs the config in two other places

i stuck a console.trace() at the start of processing() & stuck one in parseFrontMatter()

^ on desktop pop out the image in browser and zoom in - mobile preview should work fine

either processing() needs to be moved somewhere else or we somehow figure out a check for if it's being run before parseFrontMatter

[jagged pecan]

Had to use mobile browser too, discord decided what I recalled wanted was 5 pixels per line 💀

[lilac edge]

cringe

for now i'm doing this dirty hack to circumvent it

[lilac edge]

works surprisingly well

author data actually properly caches this time. if the request gets ratelimited then the author name doesn't get hyperlinked

@neon epoch ready for review

[neon atlas]

[vocal halo]

pog

[neon epoch]

I love reviewing PR’s!!!

Very nice work though, I’ll see if I get time to go through it tonight around the pub

[neon epoch]

@vocal halo no it should be plural

But thanks ;)

[vocal halo]

Interesting

[neon epoch]

You could say either as far as I am aware, maybe one is more formal than the other however it’s a debatable different

[vocal halo]

Im not the native speaker here. It just sounds wrong for me tho.

[drowsy zinc]

[neon epoch]

#1129091109742727228 message yaknow i think we just go british

[neon epoch]

thoughts @eager plover

[eager plover]

makes sense to me

all bow down to the mother land

[still apex]

@neon epoch

regarding the patch comment

[neon epoch]

Can we just nuke that?

[neon epoch]

Like if you delete the line and run yarn install

[still apex]

idk not home

[still apex]

@neon epoch I think there's something thats depending on docusaurs/utils 3.1.0

If I remove that patch line it adds @docusaurus/utils@npm:3.1.0 to package.json
https://i.imgur.com/piDPYDb.png

https://i.imgur.com/atgo9Wu.png

[drowsy zinc]

could probably use the official plugin now: https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-vercel-analytics

also, iirc the new yarn version now complains about unmet peer dependencies, someone should probably fix those

I tried to fix them, but adding webpack to devDependencies makes the whole thing come crashing down

the other two can be fixed with yarn add -D @types/react esbuild just fine though

[still apex]

should probably be done in another PR right?

[drowsy zinc]

could be in a generic dep bump PR

yarn upgrade-interactive has some available newer patch/minor versions

[shut delta]

<@&748618676189528155>

[drowsy zinc]

uh, someone would need to enable corepack on the vercel project for my PR to build 😅 (https://vercel.com/docs/deployments/configure-a-build#corepack)

[still apex]

no

[opal flare]

done.

[drowsy zinc]

❤️

[opal flare]

perhaps we can look into migrating off of yarn too

[lilac edge]

what would be the alternative

[opal flare]

pnpm

papermc/website uses it

[lilac edge]

for consistency sake it'd probably be good

[still apex]

stop stealing my ideas

[drowsy zinc]

personally I like yarn's cli

but more people know npm/pnpm, so it's more accessible

[neon epoch]

My vote is for yarn

[still apex]

you can’t vote

[neon epoch]

Watch me

[jagged pecan]

really tempted

[still apex]

@neon epoch outvoted

[neon epoch]

Maybe you could elaborate on why we should migrate @opal flare ?

[opal flare]

#docs-website message

[vocal halo]

What does hangar use?

[drowsy zinc]

pnpm

[vocal halo]

im sorry Ollie

[spice temple]

Pretty much the entire ecosystem converted on pnpm

But core pack means you can use yarn to run pnpm I guess, lol

[drowsy zinc]

corepack supports pnpm by itself

[drowsy zinc]

if it's been decided upon, I could push it up to my existing PR

[opal flare]

Go ahead

[neon epoch]

@vocal halo RE your PR, the Config component was renamed to src/components/config/ConfigDocBlock in main, will need a main merge. I like the idea of listing the config options that need to be set specifically, just needs padding out but looks great so far! (I know its still a draft :) )

[vocal halo]

Yeah I was working today during shift

It would be great to get input from more knowledgeable people though

Like earthcomputer listed features that weren’t listed in the initial changes from the other author in the initial issue and the other way

And they also said “up to you to what you set it” a couple of times

But idk what would be the best to get as close to vanilla as possible

@nova pawn

And what do you mean with “needs a padding out” @neon epoch

[neon epoch]

as in some explanation of what you are trying to accomplish in text before and after if that makes sense

what is the commit "1b3d5f7" btw @lilac edge @still apex

[drowsy zinc]

it's fallback data

https://github.com/PaperMC/docs/pull/347/files#diff-71b26c135eb99f3a007f194403854cb0f77139bce7d16115de8bd2c39f44baa3R28

[neon epoch]

Yeah i know it is, but what is it lol

is it just a random string or does it mean something

[jagged pecan]

1b3d5f7
1234567
abcdefg

[neon epoch]

thank you

😂

[drowsy zinc]

😂

[neon epoch]

im properly reviewing the username and commit PR, i didnt realise we fetch the username by commit lol, surely it would be better to do that by email or something. so like the email that they commit with, we store the username from github associated with that, and can then fetch from the cache locally. just an idea

[lilac edge]

it'd be the same thing in terms of requests

email would be less reliable as well since they're easily changed

[vocal halo]

I think it needs a lot of outside input

In order to be merged

[neon epoch]

fairs.

[vocal halo]

I’ll finish the foundation soon

From then it need input of people that know what changes to vanilla have been made

I also think about providing a download link for the modified configs

But I’m not sure

Especially all rewrites by leaf need more input

[nova pawn]

can you give me an example?

the thing is, when players say they want the game to be as close to vanilla as possible, unless they're anarchy players, they don't normally mean that

what they mean is that they want to keep the mechanics that make the game fun for them, but they don't care if for example some random book ban exploit is fixed

[fair river]

Do we really need to clarify what "vanilla gameplay" means here

[nova pawn]

so there is actually a difference between what is technically the most vanilla config, and what I believe server owners who care primarily about vanilla gameplay should set things to

[fair river]

I can see some player who think bookban exploit is considered Vanilla

[nova pawn]

as part of the technical community I believe I am well placed to decide which exploits will be missed and which won't.

[ocean void]

I don't think we want to start to have subjective decisions.

If we're making changes to "have vanilla parity" then we should adhere to actual vanilla, rather than someone's intepretation of it.

Because that interpretation can vary, sometimes wildly.

[nova pawn]

vanilla parity means all of vanilla's vulnerabilities

there are vulnerabilities that have literally no use other than to crash the server

[ocean void]

And there's the rub. How do we determine what is a vulnerability and what is a "feature"?

[nova pawn]

the definition I went by is pretty much "no use other than to crash the server"

I think that's a reasonable definition that I don't see any good arguments against

[fair river]

When creating documentation, the goal should be to make the intention of such guidance and the end results clear to the reader. Therefore, it is best to leave no doubt as to what the end goal is. I am all for making it as painfully clear as possible.

[ocean void]

I think there's still some wiggle room in there in which different people would disagree on where "no use" falls.

[ocean void]

Agreed.

[nova pawn]

what does "yse" mean?

[ocean void]

I'd be a large task but if every single tiny variation or deviation from vanilla were documented, that would be ideal.

[nova pawn]

if you want, I can go in and make a pure vanilla config with all the server crashing vulnerabilities left in (because that's basically all I left out)

But I don't see who the target audience of that config would be, aside from anarchy players who if they want to leave in exploits, well don't use paper

There is another category btw, optimizations which are not vanilla but known not to break any vanilla mechanics

Such as the redstone dust optimization

[lilac edge]

i honestly feel like that's a good idea. the config description could just have a warning in the config builder or a section can be made talking about all vanilla exploits that are fixed in paper

[nova pawn]

There is only one contraption I have ever heard of which breaks with the redstone dust optimization, and that is one I made specifically for the purpose of saying "hey I made a useless contraption which breaks with it"

Please link me the issue on github where this is being discussed

[neon epoch]

The concept of server presets was discussed here

[nova pawn]

I have updated the gist to clarify what to set these values if you want pure vanilla, with an explanation of what more realistically you would want the values would be.

Just going through the settings again to list the other non-vanilla values that I didn't think were worth changing

[vocal halo]

@nova pawn I want pure vanilla

No qol

No anarchy

Not set it like you want

Just pure vanilla

And @nova pawn did you look into the changes listed by the other user a few months ago?

[nova pawn]

I have edited it again because I realized I missed something

[nova pawn]

This is my goal here, but you have to read each individual item where I explain what value is vanilla (or as close as vanilla as possible)

Under QOL changes I explain what value is vanilla and it is only a suggestion to change it

[vocal halo]

Yeah but you wrote like “this is up to you” under a lot of settings

[nova pawn]

Have you read my updated gist?

[vocal halo]

Nope

[nova pawn]

Please do that

[vocal halo]

I will

I’m not at home right now

[nova pawn]

I don't want to hear any more complaining until you do

[vocal halo]

I just complained based on the state that I know.

Or

I didn’t even complain…

I just said it would be nice

[lilac edge]

[nova pawn]

Okay I have now gone through and added all the settings which make it pure vanilla even enabling blatant exploits

(they are still clearly marked as such but at least they are listed for you)

My hope with this gist is that you can refer to it in order to create suitable presets that will make players happy 👍

It's not intended to be a preset itself or to decide for you what you want, it's just that I have now done the research for you basically

[neon epoch]

Thank you for your work @nova pawn

[still apex]

yes

[neon atlas]

thank you

[fair river]

[vocal halo]

Thank you earth. Sorry if I came across rude yesterday 😕. Really appreciate your effort.

[rare bolt]

Hello, does anyone know how to use colors in Translations?

https://docs.papermc.io/paper/dev/component-api/i18n

Bukkit.broadcast(Component.translatable("timer.countdown", Component.text(resume)));

[rugged bay]

an entire translatable can only have one style, though the placeholders can each have their own styles afaik

[rare bolt]

So it is not yet possible? Or I have to parse it as a MiniMessage, right?

[eager plover]

You would need to use MiniMessage

(the built in translation stuff only really works with raw text, and so anything fancy really needs to be handled by something able to deal with being fancy, i.e. MM)

[still apex]

there’s a minimessage pr for translation stuff

[serene vault]

its somewhat broken if you have multiple nested ones though. I kinda fixed it here and here but its a terrible fix lol

[neon epoch]

@lilac edge i have gotten riley to add a GH token to vercel (thanks riley ), and redeployed your branch, so you can now see what it looks like in prod. Are you happy with the final state?

[lilac edge]

yeah it LGTM - just gotta make sure the cache only runs when vercel is building for prod, not preview

[lilac edge]

cache no longer runs in PRs

if you merge the pnpm PR first i can fix up any conflicts like the second patch

[neon epoch]

done

[drowsy zinc]

[lilac edge]

@neon epoch ready to merge

[neon epoch]

Thank, I’ll look tomorrow afternoon / evening

[still apex]

i also worked on this )= https://i.imgur.com/LyryUCO.png

also @neon epoch

// Only Render in Production and not cache in every invocation of importing docusaurus.config.ts

[neon epoch]

apologies the box got cleared by a plugin i believe, and I dont have permission to force push to fix it

[neon epoch]

what about it?

[still apex]

Render
Production

casing

[neon epoch]

oh, bleh

But thank you for all your work on it too, cas

[fair river]

Yes thank you cAs

[vocal halo]

nice work granny and cas

[spiral dew]

I cannot access papermc.io, it seems it blocked my ip, where can I find help for this?

[small harbor]

if you're not getting an access forbidden message from cloudflare

nothing we can do, likely an issue on your end

[radiant summit]

do we not have any docs for receiving plugin messages on Paper?

[neon epoch]

We do

[odd harbor]

https://docs.papermc.io/paper/dev/plugin-messaging

[lean venture]

Doesn't it simply work the same way as spigot?

[eager plover]

Yes

[spice temple]

We don't want to rely on outside documentation that may or may not be around in the future

[eager plover]

||shut up ollie||

[neon epoch]

valid

[eager plover]

I was debating on starting a redo of the velocity docs, but, I just realised that I'm so dead, I think I'm going to camp on the sofa instead

[neon epoch]

heres an idea, write the docs on the sofa

[eager plover]

I wanna like, basically setup a velocity server from scratch as I do it

[neon epoch]

sounds smart

[neon epoch]

How do you like those apples #1135137683023339521 message

[still apex]

what messGs

[still apex]

Whhy does the paper plugins page use 2 spaces for the examples and the plugin.yml page 4

@neon epoch your fault

(and phoenix' since they prob used find & replace)

[inner kestrel]

the organisation of the docs site rubs me a bit the wrong way

it feels a bit overly nested for lack of a better word

[fair river]

I think that's on the "to-do" list somewhere but feel free to give your official feedback https://github.com/PaperMC/docs/issues so it doesnt get lost. if you have a general idea of how you think it should be organized, list them there too!

[drowsy zinc]

about #354, imo it should rather be simplified into a plain Markdown table, seems easier for other people to edit that way

or the table should at least be moved into a component, so it's all in one place

[fierce adder]

I kinda also wanna do what cat said, and remake some or all the velocity docs but I don’t think I have the time right now 😢

[spice temple]

ok who of your broke the docs?

smh

I hate that we patch dependencies, and I hate that pnpm isnt applying the patch?

[mental sleet]

(66253e7f2d5bd6481a06496b) // @sly mulch (@mr_pippi / 603482019485319168) has been banned by @spice temple (134340832093405184)
Reason: spam

[spice temple]

regenerating the lock file helped

[inner kestrel]

i was running into this earlier i just made that function always return lmao

[spice temple]

[ERROR] FileNotTrackedError: Failed to retrieve the git history for file "docs/misc/tools/minimessage-web-editor.md" because the file is not tracked by git.

this is also awful

opened https://github.com/PaperMC/docs/issues/357, cba to learn how to do pnpm patches

[lilac edge]

oh it completely crashes on error? that's cringe

[spice temple]

you know what else is cringe?

react

[inner kestrel]

my reaction coming to this project

[spice temple]

const [convertSuccess, setConvertSuccess] = useState(false); is just const converSuccess = ref(false) in vue

[neon epoch]

Talk to Facebook

[inner kestrel]

let convertSuccess = false in svelte if we want to fight over the js frameworks :p

[spice temple]

we should convert the docs to vuepress

[inner kestrel]

what does vue loop syntax look like again

{x.map(data => element)} is kinda dies in react

[neon epoch]

Last time I checked, vuepress code blocks are broken on mobile

[spice temple]

<li v-for="item in list">{{ item}}

[inner kestrel]

weird syntax but sure

[still apex]

github wiki just markdown

[scenic gull]

Depends on your point of vue

[inner kestrel]

apple docc is the obvious correct choice </half joking>

[spice temple]

Access to fetch at 'https://item-converter.papermc.io/convert-command' from origin 'http://localhost:3000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

mfw

kenny fix cors pls

[still apex]

since when is that a thing

[spice temple]

forever?

its cors, cant just post to random domains

[inner kestrel]

cors is about a decade old by now

[still apex]

no the page

[spice temple]

today, lol

why do you think am I playing with react, lol

[neon epoch]

Maybe wrap the whole thing in a box

Nice that you doc’d the web ui - our adventure docs link it already so maybe you could link to the misc page instead? Up to you

[spice temple]

sure

[spice temple]

ill just do the skeleton of stuff and you guys can figure out the details, you know more about the docs than I do

just wanted something to justify a tools index page

[inner kestrel]

why does docasaurus use its own utility css framework with basically nothing ,

the documentation for this doesn't even have search despite being built with docasaurus

[spice temple]

good enough for me
https://i.imgur.com/IJkGrkK.gif

[inner kestrel]

brigadier wasm to provide syntax highlighting and autocompletion /joke

[vocal halo]

this looks like you banned the person that broke the website xd

[spice temple]

🦹‍♂️

[vocal halo]

tools.papermc.io wen?

[spice temple]

https://github.com/PaperMC/docs/pull/358

[rugged bay]

Tools are on the docs site

[vocal halo]

yeah but not a documentation website is not really the place for random tools, is it?

[spice temple]

we could make that a redirect

[rugged bay]

I mean, it's that, hack it onto the main site somwhere, or write a whole other site just for like 2 tools

[vocal halo]

also this is an "insider" since someone mentioned it the other day

[spice temple]

but I dont really want to host another site people have to maintain

[vocal halo]

and now every time a new tool gets released i ask that

[neon epoch]

Write it :)

[spice temple]

no

[rugged bay]

^ isn't paper's infra complicated enough as-is lol

[spice temple]

we can make tools.papermc.io redirect to docs.papermc.io/misc/tools

[neon epoch]

Sure

[spice temple]

the infra isnt complicated? its normal kubernetes stuff

hosting the item converter was just adding two yaml files

dont have a good way to make it work on vercel since cors doesn't support wild cards for subdomains

I am done with this now, so if people wanna clean stuff up, be my guest

[small harbor]

WOOOOOOOOOO KUBERNETES

[spice temple]

also @last bear fyi, this is what I came up with

[last bear]

Noice

jmp is adding parsing for component arguments, so a dropdown with Command (default), Item argument, Component argument would be nice

[spice temple]

I had enough react for today, so somebody else do it (or maybe ill do it tomorrow)

idk why people do this voluntarily

[green kernel]

😄

[inner kestrel]

they don't

:)

everyone is being held at gunpoint

[fair river]

I like this already

[inner kestrel]

faceplant

[eager plover]

this is why I wanted a wiki, let the people work for their meal

[scenic gull]

I think the paper plugins guide should be buried, now, not after some big redesign, since it continuosly causes issues.

[inner kestrel]

continued faceplanting

[drowsy zinc]

not a fan of the icon spam in the sidebar

also, deleting those README.mdxes breaks existing links, someone might have linked to their pages expecting a list of subcategories

[south thunder]

Got a feeling that making them gray will ease the visual impact

[inner kestrel]

the icons r a bit large

they should be smaller but i need to figure out how to get vertical alignment going

ideally they'd be the same size as the text

[shut delta]

Why did you remove the expandable categories?
Not a fan of how it looks tbh

[drowsy zinc]

these pages need a description or the margin needs to be poofed when there's none, else it looks off-center vertically

[inner kestrel]

the toplevel hierarchy doesn't add much of value

especially factoring in the increased cognitive load that it adds to discovering and navigating to pages

this sort of concept is referred to under the umbrella of "information scent" if you want to learn more about it

[shut delta]

Fine, then they need to be separated more clearly. I don't know, increase the spacing, make the category name bigger, do something. It feels like one thing now when it clearly isn't (because you have the categories). Or, you know, add back the hierarchy

[inner kestrel]

what do you think the goal of "separation" would be

what does the documentation browser gain by inserting more space in between groups of pages

[inner kestrel]

can you note this on the pull request

[drowsy zinc]

ya

[shut delta]

I don't know. It's just that to me the current documentation layout with the hierarchy you removed feels better.
I mean, if I visit the current documentation as a new developer I see the expandable categories, "Getting Started", "API" and "Miscellaneous" and I instantly know where the documentation I search for is and upon expanding that category, I have a short list of pages where I can find what I need.
Sure, you didn't remove the categories, but you essentially removed those short, clear sections which I personally find really nice.

Maybe it's just me but I personally feel you shouldn't remove the expandable sections.

[neon epoch]

Had a chance to look through your PR @inner kestrel, Thanks for your work, it looks good. Im not liking how this page looks though ^

[inner kestrel]

that's uh not changed by the PR?

unless i missed something

[neon epoch]

yes it is changed significantly

[inner kestrel]

oops

[echo canyon]

idk what the backend of the itemconverter looks like, but should it be clarified that its updating from "1.20.4" to "1.20.5", not "<1.20.5" to "1.20.4"?

cause I assume its not gonna update itemstack nbt if I put a 1.8 item in there, like the game would update it

[vocal halo]

#1129091109742727228 message
Ah I didn’t know that. Was it already brought up to move the tools out of “miscellaneous documentation” into its own section?

[neon epoch]

The category is, yeah

[spice temple]

I assumed that's what it does since it goes thru data converter?

If it doesn't it should be clarified on my branch, ye

[neon epoch]

#1129091109742727228 message - oh some of the table cells need resizing to remove the text wrap @inner kestrel

[echo canyon]

But you don’t ever specify the version of the input nbt. So it can’t know where to run the conversion from

[spice temple]

Right

Feature request?

[still apex]

Can this somehow be changed to include whether it's from the paper docs or velocity etc?
https://i.imgur.com/FlLfly6.png

[neon epoch]

p sure this is an instance of https://github.com/PaperMC/docs/issues/282

Feature request!: https://github.com/PaperMC/docs/issues/360

[still apex]

owen should do that

he made the pr

[neon epoch]

owen cant write coherent javadocs, let alone a whole doc page

[neon atlas]

@burnt ice you got fact checked

[still apex]

it’ll be a fun review time

[neon epoch]

it would be worse than that time i wrote a whole page severely drunk

[burnt ice]

Oops

[vocal halo]

Is the component converter only supported to work on valid input?

[last bear]

It's not gonna work in the preview due to cors

[vocal halo]

If I type abc and press convert button becomes red and doesn’t give me an error message

(On phone if this makes a difference)

[vocal halo]

Alright it somehow didn’t show me your message xd

[inner kestrel]

can you put this on the github

busy ATM

[neon epoch]

https://docs-31tmcxbu2-papermc.vercel.app/paper/dev these long pages can get fairly hard to navigate on mobile due to scrolling - what do people think?

[still apex]

the icons are all different sizes

[inner kestrel]

what in tarnation

[fair river]

We should keep that. That looks funny for some reason

[young matrix]

I haven't looked at this at all beyond the image but it looks like the description width is larger for items with longer descriptions

so it makes the icon smaller

[inner kestrel]

i have zero idea why and how the svg is squashing like that

min-{width,height} fixes it

not me fighting with the typescript type system

[inner kestrel]

this mdx thing is really finnicky about syntax

[lilac edge]

is there something specific you're having trouble with?

[inner kestrel]

no it's just obtuse to work with

[fair river]

I am very happy all the web devs can hang out here to cope

[spice temple]

The error is only logged to console, couldn't figure out a nice but not complicated way to show it so just sticker to the error state (since we had a success state for the button already)

[inner kestrel]

i am getting Very sidetracked from an issue i wanted to tackle but i am having fun (you all should be scared of the PR you will be receiving in a few hours to a few days)

[inner kestrel]

[ redacted messages, very early WIP and not seeking further feedback at the moment ]

[vocal halo]

Looks over engineered

[lilac edge]

very much so

[vocal halo]

Simple markdown does the job like 90% of the other pages

[lilac edge]

that could be turned into a simple codeblock plugin that adds highlighting to lines in a codeblock if you surround text with a certain format

[opal flare]

(return 1; should be return Command.SINGLE_SUCCESS;)

[inner kestrel]

that looked weird to me but i was just copying examples from the PR lmao

[lilac edge]

actually, docusaurus already supports highlighting codeblocks and adding line numbers

then i'm confused

what's the benefit from this

[vocal halo]

All those steps seem to unnecessary bloat the page imo

Could reduce this to step 3 and 5

[inner kestrel]

further feedback will be accepted at a later moment as this is incomplete

[lilac edge]

i don't expect this to be used

[vocal halo]

I’d wait for @neon epoch to give his opinion about this before you invest more time into this.

[opal flare]

all I can see in my head now is ::::::::::::::::::::::::::::::::::::::::::::::::::::::::

[inner kestrel]

markdown syntax is bad moment

[vocal halo]

https://tenor.com/view/static-glitch-gif-11312357

Feels kinda like this ^^

[lilac edge]

i can understand not wanting input while it's still WIP, but i'd at least communicate with the maintainers on what you're doing / what your goals are in case the effort ends up being for naught

[inner kestrel]

not my first rodeo

[vocal halo]

If this is actually going to be pulled then it would require to rewrite all the current guides using codeblocks too. Having multiple designs is whack. It already annoys me that we have a different design to plugin.yml than the other configs but I didn’t get the time to change that.

[lilac edge]

worst case you gain experience making remark plugins & extract it into it's own repo so i guess it's fine

[inner kestrel]

1. it uses the same codeblocks as everything else
2. i already said that i am not accepting feedback at this time on what is very obviously an unfinished code with two counters and some 20 line components to its name (i have not even shared the concept i am implementing)

[neon epoch]

Hello

Why am I pinged

[drowsy zinc]

@neon epoch

[inner kestrel]

i have no use for either of these but that's how i like my programming

anyways i will continue losing my marbles tomorrow

[lilac edge]

alrighty lol

[neon epoch]

I’m very confused as to what’s going on but cool

[vocal halo]

Janet sent us a wip project she is working on. And I said that before she is investing more time into this you should give your opinion about it https://github.com/pontaoski/docs/commit/f30aafa1cdc1fd73a9746b824bf2679853d0f732

Since it looks quite over engineered

And :::::::::::::::::::::

[lilac edge]

it's too late now since she removed the images that showed what it looks like

it'll have to wait until it's more polished i guess

[eager plover]

First thing i see is that I question if it's too step by step

[vocal halo]

Yep

Also said that

Step 3 and 5 would do the job

imo

[neon epoch]

I found the images in message logs :P

[eager plover]

I mean, at least at first it has a few more steps that I'd expect for creating a template

[vocal halo]

But it’s generally about the whole „behind the scenes“

[eager plover]

if this was a day 1 OOP tutorial, sure

[lilac edge]

sneaky 👀

[eager plover]

The only thing is that I don't think it exactly explains interfacing with brig itself

[neon epoch]

I don’t think this is any better than using markdown

[lilac edge]

the actual tutorial being used should be ignored

that wasn't the point of sharing it

[eager plover]

oh, they more care about the infra, eeeeer

[vocal halo]

Yeah

It was the backend stuff that they wanted to show

[inner kestrel]

sharing that was a mistake

i will not be pursuing that because i do not like the behaviour on display here

[lilac edge]

shrug

[vocal halo]

Ok? You showed it and we thought you want input

And I said that in the end you should wait for Ollie what he has to say.

[opal flare]

We do appreciate your effort, and we always welcome new suggestions and ideas. If you decide to refine your idea further, feel free to open a pull request, and we’ll happily take a look at it and consider it fairly. There’s just no guarantee that it would be accepted.

[fair river]

Yeah @inner kestrel thank you for taking an interest

[neon epoch]

What eternity said! We love docs contributors (more than paper ones 🤭)

[sinful hare]

False

[still apex]

is it worth it to have a separate docs version for .5?

[vocal halo]

hm true

[still apex]

or rather have 1.20.4 be a versioned one

cc @neon epoch

[spice temple]

Seems overkill

Not like there will be a ton of differences nor that we will recommend people to stay on .4 for extended periods of time

[neon epoch]

Why

[still apex]

bc .5 has changes

[neon epoch]

BREAKING NEWS

most updates have changes

[still apex]

i meant plugin wise

[lilac edge]

meh

[spice temple]

The differences would be minimal compared to the work needed to maintain stuff

[still apex]

isn’t it like 2 commands lol but alright

[neon epoch]

mhm

i just dont see the point

[still apex]

@neon epoch pre 1.20.4 would mean =<1.20.3?

[neon epoch]

probably

fixed

[drowsy zinc]

pre should also be hyphenated

[neon epoch]

I deleted it

💥

[twilit pivot]

- 1.20.4
+ 1.20.5

[exotic pulsar]

Is it possible to upgrade a 1.20.4 server to 1.20.5? without loss data

[spice temple]

Yes

But #paper-help

[exotic pulsar]

sorry

[last bear]

Paper.DisableCommandConverter system property to disable Paper's upgrading of command blocks and stuff with commands that have items anywhere in them

cc @neon epoch

[neon epoch]

Thank you

[vocal halo]

Im already working on other things and could include this if you want @neon epoch

oh well the transfer command is already in the docs lol

are properties case sensitive?

[neon epoch]

If you want to PR it to our 1.20.5 version then feel free thanks

I’m at a ball tonight

[vocal halo]

since i see a lot of them start with uppercase and some other with lower case. we might want to cange this to a stadard format.

[vocal halo]

have fun :)

[eager plover]

yes

[neon epoch]

It requires me wearing a tux, so it’s always fun

[vocal halo]

so its intended that some properties start with "Paper" and other with "paper"?

[eager plover]

Yes

that's the "we've been at this for almost 10 years and didn't really figure out a standard form for most of that"

[lean venture]

just go with lowercase

can't go wrong with that

[inner kestrel]

me staring at the mess that is javadoc

it's Fine ™️ as far as like . associating documentation to each individual symbol goes

but trying to expand that out into an actual documentation is torment and thus you have split documentation

[vocal halo]

I mean if the „problem“ exists for multiple years and now they decide to standardize it, it would break a lot of setups.

[lean venture]

couldn't they just make a system to convert it?

[vocal halo]

Too much effort for such a thing

[gloomy vault]

Did you enjoy it

[neon epoch]

Yeah lol, didn’t see you tho

[gloomy vault]

Nice, I was there but didn't spot you either, any excuse to put on a full suit is always fun though 😛

[neon epoch]

Next year if I’m there I will get a picture

😂

I was on the Minecraft table

[gloomy vault]

Ah my table was on the opposite side of the room lol

[neon epoch]

Gutting behaviour

[still apex]

please keep off topic stuff in #general @neon epoch !!!

[last bear]

Because I'm too lazy to update anything myself: jmp's announcement needs to be partially put into the userdev page #dev-announcements message

aka that Paper does not relocate cb packages and uses mojmap at runtime, and that if you don't want to have your jar go through the remap process every time it changes, you should remove the reobf step and set the paperweight-mappings-namespace manifest attribute

idk where this should go, but for people not using userdev that want to skip the remapping, they need to add the manifest entry

manifest {
    attributes["paperweight-mappings-namespace"] = "mojang"
}

in gradle, within tasks.jar or shadowJar for example

or https://maven.apache.org/plugins/maven-jar-plugin/examples/manifest-customization.html for maven

[last bear]

example maven config within the build plugins block:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-jar-plugin</artifactId>
    <version>3.4.1</version>
    <configuration>
        <archive>
            <manifestEntries>
                <paperweight-mappings-namespace>mojang</paperweight-mappings-namespace>
            </manifestEntries>
        </archive>
    </configuration>
</plugin>

[vocal halo]

this would make my plugin not work on spigot servers right?

[eager plover]

if you only target mojmap, yes

[last bear]

The above is for plugin that don't use internals at all but want to disable remapping without depending on userdev

though disabling it via userdev is preferred

[spice temple]

I wonder if it's worth to have a "don't bother patching the server" userdev mode for only that kinda stuff

[last bear]

oh and there is the system property paper.disable-plugin-rewriting that needs documenting

completely disables remapping AND commodore stuff

[vocal halo]

i just need to know if I have to add the line that if you add this to your build script your plugin will or wont work on spigot anymore.

i mean i guess if I want it to work on spigot i would use spigot api but just in case.

[eager plover]

The thing disables remapping of your plugin

it inheriently does nothing on a spigot server

if you're just using the API, all will still work fine with our without that

[vocal halo]

yeah i see

thank you

[ancient quiver]

looks like we already allow propertie shere @neon epoch

[neon epoch]

Slightly different

[ancient quiver]

want me to change it to use those instead?

oh, what's the difference here?

[neon epoch]

That’s a Minecraft version. The latter is a “Property” that we define in our config-spec dir iirc. They should be merged together really

Was an oversight when I made them tbh

[ancient quiver]

bibliothek will return recommended java versions soon™️, maybe we could just hook into that?

[neon epoch]

That would be good once available

[ancient quiver]

since it's probably pulling from there anyways?

[neon epoch]

It does yes

Yeah, once that’s merged I’ll probs overhaul this all

But thanks

[still apex]

is there any work done for this already or not yet?

[opal flare]

on which side?

[still apex]

bibliothek

[opal flare]

yes

there's also a WIP v3 of the API

[still apex]

Unless I'm blind that's not public yet right

[opal flare]

correct

[vocal halo]

should we rename this to reflect contributing guidelines?
https://github.com/PaperMC/docs/blob/main/docs/paper/dev/getting-started/userdev.mdx?plain=1#L7

[drowsy zinc]

it's the name of the software module

[vocal halo]

still looks weird 🤷‍♂️

[still apex]

@neon epoch i require your react knowledge

[ancient quiver]

who doesn't

what are you trying to do?

[still apex]

I hate prettier

why does the website prettier suck

docs prettier can at least format itself

https://site-jrgmctk89-papermc.vercel.app/downloads/all

the diff is because i did something with prettier

[neon epoch]

What for

It’s pretty jarring when the banner disappears

[still apex]

i know

also added an experimental thing @fair river

https://i.imgur.com/VtVHTQq.png (experimental for a test to show colors)

[still apex]

https://i.imgur.com/rVfhiz2.png why is this not a Paper console

[serene vault]

too long for the entire log to show up would be my guess

[still apex]

not that long

if you exclude the timings & server is running offline

& some other useless

https://pastes.dev/e5Lz8U11vf

[echo canyon]

the real question is... why isn't it an interactive console for interacting with an actual server?

[still apex]

That's been brought up before

https://i.imgur.com/8e4BwGM.png

[neon atlas]

okay but easter eggs in there would be pretty funnny

[lean venture]

the times are triggering me xd

[eager plover]

https://github.com/PaperMC/Paper/commit/59fe7ccc3b067676e5c8b85ccfac915c493f54d9

[still apex]

?

[eager plover]

oh, I got distracted, somebody feel free to PR or whatever that change for me please and thx ily; I'm having one of those squirrely hard to see days

[lean venture]

Starting message is at 3:16:20 and the done message at 3:16:21 while it says that it was done in 2.274s xD

[still apex]

the done message isn’t timed

[lean venture]

wdym?

I mean, it doesn't make much sense to my brain that there is 1s between start and end and it says 2+ seconds xD

but yeah, just my ocd working

[still apex]

the log timings are the actual times the messages are sent

i’ll show the code

https://i.imgur.com/x4gJ1bF.png

https://i.imgur.com/aWcQqM4.png

[neon epoch]

This is the importabt bit really

[still apex]

what should I do with the prettier stuff

[drowsy zinc]

use the lint task?

pnpm run lint

[still apex]

that one sucks

[drowsy zinc]

reconfigure it then

[still apex]

how

can it format it automatically

[drowsy zinc]

try adding the --fix option

[still apex]

oh

well it still sucks

can I force push a different branch to my current pr

let me figure this out and then i'll mark it as ready for review

fixed i think

@neon epoch https://i.imgur.com/JbLyDQB.gif ?

[drowsy zinc]

looks weird

[still apex]

i asked github

I have no clue how css animations work

[neon epoch]

Something like that, I meant more like so that instead of just forcing everything down instantly it would like slowly push things down

[still apex]

If you have any idea how feel free to push to my pr

[spice temple]

Do we really need a transition there?

What would make sense to have that whole panel use a view transition

But like, that whole page isn't provided as is, it's not meant to be UX heaven, the happy day case is the software download page

[gilded sparrow]

I do like it the way it is right now

Or like mini said, could also not have a transition in there at all since the content does not transition also

[spice temple]

It feels really arbitrary to only animate the alert

When the whole content changes

And the layout shift into black into animation is really distracting

[gilded sparrow]

Yea the more I look at it I think it's best to just follow how the rest of the content behaves. And hey you get to save one line of css

[still apex]

soooo what should be changed rn?

[still apex]

I'm not quite sure on the colors

especailly the legacy & eol

Maybe i'd be nice if the EOL builds also got the yellow ish color?

https://i.imgur.com/zkoFhQ0.png

nvm too much work

Well I sort off got it to work but I cannot figure out how to get the download button to bbe the right colorhttps://i.imgur.com/wTc2dhn.png

https://i.imgur.com/GEyO1zU.png

[fair river]

I kinda like it. It’s legacy page anyway so outdated people can suffer

[neon epoch]

@neon atlas thank you mr docs contributor

[last bear]

@spice temple completed converter site where

[small harbor]

@spice temple completed converter site where

[raw breach]

<@&748618676189528155>

[mental sleet]

(6633d1bebb3b0c6d8b8101e1) // @hollow axle (@ileon45 / 386928132919394305) has been banned by @ashen sage (220060515337109504)
Reason: Steam Scam

[spice temple]

@ mods I am getting spam pinged pls help

Also, I am getting forced to do react shit

Also, classic discord

(I'll take a look tomorrow)

[eager plover]

Sounds like a you problem

[drowsy zinc]

[mk@mk-pc docs]$ pnpm start

> docs@1.0.0 start /run/media/mk/BarraCuda/docs
> pnpm run build && pnpm run serve


> docs@1.0.0 build /run/media/mk/BarraCuda/docs
> docusaurus build

[INFO] [en] Creating an optimized production build...

[ERROR] TypeError: undefined is not a function
    at Array.map (<anonymous>)
    at cacheAuthorData (/run/media/mk/BarraCuda/docs/src/util/authorUtils.ts:62:48)
[INFO] Docusaurus version: 3.2.1
Node version: v20.11.1
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

any idea why that would happen? tried rerunning pnpm install, no luck

[still apex]

skill issue

[drowsy zinc]

happens on dev too, temporarily alleviated the problem with:

diff --git a/docusaurus.config.ts b/docusaurus.config.ts
index 75e5abe..4046259 100644
--- a/docusaurus.config.ts
+++ b/docusaurus.config.ts
@@ -10,7 +10,7 @@ import { getFileCommitHash } from "@docusaurus/utils/src/gitUtils";
 import { AUTHOR_FALLBACK, AuthorData, commitCache, cacheAuthorData } from "./src/util/authorUtils";
 
 const preview = env.VERCEL_ENV === "preview";
-cacheAuthorData(preview);
+cacheAuthorData(preview || process.env.NODE_ENV === "development");
 
 const url = (preview && `https://${env.VERCEL_URL}`) || "https://docs.papermc.io";
 

[vocal halo]

Also had the issue

But I don’t remember what I did.

[eager plover]

busted cache file thingy?

[vocal halo]

Probably

Since it happened when I rebased to pnpm

I think I just did a fresh clone

[eager plover]

oh, globby blew up, hm

I wonder if something with the repo changed and it just created a weird state

[drowsy zinc]

what made it blow up is getFileCommitHash being undefined, which should happen only when the DS patch isn't applied

I removed some caches, trying to resolve it again

works now

[still apex]

@raw breach pls build

[raw breach]

i am trying

can't we just remove the code format checking? nobody likes that anyways

[still apex]

pnpm run lint --fix

[raw breach]

perfect now i don't have to push everytime

[still apex]

I also had some fun with prettier #docs-website message

[raw breach]

wth does this mean?

[still apex]

https://stackoverflow.com/questions/54401481/eslint-missing-key-prop-for-element-in-iterator-react-jsx-key

the line numbers don't really match up with an array though

[raw breach]

i am look at that aswell though i don't see how that fits into my code

[eager plover]

if you toss out a list of elements then you need to define a key

[raw breach]

uhhhh

[eager plover]

I can't really comment with given context

[raw breach]

yeah i think i will read through some react docs rq

[eager plover]

but, you have an array of elements, when you create an element that you want to toss out and render, you need to define a key="val" on that element, that way it can be identified in the dom, etc

[raw breach]

i got this now but it still tells me the key prop is missing

[eager plover]

I mean, I can't see the code

[raw breach]

more context:

it's giving me an error for the <InfoLog line and the <div line

[eager plover]

is it upset because you forgot quotes?

eeeer o.O

[raw breach]

nope

[eager plover]

I don't like how that is handled, however

is that on a branch or something I can take a peek at tomorrow or something?

[raw breach]

pr is open on website repo

[eager plover]

if it can wait till tomorrow I can take a peek at it, assuming nobody actually skilled in react beats me

[raw breach]

yup that would be great. take as much time as you want (as long as i don't have to wait 50 years)

[eager plover]

Okay, so, I for some reason had a quick look

I literally did what you did there and it builds fine

        <div key={event.currentTarget.id}>
          {">"} {event.currentTarget.value}
        </div>,
        <InfoLog key={currentCmdOutput.length}>{currentCmdOutput}</InfoLog>,
      ]);

[raw breach]

oh yeah i forgot the save in vsc 💀

i usually use intellij for that but because of prettier i used vsc

woopsies

[vocal halo]

Common vsc L

[raw breach]

i am unsure what to do about the InfoLog key though since i don't really have an id for that

ima just push rq so people can look at the not final build

woooho it deployed

[raw breach]

also sorry for making you go through it cause i was to stupid to save 💀

[still apex]

should also make it a ccept slash commands

[raw breach]

was wondering about that. cause the actual console doesn't

should we make it kinda mirror that behaivour or not

[vocal halo]

either make it accept slash command or dont use slash commands at all i guess.

[raw breach]

yeah i think i will remove the / from the help command

[vocal halo]

yeah i would also do it like that

[neon epoch]

nice PR tamion

i think that the Uknown command is slightly different on paper? is there a way that you could check what it is on paper and mirror it? i may be wrong btw

[raw breach]

yeah could be. i am not really trying to mirror the behaivour 1:1 since the start up is also much more bloated on the real thing

can add that though

[neon epoch]

Yeah thanks <3

[raw breach]

i will remove the slash though

[neon epoch]

yeh sure

[mental sleet]

(663446a1bb3b0c6d8b8101e4) // @bright ember (@zaxgamer / 1078803715387052124) has been banned by @neon atlas (202850073812402177)
Reason: steam scam

[spice temple]

@last bear @small harbor what even needs to be done? seeing as ollie did stuff

maybe I should just checkout stuff again

[last bear]

Still my first review, dropdown with “modes”

And waiting on leaf for a final change

[spice temple]

should add swagger to item-converter, smh

smh right when I wanna work on stuff I get dragged into a work call

[spice temple]

https://i.imgur.com/Gh6dujw.png

mfw touching a file that hasnt been touched in a decade

back to modern stuff, surely react is more enjoyable than fixing ancient jsps

suuuuuureeellllyyyy

[spice temple]

something like this?

you also wanted the text areas to be larger, right?

150px?

the select looks like ass on dark mode, lets see if I can abstract out the one we use for the start script generator