#docs-website

1 messages · Page 4 of 1

eager plover
#

stfu, rtfm, and see the javadocs

radiant summit
#

ok but here it makes sense

#

In an actual sentence javadocs looks plainly weird

still apex
radiant summit
#

URL doesn't matter

still apex
#

there are 3 others

radiant summit
#

yes I can see that

still apex
#

@neon epoch help!!

neon epoch
#

what did you do

still apex
#

trying to run lint on the website

#

I didn't even touch those files

neon epoch
#

why are you running that

#

i have never

#

prettier is for babies

#

just write good code and chat gpt it when it doesn’t work ;)

lean venture
#

I would recommend (totally not based) to use BetterJDocs 👀

#

xd

neon epoch
#

it’s docusaurus lol

vocal halo
#

it was a comment about the javadocs

lean venture
neon epoch
#

oh@

#

no

#

thanks 🙏

lean venture
#

xD

vocal halo
#

i would use it over the lame light theme that burns your eyes in the night

still apex
vocal halo
#

because of my comment?

#

i think that people that are exploring the paper api for the first time really dont care if you are technically eligible to deploy on maven repos

#

and if they want they stumble across this website and know what they have to do

#

the main reason i dont want to put in a full explanation is because i want to keep it as simple as possible.

#

the group id alone would be like 5 lines if properly explained

neon epoch
#

i would review this but i’m too drunk. tysm for a contribution though!!

#

pulling a german rn

supple comet
#

not really a docs related question but close...on the download page of every project theres json code that shows the name of the latest stable release and experimental release. Is it possible to grab this anywhere else?
{"props":{"pageProps":{"project":{"name":"Velocity","latestStableVersion":"3.2.0-SNAPSHOT","latestExperimentalVersion":null,"latestVersionGroup":"3.0.0"},"hangarProjectListPagination":{"limit":1,"offset":0,"count":120}},"__N_SSG":true},"page":"/downloads/velocity","query":{},"buildId":"tAZ7k00AKN3a46Thipweo","isFallback":false,"gsp":true,"scriptLoader":[]}

eager plover
#

do your own queries against the API

supple comet
#

thats what i'm doing, but (atleast for paper) this is all I could find that simply shows 1.20.2 as latest Stable. Trying to use this to compare. Unless there another way to get just 1.20.2 idk what to do.

eager plover
#

Because you need to do multiple queries

supple comet
#

wdym

eager plover
#

we just publish a list of versions

#

you would need to parse that list of versions and run down them until you find a tree with a stable build

spice temple
#

for the code that produces those page props

supple comet
#

ok

#

im not sure how this helps me, I thought you were talking about the /v2/projects/paper/versions/1.20.2/builds tree

#

this doesn't specify if a build is stable

#

nvm yes it does im an idiot

#

ty

supple comet
#

rip

scenic gull
still apex
#

Idk if it's possible but this should (somehow) be made more clear?

#

One goes to paper's and one to velocity's

near ice
radiant summit
#

@neon epoch imho swagger already shows plenty about how to use an api

#

that'd be like basically making a http client tutorial

neon epoch
#

kennys idea

still apex
#

who?

last bear
#

The Swagger docs suck, I had to click through things for a minute to figure out what I wanted to do

#

That’s partially the fault of missing descriptive annotations, but 90% of people really just want one thing anyways (list versions/get a version)

neon epoch
#

(get latest build)

spice temple
#

We can just add two example requests and a sentence or two and call it a day

#

No need for anything fancy

fair river
#

Yeah I think that’s the best approach Pepelove

echo canyon
#

I wonder if we shouldn't have even more separate "sites" for documentation for developers using Paper or Velocity API and docs for server admin stuff. there's a 3rd category now for docs for working on Paper directly. like it all feels like it shouldn't be in the same page

#

I think we are gonna have a similar problem with the left sidebar that we had with the config reference pages, just too much there

#

also, the search thing, it would be good to limit searches to whatever category you cared about, if they were separate docs, then the search wouldn't collect everything

radiant summit
#

@neon epoch in #251 didn't they mean like- making a page on the docs for contributing, not replacing docs' contributing guide

neon epoch
#

oh

#

huh, lol whoops

#

my comment is wrong in that case but honestly i still don’t really think there’s much point in duplicating jt

vocal halo
#

i have tried it once but it doesnt really make sense imo

neon epoch
#

Bleh something about this is not sitting right with me

#

takes too long to get to the right node

vocal halo
#

I mean, there are a lot of cases like this:

neon epoch
#

That kinda makes sense though as its a more generalised folder. I dont have a problem with the MCDev stuff being there but it isnt really vital. Wondering if its better suited in misc or some shit as it isnt actually Paper

vocal halo
#

well generally I dont even planned in displaying it on the side and just put a info to paper project setup

#

but if its not in the sidebar, the sidebar is not displayed

neon epoch
#

👍

#

Yeah its a pain... Errm @still apex @radiant summit what we thinking

still apex
#

i’m thinking about sleep

neon epoch
#

arent you european

still apex
#

10:35pm

neon epoch
#

crikey that is early

still apex
#

i have to wake up at 630

neon epoch
#

crikey that is early

still apex
#

i do not function well on 4 hours of sleep

#

been there done that

vocal halo
#

my last 2 years were 4-5h sleep

still apex
#

can’t those 2 pages be merged?

vocal halo
#

nah

#

that sucks

#

imo

still apex
#

@neon epoch

#

velocity not on .2 yet

neon epoch
#

True…

#

i would help if i had any experience with it lol

near ice
vocal halo
#

because there is Admin, Development and Contributing

#

so it has to be in its own dropdown

near ice
#

It doesn’t “have” to be

still apex
#

thanks mini (:

spice temple
#

time to figure out if I remember how to deploy

#

ok so this doesnt work 😄

#

done

still apex
#

about #250, can’t swagger generate curl examples?

spice temple
#

We don't want more swagger stuff

#

We just want a paragraph with text

#

And two urls

vocal halo
#

its already there

spice temple
#

That's useless tho for many

vocal halo
#

why?

spice temple
#

Swagger is a reference, not a guide

vocal halo
#

eh

#

but I get what you mean

#

some text about how to use it

#

swagger also seems to be more for people who already know what they are doing.

spice temple
#

Ye

jagged pecan
eager plover
#

the intent of swagger is to document endpoints, not document how to interop with it

spice temple
#

its a reference, its just a different thing

#

its like papers javadocs

vocal halo
#

yeah i thought of the same

fair river
#

Since we have so much more interests from the community to make guides/docs on development stuffs, we should go over https://docs.papermc.io/ and reorganize stuff so server owner and developers has clear directions when they visit the site for information. peek

neon epoch
#

Yep! I agree. I would like it so that you can go to a project and then it is slightly less easy to navigate from admin -> dev so that server admins don’t get guides that are irrelevant. i think @echo canyon mentioned this before

still apex
#

Something like when you click on Paper (or any other proj) and on the home page it asks whether you're a server admin or a developer?

neon epoch
#

Yep, that would be my plan. then hopefully seperate the sidebars

#

then dev can have a flow to Dev and Contrib

vocal halo
#

@neon epoch i thought you meant the one misc "because it isn't actually paper".
Regardless, why does it not fit in there? With the velocity addition it doesn't really fit in paper/misc and 2 separate pages don't really make sense.

neon epoch
#

True.

#

Ops anyones

neon epoch
neon epoch
#

the sidebar actually changes between each one

#

gives it a bit of seperation

echo canyon
#

what happens with search?

neon epoch
#

ah i havent touched that yet

#

not sure if thats possible but ill give it a look

#

just kinda wanted to check that was sorta what you meant

neon epoch
#

yuh @neon atlas that is intentional but idk what you mean by "The project level separation I definitely agree with"

#

but yeah, finding a sweetspot is hard

neon atlas
#

oh

#

I am braindead

#

mb mb

neon epoch
#

maybe leaving a link to admin and dev in the sidebar at the top?

neon atlas
#

I thought this was adressing the fact that you see velocity stuff in the paper tab

#

but that was search

#

not the sidebar

#

excuse my brain

still apex
#

someone send me a screenshot

neon epoch
#

there you go

vocal halo
#

lol

still apex
#

of the docs

neon epoch
still apex
vocal halo
#

idk

echo canyon
#

ok, ive actually used react now, so I can review (a little) the auto versioning stuff

neon epoch
#

yeah there is a bit of a problem with that. one of the new config pages has the version in the yaml - but idk how to put the version in. fetching the version is async so i’ll just get a promise

#

i’ll have to bake support into the Config component i suppose

brazen moon
#

the entities.tracking-range-y section is under the wrong node it's entities.spawning.tracking-range-y in the doc

vocal halo
#

i was litterally wondering why warning looks like an error yesterday. But they changed it in v3. nice

neon epoch
still apex
#

is it a good idea to add links to the javadocs for certain things?

#

i’ll send a example in a sec

#

like here

vocal halo
#

+1

still apex
#

also docs #110 can probably be closed

#

been a year with no updates

vocal halo
#

probably ask before you close it though

still apex
neon epoch
#

if someone wants to add them i’ll just incorporate them when i get back to that

still apex
#

wdym

neon epoch
#

the javadoc links

#

add the normal links and i’ll update them to be versioned when i get to that

still apex
#

draft cus i’m still working on it

young matrix
#

it might make sense to have a javadoc component rather than having the full link each time?

still apex
#

the automatic doc versioning thing has it

young matrix
#

so you could do like <JavaDoc project="velocity" class="..." /> or something like that

#

ah

echo canyon
still apex
#

the 1st one failed

eager plover
#

1st build failed, commit after that message resolved it

echo canyon
#

I think the world config is missing the insomnia player start ticks config setting?

#

I need to get that report generator thing for the config setup so we can automated checking parity

vocal halo
#

@neon epoch what are you doing with my PR? 😅

neon epoch
#

“Fixing it” by breaking it multiple times over

#

forgot that you probably got email notifications

#

basically just addressed the comments though so it’s in a ready-to-merge state

vocal halo
#

well my main concern right now is that it doesn't really fit into paper misc since it contains both paper and velocity project setup

#

that's why i didn't move it back

neon epoch
#

Yeah, it doesn’t really belong in the misc project though i don’t feel - if it goes there it will never be seen…

#

whether you take the velocity part and chuck that in the velocity setup guide or not is up to you. Could do the same with the paper as well - just put a h2 or something at the bottom and add the respective parts to their respective project’ getting started

#

i don’t want it in misc though as they are directly related to both paper and velocity

vocal halo
#

well thats why admonitions exist

neon epoch
#

huh?

vocal halo
#

:::info

neon epoch
#

might be too much, up to you

#

anyways, all i wanted was to take it out of the misc project as it didn’t belong there

vocal halo
#

no

#

it was related to the "no one will see it " message

#

y'all didn't want it to replace the manual setup

#

and it doesn't really fit in the paper getting started since 2 times "setup project" looks weird

#

so i put it in misc and add an admonition to tell people that if they are using intelliJ there is a much simpler way to setup a project.

neon epoch
#

Ah, ok i see what you mean. If you just put a h2 or h3 at the bottom with “MCDev IntelliJ Plugin Setup” i think that works. Just note that it’s optional or whatever. Could even be in a drop down

vocal halo
#

ugh just leave it how it is now. I feel like we are talking past each other.

still apex
#

what?

vocal halo
#

what what?

still apex
#

your message

vocal halo
#

that also doesn't seem to work:

<Tabs groupId="author-front-matter">
  <TabItem value="maven" label="Maven POM">
vocal halo
#

@neon epoch i separated paper and velocity to their respective setup guides now. But I really don't want to convert it to a dropdown to be honest.

neon epoch
#

cool

vocal halo
#

i think so

neon epoch
#

brilliant

radiant summit
#

maybe we should put the fact Configurate is bundled with Velocity into the docs

eager plover
#

it being bundled at this aspect is an implementation detail

#

an implementation detail we're not too secret about, but, it's an artifact which is scheduled for removal right now

#

(I do wanna expose 4 in the API, however

vocal halo
#

sorry @neon epoch i was at work the whole days and busy the whole Saturday 😅 Thanks for doing it!

neon epoch
#

not a problem thanks for the contribution 🥰

spice temple
#

Am I stupid or do we have no doc page about inbuild commands? Like the paper command?

#

If so, I'll gonna file an tracking issue later

radiant summit
#

I mean if a command is useful for sth in particular it's probably mentioned in a related page

#

but I don't think I've ever seen a list, no

spice temple
#

Just a short reference like this

#

I'll add an issue and populate it with a Todo list lasted

#

Later

#

(thought about this because I had to check source code to know what the heap dump command we have in the server was, lol)

jagged pecan
#

Previously I wanted to start the commands reference, but I got distracted, tried data-gen from registered commands at runtime, and scope crept lol

spice temple
#

Classic

#

Also, lol, totally posted the vid in the wrong channel

coral gulch
#

<@&748618676189528155> I guess that person is scamming
sorry if I'm reporting it wrong...

sharp pivot
#

already banned, didn't automatically delete the message here

coral gulch
#

ah, thank you for letting me know about it!

sharp pivot
#

you can also right click the message and go to apps -> report

ebon cave
#

1.8 Where is the API documentation of the API?

neon atlas
#

1.8 is not maintained nor relevant

#

given we did not start the new docs when 1.8 was around, it does not exist

ebon cave
#

What do you think of 1.8, what APIs, and how to see 1.12 to 1.20 API?

neon atlas
near ice
neon atlas
ebon cave
#

1.14 or 1.15, there are some new versions, there are no old versions, I do n’t know how to check, which will cause me to not pay attention to the content of the low version when it is compatible.

neon epoch
#

don’t use an obsolete version then

#

we provide javadocs for all versions (i think) so check them for compatibility

#

however the majority of the bukkit api has been present since the dawn of time

eager plover
#

We do not support older versions

#

We have 0 interest going out of our way to setup the JD viewer for such old versions

#

You are more than welcome to grab the jd jar from the maven repo and extract it to your own web server, or use one of the several dozen already public mirrors of that stuff

ebon cave
still apex
#

legacy versions are not supported

ebon cave
#

No, I just ask how to think of the old version Javadoc

mental sleetBOT
#

(653e9cbdcdf07f25f6aca100) // @serene knot (@dextg / 372423597895057411) has been banned by @neon atlas (202850073812402177)
Reason: Porn spam

#

(653e9cbecdf07f25f6aca101) // @serene knot (@dextg / 372423597895057411) has been banned by @radiant summit (451779815415218177)
Reason: spam

radiant summit
#

LYUNX

neon atlas
#

NACIO

neon epoch
vocal halo
#

does it matter?

lilac edge
#

folia page doesn't have categories

#

same with velocity

#

Misc should have everything underneath it, not alongside it

lilac edge
#
  1. it's not very obvious that you can hover over the (i) to get shown a popup. it needs to be visually separate from the file name. Maybe add something like "Hover over the (i) to view more information on a file." above the file structure? Could also change the (i) to an actual icon that's not the same color as the file name.
  2. files without hyperlinks should not be the same color as ones with hyperlinks
  3. hyperlinks should not be actual hyperlinks - docusaurus probably has a component for directing to pages, use that instead
  4. the popup should only be visible as long as the cursor is on the (i). there's no need to keep it visible if the cursor is hovering over the description/near the description. remove the z-index off everything and remove the unnecessary margin-right: 100px on the popups
neon epoch
#

what about if you want to copy paste the text? that makes it impossible to do

#

i’ll read the rest of this later 👍

lilac edge
#

that'd be useful if the text is something you'd want to copy/paste. descriptions of the files doesn't really necessitate that imo

neon epoch
#

True Dat.

golden vine
#

Isn't this caution message irrelevant since 1.20.2 because the player locale is set during the configuration stage and no longer during the PLAY phase?

radiant summit
#

probably should be reworded

#

but the point that it's not available in PlayerJoinEvent (correct me if configuration phase changed that) still stands

golden vine
#

no, it is available, thats the thing

radiant summit
#

open an issue then

#

the entire docs should be looked over for this tbh

eager plover
#

join event is "join the world"

#

which happens after the configuration phase

radiant summit
#

so we have that now at this point

#

great

#

also a18dce2 needs an update since iirc a PR was accepted with a change to it

neon epoch
#

thanks for peoples contributions, an issue is probably needed for looking over velocity docs for recent changes

neon epoch
#

but yet vercel fails, beautiful chefskiss

still apex
#

look at logs?

neon epoch
#

do you really think i didnt do that omegalul

#

it cant find the file lol

vocal halo
#

does it?

#

it says compiled successfully

still apex
#

vercel

vocal halo
#

ahh yours is alright but the gh action

#

i see

neon epoch
#

🥁

#

🎉

echo canyon
#

@neon epoch what's up with the {'<='} in md files?

neon epoch
#

err iirc something todo with them needing to be escaped now

#

lemme double check

#

it seems a backslash will work

echo canyon
#

its just an md file... you don't have to do that in regular markdown tho right?

neon epoch
#

No, but i just checked and the compile does shit the bed

echo canyon
#

is there no difference between .md and .mdx now? like are all of them treated as mdx-type files?

young matrix
#

that has always been the case

#

that will not be the case in the future though, they are working on full commonmark compat for .md files

#

iirc there is a config option you can set to enable taht

#

(but then you have to be careful when you use .md and .mdx because they will be handled differently)

echo canyon
young matrix
echo canyon
#

I think either way, we should be consistent. Either enable the option and use .md and .mdx separately. or make them all have .mdx extensions

young matrix
#

so

markdown: {
  format: "detect"
}

in the config file will make it respect extensions

#

In Docusaurus v3 the default setting is mdx because historically Docusaurus v2 used to parse everything as MDX: let's keep this behavior for now to make the upgrade easier.

In Docusaurus v4 we will likely switch to detect as a breaking chance, making it easier for CommonMark sites adopt Docusaurus without having to even know about this setting.

#

tbh I feel like they should have made the breaking change sooner because they were already making a bunch of markdown format breaking changes due to mdx v2/3, but ¯_(ツ)_/¯

neon epoch
#

hah, just tabbed back to discord having just added this to the docusaurus config lol

#

i am hesitant to change to detect because of breaking formatting, but as this will be default going forward its probably the best choice

echo canyon
#

I think changing to detect is a good thing. That or make all files .mdx

neon epoch
#

there we go

vocal halo
#

Hmmm any input regarding this?

radiant summit
#

should be separated imho

vocal halo
#

maybe just add links and completely remove the info admonition

neon epoch
#

I am not entirely convinced this LP section belongs here. Documenting their commands and API isn't the goal of our documentation. Maybe swap this out for a section about the fact it is asynchronous? <- see kezz's comments

vocal halo
#

I think its a good "how do I use this in real life" example. Its not a documentation of their commands and API either since this are the steps required to access the prefix in the code below.

eager plover
#

It ties the thing to LP in which as general abstract documentation is not really ideal

#

I could maybe get it on a code examples repo as a more ingrained example, but, I don't think it makes sense as thee example

still apex
#

Could probably just do a final Component prefix = ...;?

vocal halo
#

What should I say about it being async? That devs should avoid using the BukkitAPI in this event?

neon epoch
#

yup

vocal halo
#

i removed the LP/MiniMessage example for now

valid pier
#

Is it possible to remove the joined/quit messages?

valid pier
#

oh sorry

neon epoch
#

anyone with some time, I had a look thru https://github.com/PaperMC/docs/pull/256 and didnt spot anything that looks broken after compilation so if I could have some more eyes that would be lovely 🥰

lilac edge
#

scrolled through each page, everything lgtm

young matrix
#

do html comments still need to be removed in .md files even though they're being parsed differently from mdx now?

#

(I haven't checked locally this just jumped out as something that may no longer be needed)

lilac edge
#

i registered those that were removed as useless/unneeded since a bunch of other html comments were added back

young matrix
#

ah, that makes sense too

lilac edge
neon epoch
#

Yeah, those comments didn't seem relevant any more.

neon epoch
#

Yeah folia's page links to itself because there aren't any guides. waterfalls category page, see 266

echo canyon
#

@neon epoch you un symlinked docs/velocity/dev/api/component-api/intro.md, is it better now to just import the component direclty like you did? or is symlinking not supported anymore or what?

neon epoch
#

the symlinking no longer worked

#

This was the way that was recommended on their documentation

dusty falcon
#

were here helping with papep api?

#

were chat

#

with that

still apex
white stratus
#

ahem

#

<@&748618676189528155>

ancient quiver
white stratus
#

F

ashen sage
empty grove
#

Same

ancient quiver
#

banned by hand but the stupid autodelete doesn't work

ashen sage
#

🪦 RIP Sentinel

white stratus
#

mods vs scammer, scammer 1, mods 0

ancient quiver
#

@opal flare please fix

fallen condor
#

OH MODERATORS

mental sleetBOT
#

(655a480242b7936e54a59f4e) // @worn umbra (@fibergod / 1057254560797839410) has been banned by @neon atlas (202850073812402177)
Reason: nude server invites

neon atlas
#

Not very docs specify I must say

spice temple
#

deployed the website

echo canyon
#

@neon epoch whatever happened with the algolia search stuff? I see history in this channel of you modifying the record extractor

neon epoch
#

I kinda got far enough so that it extracts the records but the record extractor was really confusing

#

there was something i couldn’t work out how to do though

neon epoch
#

@echo canyon idk maybe the problem is i just don’t know how

mental sleetBOT
#

(6564ec1342b7936e54a59f5e) // @short sluice (@tomatoguy1 / 869799642546728990) has been banned by @radiant summit (451779815415218177)
Reason: porn spam

radiant summit
#

always docs 💀

rigid bluff
#

Very important docs

twilit pivot
#

https://docs.papermc.io/misc/how-to-avoid-ads-on-your-server kekw

still apex
#

<@&748618676189528155>

mental sleetBOT
#

(656645fa42b7936e54a59f61) // @tranquil gull (@.alfa7777 / 746217042943803452) has been banned by @ancient quiver (1098722699116810331)
Reason: scam spam

ancient quiver
#

merci

raw breach
#

i feel like this channel got some kind of curse on it

still apex
#

alphabet

velvet bough
#

swap it with #general and general will get all the spam posts

still apex
#

it’s the alphabet

lilac edge
#

i wonder if creating a channel like bugtrap that's hidden from default channels in onboarding will make them all go there

rugged bay
#

I've seen some servers do that, auto-banning anyone who posts there, but it seems risky for general public, and easy enough for the spambots to detect and ignore

lilac edge
#

i'm not sure it's the alphabet otherwise #bot-spam would be getting them

radiant summit
#

We have people who literally report this stuff in seconds and then there's always someone who bans the person in seconds

sinful hare
lilac edge
#

ah ok

vocal halo
#

why is the message red?

neon epoch
#

better discord deleted message plugin i imagine

vocal halo
rugged bay
#

it's worth noting that both BetterDiscord itself, and especially message logging plugins for it, are big TOS violations and can get your account banned. Don't use them.

vocal halo
#

Unofficial discord clients is a topic someone could talk hours about but let’s not open this debate 😅

fallen condor
edgy urchin
#

Is the docs website down? I’m trying to access the migration website and it’s not loading

still apex
sinful hare
#

Not down for me ^

edgy urchin
#

Oh weird that one just wasn’t working on my internet connection, it works on cellular for some reason. Thanks

neon epoch
random pollen
#

where is the description field of a docs file used

#

or, I guess what's relevant for me is, should it be plain text or can it contain markdown

#

I'm guessing plain text

vocal halo
#

Isn’t that the thing that is displayed on the root pages of the sections

#

Or tab description

random pollen
#

yes thanks

#

I'll just leave it plain

#

looks like the rest are

neon epoch
mental sleetBOT
#

(6571c52742b7936e54a59f7b) // @haughty drum (@valarg43 / 1061712533892890745) has been banned by @neon atlas (202850073812402177)
Reason: NSFW discord invites

neon atlas
#

why do they always start in the docs-website 😭

raw breach
raw breach
#

don't think ollie is happy about that kekw

spice temple
#

Doesn't matter what channel they do it in

vocal halo
#

Can do it in bot spam kekw

neon epoch
#

But as Mini said, it doesn’t matter where. honestly it may be good if it happens here more often as it has the lowest traffic

mental sleetBOT
#

(657247f342b7936e54a59f7c) // @limber parcel (@squidddly / 605107252503773199) has been banned by @viscid thistle (104723018483318784)
Reason: NSFW Message

still apex
#

@neon epoch

#

for velocity the plugin messaging docs case 4 should probably have a more clear warning that it should only be used when making client mods

neon epoch
#

Ok, sure! As always anyone lurking is welcome to get started with contributing here 😄

still apex
#

why does the docs use yarn

neon epoch
#

Why not?

fair river
#

powergas stop complaining, start working enrolledchatting

young matrix
#

I think the initial reason was because it has inbuilt support for patching packages

#

altho 3/4 of the initial patches are now (in some sense or another) part of docusaurus so not as relevant

twilit pivot
#

<@&748618676189528155>

mental sleetBOT
#

(6575f0a342b7936e54a59f86) // @unique nimbus (Ark#6088 / 887051459005415485) has been banned by @ancient quiver (1098722699116810331)
Reason: crypto spam ads

#

(6575f0a442b7936e54a59f87) // @unique nimbus (Ark#6088 / 887051459005415485) has been banned by @scenic gull (71627708521512960)
Reason: spam

scenic gull
#

blargh

ancient quiver
#

too slow

twilit pivot
#

lol

ashen sage
#

the designated spam channel, it always ends up being this one

mental sleetBOT
#

(6576e70c42b7936e54a59f88) // @boreal burrow (@kyant_ / 976922462828773446) has been banned by @spice temple (134340832093405184)

spice temple
#

why does that not delete

#

urg

#

just took a second

#

this time they posted into #bot-spam first ^^

jagged pecan
#

@neon epoch for my pr #223, is the name "Bukkit Commands Configuration", with the slug "/reference/legacy-commands-configuration" ok, or should they match.
legacy feels too harsh, since its the only place for command block overrides, but bukkit commands configuration feels like its too important

neon epoch
#

meh, can we have bukkit-commands-configuration as the slug so it matches? I might have poo pood that before but i can’t remember and sounds aight in my tired mind

jagged pecan
#

👍

neon epoch
#

someone who wants a free PR update docs to 1.20.4 (it will sit in limbo until its upgraded to stable)

jagged pecan
#

For config docs and stuff, a way to specify optional /required keys would be useful
Like to document plugin.yml, paper-plugin.yml

The other this is for multi-values things (list of objects etc)
The defaults (an empty list), isn't useful for documenting all possible options

Dunno the best way to fix any of that

still apex
#

it already is

#

?

#

well not for paper plugins

#

but for plugin.yml

jagged pecan
#

I meant if we wanted to look at the same sorta layout the config files use

#

Since there was the idea of a file tree previously iirc

neon epoch
echo canyon
#

ok, so I want to move the config specs to standalone files

#

ideally just putting .yml files somewhere in the file tree

#

ok, can use raw-loader

neon epoch
#

I was having a think the other day about the auto-generating of these files

#

but I couldn't come up with a sensical plan really that wouldn't require extensive gradle knowledge that I don't have 😝

eager plover
#

Comment annotations in the config files in the source?

neon epoch
#

Yeah, sure. But how do you handle markdown nicely?

#

large comments are gonna be really ugly in the src

eager plover
#

My febral thought was is most of them are just plain strings

neon epoch
#

most are

eager plover
#

Can also maybe have an external ref annotation or something, idk

neon epoch
#

some are quite extensive

eager plover
#

But, yea, I mean, I want comments in the config files, and so it would be kinda nice to do that

#

Just in general

#

But, ofc, some are just so crazy to entire documentation for in a comment, so, idk

neon epoch
eager plover
#

Core team, somebody else's problem, or something

neon epoch
#

Almost needs like an:

@DocExportComment("blah")
@ShortformComment("blah")
int spawnRate;

Or something like that. But exported one could get quite long

eager plover
#

That's why I propose an external ref

#

Basically, for anything too long for source, it could go into a file

#

I don't got all the answers, but, it's kinda long been a dream of me for that page to be backed by some file generated from the server, makes it easier to just update that file Vs tryna deal with coordinating stuff across two repos and such

neon epoch
#

oh yeah for sure that would be great

young matrix
#

could also do something more like javadoc format for the long one

vocal halo
#

If multi line strings are available for annotations I don’t think it would look that ugly

mental sleetBOT
#

(657ff67d42b7936e54a59f99) // @paper stream (@danyaall / 584764082163286028) has been banned by @sharp pivot (331822092477792256)
Reason: ad spam

neon epoch
#

re: #1129091109742727228 message
that would increase the scope of work for this PR, but we could migrate to JSON instead of YAML. i’m happy to take that over if @echo canyon would prefer?

spice temple
#

I couldn't figure out how to tell IJ to use a json schema

#

actually never mind

#

found it

jagged pecan
#

Ah now the config thing is (going to be) split into a separate file that will be less painfull
Previously I had to do the thing of: this is MDX, with is a JavaScript bit inside, and that template literal is yaml, and that yaml value is markdown

Was fun, especially where on save it duplicated higher up levles

echo canyon
spice temple
#

ye, thats why I brought it up

#

if we gonna reorganize them in preparation anyways, might as well turn them into schemas already

echo canyon
#

I feel like the full json-schema format is overkill for now

#

firstly, how many people are editing the ymls in an editor that automatically will apply the right schema to type check?

neon epoch
#

i mean its pretty simple to convert the yaml to json once we transition using some online tool

echo canyon
#

that isnt what @spice temple means afaik. I thought he was saying we should format the spec using the json schema format

#

instead of the comparatively simple format we have now of just a default + description

neon epoch
#

Ah. That seems much more in-depth than what i threw together yes.

echo canyon
#

It’s useful no doubt, but mainly to consumers who use editors that automatically apply schema to files that match a pattern. Like ides do with paper plugin yml. But I don’t think many people edit server ymls in such a fashion

spice temple
echo canyon
#

I feel like we are talking about 2 different things

spice temple
#

But yeah, I agree that it's out of scope for this particular PR

echo canyon
#

I thought you wanted to create a full schema for all the ymls, not create a schema for the spec itself, for the format we are using to define the spec

spice temple
#

That sentence confused me

#

I proposed a JSON Schema for our bukkit.yml etc

#

I didn't know about Schemastore

echo canyon
#

yeah, that's more work than just adding something at the top. you have to declare the types for each key, defaults, its complex, just look at the one for paper-plugin.yml

spice temple
#

I only knew defining stuff manually or via a $schema property

#

I know the Schema is work, I talked about discovery

#

The Schema itself is just dum work, copilot can prolly do that easily

#

But yeah, let's refactor first and worry about this later, if ever

echo canyon
#

@neon epoch do you know of a good way to make the server.properties page more readable? the no spaces, text=test makes it annoying to distinguish between the setting and the value

#

but I don't wanna just add spaces, cause I want the format to match server.properties

neon epoch
#

i mean the only way i can think of is actually padding around the =?

echo canyon
#

what about some color difference in the text?

#

if the value color is slightly different, could make it way easier to tell with a glance

neon epoch
#

Oh maybe, greying the key a bit? or the other way around

echo canyon
#

the coloring could apply to the yaml too

#

it culd also use it, even tho its a bit more clear what the value is

neon epoch
echo canyon
#

well my initial thought was to make the separator a JSX.Element, so it could be a colored/complex component per Config component

#

but that complicates the stripping of trailing spaces

neon epoch
#

Ugh ConfigurationPart is a package private class. that’s gonna make this reflection harder. i was attempting to throw something together to generate the files

still apex
#

make it public?

neon epoch
#

well ok sure but that doesn’t help me now i was just using a userdev env

mental sleetBOT
#

(6582084442b7936e54a59f9f) // @granite laurel (@yeetusthyself / 743670340475027567) has been banned by @echo canyon (338670732403933194)
Reason: nsfw spam

neon epoch
echo canyon
#

I think that’s better than trying to use reflection.

jagged pecan
#

That would also be good In the case other plugins add something to the registry during bootstrap, which affects a config option (like biomes, tags / whatever in the future)

echo canyon
#

the reason I say its not really possible now is that the config can't be loaded that early as its setup. It can be moved up but only when spigot's config is also moved up because some of the stuff in paper config relies on spigot config

lilac edge
#

why load the config earlier instead of just stopping the server once everything loads

odd harborBOT
neon epoch
# lilac edge

seems kinda jank - don’t need to do worldgen and all

neon epoch
echo canyon
#

idk how much "starting" needs to happen. I think all we need is SharedConstants.tryDetectVersion() and Bootstrap.bootstrap() to run

#

when all the configs are merged, our config should be able to exist with only those 2 things having been ran

neon epoch
#

yeah patching the server to create this functionality seems like the easy bit. I don’t know enough about the paper infra to actually know what would run and serve this. Something to think about is that this would need versioning

lilac edge
#

are you talking about the config description generation being built in or just the config files being spat out @ ollie

echo canyon
#

we want more than just spitting the config files out

neon epoch
neon epoch
echo canyon
#

yeah, the descriptions. Probably longer ones than will be in the yaml comments (if configurate ever supports outputting comments)

neon epoch
#

Yah, this part is pretty easy IMO it’s just the serving and infrastructure i’m not clear on

echo canyon
neon epoch
#

@burnt ice

#

What is right

burnt ice
#

Super shop unlimited will load after your plugin

#

Descriptions need adjusted

neon epoch
neon epoch
#

Finally had time to work on the auto-versioning. only been like, idk 3 or 4 months 😝

neon epoch
#

when you use absolute paths in those versioned files @echo canyon it tries to resolve the current version ones.

echo canyon
#

oh you mean when we split the docs and leave an old version? that's annoying

#

can we make our own alias that handles that somehow? if you don't immediately know, we can just ignore it for now

neon epoch
#

no i do not know, but I wasn't aware this was an issue before. for example on production this links to latest docs

#

i think the only thing to consider now are the logic errors really. for example, what is the contract with api versioning? it will start with 1.21, not 1.21.1. from what i am reading i think that will be fine though

#

overall looks like it should be fine :P

mental sleetBOT
#

(6590ce6542b7936e54a59fb9) // @grizzled vector (@max_mc2 / 1113125024233181375) has been banned by @echo canyon (338670732403933194)
Reason: nsfw

supple comet
neon epoch
#

I wanna merge this auto versioning later. I’ll have a look thru and try and fix any typescript typings first tho

neon epoch
#

You can use the versioning CLI to create a new documentation version based on the latest content in the docs directory. That specific set of documentation will then be preserved and accessible even as the documentation in the docs directory continues to evolve.

#

@echo canyon ^

neon epoch
#

With some help from sulu and MM when you search for config things in the docs it now direct links & scrolls to them. However, when you search for something which is on the same config page it fails to correctly scroll and also the search results are a bit bleh as they could do with maybe the full yaml path. more of a todo message for me and anyone that wants to take a look at the config component 😝

#

oh yeah and i pushed a failing commit to main but githubs webhooks have shit the bed so vercel hasnt tried to build it yet

fair river
#

Starting first day of the year with a bang teeheeRie

jagged pecan
#

"i dont always push failing commits to main, but when i do, i take down an unrelated service so it doesnt get deployed"

neon epoch
#

this guy gets it

supple comet
raw breach
raw breach
neon epoch
radiant summit
#

new Owen

neon epoch
#

thats fixed now, i updated your PR @supple comet so that it builds. I will try and review it tongight

neon epoch
neon epoch
supple comet
small harbor
#

it's practically the same as your current PR, but for consistency it'd probably be best to copy it from docs

#

since that's what i did originally

supple comet
#

yes because there is only one way to do it correctly (wget/curl is matter of preference)
great minds think alike paperUwU

fair river
#

Thanks for contributing paperUwU @supple comet

supple comet
mental sleetBOT
#

(6595dddd42b7936e54a59fc3) // @wintry socket (@lgprov04 / 455023074706849792) has been banned by @sharp pivot (331822092477792256)
Reason: bot

small harbor
#

kinda awkward

#

the java version check got removed in 1.18.2, so i think we should recommend 21 starting that version

neon epoch
#

👍

#

Did the Java check get removed? I seem to remember MiniDigger working on it

spice temple
#

I remember working on it too, pretty sure that got merged and I updated the docs

#

So yeah, I agree with Michael

neon epoch
#

Time flies I guess

radiant summit
mental sleetBOT
#

(6599737b42b7936e54a59fce) // @verbal salmon (@pablo1031 / 480757988403970069) has been banned by @fair river (177150983258767360)
Reason: spam bot

neon epoch
#

What do we think about maybe trying to also put the Contributing.md in the docs? It’s become a very long file which is quite hard to navigate - I suppose with softspoon our tooling will change quite a bit so maybe something for after then?

neon atlas
#

Yea probably a good idea to wait

echo canyon
#

yeah I started that when I wrote how to make new events

#

that should really come with the re-org I mentioned in that issue

#

making a project selector and splitting up Admin/Dev/Contrib for each project

neon epoch
#

I took a look at swizzling that

#

But the components were gonna be more of a pain than I thought

#

So I stopped :P

#

A lot of the links need making consistent as well

#

Like paper admin category page hrefs have /cat in them a lot but othes don’t tend to

neon epoch
#

Or, standalone idk

#

With that domain explaining that is

lilac edge
#

it's such a good domain too

#

sucks that it's not going to be renewed

fair river
#

oh ollie we did have an internal discussion about it

#

let me see if I can link you

neon epoch
#

Oh haha fair enough

fair river
#

Since you are maintaining the doc place, your input would be nice paperOhhh

neon epoch
#

Yah I mean a component that does this can probably be designed pretty easily and plonked on the getting started page or with the flags page or under misc as like a utility page.

It’s just as cat says, how opinionated we wanna get with flags. I’ve heard many people recently saying aikars are a bit out of date (I can’t comment here, I don’t have enough knowledge of flags) but we have recommended this site and those flags so it wouldn’t be a change but moving it over would give us more control going forward (and the vector one, lol)

#

From what I read in that chain no one was against us hosting them, it’s just what we recommend

fair river
#

yeah it was just no one wanting to put in the effort rn unless Oille can do but I think for the opinionated part, we can just disclosed it via a disclaimer? similar to how we warn people about using older build is bad?

#

but yeah we've gone through two sites already... it would be nice to have one just for ourselves I believe as I originally mentioned there.

neon epoch
fair river
#

LOVE YOUUUU

eager plover
#

See, there was 2 distinct advantages in aikars flags

#
  1. Xmx == Xms, which, is not that huge of a deal now given that the modern JVM seems more happy to expand the heap, ik around java 8 and a few dozen versions after that it was pretty darn easy to basically get into GC stall territory
#
  1. the general distribution of the heap, i.e. old vs new split, idk how important this one is anymore, I'd imagine it will still be beneficial, it's just in a weird area where the game now stores extra data structures in memory, etc, so where that ideal split lies is a bit harder to say, ik that I no longer recommend aikars 12G+ tweaks because that pretty much WILL cause issues these days. really just need people we can ask and trust to toy around a bit and see what their metrics show
neon epoch
still apex
#

deployed failed

neon epoch
#

i see that

#

server side rendering bleh

still apex
#

Can't close the flags menu

neon epoch
#

theres an extra ! there causing an issue

#

but you can close by selecting the flags

still apex
#

maybe also add a restart script to it? Like flags.sh / mcflags has/had

neon epoch
#

maybe. how do you want the platform selector done

spice temple
#

the sizing with the inline style is also super wonky

eager plover
#

one thing that I kinda wanted is like a download button

#

like, macOS is a fun PITA

#
cd "`dirname $0`"
java -jar server.jar
spice temple
#

man, I hate looking at jsx

#

great work tho!

neon epoch
#

why hide overflow here? that removes the scrollbar in the text area, preventing you from viewing all the things

Currently i handle resizing automatically so you dont need a scrollbar

spice temple
#

wondering if we should put it under misc/tools/

neon epoch
#

could be good, incase we make some more utils in the future

spice temple
#

I would like to report a bug then 😄

neon epoch
#

browser?

spice temple
#

edge

neon epoch
#

😢

spice temple
#

it doesnt resize for me, ever

neon epoch
#

works on my machine gg glhf

spice temple
#

oh, its on page load

#

I thought you had a resize observer

neon epoch
#

it does resize? change from aikars to None

spice temple
#

now when I resize my browser tho

#

its fine

#

its a typical thing only webdevs notice but its not worth caring about

still apex
neon epoch
#

platforms need to present all the time for the #!/bin/bash

still apex
#

also maybe add some icon next to the falgs dropdown so you can see it's a dropdown

neon epoch
spice temple
#

oh god

#

why are you not using a <select>?

#

that comes with an arrow, keyboard support, etc

neon epoch
#

cause i was like ew that looked gross

#

and couldnt work out how to style it :P

#

cause i wanted both the name and description in the card, different sized

spice temple
#

I guess

neon epoch
#

Just need to recolour it

still apex
#

cn you commit

#

ty

spice temple
#

the colored emoji looks really bad to me

#

and I think I would move the gui to the right, plus add a bit of margin betweeen the options

#

label to input too I guess

#

I think something like this looks less jarring

#
.selected-flag::after {
    content: "▾";
    position: absolute;
    right: 15px;
    line-height: 0;
    font-weight: bolder;
    font-size: 20px;
    top: 50%;
    color: #a7a7a7;
}
south thunder
#

How about ▾

spice temple
#

I like that

neon epoch
#

That’s nice

spice temple
#

(updated my css)

neon epoch
#

Defaulting to Linux? I feel like the greater proportion of people using this will be noobs on windows

small harbor
#

wonder if we can put something for windows users there

#

why it's not necessarily recommended

neon epoch
#

Is it really the time and place? also - what is the reason? if you’re just self hosting a private server on your pc I don’t see the problem

small harbor
#

seems like the best place to put a heads up notice

neon epoch
#

A “don’t run windows on production servers” is almost comical

small harbor
#

nothing too important

#

well yeah if you phrase it like that Omegachair

#

something something for optimal performance, using linux is advised: short sentence why

serene vault
#

Not really a fan of putting something so opinionated in the docs personally

south thunder
#

Well, I do feel like the improved reliability, performance and wider availability of server-related tools in Linux are fairly non subjective points

fair river
#

Just show a graph on live server count on OS using data from bstat Clue

#

But yeah I don’t think such warning is needed

neon epoch
#

its reassuring to see win server still maintains market share

neon epoch
#

should be maybe done now? Lemme know what you think :)

still apex
#

you linked the same pr twice

neon epoch
#

dunno what youre on about

#

docs productivity is gonna fall off a cliff my right click on my mouse is broke... 😢

still apex
young matrix
#

(ignoring the admonition on their own docs page lol)

lilac edge
odd harborBOT
neon epoch
neon epoch
still apex
neon epoch
#

when did it change

neon epoch
#

oh so 3.3.0. so yeah put Velocity 3.3.0 ...

neon epoch
#

Agolia tweaking needed as per

echo canyon
#

can we exclude the old versions with the bot

#

kindof annoying that they show up

neon epoch
#

I’d need to look at the lib sulu uses, it’s possible we could probably just filter out when they contain like /1.*/

empty grove
#

This just in: update after 1.21 to be labelled 2.0 /s

neon epoch
#

I thought mc 2.0 was the NSFW edition

still apex
#

who keeps deleting messages here

eager plover
#

generally just spam bots getting yeeted

eager plover
#

Those damned rusky bots are pushing HARD on that steam scam

last bear
#

Via is getting hit as well, even though every single message is instantly deleted lol

neon epoch
#

but GUYS I REALLY want a $50 steam gift card

burnt ice
young matrix
#

I will look at how to do it at some point but itll prob be a while. if anyone else wants to try its here https://github.com/e-im/pencil. a lot of shit code though that I have no intention of ever touching again pepela

neon epoch
#
private static final List<String> FACETS = List.of("docs-velocity-current", "docs-misc-current", "docs-folia-current", "docs-paper-current", "docs-waterfall-current");

Tried setting the facets on the query but i am having a stroke using the api

#

that and its now 2:30 am

#

and my IDE is freaking out

#

and agolia javadocs have huge ass images in them making them unusable within my ide's insights

#

i think its time for bed

young matrix
#

lol yeah their java library feels like it was auto generated from code targeting some other language

#

doesn't really follow like any common practices

neon epoch
#

I have never seen so many builders and factories in my life 😝

echo canyon
spice temple
#

guess thats some kinda ID

#

oh, just base64

#
{"isMonorepo":true,"type":"github","projects":[{"name":"site","rootDirectory":null,"inspectorUrl":"https://vercel.com/papermc/site/3dK94iBKhenHrc1U7unvnS71Lnku","previewUrl":"site-git-fork-olijeffers0n-feat-add-tags-to-team-papermc.vercel.app","nextCommitStatus":"DEPLOYED","liveFeedback":{"resolved":0,"unresolved":0,"total":0,"link":"site-git-fork-olijeffers0n-feat-add-tags-to-team-papermc.vercel.app"}}]}
neon epoch
#

tempted to just turn off the comment

#

we dont use them on docs anyways

opal flare
#

Leave for now

neon epoch
#

yah i will its just weird that it shits out the base 64

spice temple
#

I use the preview link all the time, plus it shows the status nicely

opal flare
#

Thanks GitHub for not having a way to assign metadata to issues

#

:D

neon epoch
#

does github not have a button at the top for the latest deployment?

#

oh that may be refined github

spice temple
#

Which I don't have on mobile

#

I wish edge enabled add-ons on mobile

#

Would be a killer feature

jagged pecan
eager plover
#

We have one somewhere too

#

it's just not really been a big care

still apex
#

disgit

young matrix
#

looks like that is still being used for docs

neon epoch
#

MFW no squash :P

still apex
#

ill squash you

neon epoch
#

woah woah woah

sharp pivot
#

nothing a little git push --force can't solve

opal flare
#

for Paper/Velocity/etc we do

neon epoch
#

Oh yeah im not bothered haha

#

it wasnt like 100 commits

opal flare
#

@neon epoch for the start script, can you sort the flags now? :D

neon epoch
#

i thought i did that

opal flare
#

and have these two at the very end:

-Dusing.aikars.flags=https://mcflags.emc.gs
-Daikars.new.flags=true
sharp pivot
#

no rest for ollie

opal flare
#

sort them alphabetically I mean

fair river
opal flare
#

:3

neon epoch
#

ill unionise!

#

done

#

at least, python said they were sorted

opal flare
#

lgtm

spice temple
#

in case somebody is bored, its prolly worth to go other some of the page titles and improve their seo

#

i.e. "how to make a paper plugin" has the velocity page as top result and the paper guide only on position 2 😄

#

title should be something like "creating your first velocity plugin"

#

and for paper we dont really have a page like this, but maybe we can rename paper project setup to something like paper plugin project setup?

#

I really hate the ambiguity with paper-plugin.yml paper plugins and paper plugins that just use the paper api

vocal halo
#

Yeah

#

It’s a headache

spice temple
#

and I feel the breadcrumbs should include the project, its part of the url too, but google doesnt display urls

drifting slate
#

What plugin dev pages should be added to the docs?
I may consider contributing some.

eager plover
#

Theres been a few discussions over it, We should probably (and by we, I mean, probs somebody other than me) should create an issue tracking "nice to haves"

#

basically, the notion is that if you expect an article for it on the bukkit/spigot wiki, we want one

drifting slate
eager plover
#

(if you want a high conflict one, a good mysql + hikari guide would be nice)

last bear
#

Though I suppose it could be expanded with more tangible examples of getting and setting object data

eager plover
#

yea, I mean, I didn't kknow that we had such a page, but generally would be nice to have a bit more of a "this is how you actually use it"

fair river
#

Hard agree ^ when it comes to resource for beginner, the more the better imo and if @drifting slate wants to write something more, it is much appreciated. Pepelove

eager plover
#

Like, when somebody wants to do mysql, it's often comment to point them towards stuff like hikari

#

covering some basic aspects of "how to async" might be an idea, for example

jagged pecan
drifting slate
#

So no idea how to expand this

eager plover
#

One day

#

One day I shall rope some sucker into it

drifting slate
#

I should start using a proper database for my bot... right now do I use rethinmdb for which works.... but not optimal...

neon epoch
eager plover
#

oh, yea, for a more general thing, the velocity docs kinda suck

neon epoch
#

folia lol

raw breach
#

how come docs recommend corretto but paper links to adoptium when not having required java version

eager plover
#

we recommended one and then eventually switched to another for some reason

spice temple
#

Clearly because daddy bezos is secretly funding us

jagged pecan
#

money stopped coming in?

#

oh i misread that, bezos sponsorship is only for docs

neon epoch
#

Thought that got changed in paperclip

eager plover
#

Adventure, adventure, adventure

neon atlas
eager plover
#

I always forget when somebody asks, but generally, we need more examples of how to use the thing, maybe adventure would be interested in expanding their examples, but, it’s kinda sad that there is no real good page that we can link people in order to get them acquainted with adventure which isn’t basically just praying they can grasp it from the small loose examples scattered all over the place

neon epoch
#

You see the teensy weensy problem is I’ve never used adventure :P

#

I always designed plugins for both spigot and paper and didn’t wanna have this huge dependency

last bear
#

Cringe

radiant summit
#

imho it's stupidly easy, like, if you can use the IDE you can find all the methods you need

eager plover
#

Yes, but many folk are not really experienced enough to do that

#

Part of the headache is finding the general balance between not wanting to turn the docs into a Java course and accepting some level of reality that most people interacting with our api and adventure for the first time will generally have very little experience of doing so, and generally lack the proclivity to dive into such stuff

radiant summit
#

isn't there a new breaking version for adventure tho

eager plover
#

They’re being Mormons and changing the package in 5.x

radiant summit
#

that's it?

eager plover
#

Well, I've not seen the full set of changes, but that is the like, big thing; ontop of pretty much everything marked as deprecated

jagged pecan
#

It's a little annoying that JD search doesn't pick up adventure stuff

#

Cause it's external

neon epoch
#

Someone teach me all of adventure I’ll make them

#

Actually

#

List the big things and I’ll work out how they work and maybe write them tonight?

#

What’s there like,

  • audience
  • renderer
  • other stuff
eager plover
#

I mean, ChatRenderer is more the "how paper exposes adventure to the chat events"

radiant summit
#

I mean if you don't know about it you probably shouldn't be the one to write it

eager plover
#

not directly adventure, but, er ^

neon epoch
radiant summit
#

sure sure

eager plover
#

(nice to cover, ofc, as I know that that is a stumbling block

#

but, most of it really is down to "here is adventure and here is how you do some basic things"

radiant summit
#

I asked you for a plugin in DMs and you ignored me Ollie 😔

eager plover
#

if it's any consolation, I'd ignore you too

neon epoch
radiant summit
#

XD

neon epoch
neon epoch
#

I'd like to merge 274 and 284 if anyone is around to reveiw them. Im currently in vc

#

thank you kenny

last bear
#

Both looking good

jagged pecan
#

Haha

neon epoch
#

ah :(

#

I like emphatically lol, I was told that both scripts work (tested) and also eh, im not too bothered about downloading with a different name. they can work out how to rename easily enough

jagged pecan
#

its still missing a )

#

shellcheck complained at me without it

neon epoch
#

thanks <3

serene vault
serene vault
lilac edge
#

is there not an mini message -> adventure components converter yet?

#

kind of surprising if not

scenic gull
neon epoch
#

call me dumb but is that not just like MiniMessage.whateverThatParseMethodIs()

young matrix
#

I think they mean like minimessage -> raw adventure

#

which would be sorta more complicated to do well

neon epoch
vocal halo
#

I mean, what is missing in your opinion? I initially wanted to add a more advanced example but then I figured that it doesn’t really make sense.

#

But if there is something that needs to be done just tell me and I’ll add it.

radiant summit
#

@neon epoch #290 I'd add some more stuff not just title it Audiences

#

in general overhaul the entire category and call it like Adventure (not Component API (Adventure), that's a terrible name)

#

and title the first thing idk, Intro to Components then some, then some

neon epoch
vocal halo
#

Adventure API
Adventure Component API

last bear
#

Users don't know what adventure is when they are looking up component usage (other than seeing it in the package name if they pay attention)

#

unless you're interested in contributing to it or looking at its own website/docs specifically, there isn't even any reason for you to know that name

scenic gull
#

Text API, Message API,

eager plover
#

There comes a level of "will they notice it"

#

The reality is that most people see the deprecation and ask "what do I use instead?"

#

and so, I would probably try to keep the name genericish enough

last bear
#

Yeah, it should stay something something Component API or maybe Text Component API

scenic gull
#

I'm not convinced "component" is any more obvious than "adventure" for most users

eager plover
#

I was kinda hoping that the term text would be enough

#

I mean, you can only genericicise it so much

last bear
#

Component is the only word other than message you will see in any of those methods

#

and message won't be in most either. adding text or message to it should make it more obvious, but 'component' is definitely a must

eager plover
#

Still probably going to need the adventure command on discord, but, at least we'll have definiative docs which actually answers what people are looking for, i guess

#

right now it's annoying to link people to the adventure doc page thinking "oh, it's going to cover something that stupidly basic"

#

and it doesn't, and it's like, 99% of the time I don't have an IDE open to do a quick play with, and the whole immutable nature is ofc a confuser for most

radiant summit
eager plover
#

The sole point of the page names is for people to find them, and getting hyper specific with the name will generally not help on that front

vocal halo
#

„How to properly send messages to players in 2024“

vocal halo
neon epoch
#

it is

#

magic

vocal halo
#

xd

neon epoch
#

looks pretty good, just a couple things

vocal halo
#

Yeah most of the things I also thought of changing

#

But thanks. Will work on it later when I am back home

vocal halo
#

@neon epoch i addressed the requested changes.

#

only thing left is that we might want to add the javadocs stuff?

#

so AsyncChatRenderer links to the jd of the class

vocal halo
#

added the links

neon epoch
#

Cool beans I’ll probs not review tonight we’ll see but thanks

vocal halo
#

Take your time. I’m not in a rush haha

mental sleetBOT
#

(65b3019142b7936e54a5a012) // @idle onyx (@juley__ / 696133794624962590) has been banned by @ocean void (188417437295706113)
Reason: spam

mental sleetBOT
#

(65b3138a42b7936e54a5a013) // @hardy delta (@void_celestial / 776319570038226974) has been banned by @ashen sage (220060515337109504)
Reason: NSFW Spam

spice temple
#

this looks not aligned

#

but I can't get it to be better

#

the padding on the badge is the reason I think

eager plover
#

the tag?

spice temple
#

ye

eager plover
#

its the lack of definable borders

raw breach
#

uiii new team page?

eager plover
#

like, if the tags font was the same size as the name, it would probably look better, but waste more space

fair river
#

we don’t need to give leaf any more ego boost

spice temple
#

this looks better

eager plover
#

Like, same size, your brain can see the text on the side and "oh, it's in line"

spice temple
#

ye you added padding but forgot the negative margin to align the name back to the image

#

or you only changed the size

eager plover
#

I just made the font the same size 😄

spice temple
#

I think mine looks ok

eager plover
#

removed the xs tag

#

but, yea, the only way you're going to make that look nicer is to make the overall tag space, i.e. the box itself, the same size as the name text

#

it's really just a case of having definable lines for the brain to see

#

or parting stuff away so that the brain doesn't care to try to organise it

#

The page waste so much space, but there just not the content there for it

#

could maybe move the tag over to the right and add a small blurb type of thing

#

but, er, that means writing blurbs

green kernel
# spice temple

You want to push the Folia Tag more right so that is aligned?

spice temple
#

no, its not vertically aligned to the text

#

thats annoying me

eager plover
#

The issue is that it's in lined with the text

#

but because of the font size different it doesn't line up 100%

last bear
#

Font size shouldnt be the same, mini's update looks good

green kernel
eager plover
#

I'm not saying it should be the same

#

I'm just saying thats why it looks wrong, the brain likes having stuff to line stuff up with

last bear
#

Yeah it's just classic webdev

spice temple
eager plover
#

so the easiest option is to push it to the right and then fillout the right underneath it so it's justified

#

really thouse should be vertical boxes

#

not horizontal, and then you can just have the tag on a new line and not worry about that

green kernel
spice temple
#

man, I am tripping, is there a visual difference between these two?

last bear
#

Uh I dont think so

eager plover
#

Seemingly no

spice temple
#

so my update does nothing then 😄

#

ok what about this?

still apex
#

the folia box thing color or style looks differnet unless thats me

green kernel
#

To blind to see a difference

spice temple
#

left name is aligned with the top of the image

green kernel
#

Ah yeah.

shut delta
last bear
#

My first thought was right is better, but I think they're just different, not better or worse

eager plover
#

yea, right looks better, mainly cos line

spice temple
#

what if I make the image smaller to top and bottom are aligned?

eager plover
#

I think that would maybe look weirder

#

at least, not sure

spice temple
#

lemme actually open the code and try

eager plover
#

Like, I never saw an issue with the tag at first

#

but, I was mostly looking at the name text to the side of it; but, when I move me eyes fully over the thing, it does look jarring because the image isn't where I'd expect it

spice temple
#

urg I hate css

spice temple
#

I think I like this

#

now its perfect

#

Also made the hero smaller since somebody mentioned that somewhere

rigid bluff
spice temple
#

No

neon epoch
#

I was gonna go but haven’t bought plane tickets

raw breach
#

is folia intentionally not featured on the main page or was that just not added yet?

neon atlas
#

given it isn't even released yet kekwhyper

raw breach
#

understandable

last bear
#

perpetually unreleased

neon epoch
#

Let’s just discontinue it

still apex
#

the docs? ghood idea

neon epoch
#

big note about not using the ctor Whats wrong with using the contructor anyone?

spice temple
#

In Javaplugin

#

Don't construct a new java plugin, don't put code into the contractor, use onload/onenable instead

eager plover
#

using a constructor is fine if you know what you're doing

#

but the reality is that 99% of the time code in a constructor is going to try to enable stuff which often extends into more code intended to load up stuff, and all of a sudden one day you add something and it fails because, oops, I depend on X being initialised

#

at the very least, with onLoad/onEnable, there are general promises of what we expect to be there and ready to do stuff

#

in the constructor/class init? we can't many any promises towards anything