#velocity-dev | PaperMC | Page 6

oblique haven Feb 27, 2022, 3:03 PM

#

I’m also not entirely certain that there isn’t protocol changes. ~~I’ll go check the change log and see if there’s anything velocity interacts with which would be a concern.~~ doesn’t look like anything velocity would mess with

fervent mantle Feb 27, 2022, 4:06 PM

#

Hi, I've a problem with the API: when a message breaks, the color resets

oblique haven Feb 27, 2022, 4:14 PM

#

fervent mantle Hi, I've a problem with the API: when a message breaks, the color resets

Can you show your code for creating the message

fervent mantle Feb 27, 2022, 4:15 PM

#

maybe it's because im using the § (so legacy colors)? The code is simple Component#text

oblique haven Feb 27, 2022, 4:15 PM

#

fervent mantle maybe it's because im using the § (so legacy colors)? The code is simple Compone...

Using that character is legacy and not supported

#

That’s probably why you’re seeing the color messed up

fervent mantle Feb 27, 2022, 4:16 PM

#

so i must use minimessage's colors?

oblique haven Feb 27, 2022, 4:16 PM

#

fervent mantle so i must use minimessage's colors?

You don’t have to use minimessage, kyori has a few ways for coloring

#

You could even try using the LegacyComponentSerializer

#

That’d probably work better

fervent mantle Feb 27, 2022, 4:17 PM

#

yeah, that's right

oblique haven Feb 27, 2022, 4:18 PM

#

fervent mantle yeah, that's right

But using the section sign by itself is just going to mess things up for you

#

I highly discourage it

#

The legacy component serializer at least puts it into proper components from what I understand

fervent mantle Feb 27, 2022, 4:18 PM

#

ik, i'll use the & with the legacycomponentserializer

oblique haven Feb 27, 2022, 4:18 PM

#

👍

fervent mantle Feb 27, 2022, 4:21 PM

#

LegacyComponentSerializer#legacyAmpersand.deserialize()
Is this the correct use for the & symbol right?

oblique haven Feb 27, 2022, 4:30 PM

#

Seems right

maiden hawk Feb 27, 2022, 5:46 PM

#

fervent mantle Hi, I've a problem with the API: when a message breaks, the color resets

I noticed this too

#

it looks like, color does not get transfered to a new line

#

tho you can do some workaround around the issue

#

or use minimessage

bold wharf Feb 27, 2022, 5:51 PM

#

that's nothing to do with the API but down to how newlines work

#

do NOT mix legacy and modern text together

maiden hawk Feb 27, 2022, 5:52 PM

#

bold wharf do NOT mix legacy and modern text together

is it an issue if I parse "legacy" text as a component? I do it because people are used to work with it

#

fuck, sorry for the ping

bold wharf Feb 27, 2022, 5:52 PM

#

parsing it properly is not mixing

maiden hawk Feb 27, 2022, 5:52 PM

#

btw, can minimessage work together with legacy?

bold wharf Feb 27, 2022, 5:53 PM

#

MM doesn't parse legacy

maiden hawk Feb 27, 2022, 5:53 PM

#

well

#

fuck

fervent mantle Feb 27, 2022, 5:53 PM

#

with the LegacyComponentSerializer seems working fine

maiden hawk Feb 27, 2022, 5:54 PM

#

Does it?

#

So you can just mix those together?

bold wharf Feb 27, 2022, 5:55 PM

#

components are compnents

#

the serialiser that you use to create those individual components is irrelevant

maiden hawk Feb 27, 2022, 5:57 PM

#

Could I (in theory) make a serializer which would convert legacy to minimessage and then pass it to minimessage's one?

#

I would love to use the benefits of it, but I would also appreciate the legacy codes

bold wharf Feb 27, 2022, 5:59 PM

#

I mean

#

it'sboth of those formats have serialisers

#

there is literally nothing stopping you deserialing and then serialising to the other

#

not to mention that MM has things like placeholders, etc

maiden hawk Feb 27, 2022, 6:03 PM

#

bold wharf there is literally nothing stopping you deserialing and then serialising to the ...

monkaHmm

#

fck another ping

#

I am trying, trust me

burnt dragon Feb 27, 2022, 6:06 PM

#

i mean you could arguably just do a find and replace tbh

maiden hawk Feb 27, 2022, 6:07 PM

#

burnt dragon i mean you could arguably just do a find and replace tbh

I was thinking about that at first, but it seemed too good to be true

#

~~However I see a single issue~~ I don't

#

Gonna do that, I will report how it ends up

#

hex colors are gonna be a bit of a hassle tho

topaz cypress Feb 27, 2022, 6:55 PM

#

For some reason GeyserMC players can see the server in their servers list, but once they join it kicks them, any ideas why?

#

Reason in console "CLOSED_BY_REMOTE_PEER"

maiden hawk Feb 27, 2022, 7:06 PM

#

is there any exception visible in the console?

topaz cypress Feb 27, 2022, 7:16 PM

#

"[geyser]: Bedrock user with ip: /(Blocking this IP out for reasons) has disconnected for reason CLOSED_BY_REMOTE_PEER" is all it says.

#

[floodgate]: Floodgate player who is logged in as Nathan4031 00000000-0000-0000-0009-01ffeed6a406 joined
27.02 19:16:37 [Server] INFO [floodgate]: Floodgate player logged in as Nathan4031 disconnected
27.02 19:16:37 [Server] INFO [geyser]: Nathan4031 has disconnected from the Java server because of Connection closed.
27.02 19:16:37 [Server] INFO [geyser]: Bedrock user with ip: /(Once more not showing the IP for reasons) has disconnected for reason CLOSED_BY_REMOTE_PEER

bold wharf Feb 27, 2022, 7:24 PM

#

all that says is that the server closed the connection

#

or, maybe not, the wording of that stuff is weird

#

all i can say is that something closed the connection

topaz cypress Feb 27, 2022, 7:31 PM

#

I have installed floodgate velocity + geyser and set it up the way it should be, but IDK what else could be the issue.

maiden hawk Feb 27, 2022, 7:33 PM

#

maiden hawk hex colors are gonna be a bit of a hassle tho

This was surprisingly easy, does anyone want to get my legacy to minimessage converter?

topaz cypress Feb 27, 2022, 7:49 PM

#

I just check and I am 100% sure that my geyser is fully setup, but it doesn't seem to work.

sacred musk Feb 27, 2022, 8:09 PM

#

Is there any way to set ping response description field as raw string instead of TextComponent?

burnt dragon Feb 27, 2022, 8:14 PM

#

you can use the gson component serialiser if you've only got raw components as strings to use

maiden hawk Feb 27, 2022, 8:22 PM

#

sacred musk Is there any way to set ping response `description` field as raw string instead ...

May I ask why would you want to do that?

sacred musk Feb 27, 2022, 8:25 PM

#

Some external things like server lists pages didn't implemented handling server motd as TextComponents and I want to pass it like Bungeecord do, as raw string

#

But as I assume it isn't possible by Velocity api

long kelp Feb 27, 2022, 9:59 PM

#

im getting this error when i try to load my plugin anyone know whats going on?

#

this is my main class

spice dagger Feb 27, 2022, 11:09 PM

#

I got this error

#

Address already in use: bind

#

long kelp Feb 27, 2022, 11:14 PM

#

spice dagger

that means a program is already occupying the port 25577

#

do you have a duplicate instance of your server?

spice dagger Feb 27, 2022, 11:15 PM

#

long kelp do you have a duplicate instance of your server?

no

long kelp Feb 27, 2022, 11:15 PM

#

hmm

#

have you ran your server before but closed the command prompt?

spice dagger Feb 27, 2022, 11:16 PM

#

long kelp have you ran your server before but closed the command prompt?

yes

long kelp Feb 27, 2022, 11:16 PM

#

try going into task manager and closing any existing java instances

#

closing a server by just exiting out of command prompt is a bit buggy

#

sometimes it doesnt register with the java runtime to close the program

#

so the instance stays open occupying the port

spice dagger Feb 27, 2022, 11:17 PM

#

long kelp so the instance stays open occupying the port

oh ok

long kelp Feb 27, 2022, 11:17 PM

#

alternatively sometimes you can actually connect to the instance

#

if you can do that then try running /end

long kelp Feb 27, 2022, 11:56 PM

#

anyone know why its telling m that my class doesnt implement a registrable command subinterface

#

#

even though it does

spice dagger Feb 27, 2022, 11:57 PM

#

long kelp anyone know why its telling m that my class doesnt implement a registrable comma...

your pfp looks exactly like someone in my school

long kelp Feb 27, 2022, 11:58 PM

#

lel

#

its not me btw

#

its an image i took off of (french accent) le googel (french accent)

robust mural Feb 27, 2022, 11:59 PM

#

long kelp even though it does

You must implement SimpleCommand

long kelp Feb 28, 2022, 12:00 AM

#

i replaced simplecommand with command because arguments were being odd

#

do i have to change the way im registering the command?

robust mural Feb 28, 2022, 12:00 AM

#

https://velocitypowered.com/wiki/developers/command-api/

The Command API

The Command API lets you create commands that can be executed by a player connected to the proxy or the console. Creating a command Each…

long kelp Feb 28, 2022, 12:01 AM

#

cause rn im registering it with commandManager.register("maintenance", new MaintenanceCommand());

#

hmm

long kelp Feb 28, 2022, 12:02 AM

#

robust mural https://velocitypowered.com/wiki/developers/command-api/

is implementing Command like some deprecated thing or something?

robust mural Feb 28, 2022, 12:02 AM

#

https://jd.velocitypowered.com/3.0.0/com/velocitypowered/api/command/Command.html

#

You can implement RawCommand, SimpleCommand or BrigadierCommand

long kelp Feb 28, 2022, 12:03 AM

#

i see

#

when are they gonna update this page? https://docs.velocitypowered.com/en/latest/developers/command-api.html

#

cause thats whats listed on the front of the velocity page

spice dagger Feb 28, 2022, 12:04 AM

#

how do I add velocity to falixnodes??

long kelp Feb 28, 2022, 12:04 AM

#

spice dagger how do I add velocity to falixnodes??

what do you mean?

#

how do you make a velocity server on a panel?

#

@spice dagger isnt falix a free host?

#

you need atleast 3 servers to create a network. if you have 3 servers then its pretty straight forward. just follow the velocity installation guide

spice dagger Feb 28, 2022, 12:07 AM

#

long kelp you need atleast 3 servers to create a network. if you have 3 servers then its p...

yea I know but how do I set it up on falixnodes

long kelp Feb 28, 2022, 12:07 AM

#

its pretty much the same with every host

#

as long as you have access to the console

#

if you know how to do it on a localhost server

#

doing it on a server host is about the same

spice dagger Feb 28, 2022, 12:09 AM

#

long kelp if you know how to do it on a localhost server

no it doesnt allow custom jar files

long kelp Feb 28, 2022, 12:09 AM

#

then this is your issue

spice dagger Feb 28, 2022, 12:09 AM

#

and it gives errors when default install

long kelp Feb 28, 2022, 12:09 AM

#

if falix doesnt allow custom jars then installing a custom jar is out of the question

#

if the install provided by falix is broken

#

then thats another issue

#

try contacting falix support

long kelp Feb 28, 2022, 12:55 AM

#

is it possible to write to a toml file?

oblique haven Feb 28, 2022, 1:02 AM

#

long kelp is it possible to write to a toml file?

Well, Velocity does it, so I assume it’s possible yes

long kelp Feb 28, 2022, 1:03 AM

#

wait velocity writes to the toml file?

#

time to go through velocity source code to figure out how it does that

oblique haven Feb 28, 2022, 1:05 AM

#

long kelp wait velocity writes to the toml file?

Well… it certainly reads from it, it’s how the config file is

long kelp Feb 28, 2022, 1:06 AM

#

except creating and reading from a file is different from writing to it

#

nvm

#

writing to a toml file is about the same as writing to any file using java

#

shoulda realized this :\

oblique haven Feb 28, 2022, 1:09 AM

#

I think Velocity uses Configurate internally

craggy pecan Feb 28, 2022, 7:26 AM

#

long kelp im getting this error when i try to load my plugin anyone know whats going on?

Place your main class inside a package

long kelp Feb 28, 2022, 7:26 AM

#

Yeah I fixed the issue

craggy pecan Feb 28, 2022, 7:28 AM

#

long kelp when are they gonna update this page? https://docs.velocitypowered.com/en/latest...

All documentation on that subdomain should be assumed to be outdated, use the new wiki

valid gazelle Feb 28, 2022, 7:57 AM

#

Where's the new wiki?

long rock Feb 28, 2022, 7:59 AM

#

https://velocitypowered.com/wiki

Welcome to the Velocity Wiki

Velocity is the ridiculously scalable, flexible Minecraft proxy. Getting started It is simple to get started with Velocity. I need help! If…

inner surge Feb 28, 2022, 2:27 PM

#

How can I remove the change screen when changing server

burnt dragon Feb 28, 2022, 2:27 PM

#

you can't with velocity by default and really you shouldn't

inner surge Feb 28, 2022, 2:27 PM

#

Why not with velocity

bold wharf Feb 28, 2022, 2:28 PM

#

I mean

#

"why not" in general, the thing requires messing with a good chunk of the client state in order to work

#

i.e. it's gotta manually despawn entities and other stuff and many plugins pulling that mess have been buggy af

maiden hawk Feb 28, 2022, 3:49 PM

#

inner surge Why not with velocity

can you do it with bungee tho?

inner surge Feb 28, 2022, 3:49 PM

#

I believe so

#

It's also possible with velocity, but you gotta mess with some shit basically src

#

@maiden hawk

maiden hawk Feb 28, 2022, 3:50 PM

#

inner surge I believe so

really?

#

I mean it would be sick

#

but I imagine it would be well, messy.

#

as cat said, you would need to clear the world manually

bold wharf Feb 28, 2022, 3:58 PM

#

I mean, if you can find a plugin to do it, you can do it on any platform

#

Just, like

#

people generally haven't bothered to recreate all the stupid ass plugins yet™

#

so, there is probs no plugin for it yet

maiden hawk Feb 28, 2022, 4:04 PM

#

I mean

#

Is there really any practical reason to do this?

#

Players don't care about the screen when changing worlds

#

why would they now?

inner surge Feb 28, 2022, 4:16 PM

#

maiden hawk Is there really any practical reason to do this?

yes

#

there is

maiden hawk Feb 28, 2022, 4:16 PM

#

and which?

inner surge Feb 28, 2022, 4:16 PM

#

can't say

#

under nda

maiden hawk Feb 28, 2022, 4:16 PM

#

fr?

#

I mean

inner surge Feb 28, 2022, 4:16 PM

#

yep

#

job

maiden hawk Feb 28, 2022, 4:16 PM

#

I can't think of a single reason

inner surge Feb 28, 2022, 4:16 PM

#

there's

#

tahts why im bothering so much

#

it wil be hella work

maiden hawk Feb 28, 2022, 4:16 PM

#

I don't believe that you need to really do this

#

maybe the xyproblem?

atomic leafBOT Feb 28, 2022, 4:17 PM

#

http://xyproblem.info/

The XY Problem

Asking about your attempted solution rather than your actual problem

torpid panther Feb 28, 2022, 7:16 PM

#

i dont really know if this is the right chat for this, but it seems that this (https://github.com/PaperMC/Velocity/commit/596d4758ba9efedc60ede2789644ea10263c48e4) commit broke the "PlayerResourcePackStatusEvent" in the bukkit api, it just doesnt fire ever.

#

has anyone else experienced this?

#

the build of velocity before that commit works just fine

#

seems like this was mentioned earlier here in this chat too, but that was ignored.

oblique haven Feb 28, 2022, 7:20 PM

#

torpid panther i dont really know if this is the right chat for this, but it seems that this (h...

It stops a bukkit event from firing? That seems very weird

torpid panther Feb 28, 2022, 7:21 PM

#

it may be that the packet isnt being forwarded back to the server

oblique haven Feb 28, 2022, 7:21 PM

#

Maybe it’s due to the origin logic being messed with?

torpid panther Feb 28, 2022, 7:21 PM

#

velocity just eats the packet

oblique haven Feb 28, 2022, 7:21 PM

#

The only other thing that the PR touches other than S2C is the origin logic - so that’s the only place I’d think it could sit

#

Velocity has its own ResourcePackStatus event, can you check if that’s called and print out all the fields of the event

#

Might give us more info on what’s going on

torpid panther Feb 28, 2022, 7:22 PM

#

i do not really know how to write plugins for velocity.

#

havent ever done it

oblique haven Feb 28, 2022, 7:22 PM

#

I can probably take a look this weekend, feel free to just make an issue in the GitHub about it

torpid panther Feb 28, 2022, 7:22 PM

#

will do

long kelp Mar 1, 2022, 5:14 AM

#

anyone know what im doing wrong? i cant use @override and i cant find anything for tabcompletion on simplecommand

oblique haven Mar 1, 2022, 5:19 AM

#

long kelp anyone know what im doing wrong? i cant use @override and i cant find anything f...

there's no args parameter

#

args are held in the invocation

long kelp Mar 1, 2022, 5:19 AM

#

oh

#

facepalm

#

thanks

oblique haven Mar 1, 2022, 5:21 AM

#

long kelp thanks

no problem 👍

heady swallow Mar 1, 2022, 5:59 AM

#

is there a method that can be used to restart the proxy

craggy pecan Mar 1, 2022, 7:38 AM

#

You can shut it down with https://jd.velocitypowered.com/3.0.0/com/velocitypowered/api/proxy/ProxyServer.html#shutdown() and setup a script that restarts it

heady swallow Mar 1, 2022, 9:54 AM

#

alright, ty

halcyon jackal Mar 1, 2022, 3:13 PM

#

I would like to use the latest version of the Adventure library, but unfortunately does it conflict/clash with the one Velocity has bundled.
Is there any way to bypass this?
The error in question is this one: https://paste.helpch.at/momipadame.md

The Parser class itself, as of right now, is this one: https://github.com/Andre601/OneVersionRemake/blob/feature/improve-component-parser/core/src/main/java/com/andre601/oneversionremake/core/Parser.java

bold wharf Mar 1, 2022, 3:14 PM

#

that more looks like you never shaded it

halcyon jackal Mar 1, 2022, 3:14 PM

#

I did tho

#

Haven't pushed the change yet, but added this line to the pom.xml of the velocity module in hopes it would work....

<relocation>
    <pattern>net.kyori</pattern>
    <shadedPattern>com.andre601.oneversionremake.core.dependencies.adventure</shadedPattern>
</relocation>

bold wharf Mar 1, 2022, 3:15 PM

#

that's just a relocation

#

you have adventure api marked as provided

burnt dragon Mar 1, 2022, 3:16 PM

#

you also can't just shade+relocate your own adventure-api and use native methods for components

bold wharf Mar 1, 2022, 3:16 PM

#

not to mention you'd need to use platform too ^^

burnt dragon Mar 1, 2022, 3:17 PM

#

and sadly there isn't a velocity platform so :')

bold wharf Mar 1, 2022, 3:17 PM

#

o o f

burnt dragon Mar 1, 2022, 3:17 PM

#

submit a PR to update adventure?

bold wharf Mar 1, 2022, 3:17 PM

#

was there any API breaks? thonk

burnt dragon Mar 1, 2022, 3:17 PM

#

nope

#

one line pr tbh :')

bold wharf Mar 1, 2022, 3:17 PM

#

if no ABI breaks then i don't see why not

halcyon jackal Mar 1, 2022, 3:18 PM

#

From what I know did at most the minimessage module break in some way

burnt dragon Mar 1, 2022, 3:18 PM

#

wasn't a breaking change as there was no release

halcyon jackal Mar 1, 2022, 3:18 PM

#

Like MiniMessage.get() became MiniMessage.miniMessage()

halcyon jackal Mar 1, 2022, 3:18 PM

#

burnt dragon wasn't a breaking change as there was no release

uh.......

#

https://github.com/Andre601/OneVersionRemake/pull/135

GitHub

Bump adventure-text-minimessage from 4.0.0-SNAPSHOT to 4.10.0 in /c...

Bumps adventure-text-minimessage from 4.0.0-SNAPSHOT to 4.10.0.

Release notes
Sourced from adventure-text-minimessage's releases.

🌏 Adventure 4.10.0
Adventure 4.10.0 is a feature release of A...

burnt dragon Mar 1, 2022, 3:19 PM

#

snapshot builds are allowed to break as much as they want, that's how semver works

halcyon jackal Mar 1, 2022, 3:19 PM

#

There was...

burnt dragon Mar 1, 2022, 3:19 PM

#

as soon as you make a release, then semver comes into play

bold wharf Mar 1, 2022, 3:20 PM

#

There was no ABI breaks between the releases of adventure

#

ABI breaks in the snapshots in the meantime or other components are irrelevant

halcyon jackal Mar 1, 2022, 3:22 PM

#

So what now? Simply PR to bump the version?

burnt dragon Mar 1, 2022, 3:23 PM

#

yup

halcyon jackal Mar 1, 2022, 3:23 PM

#

mkay... Will see if I can manage that xD

narrow gate Mar 1, 2022, 4:56 PM

#

Can I do PR to add Kotlin Symbol Processing (kotlin's analogue for annotation processing) to velocity api?

#

basic kotlin annotation processing executing 8 times slower than ksp

wicked stag Mar 1, 2022, 5:12 PM

#

@bold wharf can we continue the discussion here about pr #657 i have a really bad connection now and it makes hard to use the github page (that was the reason for the duplicate message too)

bold wharf Mar 1, 2022, 5:12 PM

#

no-ping

#

The vhost getHostString just returns the string that was passed into the unresolved socket thing

#

if extra crap is getting in there it's further up and should be in the more general cleaning logic, but I question how such mangled stuff got in there

wicked stag Mar 1, 2022, 5:13 PM

#

when i used the official client it had the /<unresolved>:XXXXX part

bold wharf Mar 1, 2022, 5:13 PM

#

and, how are you seeing that?

#

where from?

#

#

is the only place where that's added in

wicked stag Mar 1, 2022, 5:14 PM

#

in the issue i posted a simple plugin that logged this info

bold wharf Mar 1, 2022, 5:14 PM

#

and, velocity doesn't use toString

#

conn.getRemoteAddress().toString()

#

that's why you're seeing the /unresolved

wicked stag Mar 1, 2022, 5:15 PM

#

but i made another version which looks like the velocity internal:

@Plugin(
        id = "handshakemonitor",
        name = "Handshakemonitor",
        version = "1.1-SNAPSHOT"
)
public class Handshakemonitor {

    @Inject
    private Logger logger;

    @Subscribe
    public void onHandShake(ConnectionHandshakeEvent e) {
        InboundConnection conn = e.getConnection();
        logger.info("{} -> {}", conn.getRemoteAddress(), conn.getVirtualHost().map(InetSocketAddress::getHostString).orElse("").toLowerCase(Locale.ROOT));
    }
}

#

and got the same result

bold wharf Mar 1, 2022, 5:16 PM

#

what result?

wicked stag Mar 1, 2022, 5:16 PM

#

domain/<unresolved>:XXXXX

bold wharf Mar 1, 2022, 5:16 PM

#

I'd need to see it

#

cos, the only way that /unresolved gets in there is from a toString on the address object

#

so something somewhere else is screwing that one up

#

what you PR'd doesn't make sense given how getHostString works, if getHostString returns a thing with the unresolved in it, something is mangling it elsewhere

wicked stag Mar 1, 2022, 5:18 PM

#

if you want i can send you the unmasked log in dm

bold wharf Mar 1, 2022, 5:18 PM

#

I don't accept DMs

#

you'd need to send it to pencil but might need a paste.gg link or something, idr

wicked stag Mar 1, 2022, 5:20 PM

#

then i'd prefer to not publicly expose my backend ip

#

but yeah the getHostString does return more than just the domain

#

and the fix just removes that data if it present

bold wharf Mar 1, 2022, 5:21 PM

#

the fix if that's the issue is in the wrong place

#

But, I don't see how that could be the issue

wicked stag Mar 1, 2022, 5:22 PM

#

but getHostString is a builtin java method, so i can't see another possible fix

bold wharf Mar 1, 2022, 5:22 PM

#

getHostString is a builtin java method which returns the hostname set when createUnresolved is called

#

if that s returning a string with /<unresolved>, there is an issue higher up

#

No

wicked stag Mar 1, 2022, 5:24 PM

#

when i used a cli chat client to test it (can't run mc on a rpi) i got the base64 data

maiden hawk Mar 1, 2022, 5:24 PM

#

I can try to test it if you want

bold wharf Mar 1, 2022, 5:25 PM

#

the thing only appends :port on the end of the hostname

maiden hawk Mar 1, 2022, 5:25 PM

#

Couldn't that also cause the issue?

bold wharf Mar 1, 2022, 5:25 PM

#

well, no

#

I mean

#

toString only appends :port on it

#

at least to me that sounds like something installed on the proxy is scuffing the hostname

maiden hawk Mar 1, 2022, 5:25 PM

#

hmmm

wicked stag Mar 1, 2022, 5:26 PM

#

you mean plugin installed?

maiden hawk Mar 1, 2022, 5:26 PM

#

I can try to run a bare proxy without any plugin, except the hostname shower and then try to connect with notchian client?

bold wharf Mar 1, 2022, 5:26 PM

#

well

#

plugin

#

the cli client

wicked stag Mar 1, 2022, 5:27 PM

#

i tried it without plugins and it had the same issue

maiden hawk Mar 1, 2022, 5:27 PM

#

even with notchian client?

bold wharf Mar 1, 2022, 5:27 PM

#

Well, what's the contents of the handshake packet?

maiden hawk Mar 1, 2022, 5:28 PM

#

is the cli chat client open source?

wicked stag Mar 1, 2022, 5:28 PM

#

oh yep, forgot to send it

#

https://github.com/MCCTeam/Minecraft-Console-Client

maiden hawk Mar 1, 2022, 5:28 PM

#

According to wiki.vg the hostname sent should be:

Hostname or IP, e.g. localhost or 127.0.0.1, that was used to connect. The Notchian server does not use this information. Note that SRV records are a simple redirect, e.g. if _minecraft._tcp.example.com points to mc.example.org, users connecting to example.com will provide example.org as server address in addition to connecting to it.

maiden hawk Mar 1, 2022, 5:28 PM

#

wicked stag <https://github.com/MCCTeam/Minecraft-Console-Client>

gonna take a look at the source

#

oh wait

#

it is C#

#

Well that shouldn't be that off from Java right?

#

ok looking on the source, the cli chat client sends the server address obtained from this method:

        public string GetServerAddress(string serverAddress)
        {
            if (ForgeEnabled())
                return serverAddress + "\0" + forgeInfo.Version + "\0";
            return serverAddress;
        }

#

Maybe here is the issue?

#

while serverAddresss is the bare thing inputted by the user

#

Or at least I think

wicked stag Mar 1, 2022, 5:34 PM

#

it's not about debugging the chat client as the issue started with the vanilla client

maiden hawk Mar 1, 2022, 5:34 PM

#

wait

#

so the issue is also present with the vanilla client?

#

I thought you couldn't test it

wicked stag Mar 1, 2022, 5:34 PM

#

i just used the chat client to continue working on the issue because the only available thing for me at the moment is a rpi4

maiden hawk Mar 1, 2022, 5:35 PM

#

Shouldn't the rpi be able to run Minecraft?

wicked stag Mar 1, 2022, 5:35 PM

#

in theory yes, in practice no

maiden hawk Mar 1, 2022, 5:35 PM

#

you have the low memory version?

wicked stag Mar 1, 2022, 5:37 PM

#

more like driver issues, video performance is also bad, like i can't watch a youtube video nor an mp4 file without tearing and low fps

#

but 4gb version

maiden hawk Mar 1, 2022, 5:37 PM

#

understandable

#

Imma try it for you

wicked stag Mar 1, 2022, 5:37 PM

#

ty

maiden hawk Mar 1, 2022, 5:38 PM

#

wicked stag but i made another version which looks like the velocity internal: ```java @Plu...

I will just reply to this, so I can have the source easily accessable

#

However, I can only test this on localhost

wicked stag Mar 1, 2022, 5:44 PM

#

well i think it should work the same or at least similarly

maiden hawk Mar 1, 2022, 5:45 PM

#

gonna use build #115

#

done, booting up minecraft

#

/127.0.0.1:44204 -> localhost

This is what gets printed

#

Weird

#

I am using latest build, notchian minecraft 1.18

#

gonna try what happens with fabric

#

The same thing

#

Maybe there's an issue somewhere else in the chain?

wicked stag Mar 1, 2022, 5:53 PM

#

it might only happen with domains or a specific java vendor?

#

idk if anything else could affect it

#

or maybe linux/windows

#

i run the server in quay.io/parkervcp/pterodactyl-images:debian_openjdk-15-hotspot

maiden hawk Mar 1, 2022, 6:02 PM

#

@wicked stag Please take a look on my latest comment on the PR, what do you think of my theory?

wicked stag Mar 1, 2022, 6:07 PM

#

i found that description too and i have no idea how can String form of the address look like domain///XXX.XXX.XXX.XXX:XXXXX///XXXXXXXXXX///long-base64-encoded-binary-data

#

where the part after the domain is the source ip port

#

and idk what is the number and base64 binary data

#

or another solution is to keep the server address field from the handshake packet as a string and use that for getting forced hosts

#

that way there couldn't be a single thing affecting the final string representation of the host

maiden hawk Mar 1, 2022, 6:18 PM

#

good catch

#

I thought that velocity used the hostname in the packet first

bold wharf Mar 1, 2022, 6:26 PM

#

it does use the hostame from the handshake packet

#

you can follow that logic around

maiden hawk Mar 1, 2022, 6:28 PM

#

I am blind then

wicked stag Mar 1, 2022, 6:29 PM

#

but it gets converted to InetSocketAddress at some point

maiden hawk Mar 1, 2022, 6:29 PM

#

gimme a while

wicked stag Mar 1, 2022, 6:36 PM

#

also is there any benefit of using InetSocketAddress instead of a string?

maiden hawk Mar 1, 2022, 6:38 PM

#

bold wharf it does use the hostame from the handshake packet

can confirm

#

sorry for the misunderstandement

#

this is really weird

#

can you try and deploy this on production noel?

#

So we can see where the issue is?

wicked stag Mar 1, 2022, 6:40 PM

#

maiden hawk can you try and deploy this on production noel?

you mean a public server without my fix?

maiden hawk Mar 1, 2022, 6:40 PM

#

Well I would want to see what InetSocketAddress#getHostString spits out in your case

#

because as I've said, it behaves normaly on local

wicked stag Mar 1, 2022, 6:44 PM

#

give me a minute

#

or a few

#

brb in about 15min

wicked stag Mar 1, 2022, 7:21 PM

#

@maiden hawk i modified the plugin to this:

@Subscribe
public void handler(PreLoginEvent e) {
    InboundConnection conn = e.getConnection();
    String vhost = conn.getVirtualHost().map(InetSocketAddress::getHostString).orElse("").toLowerCase(Locale.ROOT);
    if (vhost.contains("mct")) {
        e.setResult(PreLoginEvent.PreLoginComponentResult.denied(Component.text(vhost)));
    }
}

the server is available at test-a.mct.noelnemeth.com and test-b.mct.noelnemeth.com

maiden hawk Mar 1, 2022, 7:22 PM

#

should I join?

wicked stag Mar 1, 2022, 7:22 PM

#

it will respond you with the host string

maiden hawk Mar 1, 2022, 7:22 PM

#

I see

#

just please, don't share my IP

#

oh shiiit

wicked stag Mar 1, 2022, 7:23 PM

#

don't worry i didn't plan it 😄

maiden hawk Mar 1, 2022, 7:24 PM

#

test-a

#

I will write a response to the PR stating our findings, ok?

wicked stag Mar 1, 2022, 7:27 PM

#

ok

maiden hawk Mar 1, 2022, 7:27 PM

#

which build of velocity do you use?

wicked stag Mar 1, 2022, 7:29 PM

#

latest dev/3.0.0 which has my fix

maiden hawk Mar 1, 2022, 7:29 PM

#

ok

#

btw, can you please try to parse that base64 string? My client didn't log it and I am too lazy to write it by hand

#

I just want to make sure that my ip isn't there

wicked stag Mar 1, 2022, 7:30 PM

#

i can dm it to you

#

but it's binary data

maiden hawk Mar 1, 2022, 7:30 PM

#

pheeew

#

well guess I will have to risk it

#

nowadays, anyone has your ip anyway.

wicked stag Mar 1, 2022, 7:30 PM

#

actually i need to remove test-b i ran out of available domains on tcpshield 😄

#

i leave test-a up for a while

#

until i need one more domain

maiden hawk Mar 1, 2022, 7:31 PM

#

wicked stag actually i need to remove test-b i ran out of available domains on tcpshield 😄

oof

wicked stag Mar 1, 2022, 7:33 PM

#

yeah i'm on free plan, since i just occasionally host servers for friends

maiden hawk Mar 1, 2022, 7:33 PM

#

do you need tcp shield then?

wicked stag Mar 1, 2022, 7:35 PM

#

chinese script kiddos will find the backend ip and bruteforce or dos everything

maiden hawk Mar 1, 2022, 7:35 PM

#

really?

#

I've never met with that

wicked stag Mar 1, 2022, 7:35 PM

#

that's why i started using tcpshield and cloudflare

maiden hawk Mar 1, 2022, 7:36 PM

#

I use cloudlfare all the time

#

but it sucks they only proxy HTTP and WS

wicked stag Mar 1, 2022, 7:37 PM

#

until i found tcpshield i proxied mc over websockets XD

maiden hawk Mar 1, 2022, 7:37 PM

#

I will pretend I didn't see that

wicked stag Mar 1, 2022, 7:37 PM

#

it worked surprisingly well

#

like 40ms ping

maiden hawk Mar 1, 2022, 7:37 PM

#

GJ I guess

wicked stag Mar 1, 2022, 7:40 PM

#

anyways i'm happy with my fix so i'll leave it for the velocity team to decide how they want to fix it in the official version

maiden hawk Mar 1, 2022, 7:40 PM

#

Okayge

bold wharf Mar 1, 2022, 7:42 PM

#

wait

#

you've been using TCPShield all this time?

maiden hawk Mar 1, 2022, 7:42 PM

#

wait

#

that could explain

wicked stag Mar 1, 2022, 7:42 PM

#

yep

maiden hawk Mar 1, 2022, 7:42 PM

#

everything

wicked stag Mar 1, 2022, 7:42 PM

#

why?

maiden hawk Mar 1, 2022, 7:42 PM

#

I didn't realize :D

bold wharf Mar 1, 2022, 7:42 PM

#

...........

#

so

maiden hawk Mar 1, 2022, 7:42 PM

#

they could do some whacky stuff

bold wharf Mar 1, 2022, 7:42 PM

#

I mean, based upon the fact that they have a plugin to literally cleanup the handshake packet...

maiden hawk Mar 1, 2022, 7:43 PM

#

bold wharf I mean, based upon the fact that they have a plugin to literally cleanup the han...

Hm?

bold wharf Mar 1, 2022, 7:43 PM

#

TCPShield literally has a plugin

maiden hawk Mar 1, 2022, 7:43 PM

#

To his defend, many (mostly professional networks) use it, so I think something like official support would be appreciated by many

bold wharf Mar 1, 2022, 7:43 PM

#

That fix is bad anyways, as I keep saying

wicked stag Mar 1, 2022, 7:43 PM

#

maiden hawk test-a

it wasn't enabled during this test

maiden hawk Mar 1, 2022, 7:43 PM

#

wait

#

really?

#

Hmmm

bold wharf Mar 1, 2022, 7:44 PM

#

Yes

maiden hawk Mar 1, 2022, 7:44 PM

#

so tcp shield isn't the cause?

bold wharf Mar 1, 2022, 7:44 PM

#

The literal statement here is that the things returning mangled data

maiden hawk Mar 1, 2022, 7:44 PM

#

yes

bold wharf Mar 1, 2022, 7:44 PM

#

which, cleaning that out in a very specific case is not the proper solution

#

you'd need to clear the entire thing

half locust Mar 1, 2022, 7:44 PM

#

maiden hawk To his defend, many (mostly professional networks) use it, so I think something ...

Just because something is widely used does not mean it's good software. Coreprotect is extremely popular, yet it's a literal piece of crap internally

maiden hawk Mar 1, 2022, 7:44 PM

#

but noel says that tcp shield wasn't enabled at the moment of testing

bold wharf Mar 1, 2022, 7:44 PM

#

and, idk if we should be maintaining crud to deal with oddball platforms

maiden hawk Mar 1, 2022, 7:45 PM

#

half locust Just because something is widely used does not mean it's good software. Coreprot...

I use CoreProtect, is there any issue with it? (I haven't looked at it's source)

maiden hawk Mar 1, 2022, 7:45 PM

#

maiden hawk but noel says that tcp shield wasn't enabled at the moment of testing

Cat?

bold wharf Mar 1, 2022, 7:45 PM

#

https://github.com/TCPShield/RealIP/blob/41ff3f412c96a0808e95892224d62bd33e7b16ca/src/main/java/net/tcpshield/tcpshield/TCPShieldPacketHandler.java#L136

GitHub

RealIP/TCPShieldPacketHandler.java at 41ff3f412c96a0808e95892224d62...

The Spigot, Bungee and Velocity plugin that parses client IP addresses passed from the TCPShield network. - RealIP/TCPShieldPacketHandler.java at 41ff3f412c96a0808e95892224d62bd33e7b16ca · TCPShie...

half locust Mar 1, 2022, 7:45 PM

#

eh it works (somehow), but the fact that it does is frankly shocking.

bold wharf Mar 1, 2022, 7:45 PM

#

that's LITERALLY their format.

maiden hawk Mar 1, 2022, 7:46 PM

#

visible_confusion

#

now I am confused

wicked stag Mar 1, 2022, 7:46 PM

#

oh

maiden hawk Mar 1, 2022, 7:47 PM

#

Well

#

that's a mystery solved

wicked stag Mar 1, 2022, 7:48 PM

#

so the cleanup doesn't happen before the decision made about the server?

maiden hawk Mar 1, 2022, 7:48 PM

#

wait

#

Now I am 2 times confused

maiden hawk Mar 1, 2022, 7:48 PM

#

half locust eh it works (somehow), but the fact that it does is frankly shocking.

Is it that bad?

wicked stag Mar 1, 2022, 7:49 PM

#

maiden hawk Now I am 2 times confused

tcp shield passes client data in the server address field so the plugin can restore the original client ip

maiden hawk Mar 1, 2022, 7:49 PM

#

wicked stag tcp shield passes client data in the server address field so the plugin can rest...

okay, and that does not work for some reason?

wicked stag Mar 1, 2022, 7:50 PM

#

the plugin removes that information late or it doesn't even remove it idk

bold wharf Mar 1, 2022, 7:50 PM

#

You need their plugin to clean up that stuff

maiden hawk Mar 1, 2022, 7:50 PM

#

the plugin should remove it before the server choose stuff happens

#

do you have it installed noel?

half locust Mar 1, 2022, 7:50 PM

#

maiden hawk Is it that bad?

Every interaction opens a new SQL connection
Classes nested in if statements (didn't even know that was posible)
massive "util" class that does everything from SQL connections to formatting

maiden hawk Mar 1, 2022, 7:50 PM

#

half locust - Every interaction opens a new SQL connection - Classes nested in `if` statemen...

aaaarrree yyyouuu kkkiddin?

#

I am going to remove that thing ASAP from my server

wicked stag Mar 1, 2022, 7:51 PM

#

maiden hawk do you have it installed noel?

it was originally, then removed during testing

maiden hawk Mar 1, 2022, 7:51 PM

#

half locust - Every interaction opens a new SQL connection - Classes nested in `if` statemen...

does this mean, that every time someone breaks a block a new connection is made?

maiden hawk Mar 1, 2022, 7:51 PM

#

wicked stag it was originally, then removed during testing

OOF

#

Well that's mystery solved

half locust Mar 1, 2022, 7:51 PM

#

iirc yes 🙂

maiden hawk Mar 1, 2022, 7:52 PM

#

half locust iirc yes 🙂

That can't be real

#

I refuse to believe it

#

I hope it is at least async, right?

#

well, the good thing is, I use sqlite for coreprotect

half locust Mar 1, 2022, 7:52 PM

#

given my server never lagged to death, yes

#

same

maiden hawk Mar 1, 2022, 7:53 PM

#

maiden hawk well, the good thing is, I use sqlite for coreprotect

This is because my shared host only allows maximum size of 1GB per DB

#

ikr cringe

half locust Mar 1, 2022, 7:53 PM

#

👀 https://f.u11.io/z82u3f

maiden hawk Mar 1, 2022, 7:54 PM

#

uhhh

#

wtf

#

you might consider doing a purge

#

storing a 100GB CP DB on your Desktop seems like a horrible idea tbh

wicked stag Mar 1, 2022, 7:55 PM

#

@maiden hawk could you try now that i have re-enabled tcpshield plugin?

maiden hawk Mar 1, 2022, 7:55 PM

#

okay

maiden hawk Mar 1, 2022, 7:55 PM

#

wicked stag <@!264852356821286912> could you try now that i have re-enabled tcpshield plugin...

still the same thing

half locust Mar 1, 2022, 7:55 PM

#

maiden hawk storing a 100GB CP DB on your Desktop seems like a horrible idea tbh

dunno why the hostname has desktop tbh. It's effectively a dedi.
besides, we have the space (top is primary SSD, bottom is HDD for backups) https://f.u11.io/JLNyLi

maiden hawk Mar 1, 2022, 7:56 PM

#

ok lol

#

why don't you do a purge?

half locust Mar 1, 2022, 7:56 PM

#

anyways should move this to #general if you want to continue before cat or someone yells at us

maiden hawk Mar 1, 2022, 7:57 PM

#

monkaX

#

true

wicked stag Mar 1, 2022, 7:57 PM

#

maiden hawk still the same thing

maybe my plugin acts before tcpshield, i removed it now only tcp shield is enabled

maiden hawk Mar 1, 2022, 7:58 PM

#

wicked stag maybe my plugin acts before tcpshield, i removed it now only tcp shield is enabl...

uhh should I try again then?

wicked stag Mar 1, 2022, 7:58 PM

#

yep, please

#

oh, nvm

maiden hawk Mar 1, 2022, 7:59 PM

#

?

wicked stag Mar 1, 2022, 7:59 PM

#

it should work since it's running the modified velocity version

maiden hawk Mar 1, 2022, 8:00 PM

#

#

yupp

wicked stag Mar 1, 2022, 8:00 PM

#

the base setup was tcpshield plugin with official velocity, which didn't work

#

but the plugin rewrites the packet so it should work

maiden hawk Mar 1, 2022, 8:01 PM

#

visible_confusion

wicked stag Mar 1, 2022, 8:01 PM

#

maybe the server decision is made before the rewrite?

maiden hawk Mar 1, 2022, 8:02 PM

#

Looking at the source, the event in which their plugin operates

#

should be fired before server choosing begins

#

Maybe it is a nonblocking event? Therefore the proxy doesn't wait for its execution and just continues doing its job, possibly being faster than tcpshield?

heady swallow Mar 2, 2022, 12:24 PM

#

am I able to send a player to a specific world inside a specific server, or am I just able to send the player to the server and the server handles what world

bold wharf Mar 2, 2022, 12:29 PM

#

no, but, yes

#

the proxy can't control where people are in a server, etc

#

but, nothing stopping you sending a message to the server of which you have some plugin on the server to send people there or whatever

heady swallow Mar 2, 2022, 12:31 PM

#

could you guide me in the right direction of sending a message from what you described?

light kettle Mar 2, 2022, 2:40 PM

#

#

gives me this error

oblique haven Mar 2, 2022, 2:41 PM

#

light kettle

did you compile velocity by yourself

light kettle Mar 2, 2022, 2:41 PM

#

yes but it never gave problems

oblique haven Mar 2, 2022, 2:41 PM

#

try removing plugins 1 by 1 until it stops, it looks like it's being caused by a plugin

#

I'd start with any stats plugins and stuff like that

bold wharf Mar 2, 2022, 2:42 PM

#

best guess is make sure that you used the correct jar

#

though, I mean

oblique haven Mar 2, 2022, 2:43 PM

#

bold wharf best guess is make sure that you used the correct jar

I think one of their plugins hooks into the proxy's provided bstats, and the backend for that may have changed

bold wharf Mar 2, 2022, 2:43 PM

#

if it loaded that far one would assume it's gotta be

#

Yea, probably

oblique haven Mar 2, 2022, 2:44 PM

#

https://gyazo.com/0627561810744055dd7639e059731ab3

Gyazo

#

I smell that bstats changed and a plugin didn't upload

#

but we'll see

oblique haven Mar 2, 2022, 3:28 PM

#

@bold wharf added a quick hotfix to another spotty location in the resource pack send, it was queuing the initial resource pack rather than the intended one received from the event, which could also cause this issue, just a heads up that it's another piece post your review

maiden hawk Mar 2, 2022, 7:44 PM

#

oh no

#

you pinged cat

#

you are going to be sent to hell

oblique haven Mar 2, 2022, 7:57 PM

#

maiden hawk you are going to be sent to hell

I pinged him with something meaningful, I didn't ping him while there was an active conversation going which he was apart of like most people do

steady trellis Mar 2, 2022, 8:21 PM

#

oblique haven I pinged him with something meaningful, I didn't ping him while there was an act...

still says dont ping him xd

oblique haven Mar 2, 2022, 8:32 PM

#

steady trellis still says dont ping him xd

let him tell me that shrug

steady trellis Mar 2, 2022, 8:33 PM

#

sayless

maiden hawk Mar 3, 2022, 7:58 AM

#

This is kinda awkward but can someone please take look at #637?
I kinda need it fixed, so I don't need to use my fork.

gleaming ore Mar 3, 2022, 3:57 PM

#

How difficult would it be to make an API for sending spawn and destroy packets, is there anything in velocity that allows you to do this? Trying to implement a server side player culling system.

agile ore Mar 3, 2022, 4:01 PM

#

well, this is my code right now:
@Subscribe public void onLogin(final PostLoginEvent e) { ProxiedPlayer p = e.getPlayer(); String hostName = p.getPendingConnection().getVirtualHost().getHostString();
can someone help me with this?
How can I let the player issue a command with velocity?

oblique haven Mar 3, 2022, 4:08 PM

#

gleaming ore How difficult would it be to make an API for sending spawn and destroy packets, ...

Pretty difficult - you’d need to fork velocity, those packets aren’t handled

gleaming ore Mar 3, 2022, 4:13 PM

#

Ah, I figured. Is there any place I should put that functionality in when I fork it? Didn't know if there was a packet manager class. Sorry if my question is ignorant, not familiar with the codebase.

oblique haven Mar 3, 2022, 4:17 PM

#

gleaming ore Ah, I figured. Is there any place I should put that functionality in when I fork...

There’s a Registry which you can mess with

#

I’d recommend looking at how the other packets are drawn up, but it’s called something Registry

gleaming ore Mar 3, 2022, 4:26 PM

#

oblique haven There’s a Registry which you can mess with

I cant find anything referring to registry by doing a simple github search, am I missing something?

#

Never mind, I found it in Velocity/proxy/src/test/java/com/velocitypowered/proxy/protocol/PacketRegistryTest.java Is this what you were referring to?

oblique haven Mar 3, 2022, 4:32 PM

#

gleaming ore Never mind, I found it in `Velocity/proxy/src/test/java/com/velocitypowered/prox...

com.velocitypowered.proxy.protocol.StateRegistry

gleaming ore Mar 3, 2022, 4:34 PM

#

Perfect, thanks a ton!

#

Im assuming theres no docs for this?

maiden hawk Mar 3, 2022, 4:40 PM

#

gleaming ore How difficult would it be to make an API for sending spawn and destroy packets, ...

Are you sure that doing this is a good idea?

maiden hawk Mar 3, 2022, 4:40 PM

#

gleaming ore Im assuming theres no docs for this?

Unfortunately, Velocity is mostly undocumented

#

Most things are in JD

#

but that's really only the api

agile ore Mar 3, 2022, 4:41 PM

#

agile ore well, this is my code right now: `@Subscribe public void onLogin(final PostLogin...

someone?

bold wharf Mar 3, 2022, 4:42 PM

#

get the command manager, map, or whatever it was called and use the execute method

#

(See the javadocs)

gleaming ore Mar 3, 2022, 4:43 PM

#

maiden hawk Are you sure that doing this is a good idea?

Ehhh, not sure, I told myself I would give it a day and see where I get. I really have no other good solution. Working to achieve 10k players in a world with minestom, which is the easy part but making client performance workable is the hard part, hence the dynamic culling

maiden hawk Mar 3, 2022, 4:43 PM

#

why can't you do this directly from minestom?

#

btw, can minestom really handle that much?

#

Considering that even Velocity pbly cannot

gleaming ore Mar 3, 2022, 4:44 PM

#

The performance overhead would be nuts probably with 10k players

bold wharf Mar 3, 2022, 4:44 PM

#

minestorm basically does nothin on its own

maiden hawk Mar 3, 2022, 4:44 PM

#

Ikr?

gleaming ore Mar 3, 2022, 4:44 PM

#

Yeah it can

maiden hawk Mar 3, 2022, 4:44 PM

#

That seems sussy

#

iirc, noone even managed to get 10k players with one velocity proxy

gleaming ore Mar 3, 2022, 4:45 PM

#

Going to use multiple proxies, Ive been talking with the contributors over on their discord

gleaming ore Mar 3, 2022, 4:45 PM

#

maiden hawk iirc, noone even managed to get 10k players with one velocity proxy

yeah, Im assuming ill need 3-5

maiden hawk Mar 3, 2022, 4:45 PM

#

visible_confusion it just seems weird that minestom could handle more players than velocity

gleaming ore Mar 3, 2022, 4:45 PM

#

bandwidth should be fun 🙃

maiden hawk Mar 3, 2022, 4:45 PM

#

I realize that minestom is really only a skeleton

gleaming ore Mar 3, 2022, 4:45 PM

#

Yep, theres nothing to it

maiden hawk Mar 3, 2022, 4:45 PM

#

But I would dare to say that it still processes way more data than proxy

bold wharf Mar 3, 2022, 4:46 PM

#

proxies basically get weird, like, it's still gotta mutate stuff, it's still gotta copy data around, etc

gleaming ore Mar 3, 2022, 4:46 PM

#

maiden hawk <:visible_confusion:649667205641928724> it just seems weird that minestom could ...

Its only viable to offload packet processing to a proxy, I doubt minestom can do 10k players actually

bold wharf Mar 3, 2022, 4:46 PM

#

am sure that one could get velocity to handle that many players

gleaming ore Mar 3, 2022, 4:47 PM

#

with one instance?

bold wharf Mar 3, 2022, 4:47 PM

#

Just, you'd need to throw a ton of resources at it and that point you'd be better off just load balancing

gleaming ore Mar 3, 2022, 4:47 PM

#

Yeah, makes sense

bold wharf Mar 3, 2022, 4:47 PM

#

or, wait, would netty cope with that

maiden hawk Mar 3, 2022, 4:47 PM

#

bold wharf am sure that one could get velocity to handle that many players

iirc someone told me that the max (with velocity 1.0 iirc) players someone managed to achieve was 5k or 3k, not sure

bold wharf Mar 3, 2022, 4:48 PM

#

Like, I don't recall how efficent the selectors are

maiden hawk Mar 3, 2022, 4:48 PM

#

they used 48c xeon

gleaming ore Mar 3, 2022, 4:48 PM

#

You could probably do 10k on a mulan epyc then

maiden hawk Mar 3, 2022, 4:49 PM

#

I believe so

#

But I think you would hit architectural limits

#

The thing is, noone has ever tried it

#

so we really don't know

#

but what are you trying to achive with having 10k players on a single server?

#

Btw, bandwidth will also be pain in the ass

gleaming ore Mar 3, 2022, 4:50 PM

#

No idea on the specifics yet, it would be a one off event though. Some kind of gamemode like hide and seek etc.

#

Yeah ive already done the numbers on bandwidth, 10gbps minimum

maiden hawk Mar 3, 2022, 4:51 PM

#

gleaming ore Yeah ive already done the numbers on bandwidth, 10gbps minimum

Gbps or GBps?

gleaming ore Mar 3, 2022, 4:52 PM

#

Gbps, I dont think any hosting providers offer that much haha

#

AWS maybe? I though they only do 50gbps

maiden hawk Mar 3, 2022, 4:52 PM

#

I've found out, that you should count about 1Mbps for one connected player

#

so this makes sense

gleaming ore Mar 3, 2022, 4:53 PM

#

This whole thing is a sorta long term project with a team im working with. Im just trying to figure out now where to steer things based of theoretical limits

maiden hawk Mar 3, 2022, 4:53 PM

#

are you really sure you can obtain that much players?

maiden hawk Mar 3, 2022, 4:53 PM

#

gleaming ore This whole thing is a sorta long term project with a team im working with. Im ju...

idk, putting 10k players on a single server seems like an incredibly dumb idea tbh

gleaming ore Mar 3, 2022, 4:54 PM

#

Im not sure that its even possible to get 10k players in a server

maiden hawk Mar 3, 2022, 4:54 PM

#

honestly

#

even 1k players on a single server seems like an incredibly dumb idea

#

there will just be huge chaos

gleaming ore Mar 3, 2022, 4:54 PM

#

maiden hawk idk, putting 10k players on a single server seems like an incredibly dumb idea t...

yeah but it hasnt been done, so why not? ;) Make something fun about and turn some heads.

maiden hawk Mar 3, 2022, 4:55 PM

#

And waste thousands of dollars

gleaming ore Mar 3, 2022, 4:55 PM

#

It really depends on your game mode

#

?

#

Thousands off of what?

maiden hawk Mar 3, 2022, 4:55 PM

#

dollars?

#

I mean

gleaming ore Mar 3, 2022, 4:55 PM

#

Yeah how?

maiden hawk Mar 3, 2022, 4:55 PM

#

don't tell me that infrastructure to handle this is going to be cheap

#

10k players is way more than it may seem

gleaming ore Mar 3, 2022, 4:56 PM

#

Minestom is much better than you would think

#

Someone got 10k players running on a M1 macbook air lol

maiden hawk Mar 3, 2022, 4:56 PM

#

Idk, but I am having my doubts on that

gleaming ore Mar 3, 2022, 4:56 PM

#

Its wonderful when you dont have to use mojang code

#

Join their discord and ask around, theres a video of 7.5k bots running fine on a laptop

maiden hawk Mar 3, 2022, 4:57 PM

#

Even handling that huge amount of network IO is going to be really expensive

burnt dragon Mar 3, 2022, 4:57 PM

#

it's not really about mojang code - it's more about the fact that minestom doesn't do anything

maiden hawk Mar 3, 2022, 4:57 PM

#

yup

gleaming ore Mar 3, 2022, 4:57 PM

#

Well thats the whole point

maiden hawk Mar 3, 2022, 4:57 PM

#

it's like body without brain

burnt dragon Mar 3, 2022, 4:57 PM

#

sure there are some improvements/optimisations - but i doubt you'd get much better performance than a vanilla server if you re-implemented all the features

maiden hawk Mar 3, 2022, 4:58 PM

#

^

gleaming ore Mar 3, 2022, 4:58 PM

#

Obviously, Minestom isnt that at all, the point is to use it as a game engine of sorts

#

10k players in a survival world would be a nightmare

maiden hawk Mar 3, 2022, 4:58 PM

#

the moment you start implementing features, the player count you can handle is going to drop drastically

burnt dragon Mar 3, 2022, 4:59 PM

#

yeah ofc, i was just correcting what you were saying about mojang code :p

maiden hawk Mar 3, 2022, 4:59 PM

#

While minecraft server code isn't the best (mostly because of the old codebase), it is still optimized pretty fine (especially with things like Paper)

gleaming ore Mar 3, 2022, 4:59 PM

#

Gotcha gotcha, sorry was meaning that its nice when you dont have their code in the way, not that it was written poorly

burnt dragon Mar 3, 2022, 5:00 PM

#

right yeah

gleaming ore Mar 3, 2022, 5:01 PM

#

maiden hawk the moment you start implementing features, the player count you can handle is g...

this is why you kinda have to develop things in mind with high players. Again im not saying im going to get 10k players doing whatever tomorrow, this is more of a research based project that see what is possible and what is not, then to move on from there.

maiden hawk Mar 3, 2022, 5:01 PM

#

tbh

#

it will be a miracle if you will be able to handle 1k players

#

tho I still don't understand how you want to obtain those in the first place

gleaming ore Mar 3, 2022, 5:03 PM

#

Thats not really the point, the point is to develop efficient systems and server architectures that could handle those players

maiden hawk Mar 3, 2022, 5:03 PM

#

oh ok

#

well glhf

agile ore Mar 3, 2022, 10:15 PM

#

Hi, I am trying to create a universal plugin compatible with spigot, bungee and velocity, but I get the following error:

[23:10:12 ERROR]: Unable to load plugin plugins\XSBuildTest.jar
com.velocitypowered.api.plugin.InvalidPluginException: The plugin file XSBuildTest.jar appears to be a Bukkit or BungeeCord plugin. Velocity does not support Bukkit or BungeeCord plugins.
        at com.velocitypowered.proxy.plugin.loader.java.JavaPluginLoader.getSerializedPluginInfo(JavaPluginLoader.java:151) ~[velocity-3.1.1-98.jar:3.1.1]
        at com.velocitypowered.proxy.plugin.loader.java.JavaPluginLoader.loadCandidate(JavaPluginLoader.java:61) ~[velocity-3.1.1-98.jar:3.1.1]
        at com.velocitypowered.proxy.plugin.VelocityPluginManager.loadPlugins(VelocityPluginManager.java:92) ~[velocity-3.1.1-98.jar:3.1.1]
        at com.velocitypowered.proxy.VelocityServer.loadPlugins(VelocityServer.java:324) ~[velocity-3.1.1-98.jar:3.1.1]
        at com.velocitypowered.proxy.VelocityServer.start(VelocityServer.java:222) ~[velocity-3.1.1-98.jar:3.1.1]
        at com.velocitypowered.proxy.Velocity.main(Velocity.java:64) ~[velocity-3.1.1-98.jar:3.1.1]
[23:10:12 INFO]: Loaded 0 plugins```
Is there any way to solve it?

oblique haven Mar 3, 2022, 10:28 PM

#

agile ore Hi, I am trying to create a universal plugin compatible with spigot, bungee and ...

do you have a @plugin annotation on your velocity class

#

and is there a velocity-plugin.json file inside of the jar

agile ore Mar 3, 2022, 10:31 PM

#

oblique haven do you have a @plugin annotation on your velocity class

yes

agile ore Mar 3, 2022, 10:31 PM

#

oblique haven and is there a velocity-plugin.json file inside of the jar

I put velocity.json, it does not work?

rich hawk Mar 3, 2022, 10:45 PM

#

No

halcyon jackal Mar 3, 2022, 10:53 PM

#

Where would I actually find out the latest version of the velocity API to use?

opaque escarp Mar 3, 2022, 11:02 PM

#

In the Paper repository https://papermc.io/repo/repository/maven-public/

#

Is there an approximate release date for Velocity 3.1.2*(Includes Minecraft 1.18.2 support, brings MiniMessage and Adventure-API 4.10.0 and a new event, which I would think is enough for a release)*? I already have 5 plugins that depend on Velocity's latest "SNAPSHOT" 😅

halcyon jackal Mar 3, 2022, 11:27 PM

#

What new event?

opaque escarp Mar 3, 2022, 11:47 PM

#

halcyon jackal What new event?

https://github.com/PaperMC/Velocity/pull/625

GitHub

Implement resource pack send event. by CoreyShupe · Pull Request #6...

This resolves issue #624

violet meteor Mar 4, 2022, 11:51 AM

#

Hi, anyone have an idea how to change the brand text in the client debug menu? Is there any java method for this?

I want to change "Paper (Velocity)" to something else.

craggy pecan Mar 4, 2022, 12:05 PM

#

You will need to modify Velocity's source and compile it yourself. This has been discussed in the past, we don't understand why anyone would want to do that

violet meteor Mar 4, 2022, 12:23 PM

#

craggy pecan You will need to modify Velocity's source and compile it yourself. This has been...

There is no other way? For example using api? https://jd.velocitypowered.com/3.0.0/

burnt dragon Mar 4, 2022, 12:24 PM

#

there is no way

#

velocity and paper and others don't provide api for removing attribution

violet meteor Mar 4, 2022, 12:27 PM

#

burnt dragon velocity and paper and others don't provide api for removing attribution

Are you sure you are right? This plugin works for bungeecord and paper https://github.com/theminecoder/ServerBrand

Unfortunately it is not compatible with Velocity.

GitHub

GitHub - theminecoder/ServerBrand

Contribute to theminecoder/ServerBrand development by creating an account on GitHub.

burnt dragon Mar 4, 2022, 12:27 PM

#

is that api

#

and is that velocity or paper

bold wharf Mar 4, 2022, 12:27 PM

#

Its a plugin message

#

like, you basically just need to send the correct plugin message to the client

#

We're not gonna walk you through removing attribution, however

hollow sleet Mar 4, 2022, 9:35 PM

#

hello, what is the difference for a command between Suggest and SuggestAsync pls?

ashen fiber Mar 4, 2022, 9:39 PM

#

The one with async in the name does it asynchronously.

warm haven Mar 4, 2022, 10:15 PM

#

Is 3.1.0-SNAPSHOT the latest stable version of Velocity?

burnt dragon Mar 4, 2022, 10:15 PM

#

no

#

things that end in SNAPSHOT are not stable

warm haven Mar 4, 2022, 10:16 PM

#

Make sense, but not stable but latest release that include MiniMessage 4.10.0

burnt dragon Mar 4, 2022, 10:18 PM

#

3.1.2-SNAPSHOT

warm haven Mar 4, 2022, 10:18 PM

#

Thank you!

slate hamlet Mar 4, 2022, 10:25 PM

#

burnt dragon things that end in SNAPSHOT are not stable

PauseChamp bukkit release when

ashen fiber Mar 4, 2022, 10:41 PM

#

I guess we have been lied to for years

#

Paper has never been stable.

ebon siren Mar 5, 2022, 12:22 PM

#

rule #0 of foss programming: nothing is ever stable

fast cradle Mar 5, 2022, 4:33 PM

#

Hi! Anyone know how to check if a player session is premium?

oblique haven Mar 5, 2022, 4:36 PM

#

fast cradle Hi! Anyone know how to check if a player session is premium?

Use online mode

fast cradle Mar 5, 2022, 4:36 PM

#

oblique haven Use online mode

This is not a solution

bold wharf Mar 5, 2022, 4:37 PM

#

I mean

#

depends on the proxies config

#

then theres the UUID version

#

if you mean, you wanna make a plugin to do the hybrid auth mode thing, see the mc api docs

tired quarry Mar 5, 2022, 5:29 PM

#

hybrid auth mode is spooky

maiden hawk Mar 5, 2022, 7:53 PM

#

It is doable

#

but it has some issues

#

Main issue being, hitting Mojang API ratelimit

autumn kernel Mar 5, 2022, 8:14 PM

#

Are all Adventure methods implemented in Velocity?

#

Stuff like playSound

sour current Mar 5, 2022, 8:15 PM

#

Most are, except book/sound methods

autumn kernel Mar 5, 2022, 8:15 PM

#

Oh well, that sucks

mighty herald Mar 6, 2022, 9:36 AM

#

Anyone has an idea on how to code a sorted tablist for velocity?

maiden hawk Mar 6, 2022, 11:05 AM

#

autumn kernel Oh well, that sucks

The issue with sound is, that Velocity would need to track player's position, which would be pretty resource demanding. You can solve this by having a plugin on the server, and sending the sounds via plugin message channel.

craggy pecan Mar 6, 2022, 11:07 AM

#

Then send them directly from the backend server, don't overengineer it

autumn kernel Mar 6, 2022, 11:38 AM

#

maiden hawk The issue with sound is, that Velocity would need to track player's position, wh...

Thats not true

burnt dragon Mar 6, 2022, 11:38 AM

#

you'd need to store a sound registry on velocity

autumn kernel Mar 6, 2022, 11:39 AM

#

Why? You could just give the resource name of the sound

#

Or what do you mean?

bold wharf Mar 6, 2022, 11:39 AM

#

not for everything

#

if you just wanna use the custom sound packet, yea, sure

#

but, that packet doesn't support all the expected features

autumn kernel Mar 6, 2022, 11:40 AM

#

But thats still better than nothing, right?

bold wharf Mar 6, 2022, 11:41 AM

#

We generally try to err away from half assed features

autumn kernel Mar 6, 2022, 11:42 AM

#

Can't you also play a sound only for a player at the players position nowadays?

bold wharf Mar 6, 2022, 11:42 AM

#

Yea, sure

#

but that'sliterally half assed and doesn't support everything

#

and, once again, we don't really wanna maintain half assed code

#

and, well, actually

#

that;s part of the issue

#

We don't know where the player is

autumn kernel Mar 6, 2022, 11:58 AM

#

Isn't there a packet you can send to the player that spawns the sound where he is, without giving a position argument?

burnt dragon Mar 6, 2022, 12:07 PM

#

yup

#

but again, that is not a named sound effect packet

maiden hawk Mar 6, 2022, 12:50 PM

#

craggy pecan Then send them directly from the backend server, don't overengineer it

In some cases you would want to send it from the proxy eShrug

fiery sentinel Mar 6, 2022, 12:50 PM

#

Hello!
I am trying at the moment to implement Velocity to my multi platform plugin.
This is my first time working with Velocity...

I read that @Plugin(id = "DiscordNotify", name = "DiscordNotify", version = "3.0.0", authors = {"TrueMB"}) Annotation should create a velocity-plugin.json. This doesnt seem to work, since I couldnt find it in the compiled jar.
I am using maven.

<plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <version>3.8.1</version>
                <configuration>
                    <source>16</source>
                    <target>16</target>
                      <encoding>UTF-8</encoding>

                    <annotationProcessorPaths>
                        <annotationProcessorPath>
                            <groupId>com.velocitypowered</groupId>
                            <artifactId>velocity-api</artifactId>
                            <version>3.0.1</version>
                        </annotationProcessorPath>
                    </annotationProcessorPaths>

                </configuration>
                
            </plugin>

PS. Sorry for the repost, just saw that i was in the wrong channel

bold wharf Mar 6, 2022, 12:51 PM

#

I've literally never seen somebody specify the AP manually

#

that almost sounds wrong

fiery sentinel Mar 6, 2022, 12:51 PM

#

tried it without as well 😄 Just wanted to make sure I am not making the mistake like ppl on gradle xD

maiden hawk Mar 6, 2022, 12:52 PM

#

bold wharf I've literally never seen somebody specify the AP manually

Yup, you only need to do that with gradle

bold wharf Mar 6, 2022, 12:52 PM

#

the compiler should already look at the classpath for annotation processors

maiden hawk Mar 6, 2022, 12:52 PM

#

Send the entire pom.xml please

bold wharf Mar 6, 2022, 12:52 PM

#

don't even need to with gradle last I knew

maiden hawk Mar 6, 2022, 12:52 PM

#

Well it didn't work without it for me eShrug

bold wharf Mar 6, 2022, 12:52 PM

#

kotlin?

#

oh, odd, apparently you do

#

at least for gradle

#

I thought the compiler dealt with that

maiden hawk Mar 6, 2022, 12:53 PM

#

bold wharf kotlin?

do you mean the build file language, or the project language

fiery sentinel Mar 6, 2022, 12:53 PM

#

https://github.com/TrueMB/DiscordNotify/blob/dev/pom.xml

bold wharf Mar 6, 2022, 12:53 PM

#

I meant project, god knows

maiden hawk Mar 6, 2022, 12:53 PM

#

Java

#

You sue 3.0.0-SNAPSHOT in your dependencies

#

the current is 3.1.0

bold wharf Mar 6, 2022, 12:55 PM

#

I mean

#

I just cloned your repo and it literally doesn't build

maiden hawk Mar 6, 2022, 12:55 PM

#

PepeLaugh

bold wharf Mar 6, 2022, 12:55 PM

#

so, I have doubts that you're actually building with maven

fiery sentinel Mar 6, 2022, 12:59 PM

#

https://pastebin.com/QippCU9A
Works for me. Or do you mean something else?

Pastebin

[INFO] Scanning for projects...[INFO] [INFO] --------------------< ...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

bold wharf Mar 6, 2022, 1:01 PM

#

oh, something is mangling jars

#

probs a shit repo, god knows

maiden hawk Mar 6, 2022, 1:01 PM

#

Maven moment PepeLaugh

#

make sure to relocate your stuff correctly pal

fiery sentinel Mar 6, 2022, 1:06 PM

#

There was indeed a problem, since I moved the package name ^^
But this shouldnt have to do with the json?

tired quarry Mar 6, 2022, 3:16 PM

#

bold wharf I've literally never seen somebody specify the AP manually

Must be done in some situations but very rarely as gradle lets you specify annotation processors

tired quarry Mar 6, 2022, 3:17 PM

#

bold wharf I thought the compiler dealt with that

It depends

uneven plover Mar 6, 2022, 5:50 PM

#

what's the event when poison damages an entity?

burnt dragon Mar 6, 2022, 6:10 PM

#

there is no such event for this on velocity

modest grove Mar 6, 2022, 7:54 PM

#

Whats the equivalent of ByteArrayOutputStream b = new ByteArrayOutputStream(); DataOutputStream out = new DataOutputStream(b); try { out.writeUTF("Connect"); out.writeUTF(SERVERNAME); } for a velocity instance?

bold wharf Mar 6, 2022, 7:58 PM

#

same

#

velocity implements the bungee messaging channel

modest grove Mar 6, 2022, 8:02 PM

#

oh

#

well cool

#

thanks

chrome edge Mar 6, 2022, 9:21 PM

#

https://github.com/PaperMC/Velocity/blob/b3fc8e8235db1617ee5cee84d58f2413bda7efa4/proxy/src/main/java/com/velocitypowered/proxy/connection/client/StatusSessionHandler.java#L82

#

Why by default sample is set as empty?

rich hawk Mar 6, 2022, 9:32 PM

#

Why not

fiery sentinel Mar 7, 2022, 9:55 AM

#

Here I am again .-.
Now I got a problem with a SimpleCommand.
For some reason the command, which needs arguments, doesnt work ingame. It doesnt event trigger.
Only if I am running the command through the console....

VelocityCommandExecutor_Staff staffCommand = new VelocityCommandExecutor_Staff(this.instance);
CommandMeta staffMeta = commandManager.metaBuilder("staff").aliases("s").build();
            
commandManager.register(staffMeta, staffCommand);

If I am using only the command ingame without arguments, then it just gets ignored....

oblique haven Mar 7, 2022, 10:35 AM

#

fiery sentinel Here I am again .-. Now I got a problem with a SimpleCommand. For some reason th...

Is there a permission for it

burnt dragon Mar 7, 2022, 10:37 AM

#

that commend doesn't have any arguments?

fiery sentinel Mar 7, 2022, 10:48 AM

#

oblique haven Is there a permission for it

omg this was really the Issue....
Now I got some more questions.
My problem was, that I wasn't using Luckperms. Is there a way to do permissions management like in Bungeecord with the config?
And I guess /server worked, since it is using the bukkit Luckperms and PluginMessengerChannel?
Is it also possible to change the error message? Or can I only prevent that by returning true and do the check on myself?

craggy pecan Mar 7, 2022, 12:28 PM

#

Velocity doesn't include a permission manager, no

#

No, /server works because it's allowed by default

#

The "Incorrect argument ..." message is hardcoded in Brigadier, a Mojang library (it might be translatable by the client, not sure)

fiery sentinel Mar 7, 2022, 1:48 PM

#

Thanks for your answers!

median vessel Mar 8, 2022, 1:38 AM

#

does velocity have a built in plugin config system like paper?

rich hawk Mar 8, 2022, 1:49 AM

#

Configurate

gleaming plank Mar 8, 2022, 10:02 AM

#

how can I communicate Velocity and Paper servers?

#

so, I want to send packet from Velocity to Paper server, and receive response from Paper server then

bronze yoke Mar 8, 2022, 10:04 AM

#

that depends, if there's a player online you can use plugin messages, but if there are no players you should use something else like redis, rabbitmq, etc

gleaming plank Mar 8, 2022, 10:05 AM

#

okay, I'll use plugin messages, because communication will be only when player online. I need to listen to PluginMessageEvent in Velocity, right?

bronze yoke Mar 8, 2022, 10:05 AM

#

yes and you must register the channels you want to use

#

both ends iirc

gleaming plank Mar 8, 2022, 10:06 AM

#

but how?

#

I know how to do it on Paper side, but don't know how to do it on Velocity

#

found ProxyServer.getChannelRegistrar().register()

#

thank you

gleaming plank Mar 8, 2022, 10:45 AM

#

How can I send packet from Velocity to my Paper server?

#

I tried event.getTarget().sendPluginMessage(Constants.MINIGAME_CHANNEL_IDENTIFIER, "test".getBytes(StandardCharsets.UTF_8)); in PluginMessageEvent, but it doesn't work

bronze yoke Mar 8, 2022, 10:49 AM

#

did you register the incoming channel on the paper server as well?

#

also I'm pretty sure that method sends the plugin message to the client

gleaming plank Mar 8, 2022, 10:53 AM

#

bronze yoke did you register the incoming channel on the paper server as well?

Yes, ofc

#

nvm I fixed it

teal adder Mar 9, 2022, 1:45 PM

#

Do I need to implement something for listening class?

rocky frost Mar 9, 2022, 1:56 PM

#

https://velocitypowered.com/wiki/developers/event-api/

Working With Events

Listening to events with Velocity's @Subscribe annotation is straightforward. You've already seen one such listener, using the…

#

Hello 👋!
What's the difference between ServerConnectedEvent and ServerPostConnectEvent?

burnt dragon Mar 9, 2022, 1:58 PM

#

the javadocs explain the difference pretty clearly

rocky frost Mar 9, 2022, 2:02 PM

#

Ok

buoyant dust Mar 9, 2022, 3:45 PM

#

Hello, I'm quite new using the velocity api, and I have ran in to this error. I'm not sure what is velocity-plugin.json, as in the wiki page it doesn't appear. I have put the @Plugin annotation in my main class.

thick bramble Mar 9, 2022, 3:47 PM

#

Are you using Gradle?

#

If so make sure you've set velocity as an annotation processor

buoyant dust Mar 9, 2022, 3:48 PM

#

no, Im using maven

#

i have set it to

#

bronze yoke Mar 9, 2022, 4:02 PM

#

pretty sure someone had the same issue a few days ago

#

had something to do with relocating

#

plus you don't have to manually add the annotation processor with maven

fast cradle Mar 9, 2022, 4:04 PM

#

How to log debug if this level is disabled in logger?
/how to enable this level

bronze yoke Mar 9, 2022, 4:05 PM

#

bronze yoke plus you don't have to manually add the annotation processor with maven

and the latest api version is 3.1.0, not 3.1.1

buoyant dust Mar 9, 2022, 4:05 PM

#

bronze yoke plus you don't have to manually add the annotation processor with maven

yeah, have realized that

buoyant dust Mar 9, 2022, 4:05 PM

#

bronze yoke had something to do with relocating

hm

buoyant dust Mar 9, 2022, 4:06 PM

#

bronze yoke and the latest api version is 3.1.0, not 3.1.1

ok

buoyant dust Mar 9, 2022, 4:21 PM

#

@bronze yoke sorry for the ping, I have read the conversation and I didn't realise how he solved that issue.

half locust Mar 9, 2022, 6:09 PM

#

Paper is a server software, Velocity is a proxy (like Bungeecord)

buoyant dust Mar 9, 2022, 9:52 PM

#

buoyant dust Hello, I'm quite new using the velocity api, and I have ran in to this error. I'...

does anyone know?

bold wharf Mar 9, 2022, 10:31 PM

#

remove the AP paths I guess

#

like, processors should generally be picked up automatically

#

unless they forked with that...

sick ether Mar 9, 2022, 10:42 PM

#

hi, can someone help me with my first plugin? xD

#

i dont know how to invoke this

      this.server.getCommandManager().unregister("livetest");
      this.server.getCommandManager().register("livetest", new vLiveCommand());

lofty bramble Mar 10, 2022, 12:25 AM

#

sick ether i dont know how to invoke this ```java this.server.getCommandManager().un...

Wdym, put you command name as the first arg, then the class that you have your command logic in

buoyant dust Mar 10, 2022, 8:15 AM

#

bold wharf remove the AP paths I guess

I removed it, but still dont load

#

I have another plugin build with gradle which works perfectly

#

Ups, sorry for ping

#

peepopray

#

I think i will switch to gradle

burnt solar Mar 10, 2022, 3:18 PM

#

how can i add multiple ServerPing.samplePlayers in ProxyPingEvent when only method that exist is
'''
public Builder samplePlayers(SamplePlayer... players) {
this.samplePlayers.addAll(Arrays.asList(players));
return this;
}
'''

bold wharf Mar 10, 2022, 3:19 PM

#

it's a vararg

#

i.e. it takes as many arguments as you want

#

or an array

burnt solar Mar 10, 2022, 3:19 PM

#

okay thanks

merry trellis Mar 10, 2022, 5:19 PM

#

Using CommandExecuteEvent. Is there a way of knowing if the command ran on the proxy or was passed through to the servers?

merry trellis Mar 10, 2022, 5:36 PM

#

Basically, I want to be able to log what Velocity commands people are using but I can't seem to figure out a way to filter my velocity and server commands.

steady trellis Mar 10, 2022, 5:45 PM

#

merry trellis Basically, I want to be able to log what Velocity commands people are using but ...

checking the sender, no?

#

if sender instance of ProxiedCommandSender or ConsoleCommandSender, i forget

merry trellis Mar 10, 2022, 5:49 PM

#

No because it will be a player regardless

#

Player runs /gamemode ----> Proxy ----> Server ->>>> Command Runs!
Players run /velocity ----> Proxy ->>>>> Command runs!

#

I wan't to check if the command runs on Velocity or gets passed through

steady trellis Mar 10, 2022, 5:50 PM

#

merry trellis I wan't to check if the command runs on Velocity or gets passed through

this would probably be easier through backends but uh, check the commandmanager maybe to see if the command is registered on velocity probably

merry trellis Mar 10, 2022, 6:14 PM

#

steady trellis this would probably be easier through backends but uh, check the commandmanager ...

Back ends?

steady trellis Mar 10, 2022, 6:41 PM

#

merry trellis Back ends?

paper server

maiden hawk Mar 10, 2022, 8:38 PM

#

So, when I tried to connect to my (online mode) proxy, with an offline mode client, I got disconnected with a custom response. Does that mean, that you can now specify the message to send to people with offline clients? afaik this was only a client side thing

bold wharf Mar 10, 2022, 8:38 PM

#

the kick comes from the server as it tries to validate the session

maiden hawk Mar 10, 2022, 8:39 PM

#

bold wharf the kick comes from the server as it tries to validate the session

But, afaik, the client would disconnect first.
Does that mean that there's some kind of racing condition here?

#

The proxy is on localhost btw

bold wharf Mar 10, 2022, 8:40 PM

#

I mean

#

you're literally seeing a kick from the server

maiden hawk Mar 10, 2022, 8:40 PM

#

yes

#

That's what I am confused about :D

bold wharf Mar 10, 2022, 8:40 PM

#

I do not recall there being anything on the client which dc's itself in such cases

#

the client doesn't have the auth token, etc, it relies on mojang sitting in the middle, and, given that every kick I've ever seen for invalid sessions comes from the server, 🤷‍♂️

maiden hawk Mar 10, 2022, 8:44 PM

#

well

#

That's great :D

#

I thought you would always receive the "Invalid Session" message

maiden hawk Mar 10, 2022, 8:59 PM

#

This is on fastlogin's wiki

We could check if that username is associated to a paid account but if we request a online mode login from a cracked player (who uses a username from a paid account), the player will disconnect with the reason "bad login" or "Invalid session". There is no way to change that message on the server side (without client modifications), because it's a connection between the Client and the session-server.

Now I am even more confused

maiden hawk Mar 10, 2022, 9:04 PM

#

maiden hawk So, when I tried to connect to my (online mode) proxy, with an offline mode clie...

Velocity kicks you with this, if it received 204 from https://sessionserver.mojang.com/session/minecraft/hasJoined

#

ok

#

this was caused by tlauncher modifying the client in a way, which allows the encryption process to continue, even if the client knows its data is invalid. Therefore the server kicks you.

#

This is what I receive when connecting with a notchian client

bold wharf Mar 10, 2022, 9:13 PM

#

oh, well

#

guess I've seen both varients of the boot

#

🤷‍♂️

maiden hawk Mar 10, 2022, 9:14 PM

#

It is pretty weird

#

But it also is pretty sussy, that tlauncher modifies the client

#

But I am not really surprised, most of these "cracked" launchers are very questionable

spiral thunder Mar 10, 2022, 10:13 PM

#

Is there a public maven repository that contains the velocity-proxy jar?

#

steady trellis Mar 10, 2022, 10:37 PM

#

spiral thunder Is there a public maven repository that contains the velocity-proxy jar?

why do u need the proxy

spiral thunder Mar 10, 2022, 10:37 PM

#

I need MinecraftPacket

steady trellis Mar 10, 2022, 10:38 PM

#

spiral thunder I need MinecraftPacket

are you trying to send a packet to a player?

spiral thunder Mar 10, 2022, 10:38 PM

#

I want to intercept a packet

#

I need PluginMessage#handle(MinecraftSessionHandler handler) as well

#

So I want the proxy

sinful inlet Mar 10, 2022, 11:26 PM

#

spiral thunder I need `PluginMessage#handle(MinecraftSessionHandler handler)` as well

https://jd.velocitypowered.com/3.0.0/com/velocitypowered/api/proxy/messages/package-summary.html

naive patrol Mar 10, 2022, 11:44 PM

#

is there a native way to get all permissions a player has

ashen pawn Mar 11, 2022, 4:13 AM

#

naive patrol is there a native way to get all permissions a player has

Velocity treats permissions as a function of (player, permission) -> tristate. But most people are likely using LuckPerms at this point, so just integrate with that.

naive patrol Mar 11, 2022, 4:13 AM

#

thanks tux

#

i respect the simplicity of the former

oblique haven Mar 11, 2022, 4:15 AM

#

ashen pawn Velocity treats permissions as a function of (player, permission) -> tristate. B...

I’ve never understood this, why do permissions use tristates rather than just have permission, doesn’t have permission. Seems odd to me, I’m sure there’s a purpose.

naive patrol Mar 11, 2022, 4:23 AM

#

returning a possible null Boolean isn't really desirable

#

and having information about whether or not its actually set can be important

#

e.g. maybe you don't want to change the value if its already set

#

sure you could have another method but tristate makes it cleaner

oblique haven Mar 11, 2022, 4:25 AM

#

Hm makes sense

steady trellis Mar 11, 2022, 5:01 AM

#

ashen pawn Velocity treats permissions as a function of (player, permission) -> tristate. B...

it's tux! the man behind velocity himself! lessgo

merry trellis Mar 11, 2022, 9:25 AM

#

Can anyone help me detect where a command runs on Velocity or get passed through to a server?

Player runs /gamemode ----> Proxy ----> Server ->>>> Command Runs!
Players run /velocity ----> Proxy ->>>>> Command runs!

fervent mantle Mar 11, 2022, 12:40 PM

#

Hello, I've a problem with the API.
I tried to register a player to the mysql database, but the code does not seem to run and the debug message "test" doesn't appear. The import of Subscribe is the velocity one and I already registered the events class in the main.
That's my code: https://pastebin.com/tzcfpzRa, ping me if you know how to fix the issue.

oblique haven Mar 11, 2022, 1:07 PM

#

fervent mantle Hello, I've a problem with the API. I tried to register a player to the mysql da...

Show me your imports

#

99% sure it’s annotated with the incorrect annotation

#

I’m gonna PR in an error message for this, it’s happening quite a bit

fervent mantle Mar 11, 2022, 1:12 PM

#

It's not the Google eventbus, it's the velocity one. I said that in the message

oblique haven Mar 11, 2022, 2:14 PM

#

fervent mantle It's not the Google eventbus, it's the velocity one. I said that in the message

can you show a full snippet of the code (including constructor) along with where you're registering the class as an event listener, sorry missed that while reading

fervent mantle Mar 11, 2022, 2:51 PM

#

thats the code https://pastebin.com/CxNT1Awd

Pastebin

import com.velocitypowered.api.event.PostOrder;import com.velocityp...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

#

thats the line to register the events in the proxy initialize event:
proxyServer.getEventManager().register(this, new BaseListeners(this));

oblique haven Mar 11, 2022, 3:12 PM

#

very weird, I'm unsure

vivid creek Mar 11, 2022, 5:54 PM

#

hi, i wanna do database queires in login event is this correct way to do that? @Subscribe public EventTask onLogin(final LoginEvent event) { return EventTask.async(() -> { // code }); }

gray hedge Mar 11, 2022, 6:51 PM

#

There's no way to get all effective permissions from a player in velocity?

rich hawk Mar 11, 2022, 6:52 PM

#

no

#

that’s up to your perm plugin afaik

gray hedge Mar 11, 2022, 6:52 PM

#

Oh that sucks

#

Cause like how do you check player's highest permission based of like weight

#

Guessing random numbers

#

That sounds like very inefficient

half locust Mar 11, 2022, 6:56 PM

#

Use something designed for that purpose i.e. luckperm's Meta system

craggy pecan Mar 11, 2022, 9:02 PM

#

merry trellis Can anyone help me detect where a command runs on Velocity or get passed through...

The logic is a bit involved, you can check e.g. the BrigadierCommand test cases https://github.com/PaperMC/Velocity/blob/94e8b0df43fa7d59372d62bef1dcff5baa7315fc/proxy/src/test/java/com/velocitypowered/proxy/command/BrigadierCommandTests.java#L101

GitHub

Velocity/BrigadierCommandTests.java at 94e8b0df43fa7d59372d62bef1dc...

The modern, next-generation Minecraft server proxy. - Velocity/BrigadierCommandTests.java at 94e8b0df43fa7d59372d62bef1dcff5baa7315fc · PaperMC/Velocity

amber ridge Mar 12, 2022, 12:59 PM

#

How do i fix ```
[13:58:12 ERROR]: Can't create plugin siecmcproxypoints
com.google.inject.ProvisionException: Unable to provision, see the following errors:

[Guice/ErrorInjectingMethod]: NoClassDefFoundError: com/zaxxer/hikari/HikariConfig
at SiecMCProxyPoints.initializePlugin(SiecMCProxyPoints.java:30)
at VelocityPluginModule.configure(VelocityPluginModule.java:48)
at com.google.inject.internal.InternalProvisionException.toProvisionException(InternalProvisionException.java:251) ~[velocity.jar:3.1.2-SNAPSHOT (git-596d4758-bunknown)]
at pl.siecmc.siecmcproxypoints.SiecMCProxyPoints$$FastClassByGuice$$5539533.apply(<generated>) ~[?:?]
at com.google.inject.internal.SingleMethodInjector$1.invoke(SingleMethodInjector.java:50) ~[velocity.jar:3.1.2-SNAPSHOT (git-596d4758-bunknown)]
at com.google.inject.internal.SingleMethodInjector.inject(SingleMethodInjector.java:87) ~[velocity.jar:3.1.2-SNAPSHOT (git-596d4758-bunknown)]
at com.google.inject.internal.MembersInjectorImpl.injectMembers(MembersInjectorImpl.java:146) ~[velocity.jar:3.1.2-SNAPSHOT (git-596d4758-bunknown)]
at com.google.inject.internal.ConstructorInjector.provision(ConstructorInjector.java:124) ~[velocity.jar:3.1.2-SNAPSHOT (git-596d4758-bunknown)]
at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:91) ~[velocity.jar:3.1.2-SNAPSHOT (git-596d4758-bunknown)]
at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:296) ~[velocity.jar:3.1.2-SNAPSHOT (git-596d4758-bunknown)]
at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40) ~[velocity.jar:3.1.2-SNAPSHOT (git-596d4758-bunknown)]```?

#

Main file:

@Inject
    public void initializePlugin(ProxyServer server, Logger logger, @DataDirectory final Path folder) {

        this.logger = logger;
        this.server = server;

        logger.info("========================");
        logger.info("=> Plugin loading...");
        logger.info("========================");

        this.config = ConfigManager.loadConfig(folder);

        Toml dbConfig = config.getTable("Database");

        this.dbManager = new Database();

        dbManager.initializeDatabase(dbConfig);

        if (!dbManager.getConnection().isRunning() || dbManager.getConnection().isClosed()) {
            logger.info("========================");
            logger.info("=> Loading failed! Database not connected.");
            logger.info("========================");
        } else {
            logger.info("========================");
            logger.info("=> Loaded successfully!");
            logger.info("========================");
        }

        return;

    }

#

Database.java:

@Inject
    public HikariDataSource initializeDatabase(Toml dbConfig) {

        logger.info("========================");
        logger.info("=> Loading database!");
        logger.info("========================");

        config.setJdbcUrl( dbConfig.getString("jdbcUrl") );
        config.setUsername( dbConfig.getString("user") );
        config.setPassword( dbConfig.getString("password") );
        config.addDataSourceProperty( "cachePrepStmts" , "true" );
        config.addDataSourceProperty( "prepStmtCacheSize" , "250" );
        config.addDataSourceProperty( "prepStmtCacheSqlLimit" , "2048" );
        ds = new HikariDataSource(config);

        logger.info("========================");
        logger.info("=> Database loaded!");
        logger.info("========================");

        return ds;
    }```

Line ```this.dbManager = new Database();``` cause this error

sour current Mar 12, 2022, 1:01 PM

#

you need to shade in hikaricp

amber ridge Mar 12, 2022, 1:01 PM

#

what do u mean?

#

U mean this?

            <groupId>com.zaxxer</groupId>
            <artifactId>HikariCP</artifactId>
            <version>LATEST</version>
            <scope>compile</scope>
        </dependency>```

craggy pecan Mar 12, 2022, 2:01 PM

#

Can we see your full pom.xml file? (use a paste site)

amber ridge Mar 12, 2022, 2:07 PM

#

https://pastebin.com/2D64ad7w

Pastebin

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

sick ether Mar 12, 2022, 2:20 PM

#

Can someone help? i dont know how to repair hover text and add open url on click event

burnt dragon Mar 12, 2022, 2:27 PM

#

it's just .hoverEvent(component) if you're wanting to do a show text hover event

#

open URL on click event is .clickEvent(ClickEvent.openUrl("etc"))

craggy pecan Mar 12, 2022, 5:08 PM

#

amber ridge https://pastebin.com/2D64ad7w

You're missing maven-shade-plugin

rocky frost Mar 12, 2022, 7:13 PM

#

Hi! What are the steps for setting up messaging with paper plugins? Here is what I've done:
Velocity: server.getChannelRegistrar().register(MinecraftChannelIdentifier.create("imdabigboss", "main"));

public void onPluginMessage(PluginMessageEvent event) {

Paper:
this.getServer().getMessenger().registerOutgoingPluginChannel(this, "imdabigboss:main");
this.getServer().getMessenger().registerIncomingPluginChannel(this, "imdabigboss:main", this);

public void onPluginMessageReceived(String channel, Player player, byte[] bytes) {

But for some reason, no messages are coming through. Have I missed something?

steady trellis Mar 12, 2022, 7:17 PM

#

rocky frost Hi! What are the steps for setting up messaging with paper plugins? Here is what...

ur not sending a message to a player

#

so no plugin messages will come through

#

make sure u also registered ur listeners

rocky frost Mar 12, 2022, 7:18 PM

#

steady trellis ur not sending a message to a player

Well yeah. I can share that code if you like.

rocky frost Mar 12, 2022, 7:19 PM

#

steady trellis make sure u also registered ur listeners

That's done, for sure, the other listeners work.

#

Spigot: player.sendPluginMessage(instance, "imdabigboss:main", b.toByteArray());
Velocity: player.sendPluginMessage(CHANNEL_ID, b.toByteArray()); (public static final ChannelIdentifier CHANNEL_ID = MinecraftChannelIdentifier.create("imdabigboss", "main");)

steady trellis Mar 12, 2022, 7:22 PM

#

rocky frost That's done, for sure, the other listeners work.

and ur velocity listener has the @Subscribe annotation right

#

its either Subscribe or SubscribeEvent, i forget

fervent mantle Mar 12, 2022, 7:45 PM

#

fervent mantle Hello, I've a problem with the API. I tried to register a player to the mysql da...

.

merry trellis Mar 12, 2022, 8:21 PM

#

craggy pecan The logic is a bit involved, you can check e.g. the `BrigadierCommand` test case...

In the end... i found this lol

VelocityControl.getServer().getCommandManager().hasCommand(event.getCommand())

rocky frost Mar 12, 2022, 8:37 PM

#

steady trellis and ur velocity listener has the @Subscribe annotation right

It's Subscribe. Yes. My events are fine.

craggy pecan Mar 12, 2022, 8:51 PM

#

merry trellis In the end... i found this lol ```java VelocityControl.getServer().getCommandMan...

Well, that tells you that a command with the given alias is registered, but there's some cases when even a registered alias is redirected to the backend server: for example, /foo gets redirected if the player doesn't have permission to execute foo on the proxy

serene shuttle Mar 12, 2022, 8:53 PM

#

Hi! How is it possible to load a plugin after server startup? PluginManager#addToClasspath is only for dependencies, right?

craggy pecan Mar 12, 2022, 8:55 PM

#

It's not possible

serene shuttle Mar 12, 2022, 8:56 PM

#

Yikes.. okay, I will initiate a server restart then. Thank you

craggy pecan Mar 12, 2022, 8:56 PM

#

Loading and unloading plugins at runtime can have undesirable side effects

serene shuttle Mar 12, 2022, 8:57 PM

#

yeah, thought so, I was just curious because there's a method in waterfall, but since I'm new to velocity.. monkaThinkGlasses

sick ether Mar 12, 2022, 9:33 PM

#

Hi, why .clickEvent(ClickEvent.openUrl("www.serwer.pl/discord")) dont work?
My code:

        source.sendMessage(Component.text()
                .content("Jesli tak to serdecznie zapraszamy do nas! ").color(NamedTextColor.GOLD).build()
                .append(Component.text().content("[Klik]").color(NamedTextColor.RED)
                        .decoration(TextDecoration.BOLD, true)
                        .hoverEvent(Component.text("Kliknij aby dolaczyc na discorda", NamedTextColor.GREEN))
                        .clickEvent(ClickEvent.openUrl("www.serwer.pl/discord"))
                        .build()));

#

hover text work but ClickEvent no

waxen sierra Mar 12, 2022, 10:44 PM

#

Hello, is it possible to somehow disable the automatic language adaption of velocity to a specific client and set one default language that is used for everyone? I currently have the following idea, but it doesn't seem to be working:

    @Subscribe
    public void onServerConnected(ServerConnectedEvent e) {
        e.getPlayer().setEffectiveLocale(Locale.ENGLISH);
    }

sick ether Mar 12, 2022, 10:46 PM

#

waxen sierra Hello, is it possible to somehow disable the automatic language adaption of velo...

retranslate all language files to english
ctrl V

bold wharf Mar 12, 2022, 10:47 PM

#

server connected event is probably too early for that

#

like, the client sends the locale info pretty late in the process, idk if there is an event specificlaly for when velocity reads the clients settings

waxen sierra Mar 12, 2022, 11:14 PM

#

How does velocity determine which language should be used for which client? Event with changed Minecraft in-game language the messages are still not in English. Also I tried adding a delay of 5 seconds before setting the client locale, but still I wasn't successful.
@sick ether Where are the language files located? Isn't the translation coming from adventure?

sick ether Mar 12, 2022, 11:17 PM

#

waxen sierra How does velocity determine which language should be used for which client? Even...

in jar file

waxen sierra Mar 12, 2022, 11:21 PM

#

In which path?

sick ether Mar 12, 2022, 11:21 PM

#

com velocity

#

@waxen sierra com velocitypowered proxy l10n

waxen sierra Mar 12, 2022, 11:26 PM

#

Okay, found it! Thanks a lot!

sick ether Mar 12, 2022, 11:27 PM

#

you're welcome

#

why .clickEvent(ClickEvent.openUrl("www.serwer.pl/discord")) dont work?
My code:

        source.sendMessage(Component.text()
                .content("Jesli tak to serdecznie zapraszamy do nas! ").color(NamedTextColor.GOLD).build()
                .append(Component.text().content("[Klik]").color(NamedTextColor.RED)
                        .decoration(TextDecoration.BOLD, true)
                        .hoverEvent(Component.text("Kliknij aby dolaczyc na discorda", NamedTextColor.GREEN))
                        .clickEvent(ClickEvent.openUrl("www.serwer.pl/discord"))
                        .build()));

#

hover text work but ClickEvent no

bold wharf Mar 12, 2022, 11:31 PM

#

tried adding the schema?

#

i.e. https:// ?

sick ether Mar 12, 2022, 11:32 PM

#

no, i will try
thanks

#

thank you! this work

burnt dragon Mar 13, 2022, 12:07 AM

#

waxen sierra How does velocity determine which language should be used for which client? Even...

the client reports their locale in the settings packet

viral blade Mar 13, 2022, 3:31 AM

#

what's my best bet for transmitting data between velocity & paper?

#

is it the same as bungee?

bold wharf Mar 13, 2022, 3:37 AM

#

"best bet" is basically open ended

#

plugin messages still work within their typical limitations, ofc

#

best overall solution especially if you want something scalable is more on the lines of pubsub type stuff, etc

viral blade Mar 13, 2022, 3:50 AM

#

unfortunately this specific project isn't on a scale where that is practical, so ig I'll just go with plugin messaging

uneven lynx Mar 13, 2022, 1:02 PM

#

Hi, i'm trying to get the servers list on a velocity proxy, i don't know how to

#

can someone help me?

robust mural Mar 13, 2022, 1:04 PM

#

ProxyServer#getAllServers

uneven lynx Mar 13, 2022, 1:08 PM

#

i'm creating a bukkit plugin

simple epoch Mar 13, 2022, 2:11 PM

#

uneven lynx i'm creating a bukkit plugin

it's not possible to get servers on a bukkit plugin. maybe with the plugin messaging channels

uneven lynx Mar 13, 2022, 2:38 PM

#

simple epoch it's not possible to get servers on a bukkit plugin. maybe with the plugin messa...

that's what i was trying to do

#

because i didn't want to import apis or do complicated stuff in order to do that

#

as now, i just removed that method, but if you could send me a wiki or a documentary, it would be helpful

fervent mantle Mar 13, 2022, 2:44 PM

#

fervent mantle Hello, I've a problem with the API. I tried to register a player to the mysql da...

Anyone?

uneven lynx Mar 13, 2022, 2:46 PM

#

fervent mantle Hello, I've a problem with the API. I tried to register a player to the mysql da...

what's that LoginEvent?

fervent mantle Mar 13, 2022, 2:46 PM

#

What event should I use for that?

uneven lynx Mar 13, 2022, 2:47 PM

#

what are you trying to do

#

check whenever a player joins the server?

#

or when it logs in via some authentication plugin

fervent mantle Mar 13, 2022, 2:48 PM

#

uneven lynx check whenever a player joins the server?

Yup

uneven lynx Mar 13, 2022, 2:50 PM

#

fervent mantle Yup

ok, so then you should use PlayerJoinEvent

fervent mantle Mar 13, 2022, 2:51 PM

#

lol? There isn't any playerjoinevent in the velocity api

uneven lynx Mar 13, 2022, 2:52 PM

#

oh sorry, i don't quite use the velocity api

uneven lynx Mar 13, 2022, 2:54 PM

#

fervent mantle lol? There isn't any playerjoinevent in the velocity api

have you registered the event?

fervent mantle Mar 13, 2022, 2:54 PM

#

fervent mantle Hello, I've a problem with the API. I tried to register a player to the mysql da...

I already registered the events class in the main.

uneven lynx Mar 13, 2022, 2:55 PM

#

there is no trace of server.getEventManager().register(plugin, listener); in the code you sent

#

so, i'll ask you again, have you registered the event?

fervent mantle Mar 13, 2022, 2:56 PM

#

in my main class: proxyServer.getEventManager().register(this, new BaseListeners(this));

uneven lynx Mar 13, 2022, 2:57 PM

#

you don't need to use this as argument

viral blade Mar 13, 2022, 2:57 PM

#

Anyone know why this command is never registered?

    @Subscribe
    public void onProxyInitialization(ProxyInitializeEvent event) {
        CommandManager commandManager = proxyServer.getCommandManager();
        CommandMeta meta = commandManager.metaBuilder("runtrial")
                .build();
        commandManager.register(meta, new RunTrialCommand());
    }

fervent mantle Mar 13, 2022, 2:57 PM

#

uneven lynx you don't need to use `this` as argument

?? Do you know how the Velocity API works? 😐
void register(Object plugin, Object listener);

viral blade Mar 13, 2022, 2:58 PM

#

viral blade Anyone know why this command is never registered? ```java @Subscribe pub...

/runtrial is not registered, nor does it work from the console

uneven lynx Mar 13, 2022, 2:58 PM

#

fervent mantle ?? Do you know how the Velocity API works? 😐 `void register(Object plugin, Obje...

that's not even velocity api, it's just java

fervent mantle Mar 13, 2022, 2:59 PM

#

..

uneven lynx Mar 13, 2022, 2:59 PM

#

and also, the velocity docs doesn't say to do so

#

#

https://velocitypowered.com/wiki/developers/event-api/

Working With Events

Listening to events with Velocity's @Subscribe annotation is straightforward. You've already seen one such listener, using the…

fervent mantle Mar 13, 2022, 3:01 PM

#

#

Oh, wait, now I understand what do you mean.
The this in the new instance of BaseListeners is an argument of the constructor

viral blade Mar 13, 2022, 3:02 PM

#

uneven lynx

You have to register with an instance of the plugin

uneven lynx Mar 13, 2022, 3:02 PM

#

viral blade You have to register with an instance of the plugin

that's what i said, but you don't have to pass that istance to the event class

viral blade Mar 13, 2022, 3:02 PM

#

oh ofc

uneven lynx Mar 13, 2022, 3:02 PM

#

that was what zMario was saying

#

i also think (and i can be mistaken) that if you do so, there is a chance that the event won't work

viral blade Mar 13, 2022, 3:04 PM

#

that won't break things

#

that's how dependency injection works

#

so you can get access to the main plugin

uneven lynx Mar 13, 2022, 3:04 PM

#

ok, thanks

fervent mantle Mar 13, 2022, 3:04 PM

#

viral blade so you can get access to the main plugin

exactly

uneven lynx Mar 13, 2022, 3:04 PM

#

viral blade so you can get access to the main plugin

you can do the same using istances

viral blade Mar 13, 2022, 3:05 PM

#

what?

#

DI is passing an instance of your main class

#

do you mean using static abuse?

uneven lynx Mar 13, 2022, 3:05 PM

#

you can declare a method to get this

viral blade Mar 13, 2022, 3:05 PM

#

huh?

uneven lynx Mar 13, 2022, 3:05 PM

#

viral blade do you mean using static abuse?

nope

viral blade Mar 13, 2022, 3:06 PM

#

the this as an argument goes to the method as an instance of your main class

uneven lynx Mar 13, 2022, 3:06 PM

#

i mean

#

viral blade Mar 13, 2022, 3:06 PM

#

and that class's this is different

#

do you mean using static abuse?

uneven lynx Mar 13, 2022, 3:07 PM

#

wdym with static abuse?

viral blade Mar 13, 2022, 3:07 PM

#

you're abusing the functionalities of static methods
the issue with this is that it makes unit testing and such much more complex

#

it's not necicarily bad per-se

uneven lynx Mar 13, 2022, 3:07 PM

#

that's the only static method in my whole project

#

lmao

viral blade Mar 13, 2022, 3:07 PM

#

so?

#

that's still abusing static

#

it's fine and all

#

but there's no reason not to do DI if you can

#

atleast imho

uneven lynx Mar 13, 2022, 3:09 PM

#

i think that you're stretching a bit the concept of "abuse"

viral blade Mar 13, 2022, 3:09 PM

#

https://stackoverflow.com/questions/7026507/why-are-static-variables-considered-evil

#

It's commonly referred to as static abuse

#

I'm not the first one to call it that

uneven lynx Mar 13, 2022, 3:09 PM

#

using a static variable is considered abuse

#

?

#

if so, that's the stupidest thing i heard in a while

viral blade Mar 13, 2022, 3:10 PM

#

not a static variable

#

a static instance

#

static itself is just fine

#

I use static methods all the time for utils

#

but using it to carry an instance is referred to as static abuse

uneven lynx Mar 13, 2022, 3:11 PM

#

and why is so terrible if i may ask?

viral blade Mar 13, 2022, 3:11 PM

#

read the stack overflow post I sent

#

evil is a strong word

#

but that's why it's referred to as static abuse

uneven lynx Mar 13, 2022, 3:11 PM

#

you're stating that i'm abusing static so you should telling me

viral blade Mar 13, 2022, 3:12 PM

#

read the post!
There's no reason for me to write why when 31 people replied to that post

uneven lynx Mar 13, 2022, 3:12 PM

#

you started this discussion so you're the one that should argument

viral blade Mar 13, 2022, 3:13 PM

#

"argument"?
wdym