#velocity-dev | PaperMC | Page 3

fossil sundial Dec 27, 2021, 7:09 PM

#

notlike

agile ore Dec 27, 2021, 7:09 PM

#

lololo np i appreciate the help

#

nO, we use protocollib but not protocolsupport - and we don't use viaversion

fossil sundial Dec 27, 2021, 7:11 PM

#

show your code you use to send the messages please

agile ore Dec 27, 2021, 7:12 PM

#

Leaving it for now, I'll be back in a little bit to try again just so you know I'm not ignoring, thanks for the help

azure sage Dec 28, 2021, 4:05 AM

#

Hello I am working with code that has the following dependency...

implementation group: 'com.velocitypowered', name: 'velocity-utils', version: '4.0.0-SNAPSHOT', changing: true

I've been looking around and the highest I can find is 3.0.1 is "velocity-utils" something separate? What's the latest version?

azure sage Dec 28, 2021, 5:14 AM

#

Long story short seems like they used their own implementation with stuff that's just missing right now, wondering if anyone is willing to help me figure out how to fix the log4j error.
Exception in thread "main" java.lang.NoSuchFieldError: EMPTY_BYTE_ARRAY

warm gulch Dec 28, 2021, 8:56 PM

#

what's a velocity equivalent for being able to use a gradle property thingy like ${version} in the plugin info. previously used ProcessResources but i'm unsure how to apply that to the annotation-based thingy

warm gulch Dec 28, 2021, 9:27 PM

#

found kyori blossom

burnt dragon Dec 28, 2021, 9:31 PM

#

kyori member discovers kyori project

warm gulch Dec 28, 2021, 9:31 PM

#

shut up i don't use gradle

#

but yes i admit it's funny

minor glacier Dec 29, 2021, 11:02 PM

#

How can I take advantage of velocity's api to make a plugin that allows players to join my proxy and be proxied to an external server (like Hypixel)?

agile ore Dec 29, 2021, 11:03 PM

#

Minecraft doesn't support transferring players like that

minor glacier Dec 29, 2021, 11:03 PM

#

It's not really about Minecraft

#

I am trying to use velocity as a proxy to imitate a player

#

Which is proxying

#

Player -- joins --> [My server]
[My server] -- forward's Players' connection --> [Hypixel]

agile ore Dec 29, 2021, 11:05 PM

#

You wouldn't be able to make them join online mode servers (without having them sign in somewhere) because the player's authentication is only valid for the server they joined, your proxy.

minor glacier Dec 29, 2021, 11:05 PM

#

Ah I see, so you're saying that I would need to authenticate with Hypixel, but that information isn't sent to directly Velocity (so I can't "forward" it to Hypixel)?

#

Actually that doesn't make much sense because if I recall correctly, Velocity doesn't do anything but act as the Player when connecting to backend servers.

agile ore Dec 29, 2021, 11:06 PM

#

Velocity also handles authentication with mojang servers

minor glacier Dec 29, 2021, 11:06 PM

#

Unless it's only because the backend servers has to specify to only accept connections from "x proxy"

fossil sundial Dec 30, 2021, 12:02 AM

#

minor glacier Unless it's only because the backend servers has to specify to only accept conne...

The minecraft client will only authenticate once (LOGIN phase)
Then the connection is established
(PLAY phase)
To prevent servers from hijacking users accounts it’s only possible for the client to be in LOGIN once per connection
If you want to join another server over a proxy like velocity you’ll have to modify the proxy;
Essentially: You need the proxy to sign into your account again; and do the same thing with the server you’re trying to join as your client did to log into the proxy
That is, you need to provide the proxy with a session or your account directly so it can do that
Not a very useful idea sadly

minor glacier Dec 30, 2021, 1:44 AM

#

I see. Well it’s possible at least

oblique haven Dec 30, 2021, 2:03 AM

#

minor glacier I see. Well it’s possible at least

if you give the proxy the session token maybe

#

but that's not smart

rich hawk Dec 30, 2021, 6:02 AM

#

is PreLoginEvent the first event on connect where you can deny the connection?

oblique haven Dec 30, 2021, 8:05 AM

#

Is there a ping-ratelimit available via Velocity which will rate limit pings per IP, or is that something which should be handled by a plugin on the proxy

#

just want to see what level it should be resolved - and if it could be a feature within velocity (I'm willing to throw in the work for it if it's not available currently)

#

I know there's a login-ratelimit but that still leaves the ping exposed from what I understand

fossil sundial Dec 30, 2021, 9:25 AM

#

rich hawk is `PreLoginEvent` the first event on connect where you can deny the connection?

Technically no, the handshake event is earlier; but I wouldn’t recommend doing anything there

gritty valve Dec 30, 2021, 9:26 AM

#

Hi, does anyone have some code examples with a task scheduler?

rich hawk Dec 30, 2021, 9:27 AM

#

fossil sundial Technically no, the handshake event is earlier; but I wouldn’t recommend doing a...

looking at the JD I don't think that has a deny/cancel method, also why not :p?

fossil sundial Dec 30, 2021, 9:28 AM

#

rich hawk looking at the JD I don't think that has a deny/cancel method, also why not :p?

Because the client doesn’t have a way of being disconnected correctly at that stage. You can get the inbound connection from that event however ….
Seriously not recommended though

agile ore Dec 30, 2021, 12:20 PM

#

with bungeecord, you send a plugin message packet with the channel "bungeecord" to switch servers. Does anyone know what you have to do for velocity?

fossil sundial Dec 30, 2021, 12:31 PM

#

agile ore with bungeecord, you send a plugin message packet with the channel "bungeecord" ...

The same. Velocity supports the bungee channel api
We didn’t reinvent the wheel for that one, plus, it makes more plugins compatible with velocity

agile ore Dec 30, 2021, 12:32 PM

#

fossil sundial The same. Velocity supports the bungee channel api We didn’t reinvent the wheel ...

ah okay thanks

gritty valve Dec 30, 2021, 1:28 PM

#

How do I get players from a specific server?

bold wharf Dec 30, 2021, 1:30 PM

#

get list of players

#

filter out those who aren't on the server you're looking for

#

?

gritty valve Dec 30, 2021, 1:32 PM

#

I want to take all players who are on the server of a certain player

analog dew Dec 30, 2021, 1:32 PM

#

Ok

#

Get a list of players, filter out those who aren't on the server you're looking for...

gritty valve Dec 30, 2021, 1:41 PM

#

player.getCurrentServer().get().getServer().getPlayersConnected()

#

turned out without filtering

agile ore Dec 31, 2021, 1:37 PM

#

"Velocity does not support a cap on the number of players online."

#

why not?

jolly sandal Dec 31, 2021, 2:29 PM

#

Hi guys im trying to redirect a player when servers stop with Velocity but it just disconnects players for the reason the server stopped

vernal compass Dec 31, 2021, 3:55 PM

#

agile ore "Velocity does not support a cap on the number of players online."

because the only thing that matters is the combined player cap of all accessible servers behind the proxy. Velocity does support changing the displayed slots tho

agile ore Dec 31, 2021, 4:19 PM

#

vernal compass because the only thing that matters is the combined player cap of all accessible...

right

#

I thought that maybe some people would want something like that

#

but that would be easily done with a plugin

maiden hawk Dec 31, 2021, 8:31 PM

#

Hi, what is the best option to communicate between Bukkit <-> Velocity? Is it possible to use the integrated plugin messaging channel? Should I use it or should I choose other alternatives like RabbitMQ?

young pilot Dec 31, 2021, 8:59 PM

#

Depends. Yes you can, if players are available. Message Brokers work too, but if the proxy is static and less event driven, could also use grpc

maiden hawk Dec 31, 2021, 9:04 PM

#

young pilot Depends. Yes you can, if players are available. Message Brokers work too, but if...

Hmm, is there any documentation on how to receive plugin messages on velocity?

young pilot Dec 31, 2021, 9:11 PM

#

Certainly

#

Also read up on the caveats like with bungee and the builtin messages

maiden hawk Dec 31, 2021, 9:13 PM

#

young pilot Certainly

Well certainly isn't much helpful, can you please link it?

young pilot Dec 31, 2021, 9:22 PM

#

Unfortunately not, i am only on my phone and haven't looked at the docs for a while, so I just wanted to express there most certainly is one and someone else will hopefully chime in

maiden hawk Dec 31, 2021, 9:30 PM

#

young pilot Unfortunately not, i am only on my phone and haven't looked at the docs for a wh...

I really wasn't able to find it tho

maiden hawk Dec 31, 2021, 9:48 PM

#

It looks like this event can be used

#

https://jd.velocitypowered.com/3.0.0/com/velocitypowered/api/event/connection/PluginMessageEvent.html

young pilot Dec 31, 2021, 9:54 PM

#

https://github.com/VelocityPowered/BungeeQuack/blob/master/src/main/java/com/velocitypowered/bungeequack/BungeeQuack.java is very old, but maybe you can find similar stuff

GitHub

BungeeQuack/BungeeQuack.java at master · VelocityPowered/BungeeQuack

BungeeCord plugin messaging channel support for Velocity - BungeeQuack/BungeeQuack.java at master · VelocityPowered/BungeeQuack

maiden hawk Dec 31, 2021, 10:11 PM

#

young pilot https://github.com/VelocityPowered/BungeeQuack/blob/master/src/main/java/com/vel...

Unfortunately it is for Velocity 1.x So it isn't really relevant, I'm gonna use rabbitmq anyway.

inner hamlet Dec 31, 2021, 10:51 PM

#

Why can't the infiniburn setting here be empty? https://github.com/PaperMC/Velocity/blob/b8f1df44707d80ca48a0fa924e0bfc5927f54863/proxy/src/main/java/com/velocitypowered/proxy/connection/registry/DimensionData.java#L91

#

wiki.vg mentions it can be empty, and the game seems to handle it correctly

fossil sundial Dec 31, 2021, 10:57 PM

#

inner hamlet wiki.vg mentions it can be empty, and the game seems to handle it correctly

Between intended and working way of doing things we intend to go with the former rather the latter

inner hamlet Dec 31, 2021, 11:08 PM

#

I see, I didn't know it was intended to be required

ashen fiber Jan 1, 2022, 3:44 AM

#

What's the best way of communicating between server and proxy?

oblique haven Jan 1, 2022, 3:48 AM

#

ashen fiber What's the best way of communicating between server and proxy?

plugin messaging channels

#

or redis/another pub-sub solution

ashen fiber Jan 1, 2022, 4:05 AM

#

oblique haven plugin messaging channels

I thought plugin channels were dependent on a player...

oblique haven Jan 1, 2022, 5:18 AM

#

ashen fiber I thought plugin channels were dependent on a player...

They are, if you need to not rely on players than do the second thing I said

#

Redis/another pub sub option is good

neat nexus Jan 1, 2022, 10:59 AM

#

any idea? Error: "java.lang.NoSuchMethodError: 'com.velocitypowered.api.proxy.server.ServerPing$Builder com.velocitypowered.api.proxy.server.ServerPing$Builder.description(me.kerpson.proxy.libs.net.kyori.adventure.text.Component)'
"

#

in ProxyPingEvent

bold wharf Jan 1, 2022, 11:00 AM

#

You can't relocate adventure in your plugin and use the platform native methods

neat nexus Jan 1, 2022, 11:09 AM

#

it works, thanks

minor cradle Jan 1, 2022, 3:12 PM

#

Hi, my servers are dynamically managed by a cloud software, is it possible to set fallbacks?

#

If a player got kicked by a server he got kicked off the full network

minor cradle Jan 1, 2022, 3:12 PM

#

jolly sandal Hi guys im trying to redirect a player when servers stop with Velocity but it ju...

Same problem

#

So any method to set player fallback?

robust mural Jan 1, 2022, 5:29 PM

#

KickedFromServerEvent#setResult

jolly ledge Jan 1, 2022, 6:35 PM

#

hi

#

java.lang.NullPointerException: Cannot invoke "java.lang.CharSequence.length()" because "this.text" is null
        at java.util.regex.Matcher.getTextLength(Matcher.java:1769) ~[?:?]
        at java.util.regex.Matcher.reset(Matcher.java:415) ~[?:?]
        at java.util.regex.Matcher.<init>(Matcher.java:252) ~[?:?]
        at java.util.regex.Pattern.matcher(Pattern.java:1134) ~[?:?]
        at com.velocitypowered.proxy.plugin.loader.java.JavaPluginLoader.loadCandidate(JavaPluginLoader.java:68) ~[velocity.jar:3.1.1]
        at com.velocitypowered.proxy.plugin.VelocityPluginManager.loadPlugins(VelocityPluginManager.java:92) ~[velocity.jar:3.1.1]
        at com.velocitypowered.proxy.VelocityServer.loadPlugins(VelocityServer.java:324) ~[velocity.jar:3.1.1]
        at com.velocitypowered.proxy.VelocityServer.start(VelocityServer.java:222) ~[velocity.jar:3.1.1]
        at com.velocitypowered.proxy.Velocity.main(Velocity.java:64) ~[velocity.jar:3.1.1]
[19:24:14 ERROR]: Unable to load plugin plugins\SpicyTacos.jar
com.velocitypowered.api.plugin.InvalidPluginException: Did not find a valid velocity-plugin.json.
        at com.velocitypowered.proxy.plugin.loader.java.JavaPluginLoader.loadCandidate(JavaPluginLoader.java:64) ~[velocity.jar:3.1.1]
        at com.velocitypowered.proxy.plugin.VelocityPluginManager.loadPlugins(VelocityPluginManager.java:92) ~[velocity.jar:3.1.1]
        at com.velocitypowered.proxy.VelocityServer.loadPlugins(VelocityServer.java:324) ~[velocity.jar:3.1.1]
        at com.velocitypowered.proxy.VelocityServer.start(VelocityServer.java:222) ~[velocity.jar:3.1.1]
        at com.velocitypowered.proxy.Velocity.main(Velocity.java:64) ~[velocity.jar:3.1.1]

#

there is no trace of velocity-plugin.json in the documentation of velocity

thick bramble Jan 1, 2022, 6:39 PM

#

please don't ping random people Qg

#

it's generated with the plugin annotation

#

assuming you've set it up correctly

#

are you using maven or gradle?

jolly ledge Jan 1, 2022, 6:40 PM

#

thick bramble please don't ping random people Qg

sorry it's a fail

jolly ledge Jan 1, 2022, 6:40 PM

#

thick bramble are you using maven or gradle?

gradle

atomic leafBOT Jan 1, 2022, 6:40 PM

#

Please send large files/logs to a pastebin

New · paste.gg

A sensible, modern pastebin. Share text and source code snippets with no hassle.

jolly ledge Jan 1, 2022, 6:40 PM

#

    id 'java'
    id 'com.github.johnrengelman.shadow' version '6.1.0'
}

group 'fr.qg'
version '1.0-SNAPSHOT'

repositories {
    mavenCentral()
    maven { url 'https://repo.velocitypowered.com/snapshots/' }
}

dependencies {
    compileOnly 'com.velocitypowered:velocity-api:3.0.1-SNAPSHOT'
    annotationProcessor 'com.velocitypowered:velocity-api:3.0.1'
    implementation 'com.google.inject:guice:5.0.1'
}```

thick bramble Jan 1, 2022, 6:40 PM

#

paste your build.gradle

#

oh you do have it defined as an annotation processor, that looks correct

fossil sundial Jan 1, 2022, 6:41 PM

#

Show what’s in your @\Plugin annotation

jolly ledge Jan 1, 2022, 6:41 PM

#

fossil sundial Jan 1, 2022, 6:43 PM

#

Uh you have any invalid package names?

jolly ledge Jan 1, 2022, 6:43 PM

#

thick bramble Jan 1, 2022, 6:43 PM

#

what are you running to build it?

jolly ledge Jan 1, 2022, 6:44 PM

#

oh that's it, I use the shadowjar

rich hawk Jan 1, 2022, 6:44 PM

#

That’s fine

thick bramble Jan 1, 2022, 6:45 PM

#

run with --scan and post the link here, idk what else this all looks correct

jolly ledge Jan 1, 2022, 6:47 PM

#

https://scans.gradle.com/s/m55off4msr3ze/activate

thick bramble Jan 1, 2022, 6:49 PM

#

you've got to activate it/agree to tos first

#

just untick "Subscribe to the Gradle newsletter"

jolly ledge Jan 1, 2022, 6:52 PM

#

good

#

@thick bramble

#

😭

wary tiger Jan 1, 2022, 7:23 PM

#

Can you see what the generated velocity-plugin.json looks like?

rich hawk Jan 1, 2022, 7:29 PM

#

Make a plugin with annotation processor then open the jar?

jolly ledge Jan 1, 2022, 11:23 PM

#

wary tiger Can you see what the generated velocity-plugin.json looks like?

{"id":"spicytacos","name":"SpicyTacos","version":"1.0-SNAPSHOT","description":"I did it!","authors":["Qg"],"dependencies":[],"main":"net.hyna.spicytacos.TacosPlugin"}

bronze yoke Jan 1, 2022, 11:46 PM

#

and is the velocity-plugin.json in the root of the archive?

inner hamlet Jan 2, 2022, 3:10 AM

#

hi there, I don't have a velocity-plugin.json file in my jar even though I do have annotationProcessor set like so: https://github.com/StackDoubleFlow/ChattORE/blob/36ac869a02f2a566930d8a0898cee0c3fcd002aa/build.gradle.kts#L41

rich hawk Jan 2, 2022, 3:30 AM

#

If it’s kotlin you need kapt

inner hamlet Jan 2, 2022, 3:43 AM

#

ah

trim forge Jan 2, 2022, 2:49 PM

#

Does velocity have messaging channels similar to bungee? Or should I just use BungeeMessageChannels as I believe it supports them

rich hawk Jan 2, 2022, 3:54 PM

#

It uses the bungee ones

teal adder Jan 2, 2022, 4:27 PM

#

Hey there,
does velocity has something like Bukkit Scheduler ? also is there any API guide for beginners?

fossil sundial Jan 2, 2022, 4:31 PM

#

teal adder Hey there, does velocity has something like Bukkit Scheduler ? also is there any...

https://jd.velocitypowered.com/3.0.0/com/velocitypowered/api/proxy/ProxyServer.html#getScheduler()
You can create tasks with the builder
https://jd.velocitypowered.com/3.0.0/com/velocitypowered/api/scheduler/Scheduler.TaskBuilder.html

Basic guide to plugins:
https://velocitypowered.com/wiki/developers/creating-your-first-plugin/

Creating Your First Plugin

It is very simple to create a plugin for Velocity. This section will teach you how to setup your IDE, your plugin identifiers, and give you…

teal adder Jan 2, 2022, 4:31 PM

#

fossil sundial https://jd.velocitypowered.com/3.0.0/com/velocitypowered/api/proxy/ProxyServer.h...

Thank you, appreciate it.

#

I checked the API, but seems there is no built in configuration system for plugin configuration folder, if true/ is there a method to get plugins/velocity/data directory?

warm gulch Jan 2, 2022, 6:08 PM

#

@DataDirectory, check the wiki

#

(bottom of https://velocitypowered.com/wiki/developers/api-basics/) @teal adder

teal adder Jan 2, 2022, 6:15 PM

#

warm gulch (bottom of <https://velocitypowered.com/wiki/developers/api-basics/>) <@86276162...

oh I skipped that part, thx

agile ore Jan 2, 2022, 10:40 PM

#

i have a problem with batch inserts

#

when i do a batch insert and return generated keys it only returns 1

agile ore Jan 2, 2022, 11:20 PM

#

hi

vestal prawn Jan 3, 2022, 12:02 AM

#

What is the difference between using asynchronous events and using sync event with asynchronous ?
What is the benefit of it

vestal prawn Jan 3, 2022, 1:18 AM

#

#

i don't understand what is the difference between velocity async event and sync event with classic async

honest elbow Jan 3, 2022, 1:24 AM

#

vestal prawn What is the difference between using asynchronous events and using sync event wi...

Hum.. the first solution, the event is sent asynchronously and all handler are executed in the concurrent thread

And the second solution, the event pass through the queue of event in the main thread, each handler is execute in the main thread and after, you will free the main thread using another thread

So.. the best of course is the first, but if you doesn't have the choice, the second solution can save a bit

I think this explanation is correct 🤔

vestal prawn Jan 3, 2022, 1:25 AM

#

honest elbow Hum.. the first solution, the event is sent asynchronously and all handler are e...

so if one plugin decide that an event is asynchronous then it will be for all other plugins ?

#

it makes sense but it's not clear

honest elbow Jan 3, 2022, 1:27 AM

#

vestal prawn so if one plugin decide that an event is asynchronous then it will be for all ot...

Normally, if the developers decide that an event is asynchronous, all instance received of this event (in each handler) is in a concurrent thread of main thread in all cases
(Except if there is an error in the implementation.. but .. probably not)

#

To be sure and try you can just print the current thread when you receive event

wary tiger Jan 3, 2022, 3:03 AM

#

Asynchronous events allow asynchronously resuming execution of event listeners at a later point in time. The advantage of this is performance; threads need not block..

vestal prawn Jan 3, 2022, 11:19 AM

#

honest elbow Normally, if the developers decide that an event is asynchronous, all instance r...

Okay thanks i'll test, because if there is two events handler, one with priority last async, and the second with priority first but sync, will the two events be on a different thread ?
Or it's only all the event handlers after the first one that decide to work on another thread ?

#

I'll test it out today

vestal prawn Jan 3, 2022, 11:21 AM

#

wary tiger Asynchronous events allow asynchronously resuming execution of event listeners a...

Yep but will it stop other event handler ?
Or other event handler compute the event, and then at the end, the event "waits" for the async event handler to finish ?

#

Because on bungeecord there was some of events fired asynchronously that's why im a bit confused

vestal prawn Jan 3, 2022, 11:46 AM

#

Like if we have A1 an asynchronous event with the first priority, and then S2, a synchronous event with the last priority
Will the execution be :
A1 -> S2
With A1 asynchronous and S2 asynchronous too ?

honest elbow Jan 3, 2022, 12:15 PM

#

hum .. In this case, i can't help you, i never test this situation

fierce umbra Jan 3, 2022, 12:45 PM

#

Do pluginMessageChannels work the same with velocity as they do with bungeecord?

#

Or do i have to use a diffrent way to execute proxy functions in a paper/spigot plugin

#

For some reason my signs plugin still works? I can click the signs and it will put me in the correct server. Even tough i didnt change anything and it still uses the Bungeecord channel?

trim forge Jan 3, 2022, 12:49 PM

#

fierce umbra Do pluginMessageChannels work the same with velocity as they do with bungeecord?

They work the same as bungee, just register tham as you would for bungee.

fierce umbra Jan 3, 2022, 12:49 PM

#

Yeah i just noticed that. I havent changed anything and my "bungee" signs plugin still works

#

Thats neat 🙂

trim forge Jan 3, 2022, 12:50 PM

#

It should do, Velocity just uses bungee messaging channels for simplicity. I personally use redis to communicate most of the time, but that's just personal preference.

fierce umbra Jan 3, 2022, 12:50 PM

#

That would also work. But i only have 1 plugin that gets me the information how many people are on the server and then sends them to the specific server

#

So the extra work is probably not worth it because its a personal server where only my friends play

trim forge Jan 3, 2022, 12:51 PM

#

That's understandable, I only did it that way because it was for a large network!

neon roost Jan 3, 2022, 1:56 PM

#

hey i'm starting to learn how to develop a velocity plugin for a global chat and i noticed the server.sendMessage() takes a component. what is component or where do i find documentation for it? not sure if i did something wrong with intellij but i can't like auto-fix the import.

oblique haven Jan 3, 2022, 1:57 PM

#

neon roost hey i'm starting to learn how to develop a velocity plugin for a global chat and...

Kyori is probably the best thing to look into

#

It’s what velocity uses

#

#community-guilds message this is the discord link

neon roost Jan 3, 2022, 1:59 PM

#

alright i'll go over there, thank u

#

OH ITS ADVenture like the thing that paper recently merged. now Component makes sense!

oblique haven Jan 3, 2022, 2:00 PM

#

Yepp

light oyster Jan 3, 2022, 4:51 PM

#

Hello, does this looks correct?

server.getScheduler().buildTask(this, new RAM()).repeat(20L, TimeUnit.SECONDS);

craggy pecan Jan 3, 2022, 6:51 PM

#

Yup, to actually schedule it, call #schedule() on the builder

light oyster Jan 3, 2022, 7:45 PM

#

craggy pecan Yup, to actually schedule it, call `#schedule()` on the builder

Appreciate it 😄

vestal prawn Jan 3, 2022, 10:28 PM

#

do someone has a clear example of what is the differences between the two and what happens if multiples plugins use sync AND async events on the same event ? Thank you ! A scheme would be the best

bold wharf Jan 3, 2022, 10:33 PM

#

async means run in parallel, basically

#

right now, all events are basically fired async

#

continuation is basically akin to figures

#

task 1 finishes, it will run task 2 (i.e. the continuation)

#

(the continatuon just really seems like its for repeating tasks, but, idk there)

#

oh, that's one of the primary use cases, otherwise, what i said, futures more or less

vestal prawn Jan 3, 2022, 10:52 PM

#

bold wharf right now, all events are basically fired async

that's why it's a bit confusing for me, so flagging our event with async flag just mean that the event will skip to the next event handler and then comeback when our event computing is done ?

#

the async thing is just to tell that the other events handler can process the event and then comeback to our event handler when it's ready ?

bold wharf Jan 3, 2022, 10:56 PM

#

No

#

all events are async

#

whenever you fire an event, it's ran on another executor

#

This thing just seems like a massive ass mess in which the best thing I can suggest is reading the documentation of how it works

#

or, I mean, the implementation

wooden mauve Jan 4, 2022, 12:34 AM

#

Will @Inject only work on the main class of the plugin or can I use it in my sub packages as well to inject the server instance?

fossil sundial Jan 4, 2022, 12:36 AM

#

wooden mauve Will @Inject only work on the main class of the plugin or can I use it in my sub...

Should work everywhere unless you use a custom class loader
Though there is a tiny chance I just don’t have that part of the code in mind correctly; but I’m petty sure nonetheless

wooden mauve Jan 4, 2022, 12:37 AM

#

Okay that's cool, thanks

dry radish Jan 4, 2022, 12:40 AM

#

.

fossil sundial Jan 4, 2022, 12:41 AM

#

Wrong channel #paper-help

dry radish Jan 4, 2022, 12:41 AM

#

fossil sundial Wrong channel <#289587909051416579>

👍

wary tiger Jan 4, 2022, 1:03 AM

#

bold wharf async means run in parallel, basically

No, not with regards to velocity's async events. Rather, listeners run in sequence, but resume asynchronously.

wary tiger Jan 4, 2022, 1:04 AM

#

vestal prawn Yep but will it stop other event handler ? Or other event handler compute the ev...

It won't "stop" the other event handler; it will delay the next event handler's execution until the current handler is finished.

#

Sync event handler -> Async event handler .... long async computation ... -> Next event handler

bold wharf Jan 4, 2022, 1:05 AM

#

I mean, i was explaining what async meant, didn't entirely relay it into what velocity does too much

#

the code there just looks o.O

vestal prawn Jan 4, 2022, 1:48 AM

#

wary tiger Sync event handler -> Async event handler .... long async computation ... -> Nex...

so what's the difference with sync event handler since every handler are run sequentially

#

and electroniccat said that all event are not on the main thread

wary tiger Jan 4, 2022, 1:49 AM

#

Sequentially is not the same as "not on the main thread." Listeners are run in sequence: one after the other. However, async listeners can choose to resume execution at a later point in time

bold wharf Jan 4, 2022, 1:50 AM

#

from what I saw, looked like they ran on their own special thread

wary tiger Jan 4, 2022, 1:50 AM

#

Async listeners can therefore listen to the event, handle it and perform some computations on another thread (hence "asynchronously"), before finally resuming execution

bold wharf Jan 4, 2022, 1:50 AM

#

bearing in mind that there is no main thread in velocity

#

But, that logic was running through a good chunk of stuff, so, I am probs wrong on some of what I saw

wary tiger Jan 4, 2022, 1:51 AM

#

Velocity moves execution of event handlers to a thread pool after the first async listener (or thread-pool-requiring-listener for backward compatibility) is encountered

vestal prawn Jan 4, 2022, 1:54 AM

#

wary tiger Async listeners can therefore listen to the event, handle it and perform some co...

Okay and while the async compute the event, the others listeners can compute in parallel too ?

wary tiger Jan 4, 2022, 1:55 AM

#

No: only one listener will execute at a time.

#

This is the meaning of "sequential" when I say that the listeners run in sequence.

vestal prawn Jan 4, 2022, 1:56 AM

#

wary tiger Async listeners can therefore listen to the event, handle it and perform some co...

But what is the point to perform computation on another thread since the thread the listener is using is already async ? Or is the thread used by the listener by default is used by other stuff ?

#

i think im starting to understand the differences

wary tiger Jan 4, 2022, 2:02 AM

#

We use threads for various purposes. There is not one purpose of a thread: I think you are carrying the assumption that the only reason we use threads on a Bukkit server is so that we do not block the main thread.

On Velocity, multiple threads are still used, even though there is not a main thread. However, it is common to run certain operations on some threads, others on different ones. Consider Velocity's own threads: Velocity has a handful of threads on which the netty event loop is run; these are sometimes colloquially referred to as the "netty threads" by plugin developers.

Plugins use threads for still other purposes. Many plugins connect to a database. A common practice is to create a connection pool and a suitably matching thread pool, such that the thread pool and the connection pool are most effectively used together -- for example, if the number of threads equals the number of connections, and both pools are fixed in size. This makes for the best performance.

#

You may be wondering why we don't simply pool all of the threads, everywhere, into one thread pool. The reason for that is some thread pools require different characteristics. Some thread pools are fixed in size, some growable. The growable thread pools have settings for the expiration time of idle threads and thresholds under which threads will be created more eagerly.

vestal prawn Jan 4, 2022, 2:31 AM

#

Okay thank you for your precise answer !

#

So for example if i want to do a query on a database, i just use an async task or a connection task rather than a sync task with my own threadpool ?

wary tiger Jan 4, 2022, 2:37 AM

#

That would be a common way of doing things, yes. I'm not sure what you mean by "connection task," but I think you understand the concept. We use threads for raw performance, organization of computations, and fine-tuning performance for certain computations (the last item relying on the second one).

#

It is common in Java, also, to name thread pools, so that it is easy to identify software responsible for certain threads in a thread dump. A thread dump is a report of all threads currently in operation; thread dumps are useful to debug deadlocks and general concurrent processes in the program.

narrow pagoda Jan 4, 2022, 3:52 AM

#

Why is Velocities Configurate so OLD O_O

whole wren Jan 4, 2022, 11:07 AM

#

I have really appreciated the help that I have got before, but I have one question. Do I need velocity plugin kotlin for kotlin use in plugins, or can I just add the kotlin stdlib to my outputs, like I do with bukkit plugins. If I have to use the kotlin plugin for velocity, I would appreciate if someone tells me how I add this to my plugin.

burnt dragon Jan 4, 2022, 11:08 AM

#

velocity doesn't include kotlin so you'd need to include it in your plugin

whole wren Jan 4, 2022, 11:08 AM

#

i mean

#

https://github.com/VelocityPowered/velocity-language-kotlin

GitHub

GitHub - VelocityPowered/velocity-language-kotlin: Velocity plugin ...

Velocity plugin that provides the Kotlin standard library and useful DSLs - GitHub - VelocityPowered/velocity-language-kotlin: Velocity plugin that provides the Kotlin standard library and useful DSLs

#

is this maintained

burnt dragon Jan 4, 2022, 11:10 AM

#

oh that, i mean yeah that's got a version for 3.x if you're okay with a slightly outdated version of the various libs it includes

whole wren Jan 4, 2022, 11:12 AM

#

thanks

whole wren Jan 4, 2022, 1:37 PM

#

sorry for spamming the channel again, but in the docs, and the java docs, I was looking for a way for the velocity plugin to recieve a plugin message from a player

#

i want to do something like this

#

https://www.spigotmc.org/wiki/sending-a-custom-plugin-message-from-bungeecord/

Sending a custom plugin message from BungeeCord | SpigotMC - High P...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

#

but in velocity

#

i need this feature, because, Citizens2 does not support calling velocity commands

#

so I have to make a plugin for paper, that sends a plugin message telling the proxy to execute some code

#

(this code is some loadbalancing and looking for the optimal server)

craggy pecan Jan 4, 2022, 1:46 PM

#

whole wren but in velocity

See https://gist.github.com/Xernium/95c9262c5f70b8791557861bbc09be1b

Gist

Velocity API 1.1.0 Plugin messaging channel example

Velocity API 1.1.0 Plugin messaging channel example - MessageListener.java

#

(that's for receiving and sending messages in Velocity, consult your backend server's docs on how to send messages to a proxy)

whole wren Jan 4, 2022, 2:14 PM

#

the rest i know

#

thanks

#

i think this should be in the velocity docs

craggy pecan Jan 4, 2022, 9:01 PM

#

Feel free to make a PR 😉

wooden mauve Jan 4, 2022, 9:48 PM

#

If I remember correctly, Velocity handles stuff in different threads. When I wanna create a player hashmap to keep the last server they where on for 30+ minutes or smth like that to send them to the same server on rejoin will join, leave events always run in the same thread or to I have to make the map threadsafe?

#

Atm I think I have to do it the second way

fossil sundial Jan 4, 2022, 9:52 PM

#

wooden mauve Atm I think I have to do it the second way

do a ConcurrentHashMap<UUID, RegisteredServer/ServerInfo>, that should work for what you need

bold wharf Jan 4, 2022, 9:53 PM

#

30 minutes

#

I mean

#

use a Cache?

wooden mauve Jan 4, 2022, 9:53 PM

#

Wym by cache

bold wharf Jan 4, 2022, 9:54 PM

#

guava caches

#

or caffeine

#

they support auto removing stuff, etc

wooden mauve Jan 4, 2022, 9:55 PM

#

I never used them, was thinking about Fives solution but I'm going to check them out now, thx

bold wharf Jan 4, 2022, 9:55 PM

#

Well, Fives solution would work, just without the time thing

wooden mauve Jan 4, 2022, 9:56 PM

#

Yeah I wanted to implement the removal on my own, but I guess the cache implementation already those that for me

#

Have to check it out

agile ore Jan 4, 2022, 10:59 PM

#

Working on a new velocity plugin (I'm new to developing for velocity) and I am able to run the commands I have registered from the console but not from a player with the correct perms. Either getting "Unknown command" or invalid args message in return. Has anyone seen this behavior before (or is it expected?). Thanks!

oblique haven Jan 4, 2022, 11:14 PM

#

agile ore Working on a new velocity plugin (I'm new to developing for velocity) and I am a...

What are you using to apply the permissions

agile ore Jan 4, 2022, 11:20 PM

#

@oblique haven LuckPerms, it's installed on the proxy and individual servers as well (both running paper)

oblique haven Jan 4, 2022, 11:22 PM

#

agile ore <@!174661611024285697> LuckPerms, it's installed on the proxy and individual ser...

You might want to have something spit out the result of the permission checks on join or something

fossil sundial Jan 4, 2022, 11:22 PM

#

and you did set the permission you used as condition on the proxy?

#

/lpv is the correct command for LP on velocity unless you linked the proxy and server(s)

agile ore Jan 4, 2022, 11:26 PM

#

The proxy and the individual servers are all linked via mysql database, and doing lpv user <username> permission check <permission> with the correct args in for the perm as well as the username come back as expected (true)

oblique haven Jan 4, 2022, 11:27 PM

#

Mk, can you show us the command and the registration along with the command you’re using or trying to use

#

With the args and everything

#

something must be wrong so

agile ore Jan 4, 2022, 11:27 PM

#

Is it alright to send screenshots in here?

oblique haven Jan 4, 2022, 11:27 PM

#

No, can you send paste links

#

Like paste.gg or something

agile ore Jan 4, 2022, 11:29 PM

#

https://paste.gg/p/anonymous/754b4bcfaf6b445c95e240bedeef1fe4

#

Here's the command class (StaffChat referenced)

#

https://paste.gg/p/anonymous/d61250362ce4424b878fd3e920955321

#

Here's the main class with the registration

oblique haven Jan 4, 2022, 11:30 PM

#

agile ore https://paste.gg/p/anonymous/754b4bcfaf6b445c95e240bedeef1fe4

Have you tried putting debug into the invocation to see if it’s even being run

#

Or printed out the result of the permission check

agile ore Jan 4, 2022, 11:30 PM

#

I'll go try that now

agile ore Jan 4, 2022, 11:51 PM

#

Sorry this took a second I had to step out, the permission check is failing

#

So how else should I be going about doing the permission check?

#

Ahh I just figured it out, my Luckperms hadn't synced properly and reseting everything cleared it up. I apologize for the inconvenience

vestal prawn Jan 5, 2022, 12:11 AM

#

API is so much cleaner than bungeecord

wary tiger Jan 5, 2022, 1:02 AM

#

The best part of Velocity

wooden mauve Jan 5, 2022, 1:47 AM

#

So, yeah I just started the test on this cache thing 5 min ago. Now the only event for logout I found in the docs (may I oversaw one) is the "DisconnectEvent", now I made a lil test setup if(event.getPlayer().getCurrentServer().isPresent()) logger.info(event.getPlayer().getCurrentServer().get().getServerInfo().getName()); because I did not know if the "getCurrentServer()" is still available at that point – as far as I see it is. But since it is an Optional, may it be not set at that point if the user was connected to a server before or is the DisconnectEvent being fired always before finally disconnected and cleared?

#

Like I understand that is optional since it could disconnect from the proxy without ever being connected to a server but if the player had a server connection before

vestal prawn Jan 5, 2022, 2:12 AM

#

#

why this last sentence ?

wooden mauve Jan 5, 2022, 2:13 AM

#

I'm also just trying to figure out what of the Login or connect events might be the best to interrupt if a previous server has been found in cache.

bold wharf Jan 5, 2022, 2:13 AM

#

Because the timer is running

#

if you take too long to let that event carry on, you can prevent a client from being able to join

vestal prawn Jan 5, 2022, 2:15 AM

#

so if i need, for example, to check if the player is banned on a very slowly database (like 5 seconds of response for example), i need to accept the event (not cancel it) and then when i have my response i kick him from the proxy ?

bold wharf Jan 5, 2022, 2:15 AM

#

Yes

vestal prawn Jan 5, 2022, 2:16 AM

#

okay thanks

#

and is there a way to manipulate yml config file like waterfall ?

#

or now it's all toml file ?

#

before we had this, is there an equivalent in velocity ?

wooden mauve Jan 5, 2022, 2:17 AM

#

How is it in my case, should I also let the proxy finish the login progress and reconnect to another server after or while connecting to a server or is it safe to send the connection request already while the login event on the proxy itself?

vestal prawn Jan 5, 2022, 2:18 AM

#

wooden mauve How is it in my case, should I also let the proxy finish the login progress and ...

in your case i think that a hashmap#get is really quick so it will be fast enough

wooden mauve Jan 5, 2022, 2:19 AM

#

Hmm still not sure what "fully initialized" might be, like difference from LoginEvent to PostLoginEvent

#

Put I guess PostLoginEvent might be the best option

#

from what I see, of all events

vestal prawn Jan 5, 2022, 2:21 AM

#

wooden mauve Hmm still not sure what "fully initialized" might be, like difference from Login...

the fully initialized is in the PreLoginEvent right ?

wooden mauve Jan 5, 2022, 2:21 AM

#

na, post

#

after Mojang auth

#

and something more

vestal prawn Jan 5, 2022, 2:21 AM

#

LoginEvent is also after Mojang

wooden mauve Jan 5, 2022, 2:21 AM

#

yes

vestal prawn Jan 5, 2022, 2:22 AM

#

i believe PostLoginEvent is when the player has the server he is about to connect to

wooden mauve Jan 5, 2022, 2:22 AM

#

A I finally found it, was hidden asF 😄

#

PlayerChooseInitialServerEvent

#

it also has a setter method

vestal prawn Jan 5, 2022, 2:23 AM

#

and do you know how to manage config file ?

wooden mauve Jan 5, 2022, 2:24 AM

#

I probl will not use build in stuff this time, since I have to merge Spigot, Bungee and Velocity later, so I did not look it up so far

#

But if you search for a way to do it via toml, that might help you https://forums.velocitypowered.com/t/plugin-configuration-file/327
I will go with yml

#

Well looks like it works with caffeine cache just fine, time to go to bed. Will clean up the code tomorrow. Thanks for help

grizzled rapids Jan 5, 2022, 10:42 AM

#

wahh

vestal prawn Jan 5, 2022, 10:53 AM

#

wooden mauve But if you search for a way to do it via toml, that might help you https://forum...

Thanks i'll look

neon roost Jan 5, 2022, 11:35 AM

#

hi, is the client unable to receive messages during ServerConnectedEvent? i'm sending a "$player switched to $server" immediately and it shows up for everyone except the one switching

#

i'm going to try using ServerPostConnectEvent right now but i'd still like to know whats happening

burnt dragon Jan 5, 2022, 11:37 AM

#

yes it could be too early for them

neon roost Jan 5, 2022, 11:42 AM

#

i think that was it, fixed by using serverpostconnect

grizzled rapids Jan 5, 2022, 1:24 PM

#

agile ore Ahh I just figured it out, my Luckperms hadn't synced properly and reseting ever...

What do you mean by that

heady seal Jan 5, 2022, 3:06 PM

#

Hello, I'm currently trying to connect to a MySQL database in my plugin.

I'm having an issue where it cannot load the driver:
java.lang.ClassNotFoundException: com.mysql.jdbc.Driver

I have looked online and found I need to include this via a class path, so I have added the following into my code before the driver is used:
server.getPluginManager().addToClasspath(this, Path.of("lib/"));

However the issue still persists, I have included the driver in the lib folder.

Please let me know if I need to do something differently. Thanks!

narrow pagoda Jan 5, 2022, 3:12 PM

#

I had better luck with literally just running Class.forName to the driver after including it as a shaded and relocated dependency

bold wharf Jan 5, 2022, 3:13 PM

#

does the addToClasspath thing 1) modify the classpath seen by currently loaded plugins 2) work in a useful manner to actually load jars in a folder?

#

idk how the classloaders care when you pass a dir to them as stuff is generally resolved there

wary tiger Jan 5, 2022, 3:16 PM

#

Yes to 1.

#

Yes to 2.

#

The URLs in addToClasspath are passed directly to URLClassloader#addURL

heady seal Jan 5, 2022, 3:19 PM

#

Ah, specifying the jar in the folder lib/mysql-connector-java-8.0.27.jar has done the trick!
However now its saying that driver is obsolete and I should use "com.mysql.cj.jdbc.Driver" instead

wary tiger Jan 5, 2022, 3:20 PM

#

Moreover, you should isolate your dependencies from other plugins.

bold wharf Jan 5, 2022, 3:21 PM

#

well, you're calling Class.forName on the old class

#

the class it's telling you to use is where they moved stuff

grizzled rapids Jan 5, 2022, 3:21 PM

#

player2.playSound(Sound.sound(Key.key("BLOCK_BELL_USE"), Sound.Source.MASTER, 1, 3)); shows me a warning in the first parameter Key that it doesn't match regex

rich hawk Jan 5, 2022, 3:27 PM

#

Velocity doesn’t support sounds iirc

grizzled rapids Jan 5, 2022, 3:27 PM

#

aight but I thought it does because the playsound method exists

rich hawk Jan 5, 2022, 3:27 PM

#

From adventure

burnt dragon Jan 5, 2022, 3:28 PM

#

fwiw, that sound isn't a sound anyway

grizzled rapids Jan 5, 2022, 3:28 PM

#

rich hawk From adventure

meaning??

#

ah yeah it just isn't a mc sound

burnt dragon Jan 5, 2022, 3:28 PM

#

adventure provides the ability to play sounds, if implemented - velocity implements adventure but chooses not to implement the ability to play sounds

#

https://docs.adventure.kyori.net/platform/native

fossil sundial Jan 5, 2022, 4:14 PM

#

This isn’t implemented because that would require velocity to keep track of player and entity positions. It’s extra load that’s not justified for a proxy

burnt dragon Jan 5, 2022, 4:19 PM

#

you don't need to keep track of that stuff, the main issue would be with holding a resource mapping of sound -> id which is tricky

vestal prawn Jan 5, 2022, 4:20 PM

#

is there a broadcast thing like waterfall ?

fossil sundial Jan 5, 2022, 5:03 PM

#

burnt dragon you don't *need* to keep track of that stuff, the main issue would be with holdi...

That’s not the entire issue, if you want to do it right you do have to track locations and entity IDs; And that all varies with version

fossil sundial Jan 5, 2022, 5:05 PM

#

vestal prawn is there a broadcast thing like waterfall ?

ProxyServer extends Audience so it has the same sendMessage(Component) function as players do if that’s what you’re asking

keen scaffold Jan 5, 2022, 5:30 PM

#

How can I force a player to perform a command or go to a different server?
I want to make a lobby compass that can take you to different servers. If I could do something like Player.performCommand("/server lobby") but for Velocity commands, that would work.

burnt dragon Jan 5, 2022, 5:32 PM

#

i mean you can do spoofChatInput but you could just move them to the other server directly

keen scaffold Jan 5, 2022, 5:33 PM

#

How would I do that?

#

If spoofChatInput works, then that's fine with me

burnt dragon Jan 5, 2022, 5:35 PM

#

player.createConnectionRequest().something i cant remember

#

yeah, player.createConnectionRequest(server) and either .fireAndForget() if you don't care about the result, or one of the other methods if you do care about the result

keen scaffold Jan 5, 2022, 5:42 PM

#

Thank you, I got it all figured out.

faint sigil Jan 5, 2022, 6:15 PM

#

Quick question, are the Watterfall and Velocity UUID's the same, because there are different ways to get those on both sides, thank you for your answer in advance.

rich hawk Jan 5, 2022, 6:15 PM

#

Yes

vestal prawn Jan 5, 2022, 6:25 PM

#

is there an equivalent of ChatColor.translateAlternateColorCodes('&', message) ?

burnt dragon Jan 5, 2022, 6:26 PM

#

you can use the legacy component serializer

#

or just just a non-legacy, modern format like minimessage

vestal prawn Jan 5, 2022, 6:29 PM

#

what ?

bronze yoke Jan 5, 2022, 6:36 PM

#

read up on kyori’s LegacyComponentSerializer or just use MiniMessage which is more modern

vestal prawn Jan 5, 2022, 6:42 PM

#

have you an example ?

#

like if i want to send a message that looks like "&1Hello&2World"

#

Minimessage uses some weird html tags

burnt dragon Jan 5, 2022, 6:44 PM

#

ampersand arbitrary letter user calling tags weird

#

again, you can just the legacy component serializer

atomic leafBOT Jan 5, 2022, 6:44 PM

#

https://docs.adventure.kyori.net/

burnt dragon Jan 5, 2022, 6:44 PM

#

see docs here ^

vestal prawn Jan 5, 2022, 6:45 PM

#

i already read it but sadly there is no example

burnt dragon Jan 5, 2022, 6:48 PM

#

i will link the page for you

#

https://docs.adventure.kyori.net/serializer/

vestal prawn Jan 5, 2022, 6:52 PM

#

aaah

#

i clicked directly on the "legacy" menu that's why i never found it

#

thanks

keen scaffold Jan 5, 2022, 6:55 PM

#

Do I need some Velocity plugin to put in my server? I keep getting this error Caused by: java.lang.ClassNotFoundException: com.velocitypowered.api.proxy.Player

burnt dragon Jan 5, 2022, 6:58 PM

#

uh, velocity is a proxy software - you can't run velocity plugins on your server software

keen scaffold Jan 5, 2022, 7:10 PM

#

If I move it in the proxy plugins folder, I get this, Exception in thread "main" java.lang.NoClassDefFoundError: org/bukkit/plugin/java/JavaPlugin

rich hawk Jan 5, 2022, 7:11 PM

#

contact plugin author?

#

Also show the full logs

atomic leafBOT Jan 5, 2022, 7:11 PM

#

Please send large files/logs to a pastebin

New · paste.gg

A sensible, modern pastebin. Share text and source code snippets with no hassle.

vernal compass Jan 5, 2022, 7:11 PM

#

that error sounds like you tried to put a Bukkit plugin on a Velocity server

bold wharf Jan 5, 2022, 7:12 PM

#

I mean, you put a velocity plugin on a bukkit server

keen scaffold Jan 5, 2022, 7:12 PM

#

I'm trying to make a lobby compass. And to do that, I need access to com.velocitypowered.api.proxy.Player

bold wharf Jan 5, 2022, 7:12 PM

#

and then you put a bukkit plugin on a velocity server

#

No

#

I mean

#

you can't access that class from the server

#

use the plugin messaging channel

keen scaffold Jan 5, 2022, 7:13 PM

#

How would I do that?

#

The documentation only shows the basics.

bold wharf Jan 5, 2022, 7:13 PM

#

I mean, you'd do that from the server, in which see the spigot wiki

#

they have a full page dedicated to the bungeecord messaging channel

#

(velocity reimplements that itself)

keen scaffold Jan 5, 2022, 7:20 PM

#

I cannot find the page that you are talking about.

vernal compass Jan 5, 2022, 7:22 PM

#

https://www.spigotmc.org/wiki/bukkit-bungee-plugin-messaging-channel/

keen scaffold Jan 5, 2022, 7:43 PM

#

Thank you, everyone. I got it working.

glacial kraken Jan 5, 2022, 7:59 PM

#

Guys if im making a cross platform plugin and a universal jar, and i wanna use kyori's adventure, i can shade it but for velocity this probably wont work

#

Am i right?

burnt dragon Jan 5, 2022, 8:00 PM

#

cross what platforms?

glacial kraken Jan 5, 2022, 8:01 PM

#

I mean like

#

Bukkit, bungee, sponge, nukkit, velocity

burnt dragon Jan 5, 2022, 8:02 PM

#

blimey, well

#

id recommend not doing that

#

but if you absolutely have to for some god forsaken reason, split your stuff up into different modules

narrow pagoda Jan 5, 2022, 8:02 PM

#

Relocate it and just don't think about it, or exclude the dependency in the velocity module

burnt dragon Jan 5, 2022, 8:03 PM

#

well if you relocate adventure then nothing on velocity will work

#

if you shade it then velocity might throw a fit

#

so like, gl ?

glacial kraken Jan 5, 2022, 8:05 PM

#

burnt dragon but if you absolutely have to for some god forsaken reason, split your stuff up ...

Ofc i would do that i mean i need universal jar

burnt dragon Jan 5, 2022, 8:06 PM

#

you don't need a universal jar

glacial kraken Jan 5, 2022, 8:06 PM

#

Right

#

But universal jar is good for multiple reasons

burnt dragon Jan 5, 2022, 8:06 PM

#

look at, for example, luckperms - they don't produce a universal jar because of how annoying it is

bold wharf Jan 5, 2022, 8:06 PM

#

universal makes sense when you can contain shit

glacial kraken Jan 5, 2022, 8:07 PM

#

If i put it on spigot which jar i should upload lol 😀

burnt dragon Jan 5, 2022, 8:07 PM

#

the spigot jar?

bold wharf Jan 5, 2022, 8:07 PM

#

when you start getting into platform oddities, stuff starts going sideways, especially with cases where some deps need to be shaded, some deps would be harmful

glacial kraken Jan 5, 2022, 8:07 PM

#

Spigotmc website i mean

bold wharf Jan 5, 2022, 8:07 PM

#

they have a bungee and a spigot plugin section

#

you'd basically have to upload it twice if not universal

burnt dragon Jan 5, 2022, 8:08 PM

#

or link to a downloads page

bold wharf Jan 5, 2022, 8:08 PM

#

if you hated yourself there is the horrors that LP does where he can decide programatically what's pulled in

glacial kraken Jan 5, 2022, 8:08 PM

#

I don't want those aternos users to kill me in reviews section

bold wharf Jan 5, 2022, 8:08 PM

#

but, that's a headache

glacial kraken Jan 5, 2022, 8:08 PM

#

Ok thx anyways

burnt dragon Jan 5, 2022, 8:09 PM

#

just save yourself a headache and keep stuff separate whilst still having a common module you can keep common stuff in

amber basin Jan 5, 2022, 8:25 PM

#

I'm writing a server implementation that would conveniently provide support for velocity as a proxy, but I'm having hard time finding any official documentation about the exact plugin messages being exchanged between server and proxy, there's nothing on the website or the Github. (At this moment I have already reverse engineered it) I think that adding this information to the developer documentation will be useful for others along with myself! thanks!

analog dew Jan 5, 2022, 8:42 PM

#

I don't think it would be rejected if you made a PR to the docs, but I doubt anyone is going to go out of their way - it's trivial to reverse engineer it from the source and existing implementations (source: I did it for fun years ago when Velocity first started)

amber basin Jan 5, 2022, 9:04 PM

#

true enough, I'll reconsider when I have time :)

fossil sundial Jan 5, 2022, 10:08 PM

#

It’s all things I’d love to document

#

But I am seriously lacking for time

agile ore Jan 5, 2022, 11:15 PM

#

Hey @fossil sundial I seem to remember you have a velocity 3 autoupdate script, would you be able to run it on this plugin it used to be quite handy on my server. https://github.com/Tobi406/Aliasr

GitHub

GitHub - Tobi406/Aliasr: Velocity Plugin that can do aliases using ...

Velocity Plugin that can do aliases using RegEx. Contribute to Tobi406/Aliasr development by creating an account on GitHub.

jaunty spade Jan 6, 2022, 4:14 AM

#

Is there a similar feature to Bungeecord/Bukkit setCancelled(true)? I am trying to stop a message being sent under specific conditions and I have tried:
event.SetResult(PlayerChatEvent.ChatResult.denied(), but the message is still being sent.

knotty mica Jan 6, 2022, 10:22 AM

#

Disable username validation in your paper.yml
Also this is the wrong category entirely

fossil sundial Jan 6, 2022, 12:40 PM

#

jaunty spade Is there a similar feature to Bungeecord/Bukkit `setCancelled(true)`? I am tryin...

That’s the correct way
Which kind of message are you trying to cancel? This doesn’t apply to commands or things sent from server>client or proxy>client

agile ore Jan 6, 2022, 2:39 PM

#

hi

#

i tried to create boss-bar for 1.8.8+ in one of my velocity plugins

#

https://jd.adventure.kyori.net/api/4.7.0/net/kyori/adventure/bossbar/BossBar.Color.html

BossBar.Color (adventure-api 4.7.0 API)

declaration: package: net.kyori.adventure.bossbar, interface: BossBar, enum: Color

#

but the boss-bar it's working just for 1.9+ players

bold wharf Jan 6, 2022, 2:41 PM

#

seems legit

#

bossbars where tied to entities in 1.8

#

So, not supported as the game didn't support standalone bossbars then

vestal prawn Jan 6, 2022, 2:43 PM

#

Is there other variables that we can inject in the plugin constructor ? Except for the ProxyServer, Logger and directoryPath ?

jaunty spade Jan 6, 2022, 3:13 PM

#

fossil sundial That’s the correct way Which kind of message are you trying to cancel? This does...

Just whoever someone chats in chat. I am using the PlayerChatEvent. Everything else does work besides that. I can do some more testing later today.

zealous wigeon Jan 6, 2022, 4:09 PM

#

Hi, I would like to know if it was possible like on Spigot to build its libraries in a folder next to it so that they are not included in the jar so that it is less heavy

craggy pecan Jan 6, 2022, 4:09 PM

#

vestal prawn Is there other variables that we can inject in the plugin constructor ? Except f...

What else do you need?

faint sigil Jan 6, 2022, 5:57 PM

#

Is there an way to get the Players UUID who is Pinging the Proxy (ProxyPingEvent)?

rich hawk Jan 6, 2022, 5:58 PM

#

No

faint sigil Jan 6, 2022, 6:00 PM

#

Ok ): Thx

vestal prawn Jan 6, 2022, 7:16 PM

#

no because he is not authenticated with mojang

#

Uuid comes when the player is authenticated with mojang

oblique haven Jan 6, 2022, 7:20 PM

#

faint sigil Is there an way to get the Players UUID who is Pinging the Proxy (ProxyPingEvent...

you can hold a cache of IP -> UUID and effectively guess

faint sigil Jan 6, 2022, 7:45 PM

#

oblique haven you can hold a cache of IP -> UUID and effectively guess

That's a suitable solution , thanks.

bold wharf Jan 6, 2022, 7:47 PM

#

that works for the cheesy messages, kinda

#

but, then you get to dynamic IPs

#

CGNAT, etc

faint sigil Jan 6, 2022, 7:50 PM

#

But if its only for a short term job its possible( 10 minutes or something like that)

fierce umbra Jan 6, 2022, 10:24 PM

#

How would i get the IPs of the server under the proxy and their player count in a paper plugin?

#

The bungee way does not seem to work. I send players to servers with the message channel but not get the ip and playercount

vestal prawn Jan 6, 2022, 10:28 PM

#

faint sigil Is there an way to get the Players UUID who is Pinging the Proxy (ProxyPingEvent...

Why would you do that ?

chrome edge Jan 6, 2022, 11:40 PM

#

Maybe stupid question, but how can I get the main class instance of plugin (with @Plugin annotation) in another class?

craggy pecan Jan 6, 2022, 11:42 PM

#

You can pass it using dependency injection, i.e. pass the plugin class instance as an argument to the constructor of the class that needs access to the plugin instance

#

You can then store it in a member variable

chrome edge Jan 6, 2022, 11:43 PM

#

Ah, I didn't even think about it

#

Thanks

fierce umbra Jan 7, 2022, 7:22 AM

#

https://docs.velocitypowered.com/en/latest/developers/command-api.html

#

I dont think that is how you register a command. When i tried it, it gave me an error because you have to put the Name first and then the method.

#

Or is it because this documentation and the one on this site https://velocitypowered.com/wiki/developers/command-api/
Are written for diffrent versions?

The Command API

The Command API lets you create commands that can be executed by a player connected to the proxy or the console. Creating a command Each…

vestal prawn Jan 7, 2022, 12:17 PM

#

fierce umbra Or is it because this documentation and the one on this site https://velocitypow...

It's at the end of this page

#

CommandMeta meta = commandManager.metaBuilder("test")
// Specify other aliases (optional)
.aliases("otherAlias", "anotherAlias")
.build();

#

and then

#

commandManager.register(meta, new TestCommand());

craggy pecan Jan 7, 2022, 2:25 PM

#

fierce umbra https://docs.velocitypowered.com/en/latest/developers/command-api.html

The pages under this subdomain are for an older version of Velocity and are only kept online for archival purposes (afaik)

fossil sundial Jan 7, 2022, 4:20 PM

#

Hmm Velocity has a lot of very scarcely documented launch flags
Here is the full default set

-Dvelocity-forwarding-secret=<config>
-Dvelocity-packet-decode-logging=false
-Dvelocity.natives-tmpdir=$tmp
-Dmojang.sessionserver=“https://sessionserver.mojang.com/session/minecraft/hasJoined“
-Dvelocity.increased-compression-cap=false
-Dvelocity.natives-disabled=false
-Dvelocity.disable-native-transport=false
-Dvelocity.log-server-backpressure=false
-Dvelocity.max-packets-per-flush=8192

vestal prawn Jan 7, 2022, 4:21 PM

#

do we need to always use concurrentMap in commands and events since there is a lot of thread ?

fossil sundial Jan 7, 2022, 4:24 PM

#

vestal prawn do we need to always use concurrentMap in commands and events since there is a l...

depends on what you’re trying to do? I don’t understand your question

vestal prawn Jan 7, 2022, 4:25 PM

#

fossil sundial depends on what you’re trying to do? I don’t understand your question

someone told me that velocity use poolthread for his system, so if for example i use a Map in a Command or an Event, do i need to set the map as ConcurrentMap to prevent that two threads use the same map at the same moment ?

fossil sundial Jan 7, 2022, 4:26 PM

#

Well yes, if you need to store data outside of the command execution chain you need to ensure its thread-safe

vestal prawn Jan 7, 2022, 4:27 PM

#

but if i use the map inside the execute() method it's okay ?
Or within an event handler ?

fossil sundial Jan 7, 2022, 4:29 PM

#

again, if you don’t modify or access data outside of your execution chain that might be accessed by something else at the same time you don’t need to ensure concurrency.

vestal prawn Jan 7, 2022, 4:29 PM

#

nice thanks

fossil sundial Jan 7, 2022, 4:33 PM

#

fossil sundial Hmm Velocity has a lot of very scarcely documented launch flags Here is the full...

bold wharf Jan 7, 2022, 4:33 PM

#

the concurrency model of velocity is honestly kinda confusing

#

I remember tryna work some stuff out other day and that's probs what killed me off for the rest of the week

#

#ThxFive

paper summit Jan 7, 2022, 5:57 PM

#

if I have a Spigot EntityType, and I convert it to Mojang EntityType with CraftMagicNumbers.getEntityTypes(type) how do I check if the resulting type is EntityType<? extends Mob> it seems like its very confused because it returns EntityType<?>

#

if I do instanceof I guess it doesn't do much because both of them are EntityTypes and its not checking the generics

bold wharf Jan 7, 2022, 5:58 PM

#

wrong channel

#

you basically can't "safely"

paper summit Jan 7, 2022, 5:58 PM

#

o shoot omg

vestal prawn Jan 7, 2022, 7:15 PM

#

bold wharf the concurrency model of velocity is honestly kinda confusing

yep that's why i put ConcurrentMap and Set everywhere lol

#

a tiny bit "slower" but not notable so...

nova sparrow Jan 7, 2022, 9:33 PM

#

So im trying to convert a string containing a RGB value into a color value

#

&#837492Hello World for example could be a string with a RGB color value

#

For some reason it's only parsing the final value of the RGB, In this case it would be &2Hello World

#

    private static final Pattern pattern = Pattern.compile("&#[a-fA-F0-9]{6}");
    public static String color(String s) {
        s = format(s);
        Matcher match = pattern.matcher(s);
        while (match.find()) {
            String color = s.substring(match.start() + 1, match.end());
            String color1 = s.substring(match.start(), match.end());
            s = s.replace(color1, ChatColor.of(color) + "");
            match = pattern.matcher(s);
        }

        return ChatColor.translateAlternateColorCodes('&', s);
    }```

#

I've seen other velocity plugins use RGB values like #938203, but i want to be able to use it as &#938203

#

Any ideas?

burnt dragon Jan 7, 2022, 9:39 PM

#

use the legacy component serializer

nova sparrow Jan 7, 2022, 9:39 PM

#

How do i call that?

burnt dragon Jan 7, 2022, 9:39 PM

#

you'll need to build one

nova sparrow Jan 7, 2022, 9:40 PM

#

Are there any existing examples to save time on research on how to do that?

burnt dragon Jan 7, 2022, 9:40 PM

#

// store this somewhere
LegacyComponentSerializer serializer = LegacyComponentSerializer.builder().character('&').hexCharacter('#').hexColors().build();

// use it like
serializer.deserialize(string);

nova sparrow Jan 7, 2022, 9:45 PM

#

Hmm so if i wanted to format &7Hello World (or with a hex) i'd just call serializer.deserialize("&7Hello World")

burnt dragon Jan 7, 2022, 9:47 PM

#

yes

nova sparrow Jan 7, 2022, 9:47 PM

#

Oh

#

serializer.deserialize(.) takes in a component not a string

burnt dragon Jan 7, 2022, 9:50 PM

#

oh, it's serialize then

nova sparrow Jan 7, 2022, 9:50 PM

#

Im stupid i wrote that wrong

#

i meant serializer.serialize(.) takes a component

#

bold wharf Jan 7, 2022, 9:52 PM

#

Component is the data representation

#

or, the true one

#

if you wanna serialise to legacy, you pass in a component

#

if you wanna read legacy, you deserialise it into a component

nova sparrow Jan 7, 2022, 9:54 PM

#

Ahh thanks a bunch you two

unkempt lantern Jan 8, 2022, 7:26 AM

#

If we do legacy forwarding what we have to configure in servers

quick pike Jan 8, 2022, 7:44 AM

#

Whats the best auth plugin still date for velocity

#

Till*

agile ore Jan 8, 2022, 8:47 AM

#

quick pike Whats the best auth plugin still date for velocity

Online mode

agile ore Jan 8, 2022, 12:11 PM

#

LOL

agile ore Jan 8, 2022, 12:12 PM

#

quick pike Whats the best auth plugin still date for velocity

i would use auth me, their velocity plugin + authserver spigot plugin

vestal prawn Jan 8, 2022, 12:30 PM

#

online mode yes

#

why accept crack, it's 2022, the game is only 25 dollars everyone can afford it

heady seal Jan 8, 2022, 12:40 PM

#

ping server

vestal prawn Jan 8, 2022, 1:08 PM

#

i have a weird bug with velocity

#

when i do this, it says that the command is unknown, normal i don't have the permission

#

but if i do that

#

it prompts an error

#

i don't have the permission too

#

normally it should display the same output "Unkown command"

craggy pecan Jan 8, 2022, 2:11 PM

#

No, that's expected behavior and follows what Brigadier does

#

It's not really intuitive, blame Mojang /shrug

graceful relic Jan 8, 2022, 2:38 PM

#

Why does my server logo not work?

It works on my backend servers fine and when I add it to proxy it just goes black.

knotty mica Jan 8, 2022, 11:23 PM

#

graceful relic Why does my server logo not work? It works on my backend servers fine and when...

You're asking in the wrong channel.

nova sparrow Jan 9, 2022, 6:19 AM

#

Trying to create a simple custom tab list, having trouble with it
I am able to see the custom tab list for a millisecond when a player logs in but it instantly resets to just a vanilla username

#

public class CustomPlayerlist {

    @Subscribe
    public void connect(ServerConnectedEvent event) {
        update(event.getServer());
    }

    @Subscribe
    public void disconnect(DisconnectEvent event) {
        update(event.getPlayer().getCurrentServer().get().getServer());
    }

    public static void update(RegisteredServer server) {
        FileConfiguration c = Config.DEFAULT;
        for (Player playerToUpdate : UKMC.getServer().getAllPlayers()) {
            GameTablistUpdateEvent event = new GameTablistUpdateEvent(playerToUpdate);
            GameEvents.fire(event);
            if (!event.isOverridden()) {
                for (Player p : UKMC.getServer().getAllPlayers()) {
                    if (!playerToUpdate.getTabList().containsEntry(p.getUniqueId())) {
                        playerToUpdate.getTabList().addEntry(
                                TabListEntry.builder()
                                        .displayName(Chat.color(c.getString("tab.default-list"), p))
                                        .profile(p.getGameProfile())
                                        .gameMode(0)
                                        .tabList(playerToUpdate.getTabList())
                                        .build()
                        );
                    }
                }
            }
        }
    }
}```

#

        UKMC.getServer().getScheduler().buildTask(UKMC.get(), () -> {
            for (RegisteredServer r : UKMC.getServer().getAllServers()) {
                CustomPlayerlist.update(r);
            }
        }).repeat(50L, TimeUnit.MILLISECONDS).schedule();```

#

(Also it is registered as an event)
Any ideas?

agile ore Jan 9, 2022, 6:26 AM

#

https://dl.dropboxusercontent.com/s/a8zwoslt3ryxs5n/msedge_DD2BeDcpgx.png

#

https://versions.velocitypowered.com/download/3.0.x-SNAPSHOT.jar

night saddle Jan 9, 2022, 6:40 AM

#

To my understanding, when packets are intercepted by velocity, the packet is decoded & encoded again, even when there is no change to the contents

#

Would it not be better to forward the original ByteBuf if the packet hasn't been modified?

bold wharf Jan 9, 2022, 7:54 AM

#

then you gotta try and pass all that down the stack and deal with figuring out if it mutated, etc

#

You gotta decode it to be able to process it

night saddle Jan 9, 2022, 8:03 AM

#

public class SetSlotPacket implements MinecraftPacket {

    private byte windowId;
    private int stateId;
    private short slot;
    private ItemStack itemStack;

    @Override
    public void decode(ByteBuf buf, ProtocolUtils.Direction direction, ProtocolVersion protocolVersion) {
        windowId = buf.readByte();
        stateId = ProtocolUtils.readVarInt(buf);
        slot = buf.readShort();
        itemStack = ItemStack.readItemStack(buf);
    }

    @Override
    public void encode(ByteBuf buf, ProtocolUtils.Direction direction, ProtocolVersion protocolVersion) {
        buf.writeByte(windowId);
        ProtocolUtils.writeVarInt(buf, stateId);
        buf.writeShort(slot);
        ItemStack.writeItemStack(buf, itemStack);
    }

    @Override
    public boolean handle(MinecraftSessionHandler handler) {
        if (handler instanceof BackendPlaySessionHandler backend) {
            ConnectedPlayer player = backend.serverConn.getPlayer();
            itemStack = Translator.translateItemStack(player, itemStack);
        }
        return false;
    }

}```
I'm implementing Item translations like this. I think it would be relatively easy to cache the ByteBuf in the encode method, change whether it has been modified in the handle method, and if it hasn't, call `buf.writeBytes` with the cached buffer in encode

#

Obviously, the most difficult part of that is determining change from the MinecraftSessionHandler, but I don't think the caching requires a bunch of "passing down" like you said

bold wharf Jan 9, 2022, 8:05 AM

#

the OG buffer isn't stored

night saddle Jan 9, 2022, 8:06 AM

#

Isn't the OG buffer passed into decode?

bold wharf Jan 9, 2022, 8:06 AM

#

Yes, but none of the packets store that

night saddle Jan 9, 2022, 8:06 AM

#

Right, but I'm saying they could store that

#

Probably doesn't matter too much for the packets that base velocity intercepts

bold wharf Jan 9, 2022, 8:07 AM

#

you'd basically need to slice the buffer or something

night saddle Jan 9, 2022, 8:07 AM

#

Since most of them are either very simple or don't occur that often (eg. JoinGame)

night saddle Jan 9, 2022, 8:07 AM

#

bold wharf you'd basically need to slice the buffer or something

wdym? is it not possible to rewind it?

bold wharf Jan 9, 2022, 8:08 AM

#

Well, if you get into marking it, yes

night saddle Jan 9, 2022, 8:08 AM

#

or, worse case scenario, just copy it twice

bold wharf Jan 9, 2022, 8:08 AM

#

which then starts getting into consume the systems direct buffers or using heap buffers

#

slicing doesn't copy, iirc, it's retained towards the original buffer object from what I recall

#

it's basically just a sliced view, iirc

night saddle Jan 9, 2022, 8:12 AM

#

private ByteBuf cachedBuf;
    private int readerIndex;

    private byte windowId;
    private int stateId;
    private short slot;
    private ItemStack itemStack;

    @Override
    public void decode(ByteBuf buf, ProtocolUtils.Direction direction, ProtocolVersion protocolVersion) {
        this.readerIndex = buf.readerIndex();
        this.cachedBuf = buf;

        windowId = buf.readByte();
        stateId = ProtocolUtils.readVarInt(buf);
        slot = buf.readShort();
        itemStack = ItemStack.readItemStack(buf);
    }

    @Override
    public void encode(ByteBuf buf, ProtocolUtils.Direction direction, ProtocolVersion protocolVersion) {
        if (true) { // if(!changed)
            cachedBuf.readerIndex(readerIndex);
            buf.writeBytes(cachedBuf);
            return;
        }

        buf.writeByte(windowId);
        ProtocolUtils.writeVarInt(buf, stateId);
        buf.writeShort(slot);
        ItemStack.writeItemStack(buf, itemStack);
    }```

#

Sorry for code dumps, but this naive approach seems to function

slate hamlet Jan 9, 2022, 9:28 AM

#

Hey, quick question: Is there a reason for everything being Optional which is nullable, except for the previous server in the ServerPostConnectEvent? PandaThink

agile ore Jan 9, 2022, 10:16 AM

#

because the previous server becomes the current one afaik

slate hamlet Jan 9, 2022, 11:12 AM

#

Fired after the player has connected to a server. The server the player is now connected to is available in Player.getCurrentServer(). PandaThink

#

I think the previous server is the server the player came from

hazy socket Jan 9, 2022, 11:32 AM

#

seems like i cant send plugin message in ServerPreConnectEvent

#

works well if i don't send plugin message

fleet sailBOT Jan 9, 2022, 11:33 AM

#

hazy socket works well if i don't send plugin message

message.txt by @hazy socket: https://paste.gg/4d1e856742ac44f898710b0bb3f54759

agile ore Jan 9, 2022, 11:33 AM

#

hazy socket seems like i cant send plugin message in ServerPreConnectEvent

I mean, you're not connected yet

#

so you can't send a plugin message to the server

hazy socket Jan 9, 2022, 11:33 AM

#

umm

#

i want to send to the server currently player is connected to

#

well player is connected to the server in ServerPreConnectEvent right?

craggy pecan Jan 9, 2022, 11:49 AM

#

As its name indicates, no, you're not yet connected. You're probs looking for ServerConnectedEvent. Iirc you will still need to wait a few ticks before you can send plugin messages

nova sparrow Jan 9, 2022, 12:09 PM

#

nova sparrow Trying to create a simple custom tab list, having trouble with it I am able to s...

bump

hazy socket Jan 9, 2022, 12:17 PM

#

craggy pecan As its name indicates, no, you're not yet connected. You're probs looking for Se...

umm i think i didn't explain it right.
i need to send plugin message to the previous server that player was connected to.
so my plugin is the previous server can fully save all data and THAN successfully keep connect to the target server

craggy pecan Jan 9, 2022, 12:19 PM

#

Ah, my bad. Anyways, sending a save request on player disconnect might be too late for the new server to get the fresh data. It's usually better to save the data on the backend server, and then send a server switch request to the proxy (e.g. using the BungeeCord plugin messaging API)

hazy socket Jan 9, 2022, 12:36 PM

#

craggy pecan Ah, my bad. Anyways, sending a save request on player disconnect might be too la...

hmm what do you mean by 'backend sever'?
anyway the event is 'Pre' event so i thought it should work fine.
also delaying the event worked but that does not work
kindof sad

#

well my method worked in bungeecord but not in velocity right now

craggy pecan Jan 9, 2022, 1:29 PM

#

The backend server is Paper, Sponge, etc.

oblique haven Jan 9, 2022, 1:45 PM

#

user -> proxy -> backend (essentially, if you want the technical terms most people use)

nova sparrow Jan 9, 2022, 2:21 PM

#

nova sparrow ```java public class CustomPlayerlist { @Subscribe public void connect(...

bumpx2

oblique haven Jan 9, 2022, 2:23 PM

#

nova sparrow bumpx2

does this behavior replicate on waterfall/bungeecord?

#

if so, #paper-help (but my guess is you need to put a tick delay in the on join)

#

oh you're trying to handle tab lists on velocity? where did you get the API for that, afaik there's none built into velocity

nova sparrow Jan 9, 2022, 2:25 PM

#

You see it does work

#

Just like

#

For a fraction of a second

#

Then resets to default tablist entries

#

I think paper may be overriding it?

oblique haven Jan 9, 2022, 2:25 PM

#

maybe, probably

#

put a delay, see if that fixes it ig

#

idk what API you're using to do scoreboards like that so I can't really help much, but that's my guess

nova sparrow Jan 9, 2022, 2:26 PM

#

No api

#

Velocity has it built in

oblique haven Jan 9, 2022, 2:26 PM

#

0.o where, how

nova sparrow Jan 9, 2022, 2:27 PM

#

Sec

#

Ill show booting intellij

oblique haven Jan 9, 2022, 2:27 PM

#

sure

nova sparrow Jan 9, 2022, 2:30 PM

#

package com.mattmx.ukmc.features.tab;

import com.mattmx.ukmc.UKMC;
import com.mattmx.ukmc.ingame.gamemanager.events.GameEvent;
import com.mattmx.ukmc.ingame.gamemanager.events.GameEvents;
import com.mattmx.ukmc.ingame.gamemanager.events.GameTabUpdateEvent;
import com.mattmx.ukmc.ingame.gamemanager.events.GameTablistUpdateEvent;
import com.mattmx.ukmc.util.Chat;
import com.mattmx.ukmc.util.Config;
import com.velocitypowered.api.event.Subscribe;
import com.velocitypowered.api.event.connection.DisconnectEvent;
import com.velocitypowered.api.event.player.ServerConnectedEvent;
import com.velocitypowered.api.proxy.Player;
import com.velocitypowered.api.proxy.player.TabList;
import com.velocitypowered.api.proxy.player.TabListEntry;
import com.velocitypowered.api.proxy.server.RegisteredServer;
import org.simpleyaml.configuration.file.FileConfiguration;

import java.util.Optional;
import java.util.UUID;

public class CustomPlayerlist {

    @Subscribe
    public void connect(ServerConnectedEvent event) {
        update(event.getServer());
    }

    @Subscribe
    public void disconnect(DisconnectEvent event) {
        update(event.getPlayer().getCurrentServer().get().getServer());
    }

    public static void update(RegisteredServer server) {
        FileConfiguration c = Config.DEFAULT;
        for (Player playerToUpdate : UKMC.getServer().getAllPlayers()) {
            GameTablistUpdateEvent event = new GameTablistUpdateEvent(playerToUpdate);
            GameEvents.fire(event);
            if (!event.isOverridden()) {
                for (Player p : UKMC.getServer().getAllPlayers()) {
                    if (!playerToUpdate.getTabList().containsEntry(p.getUniqueId())) {
                        playerToUpdate.getTabList().addEntry(
                                TabListEntry.builder()
                                        .displayName(Chat.color(c.getString("tab.default-list"), p))
                                        .profile(p.getGameProfile())
                                        .gameMode(0)
                                        .tabList(playerToUpdate.getTabList())
                                        .build()
                        );
                    }
                }
            }
        }
    }
}```

#

import com.velocitypowered.api.proxy.player.TabListEntry;

#

Can set the tab to whatever you want 🙏

oblique haven Jan 9, 2022, 2:31 PM

#

oh it's scoreboards that aren't implemented, one sec, lemme look at it rq

#

@nova sparrow first issue - you're looping over all servers, but then you're looping over all players in the proxy never using that server variable, so it seems like you're doing a ton more work than you actually need to be doing to handle this

nova sparrow Jan 9, 2022, 2:33 PM

#

Oh i think that was me just messing around last night

#

Probably forgot to reset it to what it is mean to to be

oblique haven Jan 9, 2022, 2:33 PM

#

can you show me a working example of it breaking, then I may be able to help more

#

also why are you doing it on join / disconnect when you're also setting up a scheduler to do it as well

#

are you trying to get a proxy-wide tablist? is that what this is meant to be doing

nova sparrow Jan 9, 2022, 2:34 PM

#

No its not proxy wide

#

Per-proxy

#

Well per registered server

oblique haven Jan 9, 2022, 2:34 PM

#

if it's per-server tablists why are you handling it at the proxy level

nova sparrow Jan 9, 2022, 2:35 PM

#

Wdym by that?

oblique haven Jan 9, 2022, 2:35 PM

#

so your tablists are scoped to the server, so why are you handling the tablists at the proxy layer

#

like if 1 tab list belongs to a single server, shouldn't the server be handling that tablist?

nova sparrow Jan 9, 2022, 2:36 PM

#

I'd like to keep the formatting all syncronized

oblique haven Jan 9, 2022, 2:37 PM

#

I think there's better ways to achieve what you're trying to achieve there, but okei, we'll go with it for now

It looks like you're effectively calling all players and managing each player's tablist on a scheduler with all other users, you're not really scoping it to the server, which you should be doing

#

for (Player playerToUpdate : UKMC.getServer().getAllPlayers()) {```
I imagine this should be replaced with the users on the specific server

nova sparrow Jan 9, 2022, 2:37 PM

#

Yeah it already is

oblique haven Jan 9, 2022, 2:37 PM

#

and you probably want to get rid of the thing looping doing that since it's not really useful, nothing should really be pushing updates to existing users server-side, so you can probably get away with updating on-join

nova sparrow Jan 9, 2022, 2:37 PM

#

That code i provided was me messing with it

oblique haven Jan 9, 2022, 2:38 PM

#

can you show me your currently working functions, so I can get a better idea of what you're doing

nova sparrow Jan 9, 2022, 2:40 PM

#

Working functions?

oblique haven Jan 9, 2022, 2:40 PM

#

nova sparrow Working functions?

like what you're actually using

#

vs what you were playing around with

nova sparrow Jan 9, 2022, 2:44 PM

#

public class CustomPlayerlist {

    @Subscribe
    public void connect(ServerConnectedEvent event) {
        //update(event.getPlayer(), event.getServer(), false);
        update(event.getServer());
    }

    @Subscribe
    public void disconnect(DisconnectEvent event) {
        //update(event.getPlayer(), event.getPlayer().getCurrentServer().get().getServer(), true);
        update(event.getPlayer().getCurrentServer().get().getServer());
    }

    public static void update(RegisteredServer server) {
        FileConfiguration c = Config.DEFAULT;
        for (Player playerToUpdate : server.getPlayersConnected()) {
            GameTablistUpdateEvent event = new GameTablistUpdateEvent(playerToUpdate);
            GameEvents.fire(event);
            if (!event.isOverridden()) {
                for (Player p : server.getPlayersConnected()) {
                    if (!playerToUpdate.getTabList().containsEntry(p.getUniqueId())) {
                        UKMC.getServer().getScheduler().buildTask(UKMC.get(), () -> {
                            playerToUpdate.getTabList().addEntry(
                                    TabListEntry.builder()
                                            .displayName(Chat.color(c.getString("tab.default-list"), p))
                                            .profile(p.getGameProfile())
                                            .gameMode(0)
                                            .tabList(playerToUpdate.getTabList())
                                            .build()
                            );
                        }).delay(100L, TimeUnit.MILLISECONDS).schedule();
                    }
                }
            }
        }
    }

}```

#

Okay it kind of works?

#

#

However

#

When i log on; already logged on players are not updated for the joiing account

#

Wait

#

might have it

#

OK

#

WE got it

#

Working

#

🙏

#

@oblique haven Thank you so much for the time and help

nova sparrow Jan 9, 2022, 3:53 PM

#

and priority sorted 😌

worldly granite Jan 9, 2022, 5:33 PM

#

What version of the API should I depend on? The docs seem rather outdated

#

I see 3.1.0-SNAPSHOT and 4.0.0-SNAPSHOT on the maven repo

worldly granite Jan 9, 2022, 5:57 PM

#

im gonna fly with 3.1.0-SNAPSHOT

#

how does one do configurations

#

i heard someone mention Sponge but im still confused

bronze yoke Jan 9, 2022, 5:57 PM

#

4.0.0 is barely even there

#

yeah so for configurations

#

it is recommended that you use Configurate by Sponge

worldly granite Jan 9, 2022, 5:57 PM

#

ight

bronze yoke Jan 9, 2022, 5:58 PM

#

since it’s bundled

worldly granite Jan 9, 2022, 5:58 PM

#

are there any example implementations

bronze yoke Jan 9, 2022, 5:58 PM

#

you can probably find some but there’s tutorials on their github page as well

worldly granite Jan 9, 2022, 5:58 PM

#

can you link

bronze yoke Jan 9, 2022, 5:58 PM

#

https://github.com/SpongePowered/Configurate

GitHub

GitHub - SpongePowered/Configurate: A simple configuration library ...

A simple configuration library for Java applications providing a node structure, a variety of formats, and tools for transformation - GitHub - SpongePowered/Configurate: A simple configuration libr...

worldly granite Jan 9, 2022, 6:00 PM

#

yeah i just didnt know how to work with it in velocity

#

i tried looking into some other plugins but none of them seem similar

worldly granite Jan 9, 2022, 6:18 PM

#

    @Subscribe
    public void loadConfig(final @NotNull ProxyInitializeEvent proxyInitializeEvent) {
        this.configurationLoader = YAMLConfigurationLoader.builder()
                .setPath(Paths.get(pluginFolder.toString(), "config.yml"))
                .build();

        try {
            configurationRoot = this.configurationLoader.load();
        } catch (IOException exception) {
            exception.printStackTrace();
        }
    }```

#

this is what I have so far

#

but how do i do defaults

#

?

burnt dragon Jan 9, 2022, 6:29 PM

#

sponge has a discord if you want to ask configurate questions

worldly granite Jan 9, 2022, 6:29 PM

#

do they? can you link to it

burnt dragon Jan 9, 2022, 6:30 PM

#

#community-guilds

vestal prawn Jan 9, 2022, 6:55 PM

#

Yaml is still delivered with velocity ?

#

i thought there was only toml

worldly granite Jan 9, 2022, 7:01 PM

#

the class is there

vestal prawn Jan 9, 2022, 8:49 PM

#

im dumb then, i prefer Yaml

nova sparrow Jan 10, 2022, 2:21 AM

#

praise yaml

hazy socket Jan 10, 2022, 5:05 AM

#

craggy pecan Ah, my bad. Anyways, sending a save request on player disconnect might be too la...

well i know what you are explaining, but the server switch will not only excuted by my plugin so i cant use that..

fossil sundial Jan 10, 2022, 8:31 AM

#

hazy socket well i know what you are explaining, but the server switch will not only excuted...

I’m open to have a PreServerDisconnectEvent (as a sort of last-call)
But that event would obviously only be called until after the next server is in Post-connect and also only if the disconnect wasn’t a kick or crash

#

The issue is Velocity waits for the new server connection to be successful and only then disconnects the user from the original server

#

This ensures the new connection can be aborted at the very last moment and the user won’t be kicked

#

That is partially the reason Bungeecord has these weird disconnects with some plugins that fire off multiple switch requests rapidly

hazy socket Jan 10, 2022, 10:37 AM

#

hmm

#

how can i properly send plugib message?

#

plugin*

violet lion Jan 10, 2022, 11:07 AM

#

https://gist.github.com/Xernium/95c9262c5f70b8791557861bbc09be1b

Gist

Velocity API 1.1.0 Plugin messaging channel example

Velocity API 1.1.0 Plugin messaging channel example - MessageListener.java

neon roost Jan 10, 2022, 2:22 PM

#

lads

#

why does serverconnectedevent not fire after a player gets kicked?

#

i tried with serverpostconnectevent and it doesn't work either

#

context: i'm trying to make a reliable global chat plugin with server switch messages. when a player gets kicked from a server back to the lobby, my plugin doesn't receive the lobby's connect event

#

i shall keep investigating but if someone has any ideas please @ me

#

to achieve a "server switch" i'm listening to connection events that have a previous server (!getPreviousServer.isEmpty()) so perhaps getting kicked means that the previous server isn't set?

fossil sundial Jan 10, 2022, 2:33 PM

#

neon roost context: i'm trying to make a reliable global chat plugin with server switch mes...

If the server they’re connecting to was the original server but that connection failed this will not be set

#

Otherwise I don’t think I’m following you

neon roost Jan 10, 2022, 2:40 PM

#

sorry, i think i don't quite understand it myself hence my poor explanation

#

i can try to explain it better, hold on

neon roost Jan 10, 2022, 2:56 PM

#

is it really ok to ask extensive stuff in this channel? i don't want to bother anyone or come off as annoying, but as a dev i like to write proper steps to reproduce stuff.

#

anyways,

#

after carefully looking at events while interacting with minecraft, i've collected this. i will use numbers to explain the player actions and letters to explain the related events, sorted by time. my plugin's messages will be between parenthesis.

#

working, expected behaviour:
1) player joins the velocity proxy
a) LoginEvent (chat plugin shows "player joined")
b) ServerPreConnectEvent
2) player joins "lobby"
c) ServerConnectedEvent (chat plugin doesn't show server switch, because event.getPreviousServer.isEmpty(): true)
d) ServerPostConnectEvent
e) CommandExecuteEvent: /server survival
f) ServerPreConnectEvent
3) player moves to the "survival" minecraft server
f) ServerConnectedEvent (chat plugin shows "player moved to survival" because getPreviousServer.isEmpty(): false)
g) ServerPostConnectEvent
[after this point, events are different from the next list]
h) CommandExecuteEvent: /server lobby
i) ServerPreConnectEvent
4) player joins "lobby" minecraft server
j) ServerConnectedEvent (chat plugin shows "player moved to lobby" because getPreviousServer.isEmpty(): false)
k) ServerPostConnectEvent
5) player leaves the velocity proxy
l) DisconnectEvent (chat plugin shows "player quit")

#

unexpected behaviour:
1) player joins the velocity proxy
a) LoginEvent (chat plugin shows "player joined")
b) ServerPreConnectEvent
2) player joins "lobby" minecraft server
c) ServerConnectedEvent
d) ServerPostConnectEvent
e) CommandExecuteEvent: /server survival
f) ServerPreConnectEvent
3) player moves to the "survival" minecraft server
f) ServerConnectedEvent (chat plugin shows "player moved to survival")
g) ServerPostConnectEvent
[up to this point, everything is similar to the previous list]
4) player gets kicked from "survival"
h) KickedFromServerEvent
i) ServerPreConnectEvent
5) player joins "lobby"
j) ServerConnectedEvent (chat plugin doesn't do anything, , because event.getPreviousServer.isEmpty(): true which is not expected)
k) ServerPostConnectEvent
6) player leaves the velocity proxy
l) DisconnectEvent (chat plugin shows "player quit")

#

as you can see, when a player manually moves between servers the events fire as one would expect, but when they get kicked the ServerConnectedEvent doesn't have the previous server's information

#

thus, as seen in step (j) in the second list, a plugin can't know where a player was kicked from

#

(please let me know if this is not ok so i can delete the massive wall of messages)

fossil sundial Jan 10, 2022, 3:00 PM

#

I understand your confusion, however, the previous server is only set on PostConnect because, including the ServerConnectedEvent, the connection can still be aborted

#

That makes little sense looking at it from the outside

neon roost Jan 10, 2022, 3:02 PM

#

indeed 😅

#

i will look at postconnect stuff then. thanks for guiding me (and sorry again for the huge message)

fossil sundial Jan 10, 2022, 3:03 PM

#

I appreciate the detail. As I said today already we are open for a set of Server disconnect events, which may help with this

craggy pecan Jan 10, 2022, 8:39 PM

#

neon roost i will look at postconnect stuff then. thanks for guiding me (and sorry again fo...

If anything, this can serve as a guide for other developers. Thanks 😊

#

A flowchart for connect/disconnect events could be a good idea

nova sparrow Jan 11, 2022, 11:47 AM

#

Any way to set a players inventory, specifically like give them items

fossil sundial Jan 11, 2022, 11:52 AM

#

nova sparrow Any way to set a players inventory, specifically like give them items

Not using built-in methods
That would require velocity to track player inventories among other things, which isn’t stuff a proxy should handle

#

❤️ cat

bold wharf Jan 11, 2022, 11:53 AM

#

if by give items you mean, actually giving items, no
if you mean like fake inventories, no, but, teeechnically there are plugins which let you mess with packets, but, really, let the server do it, use plugin messages to talk

nova sparrow Jan 11, 2022, 11:56 AM

#

bold wharf if by give items you mean, actually giving items, no if you mean like fake inven...

Plug-in messages? is that like an internal communication between velocity servers and registered ones?

bold wharf Jan 11, 2022, 11:58 AM

#

don't mention

#

but, basically, yes

#

takes advantage of the custom payload packets in vanilla to send data over a players connection

nova sparrow Jan 11, 2022, 12:03 PM

#

How would i send a packet to a registered server (and vice versa if possible)

#

Like, what would i call and provide, i get the concept but im not sure how to execute it

marble solar Jan 11, 2022, 3:29 PM

#

Hello, everyone! I`am making a velocity plugin for paid passes for servers but I need send a Russian symbols but i have an <Sorry, I don`t know how name that, check image>

craggy pecan Jan 11, 2022, 4:42 PM

#

nova sparrow Like, what would i call and provide, i get the concept but im not sure how to ex...

It's called the plugin messaging API, you can check Velocity's and your backend server's javadocs for more info

nova sparrow Jan 11, 2022, 4:43 PM

#

Thank you very much I'll make sure to check it out

marble solar Jan 11, 2022, 4:58 PM

#

marble solar Hello, everyone! I\`am making a velocity plugin for paid passes for servers but ...

Please, help me!

vagrant pike Jan 11, 2022, 5:02 PM

#

I have the following problem
Ah multi module project with a paper, velocity and common module. To be able to use adventure in commons i added the dependency as compileOnly I have other dependencies in commons as well which i added as implementation. So i used shadow to relocate them. Now i want to use a method in my velocity module. That is from a class in the common module. This method returns a adventure component. But velocity can't use it since it looks at the shaded location for the commons shaded location. Not the one that comes with velocity. So what do i need to change in the build.gradle.kts so i can use the adventure components in the commons module and that stuff in the velocity/paper module=

half locust Jan 11, 2022, 5:04 PM

#

add the java-library plugin to common, change compileOnly to compileOnlyApi & implementation to api in common for everything you want to expose to users of the common module

burnt dragon Jan 11, 2022, 5:05 PM

#

you dont need to shade adventure if you're working on paper+velocity

half locust Jan 11, 2022, 5:05 PM

#

oh missed that important part. Don't shade or relocate adventure

#

don't shade/relocate any compileOnly[Api] dep

vagrant pike Jan 11, 2022, 5:08 PM

#

I thought compileOnly does not get shaded by default thonk

half locust Jan 11, 2022, 5:14 PM

#

yeah it doesn't shade, but it'll relocate if it's told to

#

shouldn't shade at least

worldly granite Jan 11, 2022, 10:10 PM

#

is there a way to have the maven version of the module be the plugin version

#

I can't filter the .java file

half locust Jan 11, 2022, 10:11 PM

#

~~filter the plugin.yml, then <plugin instance>.getDescription().getVersion()~~ I'm a moron, this is the velocity channel

worldly granite Jan 11, 2022, 10:12 PM

#

velocity

half locust Jan 11, 2022, 10:12 PM

#

I'm a moron

neon roost Jan 12, 2022, 10:16 AM

#

marble solar Hello, everyone! I\`am making a velocity plugin for paid passes for servers but ...

minecraft supports unicode characters just fine (as you can see in the same image) so you're probably doing something wrong with encoding in your files. stick to utf8 generally

signal dagger Jan 13, 2022, 1:13 AM

#

Quick question:
As some might've experienced, with incorrect encoding, a § can result in Â. After not facing that problem since 2018 or so, I'm currently facing it again. A config value says &cSomething.
In the plugin, I feed it into LegacyComponentSerializer but replace the & with § before (&([0-9a-flmnokr])) so both work.
It is in bright red, but there's an extra Â.
how? O_o

worldly granite Jan 13, 2022, 1:31 AM

#

can i write a velocity-plugin.json manually

#

i see that the annotation is retained until runtime

#

does it check the type of the plugin?

bold wharf Jan 13, 2022, 1:41 AM

#

probs because your compiling with the wrong encoding

craggy pecan Jan 13, 2022, 2:05 AM

#

worldly granite can i write a velocity-plugin.json manually

You can, but it's not officially supported. Are you having some trouble with the annotation processor?

signal dagger Jan 13, 2022, 3:34 AM

#

bold wharf probs because your compiling with the wrong encoding

I don't see why gradle(7.2) would use something other than UTF-8. Especially on Linux.
But that's possible, the only § is in that class. I'll take a look later

sharp ginkgo Jan 13, 2022, 11:43 AM

#

hello

#

i have paper server and not working velocity...

burnt dragon Jan 13, 2022, 11:45 AM

#

#velocity-help, make sure you're connecting to the proxy and not to the server

sharp ginkgo Jan 13, 2022, 11:46 AM

#

ok

fast cedar Jan 13, 2022, 12:37 PM

#

velocity CommandExecuteEvent isnt being called at all

#

can someone help me?

#

when i execute simple commands the event isnt fired

#

#

fossil sundial Jan 13, 2022, 1:07 PM

#

fast cedar velocity CommandExecuteEvent isnt being called at all

depends on what the command was intended for? Server? Registered command on proxy?

fast cedar Jan 13, 2022, 1:07 PM

#

fossil sundial depends on what the command was intended for? Server? Registered command on prox...

proxy

#

the command is executed on hub

#

but the command event never gets fired no matter what

#

i'm almost firing it myself lol

craggy pecan Jan 13, 2022, 2:24 PM

#

Mm, will take a look at this. Mind opening an issue on GH with version details and a small reproducer?

fossil sundial Jan 13, 2022, 2:28 PM

#

craggy pecan Mm, will take a look at this. Mind opening an issue on GH with version details a...

I don’t see any way it could happen. Feel free to open an issue, don’t have the time atm

craggy pecan Jan 13, 2022, 2:28 PM

#

Yeah, me neither

#

Iirc there's even a test for this

signal dagger Jan 13, 2022, 2:37 PM

#

signal dagger I don't see why gradle(7.2) would use something other than UTF-8. Especially on ...

indeed (decompiler)

proper brook Jan 13, 2022, 7:46 PM

#

fast cedar

wow

#

what this theme?

#

i thought it was beautiful

#

@fast cedar

fast cedar Jan 13, 2022, 7:47 PM

#

proper brook what this theme?

dracula theme

proper brook Jan 13, 2022, 7:47 PM

#

plugin?

nova sparrow Jan 13, 2022, 8:58 PM

#

I love velocity!

agile ore Jan 13, 2022, 9:24 PM

#

We love you too!

signal dagger Jan 13, 2022, 10:36 PM

#

proper brook plugin?

Probably MaterialUI. Or Material UI lite.
That's what a lot of people use with IntelliJ

inner willow Jan 14, 2022, 7:47 PM

#

Is getting plugins in CurrentServer() possible

slate hamlet Jan 14, 2022, 7:51 PM

#

what

inner willow Jan 14, 2022, 7:51 PM

#

For example getting essentials api in a velocity plugin

#

Or, a way to get a players essentials DisplayName rather than using their Player Name

rich hawk Jan 14, 2022, 7:56 PM

#

No

vestal prawn Jan 14, 2022, 10:38 PM

#

No

cosmic citrus Jan 15, 2022, 3:11 AM

#

suppose I theoretically wanted to do some sketchy shit and inject into velocity's netty channel

#

playerConnection.getChannel().pipeline().addBefore(Connections.MINECRAFT_ENCODER, "MY_HANDLER", new MyCustomHandler());
``` would hypothetically do the trick, right?

#

basically I just have to hack the handshake packet's hostname field on the proxy->backend side. Maybe there's a better way.

#

Well... I can do some disgusting reflection to get at the hostname field of the vhost object's InetSocketAddressHolder. Really really disgusting but probably less disgusting than hijacking the netty pipeline

weak bay Jan 15, 2022, 3:36 AM

#

make sure to wash your hands

cosmic citrus Jan 15, 2022, 3:37 AM

#

I did, three times

#

There really needs to be an event like riiight here https://github.com/PaperMC/Velocity/blob/340e1b23d60f507f9b09ea4fe0e8a7689df5fca5/proxy/src/main/java/com/velocitypowered/proxy/connection/backend/VelocityServerConnection.java#L183

fossil sundial Jan 15, 2022, 4:27 AM

#

I don’t see any legitimate uses for that so no.

cosmic citrus Jan 15, 2022, 4:34 AM

#

I definitely have one but it's not a very wide usecase.

#

so I don't really mind

fossil sundial Jan 15, 2022, 5:00 AM

#

cosmic citrus I definitely have one but it's not a very wide usecase.

You do realize velocity supports login plugin messaging? If you just need to add data onto the login process then you could just use that
Well given you don’t use legacy versions that is of course

cosmic citrus Jan 15, 2022, 5:06 AM

#

Unfortunately it has to be done in the handshake packet because I also need to hijack it for status requests.

#

This also sorta happens as a MITM type of thing where this data I’m injecting is read (and stripped) before the server even has a chance to see it, so anything that happens after encryption is also off the table

#

It’s a really weird use case but really the only spot this is doable or even remotely simple is by messing with the hostname sent between velocity and the backend server in the handshake

inner surge Jan 15, 2022, 10:00 AM

#

What event would I use to get the player disconnection from a server,
if it doesnt exist, using DisconnectedEvent am I able to get the server wherer the player was or I'll have to cache that?

fossil sundial Jan 15, 2022, 11:34 AM

#

inner surge What event would I use to get the player disconnection from a server, if it does...

From a server its KickedFromServerEvent, that has a method to get the server the player was kicked/disconnected from

#

DisconnectEvent is for when the player disconnects from the proxy entirely

#

in that case you should first check for the login status and if correct check if current server is present, and you can get it from there

inner surge Jan 15, 2022, 11:36 AM

#

Just one thing, there's "ServerConnectedEvent"

#

It has .getPreviousServer

#

If a player is kicked from another server, is ServerConnectedEvent called?

fossil sundial Jan 15, 2022, 11:38 AM

#

No, KickedFromServerEvent is called, and that event decides wether to kick the player from the proxy or redirect them

inner surge Jan 15, 2022, 11:41 AM

#

If the player is kicked from the proxy the DisconnectEvent will be called?

#

What I meant by ServerConnectedEvent is, if a player is kicked from one server, like a prison server, and he goes to a lobby, ServerConnectedEvent will be called right? as the player connects to lobby

fossil sundial Jan 15, 2022, 12:32 PM

#

inner surge What I meant by ServerConnectedEvent is, if a player is kicked from one server, ...

in that regard yes.

fossil sundial Jan 15, 2022, 12:32 PM

#

inner surge If the player is kicked from the proxy the DisconnectEvent will be called?

yes.

inner surge Jan 15, 2022, 12:34 PM

#

Thank you so much!

oblique haven Jan 15, 2022, 2:46 PM

#

cosmic citrus It’s a really weird use case but really the only spot this is doable or even rem...

The better question is - what are you trying to do exactly

#

There’s probably a better way

ashen fiber Jan 15, 2022, 7:57 PM

#

Is there a convenient list of libraries Velocity includes, that way I don't need to include them in the Jar?

rich hawk Jan 15, 2022, 8:05 PM

#

https://github.com/PaperMC/Velocity/blob/dev/3.0.0/proxy/build.gradle

GitHub

Velocity/build.gradle at dev/3.0.0 · PaperMC/Velocity

The modern, next-generation Minecraft server proxy. - Velocity/build.gradle at dev/3.0.0 · PaperMC/Velocity

#

https://github.com/PaperMC/Velocity/blob/dev/3.0.0/api/build.gradle

GitHub

Velocity/build.gradle at dev/3.0.0 · PaperMC/Velocity

The modern, next-generation Minecraft server proxy. - Velocity/build.gradle at dev/3.0.0 · PaperMC/Velocity

small raven Jan 15, 2022, 9:17 PM

#

What event should I use for when a player joins the proxy, but with a listener that could take a bit to execute? (querying mongo) Just asking cause I saw in the javadocs for some of the *login events that I should "try to limit the work done in any event that fires during the login process"

fossil sundial Jan 15, 2022, 9:19 PM

#

small raven What event should I use for when a player joins the proxy, but with a listener t...

If you need the data present to make a decision during login you need to block any of those events
Just if you do it too long the client will time out is what the comment about limiting work means

small raven Jan 15, 2022, 9:22 PM

#

Ah, gotcha. I wouldn't need to block the login process at all, merely just updating some values in the players document on join. So I assume PlayerChooseInitialServerEvent would do just fine?

fossil sundial Jan 15, 2022, 9:23 PM

#

Events that leave the player dangling (not fully initialized or in transition) shouldn’t be blocked for more than 2 sec at max

#

You can fire off your own query thread or future from any of those events however

#

That won’t block the event and eventually you’ll have the data

small raven Jan 15, 2022, 9:30 PM

#

Just creating a thread in the event wouldn't block it? I've never used futures, but am vaguely familiar with threads.

ashen fiber Jan 15, 2022, 10:36 PM

#

rich hawk https://github.com/PaperMC/Velocity/blob/dev/3.0.0/proxy/build.gradle

I said convenient

thick briar Jan 16, 2022, 12:15 AM

#

Is there a way to intercept a specific packet and potentially stop it from being sent to the player?

I want to do seemless world transitions by handling them myself. This includes intercepting the respawn packet

fossil sundial Jan 16, 2022, 12:34 AM

#

thick briar Is there a way to intercept a specific packet and potentially stop it from being...

You’re better off doing that with bungeecord. Bungeecord is designed with intercepting things in mind while velocity is not
You’re basically trying to break all proxy logic here on velocity
It’s seriously easier to do on bungeecord

#

Plus you don’t need to reinvent entity ID rewriting

#

And all packets you probably need are there already

thick briar Jan 16, 2022, 12:48 AM

#

Ooof, that sucks because all of our existing codebase is on velocity, is there maybe a velo lib that could help with this?

#

Moving to bungeecord just isnt ideal due to time constraints is all

weak bay Jan 16, 2022, 12:50 AM

#

~~use a bungeecord proxy behind a velocity proxy~~

fossil sundial Jan 16, 2022, 12:51 AM

#

Velocity is designed around being a clean proxy

#

The issue is deeper if you want seamless switches:

#

You need to do the following:
Full tab-list rewriting
Full entity ID rewriting for all entities
Full dimension sync or rewriting
Full tracking of player state and effects
Full tracking of all active attributes
Full tracking and rewriting of all inventory IDs and windows

#

Only then will you have a usable seamless integration

#

And this puts a tremendous amount of extra load on the proxy

#

Velocity is fundamentally made to not have any of this

thick briar Jan 16, 2022, 12:54 AM

#

Why would those need a rewrite? Don't you just not send the respawn packet and handle chunk unloading/loading yourself?

bold wharf Jan 16, 2022, 12:54 AM

#

No

#

because the players entity ID wil change across servers

#

and, so, any entities which refer to your player will have a different ID to what the client has without resending the ID or rewriting the metadata, etc

fossil sundial Jan 16, 2022, 12:54 AM

#

No; The new server will use IDs that overlap
And well that causes graphical glitches at the least

bold wharf Jan 16, 2022, 12:55 AM

#

velocity works on the fact that you can reset the clients state in-play

#

bungee/waterfall (by default) works on rewriting a lot of crud to ensure that stuff works

#

noting that that mechanism has caused many janky issues over the years

#

(and creates much more work for the proxy as Five already stated)

thick briar Jan 16, 2022, 12:55 AM

#

I should mention that I am using Minestom and not a spigot fork btw

bold wharf Jan 16, 2022, 12:56 AM

#

doesn't change much

fossil sundial Jan 16, 2022, 12:56 AM

#

That doesn’t change how the game works fundamentally

bold wharf Jan 16, 2022, 12:56 AM

#

the client is still a stateful thing

#

if you get into entities, etc, you start needing to deal with the caveats of not resetting the clients state

fossil sundial Jan 16, 2022, 12:56 AM

#

You’ll also need to rewrite map IDs I just remembered

bold wharf Jan 16, 2022, 12:56 AM

#

as for how far you need to go for your specific usecase to pretend it all works, etc

thick briar Jan 16, 2022, 12:57 AM

#

Wouldnt you just despawn the entities that are in the old dimension?

Map IDs aren't an issue for my usecase, only one of my servers will ever use maps

fossil sundial Jan 16, 2022, 12:57 AM

#

That’s not enough

thick briar Jan 16, 2022, 12:57 AM

#

bold wharf if you get into entities, etc, you start needing to deal with the caveats of not...

What other caveats are there?

bold wharf Jan 16, 2022, 12:58 AM

#

Read all that five said

#

a good % of bungees codebase is literally dealing with all the crud to keep the client happy across server transfers

#

once again, entities refer to other entities for various things using IDs

thick briar Jan 16, 2022, 12:58 AM

#

I am just struggling to understand where the issues lie, is despawning an entity not enough?

bold wharf Jan 16, 2022, 12:58 AM

#

when you transfer across servers, your player ID will change on the server given the new entities, etc, etc

#

No

#

because it's not the entities themselves which are the issue

fossil sundial Jan 16, 2022, 12:59 AM

#

you just get lots of lighting glitches, ghost blocks and entities, buggy tab-list and scoreboard, blocks refuse to break, other entities get desynced
Potion effects stay in limbo
You can’t see nether portals
Fire doesn’t render
… and lots of other fun things

bold wharf Jan 16, 2022, 12:59 AM

#

it's how they o things like referring to other entities

#

The entire game works off using the entity ID which is a runtime number which is incremented on new entity

fossil sundial Jan 16, 2022, 12:59 AM

#

We didn’t make those rules
That’s just how the client works

bold wharf Jan 16, 2022, 12:59 AM

#

that entity ID is solely how the game refers to your entity over the network

fossil sundial Jan 16, 2022, 1:00 AM

#

And it varies wildly with versions

thick briar Jan 16, 2022, 1:00 AM

#

fossil sundial We didn’t make those rules That’s just how the client works

Yea I understand, I appreciate your guys' help with this

bold wharf Jan 16, 2022, 1:00 AM

#

bungeecord, by not doing the set, needs to rewrite every single entity metadata packet to ensure that it rewrites any entity IDs which refer to your player to the entity ID that you where given by the first server

#

(as well as tryna avoid cases where your clients entity ID is the same as some other entity on the server, etc)

thick briar Jan 16, 2022, 1:00 AM

#

bold wharf bungeecord, by not doing the set, needs to rewrite every single entity metadata ...

Aren't those just sent when you go to a new server anyhow?

bold wharf Jan 16, 2022, 1:00 AM

#

don't mention

#

No

fossil sundial Jan 16, 2022, 1:01 AM

#

There is a plugin out there if I remember the name right it was something like Full-sync that does the rewriting and mapping on the server
But it was for spigot exclusively iirc
That would probably be a good place to start

bold wharf Jan 16, 2022, 1:01 AM

#

You literally have to disable the mechanism which lets you do that for the "smooth" transitions

#

which is what we're saying here

#

velocity relies on the fact that you can resend the entity ID to the client by resetting its state more or less

thick briar Jan 16, 2022, 1:01 AM

#

That's confusing, you're saying that velocity intercepts and stops entity meta being sent to the client when it joins a new server?

bold wharf Jan 16, 2022, 1:01 AM

#

bungee refuses to use that mechanism and so they rewrite a lot of crud to fake it

#

No

fossil sundial Jan 16, 2022, 1:02 AM

#

Velocity uses a trick to reset the client to after it has just logged in

#

That trick works ever since 1.7.2

bold wharf Jan 16, 2022, 1:02 AM

#

when you join a server, you get a login packet which tells you your entity ID, etc

#

with velocity, or waterfall with entity metadata rewriting disabled, when you switch server, it sends you a new login packet

fossil sundial Jan 16, 2022, 1:02 AM

#

^ that resets the client to zero

#

But it also triggers a dimension switch screen

bold wharf Jan 16, 2022, 1:03 AM

#

that login packet gives you your new entity ID, and by virtue of the clients code causes a lot of state info it has stored to be dropped

#

bungeecord, on the other hand, doesn't do that

fossil sundial Jan 16, 2022, 1:03 AM

#

Or rather it doesn’t do it right

#

pepela

thick briar Jan 16, 2022, 1:03 AM

#

Does a login packet trigger the loading screen?

bold wharf Jan 16, 2022, 1:03 AM

#

yes

thick briar Jan 16, 2022, 1:03 AM

#

Hmm okay

#

I see the issue now

bold wharf Jan 16, 2022, 1:04 AM

#

in orer to get rid of the login screen, you'd need to get rid of the login packet

#

getting rid of the login packet would prevent the client going into a state which is aligned with the server itself

fossil sundial Jan 16, 2022, 1:04 AM

#

On older versions velocity will not only send a join game packet but also one or two Respawn packets so the dimension is correct

#

Newer versions of the game have a lot more important things in the join game packet

bold wharf Jan 16, 2022, 1:05 AM

#

which, bungee doesn't do the login packet, so bungee has a whole mess of code dedicated to rewriting the metadata of entities and trying to butcher other state to line up

fossil sundial Jan 16, 2022, 1:05 AM

#

I know three incorrect rewrites bungeecord does but I don’t care anymore because md_5 refuses to believe any of them

#

If arrows or tridents ever glitch out on bungeecord that’s the reason

#

pepela

bold wharf Jan 16, 2022, 1:06 AM

#

(if it wasn't for the fact I can't be arsed, disabling metadata rewriting woulda been the default in waterfall for what, 2, 3 years now?

thick briar Jan 16, 2022, 1:07 AM

#

Does velocity forward the first game join packet exactly as it is sent by the first server the player joins?

#

Because I can ensure that the packets I use are the exact same with the same entity ID if so

fossil sundial Jan 16, 2022, 1:07 AM

#

It sends a customized one based on the server response

thick briar Jan 16, 2022, 1:08 AM

#

alrighty

fossil sundial Jan 16, 2022, 1:08 AM

#

If we re-sent the original it’d defeat the purpose of having the data from the new server

#

That can be especially important on 1.17+

#

Reason: minecraft 1.17 and newer doesn’t use world IDs but names to refer to dimensions

#

So if you don’t have a dimension the server wants to send you to…..

#

Bungeecord errors on this currently

#

But again md_5 doesn’t seem to care a whole lot

thick briar Jan 16, 2022, 1:09 AM

#

All my servers have the exact same dimension and the exact same namespace for it

bold wharf Jan 16, 2022, 1:10 AM

#

I feel that we've kinda come around full circle into you not understanding the implications of it all

fossil sundial Jan 16, 2022, 1:10 AM

#

Again you can probably make this work for your use with some difficulty

#

If you need packet interception on velocity you can see how viaversion injects by replacing the channel initializer

#

But all I can say is that it’s gonna be a royal pain to do

#

And please don’t follow the bungee examples

thick briar Jan 16, 2022, 1:11 AM

#

Well what I understand is that the entity ID for the player can change between servers, which means that the client needs to reset to that new ID somehow

bold wharf Jan 16, 2022, 1:11 AM

#

which you can't do without sending the login packet which resets the clients state which shows the loading screen.

thick briar Jan 16, 2022, 1:12 AM

#

because it can cause a ton of different issues

thick briar Jan 16, 2022, 1:12 AM

#

bold wharf which you can't do without sending the login packet which resets the clients sta...

yea

fossil sundial Jan 16, 2022, 1:12 AM

#

You can’t reset entity IDs if you don’t re-send join game

bold wharf Jan 16, 2022, 1:12 AM

#

there is literally 0 way to change the clients entity ID outside of that

#

which

#

leads you back towards bungees BS

#

which, isn't just rewriting an entity ID

#

It's rewriting literally every entity ID sent over the network

thick briar Jan 16, 2022, 1:12 AM

#

Or alternatively, I can sync my entity ids across the whole network

#

So that every player gets their own id

#

But anyhow I'll just have to compromise somehow, thanks for all the advice

#

It helps a ton

fossil sundial Jan 16, 2022, 1:13 AM

#

That’s what that plugin I talked about did
Well that and you have to ensure to never re-use old IDs which have been used on previous servers for entities != the player

#

Also to note

fossil sundial Jan 16, 2022, 1:18 AM

#

thick briar But anyhow I'll just have to compromise somehow, thanks for all the advice

You’ll be responsible for:
Setting player:
inventory, position, facing, potion effects, velocity, abilities, gamemode, boss-bar, tab list, scoreboard and objectives, stop sound, despawning entities if within range (… and so on)

Also absolutely not working without a loading screen:
brigadier commands resync (tab-complete command list)
Map-tracking
Hardcore hearts (enable or disable)
Ability to select-click blocks using creative menu (certain newer versions work)
Ability to use hotbar to teleport to other players in spectator mode (without server modifications)

#

Also careful: if you re-assign the same ID upon a real Respawn you will likely crash the client

thick briar Jan 16, 2022, 1:23 AM

#

Thanks for the tips

fossil sundial Jan 16, 2022, 1:24 AM

#

Oh also: don’t forget to set the correct daytime

#

And if this matters: adventure mode will break entirely
If you need it you’ll have to hack in a feedback rewriter on the server

#

That may be different in newer versions but last I dealt with this I’ve nearly lost my mind

thick briar Jan 16, 2022, 1:29 AM

#

Wait why can't you resync the brigadier commands?

#

Also I think the solution for me will be to just use one server, I can separate logic between worlds

small raven Jan 16, 2022, 3:45 AM

#

@Subscribe
public void playerChooseInitialServer(PlayerChooseInitialServerEvent event) {
    CompletableFuture<Void> future = CompletableFuture.runAsync(() -> {
        try {
            // Do long logic here
        } catch (Exception exception) {
            this.logger.error(exception.getMessage());
        }
    });
}

Is that the proper way to use a future? It works exactly as I'd expect and doesn't block the event, but am just curious if there's a better way I should be doing it

light kettle Jan 16, 2022, 9:27 AM

#

hi there is a way to change server brand? velocity --> custom

fossil sundial Jan 16, 2022, 10:02 AM

#

light kettle hi there is a way to change server brand? velocity --> custom

There is no supported way to do this. You’ll have to modify the source code of the proxy to do it, or make a plugin that hacks that part of the proxy logic. We don’t support it because it’s one of the few places where credit is shown to the software authors and contributors

light kettle Jan 16, 2022, 10:07 AM

#

I don't want to delete the Velocity writing but to modify it and unify it to the network style while keeping the software credits

#

I would like to ask if possible I have where to go to modify this writing to do what I have described above

vestal prawn Jan 16, 2022, 11:27 AM

#

Just git clone the repo, and search the string in the code maybe

#

but the word Velocity is kind of cool so i keep it

vagrant pike Jan 16, 2022, 11:49 AM

#

I think he just wants to add color

light kettle Jan 16, 2022, 1:58 PM

#

yes

#

i don’t find the string

agile ore Jan 16, 2022, 2:07 PM

#

light kettle i don’t find the string

Five explained how you do it

grizzled rapids Jan 16, 2022, 4:30 PM

#

for (RegisteredServer server : myplugin.getProxy().getAllServers()) {
            ByteArrayDataOutput out = ByteStreams.newDataOutput();
            out.writeUTF(arguments[0]);
            out.writeUTF(arguments[1]);
            server.sendPluginMessage(myplugin.getChannel("mychannel"), out.toByteArray());
        }

This for loop should execute "lp user ..." in every Bukkit server however the rank is given successfully only in proxy and in server where I am

bold wharf Jan 16, 2022, 4:31 PM

#

can't send a message to a server without players in it

grizzled rapids Jan 16, 2022, 4:31 PM

#

Any solution to that or nope?

bold wharf Jan 16, 2022, 4:32 PM

#

basically, you'd need to cache it and wait till somebody logs in

burnt dragon Jan 16, 2022, 4:32 PM

#

why wouldn't you just use luckperms with one backend db

bold wharf Jan 16, 2022, 4:32 PM

#

ideally you just cross link everything properly and access the LP api directly

burnt dragon Jan 16, 2022, 4:32 PM

#

it has fine cross-server/proxy support

valid gazelle Jan 17, 2022, 1:14 AM

#

hi, i'm trying to make a whitelist plugin for velocity, but i dont really understand how to use brigadiercommand. i want to make a main command /vwhitelist which has a second argument which is a subcommand, but i don't know if i'm going in the right direction

this is what i have so far: https://share.boba.best/hdns05yy.java

bobashare

hdns05yy.java (1.5 kB)

valid gazelle Jan 17, 2022, 9:58 AM

#

nvm i figured it out

onyx badger Jan 17, 2022, 12:13 PM

#

will any api be provided in the future to work with packets and, for example, add own "sessions" at the entrance?

bold wharf Jan 17, 2022, 12:14 PM

#

given that packets aren't API, and there are many dozen nuances there, probably not

fossil sundial Jan 17, 2022, 12:25 PM

#

onyx badger will any api be provided in the future to work with packets and, for example, ad...

Please specify what you’re tying to do?

onyx badger Jan 17, 2022, 12:29 PM

#

On one server, I saw authorization implemented using packets on BungeeCord. I was interested in repeating this on Velocity. Like BungeeCord, Velocity needs a protocol hack. Perhaps you could provide some more advanced API for this things. At the moment it does not carry any overly important purpose, just for interest.

bold wharf Jan 17, 2022, 12:30 PM

#

no idea what you mean

#

you can already replace the url that the proxy uses for authentication

fossil sundial Jan 17, 2022, 12:31 PM

#

onyx badger On one server, I saw authorization implemented using packets on BungeeCord. I wa...

Yea we still don’t have a clue what you want to do

fossil sundial Jan 17, 2022, 12:31 PM

#

bold wharf you can already replace the url that the proxy uses for authentication

For that see the launch flags pinned to this channel

onyx badger Jan 17, 2022, 12:37 PM

#

I'm not talking about Mojang authorization. With the help of packets, I ask the client to load world. After which, the client thinks that it appeared on a normal server, but it is not. Here I can carry out, for example, my authorization without using an additional bukkit server.

bold wharf Jan 17, 2022, 12:39 PM

#

oh, limbo server, basically

#

yea, there is probs 0 interest on the side of velocity to implement all of the stuff needed for that type of thing

fossil sundial Jan 17, 2022, 12:39 PM

#

onyx badger I'm not talking about Mojang authorization. With the help of packets, I ask the ...

Ah. You’re talking about a full server simulation for an “auth” plugin for users that pirated the game. No, that won’t ever be supported. We don’t support piracy.

bold wharf Jan 17, 2022, 12:40 PM

#

idea is to be lightweight and maintainable, not add a bunch of crud like adding support for writing world data and basically simulating a world

fossil sundial Jan 17, 2022, 12:40 PM

#

A proxy shouldn’t ever do any of this regardless

onyx badger Jan 17, 2022, 12:41 PM

#

fossil sundial Ah. You’re talking about a full server simulation for an “auth” plugin for users...

Let's look at it from the other side. I want to provide my players (ofc online players) with additional protection, or, for example, upload my resource pack.

bold wharf Jan 17, 2022, 12:42 PM

#

lets look at it from the other side

#

in order to do that

onyx badger Jan 17, 2022, 12:42 PM

#

Authorization as an example. I don't say anything about supporting offline players.

bold wharf Jan 17, 2022, 12:42 PM

#

velocity would have to maintain support for writing stuff like level data, etc, chunks, and potentially all that other crud

#

from every version, 1.7+

#

Just, no

#

it's a proxy, it proxies, use a limbo server or something lightweight

fossil sundial Jan 17, 2022, 12:43 PM

#

Regardless of why you’d want to do that, it’s possible to hack in with a plugin. With that in mind, a lightweight limbo server is still always a better option

lilac elbow Jan 17, 2022, 3:22 PM

#

https://velocitypowered.com/wiki/developers/command-api/

The Command API

The Command API lets you create commands that can be executed by a player connected to the proxy or the console. Creating a command Each…

#

There is no class called SimpleCommand or RawCommand

bold wharf Jan 17, 2022, 3:23 PM

#

I mean, it's in the API

#

you are depending on the latest API?

lilac elbow Jan 17, 2022, 3:23 PM

#

Oh wait

#

Im unsure because someone said that the doc i was using was outdated

#

1.0.0-SNAPSHOT Does not seem like the latest

bold wharf Jan 17, 2022, 3:24 PM

#

that would be an old api version, yes

fading pond Jan 17, 2022, 3:31 PM

#

~~Hey, I'm registering commands on Velocity using proxyServer.getCommandManager().register() and they work when I execute the command on the Proxy's console but not for players on each server, I believe I saw somewhere that you need to forward commands to each server so I was wondering how to do that?

Thank you.~~

Issue was due to not having the correct permissions, use LuckPerms-Velocity to set permissions to the command for yourself.

lilac elbow Jan 17, 2022, 3:44 PM

#

#

Same issue as above, this is my code

oblique haven Jan 17, 2022, 3:56 PM

#

fading pond ~~Hey, I'm registering commands on Velocity using `proxyServer.getCommandManager...

you need to make sure they have permission

#

if it's just for debug just return true in that hasPermission check

#

if not use a legit permission provider and use permissions based on those

#

LuckPerms has a velocity version

fading pond Jan 17, 2022, 4:02 PM

#

oblique haven you need to make sure they have permission

I was "fixing" a plugin I made for a client about 3-4 months ago, they just didn't have the correct permissions set 🤦

#

But yeah you're completely right, LuckPerms and such works just fine. I was just asking about forwarding because I looked up the issue in the discord and saw a staff member mentioning something about forwarding so I was wondering if Velocity made some weird change that I had to implement, thank you so much though.

oblique haven Jan 17, 2022, 4:04 PM

#

fading pond I was "fixing" a plugin I made for a client about 3-4 months ago, they just didn...

😉 glad I could help

oblique haven Jan 17, 2022, 4:04 PM

#

fading pond But yeah you're completely right, LuckPerms and such works just fine. I was just...

commands from the proxy never forward to the backend server

#

it just intercepts the declare and inserts its own stuff

fading pond Jan 17, 2022, 4:04 PM

#

oblique haven 😉 glad I could help

bro they had luckperms installed already, just didn't set perms for themselves 😭

oblique haven Jan 17, 2022, 4:04 PM

#

FacePalm

fading pond Jan 17, 2022, 4:05 PM

#

oblique haven commands from the proxy __never__ forward to the backend server

I don't think I've ever forwarded a proxy command to a backend server, wouldn't even know where to start on that lol

lilac elbow Jan 17, 2022, 4:13 PM

#

@oblique havenDo you need the HasPermission function?

oblique haven Jan 17, 2022, 4:16 PM

#

lilac elbow <@!174661611024285697>Do you need the HasPermission function?

I don’t think it’s required

craggy pecan Jan 17, 2022, 5:44 PM

#

oblique haven commands from the proxy __never__ forward to the backend server

Sorry for being nitpicky (heh), BrigadierCommands can forward conditionally if you return https://jd.velocitypowered.com/3.0.0/com/velocitypowered/api/command/BrigadierCommand.html#FORWARD from their executor

#

Apart from that you're right

agile ore Jan 17, 2022, 6:18 PM

#

Huh weird I get this error:

[13:15:41 ERROR]: Unable to load plugin plugins\DSVelocity.jar
com.velocitypowered.api.plugin.InvalidPluginException: Did not find a valid velocity-plugin.json.```
Using maven for this project.

lilac elbow Jan 17, 2022, 6:58 PM

#

How do I connect a player to another server

#

From a command

#

How do you get a player instance from a SimpleCommand

rich hawk Jan 17, 2022, 7:11 PM

#

instanceof & Cast

lilac elbow Jan 17, 2022, 7:16 PM

#

How do you get Optional<Player> to Player?

reef jacinth Jan 17, 2022, 7:20 PM

#

If you know the optional is not empty, get.

grizzled rapids Jan 17, 2022, 7:33 PM

#

~~How do I make that suggest function in SimpleCommand returns: first argument(all players), second argument(all servers)~~
Edit: solved, it's described here https://docs.velocitypowered.com/en/latest/developers/command-api.html#creating-a-simple-tab-complete

lilac elbow Jan 17, 2022, 8:41 PM

#

reef jacinth If you know the optional is not empty, `get`.

I need to check if it is a player from their args, should I do Optional<Player> == null or Optional<Player>().get() == null