#waterfall-dev | PaperMC | Page 14

queen cave Dec 29, 2020, 12:44 AM

#

plugin.getServer().getScheduler().runTask(plugin, () -> {
    ByteArrayDataOutput out = ByteStreams.newDataOutput();
    out.writeUTF("ConnectOther");
    out.writeUTF(playerName);
    out.writeUTF(serverName);
    plugin.getServer().sendPluginMessage(plugin, BungeeWideWarps.BUNGEECORD, out.toByteArray());
});

(it probably doesnt even have to be in a task)

trail plume Dec 29, 2020, 12:45 AM

#

is what it says, basically

queen cave Dec 29, 2020, 12:45 AM

#

yeah but how can it already be connecting if its just triggered once thonkeng

trail plume Dec 29, 2020, 12:46 AM

#

The only case that that would trigger is if you where already in the process of tryna join that server and something else said "go here"

queen cave Dec 29, 2020, 12:46 AM

#

well i warp the player to another location, but with a tick delay

#

seems unrelated tho

trail plume Dec 29, 2020, 12:47 AM

#

📎 unknown.png

#

That's on the UserConnection#connect logic

queen cave Dec 29, 2020, 12:50 AM

#

📎 ZqrbSANeep.mp4

#

(second warp was to same server so you can ignore that one)

#

it also only seems to happen if theres another player online

trail plume Dec 29, 2020, 12:51 AM

#

I got no idea, all I know is whatn that's fired

#

that would purely suggest that something is either stuffing in a dupe request or something is breaking it elsewhere

#

You'd probs wanna add some logging into waterfall to see where that's coming from maybe

queen cave Dec 29, 2020, 12:53 AM

#

i'd test with more users see if it triggers that message with 3 players, but i only have one alt lul

#

not gonna bother logging in waterfall tbh

midnight wave Dec 30, 2020, 12:11 AM

#

will server.scheduler.scheduleSyncRepeatingTask run every tick or only if it can?

#

i want to do player.setExhaustion(player.getExhaustion() + BASE_EXHAUSTION );

trail plume Dec 30, 2020, 12:17 AM

#

wrong channel, and it runs as often as you tell it to run

midnight wave Dec 30, 2020, 12:17 AM

#

ah i see waterfall myb

#

thanks

wintry axle Dec 30, 2020, 8:22 AM

#

sorry if what I'm asking is dumb, but where do I get the Waterfall-Super dev-SNAPSHOT API?

trail plume Dec 30, 2020, 2:23 PM

#

You don't, only the api is actually deployed, nor I'd super even something that produces a compile output

bleak current Dec 30, 2020, 5:43 PM

#

Is making the branding a option in the waterfall.yml a thing that would get accepted in a PR?

signal mica Dec 30, 2020, 6:08 PM

#

Talking about repositories and jars: Is there a way to get Waterfall-Proxy in maven.
This library contains the "InitialHandler" class which I would like to use. My current approach of just adding the whole waterfall jar as a dependency is kinda meh.

bleak current Dec 30, 2020, 6:19 PM

#

signal mica Talking about repositories and jars: Is there a way to get Waterfall-Proxy in ma...

Use mvn install and add that as a dependency in your other project

#

But it will only work locally then

signal mica Dec 30, 2020, 6:19 PM

#

Good idea, I might do this 🙂

potent lichen Dec 30, 2020, 6:19 PM

#

what's the reason you need to rely on the implementation? I'm curious

signal mica Dec 30, 2020, 6:21 PM

#

Yes, in the LoginEvent I want to get the username, for which I need to cast the events connection to an InitialHandler, which is only present in Waterfall-Proxy

potent lichen Dec 30, 2020, 6:22 PM

#

LoginEvent has the player username, doesn't it?

#

it does

bleak current Dec 30, 2020, 6:23 PM

#

I remember getting the playername was kinda weird

#

But i think it was bukkit

trail plume Dec 30, 2020, 6:40 PM

#

Changing the branding in a plugin is pretty trivial, but, no, there is no interest in a pr to add that to the config, I dont get paid for this, so the only kickback we get is to our software itself

bleak current Dec 30, 2020, 6:43 PM

#

Ok

bleak current Dec 31, 2020, 9:51 AM

#

What do these do?

#

What is the dofference between setting a PendingConnection to online mode and what effecrs does setting the UUID have?

wide maple Dec 31, 2020, 9:53 AM

#

If you set it to onlineMode it will force the player to authenticate with Mojang (using a challenge-response packet exchange)

bleak current Dec 31, 2020, 9:53 AM

#

Oh

bleak current Dec 31, 2020, 9:53 AM

#

wide maple If you set it to onlineMode it will force the player to authenticate with Mojang...

Hm does bukkit offer something similar?

wide maple Dec 31, 2020, 9:53 AM

#

Not to my knowledge

bleak current Dec 31, 2020, 9:54 AM

#

Hm ok thanks

zinc trail Jan 1, 2021, 9:14 AM

#

@bleak current is jartex waterfall?

bleak current Jan 1, 2021, 2:44 PM

#

For now it still is yes, but we will swap this year to something else, why?

wide maple Jan 1, 2021, 2:49 PM

#

Shameless plug for Velocity

#

velocity

bleak current Jan 5, 2021, 6:26 AM

#

Hey

#

Does TextComponent automatically parse messages with color?

#

So can I pass in "&aHello" as a string and it will be formatted for me

potent lichen Jan 5, 2021, 1:20 PM

#

Use TextComponent#fromLegacyText

runic prairie Jan 7, 2021, 10:06 AM

#

okay...

#

time to remove 10s startup delay by myself

trail plume Jan 7, 2021, 10:13 AM

#

Use the downloads API

#

We've literally been warning we're getting rid of the jenkins for almost 2 years now.

brazen anvil Jan 7, 2021, 11:24 AM

#

Hello,
I currently make an network with synced data between servers but currently i have an issue with sync.

For retrieve data i pull it from mongo at login and save the change when player logout.
But when i switch the server the data is not saved because the data is pulled before save it from initial server (i use Bukkit.getScheduler().runTaskAsynchronously for no lock logout process).

So my question is : how i can correctly save the modified data with less possible impact on performance ?

Thanks.

trail plume Jan 7, 2021, 11:25 AM

#

There is no "clean" solution for this, not without implementing proper locking or basically taking control over the server switch process in a more useful/controlling way

#

people often just offset the data load by a few seconds or something

hollow notch Jan 8, 2021, 9:45 PM

#

Hey im quite good at java and i want to fork waterfall but i have now idea where to start cause everything is in shell language???

#

How do i edit the java code

lean gobletBOT Jan 8, 2021, 9:45 PM

#

nice

hollow notch Jan 8, 2021, 9:45 PM

#

And do i fork it or upstream it?

lean gobletBOT Jan 8, 2021, 9:45 PM

#

nice x2

#

so

#

there's this nice file in English, it's called contributing

#

usually helps out a lot

hollow notch Jan 8, 2021, 9:46 PM

#

Ow thx

lean gobletBOT Jan 8, 2021, 9:46 PM

#

lol

hollow notch Jan 8, 2021, 9:46 PM

#

Englis is native and googleing creates somtimes a problem for me

lean gobletBOT Jan 8, 2021, 9:47 PM

#

it's more or less a standard, I do wonder if the readme says anything about compiling as well

trail plume Jan 8, 2021, 9:47 PM

#

fork travertine if you're intending to maintain your own fork, otherwise, generally consult the paper contrib guides, etc

hollow notch Jan 8, 2021, 9:48 PM

#

Ow thx

#

Travertine is like waterfall but 1.7 support right?

trail plume Jan 8, 2021, 9:49 PM

#

Yes, but, it's setup as a waterfall fork

hollow notch Jan 8, 2021, 9:49 PM

#

Ah

#

Thx you guys so much

#

So fork Travartine and follow contribute.md

#

But whats w the python

snow bolt Jan 10, 2021, 1:32 PM

#

lads how in the fuck do i use "wiggle" for waterfall patches

#

ooo i can just copy the apatch.sh from paper pepe_super_cool

trail plume Jan 10, 2021, 1:33 PM

#

I just keep a copy of it in my PATH :L

snow bolt Jan 10, 2021, 1:33 PM

#

ngl still don't have any clue what to do with wiggle

#

i got a diff but what next

trail plume Jan 10, 2021, 1:35 PM

#

apatch takes a path to the patch

#

or, you run apatch in the folder when it's merging and conflicts

snow bolt Jan 10, 2021, 1:35 PM

#

yeah but doing so just gives me a vi diff screen

#

oh no wait i see

#

aaaaaaaaaaaa i'm thinking i'm starting to get it

snow bolt Jan 10, 2021, 2:07 PM

#

that made rebasing 60 patches extremely easy

#

wiggle is dope

bleak current Jan 10, 2021, 10:05 PM

#

So I want to be able to send players from one waterfull server, to another
Ex. player joins X proxy, then is sent to Y proxy. X proxy restarts but player is not kicked because they're now connected to Y

I'm trying to making a no-downtime server if that makes sense

Does anyone know how to go about this, or a similar open source project?

lean gobletBOT Jan 10, 2021, 10:13 PM

#

buzzer sound

#

you have made a fatal mistake

#

"then is sent to Y proxy"

#

so now, connection looks like this: client > X > Y > Server

#

that's what we really need, sound effects in chat, not dumojis

bleak current Jan 10, 2021, 10:14 PM

#

who the heck are you

lean gobletBOT Jan 10, 2021, 10:14 PM

#

I'm the very best, like no one ever was

trail plume Jan 10, 2021, 10:47 PM

#

No, you can't transfer people between proxies as there is

too much state to deal with to magically do that
You'd need to magically reconnect the client elsewhere, which the client doesn't support

#

Basically, you wanna look at rolling deployments

bleak current Jan 10, 2021, 10:54 PM

#

thanks reversed_fingerguns

lean gobletBOT Jan 11, 2021, 1:26 AM

#

rolloing deploys won't accomplish no downtime (it can mitigate sure if you distribute players across proxies)

#

o, an extra o

trail plume Jan 11, 2021, 1:27 AM

#

Well, "rolling", idea is that you pull out a server from the RR when it's pending an update, people only connect to updated instance, etc

#

would require some orchestration, no idea what tools there really are to deal with all that cleanly for mc

lean gobletBOT Jan 11, 2021, 1:28 AM

#

hm, I guess some delayed form of blue/green would work I see now

wise pelican Jan 11, 2021, 12:40 PM

#

Did Waterfall has API for low level connection control? I would like to do a per-client/per-IP bandwidth limit but I can not find one in API docs.

#

currently I use a modified mmproxy before MC server/proxy to do this.

wide maple Jan 11, 2021, 1:07 PM

#

No, there is no API for such a thing in Waterfall.

median nimbus Jan 11, 2021, 8:37 PM

#

where would i change the version?

#

would it be this?

#

that didnt change that

#

ive been able to change that with .getname

#

but i would like to change it from 1.7.x-1.16.x and just remove that

full cloak Jan 11, 2021, 10:06 PM

#

The "ProxyServer.getInstance().getServers()" method is deprecated, so what is now the correct way to add new servers to the proxy while the instance is running? 🤔

trail plume Jan 11, 2021, 10:07 PM

#

see the javadocs

#

Well, actually

#

There is a method called addServer

full cloak Jan 11, 2021, 10:10 PM

#

In which Class is it? 😱

#

The one I found is also deprecated 😂

trail plume Jan 11, 2021, 10:14 PM

#

my brain hurts

#

the entirety of the config stuff is deprecated

full cloak Jan 11, 2021, 10:15 PM

#

So is there any non-deprecated way to add a new server? 😅 Because I did not find any.

trail plume Jan 11, 2021, 10:16 PM

#

no

full cloak Jan 11, 2021, 10:17 PM

#

Wow, okay. 😂 Pretty nice, that there is currently no new method for that. xD But thanks for the help! ☺️

trail plume Jan 11, 2021, 10:17 PM

#

There is no reason for a new method

#

See the reason for the deprecation on the javadocs

#

It's just saying that "this is not API, expect changes" pretty much

#

It's not viable to replace that stuff without either basically just mirroring it or breaking API behavior

full cloak Jan 11, 2021, 10:21 PM

#

Yeah, okay. Than its fine I think.

potent lichen Jan 11, 2021, 11:23 PM

#

I'm pretty sure velocity fully supports that, though you'll have to check. Just saying

weary grove Jan 12, 2021, 11:57 PM

#

imagine not using Velocity in 2021

bleak current Jan 13, 2021, 12:17 PM

#

Still in progress to move over 😦

wide maple Jan 13, 2021, 8:11 PM

#

@ zzzCat is there a special issue you’re trying to tackle with the plugin messaging?

trail plume Jan 13, 2021, 8:12 PM

#

the fact that it allows those to build up

wide maple Jan 13, 2021, 8:13 PM

#

thonkeyes

#

I don’t see yet where that happens

trail plume Jan 13, 2021, 8:13 PM

#

when you server switch, your client resends things like the brand messages

#

bungee tracks every single plugin message packet send, so, at least the open issue heavily points to the brand message being a generic offender, but it seems that it tracks plugin packets sent after join

#

There's no real need for it to relay brand messages as the client sends those anyways on switch

wide maple Jan 13, 2021, 8:15 PM

#

Depends on the switch type but yes

trail plume Jan 13, 2021, 8:15 PM

#

My brains semi fuzzed out, som some level of shots in the dark here

wide maple Jan 13, 2021, 8:15 PM

#

I see, yea and I do understand, due to the hacky switch it does have to track that too

trail plume Jan 13, 2021, 8:16 PM

#

We always send join game, and the client always sends a brand message sometime after that

wide maple Jan 13, 2021, 8:17 PM

#

Wait are we talking up or downstream

trail plume Jan 13, 2021, 8:17 PM

#

from the client

#

upstream

wide maple Jan 13, 2021, 8:17 PM

#

So upstream; but the client doesn’t always get a join game on bungee

#

1.16+ yes it does

trail plume Jan 13, 2021, 8:18 PM

#

oh, yea, it uses respawn packets prior

wide maple Jan 13, 2021, 8:19 PM

#

So you do have to store packets that get received by the downstream server

trail plume Jan 13, 2021, 8:19 PM

#

But, there generally needs to be better handling there, as on newer versions it's just gonna let those pile up

wide maple Jan 13, 2021, 8:19 PM

#

Well then you might as well start hotwiring all rewriting that is done too

#

Entity meta rewrite disabling only takes care of part of it

trail plume Jan 13, 2021, 8:20 PM

#

It's a long issue which I gotta look into, my brain just hurts far too much to throw too much time into it

wide maple Jan 13, 2021, 8:20 PM

#

Got an issue on the tracker for that I can get a link to?

trail plume Jan 13, 2021, 8:21 PM

#

https://github.com/PaperMC/Waterfall/issues/545

wide maple Jan 13, 2021, 8:23 PM

#

That reminds me @weary grove I forgot to ask this earlier but I want to PR a warning to velocity that will trigger if the server the client is joining responds with a UUID that is not the UUID sent to the player by velocity on connection to the proxy. I’ve run into this sticky issue twice now in the wild:; objections?

#

I’ll take a look zzzCat

trail plume Jan 13, 2021, 8:23 PM

#

My thinking is is, store the client brand, on join of a new server, just send it

#

No need to stuff it in a bounded list

wide maple Jan 13, 2021, 8:24 PM

#

Unless the channel is not registered yet you don’t need to store it at all

#

Just delayed write

#

Maybe lock the write till switch complete

#

But that should take care of it

trail plume Jan 13, 2021, 8:24 PM

#

It's more a "don't write to the damned list" for that stuff

wide maple Jan 13, 2021, 8:25 PM

#

I suspect it’s more again than meets the eye here

trail plume Jan 13, 2021, 8:27 PM

#

The issue here is that 1.16+ always causes the brand message to be resent

#

at least, that's what I'm getting from the issue report

wide maple Jan 13, 2021, 8:27 PM

#

But we don’t need to store it for that. I just hope md_5 didn’t change the part I PRd again

trail plume Jan 13, 2021, 8:28 PM

#

When you switch enough servers or have enough mods, etc, those things will pile up

#

We'd need to store it for 1.15 and below

wide maple Jan 13, 2021, 8:28 PM

#

Yes. For anything else hold it until registration is through

#

Also;; wait no

#

I don’t get why you’d want to hold it

#

If you do then you’ll just end up resending the stuff from the last server

#

Eh anyway there is something im probably missing here

trail plume Jan 13, 2021, 8:29 PM

#

hm?

#

am confused

wide maple Jan 13, 2021, 8:30 PM

#

So am I

#

I’ll probably understand once I look at it

#

Also side note

trail plume Jan 13, 2021, 8:30 PM

#

fromw hat you're saying, on 1.16+, or if you have metadata rewriting disabled, the client will send the brand message to the server

wide maple Jan 13, 2021, 8:30 PM

#

Should I make an effort to fix the duplicate team scoreboard bug non-destructively?

trail plume Jan 13, 2021, 8:30 PM

#

The issue is that bungee will just blindly store all of those brand messages as it stores all register plugin messages

#

There is no reason why we need to store every brand plugin message, however

wide maple Jan 13, 2021, 8:31 PM

#

^ ah, really I’m not sure about that part because MD reintroduced meta rewriting again on 1.16+

trail plume Jan 13, 2021, 8:31 PM

#

store what the client sends us and pass that on during a server switch

wide maple Jan 13, 2021, 8:32 PM

#

wide maple Should I make an effort to fix the duplicate team scoreboard bug non-destructive...

This bug is closely related to the switch logic in question

trail plume Jan 13, 2021, 8:32 PM

#

maybe this is just entity metadata rewrite disabled behavior then

#

hmmm

#

If you can do it non-derstrivpadndaknajnadspijfeojnaefnodsf

wide maple Jan 13, 2021, 8:33 PM

#

I can take a shot at it

trail plume Jan 13, 2021, 8:34 PM

#

See, my biiiigggest concern in general is plugins

#

Part of me was looking at making it possible to easily disable packets from being handled

wide maple Jan 13, 2021, 8:35 PM

#

Bad idea

#

notlike

trail plume Jan 13, 2021, 8:35 PM

#

if you're using not using metadata rewriting, and don't care about scoreboard plugins, we can shave a chunk of work off the api there and not have to worry about that one

#

i know that I wanted to provide a way to disable the old forge packet fix thing with effects

wide maple Jan 13, 2021, 8:36 PM

#

Also side note

#

Would paper be open to a ~~reimplemented~~ modified bungee API with adventure support

#

Someone I know has that cooking on the stove

#

Wether the world wants it or not

trail plume Jan 13, 2021, 8:37 PM

#

Yea

#

having a sane common text platform between the two is a goal

#

Just, paper first, and no idea if kash had any intents there or if it was gonna be the magical dream what one day I'm not dead

wide maple Jan 13, 2021, 8:38 PM

#

I mean

#

Ill talk about that later

potent lichen Jan 15, 2021, 11:09 PM

#

Path#resolve

#

getPluginsFolder().toPath().resolve("ServerListPlus").resolve("mapart") etc.

outer cosmos Jan 15, 2021, 11:10 PM

#

Plugin#getDataFolder().toPath().resolve("mapart").

#

probably.

#

.try

lean gobletBOT Jan 15, 2021, 11:11 PM

#

https://tryitands.ee/

outer cosmos Jan 15, 2021, 11:12 PM

#

Download one and start it. Stop it. drop you plugin in. Start it again.

#

np, wasn't not only my work.

potent lichen Jan 15, 2021, 11:23 PM

#

you're putting that into a loop?

#

also catch (IOException ignored)

#

have fun debugging

#

exceptions are your friends, not your enemies

#

have the compiler detect bugs first, have fail-fast exception throws detect bugs second

sly vigil Jan 16, 2021, 9:51 AM

#

waterfall is a bungeecord fork iirc

open vine Jan 16, 2021, 11:23 AM

#

Yeah, waterfall is a fork of bungeecord. Paper is a fork of Spigot

raw arrow Jan 18, 2021, 11:28 AM

#

so how do i listen for incomming ByteStream packets in Bungeecord..

wide maple Jan 18, 2021, 11:54 AM

#

There are few packet which use ByteStreams, most use netty ByteBufs. Secondly, that is unsupported. You can register a channel handler to do it anyway, but be warned, its very finicky

manic geode Jan 20, 2021, 2:14 AM

#

there aren't enought travertine documentation

trail plume Jan 20, 2021, 2:14 AM

#

it's waterfall with 1.7 proto support, no need for docs for that specifically

hidden galleon Jan 20, 2021, 10:33 AM

#

Heyo

#

Is there a way to disable the packet limiter? It kicks people who rapid auto craft things and such.

hidden galleon Jan 20, 2021, 11:08 AM

#

ViaVersion has this feature, thanks anyway.

lean gobletBOT Jan 20, 2021, 11:46 PM

#

in your own plugin? sure

#

otherwise if you are just using waterfall try the helpchanne

manic geode Jan 21, 2021, 4:37 AM

#

do waterfall connect different sub-servers

#

oh nvm

wide maple Jan 22, 2021, 9:15 AM

#

bad ideas sometimes become bad habits

#

https://github.com/Xernium/Waterfall/tree/future/master

#

from https://github.com/Xernium/BungeeCord/tree/future/1.17

#

notlike

trail plume Jan 22, 2021, 9:16 AM

#

p u s h t o m a s t e r

wide maple Jan 22, 2021, 9:17 AM

#

I mean drake_yes

#

no patch needed ™️

wide maple Jan 22, 2021, 9:38 AM

#

side note

#

https://github.com/Xernium/Travertine/blame/19326faf3b014a9fcc146335d44cd8c883f625fc/Waterfall-Proxy-Patches/0003-1.7.x-Protocol-Patch.patch#L240 I noticed that this was borked

wide maple Jan 22, 2021, 10:00 AM

#

https://github.com/Xernium/Travertine/tree/future/master

#

woo

outer elbow Jan 23, 2021, 3:06 AM

#

is there a quit reason on the proxy like there is on backend servers

lean gobletBOT Jan 23, 2021, 3:16 AM

#

anything in javadocs?

outer elbow Jan 23, 2021, 6:05 AM

#

haven't seen anything so far but the bungee docs also don't have search so it makes it slightly tougher

full cloak Jan 23, 2021, 10:41 PM

#

Why is the PermissionCheckEvent called ~7 times for each executed command from a player? Shouldn't a single call be enough for that? 🤔

trail plume Jan 23, 2021, 10:53 PM

#

Depends on what the checks where from

#

the execute chain only calls it once, but, nothing stopping plugins doing their own checks, etc

full cloak Jan 23, 2021, 11:03 PM

#

I only have my own plugin installed and that comes without any internal permissions checks on command execution, i use the normal Command class and enter there the permissions needed. I only give a result back, when the PermissionCheckEvent is called and i then saw that this done on startup for each registered command twice and when the command is executed 7 times. 🤯

trail plume Jan 23, 2021, 11:05 PM

#

are you passing any arguments to the command?

full cloak Jan 23, 2021, 11:05 PM

#

it has one arg

trail plume Jan 23, 2021, 11:05 PM

#

There are some perm checks when joining, etc, as it resends the command list and has to check what commands to send to players

#

typing arguments will also run a perm check due to the tab completion

full cloak Jan 23, 2021, 11:09 PM

#

Ahh, I see... Thx. ☺️ So many calls then, but okay, now I know the cause of them 😅

craggy furnace Jan 23, 2021, 11:49 PM

#

Is it possible with API to send data between bungee instances?

#

Simple data, like text

trail plume Jan 24, 2021, 12:10 AM

#

no

outer cosmos Jan 24, 2021, 2:53 PM

#

Use redis for that.

brittle panther Jan 25, 2021, 12:54 AM

#

I'm getting player's offline UUIDs through Mojang's API. I have run into a problem where it is now returning null every so often.

I am thinking it is because I am querying it too often, but 1) I don't think that is possible. And 2) I don't know any other way to do it.

I'm thinking of trying to use a sort of backup UUID. Basically, I think it is actually querying it twice in the same tick (I can't seem to figure out why) and I am thinking that just having a public static UUID previousUUID; in my UUIDFetcher class will fix it, but I don't know if this will cause any problems.

If anyone has any ideas they want to offer, I'm all ears.

potent lichen Jan 25, 2021, 12:58 AM

#

Regarding #2 - learn how to implement caching/rate limiting. Caching can be done with a library like Caffeine or Guava and is straight forward. Rate limiting your requests can be implemented, though you may need to rework your code somewhat to account for the fact that you can no longer make a request at any given time.

#

Having a mutable field such as public static UUID previousUUID is very likely to go wrong. There are already many ways in which that is wrong.

brittle panther Jan 25, 2021, 1:00 AM

#

I've never worked with Libraries before. How would I add one to my IJ maven project?

potent lichen Jan 25, 2021, 1:00 AM

#

First set up a proper build system

trail plume Jan 25, 2021, 1:00 AM

#

static state for something that occurs across multiple threads is generally not a good idea

potent lichen Jan 25, 2021, 1:00 AM

#

then add the dependency to your build file

trail plume Jan 25, 2021, 1:00 AM

#

mojang returning null would likely be an API limit or something, that's why you're supposed to check the response codes

potent lichen Jan 25, 2021, 1:00 AM

#

In this case, you said you're using maven, so add another <dependency> entry

brittle panther Jan 25, 2021, 1:12 AM

#

Okay. So, how exactly would I go about doing this? I've never worked with caching before.

I would assume I am going to make a caching system that will add the uuid and name to the cache if the name isn't in the cache whenever I query it. Then, when I just get it from the cache?

That seems pretty straight forward.

potent lichen Jan 25, 2021, 1:12 AM

#

No need to reinvent your own caching. Use a library which is made for that

brittle panther Jan 25, 2021, 1:12 AM

#

I am.

#

I'm asking if that's how I would do it.

#

With the new system.

potent lichen Jan 25, 2021, 1:13 AM

#

you'd use one of the methods provided by your cache library which implements an atomic get-cached-or-cached-and-get

brittle panther Jan 25, 2021, 1:13 AM

#

I'm using Caffeine by the way.

potent lichen Jan 25, 2021, 1:13 AM

#

yeah, so use cache.get(key, Function)

#

(you can also use LoadingCache if you prefer to specify the cache loader at the time you create the cache)

brittle panther Jan 25, 2021, 1:18 AM

#

What would I put in the Function part of cache.get(key, Function);

Sorry. I'm not used to Callables.

potent lichen Jan 25, 2021, 1:20 AM

#

The actual retrieval of the value.

public String getCachedName(UUID uuid) {
  return cache.get(uuid, (u) -> getUncachedName(uuid));
}

private String getUncachedName(UUID uuid) {
  // Implement this how you would without caching
}

#

This way, the Function is only invoked if there is no value cached yet

brittle panther Jan 25, 2021, 2:02 AM

#

I can't seem to find anywhere online how to instantiate the cache.

potent lichen Jan 25, 2021, 2:02 AM

#

Caffeine.newBuilder

#

Cache is an interface

#

it's in the library README. i recommend you take a closer look at the documentation

brittle panther Jan 25, 2021, 2:03 AM

#

I got this in my pom.xml, but I can't seem to use it...?

#

wait let me reload IJ

#

Okay. I think I got it working. Let me test it.

#

Looks like it works! :D Thanks!

brittle panther Jan 25, 2021, 3:21 AM

#

Now... How would I go about making it so I can reload my config with a /plugin:reload command or such?

spring estuary Jan 25, 2021, 7:11 AM

#

brittle panther Now... How would I go about making it so I can reload my config with a ``/plugin...

Build your plugin around the idea of live reloading. Make your logic resilient and introduce a way to re-initialize it with new values.

stark bone Jan 25, 2021, 1:26 PM

#

bit of a unique use case here...

I want to use waterfall for basically, just running a plugin. No server behind it or anything. Waterfalls contacts an API and gives the user an auth code. At the moment I am running the code on the LoginEvent to send the API request and then kick the user with the code.

I assume I dont want to do this with an intent because that could mean the user tries to join the server (which doesn't exist) and give an error.

However, ocassionally I get an took xxxms to process! warning in the console. Any recommendations

#

Apart from that, everything works fine. Ocasionally a user times out but i am putting that down to their internet..

wide maple Jan 25, 2021, 1:46 PM

#

@stark bone that happens if you hold an event hostage for long enough. That can happen when a database call or the method you execute on that event takes a certain amount of time to process. It’s harmless in your case

stark bone Jan 25, 2021, 1:56 PM

#

wide maple <@231385835054956544> that happens if you hold an event hostage for long enough....

any idea how to prevent it?

trail plume Jan 25, 2021, 1:57 PM

#

don't take that long?

stark bone Jan 25, 2021, 1:58 PM

#

Yeh that's an option. Thanks anyway

trail plume Jan 25, 2021, 1:59 PM

#

2 second calc attempt shows that you got 250ms to do stuff before it shouts for the entire event

wide maple Jan 25, 2021, 3:31 PM

#

@stark bone either that or run an async task from the event- however thats not usable in your case

old trail Jan 28, 2021, 2:09 AM

#

@trail plume

civic valve Jan 28, 2021, 2:09 AM

#

@stone fiber nuke him OOOO

stone fiber Jan 28, 2021, 2:10 AM

#

who am I nuking

civic valve Jan 28, 2021, 2:10 AM

#

guy above me

#

same one that pinged u

stone fiber Jan 28, 2021, 2:10 AM

#

is that the same guy

civic valve Jan 28, 2021, 2:10 AM

#

yeah

stone fiber Jan 28, 2021, 2:10 AM

#

?kick @old trail "this is not a marketplace however, try the services and recruitment forum on spigot"

chilly windBOT Jan 28, 2021, 2:10 AM

#

stone fiber Jan 28, 2021, 2:10 AM

#

literally told him

wide maple Jan 28, 2021, 5:39 AM

#

LOL same guy we dealt with on Velocity

#

Wanted a combination of aegis and flamecord

#

pepega

thorny holly Jan 28, 2021, 2:38 PM

#

How does one do like scheduled runtasklaters in waterfall api?

#

oh it has a scheduler

wide maple Jan 29, 2021, 6:14 AM

#

@ zzzCat I upstreamed Waterfall to after md_5 added a length limitable readString method and we are now facing an interesting dilemma- in the case of the login readString it’s perfectly reasonable to assume the sequence of characters is ascii and therefor only uses one byte per character.
That isn’t true however for the vast majority of other uses of the length limited read/write string methods where we have to assume UTF-8 is in use which can be up to 4 bytes per char

Now I propose we, instead of hacking in this method altogether, use md_5s method but make the max bytes per char configurable.

I should also, regarding that, go over the rest of the limited read/write string methods again to see if their length limits make sense

#

I’ll PR that later alongside some more mitigations for potential attacks

#

@weary grove do we have an oversight in this as well on velocity? I haven’t checked

weary grove Jan 29, 2021, 6:29 AM

#

wide maple <@129282174414356480> do we have an oversight in this as well on velocity? I hav...

We assume all strings are UTF-8. It's possible for us to potentially use ASCII in select places, but this is likely to cause issues as vanilla will accept UTF-8 names, especially for offline mode (and obviously that is very popular in China...)

wide maple Jan 29, 2021, 6:31 AM

#

weary grove We assume all strings are UTF-8. It's possible for us to potentially use ASCII i...

Judging by that logic even Waterfall should use 4bytes/char in the login limit

#

thonk

weary grove Jan 29, 2021, 6:33 AM

#

Mojang's code writes UTF-8 so we have to accept UTF-8 too. No middle ground.

trail plume Jan 29, 2021, 7:35 AM

#

I saw his thing but have been too ill/busy to dig into it, but, what tux said, basically, for stuff like hostnames, we can just /4 the 'real' limit, otherwise it creates many varying issues when you start tryna apply these limits across the board

trail plume Jan 29, 2021, 10:44 AM

#

cheers for the PRs, been on my todo list but been too dead for it

wide maple Jan 29, 2021, 10:45 AM

#

had to do it anyway for the additional mitigations I'm working on

trail plume Jan 29, 2021, 10:46 AM

#

Well, I take the thanks back then

wide maple Jan 29, 2021, 10:47 AM

#

thonkeyes

trail plume Jan 29, 2021, 10:47 AM

#

my brains trash and so are my jokes \o/

wide maple Jan 29, 2021, 10:47 AM

#

Hah. Almost as dead as my brain when I had to decide which method to keep for readString

#

md_5 was right for one

#

We had a length limit based on the VarInt byte len

#

but thats bad because each char can be from 1-4 bytes long

#

and we always assumed 1

#

notlike

trail plume Jan 29, 2021, 10:48 AM

#

I mean

#

MURICA

#

I guess

wide maple Jan 29, 2021, 10:49 AM

#

not bad for usernames but commands and stuff

#

usernames except in the cases with offline mode are always ascii

lean gobletBOT Jan 29, 2021, 12:15 PM

#

I mean, usernames should always be \w{3,16} unless you have one of the 1/2 latter accounts mojang allowed at some point or some dumb plugin

wide maple Jan 29, 2021, 12:34 PM

#

you should know as well as I do that chinese people use unicode characters in their cracked networks

#

and yes- its stupid

lean gobletBOT Jan 29, 2021, 12:39 PM

#

fuck them?

#

like seriously, just use supported names lol

wide maple Jan 29, 2021, 12:50 PM

#

I do have to remind you that there are also people with spaces in their usernames

#

notlike

lean gobletBOT Jan 29, 2021, 12:53 PM

#

which are also not valid usernames ¯_(ツ)_/¯

wide maple Jan 29, 2021, 1:08 PM

#

But they still exist

lean gobletBOT Jan 29, 2021, 1:11 PM

#

not in the official game

wide maple Jan 29, 2021, 1:15 PM

#

Well yes and no. I’ve seen my fair share of people with spaces in their name on the networks I’ve administered

trail plume Jan 29, 2021, 1:15 PM

#

People do dumb shit

wide maple Jan 29, 2021, 1:15 PM

#

Not a lot recently, the last time was around 2019

trail plume Jan 29, 2021, 1:15 PM

#

and, really, the server should prevent that crap

#

But, in kinda doesn't

wide maple Jan 29, 2021, 1:15 PM

#

Those are official names, they exist

trail plume Jan 29, 2021, 1:15 PM

#

(and then people wonder why their plugins break, etc)

wide maple Jan 29, 2021, 1:15 PM

#

Yea I agree

civic valve Jan 29, 2021, 1:15 PM

#

Tbf it doesn't support it either

#

It just kinda works in some places

trail plume Jan 29, 2021, 1:16 PM

#

it doesn't support it but it doesn't go prevent it either

#

one would hope that they'd filter that stuff, but, we're talking mojang here

lean gobletBOT Jan 29, 2021, 1:28 PM

#

pretty sure mojang removed space names a while back

wide maple Jan 29, 2021, 1:50 PM

#

wide maple Not a lot recently, the last time was around 2019

yea I mean its been over a year since ive seen those

stark bone Jan 29, 2021, 3:39 PM

#

Really random question. Would anyone happen to have a link that describes the protocol change in encryption between 1.7 and 1.8+ clients? Wiki.vg seems to only have the modern info...

lean gobletBOT Jan 29, 2021, 3:47 PM

#

check the page's history?

stark bone Jan 29, 2021, 4:11 PM

#

oh fuck yeh

#

good shout

wide maple Jan 30, 2021, 6:49 AM

#

I really need to push the changes for #600 and #601 I hope I have the time for that today

wide maple Jan 30, 2021, 6:17 PM

#

https://github.com/Xernium/Waterfall/commit/52a5fc2fae7450b9e72e09390425009888a2302e @ zzzCat I need an opinion

bleak current Jan 31, 2021, 9:08 AM

#

is there some way to check if a player connect failed?

wide maple Jan 31, 2021, 10:46 AM

#

There is either gonna be something in the log or no

languid rapids Jan 31, 2021, 11:38 AM

#

Hi i got question is there anything wrong with getting player by name in bungee api?

trail plume Jan 31, 2021, 11:39 AM

#

at runtime, no

#

if you're persisting stuff, use the UUID

languid rapids Jan 31, 2021, 11:43 AM

#

so there is no need fort cache like in the bukkit api?

trail plume Jan 31, 2021, 5:24 PM

#

Five, lgtm

wide maple Jan 31, 2021, 7:02 PM

#

I’ll change a few exceptions to cached ones later then I’ll PR

craggy furnace Jan 31, 2021, 9:36 PM

#

How to cancel sending ping to a player?

#

For example a banned player

full cloak Jan 31, 2021, 9:38 PM

#

I have some troubles with the timings of some events in Waterfall:

So a player disconnects from the proxy but however he manages to connect at the same time again, so the log states disconnected with: You are already connected to this proxy!".

First: Why can a player join (with the same mc client) before the disconnect event is called?

Second: After this message, the LoginEvent for the player is still called. Is that desired?

trail plume Jan 31, 2021, 9:39 PM

#

the server kicks the player already online

#

that would imply they disconnected in an unexpected manner, e.g. bad connection

#

they reconnected before their old connection had timed out

full cloak Jan 31, 2021, 9:41 PM

#

trail plume that would imply they disconnected in an unexpected manner, e.g. bad connection

I knew from the player (teammember), that he disconnect normally via the gui.

trail plume Jan 31, 2021, 9:42 PM

#

apparently they didn't disconnect properly or some plugin mangled it

full cloak Jan 31, 2021, 9:43 PM

#

Okay, that case can happen sometimes. 😅 But why is the login event still called for a player that is already online on the same proxy?

trail plume Jan 31, 2021, 9:44 PM

#

because the new connection is logging on

#

the login event is fired as the person who DC'd tries to reconnect

#

it's their dangling connection which is booted

full cloak Jan 31, 2021, 9:46 PM

#

Yeah sure, but when the proxy already knows, that the player is still online, why would i have a login event for that? I mean than the proxy can just do without an event, as a player cannot exist twice anyway.🙈

wild jackal Jan 31, 2021, 9:46 PM

#

yeah, we're having a similar issue:

player joins on one connection A
connection A gets processed, postlogin fires
player somehow joins on another connection B
connection A gets "already connected" and gets closed
connection B gets processed, postlogin fires
disconnect event fires for connection A

trail plume Jan 31, 2021, 9:47 PM

#

it fires the login event for the new player

#

not the old one

#

the login event is fired after the old connection is DC'd

#

then again, miiight be the event loop thing

#

ouch

#

I guess it could fire after, I forget how netty deals with that

wild jackal Jan 31, 2021, 9:49 PM

#

here are the logs

[16:00:05] [/x:60363] <-> InitialHandler has connected
[16:00:05] [player|/x:60363] <-> ServerConnector [lobby] has connected
[16:00:06] [/x:60365] <-> InitialHandler has connected
[16:00:06] [player] disconnected with: You are already connected to this proxy!
[16:00:06] [/x:60363|player] <-> DownstreamBridge <-> [lobby] has disconnected
[16:00:06] [player|/x:60365] <-> ServerConnector [lobby] has connected
[16:00:11] [/x:60363|player] -> UpstreamBridge has disconnected
[16:00:17] [player|/x:60365] <-> ServerConnector [skyblock] has connected
[16:00:17] [/x:60365|player] <-> DownstreamBridge <-> [lobby] has disconnected

(compare port 60363 vs 60365)

trail plume Jan 31, 2021, 9:50 PM

#

Yea, I understand the issue now

#

the thing disconnects them before, but, as it relies on the handler the actual disconnection can be one on anothrer thread

full cloak Jan 31, 2021, 9:50 PM

#

Thats the situation and I wonder, why the Login event is called for the connection, that gets the "already online" notification.

trail plume Jan 31, 2021, 9:50 PM

#

(or even, just "ater")

wild jackal Jan 31, 2021, 9:50 PM

#

yup

wide maple Jan 31, 2021, 9:51 PM

#

#603 go ham zzzCat woooo

trail plume Jan 31, 2021, 9:52 PM

#

Only real thing I think of is to remove the wording of "if ur a dev"

#

"for more info"

wide maple Jan 31, 2021, 9:53 PM

#

one sec

full cloak Jan 31, 2021, 9:57 PM

#

trail plume the thing disconnects them before, but, as it relies on the handler the actual d...

So how can I resolve the issue, that the player first logins and then afterwards disconnect again? 😅

trail plume Jan 31, 2021, 9:57 PM

#

You can't

full cloak Jan 31, 2021, 9:59 PM

#

Okay. Good to know. Do I get the information in the login event, that the player is still online and can't connect? 🤔

trail plume Jan 31, 2021, 10:00 PM

#

getPlayer for their UUID in the login event

#

should be null if it's not gonna fire, i think

wide maple Jan 31, 2021, 10:01 PM

#

changed it to For more information

#

blobcatgooglythumbsup

full cloak Jan 31, 2021, 10:03 PM

#

trail plume the login event is fired after the old connection is DC'd

So the old connection gets disconnected for already online and not the new one? 🤯

trail plume Jan 31, 2021, 10:04 PM

#

yes, as I've said multiple times now

wild jackal Jan 31, 2021, 10:04 PM

#

one thing that might work is create a map UUID->ProxiedPlayer, then in postlogin insert mapping for the proxiedplayer joining in a synchronized block, in disconnect get the proxiedplayer from the map in a synchronized block and check if they're the same as the proxiedplayer of the event. if they are, removing mapping and fire your disconnect code

trail plume Jan 31, 2021, 10:05 PM

#

syncronization won't save your ass there

full cloak Jan 31, 2021, 10:05 PM

#

Ok... thanks. The whole thing with connections is pretty complicated. 😂

trail plume Jan 31, 2021, 10:05 PM

#

it's down to how netty works

wild jackal Jan 31, 2021, 10:07 PM

#

or you could have a counter for every UUID, add 1 if player joins, remove 1 if player leaves. if it hits 0, you're good :P

full cloak Jan 31, 2021, 10:08 PM

#

trail plume it's down to how netty works

Would it than not be better to just don't let the new connection connect? 😅 So that the "already connected" is called for the new connection and not the old one?

trail plume Jan 31, 2021, 10:08 PM

#

Please stop pinging

#

I mean, maybe, sorta, it's more on UX than "what works best for code"

#

we never decided the behavior there, that was spigot

full cloak Jan 31, 2021, 10:09 PM

#

trail plume Please stop pinging

Oh, its because I use the discord answer function and dont disabled that. Sorry!

full cloak Jan 31, 2021, 10:11 PM

#

trail plume we never decided the behavior there, that was spigot

Alright, than i will search for a good solution in my case. Thank! 😇

trail plume Jan 31, 2021, 10:12 PM

#

if you wanna create an issue on the tracker we can look into it, would need look into making it happen as a callback in netty if it lets us

full cloak Jan 31, 2021, 10:14 PM

#

trail plume if you wanna create an issue on the tracker we can look into it, would need look...

I think I will do so. Thanks for the help and explanations already and the code snippet. ☺️ 🙈

wide maple Jan 31, 2021, 10:20 PM

#

I almost forgot Travertine, lol. Also, fixed/removed a redundant section while 3-way-merging

#

Ill go to bed now

#

ping me if I broke something

stone fiber Feb 1, 2021, 1:46 AM

#

oh my sweet summer child

paper fjord Feb 1, 2021, 7:38 AM

#

how do i make a new BaseComponent

#

i want to send the tablist footer

wide maple Feb 1, 2021, 7:52 AM

#

paper fjord how do i make a new BaseComponent

see https://papermc.io/javadocs/waterfall/net/md_5/bungee/api/chat/ComponentBuilder.html

paper fjord Feb 1, 2021, 7:53 AM

#

thanks

wide maple Feb 1, 2021, 7:54 AM

#

stone fiber oh my sweet summer child

oh yes we've been there

wide maple Feb 1, 2021, 4:19 PM

#

#604 is the typical case of the chicken and the egg

#

Additionally- no. Just no. Blocking connections to wait for disconnect is straight out. There are too many problems with it

trail plume Feb 1, 2021, 4:21 PM

#

it's fixable, but I'm eer on fixing it for obvious reasons

#

there's enough people having issues joining as-is

wide maple Feb 1, 2021, 4:42 PM

#

If you want I can go into detail (with a poc) how this creates a massive issue by just trying to fix this

#

but that is not something I should discuss here

reef vessel Feb 2, 2021, 10:26 AM

#

https://papermc.io/javadocs/waterfall/net/md_5/bungee/api/event/PluginMessageEvent.html

#

Does this get fired for the messaging channel?

#

Can't tell from the description if it's for the messaging channel or something like custom packets from mods

#

I assume it's fired for the messaging channel though

lean gobletBOT Feb 2, 2021, 10:27 AM

#

it's fired for all PluginMessages that get sent by the client or the server

reef vessel Feb 2, 2021, 10:28 AM

#

Not really familiar with waterfall that much. What does that mean wrt my question?

lean gobletBOT Feb 2, 2021, 10:28 AM

#

this isn't waterfall specific

#

plugin messages are a vanilla concept: https://wiki.vg/Protocol#Plugin_Message_.28clientbound.29

reef vessel Feb 2, 2021, 10:28 AM

#

And I assume the PMC uses these packets

lean gobletBOT Feb 2, 2021, 10:29 AM

#

it is the packet

reef vessel Feb 2, 2021, 10:29 AM

#

Yeah cheers

languid rapids Feb 2, 2021, 2:33 PM

#

is there anything like runTaskTimer like in Bukkit API?

outer cosmos Feb 2, 2021, 2:44 PM

#

schedule should do the right with enough parameters.

wide maple Feb 2, 2021, 8:34 PM

#

I took another look at #318 and fixing it is stupid-
Either unregister the team on getting it again or keep track of team / server mapping and reset&resend dynamically

#

Second one works reasonably well; it’s just a stupid workaround for a stupid issue

outer cosmos Feb 2, 2021, 8:36 PM

#

Or send teams with a random string. 🙂

wide maple Feb 2, 2021, 8:37 PM

#

That doesn’t work for obvious reasons

#

I should clean and publicize this so people with the issue can try it

lean gobletBOT Feb 2, 2021, 8:38 PM

#

or use velocity

#

runs

wide maple Feb 2, 2021, 8:38 PM

#

Well yes

#

I always say that

#

PR #603 pays homage to that

bleak current Feb 3, 2021, 8:50 AM

#

why is the https://papermc.io/javadocs/waterfall/net/md_5/bungee/api/event/ServerKickEvent.html deprecated and what is my alternative?

#

huh why does bungeecord have way more methods? https://ci.md-5.net/job/BungeeCord/ws/api/target/apidocs/net/md_5/bungee/api/event/ServerKickEvent.html

#

thonk

#

why would waterfall remove those methods?

wide maple Feb 3, 2021, 9:07 AM

#

Let's check that

bleak current Feb 3, 2021, 9:10 AM

#

also not related to paper, but javadocs noscript works with paper docs

#

but on mds ci its activated

#

kinda weird behaviour

#

https://github.com/PaperMC/Waterfall/blob/master/BungeeCord-Patches/0027-Improve-ServerKickEvent.patch

#

hm

wide maple Feb 3, 2021, 9:16 AM

#

that shouldnt screw with the javadocs

bleak current Feb 3, 2021, 9:16 AM

#

i know, but that just makes it weirder

wide maple Feb 3, 2021, 9:17 AM

#

well I might have an explanation- due to the way paper generates javadocs

#

lets see if I am right

#

I usually just javadoc:aggregate

#

thonk

bleak current Feb 3, 2021, 9:21 AM

#

i just site:site

#

lol

#

just got the javadoc plugin and made a maven generated docs site

wide maple Feb 3, 2021, 9:22 AM

#

site:site works with neither bungeecord nor waterfall out of the box

bleak current Feb 3, 2021, 9:22 AM

#

yeah...

#

i mean for personal projects

wide maple Feb 3, 2021, 9:24 AM

#

conclusion: md_5s apidocs are out of date

bleak current Feb 3, 2021, 9:24 AM

#

hm

wide maple Feb 3, 2021, 9:24 AM

#

want a side-by-side comparison? sec

bleak current Feb 3, 2021, 9:31 AM

#

@wide maple ok i've built the docs myself now. I guess something is wrong with the docs.

#

wide maple Feb 3, 2021, 9:37 AM

#

https://xernium.github.io/apidocs/waterfall-1.16-R0.5/net/md_5/bungee/api/event/ServerKickEvent.html vs https://xernium.github.io/apidocs/bungeecord-1.16-R0.5/net/md_5/bungee/api/event/ServerKickEvent.html

#

@bleak current compare side-by side

bleak current Feb 3, 2021, 9:38 AM

#

@wide maple guess what. The actual java files don't have that api

bleak current Feb 3, 2021, 9:39 AM

#

wide maple <@456226577798135808> compare side-by side

huh

#

so that means it got removed

#

but what should i use then?

wide maple Feb 3, 2021, 9:40 AM

#

as I said- whats on md_5s site is old

#

the build I have there is the recent one

bleak current Feb 3, 2021, 9:41 AM

#

hm yeah

wide maple Feb 3, 2021, 9:41 AM

#

it aligns with the current waterfall one

#

notlike

bleak current Feb 3, 2021, 9:41 AM

#

imma take a look at the commit that removed it

#

LOMBOK

#

knew it

wide maple Feb 3, 2021, 9:42 AM

#

pepe_morre_diabo

bleak current Feb 3, 2021, 9:42 AM

#

so paper docs don't include lombok

#

bruh

wide maple Feb 3, 2021, 9:42 AM

#

well there we have it

bleak current Feb 3, 2021, 9:42 AM

#

yeah, but how would you fix that

#

hm lemme see how md generates his docs

#

aren't the build steps public?

wide maple Feb 3, 2021, 9:44 AM

#

nope lol

bleak current Feb 3, 2021, 9:44 AM

#

i think there we have it

#

delombok

#

maybe its that

wide maple Feb 3, 2021, 9:44 AM

#

well yea

bleak current Feb 3, 2021, 9:44 AM

#

wide maple nope lol

console is public

wide maple Feb 3, 2021, 9:45 AM

#

thonkwot

bleak current Feb 3, 2021, 9:46 AM

#

https://ci.md-5.net/job/BungeeCord/1545/console

#

i mean mds ci

#

thats jenkins

#

¯_(ツ)_/¯

#

so what do we have to do now?

wide maple Feb 3, 2021, 9:47 AM

#

I have to yell at a certain someone really quickly

bleak current Feb 3, 2021, 9:47 AM

#

wide maple I have to yell at a certain someone really quickly

nice

#

ok lemme know when its fixed

#

@wide maple i think i know why

#

mds lombok

wide maple Feb 3, 2021, 9:51 AM

#

yes- so?

bleak current Feb 3, 2021, 9:51 AM

#

paper lombok

#

version not found

#

thats why it doesn't use delombok

#

right?

#

@wide maple

wide maple Feb 3, 2021, 9:52 AM

#

I dont think thats the issue

#

waterfall is simply missing the goal to properly deploy this

bleak current Feb 3, 2021, 9:53 AM

#

hm ok then

trail plume Feb 3, 2021, 12:29 PM

#

The way the entire thing works is badicslly fragile af, we basically run a a profile for the docs or something

#

Md followed suite in delombok ing eventually, never really looked af his attempt as I wasn't in the mood to fight with jenkins and stuff

wide maple Feb 3, 2021, 7:29 PM

#

No snapshot update from me today, I’ll get to it tomorrow.

trail plume Feb 3, 2021, 7:52 PM

#

wow, let down

wide maple Feb 3, 2021, 7:56 PM

#

It’s just a protocol bump

#

And I don’t have a computer on hand

#

notlike

flint cradle Feb 3, 2021, 9:20 PM

#

ing

lean gobletBOT Feb 3, 2021, 9:33 PM

#

just log them in your method?

brittle panther Feb 3, 2021, 9:58 PM

#

Does anyone know what the new snapshot (21w05a)'s protocol id for TabCompleteRequest is? I am having some trouble updating WaterFall / Bungee to 21w05a.

#

And it is caused by that.

wide maple Feb 3, 2021, 10:00 PM

#

@brittle panther unchanged. Only thing you should need to change is the protocol ID bit

brittle panther Feb 3, 2021, 10:01 PM

#

?

#

I'm confused... I changed the SNAPSHOT_PROTOCOL. But, it's still giving errors.

#

Oh. By the way, this is the TO_SERVER TabCompleteRequest.

wide maple Feb 3, 2021, 10:06 PM

#

Error log?

brittle panther Feb 3, 2021, 10:08 PM

#

This is all I have as (for some reason) it isn't logging anything (to file)...

#

And I guess you can have this. (Sorry for small print...) My console got cut off for some odd reason and I don't know how to fix it.

wide maple Feb 3, 2021, 10:10 PM

#

thonk

#

fabric mods?

brittle panther Feb 3, 2021, 10:11 PM

#

TacoRevamped is a custom mod I made.

wide maple Feb 3, 2021, 10:11 PM

#

uses any custom command args?

brittle panther Feb 3, 2021, 10:12 PM

#

Like ArgumentTypes? No.

wide maple Feb 3, 2021, 10:12 PM

#

Cause those usually do that

brittle panther Feb 3, 2021, 10:13 PM

#

Hmm.

#

I'm probably just going to wait for you to update yours tomorrow. Plus, I prefer WaterFall over BungeeCord and since I cannot find any good documentation on how to "patch" WaterFall, I'm just going to stick to doing custom BungeeCord builds.

wide maple Feb 3, 2021, 10:14 PM

#

Hah.

brittle panther Feb 3, 2021, 10:15 PM

#

🏳️

wide maple Feb 3, 2021, 10:15 PM

#

https://github.com/Xernium/BungeeCord/tree/future/1.17

#

check this out

brittle panther Feb 3, 2021, 10:15 PM

#

Did you update it?

wide maple Feb 3, 2021, 10:15 PM

#

not yet

#

but this is going to be my stick-it-to-md_5

#

lets see if this builds given ive thrown the mitigations overtop

brittle panther Feb 3, 2021, 10:18 PM

#

Yeah. I've already used your project as a sort of "what in the world am I supposed to do" model, and thus, I have updated (what I think) needs updated... But, ya know... It doesn't work.

wide maple Feb 3, 2021, 10:18 PM

#

Ive taken a long look at the networking and it doesnt appear anything has changed with tabcomplete

#

there might be another argtype I cant see just now

brittle panther Feb 3, 2021, 10:19 PM

#

Oh. Another thing, that screenshot was from someone on 1.16 logging on to a 1.16 lobby.

wide maple Feb 3, 2021, 10:19 PM

#

brittle panther Feb 3, 2021, 10:19 PM

#

Yeah.

#

I feel you.

#

This is why I came here to ask.

#

I ain't got a clue what I'm doing. I'm just a hobby programmer who has like a year of actual schooling under my belt in C#... Everything I've learned in Java is self taught.

wide maple Feb 3, 2021, 10:22 PM

#

I call c# the microsoft java

#

lol

brittle panther Feb 3, 2021, 10:22 PM

#

It really is.

#

I actually think it is better than Java, but that's just my opinion.

trail plume Feb 3, 2021, 10:23 PM

#

I mean, it is the MS java, they created it because their own JVM flopped

brittle panther Feb 3, 2021, 10:23 PM

#

Wait... I thought Java came from C?

trail plume Feb 3, 2021, 10:24 PM

#

it's inspired from C

#

many languages are, really

brittle panther Feb 3, 2021, 10:24 PM

#

I mean C is like the first actual OOP language.

wide maple Feb 3, 2021, 10:24 PM

#

at work I use rust and c# for a very few things. Java shouldnt ever be used in industry

brittle panther Feb 3, 2021, 10:24 PM

#

iirc

wide maple Feb 3, 2021, 10:24 PM

#

thats cursed

trail plume Feb 3, 2021, 10:24 PM

#

e n t e r p r i s e j a v a

lean gobletBOT Feb 3, 2021, 10:25 PM

#

java is used everywhere, lmao

tawdry narwhal Feb 3, 2021, 10:25 PM

#

Did your spacebar break, cat?

#

runs

trail plume Feb 3, 2021, 10:25 PM

#

ENTERPRISE

#

JAVA

#

MAN

brittle panther Feb 3, 2021, 10:25 PM

#

Why would you ever have to pay for a better Java?

lean gobletBOT Feb 3, 2021, 10:25 PM

#

support

wide maple Feb 3, 2021, 10:25 PM

#

trail plume p u s h t o m a s t e r

lets rewind to here again 👀

trail plume Feb 3, 2021, 10:26 PM

#

😄

lean gobletBOT Feb 3, 2021, 10:26 PM

#

if you are already paying for Oracle SQL licenses and support you might as well pay for java support

brittle panther Feb 3, 2021, 10:26 PM

#

Wait...

lean gobletBOT Feb 3, 2021, 10:26 PM

#

also pretty sure you can't just sell devices/software using oracle java without paying licensing fees

brittle panther Feb 3, 2021, 10:26 PM

#

That's dumb.

#

That's like saying the person who gave you the lumber for your house owns the license to your house...

civic valve Feb 3, 2021, 10:27 PM

#

Oracle vs Google

trail plume Feb 3, 2021, 10:27 PM

#

it's a software platform

civic valve Feb 3, 2021, 10:28 PM

#

altho that is about the java api

trail plume Feb 3, 2021, 10:28 PM

#

you can use the freely licensed openJDK distro

civic valve Feb 3, 2021, 10:28 PM

#

since google doesn't just ship the jvm

trail plume Feb 3, 2021, 10:28 PM

#

But, if you're running an enterprise level production setup, the oracle specific tools offer a lot of features for monitoring your environment and for support if/when shit hits the fan on a friday night

brittle panther Feb 3, 2021, 10:29 PM

#

¯_(ツ)_/¯

lean gobletBOT Feb 3, 2021, 10:30 PM

#

my father used to work for a company heavily relying on java and their oracle partnership for the software that they developed, shipped and managed for their customers (large energy companies) 👀

#

it's pretty common to not wanting to deal with database/jvm issues yourself lol

wide maple Feb 3, 2021, 10:31 PM

#

@brittle panther finished; but seriously- you should read the CONTRIBUTING.md for waterfall

brittle panther Feb 3, 2021, 10:32 PM

#

You see, I spent like half an evening trying to figure out how to do that and then you say it is easy as reading that? Bruh...

#

I'll have to look into it.

lean gobletBOT Feb 3, 2021, 10:33 PM

#

reading is overrated

brittle panther Feb 3, 2021, 10:33 PM

#

Oh. I was reading alright.

#

I read like 5 full Spigot conversations.

wide maple Feb 3, 2021, 10:34 PM

#

see- the waterfall-proxy folder is a fake git repo and the patches are the commits in it, whats applied over bungeecord

brittle panther Feb 3, 2021, 10:34 PM

#

Yeah. I understood that.

wide maple Feb 3, 2021, 10:34 PM

#

if downstream changes you dont have to painstakingly update the git refs or wiggle in changes

brittle panther Feb 3, 2021, 10:35 PM

#

I just didn't know how to do it for WaterFall.

wide maple Feb 3, 2021, 10:35 PM

#

./waterfall p

#

then edit what you want

brittle panther Feb 3, 2021, 10:35 PM

#

:/

#

I had to copy scripts from the internet for the Bungeecord... :/ Sad times.

wide maple Feb 3, 2021, 10:36 PM

#

commit it OR git stash it, then git rebase -i upstream/upstream, git stash pop, git add whatever, git commit amend, git rebase --continue

#

and then just rebuild the patches with ./waterfall rb

#

here is essentially what I did to update waterfall:

brittle panther Feb 3, 2021, 10:37 PM

#

Sorry. I don't speak git.

#

I'll need to learn it sooner or later, though.

wide maple Feb 3, 2021, 10:41 PM

#

# Get the repo
git clone --recursive --branch 1.17-changes-pre https://github.com/Xernium/Waterfall.git Snap21w05aWaterfall/
# --recursive: Also clone the submodules in one go, is a good habit to always specify
# --branch <branch> useful if your branch is not the tracked master branch

cd Snap21w05aWaterfall
./waterfall p

cd Waterfall-Proxy

< I edit my file> 

git stash
git rebase -i upstream/upstream
git stash pop
git add .
git commit --amend
git rebase --continue
cd ..
./waterfall rb

./waterfal b


# if everything works:
git add .
git commit 
git push origin

brittle panther Feb 3, 2021, 10:44 PM

#

Cool.

#

oof

#

It appears my ViaVersion doesn't work... :/ Well, that's dumb.

#

@wide maple if you want, you can fix this tomorrow. I'll be fine.

wide maple Feb 3, 2021, 10:53 PM

#

grr

#

youre keeping me up

#

sec

brittle panther Feb 3, 2021, 10:53 PM

#

y o u c a n w a i t

wide maple Feb 3, 2021, 11:01 PM

#

@brittle panther just mvn clean package my via fork

bleak current Feb 5, 2021, 11:56 AM

#

Hello. How can I get the player IP address with a non-deprecated method?
event.getConnection().getSocketAddress().toString(); returns /IP:PORT I have to parse this?

potent lichen Feb 5, 2021, 12:41 PM

#

you have to cast the SocketAddress to an InetSocketAddress

chilly coral Feb 5, 2021, 12:41 PM

#

the method is deprecated only because a "SocketAdress" can be something else than a "InetSocketAdress"

#

(the deprecated method does that too)

wide maple Feb 5, 2021, 3:24 PM

#

^

#

Can also be a *nix domain path

languid rapids Feb 6, 2021, 5:54 AM

#

anyone knows how to do this ?

#

and also to do when i hover over this i get some information about server or something?

lean gobletBOT Feb 6, 2021, 1:34 PM

#

just listen on the ping event and change that

static shuttle Feb 6, 2021, 1:35 PM

#

https://www.spigotmc.org/resources/serverlistplus.241/?__cf_chl_jschl_tk__=88679aa44dcb7d71b5cbd4db9fb06ca275f5c0df-1612618478-0-AdSgl6czOw0VLMJY1lE-bhgoGA6G_WLAH5K9x15VU0FZAf9SYZxKLdEATNEXnRmr8VIbOEfs-S1nBRX5DjE7F6v9t8-tyiFT-c1BPF-B52B4-2lf_apMbLXUnwxDQ2CaBHnsyfgS_E8Pp_QYWlC8sPkf767doFk76B7FFsk0HelN8jEOTWWh22hr6562a8qHu1mn2CPdtgGA5j7DKjaekNu4K0iTBsAFc0KHQvyK5b-rZlOc1TfJJyp3zDsbUChdENWXd4GIgJ8ek54aIkd_VsAKPJLs-OBHbDvs3JHsfJGXc6XQqmQHcodH86-8vGwpjQQzfCunQQ9-qwv3TWTe5jQ you can use this too

#

Wtf this link

wide maple Feb 6, 2021, 1:36 PM

#

cloudflare

lean gobletBOT Feb 6, 2021, 1:36 PM

#

just look at it before you copy/paste links lol

static shuttle Feb 6, 2021, 1:36 PM

#

Sorry I was on phone

lean gobletBOT Feb 6, 2021, 1:37 PM

#

I fail to see how that changes anything thonk

wide maple Feb 6, 2021, 1:37 PM

#

Doesn't matter

static shuttle Feb 6, 2021, 1:37 PM

#

Chat size are different on phone

#

Only 2 lines

lean gobletBOT Feb 6, 2021, 1:37 PM

#

ah

static shuttle Feb 6, 2021, 1:38 PM

#

languid rapids Feb 6, 2021, 3:14 PM

#

static shuttle https://www.spigotmc.org/resources/serverlistplus.241/?__cf_chl_jschl_tk__=88679...

thanks

shadow schooner Feb 6, 2021, 8:08 PM

#

Any plans for adding an endpoint to download latest versions of paper/waterfall?

trail plume Feb 6, 2021, 8:08 PM

#

no

#

Not viable to do with how the new system works in the first place

shadow schooner Feb 6, 2021, 8:15 PM

#

not viable?

#

Ah, are you not the developers of the API then

trail plume Feb 6, 2021, 8:15 PM

#

the API offers multiple files

shadow schooner Feb 6, 2021, 8:15 PM

#

mhm yes

trail plume Feb 6, 2021, 8:16 PM

#

The "latest" endpoints just offer so much horror to deal with in terms of caching and stuff along with people mis-using the latest endpoints that we figured that with v2 it wasn't worth it

#

it's pretty trivial to create a script which will query the latest version from the API and fetch it

shadow schooner Feb 6, 2021, 8:16 PM

#

Cache invalidation was that difficult?

trail plume Feb 6, 2021, 8:16 PM

#

but, to be able to download a file, you need to know the build number as that is in the filename itself

#

Cloudflare

#

what happens when we push multiple builds over the space of a few hours, etc

shadow schooner Feb 6, 2021, 8:17 PM

#

I see

trail plume Feb 6, 2021, 8:17 PM

#

We've only got so many caching rules and dealing with that mess was not worth it for the headaches it consistently caused

shadow schooner Feb 6, 2021, 8:18 PM

#

So the complication is with cloudflare, not the app itself.

#

Is your API using c#?

#

tbh, I wouldnt mind a build that is outdated by a day. It still saves me the effort of going in and manually grabbing the latest build, uploading it, setting permissions on it.

#

https://api.cloudflare.com/#zone-purge-files-by-cache-tags,-host-or-prefix

trail plume Feb 6, 2021, 8:20 PM

#

Basically, it's not an issue we care to solve

#

We don't wanna have to persistently blow caches

shadow schooner Feb 6, 2021, 8:20 PM

#

There is also an API for purging specific files. A bit more work, but a possibility.

#

Okay, then don't

trail plume Feb 6, 2021, 8:21 PM

#

Basically, there is little interest on our side trying to chase issues which can easily be solved with an extra singular query to the website

shadow schooner Feb 6, 2021, 8:21 PM

#

just say it's "today's selected latest build"

#

Ok.

#

Can I do it then

#

Which language is the API written in? PHP, C#, Java?

trail plume Feb 6, 2021, 8:22 PM

#

We have no interest in accepting such an addition

shadow schooner Feb 6, 2021, 8:25 PM

#

Still easier than running build tools I suppose.

#

Thousands of devs will have to reinvent the same automation script based on the new API though. Collectively is more efficient to do it in one place.

trail plume Feb 6, 2021, 8:26 PM

#

somebody already did, it's literally a 3 line script or something

shadow schooner Feb 6, 2021, 8:26 PM

#

oh hell yeah

#

where that baby at

trail plume Feb 6, 2021, 8:26 PM

#

some randomer named sulu posted it somewhere, uses jq to parse the json response from the API

outer cosmos Feb 6, 2021, 8:28 PM

#

And others random one did it too

shadow schooner Feb 6, 2021, 8:32 PM

#

May as well keep a repository of pre-made scripts, ya?

#

or some pins or sth

#

then again no one would look through em probably

outer cosmos Feb 6, 2021, 8:49 PM

#

shadow schooner May as well keep a repository of pre-made scripts, ya?

#paper-help message

That's for paper. You're free to adapt it for waterfall

copper nexus Feb 7, 2021, 1:20 PM

#

any notice for 1.16 support? (tag me pls)

chilly coral Feb 7, 2021, 1:34 PM

#

🤔

#

Waterfall already supports 1.16.x

#

@copper nexus

wide maple Feb 7, 2021, 6:30 PM

#

#545 is a complete train wreck

twilit pewter Feb 7, 2021, 6:32 PM

#

thats why 572 is there

#

😄

#

but yeah, I'm having issues with 545 as well

wide maple Feb 7, 2021, 6:38 PM

#

#572 doesn’t fix the memory leak caused by it

twilit pewter Feb 7, 2021, 6:38 PM

#

it's a bandaid fix

#

but at least it helps

#

we're having a lot of players kicked because of that bug^^

wide maple Feb 7, 2021, 6:39 PM

#

My problem is that we silence it with this without fixing it

#

I’ll give my approval or amend something once I’ve looked over it in a few min

twilit pewter Feb 7, 2021, 6:40 PM

#

That would be awesome

#

I know that it doesnt fix the issue

wide maple Feb 7, 2021, 6:40 PM

#

Do you have an easy way to reproduce it?

#

That’s gonna be the nail in the coffin if I can’t test it

twilit pewter Feb 7, 2021, 6:41 PM

#

Yea

wide maple Feb 7, 2021, 6:41 PM

#

Do tell

#

thonk

twilit pewter Feb 7, 2021, 6:43 PM

#

We added a command to print the registered relay messages for a player. It seems like you just have to have a few fabric mods installed, and every time you switch the server on the network with the /server command (or some other way) it gets added again

#

https://waste.cutiepie.at/5gafx6t125gefgr

wide maple Feb 7, 2021, 6:47 PM

#

Ah I see. Bungeecord doesnt account for that

twilit pewter Feb 7, 2021, 6:49 PM

#

https://waste.cutiepie.at/aqtptoqxn2f1gha

#

better example

wide maple Feb 7, 2021, 6:51 PM

#

this entire problem is completely insane

#

The proxy doesnt need to track it

#

well not for the relevant versions anyway

twilit pewter Feb 7, 2021, 6:52 PM

#

https://github.com/SpigotMC/BungeeCord/commit/1bbbfdb0d5ae87444a9f92c4f175846d04678d98

wide maple Feb 7, 2021, 6:53 PM

#

god damnit this is so stupid

#

I want a light-proxy mode config option to disable all of this nonsense rewriting

twilit pewter Feb 7, 2021, 6:53 PM

#

As of build 811 however, after the server change, WECUI does not work. The reason is that the server rejects the plugin message because it did not receive any REGISTER packets for the plugin channel. What Bungee did before was that it logged all the register packets and send them again when the user switches the server. The said commit however removes that functionality.
The description for the commit is "Remove artifacts from legacy forge support.". But this functionality is not only required for Forge, it is required for every mod that uses plugin channels, which are in fact a part of vanilla Minecraft.

#

makes sense imo

wide maple Feb 7, 2021, 6:54 PM

#

on 1.16+ or with the slow switching method you literally just need the current active channel

#

so this again all depends on the switching method

#

and yet better you cant use the fast switching method with fabric at all

#

you can but it breaks things because its uncalled for

twilit pewter Feb 7, 2021, 6:55 PM

#

i have no idea what you are saying makes sense

wide maple Feb 7, 2021, 6:55 PM

#

Imagine this:

#

md_5 does the following since 1.5(?) send a fake double respawn and clear all active effects of the player

#

this makes the switch quick

#

well it used to at least

#

the clients state does not get reset

#

since 1.6 you can also just send a JoinGame again to RESET the client state and registry followed by a respawn to place the player in game

#

since 1.16 this is mandatory

#

given that mods don't resync correctly if the client is not reset

#

this is a supremely stupid issue to have

twilit pewter Feb 7, 2021, 6:58 PM

#

ah okay! I think I understand now

#

but wtf

wide maple Feb 7, 2021, 6:58 PM

#

wide maple md_5 does the following since 1.5(?) send a fake double respawn and clear all ac...

this necessitates the proxy to rewrite all entity IDs because its not reset

twilit pewter Feb 7, 2021, 6:58 PM

#

If this functionality has been there since 1.6 and is required with 1.16, why don't we remove the old functionality?

wide maple Feb 7, 2021, 6:59 PM

#

Cause md_5'

#

thats ripping 40% of the internals out

twilit pewter Feb 7, 2021, 6:59 PM

#

I see

wide maple Feb 7, 2021, 6:59 PM

#

and on bungeecord its still objectively slower

twilit pewter Feb 7, 2021, 6:59 PM

#

and if we would just revert that commit we would still have issues because the client is not reset

wide maple Feb 7, 2021, 6:59 PM

#

which version is that fabric instance from?

twilit pewter Feb 7, 2021, 7:00 PM

#

Minecraft 1.16.4 if thats what you mean

wide maple Feb 7, 2021, 7:00 PM

#

thats what I mean

#

this issue should not exist

#

https://github.com/SpigotMC/BungeeCord/pull/2861

#

this. This again. It will haunt me till the day I die

twilit pewter Feb 7, 2021, 7:01 PM

#

let me check what Bungee version we are running

#

git:BungeeCord-Bootstrap:1.16-R0.4-SNAPSHOT:9c078b7:1539 by md_5

wide maple Feb 7, 2021, 7:02 PM

#

wide maple this issue should not exist

IT EXISTS because nobody is thinking right

#

I will make zzzCat happy with the patch ill propose in a few min.

#

I hope

languid rapids Feb 7, 2021, 7:02 PM

#

Hi i got question is querying some site api is bad in command?

twilit pewter Feb 7, 2021, 7:03 PM

#

wide maple I will make zzzCat happy with the patch ill propose in a few min.

that would be epic, thanks

#

you'd make me happy at least^^

wide maple Feb 7, 2021, 7:06 PM

#

twilit pewter that would be epic, thanks

Here is my problem:
I can either make a config option to disable all bungee meddling in the connection

#

or check rewriting to see if relaying should happen

#

this will not fix the issue

#

but it shouldnt

#

we can still pull in what gerry proposed

twilit pewter Feb 7, 2021, 7:07 PM

#

what would the effects of that config option be?

wide maple Feb 7, 2021, 7:09 PM

#

Disable entity meta rewriting, disable tab list rewriting, disable channel relaying, disable fast switching and disable clear/resend of stored connection attributes

#

We could essentially call that velocity-mode cause thats how velocity works

#

notlike

twilit pewter Feb 7, 2021, 7:09 PM

#

That sounds like it might break a lot of plugins..

wide maple Feb 7, 2021, 7:09 PM

#

Surprisingly I couldnt think of anything that would break plugins

#

Entity meta rewriting is only required for fastswitching

#

so is channel relaying

#

and channel attributes

#

and the tablist rewriting is bungees way of messing with online/offline mode

#

that could remain active

#

that could also break plugins but that already has a config option

wide maple Feb 7, 2021, 7:15 PM

#

twilit pewter That sounds like it might break a lot of plugins..

we were here before #waterfall-help message same systematic issue

#

notlike

#

God damnit

#

@twilit pewter has my stamp of approval for now. I don't have the energy left to think the TODOs through I left on it

copper nexus Feb 7, 2021, 8:22 PM

#

chilly coral Waterfall already supports 1.16.x

I reafer with mods, sorry xD

weary grove Feb 7, 2021, 8:23 PM

#

copper nexus I reafer with mods, sorry xD

Fabric should work, Forge won't work with any proxy.

copper nexus Feb 7, 2021, 8:23 PM

#

weary grove Fabric should work, Forge won't work with any proxy.

F xD

wide maple Feb 7, 2021, 8:23 PM

#

Yea forge 1.13+ is turning out to be worse and worse

copper nexus Feb 7, 2021, 8:23 PM

#

for forge would be supported?

weary grove Feb 7, 2021, 8:24 PM

#

If you want Forge support, there is some in-progress work but it's targeting Velocity.

wide maple Feb 7, 2021, 8:24 PM

#

I tossed what I had till now in the bin twice

#

This is all stupid

copper nexus Feb 7, 2021, 8:24 PM

#

weary grove If you want Forge support, there is some in-progress work but it's targeting Vel...

and not waterfall?

weary grove Feb 7, 2021, 8:24 PM

#

correct, because Velocity is a modern platform

#

it's not having to build atop waste

copper nexus Feb 7, 2021, 8:25 PM

#

what is the github?

wide maple Feb 7, 2021, 8:25 PM

#

The logic it requires is next to impossible to mod into bungeecord cleanly anyway. Also the WIP is not public

#

Well not yet

weary grove Feb 7, 2021, 8:25 PM

#

It's still a WIP and the work isn't public yet.

wide maple Feb 7, 2021, 8:25 PM

#

sad_cat_joinha

copper nexus Feb 7, 2021, 8:25 PM

#

F

wide maple Feb 7, 2021, 8:25 PM

#

Tux if you knew how much time I wasted till now on this

copper nexus Feb 7, 2021, 8:25 PM

#

velocity would work with bungeecord plugins? xD

weary grove Feb 7, 2021, 8:25 PM

#

Nope

wide maple Feb 7, 2021, 8:26 PM

#

At this point I just want to implement a switch server packet

weary grove Feb 7, 2021, 8:26 PM

#

Forge 1.12.2 and below works with Waterfall and Velocity, Fabric will work with both Waterfall and Velocity.

wide maple Feb 7, 2021, 8:26 PM

#

weary grove Forge 1.12.2 and below works with Waterfall and Velocity, Fabric will work with ...

Well there is #545 notlike

weary grove Feb 7, 2021, 8:26 PM

#

...might as well just switch to Fabric, IMO it's the better platform.

copper nexus Feb 7, 2021, 8:26 PM

#

and velocity is not possible to download?? xD

wide maple Feb 7, 2021, 8:26 PM

#

For fabric

weary grove Feb 7, 2021, 8:26 PM

#

https://velocitypowered.com/downloads

#

Velocity is free to download, it's open source too.

copper nexus Feb 7, 2021, 8:27 PM

#

okey

ornate jasper Feb 9, 2021, 2:16 AM

#

Has it been considered to implement an uuid cache like the minecraft server's one? thinkingwithblobs

#

probably would be better than having multiple plugins contact mojang to know someone's uuid when theyre not online

potent lichen Feb 9, 2021, 2:33 AM

#

if you like, make a common API plugins can use to lookup names and UUIDs

#

then try to get people to adopt that API

#

kind of like Vault, except that you should use proper documentation for your API, and don't mess things up as Vault is kind of messed up

dapper temple Feb 9, 2021, 4:25 AM

#

isn't that kind of what SquirrelID is

#

https://github.com/EngineHub/SquirrelID

wide maple Feb 9, 2021, 5:18 AM

#

From what I’ve seen, people commonly use LuckPerms for that purpose

potent lichen Feb 9, 2021, 1:09 PM

#

coupling to luckperms is a bad idea in my opinion

#

for this purpose, at least

warm flare Feb 9, 2021, 3:57 PM

#

can I host a waterfall server with many instances of minecraft servers that don't bind to ports

#

so that all the ports on a machine won't be used up

#

but it can still forward requests to servers

outer cosmos Feb 9, 2021, 4:00 PM

#

Aren't 65_000 - 1024 enough?

wide maple Feb 9, 2021, 4:22 PM

#

@warm flare what exactly are you trying to do here? If you don’t bind something to the port it’s still only able to be served by one service at a time

warm flare Feb 9, 2021, 4:23 PM

#

outer cosmos Aren't 65_000 - 1024 enough?

I guess yes

ornate jasper Feb 9, 2021, 5:49 PM

#

potent lichen for this purpose, at least

I think it would also be bad for other plugins to depend on an api like that

#

Because it also means the end user would have to install that plugin because it's gotta update it's database

#

imo it should be built in into the server like on the vanilla one

lean gobletBOT Feb 9, 2021, 5:55 PM

#

I mean, most plugins just store known UUIDs themselves if they really need them

wide maple Feb 10, 2021, 4:35 PM

#

I don’t agree with the modifications by Janmm14. If we are going minimal diff then this just isn’t right

#

Looking at it

#

I disagree with a lot of the sentiment

vestal robin Feb 10, 2021, 5:01 PM

#

@wide maple I already tried to minimize diff. Do you have an idea of how to reduce the diff further? I am happy to change stuff as needed.

wide maple Feb 10, 2021, 5:02 PM

#

see my review

#

@vestal robin I was going for an additional constructor in that once case; and a method that calls the original one with the original signature and a false/true hardcoded

vestal robin Feb 10, 2021, 5:09 PM

#

aka add public Base() {this(false);}?

wide maple Feb 10, 2021, 5:11 PM

#

no; I was going for not having a second base altogether but I need to at it again to see what I was thinking there

#

Kina busy right now but I’ll get back to it later

vestal robin Feb 10, 2021, 5:11 PM

#

ok

brazen forum Feb 11, 2021, 5:22 PM

#

Does the Bungee plugin messaging channel work the same for Waterfall?

potent lichen Feb 11, 2021, 5:45 PM

#

yes

brazen forum Feb 11, 2021, 8:19 PM

#

I'm trying to do a GetServer request from my Waterfall network using plugin messaging channel. Would "SomeSubChannel" below just be GetServer?

if (subchannel.equals("SomeSubChannel")) {

#

    @Override
    public void onPluginMessageReceived(String channel, Player player, byte[] message) {
        if (!channel.equals("BungeeCord")) {
            return;
        }
        ByteArrayDataInput input = ByteStreams.newDataInput(message);
        String subchannel = input.readUTF();

        if (subchannel.equals("SomeSubChannel")) {
            String servername = input.readUTF();
        }
    }

lean gobletBOT Feb 11, 2021, 8:19 PM

#

yes

brazen forum Feb 11, 2021, 8:19 PM

#

Thank you

vestal robin Feb 11, 2021, 8:38 PM

#

@wide maple

brazen forum Feb 12, 2021, 6:16 PM

#

I'm using BungeeCord plugin messaging channel to GetServer. My command class doesn't wait for the server to respond though, so by the time I set String serverType on my onPluginMessageReceived() method, the command class has already called the variable which returns null. What's the best way to wait for this variable to get set before proceeding?

echo vault Feb 12, 2021, 6:22 PM

#

block and wait for it or make it run after (e.g. with something like CompletableFuture#thenRun)

lean gobletBOT Feb 12, 2021, 6:27 PM

#

you most likely don't want to block unless you are running this on your own thread and know how to properly manage threading 👀

wide maple Feb 12, 2021, 8:55 PM

#

vestal robin <@!371398411867521024>

I’ll get to it tomorrow morning. I have a 53h work week behind me and I need some rest and some time to catch up

trail plume Feb 12, 2021, 9:00 PM

#

You can't wait, and blocking for stuff like that is dumb as you'll deadlock the server if you're blocking in the event loop

#

Just use a callback design or something

brazen forum Feb 12, 2021, 9:10 PM

#

The problem with a callback is that this same plugin message channel will be used for a variety of different commands, not just one.

trail plume Feb 12, 2021, 9:11 PM

#

So, you gotta factor that I your design or just use caching or something and update the local data periodically

brazen forum Feb 12, 2021, 9:17 PM

#

trail plume So, you gotta factor that I your design or just use caching or something and upd...

Is there another way to get the name of the Bungee server someone is on without using the plugin message channel?

trail plume Feb 12, 2021, 9:17 PM

#

No

#

Not unless you make your own system for it

humble perch Feb 12, 2021, 10:11 PM

#

I'm trying to make a plugin that plays a sound when you disable another player's sheild. Does anyone know how I would go about doing this?

trail plume Feb 12, 2021, 10:11 PM

#

wrong channel

humble perch Feb 12, 2021, 10:12 PM

#

whoops

vestal robin Feb 12, 2021, 11:19 PM

#

wide maple I’ll get to it tomorrow morning. I have a 53h work week behind me and I need som...

I can completely understand that, take your time. I've also improved the patch at some points already.

brazen forum Feb 13, 2021, 3:15 AM

#

Can I create a sort of universal callback in the onPluginMessageReceived() method? I have multiple methods that will be calling the same subchannel like GetServer. But since I can't pass variables into onPluginMessageReceived(), I'm not sure how to specify which method to run in the callback.

trail plume Feb 13, 2021, 3:16 AM

#

you could shove a callback into a map or something

#

it's not transactional, however

#

there is no promise of when you'll get a callback

#

if you need a reliable system, you wanna basically create something which is capable of tracking that stuff better or some form of caching

brazen forum Feb 13, 2021, 3:44 AM

#

trail plume if you need a reliable system, you wanna basically create something which is cap...

Could I also create a plugin for the BungeeCord server to create a sort of communication system?

trail plume Feb 13, 2021, 3:44 AM

#

yes

brazen forum Feb 13, 2021, 3:45 AM

#

I'm trying to visualize how the BungeeCord plugin and the Bukkit plugin would communicate.

trail plume Feb 13, 2021, 3:45 AM

#

the plugin message channel is a system mojang added to the game for things to communicate over arbitary messages

#

I personally just stuff json around my own custom channel

brazen forum Feb 13, 2021, 3:48 AM

#

Is there an easy example of two plugins communicating between Bungee and Bukkit?

#

I just don't really know enough about MC plugins yet to visualize it haha

trail plume Feb 13, 2021, 3:48 AM

#

I'm sure if you googled there are dozens of OSS plugins doing that stuff, and maybe some tutorials

brazen forum Feb 13, 2021, 3:49 AM

#

Okay great, thank you!

#

What does OSS stand for?

trail plume Feb 13, 2021, 3:49 AM

#

open source software

brazen forum Feb 13, 2021, 3:50 AM

#

Okay, thank you, really appreciate the help!

chilly coral Feb 13, 2021, 10:37 AM

#

https://www.spigotmc.org/wiki/bukkit-bungee-plugin-messaging-channel

wide maple Feb 13, 2021, 11:10 PM

#

vestal robin I can completely understand that, take your time. I've also improved the patch a...

After a lot of testing I want to redesign the underlying channel initialization process to more closely resemble that of velocity. I’ll finish amending what I need to tomorrow but I hope I can obsolete all of this altogether. It might break some bungee plugins that use internals in the end. We will see.

#

Sigh I almost forgot adventure

wide maple Feb 14, 2021, 5:45 PM

#

@vestal robin the race condition i was talking about- ever tried a modded client with it? When the handlers swap for the next connection stage this one is discarded but the handler is left open. Don’t see a good way to fix it either- at this point it’s still a bad idea to add another timeout mechanism into that, there is already one for that. Not to mention when this one gets reached the existing global one will fire on a null object unless it’s freed before

#

Side note

#

I’m investigating a much more serious attack vector on bungeecord type systems at the moment

#

notlike

compact topaz Feb 15, 2021, 12:04 PM

#

funny

bleak current Feb 16, 2021, 4:27 PM

#

someone know
how can I change that
into custom one?

wide maple Feb 16, 2021, 5:12 PM

#

Not supported here, but look into how the minecraft brand custom plugin message works

pallid horizon Feb 19, 2021, 12:11 PM

#

is the API built in the waterfall jar ?

trail plume Feb 19, 2021, 6:09 PM

#

Well, I mean, it has to be, but, like, use maven or gradle, see the readme, maven repo in the welcome channel or something

pallid horizon Feb 20, 2021, 12:17 AM

#

is there a method that returns all servers in bungeecord ?

trail plume Feb 20, 2021, 12:17 AM

#

it's stored in the configuration class iirc

pallid horizon Feb 20, 2021, 12:18 AM

#

how can i access it ?

#

i basically want to loop through all servers

trail plume Feb 20, 2021, 12:18 AM

#

Check ProxyServer, should have something like getConfig or something

pallid horizon Feb 20, 2021, 12:19 AM

#

returns a map though

trail plume Feb 20, 2021, 12:19 AM

#

yea

pallid horizon Feb 20, 2021, 12:19 AM

#

im kinda new to this api

#

what is a server info object ?

trail plume Feb 20, 2021, 12:19 AM

#

.jd

lean gobletBOT Feb 20, 2021, 12:19 AM

#

https://papermc.io/javadocs/

trail plume Feb 20, 2021, 12:20 AM

#

it's the info of the server

#

has the methods for interacting with it, etc

pallid horizon Feb 20, 2021, 12:20 AM

#

and i can get a server by a string ?

trail plume Feb 20, 2021, 12:20 AM

#

Yes, the string in that map is the name

pallid horizon Feb 20, 2021, 12:21 AM

#

alright, cool and ty

bleak current Feb 20, 2021, 11:29 AM

#

Is anyone going to fix the javadocs anytime soon?

#

Delombok isn't happening

#

Example https://papermc.io/javadocs/waterfall/

#

There are none of the methods there should be

signal mica Feb 20, 2021, 2:46 PM

#

Are there limits of how much tasks the async scheduler can handle? For every player joining I will start 3 async tasks. Lets say I have 100 players joining at one time, I will create 300 async tasks queued. Is it possible to overwhelm the async scheduler?

potent lichen Feb 20, 2021, 2:48 PM

#

There are limits to how much native memory your server has, though 300 threads is nowhere near that. Nonetheless, from a performance perspective, I'd not suggest creating 300 tasks at once.

#

Depending on your use case, you can group your work into 1 async task per player, and you can use a thread pool with a different thread management policy

signal mica Feb 20, 2021, 5:47 PM

#

potent lichen Depending on your use case, you can group your work into 1 async task per player...

Thanks for your Answer. I will take note on that and might implement something like that in the near future.

wide maple Feb 20, 2021, 6:51 PM

#

Future is a good point

#

You can chain futures to avoid having to deal with your threads yourself

#

That’s what I do and it works reasonably well

trail plume Feb 20, 2021, 8:38 PM

#

Is anyone going to fix the issue soon nobody bothered to report?!

#

I'll throw it on my to-do list, but, no promises on when

wide maple Feb 20, 2021, 8:46 PM

#

@ zzzCat not entirely true

trail plume Feb 20, 2021, 8:46 PM

#

Hm?

wide maple Feb 20, 2021, 8:46 PM

#

#waterfall-dev message we were there

#

But I didn’t find an easy way to fix it at the time

trail plume Feb 20, 2021, 8:48 PM

#

Well, I totally forgot

wide maple Feb 20, 2021, 8:48 PM

#

Same here

trail plume Feb 20, 2021, 8:48 PM

#

We have an issue tracker for a reason

#

🤷‍♂️

potent lichen Feb 20, 2021, 9:06 PM

#

What is the purpose of this BungeeCord commit? https://github.com/SpigotMC/BungeeCord/commit/ebec582ce22a6e9876fe3c4b3868cd9651c4e767 Java 6 and Java 7 compatibility for a small part of bungeecord?

trail plume Feb 20, 2021, 9:07 PM

#

javadoc probs changed in newer versions or something

#

Well, I mean, it did

civic valve Feb 20, 2021, 9:41 PM

#

that isn't an event

potent lichen Feb 20, 2021, 9:44 PM

#

there are a handful of netty threads which do most things

civic valve Feb 20, 2021, 9:44 PM

#

that event blocks the connection

#

but it will not hault your proxy

#

it's very hard to freeze your proxy

#

i don't think you can access it to a point where you can hault execution for other players

trail plume Feb 20, 2021, 9:46 PM

#

general gist is that asume that pretty much anything which isn't "Async" will block the event loop

civic valve Feb 20, 2021, 9:47 PM

#

it should only prevent that login from continuing iirc

trail plume Feb 20, 2021, 9:49 PM

#

Well, I thiiink auth is done on another thread

#

But, in general, the way bungee handles all of it's network stuff is pretty much shit

civic valve Feb 20, 2021, 9:49 PM

#

how do you think other servers manage

#

mojang auth isn't rate limited because otherwise every server with a shit ton of players wouldn't work

#

iirc they take player ip address in the MJ auth endpoint

#

they may ratelimit per ip address on their side

#

just like they do for login

wide maple Feb 20, 2021, 9:51 PM

#

Mojang doesn’t rate limit if the request is valid. Any others do count towards a rate limit

#

Which is why spam type attacks are more or less effective even if they don’t drown the proxy

#

There is sadly no real easy way to fix that

#

@bleak current careful. There is a timeout handler on the client for that. You can’t hold it for too long

#

I mean

#

I profile based on accounts before addresses

#

notlike

#

No- checking their account against known swarm or compromised accounts. Also a factor is the mc statistics data and account age and actions

#

Can’t reveal too much

#

I can neither deny nor prove that this exists

#

None really. But there is a list of old compromised accounts still out there

#

I’d wager about 6-8%

potent lichen Feb 20, 2021, 10:00 PM

#

there aren't hundreds of millions

civic valve Feb 20, 2021, 10:00 PM

#

once the microsoft account migration begins that number goin way down

trail plume Feb 20, 2021, 11:58 PM

#

it is

#

public class LoginEvent extends AsyncEvent<LoginEvent> implements Cancellable

#

yes

sage cradle Feb 21, 2021, 9:19 AM

#

has waterfall been patched to correctly respond to LoginPayloadRequests (well, in a way matching the vanilla client?)

wide maple Feb 21, 2021, 2:30 PM

#

sage cradle has waterfall been patched to correctly respond to LoginPayloadRequests (well, i...

Elaborate on what you mean? Login payloads can’t reasonably be used with proxies as there is no way to re-negotiate that

sage cradle Feb 21, 2021, 5:28 PM

#

@wide maple vanilla client responds to every login payload with a "failed" response, bungee currently doesn't respond at all - I tossed up a PR to bungee fixing the issue

wide maple Feb 21, 2021, 5:53 PM

#

@sage cradle was it merged? If it was I’ll pull the update to waterfall in a few

#

Or if it wasn’t link it here so I can rebase it onto waterfall

trail plume Feb 21, 2021, 5:54 PM

#

https://github.com/SpigotMC/BungeeCord/pull/3041

sage cradle Feb 21, 2021, 5:55 PM

#

it's a tiny fix, i don't mind giving md a little while to respond - but if he doesn't it'd be great to get that in waterfall

#

(also thanks cat, am still on mobile so grabbing links is tricky)

warm storm Feb 21, 2021, 10:01 PM

#

Hello! Sorry if here is not the right place for this kind of question, however, how can I start a fork of waterfall? Do you have anything for anyone who's going to fork or use waterfall's own jar?

trail plume Feb 21, 2021, 10:02 PM

#

fork travertine

warm storm Feb 21, 2021, 10:04 PM

#

Why?

trail plume Feb 21, 2021, 10:04 PM

#

because it's a fork of waterfall