#waterfall-dev | PaperMC | Page 9

bright imp Oct 16, 2023, 7:03 PM

#

i'have forget how that's work but just the proxy can transfert player betwwen server? (so spigot plugin can't?)

#

ah with plugin message maybe?

#

if is that i have to be sure that i manage all request for bungee changement and allow the player to send the plugin message after that i'hve save the inventory ?

#

ah yes i think to connect plugin send plugin message from the player's client and he send connect to proxy but if a plugin make send pluginmessage i can't knwo (please confirm) so i have to be sure that all plugin message conexion will be managed by my plugin (like this methode:

save inventory: when is good
send plugin message

but there are a risk if player'inventory got changee after inventory save?

frigid hazel Oct 16, 2023, 7:19 PM

#

Could anyone answer this perhaps?

#

It's probably very basic, but I've tried a few things and can't figure it out hahaha

bright imp Oct 16, 2023, 7:19 PM

#

you need a player to send plugin message

frigid hazel Oct 16, 2023, 7:20 PM

#

I think I just need a Server, not sure how to get that though

#

Perhaps I can do player.getServer()...

#

or is there a better way to predefine servers?

trail plume Oct 16, 2023, 7:22 PM

#

if you want to get the server somebody is on in order to send a message to them then yea, that is how you'd get it

bright imp Oct 16, 2023, 7:22 PM

#

frigid hazel I think I just need a Server, not sure how to get that though

I asked myself the same question as you some time ago but I don't remember the answer (the difference between server.sendata and player.senddata) but what I'm sure of is that you're obliged to have a co player

trail plume Oct 16, 2023, 7:22 PM

#

bright imp ah yes i think to connect plugin send plugin message from the player's client an...

That's why you'd try to put them in some form of limbo on the source server, in order to minimise the risk something modifies it

#

I mean, sending data to the player would send it to the player, and not the server they're connected to

bright imp Oct 16, 2023, 7:22 PM

#

what is limb?

trail plume Oct 16, 2023, 7:23 PM

#

i.e. remove them from the world

frigid hazel Oct 16, 2023, 7:23 PM

#

I'm trying to do something like player.getServer().sendData()

Basically I need to send a request to the bungee, check if they're authenticated, if so, it sends True or something

bright imp Oct 16, 2023, 7:23 PM

#

trail plume i.e. remove them from the world

ah start chargemnt dispaly?

frigid hazel Oct 16, 2023, 7:23 PM

#

this could be way too slow though :P

#

Would it be too slow? I need to cancel an event if they're not authenticated, like a move event or something like that

trail plume Oct 16, 2023, 7:26 PM

#

or you represent that state using a boolean in whcih you message over the network

frigid hazel Oct 16, 2023, 7:26 PM

#

Yeah, I think that's kinda what I'm thinking

trail plume Oct 16, 2023, 7:26 PM

#

plugin messages are not transactional, etc

frigid hazel Oct 16, 2023, 7:26 PM

#

trail plume plugin messages are not transactional, etc

I was just gonna listen for "UUID: True" if they're authenticated from the bungee

#

then a bit of regex

bright imp Oct 16, 2023, 7:26 PM

#

frigid hazel I'm trying to do something like player.getServer().sendData() Basically I need ...

doc are not 'clarity" about that so i'hve askd md_5 about it. server.sendata don' have difference but it choose a random player and if there are no online player the request will be queed (and player.send data will be lost)

bright imp Oct 16, 2023, 7:28 PM

#

trail plume i.e. remove them from the world

i can make a player leave his world?

trail plume Oct 16, 2023, 7:28 PM

#

without modifactions to the server, no

bright imp Oct 16, 2023, 7:29 PM

#

and for your limb I have to stop him from being able to interact with his inventory so what is the best way?

trail plume Oct 16, 2023, 7:30 PM

#

I mean, there is no best way to do this

#

I don't know anybody who has dealt with this in the more "perfect" of manners

bright imp Oct 16, 2023, 7:32 PM

#

do you know how most plugins work? or the most populate methode?

trail plume Oct 16, 2023, 7:33 PM

#

as I said, they just wait for some period of time on the new server and pray that the data saved in time

bright imp Oct 16, 2023, 7:36 PM

#

ah okay because on player leave i can get inventory but a simple problem with communciation and duplication bug.

I think i have to do it;

but you know if its possible to make a player inventory'iinvulnerable?

trail plume Oct 16, 2023, 7:36 PM

#

No, it's not

#

hence why I keep saying limbo

#

but, there is a reason those plugins do the "just wait and pray that the data saved in time"

#

Some add some locking mechanism to try to reduce the risks, but, given the lack of a proper communication system, stuff gets screwy

#

Like, theres so many unsolved issues here, that really, glhf

frigid hazel Oct 16, 2023, 7:39 PM

#

Hmm, what I'm thinking may not be the most effective way of doing it. I'll quickly go through what I'm thinking of doing.

I'm going to hook a Discord bot into the proxy plugin and handle the authentication command, codes, and all that in the proxy plugin. Everytime a user joins/moves, it will check to see if they're authenticated, if they are, it doesn't do anything. If they aren't authenticated, it cancels the event.

To check if they're authenticated, I was going to do a message from the spigot plugin with something like "Check: UUID" and to respond to that, I would do something like "True: UUID" (if authenticated).

I'm aware this would be much easier on just a lobby spigot plugin instead of network-wide, but I would like for the option to allow people to join any server they want, not through the lobby using subdomains. If it's not a feasible option, then I'll probably just revert back to what I had prior to trying to do this.

#

Keep in mind, authentication is only used by staff, so it's not going to be running for every single player

bright imp Oct 16, 2023, 7:40 PM

#

trail plume Like, theres so many unsolved issues here, that really, glhf

else using player prelogin event (check database and add date of last modif so if date is greater than x kick the player)

#

what is the timeout-time for a client before give up login?

trail plume Oct 16, 2023, 7:54 PM

#

you have like 30 seconds from connection to in the world, more or less

#

with a whole host of dozen caveats, etc

bright imp Oct 16, 2023, 7:58 PM

#

trail plume with a whole host of dozen caveats, etc

What ? Dozen caevats? What is ?

trail plume Oct 16, 2023, 7:58 PM

#

the client has to login

#

recieve chunks

#

respond to the keepalive packet in time or it gets dc'd, etc

bright imp Oct 16, 2023, 8:00 PM

#

So using playerasyncprelogin event i have 20/30 sec to get the new inveotrh on the db ? (I check if the data is refreshed every 5 seconds and ar 25 i kick the player)

trail plume Oct 16, 2023, 8:00 PM

#

MahiruShrug

frigid hazel Oct 16, 2023, 8:04 PM

#

frigid hazel Hmm, what I'm thinking may not be the most effective way of doing it. I'll quick...

Any thoughts on what I should do?

bright imp Oct 16, 2023, 8:07 PM

#

trail plume <:MahiruShrug:785807604240351254>

How i have to take it ?

wicked lantern Oct 23, 2023, 4:55 AM

#

trail plume <:MahiruShrug:785807604240351254>

Do you have any idea why getHost() is deprecated? It is from the InetSocketAddress

quaint musk Oct 24, 2023, 1:32 AM

#

Hey I am getting this error when I try to join my 1.20.1 server from the latest version of waterfall, any one know the issue? https://paste.learnspigot.com/uhinodosur.lua

(Ping if you reply)

wicked lantern Oct 24, 2023, 2:13 AM

#

quaint musk Hey I am getting this error when I try to join my 1.20.1 server from the latest ...

Your plugin "bungeepackfix" seems to be outdated or broke, it's trying to use a method that does not exist

hidden ivy Oct 24, 2023, 6:33 AM

#

So there is this weird problem, when i cancel a ChatEvent proxy-sided, when the player the cancelled message was from sends another message they get kicked because of an invalid chat signature... any ideas on how to fix this?

trail plume Oct 24, 2023, 12:41 PM

#

Basically, you can't

potent lichen Oct 24, 2023, 1:17 PM

#

hidden ivy So there is this weird problem, when i cancel a `ChatEvent` proxy-sided, when th...

Switch to Velocity then install SignedVelocity.

#

If you can't use Velocity, you'll have to adapt SignedVelocity to BungeeCord.

wicked lantern Oct 24, 2023, 3:48 PM

#

potent lichen If you can't use Velocity, you'll have to adapt SignedVelocity to BungeeCord.

There is already similar stuff

#

I think its not proper say switch to velocity here. Probably he haves already build a sytem around it

trail plume Oct 24, 2023, 3:56 PM

#

Not aware of any "similar stuff"

wicked lantern Oct 24, 2023, 9:07 PM

#

trail plume Not aware of any "similar stuff"

There is a spanish discord where it exists

wicked lantern Oct 25, 2023, 12:32 AM

#

You must use redis i guess

#

It's a system that is used to store stuff on table hashes

#

If you don't know, probably you'd like to use some plugin that does this

#

https://github.com/WiIIiam278/HuskSync

wind dove Oct 25, 2023, 6:21 PM

#

is it possible to choose the player used to send a plugin message to the backend servers?

trail plume Oct 25, 2023, 8:58 PM

#

Doesn't the API expose the players server connection?

reef minnow Oct 26, 2023, 1:39 PM

#

is the locale loaded (via ProxiedPlayer#getLocale) already present in the LoginEvent?

lean gobletBOT Oct 26, 2023, 1:40 PM

#

I don't think so

#

afaik the player settings packet is only sent after the player joined the game

trail plume Oct 26, 2023, 1:42 PM

#

No, LoginEvent is fired long before the client sends that info

#

in 1.20.2, it's sent before you join the world, before that, it's sent sometime after

reef minnow Oct 26, 2023, 1:48 PM

#

it looks like it is loaded in the PostLoginEvent

lean gobletBOT Oct 26, 2023, 1:49 PM

#

most likely only works in 1.20.2 if you care about older versions

reef minnow Oct 26, 2023, 1:50 PM

#

is there a better event i could listen to?

#

idealy an async event

lean gobletBOT Oct 26, 2023, 1:50 PM

#

aren't all events async on bungee/waterfall? or are they synced in a queue?

#

but SettingsChangedEvent would be the one

potent lichen Oct 26, 2023, 1:51 PM

#

Not all are AsyncEvent in a way that enables the intention system. But I believe they are asynchronous in that sense.

lean gobletBOT Oct 26, 2023, 1:51 PM

#

ah, right, I always forget about that system

potent lichen Oct 26, 2023, 1:52 PM

#

The path to firing events from EventBus is unsychronized, so they could totally fire in parallel, I think.

lean gobletBOT Oct 26, 2023, 1:52 PM

#

unfortunately the SettingsChangedEvent on bungee is extremely basic compared to other event APIs

reef minnow Oct 26, 2023, 1:57 PM

#

is the first SettingsChangedEvent (on waterfall) called after the AsyncPlayerPreLoginEvent on the paper side?

trail plume Oct 26, 2023, 2:03 PM

#

Yes, once again, far after login

#

pre 1.20.2, the client sends it just after you get the join game packet

#

1.20.2 sends it in the configuration phase, idk how md mapped that to existing events, my care for WF/Bungee is at all all time low, so, I never tracked that down

#

but, it's 100% not going to be tied to the login events

reef minnow Oct 26, 2023, 2:06 PM

#

ah i see

soft scroll Oct 26, 2023, 7:03 PM

#

Something that I found out: Why Paper's setPlayerProfile doesn't work if you are connected to the server via Waterfall? I'm trying to change a player's skin with it and, while the code works if I connect directly to the server or if I'm using Velocity, it doesn't work if I'm using Waterfall

This also doesn't work in BungeeCord, so this actually isn't a Waterfall issue but an upstream issue, but I was curious about why it doesn't work

(inb4 just use velocity instead of using waterfall lol, maybe this will convience me to migrate to Velocity once and for all)

trail plume Oct 26, 2023, 7:22 PM

#

I mean

#

try disabling tab list rewriting in the waterfall config if you've not got it disabled already

soft scroll Oct 26, 2023, 7:34 PM

#

trail plume try disabling tab list rewriting in the waterfall config if you've not got it di...

didn't work SCsaddarth

#

the proxy also doesn't have any plugins

trail plume Oct 26, 2023, 7:34 PM

#

No idea then

soft scroll Oct 26, 2023, 7:34 PM

#

sad_cat3

#

new reason to migrate to velocity just dropped!!! /j

trail plume Oct 26, 2023, 7:34 PM

#

make sure metadata rewriting is disabled too

#

i guess

soft scroll Oct 26, 2023, 7:34 PM

#

let me try

trail plume Oct 26, 2023, 7:34 PM

#

it's generally down to some oddball desync between the identity somewhere

#

shits been going on for years

soft scroll Oct 26, 2023, 7:35 PM

#

nope, also doesn't work

#

sad_cat3

trail plume Oct 26, 2023, 7:35 PM

#

glhf

soft scroll Oct 26, 2023, 7:36 PM

#

(first server is Waterfall, second server is Velocity)

#

tbh, considering that Waterfall is EOL (sort of)

#

I could migrate to Velocity (if I migrated all of my plugins)

trail plume Oct 26, 2023, 7:37 PM

#

I mean, there comes a level of "somebody would need to look into what is going on"

#

chances are it's losing something somewhere or something is being rewritten

#

would need to see what bungee is doing

#

and, I generally have 0 inclination for that somebody being me

soft scroll Oct 26, 2023, 7:39 PM

#

SCwetXD

#

now it makes sense why those skin changer/restorer plugins need to be installed on Bungee/Waterfall level: it is because something somewhere in Bungee causes it to bork so they need to change the skin on the proxy level

#

because I was wondering about why tf these plugins do all sort of weird crazy stuff when you can just do player.setPlayerProfile

trail plume Oct 26, 2023, 7:44 PM

#

Well, yea, there is a bunch of logic in bungee which has caused issues for years

#

disabling the tablist & entity metadata rewriting should disable most of that, but, eeeer

wind dove Oct 26, 2023, 8:37 PM

#

trail plume Doesn't the API expose the players server connection?

if you mean ProxiedPlayer.unsafe().sendPacket(DefinedPacket), it is not working apparently

trail plume Oct 26, 2023, 8:40 PM

#

Eeeerrr

#

doesn't that send a packet to the player?

wind dove Oct 26, 2023, 8:41 PM

#

I think so; I need a method to send a plugin message to one of the backend servers through a player's connection

trail plume Oct 26, 2023, 8:41 PM

#

Yes, so, get the Server from the player and use that

wind dove Oct 26, 2023, 8:42 PM

#

but doesn't that send the message through a random player? I need to choose which player to use to send the message

trail plume Oct 26, 2023, 8:42 PM

#

No

wind dove Oct 26, 2023, 8:42 PM

#

so even if two players are connected to the same server they will have two different Server instances?

trail plume Oct 26, 2023, 8:42 PM

#

yes

wind dove Oct 26, 2023, 8:42 PM

#

that makes sense then

languid lake Oct 26, 2023, 8:43 PM

#

cat so smart

rustic rain Oct 27, 2023, 7:37 PM

#

So I wrote a plugin to link up the "portals" of ancient cities in my survival server with previous seasons/versions of my survial so ppl can explore the previous seasons. However sometimes when players travel trough portals (or join the survival from the hub) they get kicked with the following message:

Internal Exception: io.netty.handler.codec.DecoderException: java.io.IOException: Packet 0/22 (PacketPlayInLook) was larger than I expected, found 16 bytes extra whilst reading packet 22

This only happens when using portals (and npc's for some reason), but not when using /server. Does anyone know what I did wrong?

This is the waterfall part of the plug-in: https://pastebin.com/DNQZarVX

#

nvm I updated waterfall and it seems to fix the issue, should have tested that beofre posting

wicked lantern Nov 1, 2023, 4:21 AM

#

languid lake cat so smart

my cat is dumb btw

languid lake Nov 1, 2023, 10:51 AM

#

I disagree.. mostly

wicked lantern Nov 1, 2023, 5:02 PM

#

languid lake I disagree.. mostly

Why

wet zephyr Nov 1, 2023, 6:59 PM

#

Any idea what the error below would be caused by?

[18:43:30 INFO]: [/**.**.**.**:62207] <-> InitialHandler has pinged
[18:43:35 INFO]: [/**.**.**.**:62209] <-> InitialHandler has pinged
[18:43:39 INFO]: [.TimoDerKoenig|/**.**.**.**:0] <-> ServerConnector [juesc] has connected
[18:43:39 WARN]: [.TimoDerKoenig|/**.**.**.**:0] <-> ServerConnector [juesc] - could not decode packet! io.netty.handler.codec.DecoderException: java.lang.UnsupportedOperationException: Packet must implement read method

Not entirely sure where to start digging; seeing it mostly happen on waterfall (by what we can tell so far) - any clues on where to start debugging? thanks 🙂

wicked lantern Nov 1, 2023, 10:16 PM

#

wet zephyr Any idea what the error below would be caused by? ``` [18:43:30 INFO]: [/**.**.*...

Try on a vanilla enviorment and without plugins

rugged grove Nov 2, 2023, 6:31 AM

#

is there a waterfall version that supports 1.8.8?

chilly coral Nov 2, 2023, 11:54 AM

#

latest

wind dove Nov 4, 2023, 5:12 PM

#

trail plume Yes, so, get the Server from the player and use that

apparently the plugin messages are not always sent using this method; I started noticing it today but just because I wasn't able to test it out completely

the fact is that I need to send a plugin message just when a player disconnects and so I cannot use their connection to send it because they are no longer online.
so I tried the method you suggested using the Server instance of another player but it still does not always send it (or, better, it sends it but the Bukkit server never receives it)

trail plume Nov 4, 2023, 5:15 PM

#

I mean, that logic has been buggy for years afaik

#

there is a reason why we generally suggest using anything but plugin messages if you wany reliable messaging

wind dove Nov 4, 2023, 7:18 PM

#

I see, but I would avoid implementing a new messaging method for just a plugin message whose purpose is to send a message to a player (but I cannot do it directly from the proxy)
...isn't there any other method (not covered by API, maybe?) to choose which player to use to send the message? in this way the message should always arrive (I hope, at least)

trail plume Nov 4, 2023, 7:53 PM

#

Yes, you literally get that player and use their server connection

#

the exact same as in the first place

#

There is no reliable mechanism for sending messages which isn't "go and actually use a reliable mechanism for sending messages"

random salmon Nov 7, 2023, 5:28 AM

#

brazen hamletBOT Nov 7, 2023, 5:28 AM

#

random salmon

message.txt by @random salmon: https://pastes.dev/ylLtizhl4Y

random salmon Nov 7, 2023, 5:28 AM

#

i have this issue

#

this is from my scoreboard.. only on new waterfall version

wicked lantern Nov 7, 2023, 5:29 AM

#

Yes, this a known bug on BungeeCord that if you register more than one scoreboard team fucks up

random salmon Nov 7, 2023, 5:29 AM

#

ah

#

will be fixed?

wicked lantern Nov 7, 2023, 5:30 AM

#

No promises, but I can investigate to see why, what I did see is that it's a pain in the ass

#

https://github.com/PaperMC/Waterfall/issues/318

random salmon Nov 7, 2023, 5:32 AM

#

hum..

wicked lantern Nov 7, 2023, 5:33 AM

#

Its a bungeecord bug, you cant really swap to servers with duplicated boards as far i know.

#

Try to make your plugins use different scoreboard names on same server

random salmon Nov 7, 2023, 5:34 AM

#

for now I will use the old version of waterfall

wicked lantern Nov 7, 2023, 5:34 AM

#

That doesn't fix nothing

#

You can use packet-based plugins, for example https://github.com/ShieldCommunity/SternalBoard

random salmon Nov 7, 2023, 5:35 AM

#

my problem does not occur when I try to swap servers, but when I try to join the server..

#

i will leave now.. thanks and bye

trail plume Nov 7, 2023, 11:44 AM

#

That's two seperate issues

halcyon cargo Nov 8, 2023, 8:30 PM

#

Hi! I want to create persistent bossbar using adventure, but when the player changes the server - bossbar disappears. I tried re-adding player to bossbar viewers in server connect events, nothing changed

#

Code is really simple - only bossbar initialisation and adding viewers to it

wicked lantern Nov 9, 2023, 1:39 AM

#

Use switch event and set it again i guess

halcyon cargo Nov 9, 2023, 6:56 AM

#

Yeah, the thing is switch event has method getFrom(), which i don't need in this case, but does not have something like getTo()

#

Maybe i can get the server player has connected using player#getServer

#

Because I want to exclude one server from displaying bossbar

#

Server connect event is also fired when changing server, but maybe that's not the good option for that

lavish cypress Nov 18, 2023, 12:05 PM

#

Hi! I’m a student and pretty much new to git, could anyone give me a demo of how to make a patch-based fork of Waterfall?

trail plume Nov 18, 2023, 12:20 PM

#

Clone the travertine repo and then delete all the patches bar the first one

#

outside of that, see the contrib guide and note that this tooling is pretty much pure abuse

lavish cypress Nov 18, 2023, 1:07 PM

#

uhh where's the contrib guide

trail plume Nov 18, 2023, 1:08 PM

#

might still be on the paper repo, moreso an older branch before we moved to gradle

lavish cypress Nov 18, 2023, 1:09 PM

#

oh found it here https://github.com/PaperMC/Paper/blob/ver/1.9.4/CONTRIBUTING.md

#

thx

lethal summit Nov 22, 2023, 7:49 PM

#

Failed to collect dependencies at io.github.waterfallmc:waterfall🫙1.19-R0.1-SNAPSHOT -> io.netty:netty-transport-native-unix-common🫙${netty.version}: Failed to read artifact descriptor for io.netty:netty-transport-native-unix-common🫙${netty.version}: The following artifacts could not be resolved: io.netty:netty-transport-native-unix-common:pom:${netty.version} (absent): Could not transfer artifact io.netty:netty-transport-native-unix-common:pom:${netty.version} from/to papermc (https://papermc.io/repo/repository/maven-public/): status code: 400, reason phrase: Bad Request (400) -> [Help 1]
why bad request

sleek jackal Nov 22, 2023, 7:50 PM

#

bad build

lethal summit Nov 22, 2023, 7:50 PM

#

i tried it also with 1.20 r0.2

sleek jackal Nov 22, 2023, 7:50 PM

#

where are you downloading it from

#

oh wiat is this maven

lethal summit Nov 22, 2023, 7:51 PM

#

maven yeah

sleek jackal Nov 22, 2023, 7:52 PM

#

figure out why your thing isn't replacig the netty var

lethal summit Nov 22, 2023, 8:06 PM

#

i solved it by using waterfall-native & waterfall-config somehow xd dunno why waterfall normal doesnt work like before. in the repo is also the jar missing

wicked lantern Nov 22, 2023, 11:41 PM

#

I moved to gradle waterfall

mint heron Dec 5, 2023, 6:29 PM

#

@trail plume one sec, will update the readme too since that is still on 1.19

#

done

storm egret Dec 8, 2023, 5:55 PM

#

hello does anyone have version 1.18.2 of waterfall?

trail plume Dec 8, 2023, 6:53 PM

#

latest supports 1.8+

mint flame Dec 8, 2023, 8:14 PM

#

Is there a version of ServerKickEvent which fires for kicks originating from the proxy? (i.e Connection#disconnect)

trail plume Dec 8, 2023, 8:16 PM

#

wouldn't that just be the general disconnect event? unless you mean you closed on the servers connection, in which case, er, I'd imagine, same event?

mint flame Dec 8, 2023, 8:18 PM

#

The disconnect event doesn't include the reason afaik. For context I wrote a logging utility plugin and I want to add logging for proxy kicks including their reason.

trail plume Dec 8, 2023, 8:35 PM

#

because all the disconnectevent knows is that the connection is dead

hollow path Dec 10, 2023, 2:38 PM

#

I have a problem with the ProxyConfig.java interface located in bungee.api:

I want to add a custom parameter to the config.
If I see this correctly, there are two configs: one from Waterfall itself (waterfall.yml) and the one from bungee.

My issue is that I need to read the property in the BungeeCord.java file.
There is a getConfig() method which returns an object from the ProxyConfig interface.

Which one?
There is the Configuration.java from bungee and the WaterfallConfiguration.java from (obviously) Waterfall.
Neither of them implement all the methods from the ProxyConfig interface.
Where should I put my custom config option?

The compiler currently nags me about this error:

[ERROR] /home/thorben/Dokumente/Development/Waterfall/Waterfall-Proxy/proxy/src/main/java/io/github/waterfallmc/waterfall/conf/WaterfallConfiguration.java:[10,8] io.github.waterfallmc.waterfall.conf.WaterfallConfiguration is not abstract and does not override abstract method isWaitingForPlayersEnabled() in net.md_5.bungee.api.ProxyConfig

I am unsure on how to proplery add a new config option.
I personally dont mind if its in the waterfall.yml or config.yml, however, the bungeecord class itself needs to be able to read this value.

subtle radish Dec 10, 2023, 2:44 PM

#

are you trying to add a config option to bungeecord.yml or waterfall.yml?

#

if you are making a plugin, just use your own file

hollow path Dec 10, 2023, 3:18 PM

#

I want to change the behaviour of the disconnect when the server closes.
It should wait until every player has left the server, so no one gets kicked while e.g. playing a game.

Via HAProxy I can dran the bungee proxies so no new connections get added, and all existing ones should not be terminated. The proxy should wait until thers no connections anymore.

I dont think I can cancel or override the end command of bungee with my own logic and stop the server arbitrarily via a plugin?

#

Therefore I want to edit the "independentThreadStop" method of bungee so it waits for shutdown until noone has connections over the proxy.

And to switch the behaviour, I want to add a new config option named "wait_for_player_disconnects" in either waterfall.yml or config.yml, though I think it fits best in waterfall.yml.

#

I also dont understand why the getTimeout, getUUID dont have any implementations, at least according to IntelliJ.
It complains that the WaterfallConfiguration.java doesnt implement the getTimeout() method, but Waterfall still compiles just fine?
Where does the implementation come from? DI?

trail plume Dec 10, 2023, 5:24 PM

#

it's lombok

hollow path Dec 11, 2023, 10:01 AM

#

Oh no

hollow path Dec 11, 2023, 10:02 AM

#

trail plume it's lombok

Could you help me though with adding the custom config parameter?

In which class should I implement it?

trail plume Dec 11, 2023, 10:03 AM

#

No

#

it's pretty much at the point of basic java

#

define it in the interface, and define it in the config class that implements it

#

the waterfall class is there for reading from the waterfall config, the super is there for reading from config.yml

rustic hawk Dec 12, 2023, 3:50 PM

#

How can I download the source of waterfall 1.16.5 to my pc?

trail plume Dec 12, 2023, 3:54 PM

#

I mean, normal people would just grab the latest version

rustic hawk Dec 12, 2023, 3:54 PM

#

but i need the one from 1.16.5

trail plume Dec 12, 2023, 3:54 PM

#

Otherwise you would need to clone the repo and find a commit for that version to check out

#

Why?

#

If you wanna pretend you don't support newer versions, use a plugin

rustic hawk Dec 12, 2023, 3:56 PM

#

trail plume Otherwise you would need to clone the repo and find a commit for that version to...

I don't think there is one, I was looking for one earlier

trail plume Dec 12, 2023, 3:56 PM

#

I mean, there is

#

You would need to go up the history yourself, however, we've never bothered to pin old versions

#

Go do a blame on the pom changes patch for the version line I guess

rustic hawk Dec 12, 2023, 3:57 PM

#

Ok, I'll have a look. Thank you

rustic hawk Dec 12, 2023, 4:05 PM

#

trail plume If you wanna pretend you don't support newer versions, use a plugin

Do you know one?

trail plume Dec 12, 2023, 4:07 PM

#

There was a few out there, I don't have any links though

rustic hawk Dec 12, 2023, 4:11 PM

#

👍 Thanks for u help

thorn zenith Dec 12, 2023, 5:43 PM

#

so if i already have texture and signature of player skin, how to set it for player

limber pecan Dec 18, 2023, 5:26 PM

#

Are plugin messages safe to use. Like to send data between a server and a proxy, you need a player as middleman. Can't a player just generate its own pluginmessages and send that to the proxy?

languid lake Dec 18, 2023, 5:29 PM

#

you can check the sender type

#

i.e. where it's coming from

limber pecan Dec 18, 2023, 5:30 PM

#

I obviously don't know enough about this, but you mean it's not an issue?

languid lake Dec 18, 2023, 5:31 PM

#

it's safe to use if you consider where the message is coming from

#

if you just want to communicate server <-> proxy but the message sender is a ProxiedPlayer then you'll want to discard it

limber pecan Dec 18, 2023, 5:33 PM

#

Okay, so just do some instance checks...

But I don't understand how this can be achieved, doesn't the information have to go through a player to communicate between server and proxy?

languid lake Dec 18, 2023, 5:35 PM

#

it uses the socket connection between the proxy and the server that the proxy is proxying for a client, but for that to exist a client has to be connected to the proxy; if it only stays between the server/proxy connection, it isn't sent to the client

limber pecan Dec 18, 2023, 5:36 PM

#

Aha, that clears up my understanding. Thanks!

Yeah, I always thought the client was middleman, as the client is required.

languid lake Dec 18, 2023, 5:37 PM

#

the proxy is the middleman, forwarding packets between server/client, but as it can intercept them you can do extra stuff with them as well before it gets forwarded

limber pecan Dec 18, 2023, 5:39 PM

#

Oh... Yeah, true.

#

(I now remember this is exactly why I wasn't didn't think about this earlier on, as the proxy is the middleman it can modify malicious packets sent from client to server and so on)

dense oasis Dec 26, 2023, 9:40 PM

#

Why do I no longer see an MOTD in the client from 1.20.3 when I set it in the ProxyPingEvent?

warm spoke Jan 13, 2024, 11:19 AM

#

hello, is it possible with waterfall/the bungeecord api to intercept all chat messages going to the client? it doesnt seem to be possible, is there some kind of workaround that doesn't involve using doing it on the server?

trail plume Jan 13, 2024, 12:39 PM

#

within the bounds of the API? no

#

with a packet library? sure

halcyon cargo Jan 14, 2024, 2:14 PM

#

How to kick proxiedplayer with adventure component kick message? I can't see any method in Audience

trail plume Jan 14, 2024, 2:15 PM

#

basically, you can't

#

I think adventure has a bungee serialiser you can use, however?

halcyon cargo Jan 14, 2024, 2:19 PM

#

I see, thanks!

bleak current Jan 16, 2024, 7:07 PM

#

Does anyone have an idea how to fix this?

trail plume Jan 16, 2024, 7:27 PM

#

well, you hit the API rate limit

#

so the answer generally is "don't"

#

as for how you don't depends on the nature of your setup, etc

bleak current Jan 16, 2024, 7:30 PM

#

This is the only thing that pops up for me when connecting players to the bungeecord server. There is no way this limit could be unattainable?

trail plume Jan 16, 2024, 7:30 PM

#

mojang sets the API limits

#

if you're hitting them the only general solution is to start load balancing proxy instances, or basically proxy the requests to mojang through something that will load balance

bleak current Jan 16, 2024, 7:31 PM

#

And can I correct that for example the query is sent from socks?

trail plume Jan 16, 2024, 7:32 PM

#

no idea

bleak current Jan 16, 2024, 9:38 PM

#

22:34:46 [SEVERE] Error authenticating xxx with minecraft.net
java.lang.IllegalStateException: Expected HTTP response 200 OK, got 429 Too Many Requests

Only problem is that currently there are no people on the server and no connections....

bleak current Jan 16, 2024, 10:02 PM

#

Does anyone have any ideas?

whole salmon Jan 16, 2024, 10:22 PM

#

I feel dumb.

#

yea no idea how to fix this

#

PluginMain is in the jar

#

did a clean, didn't fix it

#

wait I know what I did wrong

#

Actually, nevermind.

bleak current Jan 17, 2024, 12:58 AM

#

bleak current 22:34:46 [SEVERE] Error authenticating xxx with minecraft.net java.lang.IllegalS...

Any ideas?

trail plume Jan 17, 2024, 10:53 AM

#

once again, work out why you're hitting mojangs API limits and then address that

#

if using a shared host, only real advice would be don't

sharp glacier Jan 18, 2024, 1:11 AM

#

Does PlayerJoinEvent get called when changing servers?

trail plume Jan 18, 2024, 8:00 AM

#

You mean on the backend servers? yes, the backends don't know or care that the player just jumped from another server

stable river Jan 18, 2024, 11:54 AM

#

how to cancel runlater

stable river Jan 18, 2024, 11:59 AM

#

stable river how to cancel runlater

 public void addPlayerOffline(ProxiedPlayer player){
        OfflinePlayers.add(player);
        sendPartySysMassage(" " + player.getName() + " offline 5 Minutes to kick for Party");
        ScheduledTask scheduled = Plugin.getProxy().getScheduler()
.schedule(Plugin, new PlayerOffline(this, player),1, TimeUnit.MINUTES);
    }
    public void removePlayerOffline(ProxiedPlayer player) {
        OfflinePlayers.remove(player);
        // runlater cancel
    }

trail plume Jan 18, 2024, 12:00 PM

#

https://jd.papermc.io/waterfall/1.20/net/md_5/bungee/api/scheduler/ScheduledTask.html#cancel()

stable river Jan 18, 2024, 12:02 PM

#

trail plume https://jd.papermc.io/waterfall/1.20/net/md_5/bungee/api/scheduler/ScheduledTask...

i need For every player intellij

trail plume Jan 18, 2024, 12:03 PM

#

and?

#

if you're storing them in a Map, then just get it from the map and cancel it?

stable river Jan 18, 2024, 12:05 PM

#

trail plume if you're storing them in a Map, then just get it from the map and cancel it?

MAP<uuid,ScheduledTask> Like this?

trail plume Jan 18, 2024, 12:06 PM

#

yes

stable river Jan 18, 2024, 12:06 PM

#

And how to cancel.

trail plume Jan 18, 2024, 12:07 PM

#

remove(#UUID).cancel()

#

maybe wanna add a null check, but, yea

stable river Jan 18, 2024, 12:07 PM

#

trail plume remove(#UUID).cancel()

Excuse me, I'm a beginner in JAVA.

trail plume Jan 18, 2024, 12:08 PM

#

Map#remove returns the old value

stable river Jan 18, 2024, 12:08 PM

#

trail plume Map#remove returns the old value

ty 😁

stable river Jan 18, 2024, 2:13 PM

#

trail plume remove(#UUID).cancel()

        at me.st.crew.LPParty.Party.removePlayerOffline(Party.java:157) ~[?:?]
        at me.st.crew.Events.OnPlayerJoin.onPlayerjoin(OnPlayerJoin.java:29) ~[?:?]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] ``` 😐

languid lake Jan 18, 2024, 2:20 PM

#

trail plume maybe wanna add a null check, but, yea

^^

#

the return value of "java.util.Map.remove(Object)" is null

stable river Jan 18, 2024, 2:30 PM

#

languid lake > the return value of "java.util.Map.remove(Object)" is null

ty

stable river Jan 21, 2024, 12:02 PM

#

java.lang.NullPointerException: Cannot invoke "net.md_5.bungee.protocol.MinecraftEncoder.getProtocol()" because the return value of "io.netty.channel.ChannelPipeline.get(java.lang.Class)" is null
        at net.md_5.bungee.netty.ChannelWrapper.getEncodeProtocol(ChannelWrapper.java:51) ~[MainServer.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:dce3b8b:558]
        at net.md_5.bungee.UserConnection.sendPacketQueued(UserConnection.java:195) ~[MainServer.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:dce3b8b:558]
        at net.md_5.bungee.UserConnection.sendMessage(UserConnection.java:562) ~[MainServer.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:dce3b8b:558]
        at net.md_5.bungee.UserConnection.sendMessage(UserConnection.java:517) ~[MainServer.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:dce3b8b:558]
        at net.md_5.bungee.UserConnection.sendMessage(UserConnection.java:505) ~[MainServer.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:dce3b8b:558]
        at net.md_5.bungee.UserConnection.sendMessage(UserConnection.java:484) ~[MainServer.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:dce3b8b:558]
        at me.st.crew.LPParty.Party.sendPartyMassage(Party.java:46) ~[?:?]
        at me.st.crew.Commands.PartyCmd.PartyChat(PartyCmd.java:304) ~[?:?]
        at me.st.crew.Commands.PartyCmd.execute(PartyCmd.java:80) ~[?:?]```

#

public void sendPartyMassage(String msg, ProxiedPlayer player){
        for (ProxiedPlayer p : members) {
            if (!mute.contains(p)) {
                if (p != null)
                    p.sendMessage(Plugin.sendMessage(player,msg));
            }
        }
    }

#

how?

#

trail plume Jan 21, 2024, 12:05 PM

#

outside of "reproduce without plugins", eeeer

#

I mean, looks like you're sending a message to a dead connection

stable river Jan 21, 2024, 12:06 PM

#

how

#

if (p != null)

trail plume Jan 21, 2024, 12:06 PM

#

that's not how that works

#

if you store a connection object and the player DCs, it doesn't magically turn into a null value

stable river Jan 21, 2024, 12:07 PM

#

How do I fix it?

trail plume Jan 21, 2024, 12:08 PM

#

well, are you storing old connection objects or not?

#

if yes, generally, don't do that; or, at the very least, check if they're still online

stable river Jan 21, 2024, 12:08 PM

#

ye

#

online

#

trail plume Jan 21, 2024, 12:10 PM

#

them still being in the list means effectively nothing

#

I have no idea how you're logic works

stable river Jan 21, 2024, 12:10 PM

#

ok ty

#

    public void removePlayerOffline(ProxiedPlayer player) {
        OfflinePlayers.removeIf(p -> p.getUniqueId().equals(player.getUniqueId()));
        members.removeIf(p -> p.getUniqueId().equals(player.getUniqueId()));
        members.add(player);
        if (owner.getUniqueId() == player.getUniqueId()){
            setOwner(player);
        }
        if (timePlayerOffline.containsKey(player.getUniqueId())) {
            timePlayerOffline.remove(player.getUniqueId()).cancel();
        }
    }

#

I think I fixed it.

#

ye fixed @trail plume

subtle radish Jan 21, 2024, 12:23 PM

#

literally has "[no-ping]" in his name gdskull

civic stone Jan 23, 2024, 2:13 PM

#

is there an ignoreCancelled for listeners in waterfall?

delicate zealot Jan 28, 2024, 12:11 AM

#

https://jd.papermc.io/waterfall/1.20/net/md_5/bungee/api/plugin/Cancellable.html#isCancelled()

lean widget Jan 29, 2024, 10:36 PM

#

How to make a fork of waterfall

trail plume Jan 29, 2024, 10:38 PM

#

fork travertine and then work out how all the scripts work, etc

lean widget Jan 29, 2024, 10:38 PM

#

What is travertine

trail plume Jan 29, 2024, 10:39 PM

#

an old fork of waterfall

lean widget Jan 29, 2024, 10:39 PM

#

Ok

subtle radish Jan 29, 2024, 11:24 PM

#

first you should probably consider if you can do whatever your trying to do with a plugin

lean widget Jan 30, 2024, 1:06 AM

#

bruh

timber lichen Jan 30, 2024, 6:38 AM

#

sometimes i have this error can someone help me plz
most time on the first join
then i can join without problems

brazen hamletBOT Jan 30, 2024, 6:38 AM

#

timber lichen sometimes i have this error can someone help me plz most time on the first join ...

message.txt by @timber lichen: https://pastes.dev/SJHpeafgaT

trail plume Jan 30, 2024, 6:50 AM

#

Known bungee cord issue

#

Literally all you can really do is endure that you don’t have duplicate team names across servers

timber lichen Jan 30, 2024, 6:51 AM

#

trail plume Literally all you can really do is endure that you don’t have duplicate team nam...

what are team names?

trail plume Jan 30, 2024, 6:51 AM

#

Scoreboards

timber lichen Jan 30, 2024, 6:53 AM

#

trail plume Scoreboards

i dont understand
i have a scoreborad but what team names?

#

permission ranks?

trail plume Jan 30, 2024, 6:53 AM

#

Read the error

timber lichen Jan 30, 2024, 6:56 AM

#

trail plume Read the error

i change now my bungee ranks to some other and idk but now the error is gone

#

is that what you mean

#

?

trail plume Jan 30, 2024, 6:58 AM

#

All I can do is point to the error

#

https://github.com/PaperMC/Waterfall/issues/318

timber lichen Jan 30, 2024, 7:29 AM

#

trail plume https://github.com/PaperMC/Waterfall/issues/318

idk what i have to do
and why is this exists
Team npc-§8§4§a§0§0§0§4§3
i dont have a team npc?

trail plume Jan 30, 2024, 7:34 AM

#

You have a plugin in your server creating scoreboard teams

timber lichen Jan 30, 2024, 7:34 AM

#

i have to give this a other name on every server

Fallback:
title: "&8<-&ao&8-> &bPromi&6Games &8<-&ao&8->"
lines:
- "&6Zeit:&f %localtime_time_HH:mm:ss%"
- "&r "
- "&6Rang:&f %vault_group%"
- "&r "
- "&6Clan:&f %simpleclans_clan_name%"
- "&r"
- "&6Online:&f %bungee_total%"
- "&r "
- "&6Sterne:&f %vault_eco_balance%"

?

#

so Fallback1 2 3

trail plume Jan 30, 2024, 7:34 AM

#

That is causing issues with server transfers because they’re using duplicate team names across server instances

#

I cannot tell you what you have on your server that is breaking it outside of it being scoreboard related

#

All I can tell you is what the error means and point you to the name of the team that it is upset about

timber lichen Jan 30, 2024, 7:35 AM

#

i rly dont now what team is mean

trail plume Jan 30, 2024, 7:36 AM

#

It’s literally a Minecraft feature

#

The scoreboard commands

timber lichen Jan 30, 2024, 7:36 AM

#

ok i try somthing thx mate

plucky lava Feb 2, 2024, 1:46 AM

#

plucky lava Feb 2, 2024, 2:59 AM

#

or similarly sometimes it's this

#

first one came with this error

#

Just realized I'm not using waterfall

#

using bungee

#

I will try with waterfall

#

Okay if i use waterfall i get this...

#

i cant even see the back to server list button

#

starts with

#

[Render thread/WARN]: Client disconnected with reason: Internal Exception: io.netty.handler.codec.DecoderException: net.minecraft.ResourceLocationException: Non [a-z0-9_.-] character in namespace of location:

#

then its a long ass component tostring

#

seems to be from a tab-related packet

#

?

#

why is the location a component?

#

[Render thread/WARN]: Client disconnected with reason: Internal Exception: io.netty.handler.codec.DecoderException: net.minecraft.ResourceLocationException: Non [a-z0-9_.-] character in namespace of location: {\"extra\":[{\"color\":\"gray\",\"text\":\"\\n\"},{\"bold\":true,\"color\":\"white\",\"text\":\"MIDNIGHTSKY\\n\"},{\"color\":\"gray\",\"text\":\"\\n\"},{\"strikethrough\":true,\"color\":\"#0099FF\",\"text\":\" ```

trail plume Feb 2, 2024, 9:58 AM

#

Something is messing with packets and borking the data

#

Generally outdated plugins but Maoshrug

timber lichen Feb 3, 2024, 5:51 PM

#

trail plume That is causing issues with server transfers because they’re using duplicate tea...

for my server was the problem fancy npcs plugin
it was after i create the first npc but the name was not "Team npc-§7§a§o§c§f§c§f§4" that npc do not exist,
the name was my ingame name

#

i use now citizens and i no longer have the issue

plucky lava Feb 6, 2024, 2:28 AM

#

Yeah Im getting this for some reason

#

With these plugins

#

Proxy-1.0-SNAPSHOT does nothing with packets

#

And also if a player times out then for some reason they don't get disconnected from proxy which is weird

#

so they get a "already connected to this proxy"

eternal fulcrum Feb 6, 2024, 5:31 AM

#

can anyone help with waterfall i want to direct connect to a server withoutgoing through hub

dusty lintel Feb 6, 2024, 7:19 AM

#

eternal fulcrum can anyone help with waterfall i want to direct connect to a server withoutgoing...

Don't include the server on bungee

#

Its that easy

eternal fulcrum Feb 6, 2024, 7:37 AM

#

lol

grizzled beacon Feb 6, 2024, 8:01 PM

#

plucky lava Yeah Im getting this for some reason

It happens to me too, did you find a solution?

plucky lava Feb 6, 2024, 8:01 PM

#

Nope still getting it :/

#

What plugins u running

dusty lintel Feb 10, 2024, 3:19 PM

#

Change the jar

languid parrot Feb 13, 2024, 3:29 PM

#

Hii ! how to make a waterfall fork? i really want to make one.

dusty lintel Feb 15, 2024, 1:52 PM

#

What do you mean by "how to make a waterfall fork"

boreal crown Feb 15, 2024, 3:16 PM

#

So.... How do I properly setup plugin messaging in BungeeCord with a custom channel identifier?
Like listen for incoming ones and sending own back?
There are no docs for BungeeCord that seem to cover the proxy side... Only the Server side.

sleek jackal Feb 15, 2024, 3:20 PM

#

https://jd.papermc.io/waterfall/1.20/net/md_5/bungee/api/ProxyServer.html#registerChannel(java.lang.String)

#

https://jd.papermc.io/waterfall/1.20/net/md_5/bungee/api/event/PluginMessageEvent.html

#

https://jd.papermc.io/waterfall/1.20/net/md_5/bungee/api/connection/ProxiedPlayer.html#sendData(java.lang.String,byte[])

boreal crown Feb 15, 2024, 3:27 PM

#

thanks

languid parrot Feb 15, 2024, 3:51 PM

#

dusty lintel What do you mean by *"how to make a waterfall fork"*

i want to like make a fork of it of it's code but edited you know that's called fork

#

like adding things in the original waterfall

lean gobletBOT Feb 15, 2024, 3:54 PM

#

well either fork it like normal or look at how Travertine did it

boreal crown Feb 15, 2024, 4:41 PM

#

Does the proxy modify the player (connection) in any way?
I try to figure out the cause of an error in DecentHolograms and so far the only common thing I could find from all the reports is, that the servers run under a BungeeCord/Waterfall proxy.

The error in question: https://paste.helpch.at/zikamujade.swift
The first line of the plugin the stacktrace mentions: https://github.com/DecentSoftware-eu/DecentHolograms/blob/main/src/main/java/eu/decentsoftware/holograms/api/nms/PacketListener.java#L33

lean gobletBOT Feb 15, 2024, 4:42 PM

#

that error cannot be caused by a proxy

#

that sounds more like a case where the plugin is simply not compatible with the server version

#

(as far as I can tell it should work though, I use similar code even behind a proxy without issues)

#

is this happening on every join? because I think if the player leaves before it was fully joined (which could happen more often on a proxy) then maybe that could cause the the handler to be missing?

cosmic burrow Feb 18, 2024, 8:41 AM

#

            public void execute(CommandSender commandSender, String[] strings) {
                getLogger().info("Command Executed!");
                ByteArrayDataOutput out = ByteStreams.newDataOutput();
                out.writeUTF( "pumpkincore:main" );
                out.writeUTF( "Hello World" );

                ProxiedPlayer p = (ProxiedPlayer) commandSender;

                p.sendData("pumpkincore:main", out.toByteArray());
            }```
is this right how to send plugin message in waterfall?

#

it not sending anything in my paper server...

#

i have register the channel in waterfall plugin

    public void onEnable() {
        instance = this;

        getProxy().registerChannel("pumpkincore:main");```

#

then register this in paper plugin

    public void onEnable() {
        // Some Condition
        if (Bukkit.getPluginManager().getPlugin("Vault") == null) {
            this.getLogger().info("We need Vault!");
            getServer().getPluginManager().disablePlugin(this);
            return;
        }

        this.getServer().getMessenger().registerOutgoingPluginChannel(this, "pumpkincore:main");
this.getServer().getMessenger().registerIncomingPluginChannel(this, "pumpkincore:main", new PrivateMessage());

#

and this my PluginMessageListener in paper plugin

public class PrivateMessage implements PluginMessageListener {
    @Override
    public void onPluginMessageReceived(@NotNull String channel, @NotNull Player player, @NotNull byte[] messages) {
        System.out.print(channel);
        Pumpkincore.getInstance().getLogger().info("DEBUG: "+channel);
        if (!channel.equalsIgnoreCase("pumpkincore:main")) {
            return;
        }

        ByteArrayDataInput in = ByteStreams.newDataInput(messages);
        String subchannel = in.readUTF();

        String senderName = in.readUTF();
        String ggwp = in.readUTF();

        player.sendMessage(Component.text("You received a private message from: " + senderName + ", "+ggwp));
    }
}

#

there no output from


        System.out.print(channel);
        Pumpkincore.getInstance().getLogger().info("DEBUG: "+channel);```

#

after use this waterfall command #waterfall-dev message

cosmic burrow Feb 18, 2024, 10:13 AM

#

still need help

trail plume Feb 18, 2024, 12:26 PM

#

cosmic burrow ```java public void execute(CommandSender commandSender, String[] st...

Because you're sending the plugin message to the client, not to the server

cosmic burrow Feb 18, 2024, 1:08 PM

#

trail plume Because you're sending the plugin message to the client, not to the server

i see

craggy oasis Feb 19, 2024, 2:39 PM

#

What is the linux command to update the waterfall.jar to the latest version?

sleek jackal Feb 19, 2024, 2:48 PM

#

rm waterfall.jar
wget newwaterfall.jar
java -jar newaterfal.jar

#

get the url from the website

craggy oasis Feb 19, 2024, 2:51 PM

#

wget https://api.papermc.io/v2/projects/waterfall/versions/1.20 That's what I figured out so far

#

I don't really know where I can find the URL on the website

trail plume Feb 19, 2024, 2:51 PM

#

you would need to parse the API responses

daring shardBOT Feb 19, 2024, 2:51 PM

#

https://papermc.io/downloads

trail plume Feb 19, 2024, 2:51 PM

#

or if you're doing it manually just right click the download button and copy the link

craggy oasis Feb 19, 2024, 2:53 PM

#

How would I find what the correct API calls are to update the waterfall.jar through a .sh file?

trail plume Feb 19, 2024, 2:53 PM

#

https://api.papermc.io/docs/swagger-ui/index.html?configUrl=/openapi/swagger-config

cosmic burrow Feb 19, 2024, 9:02 PM

#

if I send data from waterfall plugin

#

it will send to all server?

#

i want to make global player chat

#

so i have 2 server

#

1 paper plugin and 1 waterfall plugin

#

so i send data

event.getPlayer().sendPluginMessage(getInstance(), "pumpkincore:main", out.toByteArray());```
from paper plugin with AsyncChatEvent

#

after that waterfall plugin will send it back to all servers

#

like this

        if (!event.getTag().equalsIgnoreCase("pumpkincore:main")) {
            return;
        }

        ProxiedPlayer sender = (ProxiedPlayer) event.getReceiver();

        for (Map.Entry<String, ServerInfo> entry : ProxyServer.getInstance().getServersCopy().entrySet()) {
            String serverName = entry.getKey();
            ServerInfo serverInfo = entry.getValue();

            ProxyServer.getInstance().getLogger().info("ServerName: "+serverName);

            serverInfo.sendData("pumpkincore:main", event.getData());
        }```

#

it was successfully sent to waterfall and then returned to the paper plugin but only 1 origin server could receive it

trail plume Feb 19, 2024, 9:08 PM

#

plugin messaging requires hijacking a players connection

#

if you only have 1 server with players on it, then only it will be able to send/recieve such messages

cosmic burrow Feb 19, 2024, 9:09 PM

#

trail plume if you only have 1 server with players on it, then only it will be able to send/...

i have 2 server and all server have 1 player online

#

2 server paper with 1 same plugin

trail plume Feb 19, 2024, 9:09 PM

#

so, you have 2 servers and 2 players connected through the proxy, each to different servers?

cosmic burrow Feb 19, 2024, 9:10 PM

#

yes

trail plume Feb 19, 2024, 9:10 PM

#

then it should work

cosmic burrow Feb 19, 2024, 9:11 PM

#

not work

#

I don't know how to explain it so it can be understood

trail plume Feb 19, 2024, 9:13 PM

#

You would need o check your listener setup on the backend

#

I don't really see how that could fail if you acually have 2 servers with players on logged in, they should both get the message

cosmic burrow Feb 19, 2024, 9:13 PM

#

this my listeners

    public void onPlayerChat(AsyncChatEvent event) {
        event.setCancelled(true);

        ByteArrayDataOutput out = ByteStreams.newDataOutput();
        out.writeUTF("PublicChat");
        out.writeUTF(event.getPlayer().getName());
        out.writeUTF(JSONComponentSerializer.json().serialize(event.message()));

        event.getPlayer().sendPluginMessage(getInstance(), "pumpkincore:main", out.toByteArray());
    }

    @Override
    public void onPluginMessageReceived(@NotNull String channel, @NotNull Player sender, @NotNull byte[] messages) {
        if (!channel.equalsIgnoreCase("pumpkincore:main")) {
            return;
        }

        ByteArrayDataInput in = ByteStreams.newDataInput(messages);
        String subchannel = in.readUTF();
        if (subchannel.equals("PublicChat")) {
            Player fromPlayer = Bukkit.getPlayer(in.readUTF());
            Component message = JSONComponentSerializer.json().deserialize(in.readUTF());

            Component chatRenderer = chatRenderer(fromPlayer, message);

            Bukkit.getOnlinePlayers().forEach(player -> player.sendMessage(chatRenderer));
        }
    }```

trail plume Feb 19, 2024, 9:14 PM

#

I mean, that is never going to work as intended

#

fromPlayer will always be null on other servers

#

check logs, but, you probably wanna try printing out what is being recieved in that handle, but, idk

#

on he surface idk how the other server wouldn't get anything, I'd just expect whatever your chatRenerer method does to blow up, but MahiruShrug

cosmic burrow Feb 20, 2024, 4:35 PM

#

trail plume fromPlayer will always be null on other servers

so i just need to change Player to OfflinePlayer right?

trail plume Feb 20, 2024, 4:37 PM

#

idk your logib, but, yea, you'd nee to always have an offline player, also noting that you probably want to send the UUID, not the name, or figure out a better way to handle that so that you're not causing lookups

craggy oasis Feb 22, 2024, 12:43 PM

#

Is it possible to use waterfall to 'send' players to a Fabric server amidts other servers?

craggy oasis Feb 23, 2024, 10:07 AM

#

I guess not haha

craggy oasis Feb 24, 2024, 4:20 PM

#

Bump?

austere nova Feb 24, 2024, 4:25 PM

#

I would recommend using Velocity, the bungeecord environment has almost no support for mods environments

craggy oasis Feb 24, 2024, 5:54 PM

#

how similar are waterfall and velocity

#

Got a lot of my network going on waterfall

trail plume Feb 24, 2024, 5:57 PM

#

same concept, different APIs, etc

craggy oasis Feb 24, 2024, 5:57 PM

#

Anything else to note regarding the two?

trail plume Feb 24, 2024, 5:58 PM

#

I mean, with a question as open as that, no

craggy oasis Feb 24, 2024, 5:58 PM

#

Haha i meant like

#

Roughly positive/negative things to note about the two? Or when switching from Waterfall to Velocity

#

Also how much work would switching be? The thing I am mostly worried about is the whole message channel thingy that bungeecord has that I would need to rewrite and figure out again

trail plume Feb 24, 2024, 5:59 PM

#

I mean, it's an entirely new stack which is still in development vs a piece of software which basically hasn't been developed in 10 years

#

it doesn't cater to java 6

#

how much that impacts you is going to depend on what you're doing

craggy oasis Feb 24, 2024, 6:00 PM

#

Ah is waterfall outdated

trail plume Feb 24, 2024, 6:00 PM

#

waterfall is currently EOL

craggy oasis Feb 24, 2024, 6:01 PM

#

Oh?

trail plume Feb 24, 2024, 6:02 PM

#

I had some setbacks on working on stuff due to health issues, but, I'm especially done with waterfall because theres little you can do without causing issues for plugins in order to actually try to improve it in any meaningful manner

#

after my last project resulted in weeks of constant changes in order to appease plugins, never again

craggy oasis Feb 24, 2024, 6:03 PM

#

I see that on the website it says that Velocity is much faster

#

In what ways is it much faster?

trail plume Feb 24, 2024, 6:04 PM

#

It's built from th ground up from our years of knowledge on netty and around how it works

craggy oasis Feb 24, 2024, 6:16 PM

#

Does Velocity not support Fabric 1.20.4

trail plume Feb 24, 2024, 6:18 PM

#

proxies and mods generally do not work together well

#

velocity has some extra support for stuff which can help, but, overall, YMMV, and you are somewhat on your own

#

wheeen .5 comes, theres some stuff I can work on to maybe improve compatability, but, it does require some help from 3rd parties to support fully potentially

#

(annnd last time we tried reaching out re modding stuff, nobody replied bar our existing discussion with forge, soooooo)

austere nova Feb 24, 2024, 6:43 PM

#

craggy oasis Does Velocity not support Fabric 1.20.4

Fabric is fully supported

wooden path Mar 6, 2024, 9:25 PM

#

Is there a way to add more channels to the list of registered channels that gets sent to a player when they join the proxy?

ProxyServer.registerChannel doesn't appear to affect the channel list that is sent to the client.

trail plume Mar 6, 2024, 9:30 PM

#

you'd need to handle that yourself

thick sedge Mar 10, 2024, 3:48 AM

#

where i can find waterfall-proxy for maven?

trail plume Mar 10, 2024, 4:06 AM

#

We don't publish that, you'd need to publish it yourself or find a public maven repo that does

topaz vergeBOT Mar 19, 2024, 4:30 PM

#

(65f9bd9b2d5bd6481a0648ce) // @sacred coral (@thinker369 / 933208620550737930) has been banned by @trail plume (126975485493248000)
Reason: Quick-banned for sending a message in #waterfall-dev

cosmic burrow Mar 20, 2024, 12:44 PM

#

how to disable waterfall command tab?

lean gobletBOT Mar 20, 2024, 12:47 PM

#

don't grant the permission afaik

cosmic burrow Mar 20, 2024, 12:47 PM

#

set to false?

#

my player don't have permission

lean gobletBOT Mar 20, 2024, 12:48 PM

#

if the commands are granted by default you would need to set them to false, yes

cosmic burrow Mar 20, 2024, 12:52 PM

#

lean goblet if the commands are granted by default you would need to set them to false, yes

in my luckperms?

lean gobletBOT Mar 20, 2024, 12:53 PM

#

yes

cosmic burrow Mar 20, 2024, 12:55 PM

#

but i still can access it

#

is there any Event API like PlayerCommandSendEvent in bungeecord or waterfall?

lean gobletBOT Mar 20, 2024, 1:14 PM

#

pretty sure the ChatEvent catches that

#

Are you sure /skin is a command from the proxy?

cosmic burrow Mar 20, 2024, 1:15 PM

#

lean goblet Are you sure /skin is a command from the proxy?

yes, i have delete all command list from backend server with PlayerCommandSendEvent e.getCommands().clear();

lean gobletBOT Mar 20, 2024, 1:15 PM

#

also not sure anymore if this is actually done automatically on the proxy, there might be a requirement to manually filter it out with the ProxyDefineCommandsEvent

#

ah, wait, I thought you meant the pre command event. Yeah the ProxyDefineCommandsEvent is the equivalent to that

cosmic burrow Mar 20, 2024, 5:00 PM

#

ok thats work

#

is waterfall still keep send PluginMessage after there any player join?

vestal cedar Mar 21, 2024, 11:05 AM

#

What? Do you mean if it will send a plugin message after no player is online?

lavish parcel Mar 25, 2024, 6:28 PM

#

Hey, is there any timeout implemented on ServerInfo#ping?

honest coral Mar 25, 2024, 7:29 PM

#

does a waterfall plugin work on bungeecord?

#

oh they probably wont

spiral mountain Mar 26, 2024, 6:16 PM

#

Last

visual hinge Mar 26, 2024, 6:18 PM

#

No, me last

chilly token Mar 26, 2024, 6:58 PM

#

no, me

austere nova Mar 26, 2024, 10:10 PM

#

Si.

steady pagoda Mar 26, 2024, 11:09 PM

#

cantthink

indigo basin Mar 27, 2024, 6:12 AM

#

goodbye waterfall.

vale ibex Mar 27, 2024, 9:12 AM

#

Last

torpid rampart Mar 27, 2024, 10:17 AM

#

nope, you are not the last.

#

Also goodbye waterfall.

vale ibex Mar 27, 2024, 2:24 PM

#

Dang it

steady pagoda Mar 28, 2024, 8:18 AM

#

👋

torpid agate Mar 28, 2024, 5:52 PM

#

Rest in Peace

peak geode Mar 31, 2024, 7:11 PM

#

why?

#

is this part of "end of life"?

trail plume Mar 31, 2024, 7:12 PM

#

you tried to connect waterfall to a server in online mode

peak geode Mar 31, 2024, 7:13 PM

#

oh

chilly oracle Apr 1, 2024, 9:07 PM

#

hi, I'm looking for a plugin that when my server crashes redirects me to the limbo server and when it comes back online it redirects the players back to the primary server, do you have any advice? if so, ping me

sleek jackal Apr 2, 2024, 5:12 PM

#

https://i.imgur.com/PpZURyb.png

bleak current Apr 16, 2024, 7:14 PM

#

someone know how fix this?

trail plume Apr 16, 2024, 7:15 PM

#

don't crosspost.

bleak current Apr 16, 2024, 7:15 PM

#

ok?

atomic ridge Apr 22, 2024, 8:52 PM

#

bleak current someone know how fix this?

hello, i have a same problem

#

I added a waterfall to my server and everything worked during temporary testing when I ran waterfall using screen as root. However, when I dockerized waterfall, I'm getting this error.

#

My problem probably lies either in the startup, the Dockerfile, or the Docker Compose file.

#

waterfall config.yml:

#

docker-compose:

#

and dockerfile:

trail plume Apr 22, 2024, 10:24 PM

#

Because containers are isolated, their local host is their own

#

You’d need to communicate over the docket interface, see their guides for recs, etc

plucky lava May 1, 2024, 7:43 PM

#

Trying to debug/sort out an issue but just trying to learn more about how bungee/waterfall work:
What is the upstream bridge?

#

is upstream the client or the server

trail plume May 1, 2024, 7:43 PM

#

#waterfall-help message

clear plume May 12, 2024, 9:07 AM

#

If I want to use a plugin channel, is it safe to use "BungeeCord", or is it equally safe to use "custom:channel"?

#

proxy.registerChannel("custom:channel")

trail plume May 12, 2024, 11:02 AM

#

Use your own channel, don’t try to hijack somebody else’s

clear plume May 12, 2024, 1:34 PM

#

But I listen to PluginMessageEvent and I can receive messages like this:

#

minecraft:brand -> [B@4c8d14c2

trail plume May 12, 2024, 1:34 PM

#

yes, and?

clear plume May 12, 2024, 1:35 PM

#

I'm worried about whether the custom channel can be controlled by the client sending plug-in messages?

trail plume May 12, 2024, 1:35 PM

#

You just validate the sender

#

if the sender is not whatever bungee represents is a server connection, then ignore it

clear plume May 12, 2024, 1:38 PM

#

Do this? :
val a: Connection = event.sender if (proxy.servers != a) { return }

trail plume May 12, 2024, 1:38 PM

#

wat

#

check the sender in the event

#

see if it's an instance of whatever bungee considers a server connection

clear plume May 12, 2024, 1:41 PM

#

Do this? :
val a = event.sender as? ServerInfo ?: return if (!(proxy.servers.values.contains(a))) { return }

trail plume May 12, 2024, 1:45 PM

#

clear plume May 12, 2024, 1:50 PM

#

Thanks

#

val a = event.sender as? Server ?:return if (!proxy.servers.values.contains(a.info)) return

trail plume May 12, 2024, 1:51 PM

#

There is 0 reason to check that it's registered

clear plume May 12, 2024, 1:55 PM

#

So if it is sent by the client, then event.sender will be ProxiedPlayer, and if it is sent by the server, will it be Server?

trail plume May 12, 2024, 1:56 PM

#

yes

clear plume May 12, 2024, 1:56 PM

#

Thanks

primal root Jun 5, 2024, 3:16 PM

#

Hi there,
I am having an issue with development of my bungee plugin where it says the following, Cannot invoke "java.util.List.isEmpty()" because the return value of "net.md_5.bungee.api.plugin.PluginDescription.getLibraries()" is null
But I haven’t set the field not was it an issue before the 1.20.5/6 update

trail plume Jun 5, 2024, 3:18 PM

#

spigot doesn't use nullability annotations in bungee properly

#

and so, if it's null now, it's null now

#

the thing is just loaded using snake, so, some level of "good luck" there

upbeat plaza Jun 7, 2024, 8:52 PM

#

can someone
make a minecraft plugin which creates a custom encahnt for 1.20.1 and the enchant is called-

Shoot 3 + 1 arrow per level at the charge you shot at

sleek jackal Jun 7, 2024, 8:58 PM

#

wrong channel, also not the place for that