#archived-modding-development | Hollow Knight | Page 525

rough pulsar Jul 2, 2021, 8:06 PM

#

Or wait

#

I don't know

floral blade Jul 2, 2021, 8:07 PM

#

there's already a 1.5 branch right ?

#

i was just trying to do an equivalent of if(false) without changing the code, i may as well have commented the block lol , though looking at Mul's editor it makes me question if C# even short-circuits boolean logic how i was expecting it to at all

primal latch Jul 2, 2021, 8:09 PM

#

Why not just set globalsettings to a new instance?

#

Can anybody answer this?

floral blade Jul 2, 2021, 8:11 PM

#

primal latch Can anybody answer this?

all i know is if i recompiled mapi on macos controller would work, and similar motivations lead to the creation of unix.zip. 56 probably knows more as they'd made the zip afaik.

fickle sparrow Jul 2, 2021, 8:13 PM

#

if your json files are messed up

#

you should know

#

but this is configuration data

#

and if your file is messed up, we don't want to override the config with the default

#

because that could mean you'd lose all of your stuff over a simple fix

primal latch Jul 2, 2021, 8:17 PM

#

fickle sparrow because that could mean you'd lose all of your stuff over a simple fix

That simple fix is deleting the file which is the same as a reset. We could just create a message saying "there was something wrong with your settings file so it has been reset. Please press KEY to continue"

fickle sparrow Jul 2, 2021, 8:17 PM

#

look

light zodiac Jul 2, 2021, 8:17 PM

#

floral blade there's already a 1.5 branch right ?

i do be blind

fickle sparrow Jul 2, 2021, 8:17 PM

#

unless the user is explicitly editing their json files

primal latch Jul 2, 2021, 8:17 PM

#

floral blade all i know is if i recompiled mapi on macos controller would work, and similar m...

Yeah. I get why unix.zip is there. I want to know why there is no difference between macos and unix

fickle sparrow Jul 2, 2021, 8:18 PM

#

this stuff wont ever be invalid

#

and if they are editing it

#

most likely they forgot a comma or some shit

#

so which is better

#

resetting all of their data

primal latch Jul 2, 2021, 8:18 PM

#

haven't we had cases where it just happened? The serialisation can fail or the write to the file

fickle sparrow Jul 2, 2021, 8:18 PM

#

or telling them theres a problem

#

it shouldn't

#

unless a mod is extremely bugged

#

but thats on the mod author

jolly oriole Jul 2, 2021, 8:19 PM

#

primal latch haven't we had cases where it just happened? The serialisation can fail or the w...

afaik no

floral blade Jul 2, 2021, 8:24 PM

#

primal latch Yeah. I get why unix.zip is there. I want to know why there is no difference bet...

do they both use Mono runtime to run unity games? if so that might be related

fickle sparrow Jul 2, 2021, 8:25 PM

#

what does this question even mean

#

the assembly-csharp is the same for unix and macos iirc

primal latch Jul 2, 2021, 8:26 PM

#

ok. That was my guess but I was too lazy to verify

primal latch Jul 2, 2021, 8:26 PM

#

fickle sparrow or telling them theres a problem

yeah. Something like that is fine too. But now it just breaks down

fickle sparrow Jul 2, 2021, 8:26 PM

#

I mean an error gets printed

primal latch Jul 2, 2021, 8:27 PM

#

also, Fyremoth is encountering a similar issue right now. For some reason the code that adds custom items and journal entries also messes up the save selection screen and we have no idea why

floral blade Jul 2, 2021, 8:28 PM

#

maybe : fix the settings.json and make a backup of the player's previous settings, in case they'd like to recover them + print a message in modlog

light zodiac Jul 2, 2021, 8:28 PM

#

floral blade i was just trying to do an equivalent of if(false) without changing the code, i ...

The and gets evaluated first. So you could've done what you wanted to do if you put brackets around the or statement

light zodiac Jul 2, 2021, 8:28 PM

#

primal latch also, Fyremoth is encountering a similar issue right now. For some reason the co...

Anything obvious in player.log files or other log files?

floral blade Jul 2, 2021, 8:29 PM

#

light zodiac The and gets evaluated first. So you could've done what you wanted to do if you ...

right, i was being dumb that's how that'd work , makes sense.

fickle sparrow Jul 2, 2021, 8:31 PM

#

fine

primal latch Jul 2, 2021, 8:31 PM

#

light zodiac Anything obvious in player.log files or other log files?

Yeah. Something with the language function erroring out even if no language is requested. It throws a nullreference error. The weird thing is that the stack trace doesn't not contain Fyremoth but we're sure Fyremoth causes it

fickle sparrow Jul 2, 2021, 8:31 PM

#

I'll work out something

#

I'll just keep the game open and log that the settings are fucked

#

the user can just delete the files or whatever to fix it

#

also uh you do realize you have to set default global settings yeah?

#

hold up

#

#

it literally doesn't even crash

#

_>

floral blade Jul 2, 2021, 8:36 PM

#

fickle sparrow

i remember seeing this for the benchwarp crash and seeing that even though there is a try catch, in some cases benchwarp screws up it's settings and then things dont work.

fickle sparrow Jul 2, 2021, 8:40 PM

#

well as you can see in the code flow

#

the value doesn't get set if the deserialization fails

#

which means that the default value of the settings field gets used

#

floral blade Jul 2, 2021, 8:42 PM

#

yep that's what i'd concluded. i'm just confused about how deleting the settings file fixes the issue. tamershrug

#

referring to <#archived-modding-help message>

fickle sparrow Jul 2, 2021, 8:47 PM

#

there is no issue

jolly oriole Jul 2, 2021, 8:47 PM

#

what issue

fickle sparrow Jul 2, 2021, 8:48 PM

#

this

#

literally only happens if you don't use the settings correctly

floral blade Jul 2, 2021, 8:48 PM

#

floral blade referring to <https://discord.com/channels/283467363729408000/462200562620825600...

i was referring to how this fix works

If you are using Benchwarp Mod and no mod text shows up in the top left of your title screen....

fickle sparrow Jul 2, 2021, 8:48 PM

#

idk if theres a bug send logs

#

plus thats from 1.4

#

I completely rewrote the save file implementation in 1.5

floral blade Jul 2, 2021, 8:51 PM

#

true

floral blade Jul 2, 2021, 8:51 PM

#

fickle sparrow idk if theres a bug send logs

if this happens again in 1.5 i'll be sure to send the logs

fickle sparrow Jul 2, 2021, 8:55 PM

#

like as long as you implement the interfaces correctly and w/e

#

there shouldn't really be any problems

copper nacelle Jul 2, 2021, 11:08 PM

#

primal latch Yeah. I get why unix.zip is there. I want to know why there is no difference bet...

because the source assembly is the same

#

qed

floral blade Jul 3, 2021, 2:17 AM

#

if a mod errors in their unload i think mapi breaks

floral blade Jul 3, 2021, 2:36 AM

#

So i tried it with radiance , ended up having to replace like 6 GO's tk2dsprites but it works. the halo behind radiance is a sprite though so that stays the same for now.

#

so i guess it should work for the rest of them too

floral blade Jul 3, 2021, 2:53 AM

#

apparently it switches back and forth between a version of the same sprite for some reason, so i made a cursed skin for it sethscheme

fickle sparrow Jul 3, 2021, 3:20 AM

#

huh was it not wrapped in a catch

#

gonna check

#

#

nope its fine

#

ah I do need to wrap init though

floral blade Jul 3, 2021, 5:41 AM

#

This should fix it : https://github.com/HollowKnight-Modding/HollowKnight.Modding/pull/58/files

fickle sparrow Jul 3, 2021, 6:02 AM

#

Im uh

#

Rewriting most of the mod loader btw

#

Right now it is in a state of very pauseshroom

floral blade Jul 3, 2021, 6:05 AM

#

okay

fickle sparrow Jul 3, 2021, 6:06 AM

#

Having a ref of another (non-library) mod can cause the loader to die

primal latch Jul 3, 2021, 7:55 AM

#

fickle sparrow Having a ref of another (non-library) mod can cause the loader to die

Then I’m happy Fyremoth uses reflections to add mod compatibility. But we mostly did that so you don’t need to have all those mods installed.

floral blade Jul 3, 2021, 8:24 AM

#

how does one make the scroll bar of the modmenu scroll the content ?

#

okay giving the thing a size fixed the scrolling but using keyboard does not scroll now

floral blade Jul 3, 2021, 8:52 AM

#

it scrolls using keyboard if i click the scrollbar before pressing the keys but it does not auto scroll when i press down and end up selecting an option that isn't visible feelsgrubman .

#

nimble lake Jul 3, 2021, 9:09 AM

#

yo this menu cool

light zodiac Jul 3, 2021, 9:34 AM

#

floral blade

Code?

floral blade Jul 3, 2021, 9:40 AM

#

the addMenuOptions is basically same as that's on the repo (with a few more elements), i've fiddled with this to get it to scroll. so far this is what i have

cedar hemlock Jul 3, 2021, 9:56 AM

#

Do you guys know which mods on this list:

Benchwarp;
Customknight;
FrogCore;
Hollow_Point_changes_Fix;
HollowknightDRPC;
HowwowKnyight;
Modcommon;
QoL;
SereCore
SFCore;
Vasi.
```Can be causing this:
```cs
[ERROR]:[UNITY] - FormatException: Input string was not in the correct format
[ERROR]:[UNITY] - System.Int32.Parse (System.String s)
[ERROR]:[UNITY] - HutongGames.PlayMaker.Actions.ConvertStringToInt.DoConvertStringToInt ()
[ERROR]:[UNITY] - HutongGames.PlayMaker.Actions.ConvertStringToInt.OnUpdate ()
[ERROR]:[UNITY] - HutongGames.PlayMaker.FsmState.OnUpdate ()
[ERROR]:[UNITY] - HutongGames.PlayMaker.Fsm.UpdateState (HutongGames.PlayMaker.FsmState state)
[ERROR]:[UNITY] - HutongGames.PlayMaker.Fsm.Update ()
[ERROR]:[UNITY] - PlayMakerFSM.Update ()
[ERROR]:[UNITY] -

light zodiac Jul 3, 2021, 10:06 AM

#

Pale court?

cedar hemlock Jul 3, 2021, 10:08 AM

#

_ _

#

i forgot to remove it

light zodiac Jul 3, 2021, 10:09 AM

#

Remove that and see

cedar hemlock Jul 3, 2021, 10:09 AM

#

did that already

#

i should have remove it from the list

#

done

floral blade Jul 3, 2021, 10:10 AM

#

i doubt CK is it, though you were messing with geo when it happened

#

highly suspect HowwowKnyight

cedar hemlock Jul 3, 2021, 10:11 AM

#

i'll try and if it is then i'll have to live with softlocks

floral blade Jul 3, 2021, 10:12 AM

#

is HowwowKnyight even on github?

cedar hemlock Jul 3, 2021, 10:12 AM

#

ah fook

#

it is howwoKnyight

#

shat

#

not fun

cedar hemlock Jul 3, 2021, 10:14 AM

#

floral blade is `HowwowKnyight` even on github?

no, i dont think so

#

i cant find it

#

big sad

floral blade Jul 3, 2021, 10:14 AM

#

download swapster, set your own rules to convert chunks of text into owo in replace.txt
for example if you add this:

ll=>ww
ni=>nyi

hollow knight becomes howwow knyight (and all other words matching the pattern)

cedar hemlock Jul 3, 2021, 10:15 AM

#

how do i even use github search

#

i try to find HowwowKnyight in pr's

#

but i can't

floral blade Jul 3, 2021, 10:16 AM

#

same

cedar hemlock Jul 3, 2021, 10:16 AM

#

it was added before frogcore

#

lets see when that ws added

floral blade Jul 3, 2021, 10:17 AM

#

if u want the modlinks commit you can just look at file file history / blame

cedar hemlock Jul 3, 2021, 10:17 AM

#

23 dec 2020

#

https://github.com/ricardosouzag/ModInstaller/commit/ca5e91ea0695152627a5e900fdf2586e9285565e#diff-04d391f154ab5f921a821895c975eb4bdbf6eb6f933ac74e3f99a006292c8c9f

#

why so long

#

nope not on github

#

sad

floral blade Jul 3, 2021, 10:20 AM

#

floral blade download swapster, set your own rules to convert chunks of text into owo in repl...

just do this, you'll have fun tuning the owo to your liking

#

and once you're happy with it, you could just make your own owo mod that follows those rules

primal latch Jul 3, 2021, 10:20 AM

#

Just use dnspy

cedar hemlock Jul 3, 2021, 10:21 AM

#

i am

floral blade Jul 3, 2021, 10:21 AM

#

primal latch Just use dnspy

or this >.> , this can work

primal latch Jul 3, 2021, 10:21 AM

#

I hate this mod. I looked at the code once. It is like unreadable

cedar hemlock Jul 3, 2021, 10:21 AM

#

hehe

#

funny

floral blade Jul 3, 2021, 10:21 AM

#

primal latch I hate this mod. I looked at the code once. It is like unreadable

i hope it's not hardcoded strings and actually rule based

primal latch Jul 3, 2021, 10:22 AM

#

I mean: all variables and functions also have OwO names

#

Why is owo to OwO an autocorrect feature?

#

I hate it

floral blade Jul 3, 2021, 10:22 AM

#

i mean if any mod should have OwO variable names it's that one

cedar hemlock Jul 3, 2021, 10:22 AM

#

primal latch Why is owo to OwO an autocorrect feature?

xD

cedar hemlock Jul 3, 2021, 10:23 AM

#

floral blade just do this, you'll have fun tuning the owo to your liking

but this will never do the same as howwowknyight

floral blade Jul 3, 2021, 10:24 AM

#

cedar hemlock but this will never do the same as howwowknyight

why ? it's all string replace in the end

cedar hemlock Jul 3, 2021, 10:24 AM

#

it adds things like:
OwO >w<
and stuff random

#

swapster is not random i hope

floral blade Jul 3, 2021, 10:24 AM

#

not yet

cedar hemlock Jul 3, 2021, 10:25 AM

#

#

is that what i'm looking for you think?

floral blade Jul 3, 2021, 10:25 AM

#

yep

#

R=>W
L=>W

cedar hemlock Jul 3, 2021, 10:26 AM

#

and this then:

#

{
                "N([AEIOU])",
                "NY$1"
            },
            {
                "N([aeiou])",
                "Ny$1"
            },
            {
                "n([aeiou])",
                "ny$1"
            },
            {
                "(?<!<b)r(?!>)",
                "w"
            },
            {
                "T[Hh]\\b",
                "F"
            },
            {
                "th\\b",
                "f"
            },
            {
                "T[Hh]([UI][^sS])",
                "F$1"
            },
            {
                "th([ui][^sS])",
                "f$1"
            },
            {
                "OVE\\b",
                "UV"
            },
            {
                "Ove\\b",
                "Uv"
            },
            {
                "ove\\b",
                "uv"
            }

#

how do i do that

floral blade Jul 3, 2021, 10:27 AM

#

no can do regex but atleast the first one is just

ni=>nyi
na=>nya
...

cedar hemlock Jul 3, 2021, 10:28 AM

#

and this would be impossible:

#

bool flag7 = owig.EndsWith("?") || (!flag4 && Random.value < 0.2f);
            if (flag7)
            {
                owig = owig.TrimEnd(HowwowKnyight.sepawatows);
                switch (Random.Range(0, 10))
                {
                case 0:
                    owig += " uwu";
                    break;
                case 1:
                    owig += " owo";
                    break;
                case 2:
                    owig += " UwU";
                    break;
                case 3:
                    owig += " OwO";
                    break;
                case 4:
                    owig += " >w<";
                    break;
                case 5:
                    owig += " ^w^";
                    break;
                case 6:
                case 7:
                    owig += " UwU";
                    break;
                default:
                    owig += "~";
                    break;
                }
            }
            return owig;

#

anyways imma try looking at it better later, but i have to go now

#

~~still no idea how it gets caused~~

floral blade Jul 3, 2021, 10:39 AM

#

cedar hemlock ```cs bool flag7 = owig.EndsWith("?") || (!flag4 && Random.value < 0.2f); ...

yep not possible to do this unless you do some trickery

floral blade Jul 3, 2021, 10:41 AM

#

cedar hemlock ```cs bool flag7 = owig.EndsWith("?") || (!flag4 && Random.value < 0.2f); ...

a shame they didn't write a utility to convert things like 'TrimEnd' to 'TwimEynd' in the main mod (oops didn't mean to ping!)

jolly oriole Jul 3, 2021, 10:46 AM

#

light zodiac Pale court?

That version does exactly nothing

jolly oriole Jul 3, 2021, 10:48 AM

#

fickle sparrow Rewriting most of the mod loader btw

shroompause

#

Hot reload of all mods when

light zodiac Jul 3, 2021, 10:51 AM

#

jolly oriole That version does exactly nothing

How dare you waste my 1540 byes of space

cedar hemlock Jul 3, 2021, 10:52 AM

#

floral blade a shame they didn't write a utility to convert things like 'TrimEnd' to 'TwimEy...

Oh dw about the ping

jolly oriole Jul 3, 2021, 11:17 AM

#

light zodiac How dare you waste my 1540 byes of space

Smh, not checking a mod before installing it

primal latch Jul 3, 2021, 11:25 AM

#

jolly oriole Hot reload of all mods when

Weren’t you working on that?

jolly oriole Jul 3, 2021, 11:44 AM

#

it's fucking awful

floral blade Jul 3, 2021, 12:32 PM

#

floral blade it scrolls using keyboard if i click the scrollbar before pressing the keys but ...

any one else who has implemented the mod menu / can share any insights on this ?

cedar hemlock Jul 3, 2021, 12:37 PM

#

cedar hemlock ~~still no idea how it gets caused~~

I have never had this before, and i just realized it has its own folder in mods, maybe deleting that/ its globalsettings fixes it?

#

I shall try later

floral blade Jul 3, 2021, 12:41 PM

#

sounds to me like at some point it adds some owofication to a string that is then attempted to be parsed as an Int

cedar hemlock Jul 3, 2021, 12:42 PM

#

Oh!

#

That would make sense

#

It tried to owo-ify the numbers in the bank

#

How would i fix that if i had the code?

floral blade Jul 3, 2021, 12:43 PM

#

i mean you could see if the string can be parsed into an Int, if yes don't owofy it

cedar hemlock Jul 3, 2021, 12:44 PM

#

~~is owo-ify a word lol~~

#

ok i'm really confused rn

#

that folder i talked about is completely empty

#

what is it for

#

which would i choose

HowwowKnyight_-_Microsoft_Visual_Studio_3-7-2021_14_58_03.png

#

Modding. or UnityEnigine.

#

nvm

#

what why does GetActiveScene() not exist

#

what even is scenemanager

#

this is a giant mess

#

what is Scenemanager

vocal spire Jul 3, 2021, 1:05 PM

#

Unity one or hk one?

cedar hemlock Jul 3, 2021, 1:06 PM

#

idk

#

i assume unity:

#

SceneManager.sceneLoaded -= new UnityAction<Scene, LoadSceneMode>(HowwowKnyight.ActiveSceneChangedHandwer);

vocal spire Jul 3, 2021, 1:07 PM

#

Try adding
using SceneManager = UnityEngine.SceneManagment;
to the top

cedar hemlock Jul 3, 2021, 1:07 PM

#

i've only got 4 errors now, 3 are Scenemanager

#

i only get 2 more errors

vocal spire Jul 3, 2021, 1:08 PM

#

Screenshot?

cedar hemlock Jul 3, 2021, 1:08 PM

#

there already is a using scenemanager

#

HowwowKnyight_-_Microsoft_Visual_Studio_3-7-2021_15_08_29.png

vocal spire Jul 3, 2021, 1:08 PM

#

I made a spelling error

jolly oriole Jul 3, 2021, 1:09 PM

#

cedar hemlock

maggotprime

cedar hemlock Jul 3, 2021, 1:09 PM

#

the 2 errors get fixed

jolly oriole Jul 3, 2021, 1:09 PM

#

make that line

using USceneManager = UnityEngine.SceneManagement.SceneManager;

and you should be good

cedar hemlock Jul 3, 2021, 1:09 PM

#

wait the 3 errors have changed

jolly oriole Jul 3, 2021, 1:10 PM

#

then you can have both hk scenemanager and unity one

#

without conflicts

cedar hemlock Jul 3, 2021, 1:10 PM

#

nope

jolly oriole Jul 3, 2021, 1:10 PM

#

just need to have the unity one be addressed with u at the front

cedar hemlock Jul 3, 2021, 1:10 PM

#

oh ye

#

that actually did it yay

#

only one error left

#

HowwowKnyight_-_Microsoft_Visual_Studio_3-7-2021_15_12_09.png

jolly oriole Jul 3, 2021, 1:13 PM

#

line 89

vocal spire Jul 3, 2021, 1:13 PM

#

Remove the
Stream stweam = null line

cedar hemlock Jul 3, 2021, 1:14 PM

#

i shouldn't be worried about yield break; not getting reached right?

jolly oriole Jul 3, 2021, 1:14 PM

#

i can't believe that that mod does sprite replacement in coroutines NotLikeThis

light zodiac Jul 3, 2021, 1:14 PM

#

floral blade any one else who has implemented the mod menu / can share any insights on this ?

See APIs code or my more saves branch (check modmenu.cs)

#

Both uses scroll bars

cedar hemlock Jul 3, 2021, 1:15 PM

#

i'm just going to build and hope for the best

fickle sparrow Jul 3, 2021, 1:16 PM

#

idk it might be scuffed

#

I'm gonna clean the scrollbar up at some point

cedar hemlock Jul 3, 2021, 1:17 PM

#

it does seem to have worked

fickle sparrow Jul 3, 2021, 1:17 PM

#

how is your handle broken

#

this aint it

light zodiac Jul 3, 2021, 1:18 PM

#

Handle isn't broken for moresaves

cedar hemlock Jul 3, 2021, 1:24 PM

#

floral blade i mean you could see if the string can be parsed into an Int, if yes don't owofy...

how would i even do that

vocal spire Jul 3, 2021, 1:25 PM

#

int.TryParse?

light zodiac Jul 3, 2021, 1:25 PM

#

Int32.try parse

primal latch Jul 3, 2021, 1:25 PM

#

jolly oriole i can't believe that that mod does sprite replacement in coroutines <:NotLikeThi...

Nervously starts laughing

vocal spire Jul 3, 2021, 1:25 PM

#

primal latch Nervously starts laughing

Fyremoth is fine

cedar hemlock Jul 3, 2021, 1:26 PM

#

vocal spire int.TryParse?

listen, i can 0 csharp what do you even mean with that

primal latch Jul 3, 2021, 1:26 PM

#

vocal spire Fyremoth is fine

We also do it in a coroutine

vocal spire Jul 3, 2021, 1:26 PM

#

cedar hemlock listen, i can 0 csharp what do you even mean with that

int.TryParse method

primal latch Jul 3, 2021, 1:26 PM

#

Why does coroutine auto correct to corpse stone?

vocal spire Jul 3, 2021, 1:26 PM

#

primal latch We also do it in a coroutine

It’s fine, sprite replacing occurs like one frame after we start it

primal latch Jul 3, 2021, 1:27 PM

#

Yeah

vocal spire Jul 3, 2021, 1:27 PM

#

I’ll move the stuff out of it if you want, don’t like hollow point compatibility called there anyways

light zodiac Jul 3, 2021, 1:27 PM

#

primal latch Why does coroutine auto correct to corpse stone?

Maybe you like corpses so that's why autocorrect likes that word

primal latch Jul 3, 2021, 1:27 PM

#

cedar hemlock

Why not use sfcore?

primal latch Jul 3, 2021, 1:27 PM

#

vocal spire I’ll move the stuff out of it if you want, don’t like hollow point compatibility...

Yeah.

cedar hemlock Jul 3, 2021, 1:27 PM

#

vocal spire int.TryParse method

so how would i put that in an if?
if (int.Tryparse(blabla) == true)
?

cedar hemlock Jul 3, 2021, 1:28 PM

#

primal latch Why not use sfcore?

i did not make this

jolly oriole Jul 3, 2021, 1:28 PM

#

primal latch Why not use sfcore?

because sfcore is there to add, not replace logos

primal latch Jul 3, 2021, 1:28 PM

#

Ah. You used dnspy.

primal latch Jul 3, 2021, 1:28 PM

#

jolly oriole because sfcore is there to add, not replace logos

Ok

cedar hemlock Jul 3, 2021, 1:28 PM

#

primal latch Ah. You used dnspy.

yup

vocal spire Jul 3, 2021, 1:28 PM

#

cedar hemlock so how would i put that in an if? `if (int.Tryparse(blabla) == true)` ?

if (int.TryParse(string, out int somethingy))
Add the == true part if you want, doesn’t matter

jolly oriole Jul 3, 2021, 1:28 PM

#

why tryparse, just parse and let it crash

cedar hemlock Jul 3, 2021, 1:28 PM

#

if (int.TryParse(string, out int _)) ?

cedar hemlock Jul 3, 2021, 1:29 PM

#

jolly oriole why tryparse, just parse and let it crash

well thats what happening rn and is causing a softlock

jolly oriole Jul 3, 2021, 1:29 PM

#

sad

vocal spire Jul 3, 2021, 1:29 PM

#

You can add a try around it, but if you want to continue with TryParse, do you ever need to use the parsed value?

cedar hemlock Jul 3, 2021, 1:30 PM

#

what does it output

#

always, or only if there are numbers?

vocal spire Jul 3, 2021, 1:30 PM

#

Well if you have a string 1
it gives a int 1

cedar hemlock Jul 3, 2021, 1:30 PM

#

i want, that if the string i give it contains a number, then ignore it

vocal spire Jul 3, 2021, 1:30 PM

#

If you have a string 2527384843
it gives a int 2527384843

vocal spire Jul 3, 2021, 1:31 PM

#

cedar hemlock i want, that if the string i give it contains a number, then ignore it

If (string.Contains(0) || string.Contains(1) ect) I think

#

Might have the wrong method name

cedar hemlock Jul 3, 2021, 1:31 PM

#

i don't understand shat of what i see here, so this is going to be pain

vocal spire Jul 3, 2021, 1:32 PM

#

vocal spire If (string.Contains(0) || string.Contains(1) ect) I think

If the string contains a number(have to code each number 0-9)

#

So
if (contains numbers)
continue

primal latch Jul 3, 2021, 1:32 PM

#

Just use regex

light zodiac Jul 3, 2021, 1:32 PM

#

vocal spire If the string contains a number(have to code each number 0-9)

make a list from 0 -9 and foreach the list

cedar hemlock Jul 3, 2021, 1:33 PM

#

so what i actually want is If !(string.Contains(0) || string.Contains(1) ect)

#

cus i want it to stop if theres a number

#

ok wait let me explain what i'm trying to do again

vocal spire Jul 3, 2021, 1:33 PM

#

cedar hemlock so what i actually want is `If !(string.Contains(0) || string.Contains(1) ect)`

Well if you do it without the ! Then you can add a line with just return after the if, but I suggest Mul’s idea

#

No I understand, if it has numbers, don’t do code

#

I’ll just rewrite it

cedar hemlock Jul 3, 2021, 1:35 PM

#

I want, that if the string i give it contains a number, dont OwO-ify it
Cus it OwO-ify's numbers rn and its creating softlock bc of this:

[ERROR]:[UNITY] - FormatException: Input string was not in the correct format
[ERROR]:[UNITY] - System.Int32.Parse (System.String s)
[ERROR]:[UNITY] - HutongGames.PlayMaker.Actions.ConvertStringToInt.DoConvertStringToInt ()
[ERROR]:[UNITY] - HutongGames.PlayMaker.Actions.ConvertStringToInt.OnUpdate ()
[ERROR]:[UNITY] - HutongGames.PlayMaker.FsmState.OnUpdate ()
[ERROR]:[UNITY] - HutongGames.PlayMaker.Fsm.UpdateState (HutongGames.PlayMaker.FsmState state)
[ERROR]:[UNITY] - HutongGames.PlayMaker.Fsm.Update ()
[ERROR]:[UNITY] - PlayMakerFSM.Update ()
[ERROR]:[UNITY] -

vocal spire Jul 3, 2021, 1:36 PM

#

int[] nums = new int [] {0,1,2,3,4,5,6,7,8,9};
foreach (int num in nums)
if (orig.Contains(num.ToString())
return orig;

jolly oriole Jul 3, 2021, 1:37 PM

#

Regex r = new Regex(@"\d", RegexOptions.IgnoreCase);
MatchCollection matches = r.Matches(inputString);
if (matches.Count > 0)
{
  // number in string
}
else
{
  // no number in string
}

cedar hemlock Jul 3, 2021, 1:38 PM

#

which one works better

#

two people tell me to do complete opposite things xD

primal latch Jul 3, 2021, 1:38 PM

#

Regex

cedar hemlock Jul 3, 2021, 1:38 PM

#

ok

primal latch Jul 3, 2021, 1:38 PM

#

Nobody will understand it later

cedar hemlock Jul 3, 2021, 1:39 PM

#

even better

primal latch Jul 3, 2021, 1:39 PM

#

Not like that code was readable to start with

cedar hemlock Jul 3, 2021, 1:39 PM

#

time for RedFrog to be ignored again zote

jolly oriole Jul 3, 2021, 1:40 PM

#

use whichever you want to use, both have pros and cons

cedar hemlock Jul 3, 2021, 1:40 PM

#

i'm just going to place random if's everywhere and pray it works

#

wow, i have no idea what is going on here

jolly oriole Jul 3, 2021, 1:44 PM

#

have you tried learning c#?

cedar hemlock Jul 3, 2021, 1:46 PM

#

its not really c#'s problem

#

but i get confused when LanguageGetHook is WanguageGet

jolly oriole Jul 3, 2021, 1:47 PM

#

ctrl+r, ctrl+r, then rename to LanguageGet

cedar hemlock Jul 3, 2021, 1:47 PM

#

and the random comments from DNSpy dont help either

#

i mean, what am i supposed to do with this:
// Token: 0x06000008 RID: 8 RVA: 0x000021F8 File Offset: 0x000003F8

jolly oriole Jul 3, 2021, 1:48 PM

#

literally nothing, just ignore it

cedar hemlock Jul 3, 2021, 1:48 PM

#

then why is it there wai

primal latch Jul 3, 2021, 1:50 PM

#

It is the memory location relative to the file where the function was found

cedar hemlock Jul 3, 2021, 1:50 PM

#

what is this:

Error    CS0120    An object reference is required for the non-static field, method, or property

#

why can't i just put
Regex r = new Regex(@"\d", RegexOptions.IgnoreCase);
at the top and be done

#

private static string WanguageGet(HowwowKnyight.WanguageGetWef owig, ModHooks instance, string key, string tabwe)
        {
            string owig2 = owig(instance, key, tabwe);
            Regex r = new Regex(@"\d", RegexOptions.IgnoreCase); 
            MatchCollection matches = r.Matches(owig2);
            if (matches.Count > 0)
            {
                return (owig2);
            }
            else
            {
                return HowwowKnyight.UWUfyStwing(HowwowKnyight.PwepwocessDiawogeOwO(owig2));
            }
        }

#

will that work

#

or do i need to change owig2 to owig

jolly oriole Jul 3, 2021, 1:58 PM

#

owig2 should work

cedar hemlock Jul 3, 2021, 1:58 PM

#

lets try it

#

it seems to work, but its random so i have no way to be sure

#

oh wait i can just log something if theres a number

#

why do i have to put base. before Log

#

and it doesn't even work in static classes

#

pain

#

Error    CS0120    An object reference is required for the non-static field, method, or property 'Loggable.Log(string)'

jolly oriole Jul 3, 2021, 2:05 PM

#

you can always Modding.Logger.Log(), otherwise the mod may have an instance field, over which you can also log

cedar hemlock Jul 3, 2021, 2:10 PM

#

bruh my vs is drunk

#

how would i change the reference paths

#

i saw someone do that once

#

and i have no idea how

floral blade Jul 3, 2021, 2:19 PM

#

light zodiac See APIs code or my more saves branch (check modmenu.cs)

I checked mapi code didn't find much different infact my mods menu also has the handle scrolling up magically bug

cedar hemlock Jul 3, 2021, 2:19 PM

#

ehm

HowwowKnyight_-_Microsoft_Visual_Studio_3-7-2021_16_19_41.png

#

i have tried multiple times

floral blade Jul 3, 2021, 2:20 PM

#

light zodiac Handle isn't broken for moresaves

I'll check moresave once

cedar hemlock Jul 3, 2021, 2:38 PM

#

https://github.com/ricardosouzag/ModInstaller/pull/105 done

copper nacelle Jul 3, 2021, 3:58 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/pull/59 why

GitHub

Updated ci version to .75 again by mandar1jn · Pull Request #59 · H...

#

@primal latch ??

vocal spire Jul 3, 2021, 4:08 PM

#

Doesn’t it already work on 1.5?

#

Nvm I’m on .72

primal latch Jul 3, 2021, 4:16 PM

#

copper nacelle https://github.com/HollowKnight-Modding/HollowKnight.Modding/pull/59 why

Well, my pr was accepted but if you look at the file and file history my changes don’t show up

copper nacelle Jul 3, 2021, 4:16 PM

#

yeah they do

primal latch Jul 3, 2021, 4:16 PM

#

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/pull/54/files

GitHub

updated CI to version 1.5.75.11827 by mandar1jn · Pull Request #54 ...

#

The .75 changes don’t show up

copper nacelle Jul 3, 2021, 4:26 PM

#

have you tried scrolling down

cobalt crescent Jul 3, 2021, 5:01 PM

#

hey i wanted to make a custom skin for hollow knight, but i've never done any form of coding before, does anyone have like a video I can watch or

cedar hemlock Jul 3, 2021, 5:02 PM

#

Custom knight?

#

Just go to the default folder, make a copy of it and edit the png's

#

All editable png's are there

cobalt crescent Jul 3, 2021, 5:03 PM

#

oh awesome ty!

floral blade Jul 3, 2021, 5:12 PM

#

@light zodiac sadness wai

cedar hemlock Jul 3, 2021, 5:13 PM

#

Big sad

primal latch Jul 3, 2021, 5:19 PM

#

copper nacelle have you tried scrolling down

Yes I have

copper nacelle Jul 3, 2021, 5:20 PM

#

have you tried scrolling up

floral blade Jul 3, 2021, 5:21 PM

#

okay so, it's definitely a thing with the scroll setup itself

primal latch Jul 3, 2021, 5:28 PM

#

copper nacelle have you tried scrolling up

Yeah. I saw it. I just wanted to make a point

fickle sparrow Jul 3, 2021, 5:40 PM

#

floral blade okay so, it's definitely a thing with the scroll setup itself

i need to change some code and that'll include a fix for the scrolling

#

you know

#

im not convinced I ever made the thing actually scroll on selection

#

might have been a dream

floral blade Jul 3, 2021, 5:55 PM

#

fickle sparrow i need to change some code and that'll include a fix for the scrolling

thank you !

floral blade Jul 3, 2021, 5:56 PM

#

fickle sparrow im not convinced I ever made the thing actually scroll on selection

i could not find any code that seemed to do that either

fickle sparrow Jul 3, 2021, 6:09 PM

#

I know it was working at some point

#

but I think I found some weird stuff with the old navigation code

light zodiac Jul 3, 2021, 7:44 PM

#

floral blade okay so, it's definitely a thing with the scroll setup itself

maggotprime

cedar hemlock Jul 3, 2021, 7:51 PM

#

Woooww

#

Thats alot of custom knights

floral blade Jul 3, 2021, 7:51 PM

#

i literally just copy pasted the dll like 10 times

light zodiac Jul 3, 2021, 7:52 PM

#

I'm surprised moresaves didn't have a failed to load

floral blade Jul 3, 2021, 7:53 PM

#

probably better code in there lol

light zodiac Jul 3, 2021, 7:55 PM

#

This is what I did for more saves
if (Instance == null) Instance = this;

primal latch Jul 3, 2021, 7:57 PM

#

Fyremoth does the same.

floral blade Jul 3, 2021, 7:58 PM

#

the failed to load is trying to preload an object multiple times for the same "mod" in mapi i think lol

floral blade Jul 3, 2021, 8:00 PM

#

light zodiac This is what I did for more saves `if (Instance == null) Instance = this;`

would this avoid that?

light zodiac Jul 3, 2021, 8:00 PM

#

That's what it looks like

#

But thkshadeidk tbh

floral blade Jul 3, 2021, 8:04 PM

#

imma try adding it

warped elbow Jul 3, 2021, 10:14 PM

#

How do you make mods?

#

You = people

jolly oriole Jul 3, 2021, 10:15 PM

#

https://radiance.host/apidocs/Getting-Started.html

copper nacelle Jul 3, 2021, 10:15 PM

#

kidnap 3 modders and work them to death

vocal spire Jul 3, 2021, 10:18 PM

#

~~Can confirm am modder~~

rough pulsar Jul 3, 2021, 10:27 PM

#

No don't

radiant basin Jul 3, 2021, 11:34 PM

#

hehe

ornate rivet Jul 3, 2021, 11:49 PM

#

omg you're doing a calamity anne from amphibia skin?

#

that's so cool

jolly oriole Jul 3, 2021, 11:50 PM

#

for a second i wondered who you were, then i read the name

#

but nice dashmaster grimm

ornate rivet Jul 3, 2021, 11:52 PM

#

dw I dont know who I am either

radiant basin Jul 4, 2021, 12:55 AM

#

i managed to get the name work by myself yay

jolly oriole Jul 4, 2021, 1:22 AM

#

AdditionalMaps, BlindRadiance, BossModCore, CustomBgm, CustomSaveArt, DreamKing, EnemyChanger, FireIsSmolBrain, FuryFix, GeoLog, HKHKHKHKHK, LanguageSupport, ~~LockZoteTheme~~, MenuThemesInGame, MetroidVania, MoreHealing, NailsmithBackPay, TestingStuff, PlayCountLog, PvpArena, ~~RadiantMenu~~, RedoBirthplace, ResetCharmNotches, SFCore & TestOfTeamwork ported to 1.5, still doing others as well and still need to upload those to github

nimble lake Jul 4, 2021, 2:16 AM

#

radiant basin hehe

cursed

radiant basin Jul 4, 2021, 2:19 AM

#

this is the original btw im just making it a reality
https://amp.reddit.com/r/HollowKnightMemes/comments/adbogg/cursed_grimm/

jolly oriole Jul 4, 2021, 2:22 AM

#

i can't believe they fucking fixed it

deep wave Jul 4, 2021, 2:23 AM

#

excuse me????????????? what????????? tc????????

fickle sparrow Jul 4, 2021, 2:24 AM

#

thats so sad

#

they hate thorn yump

light zodiac Jul 4, 2021, 2:25 AM

#

Did they fix the one on top of this area too?

jolly oriole Jul 4, 2021, 2:27 AM

#

yes

radiant basin Jul 4, 2021, 2:28 AM

#

damn

deep wave Jul 4, 2021, 2:30 AM

#

huh, did they fix pop thornwalk?

nimble lake Jul 4, 2021, 2:31 AM

#

jolly oriole i can't believe they fucking fixed it

bruh

vocal spire Jul 4, 2021, 3:13 AM

#

NOOOOOOOOOO

#

~~im depression now~~

jolly jungle Jul 4, 2021, 4:38 AM

#

radiant basin hehe

Glorious, ping me with the final thing please wai

cedar hemlock Jul 4, 2021, 11:31 AM

#

<@&283547423706447872>

primal latch Jul 4, 2021, 11:40 AM

#

What happened?

cedar hemlock Jul 4, 2021, 11:41 AM

#

CSGO

#

csgo happened

primal latch Jul 4, 2021, 11:41 AM

#

Ah

#

Let me guess. He was quitting and giving away skins?

cedar hemlock Jul 4, 2021, 11:42 AM

#

how did you guess

primal latch Jul 4, 2021, 11:42 AM

#

I have been on the internet for longer then just today

cedar hemlock Jul 4, 2021, 11:45 AM

#

judging by the fact i've seen more messages from you then only the ones you just send, you're totally right

jolly oriole Jul 4, 2021, 12:14 PM

#

jolly oriole AdditionalMaps, BlindRadiance, BossModCore, CustomBgm, CustomSaveArt, DreamKing,...

gaming hotdogHotdog

light zodiac Jul 4, 2021, 12:19 PM

#

damn

light zodiac Jul 4, 2021, 12:19 PM

#

jolly oriole gaming <:hotdogHotdog:676965312792494101>

~~gaming~~ coding

jolly oriole Jul 4, 2021, 12:20 PM

#

oh god, i have errors

#

but nice, most seems to work

jolly jungle Jul 4, 2021, 12:31 PM

#

Where does SOUL-from-dreamnail happen?

cedar hemlock Jul 4, 2021, 12:32 PM

#

when you Dnail an enemy?

jolly jungle Jul 4, 2021, 12:33 PM

#

yeah that

#

Nevermind I'll hunt it down myself

cedar hemlock Jul 4, 2021, 12:34 PM

#

good luck with your hunting

jolly oriole Jul 4, 2021, 12:44 PM

#

no errors anymore

#

time to commit

nimble lake Jul 4, 2021, 12:58 PM

#

jolly oriole but nice, most seems to work

that’s an incredible amount of unavailable mods, wow

light zodiac Jul 4, 2021, 12:58 PM

#

why unavailable?

#

he just said he'll commit

nimble lake Jul 4, 2021, 12:59 PM

#

nah i’m talking about the mods he have installed

#

like fire is smol brain

#

unavailable

#

not in loader

vocal spire Jul 4, 2021, 1:00 PM

#

Is that the one with the soul totem in dirtmouth

nimble lake Jul 4, 2021, 1:00 PM

#

well that’s just one example

#

among the many others he has

vocal spire Jul 4, 2021, 1:01 PM

#

Dream king, more healing

nimble lake Jul 4, 2021, 1:01 PM

#

like all of those

#

save for a few

#

and i guess also with how debug mod is a much more updated version not in the loader

jolly oriole Jul 4, 2021, 1:02 PM

#

smh, calling me out

#

that's what mul linked here some time ago

nimble lake Jul 4, 2021, 1:02 PM

#

kinda weird though
some mods are getting lots of updates and commits, but never get updated in the loader

jolly oriole Jul 4, 2021, 1:03 PM

#

currently because it's 1432 and these updates are 1.5

light zodiac Jul 4, 2021, 1:03 PM

#

nimble lake and i guess also with how debug mod is a much more updated version not in the lo...

i made pr but no one push sadcowgrub

vocal spire Jul 4, 2021, 1:03 PM

#

I made a pr for 1.5 support but no one care

light zodiac Jul 4, 2021, 1:03 PM

#

then i made more update and didn't even push cuz no one care

nimble lake Jul 4, 2021, 1:04 PM

#

smh smashing my head

light zodiac Jul 4, 2021, 1:05 PM

#

https://github.com/TheMulhima/HollowKnight.DebugMod/releases/download/v1.4.2-1432/DebugMod.dll

#

if you want to use (for 1432)

jolly oriole Jul 4, 2021, 1:08 PM

#

i pushed a bit

light zodiac Jul 4, 2021, 1:12 PM

#

something doesnt feel right

jolly oriole Jul 4, 2021, 1:13 PM

#

fuck

jolly jungle Jul 4, 2021, 1:14 PM

#

nimble lake like all of those

nimble lake Jul 4, 2021, 1:14 PM

#

yea that’s an example

jolly oriole Jul 4, 2021, 1:15 PM

#

that's made for fireb0rn, but i can upload it to github

#

https://github.com/SFGrenade/FireIsSmolBrain

light zodiac Jul 4, 2021, 1:22 PM

#

why did you make this

jolly oriole Jul 4, 2021, 1:23 PM

#

made for fireb0rn

light zodiac Jul 4, 2021, 1:23 PM

#

hard to guess that damn

jolly oriole Jul 4, 2021, 1:29 PM

#

done now

#

i think i can automatically make myself ready-to-release packages on windows in post build event

light zodiac Jul 4, 2021, 1:40 PM

#

HKHKHKHKHK 👀

jolly oriole Jul 4, 2021, 1:41 PM

#

inspired by VVVVVVVVV, but some parts are very funky

jolly oriole Jul 4, 2021, 1:59 PM

#

csproj god 56, how can i write the output of a command to a file in postbuildevent, kinda want the output of

$(certUtil -hashfile "$(ZipFileLocation)" SHA256)[1] -replace " ",""

written to a file so i can copy paste that easier to modlinks and release description

primal latch Jul 4, 2021, 2:02 PM

#

jolly jungle

I thought it was mocking Fyremoth

jolly jungle Jul 4, 2021, 2:03 PM

#

lmao

primal latch Jul 4, 2021, 2:04 PM

#

Well, with grenade pushing all his mods like 1/4 of the mod loader has been update to 1.5

jolly oriole Jul 4, 2021, 2:04 PM

#

you do know i have like 4 mods on the modinstaller

primal latch Jul 4, 2021, 2:04 PM

#

Wait. Are all the others not on the installer?

#

My bad

jolly oriole Jul 4, 2021, 2:05 PM

#

oh my bad

#

i have 5 on the modinstaller

#

but yea, all others weren't/aren't on the modinstaller

primal latch Jul 4, 2021, 2:06 PM

#

Ok

#

So, what is still in the work that would delay the release of the 1.5 mapi to the installer? The API seems stable and I don’t think any important mods are in the work to be ported to 1.5 that we are waiting for.

jolly oriole Jul 4, 2021, 2:11 PM

#

the modinstaller

primal latch Jul 4, 2021, 2:11 PM

#

Ah. Yeah.

#

What has to be done to it?

#

I’m in support for multi patch support, but not in the way frog did it. Would there be a way to split it up into multiple files? 1 for every version

jolly oriole Jul 4, 2021, 2:16 PM

#

the way frog has a pr for is one way, but i had some texts between me and 56 (i think a few things also were here, idk).
And out came ideas for a completely new modinstaller that is not SHA1 based for versioning, but has an internal database of installed mods and their versions.
That way sideloading would be difficult, but idrc.
Also changed is SHA1 -> SHA256 and also not for individual files, but the zip download itself, to verify that the download is unchanged.
Also both of us didn't want to actually deal with making mods for multiple patches.
Which is all why the new modlinks repo is the way it is

primal latch Jul 4, 2021, 2:17 PM

#

Ah. What do you mean with side loading?

#

Does that mean it gets harder to develop mods?

jolly oriole Jul 4, 2021, 2:18 PM

#

side loading in this case would be manually moving mods in the mods folder

primal latch Jul 4, 2021, 2:18 PM

#

So yes. Developing a mod would get more difficult

floral blade Jul 4, 2021, 2:19 PM

#

jolly oriole side loading in this case would be manually moving mods in the mods folder

i hope this would not impact mapi but only the modinstaller ?

jolly oriole Jul 4, 2021, 2:19 PM

#

only the modinstaller

primal latch Jul 4, 2021, 2:22 PM

#

How significantly would this impact testing a build of an in development mod?

fickle sparrow Jul 4, 2021, 2:22 PM

#

someone test the updated mod loader for me ty

📎 Assembly-CSharp.dll

primal latch Jul 4, 2021, 2:22 PM

#

What does it do?

fickle sparrow Jul 4, 2021, 2:22 PM

#

im like 99% sure it works

#

it loads mods

#

I just rewrote it

#

to not be cursed af

floral blade Jul 4, 2021, 2:24 PM

#

primal latch How significantly would this impact testing a build of an in development mod?

since it doesnt impact mapi i would guess not at all ?

primal latch Jul 4, 2021, 2:24 PM

#

jolly oriole side loading in this case would be manually moving mods in the mods folder

This is how I test my mods

#

How about you?

jolly oriole Jul 4, 2021, 2:25 PM

#

only how it's displayed in the modinstaller, but idk if 56 is working on it and if a method of manually scanning the mods folder to update the version manually maybe is considered

jolly oriole Jul 4, 2021, 2:28 PM

#

fickle sparrow someone test the updated mod loader for me ty

is that preloading in serial?

fickle sparrow Jul 4, 2021, 2:29 PM

#

hm?

jolly oriole Jul 4, 2021, 2:30 PM

#

is the preloading done in serial? looks like it in dnspy

fickle sparrow Jul 4, 2021, 2:30 PM

#

in serial what

jolly oriole Jul 4, 2021, 2:30 PM

#

serial, one after another

fickle sparrow Jul 4, 2021, 2:30 PM

#

oh

#

probably idk

#

I kept the preloading code the same

jolly oriole Jul 4, 2021, 2:30 PM

#

wait what

#

do you have a testing branch so i don't have to look at this garbage decomp?

fickle sparrow Jul 4, 2021, 2:31 PM

#

no changes

#

I do not yet

jolly oriole Jul 4, 2021, 2:32 PM

#

wait a second, i need to check something

#

idk if it looks anything like this for you

fickle sparrow Jul 4, 2021, 2:33 PM

#

thats a coroutine

#

or rather a generator

#

none of the preloading code changed

jolly oriole Jul 4, 2021, 2:34 PM

#

ok, compilation just makes this ass to look at in dnspy

fickle sparrow Jul 4, 2021, 2:34 PM

#

yeah it compiles to a state machine

jolly oriole Jul 4, 2021, 2:34 PM

#

now i just need to find this method that is in another method

#

ok, can't look at the code for it, but if the actual preloading didn't change i think it should be good

fickle sparrow Jul 4, 2021, 2:39 PM

#

yeah I didn't change that

primal latch Jul 4, 2021, 2:39 PM

#

jolly oriole ok, compilation just makes this ass to look at in dnspy

Just use ILspy

fickle sparrow Jul 4, 2021, 2:39 PM

#

pauseshroom

jolly oriole Jul 4, 2021, 2:40 PM

#

don't have it installed

primal latch Jul 4, 2021, 2:40 PM

#

Dnspy has been discontinued

jolly oriole Jul 4, 2021, 2:40 PM

#

archived*

primal latch Jul 4, 2021, 2:40 PM

#

But dnspy does look beter then ILspy

fickle sparrow Jul 4, 2021, 2:40 PM

#

dnspy is so much better than ilspy

#

its unreal

primal latch Jul 4, 2021, 2:40 PM

#

jolly oriole archived*

Kinda the same

jolly oriole Jul 4, 2021, 2:43 PM

#

can't believe ilspy doesn't have a dark mode

floral blade Jul 4, 2021, 2:44 PM

#

jolly oriole can't believe ilspy doesn't have a dark mode

it does ?

primal latch Jul 4, 2021, 2:44 PM

#

It does

jolly oriole Jul 4, 2021, 2:44 PM

#

where

#

oih

primal latch Jul 4, 2021, 2:44 PM

#

Click the moon icon

jolly oriole Jul 4, 2021, 2:44 PM

#

why isn't it in the fucking options

floral blade Jul 4, 2021, 2:45 PM

#

is a dropdown for me

jolly oriole Jul 4, 2021, 2:45 PM

#

not even normal ilspy layout lets me view the state machine thing

#

fuck this, uninstalling

fickle sparrow Jul 4, 2021, 2:47 PM

#

its not trivial to decompile a generator

jolly oriole Jul 4, 2021, 2:48 PM

#

yea, can look at it in il but i don't want to look at it in il

fickle sparrow Jul 4, 2021, 2:52 PM

#

making a branch

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/tree/loader-rework\

jolly oriole Jul 4, 2021, 2:53 PM

#

the backslash is ruining things

fickle sparrow Jul 4, 2021, 2:54 PM

#

what backslash

jolly oriole Jul 4, 2021, 2:54 PM

#

wait what

fickle sparrow Jul 4, 2021, 2:54 PM

#

50948995f66bb648

cedar hemlock Jul 4, 2021, 2:54 PM

#

Modding.Logger.Log("Found something usefull"); this should log something in modlog right?

fickle sparrow Jul 4, 2021, 2:54 PM

#

it is better to use the Log methods on your mod instance

#

because it will automatically prefix it with your mod name

cedar hemlock Jul 4, 2021, 2:55 PM

#

Error    CS0120    An object reference is required for the non-static field, method, or property 'Loggable.Log(string)'
``` ;-;

jolly oriole Jul 4, 2021, 2:55 PM

#

fickle sparrow <:50948995f66bb648:797362953141747714>

🥴

fickle sparrow Jul 4, 2021, 2:56 PM

#

🥴

#

I did press backslash at the same frame I sent the message

#

cause typing is hard

jolly oriole Jul 4, 2021, 2:57 PM

#

smh, not signing commits

cedar hemlock Jul 4, 2021, 2:57 PM

#

fickle sparrow because it will automatically prefix it with your mod name

but it should still put atleast something in modlog right?

fickle sparrow Jul 4, 2021, 2:57 PM

#

yeah sure

cedar hemlock Jul 4, 2021, 2:57 PM

#

well it doesn't 🥴

#

and i'm 100% sure it gets called

fickle sparrow Jul 4, 2021, 2:58 PM

#

clearly it isn't

#

or you're looking in the wrong place

jolly oriole Jul 4, 2021, 2:58 PM

#

i love how that commit is titled "Rework the mod loader code" and the first thing i see is something for the mod menus

fickle sparrow Jul 4, 2021, 2:58 PM

#

yeah I did that at the same time

jolly oriole Jul 4, 2021, 2:58 PM

#

making me scroll shroompause

fickle sparrow Jul 4, 2021, 2:58 PM

#

look

#

if I don't start the changes that someone asks for

cedar hemlock Jul 4, 2021, 2:59 PM

#

fickle sparrow clearly it isn't

if (matches.Count > 0)
            {
                Modding.Logger.Log("Theres a number here!");
                //No longer needed, it worked! OwO
                return (text);
            }
            else
            {
                Modding.Logger.Log("Found something usefull");
                return UWUfyStwing(PwepwocessDiawoge(text));
            }
``` It has 2 options, either do this if or do the else right?
And i know that it does `return UWUfyStwing(PwepwocessDiawoge(text));`, cus the text in-game changes.

fickle sparrow Jul 4, 2021, 2:59 PM

#

I will forget it within like an hour

#

ModLog.txt

cedar hemlock Jul 4, 2021, 3:00 PM

#

yes

jolly oriole Jul 4, 2021, 3:00 PM

#

i can't believe there was a whitespace

cedar hemlock Jul 4, 2021, 3:00 PM

#

whats with it

fickle sparrow Jul 4, 2021, 3:00 PM

#

the log

#

I formatted the whole file

#

cause it was mildly messy

#

idk what to say cause the logger isn't broken

cedar hemlock Jul 4, 2021, 3:01 PM

#

i look in modlog, and the ingame console by the api, and theres nothing

fickle sparrow Jul 4, 2021, 3:02 PM

#

idk then

jolly oriole Jul 4, 2021, 3:02 PM

#

look in player.log to see which thing errored out

fickle sparrow Jul 4, 2021, 3:03 PM

#

very true

cedar hemlock Jul 4, 2021, 3:05 PM

#

what would it look like you think?

#

a keyword that would be in it cus this log is huge

jolly oriole Jul 4, 2021, 3:06 PM

#

exception

vocal spire Jul 4, 2021, 3:06 PM

#

Just search for the class name containing the method that failed or the method that failed or the method calling the method that failed or the class containing the method calling the method that failed

cedar hemlock Jul 4, 2021, 3:06 PM

#

i see an NRE, i'll post it here

#

NullReferenceException: Object reference not set to an instance of an object
  at ActionButtonIconBase.GetButtonIcon (HeroActionButton actionButton) [0x00000] in <filename unknown>:0 
  at ActionButtonIconBase.RefreshButtonIcon () [0x00000] in <filename unknown>:0 
  at ActionButtonIconBase.OnEnable () [0x00000] in <filename unknown>:0 
UnityEngine.GameObject:SetActive(Boolean)
GameCameras:StartScene()
GameCameras:SceneInit()
GameManager:BeginScene()
GameManager:LevelActivated(Scene, Scene)
UnityEngine.SceneManagement.SceneManager:Internal_ActiveSceneChanged(Scene, Scene)
 
(Filename:  Line: -1)

jolly oriole Jul 4, 2021, 3:07 PM

#

nothing by mapi

cedar hemlock Jul 4, 2021, 3:07 PM

#

vocal spire Just search for the class name containing the method that failed or the method t...

i'll try that

vocal spire Jul 4, 2021, 3:07 PM

#

I do it all the time with fyremoth

cedar hemlock Jul 4, 2021, 3:07 PM

#

nothing

vocal spire Jul 4, 2021, 3:08 PM

#

Then it didn’t have an exception

cedar hemlock Jul 4, 2021, 3:08 PM

#

neither the name of the class, or the name of the method

copper nacelle Jul 4, 2021, 3:08 PM

#

among us suicide

jolly oriole Jul 4, 2021, 3:08 PM

#

give player log

copper nacelle Jul 4, 2021, 3:08 PM

#

use debug.log if you don't trust the modding logger

cedar hemlock Jul 4, 2021, 3:08 PM

#

i'll try logging to player_log instead of modlog

copper nacelle Jul 4, 2021, 3:08 PM

#

it's gonna give the same thing though

jolly oriole Jul 4, 2021, 3:08 PM

#

give player log, let me search in it

cedar hemlock Jul 4, 2021, 3:09 PM

#

jolly oriole give player log

would this one be it? i just noticed it has a different name so i could be looking at the wrong file

📎 output_log.txt

jolly oriole Jul 4, 2021, 3:09 PM

#

output_log is from 1432

cedar hemlock Jul 4, 2021, 3:09 PM

#

oh ok this is the right one then

#

the method is: WanguageGet
the class is: HowwowKnyight
the namespace is: HowwowKnyight
the file is: HowwowKnyight.dll/ HowwowKnyight.cs

copper nacelle Jul 4, 2021, 3:11 PM

#

my eyes

cedar hemlock Jul 4, 2021, 3:11 PM

#

hehe

jolly oriole Jul 4, 2021, 3:12 PM

#

are you making a mod for 1432 or 1.5

vocal spire Jul 4, 2021, 3:12 PM

#

Look at player_log if 1.5

cedar hemlock Jul 4, 2021, 3:12 PM

#

1432

floral blade Jul 4, 2021, 3:13 PM

#

Yuri i have a feature request for modmenu, TBH i'm not sure if it should be handled by the api itself but, horizontalOptions don't have a way to go "back to previous option" using a mouse but using a kb / controller one can go back, would it make sense to make the < & > icons be buttons ?

fickle sparrow Jul 4, 2021, 3:13 PM

#

idk

#

if you are using a mouse its implied you can use a keyboard tbh

#

I'll put it on my backlog

#

cause its a good solution

#

it just requires effort to make it look nice

jolly oriole Jul 4, 2021, 3:14 PM

#

cedar hemlock ```cs if (matches.Count > 0) { Modding.Logger.Log("T...

nothing that exceptionally is in the output log

floral blade Jul 4, 2021, 3:14 PM

#

fickle sparrow I'll put it on my backlog

thank you !

cedar hemlock Jul 4, 2021, 3:16 PM

#

jolly oriole nothing that exceptionally is in the output log

oh bruh i'm sorry i was being dumb, and used the wrong dll knightbonk

vocal spire Jul 4, 2021, 3:16 PM

#

Nice

primal latch Jul 4, 2021, 3:17 PM

#

hey. Remember that conversation that serialising settings and writing to a file can't fail? It just did

vocal spire Jul 4, 2021, 3:17 PM

#

Fun

fickle sparrow Jul 4, 2021, 3:17 PM

#

yeah sure

#

thats your mods problem

vocal spire Jul 4, 2021, 3:17 PM

#

primal latch hey. Remember that conversation that serialising settings and writing to a file ...

~~Remember that one conversation that we just had?~~, bringing it up because idk

primal latch Jul 4, 2021, 3:17 PM

#

fickle sparrow yeah sure

Yeah. I just checked the globalsettings file and it is empty

vocal spire Jul 4, 2021, 3:18 PM

#

Fun

primal latch Jul 4, 2021, 3:18 PM

#

vocal spire ~~Remember that one conversation that we just had?~~, bringing it up because idk

I wasn't talking about Fyremoth

vocal spire Jul 4, 2021, 3:18 PM

#

Kool

fickle sparrow Jul 4, 2021, 3:18 PM

#

I mean what did you do

vocal spire Jul 4, 2021, 3:18 PM

#

Which mod

fickle sparrow Jul 4, 2021, 3:18 PM

#

I have never encountered this error

vocal spire Jul 4, 2021, 3:18 PM

#

Null globalsettings prob

fickle sparrow Jul 4, 2021, 3:18 PM

#

so true

vocal spire Jul 4, 2021, 3:18 PM

#

I think I’ve seen it before

fickle sparrow Jul 4, 2021, 3:18 PM

#

luckily there is fallback to defaulting the settings file

#

FeelsOkayMan

#

so the mod loader shouldn't crash

#

in fact if theres an error loading the file it wont even call OnLoadGlobalSettings

primal latch Jul 4, 2021, 3:22 PM

#

fickle sparrow so the mod loader shouldn't crash

but it does

copper nacelle Jul 4, 2021, 3:23 PM

#

go on

#

where's the log

#

because there's a nice try catch you know

primal latch Jul 4, 2021, 3:23 PM

#

📎 ModLog.txt

jolly oriole Jul 4, 2021, 3:23 PM

#

player.log

primal latch Jul 4, 2021, 3:24 PM

#

📎 Player.log

vocal spire Jul 4, 2021, 3:25 PM

#

Looks pretty null reference exception not try catched to me

copper nacelle Jul 4, 2021, 3:25 PM

#

oh not the mod one

fickle sparrow Jul 4, 2021, 3:26 PM

#

what the fuck happened

copper nacelle Jul 4, 2021, 3:26 PM

#

it does that

fickle sparrow Jul 4, 2021, 3:26 PM

#

how did this mess up

copper nacelle Jul 4, 2021, 3:26 PM

#

it breaks all the save loading

fickle sparrow Jul 4, 2021, 3:26 PM

#

pauseshroom

vocal spire Jul 4, 2021, 3:26 PM

#

Fun

fickle sparrow Jul 4, 2021, 3:28 PM

#

ill fix that in my loader rewrite

#

cause that code was sketchy

primal latch Jul 4, 2021, 3:35 PM

#

fickle sparrow someone test the updated mod loader for me ty

it fails while loading Fyremoth with a failed to call constructor

#

📎 ModLog.txt

fickle sparrow Jul 4, 2021, 3:35 PM

#

what does this mean

#

I see a null deref

primal latch Jul 4, 2021, 3:36 PM

#

yeah. But it isn't thrown when loading using the latest github version

fickle sparrow Jul 4, 2021, 3:36 PM

#

idk I need to see the code

primal latch Jul 4, 2021, 3:36 PM

#

oh god

jolly oriole Jul 4, 2021, 3:40 PM

#

i'm nearly done setting up postbuild to have a package ready for instant upload

jolly oriole Jul 4, 2021, 3:53 PM

#

jolly oriole i'm nearly done setting up postbuild to have a package ready for instant upload

<Target Name="CopyMod" AfterTargets="PostBuildEvent">
    <RemoveDir Directories="$(ExportDir)$(TargetName)/" />
    <MakeDir Directories="$(ExportDir)$(TargetName)/" />
    <MakeDir Directories="$(ExportDir)$(TargetName)/zip/" />
    <Copy SourceFiles="$(TargetPath)" DestinationFolder="$(HollowKnightRefs)/Mods/" />
    <Copy SourceFiles="$(TargetDir)$(TargetName).pdb" DestinationFolder="$(HollowKnightRefs)/Mods/" />
    <Copy SourceFiles="ReadMe.md" DestinationFolder="$(ExportDir)$(TargetName)/zip/" />
    <Copy SourceFiles="$(TargetPath)" DestinationFolder="$(ExportDir)$(TargetName)/" />
    <Copy SourceFiles="$(TargetPath)" DestinationFolder="$(ExportDir)$(TargetName)/zip/" />
    <Copy SourceFiles="$(TargetDir)$(TargetName).pdb" DestinationFolder="$(ExportDir)$(TargetName)/zip/" />
    <ZipDirectory SourceDirectory="$(ExportDir)$(TargetName)/zip/" DestinationFile="$(ExportDir)$(TargetName)/$(TargetName).zip" />
    <RemoveDir Directories="$(ExportDir)$(TargetName)/zip/" />
    
    <GetFileHash Files="$(ExportDir)$(TargetName)/$(TargetName).zip" Algorithm="SHA256">
        <Output TaskParameter="Items" ItemName="FilesWithHashes" />
    </GetFileHash>
    <WriteLinesToFile File="$(ExportDir)$(TargetName)/SHA.txt" Lines="@(FilesWithHashes->'%(FileHash)')" Overwrite="true" Encoding="UTF-8"/>
</Target>

hotdogHotdog

cedar hemlock Jul 4, 2021, 3:54 PM

#

https://github.com/ricardosouzag/ModInstaller/pull/106 2nd try

fickle sparrow Jul 4, 2021, 4:00 PM

#

fixed the settings loading bug

#

well I actually just rewrote the global settings

#

also ModHooksGlobalSettings.ModEnabledSettings was changed a lot so I basically removed it

#

use ModHooks.ModEnabled(string name) now

#

well once I can see this loading code is stable

copper nacelle Jul 4, 2021, 6:25 PM

#

https://hk-modding.github.io/api/articles/logs.html yeet

#

moved/rewrote a bit

#

the cross-reference to actual classes is nice

jolly oriole Jul 4, 2021, 6:34 PM

#

then ig over the next 2 years the apidocs website can/will be transfered to that?

copper nacelle Jul 4, 2021, 6:35 PM

#

2 years PauseShroom

jolly oriole Jul 4, 2021, 6:35 PM

#

realistic timeframe

copper nacelle Jul 4, 2021, 6:36 PM

#

nope

jolly oriole Jul 4, 2021, 6:36 PM

#

oh yea sorry, exactly until silksong releases, so 4 years

copper nacelle Jul 4, 2021, 6:36 PM

#

wdym that's never happening

jolly oriole Jul 4, 2021, 6:37 PM

#

but the other part?

#

||then ig over the next 2 years|| the apidocs website can/will be transfered to that?

#

the contents ofc

copper nacelle Jul 4, 2021, 6:40 PM

#

idk presumably

jolly oriole Jul 4, 2021, 6:53 PM

#

i need a single more contribution today

copper nacelle Jul 4, 2021, 6:53 PM

#

what

jolly oriole Jul 4, 2021, 6:54 PM

#

copper nacelle Jul 4, 2021, 6:54 PM

#

PauseShroom

#

lmao

jolly oriole Jul 4, 2021, 6:54 PM

#

i updated a bit

jolly oriole Jul 4, 2021, 6:55 PM

#

copper nacelle lmao

smh, low number

copper nacelle Jul 4, 2021, 6:56 PM

#

no that's from your page

#

private commits PauseShroom

jolly oriole Jul 4, 2021, 6:56 PM

#

i know

#

now you see 1 more hotdogHotdog

copper nacelle Jul 4, 2021, 6:57 PM

#

🥴

jolly oriole Jul 4, 2021, 6:57 PM

#

the last one i won't show until it's done 😤

copper nacelle Jul 4, 2021, 6:58 PM

#

why is the note massive

#

omegaMaggotPrime

jolly oriole Jul 4, 2021, 6:58 PM

#

lmao

#

yea, you have this text that shows how things can be altered

note
PLEASE DO THINGS THIS WAY TO MAKE YOUR MOD COMPATIBLE TO OTHER MODS

#

finally

========== Alles neu erstellen: 32 erfolgreich, 0 fehlerhaft, 0 übersprungen ==========

copper nacelle Jul 4, 2021, 7:01 PM

#

peepoHappy

jolly oriole Jul 4, 2021, 7:07 PM

#

nice

#

brb making releases of these 21 mods

fickle sparrow Jul 4, 2021, 7:15 PM

#

PAUSERS

jolly oriole Jul 4, 2021, 7:33 PM

#

i made a few (21) releases

#

widepeepoHappy

jolly jungle Jul 4, 2021, 7:58 PM

#

Were those all ported to 1.5

#

wow

#

What's Hall of Custom Gods?

copper nacelle Jul 4, 2021, 7:59 PM

#

https://hk-modding.github.io/api/articles/charms.html e

jolly jungle Jul 4, 2021, 7:59 PM

#

And Dream King

jolly oriole Jul 4, 2021, 7:59 PM

#

jolly jungle What's Hall of Custom Gods?

a thing in WIP that (will at some point in the future) be a thing to have a hall of gods but for boss mod bosses, so all boss mods can be installed simultaneously

jolly jungle Jul 4, 2021, 8:00 PM

#

copper nacelle https://hk-modding.github.io/api/articles/charms.html e

1.5 documentation?

jolly oriole Jul 4, 2021, 8:00 PM

#

jolly jungle And Dream King

the thing that got me into hk modding, not telling anything else

jolly jungle Jul 4, 2021, 8:00 PM

#

jolly oriole a thing in WIP that (will at some point in the future) be a thing to have a hal...

So a kind of mod manager for boss mods specifically?

jolly oriole Jul 4, 2021, 8:00 PM

#

copper nacelle https://hk-modding.github.io/api/articles/charms.html e

looks poggers

jolly oriole Jul 4, 2021, 8:00 PM

#

jolly jungle So a kind of mod manager for boss mods specifically?

yes, you can find the project in my github under BossModCore

copper nacelle Jul 4, 2021, 8:00 PM

#

ig it's 1.5

#

just moving/adding to docs

jolly oriole Jul 4, 2021, 8:01 PM

#

PlayerData.instance.GetBool("gotCharm_X")
it's 1432 docs lol

#

but yea

jolly jungle Jul 4, 2021, 8:01 PM

#

jolly oriole yes, you can find the project in my github under `BossModCore`

Cool, I'll definitely look at it sometime . _.

copper nacelle Jul 4, 2021, 8:01 PM

#

is that not the case in 1.5

jolly oriole Jul 4, 2021, 8:01 PM

#

oh wait

copper nacelle Jul 4, 2021, 8:01 PM

#

x5fiftM

jolly oriole Jul 4, 2021, 8:02 PM

#

it's playerdata, not modhooks

jolly jungle Jul 4, 2021, 8:02 PM

#

jolly oriole the thing that got me into hk modding, not telling anything else

||~~Is it a half cringe NKG mod zote ~~||

copper nacelle Jul 4, 2021, 8:02 PM

#

lmao

#

yeah i used the new modhooks

#

the old thing had just setting the ints

jolly oriole Jul 4, 2021, 8:02 PM

#

jolly jungle ||~~Is it a half cringe NKG mod <:zote:562358113374568477> ~~||

not telling anything 😤

jolly oriole Jul 4, 2021, 8:02 PM

#

copper nacelle the old thing had just setting the ints

lol

floral blade Jul 4, 2021, 8:13 PM

#

(please keep a moderate volume when watching)

how do i tune the sound on Beeg knight's walk?
i want it to feel impactful but my current tuning makes it feel like too much impact?

light zodiac Jul 4, 2021, 8:18 PM

#

i want it to feel impactful
add screenshake

#

imo it feels like someone is playing a guitar rather than walking

#

hence i just took a monster stepping sound and didn't mess with it much

floral blade Jul 4, 2021, 8:22 PM

#

should i just remove the mosterwalk and play the original sound ? grubsad

fickle sparrow Jul 4, 2021, 8:24 PM

#

just lower the speed

#

or lower pitch and increase echo a bit

floral blade Jul 4, 2021, 8:26 PM

#

lower pitch on the current one or the default one ?

jolly jungle Jul 4, 2021, 8:30 PM

#

Original, I think they mean

floral blade Jul 4, 2021, 8:35 PM

#

this is how that sounds, maybe i've messed up the reverb params ? i have this rn.

r.reverbLevel = 200f;
r.decayTime = 3f;
r.decayHFRatio = 2f;

fickle sparrow Jul 4, 2021, 8:40 PM

#

reverb makes things generally sound far away

#

or in a large room

floral blade Jul 4, 2021, 8:44 PM

#

i'll try an AudioEchoFilter once

fickle sparrow Jul 4, 2021, 8:46 PM

#

and definitely lower the pitch to be like 70% of the original

#

maybe even lower depending on how it sounds

floral blade Jul 4, 2021, 8:47 PM

#

yeah i'm lowering/raising the pitch of all knight sounds, just want to get the walk right for beeg

fickle sparrow Jul 4, 2021, 8:47 PM

#

yeah

merry lotus Jul 4, 2021, 8:50 PM

#

light zodiac > i want it to feel impactful add screenshake

Even if you don't add screenshake to walking (which, I wouldn't personally, because that sounds nauseating lol), you could possibly add it it to landing from a jump.

floral blade Jul 4, 2021, 9:09 PM

#

going to try adjusting the pitch a bit more

radiant basin Jul 4, 2021, 9:27 PM

#

are these unused?

copper nacelle Jul 4, 2021, 9:28 PM

#

spikes

radiant basin Jul 4, 2021, 9:28 PM

#

hes off screen for those though

jolly oriole Jul 4, 2021, 9:28 PM

#

then ig

copper nacelle Jul 4, 2021, 9:30 PM

#

Oh yeah

#

I guess they just recolored the Grimm ones

#

You can see similar things with pure vessel

radiant basin Jul 4, 2021, 9:30 PM

#

oh huh

#

thanks, i was just double checking

jolly oriole Jul 4, 2021, 9:30 PM

#

though with pure vessel there do be a lot of sprites just not being there

#

same with thk not having some sprites pv has

vocal spire Jul 4, 2021, 9:41 PM

#

jolly oriole the thing that got me into hk modding, not telling anything else

I can guess. Not saying my guess though

floral blade Jul 4, 2021, 9:54 PM

#

i think i'll go with this for now, it's not much of an impact but feels better than the previous one

proven plover Jul 5, 2021, 1:48 AM

#

The ArmorCtrl Code doesn't seem to work for me

#

I think I'm missing a reference or something

#

#

vocal spire Jul 5, 2021, 3:16 AM

#

proven plover The ArmorCtrl Code doesn't seem to work for me

Add a reference to UnityEngine.AnimatonModule.dll
Also it appears to assume your class inheriting mod is called Tutorial, so either change your mod class’s name to Tutorial or change anything referencing Tutorial to the name of your mod class

proven plover Jul 5, 2021, 5:10 AM

#

Thanks!

primal latch Jul 5, 2021, 6:33 AM

#

proven plover

It also seems like your project file is broken

cedar hemlock Jul 5, 2021, 8:18 AM

#

where can i find the latest api

jolly oriole Jul 5, 2021, 8:19 AM

#

https://github.com/hk-modding/api

cedar hemlock Jul 5, 2021, 8:21 AM

#

the latest release is for 1.5.68 tho and not 1.5.75

#

and in steam i have no way to go to .68

#

https://github.com/hk-modding/api/suites/3154877205/artifacts/72546772 does that work?

jolly oriole Jul 5, 2021, 8:32 AM

#

if that's the latest master artifact, likely

#

the artifact from this action should definetly work: https://github.com/hk-modding/api/actions/runs/998921662

primal latch Jul 5, 2021, 8:53 AM

#

I remember someone posting a link when visiting was first implemented that always linked to the latest run

jolly oriole Jul 5, 2021, 9:07 AM

#

you mean that pinned one by yuri?

cedar hemlock Jul 5, 2021, 9:16 AM

#

jolly oriole the artifact from this action should definetly work: <https://github.com/hk-modd...

they're the same

cedar hemlock Jul 5, 2021, 10:44 AM

#

damn HowwowKnyight updated to 1.5 and .net 4.7.2, and 0 errors, prob did something wrong

cedar hemlock Jul 5, 2021, 11:07 AM

#

how do i add multiple links to modlinks

#

do i just do:

<Link>https://link1.com</Link>
<Link>https://link2.com</Link>
```?

jolly oriole Jul 5, 2021, 11:08 AM

#

which modlinks

cedar hemlock Jul 5, 2021, 11:09 AM

#

the main modlinks

#

by the modinstaller

jolly oriole Jul 5, 2021, 11:09 AM

#

idk

#

and then: how the two links, for one mod or different mods

cedar hemlock Jul 5, 2021, 11:10 AM

#

art mods are hosted on radiance.host, so if i want to add a mod to them i need the have a seperate link

jolly oriole Jul 5, 2021, 11:11 AM

#

download arts mods zip
add mod to zip
ask somebody to upload new zip to radiance.host
update shas in modinstaller

cedar hemlock Jul 5, 2021, 11:11 AM

#

but who has access to radiance.host

jolly oriole Jul 5, 2021, 11:11 AM

#

idk

floral blade Jul 5, 2021, 11:14 AM

#

They do

cedar hemlock Jul 5, 2021, 11:15 AM

#

i can't find the zip there

floral blade Jul 5, 2021, 11:15 AM

#

No I meant to say that they can update radiance host

cedar hemlock Jul 5, 2021, 11:15 AM

#

thats only for the api doc i think

cedar hemlock Jul 5, 2021, 11:16 AM

#

floral blade No I meant to say that they can update radiance host

oh like that

steady comet Jul 5, 2021, 11:24 AM

#

Is there an updated QoL (plus dependencies) for 1.5.75?

#

Also, if I'm updating mods to 1.5, is it .NET Framework 4.7.2? (Plus changes to the MAPI, plus possible changes to FSMs)

cedar hemlock Jul 5, 2021, 11:31 AM

#

i believe 4.7.2 yeah

#

Error    CS1069    The type name 'Regex' could not be found in the namespace 'System.Text.RegularExpressions'. This type has been forwarded to assembly 'System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' Consider adding a reference to that assembly.
```I have searched for that to reference it, but i cannot find it anywhere, anyone know where it is?

primal latch Jul 5, 2021, 12:06 PM

#

@cedar hemlock add a refference to the system assembly

cedar hemlock Jul 5, 2021, 12:06 PM

#

Just system?

primal latch Jul 5, 2021, 12:07 PM

#

Yes

cedar hemlock Jul 5, 2021, 12:07 PM

#

Cus i can't reference that

#

Something about it already being there or smth

primal latch Jul 5, 2021, 12:08 PM

#

Ah. Look through all the references and remove the reference to system and add a reference to the dll in the managed dir of HK

jolly oriole Jul 5, 2021, 12:09 PM

#

edit your csproj to have that reference

#

vs doesn't let you do that, but if you edit the file directly vs will accept it

cedar hemlock Jul 5, 2021, 12:10 PM

#

Ah ok

arctic dragon Jul 5, 2021, 12:15 PM

#

hollow knight skin creators- does ANYONE know why the full soul orb texture is seperate from the rest of the HUD textures, while there's a perfectly fine full orb texture in the HUD textures?

cedar hemlock Jul 5, 2021, 12:16 PM

#

Nope teamcherry

arctic dragon Jul 5, 2021, 12:17 PM

#

ooooooooooooooooooohhh

#

we still have no idea how to change the liquid soul color in the big orb right

cedar hemlock Jul 5, 2021, 12:22 PM

#

nope

arctic dragon Jul 5, 2021, 12:22 PM

#

AGONY

cedar hemlock Jul 5, 2021, 12:25 PM

#

jolly oriole edit your csproj to have that reference

how

#

ah i got it i believe

cedar hemlock Jul 5, 2021, 12:35 PM

#

jolly oriole edit your csproj to have that reference

like this?

    <Reference Include="System">
      <HintPath>C:\Program Files (x86)\Steam\steamapps\common\Hollow Knight\hollow_knight_Data\Managed\System.dll</HintPath>
    </Reference>

#

ayy it worked

#

[ERROR]:[API] - Error: System.InvalidOperationException: Return type of hook for  doesn't match, must be System.Void

wanguageGetHook = new Hook(typeof(ModHooks).GetMethod("LanguageGet", BindingFlags.NonPublic | BindingFlags.Instance), typeof(HowwowKnyight).GetMethod("WanguageGet", BindingFlags.NonPublic | BindingFlags.Static));
```Any ideas?

primal latch Jul 5, 2021, 1:36 PM

#

what is the latest debug mod bui;d?

cedar hemlock Jul 5, 2021, 1:41 PM

#

see mulhima's fork

#

Did LanguageGet change in 1.5?

steady comet Jul 5, 2021, 1:49 PM

#

Yes

#

Well, the hook changed

#

BTW I think with how the hook changed you could probably just go through the hook rather than detouring it for howwowknyight (that seems like it's probably safer IG)

cedar hemlock Jul 5, 2021, 1:51 PM

#

i should learn more c# i have almost no idea what that means

#

just use modhook.blabla += WanguageGet?

steady comet Jul 5, 2021, 1:52 PM

#

You'd need to change the signature of WanguageGet though to match the LanguageGetProxy

#

So it would need to be something like

private string WanguageGet(string key, string sheetTitle, string orig)
{
  // code goes here
}

#

(And then ModHooks.LanguageGetHook += WanguageGet)

jolly oriole Jul 5, 2021, 1:54 PM

#

at one point or another it may be easier to just make a completely new project and reimplement the functionality of that mod into the fresh project so you don't have to deal with decomp

cedar hemlock Jul 5, 2021, 1:55 PM

#

dw i got the source

jolly oriole Jul 5, 2021, 1:57 PM

#

then you wouldn't have to deal with whatever

wanguageGetHook = new Hook(typeof(ModHooks).GetMethod("LanguageGet", BindingFlags.NonPublic | BindingFlags.Instance), typeof(HowwowKnyight).GetMethod("WanguageGet", BindingFlags.NonPublic | BindingFlags.Static));

is

cedar hemlock Jul 5, 2021, 1:57 PM

#

yes i do?

#

its in the source

#

private string WanguageGet((string key, string sheetTitle, string owig))
        {
            string text = owig(instance, key, tabwe);
```what do i do with `string text`

copper nacelle Jul 5, 2021, 1:59 PM

#

why

cedar hemlock Jul 5, 2021, 1:59 PM

#

dunno

copper nacelle Jul 5, 2021, 1:59 PM

#

just use the hook

#

the modhook

steady comet Jul 5, 2021, 2:00 PM

#

Is there a way to ensure that your function gets applied last, other than just giving a load priority of 1000 or something?

#

(Or would it be -1000?)

copper nacelle Jul 5, 2021, 2:01 PM

#

just the load priority thing

jolly oriole Jul 5, 2021, 2:04 PM

#

cedar hemlock yes i do?

an actual source would have it something like https://github.com/SFGrenade/TestOfTeamwork/blob/master/TestOfTeamwork.cs#L177

#

yes, that single line

cedar hemlock Jul 5, 2021, 2:10 PM

#

wth is my game doing

#

i have the saves not loading error, but the procedure to fix it doesn't fix it

#

damn got it working

#

but how did i fix the saves not loading error without deleting the globalsettings

#

i'm ultimate confusion

small heart Jul 5, 2021, 3:05 PM

#

Hello there!

Currently, I've been stuck finding Nightmare Grimm's attacks in FSMView. I have looked through everything, but I still can't find the attacks. I'm using Gods and Glory Nightmare Grimm, but that doesn't make a difference. Please help me locate the fsm.

Thanks in advance!

copper nacelle Jul 5, 2021, 3:10 PM

#

what scene did you check

jolly oriole Jul 5, 2021, 3:14 PM

#

Should be viewable in gg_nightmare_grimm

copper nacelle Jul 5, 2021, 3:15 PM

#

^

jolly oriole Jul 5, 2021, 3:19 PM

#

I have no idea if i spelled it correctly

small heart Jul 5, 2021, 3:52 PM

#

I have checked GG_Grimm_Nightmare and am checking. I just cant find it. Sorry for the late response. Still looking through 😦

copper nacelle Jul 5, 2021, 3:53 PM

#

show

small heart Jul 5, 2021, 4:00 PM

#

copper nacelle show

what?

copper nacelle Jul 5, 2021, 4:00 PM

#

where are you checking

#

Like you can't find it in the list?

#

it's like something - control

small heart Jul 5, 2021, 4:01 PM

#

1sec

#

and ...

#

...

copper nacelle Jul 5, 2021, 4:02 PM

#

yeah

small heart Jul 5, 2021, 4:02 PM

#

one sec

#

wait thats it?

#

i saw many more

#

well umm, how can i spawn a grimm fireball?

jolly oriole Jul 5, 2021, 6:05 PM

#

get gameobject, instantiate gameobject

floral blade Jul 5, 2021, 6:11 PM

#

SF how can one get a GO as if you preloaded it but without preloading it ? like in any scene

jolly oriole Jul 5, 2021, 6:13 PM

#

you have to get it in any way, preloading is one way to get a GO, another way is to just GameObject.Find it in initialize (requires the go to be loaded in the main menu)

#

or you do this fun stuff hotdogHotdog https://github.com/SFGrenade/BossModCore/blob/master/MonoBehaviours/CustomBossCopy.cs

floral blade Jul 5, 2021, 6:14 PM

#

no so i don't want to preload it but rather load it on demand in a random scene

jolly oriole Jul 5, 2021, 6:15 PM

#

if you want to do that at any point then the async level load also isn't an option, then ig you could dump the GO and bundle it in your mod to then load on demand

floral blade Jul 5, 2021, 6:16 PM

#

if i'd do it at scene transition instead would that make it better ?

jolly oriole Jul 5, 2021, 6:17 PM

#

then the async loading is way less noticable (and i also do it on scene transition)

#

don't ask me why all those logs are still there

floral blade Jul 5, 2021, 6:19 PM

#

i don't fully understand what you do, but is it basically

start scene transition => load scene with GO => get GO => go back to scene you originally wanted to go to but now you have the GO you wanted

jolly oriole Jul 5, 2021, 6:22 PM

#

in bossmodcore i do it in a slightly odd way (which you probably won't do, because you don't have a custom scene)
but basically yea

wait for scene transition to the scene you want to have your stuff in
Load scene (with your wanted content) additively
copy/move the content you want to the scene you want (UnityEngine.SceneManagement.SceneManager.MoveGameObjectToScene(go, scene) to move gos)
unload the additively loaded scene
do stuff with your go

floral blade Jul 5, 2021, 6:27 PM

#

would GameObject.Find work with inactive GOs ?

jolly oriole Jul 5, 2021, 6:27 PM

#

afaik no

#

but

#

sfcore's gameObject.Find(name) and scene.Find(name) methods can find inactive GOs

floral blade Jul 5, 2021, 6:30 PM

#

time to look at sfcore's code then!

jolly oriole Jul 5, 2021, 6:30 PM

#

https://github.com/SFGrenade/SFCore/blob/master/Util/USceneUtil.cs#L18

floral blade Jul 5, 2021, 6:32 PM

#

it might not work but basically i want to load the GOs defined in /Swapster on skin change but i would not know which GOs i need preloaded. if i can load them async then i can ensure all GOs are updated regardless of which scene they're in / if they're active or inactive, not even sure if that's a great idea tbh.

jolly oriole Jul 5, 2021, 6:33 PM

#

idk

floral blade Jul 5, 2021, 6:38 PM

#

i'm gonna try it once, atleast going to use the gameObject.Find to make it apply textures without having to poll GameObject.Find , though i guess that would fail if some object tries to spawn a GO right ?

jolly oriole Jul 5, 2021, 6:40 PM

#

i needed to read this like 5 times to somewhat understand it, but if you check with either scene.Find or GameObject.Find it would not work with GOs that are spawned later in

floral blade Jul 5, 2021, 6:42 PM

#

sorry i can be like that sometimes! thanks for the help tho, i have ideas now sethscheme

pine girder Jul 5, 2021, 7:20 PM

#

Does anyone know where is the file (For soul orb halfway not full and not mini ones) is?

#

And dont tell me it is impossible to reskin that file
I know killer whale and sapphire did this

radiant basin Jul 5, 2021, 7:24 PM

#

do you mean the eyes that appear when the meter is half full?

floral blade Jul 5, 2021, 7:26 PM

#

or the color of the liquid that fills?

pine girder Jul 5, 2021, 7:30 PM

#

The eyes
Although I am not sure if the color is reskinable

radiant basin Jul 5, 2021, 7:32 PM

#

the eyes are here on the right side of the HUD sheet

pine girder Jul 5, 2021, 7:33 PM

#

Oh ty

#

Wait it is not there??

#

I am confused

#

Nvm, sorry

#

Another question, how do I find the file without other critters like hearts?

#

I tried to find it inside the sprite packer's dumped sprites

radiant basin Jul 5, 2021, 7:38 PM

#

wdym?

#

what are you looking for exactly

floral blade Jul 5, 2021, 7:40 PM

#

pine girder The eyes Although I am not sure if the color is reskinable

the liquid is skin-able in the pre-release 1.5 CK

#

you can find the other newly added sprites in the zip here, incase you want to add some of them in your skin
https://github.com/PrashantMohta/HollowKnight.CustomKnight/releases/tag/1.5-candidate

pine girder Jul 5, 2021, 7:43 PM

#

Oh nice

radiant basin Jul 5, 2021, 7:44 PM

#

oh pog you can change the feathers!!

pine girder Jul 5, 2021, 7:44 PM

#

radiant basin what are you looking for exactly

The eyes by itself only without other critters
So the hitbox don't ended up being wrong

#

Like atlas dumped into individual files

radiant basin Jul 5, 2021, 7:44 PM

#

ohh right

#

the eyes are not dumped

#

you just draw straight onto the atlas

#

i recommend doing it at the end

#

after the other sprites

floral blade Jul 5, 2021, 7:45 PM

#

pine girder The eyes by itself only without other critters So the hitbox don't ended up bein...

the bounding box is defined in game so you only have the space to cover the area that existing eyes themselves use

pine girder Jul 5, 2021, 7:45 PM

#

Let me show an example

#

It is a dumped file

radiant basin Jul 5, 2021, 7:46 PM

#

oh yeah you just have to guess i think

pine girder Jul 5, 2021, 7:46 PM

#

although I may be wrong about the label

radiant basin Jul 5, 2021, 7:46 PM

#

though there was a version of the knight atlas with the boundaries on so maybe there a version of the hud one?

pine girder Jul 5, 2021, 7:47 PM

#

Yeah I already found the dumped hub but eyes aren't there

#

So far i know of

floral blade Jul 5, 2021, 7:48 PM

#

<#modding-discussion message>

#

it's really not a lot of room tbh

radiant basin Jul 5, 2021, 7:49 PM

#

yeah its real tight

#

you can overlay that image with yours to work out where the boundary is

floral blade Jul 5, 2021, 7:50 PM

#

i was gonna say : alternate black and white stripes to count and figure out lol

#

a checker board pattern might be better to get horizontal scale too.

radiant basin Jul 5, 2021, 7:51 PM

#

oh man why did i not look into 1.5 ck earlier i couldve done beans defender and nk sans way easier

pine girder Jul 5, 2021, 7:52 PM

#

I always use checker board with grey color
Less strain for me

#

Although I sometimes turn off checker

#

Shouldn't be too much problem

#

And beside my custom eyes aren't too different

floral blade Jul 5, 2021, 7:54 PM

#

radiant basin oh man why did i not look into 1.5 ck earlier i couldve done beans defender and ...

to be fair i was working on swapster while you were working on BD , that's what had inspired me to make it easier to do

radiant basin Jul 5, 2021, 7:54 PM

#

ohh cool!

jolly jungle Jul 5, 2021, 8:07 PM

#

radiant basin oh man why did i not look into 1.5 ck earlier i couldve done beans defender and ...

this way you learn the stuff yourself though

radiant basin Jul 5, 2021, 8:09 PM

#

yeah true
plus more people can use them sooner

jolly jungle Jul 5, 2021, 8:09 PM

#

Exactly

floral blade Jul 5, 2021, 8:10 PM

#

did a basic grid thing

jolly jungle Jul 5, 2021, 8:11 PM

#

Uhhhh

#

Transparency?

floral blade Jul 5, 2021, 8:11 PM

#

pine girder And beside my custom eyes aren't too different

this help ?

jolly jungle Jul 5, 2021, 8:11 PM

#

Oh wait I get it now

floral blade Jul 5, 2021, 8:11 PM

#

jolly jungle Transparency?

nah wanted to figure out the size

jolly jungle Jul 5, 2021, 8:12 PM

#

To see the outlines?

#

yeah I see now

pine girder Jul 5, 2021, 8:23 PM

#

Btw this is the eyes I going to use

#

If it is not fitting
I can resize and make it smaller

radiant basin Jul 5, 2021, 8:27 PM

#

ooo thats cool

#

reminds me of shounen protag eyes lol

pine girder Jul 5, 2021, 8:36 PM

#

👀

#

Well Gaara ain't a protagonist but yes

floral blade Jul 5, 2021, 8:38 PM

#

is there a skin that turns the weaverlings into little hornets ?

jolly jungle Jul 5, 2021, 8:39 PM

#

Sadly, not that I know of

radiant basin Jul 5, 2021, 8:42 PM

#

oh thatd be cute

floral blade Jul 5, 2021, 8:47 PM

#

pine girder Well Gaara ain't a protagonist but yes

you're making a gaara skin ?

fickle sparrow Jul 5, 2021, 8:58 PM

#

ok new version of the loader rework

📎 Assembly-CSharp.dll

#

if you find any crashes, send the logs and please find any of the problematic code from the error stack trace and send it to me

#

because I cannot fix a bug if I do not know whats causing it

#

🙂

jolly oriole Jul 5, 2021, 9:12 PM

#

infinite menu load

#

let me get logs

#

📎 ModLog.txt

#

📎 Player.log

#

@fickle sparrow seems like after initializing all mods it just decides to say that the preload is done again, resulting in all mods initializing, resulting in ...

grave willow Jul 5, 2021, 9:15 PM

#

Can you make a Hank J Wimbleton for Hollow Knight?

fickle sparrow Jul 5, 2021, 9:15 PM

#

hmmm

#

NullReferenceException: Object reference not set to an instance of an object
  at GameManager.SetupHeroRefs () [0x00016] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at GameManager.orig_SetupSceneRefs (System.Boolean refreshTilemapInfo) [0x0006c] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at GameManager.SetupSceneRefs (System.Boolean refreshTilemapInfo) [0x00001] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at GameManager.LevelActivated (UnityEngine.SceneManagement.Scene sceneFrom, UnityEngine.SceneManagement.Scene sceneTo) [0x0003c] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at (wrapper delegate-invoke) UnityEngine.Events.UnityAction`2[UnityEngine.SceneManagement.Scene,UnityEngine.SceneManagement.Scene].invoke_void_T0_T1(UnityEngine.SceneManagement.Scene,UnityEngine.SceneManagement.Scene)
  at UnityEngine.SceneManagement.SceneManager.Internal_ActiveSceneChanged (UnityEngine.SceneManagement.Scene previousActiveScene, UnityEngine.SceneManagement.Scene newActiveScene) [0x0000e] in <047294ce45cf4b9a9441e48d2b8435e4>:0

jolly oriole Jul 5, 2021, 9:16 PM

#

that's normal

light zodiac Jul 5, 2021, 9:17 PM

#

Debug do be doing that

fickle sparrow Jul 5, 2021, 9:17 PM

#

wtf

light zodiac Jul 5, 2021, 9:17 PM

#

Or is it not debug?

fickle sparrow Jul 5, 2021, 9:17 PM

#

why does this keep looping

jolly oriole Jul 5, 2021, 9:18 PM

#

i could disable some of these to see if it helps

fickle sparrow Jul 5, 2021, 9:18 PM

#

uhhh i think i know

jolly oriole Jul 5, 2021, 9:18 PM

#

PauseChamp

fickle sparrow Jul 5, 2021, 9:19 PM

#

📎 Assembly-CSharp.dll

jolly oriole Jul 5, 2021, 9:20 PM

#

no more infinite load

fickle sparrow Jul 5, 2021, 9:20 PM

#

xdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxdxd

jolly oriole Jul 5, 2021, 9:20 PM

#

what was it

fickle sparrow Jul 5, 2021, 9:20 PM

#

bad infrastructure

#

OnScreenDebugInfo getting recreated

#

stupid shit

floral blade Jul 5, 2021, 9:21 PM

#

fickle sparrow

seems to work

jolly oriole Jul 5, 2021, 9:21 PM

#

that's why starting mod loading in StartManager update (last i tested start didn't work) is better 😤

fickle sparrow Jul 5, 2021, 9:21 PM

#

blorry

jolly oriole Jul 5, 2021, 9:21 PM

#

it do be loaded only once

fickle sparrow Jul 5, 2021, 9:22 PM

#

I'll just do

#

StartManager awake

jolly oriole Jul 5, 2021, 9:22 PM

#

won't work

fickle sparrow Jul 5, 2021, 9:23 PM

#

yeah makes sense

jolly oriole Jul 5, 2021, 9:23 PM

#

camera doesn't exist then

#

which is also why i had problems with startmanager start

fickle sparrow Jul 5, 2021, 9:23 PM

#

yeah

#

fair enough

#

time to keep this the same

#

wait

jolly oriole Jul 5, 2021, 9:23 PM

#

... it also clogs modlog / player log because gamemanager/herocontroller/basically everything doesn't exist

fickle sparrow Jul 5, 2021, 9:24 PM

#

StartManager Start should work

#

if you patch the stuff to the end

jolly oriole Jul 5, 2021, 9:25 PM

#

i swear i had a branch where i had that barely working

floral blade Jul 5, 2021, 9:25 PM

#

hmm i have random errors like doublejump anim playing but it not working and multiple dreamgates and getting stuck in walk animation ( not sure if related to the current dll)

#

lemme confirm by reverting

floral blade Jul 5, 2021, 9:26 PM

#

fickle sparrow

it's the this

fickle sparrow Jul 5, 2021, 9:27 PM

#

any erorr logs

floral blade Jul 5, 2021, 9:27 PM

#

sending last modlog and player prev

jolly oriole Jul 5, 2021, 9:27 PM

#

jolly oriole i swear i had a branch where i had that barely working

nvm, it's the commits from cfc33db275611be1bf7f5d99831a9760ff78f9ec to 28270e8956a98dd44240abc1dcb9cdb6a1b30bc5 that had the earlier mod loading

floral blade Jul 5, 2021, 9:29 PM

#

cannot find the right vibemix

📎 Player-prev.log

#

modlog seems useless to me but sending anyways

📎 ModLog_07_05_2021_21_25_23.txt

jolly oriole Jul 5, 2021, 9:30 PM

#

looks like it's caused by hkmp?

floral blade Jul 5, 2021, 9:31 PM

#

jolly oriole looks like it's caused by hkmp?

i mean i used it on 2 assembly-csharps and only the new one borked stuff

fickle sparrow Jul 5, 2021, 9:31 PM

#

I did change stuff

#

but this is probably not a bug with the new codde

#

I'll need to see the relevant code in HKMP

floral blade Jul 5, 2021, 9:31 PM

#

want me to disable all mods and try ?

jolly oriole Jul 5, 2021, 9:31 PM

#

NullReferenceException: Object reference not set to an instance of an object
  at DesktopPlatform.GetVibrationMixer () [0x00000] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at VibrationManager.GetMixer () [0x00019] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at VibrationManager.PlayVibrationClipOneShot (VibrationData vibrationData, System.Nullable`1[T] vibrationTarget, System.Boolean isLooping, System.String tag) [0x00009] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at HeroController.BackOnGround () [0x0004e] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at HeroController.FailSafeChecks () [0x0015a] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at HeroController.orig_Update () [0x00027] in <ec95cbe21af7448ea086a0245ca33b78>:0 
  at (wrapper dynamic-method) HeroController.DMD<HeroController::Update>(HeroController)
  at (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<HeroController::Update>?-1653690368(HeroController)
  at HKMP.Game.Client.MapManager.HeroControllerOnUpdate (On.HeroController+orig_Update orig, HeroController self) [0x00001] in <fc613eecd7b64064a8b5e4e51bd8948c>:0 
  at (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<HeroController::Update>?648599168(HeroController)
  at (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<HeroController::Update>?-1967164416(HeroController)
  at HKMP.Game.Client.ClientManager.OnPlayerUpdate (On.HeroController+orig_Update orig, HeroController self) [0x00001] in <fc613eecd7b64064a8b5e4e51bd8948c>:0 
  at (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<HeroController::Update>?642833408(HeroController)

no pdb moment