#archived-modding-development | Hollow Knight | Page 523

copper nacelle Jun 27, 2021, 10:05 PM

#

unity + redirect to reference mscorlib xml

jolly oriole Jun 27, 2021, 10:05 PM

#

oh yea, that unity xml with the typo in some vector stream function

copper nacelle Jun 27, 2021, 10:06 PM

#

lmao

#

i swear

#

the mono internal function is actually more portable

jolly oriole Jun 27, 2021, 10:07 PM

#

look in the uimodule xml on line 267 and tell me that it's a vertex st(r)eam

copper nacelle Jun 27, 2021, 10:08 PM

#

do be

#

corrisponding[sic] pauseshroom

jolly oriole Jun 27, 2021, 10:08 PM

#

oh lol

copper nacelle Jun 28, 2021, 12:24 AM

#

breaking modhooks part 2

#

peepoHappy

vocal spire Jun 28, 2021, 12:25 AM

#

yay

ornate rivet Jun 28, 2021, 12:26 AM

#

kill me

vocal spire Jun 28, 2021, 12:26 AM

#

no, first pale court

fickle sparrow Jun 28, 2021, 12:30 AM

#

true

copper nacelle Jun 28, 2021, 12:43 AM

#

copper nacelle breaking modhooks part 2

as far as this goes, mostly in response to the problems people had/feedback given

#

removed the nullable stuff as you can return orig and that was confusing anyways

#

and then simplified the bool tryget stuff to just use a return

#

removed 'orig' from langget vs current as people didn't think it was too helpful

#

generally this should be easier to use now, the main change from 1432 just being that sets return instead of setting themselves and gets get the original value

#

hopefully not too much of a pain to update but i think it'll be nice

vocal spire Jun 28, 2021, 3:49 AM

#

new hk update again?

#

was in the middle of debugging fyremoth, then steam is updating hk....

#

I may or may not have also crashed steam

vocal spire Jun 28, 2021, 4:14 AM

#

api built for new patch https://drive.google.com/file/d/1BN9YfKRrfqikpQqHYyNw-voRo8ZrdLrL/view?usp=sharing

Google Docs

OutputFinal.zip

vocal spire Jun 28, 2021, 4:36 AM

#

[ERROR]:[API] - Error: System.NullReferenceException: Object reference not set to an instance of an object
[ERROR]:[API] -   at System.Delegate.Combine (System.Delegate a, System.Delegate b) [0x00030] in <9577ac7a62ef43179789031239ba8798>:0 
[ERROR]:[API] -   at Modding.ModHooks.add_LanguageGetHook (Modding.LanguageGetProxy value) [0x00008] in <c2a48dab016a4177be1ebaa8c1a99f48>:0 
[ERROR]:[API] -   at Fyremoth.Fyremoth.InitCallbacks () [0x00013] in <858ad8b8baf0461eabc995e5fc05b2ed>:0 
[ERROR]:[API] -   at Fyremoth.Fyremoth.Initialize (System.Collections.Generic.Dictionary`2[TKey,TValue] preloadedObjects) [0x0015b] in <858ad8b8baf0461eabc995e5fc05b2ed>:0 
[ERROR]:[API] -   at Modding.ModLoader.LoadMod (Modding.IMod mod, System.Boolean updateModText, System.Boolean changeSettings, System.Collections.Generic.Dictionary`2[TKey,TValue] preloadedObjects) [0x00047] in <c2a48dab016a4177be1ebaa8c1a99f48>:0 
[ERROR]:[API] -   at Modding.ModLoader+<LoadMods>d__8.MoveNext () [0x00534] in <c2a48dab016a4177be1ebaa8c1a99f48>:0 ```
strange error

#

something tells me I did something else wrong

#

Seems to just be a problem with LanguageGet

copper nacelle Jun 28, 2021, 4:55 AM

#

works for me

#

what did you do

vocal spire Jun 28, 2021, 4:55 AM

#

I cloned and built the api

#

That’s all

#

tried again with the one from actions with the same result

copper nacelle Jun 28, 2021, 5:07 AM

#

the one from actions is about one hk version old

vocal spire Jun 28, 2021, 5:14 AM

#

well I did something very wrong

#

verified files, was fine, tried again with the built one, same result

#

imma sleep for now

primal latch Jun 28, 2021, 5:45 AM

#

Did they update how they implement language?

primal latch Jun 28, 2021, 5:45 AM

#

vocal spire something tells me I did something else wrong

Isn’t this mentioned in the modding help pins?

jolly oriole Jun 28, 2021, 6:38 AM

#

vocal spire was in the middle of debugging fyremoth, then steam is updating hk....

widepeepoHappy

primal latch Jun 28, 2021, 6:39 AM

#

~~Fyremoth leaks but not really~~

light zodiac Jun 28, 2021, 6:42 AM

#

is the mapi in actions updated to .75?

jolly oriole Jun 28, 2021, 6:42 AM

#

I meant to reply to the hk update message but mobile sucks

copper nacelle Jun 28, 2021, 6:43 AM

#

no

#

it'll be updated when I can be bothered downloading the Linux version again

jolly oriole Jun 28, 2021, 6:43 AM

#

light zodiac is the mapi in actions updated to .75?

As long as the latest commit says "updated ci to .72", no

primal latch Jun 28, 2021, 6:44 AM

#

vocal spire api built for new patch https://drive.google.com/file/d/1BN9YfKRrfqikpQqHYyNw-vo...

@light zodiac frog posted a build

#

Although it is probably broken

light zodiac Jun 28, 2021, 6:44 AM

#

thanks

primal latch Jun 28, 2021, 6:45 AM

#

vocal spire ``` [ERROR]:[API] - Error: System.NullReferenceException: Object reference not s...

Seems to be an issue with registering the callback

#

Is our way of using hooks up to date?

jolly oriole Jun 28, 2021, 6:45 AM

#

Idk

primal latch Jun 28, 2021, 6:47 AM

#

jolly oriole Idk

How would you know?

copper nacelle Jun 28, 2021, 6:47 AM

#

why did you ask then bro

primal latch Jun 28, 2021, 6:47 AM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/commit/140c4fb9d640b1f2a8ef89feef23b54404f03e41 does this fix the issue with mac zips?

GitHub

Handle invalid dlls without crashing · HollowKnight-Modding/HollowK...

primal latch Jun 28, 2021, 6:47 AM

#

copper nacelle why did you ask then bro

I asked frog

copper nacelle Jun 28, 2021, 6:47 AM

#

idk what this means

primal latch Jun 28, 2021, 6:48 AM

#

There was an issue with zips by macOS that created a wierd file that also had the extension .dll and that crashed the game

copper nacelle Jun 28, 2021, 6:49 AM

#

should then ig?

light zodiac Jun 28, 2021, 7:15 AM

#

this is hilarious

#

thank you for adding it

jolly oriole Jun 28, 2021, 7:18 AM

#

Wait, you added that to the mapi itself? Lmao

floral blade Jun 28, 2021, 7:20 AM

#

epic

copper nacelle Jun 28, 2021, 7:20 AM

#

it's good for runs

#

Can't hide it

floral blade Jun 28, 2021, 7:22 AM

#

someone dedicated enough could hide both top left list and the icon tamershrug

copper nacelle Jun 28, 2021, 7:22 AM

#

if you're hiding the icon without modifying the API it gets kinda obvious you get me

#

it's also clearer than like the tiny text

#

it's also fun

#

not perfect obv

floral blade Jun 28, 2021, 7:23 AM

#

copper nacelle if you're hiding the icon without modifying the API it gets kinda obvious you ge...

yeah

floral blade Jun 28, 2021, 7:23 AM

#

copper nacelle it's also fun

though i think this is sufficient reason for doing it lol

jolly oriole Jun 28, 2021, 10:35 AM

#

passed my exam, so now i can port mods to the new MApi / hk version

#

smh, not verified commits

rough pulsar Jun 28, 2021, 10:38 AM

#

everyone is too lazy to make a GPG key fleacrying

jolly oriole Jun 28, 2021, 10:38 AM

#

don't worry, like 10% of 56's commits are verified

jolly oriole Jun 28, 2021, 11:48 AM

#

oh no, i have to build myself, no ci for it smh

light zodiac Jun 28, 2021, 11:49 AM

#

https://drive.google.com/uc?export=download&id=1EcqPY6qldQLkaAoUGchjP0yomJG_vPxG

#

If you're lazy

jolly oriole Jun 28, 2021, 11:49 AM

#

can i trust that though? palehmm

#

i have aquired mapi

#

also adding xml docs while porting

primal latch Jun 28, 2021, 1:13 PM

#

jolly oriole passed my exam, so now i can port mods to the new MApi / hk version

congrats

jolly oriole Jun 28, 2021, 1:13 PM

#

thanks

jolly jungle Jun 28, 2021, 1:46 PM

#

Bravo, friend

#

Good luck with everything

jolly jungle Jun 28, 2021, 1:47 PM

#

light zodiac this is hilarious

What's that spaghetti doing there?

jolly oriole Jun 28, 2021, 1:48 PM

#

jolly jungle What's that spaghetti doing there?

it's amazing, isn't it?

jolly jungle Jun 28, 2021, 1:48 PM

#

Is it entirely functional?

jolly oriole Jun 28, 2021, 1:49 PM

#

it's about as functional as the other sprites

jolly jungle Jun 28, 2021, 1:49 PM

#

No the mapi

jolly oriole Jun 28, 2021, 1:49 PM

#

it do be working

jolly jungle Jun 28, 2021, 1:49 PM

#

I thought 1.5 mapi wasn't yet complete

#

Cool

#

Which link should I get it from?

jolly oriole Jun 28, 2021, 1:49 PM

#

afaik 56 still wants to remake a bit of it, but most of it is done

#

mul posted it a bit earlier

jolly oriole Jun 28, 2021, 1:49 PM

#

light zodiac <https://drive.google.com/uc?export=download&id=1EcqPY6qldQLkaAoUGchjP0yomJG_vPx...

here

jolly jungle Jun 28, 2021, 1:50 PM

#

Thanks hollowknice

#

So what changes will all mods need?

jolly oriole Jun 28, 2021, 1:51 PM

#

a few

cedar hemlock Jun 28, 2021, 1:51 PM

#

i believe modhooks are static more idk (exept 2020 and 4.7.2 )

jolly jungle Jun 28, 2021, 1:52 PM

#

jolly oriole a *few*

Why thank you zote

jolly jungle Jun 28, 2021, 1:52 PM

#

cedar hemlock i believe modhooks are static more idk (exept 2020 and 4.7.2 )

Is there any documentation yet?

cedar hemlock Jun 28, 2021, 1:52 PM

#

not that i know but i haven't been keeping up date rly

jolly oriole Jun 28, 2021, 1:54 PM

#

modhooks static, the signatures of those also changed afaik

light zodiac Jun 28, 2021, 2:04 PM

#

save settings changed

#

new modmenu stuff

#

set/get player bool/int/string hook, language.gethook, reflectionhelper changed

jolly jungle Jun 28, 2021, 2:08 PM

#

can you, perhaps, send me basic documentation/a list of changes?

#

If it's not too much

#

It probably is though

light zodiac Jun 28, 2021, 2:09 PM

#

56 put examples follow those

cedar hemlock Jun 28, 2021, 2:09 PM

#

try looking at the commits

#

maybe those can help a little

jolly jungle Jun 28, 2021, 2:09 PM

#

light zodiac 56 put examples follow those

link?

jolly oriole Jun 28, 2021, 2:10 PM

#

in the repo

light zodiac Jun 28, 2021, 2:10 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/ModHooks.cs

jolly oriole Jun 28, 2021, 2:54 PM

#

oh damn, sfcore even gets an update, the item helper now should show amount of items you have (36 rancid eggs count as a single item) / total amount of items (121 rancid eggs count as a single item)

#

well, not "now", but when i upload it

floral blade Jun 28, 2021, 2:56 PM

#

so like a count of held type of items / total types of items ?

jolly oriole Jun 28, 2021, 2:56 PM

#

yes

#

before (or currently, depending on how you want it) it displays the numbers of the hunters journal

floral blade Jun 28, 2021, 2:58 PM

#

ah cool

primal latch Jun 28, 2021, 2:59 PM

#

jolly oriole oh damn, sfcore even gets an update, the item helper now should show `amount of ...

did you also test the bug I sent here?

jolly oriole Jun 28, 2021, 3:00 PM

#

i hate discord

primal latch Jun 28, 2021, 3:00 PM

#

also: why does the mapi use a custom version of mscorlib?

jolly oriole Jun 28, 2021, 3:00 PM

#

to have reflection.emit

jolly oriole Jun 28, 2021, 3:01 PM

#

primal latch did you also test the bug I sent here?

on it after i ported the entirety of sfcore

primal latch Jun 28, 2021, 3:01 PM

#

ok

jolly oriole Jun 28, 2021, 3:06 PM

#

apparently building it just now worked, so

#

i just add a counted item with a custom sprite, right?

floral blade Jun 28, 2021, 3:08 PM

#

Expansion of my flappy knight idea:

The player is a shade, and they're looking for their hollow shell (the mask they drop on death),player has infinite 'jumps' and touching any and all walls damages the shade. picking up the shell allows the player to play as the knight for a short duration of time but every shell breaks eventually.

defeating THK is just a way of stealing their shell, permanently.

jolly oriole Jun 28, 2021, 3:09 PM

#

jolly oriole i just add a counted item with a custom sprite, right?

@primal latch ping for visibility

primal latch Jun 28, 2021, 3:09 PM

#

jolly oriole <@!460108615110623232> ping for visibility

what do you mean?

jolly oriole Jun 28, 2021, 3:10 PM

#

how you encountered the bug

primal latch Jun 28, 2021, 3:10 PM

#

#archived-modding-development message

jolly oriole Jun 28, 2021, 3:10 PM

#

<@&283547423706447872>

cedar hemlock Jun 28, 2021, 3:10 PM

#

<@&283547423706447872>

primal latch Jun 28, 2021, 3:10 PM

#

<@&283547423706447872>

cedar hemlock Jun 28, 2021, 3:10 PM

#

too late

jolly oriole Jun 28, 2021, 3:10 PM

#

lol

wary rose Jun 28, 2021, 3:11 PM

#

guys

#

one at a time

glossy olive Jun 28, 2021, 3:11 PM

#

Thank you

#

Also

cedar hemlock Jun 28, 2021, 3:11 PM

#

lol

primal latch Jun 28, 2021, 3:11 PM

#

lmao that was fast

glossy olive Jun 28, 2021, 3:11 PM

#

They do it in several channels

primal latch Jun 28, 2021, 3:11 PM

#

jolly oriole how you encountered the bug

I didn't encounter it. @lofty quiver did

jolly oriole Jun 28, 2021, 3:12 PM

#

primal latch https://discord.com/channels/283467363729408000/327461802311155714/8413620651757...

that is already done, but i'll try to get 2 simple keys ig

lofty quiver Jun 28, 2021, 3:13 PM

#

primal latch I didn't encounter it. <@!826917811712557058> did

Hey, can i help?

jolly oriole Jun 28, 2021, 3:13 PM

#

sfcore itemhelper bug, 2 keys displaying flower sprite

primal latch Jun 28, 2021, 3:14 PM

#

lofty quiver Jun 28, 2021, 3:14 PM

#

Yea, if you need i can send a screen, but not now...

lofty quiver Jun 28, 2021, 3:14 PM

#

primal latch

Damn

primal latch Jun 28, 2021, 3:14 PM

#

#

the screenshot flare sent

lofty quiver Jun 28, 2021, 3:15 PM

#

Ok

jolly oriole Jun 28, 2021, 3:15 PM

#

primal latch

sunglasses_guy_tm

lofty quiver Jun 28, 2021, 3:15 PM

#

jolly oriole <:sunglasses_guy_tm:465869115106525185>

weird flex but ok lol

primal latch Jun 28, 2021, 3:16 PM

#

jolly oriole <:sunglasses_guy_tm:465869115106525185>

I don't even own this game for 3 months on PC

jolly oriole Jun 28, 2021, 3:16 PM

#

i own it since matpat did his theory

#

time to test items

primal latch Jun 28, 2021, 3:16 PM

#

jolly oriole i own it since matpat did his theory

I got it for free around 3 months ago when I volunteered for Fyremoth

jolly oriole Jun 28, 2021, 3:20 PM

#

where was a debug build for .75 again?

primal latch Jun 28, 2021, 3:20 PM

#

you mean of the mapi?

jolly oriole Jun 28, 2021, 3:21 PM

#

nah, debug mod

primal latch Jun 28, 2021, 3:21 PM

#

Don't think there is one

#

@copper nacelle I used steamcmd to download the unix version so you don't have to: https://github.com/HollowKnight-Modding/HollowKnight.Modding/pull/54

GitHub

updated CI to version 1.5.75.11827 by mandar1jn · Pull Request #54 ...

light zodiac Jun 28, 2021, 3:23 PM

#

jolly oriole where was a debug build for .75 again?

https://github.com/TheMulhima/HollowKnight.DebugMod/releases/download/v1.4.2/DebugMod.dll

jolly oriole Jun 28, 2021, 3:23 PM

#

thanks

primal latch Jun 28, 2021, 3:24 PM

#

is there a .75 modcommon build?

jolly oriole Jun 28, 2021, 3:29 PM

#

uh, can others try to debug themselves geo? i don't get the geo

primal latch Jun 28, 2021, 3:30 PM

#

jolly oriole uh, can others try to debug themselves geo? i don't get the geo

I do get it

jolly oriole Jun 28, 2021, 3:31 PM

#

hm, weird

#

ok, setint and getint hooks don't seem to work like the docs suggest they do

#

having

private int OnSetPlayerIntHook(string target, int orig)
{
    return orig;
}

makes it so i never get geo and possibly any other pd int

copper nacelle Jun 28, 2021, 3:37 PM

#

omegaMaggotPrime

light zodiac Jun 28, 2021, 3:38 PM

#

jolly oriole uh, can others try to debug themselves geo? i don't get the geo

debug as in use debug mod to get geo?

jolly oriole Jun 28, 2021, 3:38 PM

#

both

copper nacelle Jun 28, 2021, 3:38 PM

#

https://www.github.com/HollowKnight-Modding/HollowKnight.Modding/tree/master/Assembly-CSharp%2FModHooks.cs#L850

jolly oriole Jun 28, 2021, 3:39 PM

#

get works fine

light zodiac Jun 28, 2021, 3:39 PM

#

I'm able to get geo using debug mod

primal latch Jun 28, 2021, 3:39 PM

#

same

jolly oriole Jun 28, 2021, 3:39 PM

#

i know how to fix the setint hook, i'll just throw an exception and then it will work

copper nacelle Jun 28, 2021, 3:39 PM

#

oh I'm bad

jolly oriole Jun 28, 2021, 3:39 PM

#

maybe

#

nvm

copper nacelle Jun 28, 2021, 3:40 PM

#

return.png

jolly oriole Jun 28, 2021, 3:40 PM

#

copper nacelle return.png

https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/ModHooks.cs#L807

primal latch Jun 28, 2021, 3:40 PM

#

does anyone have a .75 build of modcommon?

vocal spire Jun 28, 2021, 3:40 PM

#

I’ve got one that kinda works

primal latch Jun 28, 2021, 3:40 PM

#

nice

#

because without modcommon Fyremoth destroys the save select

vocal spire Jun 28, 2021, 3:41 PM

#

Same one I used for other 1.5 patches

primal latch Jun 28, 2021, 3:41 PM

#

for some wierd reason

vocal spire Jun 28, 2021, 3:41 PM

#

primal latch because without modcommon Fyremoth destroys the save select

🤔 what

#

Has that been my problem

primal latch Jun 28, 2021, 3:41 PM

#

vocal spire Has that been my problem

yes

vocal spire Jun 28, 2021, 3:42 PM

#

My Modcommon fails to load but the library part is fine

#

I will figure out why that happens

jolly oriole Jun 28, 2021, 3:42 PM

#

imagine having anything fail

vocal spire Jun 28, 2021, 3:42 PM

#

Did you really think I’d put in the effort to slightly change modcommon’s code?

primal latch Jun 28, 2021, 3:44 PM

#

not really

vocal spire Jun 28, 2021, 3:45 PM

#

Yep I remove fyremoth and it’s fine

#

Why

jolly oriole Jun 28, 2021, 3:45 PM

#

not updating legacy code elderCUltra

copper nacelle Jun 28, 2021, 3:45 PM

#

updating modcommon I sleep

#

using it as an excuse to not use it again I awaken

jolly oriole Jun 28, 2021, 3:46 PM

#

change every method to

throw new NotImplementedException();

vocal spire Jun 28, 2021, 3:46 PM

#

Ah yes I love when windows stops working zote

light zodiac Jun 28, 2021, 3:46 PM

#

@floral blade why is my big knight doing this

primal latch Jun 28, 2021, 3:47 PM

#

oh my god

vocal spire Jun 28, 2021, 3:47 PM

#

light zodiac <@!731231925599076432> why is my big knight doing this

Iirc you need to hook some extra methods (ex: turning) for it to look smooth

light zodiac Jun 28, 2021, 3:49 PM

#

turning?

patent zealot Jun 28, 2021, 3:49 PM

#

beeg knight

light zodiac Jun 28, 2021, 3:50 PM

#

also why doesnt it become big from y and x. currently is only becoming big on y

primal latch Jun 28, 2021, 3:53 PM

#

because

#

just because

floral blade Jun 28, 2021, 3:58 PM

#

light zodiac <@!731231925599076432> why is my big knight doing this

Did you change Look left look right hooks ?

jolly oriole Jun 28, 2021, 3:58 PM

#

56, can you remove that single line? it's literally killing everything rn

copper nacelle Jun 28, 2021, 3:58 PM

#

I can but will I

#

and yeah after I get out of bed

light zodiac Jun 28, 2021, 4:00 PM

#

floral blade Did you change Look left look right hooks ?

i just changed 0.5 to 5

#

that is probably the reason then

jolly oriole Jun 28, 2021, 4:00 PM

#

copper nacelle and yeah after I get out of bed

wait a second, i could just make that change myself

copper nacelle Jun 28, 2021, 4:01 PM

#

very true

#

do it on vector3 too if you do

#

I missed it there as well

floral blade Jun 28, 2021, 4:02 PM

#

light zodiac that is probably the reason then

I might have hard-coded 0.5 somewhere lol

light zodiac Jun 28, 2021, 4:02 PM

#

i changed that but it still doesnt change the knights x scale

floral blade Jun 28, 2021, 4:03 PM

#

There's also the setscale fsm thingy

light zodiac Jun 28, 2021, 4:03 PM

#

in setVignette?

floral blade Jun 28, 2021, 4:03 PM

#

Oh wait there's also the check to see if you're actually smol or not

jolly oriole Jun 28, 2021, 4:04 PM

#

copper nacelle I missed it there as well

https://github.com/HollowKnight-Modding/HollowKnight.Modding/pull/55 have it

light zodiac Jun 28, 2021, 4:04 PM

#

floral blade Oh wait there's also the check to see if you're actually smol or not

currentPlayerIsSmol = ( (playerTransform.localScale.x*playerTransform.localScale.x) < currentScale ) && ((playerTransform.localScale.y*playerTransform.localScale.y) < currentScale );

floral blade Jun 28, 2021, 4:08 PM

#

Yes but this should only impact if HKMP is on iirc

#

Maybe there's a vanilla check to fix x scale ?

jolly oriole Jun 28, 2021, 4:08 PM

#

oh damn, i appear to have made an error with selecting the sprite to display

#

defaultSprites["Simple Key"] = (Sprite) UObject.Instantiate(equipmentGo.FindGameObjectInChildren("Xun Flower")

nice

primal latch Jun 28, 2021, 4:10 PM

#

jolly oriole oh damn, i appear to have made an error with selecting the sprite to display

that explains the report

light zodiac Jun 28, 2021, 4:11 PM

#

I'm just gonna yeet everything that related to hkmp for now

floral blade Jun 28, 2021, 4:12 PM

#

Makes sense

jolly oriole Jun 28, 2021, 4:14 PM

#

my game isn't responding smh

#

nvm, it did

#

i have aquired ke

floral blade Jun 28, 2021, 4:18 PM

#

light zodiac I'm just gonna yeet everything that related to hkmp for now

For now you could try removing the check on time and call smol / beeg every playerUpdate and see if that works as expected

vocal spire Jun 28, 2021, 4:18 PM

#

Iirc that makes the knight flash different sizes, might be remembering wrong tho

floral blade Jun 28, 2021, 4:19 PM

#

vocal spire Iirc that makes the knight flash different sizes, might be remembering wrong tho

Yes but the hooks are overriding the scale in smolknight anyway

jolly oriole Jun 28, 2021, 4:28 PM

#

does the chinese translation use traditional or simplified chinese?

#

nvm, appears to be simplified

#

more custom text (lower right corner)

floral blade Jun 28, 2021, 5:59 PM

#

@light zodiac seems to be working fine! (edit: figured it out)

Screenshot_2021-06-28_at_11.25.14_PM.png

#

Screenshot_2021-06-28_at_11.28.56_PM.png

#

a feature request though: can you change the number of the save in the save select screen to match it's backup number ?

light zodiac Jun 28, 2021, 6:02 PM

#

I updated to a new version

#

https://github.com/TheMulhima/MoreSaves/releases/download/v0.4.6-1.5.75/MoreSaves.dll

light zodiac Jun 28, 2021, 6:02 PM

#

floral blade a feature request though: can you change the number of the save in the save sele...

I don't get what you mean?

floral blade Jun 28, 2021, 6:03 PM

#

this is save 12, yet the number says 4

Screenshot_2021-06-28_at_11.33.40_PM.png

light zodiac Jun 28, 2021, 6:04 PM

#

This should save as save 12

#

And it does

#

Just the menu didn't update because uimanager needs to be destroyed for getmenuscreen to be called again which is required to generate new buttons

floral blade Jun 28, 2021, 6:06 PM

#

this looks great! could the note be made static / the first thing the player sees ?

Screenshot_2021-06-28_at_11.35.10_PM.png

floral blade Jun 28, 2021, 6:06 PM

#

light zodiac Just the menu didn't update because uimanager needs to be destroyed for getmenus...

it does save as 12, it just keeps saying 4 on the left

fickle sparrow Jun 28, 2021, 6:07 PM

#

you can always manually do the menu stuff btw

floral blade Jun 28, 2021, 6:07 PM

#

light zodiac Just the menu didn't update because uimanager needs to be destroyed for getmenus...

you can call the update thingy

light zodiac Jun 28, 2021, 6:07 PM

#

Oh like that

floral blade Jun 28, 2021, 6:07 PM

#

i call it manually to update ck

fickle sparrow Jun 28, 2021, 6:07 PM

#

like you can edit MenuScreens

#

even after the thing calls GetMenuScreen

floral blade Jun 28, 2021, 6:08 PM

#

for example, i just keep a reference and call menuSetting.RefreshValueFromGameSettings() to update the horizontal lists

fickle sparrow Jun 28, 2021, 6:08 PM

#

yeah

#

all of the actual Modding.Menu code should be able to just be done through user code

floral blade Jun 28, 2021, 6:11 PM

#

yes i tried that, made a custom knight entry beside mods lol was fun

#

that's how i figured mods menu was being yeeted

fickle sparrow Jun 28, 2021, 6:12 PM

#

yeah if you don't even want to use the ICustomMenuMod shit

#

you just hook on to UIManager.EditMenus

floral blade Jun 28, 2021, 6:13 PM

#

fickle sparrow yeah if you don't even want to use the `ICustomMenuMod` shit

i like this because this gives mods a standard place to live, the only other menu system i'd go to is if something like weavercore's taskbar thingy was in mapi itself.

fickle sparrow Jun 28, 2021, 6:13 PM

#

yeah

#

but sometimes you need a lot more direct control

floral blade Jun 28, 2021, 6:14 PM

#

so that players didn't need to go in 2 level deep menus

fickle sparrow Jun 28, 2021, 6:14 PM

#

mhm

#

I might look into making a better way to add things directly to the options menu?

#

I'll see

floral blade Jun 28, 2021, 6:14 PM

#

fickle sparrow but sometimes you need a lot more direct control

yeah, i don't see debug / benchwarp using this, for example

fickle sparrow Jun 28, 2021, 6:14 PM

#

I don't want to pollute the option menu though

floral blade Jun 28, 2021, 6:15 PM

#

please consider a small taskbar like menu on the top of the screen, that can be hidden

fickle sparrow Jun 28, 2021, 6:16 PM

#

maybe

#

the problem is that tc does not have super good infrastructure for that

floral blade Jun 28, 2021, 6:16 PM

#

fickle sparrow I might look into making a better way to add things directly to the options menu...

if i want this i will steal mods menu code vesselsip

fickle sparrow Jun 28, 2021, 6:17 PM

#

I guess it is pretty simple

#

only 15 lines or something

floral blade Jun 28, 2021, 6:17 PM

#

fickle sparrow the problem is that tc does not have super good infrastructure for that

i'm not sure what you mean, it's basically the same menu / control logic right ? just shows up on top

fickle sparrow Jun 28, 2021, 6:17 PM

#

I'm confused then

#

do you just mean a taskbar in the pause menu?

floral blade Jun 28, 2021, 6:18 PM

#

yes, pretty much

fickle sparrow Jun 28, 2021, 6:18 PM

#

ah pauseshroom it would be ugly

#

I'll leave that to a mod to add ngl

floral blade Jun 28, 2021, 6:18 PM

#

it would be tiny and would auto hide sadcowgrub

fickle sparrow Jun 28, 2021, 6:19 PM

#

part of my goal for the mod stuff built into the api

floral blade Jun 28, 2021, 6:19 PM

#

no more clutter on pause menu even for mods like debug

fickle sparrow Jun 28, 2021, 6:19 PM

#

is to replicate the look and feel of vanilla menus

#

and this would be a fairly dramatic break from that

floral blade Jun 28, 2021, 6:19 PM

#

that is true, the menu looks and feels seamless i cannot argue with that loveblood

fickle sparrow Jun 28, 2021, 6:20 PM

#

yeah they look seamless because I spent like a month or something reverse engineering all of the structures ax1uWide3

#

also I'm not sure how controller players would navigate something like that

#

cause it might be kinda counter intuitive

floral blade Jun 28, 2021, 6:22 PM

#

the only reason i want something like that to be a part of mapi is :

it gives everyone a clear incentive to use the standard way of doing it rather than a bunch of ways of implementing it existing & it would be better than current pause menu clutter that exists.

fickle sparrow Jun 28, 2021, 6:23 PM

#

wait what pause menu clutter

floral blade Jun 28, 2021, 6:23 PM

#

i agree that there's not a simple solution for controller players either, because that would be kind of upto the mod to implement, just a standard way to show / hide a mod's interface is all i ask

fickle sparrow Jun 28, 2021, 6:23 PM

#

honestly though like

#

keybind to show the menu

#

its possible in game I think

#

maybe

floral blade Jun 28, 2021, 6:24 PM

#

fickle sparrow wait what pause menu clutter

debug + benchwarp + hkmp + customknight on 1.4.3.2 was a mess if one didn't use the hide menu option of each of them for example.

fickle sparrow Jun 28, 2021, 6:24 PM

#

oh is it because they like

merry lotus Jun 28, 2021, 6:25 PM

#

fickle sparrow wait what pause menu clutter

A lot of mods in 1.4 use their own menus on the pause screen, and they overlap of you have some of them at the same time. Some mods are adding ways to toggle their UI, but it's not a standard

fickle sparrow Jun 28, 2021, 6:25 PM

#

had info when you pressed f1

#

oh well

#

pauseshroom

#

put them in the mod menu imo

floral blade Jun 28, 2021, 6:25 PM

#

merry lotus A lot of mods in 1.4 use their own menus on the pause screen, and they overlap o...

yes this

floral blade Jun 28, 2021, 6:25 PM

#

fickle sparrow put them in the mod menu imo

too burried in for something like benchwarp / debug , sadly.

merry lotus Jun 28, 2021, 6:25 PM

#

Does the mods menu currently go Options > Mods in 1.5, like in 1.4? Because a simple change of putting Mods into the top menu would already be nice.

Possibly a shortcut code could be put in to pull it up too, like SHIFT + [Pause button] could pause and instantly open mod options. ||(This might be overkill though.)||

fickle sparrow Jun 28, 2021, 6:26 PM

#

so much effort

#

and again I want to keep the mod menu its own thing

light zodiac Jun 28, 2021, 6:26 PM

#

fickle sparrow like you can edit `MenuScreen`s

that was actually really easy lol

fickle sparrow Jun 28, 2021, 6:26 PM

#

and not stick everything in the option menu

light zodiac Jun 28, 2021, 6:26 PM

#

i was just being stupid

fickle sparrow Jun 28, 2021, 6:27 PM

#

if you wanted you could add a custom keybind to pause -> switch to menu

#

just create a coro thats like

merry lotus Jun 28, 2021, 6:28 PM

#

I meant put the button for mod menu in the top pause menu, assuming it's currently in the options menu. I haven't messed around with the 1.5 API stuff, so for all I know is already there.

light zodiac Jun 28, 2021, 6:29 PM

#

so like GameManager.instance.TogglePause() and then UIManager.instance.UIGoToDynamicMenu(yourscreen) to open that screen?

floral blade Jun 28, 2021, 6:29 PM

#

merry lotus I meant put the button for mod menu in the top pause menu, assuming it's current...

it is in options currently

fickle sparrow Jun 28, 2021, 6:30 PM

#

PauseGameToggle but yeah exactly

#

it should be easy

floral blade Jun 28, 2021, 6:32 PM

#

the problem is : if it's upto mods to implement a pause menu they'd all come up with different solutions and it'll be back to the old setup pretty soon i think and then show/hide the keybindings setup is back again where you have to hide all other mods before you use one and so on and so forth.

instead if we could have a "hide all mod uis except this one" button that was part of the api itself i feel like a lot more mods would be onboard with that

fickle sparrow Jun 28, 2021, 6:32 PM

#

you see

#

you can have bindable keybinds now

#

and this would interface directly to the menu

#

so it would be hide all mod uis except this one

floral blade Jun 28, 2021, 6:33 PM

#

fickle sparrow so it would be `hide all mod uis except this one`

maybe i'm missing it but how does one achieve this ?

#

with custom pause menu UIs i.e.

light zodiac Jun 28, 2021, 6:34 PM

#

see timer mod 1.5 its pinned

#

wait i misunderstoof

#

nvm

fickle sparrow Jun 28, 2021, 6:34 PM

#

yield return GameManage.instance.PauseGameToggle();
if(GameManager.instance.gameState == GameState.PAUSED) {
  yield return UIManager.instance.GoToDynamicMenu(myMenuScreen);
}

#

basically this

#

im not sure if you need to iterate through the two things that are being yield return'd

#

but its a solid maybe

#

anyways

floral blade Jun 28, 2021, 6:35 PM

#

yes but custom menus just draw whatever they want when the game is paused right ? grubsad

fickle sparrow Jun 28, 2021, 6:35 PM

#

no

#

they would use the menu api

#

you can place text panels and shit on the menu screens

floral blade Jun 28, 2021, 6:35 PM

#

oh if they all used the menu api then it would work

fickle sparrow Jun 28, 2021, 6:35 PM

#

yes

floral blade Jun 28, 2021, 6:35 PM

#

yes

fickle sparrow Jun 28, 2021, 6:36 PM

#

like you can just create a MenuScreen wrapped around your custom drawing

#

all of this garbage is optional

floral blade Jun 28, 2021, 6:37 PM

#

yep gotcha, now to just incentivise people to use this in their mods vs just drawing beside pause menu

fickle sparrow Jun 28, 2021, 6:37 PM

#

well I mean

#

its super easy to like

#

kinda use the menu

#

so if they don't use it

#

blorry_Wizzer

#

trolling imo

floral blade Jun 28, 2021, 6:38 PM

#

i like it , i just want it to be used a bunch so i can have my mods and my clean pause menu

fickle sparrow Jun 28, 2021, 6:38 PM

#

yeah

#

I just need to make sure of something

#

uh

#

what does this do

#

it just adds a single frame delay to the start wtf

#

w h a t

#

local girl is incredibly confused

candid sapphire Jun 28, 2021, 6:43 PM

#

How would I add a boss to godhome?

fickle sparrow Jun 28, 2021, 6:50 PM

#

well it kinda works

#

its just slow

#

I'm gonna implement a patch that moves it directly to the screen

floral blade Jun 28, 2021, 6:51 PM

#

i present to you my bad krita edit

Screenshot_2021-06-29_at_12.21.10_AM.png

light zodiac Jun 28, 2021, 6:51 PM

#

floral blade this is save 12, yet the number says 4

that's going to be effort lol

light zodiac Jun 28, 2021, 6:52 PM

#

floral blade this looks great! could the note be made static / the first thing the player see...

and i dont need that text anymore

floral blade Jun 28, 2021, 6:52 PM

#

fickle sparrow I'm gonna implement a patch that moves it directly to the screen

each of those "CK" is a button that directly does this magic

fickle sparrow Jun 28, 2021, 6:52 PM

#

yeah but like pauseshroom not scaleable at all

#

horizontal scroll bars are cursed

vocal spire Jun 28, 2021, 6:53 PM

#

Does the modding.menu stuff reload on language change?

fickle sparrow Jun 28, 2021, 6:53 PM

#

doubt it

jolly oriole Jun 28, 2021, 6:53 PM

#

smh

fickle sparrow Jun 28, 2021, 6:53 PM

#

lang integration is extreme effort

#

create a component that auto edits the text tbh

vocal spire Jun 28, 2021, 6:54 PM

#

Ok

jolly oriole Jun 28, 2021, 6:54 PM

#

fickle sparrow create a component that auto edits the text tbh

that exists though

vocal spire Jun 28, 2021, 6:54 PM

#

Yeah

fickle sparrow Jun 28, 2021, 6:54 PM

#

yeah then just add that

#

its so easy

#

adding it to the api is so much effort

#

and way too many settings for it imo

jolly oriole Jun 28, 2021, 6:55 PM

#

(- textfield)

sheettitle
textkey

floral blade Jun 28, 2021, 6:56 PM

#

fickle sparrow yeah but like <:pauseshroom:828356278651846706> not scaleable at all

but also pretty & would solve this issue for most people, a horizontal scroll would be avoidable by using a ">" key to go to next page

#

it also makes accessing mod menus a pause + one click without cluttering the pause menu itself too much

fickle sparrow Jun 28, 2021, 6:57 PM

#

that completely breaks the vanilla feel honestly

#

so I'd rather not include it in the api

jolly oriole Jun 28, 2021, 6:57 PM

#

jolly oriole (- textfield) - sheettitle - textkey

fickle sparrow Jun 28, 2021, 6:57 PM

#

people can add this themselves its super easy

#

I have the out variables for a reason

floral blade Jun 28, 2021, 6:58 PM

#

yeah but then it's not a standard so no one would do it 😦

vocal spire Jun 28, 2021, 6:59 PM

#

Just switch the text for Lang keys

floral blade Jun 28, 2021, 6:59 PM

#

either way i think i won't change your mind feelsgrubman i accept defeat

fickle sparrow Jun 28, 2021, 6:59 PM

#

fine I might add a lang key meme

#

if C# had sum types it would be like so much nicer

light zodiac Jun 28, 2021, 7:05 PM

#

fickle sparrow ```cs yield return GameManage.instance.PauseGameToggle(); if(GameManager.instanc...

with this maybe i can consider moving debug UI to the mod menu

fickle sparrow Jun 28, 2021, 7:05 PM

#

I am adding something to make it easier

light zodiac Jun 28, 2021, 7:06 PM

#

I'll wait for that ig

jolly jungle Jun 28, 2021, 7:08 PM

#

I entirely forgot to ask

#

Who's working on a 1.5 modcommon?

floral blade Jun 28, 2021, 7:08 PM

#

jolly jungle Who's working on a 1.5 modcommon?

yeeted it

jolly jungle Jun 28, 2021, 7:08 PM

#

Gonna all be in the MAPI?

floral blade Jun 28, 2021, 7:08 PM

#

no i yeeted it and copied thingies into my mod

jolly oriole Jun 28, 2021, 7:09 PM

#

nah, other lib mods or copy pasted into the mod

jolly jungle Jun 28, 2021, 7:09 PM

#

Oh shit

light zodiac Jun 28, 2021, 7:09 PM

#

SFCore when

jolly jungle Jun 28, 2021, 7:09 PM

#

So I'm gonna have to copy in all the fsm stuff?

jolly oriole Jun 28, 2021, 7:09 PM

#

light zodiac SFCore when

oh fuck, there was something

#

works for now, still want to add docs

📎 SFCore.dll

light zodiac Jun 28, 2021, 7:10 PM

#

who needs docs

jolly oriole Jun 28, 2021, 7:10 PM

#

true, some helpers have a single public function, idk if i need to tell the people what that function is called

fickle sparrow Jun 28, 2021, 7:14 PM

#

mms

light zodiac Jun 28, 2021, 7:18 PM

#

forcing modders to play ag nice

floral blade Jun 28, 2021, 7:18 PM

#

light zodiac forcing modders to play ag nice

what's ag ?

jolly oriole Jun 28, 2021, 7:19 PM

#

All staGs

floral blade Jun 28, 2021, 7:20 PM

#

i am just as confused now as i was earlier lol , do they mean that they cant save and quit so they need to get all stags to finish the game ?

jolly oriole Jun 28, 2021, 7:22 PM

#

yuri

#

no need to autotranslate

#

or: have those as additional methods and let the users care about having the correct lang strings

light zodiac Jun 28, 2021, 7:26 PM

#

floral blade what's ag ?

all glitches

floral blade Jun 28, 2021, 7:26 PM

#

oh the one where the menu makes one float ?

fickle sparrow Jun 28, 2021, 7:28 PM

#

ok this is working

#

I also uh

#

broke the mods that use menus

#

🥴 they just need to be recompiled

copper nacelle Jun 28, 2021, 7:29 PM

#

🥴

fickle sparrow Jun 28, 2021, 7:30 PM

#

look whats a little breakage

#

its not my fault C# handles optional arguments in a scuffed way

#

anyways tldr

#

#

free trick

#

idk if the null check is really useful but can't be too safe

#

you can also call PauseToggleDynamicMenu(menuScreen, true) to be able to actually toggle it instead of only opening it

light zodiac Jun 28, 2021, 7:36 PM

#

nice

fickle sparrow Jun 28, 2021, 7:39 PM

#

I spent like 10 minutes trying to figure out why the the menu wasn't closing

#

and then I realized I forgot to set the ui state to paused

#

pauseshroom

#

also if you wanted to add some sort of taskbar

#

I think you should be able to get all of the loaded menu mods and construct it yourself

#

basically a budget modlistmenu

#

I'm like 35% sure you can get a list of all loaded mods

#

from outside code without reflection

#

of course you can just use reflection if you need to but echaleph

floral blade Jun 28, 2021, 7:46 PM

#

but won't one need to build new menus then ?

#

by calling GetMenuScreen ?

fickle sparrow Jun 28, 2021, 7:51 PM

#

I guess I can cache the built menu screens or something

floral blade Jun 28, 2021, 7:52 PM

#

and expose them to a public thingy popseeker ?

fickle sparrow Jun 28, 2021, 7:52 PM

#

yeah

#

just in a map or some meme

#

in modhooks ig

jolly oriole Jun 28, 2021, 8:07 PM

#

i love letting others handle things

fickle sparrow Jun 28, 2021, 8:13 PM

#

alright

#

#

BuiltModMenuScreens gets wiped each EditMenus call

#

wait I made a funny error

#

actually I doubt anything will happen

jolly oriole Jun 28, 2021, 8:15 PM

#

why am i bothering with letting users pick unique names? but do i want to generate random strings?

fickle sparrow Jun 28, 2021, 8:15 PM

#

I guess this is a feature

#

ax1uWide3

light zodiac Jun 28, 2021, 8:15 PM

#

With ICustomMenu is Getmenuscreen called before the mods initialize?

floral blade Jun 28, 2021, 8:15 PM

#

light zodiac With ICustomMenu is Getmenuscreen called before the mods initialize?

after

fickle sparrow Jun 28, 2021, 8:16 PM

#

its called at the same time as IMenuMod btw

light zodiac Jun 28, 2021, 8:16 PM

#

Nice. I just wanted to know whether I would get screwed over for including a dict in init and looking for that

fickle sparrow Jun 28, 2021, 8:16 PM

#

yeah you can totally do that

floral blade Jun 28, 2021, 8:17 PM

#

fickle sparrow `BuiltModMenuScreens` gets wiped each `EditMenus` call

so does it get wiped or no?

#

so if i'd just do var x = ModHooks.LoadedModInstances() at some point for example , do i need to worry about the mods disappearing from the list ?

#

if they get toggled off for example

fickle sparrow Jun 28, 2021, 8:26 PM

#

nah none of them actually get mutated

#

when the menus are rebuilt

#

BuiltModMenuScreens will become a new dict

#

but the old one wont get cleared

floral blade Jun 28, 2021, 8:27 PM

#

so the references my mod holds will be useless ?

fickle sparrow Jun 28, 2021, 8:27 PM

#

yeah

#

just acquire a new reference the frame after EditMenus I think

#

or something like that

floral blade Jun 28, 2021, 8:27 PM

#

~~playerupdate it is then~~ ah yes

fickle sparrow Jun 28, 2021, 8:28 PM

#

either way its functionally the same

#

because I can't really guarantee the order of EditMenus

#

most likely your hook will be after modlistmenu though

#

like just reacquire ModHooks.LoadedModInstances when you need to

floral blade Jun 28, 2021, 8:30 PM

#

wait so if i understand correctly GetMenuScreen could be called multiple times throughout the life of the mod, and devs need to be careful about it

fickle sparrow Jun 28, 2021, 8:30 PM

#

yeah sure

light zodiac Jun 28, 2021, 8:30 PM

#

floral blade wait so if i understand correctly GetMenuScreen could be called multiple times t...

~~could~~ will

fickle sparrow Jun 28, 2021, 8:31 PM

#

SubmitAction = _ => UIManager.instance.UIGoToDynamicMenu(ModHooks.BuiltModMenuScreens[thisMod])

#

this will always work as long as thisMod has a menuscreen

floral blade Jun 28, 2021, 8:32 PM

#

okay this makes sense

#

will an unloaded mod have a menuscreen ?

fickle sparrow Jun 28, 2021, 8:32 PM

#

yeah

#

Unload doesn't really unload a mod btw

#

the Mod instance still exists

#

a

floral blade Jun 28, 2021, 8:33 PM

#

alright then this is perfect, mods don't really get added or removed after the initial load

fickle sparrow Jun 28, 2021, 8:33 PM

#

yeah

jolly oriole Jun 28, 2021, 8:33 PM

#

currently

fickle sparrow Jun 28, 2021, 8:33 PM

#

although when the menus are rebuilt

#

I'd just iterate through them just to make sure

#

foreach(IMod mod in ModHooks.LoadedModInstances) {
  if(mod is IMenuMod immod) {
      //add the button with
      SubmitAction = _ => UIManager.instance.UIGoToDynamicMenu(ModHooks.BuiltModMenuScreens[mod]),
      // etc etc
  }
  // same thing for ICustomMenuMod
}

#

this will lazily evaluate ModHooks.BuiltModMenuScreens

#

so even if for some reason this is called before ModListMenu is built, it will still work

floral blade Jun 28, 2021, 8:37 PM

#

i still gotta wait till all the mods are loaded though, i don't think there's a way to know right now when that is , correct ?

fickle sparrow Jun 28, 2021, 8:37 PM

#

no the mods all load first

#

otherwise there is no way any of the mod code would be run

floral blade Jun 28, 2021, 8:39 PM

#

i mean could it be that my mod could be in the middle of the load order and there are other mods that have not been instantiated, yet?

fickle sparrow Jun 28, 2021, 8:39 PM

#

1. Load all mods
2. Call `Initialize` of all mods
3. Create ModListMenu

floral blade Jun 28, 2021, 8:39 PM

#

ah that answers my question

fickle sparrow Jun 28, 2021, 8:39 PM

#

actually

#

I'm pretty sure this is right?

#

yeah it is

#

the constructors run really early

floral blade Jun 28, 2021, 8:40 PM

#

i guess there's the preload objects step after it

fickle sparrow Jun 28, 2021, 8:41 PM

#

either way you don't need to worry about the load order there

#

only thing that might be sketchy is the ModListMenu?

#

but I doubt it because you're lazily accessing it

floral blade Jun 28, 2021, 8:42 PM

#

there is another concern, the cancel action on all mod menus' buttons etc will take back to the mods menu and not pause menu

fickle sparrow Jun 28, 2021, 8:42 PM

#

yes that is intended

#

you click escape to exit the pause menu

#

vanilla menus work the same way

#

like theoretically

floral blade Jun 28, 2021, 8:43 PM

#

yep i get that it is intended but if i invoke the menu manually, then wouldnt player expectation be to go back to where they started from ?

fickle sparrow Jun 28, 2021, 8:43 PM

#

you could just call the build menus again right

#

and set the modlistmenu to the option menu

#

but like I wouldn't worry about it

floral blade Jun 28, 2021, 8:43 PM

#

yes, that works

fickle sparrow Jun 28, 2021, 8:44 PM

#

like probably don't do that tbh

floral blade Jun 28, 2021, 8:44 PM

#

some mods will probably have side effects in there i am sure of it

fickle sparrow Jun 28, 2021, 8:44 PM

#

yeah thats why I wouldn't do it

#

most people will be clicking the escape button tbh

floral blade Jun 28, 2021, 8:46 PM

#

true, but it does break the experience a bit.
could the modmenus not take the backmenuscreen when going to a menu ?

#

(idk if that'd break vanilla)

fickle sparrow Jun 28, 2021, 8:47 PM

#

changing that would require rewriting a shit ton of code

#

I'd essentially have to keep a global stack of menus and that is hellish

#

like straight up TCs menu code cannot handle that

#

and imo its way more effort than its worth

floral blade Jun 28, 2021, 8:48 PM

#

i suppose that makes sense

fickle sparrow Jun 28, 2021, 8:52 PM

#

ideally the menus would have been written with a pushdown statemachine but sadly its hard coded

jolly oriole Jun 28, 2021, 8:55 PM

#

i hate the delicate flower

#

even has text that you can't see in-game

#

yo 56, docs for hooks in front of the delegate or the public static hooktype hookname;?

jolly oriole Jun 28, 2021, 10:04 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/commit/f7a108ab0bdc08f405b70554d1f187e8afd9ee36#diff-9206421e9d448774e3f469ec9112251cc29bd11d66c03cf40a46107813c4363eL1090 why

fickle sparrow Jun 28, 2021, 10:04 PM

#

auto formatter or something

copper nacelle Jun 28, 2021, 10:17 PM

#

my casts pauseshroom

#

and the latter

#

mostly

#

Like you describe the hook itself, maybe an example over the hook

#

and then you explain the args/return over the delegate type

pine girder Jun 28, 2021, 10:59 PM

#

Anyone do know files for gifs soul like focusing (Not for knight) I am looking for ones that does gif on vessel soul(Not mini ones)

#

I seem couldn't find ones

shy cloak Jun 29, 2021, 1:01 AM

#

anyone know if gradow == fifty-six ? I think it is but it's been a long time

vocal spire Jun 29, 2021, 1:01 AM

#

They aren’t the same

shy cloak Jun 29, 2021, 1:01 AM

#

ok thank you 🙂

#

also nice name

#

follow up question: what's gradow's username on github? lol

vocal spire Jun 29, 2021, 1:04 AM

#

Looks like it is Ayugradow

#

At least that’s what’s credited in the ModdingApi readme

shy cloak Jun 29, 2021, 1:04 AM

#

404'd; i think he changed the name but the xml file is a static link

#

I think I found it?

#

thanks ❤️

pine girder Jun 29, 2021, 1:37 AM

#

I want to make custom designs for certain charms, I saw killer whale's skin can do that
So I wonder
What is the file to use? I uses sprites folder from sprite packer usual. Charms aren't in there.
Is it ok to grab bunch of files from #art-discussion pinned? To use for custom skin?

vocal spire Jun 29, 2021, 2:57 AM

#

pine girder I want to make custom designs for certain charms, I saw killer whale's skin can ...

Yes, you can also find the charms in the default skin for CustomKnight iirc

primal latch Jun 29, 2021, 5:54 AM

#

So I got some time on my hand the coming days in the afternoon. What has to be done to the mapi before release?

copper nacelle Jun 29, 2021, 5:54 AM

#

stare at it really hard

primal latch Jun 29, 2021, 5:55 AM

#

Why?

#

How does that contribute?

floral blade Jun 29, 2021, 6:54 AM

#

<#archived-modding-help message>
@light zodiac as far as i understand there's a navigation graph thingy, that tells the UI which element to go to when pressing up / down buttons , without that i think controller/keyboard navigation breaks.

https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/docs/MenuAPI.README.md#navigation-graphs

light zodiac Jun 29, 2021, 6:59 AM

#

how else do you build the menu

floral blade Jun 29, 2021, 7:04 AM

#

one of the previous versions had an auto nav thingy that was removed i think , presumably that did similar stuff

#

CreateAutoMenuNav removed in https://github.com/HollowKnight-Modding/HollowKnight.Modding/commit/e3c3804823e2c4d061e8ccfbc21bae26713b0435

primal latch Jun 29, 2021, 7:34 AM

#

primal latch So I got some time on my hand the coming days in the afternoon. What has to be d...

Still looking for a serious answer

jolly jungle Jun 29, 2021, 7:36 AM

#

Stare at it really hard

#

Oooh I know

#

@primal latch do you think you can start working on documentation

primal latch Jun 29, 2021, 7:37 AM

#

I mean like code

#

I could try documentation

fickle sparrow Jun 29, 2021, 2:41 PM

#

We already have documentation written pauseshroom

#

Theres like nothing we are really waiting on ngl

#

I mean the real thing thats the roadblock is other mods tbh

#

So if you wanna update those to 1.5 that would make things faster

#

or at least just tell the devs to update pauseshroom cause ive been developing my mod on 1.5 for like months now so its totally possible

fickle sparrow Jun 29, 2021, 2:48 PM

#

floral blade <https://discord.com/channels/283467363729408000/462200562620825600/859323130169...

and yes you gotta use the navigation graph

#

it should be pretty simple

#

GridNavGraph is god tier

#

I'm gonna add more customization in the future to them

light zodiac Jun 29, 2021, 2:49 PM

#

fickle sparrow So if you wanna update those to 1.5 that would make things faster

I'm pretty sure there are double digit number of mods that are updated

fickle sparrow Jun 29, 2021, 2:50 PM

#

yeah but Im sure some still aren't and its better to not have a bunch of mods break on the new version plus theres not a whole lot that needs to be done to the modding api

light zodiac Jun 29, 2021, 2:51 PM

#

Could fsm util stuff be added to the API?

fickle sparrow Jun 29, 2021, 2:51 PM

#

wdym

light zodiac Jun 29, 2021, 2:52 PM

#

https://github.com/SFGrenade/SFCore/blob/master/Util/FsmUtil.cs

#

This basically

fickle sparrow Jun 29, 2021, 2:52 PM

#

just use sfcore then imo

light zodiac Jun 29, 2021, 2:53 PM

#

Fair

jolly jungle Jun 29, 2021, 2:53 PM

#

fickle sparrow We already have documentation written <:pauseshroom:828356278651846706>

Can you send a link?

fickle sparrow Jun 29, 2021, 2:54 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/CanvasUtil.cs#L13-L15

#

?

jolly jungle Jun 29, 2021, 2:54 PM

#

Thanks

#

I think

#

The comments, right?

fickle sparrow Jun 29, 2021, 2:54 PM

#

all of our public stuff

#

has doc comments written

jolly jungle Jun 29, 2021, 2:55 PM

#

K, thanks

#

I guess its time to start working on 1.5

fickle sparrow Jun 29, 2021, 2:55 PM

#

so just include the xml

jolly jungle Jun 29, 2021, 2:55 PM

#

thanks

jolly jungle Jun 29, 2021, 2:55 PM

#

fickle sparrow so just include the xml

What xml?

light zodiac Jun 29, 2021, 2:55 PM

#

jolly jungle I guess its time to start working on 1.5

It was like 2 weeks ago imo

jolly jungle Jun 29, 2021, 2:55 PM

#

light zodiac It was like 2 weeks ago imo

No I mean, time for me

floral blade Jun 29, 2021, 2:55 PM

#

fickle sparrow I mean the real thing thats the roadblock is other mods tbh

but does this stop mapi from having an official and modinstaller from having a beta release ?

fickle sparrow Jun 29, 2021, 2:56 PM

#

I mean yeah we could literally release it rn

#

but like theres no real thing in the api itself that we are waiting for

light zodiac Jun 29, 2021, 2:58 PM

#

Is there a way to remove a mod from the top left of main menu?

#

Like how toggling mod does

fickle sparrow Jun 29, 2021, 2:58 PM

#

dont think so plus we kinda need that for speedrun validity

floral blade Jun 29, 2021, 2:58 PM

#

light zodiac Is there a way to remove a mod from the top left of main menu?

dont pause zote

floral blade Jun 29, 2021, 2:59 PM

#

fickle sparrow dont think so plus we kinda need that for speedrun validity

i mean one could just build their own mapi for avoiding this

jolly jungle Jun 29, 2021, 2:59 PM

#

light zodiac Is there a way to remove a mod from the top left of main menu?

I don't know why, but my old buzzbo mod never appeared for me in the topleft

light zodiac Jun 29, 2021, 2:59 PM

#

My reasoning for this is since mods can make custom menus and stuff, the mod menu can have 2 entries for the mod, the toggle switch and the custom menu. It would make sense to add the toggle switch into the custom menu but then the mod still does show up on top left of main menu

jolly jungle Jun 29, 2021, 3:00 PM

#

It did for others though

light zodiac Jun 29, 2021, 3:00 PM

#

It appears if you call initialize?

jolly jungle Jun 29, 2021, 3:00 PM

#

wdym?

fickle sparrow Jun 29, 2021, 3:00 PM

#

so much effort tbh

jolly jungle Jun 29, 2021, 3:00 PM

#

Anyways

#

Suppose I take this and wanna use it https://github.com/HollowKnight-Modding/HollowKnight.Modding

#

How do I do that

fickle sparrow Jun 29, 2021, 3:01 PM

#

what

floral blade Jun 29, 2021, 3:01 PM

#

light zodiac My reasoning for this is since mods can make custom menus and stuff, the mod men...

toggle inside mod menu is a good idea, the mod can itself handle it's lifecycle

jolly jungle Jun 29, 2021, 3:01 PM

#

A wait I'm dumb

fickle sparrow Jun 29, 2021, 3:01 PM

#

#archived-modding-development message

light zodiac Jun 29, 2021, 3:01 PM

#

Go to actions and download the mapi

fickle sparrow Jun 29, 2021, 3:01 PM

#

yeah I was gonna add the toggle inside the mod menu

light zodiac Jun 29, 2021, 3:02 PM

#

fickle sparrow so much effort tbh

Just make the toggle list public

jolly jungle Jun 29, 2021, 3:02 PM

#

fickle sparrow https://discord.com/channels/283467363729408000/327461802311155714/8518435799315...

But what do I do with whatever is in there?

fickle sparrow Jun 29, 2021, 3:02 PM

#

you download it and use that as refs

light zodiac Jun 29, 2021, 3:03 PM

#

Toggle just call unload and add to that dictl/list right?

fickle sparrow Jun 29, 2021, 3:03 PM

#

the what

floral blade Jun 29, 2021, 3:03 PM

#

light zodiac My reasoning for this is since mods can make custom menus and stuff, the mod men...

now this makes sense

fickle sparrow Jun 29, 2021, 3:03 PM

#

ok I have a solution

floral blade Jun 29, 2021, 3:03 PM

#

if you disable a mod using your own toggle it still displays in top left

jolly jungle Jun 29, 2021, 3:03 PM

#

fickle sparrow you download it and use that as refs

What will the actual mods use?

fickle sparrow Jun 29, 2021, 3:03 PM

#

why though

#

oh

#

I see

floral blade Jun 29, 2021, 3:04 PM

#

because one mod having 2 entries in modmenu

fickle sparrow Jun 29, 2021, 3:04 PM

#

also this is what actual mods are gonna use

#

yeah

jolly jungle Jun 29, 2021, 3:04 PM

#

yknow what nevermind, I'll get this on my pc there and then come back when/if I don't unerstand

fickle sparrow Jun 29, 2021, 3:04 PM

#

I'll just pass a param of the action to toggle the mod into the mod menu

#

and have IToggleableMod have a property to tell if it should be on the main mod menu

floral blade Jun 29, 2021, 3:05 PM

#

so the mod can tell mapi to toggle itself on and off ?

fickle sparrow Jun 29, 2021, 3:05 PM

#

yes

floral blade Jun 29, 2021, 3:05 PM

#

might want it to be only off

fickle sparrow Jun 29, 2021, 3:05 PM

#

it still needs to be IToggleableMod

light zodiac Jun 29, 2021, 3:05 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/f7a108ab0bdc08f405b70554d1f187e8afd9ee36/Assembly-CSharp/ModListMenu.cs#L182

fickle sparrow Jun 29, 2021, 3:05 PM

#

yeah and

light zodiac Jun 29, 2021, 3:06 PM

#

It adds to the dict and calls unload

floral blade Jun 29, 2021, 3:06 PM

#

fickle sparrow it still needs to be IToggleableMod

then there needs to be something to tell mapi if the mod does not want to show up with the toggle in mods menu directly

fickle sparrow Jun 29, 2021, 3:06 PM

#

yeah

#

thats what I said

#

I'll add something to IToggleableMod

#

or actually

#

something in IMenuMod

#

pauseshroom

#

this is going to break all mods

#

that use menu stuff

jolly oriole Jun 29, 2021, 3:09 PM

#

I read something of "use sfcore" me happy widepeepoHappy

floral blade Jun 29, 2021, 3:12 PM

#

~~but what if i as a bad mod dev tell mapi i will show a toggle so it doesn't need to but i dont~~ zote ... through clever deduction skill i have concluded that it would then not need to implement the interface at all

floral blade Jun 29, 2021, 3:13 PM

#

fickle sparrow this is going to break all mods

break fast move things

fickle sparrow Jun 29, 2021, 3:14 PM

#

so true

#

whats a little breaking changes

floral blade Jun 29, 2021, 3:19 PM

#

would the modlog display count as a modmenu ?

#

it's info that shows up and can be hidden, but is also an overlay

fickle sparrow Jun 29, 2021, 3:20 PM

#

idk

#

not really

#

like things that should be overlayed while the game is playing are a bit out of scope

floral blade Jun 29, 2021, 3:21 PM

#

agreed, no real way to make them interact-able via controller either

#

because it's busy controlling player

fickle sparrow Jun 29, 2021, 3:21 PM

#

mhm

#

thats why I don't wanna really touch it

#

debug is already not able to really be used without a mouse

floral blade Jun 29, 2021, 3:22 PM

#

oh Mul was planning to port debug to modmenu i think

light zodiac Jun 29, 2021, 3:31 PM

#

I have done a grand total of 2 buttons from the top menu till now

floral blade Jun 29, 2021, 3:33 PM

#

a mod that after player interacts with a certain ingame object , unloads itself and yeets it's own dll and settings file

light zodiac Jun 29, 2021, 3:33 PM

#

You can't yeet you own dll unfortunately

floral blade Jun 29, 2021, 3:35 PM

#

why not ?

light zodiac Jun 29, 2021, 3:35 PM

#

Cuz it's currently loaded into the game

#

Unless there's something I'm missing

floral blade Jun 29, 2021, 3:36 PM

#

i have deleted mods while the game was running before

fickle sparrow Jun 29, 2021, 3:52 PM

#

can someone test out the new menu stuff for me

📎 Assembly-CSharp.dll

#

#

floral blade Jun 29, 2021, 3:54 PM

#

with IMenuMod mapi adds the toggle?

fickle sparrow Jun 29, 2021, 3:54 PM

#

nope

#

you have to add it yourself

#

oh

#

yeah you still have to put it in the list

#

but the MenuEntry is preconstructed

floral blade Jun 29, 2021, 3:55 PM

#

makes sense

#

at work rn , can test after

jolly oriole Jun 29, 2021, 4:04 PM

#

if that works, can we just update the modinstaller to work with the amalgamation that is multi patch modlinks or the new modlinks to have the people be satisfied and not ask 36 times per hour in mod help?

fickle sparrow Jun 29, 2021, 4:05 PM

#

guys why is the mod installer not working??? No i haven’t checked the pins

rough pulsar Jun 29, 2021, 4:07 PM

#

guys it give me it requre most stable version to run!!!!!! what is thismean,

deep wave Jun 29, 2021, 4:26 PM

#

1.5 is not stable FeelsInvertedMan

fickle sparrow Jun 29, 2021, 4:29 PM

#

so fucking true

floral blade Jun 29, 2021, 4:36 PM

#

btws Yuri , any plans on adding a textbox to modmenu ? not sure how it would look with vanilla styles or if it's even a common requirement.

fickle sparrow Jun 29, 2021, 4:56 PM

#

ah you see

#

thats hard

#

I can't use unity's textbox

#

so I'd legit have to code one by hand

#

which I will get around to at some point

#

in fact

proven plover Jun 29, 2021, 4:58 PM

#

When i try to follow the tutorial on the modding api for creating an enemy, the code always errors. Does anyone know why?
Also, i'm using Visual Studio if that helps

light zodiac Jun 29, 2021, 4:59 PM

#

What is the code?

#

Using VS shouldn't affect anything

proven plover Jun 29, 2021, 4:59 PM

#

Here is the code from the website:

#

https://gist.github.com/SalehAce1/0448a531e9d179dc5ef8910ccfebdc2b

Gist

ArmorCtrl.cs

GitHub Gist: instantly share code, notes, and snippets.

#

And the tutorial: https://radiance.host/apidocs/Assets.html

radiant basin Jun 29, 2021, 5:25 PM

#

how would i go about making a mod that replaces sprites for a boss, specifically ogrim?

ornate rivet Jun 29, 2021, 5:26 PM

#

proven plover Here is the code from the website:

it would help to say what the error is

floral blade Jun 29, 2021, 5:58 PM

#

fickle sparrow I can't use unity's textbox

why not ? is it not theme-able ?

light zodiac Jun 29, 2021, 6:01 PM

#

proven plover https://gist.github.com/SalehAce1/0448a531e9d179dc5ef8910ccfebdc2b

Isn't this saleh's code?

#

What code did you use

vocal spire Jun 29, 2021, 6:04 PM

#

Prob missing assetbundle

light zodiac Jun 29, 2021, 6:05 PM

#

Or a reference

vocal spire Jun 29, 2021, 6:06 PM

#

radiant basin how would i go about making a mod that replaces sprites for a boss, specifically...

~~in the case you mean a boss under that name, pale court hasn’t released yet.~~
If you mean white defender or dung defender, either wait for CustomKnight + to release or look at the code for a mod that replaces the sprites for a boss

floral blade Jun 29, 2021, 6:07 PM

#

radiant basin how would i go about making a mod that replaces sprites for a boss, specifically...

simplest way would be to preload ogrim, and replace their spritesheet on game load itself with a sprite in the embedded resource , i can share the code for washer knights if that helps

radiant basin Jun 29, 2021, 6:08 PM

#

floral blade simplest way would be to preload ogrim, and replace their spritesheet on game lo...

yeah the washer knights code would be helpful thanks

radiant basin Jun 29, 2021, 6:09 PM

#

vocal spire ~~in the case you mean a boss under that name, pale court hasn’t released yet.~~...

yeah i meant dung defender

floral blade Jun 29, 2021, 6:12 PM

#

https://github.com/PrashantMohta/washerknights there you go

radiant basin Jun 29, 2021, 6:13 PM

#

thanks!

fickle sparrow Jun 29, 2021, 6:13 PM

#

floral blade why not ? is it not theme-able ?

all of the controls are wrong

#

like the selection and all of that stuff does not act correctly

#

I tried but it didn't work

floral blade Jun 29, 2021, 6:14 PM

#

you mean the navigation graph bit ?

fickle sparrow Jun 29, 2021, 6:14 PM

#

like the navigation shit itself

#

yeah all of the keyboard and controller controls

#

just died

floral blade Jun 29, 2021, 6:15 PM

#

ah could you not just wrap it in a wrapper that uses mapi navigation stuff but inside is unity input ?

fickle sparrow Jun 29, 2021, 6:15 PM

#

well I tried that as well

#

but its just bad

#

so much had to be changed that it was just like

#

why bother

#

like legit its just easier to write it myself xd

floral blade Jun 29, 2021, 6:17 PM

#

personally i think it would be okay if we could not navigate to it in v1
as long as it emulates the feel of HK's UI since without it all mods will end up using unity's inputbox anyways

#

but yeah if it is too annoying to work with might be simpler writing your own setup

fickle sparrow Jun 29, 2021, 6:18 PM

#

I mean heres the thing right

#

if I can't make it feel like the vanilla menu

#

I'd rather not advertise it to be the thing to use

floral blade Jun 29, 2021, 6:19 PM

#

yes

#

that makes sense

#

the only situation where i would consider that better than mods using unity's input is if mapi updates could make it more seamless without mod devs requiring to updating

light zodiac Jun 29, 2021, 6:21 PM

#

fickle sparrow

when i use this do i have to place the horizontal config myself?

fickle sparrow Jun 29, 2021, 6:21 PM

#

yes

#

I didn't want to auto place anything cause that would be bad

candid sapphire Jun 29, 2021, 6:31 PM

#

is there an in depth guide for using weavercore?

light zodiac Jun 29, 2021, 6:35 PM

#

i dont think other mods can use weaver core as a dependancy

#

I'm wrong?

merry lotus Jun 29, 2021, 6:37 PM

#

Other mods can use WeaverCore

#

IIRC it just doesn't have good doumentation for others to read right now? And it currently only works in the Main Menu.

candid sapphire Jun 29, 2021, 6:38 PM

#

light zodiac i dont think other mods can use weaver core as a dependancy

I also wondered about that

candid sapphire Jun 29, 2021, 6:39 PM

#

merry lotus IIRC it just doesn't have good doumentation for others to read right now? And it...

really?

#

I thought a lot of mods used it

#

like corrupted kin... and a couple others

merry lotus Jun 29, 2021, 6:41 PM

#

I asked Nick(? I think Nick, but I'm very forgetful with people that aren't super active) about it a few months ago.. They mentioned that one of the issues with it right now, is just that there's not very much user-friendliness in the way of using it.
Currently, I think that all of the mods that use it, are made by the person that made it, so no docs needed gorbbrain

candid sapphire Jun 29, 2021, 6:47 PM

#

I see

#

is there something like it with better documentation?

light zodiac Jun 29, 2021, 6:47 PM

#

it?

candid sapphire Jun 29, 2021, 6:48 PM

#

weavercore

jolly oriole Jun 29, 2021, 6:56 PM

#

candid sapphire is there an in depth guide for using weavercore?

@charred topaz

light zodiac Jun 29, 2021, 6:57 PM

#

fickle sparrow can someone test out the new menu stuff for me

did i do something wrong, the toggle option still shows up

https://github.com/TheMulhima/Easier-Pantheon-Practice/blob/master/Source Code/Init.cs

fickle sparrow Jun 29, 2021, 7:02 PM

#

OH

rough pulsar Jun 29, 2021, 7:02 PM

#

~~Source code is always a documentation~~ fleacrying

fickle sparrow Jun 29, 2021, 7:02 PM

#

YEAH I KNOW WHY

#

I didn't need to look at my code btw

#

I just remember coding the bug ax1uWide3

#

wait nvm

#

pauseshroom this is correct

rough pulsar Jun 29, 2021, 7:02 PM

#

you code a bug???? fleacrying

jolly oriole Jun 29, 2021, 7:02 PM

#

tc coded quite a few

fickle sparrow Jun 29, 2021, 7:03 PM

#

yeah I fucked up nvm

jolly oriole Jun 29, 2021, 7:03 PM

#

so coding a single one isn't that big of a deal

fickle sparrow Jun 29, 2021, 7:03 PM

#

rogue not

rough pulsar Jun 29, 2021, 7:03 PM

#

yeah by coding what you didn't intend to do feelspkman

#

oh wait i read the sentence wrong

fickle sparrow Jun 29, 2021, 7:03 PM

#

uhhhh

rough pulsar Jun 29, 2021, 7:03 PM

#

don't mind

fickle sparrow Jun 29, 2021, 7:04 PM

#

ok fixed it lol

#

📎 Assembly-CSharp.dll

radiant basin Jun 29, 2021, 7:04 PM

#

@floral blade sorry im very new to c# and vs so im a bit confused, theres errors in the washer knights project so i cant build to a dll, did i load it up wrong?

light zodiac Jun 29, 2021, 7:04 PM

#

which references did you add

#

cuz dandy's install is going to be different than yours

floral blade Jun 29, 2021, 7:05 PM

#

radiant basin <@!731231925599076432> sorry im very new to c# and vs so im a bit confused, ther...

probably missing all references to mapi & unity dlls

radiant basin Jun 29, 2021, 7:06 PM

#

how do i add those in?

floral blade Jun 29, 2021, 7:06 PM

#

i add them manually, but i know there's supposed to be a visual studio trick to add them easier i just dont know it

light zodiac Jun 29, 2021, 7:07 PM

#

i add 1 and copy the path manually in the csprof for the rest

fickle sparrow Jun 29, 2021, 7:07 PM

#

I am begging everyone to use this

#

custom property is so nice tbh

charred topaz Jun 29, 2021, 7:08 PM

#

candid sapphire is there an in depth guide for using weavercore?

There isn't much documentation on the mod right now since it's still pretty messy and several areas of the mod are subject to major changes. However, one area that I have documented is the Settings Menu and how to create panels https://github.com/nickc01/WeaverCore/blob/master/WeaverCore/Settings/Panel.cs

You can find an example of how it's used in Corrupted Kin : https://github.com/nickc01/Corrupted-Kin/blob/master/Assets/MOD FILES/Scripts/CorruptedKinSettings.cs

Added documentation and guides for my mod is something I really want to get to. I recently finished reworking my crappy compilation system and there's a few other things on my to-do list before i get to it.

jolly oriole Jun 29, 2021, 7:09 PM

#

fickle sparrow I am begging everyone to use this

ew, would require me to have a weird hollowknightmanaged folder somewhere instead of linking to the gamefiles i do update regularly

floral blade Jun 29, 2021, 7:09 PM

#

@radiant basin you'd want to set the path to these .dll files correctly

Screenshot_2021-06-30_at_12.38.49_AM.png

fickle sparrow Jun 29, 2021, 7:09 PM

#

wtf

#

you just

#

link the actual managed folder

#

or have some refs

copper nacelle Jun 29, 2021, 7:09 PM

#

you just change the property to your managed folder location I don't see the problem

fickle sparrow Jun 29, 2021, 7:09 PM

#

yeah

candid sapphire Jun 29, 2021, 7:10 PM

#

charred topaz There isn't much documentation on the mod right now since it's still pretty mess...

thank you

fickle sparrow Jun 29, 2021, 7:10 PM

#

you can change HollowKnightRefs its so clean

jolly oriole Jun 29, 2021, 7:10 PM

#

... i meant that as in: contributing to other mods' projects requires me to have the hollowknightrefs of the one i'm contributing to

fickle sparrow Jun 29, 2021, 7:10 PM

#

well yes that happens with all of them

#

theres no way around that because people have different file structures

#

its better than uploading all the ref dlls in the repo

jolly oriole Jun 29, 2021, 7:12 PM

#

fickle sparrow I am begging everyone to use this

but this actually works on its own? or does this require something else reffed or something

fickle sparrow Jun 29, 2021, 7:12 PM

#

what

#

you can change the content of the HollowKnightRefs tag to literally anything

#

instead of having to change each file path

jolly oriole Jun 29, 2021, 7:13 PM

#

> i can copy paste that into my .csproj (that's literally it)
> i need some extension or something
which one

copper nacelle Jun 29, 2021, 7:13 PM

#

what

fickle sparrow Jun 29, 2021, 7:13 PM

#

first one

jolly oriole Jun 29, 2021, 7:13 PM

#

ok

fickle sparrow Jun 29, 2021, 7:13 PM

#

theres no extension

#

its just a property

#

in the csproj files

copper nacelle Jun 29, 2021, 7:13 PM

#

can you set properties in .csproj.user

fickle sparrow Jun 29, 2021, 7:13 PM

#

uhhhhhhh

#

maybe

copper nacelle Jun 29, 2021, 7:13 PM

#

or whatever the fuck it's called

fickle sparrow Jun 29, 2021, 7:13 PM

#

I think?

#

that would be super ideal

copper nacelle Jun 29, 2021, 7:14 PM

#

I remember I had a different file path so I just added the ref twice to someone's project with a condition for the file existing

#

Ideal

jolly oriole Jun 29, 2021, 7:14 PM

#

time to update some mods hotdogHotdog

fickle sparrow Jun 29, 2021, 7:14 PM

#

I can find 0 documentation on csproj.user

jolly oriole Jun 29, 2021, 7:15 PM

#

i should write a python script or something to automate that for me

#

i don't want to do this by hand

floral blade Jun 29, 2021, 7:16 PM

#

meanwhile me : make a symlink in ./vanilla in each mod and actually point to directory with refs & never commit the symlink

light zodiac Jun 29, 2021, 7:16 PM

#

fickle sparrow

it works grubhappy

fickle sparrow Jun 29, 2021, 7:16 PM

#

uh yeah I have a symlink directory in my workspace

light zodiac Jun 29, 2021, 7:16 PM

#

but toggling it off doesnt yeet it from top left menu

fickle sparrow Jun 29, 2021, 7:16 PM

#

#

mul did you exit the menu

light zodiac Jun 29, 2021, 7:17 PM

#

wdym?

fickle sparrow Jun 29, 2021, 7:17 PM

#

like

floral blade Jun 29, 2021, 7:17 PM

#

apply ?

fickle sparrow Jun 29, 2021, 7:17 PM

#

it will only turn off the mod once you go out of the menu

#

for performance reasons

jolly oriole Jun 29, 2021, 7:17 PM

#

fickle sparrow I am begging everyone to use this

is that part of a csproj file? mine look vastly different

light zodiac Jun 29, 2021, 7:17 PM

#

i did it in main menu and opened a save to check wheter language.get hook wasnt hook

copper nacelle Jun 29, 2021, 7:17 PM

#

stop using ugly csproj

fickle sparrow Jun 29, 2021, 7:17 PM

#

true

copper nacelle Jun 29, 2021, 7:17 PM

#

all my homies hate old csproj

fickle sparrow Jun 29, 2021, 7:17 PM

#

this is the god csproj

#

they call me a homie

copper nacelle Jun 29, 2021, 7:18 PM

#

less goo

fickle sparrow Jun 29, 2021, 7:18 PM

#

sidepeepoHappy

jolly oriole Jun 29, 2021, 7:18 PM

#

idk, i use whatever vs generated for me

light zodiac Jun 29, 2021, 7:18 PM

#

fickle sparrow it will only turn off the mod once you go out of the menu

but I'm using the one i made in my mod

radiant basin Jun 29, 2021, 7:18 PM

#

floral blade <@!316609893350244353> you'd want to set the path to these .dll files correctly

how would i do this?

jolly oriole Jun 29, 2021, 7:18 PM

#

jolly oriole idk, i use whatever vs generated for me

which inclused this funny

copper nacelle Jun 29, 2021, 7:19 PM

#

nooooooooooooooo

fickle sparrow Jun 29, 2021, 7:19 PM

#

ok multiple things mul

copper nacelle Jun 29, 2021, 7:19 PM

#

I hate that postbuild

#

I rewrote it to be less shit so long ago

fickle sparrow Jun 29, 2021, 7:19 PM

#

so like

#

https://github.com/TheMulhima/Easier-Pantheon-Practice/blob/37328f2244fa4efa12a2def7309aab019f977494/Source Code/Init.cs#L71

GitHub

TheMulhima/Easier-Pantheon-Practice

A mod that makes practicing in HoG easier. It adds many features some of them include, allowing you to press a key to reload bosses much quicker, matcheing the health and damage of bosses with P5, ...

jolly oriole Jun 29, 2021, 7:19 PM

#

copper nacelle I rewrote it to be less shit so long ago

do you think i copied the project structure from anywhere

fickle sparrow Jun 29, 2021, 7:19 PM

#

all of the CancelActions need to run

floral blade Jun 29, 2021, 7:20 PM

#

radiant basin how would i do this?

the files would be all in your managed directory if you have modding api installed, just add their paths here or create them in the same path structure as the file has right now , where . = current directory

fickle sparrow Jun 29, 2021, 7:20 PM

#

ModToggleDelegates.ApplyChange or w/e

#

you also need to use SetModEnabled and GetModEnabled for the toggle option

#

otherwise it wont work

light zodiac Jun 29, 2021, 7:20 PM

#

fickle sparrow `ModToggleDelegates.ApplyChange` or w/e

I'm not following

fickle sparrow Jun 29, 2021, 7:20 PM

#

I will update my timer mod

#

as an example

jolly oriole Jun 29, 2021, 7:22 PM

#

jolly oriole do you think i copied the project structure from anywhere

but i will not give this up 😤

charred topaz Jun 29, 2021, 7:23 PM

#

btw, my mods are pretty much all set for release whenever the ModInstaller is up with the latest MAPI

copper nacelle Jun 29, 2021, 7:23 PM

#

did you check against the second modhooks redo meme

jolly oriole Jun 29, 2021, 7:23 PM

#

i have sfcore ready (and possibly tot? idk)

copper nacelle Jun 29, 2021, 7:23 PM

#

🥴

light zodiac Jun 29, 2021, 7:24 PM

#

charred topaz btw, my mods are pretty much all set for release whenever the ModInstaller is up...

you could always send them here for someone to use

charred topaz Jun 29, 2021, 7:24 PM

#

You mean the commit where the null and out parameters were removed from some of the hooks, yes

charred topaz Jun 29, 2021, 7:25 PM

#

light zodiac you could always send them here for someone to use

I could, but I was also looking to make an announcement video on it too since IKG's got a new feature

floral blade Jun 29, 2021, 7:25 PM

#

@fickle sparrow even if a mod does not implement IToggleableMod it still gotta handle ModToggleDelegates in GetMenuScreen ?

light zodiac Jun 29, 2021, 7:26 PM

#

you can leave it how it is

#

its a ModToggleDelegates? so you can ignore it

jolly oriole Jun 29, 2021, 7:26 PM

#

jolly oriole but i will not give this up 😤

wait a sec, i just realized that the "god" csproj still has around 200 lines of references

fickle sparrow Jun 29, 2021, 7:26 PM

#

modtoggledelegates will be null if its not toggleable

#

you don't have to do anything with it if you don't want to

floral blade Jun 29, 2021, 7:27 PM

#

so just change the function signature

fickle sparrow Jun 29, 2021, 7:27 PM

#

yes

floral blade Jun 29, 2021, 7:27 PM

#

makes sense

fickle sparrow Jun 29, 2021, 7:27 PM

#

there was no better option

#

😔

floral blade Jun 29, 2021, 7:27 PM

#

now to make custom knight toggleable again

fickle sparrow Jun 29, 2021, 7:27 PM

#

no default methods in interfaces sadly

floral blade Jun 29, 2021, 7:28 PM

#

youd probably need a third interface magic to make it work i guess

fickle sparrow Jun 29, 2021, 7:29 PM

#

yeah thats just bad

#

too much bloat pauseshroom

floral blade Jun 29, 2021, 7:29 PM

#

wait is this a typo ?

Screenshot_2021-06-30_at_12.59.28_AM.png

fickle sparrow Jun 29, 2021, 7:29 PM

#

wtf

#

it is

radiant basin Jun 29, 2021, 7:29 PM

#

um

fickle sparrow Jun 29, 2021, 7:29 PM

#

not my typo though

light zodiac Jun 29, 2021, 7:30 PM

#

radiant basin um

this means its already there and you dont need to add it again

fickle sparrow Jun 29, 2021, 7:30 PM

#

it should have an e cmm

#

I'll fix the docs though

copper nacelle Jun 29, 2021, 7:31 PM

#

break the interface easy

floral blade Jun 29, 2021, 7:31 PM

#

radiant basin um

you only need to add the reference for the ones with a path in the screenshot i sent

copper nacelle Jun 29, 2021, 7:32 PM

#

Wiktionary has both

#

Ruined

fickle sparrow Jun 29, 2021, 7:32 PM

#

PepeHands

#

ok my code be working

#

oh I should add the version description

#

that would be based and estrogenpilled

#

as the cool kids say

#

shit

#

buttons can't have descriptions

#

🥴

light zodiac Jun 29, 2021, 7:36 PM

#

just add text below it

fickle sparrow Jun 29, 2021, 7:36 PM

#

idk how vanilla would do it

#

pauseshroom

light zodiac Jun 29, 2021, 7:36 PM

#

easy descriptions

fickle sparrow Jun 29, 2021, 7:37 PM

#

yeah but I need to add it to the menu api

#

SAVED

jolly oriole Jun 29, 2021, 7:37 PM

#

why is menubutton red

#

sorry

#

i meant menuButton

fickle sparrow Jun 29, 2021, 7:38 PM

#

cause

#

idk

#

I assume I center the description on a button

#

fuck you all I'm slightly breaking the API

#

ok this should work

radiant basin Jun 29, 2021, 7:44 PM

#

i finally got it to make the dll and it works, thanks!
now the hard part

fickle sparrow Jun 29, 2021, 7:45 PM

#

fickle sparrow ok this should work

damn I was so stupid 3 minutes ago

floral blade Jun 29, 2021, 7:50 PM

#

can i do a ModToggleDelegates() ?

fickle sparrow Jun 29, 2021, 7:50 PM

#

I mean

#

its not a delegate

#

its a struct

floral blade Jun 29, 2021, 7:51 PM

#

i don't really understand what i need to do with it tbh

fickle sparrow Jun 29, 2021, 7:52 PM

#

im gonna upload the code

jolly oriole Jun 29, 2021, 7:52 PM

#

i hate how vs does this

fickle sparrow Jun 29, 2021, 7:53 PM

#

pauseshroom

copper nacelle Jun 29, 2021, 7:53 PM

#

pauseshroom

fickle sparrow Jun 29, 2021, 7:53 PM

#

https://github.com/Yurihaia/HollowKnight-Timer/blob/timer-1.5/src/HKTimer.cs#L70

jolly oriole Jun 29, 2021, 7:53 PM

#

can anybody write me a python script to make this good (so combing all itemgroups in one and redo the references in the new way)?

radiant basin Jun 29, 2021, 7:56 PM

#

what is this and how would i find dung defenders version of it?

light zodiac Jun 29, 2021, 7:59 PM

#

check pins for gameobject dumb

floral blade Jun 29, 2021, 8:00 PM

#

it's the scene + object path for a watcher knight

radiant basin Jun 29, 2021, 8:00 PM

#

ah ok

floral blade Jun 29, 2021, 8:00 PM

#

in this <#archived-modding-development message>

radiant basin Jun 29, 2021, 8:00 PM

#

thank you!

floral blade Jun 29, 2021, 8:00 PM

#

you just look for whatever dung beetle person is called

#

it works ! but weird that the menu remains

fickle sparrow Jun 29, 2021, 8:02 PM

#

which menu

light zodiac Jun 29, 2021, 8:02 PM

#

how else are you going to renable it

fickle sparrow Jun 29, 2021, 8:02 PM

#

so true

light zodiac Jun 29, 2021, 8:02 PM

#

grubthink

floral blade Jun 29, 2021, 8:02 PM

#

wait no i am dumb

fickle sparrow Jun 29, 2021, 8:02 PM

#

lmao

floral blade Jun 29, 2021, 8:02 PM

#

this is good

#

lol

fickle sparrow Jun 29, 2021, 8:03 PM

#

yeah I need the menus to stay for many reasons

floral blade Jun 29, 2021, 8:03 PM

#

hitting apply does give me a spinny cursor though

#

did i do something incorrectly ?

fickle sparrow Jun 29, 2021, 8:05 PM

#

lemme see your code

floral blade Jun 29, 2021, 8:05 PM

#

pushing

radiant basin Jun 29, 2021, 8:07 PM

#

would this be right?

floral blade Jun 29, 2021, 8:08 PM

#

fickle sparrow lemme see your code

https://github.com/PrashantMohta/HollowKnight.CustomKnight/pull/7/commits/8dc8db1b782850d18d32551f1fc631c13847cea9

light zodiac Jun 29, 2021, 8:08 PM

#

wouldnt it be better to check the current scene and then find the boss and change its sprite?

radiant basin Jun 29, 2021, 8:09 PM

#

idk im just editing dandys washer knights,,

floral blade Jun 29, 2021, 8:09 PM

#

radiant basin would this be right?

i'm not sure you need the corpse there

#

unless the corpse uses the same sprite then it could work

light zodiac Jun 29, 2021, 8:10 PM

#

yuri i regret asking you for giving mod makers the option to toggle mods

https://github.com/PrashantMohta/HollowKnight.CustomKnight/blob/8dc8db1b782850d18d32551f1fc631c13847cea9/CustomKnight/CustomKnight.cs#L116

fickle sparrow Jun 29, 2021, 8:11 PM

#

what do you mean you got a spinny cursor though

#

can I have error logs or something

floral blade Jun 29, 2021, 8:12 PM

#

there wasn't much of a log in modlog , it may be CK doing CK things but it looked like the game froze

fickle sparrow Jun 29, 2021, 8:13 PM

#

you need to activate ModToggleDelegates.ApplyChange in the cancel action or like

#

a submit button

#

not when you create the menu

#

floral blade Jun 29, 2021, 8:14 PM

#

floral blade Jun 29, 2021, 8:14 PM

#

fickle sparrow not when you create the menu

i call it in my apply() function

fickle sparrow Jun 29, 2021, 8:15 PM

#

I feel like this is a problem with your unload code then

floral blade Jun 29, 2021, 8:15 PM

#

light zodiac yuri i regret asking you for giving mod makers the option to toggle mods https:...

its literally a Log lol

fickle sparrow Jun 29, 2021, 8:16 PM

#

can I see the Player.log file

light zodiac Jun 29, 2021, 8:18 PM

#

floral blade its literally a Log lol

the function is to unload stuff not make logs

floral blade Jun 29, 2021, 8:18 PM

#

📎 player.log