#archived-modding-development | Hollow Knight | Page 522

vocal spire Jun 19, 2021, 11:51 PM

#

But discord rpc for example iirc needs the file to be there before the game starts

#

Also that can already be done with globalsettings and the constructor

floral blade Jun 19, 2021, 11:54 PM

#

vocal spire Also that can already be done with globalsettings and the constructor

how does the mod know it's been reinstalled / updated ?

jolly oriole Jun 19, 2021, 11:54 PM

#

check if file exists

copper nacelle Jun 19, 2021, 11:54 PM

#

GetVersion

floral blade Jun 19, 2021, 11:54 PM

#

vocal spire But discord rpc for example iirc needs the file to be there before the game star...

it would just be usable after a restart ?

#

the player might re-install the same version of the mod

jolly oriole Jun 19, 2021, 11:56 PM

#

floral blade the player might re-install the same version of the mod

how to know if discordrpc needs to be installed:

check current appdomain if discordrpc is part of loaded modules

floral blade Jun 19, 2021, 11:56 PM

#

yeah that makes sense

#

a file check would work as well i assume

#

if it does not then add the file and then indicate to the player that we need a restart to work

jolly oriole Jun 19, 2021, 11:58 PM

#

is a restart needed though?

#

can't one just Assembly.Load or AppDomain.currentAppDomain.Load?

floral blade Jun 19, 2021, 11:58 PM

#

basing that on what redfrog said, idrk how drpc works

vocal spire Jun 19, 2021, 11:59 PM

#

Those had problems iirc since it’s a com assembly or something

jolly oriole Jun 19, 2021, 11:59 PM

#

ok, then assembly load prob doesn't work, but appdomain load is made for that according to ms docs

jolly oriole Jun 20, 2021, 12:41 AM

#

everything should be set up for modlinks to be added now, but personally i'll wait with updating my mods until TC releases the next 1.5 patch

floral blade Jun 20, 2021, 12:42 AM

#

there's another ?

#

pikaknight

jolly oriole Jun 20, 2021, 12:43 AM

#

the beta branch has 1.5.71.numbers, stable is at 1.5.68.11808

floral blade Jun 20, 2021, 12:44 AM

#

oh 😮

jolly oriole Jun 20, 2021, 12:44 AM

#

narts can't be nutted on anymore sadly

#

even though the new/old damage calc is still in the fsm, the old/new one is again used

floral blade Jun 20, 2021, 1:12 AM

#

can we change the value of a variable at a certain FSM event ?

#

so that every time it happens the new value is used instead of the old one

#

this is not a single FSM though, like all NPCs FSMs have this thingy

#

would this second one work to replace all SetScales ?

floral blade Jun 20, 2021, 2:53 AM

#

it worked!

sacred prism Jun 20, 2021, 2:58 AM

#

good job

jolly jungle Jun 20, 2021, 4:10 AM

#

floral blade can we change the value of a variable at a certain FSM event ?

If I understand what you meant then yeah, I do it all the time

#

That's basically the only thing I do other than insert methods ._.

upper hemlock Jun 20, 2021, 5:22 AM

#

ik it takes a long time to make skins, but has anyone considered making an actual knight (medieval) skin? I think that it'd be dope, if possible.

#

also, could someone link a good tool for skin creating

#

I dont know what to use

primal latch Jun 20, 2021, 5:37 AM

#

Fun fact: they changed the sprite of the hollow knight in 1.5

marble hollow Jun 20, 2021, 5:37 AM

#

upper hemlock ik it takes a long time to make skins, but has anyone considered making an actua...

i would be willing to if someone helps me ngl

primal latch Jun 20, 2021, 5:37 AM

#

I noticed that it was all messed up so Frog ripped it and confirmed it

marble hollow Jun 20, 2021, 5:37 AM

#

making a skin alone is difficult

nimble lake Jun 20, 2021, 7:12 AM

#

jolly oriole the beta branch has 1.5.71.numbers, stable is at 1.5.68.11808

wait there’s a new beta?

#

oh it was out for 3 days already lol

#

did they fix nail damage like they claim?

jolly oriole Jun 20, 2021, 10:50 AM

#

jolly oriole even though the new/old damage calc is still in the fsm, the old/new one is agai...

Yes

jolly oriole Jun 20, 2021, 11:19 AM

#

nice

jolly jungle Jun 20, 2021, 1:03 PM

#

primal latch I noticed that it was all messed up so Frog ripped it and confirmed it

Can you send frog's rip?

primal latch Jun 20, 2021, 1:13 PM

#

jolly jungle Can you send frog's rip?

https://drive.google.com/file/d/1hBzKQ5haj2eXAguUXKl7VcF54KhQRfjf/view?usp=sharing

Google Docs

Hollow Knight Boss Cln_full_0.png

jolly jungle Jun 20, 2021, 1:19 PM

#

Thanks

#

How long till we have a full folder of all the sprites?

#

Most of them didn't change, right?

#

And the rest just need to be ripped like this one

#

Hm

vocal spire Jun 20, 2021, 2:53 PM

#

How would I get hk’s fonts in the unity editor?

dark wigeon Jun 20, 2021, 2:53 PM

#

assetstudio

vocal spire Jun 20, 2021, 2:53 PM

#

Thanks

jolly oriole Jun 20, 2021, 2:55 PM

#

or just find perpetua/noto serif CJK SC online

mellow shore Jun 20, 2021, 3:38 PM

#

hey, im working on a custom knight skin and there's some inconsistencies in the run animation. namely, i think it takes one frame from another animation and puts it in the middle of the run animation. this means its using a different sprite for the head and it looks really bad on my end. anyone know what animation it pulls from? 😦

jolly oriole Jun 20, 2021, 3:52 PM

#

#modding-discussion message

rich stone Jun 21, 2021, 12:59 AM

#

anything that might have to do with inbetweens like running start and a little bounce when it hits the ground could do it

#

if these are not the things there might be something wrong with the file names

jolly oriole Jun 21, 2021, 10:11 AM

#

i wonder when tc will put their beta branch release onto the stable branch

floral blade Jun 21, 2021, 10:19 AM

#

you want to start updating your mods ?

#

mastersmirk

primal latch Jun 21, 2021, 10:26 AM

#

jolly oriole i wonder when tc will put their beta branch release onto the stable branch

Let’s first make the mapi for this version public

vocal spire Jun 21, 2021, 1:14 PM

#

Well I just realized I probably need to rewrite how I get sprites for gameobjects for CustomKnight +

primal latch Jun 21, 2021, 1:17 PM

#

Why?

jolly oriole Jun 21, 2021, 2:18 PM

#

primal latch Let’s first make the mapi for this version public

you can already get it, so by definition it's public

light zodiac Jun 21, 2021, 2:23 PM

#

It's even on the release page now

vocal spire Jun 21, 2021, 2:23 PM

#

Nice

light zodiac Jun 21, 2021, 2:24 PM

#

As a pre release tho but still

primal latch Jun 21, 2021, 2:46 PM

#

I meant on the mod installer

jolly oriole Jun 21, 2021, 2:54 PM

#

update the modinstaller to have it work with https://github.com/HollowKnight-Modding/HollowKnight.ModLinks and you're good to go

primal latch Jun 21, 2021, 2:56 PM

#

No multi-patch support 😩

jolly oriole Jun 21, 2021, 2:57 PM

#

1432 sucks

#

but you can fork it / make someting similar for other patches, if you make a modinstaller that supports those additional repos

primal latch Jun 21, 2021, 2:58 PM

#

Nah

#

I’d say: release the api. Get rid of the daily 100+ questions of “hewp 1.5 is bwoken”

cedar hemlock Jun 21, 2021, 3:16 PM

#

then 1.5 is still broken as only like 5 mods are updated

primal latch Jun 21, 2021, 3:17 PM

#

True

cedar hemlock Jun 21, 2021, 3:17 PM

#

so, they'll still say "hewp 1.5 is bwoken" lol

primal latch Jun 21, 2021, 3:17 PM

#

~~the reason why we need to be able to specify a version~~

#

Just wondering: how are you guys planning to roll out 1.5? Seeing as a lot of mods aren’t on 1.5 and a lot of mods probably won’t be updated until the 1.5 api releases

cedar hemlock Jun 21, 2021, 3:22 PM

#

make a warning on the modinstaller that not many mods are compatible with 1.5

#

maybe on startup/ just on the main menu

light zodiac Jun 21, 2021, 3:24 PM

#

Or maybe just wait

merry lotus Jun 21, 2021, 4:27 PM

#

Didn't RedFrog/Someone already add multipatch support to mod installer?

primal latch Jun 21, 2021, 4:43 PM

#

he did

vocal spire Jun 21, 2021, 6:13 PM

#

Yeah I love being ignored

young walrus Jun 21, 2021, 6:14 PM

#

https://tenor.com/view/sorry-mushu-mulan-did-you-say-something-not-listening-gif-5008260

Tenor

jolly oriole Jun 21, 2021, 6:48 PM

#

that was fast

floral blade Jun 21, 2021, 6:54 PM

#

what was ?

jolly oriole Jun 21, 2021, 6:55 PM

#

stean scam

floral blade Jun 21, 2021, 6:55 PM

#

hollowcool and mods being fast ?

jolly oriole Jun 21, 2021, 6:58 PM

#

yep, in <10 seconds

floral blade Jun 21, 2021, 7:00 PM

#

speedrunning

cedar hemlock Jun 21, 2021, 7:05 PM

#

sped

ornate rivet Jun 21, 2021, 7:05 PM

#

sussy

safe hamlet Jun 21, 2021, 10:08 PM

#

ヘンタイ

ornate rivet Jun 21, 2021, 10:08 PM

#

so true

safe hamlet Jun 21, 2021, 10:09 PM

#

true true

ornate rivet Jun 21, 2021, 10:11 PM

#

@copper nacelle

#

help me

safe hamlet Jun 21, 2021, 10:11 PM

#

are you under the water saleh?

ornate rivet Jun 21, 2021, 10:12 PM

#

yes

#

I'm drowning

mortal trout Jun 21, 2021, 10:12 PM

#

is there too much raining?

ornate rivet Jun 21, 2021, 10:12 PM

#

yes

#

raining something very good

#

thank you 56

#

glad this channel is going back to its roots

vocal spire Jun 22, 2021, 1:40 AM

#

?

jolly oriole Jun 22, 2021, 7:37 AM

#

bless you

weak lodge Jun 22, 2021, 12:26 PM

#

so true

#

bussin

ornate rivet Jun 22, 2021, 2:52 PM

#

I love you knightmere

#

please be my sussy baka

fair rampart Jun 22, 2021, 3:23 PM

#

is there a way to change the attack speed of the knight with mod development?
like 15 attacks per second

rough pulsar Jun 22, 2021, 3:25 PM

#

something
something
apidocs

#

i believe you can change the constants found in the player's variables

#

#

@fair rampart

light zodiac Jun 22, 2021, 3:29 PM

#

I'm sure they know what "apidocs" means

#

https://radiance.host/apidocs

rough pulsar Jun 22, 2021, 3:29 PM

#

ide already displays which variables exist in a class

patent zealot Jun 22, 2021, 3:30 PM

#

SFgrenade has this which are the default values

📎 HeroControllerPublicDefaultValues.txt

#

Attack duration or cooldown is prob what you wanna change

floral blade Jun 22, 2021, 3:31 PM

#

mod that makes you zoom fast through everything

#

zoom kngt

primal latch Jun 22, 2021, 3:31 PM

#

too fast for the work knight

rough pulsar Jun 22, 2021, 3:31 PM

#

set this to 0f zotewheeze

#

also i think ATTACK_COOLDOWN_TIME is what you wanna change

primal latch Jun 22, 2021, 3:34 PM

#

rough pulsar set this to 0f <:zotewheeze:718225348164059187>

or to something very high and call it invulnerable knight

jolly oriole Jun 22, 2021, 3:34 PM

#

but just to be sure set both attack_cooldown_time, attack_cooldown_time_ch, attack_duration_time and attack_duration_time_ch to something low

rough pulsar Jun 22, 2021, 3:34 PM

#

attack_duration_time is how long the nail swing is

#

idk what attack_cooldown_time_ch is

#

anyone care to explain?

primal latch Jun 22, 2021, 3:34 PM

#

attack_cooldown_time_cherry?

#

IDK what ch stands for

worn eagle Jun 22, 2021, 3:35 PM

#

charm - quickslash

rough pulsar Jun 22, 2021, 3:35 PM

#

oh

primal latch Jun 22, 2021, 3:39 PM

#

ah

primal latch Jun 22, 2021, 4:23 PM

#

does anyone have a way to search for a string in a dll? You can't do that with il/dn spy

copper nacelle Jun 22, 2021, 4:24 PM

#

but you can

jolly oriole Jun 22, 2021, 4:24 PM

#

text/number

copper nacelle Jun 22, 2021, 4:25 PM

#

yeah

#

in the search type

jolly oriole Jun 22, 2021, 4:25 PM

#

copper nacelle Jun 22, 2021, 4:26 PM

#

virgin number vs chad zahl

rough pulsar Jun 22, 2021, 4:28 PM

#

what if all charms became inventory items that would give permanent boosts

#

🚎

copper nacelle Jun 22, 2021, 4:29 PM

#

permanent dung aura pauseshroom

primal latch Jun 22, 2021, 4:29 PM

#

whoops

jolly oriole Jun 22, 2021, 4:29 PM

#

permanent gamer odor shroompog

copper nacelle Jun 22, 2021, 4:29 PM

#

true

floral blade Jun 22, 2021, 4:31 PM

#

Permanent lag

#

elderC

#

With the bees that go boom

rough pulsar Jun 22, 2021, 4:37 PM

#

modding moment

rough pulsar Jun 22, 2021, 4:58 PM

#

what happens if we add too many inventory items to the player using sfcore

#

does it just give up displaying or overlap

jolly oriole Jun 22, 2021, 5:12 PM

#

i have never tested the journal list limit

#

probably a good idea for a mod to just add 42069 random items

rough pulsar Jun 22, 2021, 5:13 PM

#

oh so new inventory items are just in a seperate journal-like tab?

jolly oriole Jun 22, 2021, 5:14 PM

#

yes

rough pulsar Jun 22, 2021, 5:14 PM

#

dang

#

i thought they would get displayed like

jolly oriole Jun 22, 2021, 5:14 PM

#

well, if anything adds custom items, the whole inv screen (the one containing dash and stuff) is moved to its own screen

rough pulsar Jun 22, 2021, 5:14 PM

#

on the normal invenotry

#

oh

jolly oriole Jun 22, 2021, 5:15 PM

#

but imma test with the 1.5 version i have already downloaded

rough pulsar Jun 22, 2021, 5:15 PM

#

im using sfcore

primal latch Jun 22, 2021, 5:17 PM

#

do we want to keep the warning Couldn't find a Hero, make sure one exists in the scene.?

copper nacelle Jun 22, 2021, 5:17 PM

#

have you tried finding a hero

primal latch Jun 22, 2021, 5:18 PM

#

I mean: it clutters the output_log file and makes it very hard to find an error

copper nacelle Jun 22, 2021, 5:19 PM

#

does it even log much without misuse from a mod

primal latch Jun 22, 2021, 5:19 PM

#

wdym?

#

ah

#

I get it

rough pulsar Jun 22, 2021, 5:19 PM

#

the hero is missing grubthink

primal latch Jun 22, 2021, 5:20 PM

#

yes. It also logs it in the menu without mods

copper nacelle Jun 22, 2021, 5:20 PM

#

more than once?

#

like is it actually spammy

#

cause you can just use unsafeInstance

jolly oriole Jun 22, 2021, 5:20 PM

#

for me no

primal latch Jun 22, 2021, 5:20 PM

#

yes

copper nacelle Jun 22, 2021, 5:20 PM

#

sus

rough pulsar Jun 22, 2021, 5:20 PM

#

jolly oriole for me no

me neither

primal latch Jun 22, 2021, 5:20 PM

#

lemme check

jolly oriole Jun 22, 2021, 5:21 PM

#

jolly oriole for me no

as in, neither modded nor unmodded 1432 spams that when staying in it, may be 1 or 2 lines of it, but not continuously

rough pulsar Jun 22, 2021, 5:21 PM

#

is it 1.5 that spams it

jolly oriole Jun 22, 2021, 5:21 PM

#

1 sec

primal latch Jun 22, 2021, 5:22 PM

#

it might just have to do with preloads

jolly oriole Jun 22, 2021, 5:23 PM

#

1.5.68.11808 vanilla player.log stays at ~3 KB
1.5.68.11808 modded player.log stays at ~22 KB

rough pulsar Jun 22, 2021, 5:24 PM

#

22 KILOBYTES

#

WHAT

primal latch Jun 22, 2021, 5:24 PM

#

Just tested without mods on. It might just have to do with preloading

#

nope

#

IDK

#

in my mind it was spammed a lot in the console

copper nacelle Jun 22, 2021, 5:26 PM

#

do you have mods on

primal latch Jun 22, 2021, 5:26 PM

#

I tried with and without

jolly oriole Jun 22, 2021, 5:28 PM

#

oh no, reflectionhelper changed

copper nacelle Jun 22, 2021, 5:28 PM

#

a bit

#

the naming was bad

jolly oriole Jun 22, 2021, 5:29 PM

#

so basically getattr -> getfield?

copper nacelle Jun 22, 2021, 5:29 PM

#

yeah

jolly oriole Jun 22, 2021, 5:29 PM

#

what's the difference between setfield and setfieldsafe?

#

oh, one nre checks

copper nacelle Jun 22, 2021, 5:30 PM

#

yeah one dies silently

#

cause that's what pd actually does

jolly oriole Jun 22, 2021, 5:30 PM

#

silent dying?

copper nacelle Jun 22, 2021, 5:30 PM

#

yeah

#

if it gets a bad field name

jolly oriole Jun 22, 2021, 5:30 PM

#

nice

#

???

copper nacelle Jun 22, 2021, 5:32 PM

#

nice

steady comet Jun 22, 2021, 5:33 PM

#

Is PlayerData.SetBoolSwappedArgs a function written by TC? (EDIT: apparently it's by the modding api? palehmm )

jolly oriole Jun 22, 2021, 5:33 PM

#

just writing it works now just fine wtf

rough pulsar Jun 22, 2021, 5:34 PM

#

jolly oriole ???

Visual Studio is drunk once again

#

Sigh

#

Meanwhile I'm in visual studio code because normal vs 2019 lags my computer 🥴

#

jolly oriole Jun 22, 2021, 5:35 PM

#

rough pulsar

nice

#

now to figure out how the new modhooks work

rough pulsar Jun 22, 2021, 5:36 PM

#

The same i think

#

Almost

#

Without the Instance part

jolly oriole Jun 22, 2021, 5:36 PM

#

doubt

rough pulsar Jun 22, 2021, 5:36 PM

#

jolly oriole doubt

Huh

#

I don't

#

Though it worked for me

#

My brain is fried zote

unborn flicker Jun 22, 2021, 5:37 PM

#

The API updated to change the signatures of those hooks, to make it clearer when you intend to override the original value.

copper nacelle Jun 22, 2021, 5:37 PM

#

yeah

rough pulsar Jun 22, 2021, 5:37 PM

#

Thanks for explanation

#

Cool green name person

copper nacelle Jun 22, 2021, 5:37 PM

#

if you check the xml i put some examples in and all too

jolly oriole Jun 22, 2021, 5:38 PM

#

yea, but i don't want to change my method, so i spent 2 hours more to not copy paste them

jolly oriole Jun 22, 2021, 5:38 PM

#

copper nacelle if you check the xml i put some examples in and all too

i'm fairly certain VS will definetly show me that

rough pulsar Jun 22, 2021, 5:38 PM

#

^^

#

Yes

unborn flicker Jun 22, 2021, 5:38 PM

#

steady comet Is PlayerData.SetBoolSwappedArgs a function written by TC? (EDIT: apparently it'...

The API replaces all PD field calls with methods (since fields can't be hooked)

#

The result is pretty ugly though

jolly oriole Jun 22, 2021, 5:39 PM

#

and sometimes is even worse, especially with variable gets/sets

steady comet Jun 22, 2021, 5:40 PM

#

So, in the unmodded assembly-csharp, they're all field calls?

jolly oriole Jun 22, 2021, 5:40 PM

#

yes

steady comet Jun 22, 2021, 5:40 PM

#

huh

copper nacelle Jun 22, 2021, 5:41 PM

#

calls pauseshroom

#

just sets

jolly oriole Jun 22, 2021, 5:41 PM

#

and gets

copper nacelle Jun 22, 2021, 5:41 PM

#

fields are just an offset in memory

unborn flicker Jun 22, 2021, 5:41 PM

#

Yeah, I knew call was the wrong word, but I couldn't think of what would be inclusive of both read/write

copper nacelle Jun 22, 2021, 5:42 PM

#

access ig

jolly oriole Jun 22, 2021, 5:44 PM

#

why does langget have a bool return but that isn't used

#

wait nvm

#

its in an if

copper nacelle Jun 22, 2021, 5:44 PM

#

yeah

#

trygetvalue

jolly oriole Jun 22, 2021, 5:45 PM

#

so having

res = current;
return false;

is to not have a custom string being returned ig

#

with the first line not even being needed

copper nacelle Jun 22, 2021, 5:45 PM

#

yes

jolly oriole Jun 22, 2021, 5:46 PM

#

oh god, res needs to be assigned smh

copper nacelle Jun 22, 2021, 5:46 PM

#

yeah

#

can just do null

jolly oriole Jun 22, 2021, 5:46 PM

#

"" is shorter

#

using more memory for my slightly shorter code = good

copper nacelle Jun 22, 2021, 5:47 PM

#

pauseshroom

#

string.Empty

unborn flicker Jun 22, 2021, 5:48 PM

#

Apparently "" doesn't create a new string anymore according to SE? string.Empty is definitely prettier though imo

jolly oriole Jun 22, 2021, 5:48 PM

#

why does github stop doing markup from https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/ModHooks.cs#L536

prime urchin Jun 22, 2021, 5:49 PM

#

theoretically they're interned and so all options use the same amount of memory, ez

copper nacelle Jun 22, 2021, 5:50 PM

#

ugly though smh

rough pulsar Jun 22, 2021, 5:50 PM

#

jolly oriole why does github stop doing markup from <https://github.com/HollowKnight-Modding/...

The rest of the markup is also kinda broken or that's how github works

#

Either way

#

🥴

jolly oriole Jun 22, 2021, 5:52 PM

#

smh, pinging people PingReee

copper nacelle Jun 22, 2021, 5:52 PM

#

if anyone has suggestions on changing the hooks btw feel free

#

Pre release for a reason

rough pulsar Jun 22, 2021, 5:52 PM

#

I don't

jolly oriole Jun 22, 2021, 5:54 PM

#

hooks look nice, though idk why orig is needed for language hook

copper nacelle Jun 22, 2021, 5:55 PM

#

idk seemed nice to have

#

kinda wanted it on all of them but that's a pain

#

could also just have (string orig, ref string current)

primal latch Jun 22, 2021, 5:58 PM

#

would be beter ngl. Having orig for language is kinda wierd

jolly oriole Jun 22, 2021, 6:01 PM

#

i think i just successfully updated sfcore and tot

#

time to test 42069 inventory items

#

apparently it works, just have like 1 fps when scrolling a step

unborn flicker Jun 22, 2021, 6:05 PM

#

copper nacelle if anyone has suggestions on changing the hooks btw feel free

Is it worth considering encapsulating the event arguments? Something like this might be nice

📎 info.cs

rough pulsar Jun 22, 2021, 6:05 PM

#

i don't really know what are the sheet and orig are for

#

me dumb pepegamaster

jolly oriole Jun 22, 2021, 6:05 PM

#

sheet is amazing to have

rough pulsar Jun 22, 2021, 6:06 PM

#

care to explain?

jolly oriole Jun 22, 2021, 6:06 PM

#

even though i think no one but me uses it

#

it's different sheets where you can have the exact same key for a language string

#

like a different sheet of paper with keys written on it

rough pulsar Jun 22, 2021, 6:06 PM

#

cool

copper nacelle Jun 22, 2021, 6:06 PM

#

yeah that might be nice

jolly oriole Jun 22, 2021, 6:07 PM

#

unborn flicker Is it worth considering encapsulating the event arguments? Something like this m...

instead of the get; set;, readonly should also work

rough pulsar Jun 22, 2021, 6:08 PM

#

^^

#

...
    public readonly string Sheet;
    public readonly string Key;
    public readonly string Orig;
    public readonly string Current;
}

#

The constructor can still set those values

#

Only after created it can't ever be set again

#

Unless i'm wrong

jolly oriole Jun 22, 2021, 6:09 PM

#

the current needs to be assigned though, after a hook, but otherwise yea

unborn flicker Jun 22, 2021, 6:10 PM

#

You could also do

    public string Sheet { get; init; }

on the newer version of C#, right?

#

Not sure how important the decision to expose properties or fields is though.

copper nacelle Jun 22, 2021, 6:11 PM

#

yeah

jolly oriole Jun 22, 2021, 6:12 PM

#

jolly oriole but imma test with the 1.5 version i have already downloaded

6969 has like 0.5 seconds to update the scroll position when i press up/down, 42069 like 2 seconds, but otherwise the only limit seems to be ram

steady comet Jun 22, 2021, 6:12 PM

#

Potential use case for orig: you want your modification to the string to be “add some stuff to the end, but only if the current isn’t vastly longer than the orig already”

copper nacelle Jun 22, 2021, 6:14 PM

#

change it if it hasn't been changed

#

is also a thing ig

#

properties vs fields is just a matter of future proofing and a bit of overhead

jolly oriole Jun 22, 2021, 6:15 PM

#

overhead is bad if i want to do recursion

rough pulsar Jun 22, 2021, 6:30 PM

#

I'm going to spend eternity programming every charm sprite into my mod

#

🥴

#

jolly oriole Jun 22, 2021, 6:37 PM

#

can you make it new Vector2(0.5f, 0.5f)?

rough pulsar Jun 22, 2021, 6:37 PM

#

Oh

prime urchin Jun 22, 2021, 6:37 PM

#

should put that into a helper that takes a string (possibly the simple file name) and a width and height, saves you some typing

rough pulsar Jun 22, 2021, 6:38 PM

#

You're right

jolly oriole Jun 22, 2021, 6:40 PM

#

btw, new texture can be given 2, 2, loadimage will resize the texture
and having file.readallbytes not the best, loading from embedded resource stream is better

rough pulsar Jun 22, 2021, 6:45 PM

#

And I realized like I can't do that either

#

The readallbytes thing

rough pulsar Jun 22, 2021, 6:46 PM

#

jolly oriole btw, new texture can be given `2, 2`, loadimage will resize the texture and havi...

Can you show me an example on loading from embedded resource stream

jolly oriole Jun 22, 2021, 6:46 PM

#

https://github.com/SFGrenade/TestOfTeamwork/blob/master/Consts/TextureStrings.cs#L61

mental void Jun 22, 2021, 6:50 PM

#

alright I am ready for my lessons on hollowknight modding

rough pulsar Jun 22, 2021, 6:50 PM

#

https://radiance.host/apidocs/Getting-Started.html#creating-mods

rough pulsar Jun 22, 2021, 6:54 PM

#

jolly oriole <https://github.com/SFGrenade/TestOfTeamwork/blob/master/Consts/TextureStrings.c...

How can I find out the file names of the charms?

jolly oriole Jun 22, 2021, 6:55 PM

#

oh wait, you aren't in vs are you?

rough pulsar Jun 22, 2021, 6:55 PM

#

Does vs show these elderC

#

I mean vscode also displays the list of methods and stuff

#

jolly oriole Jun 22, 2021, 6:56 PM

#

if you have it in vs, right click -> properties the file, set it to embedded resource, then address them like the link does in a format like "Assembly.Folderstructure.Filename.extension"

#

for that it needs to be part of the project ofc

rough pulsar Jun 22, 2021, 6:58 PM

#

Luckily I already have downloaded the charm sprites from wiki zote

jolly oriole Jun 22, 2021, 6:58 PM

#

but are those accurate to the game sprites

rough pulsar Jun 22, 2021, 7:03 PM

#

I mean they are certainly not ripped from the game sprites

#

Just from the wiki instead

cedar hemlock Jun 22, 2021, 7:03 PM

#

All the sprites can be found in art-discussion

rough pulsar Jun 22, 2021, 7:04 PM

#

Huh?????????????

#

Really????????????????

#

zote 🥴

#

Oh dang this is HELPFUL

nimble lake Jun 22, 2021, 7:05 PM

#

rough pulsar Really????????????????

yes

rough pulsar Jun 22, 2021, 7:05 PM

#

It's just as if I found a gold mine

cedar hemlock Jun 22, 2021, 7:05 PM

#

lol

jolly oriole Jun 22, 2021, 7:05 PM

#

or take this incomplete pack

📎 Charms.zip

rough pulsar Jun 22, 2021, 7:06 PM

#

The charm names here are accurate right

#

The charm_fungus name

cedar hemlock Jun 22, 2021, 7:06 PM

#

I believe so

#

They are 1.4 sprites, be ware

rough pulsar Jun 22, 2021, 7:06 PM

#

I am in 1.4.3.2

cedar hemlock Jun 22, 2021, 7:06 PM

#

So if, any of them changed...

#

Oh ok

nimble lake Jun 22, 2021, 7:07 PM

#

cedar hemlock They are 1.4 sprites, be ware

are they even different than 1.5?

jolly oriole Jun 22, 2021, 7:07 PM

#

boomer

cedar hemlock Jun 22, 2021, 7:07 PM

#

nimble lake are they even different than 1.5?

Idk thought i heard smth about that

floral blade Jun 22, 2021, 7:16 PM

#

rough pulsar I am in 1.4.3.2

Why are you not stealing code from customknight ?

rough pulsar Jun 22, 2021, 7:17 PM

#

noot

floral blade Jun 22, 2021, 7:17 PM

#

it's got logic to load charms and stuff right ? Just use the sprites for inventory instead ?

rough pulsar Jun 22, 2021, 7:17 PM

#

I'm just assuming it loads them from file

floral blade Jun 22, 2021, 7:17 PM

#

It does yeah

rough pulsar Jun 22, 2021, 7:17 PM

#

Like

#

external files

cedar hemlock Jun 22, 2021, 7:18 PM

#

the default folder

floral blade Jun 22, 2021, 7:18 PM

#

Yes yes, but name arrays and files in the default skin would let you start off

cedar hemlock Jun 22, 2021, 7:18 PM

#

wait it depends

#

i believe it just doesn't change anything when no skin is selected

floral blade Jun 22, 2021, 7:19 PM

#

cedar hemlock i believe it just doesn't change anything when no skin is selected

It definitely does not

cedar hemlock Jun 22, 2021, 7:19 PM

#

oh ok

#

what does it do then?

floral blade Jun 22, 2021, 7:20 PM

#

Just shows the menu on pause ?

#

If you do apply a skin it would apply things from that skin

#

As Far as I can tell the default folder is more of a resource for people wanting to make skins than an actual "revert me to default"

#

Because it still loads the default skin from disk lol

#

Even though it should have a copy of the default sprites in memory

rough pulsar Jun 22, 2021, 7:51 PM

#

I'm back

#

I'm just gonna steal the entirety of https://github.com/SFGrenade/TestOfTeamwork/blob/master/Consts/TextureStrings.cs#L61 and modify it into my needs grublaugh

jolly oriole Jun 22, 2021, 7:54 PM

#

smh

lone rune Jun 22, 2021, 9:09 PM

#

did any sprites change in 1.5?

jolly oriole Jun 22, 2021, 9:10 PM

#

some spritesheets changed, but idk about specific sprites

lone rune Jun 22, 2021, 9:12 PM

#

you mean like the order of the sprites on the sheet?

jolly oriole Jun 22, 2021, 9:12 PM

#

the spritesheet for the fungal wastes / mantis village got bigger, but that's about all i checked

lone rune Jun 22, 2021, 9:12 PM

#

oh huh really? I'll take a look at that

#

tbh not really feeling like extracting and organizing 10K files again for the sprite folder, so if nothing got added then I hope I don't need to do that

jolly oriole Jun 22, 2021, 9:14 PM

#

dw, 1432 only has 3608 sprites/spritesheets

lone rune Jun 22, 2021, 9:15 PM

#

yeah but you can extract a lot of individual sprites, I extracted over 10K with asset studio

jolly oriole Jun 22, 2021, 9:15 PM

#

yea, but idk if asset studio works with unity 2020

lone rune Jun 22, 2021, 9:22 PM

#

seems like it does

rough pulsar Jun 22, 2021, 9:23 PM

#

heroupdatehook works if only the knight can be controlled or exists right

vocal spire Jun 22, 2021, 9:24 PM

#

Only if it exists and it’s GameObject is active(basically whenever it exists)

rough pulsar Jun 22, 2021, 9:25 PM

#

Cool

floral blade Jun 22, 2021, 10:21 PM

#

is it possible to trigger a "pause" input from a mod ?

jolly oriole Jun 22, 2021, 10:22 PM

#

yes

floral blade Jun 22, 2021, 10:22 PM

#

like bring up pause menu and close the pause menu in a way other mods dont break

rough pulsar Jun 22, 2021, 10:22 PM

#

what are the language string ids thingies for charm descriptions?

jolly oriole Jun 22, 2021, 10:22 PM

#

everything is possible with mods, the only thing limiting is how difficult those things might be

jolly oriole Jun 22, 2021, 10:22 PM

#

rough pulsar what are the language string ids thingies for charm descriptions?

CHARM_DESC_X

rough pulsar Jun 22, 2021, 10:23 PM

#

thanks!

floral blade Jun 22, 2021, 10:24 PM

#

i mean i don't want to break other mods by trying to trigger a pause in mine

#

i guess it would depend on how the other mods detect their pause behaviour

rough pulsar Jun 22, 2021, 10:27 PM

#

Imagine if there was some sort of an UI where you could change other mods' keybinds

#

if the mods let anyone to do so

#

Wouldn't that be awesome

floral blade Jun 22, 2021, 10:28 PM

#

rough pulsar Imagine if there was some sort of an UI where you could change other mods' keybi...

you mean the new custom mod menu ?

vocal spire Jun 22, 2021, 10:28 PM

#

You might be able to make something like that with the new custom menu api

rough pulsar Jun 22, 2021, 10:28 PM

#

I mean close

floral blade Jun 22, 2021, 10:28 PM

#

each mod needs to implement it tho

rough pulsar Jun 22, 2021, 10:28 PM

#

vocal spire You might be able to make something like that with the new custom menu api

In 1.5?

vocal spire Jun 22, 2021, 10:28 PM

#

Yes

floral blade Jun 22, 2021, 10:28 PM

#

rough pulsar In 1.5?

yep

#

The new menu api is super cool, it works with controller, is in an obvious but out of the way place and looks good with minimal effort

#

i'm definitely using it in 1.5 CK

rough pulsar Jun 22, 2021, 10:45 PM

#

please do!!!

fickle sparrow Jun 22, 2021, 11:15 PM

#

I also have documentation for it 😤

#

it took like a month to reverse engineer HKs menus

#

FeelsInvertedMan

ornate rivet Jun 22, 2021, 11:20 PM

#

can you post the documentation into the apidocs

#

radiance.host I mean

copper nacelle Jun 22, 2021, 11:25 PM

#

pauseshroom

ornate rivet Jun 22, 2021, 11:25 PM

#

what's wrong?

copper nacelle Jun 22, 2021, 11:25 PM

#

local man unable to look at xml

#

I should set up docfx

fickle sparrow Jun 22, 2021, 11:40 PM

#

true

#

also I should make a guide for the menu api

vocal spire Jun 22, 2021, 11:47 PM

#

Yeah

#

Also when are the custom ui methods overridable by mods called?

fickle sparrow Jun 22, 2021, 11:55 PM

#

wdym

#

Like the “OnSubmitAction” thing?

vocal spire Jun 23, 2021, 12:30 AM

#

No

#

Like the method where you return a list of the settings, or the one where you return a menu you’ve set up yourself

fickle sparrow Jun 23, 2021, 2:18 AM

#

oh

#

uhhhhh

#

so its a bit complex

#

but essentially its whenever a UIManager is created

#

#

relevant code

#

hmmmm

#

nvm I thought I found a bug but I didn't 🥴 my code actually works

fickle sparrow Jun 23, 2021, 5:04 AM

#

https://cdn.discordapp.com/attachments/521709991019806731/857117917630824468/unknown.png

#

echaleph

#

top 10 worst mistakes

jolly oriole Jun 23, 2021, 5:31 AM

#

ornate rivet can you post the documentation into the apidocs

Apidocs bad >:( and no, i won't make them better >:(

copper nacelle Jun 23, 2021, 5:31 AM

#

I can't tell if this is ironic or not

jolly oriole Jun 23, 2021, 6:40 AM

#

take a guess

copper nacelle Jun 23, 2021, 7:22 AM

#

likely

jolly oriole Jun 23, 2021, 7:28 AM

#

considering i already contributed to the apidocs (and probably should update what i changed for sfcore 1.5 like next tuesday), i think one can categorize that as ironic

ornate rivet Jun 23, 2021, 10:37 AM

#

should we have a 1.4 and 1.5 section or just replace everything with 1.5 stuff?

#

well I'm not going to delete the Utiny stuff, that shit took way too long

jolly oriole Jun 23, 2021, 10:42 AM

#

mark it at the top with something like "This only works with the 1.4.3.2 patch"

cedar hemlock Jun 23, 2021, 10:43 AM

#

why does this give me 404

floral blade Jun 23, 2021, 10:48 AM

#

ornate rivet should we have a 1.4 and 1.5 section or just replace everything with 1.5 stuff?

if its about a document then , i'd suggest to make a new one for 1.5 & link the doc for 1.4.3.2 in it.

#

1.5 would be the default one that opens

#

Oh I guess it was about apidocs lol I'd still suggest the same tbh

light zodiac Jun 23, 2021, 11:06 AM

#

cedar hemlock why does this give me 404

Just download API from release page

rough pulsar Jun 23, 2021, 12:43 PM

#

im just gonna wait until weird softlocking glitches in 1.5 mapi stops happening

light zodiac Jun 23, 2021, 12:52 PM

#

What soft locking glitches?

rough pulsar Jun 23, 2021, 1:03 PM

#

i mean for me i occasionally cant exit to menu, one time i was stuck in an elevator transition

light zodiac Jun 23, 2021, 1:41 PM

#

for FSMViewAvalonia if i change the hkpath.txt to a 1.4 installation, would it show me the 1.4 FSMs?

jolly oriole Jun 23, 2021, 1:50 PM

#

with open you can already open 1432 assetbundles and view their fsms, but the hkpath is probably used to determine the hk installation checked with select scene and the resources one

light zodiac Jun 23, 2021, 1:56 PM

#

i could probably build the non avalonia fsm viewer and change the place it looks for hk

jolly oriole Jun 23, 2021, 1:59 PM

#

i meant that as in "yes, you can look at 1432 fsms"

light zodiac Jun 23, 2021, 2:01 PM

#

ok

jolly oriole Jun 23, 2021, 2:01 PM

#

but give me a minute to test it myself with that .txt as i have technical problems with it rn

light zodiac Jun 23, 2021, 2:01 PM

#

is there a fsm change that is known so i can tell if i'm looking at the correct one

jolly oriole Jun 23, 2021, 2:02 PM

#

light zodiac is there a fsm change that is known so i can tell if i'm looking at the correct ...

convo_finish and talk_finish events, idk which one is 1432 or 1.5

jolly oriole Jun 23, 2021, 2:04 PM

#

light zodiac for FSMViewAvalonia if i change the `hkpath.txt` to a 1.4 installation, would it...

oh, you mean compiling yourself with that changed txt, then maybe, i haven't looked at the code

#

oh wait

#

now that i read the code

#

yes, should show 1432 fsms

light zodiac Jun 23, 2021, 2:10 PM

#

Thanks

jolly oriole Jun 23, 2021, 2:10 PM

#

yep, just tested, works

deep wave Jun 23, 2021, 2:30 PM

#

<@&283547423706447872>

#

stmeacomunnitty think

jolly oriole Jun 23, 2021, 2:33 PM

#

they get more creative

vocal spire Jun 23, 2021, 2:34 PM

#

Fun

dark wigeon Jun 23, 2021, 2:44 PM

#

why tf does gog have to be different

jolly oriole Jun 23, 2021, 2:44 PM

#

yes

#

in the meantime, i got steam installed in a vm

#

now can test hk mods on linux at <1 fps (well, once i downloaded it)

floral blade Jun 23, 2021, 2:49 PM

#

tamershrug i just test on mac and release

jolly oriole Jun 23, 2021, 2:50 PM

#

well nvm that, it doesn't want to run in my vm

#

probably because software rendering

nimble lake Jun 23, 2021, 5:07 PM

#

how can i display the console in the game?

#

the one that usually appears in the bottom left

ornate rivet Jun 23, 2021, 5:09 PM

#

if F10 doesn't toggle it then you have to go to the modding api json and enable it

nimble lake Jun 23, 2021, 5:12 PM

#

ah ok, thanks

#

also another question, how can I read a value from a flag in the current save file and use it in a mod?

light zodiac Jun 23, 2021, 5:22 PM

#

PlayerData.instance.{the value you want}

vocal spire Jun 23, 2021, 5:25 PM

#

Or PlayerData.instance.Gettype(field name)
Replace type with Int, String, Float, ect

nimble lake Jun 23, 2021, 5:27 PM

#

also why is this error happening? i can't find anything about this on google

#

incase anyone knows

vocal spire Jun 23, 2021, 5:28 PM

#

How did you create the project

nimble lake Jun 23, 2021, 5:28 PM

#

class library

vocal spire Jun 23, 2021, 5:29 PM

#

Or is this a project you’ve already used before?

nimble lake Jun 23, 2021, 5:29 PM

#

it worked before fine but this is the 2nd time it's happening today after i repaired VS

vocal spire Jun 23, 2021, 5:29 PM

#

Huh

#

Idk, sorry

nimble lake Jun 23, 2021, 5:32 PM

#

ok i think i fixed it

#

but there's no get

#

light zodiac Jun 23, 2021, 5:33 PM

#

light zodiac PlayerData.instance.{the value you want}

..

nimble lake Jun 23, 2021, 5:34 PM

#

or anything at all

vocal spire Jun 23, 2021, 5:34 PM

#

Huh, was that removed with the new get/set hooks?

light zodiac Jun 23, 2021, 5:34 PM

#

did you reference assembly c-sharp.dll?

light zodiac Jun 23, 2021, 5:34 PM

#

vocal spire Huh, was that removed with the new get/set hooks?

isn't this 1.4 (seeing from the mod common)

nimble lake Jun 23, 2021, 5:34 PM

#

i'll try re-referencing it

vocal spire Jun 23, 2021, 5:35 PM

#

light zodiac isn't this 1.4 (seeing from the mod common)

Ah, then it should be there

light zodiac Jun 23, 2021, 5:35 PM

#

and are you using modding

vocal spire Jun 23, 2021, 5:35 PM

#

Should be there without it

nimble lake Jun 23, 2021, 5:35 PM

#

light zodiac and are you `using modding`

yes to that as well

#

oh wait

#

relaunching VS fixed this

#

what is going on with my VS today though
literally hadn't touched it in days and like 6000 things are broken for no reason

vocal spire Jun 23, 2021, 5:39 PM

#

https://youtu.be/Dey2LmtAmHs

YouTube

MEBI's animations and other stuff

Pale court: reworking an isma attack

an old isma attack was giving problem to the programmers and needed overall balancing, so I decided to remake it

▶ Play video

floral blade Jun 23, 2021, 5:40 PM

#

does isma attack with acid ? or vines ?

jolly oriole Jun 23, 2021, 5:40 PM

#

wait and see

floral blade Jun 23, 2021, 5:41 PM

#

looks like vines

floral blade Jun 23, 2021, 5:42 PM

#

jolly oriole wait and see

i am impatient okay ?

nimble lake Jun 23, 2021, 5:46 PM

#

Wait is that right? PlayerData.instance.GetInt("maxHealth");

jolly oriole Jun 23, 2021, 5:47 PM

#

looks right

nimble lake Jun 23, 2021, 5:47 PM

#

because it's not working ingame, it seems

jolly oriole Jun 23, 2021, 5:49 PM

#

are you trying that while having a save loaded (ingame ingame) or in the main menu?

nimble lake Jun 23, 2021, 5:49 PM

#

oh maybe that's why

#

maybe it just tries to read a save file before one is even opened

#

wait but it shouldn't from the looks of it

public MoreBaseHealthUI() : base("More Base Health UI")
{
    On.GameCameras.Start += MoreHealthDisplay;
}

jolly oriole Jun 23, 2021, 5:52 PM

#

oh, uh, gamecameras start at the game start (or after preloading is done), so that is way before any save file is loaded

nimble lake Jun 23, 2021, 5:52 PM

#

i see

jolly oriole Jun 23, 2021, 5:53 PM

#

the workaround i did was to just preload whatever and have a set amount of additional masks being added

nimble lake Jun 23, 2021, 5:54 PM

#

yea, i wanted to just read from the save file instead of having a static number in the code

jolly oriole Jun 23, 2021, 5:54 PM

#

then you'd have to manually load every save yourself and get the max health across all of them

nimble lake Jun 23, 2021, 5:59 PM

#

why not just from the save that's being loaded?

vocal spire Jun 23, 2021, 5:59 PM

#

ModHooks.Instance.AfterSaveGameLoad?

jolly oriole Jun 23, 2021, 5:59 PM

#

then you'd have to remember how many masks are already there and only instantiate new ones

#

but also possible

light zodiac Jun 23, 2021, 7:56 PM

#

how do I set a value in game manager to a value i want

jolly oriole Jun 23, 2021, 7:57 PM

#

GameManager.instance.value = myValue ?

light zodiac Jun 23, 2021, 7:57 PM

#

I'm doing GameManager.instance.TimeSlowed = true; but I'm getting a this property has no settter

jolly oriole Jun 23, 2021, 7:58 PM

#

then check with dnspy if it has an internally used bool and set that instead

#

if not, idk

light zodiac Jun 23, 2021, 7:59 PM

#

could i use reflection?

jolly oriole Jun 23, 2021, 7:59 PM

#

yes

light zodiac Jun 23, 2021, 7:59 PM

#

also dnspy shows me public bool TimeSlowed => this.timeSlowedCount > 0;

jolly oriole Jun 23, 2021, 8:00 PM

#

then ig set timeSlowedCount to 1 or something

light zodiac Jun 23, 2021, 8:32 PM

#

thanks its working now

pine girder Jun 23, 2021, 8:33 PM

#

Leak from pale court 👀

rough pulsar Jun 23, 2021, 8:34 PM

#

we're about to see slowdown in pale court 👀

jolly oriole Jun 23, 2021, 8:58 PM

#

i mean, yea, parries

void burrow Jun 23, 2021, 9:12 PM

#

can somemone teach me how do I create a mod?

jolly oriole Jun 23, 2021, 9:12 PM

#

https://radiance.host/apidocs/Getting-Started.html

void burrow Jun 23, 2021, 9:13 PM

#

ok thanks

pine girder Jun 23, 2021, 10:09 PM

#

I just realized
Can I colorize soul based on frames?

vocal spire Jun 24, 2021, 12:41 AM

#

@arctic wraith good place to start modding https://radiance.host/apidocs/

arctic wraith Jun 24, 2021, 12:41 AM

#

itssoulgood

#

i meant tools to download mods though zote

vocal spire Jun 24, 2021, 12:43 AM

#

Oh lol

#

Sorry

fickle sparrow Jun 24, 2021, 1:48 AM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/docs/MenuAPI.README.md

#

gg

#

also refer to the xml docs they're good 😤

floral blade Jun 24, 2021, 9:53 AM

#

How does one spawn a block of ground ?

jolly oriole Jun 24, 2021, 9:54 AM

#

var ground = new GameObject("", typeof(BoxCollider2D));

floral blade Jun 24, 2021, 10:01 AM

#

Yes but, I'd have to supply the sprite myself right ?
Any chance I can copy it from the game instead of using an assembly resource?

jolly oriole Jun 24, 2021, 10:12 AM

#

preload a platform from some scene?

floral blade Jun 24, 2021, 10:23 AM

#

Okay I'm going to try that

primal latch Jun 24, 2021, 11:10 AM

#

jolly oriole `var ground = new GameObject("", typeof(BoxCollider2D));`

Don’t forget to set it to layer 7

#

Or 8. Not sure

jolly oriole Jun 24, 2021, 11:11 AM

#

PhysLayers.Terrain

#

PingReee

floral blade Jun 24, 2021, 11:14 AM

#

what's PhysLayers.Terrain ?

jolly oriole Jun 24, 2021, 11:15 AM

#

enum value for terrain layer

floral blade Jun 24, 2021, 11:16 AM

#

oh and do i need to be using GlobalEnums to use it ?

ornate rivet Jun 24, 2021, 11:20 AM

#

are those updated? Some of the layers aren't in it so I'm just wondering.

jolly oriole Jun 24, 2021, 11:21 AM

#

idk which ones are missing

floral blade Jun 24, 2021, 11:24 AM

#

finally claw can be collected !

jolly jungle Jun 24, 2021, 11:42 AM

#

It was too high?

floral blade Jun 24, 2021, 11:46 AM

#

yep

#

apparently spell twister is the same way

#

looking for its scene name now

floral blade Jun 24, 2021, 12:19 PM

#

i guess it's all the "Shiny Item Stand" that might break pikashade

patent zealot Jun 24, 2021, 12:25 PM

#

I find it funny that claw is too high on the shelf to get

floral blade Jun 24, 2021, 12:49 PM

#

even though there's like a 100 of them in that room, the knight just wont pick the others because they're not shiny vibecollector

iron ibex Jun 24, 2021, 2:45 PM

#

Hi all, anyone have good suggestions for software to create custom skins?

cedar hemlock Jun 24, 2021, 2:55 PM

#

idk but dandy wants to share this so it can help eventually https://prashantmohta.github.io/HollowKnight.SkinRemixer/

ornate rivet Jun 24, 2021, 2:57 PM

#

That's really cool

jolly oriole Jun 24, 2021, 2:58 PM

#

dandy, can you add the parts of the "Yeah Whatever 3.0" custom knight skin?

floral blade Jun 24, 2021, 2:59 PM

#

jolly oriole dandy, can you add the parts of the "Yeah Whatever 3.0" custom knight skin?

is that the green skin lol?

jolly oriole Jun 24, 2021, 2:59 PM

#

its rainbow

#

#modding-discussion message

floral blade Jun 24, 2021, 3:02 PM

#

yeah

jolly oriole Jun 24, 2021, 3:03 PM

#

"the green skin" 🙄

floral blade Jun 24, 2021, 3:04 PM

#

to be fair i remembered it from the HUD lol

#

and yeah you could copy over the effects / slashes from this using the remixer

#

jolly oriole Jun 24, 2021, 3:12 PM

#

nice

jolly jungle Jun 24, 2021, 4:34 PM

#

So dandy
what are the current limitations of the remixer?

#

I know there's the whole thing with eyes not being entirely precise, and hats dont always work well with a different type of horn than the one they were designed for, at the moment

#

but are there any actual big problems?

floral blade Jun 24, 2021, 4:53 PM

#

the hat/hair thing is just another layer, so it's still a lot of work from the artists perspective to create different variations. my ideal would be to not require the artist have to draw all poses , like for eyes we only require 1 eye png to create it.

biggest challenge right now is horns/head shapes. once i have that & a bit of refactor i'd consider the remixer to be complete. (that and also supporting sprint.png )

#

also while the groundwork for hats is done it's not implemented fully yet , i'm hoping to finish that one the coming weekend

floral blade Jun 24, 2021, 5:32 PM

#

unrelated to this, what controls the size of the light around the knight ?

#

i saw a HeroLight but increasing it's localScale does not increase the light significantly

floral blade Jun 24, 2021, 6:40 PM

#

the light was increasing properly, it was the Vignette that was not scaled at all so the light being scaled did not matter much FML.

merry lotus Jun 24, 2021, 6:44 PM

#

Assuming this is for smol Knight, i didn't think to test that with debug. I just noticed the light issue, but didn't think to toggle the various things that could affect it

floral blade Jun 24, 2021, 6:52 PM

#

it is for smol knight, i might just end up only scaling the Vignette back up if that makes the dark rooms playable

jolly jungle Jun 25, 2021, 6:54 AM

#

floral blade the hat/hair thing is just another layer, so it's still a lot of work from the a...

Can't you make it so that horns come on two separate layers, so one will be in front of hats/hair always?

#

And then they won't need to leave empty space for the horn, which is messed up with different horns

jolly oriole Jun 25, 2021, 7:03 AM

#

sir, this is #archived-modding-development

cedar hemlock Jun 25, 2021, 7:58 AM

#

(use a channel like #off-topic next time)

floral blade Jun 25, 2021, 8:29 AM

#

jolly jungle Can't you make it so that horns come on two separate layers, so one will be in f...

Can but then each skin needs to have the horns on separate layer

eternal crown Jun 25, 2021, 9:21 AM

#

is API already updated to the current HK version? Or it has just released so nobode had time to do anything?

jolly oriole Jun 25, 2021, 9:27 AM

#

the api for 1.5 is currently basically a beta version, some things are subject to change, but overall it mostly is done

jolly oriole Jun 25, 2021, 12:48 PM

#

new hk patch?

copper nacelle Jun 25, 2021, 12:50 PM

#

yeah

#

what's the version number btw

jolly oriole Jun 25, 2021, 12:53 PM

#

probably 1.5.71.numbers

#

not at home rn

#

41188 maybe, idk

steady comet Jun 25, 2021, 12:55 PM

#

1.5.72.11824?

jolly oriole Jun 25, 2021, 12:55 PM

#

wait what

#

that's newer than yesterdays beta-channel

#

damn

steady comet Jun 25, 2021, 12:56 PM

#

<#822831192150638643 message>

copper nacelle Jun 25, 2021, 12:57 PM

#

nail art damage again

#

what will it be this time

#

glad on the elevator spikes though that was annoying me

jolly oriole Jun 25, 2021, 12:58 PM

#

should (hopefully) be the nart damage change from 1.5.71., which reverted it back to 1432 workings

copper nacelle Jun 25, 2021, 12:59 PM

#

ruined

#

where's the str fury cyclone feelsbadman

jolly oriole Jun 25, 2021, 12:59 PM

#

unless tc decided to change it yet again

#

because i submitted my opinion to have 2x+strength+fury narts (instead of 2.5x+fury)

#

1x for cyclone

deep wave Jun 25, 2021, 1:00 PM

#

do tc know what a beta branch is for

#

day 201927 of pushing straight to live 🥴

jolly oriole Jun 25, 2021, 1:00 PM

#

.71 was only on the beta branch

vocal spire Jun 25, 2021, 1:57 PM

#

Tc is kinda questionable atm

deep wave Jun 25, 2021, 2:02 PM

#

atm? feelspkman

tawny onyx Jun 25, 2021, 2:04 PM

#

what does atm means

vocal spire Jun 25, 2021, 2:04 PM

#

At the moment

jolly oriole Jun 25, 2021, 2:11 PM

#

ATMs are those things where you can withdraw money from a bank account

tawny onyx Jun 25, 2021, 2:13 PM

#

should have cards at first

#

lol

fair rampart Jun 25, 2021, 2:53 PM

#

hi after the patch I have an error in "using Modding"

#

i can solve by simply refreshing the assembly references or I have to do something else

deep wave Jun 25, 2021, 2:57 PM

#

if you are referencing the game files directly, the update will have overwritten assembly-csharp, so the Modding namespace will not exist

jolly jungle Jun 25, 2021, 3:03 PM

#

How do I change timescale like in Debug?

copper nacelle Jun 25, 2021, 3:04 PM

#

Time.timeScale

jolly jungle Jun 25, 2021, 3:04 PM

#

steady comet <https://discord.com/channels/772964112908156938/822831192150638643/857839353546...

what's this link btw?

jolly jungle Jun 25, 2021, 3:05 PM

#

copper nacelle Time.timeScale

Thanks

#

Is that really all it is?

copper nacelle Jun 25, 2021, 3:05 PM

#

yeah

jolly jungle Jun 25, 2021, 3:06 PM

#

Like, there isn't anything else you didn't mention because it should be basic and common sense and yet for some reason I'm not aware of

copper nacelle Jun 25, 2021, 3:07 PM

#

it'll get reset if you get hit and shit

jolly jungle Jun 25, 2021, 3:08 PM

#

Hm

#

Thanks

steady comet Jun 25, 2021, 3:10 PM

#

jolly jungle what's this link btw?

https://cdn.discordapp.com/attachments/822831192150638643/857839353313099806/unknown.png

jolly jungle Jun 25, 2021, 3:10 PM

#

Ah, thanks

#

zotewheeze

#

How do I hook the end of a focus? Only BeforeAddHealthHook or is there a more successful-focus-specific way?

fair rampart Jun 25, 2021, 3:12 PM

#

ops i have replaced assembly-csharp but the game crashed

copper nacelle Jun 25, 2021, 3:12 PM

#

probably just use spell control

jolly jungle Jun 25, 2021, 3:12 PM

#

spell control?

steady comet Jun 25, 2021, 3:12 PM

#

jolly jungle How do I hook the end of a focus? Only `BeforeAddHealthHook` or is there a more ...

I imagine this one would trigger off benching and hot springs too?

fair rampart Jun 25, 2021, 3:12 PM

#

probably it was the assembly c sharp of the previous patch

jolly jungle Jun 25, 2021, 3:13 PM

#

steady comet I imagine this one would trigger off benching and hot springs too?

Ah, didn't think of that

#

Thanks

#

Spell control it is, then, once I figure out what it is

steady comet Jun 25, 2021, 3:14 PM

#

jolly jungle spell control?

I think this means to modify the Knight-Spell Control FSM

jolly jungle Jun 25, 2021, 3:14 PM

#

Hm

#

I'll take a look at it, see if it works for me

#

Thanks

fair rampart Jun 25, 2021, 3:18 PM

#

whe have already an updated assembly c sharp for modding?

jolly jungle Jun 25, 2021, 3:18 PM

#

What's "Dream Focus"?

steady comet Jun 25, 2021, 3:19 PM

#

jolly jungle What's "Dream Focus"?

I would guess when you try to absorb Herrah, but IDK

jolly jungle Jun 25, 2021, 3:19 PM

#

Doesn't seem like it?

#

Doesn't seem like what I need, though, either

#

Aight so how do I access the Knight's FSMs in code palehmm

jolly oriole Jun 25, 2021, 3:24 PM

#

HeroController.instance.LocateMyFSM("")

jolly jungle Jun 25, 2021, 3:24 PM

#

I'm an idiot, thanks sethsalute

#

I need to change it only once, right?

#

Not, like, every scene or something

jolly oriole Jun 25, 2021, 3:25 PM

#

everytime a save is loaded, or on every herocontroller.start

jolly jungle Jun 25, 2021, 3:27 PM

#

So should I hook loading a save and then do this?

jolly oriole Jun 25, 2021, 3:28 PM

#

either hook the aftersaveload hook (i think this should work), or on.herocontroller.start (this definetly works)

jolly jungle Jun 25, 2021, 3:29 PM

#

Thanks

#

Turns out I dont know how to hook herocontroller.start

copper nacelle Jun 25, 2021, 3:33 PM

#

On.HeroController.Start

jolly jungle Jun 25, 2021, 3:34 PM

#

Hm

#

Ok

#

On is generally used for any function?

copper nacelle Jun 25, 2021, 3:35 PM

#

yeah that is what hookgen does

jolly jungle Jun 25, 2021, 3:35 PM

#

Cool, thanks

jolly jungle Jun 25, 2021, 3:42 PM

#

jolly oriole HeroController.instance.LocateMyFSM("")

For whatever reason this isn't working :/

copper nacelle Jun 25, 2021, 3:43 PM

#

.gameObject.LocateMyFSM

jolly jungle Jun 25, 2021, 3:46 PM

#

grimmpalm

#

of coures

jolly oriole Jun 25, 2021, 3:47 PM

#

oh

jolly jungle Jun 25, 2021, 3:49 PM

#

Stupider problem, why does it not recognise the }

copper nacelle Jun 25, 2021, 3:50 PM

#

are you using 50 spaces or is there something behind Playmakerfsm

jolly jungle Jun 25, 2021, 3:51 PM

#

private

#

copper nacelle Jun 25, 2021, 3:52 PM

#

why the fuck

#

no

#

remove it

jolly jungle Jun 25, 2021, 3:52 PM

#

Oh ok

#

What'd it do?

#

Wait you're right

#

it's inside a random function

#

idiot

#

me, that is

#

not you

#

you're fine

vocal spire Jun 25, 2021, 3:56 PM

#

fair rampart whe have already an updated assembly c sharp for modding?

Yes, you get it and the files that need to go with it from the ModdingApi GitHub repo. You can get a pre built ver from the actions tab

copper nacelle Jun 25, 2021, 3:57 PM

#

no

#

lying to the people feelsbadman

#

At least I didn't update the ci build files

vocal spire Jun 25, 2021, 4:00 PM

#

Oh

#

I thought they meant 1.5 in general

#

We’re there really that many changes in the code?

jolly jungle Jun 25, 2021, 4:01 PM

#

How do I make isTrue act like isFalse? I tried sendevent but it doesn't fit

copper nacelle Jun 25, 2021, 4:02 PM

#

I mean no I just haven't bothered changing out the files

light zodiac Jun 25, 2021, 4:03 PM

#

https://drive.google.com/file/d/1EcqPY6qldQLkaAoUGchjP0yomJG_vPxG/view?usp=sharing

API for .72 if someone wants

jolly jungle Jun 25, 2021, 4:03 PM

#

Welp for now I'll just change SetIntValue I guess

fair rampart Jun 25, 2021, 4:03 PM

#

light zodiac <https://drive.google.com/file/d/1EcqPY6qldQLkaAoUGchjP0yomJG_vPxG/view?usp=shar...

thanks

vocal spire Jun 25, 2021, 4:03 PM

#

light zodiac <https://drive.google.com/file/d/1EcqPY6qldQLkaAoUGchjP0yomJG_vPxG/view?usp=shar...

Someone does want

light zodiac Jun 25, 2021, 4:03 PM

#

And debug https://github.com/TheMulhima/HollowKnight.DebugMod/releases/download/v1.4.1/DebugMod.dll

jolly jungle Jun 25, 2021, 4:03 PM

#

But I'll need to know at some point how to finish early

jolly jungle Jun 25, 2021, 4:03 PM

#

light zodiac And debug <https://github.com/TheMulhima/HollowKnight.DebugMod/releases/download...

also .72?

vocal spire Jun 25, 2021, 4:04 PM

#

Game ver

#

1.5.72.numbers

jolly jungle Jun 25, 2021, 4:04 PM

#

yeah I know

#

I asked if debug is also that

vocal spire Jun 25, 2021, 4:04 PM

#

Oh

jolly jungle Jun 25, 2021, 4:04 PM

#

I dont see a reason it wouldnt

light zodiac Jun 25, 2021, 4:04 PM

#

jolly jungle also .72?

Yes

jolly jungle Jun 25, 2021, 4:04 PM

#

but still wanted to ask

#

Thanks

vocal spire Jun 25, 2021, 4:04 PM

#

jolly jungle How do I make isTrue act like isFalse? I tried sendevent but it doesn't fit

Thing.isTrue = thing.isFalse

jolly jungle Jun 25, 2021, 4:09 PM

#

I guess that'll work?

#

Thanks

jolly jungle Jun 25, 2021, 4:14 PM

#

vocal spire Thing.isTrue = thing.isFalse

In general, what type are isTrue and isFalse in here

vocal spire Jun 25, 2021, 4:34 PM

#

jolly jungle In general, what type are isTrue and isFalse in here

FsmEvent, also you can look yourself with dnspy or just in your ide

primal latch Jun 25, 2021, 4:56 PM

#

Where are the change notes for the 1.5 beta branch?

charred topaz Jun 25, 2021, 5:25 PM

#

Am I doing something wrong that's causing the "defeatedNightmareGrimm" and "killedNightmareGrimm" values to continue to return True?

primal latch Jun 25, 2021, 5:37 PM

#

IDK, but instead of bull you should return orig

jolly oriole Jun 25, 2021, 5:38 PM

#

not in the new hooks

charred topaz Jun 25, 2021, 5:40 PM

#

Nvm, there was another function hook overriding it completely

copper nacelle Jun 25, 2021, 7:23 PM

#

happens

copper nacelle Jun 25, 2021, 7:24 PM

#

primal latch IDK, but instead of bull you should return orig

bro you return null if you're not changing it

jolly oriole Jun 25, 2021, 7:29 PM

#

yeah, have you not looked at the docs for it that are only in some doc strings or xml files or whatever

copper nacelle Jun 25, 2021, 7:30 PM

#

bro

#

the doc strings get put into vs

jolly oriole Jun 25, 2021, 7:31 PM

#

i have no idea where that would be displayed tbh

copper nacelle Jun 25, 2021, 7:32 PM

#

x5fiftAleph

#

bro even dnspy shows the xml docs

jolly oriole Jun 25, 2021, 7:33 PM

#

looking at some text when autocompleting functions 🙄

copper nacelle Jun 25, 2021, 7:33 PM

#

this sounds like a you problem

#

I should setup docfx

#

So much effort

#

I should also update the ci

#

Also effort

jolly oriole Jun 25, 2021, 7:36 PM

#

docfx sounds like automated wiki for functions and stuff, nice if it is

copper nacelle Jun 25, 2021, 7:36 PM

#

yeah it's just display xml doc in html

rough pulsar Jun 25, 2021, 7:39 PM

#

copper nacelle bro even dnspy shows the xml docs

what

#

i never ever knew that before

copper nacelle Jun 25, 2021, 7:40 PM

#

they do be part of the assembly

fair rampart Jun 25, 2021, 8:08 PM

#

after updating I have only this error

#

y is no one answering me 😦

light zodiac Jun 25, 2021, 8:09 PM

#

The language.gethook signature got changed

#

Right click and click on create overload function

#

And then make your old function work with new signatur

fair rampart Jun 25, 2021, 8:18 PM

#

sorry my visual studio is not showing "create overload function"

light zodiac Jun 25, 2021, 8:20 PM

#

Then comment out the current LangGet function and let Vs make the function with correct signature

fair rampart Jun 25, 2021, 8:34 PM

#

ok but now it's a different method from before

#

#

before it was returning String

light zodiac Jun 25, 2021, 8:35 PM

#

Make "Res = " what you want to change text to and return whether you want to change it or not

#

So something like case "HORNET_MAIN":
Res = "Hornet";
Return true;

copper nacelle Jun 25, 2021, 8:36 PM

#

res = key switch {
    "A" => "amogus",
    _ => null
};

return res is null;

#

maybe nullable was better

#

are null strings used though

jolly oriole Jun 25, 2021, 8:37 PM

#

copper nacelle yeah it's just display xml doc in html

it's likely possible that one can make repo wiki automatically using both that and https://github.com/marketplace/actions/publish-to-github-wiki

#

but not sure

fair rampart Jun 25, 2021, 8:43 PM

#

thanks Mul and 56 now is working as before

fickle sparrow Jun 25, 2021, 8:53 PM

#

I doubt null strings are used at all

#

like the game would probably die

jolly oriole Jun 25, 2021, 8:57 PM

#

i know that null variables are definetly used

copper nacelle Jun 25, 2021, 8:57 PM

#

alright so tryget it is

lone rune Jun 25, 2021, 9:36 PM

#

does anyone here know the fury cyclone slash damage values?

brisk knot Jun 25, 2021, 9:50 PM

#

Could this help?

copper nacelle Jun 25, 2021, 9:50 PM

#

no they want the patched values

#

for that wiki you just took values from

#

lmfao

brisk knot Jun 25, 2021, 9:51 PM

#

lol, sry

copper nacelle Jun 25, 2021, 9:51 PM

#

lone rune does anyone here know the fury cyclone slash damage values?

#archived-modding-development message api/debug if you want to test yourself fwiw

jolly oriole Jun 25, 2021, 9:52 PM

#

lone rune does anyone here know the fury cyclone slash damage values?

oh no, not this again
code to set the damage to 1x+strength still exists, but until i can test it with a mapi (too lazy lmao) i'll say that .71 had it back to 1432 behaviour (1.25x+fury)

lone rune Jun 25, 2021, 10:13 PM

#

copper nacelle https://discord.com/channels/283467363729408000/327461802311155714/8580144334556...

thanks, I'll look into this

lone rune Jun 25, 2021, 10:15 PM

#

jolly oriole oh no, not this again code to set the damage to 1x+strength still exists, but un...

alright thanks, good to have this confirmed. I was mainly unsure about the way fury damage is calculated for cyclone slash. I don't remember how we got the damage values for fury + great slash/dash slash

jolly oriole Jun 25, 2021, 10:16 PM

#

that is btw not info for the newest release (.72)

lone rune Jun 25, 2021, 10:17 PM

#

did something get messed up there again

jolly oriole Jun 25, 2021, 10:18 PM

#

i just didn't look at it

lone rune Jun 25, 2021, 10:18 PM

#

oh ok, I'll just assume it's the same as .71 for now

charred topaz Jun 25, 2021, 11:03 PM

#

I have a compiled version of the mapi built against the current hollow knight version if you want to use it: https://drive.google.com/file/d/1qIkfiN1oUqpzODTBFcdlbfj0Gr1l-bl7/view?usp=drivesdk

Google Docs

OutputFinal.zip

#

I also made some quick direct ports of Debug Mod, ModCommon, and InfiniteGrimm that should also be functional https://drive.google.com/drive/folders/1rOOkoOGWApqKFeLfdi5-vVFHGqlK9QmM

light zodiac Jun 26, 2021, 5:39 AM

#

Which debug did you build?

floral blade Jun 26, 2021, 12:32 PM

#

anyone else getting this on latest HK with mapi ?

[Position out of bounds!]

Obtained 21 stack frames.
#0  0x007fff6c6be33a in __pthread_kill
#1  0x007fff6c5d593e in raise
#2  0x000001061fe461 in operator delete[](void*, std::nothrow_t const&)
#3  0x000001061febac in operator delete[](void*, std::nothrow_t const&)
...```

#

if i verify integrity it works, but readding mapi seems to break it again

#

nvm i didn't update my vanilla folder and i guess even the pre-release is on the older 1.5 build tamershrug

jolly oriole Jun 26, 2021, 12:40 PM

#

...

#

it's titled 'v1.5.68.11808-61'

floral blade Jun 26, 2021, 12:46 PM

#

yes i didn't think that it would matter since the major version didn't change

light zodiac Jun 26, 2021, 12:57 PM

#

#archived-modding-development message

#

Use this mapi

floral blade Jun 26, 2021, 12:59 PM

#

ty, i built it with the new Vanilla folder and it works now

jolly oriole Jun 26, 2021, 3:43 PM

#

i made a very small dll file, just 1.5 KB

#

it contains exactly nothing

#

leak

📎 PaleCourt.dll

patent zealot Jun 26, 2021, 3:47 PM

#

pog

light zodiac Jun 26, 2021, 3:48 PM

#

@ modding staff sfg is sending viruses

#

pls protect us

ornate rivet Jun 26, 2021, 3:49 PM

#

nooooooooooooooooooooooooooooo

#

wow I missed Sumwan being here

vocal spire Jun 26, 2021, 3:50 PM

#

🤔

primal latch Jun 26, 2021, 4:06 PM

#

jolly oriole i made a *very* small dll file, just 1.5 KB

What did you do?

jolly oriole Jun 26, 2021, 4:07 PM

#

i ilasm'ed the following:

//test

primal latch Jun 26, 2021, 4:07 PM

#

Ah

#

Why?

#

Do you want to write it in il?

jolly oriole Jun 26, 2021, 4:07 PM

#

it didn't want to work with exactly nothing

#

nah, just because i thought why not

primal latch Jun 26, 2021, 4:08 PM

#

Ok

#

Fair enough

charred topaz Jun 26, 2021, 5:22 PM

#

light zodiac Which debug did you build?

Ok, I may have ported an older version of Debug Mod without looking at some of the other forks first 🥴 . Plus it looks like you already made a port so I can just use yours.

jolly oriole Jun 26, 2021, 5:41 PM

#

why are JsonNet, docs & override folders needed
could put the additional dlls from jsonnet n override in a folder called binaries or libs or something
the docs could be moved to the wiki or the apidocs repo

copper nacelle Jun 26, 2021, 5:48 PM

#

true

floral blade Jun 26, 2021, 5:51 PM

#

who is this weird Q person

#

definitely not >55

primal latch Jun 26, 2021, 6:55 PM

#

cil has some funny optimizations that you can apply. For example: you can load arg 1 by ldarg.0 if you need to load it twice immediately after eachother you can also load it once and use the dup opcode. This saves a few CPU cycles

jolly oriole Jun 26, 2021, 7:28 PM

#

hk playcount checker hotdogHotdog

📎 HkPlayCountCheck.exe

light zodiac Jun 26, 2021, 7:31 PM

#

1357

jolly oriole Jun 26, 2021, 7:34 PM

#

rookie numbers

floral blade Jun 26, 2021, 7:35 PM

#

jolly oriole hk playcount checker <:hotdogHotdog:676965312792494101>

sadness in macness grubsad

patent zealot Jun 26, 2021, 7:41 PM

#

close

jolly oriole Jun 26, 2021, 7:43 PM

#

works better

📎 HkPlayCountCheck.exe

primal latch Jun 26, 2021, 8:00 PM

#

How did you make that?

#

How does it work?

#

And is it coded in cil?

#

That last one is the most important

jolly oriole Jun 26, 2021, 8:02 PM

#

it checks registry entries

copper nacelle Jun 26, 2021, 8:03 PM

#

cil kinda slow bro

#

not writing it in assembly smh

jolly oriole Jun 26, 2021, 8:03 PM

#

i have an ASIC for it

copper nacelle Jun 26, 2021, 8:03 PM

#

lmao

primal latch Jun 26, 2021, 8:04 PM

#

copper nacelle cil kinda slow bro

Why? You can make it faster then c#

copper nacelle Jun 26, 2021, 8:04 PM

#

ok and

primal latch Jun 26, 2021, 8:04 PM

#

Then why is it slow?

copper nacelle Jun 26, 2021, 8:04 PM

#

you can make assembly faster than c#

#

what's your point

safe hamlet Jun 26, 2021, 8:06 PM

#

ah yes let me make my life horrible to get speed that doesn't even matter by using cil

copper nacelle Jun 26, 2021, 8:06 PM

#

if you want speed just use unsafe

#

and Unsafe

safe hamlet Jun 26, 2021, 8:06 PM

#

and crash the runtime

copper nacelle Jun 26, 2021, 8:06 PM

#

true

#

I mean string uses it 😤

safe hamlet Jun 26, 2021, 8:07 PM

#

i mean almost everything under the hood uses unsafe and some fucked shit

copper nacelle Jun 26, 2021, 8:07 PM

#

it's the tech

primal latch Jun 26, 2021, 8:07 PM

#

copper nacelle you can make assembly faster than c#

Probably not if you have to integrate it in c#

copper nacelle Jun 26, 2021, 8:08 PM

#

what

safe hamlet Jun 26, 2021, 8:08 PM

#

palehmm

#

what does this even mean

copper nacelle Jun 26, 2021, 8:08 PM

#

impressive levels of pepega

primal latch Jun 26, 2021, 8:09 PM

#

Well, an assembly is just a set of instructions. No types or functions defined. You would have to come up with a way to be able to make it interact with c#

copper nacelle Jun 26, 2021, 8:09 PM

#

yeah you just declare an extern function

#

Not difficult

#

Or use an unmanaged function pointer

primal latch Jun 26, 2021, 8:09 PM

#

But assembly doesn’t know functions

safe hamlet Jun 26, 2021, 8:09 PM

#

palehmm

primal latch Jun 26, 2021, 8:10 PM

#

It only knows jump points

#

It also doesn’t know variables

#

Only memory

#

And opcodes

safe hamlet Jun 26, 2021, 8:10 PM

#

ok and? i don't see your point about it being slow

primal latch Jun 26, 2021, 8:11 PM

#

You would have to write systems to integrate all of that into assembly. That will probably make it slower then using the out of the box support of cil

copper nacelle Jun 26, 2021, 8:11 PM

#

functions are just jump points + a calling convention

safe hamlet Jun 26, 2021, 8:11 PM

#

this

#

literally nothing special about it, you can write something in pure assembly and have it extern the function

#

which you can use in your c# code

copper nacelle Jun 26, 2021, 8:19 PM

#

you do know cil JITs into assembly yeah?

primal latch Jun 26, 2021, 8:20 PM

#

I know

#

all code is at some point converted into assembly

dark wigeon Jun 26, 2021, 8:21 PM

#

have you heard of interpreted languages

primal latch Jun 26, 2021, 8:28 PM

#

yes

#

still technically converted to assembly

jolly oriole Jun 26, 2021, 8:31 PM

#

56 make hk in assembly so i can get 3k+ fps 😤

fickle sparrow Jun 26, 2021, 8:31 PM

#

nah you'd get more frames if playmaker was actually good

#

ax1uWide3

copper nacelle Jun 26, 2021, 8:31 PM

#

that's true

#

it's so bad

jolly oriole Jun 26, 2021, 8:35 PM

#

ok, make playmaker in assembly

jolly oriole Jun 26, 2021, 8:54 PM

#

56

#

yo did that benchmark at some point, right?

#

what was the most intensive thing again?

#

found it

sweet gust Jun 26, 2021, 9:14 PM

#

how do i get the point mod

dark wigeon Jun 26, 2021, 9:34 PM

#

primal latch still technically converted to assembly

uh no? it's not converted to assembly, that would be jit/aot

#

even then it's compiled to machine code not assembly if you want to be really technical

copper nacelle Jun 27, 2021, 2:19 AM

#

unlucky

#

i have also wiped windows though

primal latch Jun 27, 2021, 5:48 AM

#

dark wigeon even then it's compiled to machine code not assembly if you want to be really te...

True

primal latch Jun 27, 2021, 5:48 AM

#

dark wigeon uh no? it's not converted to assembly, that would be jit/aot

The difference between jit and interpreted is that jit first compiles into and intermediate language

tawny onyx Jun 27, 2021, 6:41 AM

#

i re-install system recently

primal latch Jun 27, 2021, 7:44 AM

#

Why is there even a registry entry for the amount of times you opened HK?

eager meadow Jun 27, 2021, 9:56 AM

#

the modinstaller still haven't get a new uptade right?

jolly jungle Jun 27, 2021, 9:58 AM

#

When it'll get an uptade you'll probably hear about it

cedar hemlock Jun 27, 2021, 10:00 AM

#

have patience, when it gets updated the pinned message in #archived-modding-help will change

jolly oriole Jun 27, 2021, 10:48 AM

#

primal latch Why is there even a registry entry for the amount of times you opened HK?

Ask unity

marble hollow Jun 27, 2021, 11:35 AM

#

oh shit my real name

#

i feel inferior

jolly oriole Jun 27, 2021, 11:35 AM

#

dw, you're not the first one to dox yourself with a screenshot of that lol

marble hollow Jun 27, 2021, 11:35 AM

#

ahah

#

tbh i dont care if my name got leaked i just dont like my irl name that much

jolly oriole Jun 27, 2021, 11:36 AM

#

fair

#

but nice, nearly triple digits

cedar hemlock Jun 27, 2021, 11:39 AM

#

ah i got 558 times

#

why so much..?

jolly oriole Jun 27, 2021, 11:39 AM

#

1.5.72 modded w/ debug unpause glitches <#822831192150638643 message>

light zodiac Jun 27, 2021, 11:43 AM

#

I'm dumb

#

It's my mistake

jolly oriole Jun 27, 2021, 11:45 AM

#

ah ok

light zodiac Jun 27, 2021, 11:45 AM

#

Full fix here
https://github.com/TheMulhima/HollowKnight.DebugMod/releases/download/v1.4.1/DebugMod.dll

rough pulsar Jun 27, 2021, 11:59 AM

#

copper nacelle unlucky

where can i find this

#

ples

light zodiac Jun 27, 2021, 12:01 PM

#

jolly oriole works better

Here

rough pulsar Jun 27, 2021, 12:01 PM

#

Awesome

floral blade Jun 27, 2021, 12:05 PM

#

jolly oriole Jun 27, 2021, 12:05 PM

#

pog

floral blade Jun 27, 2021, 12:05 PM

#

is this what the checker also gets ?

light zodiac Jun 27, 2021, 12:06 PM

#

Yes

jolly oriole Jun 27, 2021, 12:06 PM

#

would if i made it work on mac

floral blade Jun 27, 2021, 12:06 PM

#

alright

rough pulsar Jun 27, 2021, 12:06 PM

#

what

dark wigeon Jun 27, 2021, 2:35 PM

#

primal latch The difference between jit and interpreted is that jit first compiles into and i...

this is wrong again, interpreted can actually have its own intermediate language like python. my point is that python never converts this to machine code. never. jit converts intermediate to machine code. python just runs the intermediate language in c written to handle each instruction.
the program is never converted to machine code, only the interpreter is

jolly oriole Jun 27, 2021, 3:31 PM

#

mods too fast

eager meadow Jun 27, 2021, 5:34 PM

#

@cedar hemlock ok thanks

cedar hemlock Jun 27, 2021, 5:34 PM

#

:+1: ig

vocal spire Jun 27, 2021, 6:13 PM

#

<@&283547423706447872>

#

Well

#

You’re extremely fast

glossy olive Jun 27, 2021, 6:13 PM

#

Thanks for ping

#

Nah they did it in other channels

vocal spire Jun 27, 2021, 6:14 PM

#

Ah ok

jolly oriole Jun 27, 2021, 6:16 PM

#

oh damn, doing that with a 2 year old account

meager herald Jun 27, 2021, 6:21 PM

#

probly got hacked bc idiot clicked link

ornate rivet Jun 27, 2021, 6:36 PM

#

dang hadn't blocked this mod

nimble lake Jun 27, 2021, 6:39 PM

#

ayy wtf

jolly oriole Jun 27, 2021, 6:39 PM

#

nice

jolly jungle Jun 27, 2021, 6:51 PM

#

nimble lake ayy wtf

lucky

light zodiac Jun 27, 2021, 6:51 PM

#

how much do you have

nimble lake Jun 27, 2021, 6:52 PM

#

hours?

#

725

nimble lake Jun 27, 2021, 6:53 PM

#

jolly jungle lucky

maybe i should try to predict ss release date now

copper nacelle Jun 27, 2021, 6:59 PM

#

smh

nimble lake Jun 27, 2021, 7:04 PM

#

no that doesn't count

primal latch Jun 27, 2021, 7:27 PM

#

@vocal spire what happened?

vocal spire Jun 27, 2021, 7:40 PM

#

primal latch <@!566029907264667657> what happened?

usual scam "leaving CSGO, trade with me here" message

vocal spire Jun 27, 2021, 8:57 PM

#

idk if dnspy is just looking at the wrong assembly, but it's really looking to me like somebody forgot to update this constructor.

public FsmTransition(FsmTransition source)
        {
            this.fsmEvent = source.FsmEvent;
            this.toState = source.toState;
            this.linkStyle = source.linkStyle;
            this.linkConstraint = source.linkConstraint;
            this.colorIndex = source.colorIndex;
        }```

#

thank you old constructor for wasting my time

jolly oriole Jun 27, 2021, 9:02 PM

#

nice

#

@ 56, while you remake playmaker, also fix this ples

copper nacelle Jun 27, 2021, 9:58 PM

#

bruh

jolly oriole Jun 27, 2021, 9:59 PM

#

are mdbs another form of pdbs?

#

sounds mobile, but p sounds portable

copper nacelle Jun 27, 2021, 9:59 PM

#

they're the ones which work with unity

jolly oriole Jun 27, 2021, 9:59 PM

#

ah

#

but the problem with debugging dynamic on things is still a thing, right?

copper nacelle Jun 27, 2021, 10:01 PM

#

what problem

jolly oriole Jun 27, 2021, 10:01 PM

#

i heard several times that debugging on hooks is not a good idea

copper nacelle Jun 27, 2021, 10:01 PM

#

ah

#

yeah

#

don't do that

jolly oriole Jun 27, 2021, 10:02 PM

#

sad

copper nacelle Jun 27, 2021, 10:02 PM

#

wouldn't exactly mind line numbers for unity stuff though you get me

#

or the docs actually working in my fucking ide

#

i should've done this earlier

jolly oriole Jun 27, 2021, 10:02 PM

#

imagine looking at line numbers

copper nacelle Jun 27, 2021, 10:02 PM

#

so much nicer

#

i was wondering why that was broken

jolly oriole Jun 27, 2021, 10:03 PM

#

which ide is that

copper nacelle Jun 27, 2021, 10:03 PM

#

rider

jolly oriole Jun 27, 2021, 10:03 PM

#

could be done on vs with https://docs.microsoft.com/en-us/visualstudio/gamedev/unity/get-started/using-visual-studio-tools-for-unity?pivots=windows probably

copper nacelle Jun 27, 2021, 10:04 PM

#

no it's just missing the xml

#

cause we ref the game dlls

jolly oriole Jun 27, 2021, 10:04 PM

#

oh yea

copper nacelle Jun 27, 2021, 10:04 PM

#

you can just take them from the editor

#

and then your ide is actually functional

#

amazing stuff

jolly oriole Jun 27, 2021, 10:04 PM

#

you need them or already did?

copper nacelle Jun 27, 2021, 10:04 PM

#

i got em

jolly oriole Jun 27, 2021, 10:05 PM

#

thumbsup_tm

copper nacelle Jun 27, 2021, 10:05 PM

#

if anyone else wants them

📎 xmls.zip