#archived-modding-development | Hollow Knight | Page 521

copper nacelle Jun 14, 2021, 8:13 PM

#

did you check player.log

jolly jungle Jun 14, 2021, 8:14 PM

#

This time only one of them froze

jolly jungle Jun 14, 2021, 8:14 PM

#

copper nacelle did you check player.log

Nope, what am I supposed to look for?

copper nacelle Jun 14, 2021, 8:17 PM

#

bruh

#

exceptions

jolly jungle Jun 14, 2021, 8:17 PM

#

Oh ok

#

I'm not sure how exceptions are meant to look

#

But there's no mention of the word exception there

#

Nothing there really seems exceptional, no pun intended

#

Though not sure how much of a pun it is, they're the same word and mean the same general thing

copper nacelle Jun 14, 2021, 8:21 PM

#

did you remove the trigger2devent one

#

I cba opening things

#

hate me

jolly jungle Jun 14, 2021, 8:26 PM

#

copper nacelle did you remove the trigger2devent one

yep

#

Is there something wrong with that?

copper nacelle Jun 14, 2021, 8:27 PM

#

show me all the actions imo

jolly jungle Jun 14, 2021, 8:27 PM

#

I tried removing the transition NAIL but couldn't figure it all

jolly jungle Jun 14, 2021, 8:27 PM

#

copper nacelle show me all the actions imo

wdym?

copper nacelle Jun 14, 2021, 8:28 PM

#

take a picture

#

I don't want to get out of bed

#

So much effort

jolly jungle Jun 14, 2021, 8:28 PM

#

No I mean

#

A picture of what

#

My code or the fsm or?

copper nacelle Jun 14, 2021, 8:28 PM

#

the fsm state you're fucking with

jolly jungle Jun 14, 2021, 8:29 PM

#

copper nacelle Jun 14, 2021, 8:29 PM

#

why would you remove the third one

jolly jungle Jun 14, 2021, 8:30 PM

#

Third one is nail attack no?

copper nacelle Jun 14, 2021, 8:30 PM

#

mrw 4

jolly jungle Jun 14, 2021, 8:30 PM

#

I mean, otehr than freezing it does what I want

copper nacelle Jun 14, 2021, 8:30 PM

#

index is 3 if that's what you're talking about

jolly jungle Jun 14, 2021, 8:30 PM

#

the attack isn't deflectable

jolly jungle Jun 14, 2021, 8:30 PM

#

copper nacelle index is 3 if that's what you're talking about

yea

#

I just want to make it so the blade can't be hit back

copper nacelle Jun 14, 2021, 8:32 PM

#

would it not be nicer to just remove the velocity change so you still get the impact tink

jolly jungle Jun 14, 2021, 8:32 PM

#

This worked, but for some reason all the sturdy fools freeze at one point or another

jolly jungle Jun 14, 2021, 8:32 PM

#

copper nacelle would it not be nicer to just remove the velocity change so you still get the im...

I guess?

#

I'll need to remove the damage too I guess

#

won't be a problem tho

#

Aight I'll just do it like that I suppose

#

I just need to remove this action, right?

#

Not mess with it in any way

#

only remove it

copper nacelle Jun 14, 2021, 8:35 PM

#

yeah

jolly jungle Jun 14, 2021, 8:37 PM

#

That would change the index of the other actions, right/

#

?

copper nacelle Jun 14, 2021, 8:38 PM

#

yes

#

it do be an array

jolly jungle Jun 14, 2021, 8:38 PM

#

Aight thanks

#

Welp the fool still freezes

#

it might be unrelated

#

but I dunno what else it couldve been

copper nacelle Jun 14, 2021, 8:43 PM

#

comment out everything else

jolly jungle Jun 14, 2021, 8:50 PM

#

Yep, the fool froze

#

So it's this

#

Somehow

#

Welp I gtg

#

I'll have to continue this some other time

ornate rivet Jun 15, 2021, 12:20 AM

#

Where do I get UnityEngine.AddressableAssets from? I can't find it in the hk managed folder.

charred topaz Jun 15, 2021, 1:06 AM

#

ornate rivet Where do I get UnityEngine.AddressableAssets from? I can't find it in the hk man...

Wouldn’t that be part of a separate Unity Package called the “Addressable Asset System”? I don’t think HK is using that package

ornate rivet Jun 15, 2021, 1:20 AM

#

is there somewhere else I can get that package?

dark wigeon Jun 15, 2021, 1:24 AM

#

yep you gotta get it from the unity package manager

ornate rivet Jun 15, 2021, 1:24 AM

#

yea I got it but where does the dll go?

dark wigeon Jun 15, 2021, 1:24 AM

#

somewhere

#

its in managed when you build at least

#

I think

#

never tried to add it into a game without yet

ornate rivet Jun 15, 2021, 1:26 AM

#

ok thanks

#

should I replace the assetbundles I use in my mod with addressables?

#

or am I misunderstanding what addessables are for/there's no reason to do it?

dark wigeon Jun 15, 2021, 1:32 AM

#

addressables are bundles under the hood

#

it's basically just an assetbundle manager

ornate rivet Jun 15, 2021, 1:36 AM

#

ok thanks

dark wigeon Jun 15, 2021, 2:37 AM

#

can you send me these bundles

charred topaz Jun 15, 2021, 2:59 AM

#

dark wigeon can you send me these bundles

Yep, should be here https://drive.google.com/drive/folders/15xY_1JeOwofDrGfBQLvt8BGtmCntRjb6

dark wigeon Jun 15, 2021, 3:01 AM

#

charred topaz Yep, should be here https://drive.google.com/drive/folders/15xY_1JeOwofDrGfBQLvt...

what about library/scriptassemblies

charred topaz Jun 15, 2021, 3:03 AM

#

dark wigeon what about library/scriptassemblies

That I don’t have available right now. I can send you that too when I get home from work within the next hour or so when I have access to my computer

dark wigeon Jun 15, 2021, 3:06 AM

#

nvm you have typetrees

#

you don't need dlls

#

with your code I get this

#

where I set the mod name to tomato

#

📎 code.cs

charred topaz Jun 15, 2021, 3:39 AM

#

dark wigeon with your code I get this

So I didn’t need to use MonoDeserializer? I can try that out later and see if it works

dark wigeon Jun 15, 2021, 3:40 AM

#

not for bundles usually

#

I just forgot about that being a thing

light zodiac Jun 15, 2021, 4:54 AM

#

<@&283547423706447872> spammer

floral furnace Jun 15, 2021, 4:54 AM

#

uhuh

copper nacelle Jun 15, 2021, 4:55 AM

#

snail emoji

#

Re-did the Get/Set<T> and LanguageGet hooks fwiw, should be a much nicer api now

#

also broke every mod while I'm at it so you should get the new one

jolly oriole Jun 15, 2021, 5:06 AM

#

copper nacelle also broke every mod while I'm at it so you should get the new one

Poggers

charred topaz Jun 15, 2021, 5:15 AM

#

dark wigeon

Was able to test it out, and it works great! One small issue I'm running into is that one specific MonoBehaviour seems to be throwing an Out Of Memory Exception when making the call to GetTypeInstance(). Not sure what it is, but I am able to just skip over it and it still works. Might be one of the large animation Object I also have bundled, and it could be too large for it to handle?

dark wigeon Jun 15, 2021, 5:16 AM

#

size shouldn't matter unless the asset is like over 100mb

#

but I tested on your bundle and there were no errors

#

so maybe your library version is too old or something? not sure why you would be getting different results

charred topaz Jun 15, 2021, 5:17 AM

#

Wait, just noticed the error is with the WeaverCore bundle

dark wigeon Jun 15, 2021, 5:17 AM

#

o

#

well you can send it to me

#

see if I can get the exception

charred topaz Jun 15, 2021, 5:19 AM

#

ok

#

Might be any one of these

#

Uploaded WeaverCore, you can find it in the StandaloneWindows folder
https://drive.google.com/drive/folders/15xY_1JeOwofDrGfBQLvt8BGtmCntRjb6?usp=sharing

dark wigeon Jun 15, 2021, 5:24 AM

#

pathid -3242457742616307400

#

id 0x72 called MonoScript 🤔

charred topaz Jun 15, 2021, 5:26 AM

#

I can't seem to find it in UABE

charred topaz Jun 15, 2021, 5:29 AM

#

dark wigeon id 0x72 called MonoScript 🤔

Found it. Not sure why this one is the culprit

dark wigeon Jun 15, 2021, 5:29 AM

#

charred topaz Jun 15, 2021, 5:29 AM

#

huh?

dark wigeon Jun 15, 2021, 5:29 AM

#

yours looks different 🤔

charred topaz Jun 15, 2021, 5:30 AM

#

should be the same thing I sent you

dark wigeon Jun 15, 2021, 5:30 AM

#

mine is saying it's a monoscript but yours says it's a monobehaviour

charred topaz Jun 15, 2021, 5:30 AM

#

I'll redownload the bundle I sent you to double check

dark wigeon Jun 15, 2021, 5:30 AM

#

I meant your screenshot, probably an older version of uabea

charred topaz Jun 15, 2021, 5:32 AM

#

I'll try it out with the nightly build of UABE

#

Same bundle viewed in nightly UABE, now looks like yours

dark wigeon Jun 15, 2021, 5:37 AM

#

is weavercore settings a scriptable object?

charred topaz Jun 15, 2021, 5:39 AM

#

I found the source of the problem. It's a scriptable object with a missing monoscript

dark wigeon Jun 15, 2021, 5:40 AM

#

yep that will do it

#

this whole time I've been assuming that unity would never let the script be null

charred topaz Jun 15, 2021, 5:43 AM

#

I find that happens whenever a script file gets renamed or deleted

#

The build now went from two OutOfMemory errors to one, so I have another one somewhere.

#

How do you get the path ID of a Monobehaviour in AssetTools? I'm still getting an OutOfMemory Exception for an asset and was going to try and search it up in UABE

dark wigeon Jun 15, 2021, 5:57 AM

#

not sure what you mean

#

like given a name get a path id?

charred topaz Jun 15, 2021, 5:59 AM

#

dark wigeon `pathid -3242457742616307400`

I was wondering how you found the path id of one of the sus assets, like this one

dark wigeon Jun 15, 2021, 6:00 AM

#

let assetstools crash on a command line program, walk up stacktrace, mouse over the info of the asset it was reading

#

or you could try catch and log which asset it was reading at that time

#

well that's not good

#

it will break on any scriptableobject

charred topaz Jun 15, 2021, 6:11 AM

#

dark wigeon or you could try catch and log which asset it was reading at that time

I found the other sus file, but this one doesn't even give a name of the asset this time

dark wigeon Jun 15, 2021, 6:11 AM

#

use this instead

📎 AssetsTools.NET.7z

#

somehow I made a stupid bug where scriptable objects will read from monobehaviour data instead

#

it's been there for like years

charred topaz Jun 15, 2021, 6:18 AM

#

dark wigeon use this instead

Seems to be fixed! I'm not getting any exceptions in the logs grublove

dark wigeon Jun 15, 2021, 6:18 AM

#

yayyyy

#

now time to go beat myself up

dark wigeon Jun 15, 2021, 7:00 AM

#

well oof me

#

that broke everything but monobehaviours

#

if you run into more issues

📎 AssetsTools.NET.7z

light zodiac Jun 15, 2021, 9:24 AM

#

What am I supposed to return when I use LanguageGetHook

#

Nvm

dark wigeon Jun 15, 2021, 5:37 PM

#

@jolly oriole @vocal spire @jolly jungle @primal latch going to start stream in 30 minutes unless now is a bad time

jolly jungle Jun 15, 2021, 5:37 PM

#

Epic

jolly oriole Jun 15, 2021, 5:37 PM

#

samping

jolly jungle Jun 15, 2021, 5:37 PM

#

Ahahaaa

dark wigeon Jun 15, 2021, 5:38 PM

#

ha

jolly jungle Jun 15, 2021, 5:38 PM

#

I knew you'll do that grenade

dark wigeon Jun 15, 2021, 5:38 PM

#

that's what you get for saying "i'd watch"

jolly jungle Jun 15, 2021, 5:38 PM

#

I thought of adding hornetping for you but decided not to cuz I myself don't mind

jolly oriole Jun 15, 2021, 5:38 PM

#

i have more of those emotes, thanks to free nitro from epic

dark wigeon Jun 15, 2021, 5:38 PM

#

only new subs 😢

jolly jungle Jun 15, 2021, 5:38 PM

#

That sounds like a promo for epic

dark wigeon Jun 15, 2021, 5:38 PM

#

my free year ran out a while ago

jolly jungle Jun 15, 2021, 5:39 PM

#

I'm reading it in a salesman voice in an ad from 20 years ago

jolly jungle Jun 15, 2021, 5:39 PM

#

dark wigeon my free year ran out a while ago

Free year?

#

When the hell'd they give that much away

dark wigeon Jun 15, 2021, 5:39 PM

#

discord hackathon

jolly jungle Jun 15, 2021, 5:40 PM

#

Ohhh, cool

#

Never heard of it but sounds hard

primal latch Jun 15, 2021, 5:41 PM

#

dark wigeon <@!202560032712163329> <@!566029907264667657> <@!427473606725861397> <@!46010861...

Can’t watch. Sad. Good luck

dark wigeon Jun 15, 2021, 5:42 PM

#

I'll record it so y'all can see my stupidity later

primal latch Jun 15, 2021, 5:42 PM

#

Good luck

jolly oriole Jun 15, 2021, 5:43 PM

#

wait, where you gonna stream? twitch, yt or one of the VCs?

dark wigeon Jun 15, 2021, 5:43 PM

#

I have it set up for twitch

jolly oriole Jun 15, 2021, 5:43 PM

#

👍

dark wigeon Jun 15, 2021, 5:43 PM

#

if that's too hard then I can just use discord

#

twitch link is on my discord profile

vocal spire Jun 15, 2021, 6:05 PM

#

I’m here now

jolly jungle Jun 15, 2021, 6:07 PM

#

Sorry I'm late

#

Oooh nes any chance you can also add arrowheads to the lines between states? I know it always starts at an event and ends in a state's name but it'll be easier to read that way

jolly oriole Jun 15, 2021, 6:47 PM

#

why

📎 log.txt

#

ok, i got that part working, new problems arise

dark wigeon Jun 15, 2021, 6:57 PM

#

frick there was no mic audio

#

o well

#

chat should've said something

primal latch Jun 15, 2021, 7:43 PM

#

jolly oriole why

still working on appdomains?

jolly oriole Jun 15, 2021, 7:43 PM

#

yes

primal latch Jun 15, 2021, 7:43 PM

#

good luck

jolly oriole Jun 15, 2021, 7:46 PM

#

[ERROR]:[API] - Error: System.Runtime.Serialization.SerializationException: Type 'EnemyChanger.EnemyChanger' in Assembly 'EnemyChanger, Version=1.0.0.0, Culture=neutral, PublicKeyToken=723094b6adc0e8b9' is not marked as serializable.

oh my god

floral blade Jun 15, 2021, 7:58 PM

#

dark wigeon frick there was no mic audio

i thought it was intentional lol, plus i was on mobile web so i could not chat 😦

dark wigeon Jun 15, 2021, 8:15 PM

#

I figured that's why

#

at the beginning I was doing a lot of mouse circling

#

I turned on vods

jolly oriole Jun 15, 2021, 8:16 PM

#

i had it open while getting midly progress with appdomains

#

but fuck those

copper nacelle Jun 15, 2021, 8:17 PM

#

i just thought you were doing micless

dark wigeon Jun 15, 2021, 8:18 PM

#

I was explaining why not to code at 3am

#

nah windows totally ignored the mic plugged in, the mic was enabled in obs so I thought it was fine

copper nacelle Jun 15, 2021, 8:20 PM

#

FeelsInvertedMan

jolly oriole Jun 15, 2021, 8:20 PM

#

nice

ornate rivet Jun 15, 2021, 8:38 PM

#

I'm trying to fix the pink shaders but when I manually set the shaders in the editor myself to Unity's default shaders (and it looks fine in the editor), it looks even worse in-game.

#

I dont understand

jolly oriole Jun 15, 2021, 8:40 PM

#

afaik that's because the path_ids of the used materials are different for your assetbundles compared to HKs assetbundles

ornate rivet Jun 15, 2021, 8:41 PM

#

oh

#

how do I fix that?

#

manually set the shaders in code?

jolly oriole Jun 15, 2021, 8:42 PM

#

yes, though with 1.5 it should be possible (even for you) to attach scripts to gameobjects that automatically put the correct materials & shaders on the gameobjects you want (even with a bit optimization if the same material/shader is used instead of one for each go)

#

like how i do it with SFCores SpritePatcher

#

but that only reliably works with simple shaders, like sprites-default and -lit

patent zealot Jun 15, 2021, 9:03 PM

#

Having trouble with inserting the method into mawlek when it lands from a jump, does anything look wrong?

#

I put a log after a lot of it, and all the logs before the insert worked

#

and i cant see whats wrong with the insert

floral blade Jun 15, 2021, 10:53 PM

#

it was just not enough for me to have one

floral blade Jun 16, 2021, 12:51 AM

#

a smolknight update that works across hkmp (required on all clients to function properly)

#

i just need to fix my code a bit

edgy plover Jun 16, 2021, 2:24 AM

#

I can't speak English where I find the mods

#

please

nimble lake Jun 16, 2021, 3:32 AM

#

?mods

finite forumBOT Jun 16, 2021, 3:32 AM

#

Mods
Google Drive with Mods - https://drive.google.com/drive/u/0/folders/1lnjtSYMfRe1LyA_qSq2CoXKI6NRm_I-e
Installer - https://radiance.host/mods/ModInstaller.exe
Mod Summaries - https://docs.google.com/document/d/1cz5tcggpGofrBcM90XyTkMWjMelDHzugvQM6HpB13Ew

nimble lake Jun 16, 2021, 3:32 AM

#

@edgy plover

edgy plover Jun 16, 2021, 4:07 AM

#

thanks

primal latch Jun 16, 2021, 5:53 AM

#

Last night I was wondering: why do we help everyone with the same few problems if we can also fix them?

jolly jungle Jun 16, 2021, 6:44 AM

#

What do you mean

primal latch Jun 16, 2021, 6:50 AM

#

Like the issue with the mod installer or saves saying loading

merry lotus Jun 16, 2021, 6:52 AM

#

You'd have to find a way to implement a fix. Like, with the Benchwarp settings issue (saves saying "loading"), it seems that somehow the settings file has an issue being read, and resetting it fixes it. But the only alternative would be to somehow ensure that the settings file didn't have whatever the unknown issue is?

copper nacelle Jun 16, 2021, 6:53 AM

#

mrw the issue

#

descriptive

jolly oriole Jun 16, 2021, 7:25 AM

#

the issue

floral blade Jun 16, 2021, 8:02 AM

#

merry lotus You'd have to find a way to implement a fix. Like, with the Benchwarp settings i...

Or MI could have a button to reset it as a starter, and once we figure out what breaks mapi/ the mod could fix the file itself

#

Also just wondering, how do updates to MI get delivered to users?

#

In case the new modlinks update does not account for this, might I suggest a "tools" section that allows for MI / MI2 or any such tools to also update themselves ?

cedar hemlock Jun 16, 2021, 8:11 AM

#

When the modinstaller 1 got a update that broke updates, one of the symptoms was that a AU.exe popped up.

#

So, i assume tha AU.exe (likely AutoUpdater) updates the installer

steel bison Jun 16, 2021, 1:50 PM

#

Hello mo mod install does not work how I can do for it to work it tells me that it has not updated because of the shift hollow knight that took place recament

jolly oriole Jun 16, 2021, 1:50 PM

#

there's a help channel

steel bison Jun 16, 2021, 1:51 PM

#

thx

tawny agate Jun 16, 2021, 2:27 PM

#

Hi

#

Can someone replace all enemies with gorb?

vocal spire Jun 16, 2021, 2:55 PM

#

This is modding development

ornate rivet Jun 16, 2021, 2:58 PM

#

tawny agate Can someone replace all enemies with gorb?

Hi

#

I can replace your mom with gorb

tawny onyx Jun 16, 2021, 3:10 PM

#

https://github.com/DemoJameson/HollowKnight.HotReloadHelper

GitHub

DemoJameson/HollowKnight.HotReloadHelper

Provide hot reload feature for Hollow Knight's mod development - DemoJameson/HollowKnight.HotReloadHelper

#

anyone who have try this?

tawny agate Jun 16, 2021, 3:11 PM

#

tawny onyx anyone who have try this?

1 s t a r. S e e m s. G o o D.

tawny onyx Jun 16, 2021, 3:11 PM

#

ornate rivet Jun 16, 2021, 3:11 PM

#

woah

#

it works?

tawny onyx Jun 16, 2021, 3:11 PM

#

I found it just now

jolly jungle Jun 16, 2021, 3:13 PM

#

So...

#

If I understood correctly it allows you to load mods while the game is open?

ornate rivet Jun 16, 2021, 3:14 PM

#

reload them

jolly jungle Jun 16, 2021, 3:14 PM

#

Hm

copper nacelle Jun 16, 2021, 3:14 PM

#

call unload load assembly again hotkey

ornate rivet Jun 16, 2021, 3:14 PM

#

so you make a change to your mod then reload it

jolly jungle Jun 16, 2021, 3:14 PM

#

What's the difference?

ornate rivet Jun 16, 2021, 3:14 PM

#

bruh, you dont have to close and open the game every single time

jolly jungle Jun 16, 2021, 3:15 PM

#

Yeah I get that

#

I meant what's the difference between load and reload

ornate rivet Jun 16, 2021, 3:16 PM

#

I guess if you didn't load the mod when you opened the game

jolly oriole Jun 16, 2021, 3:25 PM

#

i mean, it's a start to get reloading of all mods and their content to work

#

currently that only does toggleable mods though

light zodiac Jun 16, 2021, 3:27 PM

#

Just make all the mods toggleable

#

Easy

tawny onyx Jun 16, 2021, 3:27 PM

#

i think it should try to pull preload objects again if changed

jolly oriole Jun 16, 2021, 3:30 PM

#

tawny onyx i think it should try to pull preload objects again if changed

i think you're trying to say that the game should just start with the preloading process again, but:

some objects from the game (e.g. GameCameras & GameManager are marked as DontDestroyOnLoad, so you'd have to manually find all of them and destroy them)
~~this brings us to the fact that you can't execute code without gameobjects~~ edit midway through writing: you can just have one not marked
but then what still remains are static changes (the static variables of some classes, be it modding classes or base game classes)

jolly jungle Jun 16, 2021, 3:34 PM

#

Alright so thanks to the power of commenting it seems almost definite that this piece of code is also what leads to the sturdy fools to freeze

_control.InsertMethod("Spawn Bullet L", 3, () => {
    _control.FsmVariables.GetFsmGameObject("Pickaxe").Value.LocateMyFSM("collide_with_wall").RemoveAction("Nail Hit", 1);
    _control.FsmVariables.GetFsmGameObject("Pickaxe").Value.LocateMyFSM("collide_with_wall").GetAction<SetFsmInt>("Nail Hit", 2).setValue = 0;
});
_control.InsertMethod("Spawn Bullet R", 2, () => {
    _control.FsmVariables.GetFsmGameObject("Pickaxe").Value.LocateMyFSM("collide_with_wall").RemoveAction("Nail Hit", 1);
    _control.FsmVariables.GetFsmGameObject("Pickaxe").Value.LocateMyFSM("collide_with_wall").GetAction<SetFsmInt>("Nail Hit", 2).setValue = 0;
});

If anyone has any idea how to accomplish this in a way that doesn't freeze them randomly please tell

#

(What I'm trying is to make their projectiles not deflectable)

#

Which works, but they also freeze randomly

jolly oriole Jun 16, 2021, 3:38 PM

#

where can i look at the fsm

jolly jungle Jun 16, 2021, 3:38 PM

#

Wdym

#

Which one?

jolly oriole Jun 16, 2021, 3:38 PM

#

which file to open to see the fsm of the sturdy fool

jolly jungle Jun 16, 2021, 3:38 PM

#

assets 32

tawny onyx Jun 16, 2021, 3:40 PM

#

nop, I mean to figure out the changed of a certain mod's objects preload requirements. and load them manually if API dosen't contain , and then add to API's preloaded GameObject dictionary. as for the usless preload gameobjcts, just keep them, dont destroy.
(the picture show is DJ's code, he havent concern a mod with preload objects)

jolly oriole Jun 16, 2021, 3:40 PM

#

jolly jungle assets 32

lol, just remove the action at index 3 of the In Air state, easier

jolly jungle Jun 16, 2021, 3:42 PM

#

I tried

#

That was the thing I tried before this

#

same effect

jolly oriole Jun 16, 2021, 3:48 PM

#

then just do

_control.GetAction<SpawnObjectFromGlobalPool>("Spawn Bullet L", 1).gameObject.LocateMyFSM("collide_with_wall").RemoveAction("In Air", 3);

after spawning it

#

though you may want to put it in a try... catch if you spawn multiple

#

or you do it once after preloading the enemy and then no more

jolly jungle Jun 16, 2021, 3:49 PM

#

Hm

#

Thanks, I'll try

#

Welp

#

Now it doesn't work at all

#

:/

#

_control.GetAction<SpawnObjectFromGlobalPool>("Spawn Bullet L", 1).gameObject.Value.LocateMyFSM("collide_with_wall").RemoveAction("In Air", 3);
_control.GetAction<SpawnObjectFromGlobalPool>("Spawn Bullet R", 0).gameObject.Value.LocateMyFSM("collide_with_wall").RemoveAction("In Air",3);

Did I mistype anything?

jolly oriole Jun 16, 2021, 4:04 PM

#

does it crash?

jolly jungle Jun 16, 2021, 4:18 PM

#

Nope

#

I meant, it doesn't do what I wanted

#

I'm assuming I just missed something

#

And changed the wrong thing somewhere

#

But no, it all seems fine in the code

jolly oriole Jun 16, 2021, 4:21 PM

#

hm :/

glossy pilot Jun 16, 2021, 5:01 PM

#

tawny onyx https://github.com/DemoJameson/HollowKnight.HotReloadHelper

it's pretty rough, just verifying that hot reloading works
hope ModdingAPI can have a similar feature, it doesn't need to be perfect as long as it can reduce the number of restarts of the game
or add a hotkey to restart the game and then restore the scene is enough

shrewd igloo Jun 16, 2021, 5:15 PM

#

Impressive DJ

shadow cedar Jun 17, 2021, 12:40 AM

#

Good evening fellow peeps. I'm making a custom knight skin and I was wondering if anyone knew which of sprites get cycled through for the "run" (the normal explore around the world walk) animation? I'm using the sprite packer and what I drew looks smooth but once in game it looks entirely different. Does the game pull a sprite from a different animation for a between frame or something?

proven plover Jun 17, 2021, 2:02 AM

#

Does anyone know how I could make a new spell for the game?

knotty monolith Jun 17, 2021, 2:33 AM

#

shadow cedar Good evening fellow peeps. I'm making a custom knight skin and I was wondering i...

It pulls from the 6th frame of the slash animation iirc

#

Is weird

shadow cedar Jun 17, 2021, 2:38 AM

#

oh my haha that would explain it

#

yeah after looking at that frame, i totally see it now. That is very strange.
I'll test the 6th frame to confirm that's it

#

yup confirmed 6th frame of the slash is used for the run cycle
Thank you Basil

vocal spire Jun 17, 2021, 4:27 AM

#

proven plover Does anyone know how I could make a new spell for the game?

How would you cast it? Would it require a charm to be on, or just replace spells by default?

#

If it requires a charm to be on, you’d have to make a good amount of edits the spell fsm. If it’s by default you just need to replace the GameObject the fsm creates

quasi ridge Jun 17, 2021, 8:18 AM

#

still looking for life steal mods

jolly oriole Jun 17, 2021, 8:38 AM

#

nice

#

and now?

nimble lake Jun 17, 2021, 9:53 AM

#

quasi ridge still looking for life steal mods

watch 56’s bad modding tutorial, he explains how to do it there

floral blade Jun 17, 2021, 10:56 AM

#

what is vasi ? like what does it do / why do some mods depend on it?

ornate rivet Jun 17, 2021, 10:58 AM

#

it's another core mod with reflection stuff and other stuff

#

https://github.com/fifty-six/HollowKnight.Vasi/

floral blade Jun 17, 2021, 11:24 AM

#

okay thanks!

arctic marsh Jun 17, 2021, 12:58 PM

#

hey, uh, very stupid dum person here, i need some help with maybe possibly 12% chance of making a mod sometime

what if i want to open and see the code of a certain mod, but its a dll and what if i want to change some stuff in it, dnspy doesnt do that right?
so uh yea how do i like open a dll in visual studio code cause it doesnt work when i open a folder and select a dll from there can i like convert it or what

i have literally no experience with modding and very little with coding but i wanna look around some mods to get the hang of how mods work

floral blade Jun 17, 2021, 1:29 PM

#

a lot of the mods have their source available on github , that would probably the best first place to start

vocal spire Jun 17, 2021, 1:30 PM

#

You can also open the dll in Dnspy

floral blade Jun 17, 2021, 1:30 PM

#

that and this https://radiance.host/apidocs/Getting-Started.html

vocal spire Jun 17, 2021, 1:30 PM

#

Suggest doing that with the Assembly-CSharp.dll file

arctic marsh Jun 17, 2021, 1:39 PM

#

alright but i got the github zip for the hell mod cause the apidocs told me to do that and i dont know where exactly the thing i need is, i found a .csproj file but i watched 56's tutorial and it doesnt look anything like that, its just refernces and stuff. what am i missing? did i do it wrong?

vocal spire Jun 17, 2021, 1:39 PM

#

What did you open it in

arctic marsh Jun 17, 2021, 1:51 PM

#

visual studio code

vocal spire Jun 17, 2021, 1:55 PM

#

Ah, iirc 56 uses rider

#

I use visual studio community

#

Can’t really open them that way in vs code (at least I’ve found)

#

Iirc vscode just opens csproj and sln files in a text editor

deep wave Jun 17, 2021, 2:35 PM

#

the csproj just gives info on references and included files. the files you want to open will probably be in a folder called "source" or similar, there will also be Include tags for each file

light zodiac Jun 17, 2021, 2:39 PM

#

If you want to open the mod using visual studio you should open the .sln or the .csproj not the .cs files

deep wave Jun 17, 2021, 2:56 PM

#

... they said vscode, which is not the same TeeHee

light zodiac Jun 17, 2021, 2:59 PM

#

can you compile mods using vscode?

arctic marsh Jun 17, 2021, 3:07 PM

#

so im using the wrong thing?

deep wave Jun 17, 2021, 3:09 PM

#

you can build in vscode

#

i'd certainly recommend full vs though, much easier to work with imo

arctic marsh Jun 17, 2021, 3:10 PM

#

i mean i did install normal vs

#

if its easier to work with im totally using that

deep wave Jun 17, 2021, 3:13 PM

#

there are reasons for both, and vscode is totally fine, just a little less intuitive and a bit more work to set up if you've never used it before tamershrug

#

one thing i will mention because it caught me out the first time, make sure you make a project targeting .net framework 3.5 for mods 1.4 and prior, or 4.7.2 if for 1.5 iirc

arctic marsh Jun 17, 2021, 3:16 PM

#

i guess imma figure out how to do that when i get there

#

oh also
when i add references and everything i saw 56 do in his tutorial is it just hooks and stuff or is there more things i need to do

like can i change how a boss works with just hooks or whatever

tawny onyx Jun 17, 2021, 3:18 PM

#

recommend to use vs2019, vscode is shit

jolly oriole Jun 17, 2021, 3:19 PM

#

vscode is amazing, just not for c# projects

arctic marsh Jun 17, 2021, 3:19 PM

#

alright itssoulgood

tawny onyx Jun 17, 2021, 3:21 PM

#

i try use vscode to coding with Vue.js , the exprience is terrible. espically the label aligenment

#

also try to remote coding c/c++,and the auto-completion dont work

arctic marsh Jun 17, 2021, 3:23 PM

#

vs 2019 can open dll right? or did i do the stupid again

tawny onyx Jun 17, 2021, 3:25 PM

#

Oops, fine, i find some requirement just now. maybe i know why code completion dont work.

tawny onyx Jun 17, 2021, 3:26 PM

#

arctic marsh vs 2019 can open dll right? or did i do the stupid again

nop, but you can open it with dnSpy

arctic marsh Jun 17, 2021, 3:26 PM

#

i did the stupid
to github i go

tawny onyx Jun 17, 2021, 3:26 PM

#

also you can export dll to vs project with dnSpy

arctic marsh Jun 17, 2021, 3:28 PM

#

you can? how?

tawny onyx Jun 17, 2021, 3:29 PM

#

the first opion of File Menu

#

arctic marsh Jun 17, 2021, 3:45 PM

#

now uh...
i forgot what file i needed to open which actually has all the code and stuff cause the dlls dont seem to have much

floral blade Jun 17, 2021, 3:51 PM

#

light zodiac can you compile mods using vscode?

you can and i do sometimes

arctic marsh Jun 17, 2021, 4:06 PM

#

so i went in vs 2019 and selected class library now its asking me to select .net standard 2.0 or 2.1, .net core 2.1 or 3.1, or .net 5.0
which one do i have to select

jolly oriole Jun 17, 2021, 4:07 PM

#

class library (.net framework) as a project template

arctic marsh Jun 17, 2021, 4:08 PM

#

ah, found it, thanks

jolly oriole Jun 17, 2021, 4:09 PM

#

then .net framework 3.5 if you're making mods for patch 1.4.3.2
or .net framework 4.7.2 if you're doing it for patch 1.5.numbers

arctic marsh Jun 17, 2021, 4:12 PM

#

so im trying to add UnityEngine.dll as a reference and there literally isnt one

#

im following apidocs

light zodiac Jun 17, 2021, 4:15 PM

#

Check in hollow_knight_Data/Managed

arctic marsh Jun 17, 2021, 4:22 PM

#

there is a ton of UnityEngine and then something else but no simple UnityEngine.dll

i assume i dont need it then?

floral blade Jun 17, 2021, 4:23 PM

#

take a copy of all of Managed directory and put somewhere else

#

use those files as references

light zodiac Jun 17, 2021, 4:24 PM

#

arctic marsh there is a ton of UnityEngine and then something else but no simple UnityEngine....

You probs do need it lol

floral blade Jun 17, 2021, 4:24 PM

#

you may need to reference more than just the engine while modding

light zodiac Jun 17, 2021, 4:24 PM

#

Type it in the bottom of the explorer that opens

arctic marsh Jun 17, 2021, 4:25 PM

#

~~confused nodding~~

merry lotus Jun 17, 2021, 4:26 PM

#

To whoever is currently working on Mod Installer:
#archived-modding-help message

The current build has been having an issue for people where dependencies don't download / unzip correctly.
This was first noticed a lot with Vasi, but as time goes on, it's becoming apparent that it affects lots of stuff. I'm not sure if maybe there's a way to verify that each step happens correctly before moving on?

arctic marsh Jun 17, 2021, 4:26 PM

#

i put every unityengine thing as reference is that fine

vocal spire Jun 17, 2021, 4:26 PM

#

If there isn’t a UnityEngine.dll the game can’t run

arctic marsh Jun 17, 2021, 4:28 PM

#

found it!

#

ok i did what 56 did with the log thing but how do i turn that into a dll
is it already a dll?

light zodiac Jun 17, 2021, 4:31 PM

#

What is already a dll?

arctic marsh Jun 17, 2021, 4:32 PM

#

that was probably stupid

#

how do i turn cs into dll or am i missing something

vocal spire Jun 17, 2021, 4:33 PM

#

You build the project

#

Ctrl + b in vs

arctic marsh Jun 17, 2021, 4:33 PM

#

itssoulgood

vocal spire Jun 17, 2021, 4:33 PM

#

Or you click the build tab at the top then select one of the options

jolly oriole Jun 17, 2021, 4:38 PM

#

but does it work on the newest beta patch?

arctic marsh Jun 17, 2021, 4:41 PM

#

how is it not working cry_angry

light zodiac Jun 17, 2021, 4:42 PM

#

What did you expect to happen

arctic marsh Jun 17, 2021, 4:42 PM

#

are you mocking me or asking me what i tried to do i genuinely have no idea

light zodiac Jun 17, 2021, 4:42 PM

#

Why would I mock you

arctic marsh Jun 17, 2021, 4:42 PM

#

i dont know

light zodiac Jun 17, 2021, 4:43 PM

#

I don't know what you wanted

#

To happen

arctic marsh Jun 17, 2021, 4:44 PM

#

anyway i tried doing what 56 did in the tutorial and did the Log("initializing."); so that log pops up but it didnt
is this what makes the log pop up? im really not sure
but i probably did it wrong

light zodiac Jun 17, 2021, 4:45 PM

#

You have to enable the log by going to save files and opening modding API.globalsettings

floral blade Jun 17, 2021, 4:45 PM

#

Log probably needs to be enabled in settings

arctic marsh Jun 17, 2021, 4:45 PM

#

alright

#

after i do that time for more copying

#

why do i always feel like everyone is acting chill but wants to call me an idiot any second radS

anyway where is "save files"?

#

is it in

#

?saves

finite forumBOT Jun 17, 2021, 4:48 PM

#

Saves

Windows File Paths: (Assumes Default Steam Install Path, Adjust accordingly for DRM Free or Non-Standard Steam Path)

Game Files: C:\Program Files (x86)\Steam\steamapps\common\Hollow Knight\```
** **
Mac File Paths:
```Save Files: ~/Library/Application Support/unity.Team Cherry.Hollow Knight/
Game Files: ~/Library/Application Support/Steam/steamapps/common/Hollow Knight/hollow_knight.app/```
** **
Linux File Paths:
```Save Files: ~/.config/unity3d/Team Cherry/Hollow Knight/
Game Files: ~/.local/share/Steam/steamapps/common/Hollow Knight/```

arctic marsh Jun 17, 2021, 4:48 PM

#

?

#

its there

#

yay

floral blade Jun 17, 2021, 4:51 PM

#

We're just worried

#

That

#

You'll steal our nicknames

#

shermanxious

arctic marsh Jun 17, 2021, 4:56 PM

#

~~i mean you dont have an interesting nickname, actually you dont even have a nickname~~

thats cuz i tend to find someone with an interesting nickname then i change my nickname to that but make it different so its mine, so i now made my nick Mr Steal Your Nickname mylaU

#

~~the first part is stolen yes~~

#

can i change a boss attack using a hook or is that just for the knight? how hard is it to change a boss?

floral blade Jun 17, 2021, 5:19 PM

#

for bosses you might need to modify the FSM

arctic marsh Jun 17, 2021, 6:24 PM

#

where do i download fsm viewer

young walrus Jun 17, 2021, 6:24 PM

#

pins

arctic marsh Jun 17, 2021, 6:30 PM

#

how does it work and what am i supposed to open in fsmviewer

patent zealot Jun 17, 2021, 6:31 PM

#

https://radiance.host/apidocs/PlayMakerFSM.html

jolly oriole Jun 17, 2021, 6:31 PM

#

https://github.com/nesrak1/FSMViewAvalonia/releases/tag/v3

arctic marsh Jun 17, 2021, 6:32 PM

#

itssoulgood

floral blade Jun 17, 2021, 7:10 PM

#

so this happens when using smolknight & touching a wall/floor and jumping/dashing some times
any idea what could be the cause

#

nvm found it, now to figure out how to fix

#

x scale gets reset at certain points i guess

floral blade Jun 17, 2021, 7:29 PM

#

is there a way to replace a method on a mono behaviour?

jolly oriole Jun 17, 2021, 7:30 PM

#

On.Class.Method += hook;

floral blade Jun 17, 2021, 7:30 PM

#

this would replace the method or run it after the method ?

jolly oriole Jun 17, 2021, 7:30 PM

#

though completely replacing a method likely makes your mod not compatible with other mods

jolly oriole Jun 17, 2021, 7:31 PM

#

floral blade this would replace the method or run it after the method ?

you can replace it, run code before or after, whichever you want

floral blade Jun 17, 2021, 7:32 PM

#

after should be best for compatibility with mods in my case, i can set the scale back without messing up other mods i guess

jolly oriole Jun 17, 2021, 7:32 PM

#

Example:

On.HeroController.FixedUpdate += Hook;

private void Hook(On.HeroController.orig_FixedUpdate orig, HeroController self)
{
  // here you can change stuff before the original method is being executed, like changing variables

  orig(self); // the original method, with self and the rest of its arguments

  // here you can change stuff after the original method is being executed, like changing unwanted stuff on the object
}

floral blade Jun 17, 2021, 7:33 PM

#

oh that should do it! thanks!

#

mapi does this for all monobehaviours in the game ?

jolly oriole Jun 17, 2021, 7:39 PM

#

yes

floral blade Jun 17, 2021, 7:41 PM

#

okay ! that did the trick ! no more squished-disco-boi !

fair rampart Jun 17, 2021, 7:49 PM

#

How can I make a gameObject hittable by the hero's nail like buzzsaws for example?

#

I have to add some component to the object?

#

For example the needle of hornet when she throws to you is hittable but not when I Instantiate it again

#

floral blade Jun 17, 2021, 8:30 PM

#

have you tried putting it on layer 9 ?

copper nacelle Jun 17, 2021, 8:31 PM

#

it shouldn't even have a non bouncer in the first place should it

fair rampart Jun 17, 2021, 8:38 PM

#

thanks I'll try tomorrow

#

I see that buzzSaw of white palace is on layer 17

fair rampart Jun 17, 2021, 9:18 PM

#

floral blade have you tried putting it on layer 9 ?

thanks changing layer worked.

vocal spire Jun 18, 2021, 2:06 AM

#

with the new get hooks do we still need to return PlayerData.instance.Get(type)Internal?

copper nacelle Jun 18, 2021, 2:07 AM

#

no

#

bro I wrote docs

#

with examples too

#

This is so sad

vocal spire Jun 18, 2021, 2:09 AM

#

oh didn't see

timid ore Jun 18, 2021, 9:07 AM

#

heya

primal latch Jun 18, 2021, 9:07 AM

#

hello

floral blade Jun 18, 2021, 9:25 AM

#

a mod that makes enemy attacks hurt each other and lets you run sims of them fighting gorbbrain

jolly jungle Jun 18, 2021, 9:43 AM

#

yes

primal latch Jun 18, 2021, 9:44 AM

#

but why?

jolly jungle Jun 18, 2021, 9:45 AM

#

to find who is the strongest

#

And then, we can start tweaking their ais to be smarter, constantly trying to beat each other up

#

We come out of this with a bunch of enemies with enhanced ais

floral blade Jun 18, 2021, 10:30 AM

#

primal latch but why?

it sounds like a fun thing to do , also if it'd be a youtube series i'd watch it

#

kind of like that old TV programme Animal Face-Off

#

example https://youtu.be/HP-6wG_wZ8A?t=244

jolly jungle Jun 18, 2021, 10:59 AM

#

Seriously though I totally wanna see a fight between, like, Husk Guard and Moss Knight

jolly oriole Jun 18, 2021, 11:05 AM

#

making enemies damage other enemies is easy, though it may result in enemies damagin themselves

floral blade Jun 18, 2021, 11:40 AM

#

jolly oriole making enemies damage other enemies is easy, though it may result in enemies dam...

that is okay i think self damage can just be a trait of the enemy , but can we make them target the other enemies on the screen easily though ?

ornate rivet Jun 18, 2021, 11:52 AM

#

without looking into it too much, I think it would be as simple as setting the Hero variable in the enemy's fsm to another enemy instead of the player go

#

it would require more work if you want to change the fsm to attack all enemies, not just a particular one

floral blade Jun 18, 2021, 11:56 AM

#

what if i set it to a new go, that i move around to track whichever enemy i want the particular enemy to track?

so each enemy would have its own "lockon" object that we can just move to track whichever object we want it to, this would allow for switching target lockons etc?

ornate rivet Jun 18, 2021, 11:57 AM

#

ooooo that's a great idea

#

I would test to see if just setting the enemy's hero fsm to another enemy even works first though

floral blade Jun 18, 2021, 11:58 AM

#

yes, good idea

remote totem Jun 18, 2021, 2:19 PM

#

so if I wanted to learn to make my first mod ever using HK modding API with zero experience in unity or C#..... What resources can I use to do that?

floral blade Jun 18, 2021, 2:20 PM

#

if you already know some programming then a few unity tutorials can be a good starting point and then https://radiance.host/apidocs/Getting-Started.html

remote totem Jun 18, 2021, 2:21 PM

#

my last programming experience was sometime in 2000 with visual basic - so I'd more or less be starting fresh

floral blade Jun 18, 2021, 2:22 PM

#

then it might be good to learn basic programming with c#

#

https://docs.microsoft.com/en-us/dotnet/csharp/tour-of-csharp/tutorials/
this might be good

ornate rivet Jun 18, 2021, 2:36 PM

#

any idea why hm.IsInvincible = true; isn't making my go invincible?

#

oh hmm I think I get why nvm

potent dirge Jun 18, 2021, 3:16 PM

#

is it another of those unused variables that youd think would solve all your problems but then end up not doing it?

ornate rivet Jun 18, 2021, 3:16 PM

#

nah, the problem was that the fsm changed it too

potent dirge Jun 18, 2021, 3:17 PM

#

the variable it?

#

OhISee

ornate rivet Jun 18, 2021, 3:17 PM

#

the fsm set hm.IsInvincible too

potent dirge Jun 18, 2021, 3:17 PM

#

remake hk iwthout the fsms when tbh tbh 😤

primal latch Jun 18, 2021, 3:21 PM

#

potent dirge remake hk iwthout the fsms when tbh tbh 😤

Would be beter. I hate them.

jolly oriole Jun 18, 2021, 3:29 PM

#

fsms are great, makes mods easier compatible

ornate rivet Jun 18, 2021, 4:26 PM

#

fuck
utiny doesn't work past unity2019

#

I hate life

jolly oriole Jun 18, 2021, 4:27 PM

#

rip

ornate rivet Jun 18, 2021, 4:56 PM

#

anyone know an alternative to utiny ripper?

dark wigeon Jun 18, 2021, 5:09 PM

#

fixing it

#

maybe hkworldedit would let you export into bundles or smth

ornate rivet Jun 18, 2021, 5:13 PM

#

hkworldedit has an update?

dark wigeon Jun 18, 2021, 5:17 PM

#

it does run on latest unity but the only thing is that sprites aren't rendering

#

due to a bug in the editor again

#

I think if you rebundle it it might fix or something

#

ornate rivet Jun 18, 2021, 5:23 PM

#

hmm

dark wigeon Jun 18, 2021, 5:28 PM

#

my guess is the editor only supports m_RD but the latest version moves it over to a spriteatlas asset that the editor can't read

dark wigeon Jun 18, 2021, 6:37 PM

#

as you can see it's working with absolutely 0 bugs

jolly oriole Jun 18, 2021, 6:42 PM

#

i do see a few tbh

dark wigeon Jun 18, 2021, 6:54 PM

#

turns out the new vertex data is completely wrong so uh

#

idk what to do

vocal spire Jun 18, 2021, 6:54 PM

#

sad

jolly oriole Jun 18, 2021, 6:55 PM

#

dark wigeon idk what to do

in what way 'completely wrong'? (maybe hopefully only left/right or top/bottom mirrored)

dark wigeon Jun 18, 2021, 7:01 PM

#

the sprite it selects in the spritesheet overlaps multiple sprites

#

almost as if it's for a different texture

#

the texture is correct though

#

and no not mirrored

floral blade Jun 18, 2021, 7:03 PM

#

Is it flipped or whatever that sprite.json thingy is

dark wigeon Jun 18, 2021, 7:03 PM

#

dark wigeon and no not mirrored

.

floral blade Jun 18, 2021, 7:04 PM

#

No no it's not just mirrored like the sprite is rotated 90degrees and the coordinates are as if the image is not rotated 90degrees

dark wigeon Jun 18, 2021, 7:04 PM

#

doubt

#

not at the pc right now but I don't think it was the same size at all

floral blade Jun 18, 2021, 7:05 PM

#

That's what knight.png has some sprites are just that way godump generates a flag called flipped for those

dark wigeon Jun 18, 2021, 7:05 PM

#

that's tk2d

#

those are the only sprites loading in the screenshot

#

the issue is about unity sprites

floral blade Jun 18, 2021, 7:06 PM

#

Ah okay

jolly oriole Jun 18, 2021, 7:12 PM

#

there is the possibility that it do be 90/270° rotated for no reason, would align some silhouettes with 'wood' textures somewhat close

#

here, top image is the bottom right part of 1432 fung spriteatlas, bottom image is bottom part of 1432 fung spriteatlas rotate 90° counter clockwise

dark wigeon Jun 18, 2021, 7:21 PM

#

same sprite from 1.4 and 1.5

jolly oriole Jun 18, 2021, 7:21 PM

#

hm :/

#

on the release 1.5 or beta 1.5?

dark wigeon Jun 18, 2021, 7:22 PM

#

same sprite

#

release 1.5

jolly oriole Jun 18, 2021, 7:23 PM

#

sad, the uabe i have doesn't work with 1.5 ;_;

dark wigeon Jun 18, 2021, 7:23 PM

#

wat

#

are you using the original

jolly oriole Jun 18, 2021, 7:23 PM

#

yea

dark wigeon Jun 18, 2021, 7:23 PM

#

why are you doing that

#

https://nightly.link/nesrak1/UABEA/workflows/dotnet-desktop/master/uabea-windows.zip

jolly oriole Jun 18, 2021, 7:24 PM

#

because i found it through https://github.com/DerPopo/UABE

dark wigeon Jun 18, 2021, 7:26 PM

#

well shoot I think I can guess why it's not even close

#

there's a lot and I picked the wrong one

jolly oriole Jun 18, 2021, 7:28 PM

#

i can manually compare the textures once the texture export is done

jolly oriole Jun 18, 2021, 7:28 PM

#

dark wigeon there's a lot and I picked the wrong one

nah, those are gameobjects, not sprites

dark wigeon Jun 18, 2021, 7:29 PM

#

different sprites in those gameobjects with the same name

#

there are two sprites with that name

jolly oriole Jun 18, 2021, 7:29 PM

#

how

dark wigeon Jun 18, 2021, 7:29 PM

#

because team cherry

jolly oriole Jun 18, 2021, 7:29 PM

#

and unity does nothing? 🥴

#

why did unity change the naming of sprite atlases

dark wigeon Jun 18, 2021, 7:30 PM

#

yeah in the sprite names to index, they have two sprites of the same name with different sprites

#

idk how you do that but it just is

#

oh but sadly they seem to have the same data

#

so I guess that wasn't it

jolly oriole Jun 18, 2021, 7:32 PM

#

found the spritesheet, silhouette is in bottom right corner, and i don't think any wooden looking sprite and overlap it with any kind of mirroring/rotation in the UVs, idk

sactx-0-4096x4096-DXT5-Fung-0ad5fae8-sharedassets23.assets-2.png

#

... it did change btw, was 2048x4096 before

dark wigeon Jun 18, 2021, 7:35 PM

#

let me try randomly changing values brb

vocal spire Jun 18, 2021, 7:36 PM

#

zote

jolly oriole Jun 18, 2021, 7:37 PM

#

found the part with the 'bugs' i highlighted before

dark wigeon Jun 18, 2021, 7:38 PM

#

sprite atlas is supposed to be rectangle only?

#

or can it cut the sprite in polygons

jolly oriole Jun 18, 2021, 7:38 PM

#

polygons

dark wigeon Jun 18, 2021, 7:38 PM

#

tight packing

jolly oriole Jun 18, 2021, 7:38 PM

#

if it's tight packing

dark wigeon Jun 18, 2021, 7:39 PM

#

is that in settingsRaw or smth? I don't see a field for it

jolly oriole Jun 18, 2021, 7:39 PM

#

good question, let me search

dark wigeon Jun 18, 2021, 7:40 PM

#

if you look at the new spriteatlasdata there are only rectangles

jolly oriole Jun 18, 2021, 7:40 PM

#

m_IsPolygon is false with that sprite

dark wigeon Jun 18, 2021, 7:41 PM

#

oh

#

yeah it's false

#

let me make sure I get one that isn't

jolly oriole Jun 18, 2021, 7:42 PM

#

uh, about that

#

i can't find a single polygon sprite

dark wigeon Jun 18, 2021, 7:45 PM

#

they all say false even when they aren't I just checked

jolly oriole Jun 18, 2021, 7:45 PM

#

yea

#

m_RD/m_VertexData/m_VertexCount says 9 for mush_010000 sprite

#

but idk where to find the data for those vertices

shadow cedar Jun 18, 2021, 8:14 PM

#

Hello peeps. I'm making a custom knight mod and currently working on the double jump. Does anyone know where the sprites for the "feathers" that fall from the knight after the double jump are? I can find every part of double jump but those dang feathers

merry lotus Jun 18, 2021, 8:27 PM

#

Have you tried using Dandy's sprite remixer to find animations?

shadow cedar Jun 18, 2021, 8:27 PM

#

never heard of that, what does that do? I'm using sprite packer currently

deep wave Jun 18, 2021, 8:28 PM

#

with the knight folder pinned in modding-discussion the animation is "100. Double Jump Wings 2"

#

would appear to be on the wraiths sheet

merry lotus Jun 18, 2021, 8:28 PM

#

https://prashantmohta.github.io/HollowKnight.SkinRemixer/
Edit: I just realized that the wings may not be in knight.png, which is what that link looks for

deep wave Jun 18, 2021, 8:30 PM

#

grubthink

#

for reference, 100 is the wings detail

shadow cedar Jun 18, 2021, 8:30 PM

#

that is not the sprite I'm talking about

#

the feathers that fall down from the knight after that animation you posted plats

floral blade Jun 18, 2021, 8:31 PM

#

shadow cedar Hello peeps. I'm making a custom knight mod and currently working on the double ...

if you mean the feather particles then i don't believe those are skinnable using CK just yet

shadow cedar Jun 18, 2021, 8:31 PM

#

plays*

deep wave Jun 18, 2021, 8:31 PM

#

oh the feathers that fall from the knight? believe those are particles and not animations

shadow cedar Jun 18, 2021, 8:31 PM

#

@floral blade ah I was afraid that was probably the answer 😦

#

sorry it was hard to explain haha

floral blade Jun 18, 2021, 8:32 PM

#

deep wave <:grubthink:371797157629657109>

yeah the remixer only supports Knight.png as of now

deep wave Jun 18, 2021, 8:32 PM

#

another reason for 1.5 to introduce customknight 2 feelspkman

shadow cedar Jun 18, 2021, 8:32 PM

#

yessss

vocal spire Jun 18, 2021, 8:32 PM

#

hey I already claimed customknight 2

#

customknight +

floral blade Jun 18, 2021, 8:33 PM

#

vocal spire hey I already claimed customknight 2

i'm going to keep using customknight

merry lotus Jun 18, 2021, 8:33 PM

#

Dandy is making CK support more basic stuff, and RedFrom/Someone can make the CK+ extension

floral blade Jun 18, 2021, 8:33 PM

#

but probably add a space in between

shadow cedar Jun 18, 2021, 8:33 PM

#

customknight ultra grubfather

deep wave Jun 18, 2021, 8:33 PM

#

are you patch 1.5.68.11808 for critically acclaimed spaghetti mess Hollow Knight? omg hi 😳

vocal spire Jun 18, 2021, 8:33 PM

#

I'll add particle replacements to customknight +

floral blade Jun 18, 2021, 8:34 PM

#

CK already does replace some particles

light zodiac Jun 18, 2021, 8:34 PM

#

vocal spire I'll add particle replacements to customknight +

That's what you always say grubsad

floral blade Jun 18, 2021, 8:34 PM

#

particularly the shade's black orbs

vocal spire Jun 18, 2021, 8:35 PM

#

fine I'll stop working on pale court right now and work on ck+ instead

floral blade Jun 18, 2021, 8:35 PM

#

on my todo list are the cdash and djump particles

light zodiac Jun 18, 2021, 8:36 PM

#

Ck+ clearly > pale court

floral blade Jun 18, 2021, 8:36 PM

#

but before that smolknight!

floral blade Jun 18, 2021, 8:36 PM

#

light zodiac Ck+ clearly > pale court

yes

#

CK+ first then any other mods

vocal spire Jun 18, 2021, 8:36 PM

#

tbh I should do it though, been putting it off for a LONG time now

shadow cedar Jun 18, 2021, 8:37 PM

#

please

vocal spire Jun 18, 2021, 8:40 PM

#

Planned features:```
create tk2dspritecollectiondata instances for a inputted texture

edit/add/remove frames from tk2dspriteanimation instances and edit fps (possibly mess with triggers)

change any particle's sprite to a slice of a inputted texture

change any spriterenderer's sprite to a slice of a inputted texture```
did I miss anything

#

excluding the editor

dark wigeon Jun 18, 2021, 8:41 PM

#

jolly oriole why did unity change the naming of sprite atlases

ahhhhhhh the names and pointers are in order but the data is in random order

vocal spire Jun 18, 2021, 8:41 PM

#

nice

dark wigeon Jun 18, 2021, 8:41 PM

#

I just try not to understand anything anymore

vocal spire Jun 18, 2021, 8:41 PM

#

why would you

jolly oriole Jun 18, 2021, 8:43 PM

#

deep wave are you patch 1.5.68.11808 for critically acclaimed spaghetti mess Hollow Knight...

you sure mean 1.5.71.numbers, right?

floral blade Jun 18, 2021, 8:46 PM

#

this is probably it

vocal spire Jun 18, 2021, 8:46 PM

#

jolly oriole you sure mean 1.5.71.numbers, right?

where did you get .71 from?

jolly oriole Jun 18, 2021, 8:47 PM

#

beta branch

vocal spire Jun 18, 2021, 8:47 PM

#

in game version for me says .68

#

ah nvm

#

I'm not on beta branch

#

thought I was

#

I am on None

dark wigeon Jun 18, 2021, 8:56 PM

#

ayyyyy

vocal spire Jun 18, 2021, 8:56 PM

#

nice

dark wigeon Jun 18, 2021, 8:57 PM

#

🤔

jolly oriole Jun 18, 2021, 8:58 PM

#

too few edits

vocal spire Jun 18, 2021, 8:59 PM

#

does this mean hope for utiny ripper update?

dark wigeon Jun 18, 2021, 9:01 PM

#

lolllll no

#

utinyripper extracts assets

#

hkworldedit just directs unity to the assets

#

what are the chances I know both of these people

ornate rivet Jun 18, 2021, 9:03 PM

#

:)

dark wigeon Jun 18, 2021, 9:03 PM

#

yeah utiny looks pretty dead tho

vocal spire Jun 18, 2021, 9:03 PM

#

sad

ornate rivet Jun 18, 2021, 9:03 PM

#

wish I was smart enough to update it

dark wigeon Jun 18, 2021, 9:04 PM

#

it's not about smarts it's just about a lot of work

vocal spire Jun 18, 2021, 9:04 PM

#

~~time to become smart enough to update it~~

#

oh no effort

#

every programmers worst nightmare

ornate rivet Jun 18, 2021, 9:05 PM

#

will hkworldedit allow assetbundling?

vocal spire Jun 18, 2021, 9:05 PM

#

I would like to attempt trying to update utiny tho

dark wigeon Jun 18, 2021, 9:05 PM

#

it's not if hkworldedit allows it, it's if unity editor allows it with it's wack new changes

vocal spire Jun 18, 2021, 9:05 PM

#

I've assetbundled in 2020.2.2

ornate rivet Jun 18, 2021, 9:06 PM

#

that's not what he means

dark wigeon Jun 18, 2021, 9:06 PM

#

utiny doesn't run on assetstools so you'd have to update each asset type manually with binary reader

dark wigeon Jun 18, 2021, 9:06 PM

#

vocal spire I've assetbundled in 2020.2.2

I meant the editor changed how sprites are handled now

#

in assets files

vocal spire Jun 18, 2021, 9:06 PM

#

ah

#

ohhhhhh

dark wigeon Jun 18, 2021, 9:06 PM

#

it may break during bundle now

vocal spire Jun 18, 2021, 9:06 PM

#

I get it now

dark wigeon Jun 18, 2021, 9:06 PM

#

only way to know is to try

#

https://github.com/nesrak1/HKWorldEdit2 it's committed have fun

GitHub

nesrak1/HKWorldEdit2

WIP Hollow Knight Level Editor. Contribute to nesrak1/HKWorldEdit2 development by creating an account on GitHub.

ornate rivet Jun 18, 2021, 9:07 PM

#

it wouldn't let me assetbundle before either iirc

dark wigeon Jun 18, 2021, 9:07 PM

#

wdym wouldn't let you

vocal spire Jun 18, 2021, 9:07 PM

#

dark wigeon utiny doesn't run on assetstools so you'd have to update each asset type manuall...

~~time to start taking notes~~

dark wigeon Jun 18, 2021, 9:07 PM

#

it will always let you but it won't always look good

ornate rivet Jun 18, 2021, 9:07 PM

#

I remember there being errors but it's been like a year now so I dont remember

dark wigeon Jun 18, 2021, 9:07 PM

#

well let me know what they are if you try again

jolly oriole Jun 18, 2021, 9:08 PM

#

dark wigeon https://github.com/nesrak1/HKWorldEdit2 it's committed have fun

poggers

dark wigeon Jun 18, 2021, 9:08 PM

#

oh frick

#

I have debug hardcoded paths

#

hold up a sec

vocal spire Jun 18, 2021, 9:08 PM

#

well imma go do customknight+ stuff now

#

oh no

#

well good news and bad news on customknight+
good news: I found where I left the code
bad news: it's a old version

#

I was going to rewrite a bunch of stuff tho so it's probably fine

#

probably

rough pulsar Jun 18, 2021, 9:13 PM

#

I hope it's going to be fine

#

Most of the time it isn't

vocal spire Jun 18, 2021, 9:13 PM

#

has hk been using tk2d the entirety of development?

ornate rivet Jun 18, 2021, 9:14 PM

#

probably not when they weren't using unity

#

and were instead using stencil or whatever

rough pulsar Jun 18, 2021, 9:14 PM

#

It was Stencil yup

ornate rivet Jun 18, 2021, 9:17 PM

#

ping me when nes updates

vocal spire Jun 18, 2021, 9:17 PM

#

well as long as it's been used for every unity ver imma port it to all hk versions

rough pulsar Jun 18, 2021, 9:17 PM

#

nes?

ornate rivet Jun 18, 2021, 9:18 PM

#

nesquack

vocal spire Jun 18, 2021, 9:18 PM

#

like 10 messages above

ornate rivet Jun 18, 2021, 9:18 PM

#

floral blade Jun 18, 2021, 9:18 PM

#

meanwhile FSMAvalonia finally loads scene list on mac!

rough pulsar Jun 18, 2021, 9:18 PM

#

Oh

#

Nice!!!

vocal spire Jun 18, 2021, 9:18 PM

#

kool

floral blade Jun 18, 2021, 9:19 PM

#

bad news is i still need to run it via VS / compile it because some paths be hardcoded

jolly oriole Jun 18, 2021, 9:19 PM

#

cool!

dark wigeon Jun 18, 2021, 9:19 PM

#

?

#

you mean like the assemblies being in the wrong place?

floral blade Jun 18, 2021, 9:20 PM

#

no like it tries to get "hollow_knight_Data" but there's only "Data"

dark wigeon Jun 18, 2021, 9:20 PM

#

oh even that's different

#

dang macs

floral blade Jun 18, 2021, 9:21 PM

#

like this

#

oh and if you do update it may i request to add an option to reset the game path selected ? i found the txt file by following the code but might be a nice QOL thing to be able to change it

dark wigeon Jun 18, 2021, 9:24 PM

#

yes I know

#

I just haven't

#

about the data thing, we can just check for mac and then look for a different folder

#

you don't have to change it yourself every time a new commit is made

dark wigeon Jun 18, 2021, 9:26 PM

#

ornate rivet ping me when nes updates

ping

floral blade Jun 18, 2021, 9:26 PM

#

yeah that might be nice but this is still great to finally be able to see FSMs in all scenes

dark wigeon Jun 18, 2021, 9:27 PM

#

there are now four errors because I'm no longer giving an absolute path

#

but who cares it works anyway

ornate rivet Jun 18, 2021, 9:29 PM

#

thanks dude

dark wigeon Jun 18, 2021, 9:40 PM

#

bundle doesn't work because unity doesn't recognize anything as assets

#

if you wanted you could just write something similar to hkwe to copy sprites to prefabs and skip the editor freaking out over glitched scene files

ornate rivet Jun 18, 2021, 9:44 PM

#

I dont understand how unity works past using its basic features and I also don't know how to learn the stuff that makes hkwe work either

dark wigeon Jun 18, 2021, 9:49 PM

#

@ornate rivet do you need to bundle or put gameobjects into a prefab or what

#

I can copy any selection of objects directly from the scene to a bundle but that's about it

ornate rivet Jun 18, 2021, 10:06 PM

#

being able to copy objects into a bundle would be really nice

#

I remember the last time we tried that, it wouldn't copy the dependencies into it so it only ever worked if you used the bundle in the scene it came from which made it useless

dark wigeon Jun 18, 2021, 10:07 PM

#

can you be more specific

#

like why you are using it

#

are you just trying to basically preload objects, or are you trying to edit the whole scene or what

#

once you copy into a bundle, it's irreversible

ornate rivet Jun 18, 2021, 10:09 PM

#

trying to make new scenes from stuff in hk's old scenes plus new stuff I add myself

dark wigeon Jun 18, 2021, 10:11 PM

#

so you probably want prefabs then

#

I haven't really played with prefabs so idk what would happen if packed into one

floral blade Jun 18, 2021, 10:26 PM

#

shadow cedar <@731231925599076432> ah I was afraid that was probably the answer 😦

well, it works now. LMK if u want me to share the dev dll / the png for the feathers.

vocal spire Jun 18, 2021, 11:07 PM

#

does using monomod hooks on unity dlls work?

jolly oriole Jun 18, 2021, 11:16 PM

#

no

vocal spire Jun 18, 2021, 11:17 PM

#

sad

#

would've been much easier to use Awake hooks for all the monobehaviours

floral blade Jun 18, 2021, 11:29 PM

#

will the new modding api have the option to enable / disable in game modlog while the game is running ?

copper nacelle Jun 18, 2021, 11:34 PM

#

you can detour unity stuff if you construct the hooks yourself

#

And there's been a bind to hide the console for forever

#

F10

vocal spire Jun 18, 2021, 11:44 PM

#

copper nacelle you can detour unity stuff if you construct the hooks yourself

could you give more information on this?

copper nacelle Jun 18, 2021, 11:55 PM

#

new Hook (MethodInfo, MethodInfo)

vocal spire Jun 18, 2021, 11:56 PM

#

well that is surprisingly simple

#

what do I need to reference for that

copper nacelle Jun 19, 2021, 12:00 AM

#

MonoMod.RuntimeDetour

vocal spire Jun 19, 2021, 12:00 AM

#

Thanks!

floral blade Jun 19, 2021, 12:03 AM

#

copper nacelle And there's been a bind to hide the console for forever

does the thing need to be true in settings or does it get toggled anyway ?

#

i mean the modlog in bottom left

#

F10 does nothing for me

tawny onyx Jun 19, 2021, 12:07 AM

#

copper nacelle new Hook (MethodInfo, MethodInfo)

i usually use new Detour(MethodInfo,MethodInfo),~~ what's the differences?~~nvm i found it

#

copper nacelle Jun 19, 2021, 12:12 AM

#

floral blade does the thing need to be true in settings or does it get toggled anyway ?

has to be true

#

and yeah Hook takes a trampoline and has better cross mod support

#

Detour is a level lower basically

floral blade Jun 19, 2021, 12:14 AM

#

copper nacelle has to be true

okay thanks!

vocal spire Jun 19, 2021, 12:21 AM

#

would it be possible to get the instance the original method is run on

copper nacelle Jun 19, 2021, 12:36 AM

#

yeah that is a required parameter for non static hooks

vocal spire Jun 19, 2021, 1:22 AM

#

Oh ok

vocal spire Jun 19, 2021, 3:08 AM

#

am I not supposed to be using them on constructors? Tried opening the game and this time a bunch of not responding errors appeared and it crashed on the main menu

#

nvm I think the not responding things were a one time thing

charred topaz Jun 19, 2021, 3:45 AM

#

Would anyone know how I can find the FSMs related to the Grimm Child? I've been unable to find it with FSMViewAvalonia

copper nacelle Jun 19, 2021, 3:48 AM

#

?

#

resources.assets

charred topaz Jun 19, 2021, 3:51 AM

#

Yeah i'm dumb. That's the one place i didn't look

vocal spire Jun 19, 2021, 3:51 AM

#

it seems that hooking a constructor for SpriteRenderer doesn't work

tawny onyx Jun 19, 2021, 3:53 AM

#

looking over source code of MonoMod.RuntimeDetour and finally understand how to use Hook

// Demo for Hook
class Test
    {
        public string id;
        public Test(string _id) { id = _id; }
        public void func1(int arg1) //origin method
        {
            Console.WriteLine($"id:{id},number:{arg1}");
        }
    }
    class Program
    {
        public delegate void func1_delegate(Test self,int n); //delegate for use trampoline
        private static void new_func1(func1_delegate orig,Test self,int number) //orig is optional
        {
            Console.WriteLine($"hook {self.id},number:{number*2}");
            orig(self, number);
        }


        static void Main(string[] args)
        {
            var from = typeof(Test).GetMethod("func1", BindingFlags.Instance|BindingFlags.Public);
            var to = typeof(Program).GetMethod("new_func1", BindingFlags.Static | BindingFlags.NonPublic);
            var instance = new Test("hk");
            instance.func1(2);
            new Hook(from, to);
            instance.func1(2);
            
            Console.ReadKey();
        }

    }

if use Detour or not use delegate, can also use new Hook(from, to).GenerateTrampoline().Invoke() instead

vocal spire Jun 19, 2021, 3:54 AM

#

I have been looking

vocal spire Jun 19, 2021, 4:23 AM

#

seems to not work with constructors with no perameters

#

at least from my testing

tawny onyx Jun 19, 2021, 4:25 AM

#

show your code

vocal spire Jun 19, 2021, 4:28 AM

#

well I messed it up testing something else

copper nacelle Jun 19, 2021, 4:28 AM

#

are you getting a constructorinfo?

#

or what

vocal spire Jun 19, 2021, 4:28 AM

#

copper nacelle are you getting a constructorinfo?

....am I not supposed to be?

copper nacelle Jun 19, 2021, 4:29 AM

#

when in doubt assume everything wrong

#

does the hook get called

vocal spire Jun 19, 2021, 4:29 AM

#

ok

copper nacelle Jun 19, 2021, 4:29 AM

#

what happens

#

etc

vocal spire Jun 19, 2021, 4:29 AM

#

well it doesn't since it's not logging and I have a log in there

vocal spire Jun 19, 2021, 4:30 AM

#

tawny onyx show your code

(in a mod class)

private static void new_func1(Action<Test> orig, Test self) //orig is optional
        {
            Instance.Log($"hook");
            orig(self);
        }
        public void AddHooks()
        {
            var from = typeof(Test).GetConstructors()[0];
            foreach (var aaa in ((MethodBase)from).GetParameters())
                Log(aaa.ParameterType);
            var to = typeof(CK2).GetMethod("new_func1", BindingFlags.Static | BindingFlags.NonPublic);
            var instance = new Test("hk");
            new Hook(from, to);
            var instance2 = new Test("hk");
        }
        public class Test
        {
            public string id;
            public Test() { }
        }```

#

I got a constructor hook working before

#

wait I didn't revert some stuff

#

timeline

I got a constructor with a argument working
tested without argument didn't work
tried going back to one argument but it didn't work
was making it use no arguments again to show code

copper nacelle Jun 19, 2021, 4:33 AM

#

    internal class Yeah
    {
        public Yeah(int h = 37)
        {
            Console.WriteLine("Yeah::.ctor");
            Console.WriteLine($"Got h = {h}");
        }
    }
    
    internal static class Program
    {
        private static void Main()
        {
            var ci = typeof(Yeah).GetConstructor(new[] { typeof(int) });

            var hook = new Hook(ci, typeof(Program).GetMethod("ctor_override"));

            var yeah = new Yeah();

            Console.ReadLine();
        }

        public static void ctor_override(Action<Yeah, int> orig, Yeah self, int h)
        {
            Console.WriteLine("Program::ctor_override");
            Console.WriteLine($"h = {h}, overriding to 20");

            orig(self, 20);
        }
    }

#

e.g.

vocal spire Jun 19, 2021, 4:34 AM

#

Ok

#

works now, thanks

#

sad System.NotSupportedException: Body-less method

copper nacelle Jun 19, 2021, 4:55 AM

#

do a native detour then or something

vocal spire Jun 19, 2021, 4:57 AM

#

what's that

copper nacelle Jun 19, 2021, 4:57 AM

#

NativeDetour

vocal spire Jun 19, 2021, 4:57 AM

#

ok

#

well it worked but it didn't

#

got the log in so it was called

#

but it crashed

#

I think I broke something

#

prob because I don't call orig but orig crashes?

#

(trying out hooking GameObject.SetActive)

#

I'll just hook something else

#

IT WORKS

#

yay

ornate rivet Jun 19, 2021, 11:37 AM

#

cooool

jolly oriole Jun 19, 2021, 12:14 PM

#

why did TC change the path for GOG, makes modinstaller more complicated

light zodiac Jun 19, 2021, 12:19 PM

#

What is the new path?

jolly oriole Jun 19, 2021, 12:22 PM

#

hollow_knight_Data => Hollow Knight_Data

#

https://github.com/ricardosouzag/ModInstaller/pull/103 definetly serious pull request

light zodiac Jun 19, 2021, 12:39 PM

#

Only API is updated to 1.5 grubthink

jolly oriole Jun 19, 2021, 12:40 PM

#

at least then the people asking for mods in #modding-help will then have their modinstaller working normally

light zodiac Jun 19, 2021, 12:41 PM

#

Also I just wanna confirm. With the new GetPlayerStringHook, if I return false, it will set the string to what it originally wanted to be?

fair rampart Jun 19, 2021, 12:41 PM

#

I want to start modding hollow knight,
where do i start?

light zodiac Jun 19, 2021, 12:41 PM

#

jolly oriole at least then the people asking for mods in #modding-help will then have their m...

Fwiw I have debug and benchwarp updated to the newest api

jolly oriole Jun 19, 2021, 12:43 PM

#

fair rampart I want to start modding hollow knight, where do i start?

https://radiance.host/apidocs/Getting-Started.html

fair rampart Jun 19, 2021, 12:43 PM

#

thanks

light zodiac Jun 19, 2021, 12:44 PM

#

new stuff ig

📎 Benchwarp.dll

#

📎 DebugMod.dll

steady comet Jun 19, 2021, 12:48 PM

#

light zodiac Also I just wanna confirm. With the new GetPlayerStringHook, if I return false, ...

Yes, assuming you're the only mod that has hooked it

#

(I guess one could say that if you return false, it's like you didn't even add the hook)

light zodiac Jun 19, 2021, 12:59 PM

#

I should've read the example lol. In that it returns null if it didn't want to change anything

#

Nvm that's for set not get

#

The get doesn't have the bool? return value, it has bool return value

#

So I can't return null

steady comet Jun 19, 2021, 1:06 PM

#

I think you return false if you don't want to change the string, and return true if you do want to change the string

#

(If you're returning false, then you can set res to null or orig or whatever you like I guess)

light zodiac Jun 19, 2021, 1:07 PM

#

Ok thanks

steady comet Jun 19, 2021, 1:10 PM

#

It seems that it works differently for strings, where you change the value of the param and return a bool, whereas for bools and ints you return the new value or null

jolly oriole Jun 19, 2021, 3:44 PM

#

how the fuck can i tell the package manager in unity to list all packages

#

rough pulsar Jun 19, 2021, 3:45 PM

#

I'm lazy so i'll post a link https://docs.unity3d.com/2020.2/Documentation/Manual/upm-ui.html
See if this helps

#

The version is 2020.2 right

vocal spire Jun 19, 2021, 3:48 PM

#

[INFO]:[CK2] - Looking at Sprite Renderer GO: Elderbug (UnityEngine.GameObject)why does elderbug have a spriterenderer

floral blade Jun 19, 2021, 3:49 PM

#

to

#

render sprites ?

vocal spire Jun 19, 2021, 3:50 PM

#

no?

#

elderbug is tk2d

#

oh nvm it's a box collider

#

I copied the log and didn't change the text

#

nvm I did change the text?

rough pulsar Jun 19, 2021, 3:51 PM

#

I broke steam fleascream

vocal spire Jun 19, 2021, 3:51 PM

#

nvm I copied the code calling the look at sprite renderer method and forgot to change it to box collider

floral blade Jun 19, 2021, 4:02 PM

#

question, how do you find the path needed for preloading an obj ?
for example "Deepnest_Spider_Town", "RestBench Spider/Webbed Knight"
i see only "RestBench Spider" in fsm viewer

#

light zodiac Jun 19, 2021, 4:03 PM

#

there's a gameobject dump for each scene in the pins

floral blade Jun 19, 2021, 4:03 PM

#

the scenes.rar ?

light zodiac Jun 19, 2021, 4:04 PM

#

yee

primal latch Jun 19, 2021, 4:04 PM

#

light zodiac there's a gameobject dump for each scene in the pins

is that still accurate for 1.5?

light zodiac Jun 19, 2021, 4:04 PM

#

thkshadeidk

floral blade Jun 19, 2021, 4:06 PM

#

light zodiac yee

thanks! things make so much more sense now

vocal spire Jun 19, 2021, 4:06 PM

#

fine I'll go through 1.5 and dump every scene

#

.....after finishing customknight+

copper nacelle Jun 19, 2021, 4:09 PM

#

he will never dump every scene

primal latch Jun 19, 2021, 4:09 PM

#

vocal spire .....after finishing customknight+

when do you think you'll finish that?

vocal spire Jun 19, 2021, 4:13 PM

#

¯_(ツ)_/¯

#

getting a lot of work done

#

I also need to finish/rewrite the editor as well

eager meadow Jun 19, 2021, 4:29 PM

#

just wanna check, there still no mod installer that works with newest patch?

jolly oriole Jun 19, 2021, 4:30 PM

#

nope

eager meadow Jun 19, 2021, 4:30 PM

#

ok thanks 🙂

dark wigeon Jun 19, 2021, 4:54 PM

#

or just look in assetsview if you can

floral blade Jun 19, 2021, 4:58 PM

#

are these pink dots an issue or just TC being TC ?

Screenshot_2021-06-19_at_10.27.29_PM.png

copper nacelle Jun 19, 2021, 4:58 PM

#

they're always there dwai

floral blade Jun 19, 2021, 4:59 PM

#

okay

vocal spire Jun 19, 2021, 5:53 PM

#

customknight + might actually have a kind of working beta now

#

core features working, editor very incomplete

#

needs more features though

light zodiac Jun 19, 2021, 5:54 PM

#

How can you change a sprite of an item in the inventory?

shadow cedar Jun 19, 2021, 6:41 PM

#

does customknight support replacing grubberfly beam/projectile? grubthink

vocal spire Jun 19, 2021, 6:42 PM

#

light zodiac How can you change a sprite of an item in the inventory?

I’ll give you some code in a couple hours for this.

light zodiac Jun 19, 2021, 6:43 PM

#

Thanks

floral blade Jun 19, 2021, 6:45 PM

#

shadow cedar does customknight support replacing grubberfly beam/projectile? <:grubthink:3717...

unless its in the base images , not atm

jolly jungle Jun 19, 2021, 7:10 PM

#

vocal spire I’ll give you some code in a couple hours for this.

ping me for this please

copper nacelle Jun 19, 2021, 7:12 PM

#

https://www.github.com/fifty-six/HollowKnight.Lightbringer/tree/master/Lightbringer%2FLightbringer.cs 323, 345

GitHub

fifty-six/HollowKnight.Lightbringer

API Lightbringer Port. Contribute to fifty-six/HollowKnight.Lightbringer development by creating an account on GitHub.

light zodiac Jun 19, 2021, 7:18 PM

#

Thank you

rough pulsar Jun 19, 2021, 7:23 PM

#

gonna tell something

#

thought i would play with modding api 1.5

#

and it broke during an elevator transition zotewheeze

#

the game broke

vocal spire Jun 19, 2021, 8:32 PM

#

thk's spritesheet changed

light zodiac Jun 19, 2021, 8:32 PM

#

but why tho

vocal spire Jun 19, 2021, 8:32 PM

#

¯_(ツ)_/¯

rough pulsar Jun 19, 2021, 8:32 PM

#

Team cherry 😡

vocal spire Jun 19, 2021, 8:32 PM

#

i'm not comparing them

#

maybe the fsm changed too?

rough pulsar Jun 19, 2021, 8:33 PM

#

If fsm changed then the ai did too
That's what i'm assuming

vocal spire Jun 19, 2021, 8:33 PM

#

yes the fsm is the ai

#

I'm not checking tho, someone else can

jolly oriole Jun 19, 2021, 8:57 PM

#

https://github.com/SFGrenade/HollowKnight.ModLinks so, now support for modlinks and apilinks, automatically verified and support for multiple game patches

floral blade Jun 19, 2021, 9:00 PM

#

Apilinks is just modlinks for the api ?

jolly oriole Jun 19, 2021, 9:00 PM

#

yes

floral blade Jun 19, 2021, 9:00 PM

#

And what does "automatically verified" mean ?

jolly oriole Jun 19, 2021, 9:00 PM

#

github action to validate the xml according to xml schemas that also are in the repo

#

set to do its work each push / pull request

floral blade Jun 19, 2021, 9:01 PM

#

Oh so that broken XML isn't introduced ?

rough pulsar Jun 19, 2021, 9:01 PM

#

That's awesome

jolly oriole Jun 19, 2021, 9:01 PM

#

well, that it's visible

rough pulsar Jun 19, 2021, 9:01 PM

#

floral blade Jun 19, 2021, 9:02 PM

#

Yeah I meant it wouldn't be merged into master if it's visible right

#

Sounds great!

#

I'm not super sure on the rationale behind making apilinks separate from modlinks tbh

jolly oriole Jun 19, 2021, 9:03 PM

#

IMO mapi doesn't belong in modlinks because it isn't a mod

floral blade Jun 19, 2021, 9:04 PM

#

That's true

rough pulsar Jun 19, 2021, 9:05 PM

#

I'm still not sure which is better
Mod entries for specific patches only, or mod entries with multiple patch entries in them

deep wave Jun 19, 2021, 9:05 PM

#

i think the prior makes more sense when looking at mods for older versions (ie debug) where they literally have different functionality

rough pulsar Jun 19, 2021, 9:05 PM

#

I mean 1.5 modding api is unplayable for me, considering it can hardlock me or something

#

Sometimes

copper nacelle Jun 19, 2021, 9:07 PM

#

do they have literally different functionality

floral blade Jun 19, 2021, 9:08 PM

#

IMO the simplest solution would've been keep a modlinks.xml for each patch version in its own directory in the repo.

But this way there's less files to edit and manage I guess.

#

Also, what happens when / if there is a minor patch bump of the game ?

jolly oriole Jun 19, 2021, 9:13 PM

#

new patch numbers hotdogHotdog

floral blade Jun 19, 2021, 9:14 PM

#

I hope we wouldn't need to update the entire modlinks for the new patch if it's not breaking

rough pulsar Jun 19, 2021, 9:14 PM

#

Isn't there an option to make your mod be installable from modlinks in pre-1.5 and post-1.5?

#

Oh nevermind I realized 1.2.2.1 was a thing

floral blade Jun 19, 2021, 9:16 PM

#

Perhaps add an option to only check the major game version then ?

Like 1.2 => all 1.2.x.xxx
1.4 => all 1.4.x.xxx
1.5 => all 1.5.x.xxx

rough pulsar Jun 19, 2021, 9:17 PM

#

^^

#

~~Or just let us decide required DLCs~~

#

Like

copper nacelle Jun 19, 2021, 9:23 PM

#

supporting more patches is so much work

#

all the file formats are fucked

rough pulsar Jun 19, 2021, 9:28 PM

#

@proven plover I think SFCore is what you need to make custom charms

proven plover Jun 19, 2021, 9:28 PM

#

Oh

rough pulsar Jun 19, 2021, 9:29 PM

#

Reference SFCore

#

See if that works

proven plover Jun 19, 2021, 9:29 PM

#

Thanks

#

I'll try that

rough pulsar Jun 19, 2021, 9:29 PM

#

Also custom charms api documentation https://radiance.host/apidocs/SFCore.html#add-custom-charms

proven plover Jun 19, 2021, 9:34 PM

#

All of the solutions in the file are erroring. Its the same thing that happens. When I try to follow the tutorials on the docs.

#

I think I don't have a reference or something

vocal spire Jun 19, 2021, 9:36 PM

#

customknight + leak

proven plover Jun 19, 2021, 9:36 PM

#

Whats going on there?

vocal spire Jun 19, 2021, 9:37 PM

#

replacing sprites through a json file

proven plover Jun 19, 2021, 9:37 PM

#

oh

jolly oriole Jun 19, 2021, 9:37 PM

#

proven plover I think I don't have a reference or something

https://radiance.host/apidocs/Getting-Started.html#creating-mods should help

vocal spire Jun 19, 2021, 9:37 PM

#

customknight + json leak

📎 message.txt

proven plover Jun 19, 2021, 9:37 PM

#

ok

rough pulsar Jun 19, 2021, 9:37 PM

#

BB 2 palehmm

vocal spire Jun 19, 2021, 9:37 PM

#

charm backboards

proven plover Jun 19, 2021, 9:37 PM

#

Thanks for helping!

copper nacelle Jun 19, 2021, 9:37 PM

#

Bloodborne 2

rough pulsar Jun 19, 2021, 9:38 PM

#

Hell 2

jolly oriole Jun 19, 2021, 9:38 PM

#

vocal spire customknight + json leak

6 KB json salubraS

floral blade Jun 19, 2021, 9:38 PM

#

vocal spire charm backboards

are you manually coding all game objects ? or are you planning on using the preload paths ?

vocal spire Jun 19, 2021, 9:39 PM

#

?

#

wdym

floral blade Jun 19, 2021, 9:40 PM

#

perhaps json could contain "Ruins2_03_boss", "Battle Control/Black Knight 2/Corpse Black Knight 1(Clone)"
and then the file to replace this GOs sprite with

vocal spire Jun 19, 2021, 9:40 PM

#

I have code that checks every spriterenderer on scene load and checks when a component is added to a go if it's a spriterenderer. if the json file has an entry with a name that matches the go(no path) it adds a component that will set the sprite on enable

proven plover Jun 19, 2021, 9:41 PM

#

Which file in sfcore do I reference?

vocal spire Jun 19, 2021, 9:41 PM

#

CharmHelper?

#

there's a page in the apidocs specifically for sfcore

floral blade Jun 19, 2021, 9:41 PM

#

vocal spire I have code that checks every spriterenderer on scene load and checks when a com...

nice, works for what i was thinking

#

basically allows to reskin the entire game

jolly oriole Jun 19, 2021, 9:41 PM

#

proven plover Which file in sfcore do I reference?

just the DLL

vocal spire Jun 19, 2021, 9:41 PM

#

that's only for spriterenderers

rough pulsar Jun 19, 2021, 9:41 PM

#

vocal spire there's a page in the apidocs specifically for sfcore

That's where I linked them to.

vocal spire Jun 19, 2021, 9:42 PM

#

tk2d stuff is similar

floral blade Jun 19, 2021, 9:42 PM

#

some GOs might spawn later though, not on scene load right ?

#

(i ask because i do not know)

vocal spire Jun 19, 2021, 9:43 PM

#

hmmm

dark wigeon Jun 19, 2021, 9:43 PM

#

is that why you were trying to hook awake

vocal spire Jun 19, 2021, 9:43 PM

#

yes

#

but spriterenderer has no awake

#

so I went to constructor

#

but that didn't work

#

then I went to setactive

#

that died

#

then I went to AddComponent

dark wigeon Jun 19, 2021, 9:43 PM

#

isn't there some kind of fsm call that you could patch

vocal spire Jun 19, 2021, 9:44 PM

#

?

floral blade Jun 19, 2021, 9:45 PM

#

i assume preloading is out of question so that you can support a large number of objects ?

vocal spire Jun 19, 2021, 9:45 PM

#

yep

#

plus it wouldn't work for spriterenderers

copper nacelle Jun 19, 2021, 9:45 PM

#

preloading pauseshroom

jolly oriole Jun 19, 2021, 9:46 PM

#

copper nacelle preloading <:pauseshroom:828191992969166868>

https://github.com/SFGrenade/BossModCore/blob/master/MonoBehaviours/CustomBossCopy.cs doing this garbage shroompog

rough pulsar Jun 19, 2021, 9:46 PM

#

How do you load data into a Sprite class anyways

vocal spire Jun 19, 2021, 9:46 PM

#

Sprite.Create?

proven plover Jun 19, 2021, 9:46 PM

#

jolly oriole just the DLL

I can't find a dll in the sfcore file anywhere

vocal spire Jun 19, 2021, 9:46 PM

#

Texture2D.LoadImage?

vocal spire Jun 19, 2021, 9:46 PM

#

proven plover I can't find a dll in the sfcore file anywhere

did you download the source code

jolly oriole Jun 19, 2021, 9:47 PM

#

proven plover I can't find a dll in the sfcore file anywhere

have you tried the one from modinstaller, alternatively from the releases?

proven plover Jun 19, 2021, 9:47 PM

#

From github?

rough pulsar Jun 19, 2021, 9:47 PM

#

vocal spire Sprite.Create?

I'm stupid shroompog

proven plover Jun 19, 2021, 9:47 PM

#

I have not tried other versions yet

vocal spire Jun 19, 2021, 9:48 PM

#

?

proven plover Jun 19, 2021, 9:48 PM

#

I'll try to download the source code

vocal spire Jun 19, 2021, 9:48 PM

#

no

jolly oriole Jun 19, 2021, 9:48 PM

#

proven plover I have not tried other versions yet

yea, you need to reference SFCore.dll, which you can get from either the github releases (idk which version though), or the one modinstaller downloads

proven plover Jun 19, 2021, 9:48 PM

#

ok

#

I get an error every time I try to download sfcore

#

It says there was an unhandled exception that occured.

#

I'll just download the files

jolly oriole Jun 19, 2021, 9:54 PM

#

if you're targeting 1.4.3.2 for mods, use https://github.com/SFGrenade/SFCore/releases/download/v1.4.3.4/SFCore.zip

proven plover Jun 19, 2021, 10:00 PM

#

thanks!

#

hope it works!

dark wigeon Jun 19, 2021, 10:02 PM

#

vocal spire ?

what places does a gameobject with a sprite get created other than scene load
what I'm trying to say is, instead of patching the unity gameobject create event, can
you not just patch the few methods that exist to spawn enemies and such?

jolly oriole Jun 19, 2021, 10:03 PM

#

spawnfromglobalpool

proven plover Jun 19, 2021, 10:03 PM

#

Do you you know where I can find the modcommon dll?

#

I found it

floral blade Jun 19, 2021, 10:09 PM

#

there's also the matter of wanting to batch modify objects

floral blade Jun 19, 2021, 10:09 PM

#

vocal spire customknight + leak

in case , for example someone wanted to modify all of these BB thingies

jolly oriole Jun 19, 2021, 10:31 PM

#

is customknight+ gonna be 1.5?

vocal spire Jun 19, 2021, 10:34 PM

#

dark wigeon what places does a gameobject with a sprite get created other than scene load wh...

Ex: new GameObject() from a mod

dark wigeon Jun 19, 2021, 10:34 PM

#

oof then

#

and addcomponent won't work because extern?

jolly oriole Jun 19, 2021, 10:41 PM

#

is 1432 support needed? single patch support seems easier i heard

#

also gives us more people that ask in #modding-help because their pirated copies can't get the new mods

vocal spire Jun 19, 2021, 11:09 PM

#

dark wigeon and addcomponent won't work because extern?

It does work

vocal spire Jun 19, 2021, 11:26 PM

#

jolly oriole is 1432 support needed? single patch support seems easier i heard

What about 32 bit support

copper nacelle Jun 19, 2021, 11:26 PM

#

who tf uses 32 bit

#

even vs is going 64 bit

jolly oriole Jun 19, 2021, 11:28 PM

#

vocal spire What about 32 bit support

its 2021

floral blade Jun 19, 2021, 11:30 PM

#

i think keeping older mods that may or may not be updated usable by down patching is enough

#

new mods shouldn't really need to support both patches

#

mod installer having a dropdown to pick the right patch would be a bonus, not a core necessity

copper nacelle Jun 19, 2021, 11:33 PM

#

i don't want to support 4 zip file paths

#

either way someone gets annoyed at how i extract it

floral blade Jun 19, 2021, 11:35 PM

#

give a field in modlinks to choose where to extract the zip and respect directorie structure inside the zip beyond that ?

copper nacelle Jun 19, 2021, 11:36 PM

#

we had that

jolly oriole Jun 19, 2021, 11:36 PM

#

why github

copper nacelle Jun 19, 2021, 11:36 PM

#

it had the same value for everything despite people using different paths

floral blade Jun 19, 2021, 11:37 PM

#

tbh, people probably didn't know that even existed

jolly oriole Jun 19, 2021, 11:38 PM

#

even better, now just have everyone have their dll files at the zip root

copper nacelle Jun 19, 2021, 11:38 PM

#

yeah that's what i want

#

easier

vocal spire Jun 19, 2021, 11:38 PM

#

Why didn’t people do that before

floral blade Jun 19, 2021, 11:38 PM

#

jolly oriole even better, now just have everyone have their dll files at the zip root

works if they only want to put them in /mods

#

is there a reason to replace any of the other game files ?

copper nacelle Jun 19, 2021, 11:39 PM

#

not really afaik

vocal spire Jun 19, 2021, 11:39 PM

#

Discord rpc needs to be in the plugins folder

jolly oriole Jun 19, 2021, 11:39 PM

#

~~only~~ the cursed assets replacing TWP customknight skins would

floral blade Jun 19, 2021, 11:39 PM

#

jolly oriole ~~only~~ the cursed assets replacing TWP customknight skins would

yeah thats what i'd seen doing this before

jolly oriole Jun 19, 2021, 11:40 PM

#

but those also aren't installed with the modinstaller afaik

floral blade Jun 19, 2021, 11:41 PM

#

it makes sense then to just extract whatever the zip has inside mods directory. it should not be MI's job to install a mod that's packaged incorrectly

#

having an install script might be nice though

#

for people who need to do custom stuff to install their mods

#

maybe the first time a mod is loaded after an update, a particular method could be called before initialise ? this would allow the mod to setup whatever weird stuff it needs to to work properly.