#archived-modding-development | Hollow Knight | Page 519

rough pulsar Jun 7, 2021, 6:53 PM

#

i tested your mapi and the "Start game" just said "Start" in my own screen

jolly oriole Jun 7, 2021, 6:54 PM

#

poggers

rough pulsar Jun 7, 2021, 6:54 PM

#

h le same thing

#

and no Modding API thing at top left

jolly oriole Jun 7, 2021, 6:54 PM

#

you have no Mods folder maybe?

rough pulsar Jun 7, 2021, 6:54 PM

#

i do

#

maybe i didnt put in all of the dlls

light zodiac Jun 7, 2021, 6:57 PM

#

What's your keybinds?

rough pulsar Jun 7, 2021, 6:57 PM

#

there we go

#

jolly oriole Jun 7, 2021, 6:58 PM

#

why does mapi rename start to start game lol

rough pulsar Jun 7, 2021, 6:58 PM

#

i mean it originally was Start Game

patent zealot Jun 7, 2021, 6:58 PM

#

rough pulsar Jun 7, 2021, 6:59 PM

#

hunt, i was able to quit the game without any problems

patent zealot Jun 7, 2021, 6:59 PM

#

modinstaller is biased

#

yhtsi

rough pulsar Jun 7, 2021, 7:00 PM

#

~~i install mods without any modinstaller~~

#

maybe i should prepare a batch file that lets you manually install mods

#

or a powershell script

patent zealot Jun 7, 2021, 7:00 PM

#

i meant modding api

#

idk why i said modinstaller

rough pulsar Jun 7, 2021, 7:00 PM

#

oh

#

alright

fair rampart Jun 7, 2021, 7:03 PM

#

now I don't have errors in the project but when I try to compile it says that it cannot find modcommon, modding etc, even if they are referenced and imported in the project with no errors

rough pulsar Jun 7, 2021, 7:04 PM

#

what are you trying to compile

jolly jungle Jun 7, 2021, 7:05 PM

#

beautiful

rough pulsar Jun 7, 2021, 7:05 PM

#

oh, make sure the references in the list have no yellow warning signs

jolly jungle Jun 7, 2021, 7:05 PM

#

Who made?

#

anyways

patent zealot Jun 7, 2021, 7:05 PM

#

a friend

jolly jungle Jun 7, 2021, 7:05 PM

#

How do I look at Colosseum enemies' FSMs?

fair rampart Jun 7, 2021, 7:06 PM

#

rough pulsar oh, make sure the references in the list have no yellow warning signs

yes they dont have

vocal spire Jun 7, 2021, 7:07 PM

#

then they are probably either missing or for the wrong version

fair rampart Jun 7, 2021, 7:10 PM

#

probably the version is the problem

light zodiac Jun 7, 2021, 7:11 PM

#

patent zealot

Idk it works find for me

#

That's with the F1 menu open

patent zealot Jun 7, 2021, 7:12 PM

#

im on 1.5

fair rampart Jun 7, 2021, 7:12 PM

#

for example if I try to compile daughter of hallownest

patent zealot Jun 7, 2021, 7:12 PM

#

oh wait that wasnt to me

rough pulsar Jun 7, 2021, 7:12 PM

#

try re-adding references

#

doflamnigo

light zodiac Jun 7, 2021, 7:13 PM

#

@ hunt does that bug happen with debug removed?

patent zealot Jun 7, 2021, 7:13 PM

#

yea

light zodiac Jun 7, 2021, 7:14 PM

#

I thought it was debug problem lol

patent zealot Jun 7, 2021, 7:14 PM

#

i uninstalled the modding api, and it worked and trie with no mods and only the api and it didnt work

rough pulsar Jun 7, 2021, 7:14 PM

#

he mentioned it previously

light zodiac Jun 7, 2021, 7:14 PM

#

Oh just read it

#

Mb

jolly oriole Jun 7, 2021, 7:18 PM

#

noooooooo

rough pulsar Jun 7, 2021, 7:19 PM

#

scared

primal latch Jun 7, 2021, 7:19 PM

#

This channel hasn't been this active in ages

light zodiac Jun 7, 2021, 7:19 PM

#

jolly oriole noooooooo

Welp guess I'm staying on 1.4

jolly oriole Jun 7, 2021, 7:19 PM

#

UnityEngine.Object.DontDestroyOnLoad threw an nre

#

nice

primal latch Jun 7, 2021, 7:20 PM

#

yes. Chromebooks waiting like .5 seconds before typing a space that way you type another letter before it

jolly oriole Jun 7, 2021, 7:21 PM

#

oh no

#

it's assetbundle related

rough pulsar Jun 7, 2021, 7:22 PM

#

the error??

jolly oriole Jun 7, 2021, 7:22 PM

#

my thing

vocal spire Jun 7, 2021, 7:22 PM

#

oof

#

random blame: custom materials

jolly oriole Jun 7, 2021, 7:23 PM

#

it's audio

vocal spire Jun 7, 2021, 7:23 PM

#

oh nice

#

pale court will be fun

#

surprised fyremoth was able to load, has a video

rough pulsar Jun 7, 2021, 7:24 PM

#

since jumping from 2017 to 2020 is a huge gap

vocal spire Jun 7, 2021, 7:24 PM

#

also getting pretty far on adding multiple patch support to mod installer

rough pulsar Jun 7, 2021, 7:24 PM

#

i'm sure this is going to frustrate a lot of people 🙃

vocal spire Jun 7, 2021, 7:24 PM

#

time to customize modlinks

rough pulsar Jun 7, 2021, 7:24 PM

#

vocal spire also getting pretty far on adding multiple patch support to mod installer

really

#

cool

#

i'm going to make a branch in my github mod page

#

basically like, 1.4.3.2 edition

#

question, does 1.2.2.1 also use .NET Framework 3.5?@vocal spire

copper nacelle Jun 7, 2021, 7:25 PM

#

Yes

rough pulsar Jun 7, 2021, 7:25 PM

#

ah

#

thanks for the heads-up

copper nacelle Jun 7, 2021, 7:26 PM

#

We do a little NUKEing

rough pulsar Jun 7, 2021, 7:26 PM

#

now time to observe unity 2020 documentation elderC

jolly oriole Jun 7, 2021, 7:27 PM

#

specifically the last audio file i try to DontDestroyOnLoad doesn't work lol

#

wait, is it even in the bundle

vocal spire Jun 7, 2021, 7:28 PM

#

doesn't don't destroy only work on gameobjects and components

rough pulsar Jun 7, 2021, 7:28 PM

#

well

#

every object in unity seems to have DontDestroyOnLoad

jolly oriole Jun 7, 2021, 7:28 PM

#

mystery solved, i can't load what never was

rough pulsar Jun 7, 2021, 7:28 PM

#

zotewheeze

vocal spire Jun 7, 2021, 7:28 PM

#

zote

#

ah yes code just appears

jolly oriole Jun 7, 2021, 7:29 PM

#

in the meantime, i started hk a total of 4250 times by now

vocal spire Jun 7, 2021, 7:29 PM

#

let me load some code that doesn't exist from vs

vocal spire Jun 7, 2021, 7:29 PM

#

jolly oriole in the meantime, i started hk a total of 4250 times by now

nice

rough pulsar Jun 7, 2021, 7:29 PM

#

how does one keep track of such number

jolly oriole Jun 7, 2021, 7:29 PM

#

part of registry on windows, i have a small script that prints such information

rough pulsar Jun 7, 2021, 7:29 PM

#

nvm

#

oh

copper nacelle Jun 7, 2021, 7:30 PM

#

give

jolly oriole Jun 7, 2021, 7:30 PM

#

here, have

#

foreach (var keyname in Registry.CurrentUser.OpenSubKey("SOFTWARE").OpenSubKey("Team Cherry").OpenSubKey("Hollow Knight").GetValueNames())
{
    if (keyname.Contains("_"))
    {
        string paddedName = keyname.Substring(0, keyname.LastIndexOf('_'));
        try
        {
            string decryptedName = Encryption.Decrypt(paddedName);
            string ret = (string) typeof(PlayerPrefsSharedData).GetMethod("ReadEncrypted", BindingFlags.NonPublic | BindingFlags.Instance).Invoke(Platform.Current.EncryptedSharedData, new object[] { decryptedName });

            Log($"Raw Key: '{decryptedName}': '{ret}'");
        }
        catch (Exception e)
        {
            string retString = PlayerPrefs.GetString(paddedName, "DOESN'T EXIST");
            if (retString.Equals("DOESN'T EXIST"))
            {
                float retfloat = PlayerPrefs.GetFloat(paddedName, -123.456f);
                if (retfloat.Equals(-123.456f))
                {
                    Log($"Other Key: '{paddedName}': '{PlayerPrefs.GetInt(paddedName, 0)}'");
                }
                else
                {
                    Log($"Float Key: '{paddedName}': '{retfloat}'");
                }
            }
            else
            {
                Log($"String Key: '{paddedName}': '{retString}'");
            }
        }
    }
}

rough pulsar Jun 7, 2021, 7:32 PM

#

while 4.7.2 has arrived

#

i'm gonna check if it has proper zip archiving tools

#

if it does, great, if it doesn't, fuck

vocal spire Jun 7, 2021, 7:32 PM

#

ayyy, got separate mod lists from different patches

fair rampart Jun 7, 2021, 7:32 PM

#

no, complilig still says that all references are missing

#

I'll continue tomorrow

rough pulsar Jun 7, 2021, 7:33 PM

#

time to

#

look up a tutorial on how to extract zip files hollowcool

#

YO

jolly oriole Jun 7, 2021, 7:34 PM

#

how is save mod data stored again?

rough pulsar Jun 7, 2021, 7:34 PM

#

I CAN EXTRACT ARCHIVES IN .NET FRAMEWORK 4.7.2

vocal spire Jun 7, 2021, 7:34 PM

#

what discord

#

I sent a message

#

here

jolly oriole Jun 7, 2021, 7:34 PM

#

rip

vocal spire Jun 7, 2021, 7:34 PM

#

and clyde is.....?

jolly oriole Jun 7, 2021, 7:34 PM

#

bot

vocal spire Jun 7, 2021, 7:34 PM

#

bruh, I just want to send the example of the new modlinks

rough pulsar Jun 7, 2021, 7:35 PM

#

try and send it again

#

.

vocal spire Jun 7, 2021, 7:35 PM

#

I did

#

well it would look terrible in discord anyways, screenshot time

rough pulsar Jun 7, 2021, 7:35 PM

#

dm the file to someone here and ask them to repost it here

vocal spire Jun 7, 2021, 7:36 PM

#

rough pulsar Jun 7, 2021, 7:36 PM

#

looks like we have to include seperate patch blocks ourselves

vocal spire Jun 7, 2021, 7:36 PM

#

someone should write a program to convert the old modlinks

rough pulsar Jun 7, 2021, 7:37 PM

#

do you plan to enabling the user to choose which patch to install

charred topaz Jun 7, 2021, 7:37 PM

#

Did 1.5 just come out?

vocal spire Jun 7, 2021, 7:37 PM

#

I plan to have some detection system

jolly oriole Jun 7, 2021, 7:37 PM

#

yes

vocal spire Jun 7, 2021, 7:37 PM

#

yee

rough pulsar Jun 7, 2021, 7:37 PM

#

yeah it did

vocal spire Jun 7, 2021, 7:37 PM

#

I was up at 5am this morning updating mods

rough pulsar Jun 7, 2021, 7:37 PM

#

your mod will not work in 1.5 unless you change the .net framework to 4.7.2

cedar hemlock Jun 7, 2021, 7:37 PM

#

charred topaz Did 1.5 just come out?

Lil late but ye

vocal spire Jun 7, 2021, 7:37 PM

#

I slept until 11

vocal spire Jun 7, 2021, 7:38 PM

#

rough pulsar your mod will not work in 1.5 unless you change the .net framework to 4.7.2

also a myriad of other changes

rough pulsar Jun 7, 2021, 7:38 PM

#

unity 2020.2

#

and ingame patches

vocal spire Jun 7, 2021, 7:38 PM

#

modsettings has been killed in new api

rough pulsar Jun 7, 2021, 7:38 PM

#

tbh i've been looking forward to this update

#

because working with .net framework 3.5 was tedious and harder in my case

charred topaz Jun 7, 2021, 7:40 PM

#

crap, just had to come out when I'm busy on homework. I'll see if I can find an opportunity sometime to get my mods working. At least I no longer have to have 2 separate branches for each game version.

rough pulsar Jun 7, 2021, 7:40 PM

#

dang

vocal spire Jun 7, 2021, 7:40 PM

#

you do if you want 32 bit compatibility

rough pulsar Jun 7, 2021, 7:40 PM

#

yeah

vocal spire Jun 7, 2021, 7:40 PM

#

kinda why I'm making this installer update

jolly oriole Jun 7, 2021, 7:41 PM

#

oh yea, 64 bit

rough pulsar Jun 7, 2021, 7:41 PM

#

uhm

#

i just remembered...

#

last time i tried to download from discord using code

#

it failed

vocal spire Jun 7, 2021, 7:41 PM

#

?

rough pulsar Jun 7, 2021, 7:42 PM

#

like yknow

#

i tried to set up a code that would install discord game sdk files to set up the discord rich presence without having the user do it

jolly oriole Jun 7, 2021, 7:43 PM

#

oh yea, that

rough pulsar Jun 7, 2021, 7:43 PM

#

and downloading from discord threw a Forbidden error code

vocal spire Jun 7, 2021, 7:43 PM

#

upload the file to google drive?

rough pulsar Jun 7, 2021, 7:43 PM

#

doing curl on ocmmandline worked

rough pulsar Jun 7, 2021, 7:43 PM

#

vocal spire upload the file to google drive?

oh yeah i didn't think about that 😓 sure

#

i can try that

cedar hemlock Jun 7, 2021, 7:44 PM

#

I havent veen keeping up with this, so whats gonna change with modlinks and stuff?

rough pulsar Jun 7, 2021, 7:44 PM

#

for now ima wait for visual studio to open the solution

light zodiac Jun 7, 2021, 7:44 PM

#

vocal spire

Why is it <Name>1.4.3.2<\Name>

rough pulsar Jun 7, 2021, 7:44 PM

#

cedar hemlock I havent veen keeping up with this, so whats gonna change with modlinks and stuf...

different patch blocks and stuff

cedar hemlock Jun 7, 2021, 7:44 PM

#

Patch name

rough pulsar Jun 7, 2021, 7:44 PM

#

also.

jolly oriole Jun 7, 2021, 7:44 PM

#

light zodiac Why is it <Name>1.4.3.2<\Name>

don't get to the link that's a local path

rough pulsar Jun 7, 2021, 7:44 PM

#

shouldn't you set this to something like

#

maybe not patch specific

copper nacelle Jun 7, 2021, 7:45 PM

#

32 bit compatability kinda cringe

vocal spire Jun 7, 2021, 7:45 PM

#

I'm using local paths because it's easier atm

rough pulsar Jun 7, 2021, 7:45 PM

#

i'm choosing to support 32-bit users hollowcool

vocal spire Jun 7, 2021, 7:45 PM

#

same

vocal spire Jun 7, 2021, 7:45 PM

#

light zodiac Why is it <Name>1.4.3.2<\Name>

the patch name?

jolly oriole Jun 7, 2021, 7:45 PM

#

i'm putting memory huggers in all my mods so only people with 10+ GB of spare RAM can play my mods

#

😎

vocal spire Jun 7, 2021, 7:46 PM

#

jolly oriole i'm putting memory huggers in all my mods so only people with 10+ GB of spare RA...

well imma die cya

rough pulsar Jun 7, 2021, 7:46 PM

#

me with 4 gb

#

scared

vocal spire Jun 7, 2021, 7:48 PM

#

would checking assembly-csharp's hash be a good way to detect patches?

rough pulsar Jun 7, 2021, 7:48 PM

#

sure

#

just

#

choose to support below 1.4.3.2 as well

floral blade Jun 7, 2021, 7:48 PM

#

vocal spire would checking assembly-csharp's hash be a good way to detect patches?

What happens when mapi updates ?

rough pulsar Jun 7, 2021, 7:48 PM

#

there are modding apis for 1.2.2.1

vocal spire Jun 7, 2021, 7:48 PM

#

rough pulsar just

ik

vocal spire Jun 7, 2021, 7:49 PM

#

floral blade What happens when mapi updates ?

we add 2(or more) hashes per patch

#

ohhh when it updates

#

maybe checking another file would be a good idea

ornate rivet Jun 7, 2021, 7:49 PM

#

is it really a good idea to continue supporting 1.4?
People who want to use it can just use the old modinstaller

rough pulsar Jun 7, 2021, 7:49 PM

#

mscorlib seemed to appear only in 1.5

rough pulsar Jun 7, 2021, 7:49 PM

#

ornate rivet is it really a good idea to continue supporting 1.4? People who want to use it c...

there are people with 32-bit computers

vocal spire Jun 7, 2021, 7:49 PM

#

but versions before 1.4

floral blade Jun 7, 2021, 7:49 PM

#

Or could you check the version inside the DLL?

rough pulsar Jun 7, 2021, 7:50 PM

#

^^

ornate rivet Jun 7, 2021, 7:50 PM

#

that's they're fault, it's 2021

vocal spire Jun 7, 2021, 7:50 PM

#

floral blade Or could you check the version inside the DLL?

ah yeah

rough pulsar Jun 7, 2021, 7:50 PM

#

lacestare

vocal spire Jun 7, 2021, 7:50 PM

#

ornate rivet that's they're fault, it's 2021

well im finding editing mod installer fun so I will add it

dark wigeon Jun 7, 2021, 7:50 PM

#

~~if they are on 32bit they don't have a good enough computer to run mods anyway~~

copper nacelle Jun 7, 2021, 7:51 PM

#

true

rough pulsar Jun 7, 2021, 7:51 PM

#

4 errors right after opening the solution hollowcool

dark wigeon Jun 7, 2021, 7:51 PM

#

computers have been mostly 64 bit for ages

vocal spire Jun 7, 2021, 7:51 PM

#

get rid of instance

#

everything is static now

floral blade Jun 7, 2021, 7:51 PM

#

As long as it's not confusing for players I'm all for supporting 32 bit

pale crest Jun 7, 2021, 7:51 PM

#

prob late to the party but new update won't allow mods?

vocal spire Jun 7, 2021, 7:51 PM

#

yep

pale crest Jun 7, 2021, 7:52 PM

#

rip

vocal spire Jun 7, 2021, 7:52 PM

#

unless you manually install the 1.5 api

ornate rivet Jun 7, 2021, 7:52 PM

#

wat, yea it will

dark wigeon Jun 7, 2021, 7:52 PM

#

as long as it's not a hassle supporting 1.4 and 1.5

rough pulsar Jun 7, 2021, 7:52 PM

#

vocal spire get rid of instance

that seemed to fix it, thanks

vocal spire Jun 7, 2021, 7:52 PM

#

i'm doing the hassle for ya so

floral blade Jun 7, 2021, 7:52 PM

#

dark wigeon as long as it's not a hassle supporting 1.4 and 1.5

And this yes

vocal spire Jun 7, 2021, 7:52 PM

#

¯_(ツ)_/¯

floral blade Jun 7, 2021, 7:53 PM

#

vocal spire i'm doing the hassle for ya so

The mod itself would still need to be made for both old and new mapi / hk

fair rampart Jun 7, 2021, 7:53 PM

#

I noticed that if I install moddingAPI tha game is not working anymore

floral blade Jun 7, 2021, 7:53 PM

#

Unless you plan on making frogcore normalise the API

vocal spire Jun 7, 2021, 7:53 PM

#

fair rampart I noticed that if I install moddingAPI tha game is not working anymore

did you install the 1.5 one

rough pulsar Jun 7, 2021, 7:53 PM

#

my mod's not that complicated (thankfully!) so i can easily port my mod to both 1.4.3.2/1.2.2.1 AND 1.5

fair rampart Jun 7, 2021, 7:54 PM

#

vocal spire did you install the 1.5 one

a new moddingAPI?

rough pulsar Jun 7, 2021, 7:54 PM

#

yeah

#

compile the ModdingAPI yourself

fair rampart Jun 7, 2021, 7:54 PM

#

ah no

vocal spire Jun 7, 2021, 7:54 PM

#

can someone else link the pre compiled api

rough pulsar Jun 7, 2021, 7:54 PM

#

oh yaeh

#

yeah

vocal spire Jun 7, 2021, 7:54 PM

#

floral blade The mod itself would still need to be made for both old and new mapi / hk

you can choose which patches it supports

#

if it doesn't have a patch for the current patch, modinstaller won't show it

rough pulsar Jun 7, 2021, 7:55 PM

#

#archived-modding-development message

#

make sure to use every dll found in there

vocal spire Jun 7, 2021, 7:55 PM

#

vocal spire if it doesn't have a patch for the current patch, modinstaller won't show it

at least from what I've coded this is the case

floral blade Jun 7, 2021, 7:55 PM

#

vocal spire you can choose which patches it supports

Installer support is great I think(as long as it's not making the ux complex). I was talking about mods actually continuing versions for both the versions of the game

rough pulsar Jun 7, 2021, 7:56 PM

#

i forgot to set my mod's target framework

vocal spire Jun 7, 2021, 7:57 PM

#

floral blade Installer support is great I think(as long as it's not making the ux complex). I...

ah, I'm arguing for installer support

fair rampart Jun 7, 2021, 7:57 PM

#

rough pulsar https://discord.com/channels/283467363729408000/327461802311155714/8514788724741...

so i have to put extracted files where the readme says not in Managed folder?

floral blade Jun 7, 2021, 7:58 PM

#

vocal spire at least from what I've coded this is the case

You could simplify it to just use 2 modlinks , that way only mods available in a version would be in its file

vocal spire Jun 7, 2021, 7:58 PM

#

fair rampart so i have to put extracted files where the readme says not in Managed folder?

in your managed folder. the readme said the managed folder?

floral blade Jun 7, 2021, 7:58 PM

#

And any number of patches could be supported with just creating a new modlinks

#

Past or future

vocal spire Jun 7, 2021, 7:59 PM

#

floral blade You could simplify it to just use 2 modlinks , that way only mods available in a...

then we have a whole modlinks file for each patch, that will get annoying at some point. If all patches are right next to eachother then it's easier to manage updates

rough pulsar Jun 7, 2021, 7:59 PM

#

hollowdefault

#

cool

vocal spire Jun 7, 2021, 7:59 PM

#

kool

floral blade Jun 7, 2021, 7:59 PM

#

vocal spire then we have a whole modlinks file for each patch, that will get annoying at som...

I'd expect older patches to be full of archived mods and the occasional current mods

rough pulsar Jun 7, 2021, 8:00 PM

#

now i can unzip files without using outside libraries

fair rampart Jun 7, 2021, 8:00 PM

#

vocal spire in your managed folder. the readme said the managed folder?

no, in C:\Program Files (x86)\Steam\steamapps\common\Hollow Knight\

rough pulsar Jun 7, 2021, 8:00 PM

#

feels like a dream

vocal spire Jun 7, 2021, 8:01 PM

#

fair rampart no, in C:\Program Files (x86)\Steam\steamapps\common\Hollow Knight\

then in Managed

fair rampart Jun 7, 2021, 8:01 PM

#

vocal spire then in Managed

ah so I did earlier

vocal spire Jun 7, 2021, 8:01 PM

#

floral blade I'd expect older patches to be full of archived mods and the occasional current ...

but this way if a mod is updated, the creator can update the values for all patches in the same file

fair rampart Jun 7, 2021, 8:02 PM

#

but next I have to build the modAPI , not use the prevoius one

vocal spire Jun 7, 2021, 8:02 PM

#

wdym

#

that file you downloaded was the 1.5 moddingapi

#

not the previous one?

rough pulsar Jun 7, 2021, 8:02 PM

#

you don't, i linked a 1.5 mapi previously.

fair rampart Jun 7, 2021, 8:04 PM

#

from that zip I extracted this

#

#

next copy them under /Managed

rough pulsar Jun 7, 2021, 8:05 PM

#

knightyes

fair rampart Jun 7, 2021, 8:07 PM

#

ok but after how I open the moddingAPI

rough pulsar Jun 7, 2021, 8:08 PM

#

you just copy all of these dlls into /Managed folder

#

and launch the game

#

make sure you have 1.5 x)

fair rampart Jun 7, 2021, 8:08 PM

#

previously I used this

ornate rivet Jun 7, 2021, 8:08 PM

#

shoot can someone send me updated QoL, slow loading times is killing me

floral blade Jun 7, 2021, 8:08 PM

#

vocal spire but this way if a mod is updated, the creator can update the values for all patc...

True, it doesn't matter much either way I think

rough pulsar Jun 7, 2021, 8:08 PM

#

sure i can try to send a link to qol download if i can real quick

#

https://drive.google.com/uc?export=download&id=1X35qzJmch1Wx24qjARbvjJXeCNq9h53k

#

it's the QoL dll

floral blade Jun 7, 2021, 8:09 PM

#

It's editing 1 file more Vs 2 files less

rough pulsar Jun 7, 2021, 8:09 PM

#

you have to put it manually into

#

C:\Program Files (x86)\Steam\steamapps\common\Hollow Knight\hollow_knight_Data\Managed\Mods

floral blade Jun 7, 2021, 8:09 PM

#

It is great that you're adding the support tho!

rough pulsar Jun 7, 2021, 8:09 PM

#

i am adding support for every version that has modding api supported 🙂

mortal nest Jun 7, 2021, 8:10 PM

#

can't wait for bonfire and health bar mods to be usable again

rough pulsar Jun 7, 2021, 8:10 PM

#

currently i am working on 1.5 version now, since that's the current one i have...

vocal spire Jun 7, 2021, 8:10 PM

#

link me a version of the moddingapi with the unmodded assembly and I'll add support

copper nacelle Jun 7, 2021, 8:10 PM

#

you can send them the qol but it won't work

#

lmao

rough pulsar Jun 7, 2021, 8:11 PM

#

yeah

#

i forgot

#

about that

rough pulsar Jun 7, 2021, 8:11 PM

#

vocal spire link me a version of the moddingapi with the unmodded assembly and I'll add supp...

wdym unmodded assembly

vocal spire Jun 7, 2021, 8:12 PM

#

unmodded assembly-csharp or at least the hash

ornate rivet Jun 7, 2021, 8:12 PM

#

oh well I won't be modding until QoL is fixed

copper nacelle Jun 7, 2021, 8:12 PM

#

📎 QoL.dll

#

📎 QoL.pdb

#

📎 Vasi.dll

#

📎 Vasi.pdb

vocal spire Jun 7, 2021, 8:12 PM

#

scary

ornate rivet Jun 7, 2021, 8:12 PM

#

well that was fast

copper nacelle Jun 7, 2021, 8:12 PM

#

might work

ornate rivet Jun 7, 2021, 8:12 PM

#

thanks

rough pulsar Jun 7, 2021, 8:12 PM

#

you mean like 1.4 assembly right

#

or just unmodded

ornate rivet Jun 7, 2021, 8:12 PM

#

is the pdb file needed?

rough pulsar Jun 7, 2021, 8:12 PM

#

i doubt, i think that's the debug file

vocal spire Jun 7, 2021, 8:13 PM

#

rough pulsar or just unmodded

if you want a moddingapi version added, send me either the unmodded assembly-csharp and modded assembly-csharp or their sha1 hashes

copper nacelle Jun 7, 2021, 8:13 PM

#

if you want errors i would take them for when it inevitably explodes

vocal spire Jun 7, 2021, 8:13 PM

#

unmodded: self explanatory
modded: moddingapi

rough pulsar Jun 7, 2021, 8:15 PM

#

alright i uploaded discord game sdk to google drive, im gonna test if it works

fair rampart Jun 7, 2021, 8:15 PM

#

ok I have done it

copper nacelle Jun 7, 2021, 8:17 PM

#

we have ci now fyi

#

took a few child sacrifices but you know you live you learn

vocal spire Jun 7, 2021, 8:17 PM

#

???

copper nacelle Jun 7, 2021, 8:17 PM

#

what

vocal spire Jun 7, 2021, 8:17 PM

#

(what's ci)

copper nacelle Jun 7, 2021, 8:17 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/runs/2767702031

#

can get the api build off artifacts at any point

vocal spire Jun 7, 2021, 8:18 PM

#

oh ok

copper nacelle Jun 7, 2021, 8:18 PM

#

just need to get it to auto-release w/ a tag and i'll be further set

jolly oriole Jun 7, 2021, 8:22 PM

#

poggers

patent zealot Jun 7, 2021, 8:25 PM

#

finally got custom grubs to save again Ameliacheer

ornate rivet Jun 7, 2021, 8:27 PM

#

very nice

vocal spire Jun 7, 2021, 8:33 PM

#

vocal spire if you want a moddingapi version added, send me either the unmodded assembly-csh...

nvm about this

jolly oriole Jun 7, 2021, 8:34 PM

#

idk if we could've started this earlier, didn't log into gog 🥴 (may have been on gog for 5 days already)

copper nacelle Jun 7, 2021, 8:35 PM

#

lmao

fair rampart Jun 7, 2021, 8:39 PM

#

now I have only these errors

#

vocal spire Jun 7, 2021, 8:39 PM

#

remove instance from the modhooks stuff, everything is static now

fair rampart Jun 7, 2021, 8:40 PM

#

ah ok. I was looking from daughter of hallownest project

ornate rivet Jun 7, 2021, 8:42 PM

#

daughter of hallownest? that hasn't been updated to 1.5, don't look at that

fair rampart Jun 7, 2021, 8:42 PM

#

ornate rivet daughter of hallownest? that hasn't been updated to 1.5, don't look at that

yes but for learning modding I was looking at that

ornate rivet Jun 7, 2021, 8:43 PM

#

that's one of the older mods, some of the implementation in it is not the best

vocal spire Jun 7, 2021, 8:47 PM

#

currently I'm trying to figure out why I added the current patch to the installer's settings and if I should revert that change

fair rampart Jun 7, 2021, 8:52 PM

#

now how can I add objects to preloadedObjects?

ornate rivet Jun 7, 2021, 8:55 PM

#

public override List<(string, string)> GetPreloadNames()
{
    return new List<(string, string)>
    {
        ("GG_Hive_Knight", "Battle Scene/Hive Knight/Slash 1"),
        ("GG_Hollow_Knight", "Battle Scene/HK Prime"),
        ("GG_Hollow_Knight", "Battle Scene/HK Prime/Counter Flash"),
        ("Abyss_05", "Dusk Knight/Dream Enter 2"),
        ("Abyss_05","Dusk Knight/Idle Pt")
    };
}

jolly oriole Jun 7, 2021, 8:56 PM

#

ornate rivet ```CSharp public override List<(string, string)> GetPreloadNames() { return ...

?

fair rampart Jun 7, 2021, 8:59 PM

#

ah, so robably somthing is still wrong with references

ornate rivet Jun 7, 2021, 9:12 PM

#

does the assetbundle browser not work in 2020?

jolly oriole Jun 7, 2021, 9:14 PM

#

latest release of it is from 2018

#

latest commit is from late 2019

ornate rivet Jun 7, 2021, 9:16 PM

#

so...did the latest release/commit work for you?

jolly oriole Jun 7, 2021, 9:16 PM

#

idk, i don't use it lol

#

though the latest commit might work

#

as 2020.2 was probably released before 2020

ornate rivet Jun 7, 2021, 9:17 PM

#

alright

fair rampart Jun 7, 2021, 9:17 PM

#

for GetPreloadedNames says that reference to type (,) is not found in mscorlib

copper nacelle Jun 7, 2021, 9:18 PM

#

Are you using the right mscorlib?

#

This is net 4 so it should have it even if you don't use hk's

ornate rivet Jun 7, 2021, 9:20 PM

#

what are Addressables?

fair rampart Jun 7, 2021, 9:20 PM

#

copper nacelle Are you using the right mscorlib?

I tryed to add it to references but it says that it is already used by compiler

ornate rivet Jun 7, 2021, 9:20 PM

#

have you tried deleting the old one and adding the new one?

copper nacelle Jun 7, 2021, 9:21 PM

#

It's probably implicit

#

Are you going against 472?

#

3.5 is the one without tuple built in

fair rampart Jun 7, 2021, 9:22 PM

#

copper nacelle It's probably implicit

now I have updated .Net to 4.5 so I have only th problem on GetPreloadNames

#

copper nacelle Jun 7, 2021, 9:23 PM

#

are you going to show the error

#

Or just that red text

fair rampart Jun 7, 2021, 9:23 PM

#

I have translated it, it's italian

copper nacelle Jun 7, 2021, 9:24 PM

#

where

#

x5fiftM

fair rampart Jun 7, 2021, 9:26 PM

#

for GetPreloadedNames says that reference to type (,) is not found in mscorlib

vocal spire Jun 7, 2021, 9:26 PM

#

I guess I won't be playing 1.5 then....

copper nacelle Jun 7, 2021, 9:26 PM

#

472 not 45 ty

fair rampart Jun 7, 2021, 9:27 PM

#

copper nacelle 472 not 45 ty

.Net version?

copper nacelle Jun 7, 2021, 9:27 PM

#

yes

vocal spire Jun 7, 2021, 9:27 PM

#

4.7.2

copper nacelle Jun 7, 2021, 9:28 PM

#

dots kinda cold face smh

vocal spire Jun 7, 2021, 9:28 PM

#

well imma go do some more testing with the installer now

#

then I'll transition the old modlinks to new or something I guess

copper nacelle Jun 7, 2021, 9:29 PM

#

can't exactly do that when they don't exist ngl

vocal spire Jun 7, 2021, 9:29 PM

#

?

#

I'm using a local file for the modlinks atm?

jolly oriole Jun 7, 2021, 9:30 PM

#

any specific plans already for https://github.com/HollowKnight-Modding/HollowKnight.ModLinks?
like: similar to the current modlinks
or a new form, like seperate files for each mod or something

copper nacelle Jun 7, 2021, 9:31 PM

#

I was thinking same form

#

But idk

#

Actual package management kinda thing would be nice

fair rampart Jun 7, 2021, 9:34 PM

#

ok now it says that I have a double reference to System.ValueTuple2 both in mscorlib

vocal spire Jun 7, 2021, 9:35 PM

#

get rid of the valuetuple ref

#

nvm I read it wrong

#

I cannot think

fair rampart Jun 7, 2021, 9:37 PM

#

wooo finally

jolly oriole Jun 7, 2021, 9:37 PM

#

copper nacelle Actual package management kinda thing would be nice

~~i can check out how those are done tomorrow at work~~ i mean work, i work at work

ornate rivet Jun 7, 2021, 9:39 PM

#

The type or namespace name 'RuntimeServices' could not be found (are you missing a using directive or an assembly reference?)
The type or namespace name 'Boo' could not be found (are you missing a using directive or an assembly reference?)
Anyone know where I can get Boo and RuntimeServices?

jolly oriole Jun 7, 2021, 9:39 PM

#

lmao, what is Boo

fair rampart Jun 7, 2021, 9:40 PM

#

Thanks all. Sorry I am not familiar with Visual Studio and C#, I use java and Eclipse at work

#

now my mod is working again

copper nacelle Jun 7, 2021, 9:43 PM

#

why are you using Boo what the hell

#

that's long dead

ornate rivet Jun 7, 2021, 9:46 PM

#

the assetbundle browser uses it

copper nacelle Jun 7, 2021, 9:48 PM

#

Wtf

#

Boo is Unity's budget python

ornate rivet Jun 7, 2021, 9:49 PM

#

is there another assetbundle browser not by Unity?

worn eagle Jun 7, 2021, 9:49 PM

#

I yeet out everything that depends on boo to make it work

ornate rivet Jun 7, 2021, 9:50 PM

#

like you delete the files or just the methods?

worn eagle Jun 7, 2021, 9:51 PM

#

just the methods

ornate rivet Jun 7, 2021, 9:51 PM

#

ok thanks

jolly oriole Jun 7, 2021, 9:51 PM

#

according to https://docs.unity3d.com/Manual/AssetBundles-Browser.html it should work without doing anything?

ornate rivet Jun 7, 2021, 9:51 PM

#

¯_(ツ)_/¯

#

also do any of you know what addressables are? Should I be switching from assetbundles to them?

jolly oriole Jun 7, 2021, 9:53 PM

#

https://docs.unity3d.com/2020.2/Documentation/Manual/com.unity.addressables.html

Description
The Addressable Asset System allows the developer to ask for an asset via its address. Once an asset (e.g. a prefab) is marked "addressable", it generates an address which can be called from anywhere. Wherever the asset resides (local or remote), the system will locate it and its dependencies, then return it.
[...]
Addressables use asynchronous loading to support loading from any location with any collection of dependencies. Whether you have been using direct references, traditional asset bundles, or Resource folders, addressables provide a simpler way to make your game more dynamic. Addressables simultaneously opens up the world of asset bundles while managing all the complexity.
For usage samples, see github.com/Unity-Technologies/Addressables-Sample

ornate rivet Jun 7, 2021, 9:54 PM

#

honestly, I already read that and I'm not sure what it's saying

jolly oriole Jun 7, 2021, 9:55 PM

#

appears to be something like a file and you can tell unity to search for it instead of "hardcoding" file paths?

copper nacelle Jun 7, 2021, 9:55 PM

#

Remote seems to imply auto fetch

jolly oriole Jun 7, 2021, 9:56 PM

#

i'd test with it in a seperate project first

#

though you probably can't use it in a DLL as an embedded resource

vocal spire Jun 7, 2021, 9:58 PM

#

modlinks but patches

📎 newmodlinksorsomething.xml

ornate rivet Jun 7, 2021, 11:03 PM

#

any idea why in 1.5 going to a custom scene causes particles from stuff like dash and super dash to break (turn pink)
Even after going back to a scene that's not custom, the particles are still broken

dark wigeon Jun 7, 2021, 11:17 PM

#

addressables are resources.assets in bundles

#

essentially

vocal spire Jun 8, 2021, 2:00 AM

#

so I have an update to mod installer that adds support for different patches(as long as there is a moddingapi for that patch)

#

what should I do with it?

#

modlinks is rewritten so previous installer versions won't work

deep wave Jun 8, 2021, 2:05 AM

#

fwiw I had a proposal to update modlinks that shouldn't break mi1 or 2 but not at pc zote

vocal spire Jun 8, 2021, 2:10 AM

#

uploaded my changes to my fork

copper nacelle Jun 8, 2021, 3:24 AM

#

break them both

tawny onyx Jun 8, 2021, 3:25 AM

#

you can try my code. in Decoration/Util. just copy them to your project

vocal spire Jun 8, 2021, 3:27 AM

#

copper nacelle break them both

~~ah, I see you’ll like my fork~~

tawny onyx Jun 8, 2021, 3:27 AM

#

my folder keep it as

vocal spire Jun 8, 2021, 3:43 AM

#

nice I got 100
https://github.com/ricardosouzag/ModInstaller/pull/100

GitHub

Add support for multiple patches in modlinks by RedFrog6002 · Pull ...

add support for multiple patches in modlinks and add open mods folder button

tawny onyx Jun 8, 2021, 3:52 AM

#

can we merge all of these libraries to just one dll?

#

as far as i remember, 1432 api is just one file

copper nacelle Jun 8, 2021, 3:53 AM

#

no

#

I mean you can but I won't

light zodiac Jun 8, 2021, 3:53 AM

#

What's the mmhook?

copper nacelle Jun 8, 2021, 3:53 AM

#

God awful 30 mb dll with shit build times

#

it is on hooks

light zodiac Jun 8, 2021, 3:54 AM

#

Ok

tawny onyx Jun 8, 2021, 3:55 AM

#

sum of them just 14 mb

copper nacelle Jun 8, 2021, 4:15 AM

#

yeah and the repack is more than that

#

Kills any chance of being able to reasonably dnspy the result

#

Makes build times for the api significantly worse

#

It's bloat with no benefit besides being able to ref 1 dll and get 40 things as a result

primal latch Jun 8, 2021, 5:49 AM

#

Damn. You guys have made a lot of progress

ornate rivet Jun 8, 2021, 10:21 AM

#

tawny onyx you can try my code. in Decoration/Util. just copy them to your project

How would that help with custom scenes losing material/shader of certain particles?

primal latch Jun 8, 2021, 10:26 AM

#

var mat = new Material(Shader.Find("Sprites/Default"));
SpriteRenderer[] rends = FindObjectsOfType<SpriteRenderer>();
foreach (SpriteRenderer rend in rends)
{
rend.material = mat;
}

#

Run this when the new scene is loaded

#

@ornate rivet

jolly oriole Jun 8, 2021, 10:29 AM

#

that's not the problem, afaik problem is that the knight's dash loses material/shader

jolly oriole Jun 8, 2021, 10:29 AM

#

ornate rivet any idea why in 1.5 going to a custom scene causes particles from stuff like das...

like this

ornate rivet Jun 8, 2021, 10:33 AM

#

yep

floral blade Jun 8, 2021, 10:36 AM

#

github is ded, what do i do with my free time now zote

ornate rivet Jun 8, 2021, 10:36 AM

#

it's interesting that it's only the particles that are broken now

floral blade Jun 8, 2021, 10:40 AM

#

might it be that unloading the custom scene resets the materials used by that scene (not realising we'd need it for the current one as well)?

ornate rivet Jun 8, 2021, 10:45 AM

#

but why would tc make it do that for stuff like dash, that's going to be in every scene

jolly oriole Jun 8, 2021, 10:47 AM

#

wait, it's 1.5, just load all assetbundles at the mods initialize/constructor

copper nacelle Jun 8, 2021, 10:49 AM

#

moments before running out of gpu memory

jolly oriole Jun 8, 2021, 10:50 AM

#

then just download more vram

#

or just don't have 200+ MB of assetbundles lmao

primal latch Jun 8, 2021, 11:00 AM

#

jolly oriole or just don't have 200+ MB of assetbundles lmao

Me rn: oh god.

primal latch Jun 8, 2021, 11:01 AM

#

jolly oriole then just download more vram

https://downloadmoreram.com

DownloadMoreRAM.com - CloudRAM 2.0

primal latch Jun 8, 2021, 11:02 AM

#

jolly oriole wait, it's 1.5, just load all assetbundles at the mods initialize/constructor

Ah. That’s why I don’t encounter this. I load everything on initialise

floral blade Jun 8, 2021, 11:19 AM

#

finally github is up knighttoot and so is my shiny new PR

#

this might be the last update CK gets on 1432 : but it finally adds saving skins in mod settings and a fix for invisible geo
https://github.com/PrashantMohta/HollowKnight.CustomKnight/releases/tag/v1.2.4c

ornate rivet Jun 8, 2021, 11:44 AM

#

@jolly oriole
So do your new scenes from ToT work?

jolly oriole Jun 8, 2021, 11:47 AM

#

those work, but i do have exactly 0 materials and shaders in the bundles (maybe a 2dphysicsmaterial and one for custom particles)

#

so potentially not exactly 0

ornate rivet Jun 8, 2021, 11:50 AM

#

but in this case, stuff like the shadow dash particles shouldn't be related to the assetbundle's shaders/materials

#

huh the materials and particles do seem to exist in the scene

#

so why are they pink??

copper nacelle Jun 8, 2021, 11:55 AM

#

racist

#

if you get the material before entering the scene is it the same material as after exiting the scene

#

or does it get replaced

ornate rivet Jun 8, 2021, 11:57 AM

#

nvm I dont think that's the shadow dash particle material that's missing

ornate rivet Jun 8, 2021, 11:57 AM

#

copper nacelle or does it get replaced

I'll try that

jolly oriole Jun 8, 2021, 11:57 AM

#

56, did you update your debugmod for 1.5 or should i do it for myself for now? might need to damagetest potentially fucked nailarts

copper nacelle Jun 8, 2021, 11:58 AM

#

mulhima pr'd it

#

I had my own shitty one before the settings meme but I assume this one is better anyways

jolly oriole Jun 8, 2021, 11:59 AM

#

👍

copper nacelle Jun 8, 2021, 12:00 PM

#

you should tell us if you do damage test

#

such a massive pain

jolly oriole Jun 8, 2021, 12:03 PM

#

planning to do that because methyl said that apparently nailarts do different damage when in pantheon with all bindings compared to out of pantheon

#

which seems hella jank

ornate rivet Jun 8, 2021, 12:04 PM

#

Oh the shader goes from Sprites/Default to Hidden/InternalErrorShader

#

hmmmmmmmm

jolly oriole Jun 8, 2021, 12:05 PM

#

wtf changes the knight's dash's shader

ornate rivet Jun 8, 2021, 12:05 PM

#

ok I'll just manually set it like I would with SpriteRenderers

#

I wonder why this is happening in 1.5 all of a sudden

jolly oriole Jun 8, 2021, 12:06 PM

#

likely new unity version, also now throws an exception when dontdestroyonloading null instead of only logging that it doesn't do anything

ornate rivet Jun 8, 2021, 12:06 PM

#

I mean that makes sense

copper nacelle Jun 8, 2021, 12:07 PM

#

they call me omniscient

#

did you already check hc

ornate rivet Jun 8, 2021, 12:07 PM

#

what's hc

jolly oriole Jun 8, 2021, 12:07 PM

#

herocontroller

ornate rivet Jun 8, 2021, 12:07 PM

#

oh

#

I have not

#

I dont think it's related to herocontroller though

copper nacelle Jun 8, 2021, 12:09 PM

#

it's time to on hook every shader change

jolly oriole Jun 8, 2021, 12:10 PM

#

make with monomod every unity dll hookable /s

copper nacelle Jun 8, 2021, 12:10 PM

#

I mean you can just do the hooks yourself with the constructor

floral blade Jun 8, 2021, 12:11 PM

#

after building the new mapi , i get this when trying to build my mod
Reference to type 'Action' claims it is defined in 'mscorlib',but it could not be found
any idea what could be causing this ?

ornate rivet Jun 8, 2021, 12:13 PM

#

I was too lazy to do that

foreach (var i in FindObjectsOfType<ParticleSystemRenderer>(true))
{
    if (i.material.shader.name == "Hidden/InternalErrorShader")
    {
        Log($"Had an error: {i.name}");
        i.material.shader = Shader.Find("Sprites/Default");
    }
}

#

This works fine except I think not all the materials that are breaking use Sprites/Default

#

because some of the particles are turning into rectangles

fair rampart Jun 8, 2021, 12:14 PM

#

floral blade after building the new mapi , i get this when trying to build my mod `Reference...

I have this problem yesterday

#

try to update .NET framework

ornate rivet Jun 8, 2021, 12:16 PM

#

so new big brain plan: Copy a list of all the bad materials, figure out what shader they are supposed to use, set shader to that

#

hopefully this works for all the arenas

copper nacelle Jun 8, 2021, 12:16 PM

#

omegamaggotprime

ornate rivet Jun 8, 2021, 12:17 PM

#

what should I do then?

floral blade Jun 8, 2021, 12:17 PM

#

fair rampart try to update .NET framework

what version would i need ? .NET 5.0 or .NET core 3.1 ?

fair rampart Jun 8, 2021, 12:17 PM

#

4.72

ornate rivet Jun 8, 2021, 12:17 PM

#

Could it be related to the Graphics setting here?

floral blade Jun 8, 2021, 12:20 PM

#

fair rampart 4.72

i guess i would update mono then since i'm on mac ?

fair rampart Jun 8, 2021, 12:22 PM

#

floral blade i guess i would update mono then since i'm on mac ?

I don't know how to do with mac. I have just copied new ModdingAPI files under /Managed

#

and make a reference again

jolly oriole Jun 8, 2021, 12:24 PM

#

ornate rivet Could it be related to the Graphics setting here?

idk if i changed anything there, but i also don't use assetbundle browser, so i may just don't have those shaders, though my personal theory is more in the direction of something bundled that has references to the knight (potentially thanks to a assetstudio rip)

floral blade Jun 8, 2021, 12:49 PM

#

it lives again! caravanpraise

floral blade Jun 8, 2021, 12:51 PM

#

fair rampart and make a reference again

thanks! updating mono and the TargetFrameworkVersion in csproj to "v4.7.2" worked!

fair rampart Jun 8, 2021, 12:53 PM

#

floral blade thanks! updating mono and the TargetFrameworkVersion in csproj to "v4.7.2" worke...

Good, I also have to do this yesterday because my mod wasn't working anymore

fair rampart Jun 8, 2021, 12:53 PM

#

floral blade thanks! updating mono and the TargetFrameworkVersion in csproj to "v4.7.2" worke...

👍

rough pulsar Jun 8, 2021, 1:49 PM

#

wait did mapi get another update?

#

also i tried downloading from google drive with code and it seems like it also had an error

#

luckily i found a code online that seemed like it had many things i missed, i haven't tested it yet

primal latch Jun 8, 2021, 1:58 PM

#

rough pulsar wait did mapi get another update?

since?

rough pulsar Jun 8, 2021, 1:58 PM

#

primal latch since?

i read the chat history and someone said they applied pr something

primal latch Jun 8, 2021, 1:59 PM

#

ah. Yeah. 1.5 support is still WIP

vocal spire Jun 8, 2021, 1:59 PM

#

?

#

Somebody or me?

primal latch Jun 8, 2021, 1:59 PM

#

lmao

vocal spire Jun 8, 2021, 1:59 PM

#

The pr I posted was for mod installer

rough pulsar Jun 8, 2021, 2:00 PM

#

no, the pr to mapi that like

vocal spire Jun 8, 2021, 2:00 PM

#

Add support for multiple patches in modlinks

rough pulsar Jun 8, 2021, 2:00 PM

#

save settigns or smthin

light zodiac Jun 8, 2021, 2:00 PM

#

If iglobalsettings and ilocalsettings is what your using for save settings its the newest one

#

I think

vocal spire Jun 8, 2021, 2:00 PM

#

There have been no prs in this channel recently except mine

copper nacelle Jun 8, 2021, 2:20 PM

#

fixable

#

untrue

vocal spire Jun 8, 2021, 2:21 PM

#

?

copper nacelle Jun 8, 2021, 2:22 PM

#

dandy posted his

#

checkmate

floral blade Jun 8, 2021, 2:22 PM

#

is it modapi that exposes On.HeroController ?

vocal spire Jun 8, 2021, 2:23 PM

#

Yes

primal latch Jun 8, 2021, 2:23 PM

#

yes

vocal spire Jun 8, 2021, 2:24 PM

#

In 1.5 MMHOOK_Assembly-CSharp

vocal spire Jun 8, 2021, 2:24 PM

#

copper nacelle dandy posted his

I don’t see it?

floral blade Jun 8, 2021, 2:24 PM

#

aah that's my problemo

floral blade Jun 8, 2021, 2:24 PM

#

copper nacelle dandy posted his

technically i posted the link to a release and not the PR itself

#

double checkmate ?

copper nacelle Jun 8, 2021, 2:25 PM

#

true

vocal spire Jun 8, 2021, 2:25 PM

#

lol

fickle sparrow Jun 8, 2021, 2:43 PM

#

tbf the 1.5 modding api does work

copper nacelle Jun 8, 2021, 2:43 PM

#

true

fickle sparrow Jun 8, 2021, 2:44 PM

#

build for latest commit is here https://github.com/HollowKnight-Modding/HollowKnight.Modding/actions/runs/916298306#artifacts

#

under artifacts

#

and also you can just compile the code yourself

floral blade Jun 8, 2021, 2:45 PM

#

fickle sparrow and also you can just compile the code yourself

yes that's what i'm doing rn

vestal plover Jun 8, 2021, 2:46 PM

#

Is it wise to start updating mods for 1.5 or are there going to be major changes to the modding API before its release?

copper nacelle Jun 8, 2021, 2:46 PM

#

man just ignores the artifact

#

idk about major probably just some smaller stuff

fickle sparrow Jun 8, 2021, 2:47 PM

#

I doubt we'll do anything more that will break it

#

cause we already changed most of the cursed stuff

copper nacelle Jun 8, 2021, 2:48 PM

#

I gotta change the reflection helper member names

#

They annoy me deeply

vestal plover Jun 8, 2021, 2:53 PM

#

Does the new Unity version store crash logs in a different place now, or did I somehow crash the crash reporter?

copper nacelle Jun 8, 2021, 2:53 PM

#

It's either the saves folder or the game folder

#

I don't remember which is the current one

vestal plover Jun 8, 2021, 2:55 PM

#

Hmm, it doesn't show up in either folder

copper nacelle Jun 8, 2021, 2:57 PM

#

Also if this is from just installing the api I'd make sure you have the newest

vestal plover Jun 8, 2021, 2:58 PM

#

No, the installation went perfectly fine, I just refactored my mod for the 1.5 API and it straight up crashes without any indication in the ModLog or any crash reports

primal latch Jun 8, 2021, 2:58 PM

#

I'm not really familiar with attributes, but shouldn't it be easier for https://github.com/HollowKnight-Modding/HollowKnight.Modding/blob/master/Assembly-CSharp/AssemblyTypeAttribute.cs to be an enum?

GitHub

HollowKnight-Modding/HollowKnight.Modding

Hollow Knight Modding API. Contribute to HollowKnight-Modding/HollowKnight.Modding development by creating an account on GitHub.

jolly oriole Jun 8, 2021, 2:59 PM

#

copper nacelle I gotta change the reflection helper member names

can you also make the methods generic so i can type o.SetAttr<>("", whatever)?

copper nacelle Jun 8, 2021, 2:59 PM

#

what

#

and yeah that should be an enum I just never bothered changing it

#

iirc

#

idk what you mean with the generics though they are generic

jolly oriole Jun 8, 2021, 3:00 PM

#

1 sec

#

... if vs stops lagging

#

like this (so i don't need this in sfcore)

copper nacelle Jun 8, 2021, 3:01 PM

#

that is an extension

jolly oriole Jun 8, 2021, 3:01 PM

#

yea

copper nacelle Jun 8, 2021, 3:02 PM

#

I don't like extensions on every object they get cluttered very quick

#

I'd prefer that to be in like a lib like it is but if a bunch of people are using it I could I guess

#

I had them in modcommon and then I couldn't change them because breaking api meme I think

#

Aids

jolly oriole Jun 8, 2021, 3:03 PM

#

i mean, i only added it because i was used to it from serecore/modcommon (idk which one it was)

primal latch Jun 8, 2021, 3:03 PM

#

copper nacelle I had them in modcommon and then I couldn't change them because breaking api mem...

well, now there are already breaking API changes

copper nacelle Jun 8, 2021, 3:04 PM

#

yeah

#

But I also do not care enough to modify modcommon

#

Checkmate

primal latch Jun 8, 2021, 3:04 PM

#

oof

#

I got checkmated

#

beter then jebaited

rough pulsar Jun 8, 2021, 3:04 PM

#

is there anything you can even do with modcommon

primal latch Jun 8, 2021, 3:04 PM

#

debug collider

jolly oriole Jun 8, 2021, 3:05 PM

#

a*

primal latch Jun 8, 2021, 3:05 PM

#

although I find that should be a build-in feature of the mapi

jolly oriole Jun 8, 2021, 3:05 PM

#

nah, not needed in the mapi, just write your code that it works

#

ez

primal latch Jun 8, 2021, 3:06 PM

#

it's handy for visualizing. For example: when you haven't set up sprites for things yet

jolly oriole Jun 8, 2021, 3:06 PM

#

visualize using hkwe2

#

wait

#

there was something

floral blade Jun 8, 2021, 3:08 PM

#

it be alive! , only had to yeet modcommon and settings.

rough pulsar Jun 8, 2021, 3:08 PM

#

good joob

#

i have yet to port my own but i am adding another feature to 1.5 port

floral blade Jun 8, 2021, 3:12 PM

#

i need to bring settings back i just added them like last release

copper nacelle Jun 8, 2021, 3:13 PM

#

the new ones are very easy dw

rough pulsar Jun 8, 2021, 3:13 PM

#

what new ones

#

ohhh

#

settings

floral blade Jun 8, 2021, 3:13 PM

#

yeah i saw the example it was pretty simple to grasp

rough pulsar Jun 8, 2021, 3:13 PM

#

pure vessel skin isn't public i assume

jolly oriole Jun 8, 2021, 3:15 PM

#

which one

#

aren't there like 3 different ones

patent zealot Jun 8, 2021, 3:18 PM

#

Theres emray and twp onr afaik

primal latch Jun 8, 2021, 3:18 PM

#

why doesn't the ci build the example mods? Aren't they important too since they could break after updates to the api?

jolly oriole Jun 8, 2021, 3:21 PM

#

why doesn't github have a quick link to the latest action smh

fickle sparrow Jun 8, 2021, 3:22 PM

#

true

#

nightly builds
Windows: https://nightly.link/hk-modding/api/workflows/dotnet.yaml/master/ModdingApiWin.zip
Unix: https://nightly.link/hk-modding/api/workflows/dotnet.yaml/master/ModdingApiUnix.zip

#

use this tbh

copper nacelle Jun 8, 2021, 3:22 PM

#

fickle sparrow nightly builds Windows: https://nightly.link/hk-modding/api/workflows/dotnet.yam...

jolly oriole Jun 8, 2021, 3:22 PM

#

oh damn

primal latch Jun 8, 2021, 3:22 PM

#

green checkmark and then details

jolly oriole Jun 8, 2021, 3:23 PM

#

nah, l'll just use that link yuri posted

primal latch Jun 8, 2021, 3:25 PM

#

primal latch why doesn't the ci build the example mods? Aren't they important too since they ...

can somebody answer this?

patent zealot Jun 8, 2021, 3:27 PM

#

Is that the same modding api or is it a different one

jolly oriole Jun 8, 2021, 3:27 PM

#

updated since yesterday

patent zealot Jun 8, 2021, 3:27 PM

#

Pog

jolly oriole Jun 8, 2021, 3:27 PM

#

primal latch can somebody answer this?

probably because they aren't necessary for the mapi

rough pulsar Jun 8, 2021, 3:27 PM

#

kinda off topic but are there any linux users here

primal latch Jun 8, 2021, 3:28 PM

#

yeah. But they are still the examples. You would expect them to be updated

primal latch Jun 8, 2021, 3:28 PM

#

rough pulsar kinda off topic but are there any linux users here

yes

rough pulsar Jun 8, 2021, 3:28 PM

#

doesn't linux have a built-in file download tool for bash

primal latch Jun 8, 2021, 3:28 PM

#

but not for HK

primal latch Jun 8, 2021, 3:28 PM

#

rough pulsar doesn't linux have a built-in file download tool for bash

wget?

copper nacelle Jun 8, 2021, 3:28 PM

#

curl

#

both of those aren't actually bash though they're just standard utils

ornate rivet Jun 8, 2021, 3:29 PM

#

why did you change Log?

rough pulsar Jun 8, 2021, 3:29 PM

#

is wget builtin to linux?

#

or curl

copper nacelle Jun 8, 2021, 3:29 PM

#

no they're just both very standard

primal latch Jun 8, 2021, 3:29 PM

#

rough pulsar is wget builtin to linux?

depends on your distro

jolly oriole Jun 8, 2021, 3:29 PM

#

56, the latest commit of debugmod is broken

copper nacelle Jun 8, 2021, 3:29 PM

#

curl is ubiquitous

rough pulsar Jun 8, 2021, 3:29 PM

#

hmmm aleight

copper nacelle Jun 8, 2021, 3:30 PM

#

@ Mulhima#2695 😤

rough pulsar Jun 8, 2021, 3:30 PM

#

juat wanna make sure the autodependency install is portable to all OS

primal latch Jun 8, 2021, 3:30 PM

#

copper nacelle curl

curl is used for all kinds of data transfers. wget is specific to files

rough pulsar Jun 8, 2021, 3:30 PM

#

i plan to use terminal in this

jolly oriole Jun 8, 2021, 3:30 PM

#

@light zodiac you seem responsible according to 56

copper nacelle Jun 8, 2021, 3:30 PM

#

why would you make it more specific when curl is more portable

primal latch Jun 8, 2021, 3:31 PM

#

Wget is a command-line utility for downloading files from the web

copper nacelle Jun 8, 2021, 3:31 PM

#

I don't think alpine comes with either though

#

and

primal latch Jun 8, 2021, 3:31 PM

#

@rough pulsar wget is easier, curl is more versetile

rough pulsar Jun 8, 2021, 3:31 PM

#

as long as ubuntu has curl or wget builtin i think its fine

primal latch Jun 8, 2021, 3:31 PM

#

I think it has both

ornate rivet Jun 8, 2021, 3:32 PM

#

What did the new version of mapi do to Logger.Log?

rough pulsar Jun 8, 2021, 3:32 PM

#

cool, mac os and windows has curl too

primal latch Jun 8, 2021, 3:32 PM

#

really?

fickle sparrow Jun 8, 2021, 3:32 PM

#

don't use Logger.Log

copper nacelle Jun 8, 2021, 3:32 PM

#

don't use curl and expect it to work on windows

primal latch Jun 8, 2021, 3:32 PM

#

might come with gitforwindows

rough pulsar Jun 8, 2021, 3:32 PM

#

yeah i checked

fickle sparrow Jun 8, 2021, 3:32 PM

#

use the Log function in the Mod class

copper nacelle Jun 8, 2021, 3:32 PM

#

he needs his 800 static logs though smh

ornate rivet Jun 8, 2021, 3:32 PM

#

alright, thanks

rough pulsar Jun 8, 2021, 3:32 PM

#

copper nacelle don't use curl and expect it to work on windows

doesnt it come bultin in versions later than 1808 or something

#

builtin

primal latch Jun 8, 2021, 3:33 PM

#

rough pulsar doesnt it come bultin in versions later than 1808 or something

nope. It comes with gitforwindows

rough pulsar Jun 8, 2021, 3:33 PM

#

damn

copper nacelle Jun 8, 2021, 3:33 PM

#

Windows 10 Insider build 17063 and up

#

In theory

primal latch Jun 8, 2021, 3:33 PM

#

really?

#

didn't know that

copper nacelle Jun 8, 2021, 3:34 PM

#

Just use WebClient though if you have a mod

#

Yeah I was surprised too

rough pulsar Jun 8, 2021, 3:34 PM

#

its going to be a pain in the ass to make code for downloading then

copper nacelle Jun 8, 2021, 3:34 PM

#

why

#

WebClient is pretty simple

rough pulsar Jun 8, 2021, 3:34 PM

#

i tried webclient

copper nacelle Jun 8, 2021, 3:34 PM

#

what happens

rough pulsar Jun 8, 2021, 3:34 PM

#

it threw errors at me when i tried with discord

copper nacelle Jun 8, 2021, 3:34 PM

#

but what are the errors

rough pulsar Jun 8, 2021, 3:35 PM

#

like, Forbidden http error

copper nacelle Jun 8, 2021, 3:35 PM

#

did you give the auth token?

#

in the header

rough pulsar Jun 8, 2021, 3:35 PM

#

no...

copper nacelle Jun 8, 2021, 3:35 PM

#

really makes you wonder why it's forbidden

rough pulsar Jun 8, 2021, 3:35 PM

#

i didnt know i had to do that

copper nacelle Jun 8, 2021, 3:35 PM

#

I mean for most discord actions you need a login

rough pulsar Jun 8, 2021, 3:36 PM

#

m

#

actually i tried downloading from discord with curl and it worked

#

dunno why it just didnt with webclient

fickle sparrow Jun 8, 2021, 3:37 PM

#

like a file hosted on discord?

rough pulsar Jun 8, 2021, 3:37 PM

#

ye

#

discord_game_sdk.zip

light zodiac Jun 8, 2021, 3:37 PM

#

jolly oriole <@!724954591602671628> you seem responsible according to 56

I hate making PRS I always forget something

fickle sparrow Jun 8, 2021, 3:37 PM

#

check the headers that curl adds

rough pulsar Jun 8, 2021, 3:37 PM

#

ok

jolly oriole Jun 8, 2021, 3:38 PM

#

ornate rivet What did the new version of mapi do to Logger.Log?

works normally though

light zodiac Jun 8, 2021, 3:39 PM

#

jolly oriole <@!724954591602671628> you seem responsible according to 56

https://github.com/TheMulhima/Debug_Mod/releases/tag/v1.3.7

Compiled version

jolly oriole Jun 8, 2021, 3:39 PM

#

thanks!

#

i love having like 3 hk installations

copper nacelle Jun 8, 2021, 3:40 PM

#

that's so little smh

rough pulsar Jun 8, 2021, 3:41 PM

#

curl sends those

jolly oriole Jun 8, 2021, 3:41 PM

#

yea, the 1432 64 bit one is practically unused

rough pulsar Jun 8, 2021, 3:41 PM

#

looks like i gotta add the User-Agent and Accept

copper nacelle Jun 8, 2021, 3:47 PM

#

#

pretty sure serena has more

jolly oriole Jun 8, 2021, 3:51 PM

#

wow this is jank

copper nacelle Jun 8, 2021, 3:52 PM

#

and by more I mean literally every patch

#

what's jank

jolly oriole Jun 8, 2021, 3:52 PM

#

nailart damage

copper nacelle Jun 8, 2021, 3:52 PM

#

Ah

#

Yeah

#

They do that

primal latch Jun 8, 2021, 3:52 PM

#

hey, remember me asking if AssemblyTypeAttribute should be an enum? Yeah. enums can't be attributes

jolly oriole Jun 8, 2021, 3:52 PM

#

current findings:

No Charms, No Bindings:
After Creating Save:
G Slash: 450 -> 408 = 42 = 2x
D Slash: 408 -> 356 = 52 = 2.5x
C Slash: 356 -> 304 (2 hits) = 26 = 1.25x
After dying once:
G Slash: 450 -> 408 = 42 = 2x
D Slash: 408 -> 366 = 42 = 2x
C Slash: 366 -> 324 (2 hits) = 21 = 1x

copper nacelle Jun 8, 2021, 3:52 PM

#

wtf

ornate rivet Jun 8, 2021, 3:53 PM

#

why does it say I dont have the interface's methods implemented?

copper nacelle Jun 8, 2021, 3:53 PM

#

Does dying once have a hit before using it

#

The way it was working out for me was that the first use of the nail art was fucked

#

Saleh just autogen the methods think about it

ornate rivet Jun 8, 2021, 3:54 PM

#

I did but nothing happens when I do

fickle sparrow Jun 8, 2021, 3:54 PM

#

wtf

rough pulsar Jun 8, 2021, 3:54 PM

#

what

fickle sparrow Jun 8, 2021, 3:54 PM

#

drunk ide

jolly oriole Jun 8, 2021, 3:54 PM

#

i went in, activated invincibility, tested each once (except the second cyclone one, first one i wasn't sure if 1 or 2 hits), then died

copper nacelle Jun 8, 2021, 3:54 PM

#

Build anyways and see what happens

rough pulsar Jun 8, 2021, 3:54 PM

#

microsoft, your faulty ide 🙄

copper nacelle Jun 8, 2021, 3:54 PM

#

do it without testing once pretty sure that's the actual part

#

fury was triggering only if it was the first time since quit out that nail art had been used last time pauseshroom

#

Awful

jolly oriole Jun 8, 2021, 3:55 PM

#

so use each one once before he pantheon? or what

#

i'll just use them like 3 times per test

copper nacelle Jun 8, 2021, 3:55 PM

#

like first use is different than the second

#

esp if you're doing charms

rough pulsar Jun 8, 2021, 3:56 PM

#

ok i applied the headers that curl does similarly, idk if user-agent matters. time to test le mod

#

shit shit i forgot to put in the mod lol

primal latch Jun 8, 2021, 3:58 PM

#

trying to build the mapi gives the error " The command " C:\Users\Erik de Vlaam\Desktop\HollowKnight.Modding/PrePatcher/Output/PrePatcher.exe Assembly-CSharp.dll Assembly-CSharp-patched.dll" exited with code 9009." the build mode is release

copper nacelle Jun 8, 2021, 3:58 PM

#

build the prepatcher first

primal latch Jun 8, 2021, 3:58 PM

#

ok

copper nacelle Jun 8, 2021, 3:59 PM

#

I swear if you have the same thing as the ci I will murder someone

jolly oriole Jun 8, 2021, 4:00 PM

#

uh

#

shouldn't the narts do 2x damage now?

copper nacelle Jun 8, 2021, 4:01 PM

#

somni said they reversed the changes

#

so no idea

vestal plover Jun 8, 2021, 4:02 PM

#

Is there anyone that has updated their mod to 1.5 and uses dynamically added TextMeshPro components? If I try to add such a component to a GameObject my game crashes without any stack trace or unity crash log.

floral blade Jun 8, 2021, 4:02 PM

#

primal latch trying to build the mapi gives the error " The command " C:\Users\Erik de Vlaam\...

Also build the release version and not debug

jolly oriole Jun 8, 2021, 4:03 PM

#

poggers

floral blade Jun 8, 2021, 4:03 PM

#

vestal plover Is there anyone that has updated their mod to 1.5 and uses dynamically added `Te...

Player.log is empty as well ?

vestal plover Jun 8, 2021, 4:03 PM

#

floral blade Player.log is empty as well ?

Where is that file located?

copper nacelle Jun 8, 2021, 4:03 PM

#

Saves

jolly oriole Jun 8, 2021, 4:07 PM

#

this concludes the no bindings test, now for all bindings (i heard there were differences 🥴)

light zodiac Jun 8, 2021, 4:08 PM

#

So great and dash slash is still at 2.5 and cyclone is 1.25?

#

This is with strength?

jolly oriole Jun 8, 2021, 4:08 PM

#

dw, it's fucked up

#

and yesn't

#

no charms

vestal plover Jun 8, 2021, 4:11 PM

#

floral blade Player.log is empty as well ?

Thanks, I didn't know this existed and it does contain a stack trace.

light zodiac Jun 8, 2021, 4:11 PM

#

jolly oriole poggers

What's the last column mean?

jolly oriole Jun 8, 2021, 4:12 PM

#

y*naildamage

#

it displays y

#

should be at 2/1

primal latch Jun 8, 2021, 4:16 PM

#

copper nacelle build the prepatcher first

I did

copper nacelle Jun 8, 2021, 4:17 PM

#

I'm going to commit a warcrime

#

Are you building the solution and not the individual projects

primal latch Jun 8, 2021, 4:17 PM

#

I tried both

copper nacelle Jun 8, 2021, 4:18 PM

#

Is the prepatcher output in output

jolly oriole Jun 8, 2021, 4:18 PM

#

making a godseeker save and using nailarts will use the old 2.5/1.25 times naildamage formula, while doing so after dying at least once results in the new 2/1 times naildamage

primal latch Jun 8, 2021, 4:18 PM

#

copper nacelle Is the prepatcher output in output

yes

#

It could be that my user name has spaces in it

copper nacelle Jun 8, 2021, 4:18 PM

#

ah

#

Terrible

#

Don't do that easy

light zodiac Jun 8, 2021, 4:19 PM

#

Why do you need to die for changes to take effect

jolly oriole Jun 8, 2021, 4:19 PM

#

🍝

primal latch Jun 8, 2021, 4:19 PM

#

primal latch It could be that my user name has spaces in it

could this be it?

copper nacelle Jun 8, 2021, 4:19 PM

#

yes

primal latch Jun 8, 2021, 4:19 PM

#

how could I fix it?

copper nacelle Jun 8, 2021, 4:19 PM

#

I didn't quote the args

#

Quote the args

primal latch Jun 8, 2021, 4:19 PM

#

ok

#

got it

rough pulsar Jun 8, 2021, 4:27 PM

#

oi WebClient works thankfully

#

no more pain, all i missed are the headers

jolly oriole Jun 8, 2021, 4:32 PM

#

oh wow, i think i know why it's 2.5x before dying/maybe doing another thing that somehow rechecks nart multiplier

primal latch Jun 8, 2021, 4:35 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/pull/49 I created a pull request fixing the issue with crashes when having a username with a space in it

GitHub

added quotes to the after build command that way users with a space...

…n their username won't get an error

jolly oriole Jun 8, 2021, 4:36 PM

#

FsmViewAvalonia just closes when looking at the damages_enemy fsm on the Great Slash gameobject in scene4 of 1.5 release

primal latch Jun 8, 2021, 4:39 PM

#

why does almost everything contain this.? It seems unnecessary

#

never mind. Got it

light zodiac Jun 8, 2021, 4:40 PM

#

jolly oriole oh wow, i think i know why it's 2.5x before dying/maybe doing another thing that...

Fsm viewer crashes on 1.5 for me

primal latch Jun 8, 2021, 4:40 PM

#

probably because it patches the assembly

#

but... It's also in non-patch classes

jolly oriole Jun 8, 2021, 4:41 PM

#

light zodiac Fsm viewer crashes on 1.5 for me

the non avalonia only works with 1432

#

but the avalonia one doesn't have a scene list or working search bar sadly

dark wigeon Jun 8, 2021, 4:43 PM

#

tHeN make an iSsuE if you report a bug to the void then only the void can fix the bug

jolly oriole Jun 8, 2021, 4:44 PM

#

oh yea, there was a repo for that

dark wigeon Jun 8, 2021, 4:45 PM

#

y'all want tabs and scene view I guess

jolly oriole Jun 8, 2021, 4:45 PM

#

imo tabs isn't that much of an issue, but scene list and the search bar is the biggest thing

dark wigeon Jun 8, 2021, 4:45 PM

#

oh yeah I think searching has a pr

#

sorry 56

primal latch Jun 8, 2021, 4:46 PM

#

primal latch why does almost everything contain ``this.``? It seems unnecessary

can somebody give a reason for this?

jolly oriole Jun 8, 2021, 4:46 PM

#

primal latch can somebody give a reason for this?

in the decomp or actual source code?

primal latch Jun 8, 2021, 4:47 PM

#

jolly oriole in the decomp or actual source code?

the mapi

jolly oriole Jun 8, 2021, 4:48 PM

#

probably looks cleaner ¯_(ツ)_/¯

primal latch Jun 8, 2021, 4:50 PM

#

all those this.?

#

I'd say it adds code clutter

jolly oriole Jun 8, 2021, 4:52 PM

#

but you have the difference of this.w <=> other.w

primal latch Jun 8, 2021, 4:52 PM

#

I know

#

but VS studio marks a lot of them as unnecesary. I get it for the patches, but for the custom classes?

light zodiac Jun 8, 2021, 5:00 PM

#

jolly oriole making a godseeker save and using nailarts will use the old 2.5/1.25 times naild...

Is the "after dying" per save or per quitout?

copper nacelle Jun 8, 2021, 5:03 PM

#

where is it used in custom classes

#

It's just a style preference though

#

I tend to not use it

dark wigeon Jun 8, 2021, 5:05 PM

#

@jolly oriole this is Great Slash/damages_enemy

#

not getting the crash

#

could you try using this

📎 classdata.tpk

#

here just use this https://drive.google.com/file/d/18nS2CqTwLJDavPiYDqhh65c3NYZlPzkW/view?usp=sharing

Google Docs

fsmviewavalonia2-r3.zip

fickle sparrow Jun 8, 2021, 5:28 PM

#

using this.Field is way better practice tbh

#

introduces explicitness on the access

merry lotus Jun 8, 2021, 5:31 PM

#

Question about 1.5 API:
I understand that 1.5 inherently breaks essentially everything, but is it literally everything? Like, if I get the current 1.5 API and attempt to load some of the random mods that people uploaded to this server too see if they still work, would there be any chance that they do?
For example, if I try celeste.dll, which just added dashing in all directions, could something like that still work, or is there a fundamental change that means that literally nothing built pre-1.5 will work?

floral blade Jun 8, 2021, 5:31 PM

#

merry lotus Question about 1.5 API: I understand that 1.5 inherently breaks essentially ever...

If they don't use hooks or save settings then they might.

#

Which is basically all of them I guess

fickle sparrow Jun 8, 2021, 5:32 PM

#

the changes are super easy

floral blade Jun 8, 2021, 5:32 PM

#

The .NET version being different might nuke them too idk

fickle sparrow Jun 8, 2021, 5:32 PM

#

not really

dark wigeon Jun 8, 2021, 5:32 PM

#

3.5 is compatible with 4.7

#

even .net core+ although it does sort of complain

floral blade Jun 8, 2021, 5:33 PM

#

So then as long as no hooks / settings it would work

fickle sparrow Jun 8, 2021, 5:33 PM

#

maybe

#

better to just fix the mods

#

cause it takes a minute to do so

dark wigeon Jun 8, 2021, 5:33 PM

#

did hooks change or smth

fickle sparrow Jun 8, 2021, 5:33 PM

#

we made them static

floral blade Jun 8, 2021, 5:33 PM

#

dark wigeon did hooks change or smth

Yes now they static shock

fickle sparrow Jun 8, 2021, 5:33 PM

#

so you just remove the .Instance access and it works fine

#

and the new save thing is super easy as well

floral blade Jun 8, 2021, 5:35 PM

#

It is but old DLLs probably won't work as is unless it's a tiny mod

fickle sparrow Jun 8, 2021, 5:35 PM

#

they wont

#

if they don't use saves they might

floral blade Jun 8, 2021, 5:36 PM

#

And hooks

fickle sparrow Jun 8, 2021, 5:36 PM

#

well the ModHooks::Instance field still exists

#

its just obsoleted

#

and .NET should technically work

#

because you can access static methods through instances

copper nacelle Jun 8, 2021, 5:37 PM

#

no the il doesn't work

#

It's an error I had it wrong

fickle sparrow Jun 8, 2021, 5:37 PM

#

ah

jolly oriole Jun 8, 2021, 5:37 PM

#

dark wigeon here just use this https://drive.google.com/file/d/18nS2CqTwLJDavPiYDqhh65c3NYZl...

works, though maybe nitpick?
the search bars do exactly nothing for me

fickle sparrow Jun 8, 2021, 5:37 PM

#

ax1uWide3

#

insane

jolly oriole Jun 8, 2021, 5:38 PM

#

jolly oriole works, though maybe nitpick? the search bars do exactly nothing for me

ok nvm, they do display text, but that's about it

floral blade Jun 8, 2021, 5:38 PM

#

fickle sparrow because you can access static methods through instances

it does complain when compiling but would work at runtime?

fickle sparrow Jun 8, 2021, 5:39 PM

#

idk 56 said it didn't

dark wigeon Jun 8, 2021, 5:44 PM

#

jolly oriole works, though maybe nitpick? the search bars do exactly nothing for me

#archived-modding-development message

jolly oriole Jun 8, 2021, 5:44 PM

#

oh yea, forgot that already lol

dark wigeon Jun 8, 2021, 5:45 PM

#

I've been too lazy to test it

#

Or I could just trust 56

#

can I trust 56

copper nacelle Jun 8, 2021, 5:45 PM

#

it works

dark wigeon Jun 8, 2021, 5:45 PM

#

ok

copper nacelle Jun 8, 2021, 5:45 PM

#

I can't live without search

patent zealot Jun 8, 2021, 5:45 PM

#

is there a benchwarpfor 1.5 yet?

dark wigeon Jun 8, 2021, 5:46 PM

#

I believe in you

#

merged

#

*kids saying yay sound effect*

jolly oriole Jun 8, 2021, 5:46 PM

#

oh my god

#

wait what

dark wigeon Jun 8, 2021, 5:47 PM

#

what

jolly oriole Jun 8, 2021, 5:47 PM

#

nvm

#

nart damage is badly made

dark wigeon Jun 8, 2021, 5:47 PM

#

avalonia missing text changed events is meme

#

to this day it still has no event

copper nacelle Jun 8, 2021, 5:49 PM

#

my favorite auto complete box with no auto complete

jolly oriole Jun 8, 2021, 5:50 PM

#

nart damage is 2.5x/1.25x until anything sends the UPDATE NAIL DAMAGE or CHARM INDICATOR CHECK event to the knight
so potentially when you get a nail upgrade, enter nail binding pantheon, equip strength, get fury effect or charms change? (probably this is CHARM INDICATOR CHECK)
after that it's 2x/1x

#

gonna write a bug report

#

before i forget it again

#

though a nart that does 6.5625 times naildamage is probably poggers

#

gonna test it first

#

if this holds up

merry lotus Jun 8, 2021, 5:53 PM

#

floral blade It is but old DLLs probably won't work as is unless it's a tiny mod

One follow up question (please ping if responding, because I'm about to be AFK for 4 hours):
Would one be able to "update" a simplistic mod to 1.5 if they only had access to the .dll, or would the source code be needed? A lot of the one-off mods never had source uploaded afaik.

jolly oriole Jun 8, 2021, 5:55 PM

#

merry lotus One follow up question (please ping if responding, because I'm about to be AFK f...

one can extract the decompiled source code and have not exactly the same, but pretty close to it.
so updating 'simplistic' mods is possible

#

holy shit strength narts are powerfull
without damage reset they do 'normal' 2.5x, even with strength equipped
but with damage reset they do 2x without strength, 5x with strength

floral blade Jun 8, 2021, 6:02 PM

#

mapi 1.5 could also support hooks on hooks.instance.xyz right ? if it does then simple mods wouldnt break and anything more complex would need updating due to unity changes anyway

light zodiac Jun 8, 2021, 6:08 PM

#

jolly oriole holy shit strength narts are powerfull without damage reset they do 'normal' 2.5...

Did you say 5x? So like gslash does 105?

#

That is omega broken even if it's intended

fickle sparrow Jun 8, 2021, 6:10 PM

#

I really do not want to support instance methods

#

the mod owners will probably get around to updating them

#

and yes it is possible to update a mod to not use the instance methods with dnSpy

jolly oriole Jun 8, 2021, 6:13 PM

#

light zodiac That is omega broken even if it's intended

potentially up to 8.75x with fury

floral blade Jun 8, 2021, 6:13 PM

#

fickle sparrow I really do not want to support instance methods

that's fair

light zodiac Jun 8, 2021, 6:14 PM

#

Who needs debug nail increase keybind any more

#

I'll just remove it when I fix those missing files

jolly oriole Jun 8, 2021, 6:15 PM

#

after testing: the damage is 'only' ~7.125x

#

(92)

light zodiac Jun 8, 2021, 6:19 PM

#

How is 92 7.125

jolly oriole Jun 8, 2021, 6:21 PM

#

it's ~7.08, but game rounds down somewhere during that, and 7.125 is the closest then

light zodiac Jun 8, 2021, 6:21 PM

#

21*7 = 147?

jolly oriole Jun 8, 2021, 6:22 PM

#

oh fuck, i copied wrong formula

#

strength+fury does probably 4.5x

copper nacelle Jun 8, 2021, 6:24 PM

#

5x tf

#

what the fuck

jolly oriole Jun 8, 2021, 6:26 PM

#

yea, not 5x

copper nacelle Jun 8, 2021, 6:26 PM

#

ruined

jolly oriole Jun 8, 2021, 6:27 PM

#

would've been 5x if it was the nailbinding as base

vestal plover Jun 8, 2021, 6:29 PM

#

There doesn't happen to be an extensive changelog of FSMs that were changed in the update right?

light zodiac Jun 8, 2021, 6:41 PM

#

TC and changelogs

#

You expect too much

nimble lake Jun 8, 2021, 7:02 PM

#

tcArriveWithSpaghetti

#

no way speedrun mods will allow that lmao

jolly oriole Jun 8, 2021, 7:05 PM

#

nimble lake no way speedrun mods will allow that lmao

yea, dw, math be hella scuffed

#

i have no idea how this contruct is supposed to work.
everything following is theoretical

one way it could work is that nailart damage is (cases Great & Dash slash):

tmpDmg = nailDamage * (1.25 for cyclone, otherwise 2.5) (* 1.75 if fury effect is active)
finalDmg = round(tmpDmg)

which would cap G/Dslash out at 92 damage. This results in roughly 92 DPS.
Cyclone would cap out at 322 damage. This results in roughly 150 DPS.

another way is:

tmpDmg = nailDamage (* 1.5 if strength is active)
finalDmg = round(tmpDmg) * (1 for cyclone, otherwise 2)

which would cap G/Dslash out at 64 damage. This results in roughly 64 DPS.
Cyclone would cap out at 224 damage. This results in roughly 105 DPS.

in theory the 2nd way should be happening though the 1st way is apparently happening in practice.
the Strength/Fury + NGM combo could need the effects of both Strength and Fury, with a potential damage calculation being

tmp1Dmg = nailDamage * (1 for cyclone, otherwise 2) (* 1.5 if strength is active)
tmp2Dmg = round(tmp1Dmg) (* 1.75 if fury effect is active)
finalDmg = round(tmpDmg)

which would cap G/Dslash out at 110 damage. This results in roughly 110 DPS.
Cyclone would cap out at 392 damage. This results in roughly 105 DPS.

But even this doesn't do more damage than the Fury+Strength+QS combo, which caps out at roughly 224 DPS.

dmgPerHit = round(round(nailDamage * 1.5) * 1.75)
dps = dmgPerHit / 0.25

nimble lake Jun 8, 2021, 7:30 PM

#

get graig on this lol

patent zealot Jun 8, 2021, 7:31 PM

#

just say pale court released and he will come

jolly oriole Jun 8, 2021, 7:34 PM

#

i'll make this the bug report

light zodiac Jun 8, 2021, 7:38 PM

#

can you cancel bug reports?

jolly oriole Jun 8, 2021, 7:40 PM

#

i can delete the message i sent to benji

#

why

light zodiac Jun 8, 2021, 7:43 PM

#

The Colo geo bug

primal latch Jun 8, 2021, 7:43 PM

#

why did the ci fail on my pr? It says it can't acces a repository. My guess is that that repo contains the vanilla files?

light zodiac Jun 8, 2021, 7:43 PM

#

The bug reports go to Benji? I thought there was a Google forms or something

jolly oriole Jun 8, 2021, 7:44 PM

#

i reported my bugs to benji, but you could've sent them to benji, simo or the steam thread

primal latch Jun 8, 2021, 7:57 PM

#

anybody have an idea?

jolly oriole Jun 8, 2021, 7:58 PM

#

yea

#

you arent part of the group having that private ci repository

primal latch Jun 8, 2021, 7:59 PM

#

ah. Then why add the ci? I mean: isn't it used to validate the integrity of the commit?

jolly oriole Jun 8, 2021, 8:00 PM

#

idk why the ci doesn't just go from the owner of the repo though

primal latch Jun 8, 2021, 8:03 PM

#

I swear like 1 in 10 messages is check the pins or ?pins in #archived-modding-help

vocal spire Jun 8, 2021, 8:03 PM

#

Yeah

jolly oriole Jun 8, 2021, 8:03 PM

#

new patch which is incompatible with current mods and modinstaller

#

so kinda expected

primal latch Jun 8, 2021, 8:04 PM

#

yeah

#

we really need to roll this out to the public soon

fickle sparrow Jun 8, 2021, 8:08 PM

#

we are using the CI to just build nightly

#

theres literally no other use for it because unit tests can't really happen in a modding api

vocal spire Jun 8, 2021, 8:12 PM

#

I already made an update for modlinks that allows for multiple patch support

https://github.com/ricardosouzag/ModInstaller/pull/100

GitHub

Add support for multiple patches in modlinks by RedFrog6002 · Pull ...

add support for multiple patches in modlinks and add open mods folder button

fickle sparrow Jun 8, 2021, 8:13 PM

#

old modinstaller

vocal spire Jun 8, 2021, 8:13 PM

#

?

light zodiac Jun 8, 2021, 8:13 PM

#

What happens when a mod (previously turned off in the in-game mods menu) is turned on in the in-game mods menu?

fickle sparrow Jun 8, 2021, 8:14 PM

#

it calls Initialize

vocal spire Jun 8, 2021, 8:14 PM

#

Initialize is run?

fickle sparrow Jun 8, 2021, 8:14 PM

#

yes

#

its also always run on load

#

but then gets unloaded if the mod is turned off

light zodiac Jun 8, 2021, 8:14 PM

#

I tried rn and my mod doesn't reappear on top left

fickle sparrow Jun 8, 2021, 8:14 PM

#

in the mod menu?

vocal spire Jun 8, 2021, 8:14 PM

#

Check modlog

light zodiac Jun 8, 2021, 8:14 PM

#

Yes

fickle sparrow Jun 8, 2021, 8:14 PM

#

you have to exit the menu

#

then all changed mods will get activated/deactivated

#

I didn't want someone spamming on/off to cause performance issues

light zodiac Jun 8, 2021, 8:15 PM

#

I exited the menu and changed a scene too

fickle sparrow Jun 8, 2021, 8:15 PM

#

then your mod probably crashed something

light zodiac Jun 8, 2021, 8:16 PM

#

vocal spire Check modlog

Nothing

vocal spire Jun 8, 2021, 8:16 PM

#

fickle sparrow old modinstaller

I was making changes to mod installer 2, and dmed 56 asking for a solution to a weird error, and 56 suggested not doing anything since they’d be doing something their self

light zodiac Jun 8, 2021, 8:23 PM

#

Currently my initialze is

public override void Initialize(Dictionary<string, Dictionary<string, GameObject>> preloadedObjects)
        {
            Instance = this;
            PreloadedObjects.Add("Inspect", preloadedObjects["GG_Workshop"]["GG_Statue_Hornet/Inspect"]);

             GameManager.instance.gameObject.AddComponent<FindBoss>();

             GameManager.instance.gameObject.AddComponent<GUIForSettings>();
            
             ModHooks.Instance.LanguageGetHook += BossDesc;
        }```

fickle sparrow Jun 8, 2021, 8:24 PM

#

wwhats your unload

vocal spire Jun 8, 2021, 8:25 PM

#

Does it pass null in for preloadedObjects

fickle sparrow Jun 8, 2021, 8:25 PM

#

yeah it should if you don't request any preloads

light zodiac Jun 8, 2021, 8:26 PM

#

fickle sparrow wwhats your unload

ModHooks.LanguageGetHook -= BossDesc;

        var MainComponent = GameManager.instance?.gameObject.GetComponent<FindBoss>();
        if (MainComponent != null) UnityEngine.Object.Destroy(MainComponent);
        var GUIComponent = GameManager.instance?.gameObject.GetComponent<GUIForSettings>();
        if (GUIComponent != null) UnityEngine.Object.Destroy(GUIComponent);

light zodiac Jun 8, 2021, 8:26 PM

#

vocal spire Does it pass null in for preloadedObjects

How do I check that

fickle sparrow Jun 8, 2021, 8:27 PM

#

preloadedObjects only gets passed in on the first time it initializes I think

#

just cache them tbh

light zodiac Jun 8, 2021, 8:27 PM

#

The preloaded object doesn't really matter anyways

fickle sparrow Jun 8, 2021, 8:28 PM

#

well I mean you're indexing it so if its null you'll crash

light zodiac Jun 8, 2021, 8:28 PM

#

I'll remove the preload and try

#

It works now

#

So Toggleable mods can't have preloads?

#

Or is there a workaround?

jolly oriole Jun 8, 2021, 8:34 PM

#

fickle sparrow just cache them tbh

_ _

light zodiac Jun 8, 2021, 8:34 PM

#

Idk how

fickle sparrow Jun 8, 2021, 8:34 PM

#

if preloadedObjects objects is null

#

it means you are re-enabling the mod

#

it will get passed in the first time

light zodiac Jun 8, 2021, 8:35 PM

#

Ok thanks

fickle sparrow Jun 8, 2021, 8:37 PM

#

the lifecycle is basically

1. constructor
2. initialize(with preloaded objects)
3. unload
4. initialize(not with preloaded objects)
5. repeat from 3

rough pulsar Jun 8, 2021, 8:47 PM

#

i got the auto dependency install thingy working on my mod finally!!!
kinda

#

i just made a simple mistake i could fix

floral blade Jun 8, 2021, 9:40 PM

#

if i have a Texture2D A & another one B and i do A = B , does the original A get garbage collected automatically ? or do i need to destroy A manually ?

dark wigeon Jun 9, 2021, 1:42 AM

#

https://github.com/nesrak1/FSMViewAvalonia/pull/3/commits ahhh I knew I should've tested

GitHub

Fix search bug and support double click to select item by DemoJames...

glossy pilot Jun 9, 2021, 1:44 AM

#

wait I need to test too, lmao
let me push a NPE patch quickly

#

done

dark wigeon Jun 9, 2021, 1:49 AM

#

I was making fun of 56 earlier and being able to trust him with the pr without me testing

#

ok this better work

glossy pilot Jun 9, 2021, 1:52 AM

#

I know
btw can you add the Open resources.assets menu, miss it

dark wigeon Jun 9, 2021, 1:53 AM

#

yeah I'll get to those things tonight

#

also those lines need arrow heads lol

#

always bothered me

dark wigeon Jun 9, 2021, 3:16 AM

#

@glossy pilot ok resources.assets back

#

anyone on gog it now does that open folder dialog so you can just pick the location

copper nacelle Jun 9, 2021, 3:17 AM

#

wtf

#

if you click select with nothing selected you are asking for a crash 😤

dark wigeon Jun 9, 2021, 3:18 AM

#

wat

#

@copper nacelle wat

copper nacelle Jun 9, 2021, 3:19 AM

#

idk that's what a commit said it fixed

dark wigeon Jun 9, 2021, 3:19 AM

#

ohh I see

#

you were replying to a commit message

#

yeah uh, I thought clicking select without anything selected working fine would be obvious but

#

someone spent three days trying to get me a stack trace which basically showed dude kept trying to click open without selecting a file

#

I lost faith in humanity long ago

copper nacelle Jun 9, 2021, 3:22 AM

#

pauseshroom

#

disaster

dark wigeon Jun 9, 2021, 3:24 AM

#

anyone using linux fsm view?

glossy pilot Jun 9, 2021, 3:54 AM

#

dark wigeon <@!313598668987039744> ok resources.assets back

nice, but it can't find my hk path now LOL

dark wigeon Jun 9, 2021, 3:55 AM

#

frick

#

that was for debug reasons

#

k release updated

glossy pilot Jun 9, 2021, 4:00 AM

#

also, if I click cancel in the folder selection dialog, the app crashes
you shouldn't trust humanity.

dark wigeon Jun 9, 2021, 4:00 AM

#

ahhhhhhhhhhh

#

why didn't you say that 30 seconds ago

glossy pilot Jun 9, 2021, 4:01 AM

#

shroompog

vocal spire Jun 9, 2021, 4:02 AM

#

dark wigeon why didn't you say that 30 seconds ago

you should’t trust humanity
I’d refer to this sentence

dark wigeon Jun 9, 2021, 4:02 AM

#

I hate debugging in avalonia