#archived-modding-development | Hollow Knight | Page 518

zealous basin Jun 4, 2021, 4:27 PM

#

actually never mind im not even sure i need to do this

pure nova Jun 4, 2021, 5:17 PM

#

You don’t need to not to mention the fact that you can’t.

jolly oriole Jun 4, 2021, 5:34 PM

#

crazy

copper nacelle Jun 4, 2021, 5:41 PM

#

ah yes leaving the question open to be answered for no reason is much better

jolly oriole Jun 4, 2021, 5:43 PM

#

like those stack overflow question one needs
"how do i do X?"
self answer, a few days later: "figured it out"

pure nova Jun 4, 2021, 6:05 PM

#

pure nova You don’t need to not to mention the fact that you can’t.

You don't need the unity project because we don't have access to the unity project so every mod that's ever been made doesn't need it.

copper nacelle Jun 4, 2021, 6:08 PM

#

I mean the implication might be the unity project but you can straight up use scene resources via unity no?

#

Arguably opening hollow knight in a sense, although just a portion

pure nova Jun 4, 2021, 6:21 PM

#

Yeah I guess.

zealous basin Jun 4, 2021, 8:13 PM

#

huh

#

look im not particulary knowledgable of this but no need to be like that

#

anyway

#

now i know more, my question would be.. how do i change textures in the game that arent labeled texture 2d. if that is possible

vocal spire Jun 4, 2021, 8:32 PM

#

Like Sprites?

#

Or tk2d stuff?

zealous basin Jun 4, 2021, 8:32 PM

#

i think so

#

like the sprite sheets

vocal spire Jun 4, 2021, 8:32 PM

#

That’s tk2d stuff

#

At it’s base, it’s just a texture 2d replacement

zealous basin Jun 4, 2021, 8:33 PM

#

yeah

#

i mean like boss sprites specifiically

vocal spire Jun 4, 2021, 8:33 PM

#

All hollow knight enemies/bosses are the same

#

All use tk2d

zealous basin Jun 4, 2021, 8:34 PM

#

ive never heard of tk2d before

vocal spire Jun 4, 2021, 8:35 PM

#

Animation tool team Cherry used

zealous basin Jun 4, 2021, 8:35 PM

#

ahh.

vocal spire Jun 4, 2021, 8:35 PM

#

Just doing

targetgameobject.GetComponent<tk2dSprite>().collection.textures[0] = texture2d I want;```
Should work iirc

zealous basin Jun 4, 2021, 8:36 PM

#

where would that be input? im not sure

#

also, thanks

vocal spire Jun 4, 2021, 8:39 PM

#

Either

(Uses less memory and doesn’t add time to the startup of the game) You use a UnityEngine.ScenweManagement.SceneManager.ActiveSceneChanged hook to start a coroutine that waits for one frame, then uses GameObject.Find to get the instance of the boss GameObject, then use the code I gave on that instance
Preload the boss, then use my code in initialize(running the code I posted on any object will replace the spritesheet for any object that uses that sheet iirc)

zealous basin Jun 4, 2021, 8:50 PM

#

I'm gonna be honest and say i have no idea what I am supposed to do this in. i think i've heard of modding API for the game, but i'm not sure. I'm new to modding hollow knight pretty much, although i have unity, UABE, and the game on pc.

jolly oriole Jun 4, 2021, 8:55 PM

#

https://radiance.host/apidocs/

zealous basin Jun 4, 2021, 8:56 PM

#

ah! thatll be it, thank you

patent zealot Jun 4, 2021, 10:26 PM

#

are there any already existing mods that preload gameobjects

#

https://radiance.host/apidocs/ModdingAPI.html#preload-gameobjects this part*

vocal spire Jun 4, 2021, 11:08 PM

#

patent zealot are there any already existing mods that preload gameobjects

Pretty much every mod I know of does

#

If you need to look at what GameObjects are in a scene, look in the pins for scenes.rar and GGscenes.zip

#

Extract them then open the files in them in notepad(or a different text editor/viewer)

#

Example of preloading https://github.com/jngo102/HollowKnight.CustomKnight/blob/master/CustomKnight/CustomKnight.cs

GitHub

jngo102/HollowKnight.CustomKnight

Hollow Knight mod to load custom texture sheets for the player - jngo102/HollowKnight.CustomKnight

patent zealot Jun 4, 2021, 11:13 PM

#

Alright thanks

#

i had the scenes, i was just confused on how it worked and needed an example

thick nebula Jun 5, 2021, 2:31 AM

#

I'm new to modding development and not sure if this would even be a 'mod' per se, but would it be possible for me to replace sound effects in game?

#

Example: crappy voice overs so instead of the nail sound its me saying swish

runic wind Jun 5, 2021, 2:33 AM

#

Yep it’s possible

thick nebula Jun 5, 2021, 2:33 AM

#

How could I go about doing it?

runic wind Jun 5, 2021, 2:34 AM

#

You’d be editing whatever fsm controls swinging the nail and changing its sound playing action, most likely

vocal spire Jun 5, 2021, 2:47 AM

#

Iirc there’s a way to do it with hooks, I think the boop mod might have done it(tried it when updating it to current patch, didn’t really look at the code)

flat summit Jun 5, 2021, 4:32 AM

#

so, a hypothetical - if i wanted to make a mod that replaces all the music in HK with me playing it on kazoo, would anyone actually want that abomination, and also how the hell do i acomplish such a thing

vocal spire Jun 5, 2021, 5:08 AM

#

flat summit so, a hypothetical - if i wanted to make a mod that replaces all the music in HK...

You have to mess with audio snapshots for that iirc. Not sure who would want it, but why not

runic wind Jun 5, 2021, 6:37 AM

#

I'd use it at least once

tawny onyx Jun 5, 2021, 7:14 AM

#

nvm, i've found camera control code

frosty valley Jun 5, 2021, 8:41 AM

#

is there a modding api for the hollow knight 1.5 beta?

#

i've heard using the api alone improves performance which is fantastic for my shit laptop

tawny onyx Jun 5, 2021, 8:51 AM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding you can build yourself

GitHub

HollowKnight-Modding/HollowKnight.Modding

Hollow Knight Modding API. Contribute to HollowKnight-Modding/HollowKnight.Modding development by creating an account on GitHub.

frosty valley Jun 5, 2021, 8:52 AM

#

ah i dont know how to code lol

primal latch Jun 5, 2021, 9:38 AM

#

@copper nacelle could you improve the build instructions for the modding API? They don’t seem to be correct

jolly oriole Jun 5, 2021, 10:48 AM

#

tawny onyx ~~~<@!202560032712163329> I have a question about how to set scene size. the van...

If i were awake when you asked this, i wouldve probably linked the SceneChanger from tot, as i have that code somewhere at the top of that class

copper nacelle Jun 5, 2021, 11:07 AM

#

Besides it being in debug instead of release I don't see any issue with the instructions

primal latch Jun 5, 2021, 11:09 AM

#

copper nacelle Besides it being in debug instead of release I don't see any issue with the inst...

There is no folder named OutputFinal

#

And no ModdingAPI.zip shows up

copper nacelle Jun 5, 2021, 11:10 AM

#

like I said

#

debug instead of release

#

swap to release

primal latch Jun 5, 2021, 11:10 AM

#

Ah. Ok. I’ll try later.

thick nebula Jun 5, 2021, 1:33 PM

#

thick nebula I'm new to modding development and not sure if this would even be a 'mod' per se...

let me rephrase: is there any way i could accomplish this without any coding experience?

cedar hemlock Jun 5, 2021, 1:38 PM

#

prob not

#

unless someone does it for you

#

but that chance is small

#

wait

#

there might be something that might work

thick nebula Jun 5, 2021, 1:39 PM

#

what is it?

cedar hemlock Jun 5, 2021, 1:39 PM

#

CustomBGM

#

made by SFG

#

but it prob wont work...

jolly oriole Jun 5, 2021, 1:40 PM

#

sounds effects no

#

BGM yes

cedar hemlock Jun 5, 2021, 1:40 PM

#

oh ok

cedar hemlock Jun 5, 2021, 1:40 PM

#

thick nebula let me rephrase: is there any way i could accomplish this without any coding exp...

so, no

thick nebula Jun 5, 2021, 1:41 PM

#

darn

dawn halo Jun 5, 2021, 3:34 PM

#

Hello modders, could you help me kickstart my Thai localization mod? I really love this game and want to help translate into Thai language to help make this game more accessible for Thai gamers. I have experience in Book Translation and localization of other games, but very little to no info about how to create a mod project and work on it.

I searched in this channel and found this message, so does that mean I can use this to start translating rightaway?
#archived-modding-development message
On pinned messages, what does TranslationMod.dll do? And how to use it?
How to insert new font into the game?
I saw that modding this game requires Unity knowledge, if I consult my friend who can use UnityEngine, would they understand how to pack/unpack mod rightaway?

I apologize for my very noob questions. I would like to start the translation/localization asap and see whether Thai font has problems or not.

Thank you so much guys.

vocal spire Jun 5, 2021, 3:36 PM

#

It looks like that’s the poorly translated mod

copper nacelle Jun 5, 2021, 3:36 PM

#

no
puts it through about 50 google translate layers so you get garbage as an output
you need an asset bundle but you can also load os fonts if the font you need is standard
not right away but the code should be familiar

vocal spire Jun 5, 2021, 3:37 PM

#

What you’d probably need to do is either replace a language in the game, or somehow add something to the enum for languages and it to the ui

dawn halo Jun 5, 2021, 3:37 PM

#

First of all, thank you for your time.

#

On replacing a language, I've tried Bloodstained Ritual of the Night (UnrealEngine) and that game required replacing bit by bit in hexedit, is this game like that?

vocal spire Jun 5, 2021, 3:39 PM

#

Nah

#

I mean you can do that if you want

dawn halo Jun 5, 2021, 3:39 PM

#

I prefer not to do that :X

vocal spire Jun 5, 2021, 3:39 PM

#

But you can just code a mod for that

dawn halo Jun 5, 2021, 3:40 PM

#

Right now I have only ModInstaller (the Zote icon) and don't know what to do to start getting the original English localization text to work on

vocal spire Jun 5, 2021, 3:41 PM

#

What I’d do: use a LanguageGetHook, detect if the language is the language you want to replace(or don’t do this if you just want to have every language replaced) then get the value from a Dictionary<string, Dictionary<string, string>> using the sheet and key parameters for the hook

#

I forgot where to get it from, might be a good idea to check the history of this channel

copper nacelle Jun 5, 2021, 3:42 PM

#

Bro

#

Pretty sure grenade already has a whole thing

vocal spire Jun 5, 2021, 3:42 PM

#

Oh yeah

floral blade Jun 5, 2021, 3:42 PM

#

isn't there a language mod thingy ?

vocal spire Jun 5, 2021, 3:42 PM

#

I blame just waking up

copper nacelle Jun 5, 2021, 3:43 PM

#

https://github.com/SFGrenade/LanguageSupport

GitHub

SFGrenade/LanguageSupport

A Hollow Knight mod. Contribute to SFGrenade/LanguageSupport development by creating an account on GitHub.

#

Should be pretty easy if you follow the readme

dawn halo Jun 5, 2021, 3:44 PM

#

Oh thank you you all for helping

#

I would take a look at it

#

Good think is I don't have to face horror like Bloodstained

copper nacelle Jun 5, 2021, 3:46 PM

#

Nah this should be much much easier

#

Just a few text files

jolly oriole Jun 5, 2021, 3:46 PM

#

like 15

#

or something

#

36*

#

though at least one of them is literally just copy paste

#

the one with the prices in it

dawn halo Jun 5, 2021, 3:47 PM

#

what do you mean?

jolly oriole Jun 5, 2021, 3:48 PM

#

you probably don't need to change a single thing in Prices.txt for your translation, as it's literally just numbers

dawn halo Jun 5, 2021, 3:48 PM

#

oh ok

jolly oriole Jun 5, 2021, 3:49 PM

#

and so you can save yourself like 5 seconds, thai language code is "TH"

dawn halo Jun 5, 2021, 4:04 PM

#

Thank you lifesavers

copper nacelle Jun 5, 2021, 4:07 PM

#

yo nice

jolly oriole Jun 5, 2021, 4:14 PM

#

poggers

dawn halo Jun 5, 2021, 4:26 PM

#

is it possible to add my language at boot time? right now i need to select English and then head to options to change it

#

#

#

and oof

jolly oriole Jun 5, 2021, 4:29 PM

#

sadly i don't think that it's possible to have it be added that early

dawn halo Jun 5, 2021, 4:33 PM

#

do you know how to fix Thai characters shown as squares?

jolly oriole Jun 5, 2021, 4:37 PM

#

that would need some things to make the game know how each character looks, i think there are some messages here that outline how to do that, let me look

#

seems like it's from this point downwards

dawn halo Jun 5, 2021, 4:44 PM

#

so i should download unity and open the asset something like that?

jolly oriole Jun 5, 2021, 4:45 PM

#

hm, maybe that also doesn't quite work, as the perpetua font (which is used by hk) doesn't have thai characters :/

dawn halo Jun 5, 2021, 4:50 PM

#

so is there a way to inject/replace font?
can i insert Thai characters into hk font directly, in a way that if i type อีกแล้วเหรอ and it would show those chars? or do i have to replace some of the current fonts which aren't used in Thai (such as AEIOU that have hats on top) and use that in my .txt? (e.g. ÍÕ¡¥ÅÜÇ£ËÃÍ)

jolly oriole Jun 5, 2021, 4:50 PM

#

though i can try making a character map with the noto serif thai font (which hopefully has thai characters)

copper nacelle Jun 5, 2021, 4:50 PM

#

you can change the font of the text mesh can't you

jolly oriole Jun 5, 2021, 4:51 PM

#

after i'm done eating

copper nacelle Jun 5, 2021, 4:51 PM

#

The unity text is easy you can just load a font off the host

jolly oriole Jun 5, 2021, 4:51 PM

#

copper nacelle you can change the font of the text mesh can't you

yea, but i thought maybe the perpetua one already had thai characters, that one doesn't have to use another font and let hk think it's still the same

dawn halo Jun 5, 2021, 4:52 PM

#

main menu Thai works fine, but in game isn't

#

I really appreciate your help, and no rush, thank you so much.
I've looked up, Perpetua doesn't have Thai chars, but Noto Serif has them.

#

It's midnight (0:00) here, so good night/day. I'll pop back soon

pure nova Jun 5, 2021, 6:05 PM

#

Wrong channel.

fair rampart Jun 5, 2021, 6:05 PM

#

oh sorry XD

jolly oriole Jun 5, 2021, 6:14 PM

#

i've never done this, can only go well

jolly oriole Jun 5, 2021, 6:29 PM

#

dawn halo 1. so is there a way to inject/replace font? 2. can i insert Thai characters int...

uh, this might sound rude, but are there more 'thai' characters than what parts of the internet show me? the 2nd character of the thing you wrote is apparently not part of noto's thai font

#

nvm, now it works

jolly oriole Jun 5, 2021, 7:21 PM

#

close but not quite

primal latch Jun 5, 2021, 7:21 PM

#

jolly oriole close but not quite

Yes. Close

jolly oriole Jun 5, 2021, 7:23 PM

#

🤔

jolly oriole Jun 5, 2021, 8:04 PM

#

why

patent zealot Jun 5, 2021, 8:05 PM

#

How would one change what enemies appear in arena waves?

#

for example like the one in queens gardens

#

i looked at the fsm for it, and only found the wait time between and the triggers

vocal spire Jun 5, 2021, 8:17 PM

#

patent zealot How would one change what enemies appear in arena waves?

probably look at the custom trials mod

#

https://github.com/jngo102/HollowKnight.CustomTrial

GitHub

jngo102/HollowKnight.CustomTrial

Create custom Colosseum trials in Hollow Knight. Contribute to jngo102/HollowKnight.CustomTrial development by creating an account on GitHub.

patent zealot Jun 5, 2021, 8:18 PM

#

alr

jolly oriole Jun 5, 2021, 9:12 PM

#

sad

vocal spire Jun 5, 2021, 9:20 PM

#

Kool

jolly oriole Jun 5, 2021, 9:43 PM

#

dawn halo It's midnight (0:00) here, so good night/day. I'll pop back soon

it appears that i can't add new characters, it just doesn't want to work, sad

dawn halo Jun 6, 2021, 2:44 AM

#

Does that mean Thai language mod would be impossible for this game ?

vocal spire Jun 6, 2021, 3:30 AM

#

I'd try it but I haven't messed with fonts in unity

pale crest Jun 6, 2021, 4:16 AM

#

I'm guessing GG_Arena_Prefab\BG\GG_gods_ray isn't a traditional game object?

#

tried adding that to mulhima's mod that deletes objects, thinking it would remove the light rays in dung defender's arena

#

learned when dung defender is defeated, I can't leave because he isn't sent flying into the background

#

because there is no background zote

dawn halo Jun 6, 2021, 4:45 AM

#

jolly oriole uh, this might sound rude, but are there more 'thai' characters than what parts ...

there are many characters missing from that picture

#

like vowels that float above/below and tone marks

#

https://jrgraphix.net/r/Unicode/0E00-0E7F

#

i.e. 0E34 and so on, 0E47 and so on

dawn halo Jun 6, 2021, 4:49 AM

#

jolly oriole close but not quite

was that because thai font has no English chars, so they disappeared?

dawn halo Jun 6, 2021, 5:09 AM

#

one more problem with Thai fonts, especially google fonts, the floating vowels and tone marks will collide with each other, so there is another font version that is a workaround.

like this CC-BY font https://www.f0nt.com/download/raveetavan/CSChatThai.zip

You will need CSChatThaiUI font for displaying in applications, not the original CSChatThai which is for typing in Web/Microsoft Word/Google Docs

The normal font use computer logic to determine when the floating character will stay at its level, or rise up one more level, etc.
The ......UI font gives every floating character a fixed offset, so all characters will now have their own offset to avoid colliding with each other.

dawn halo Jun 6, 2021, 5:43 AM

#

I wonder why Thai chars worked flawlessly in Main Menu (also vowels/tone marks offset perfectly), does it use different font? If so, could we use that in game too?

tawny onyx Jun 6, 2021, 8:48 AM

#

yeah Main Menu use different font

floral blade Jun 6, 2021, 9:36 AM

#

is there a way to give modInstaller a source zip file and have it install to hk as a mod ? (i would like to avoid compiling a fork)

cedar hemlock Jun 6, 2021, 12:33 PM

#

it cant compile for you

#

it can if you give it a zip, unzip everything to the mods folder

floral blade Jun 6, 2021, 12:35 PM

#

i want to give a compiled mod's zip (locally) and have it install into the game

cedar hemlock Jun 6, 2021, 12:36 PM

#

wdym with install into the game

floral blade Jun 6, 2021, 12:36 PM

#

basically the same steps it does when installing a mod from modlinks.xml

#

but for a local zip file

cedar hemlock Jun 6, 2021, 12:36 PM

#

a zip already present on the pc you mean?

floral blade Jun 6, 2021, 12:36 PM

#

yes

cedar hemlock Jun 6, 2021, 12:37 PM

#

just make your mod unzip it

floral blade Jun 6, 2021, 12:37 PM

#

the mod is in the zip file

cedar hemlock Jun 6, 2021, 12:37 PM

#

oh you mean for testing

floral blade Jun 6, 2021, 12:37 PM

#

yes

cedar hemlock Jun 6, 2021, 12:38 PM

#

press the manually install button at the bottom of the installer

floral blade Jun 6, 2021, 12:38 PM

#

this is modinstaller 2 ? (i'm on mac)

cedar hemlock Jun 6, 2021, 12:38 PM

#

go to the mods folder and put the dll there

#

Go to steam -> right click hollow knight -> click on properties-> click on local files -> browse local files -> Hollow_Knight_Data -> Managed -> mods

floral blade Jun 6, 2021, 12:40 PM

#

yes i do that when testing the mod during development, but some times MI unzips all files into the /mods directory as opposed to maintaining the directory structure. i am assuming that's due to my zip's directory structure being incorrectly made.

#

i'd like to test the modinstaller's installing behaviour without raising a PR to modlinks.xml & potentially breaking it for others

cedar hemlock Jun 6, 2021, 12:41 PM

#

then i see no other way other then using modinstaller 1

#

but that isn't possible on mac...

#

idk maybe someone else can help

jolly oriole Jun 6, 2021, 12:51 PM

#

TIL hk's font is either Perpetua or Noto Serif CJK SC

light zodiac Jun 6, 2021, 1:46 PM

#

floral blade is there a way to give modInstaller a source zip file and have it install to hk ...

You could build the modinstaller locally and in 'ModManager.cs' change the private const string ModLinks to a modlinks file with the thing you wanna test

#

Or am I misunderstanding what you want to do

floral blade Jun 6, 2021, 1:49 PM

#

you're right but that's what i was wanting to avoid

vocal spire Jun 6, 2021, 2:25 PM

#

floral blade you're right but that's what i was wanting to avoid

That’s what I did when testing the fixed CustomKnight zip

#

Couldn’t use google drive since it was so large it gave me the can’t scan for viruses message

#

Didn’t want to go through the trouble of GitHub

floral blade Jun 6, 2021, 2:32 PM

#

i guess that's probably what i'll end up doing then, might raise a PR to MI2 to check for this in settings.

merry lotus Jun 6, 2021, 3:41 PM

#

floral blade i guess that's probably what i'll end up doing then, might raise a PR to MI2 to ...

If you are going to build MI2, and raise a PR for an improvement, can I suggest also adding an "open mods folder" button of some kind?

primal latch Jun 6, 2021, 5:31 PM

#

Hey guys, I was wondering: IF silksong comes out, how do we want to handle modding? Do we want to use the same system as the current modding API or do we want to use a runtime injection based system like subnautica?

vocal spire Jun 6, 2021, 5:32 PM

#

I’d think we’d use a similar api, but before it’s developed we’d use something like BepInEx and harmony

primal latch Jun 6, 2021, 5:35 PM

#

I’m considering to already start after Fyremoth is done. (Setting up everything and writing some mod loading code) so we can get started immediately after SS releases

copper nacelle Jun 6, 2021, 5:35 PM

#

it's not like it's difficult

vocal spire Jun 6, 2021, 5:36 PM

#

Yeah

primal latch Jun 6, 2021, 5:37 PM

#

No. I get that. It would just kickstart the modding community on release.

vocal spire Jun 6, 2021, 5:37 PM

#

I’ve tried creating a very simple ModdingApi for some other unity games and it’s pretty simple

#

Did it within a couple hours

#

During school

#

In person

jolly oriole Jun 6, 2021, 6:55 PM

#

[INFO]:[ModCommon] - Mod Common is done initializing!
[INFO]:[TestMod] - CPP WORKS!
[INFO]:[API] - Saving Global Settings

it just works

copper nacelle Jun 6, 2021, 6:55 PM

#

cpphell ax1uWide3

vocal spire Jun 6, 2021, 6:56 PM

#

Kool

jolly oriole Jun 6, 2021, 6:56 PM

#

the mapi threw an exception when i had no namespace

#

so i had to think of a name

vocal spire Jun 6, 2021, 6:56 PM

#

So we can mod in c++, nice, ~~time to learn it~~

jolly oriole Jun 6, 2021, 6:57 PM

#

it's not c++, it's CIL, so pretty much the same as c#, just c++ writing

vocal spire Jun 6, 2021, 6:57 PM

#

Ah ok

copper nacelle Jun 6, 2021, 6:57 PM

#

c++/cil pauseshroom

jolly oriole Jun 6, 2021, 6:57 PM

#

but it looks funny in dnspy

copper nacelle Jun 6, 2021, 6:58 PM

#

does that support the c++20 stuff

#

Or is it just bad

jolly oriole Jun 6, 2021, 6:58 PM

#

maybe?

#

what c++20 stuff should i throw in

copper nacelle Jun 6, 2021, 6:58 PM

#

std::span maybe

#

Concepts

jolly oriole Jun 6, 2021, 6:59 PM

#

i need an include for that, do i?

#

then it doesn't work

copper nacelle Jun 6, 2021, 6:59 PM

#

yes

#

echnight

#

what's the point of it then

#

finally ugly c#

jolly oriole Jun 6, 2021, 7:00 PM

#

(my vs only allows up to c++17 regardless radS )

copper nacelle Jun 6, 2021, 7:00 PM

#

do lambdas work

#

try an iife

#

{ }()

#

kinda beat

jolly oriole Jun 6, 2021, 7:03 PM

#

copper nacelle []() { }()

can i just copy paste this?

#

local lambda function isn't possible in a member function of a mamanged class

#

but if statements with initializers work

copper nacelle Jun 6, 2021, 7:06 PM

#

this seems very limited ngl

#

what's the decomp look like under cpphell?

floral blade Jun 6, 2021, 7:06 PM

#

jolly oriole ``` [INFO]:[ModCommon] - Mod Common is done initializing! [INFO]:[TestMod] - CPP...

now make it do javascript gorbbrain

vocal spire Jun 6, 2021, 7:07 PM

#

~~scratch~~

floral blade Jun 6, 2021, 7:09 PM

#

56 pls check the PR on MI2 popseeker

jolly oriole Jun 6, 2021, 7:09 PM

#

copper nacelle what's the decomp look like under cpphell?

left turned to right

copper nacelle Jun 6, 2021, 7:11 PM

#

Oh that's interesting

copper nacelle Jun 6, 2021, 7:13 PM

#

floral blade 56 pls check the PR on MI2 <:popseeker:663988996648730634>

later

#

I am about to leave

vocal spire Jun 6, 2021, 7:13 PM

#

Cya

jolly jungle Jun 6, 2021, 7:23 PM

#

How do I check if a trial has been completed previously?

jolly oriole Jun 6, 2021, 7:25 PM

#

getbool completedtrialgold/silver/bronze

light zodiac Jun 6, 2021, 7:25 PM

#

"colosseumBronzeOpened": true,
"colosseumBronzeCompleted": true,
"colosseumSilverOpened": true,
"colosseumSilverCompleted": true,
"colosseumGoldOpened": true,
"colosseumGoldCompleted": true,```
these pd bools may be of interest to you

jolly jungle Jun 6, 2021, 7:30 PM

#

Thanks

#

So at any point at all I do getbool completedtrialgold and it tells me if t3 was completed yet?

light zodiac Jun 6, 2021, 7:31 PM

#

or just PlayerData.instance.colosseumGoldCompleted

vocal spire Jun 6, 2021, 7:31 PM

#

Or just PlayerData.Instance.completedtrualgold

copper nacelle Jun 6, 2021, 7:31 PM

#

it's not snail he suggested trual

vocal spire Jun 6, 2021, 7:32 PM

#

Yeah, trual not trial

light zodiac Jun 6, 2021, 7:32 PM

#

why did i even say trial

jolly jungle Jun 6, 2021, 7:35 PM

#

wait so colosseumGoldCompleted or completedtrialgold?

#

in PlayerData.instance.etc.

vocal spire Jun 6, 2021, 7:36 PM

#

I’d look at the stuff in the colosseum rooms or just trual and error ¯_(ツ)_/¯

light zodiac Jun 6, 2021, 7:36 PM

#

jolly jungle wait so `colosseumGoldCompleted` or `completedtrialgold`?

my user1.json shows colosseumGoldCompleted so...

jolly jungle Jun 6, 2021, 7:41 PM

#

vocal spire I’d look at the stuff in the colosseum rooms or just *trual* and error ¯\_(ツ)_/¯

redfrog please shermanxious || zotewheeze ||

patent zealot Jun 6, 2021, 7:47 PM

#

is slashhithook called when a grubjar is hit

vocal spire Jun 6, 2021, 9:07 PM

#

patent zealot is slashhithook called when a grubjar is hit

I don’t have the code, but probably. If not you can probably use a on hook

pale crest Jun 6, 2021, 9:07 PM

#

pale crest I'm guessing `GG_Arena_Prefab\BG\GG_gods_ray` isn't a traditional game object?

bump

patent zealot Jun 6, 2021, 9:07 PM

#

yeah i just tried it

#

looks like it works

vocal spire Jun 6, 2021, 9:08 PM

#

pale crest bump

I’ll look at it. It is just a normal GameObject, might just have some stuff depending on it

pale crest Jun 6, 2021, 9:08 PM

#

awesome, thanks

#

might have to do with gods_ray being connected to the overall object gg_arena_prefab

vocal spire Jun 6, 2021, 9:14 PM

#

I don’t think so

#

Can you show how you entered it in?

#

It just appears to be the parent to some light rays

pale crest Jun 6, 2021, 9:15 PM

#

hmm

#

I'll try this

#

📎 ClassLibrary1.dll

vocal spire Jun 6, 2021, 9:15 PM

#

?

pale crest Jun 6, 2021, 9:16 PM

#

it's the code that mulhima wrote for deleting objects

vocal spire Jun 6, 2021, 9:16 PM

#

But can you show how you entered in the object’s name

pale crest Jun 6, 2021, 9:18 PM

#

ah okay

if (arg1.name == "GG_Arena_Prefab")

vocal spire Jun 6, 2021, 9:18 PM

#

Is that it

pale crest Jun 6, 2021, 9:18 PM

#

should I like

#

upload the whole thing

vocal spire Jun 6, 2021, 9:19 PM

#

That would be helpful

#

I can’t view the file you sent since I’m on mobile atm

pale crest Jun 6, 2021, 9:20 PM

#

📎 ex.txt

#

took out gg_arena_prefab part

vocal spire Jun 6, 2021, 9:21 PM

#

Well ofc it’s gonna have a problem, it was deleting that and not just the object you specified

vocal spire Jun 6, 2021, 9:22 PM

#

pale crest ah okay `if (arg1.name == "GG_Arena_Prefab")`

Oh nvm this is checking if it’s the name of a scene?

#

Can you show it with the dung defender code included?

pale crest Jun 6, 2021, 9:23 PM

#

shit I got it mixed it up

#

I put in if (arg1.name == "GG_Dung_Defender)

vocal spire Jun 6, 2021, 9:23 PM

#

Ok

#

And the if (go.name.Contains(“arena prefab thing”)) was in the other one?

pale crest Jun 6, 2021, 9:24 PM

#

yes

vocal spire Jun 6, 2021, 9:25 PM

#

vocal spire Well ofc it’s gonna have a problem, it was deleting that and not just the object...

Well this applies

#

Instead do the object’s name, not the beginning object in the path

vocal spire Jun 6, 2021, 9:26 PM

#

pale crest I'm guessing `GG_Arena_Prefab\BG\GG_gods_ray` isn't a traditional game object?

In this case it’s GG_gods_ray

pale crest Jun 6, 2021, 9:27 PM

#

so not GG_Arena_Prefab\BG\GG_gods_ray

vocal spire Jun 6, 2021, 9:27 PM

#

No

#

That would end with nothing deleted

#

GG_Arena_Prefab is the parent of BG which is the parent of GG_gods_ray which is the object you want to delete

pale crest Jun 6, 2021, 9:29 PM

#

okay I'll try that when I get home

#

much thanks

candid sapphire Jun 6, 2021, 11:29 PM

#

where can I find a tutorial on how to make mods?

runic wind Jun 6, 2021, 11:54 PM

#

Docs on radiance.host + some videos that may or may not be helpful

candid sapphire Jun 7, 2021, 1:23 AM

#

runic wind Docs on radiance.host + some videos that may or may not be helpful

ty

slow temple Jun 7, 2021, 2:02 AM

#

Just made my first simple mod. "QOLGatheringCompass" removes the cost of Gathering Swarm and Wayward Compass. Wondering if I need to have public void Start() or public void OnDestroy() here is the full code.
`using Modding;
using UnityEngine;
using System;
using HutongGames.PlayMaker;

namespace nsQOLGatheringCompass
{
public class QOLGatheringCompass : Mod
{
public override void Initialize()
{
Log("Initializing QOLGatheringCompass...");
ReduceCharmCost();
ModHooks.Instance.BeforeSavegameSaveHook += RestoreCharmCost;
ModHooks.Instance.SavegameLoadHook += ReduceCharmCost;
ModHooks.Instance.SavegameSaveHook += ReduceCharmCost;
ModHooks.Instance.NewGameHook += ReduceCharmCost;
}
public void Start()
{
ReduceCharmCost();
ModHooks.Instance.BeforeSavegameSaveHook += RestoreCharmCost;
ModHooks.Instance.SavegameSaveHook += ReduceCharmCost;
ModHooks.Instance.NewGameHook += ReduceCharmCost;
}

    public void OnDestroy()
    {
        ModHooks.Instance.BeforeSavegameSaveHook -= RestoreCharmCost;
        ModHooks.Instance.SavegameSaveHook -= ReduceCharmCost;
    }

    private void ReduceCharmCost()
    {
        PlayerData.instance.charmCost_1 = 0;
        PlayerData.instance.charmCost_2 = 0;
    }

    private void ReduceCharmCost(int id)
    {
        ReduceCharmCost();
    }

    private void RestoreCharmCost(SaveGameData data)
    {
        PlayerData.instance.charmCost_1 = 1;
        PlayerData.instance.charmCost_2 = 1;
    }
}

}`

copper nacelle Jun 7, 2021, 2:03 AM

#

No, those are unity events which you want on MonoBehaviours and such

slow temple Jun 7, 2021, 2:03 AM

#

so i should be fine to remove them?

copper nacelle Jun 7, 2021, 2:03 AM

#

Mod isn't a unity type, you just use initialize

#

Yeah

#

If you want to have an undo, you can run that before the SaveGame save and restore it after

#

That way the modified costs don't affect a save file

#

However there's no real reason to actually change the fields imo

#

Can just override GetInt

#

And in that case if you want to turn the mod off it's a simple as not using it, though you can implement IToggleableMod to make it swappable in-game.

slow temple Jun 7, 2021, 2:05 AM

#

so do i need to

#

ModHooks.Instance.BeforeSavegameSaveHook -= RestoreCharmCost; ModHooks.Instance.SavegameSaveHook -= ReduceCharmCost;

copper nacelle Jun 7, 2021, 2:06 AM

#

Not really no unless you want to make your mod toggleable in game

slow temple Jun 7, 2021, 2:06 AM

#

if I did if i add them on ini where do i remove them?

copper nacelle Jun 7, 2021, 2:07 AM

#

You can implement IToggleableMod and then put those in Unload

#

Then you'd be able to turn off the mod from the mods menu

slow temple Jun 7, 2021, 2:08 AM

#

ok, thanks for the help I'll look at IToggleableMod

#

What is a good resource for a Toggleable Mod?

copper nacelle Jun 7, 2021, 2:13 AM

#

https://github.com/fifty-six/HollowKnight.HellMod/blob/master/HellMod/HellMod.cs this has it I guess

#

It's just the Unload and : Mod, IToggleableMod really

slow temple Jun 7, 2021, 4:10 AM

#

Does this seem correct? It appears to be working correctly.

#

`using Modding;
using UnityEngine;
using System;
using HutongGames.PlayMaker;

namespace nsQoLGatheringCompass
{
public class QoLGatheringCompass : Mod, ITogglableMod
{
public QoLGatheringCompass() : base("QoL GatheringCompass") { }
public override void Initialize()
{
Log("Initializing QoL GatheringCompass...");
ModHooks.Instance.GetPlayerIntHook += ReduceCharmCost;
}
private int ReduceCharmCost(string intName)
{
if (intName == nameof(PlayerData.charmCost_1) | intName == nameof(PlayerData.charmCost_2))
{
return 0;
}
return PlayerData.instance.GetIntInternal(intName);
}
public void Unload()
{
ModHooks.Instance.GetPlayerIntHook -= ReduceCharmCost;
}
}
}`

slow temple Jun 7, 2021, 4:38 AM

#

This is the QoL GatheringCompass mod, it removes the charm cost of Gathering Swarm and Wayward Compass without editing save data.

📎 QoLGatheringCompass.dll

vocal spire Jun 7, 2021, 5:41 AM

#

1.5 time kool

primal latch Jun 7, 2021, 5:55 AM

#

Hype

vocal spire Jun 7, 2021, 5:56 AM

#

api building time kool

primal latch Jun 7, 2021, 5:57 AM

#

Yeah.

#

I expected a bit more hype here….

vocal spire Jun 7, 2021, 6:01 AM

#

like no one is on

primal latch Jun 7, 2021, 6:01 AM

#

Yeah. Let’s colonise this channel in the name of Fyremoth

vocal spire Jun 7, 2021, 6:04 AM

#

oh I just realized it's 1am for me

#

what better thing to do than update mods

primal latch Jun 7, 2021, 6:04 AM

#

Lmao

#

It’s 08:04 here

vocal spire Jun 7, 2021, 6:05 AM

#

when everyone wakes up there's gonna be a fun surprise

primal latch Jun 7, 2021, 6:05 AM

#

Yeah.

pure nova Jun 7, 2021, 6:07 AM

#

This is where the fun begins. Unless you're in #archived-modding-help. Best of wishes if you frequent #archived-modding-help.

floral blade Jun 7, 2021, 7:19 AM

#

Will modinstaller now maintain 2 versions of mods ? For 1.4 & 1.5 ? Assuming that a lot of mods would not get updated to 1.5 due to their creators moving on to something else

#

or would they be dropped ?

jolly oriole Jun 7, 2021, 7:23 AM

#

drop it like its hot

cedar hemlock Jun 7, 2021, 7:54 AM

#

@rough pulsar we have .net 4.7.2 now, you can continue with your project

primal latch Jun 7, 2021, 8:03 AM

#

We (Fyremoth) are going away from 32 bit ASAP. We have had too much memory issues.

vocal spire Jun 7, 2021, 8:04 AM

#

(let's still make a 32bit version so 32bit people can play)

primal latch Jun 7, 2021, 8:04 AM

#

No

vocal spire Jun 7, 2021, 8:04 AM

#

yes

primal latch Jun 7, 2021, 8:05 AM

#

I don’t want to maintain 2 seperate versions

vocal spire Jun 7, 2021, 8:05 AM

#

then at the end of development for 1.5 we switch back to 1.4.3.2 and remove enemy sprite patching(except for custom enemies)

primal latch Jun 7, 2021, 8:05 AM

#

Yeah. Let’s do something like that

cedar hemlock Jun 7, 2021, 8:08 AM

#

Dont bully 32 bit people

vocal spire Jun 7, 2021, 8:09 AM

#

I'm not?

cedar hemlock Jun 7, 2021, 8:13 AM

#

primal latch No

_ _

primal latch Jun 7, 2021, 8:14 AM

#

I’m sorry, but I have had to fix like 30 issues relating to assigning too much memory

jolly oriole Jun 7, 2021, 8:29 AM

#

while the modinstaller is 'soft down', i have my vote for sha256

vestal plover Jun 7, 2021, 8:30 AM

#

jolly oriole while the modinstaller is 'soft down', i have my vote for sha256

What is the rationale behind the hash check, download integrity?

jolly oriole Jun 7, 2021, 8:31 AM

#

yes

cedar hemlock Jun 7, 2021, 8:32 AM

#

to check if its the latest update

light zodiac Jun 7, 2021, 8:32 AM

#

jolly oriole yes

The wrong sha doesn't block downloads?

vestal plover Jun 7, 2021, 8:33 AM

#

It's just unfortunate that you can't add a github latest release link (/releases/latest) to the modlinks file that way. I just don't feel like opening a new PR every time I make a new release.

cedar hemlock Jun 7, 2021, 8:34 AM

#

you can

#

ehm lemme show

vocal spire Jun 7, 2021, 8:34 AM

#

hmmm

cedar hemlock Jun 7, 2021, 8:34 AM

#

https://github.com/ricardosouzag/ModInstaller/blob/9103b8bb63cefd83ecaefa145463b5943c7c1bd5/modlinks.xml#L839

vocal spire Jun 7, 2021, 8:34 AM

#

what if we had a system where other modlinks files could be added?

#

every person who has a mod can have their own, only needing a pr once

#

their own modlink can be in their own repo where they don't have to go through as much trouble

#

also I'm casting in my vote for both 1.4.3.2 and 1.5 support

vestal plover Jun 7, 2021, 8:36 AM

#

cedar hemlock <https://github.com/ricardosouzag/ModInstaller/blob/9103b8bb63cefd83ecaefa145463...

What is the point of the hash then? If the DLL in the release changes, the hash should also change, and then some check with the hash should fail right? What am I missing here?

cedar hemlock Jun 7, 2021, 8:36 AM

#

oh yeah im stoopid

vocal spire Jun 7, 2021, 8:36 AM

#

👏

#

~~congrats~~

cedar hemlock Jun 7, 2021, 8:37 AM

#

i mean i am willing to make a new pr for every new HKMP release

#

the only contributing i have done is changing sha1's of mods i didn't even make

light zodiac Jun 7, 2021, 8:37 AM

#

Time to change that

cedar hemlock Jun 7, 2021, 8:38 AM

#

nope

vestal plover Jun 7, 2021, 8:38 AM

#

I'm just wondering whether download integrity checking with hashes is even worth it

cedar hemlock Jun 7, 2021, 8:38 AM

#

im bad at making mods

vocal spire Jun 7, 2021, 8:38 AM

#

I think it is

cedar hemlock Jun 7, 2021, 8:38 AM

#

vestal plover I'm just wondering whether download integrity checking with hashes is even worth...

its to check if the user has updated

#

otherwise the modinstaller doesnt know if it has been updated

vocal spire Jun 7, 2021, 8:39 AM

#

we could add to the settings of the installer

#

a dictionary or something of mod names and versions

jolly oriole Jun 7, 2021, 8:40 AM

#

yea, just threw 56 a dm, that mi2 could add a feature that downloaded mods are actually sha checked on download, to try to counter mitm

vestal plover Jun 7, 2021, 8:41 AM

#

cedar hemlock its to check if the user has updated

I'm completely confused now, so the hash is not for download integrity at the moment? What is it used for then?

vocal spire Jun 7, 2021, 8:41 AM

#

the installer checks if the current file matches the hash. if not then download the mod again

cedar hemlock Jun 7, 2021, 8:42 AM

#

if a mod updates, the SHA1 changes, so the installer knows, this is not the right version

light zodiac Jun 7, 2021, 8:42 AM

#

Another solution: make everyone maintainers (joke)

cedar hemlock Jun 7, 2021, 8:43 AM

#

another solution: make more people maintainers

#

SFG can be one and redfrog too

vocal spire Jun 7, 2021, 8:43 AM

#

proposing a new modlinks system:
in the main modlinks file have an extra section for linking other modlinks files(people can update their own modlinks without pring the main file), every mod has a version of hk it targets, and different files per version, so we can easily add support for both 1.4.3.2, and 1.5. maybe even more versions

vocal spire Jun 7, 2021, 8:44 AM

#

cedar hemlock SFG can be one and redfrog too

ah yes trust me nothing bad ever comes of that

cedar hemlock Jun 7, 2021, 8:44 AM

#

ok only grenade then

vocal spire Jun 7, 2021, 8:46 AM

#

sfg, have you got an 1.5 version of sfcore atm?

jolly oriole Jun 7, 2021, 8:47 AM

#

i'm at work, can compile and update the repo after

vocal spire Jun 7, 2021, 8:47 AM

#

ok

#

I'll just compile one myself for now

#

approaching the 4am mark

jolly oriole Jun 7, 2021, 8:48 AM

#

though the only thing to change should be to uncomment the things in https://github.com/SFGrenade/SFCore/blob/master/Util/FsmUtil.cs

vestal plover Jun 7, 2021, 8:49 AM

#

vocal spire proposing a new modlinks system: in the main modlinks file have an extra section...

Indeed, for my specific use-case, the modinstaller needs to be able to get the latest version number from something other than a repository that I don't have direct access to. So if the modlinks file does not only contain a link to the latest DLL, but also to a file containing the latest version (possibly remotely hosted), then you could still do version checking.

cedar hemlock Jun 7, 2021, 8:50 AM

#

wdym with

other than a repository that I don't have direct access to

#

i assume you have direct access to your rep 👀

vestal plover Jun 7, 2021, 8:51 AM

#

cedar hemlock wdym with > other than a repository that I don't have direct access to

If the modinstaller can retrieve the latest version of a mod from the repository of that mod, instead of from the SHA in modlinks, then updating the mod wouldn't require a PR to modlinks

cedar hemlock Jun 7, 2021, 8:51 AM

#

oh like that

#

a possibility is that the modinstaller checks the name(/tag) of the latest version of a rep, and then checks it with the filename thats present in the mods folder

vestal plover Jun 7, 2021, 8:53 AM

#

jolly oriole yea, just threw 56 a dm, that mi2 could add a feature that downloaded mods are a...

Are MITM attacks really something we should be concerned about on the application level? Are the PRs on the modlinks repo even checked for malware? If not, than that is considerably easier than MITM from an attacker perspective.

cedar hemlock Jun 7, 2021, 8:54 AM

#

you'd need to ask 56

#

all the merges are done by 56

vocal spire Jun 7, 2021, 9:00 AM

#

jolly oriole though the only thing to change should be to uncomment the things in <https://gi...

modsettings need to be changed, been replaced

jolly oriole Jun 7, 2021, 9:00 AM

#

oh yea

#

completely forgot about that

vocal spire Jun 7, 2021, 9:17 AM

#

quickly fixed

#

also modhooks is static

rough pulsar Jun 7, 2021, 9:33 AM

#

cedar hemlock <@820685412208345148> we have .net 4.7.2 now, you can continue with your project

wait huh what what i'm back

#

is 1.5 out? as stable?

jolly oriole Jun 7, 2021, 9:33 AM

#

yes

rough pulsar Jun 7, 2021, 9:34 AM

#

cool

#

now i uh have to update it

#

i'll add some overhauls perhaps

jolly jungle Jun 7, 2021, 10:03 AM

#

So, uh
what do we need to change to get mods to work now?

#

Linking to a discussion also works for me

vocal spire Jun 7, 2021, 10:04 AM

#

what I already told you in other chat

fair rampart Jun 7, 2021, 10:04 AM

#

wait, do you mean in the sense of, writing a modding api, updating mods etc, or, do you mean in the sense of, you just updated and mods arent working anymore. because then #archived-modding-help look in the pins

vocal spire Jun 7, 2021, 10:05 AM

#

updating mods

fair rampart Jun 7, 2021, 10:06 AM

#

dont know if thats actually a thing that has to be done with the release of the new update, i was just taking a guess here tbh.

vocal spire Jun 7, 2021, 10:06 AM

#

remove modsettings inheritance since it no longer exists. if mods use settings, inherit LocalSettings<WhatUsedToBeYourSaveSettingsClass> on your mod class, and GlobalSettings<WhatUsedToBeYourGlobalSettingsClass>

tawny onyx Jun 7, 2021, 10:06 AM

#

#

vocal spire Jun 7, 2021, 10:07 AM

#

Update .new framework to 4.7.2

tawny onyx Jun 7, 2021, 10:07 AM

#

try buliding api fail

vocal spire Jun 7, 2021, 10:07 AM

#

are you in 1.5? also which github link did you get it from

tawny onyx Jun 7, 2021, 10:08 AM

#

fifty-six's fork

#

yes, i am trying to build 1.5 api

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding

GitHub

HollowKnight-Modding/HollowKnight.Modding

Hollow Knight Modding API. Contribute to HollowKnight-Modding/HollowKnight.Modding development by creating an account on GitHub.

vocal spire Jun 7, 2021, 10:10 AM

#

tawny onyx fifty-six's fork

use https://github.com/HollowKnight-Modding/HollowKnight.Modding

GitHub

HollowKnight-Modding/HollowKnight.Modding

Hollow Knight Modding API. Contribute to HollowKnight-Modding/HollowKnight.Modding development by creating an account on GitHub.

#

also I meant are you on the 1.5 version of the game

tawny onyx Jun 7, 2021, 10:11 AM

#

of course, i have already update

vocal spire Jun 7, 2021, 10:11 AM

#

ok

jolly jungle Jun 7, 2021, 10:11 AM

#

vocal spire 2. remove modsettings inheritance since it no longer exists. if mods use setting...

what's modsettings?

tawny onyx Jun 7, 2021, 10:12 AM

#

i am not coping all .dll files (just assembly and firstpass and UnityEngine.xxx and PlarMaker) maybe i should copy more

#

now i build successfuly, but not get the OutputFinal folder

primal latch Jun 7, 2021, 10:17 AM

#

You have to build in release mode

tawny onyx Jun 7, 2021, 10:18 AM

#

oh, that's my bad

#

thank you

primal latch Jun 7, 2021, 10:19 AM

#

Np

tawny onyx Jun 7, 2021, 10:19 AM

#

#

shroompog

primal latch Jun 7, 2021, 10:20 AM

#

Nice

tawny onyx Jun 7, 2021, 10:20 AM

#

time to update my mod

jolly jungle Jun 7, 2021, 10:21 AM

#

So what are you working on sawyer

floral blade Jun 7, 2021, 10:21 AM

#

Mapi itself hasn't changed much right ? elderC

primal latch Jun 7, 2021, 10:22 AM

#

It has

tawny onyx Jun 7, 2021, 10:23 AM

#

jolly jungle So what are you working on sawyer

try to make 1.5 api and update my Deco mod in current patch

jolly jungle Jun 7, 2021, 10:23 AM

#

So once you release 1.5 api we can start making mods for 1.5?

primal latch Jun 7, 2021, 10:23 AM

#

You already can. You just have to build the api yourself

#

It won’t fully release until 56 wakes up

tawny onyx Jun 7, 2021, 10:24 AM

#

yeah, you should wait 56 wake up

#

or build api yourself

floral blade Jun 7, 2021, 10:32 AM

#

primal latch It has

do we have any documentation ?

jolly oriole Jun 7, 2021, 10:32 AM

#

commits

nimble lake Jun 7, 2021, 10:43 AM

#

once mod support comes for 1.5, will 1.4.3.2 mods still work?

jolly oriole Jun 7, 2021, 10:45 AM

#

1432 mods only work with 1432, 1.5 is another .net framework version, unity version and not 32 bit anymore

nimble lake Jun 7, 2021, 10:46 AM

#

damn

#

good thing i kept the older one

jolly oriole Jun 7, 2021, 10:46 AM

#

you can also use the 1432 beta branch on steam

nimble lake Jun 7, 2021, 10:48 AM

#

yea but i had that one from before it went public

copper nacelle Jun 7, 2021, 11:25 AM

#

wtf I still have deprecated members to kill

jolly oriole Jun 7, 2021, 11:28 AM

#

do it quick

primal latch Jun 7, 2021, 11:28 AM

#

Good morning 56

jolly oriole Jun 7, 2021, 11:29 AM

#

i mean, idc, we can just tell people to use the 1432 'beta' branch currently

#

until your hired hitman is done

primal latch Jun 7, 2021, 11:30 AM

#

@copper nacelle I guess you didn’t expect to wake up to this

jolly jungle Jun 7, 2021, 11:34 AM

#

So for now, what I should do is wait for 1.5 api to come out, update .net framework version, and crusade through the code to turn everything from unity 2017 to unity 2020?

#

I've done only fairly simple mods

jolly oriole Jun 7, 2021, 11:36 AM

#

with fairly simple mods you might only need to wait for 1.5 mapi and update the references/.netframework version

tawny onyx Jun 7, 2021, 12:43 PM

#

is ModSetting removed?

primal latch Jun 7, 2021, 12:43 PM

#

yes

#

it was replaced with something else

jolly oriole Jun 7, 2021, 12:44 PM

#

the example mods have thing to show the new settings

tawny onyx Jun 7, 2021, 12:49 PM

#

#

am i get the wrong files?

jolly oriole Jun 7, 2021, 12:51 PM

#

apparently it isn't merged yet, let me find it

#

https://github.com/Yurihaia/HollowKnight.Modding/tree/master/Examples

tawny onyx Jun 7, 2021, 12:53 PM

#

thank

#

it look easier than before

light zodiac Jun 7, 2021, 1:07 PM

#

I'm getting a "cannot ressolve symbol" for IGlobalSettings<CustomGlobalSaveData>

tawny onyx Jun 7, 2021, 1:12 PM

#

you may use GlobalSettings instead

#

IGlobalSettings is SFG's fork

light zodiac Jun 7, 2021, 1:13 PM

#

thanks

#

it works

copper nacelle Jun 7, 2021, 1:15 PM

#

ah I need to merge that

#

should work against Yuri's branch

#

almost certainly going to merge as is

tawny onyx Jun 7, 2021, 1:20 PM

#

debug built lol.

light zodiac Jun 7, 2021, 1:20 PM

#

nice

tawny onyx Jun 7, 2021, 1:20 PM

#

UnityEngine.Input has been moved to UnityEngine.InputLegacyModule.dll

copper nacelle Jun 7, 2021, 1:20 PM

#

yeah

#

I have debug already built against a few commits ago

#

Works fine

#

Real downside is just reflection emit getting axed

light zodiac Jun 7, 2021, 1:22 PM

#

I'm not able to build yuri's fork it gives the error
Assembly-CSharp.csproj(40, 9): [MSB3073] The command " C:\Users\{username}\Desktop\Temporary\HollowKnight.Modding-master (1)\HollowKnight.Modding-master\PrePatcher/Output/PrePatcher.exe Assembly-CSharp.dll Assembly-CSharp-patched.dll" exited with code 9009.

tawny onyx Jun 7, 2021, 1:23 PM

#

a path with space

#

rename "HollowKnight.Modding-master (1)" to "HollowKnight.Modding-master_(1)" may fix

jolly oriole Jun 7, 2021, 1:27 PM

#

i can update my mods in like 1 1/2 hours

#

1432 support not needed

floral blade Jun 7, 2021, 1:27 PM

#

jolly oriole i can update my mods in like 1 1/2 hours

5.5 hours ?

copper nacelle Jun 7, 2021, 1:28 PM

#

how did you turn 1 into 5

jolly oriole Jun 7, 2021, 1:28 PM

#

floral blade 5.5 hours ?

there's a space

#

1 ½ hours

floral blade Jun 7, 2021, 1:28 PM

#

i blame the new update

primal latch Jun 7, 2021, 1:28 PM

#

yes. UPDATE SFCore!!!

light zodiac Jun 7, 2021, 1:33 PM

#

tawny onyx rename "HollowKnight.Modding-master (1)" to "HollowKnight.Modding-master_(1)" m...

that didn't fix it grubsad

floral blade Jun 7, 2021, 1:33 PM

#

i'd just got around to adding settings to CK grubsad . should i bother to release it for 1432 or just work on getting 1.5 support confuzz

light zodiac Jun 7, 2021, 1:33 PM

#

both

primal latch Jun 7, 2021, 1:33 PM

#

floral blade i'd just got around to adding settings to CK <:grubsad:316743976474509314>. shou...

1.5

light zodiac Jun 7, 2021, 1:33 PM

#

dont leave the 32 but people

primal latch Jun 7, 2021, 1:34 PM

#

f*ck 32 bits. All my homies use 64 bit

primal latch Jun 7, 2021, 1:34 PM

#

light zodiac dont leave the 32 but people

why? That is probably like 1 person

copper nacelle Jun 7, 2021, 1:35 PM

#

build the prepatcher first

floral blade Jun 7, 2021, 1:35 PM

#

light zodiac dont leave the 32 but people

i mean at the most i would test & release the last version. if 1.5 brings big change then i would not want to maintain 2 versions.

light zodiac Jun 7, 2021, 1:35 PM

#

copper nacelle build the prepatcher first

how can i do that?

primal latch Jun 7, 2021, 1:36 PM

#

right click build

ornate rivet Jun 7, 2021, 1:36 PM

#

@gilded lotus when can I use mods?

primal latch Jun 7, 2021, 1:37 PM

#

why did you ping him? Ask 56

light zodiac Jun 7, 2021, 1:38 PM

#

its a joke lol

light zodiac Jun 7, 2021, 1:38 PM

#

primal latch right click build

didn't know i could do that

#

thanks

jolly oriole Jun 7, 2021, 1:40 PM

#

visual studio? if so then it should automatically build before the mapi

#

or rebuild everything is needed in that case

#

but that also works

copper nacelle Jun 7, 2021, 1:40 PM

#

yeah it should

light zodiac Jun 7, 2021, 1:40 PM

#

it sometimes doesnt

copper nacelle Jun 7, 2021, 1:40 PM

#

vs or no vs

jolly oriole Jun 7, 2021, 1:40 PM

#

that is the question

light zodiac Jun 7, 2021, 1:40 PM

#

i use rider

copper nacelle Jun 7, 2021, 1:41 PM

#

I need CI so I can call people who fail to build it bad

#

so do I

jolly oriole Jun 7, 2021, 1:51 PM

#

56, remake the mapi in CIL

copper nacelle Jun 7, 2021, 1:52 PM

#

true

#

wait

#

not C++/CIL

#

Just cil

jolly oriole Jun 7, 2021, 1:53 PM

#

no difference

copper nacelle Jun 7, 2021, 1:54 PM

#

cil is il

#

common intermediate language

rough pulsar Jun 7, 2021, 1:54 PM

#

is there really any documentation for modcommon

copper nacelle Jun 7, 2021, 1:55 PM

#

no

rough pulsar Jun 7, 2021, 1:55 PM

#

dang

jolly oriole Jun 7, 2021, 1:55 PM

#

would having it pure CIL make it faster?

copper nacelle Jun 7, 2021, 1:55 PM

#

there's some shit on the apidocs page I don't think it's very much though

#

I mean you could write it better in IL I guess

#

Just like you could write something faster in assembly

#

Have fun with that though

rough pulsar Jun 7, 2021, 1:57 PM

#

i don't know if anyone would even bother writing a map in x86 assembly

#

definitely wouldn't zotewheeze

copper nacelle Jun 7, 2021, 1:57 PM

#

You'd probably just write injection in assembly at most

jolly oriole Jun 7, 2021, 1:57 PM

#

copper nacelle Have fun with that though

then c++/cil and let vs optimize it to hell and back 😤

copper nacelle Jun 7, 2021, 1:58 PM

#

I doubt c++/cil is any faster

light zodiac Jun 7, 2021, 1:58 PM

#

tawny onyx debug built lol.

how did you get the SerializableIntDictionary?

copper nacelle Jun 7, 2021, 1:58 PM

#

Any real amount that is

#

Dictionary<string, int>

light zodiac Jun 7, 2021, 1:58 PM

#

lol I'm dumb

copper nacelle Jun 7, 2021, 1:58 PM

#

Serializable dictionary should've died 8 versions ago cmm

rough pulsar Jun 7, 2021, 1:59 PM

#

i can't even see any real usage for serializable anything

#

it just looks like salt on a food for me

jolly oriole Jun 7, 2021, 2:01 PM

#

serializable so it can be saved

tawny onyx Jun 7, 2021, 2:01 PM

#

copper nacelle Jun 7, 2021, 2:01 PM

#

The use is for json utility in unity which we have since avoided

#

I assume the c# console in that doesn't work either yeah?

rough pulsar Jun 7, 2021, 2:02 PM

#

so it is salt on a food except worse

copper nacelle Jun 7, 2021, 2:02 PM

#

Used to be necessary

rough pulsar Jun 7, 2021, 2:02 PM

#

glad it isn't then

patent zealot Jun 7, 2021, 2:06 PM

#

is https://github.com/HollowKnight-Modding/HollowKnight.Modding the 1.5 api

light zodiac Jun 7, 2021, 2:07 PM

#

yes

copper nacelle Jun 7, 2021, 2:08 PM

#

no

#

use yuri's

patent zealot Jun 7, 2021, 2:08 PM

#

where is it

#

this one https://github.com/Yurihaia/HollowKnight.Modding/tree/master/Examples ?

#

wait no

copper nacelle Jun 7, 2021, 2:08 PM

#

yes

#

though not that folder

floral blade Jun 7, 2021, 2:33 PM

#

will FSMViewAvalonia <= work on the new version without any updates ?

rough pulsar Jun 7, 2021, 2:33 PM

#

1.5?

#

i definitely think it would

copper nacelle Jun 7, 2021, 2:33 PM

#

yeah

jolly oriole Jun 7, 2021, 2:42 PM

#

It doesn't have a scene list anymore sadly

tawny onyx Jun 7, 2021, 2:58 PM

#

can we add reflection back this way?

copper nacelle Jun 7, 2021, 2:59 PM

#

Oh what

#

Busted as fuck?

jolly oriole Jun 7, 2021, 2:59 PM

#

PauseChamp

copper nacelle Jun 7, 2021, 3:00 PM

#

That's gonna be such a pain to distribute x5fiftAleph

jolly oriole Jun 7, 2021, 3:02 PM

#

i don't have a system reflection emit dll

rough pulsar Jun 7, 2021, 3:04 PM

#

do i have to compile the modding api myself or is there a ready 1.5 version

copper nacelle Jun 7, 2021, 3:07 PM

#

I think we can do this ourselves with a little unsafe

jolly oriole Jun 7, 2021, 3:11 PM

#

oh nice, project setting upon opening is release now

light zodiac Jun 7, 2021, 3:12 PM

#

new debug for 1.5
https://github.com/TheMulhima/Debug_Mod/releases/tag/v1.3.7

rough pulsar Jun 7, 2021, 3:12 PM

#

isn't there a modding api for 1.5 that has been already compiled

jolly oriole Jun 7, 2021, 3:13 PM

#

just now

📎 OutputFinal.zip

light zodiac Jun 7, 2021, 3:13 PM

#

this is yuri's branch?

jolly oriole Jun 7, 2021, 3:13 PM

#

though doesn't contain any of 56's edits he still wants to make

jolly oriole Jun 7, 2021, 3:13 PM

#

light zodiac this is yuri's branch?

got merged

rough pulsar Jun 7, 2021, 3:14 PM

#

cool

light zodiac Jun 7, 2021, 3:14 PM

#

jolly oriole got merged

neat

copper nacelle Jun 7, 2021, 3:14 PM

#

Man really wiped the entire git history

#

omegaMaggotPrime

rough pulsar Jun 7, 2021, 3:14 PM

#

scared

light zodiac Jun 7, 2021, 3:14 PM

#

i made a new one

#

i was lazy

rough pulsar Jun 7, 2021, 3:14 PM

#

i am too lazy to compile modding api or dsgm trabkjfamtbjrab something

#

can't wait for my system to load visual studio for like 5 minutes

copper nacelle Jun 7, 2021, 3:15 PM

#

imma be real i'd rather just finish doing it myself than wipe the history

rough pulsar Jun 7, 2021, 3:15 PM

#

i doubt you can even roll back in github

jolly oriole Jun 7, 2021, 3:16 PM

#

who needs debugmod for testing smh

light zodiac Jun 7, 2021, 3:16 PM

#

copper nacelle imma be real i'd rather just finish doing it myself than wipe the history

Finish doing what?

rough pulsar Jun 7, 2021, 3:16 PM

#

~~why use debugmod when you can write the code to do what you wanted to do in debug~~

copper nacelle Jun 7, 2021, 3:16 PM

#

I already have one half updated before the recent pr

light zodiac Jun 7, 2021, 3:18 PM

#

If you send that version I'll add those changes into the version I sent

jolly oriole Jun 7, 2021, 3:18 PM

#

luckily i don't have to port that many mods

rough pulsar Jun 7, 2021, 3:19 PM

#

that's something i will never ever bother to do

#

with that many mods

copper nacelle Jun 7, 2021, 3:19 PM

#

blur censoring

#

Poor choices

#

Bro if you added changes the history would still be gone

#

That's the whole point

rough pulsar Jun 7, 2021, 3:20 PM

#

~~why even use blurring when you can just erase the things yourself using paint brush~~

jolly oriole Jun 7, 2021, 3:20 PM

#

i honestly don't think you could get any information from the blur, the pixelated one fair, but not the blurred one

light zodiac Jun 7, 2021, 3:20 PM

#

I'll make a pr

copper nacelle Jun 7, 2021, 3:20 PM

#

I mean the pixelated part

#

Blur is whatever I don't think there's anything of value

#

There's already stuff to undo pixelation though

jolly oriole Jun 7, 2021, 3:21 PM

#

yea, the pixelated one says PaleCourtStuff

rough pulsar Jun 7, 2021, 3:21 PM

#

there have been algorithms that would attempt to decrypt the pixellating blurs

copper nacelle Jun 7, 2021, 3:21 PM

#

Wtf you ruined the fun

#

I wanted to try the undoer

#

Unlucky

jolly oriole Jun 7, 2021, 3:22 PM

#

sadge, now you have to spend your time updating your mods and the mapi

copper nacelle Jun 7, 2021, 3:22 PM

#

that's a strange way of spelling sitting in bed until I decay

rough pulsar Jun 7, 2021, 3:22 PM

#

hey, looks like it's my own responsibility to port my mod

#

maybe i'll wait for the official release of modding api 1.5 instead elderC

light zodiac Jun 7, 2021, 3:23 PM

#

Why doesn't GitHub allow me to make 2 forks for the same repo

copper nacelle Jun 7, 2021, 3:23 PM

#

it doesn't want you to

#

Easy

#

Probably the naming collision

rough pulsar Jun 7, 2021, 3:24 PM

#

unlike windows, github won't let you copy a repository twice feelspkman

patent zealot Jun 7, 2021, 3:26 PM

#

what framework do we need btw

jolly oriole Jun 7, 2021, 3:26 PM

#

4.7.2

rough pulsar Jun 7, 2021, 3:26 PM

#

yeah

jolly oriole Jun 7, 2021, 3:28 PM

#

did the beta patch have both a mscorlib and a netstandard dll before?

copper nacelle Jun 7, 2021, 3:30 PM

#

where

#

oh

#

yeah

#

they all do

#

I haven't even updated yet rofl

jolly oriole Jun 7, 2021, 3:30 PM

#

first time i've realized that there are those two

rough pulsar Jun 7, 2021, 3:30 PM

#

i have updated

jolly oriole Jun 7, 2021, 3:30 PM

#

thought before that only one of them is there

prime urchin Jun 7, 2021, 3:34 PM

#

absolute life-saving changes tbh

fickle sparrow Jun 7, 2021, 3:34 PM

#

true

rough pulsar Jun 7, 2021, 3:34 PM

#

1.5 modding api?

fickle sparrow Jun 7, 2021, 3:34 PM

#

to be fair nobody was using the LocalSettings interface anyways

rough pulsar Jun 7, 2021, 3:35 PM

#

localsettings would be used for like

#

save specific settings

fickle sparrow Jun 7, 2021, 3:35 PM

#

yeah

#

uh

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/tree/master/Examples

rough pulsar Jun 7, 2021, 3:35 PM

#

and yeah there really aren't that many mods that use save specific settings

fickle sparrow Jun 7, 2021, 3:35 PM

#

well see

#

this is super new

#

we got rid of the old save system because it was bad

jolly oriole Jun 7, 2021, 3:35 PM

#

save specific settings is the new form of savesettings, and there were some mods that used it

fickle sparrow Jun 7, 2021, 3:36 PM

#

yeah they'll have to update

primal latch Jun 7, 2021, 3:36 PM

#

what is the new unity version?

jolly oriole Jun 7, 2021, 3:37 PM

#

2020.2.2

rough pulsar Jun 7, 2021, 3:37 PM

#

does hk use 2020.2.2 now?

fickle sparrow Jun 7, 2021, 3:37 PM

#

yeah and .net 472

rough pulsar Jun 7, 2021, 3:37 PM

#

hollowknice

primal latch Jun 7, 2021, 3:39 PM

#

ok. Thanks

#

surprisingly 2017 asset bundles still work. I just want to update them to use the latest compression and stuff

jolly oriole Jun 7, 2021, 3:45 PM

#

ok, updated the .net version and references for my entire project folder

#

nice

rough pulsar Jun 7, 2021, 3:52 PM

#

excellent

#

did you compile that yourself from the uhhh

#

did you compile that yourself

jolly oriole Jun 7, 2021, 3:53 PM

#

jolly oriole just now

it's exactly this

rough pulsar Jun 7, 2021, 3:53 PM

#

cool

jolly oriole Jun 7, 2021, 3:53 PM

#

and yes

#

~~and i also hid some viruses in it~~

#

~~bitcoin miner~~

tawny onyx Jun 7, 2021, 4:07 PM

#

jolly oriole i don't have a system reflection emit dll

i found similar one in "\Editor\Data\MonoBleedingEdge\lib\mono\4.7.1-api\Facades"

jolly oriole Jun 7, 2021, 4:08 PM

#

hm

#

for now i'll update sfcore

#

yo 56, before i do it wrong, how would you do field caching? for settings ofc

tawny onyx Jun 7, 2021, 4:12 PM

#

#

finally i success(copying from 4.5 is ok)

copper nacelle Jun 7, 2021, 4:13 PM

#

wdym field caching

#

I'd use the helper

#

Actual delegates are faster than anything you're doing yourself unless you also want to emit

jolly oriole Jun 7, 2021, 4:14 PM

#

thinking about making 'reflection' for the get/set pd thingies cached in one way or another for a bit more performance thanks to betaend

copper nacelle Jun 7, 2021, 4:15 PM

#

GetBool?

jolly oriole Jun 7, 2021, 4:15 PM

#

let me quickly find one cursed example of mine

#

Reference: inside a GetBool hook
but reflection is slow, so i'm thinking of maybe having all fields of the save settings type cached in a dictionary or something

ornate rivet Jun 7, 2021, 4:17 PM

#

Just to make sure, we use Unity 2020.2.2 now?

rough pulsar Jun 7, 2021, 4:18 PM

#

yeah

jolly oriole Jun 7, 2021, 4:18 PM

#

yes

rough pulsar Jun 7, 2021, 4:18 PM

#

and net 4.7.2

copper nacelle Jun 7, 2021, 4:18 PM

#

ReflectionHelper.GetField

#

easy

#

GetValue is still slow though

jolly oriole Jun 7, 2021, 4:21 PM

#

yea, but getvalue won't be called as often as getfield

#

thanks solely to betaend

fair rampart Jun 7, 2021, 4:23 PM

#

For the using Modding import I have to wait a ModdingApi update?

vocal spire Jun 7, 2021, 4:24 PM

#

It’s already updated, you just need to build it yourself. To make any mod for 1.5 you need it

patent zealot Jun 7, 2021, 4:24 PM

#

#archived-modding-development message

copper nacelle Jun 7, 2021, 4:24 PM

#

dw i'll make more breaking changes

fair rampart Jun 7, 2021, 4:25 PM

#

ok thanks

dawn halo Jun 7, 2021, 4:25 PM

#

sorry for tagging @jolly oriole my friend sent me thsese. i'm not sure if these can be of use
https://unitylist.com/p/ru/Unity3D.Thai-Font-Adjuster
https://github.com/phanphantz/Unity3D.ThaiTextUI

ornate rivet Jun 7, 2021, 4:26 PM

#

has modcommon been rebuilt?

copper nacelle Jun 7, 2021, 4:26 PM

#

no

vocal spire Jun 7, 2021, 4:26 PM

#

I rebuilt it

ornate rivet Jun 7, 2021, 4:26 PM

#

send pls

copper nacelle Jun 7, 2021, 4:26 PM

#

i can't believe you've done this

#

stop using it coward

ornate rivet Jun 7, 2021, 4:26 PM

#

all of my mods use it 56 zote

jolly oriole Jun 7, 2021, 4:26 PM

#

dawn halo sorry for tagging <@!202560032712163329> my friend sent me thsese. i'm not sure...

with 1.5 now out i may be able to actually use what i tried before in game, which was my last problem

jolly oriole Jun 7, 2021, 4:27 PM

#

ornate rivet all of my mods use it 56 <:zote:562358113374568477>

use frogcore/serecore/sfcore/vasi instead

ornate rivet Jun 7, 2021, 4:27 PM

#

modcommon is the objectively best mod

copper nacelle Jun 7, 2021, 4:27 PM

#

use nothing instead

#

checkmate

ornate rivet Jun 7, 2021, 4:27 PM

#

none of you have debug colliders

vocal spire Jun 7, 2021, 4:27 PM

#

Got frogcore to stop using it

vocal spire Jun 7, 2021, 4:27 PM

#

ornate rivet none of you have debug colliders

Oh yeah

copper nacelle Jun 7, 2021, 4:27 PM

#

bro why would you leave a dependency in for debug

#

it's for debugging

vocal spire Jun 7, 2021, 4:27 PM

#

Because why not

copper nacelle Jun 7, 2021, 4:27 PM

#

bloat

ornate rivet Jun 7, 2021, 4:27 PM

#

also printscenehierarchytree

copper nacelle Jun 7, 2021, 4:27 PM

#

dependencies

#

terrible

#

friendship ended with saleh

jolly oriole Jun 7, 2021, 4:28 PM

#

copper nacelle terrible

didn't you make vasi

ornate rivet Jun 7, 2021, 4:28 PM

#

why do all of you have core mods

vocal spire Jun 7, 2021, 4:28 PM

#

…yeah why?

copper nacelle Jun 7, 2021, 4:28 PM

#

because i wanted GetRefField

#

checkmate

jolly oriole Jun 7, 2021, 4:28 PM

#

... for... other mods?

#

as... a dependency?

ornate rivet Jun 7, 2021, 4:28 PM

#

redfrog send me the modcommon build

vocal spire Jun 7, 2021, 4:29 PM

#

Turning on my computer, I just woke up

ornate rivet Jun 7, 2021, 4:29 PM

#

oh ok nvm take your time

vocal spire Jun 7, 2021, 4:29 PM

#

Was up until 5am working on updating fyremoth

#

Dms or here?

ornate rivet Jun 7, 2021, 4:30 PM

#

here

vocal spire Jun 7, 2021, 4:30 PM

#

Also removed global settings since I couldn’t be bothered to update it

ornate rivet Jun 7, 2021, 4:30 PM

#

let all see the glory of modcommon

vocal spire Jun 7, 2021, 4:30 PM

#

📎 ModCommon.dll

fair rampart Jun 7, 2021, 4:30 PM

#

thanks

vocal spire Jun 7, 2021, 4:31 PM

#

updated frogcore because no one asked

📎 FrogCore.dll

#

except i think I didn't finish some stuff

jolly oriole Jun 7, 2021, 4:32 PM

#

sha256 is now needed, right?

copper nacelle Jun 7, 2021, 4:33 PM

#

i haven't swapped shit

#

that is what the new repo is for

#

tm

jolly oriole Jun 7, 2021, 4:33 PM

#

but you want to have sha256, right?

copper nacelle Jun 7, 2021, 4:33 PM

#

maybe

#

md5 is also a thing

jolly oriole Jun 7, 2021, 4:34 PM

#

anything from these please

ornate rivet Jun 7, 2021, 4:34 PM

#

oh do yall have sfcore and vasi too?

vocal spire Jun 7, 2021, 4:34 PM

#

vocal spire proposing a new modlinks system: in the main modlinks file have an extra section...

can somebody scream why this is wrong

jolly oriole Jun 7, 2021, 4:34 PM

#

ornate rivet oh do yall have sfcore and vasi too?

gimme a minute

vocal spire Jun 7, 2021, 4:34 PM

#

I have a sfcore if you don't

copper nacelle Jun 7, 2021, 4:35 PM

#

why would i want people to be able to edit modlinks at will without pring

vocal spire Jun 7, 2021, 4:35 PM

#

faster?

copper nacelle Jun 7, 2021, 4:35 PM

#

my security smh

vocal spire Jun 7, 2021, 4:35 PM

#

oh didn't think about that

#

should we still do a version system though?

copper nacelle Jun 7, 2021, 4:37 PM

#

idk imagine doing it same-day when i could think about it

floral blade Jun 7, 2021, 4:38 PM

#

I mean mods that want to self update can do so anyway right ?

#

Nothings stopping a mod from downloading a dependency that's actually the real mod. And the one in modlinks is actually just the loader for that mod

copper nacelle Jun 7, 2021, 4:40 PM

#

hash

#

reject invalid hash no download easy

floral blade Jun 7, 2021, 4:40 PM

#

Yeah the loader doesn't update

#

The dependency is the real payload

#

elderC

jolly oriole Jun 7, 2021, 4:41 PM

#

✅ check dandy's modlinks-PRs from now on

#

https://github.com/SFGrenade/SFCore/releases/tag/v1.5 sfcore

vocal spire Jun 7, 2021, 4:41 PM

#

nice

#

I should probably update frogcore

#

first imma see what chaos I can bring upon the installer when trying to add support for different game versions

floral blade Jun 7, 2021, 4:48 PM

#

jolly oriole ✅ check dandy's modlinks-PRs from now on

I heard you like mod installers so I put a modinstaller in your mod installer zotewheeze

fair rampart Jun 7, 2021, 4:48 PM

#

I still have some errors like this

vocal spire Jun 7, 2021, 4:49 PM

#

what is the error?

#

does the method not exist? if so, then you are missing a reference to whatever file you got it from

fair rampart Jun 7, 2021, 4:50 PM

#

after copyng files from OutputFinal.zip in the game folder

#

"Managed" folder

#

before the update it was ok

jolly oriole Jun 7, 2021, 4:52 PM

#

now this is a screenshot

ornate rivet Jun 7, 2021, 4:56 PM

#

what happened to ModSettings

light zodiac Jun 7, 2021, 4:56 PM

#

It got changed

ornate rivet Jun 7, 2021, 4:56 PM

#

ok to what

light zodiac Jun 7, 2021, 4:56 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/tree/master/Examples

ornate rivet Jun 7, 2021, 4:57 PM

#

thanks

copper nacelle Jun 7, 2021, 4:58 PM

#

can't believe saleh isn't paying any attention

ornate rivet Jun 7, 2021, 4:58 PM

#

I haven't read anything in this channel in like a year

vocal spire Jun 7, 2021, 4:58 PM

#

so how do I edit the mod installer's ui? all I see is the weird thing where the Manually button is at the top left corner

merry lotus Jun 7, 2021, 4:59 PM

#

vocal spire so how do I edit the mod installer's ui? all I see is the weird thing where the ...

From when I asked a few weeks ago, I was informed that you had to do it exclusively from the code now

vocal spire Jun 7, 2021, 5:00 PM

#

ah ok

#

that's fun

merry lotus Jun 7, 2021, 5:00 PM

#

Something about the visual part was broke in some update tamershrug

vocal spire Jun 7, 2021, 5:00 PM

#

what happened to that poor thing

merry lotus Jun 7, 2021, 5:01 PM

#

I will, as I always do, request that anyone who is willing to attempt to update Mod Installer, please add an "open mods folder" button

vocal spire Jun 7, 2021, 5:01 PM

#

I'm dealing with mod installer 1, doesn't it already have that

merry lotus Jun 7, 2021, 5:02 PM

#

Just like, a little square button, with a folder icon. Doesn't even need text. It would be perfect.

copper nacelle Jun 7, 2021, 5:03 PM

#

@floral blade you are ruining my life

merry lotus Jun 7, 2021, 5:03 PM

#

vocal spire I'm dealing with mod installer 1, doesn't it already have that

Unless an update for it was pushed that I never saw, and I'm using an out of date one, then no. Neither 1 or 2 has it yet.

floral blade Jun 7, 2021, 5:05 PM

#

copper nacelle <@!731231925599076432> you are ruining my life

What why

dark wigeon Jun 7, 2021, 5:05 PM

#

oof is 1.5 out now

copper nacelle Jun 7, 2021, 5:05 PM

#

my indentation

vocal spire Jun 7, 2021, 5:06 PM

#

merry lotus Just like, a little square button, with a folder icon. Doesn't even need text. I...

I'll add one

floral blade Jun 7, 2021, 5:06 PM

#

I explicitly did not push any indentation changes elderC prolly should have

copper nacelle Jun 7, 2021, 5:07 PM

#

i like the button but i want it at the bottom

#

do you know how you do dockpanel w/ virtualizingstackpanel?

#

tfw

#

floral blade Jun 7, 2021, 5:09 PM

#

copper nacelle do you know how you do dockpanel w/ virtualizingstackpanel?

Not really, I just copied the existing button and edited text and boom it worked

copper nacelle Jun 7, 2021, 5:13 PM

#

echprime

fair rampart Jun 7, 2021, 5:14 PM

#

_control is PlayMakerFSM but the methond isn t working from the update

copper nacelle Jun 7, 2021, 5:14 PM

#

wtf why are you reloading settings

vocal spire Jun 7, 2021, 5:16 PM

#

fair rampart _control is PlayMakerFSM but the methond isn t working from the update

as I told you before you are missing a reference to a mod dependency

#

probably Modcommon, Vasi, or SFCore

#

you need to get a updated version of one of those then reference them

light zodiac Jun 7, 2021, 5:17 PM

#

56 pls add readmes to mi2

copper nacelle Jun 7, 2021, 5:17 PM

#

no

floral blade Jun 7, 2021, 5:18 PM

#

copper nacelle wtf why are you reloading settings

Needed an instance of settings, not sure if it was accessible already and I made a dumdum

fair rampart Jun 7, 2021, 5:18 PM

#

vocal spire probably Modcommon, Vasi, or SFCore

not PlayMaker.dll?

copper nacelle Jun 7, 2021, 5:19 PM

#

no those are extensions

vocal spire Jun 7, 2021, 5:19 PM

#

whatever mod you referenced before

floral blade Jun 7, 2021, 5:19 PM

#

Wait could I just pass it into new ModListViewModel ?

#

And have an instance right there

#

zemershock

fair rampart Jun 7, 2021, 5:21 PM

#

#

previously I have these imports

copper nacelle Jun 7, 2021, 5:22 PM

#

bro you can't just make it null! and not force it to be non-null

#

that defeats the whole point of nullable reference types

floral blade Jun 7, 2021, 5:25 PM

#

If it's null then we won't be able to load any mods tho right ?

copper nacelle Jun 7, 2021, 5:27 PM

#

It can't be null unless you did it wrong

#

That's the whole point

#

unless the field type is nullable

#

or you forced it to be null

floral blade Jun 7, 2021, 5:28 PM

#

Incase we load an old JSON it might not have the key so we'd get a null, right ?

copper nacelle Jun 7, 2021, 5:28 PM

#

That is the problem yes

#

I fixed it already

jolly oriole Jun 7, 2021, 5:29 PM

#

dark wigeon oof is 1.5 out now

yes

floral blade Jun 7, 2021, 5:29 PM

#

I'd checked if it was null after loading tho and assigned the correct value

copper nacelle Jun 7, 2021, 5:29 PM

#

that's the point

#

you shouldn't be checking that

#

period

#

for null

#

because the field isn't nullable

#

if it was ever null you have already gone wrong

floral blade Jun 7, 2021, 5:30 PM

#

So you'd just give it a default value when deserialising ?

copper nacelle Jun 7, 2021, 5:30 PM

#

Yeah

#

https://github.com/fifty-six/Modinstaller2/commit/508cd7ab5a4444df333570499d77961d1c3fee5b

GitHub

Merge; Fix indentation, nullable usages, settings. · fifty-six/Modi...

Default to a valid modlinks uri when deserializing using private
constructor, use URI.IsFile instead of parsing ourselves, fix
indentation from modifications.

#

Can see what I did if you'd like

floral blade Jun 7, 2021, 5:31 PM

#

I will ! Thanks!

vocal spire Jun 7, 2021, 5:34 PM

#

fair rampart

see how you require modcommon

jolly oriole Jun 7, 2021, 5:35 PM

#

oh no
modcommon

vocal spire Jun 7, 2021, 5:36 PM

#

#

it does not work

floral blade Jun 7, 2021, 5:37 PM

#

copper nacelle Can see what I did if you'd like

Gotcha ! So I was setting it to null when I didn't really want a null and then checking if it was null and setting it to the right value.

copper nacelle Jun 7, 2021, 5:37 PM

#

yes

floral blade Jun 7, 2021, 5:37 PM

#

Lol now that I follow the logic it is pretty stoopid

#

Sorry you had to deal with that mess !

copper nacelle Jun 7, 2021, 5:41 PM

#

it's fine

primal latch Jun 7, 2021, 5:45 PM

#

My therapist: "how would you describe today?"
Me: "Team Cherry pulled a sneaky on us and now everyone is scrambling to update their mod to 1.5"

jolly oriole Jun 7, 2021, 5:46 PM

#

nah, more time to polish it lol

floral blade Jun 7, 2021, 5:53 PM

#

primal latch My therapist: "how would you describe today?" Me: "Team Cherry pulled a sneaky o...

I think what made it better was many of us woke up to 1.5

patent zealot Jun 7, 2021, 6:10 PM

#

amazing

fair rampart Jun 7, 2021, 6:15 PM

#

vocal spire see how you require modcommon

I see the problem is that the type Func<> should be defined in mscorlib but it is not found

patent zealot Jun 7, 2021, 6:17 PM

#

odd

#

i was messing with save shit and i removed the mod

#

and now its still happening

floral blade Jun 7, 2021, 6:17 PM

#

patent zealot and now its still happening

A bug in hollow knight ?

patent zealot Jun 7, 2021, 6:17 PM

#

i doubt it

#

either api, sf core or debug idk

#

cus they're the only 3 things on

jolly oriole Jun 7, 2021, 6:18 PM

#

didn't debug do somethin with pauses

#

let me test

#

with only mapi and sfcore

patent zealot Jun 7, 2021, 6:19 PM

#

i was using this #archived-modding-development message

floral blade Jun 7, 2021, 6:19 PM

#

patent zealot i doubt it

It's a game about bugs hunt, there's gotta be some bugs !

patent zealot Jun 7, 2021, 6:19 PM

#

hmm

#

does the grub next to me count

jolly oriole Jun 7, 2021, 6:19 PM

#

it's debug, mapi and sfcore alone can save+quit

patent zealot Jun 7, 2021, 6:20 PM

#

whacky

floral blade Jun 7, 2021, 6:20 PM

#

patent zealot does the grub next to me count

Only when alive elderC

patent zealot Jun 7, 2021, 6:21 PM

#

floral blade Only when alive <:elderC:598291441013358605>

so no smirking

jolly oriole Jun 7, 2021, 6:21 PM

#

wait a second

#

wtf

#

TC renamed something that the hollow_knight_Data is now the Hollow Knight_Data folder

patent zealot Jun 7, 2021, 6:22 PM

#

oh yeah i realised that

#

i saw my path change

#

put the modding api in the wrong folder lol

floral blade Jun 7, 2021, 6:24 PM

#

jolly oriole TC renamed something that the `hollow_knight_Data` is now the `Hollow Knight_Dat...

Wow only remove the first underscore the second one is necessary

jolly oriole Jun 7, 2021, 6:25 PM

#

the _Data part is generated by unity

#

it's now that instead of the game being called hollow_knight, it's now called Hollow Knight

rough pulsar Jun 7, 2021, 6:25 PM

#

what?

fickle sparrow Jun 7, 2021, 6:25 PM

#

it isn't for me

vocal spire Jun 7, 2021, 6:25 PM

#

Kool

rough pulsar Jun 7, 2021, 6:25 PM

#

wait what

fickle sparrow Jun 7, 2021, 6:25 PM

#

ech

vocal spire Jun 7, 2021, 6:25 PM

#

It isn’t for me

floral blade Jun 7, 2021, 6:25 PM

#

Ah that makes it make so much more sense

rough pulsar Jun 7, 2021, 6:26 PM

#

its same for me

vocal spire Jun 7, 2021, 6:26 PM

#

Same

jolly oriole Jun 7, 2021, 6:26 PM

#

rough pulsar Jun 7, 2021, 6:26 PM

#

huh

vocal spire Jun 7, 2021, 6:26 PM

#

Gog specific?

jolly oriole Jun 7, 2021, 6:26 PM

#

steam wasn't renamed

#

just checked

floral blade Jun 7, 2021, 6:27 PM

#

Mysterious ways of TC

vocal spire Jun 7, 2021, 6:27 PM

#

Well that makes things slightly more complicated for the installer

rough pulsar Jun 7, 2021, 6:27 PM

#

i can't even be bothered to buy a hollow knight gog galaxy copy to check feelspkman

#

also yeah it is strange

jolly oriole Jun 7, 2021, 6:27 PM

#

vocal spire Well that makes things slightly more complicated for the installer

select folder
ez
so exactly like how it's done currently

rough pulsar Jun 7, 2021, 6:28 PM

#

fun

floral blade Jun 7, 2021, 6:28 PM

#

Mod zips must no longer contain hollow_knight_Data I guess

rough pulsar Jun 7, 2021, 6:28 PM

#

i mean

jolly oriole Jun 7, 2021, 6:28 PM

#

56 wanted to remove that anyway because it sucked

floral blade Jun 7, 2021, 6:28 PM

#

Or the installer would need to figure it out

vocal spire Jun 7, 2021, 6:28 PM

#

I’d want to remove it

rough pulsar Jun 7, 2021, 6:28 PM

#

my mod zips are just the DLL itself and a readme

jolly oriole Jun 7, 2021, 6:29 PM

#

rough pulsar my mod zips are just the DLL itself and a readme

that's how it's supposed to be for all mods

floral blade Jun 7, 2021, 6:29 PM

#

jolly oriole that's how it's supposed to be for all mods

Customknight want give default pngs

#

No want rip at runtime

jolly oriole Jun 7, 2021, 6:30 PM

#

just have the folder with the skin folders at top level???

#

MI1/2 just extracts the zip if the top level folder isn't hollow_knight_Data

floral blade Jun 7, 2021, 6:30 PM

#

Yeah thats what would make the most sense

#

Extract whatever you want in mods/

jolly oriole Jun 7, 2021, 6:32 PM

#

i already hate the new Sprite() that isn't anymore

vocal spire Jun 7, 2021, 6:32 PM

#

yeah :(

patent zealot Jun 7, 2021, 6:33 PM

#

is this how saving should be done

vocal spire Jun 7, 2021, 6:33 PM

#

I just created a static empty sprite I can use instead

rough pulsar Jun 7, 2021, 6:33 PM

#

what is the ci branch of modding api for

vocal spire Jun 7, 2021, 6:33 PM

#

yes

patent zealot Jun 7, 2021, 6:33 PM

#

cus so far it wasnt only debug that wasnt leting me save quit

fair rampart Jun 7, 2021, 6:35 PM

#

I solved, I forgot to update modCommon with modInstaller

copper nacelle Jun 7, 2021, 6:36 PM

#

for ci

jolly oriole Jun 7, 2021, 6:36 PM

#

custom charms + save&quit do be working

patent zealot Jun 7, 2021, 6:37 PM

#

disabled all mods and no savequit tf

rough pulsar Jun 7, 2021, 6:37 PM

#

wait wdym no savequit

#

is there no save&quit option

patent zealot Jun 7, 2021, 6:37 PM

#

patent zealot amazing

this

rough pulsar Jun 7, 2021, 6:38 PM

#

lmao it just keeps noping you out

#

feels bad

fickle sparrow Jun 7, 2021, 6:38 PM

#

patent zealot is this how saving should be done

yeah this is how saving mod data is done now

rough pulsar Jun 7, 2021, 6:38 PM

#

maybe it's modding api's fault

#

maybe

patent zealot Jun 7, 2021, 6:39 PM

#

i think it might be so im gonna verify files to get rid of it

copper nacelle Jun 7, 2021, 6:39 PM

#

among us

rough pulsar Jun 7, 2021, 6:39 PM

#

that's

#

sus

jolly oriole Jun 7, 2021, 6:39 PM

#

wrong channel 56, this isn't the channel for the apple thing going on right now

#

keynote or whatever

fickle sparrow Jun 7, 2021, 6:40 PM

#

everything sucks

vocal spire Jun 7, 2021, 6:41 PM

#

got the open mods folder button working

copper nacelle Jun 7, 2021, 6:41 PM

#

vocal spire Jun 7, 2021, 6:42 PM

#

lol

rough pulsar Jun 7, 2021, 6:42 PM

#

when the postbuild deletes your system32 folder

#

sus

copper nacelle Jun 7, 2021, 6:42 PM

#

we can do that

rough pulsar Jun 7, 2021, 6:42 PM

#

no

#

no

#

don't

vocal spire Jun 7, 2021, 6:42 PM

#

yes

#

yes

#

do it

rough pulsar Jun 7, 2021, 6:42 PM

#

🥺

floral blade Jun 7, 2021, 6:42 PM

#

Do it!

rough pulsar Jun 7, 2021, 6:42 PM

#

scared

floral blade Jun 7, 2021, 6:42 PM

#

Us Mac users will survive

jolly oriole Jun 7, 2021, 6:43 PM

#

56, ples us modin xperence to mak amogus mod

vocal spire Jun 7, 2021, 6:43 PM

#

imma continue adding stuff for multiple patch support now

floral blade Jun 7, 2021, 6:44 PM

#

jolly oriole 56, ples us modin xperence to mak amogus mod

One of the multi player is nosk?

rough pulsar Jun 7, 2021, 6:44 PM

#

teach us the ways of modcommon so we make among us real life implementation into hollow knight,

patent zealot Jun 7, 2021, 6:48 PM

#

#

among us flushed_cool

primal latch Jun 7, 2021, 6:49 PM

#

oh god

patent zealot Jun 7, 2021, 6:50 PM

#

ok i think the modding api might be causing it or smth

#

i uninstalled it and it savequits fine

jolly oriole Jun 7, 2021, 6:51 PM

#

oh yea, i wanted to test it

rough pulsar Jun 7, 2021, 6:52 PM

#

i'll test it too

#

i'm compiling it from the latest commit atm

jolly oriole Jun 7, 2021, 6:52 PM

#

dw, hunt has my mapi, and that works on steam version

#

mapi works on my 1.5 gog copy as well