#archived-modding-development | Hollow Knight | Page 515

jovial gazelle Apr 29, 2021, 7:24 PM

#

Uh no, I prefer text tutorials. I don't mind going off of HellMod, I just figured there might be a dedicated example mod instead that I was missing.

pseudo pond Apr 29, 2021, 7:26 PM

#

jovial gazelle Uh no, I prefer text tutorials. I don't mind going off of HellMod, I just figure...

got it. The video is like 15 mins and nice for seeing the barebones of how the class should be formed and how to find things using dnspy etc. but if you prefer the text guide that's good too.

jovial gazelle Apr 29, 2021, 7:26 PM

#

pseudo pond got it. The video is like 15 mins and nice for seeing the barebones of how the c...

Yea I'll probably check it out later but for now I'm probably just going to explore the code a little and see what's happening

pseudo pond Apr 29, 2021, 7:27 PM

#

alrighty

jovial gazelle Apr 29, 2021, 8:15 PM

#

Alright, first extremely short mod written, hope it works lol

#

Annndd errors

cedar hemlock Apr 29, 2021, 8:18 PM

#

What are you doing?

jovial gazelle Apr 29, 2021, 8:19 PM

#

I just chose a hook that looked interesting, in this case SoulGain, and doubled the amount, but Hollow Knight crashed before getting to the main menu

#

Might be unrelated

cedar hemlock Apr 29, 2021, 8:20 PM

#

Try without your mod

jovial gazelle Apr 29, 2021, 8:20 PM

#

I will in a sec, things are loading

#

Ay didn't crash this time, with the mod still on

#

Oh wait it failed to load

vocal spire Apr 29, 2021, 8:23 PM

#

jovial gazelle Oh wait it failed to load

What did you set your target framework to? Also did you have a controller plugged in when it crashed

jovial gazelle Apr 29, 2021, 8:23 PM

#

vocal spire What did you set your target framework to? Also did you have a controller plugge...

I need to check that. I don't own a controller. It said to look for ModLogs.txt but idk where that is

vocal spire Apr 29, 2021, 8:24 PM

#

*ModLog.txt

#

?saves

finite forumBOT Apr 29, 2021, 8:24 PM

#

Saves

Windows File Paths: (Assumes Default Steam Install Path, Adjust accordingly for DRM Free or Non-Standard Steam Path)

Game Files: C:\Program Files (x86)\Steam\steamapps\common\Hollow Knight\```
** **
Mac File Paths:
```Save Files: ~/Library/Application Support/unity.Team Cherry.Hollow Knight/
Game Files: ~/Library/Application Support/Steam/steamapps/common/Hollow Knight/hollow_knight.app/```
** **
Linux File Paths:
```Save Files: ~/.config/unity3d/Team Cherry/Hollow Knight/
Game Files: ~/.local/share/Steam/steamapps/common/Hollow Knight/```

vocal spire Apr 29, 2021, 8:24 PM

#

It’s in your save files path

jovial gazelle Apr 29, 2021, 8:24 PM

#

Ok

vocal spire Apr 29, 2021, 8:24 PM

#

70% of the time I’ve found the problem without modlog though

jovial gazelle Apr 29, 2021, 8:24 PM

#

k

jolly oriole Apr 29, 2021, 8:25 PM

#

imagine not needing output_log for your problems 🥴

jovial gazelle Apr 29, 2021, 8:25 PM

#

Target framework is .NET core 3.1, is that good?

jolly oriole Apr 29, 2021, 8:25 PM

#

it should be .net framework 3.5

jovial gazelle Apr 29, 2021, 8:25 PM

#

Ok

jolly oriole Apr 29, 2021, 8:25 PM

#

unless you want to make a mod for the 1.5 beta, in which case it should be 4.7.2 i think

jovial gazelle Apr 29, 2021, 8:26 PM

#

I need to install that then, cause it's not listed lol

jolly oriole Apr 29, 2021, 8:26 PM

#

are you using rider or visual studio?

jovial gazelle Apr 29, 2021, 8:27 PM

#

visual studio

jolly oriole Apr 29, 2021, 8:27 PM

#

well, shouldn't matter, i think both have a completely seperate project template for .net framework DLLs instead of .net core ones

jovial gazelle Apr 29, 2021, 8:27 PM

#

huh

jolly oriole Apr 29, 2021, 8:28 PM

#

if this piece of garbage would stop lagging, i could make a screenshot

jovial gazelle Apr 29, 2021, 8:28 PM

#

On the microsoft download page theres only 3.5 SP1, is that fine? It also is only available for runtime, not developer apparently

jolly oriole Apr 29, 2021, 8:30 PM

#

screenshot is in german though

jovial gazelle Apr 29, 2021, 8:30 PM

#

ohhh

#

So I need to make a new project ig?

jolly oriole Apr 29, 2021, 8:31 PM

#

you could also edit the .csproj file, but creating a new project is probably easier

jovial gazelle Apr 29, 2021, 8:31 PM

#

Yeah, especially given I have like 10 lines of code lol

#

The frameworks only go down to 4 in the drop down

vocal spire Apr 29, 2021, 8:33 PM

#

Then you made the wrong project

#

Or you need to install 3.5 framework

jovial gazelle Apr 29, 2021, 8:33 PM

#

vocal spire Or you need to install 3.5 framework

Probably that since Class Library .Net framework is what I'm supposed to be using, right?

vocal spire Apr 29, 2021, 8:34 PM

#

Yeah

jovial gazelle Apr 29, 2021, 8:34 PM

#

Do you know where I can install 3.5?

vocal spire Apr 29, 2021, 8:34 PM

#

Can’t link atm

jovial gazelle Apr 29, 2021, 8:34 PM

#

What should I google then?

vocal spire Apr 29, 2021, 8:35 PM

#

You can just do it from add/remove windows features iirc

jovial gazelle Apr 29, 2021, 8:35 PM

#

k

young walrus Apr 29, 2021, 8:35 PM

#

or download from microsoft.com

jolly oriole Apr 29, 2021, 8:35 PM

#

should be sufficient (in the visual studio installer)

jovial gazelle Apr 29, 2021, 8:36 PM

#

k

vocal spire Apr 29, 2021, 8:36 PM

#

jolly oriole should be sufficient (in the visual studio installer)

Can I @ u

jolly oriole Apr 29, 2021, 8:36 PM

#

no

vocal spire Apr 29, 2021, 8:36 PM

#

jolly oriole no

Oh ok

#

~~Wouldn’t it be a shame if I accidentally edited a reply message~~

jolly oriole Apr 29, 2021, 8:37 PM

#

vocal spire ~~Wouldn’t it be a shame if I accidentally edited a reply message~~

discord doesn't make @ out of those anymore
but i still have a way to do so

vocal spire Apr 29, 2021, 8:37 PM

#

Well

#

Gg

jovial gazelle Apr 29, 2021, 8:38 PM

#

Well I must say just from reading the docs hooks look very nice to use.

vocal spire Apr 29, 2021, 8:38 PM

#

Imma go annoy someone now bye

jovial gazelle Apr 29, 2021, 8:38 PM

#

Have fun

jovial gazelle Apr 29, 2021, 9:01 PM

#

jolly oriole should be sufficient (in the visual studio installer)

Still doesn't pop up in the list =/

jolly oriole Apr 29, 2021, 9:03 PM

#

hm

jovial gazelle Apr 29, 2021, 9:03 PM

#

I googled and it said to check the turn windows features on and off, which I'm trying now

pseudo pond Apr 29, 2021, 9:07 PM

#

vocal spire Imma go annoy someone now bye

Wait you're annoying yourself? I'm confused

pseudo pond Apr 29, 2021, 9:08 PM

#

jovial gazelle I googled and it said to check the turn windows features on and off, which I'm t...

I might be able to help you, can you hop in general and screen share?

jovial gazelle Apr 29, 2021, 9:09 PM

#

I want to finish trying this first but after that sure

#

Maybe idk

pseudo pond Apr 29, 2021, 9:12 PM

#

jovial gazelle I want to finish trying this first but after that sure

what does pop up in the list?

jovial gazelle Apr 29, 2021, 9:12 PM

#

pseudo pond what does pop up in the list?

Everything after framework 4

#

And then "enable .net framework 3.5" is the first item on the windows features list so I figured I'd give that a shot

pseudo pond Apr 29, 2021, 9:13 PM

#

hmm

jovial gazelle Apr 29, 2021, 9:14 PM

#

I'm waiting for that to download right now

pseudo pond Apr 29, 2021, 9:14 PM

#

i figured it was probably what SFGrenade was saying but if you already checked that idk what it is

jovial gazelle Apr 29, 2021, 9:15 PM

#

I think it was because in the visual studio installer there was targetting packs for all the 4+ frameworks, but the thing for 3.5 was dev tools, not a targetting pack

pseudo pond Apr 29, 2021, 9:15 PM

#

That could be it

jovial path Apr 29, 2021, 9:30 PM

#

how would I go about making my own mod?

pseudo pond Apr 29, 2021, 9:30 PM

#

?pins

finite forumBOT Apr 29, 2021, 9:30 PM

#

Check the pinned messages for more information - https://cdn.discordapp.com/attachments/187137504393035776/823796522751623168/unknown.png

jovial path Apr 29, 2021, 9:30 PM

#

Thanks

pseudo pond Apr 29, 2021, 9:31 PM

#

specifically the radiancehost link

#

https://radiance.host/apidocs

vocal spire Apr 29, 2021, 9:36 PM

#

pseudo pond Wait you're annoying yourself? I'm confused

You have a problem with that?

jovial gazelle Apr 29, 2021, 10:05 PM

#

Well I restarted my computer after changing that thing in windows features, and I think I'm just gonna give framework 4 a shot, does that have anychance of working?

#

Wait nevermind it finally showed up!

#

Finally lol

pseudo pond Apr 29, 2021, 10:13 PM

#

nice

vocal spire Apr 29, 2021, 10:13 PM

#

jovial gazelle Well I restarted my computer after changing that thing in windows features, and ...

Yes but you’ll get a nasty failed to load every time you use it

jovial gazelle Apr 29, 2021, 10:14 PM

#

vocal spire Yes but you’ll get a nasty failed to load every time you use it

Well I got visual studio to be able to use 3.5 now so i think it's all good

vocal spire Apr 29, 2021, 10:14 PM

#

Nice

jovial gazelle Apr 29, 2021, 10:34 PM

#

And it works! hooray

jovial gazelle Apr 29, 2021, 10:51 PM

#

Why does directly setting the fields in PlayerData cause potential conflict as opposed to using something like SetInt or a varient?

deep wave Apr 29, 2021, 11:06 PM

#

if stuff is hooked to setint then it wont be called when you change playerdata directly

jovial gazelle Apr 29, 2021, 11:09 PM

#

k

runic wind Apr 30, 2021, 3:01 AM

#

using the OnEnemyEnabled hook, duplicate enemies have numbers after their names. Is there a property that shows the base name, or a way to convert the enemy object to a string so I can see all the properties?

#

if not I can just use a substring, but that's gross

steady comet Apr 30, 2021, 3:45 AM

#

I don’t think so for your question Staxis, but maybe you could think of a property that that enemy has? E.g. if your enemy is the only one in the game with a FSM with a particular name, you could check if the enemy has that FSM?

That said just looking for the start of the enemy name (or maybe just strip off numbers and (clone)) is probably the most sensible

runic wind Apr 30, 2021, 3:51 AM

#

alright, thanks

#

also, what's the best way to wait a bit in a hook function?

#

yield return new WaitWhatever doesn't work

steady comet Apr 30, 2021, 3:55 AM

#

Uhh

#

I think you can only do that in a coroutine

#

You can see an example here I guess https://github.com/flibber-hk/HollowKnight.RandomizerMod/blob/main/RandomizerMod3.0/SceneChanges/RandomizerChanges.cs#L269

runic wind Apr 30, 2021, 4:02 AM

#

I just need to delay a little for fps to stabilize

#

maybe there's a more useful hook, I'll look later

runic wind Apr 30, 2021, 6:25 AM

#

can a value in an fsm be replaced with a function?

#

ChaseObject in the vengefly (Buzzer) fsm has speedMax and acceleration, both of which I want to multiply by (200 / Time.DeltaTime)

steady comet Apr 30, 2021, 6:37 AM

#

Is Tme,DeltaTime constant?

jolly oriole Apr 30, 2021, 6:38 AM

#

steady comet Is Tme,DeltaTime constant?

no, is time between each frame, and since that isn't consistent, time.deltatime isn't consistent

#

or constant

steady comet Apr 30, 2021, 6:38 AM

#

Otherwise you can just set those fields at the start of the state

jolly oriole Apr 30, 2021, 6:39 AM

#

runic wind ChaseObject in the vengefly (Buzzer) fsm has speedMax and acceleration, both of ...

i haven't looked at it:
the only thing probably fps dependent is the acceleration, with the speed probably being applied to a rigidbody, which moves fps independent

runic wind Apr 30, 2021, 6:46 AM

#

Oh weird

#

I still need to know how to change acceleration each frame though

steady comet Apr 30, 2021, 6:52 AM

#

You could add a hook to the ChaseObject.OnFixedUpdate to set its acceleration whenever it's called - I don't know what that'd do for performance though

runic wind Apr 30, 2021, 6:52 AM

#

Hmm

#

You can add functions into fsms, so maybe I could create a new fsm variable, update it with the custom function and set the acceleration to that?

steady comet Apr 30, 2021, 6:54 AM

#

Yeah, something like that was my original suggestion

runic wind Apr 30, 2021, 6:55 AM

#

I’d expect it to be faster than adding hooks but idrk

#

I don’t think execution time should be a problem here anyway

#

And even if it is, the mod will compensate for it monomonteehee

steady comet Apr 30, 2021, 7:01 AM

#

If you don't do it every update then it won't work if they change FPS, that's the only issue

runic wind Apr 30, 2021, 7:01 AM

#

Yeah it def needs to be every frame or every few frames

#

Even a second after loading in my FPS isn’t stable

#

I mean tbh my FPS is never totally stable

steady comet Apr 30, 2021, 7:02 AM

#

(That's why I suggested OnFixedUpdate)

runic wind Apr 30, 2021, 7:02 AM

#

What is OnFixedUpdate?

steady comet Apr 30, 2021, 7:02 AM

#

I think it's the code in the ChaseObject action that runs every frame?

#

Actually probably you have to look into the ChaseObject action a bit more (in DNSPY)

jolly oriole Apr 30, 2021, 7:04 AM

#

idk if it has it, but FixedUpdate runs every physics tick, exactly 50 times a second in the case of hk

runic wind Apr 30, 2021, 7:06 AM

#

Ah ok

jolly oriole Apr 30, 2021, 7:42 AM

#

just read that ms is apparently changing parts of their store, so modding the ms store version of hk should be easier at some point in time

fair rampart Apr 30, 2021, 9:12 AM

#

can someone look at modding help pls

runic wind Apr 30, 2021, 9:14 AM

#

fair rampart can someone look at modding help pls

modding help exists for a reason

#

how do I make a hook to ChaseObject.OnFixedUpdate()? The docs don't seem to say anything about using other hooks

#

in dnSpy I see what I think is the hook being added and then removed? I'm not totally sure how it's all set up

steady comet Apr 30, 2021, 9:17 AM

#

In general write the full path of the thing, but add On to the start

#

So it'd be On.HutongGames.PlayMaker.Actions.ChaseObject.OnFixedUpdate

runic wind Apr 30, 2021, 9:20 AM

#

do you mean like ModHooks.Instance.On.HutongGames.PlayMaker.Actions.ChaseObject.OnFixedUpdate?

steady comet Apr 30, 2021, 9:20 AM

#

No

runic wind Apr 30, 2021, 9:20 AM

#

oh remove the modhooks.instance

steady comet Apr 30, 2021, 9:21 AM

#

AFAIK ModHooks.Instance.... hooks were placed manually by 56/whoever, and On.... hooks were placed automatically by the monomod

runic wind Apr 30, 2021, 9:21 AM

#

ok wtf is this signature

#

private void FixedUpdate(On.HutongGames.PlayMaker.Actions.ChaseObject.orig_OnFixedUpdate orig, ChaseObject self)

#

what on earth is that input type

steady comet Apr 30, 2021, 9:22 AM

#

Something created by monomod tamershrug

#

(You also have to remember to put orig(self) somewhere so the original function runs)

runic wind Apr 30, 2021, 9:23 AM

#

I'm not sure I fully understand how hooks work

#

the idea is that instead of the normal function running, my function will be run instead, right?

steady comet Apr 30, 2021, 9:23 AM

#

Uhh

#

Well it depends on the hook

runic wind Apr 30, 2021, 9:23 AM

#

ok

steady comet Apr 30, 2021, 9:24 AM

#

runic wind the idea is that instead of the normal function running, my function will be run...

I think this is accurate in this case but I'm not sure

#

I just mimic examples from other people's code lurkersweat

runic wind Apr 30, 2021, 9:34 AM

#

ok well now I'm way more confused

#

it seems like the acceleration is being done in the onFixedUpdate

#

so idek why it's fps dependant

#

do you happen to know the internal name of soul sanctum?

steady comet Apr 30, 2021, 9:38 AM

#

As in room names?

#

They're all Ruins1_XX

cedar hemlock Apr 30, 2021, 9:39 AM

#

get debug mod and go to that room

runic wind Apr 30, 2021, 9:39 AM

#

yeah didn't have hk open

steady comet Apr 30, 2021, 9:41 AM

#

@runic wind #archived-modding-development message

runic wind Apr 30, 2021, 9:44 AM

#

alright I'll try to figure out the fps dependency tomorrow

#

thanks for all your help Flib mathulLove

steady comet Apr 30, 2021, 9:46 AM

#

Good luck with that 😛

fair rampart Apr 30, 2021, 10:05 AM

#

does anyone know where the attack sprites for boss attacks like pure vessel are

#

is there a way to obtain that

#

like this one

#

but transparent

#

(pls ping me i'll be offline)

cedar hemlock Apr 30, 2021, 10:08 AM

#

#

@fair rampart

fair rampart Apr 30, 2021, 10:11 AM

#

ayyy thanks

#

the image quality isn't super high though

cedar hemlock Apr 30, 2021, 10:12 AM

#

its whats used in the game

#

download it and maybe the quality is higher??

fair rampart Apr 30, 2021, 10:12 AM

#

i need a better quality of this?

#

lemme download the pp mod.

jolly oriole Apr 30, 2021, 10:12 AM

#

i think there are also seperate sprites just for that focus effect

cedar hemlock Apr 30, 2021, 10:13 AM

#

i'll look

fair rampart Apr 30, 2021, 10:13 AM

#

wait hold on when i downloaded from discord it is high enough

#

thanks

fair rampart Apr 30, 2021, 10:13 AM

#

jolly oriole i think there are also seperate sprites just for that focus effect

but i'd need this too

#

this one

jolly oriole Apr 30, 2021, 10:14 AM

#

cedar hemlock i'll look

if you search with file names, i think those were called something with "out of bounds"

#

i'm at work, so i can't look for them

cedar hemlock Apr 30, 2021, 10:14 AM

#

not stuff like "atlas0_xxx"?

jolly oriole Apr 30, 2021, 10:14 AM

#

no, that animation is also split in like 13 different singular image files

fair rampart Apr 30, 2021, 10:18 AM

#

man, i'm just trying to make abyssshrek and we have 13 images

#

shermaU

jolly oriole Apr 30, 2021, 10:19 AM

#

grimm is also amazing, made of 2 spritesheets and the godseeker bow is also a row of like 13 images

cedar hemlock Apr 30, 2021, 10:24 AM

#

i can only find 7

jolly jungle Apr 30, 2021, 10:25 AM

#

fair rampart i need a better quality of this?

Where is this from?

#

Oh I see

#

Click the spritesheet, do "open original", and then download

cedar hemlock Apr 30, 2021, 10:25 AM

#

📎 out_of_bounds_impact000x.zip

jolly jungle Apr 30, 2021, 10:25 AM

#

Or get it from #art-discussion

jolly jungle Apr 30, 2021, 10:26 AM

#

cedar hemlock

what's this? popseeker

cedar hemlock Apr 30, 2021, 10:26 AM

#

fair rampart this one

^

jolly oriole Apr 30, 2021, 10:26 AM

#

possible actually 7, just thought of a random number to say

jolly jungle Apr 30, 2021, 10:27 AM

#

Oh huh

#

Where is it listed in the ripped sprites folder?

cedar hemlock Apr 30, 2021, 10:27 AM

#

oh wait lemme ping @fair rampart

jolly jungle Apr 30, 2021, 10:27 AM

#

Next to PV, or?

fair rampart Apr 30, 2021, 10:30 AM

#

thanks

fair rampart Apr 30, 2021, 10:30 AM

#

jolly jungle what's this? <:popseeker:663988996648730634>

pv's focus attack big orb

#

but anyway i resolved the issue

#

thanks for the sprites ruttie

#

new soulorb

jolly jungle Apr 30, 2021, 10:31 AM

#

Nice hollowknice

#

What's the rest of the skin gonna be?

cedar hemlock Apr 30, 2021, 10:32 AM

#

pv skin

arctic dragon Apr 30, 2021, 10:32 AM

#

how bad of an idea would it be to make a custom knight

arctic dragon Apr 30, 2021, 10:32 AM

#

arctic dragon how bad of an idea would it be to make a custom knight

as someone with absolutely 0 knowledge on how to do it btw

fair rampart Apr 30, 2021, 10:33 AM

#

jolly jungle What's the rest of the skin gonna be?

pv skin with original young thk cloak and unsquished horns

#

gonna make the sprite smaller

#

everyone uses knight's cloak shape (even the private skin) which is sad

#

but understandable

#

it looks like i have to draw in some things myself

jolly jungle Apr 30, 2021, 10:39 AM

#

fair rampart pv skin with original young thk cloak and unsquished horns

Ohoho

#

It's a shame we can't really do the actual PV horn size

jolly jungle Apr 30, 2021, 10:39 AM

#

fair rampart gonna make the sprite smaller

Isn't there gonna be a hitbox problem with that?

#

Or seomthing

#

Not sure

cedar hemlock Apr 30, 2021, 10:39 AM

#

no make the body smaller

#

so theres more room for horns

jolly jungle Apr 30, 2021, 10:40 AM

#

What I meant was that the Knight has hitbox only up to top of head

#

this'll have hitbox on the horns too a bit

cedar hemlock Apr 30, 2021, 10:41 AM

#

eh doesnt rly matter

#

people will get used to it

arctic dragon Apr 30, 2021, 10:55 AM

#

wait, the horns aren’t counted in the hitbox? neat!

fair rampart Apr 30, 2021, 11:02 AM

#

jolly jungle Isn't there gonna be a hitbox problem with that?

nah, it doesn't affect

#

the hitbox is just part of the body by default and it'll be a bit of the head when i make it smaller

#

wait no

#

sorry memory bad

#

anyway, i had to edit it a bit but it's some good work i have here

#

not very neat because contrast increase but yeah

#

i'm probably gonna put this over the smaller orbs

vocal spire Apr 30, 2021, 11:39 AM

#

jolly jungle It's a shame we *can't* really do the actual PV horn size

Be patient and wait for me to finish other mods so I can finish the CustomKnight+ editor so you can do this

jolly jungle Apr 30, 2021, 11:45 AM

#

vocal spire Be patient and wait for me to finish other mods so I can finish the CustomKnight...

Wait I thought you said customknight+ wont be able to do anything about that

#

that's... marvelous

jolly jungle Apr 30, 2021, 12:05 PM

#

Well
#modding-discussion
But also do you have the base files?

cedar hemlock Apr 30, 2021, 12:05 PM

#

grimmpalm

#

this is #archived-modding-development

jolly jungle Apr 30, 2021, 12:05 PM

#

My bad

#

I knew something seemed off in that name but couldn't figure out what

#

Thanks

vocal spire Apr 30, 2021, 12:31 PM

#

jolly jungle Wait I thought you said customknight+ wont be able to do anything about that

...tell me what you know about CustomKnight+
Really not looking forward to explaining this again

jolly jungle Apr 30, 2021, 1:26 PM

#

Nah

#

just gonna wait for you to release it in a year and a half and then I'll see what it does

pseudo pond Apr 30, 2021, 1:55 PM

#

So for some odd reason using the SetPlayerIntHook broke the game

#

private void OnSetPlayerIntHook(string intName, int value)
        {
            //Ensures the player can only have a maximum of 3 slots even when aquiring a charm notch
           PlayerData.instance.SetIntInternal(nameof(PlayerData.charmSlots), 3);
        }*/

#

This segment gave me unlimited soul, dunno how that works

copper nacelle Apr 30, 2021, 1:57 PM

#

bro

jolly oriole Apr 30, 2021, 1:57 PM

#

Bro

jovial gazelle Apr 30, 2021, 1:57 PM

#

Bro

copper nacelle Apr 30, 2021, 1:57 PM

#

you are ignoring every int set

pseudo pond Apr 30, 2021, 1:57 PM

#

wdym

#

oh do i have to make it actually change the things it's trying to set

copper nacelle Apr 30, 2021, 1:58 PM

#

you're supposed to like check the intName and call SetIntInternal/set it directly with a different value when it would set something that you want to change

#

and if it's not what you want to change you just call SetIntInternal with the stuff you get

#

this delegate really should be like trygetvalue imo

#

but i also don't want to break every mod in existence

pseudo pond Apr 30, 2021, 1:59 PM

#

tbh i thought that it'd set the player int like normal while also running the line of code i added

#

i guess i just misunderstood the way the hook worked

jolly oriole Apr 30, 2021, 2:10 PM

#

https://radiance.host/apidocs/Hooks.html#getplayerbool the example can be applied to your effect as well, just need to swap bool to int and get to set

pseudo pond Apr 30, 2021, 2:13 PM

#

jolly oriole <https://radiance.host/apidocs/Hooks.html#getplayerbool> the example can be appl...

does getting a charm notch change a bool in PlayerData

jolly oriole Apr 30, 2021, 2:14 PM

#

then let it be PlayerGetIntHook, if the target string is the same as charmSlots, return 3, otherwise getintinternal

pseudo pond Apr 30, 2021, 2:33 PM

#

👍

pseudo pond Apr 30, 2021, 4:54 PM

#

thank you 🙂

#

sorry for asking so many questions, you guys are very helpful

jovial gazelle Apr 30, 2021, 4:58 PM

#

Random unrelated tip thingy, you can edit your build settings in visual studio to copy your built .dll to your mods folder by going from Project > Properties > Build Events, and then in the Post-Build textbox you can put copy [Your built .dll path here] [Your mods folder here] so then you don't have to move your updated build file every time you change something. I thought this might be useful for some people, maybe not idk.

pseudo pond Apr 30, 2021, 4:58 PM

#

that is a nice tip, thanks

#

ill just have to remember to change it if i ever do anything non-hollowknight related

#

or is it just per project

jovial gazelle Apr 30, 2021, 4:59 PM

#

Per project

pseudo pond Apr 30, 2021, 4:59 PM

#

ah okay

#

definitely nice then

jovial gazelle Apr 30, 2021, 4:59 PM

#

Unless visual studio does something really weird lol

jolly oriole Apr 30, 2021, 5:34 PM

#

pseudo pond thank you 🙂

to your deleted messages: yes

light zodiac Apr 30, 2021, 5:46 PM

#

i tried using the Reflection to call private functions but its causing a System.NullReferenceException error when i use the mod.
My code is:```cs
private bool CanDash()
{
BindingFlags private_instance_flags = BindingFlags.NonPublic | BindingFlags.Instance;
MethodInfo m;
HeroController instance = new HeroController();

        m = typeof(HeroController).GetMethod("CanDash", private_instance_flags);
        bool CanIDash = (bool) m.Invoke(instance, new object[] { });
        return CanIDash;
    }```

#

I'm trying to call this function from HeroController

steady comet Apr 30, 2021, 5:48 PM

#

Uhh

#

This doesn't answer your question, but why can't you just use the reflectionhelper?

copper nacelle Apr 30, 2021, 5:48 PM

#

new HeroController

#

jolly oriole Apr 30, 2021, 5:48 PM

#

additionally, instead of new object[] { } i personally do either null or new object[0]

copper nacelle Apr 30, 2021, 5:49 PM

#

do null

light zodiac Apr 30, 2021, 5:49 PM

#

copper nacelle new HeroController

i just copied it from the API docs

light zodiac Apr 30, 2021, 5:51 PM

#

jolly oriole additionally, instead of `new object[] { }` i personally do either `null` or `ne...

bool CanIDash = (bool) m.Invoke(instance, null);?

jolly oriole Apr 30, 2021, 5:51 PM

#

light zodiac `bool CanIDash = (bool) m.Invoke(instance, null);`?

yes

light zodiac Apr 30, 2021, 5:51 PM

#

steady comet This doesn't answer your question, but why can't you just use the reflectionhelp...

does that allow calling functions?

jolly oriole Apr 30, 2021, 5:51 PM

#

light zodiac i just copied it from the API docs

HeroController.instance

copper nacelle Apr 30, 2021, 5:51 PM

#

should be caching the method info

#

you can get a fast reflection delegate using the monomod extension too

light zodiac Apr 30, 2021, 5:54 PM

#

jolly oriole `HeroController.instance`

copper nacelle Apr 30, 2021, 5:55 PM

#

bro

#

it's a property not a type

jolly oriole Apr 30, 2021, 5:56 PM

#

private bool CanDash()
{
    return (bool) typeof(HeroController).GetMethod("CanDash", BindingFlags.NonPublic | BindingFlags.Instance).Invoke(HeroController.instance, null);
}

how i'd do it

light zodiac Apr 30, 2021, 6:00 PM

#

it works thanks

copper nacelle Apr 30, 2021, 6:04 PM

#

wtf

#

no cache

#

using invoke

#

x5fiftPrime

jolly oriole Apr 30, 2021, 6:05 PM

#

if it works, don't change it

pseudo pond Apr 30, 2021, 6:37 PM

#

jolly oriole to your deleted messages: yes

I deleted it because i felt bad for @ing you for something i couldve just tested lol, thanks for your help

pseudo pond Apr 30, 2021, 7:08 PM

#

where can i find my hollow knight save files if they're not in my appdata folder

light zodiac Apr 30, 2021, 7:08 PM

#

Press win + r and then paste this

%AppData%\..\LocalLow\Team Cherry\Hollow Knight

pseudo pond Apr 30, 2021, 7:08 PM

#

i tried

#

only brings me here:

cedar hemlock Apr 30, 2021, 7:08 PM

#

go back one folder

#

then locallow

#

team cherry

pseudo pond Apr 30, 2021, 7:09 PM

#

ok cool

cedar hemlock Apr 30, 2021, 7:09 PM

#

and hollow knight

pseudo pond Apr 30, 2021, 7:09 PM

#

i found it 🤦‍♂️ '

#

im bafflingly incompetent sometimes

vocal spire Apr 30, 2021, 7:11 PM

#

deleted messages

pseudo pond Apr 30, 2021, 7:11 PM

#

huh?

safe hamlet Apr 30, 2021, 7:56 PM

#

when there is literally a lib for fast reflection and no one uses it

copper nacelle Apr 30, 2021, 7:57 PM

#

true

jolly oriole Apr 30, 2021, 8:20 PM

#

is the vasi reflection helper different from the one directly in the mapi?

copper nacelle Apr 30, 2021, 8:21 PM

#

a bit

#

there's some stuff i changed because i don't have the restrictions on not breaking old things

jolly oriole Apr 30, 2021, 8:26 PM

#

break old things in the 1.5 mapi :v

copper nacelle Apr 30, 2021, 8:35 PM

#

true

runic wind Apr 30, 2021, 8:39 PM

#

I need some help understanding how fsms work

#

I'm looking at the vengefly fsm, and two relevant states have the action "ChaseObject"

#

the important part of ChaseObject is doBuzz(), which is being called through OnFixedUpdate() as well as OnEnter()

#

What is the fsm really doing with ChaseObject? I don't understand how it can be a class instead of a method

#

And is OnFixedUpdate() even being used? ChaseObject is being called once per graphics frame as far as I can tell

#

oh, and I'm assuming OnEnter() is called automatically- when does that happen?

steady comet Apr 30, 2021, 8:56 PM

#

runic wind What is the fsm really doing with ChaseObject? I don't understand how it can be ...

All actions in an FSM state are classes that inherit from FsmStateAction. When the action "executes", it really calls "OnEnter" and does the thing there. If it has an OnFixedUpdate or OnUpdate method, then those happen when they happen.

#

You're right that OnFixedUpdate should be called every physics frame, except if the FSM leaves the state that the ChaseObject action is in then it won't be called any more... that might be why it's not behaving as you'd expect

runic wind Apr 30, 2021, 9:03 PM

#

Wow, at this point instead of the intended quick fix it looks like I should just fix tcs broken code

steady comet Apr 30, 2021, 9:10 PM

#

runic wind Wow, at this point instead of the intended quick fix it looks like I should just...

Uhh, wasn't that the whole point of this project?

#

:tcarrivewithspaghetti:

silent marsh Apr 30, 2021, 9:11 PM

#

Hi,
I just want to share a small theory that I have: I think the dream nail is an hallucination we collectively had, there has never been a dream nail in Hollow Knight:
I didn't find any hook related to it (unlike dash for example), I didn't find anything related to dreamnail usage in HeroController.instance.cState (unlike C-dash for example), I didn't tind any FSM related to it in HeroController.instance (unlike spells for example), and I didn't find anything related to it by listening to every single {Get/Set}Player{Int/Bool} (unlike bench state for example)

Only reasonable conclusion is that dream nail doesn't exist

copper nacelle Apr 30, 2021, 9:11 PM

#

there's an fsm

#

it's just not referenced in code

silent marsh Apr 30, 2021, 9:11 PM

#

Where ? 😮

copper nacelle Apr 30, 2021, 9:11 PM

#

You can use the FSM Viewer to look at it

silent marsh Apr 30, 2021, 9:12 PM

#

Hmmm I'll try that thanks, I thought I could find everything by looking at the code

copper nacelle Apr 30, 2021, 9:12 PM

#

I wish

silent marsh Apr 30, 2021, 9:12 PM

#

Code for dream nail must be in the dream dimension, it all makes sense

runic wind Apr 30, 2021, 9:18 PM

#

steady comet Uhh, wasn't that the whole point of this project?

My original plan was to just slap *= 200 / fps onto the relevant numbers, honestly just creating more broken code

silent marsh Apr 30, 2021, 9:22 PM

#

copper nacelle You can use the FSM Viewer to look at it

(Obviously) you were right, I think I found it, thanks a lot. Now I just need to figure how to interact with it in my code, but it seems that radiance.host has some tips regarding that
Edit: I figured it out, thank you again for your help 56 🙂

runic wind Apr 30, 2021, 9:48 PM

#

can you create and remove entire states in FSMs? It's not required for what I want, I just think it would be cleaner

copper nacelle Apr 30, 2021, 9:52 PM

#

Yeah

runic wind Apr 30, 2021, 9:53 PM

#

how? the docs only mention adding/removing actions within states and changing the current state

copper nacelle Apr 30, 2021, 9:55 PM

#

You just remove it from the array and update transitions to not point to it

runic wind Apr 30, 2021, 9:56 PM

#

ok, but how do I make a new one

copper nacelle Apr 30, 2021, 9:57 PM

#

new FsmState()?

runic wind Apr 30, 2021, 9:57 PM

#

ok, thanks

steady comet Apr 30, 2021, 10:04 PM

#

copper nacelle You just remove it from the array and update transitions to not point to it

Do you need to even bother removing it from the array? I mean if there're no transitions pointing to it then it doesn't matter if it's there right?

#

Unless you want to remove the init state palehmm

copper nacelle Apr 30, 2021, 10:07 PM

#

I mean you don't have to

#

I don't know why you wouldn't though

#

Leaving garbage lying around x5fiftPrime

steady comet Apr 30, 2021, 10:09 PM

#

IDK I learned to code by reading TC code

fair rampart Apr 30, 2021, 11:06 PM

#

mrmmm, remade howling wraiths i have
remake abyssshrek i must

runic wind Apr 30, 2021, 11:09 PM

#

copper nacelle new FsmState()?

what's the parameter? Debugger doesn't like FsmState chase = new FsmState(fsm);

#

it suggests FsmState(Fsm.StepFsm) but idk what Fsm.StepFsm is

fair rampart Apr 30, 2021, 11:58 PM

#

5 min abyss shrek customknight spell, feel free to use it

#

a recording of it

copper nacelle May 1, 2021, 12:00 AM

#

not cutting the head smh

weak lodge May 1, 2021, 12:02 AM

#

we dont need to make any more custom knight skins

#

this one peaked them

safe hamlet May 1, 2021, 12:02 AM

#

you should remove the background and it will be perfect

fair rampart May 1, 2021, 12:03 AM

#

nah, the "abyss" is in the background as well

safe hamlet May 1, 2021, 12:03 AM

#

i don't care what you think, remove it

weak lodge May 1, 2021, 12:04 AM

#

toxic

fair rampart May 1, 2021, 12:05 AM

#

remove it yourself i have 2 exams on wed

#

need to stop making sustomknight stuff

runic wind May 1, 2021, 6:38 AM

#

ok this is perhaps the dumbest possible problem to have

#

as far as I can tell, fsms have BoolAllTrue, BoolAnyTrue, and BoolNoneTrue

#

but I need BoolAnyFalse (or something) and can't find that one

#

and I'd rather not use a bunch of BoolFlipEveryFrames if possible

copper nacelle May 1, 2021, 6:40 AM

#

Is there not a not

runic wind May 1, 2021, 6:41 AM

#

idk, does that work for fsms? I can try it

#

a weird exclusion regardless

fair rampart May 1, 2021, 7:15 AM

#

should i remake the big orb it doesn't have a good colour and contrast

runic wind May 1, 2021, 7:16 AM

#

how do I get an fsm event as an FsmEvent type?

steady comet May 1, 2021, 7:18 AM

#

runic wind how do I get an fsm event as an FsmEvent type?

https://github.com/seresharp/HollowKnight.SereCore/blob/master/PlaymakerExtensions.cs#L63

I'm not sure it changes in the 1.5 mapi tho

runic wind May 1, 2021, 7:19 AM

#

hmm

#

I think I can just use a workaround

steady comet May 1, 2021, 7:19 AM

#

Yeah probably

runic wind May 1, 2021, 7:24 AM

#

ok what the fuck

#

how do I even see if an fsmBool is true or false

#

it can't go in if statements and such

steady comet May 1, 2021, 7:27 AM

#

Usually .Value

#

so like myFsmBool.Value should have the bool type probably

steel badger May 1, 2021, 7:28 AM

#

fair rampart should i remake the big orb it doesn't have a good colour and contrast

Depends, what skin are you trying to make?

nimble lake May 1, 2021, 7:34 AM

#

fair rampart should i remake the big orb it doesn't have a good colour and contrast

whoa that looks cool

fair rampart May 1, 2021, 7:36 AM

#

steel badger Depends, what skin are you trying to make?

pure vessel but better

runic wind May 1, 2021, 9:44 AM

#

is there a way to insert a method into an fsm that runs every frame?

fair rampart May 1, 2021, 9:46 AM

#

i think i improved it but the colour is still off shermanxious
i shall proceed to ignore that

pale plover May 1, 2021, 11:00 AM

#

nice

steady comet May 1, 2021, 11:16 AM

#

@runic wind If you want to make it run every frame you'll probably want to make your own FsmStateAction with an OnUpdate or OnFixedUpdate method. This is what rando does for a method that just runs once https://github.com/homothetyhk/HollowKnight.RandomizerMod/blob/master/RandomizerMod3.0/FsmStateActions/RandomizerExecuteLambda.cs, you can just also override OnUpdate or OnFixedUpdate as well to make it run every frame.

arctic dragon May 1, 2021, 11:45 AM

#

fair rampart i think i improved it but the colour is still off <:shermanxious:732796677760614...

maybe decrease the brightness of the orb itself before slapping the focus thingy on it? like the smaller orbs r darker with the thingies being bright. it looks very nice, though!

shut falcon May 1, 2021, 12:03 PM

#

fair rampart should i remake the big orb it doesn't have a good colour and contrast

that looks amazing

steady comet May 1, 2021, 12:47 PM

#

What is the etiquette on how good/useful/polished a mod has to be before it can go on modinstaller?

cedar hemlock May 1, 2021, 12:47 PM

#

working

#

not too much updates after adding

#

not breaking everything

vocal spire May 1, 2021, 12:49 PM

#

cedar hemlock not breaking everything

I have the best mod idea, break everything!

cedar hemlock May 1, 2021, 12:50 PM

#

i mean, even with breaking everything it still gets on the modinstaller and the fix doesn't get merged

jolly oriole May 1, 2021, 12:56 PM

#

visibility:
https://github.com/ricardosouzag/ModInstaller/pull/92
https://github.com/ricardosouzag/ModInstaller/pull/90
https://github.com/ricardosouzag/ModInstaller/pull/89

cedar hemlock May 1, 2021, 12:57 PM

#

i love how 91 gets merged but the rest gets skipped

jolly oriole May 1, 2021, 12:58 PM

#

91 is an issue

cedar hemlock May 1, 2021, 12:59 PM

#

learned smth new: issues and pr's share that id thingie

tawny onyx May 1, 2021, 2:49 PM

#

what i found! jngo comming back?

jolly oriole May 1, 2021, 2:51 PM

#

maybe ¯_(ツ)_/¯

tawny onyx May 1, 2021, 2:51 PM

#

grubomg

floral blade May 1, 2021, 3:31 PM

#

tawny onyx what i found! jngo comming back?

I really wish they would, my pr to custom knight lies in wait

pseudo pond May 1, 2021, 3:51 PM

#

jovial gazelle Random unrelated tip thingy, you can edit your build settings in visual studio t...

i can't get this to work

jovial gazelle May 1, 2021, 3:52 PM

#

pseudo pond i can't get this to work

Is there a space in your file path?

pseudo pond May 1, 2021, 3:52 PM

#

i might just be formatting it incorectly

jovial gazelle May 1, 2021, 3:52 PM

#

Spaces in folder names mess some stuff up, but you should be able to fix it my putting quotes around the path in your command

pseudo pond May 1, 2021, 3:53 PM

#

i think i see the issue

#

ill try that

#

yep that worked, thanks

jovial gazelle May 1, 2021, 3:53 PM

#

🙂

pseudo pond May 1, 2021, 3:53 PM

#

i think it was the space in Program Files (x86)

jovial gazelle May 1, 2021, 3:54 PM

#

That would do it

runic wind May 1, 2021, 8:17 PM

#

is "FINISHED" the only fsm event that will automatically trigger if the state reaches the end?

#

it seems to be happening with other events, when I don't want it to

#

if it's supposed to happen with all events, how do I keep the fsm in one state until some conditions are met?

steady comet May 1, 2021, 8:19 PM

#

runic wind is "FINISHED" the only fsm event that will automatically trigger if the state re...

FINISHED is just the event that happens when the state reaches the end, the others have to happen manually (i.e. the fsm receives that event somehow). If there's no transition on FINISHED then nothing will happen when the state reaches the end, I think

runic wind May 1, 2021, 8:20 PM

#

hmm, I probably fucked up indexes then

steady comet May 1, 2021, 8:20 PM

#

Maybe

runic wind May 1, 2021, 8:22 PM

#

when an event is sent it will immediately stop executing the state instructions, right?

#

e.g. nothing after the send instruction is done

steady comet May 1, 2021, 8:23 PM

#

I believe that nothing will happen unless the state has a transition for that event

runic wind May 1, 2021, 8:24 PM

#

but if it does

steady comet May 1, 2021, 8:25 PM

#

AFAIK when it receives the event it stops everything in the current state, moves to the new state and starts doing the actions in the new state

runic wind May 1, 2021, 8:25 PM

#

cool, that's the behavior I want

#

but I'm using log debugging and it's reaching the end of one state and then immediately the start of the next state and I have no idea why

#

there's two events, one is completely unused and the other is not "FINISHED"

steady comet May 1, 2021, 8:27 PM

#

Are you sure there's no FINISHED transition? That's all I can think of

runic wind May 1, 2021, 8:27 PM

#

I thought of something else that's actually probably happening

#

the insertMethods I'm using to debug are only being run the first time

#

yep got it

#

forgot to set something to run every frame and my debug logs were also running only once so I didn't see it

#

it's actually working now!

#

and 50 fps vengeflys are hilarious

jolly jungle May 1, 2021, 9:16 PM

#

Guess who's gonna create brand new attacks (with animations) for a boss for the first time?

#

Wish me luck

jolly oriole May 1, 2021, 9:16 PM

#

gl ig

jolly jungle May 1, 2021, 9:18 PM

#

My luck acquisition techniques are brilliant shadeshades

#

Wait how do I create new states shadecry

#

Regarding states there's only "change state" and "current state" in the docs

#

Can I just add in a random name into "state2" and it'll go to a new state called that?

jolly oriole May 1, 2021, 9:27 PM

#

some fsmutil versions have a pfsm.copyState method to copy a state, its actions and transitions to a new state with a name you provide

jolly jungle May 1, 2021, 9:28 PM

#

Will transitions to the state also be copied?
They shouldn't, but...

jolly oriole May 1, 2021, 9:28 PM

#

no

jolly jungle May 1, 2021, 9:29 PM

#

Aight, good

#

So I can copy it over, and then change all the actions and transitions as I please

#

Cool

#

Thanks hollowknice

jolly oriole May 1, 2021, 9:30 PM

#

i think in the fsmutil of dev versions of sfcore i have a method to create empty states

jolly jungle May 1, 2021, 9:31 PM

#

I mean if it's short and doesn't need anything else I guess I can copy it over? But I don't see why bother, least not right now

#

Thanks though

jolly jungle May 1, 2021, 9:58 PM

#

What happens if I remove a transition but I don't change the action that leads to it?

jolly oriole May 1, 2021, 9:59 PM

#

it just continues with the current state

jolly jungle May 1, 2021, 10:17 PM

#

Oh, alright

#

Thanks

#

Well I'm done for today

vague venture May 1, 2021, 10:28 PM

#

i'm looking to commission someone to make a little mod that lets me kill grubs. dm me for more info if you're capable/interested

merry lotus May 1, 2021, 10:30 PM

#

That is the most upsetting commission request I've ever seen grubcry

jolly oriole May 1, 2021, 10:42 PM

#

weird way to spell 'blessed'

copper nacelle May 1, 2021, 10:44 PM

#

TRUE

steel badger May 1, 2021, 11:20 PM

#

vague venture i'm looking to commission someone to make a little mod that lets me kill grubs. ...

Don’t we already have it to where you can kill grubs? But they are mimics

jolly oriole May 1, 2021, 11:22 PM

#

but those aren't grubs

steel badger May 1, 2021, 11:38 PM

#

jolly oriole but those aren't grubs

But then what are they?

copper nacelle May 1, 2021, 11:40 PM

#

mimics

steel badger May 1, 2021, 11:42 PM

#

copper nacelle mimics

But that is the closest thing we have to killing grubs, how much more evil can we get?

copper nacelle May 1, 2021, 11:43 PM

#

bro it's easy

#

kill a real grub

steel badger May 1, 2021, 11:44 PM

#

copper nacelle kill a real grub

but doesn't that make us worse than The Radiance?

copper nacelle May 1, 2021, 11:44 PM

#

you mean more based

steel badger May 1, 2021, 11:45 PM

#

copper nacelle you mean more based

No I mean worse

copper nacelle May 1, 2021, 11:45 PM

#

nah you don't

steel badger May 1, 2021, 11:45 PM

#

copper nacelle nah you don't

We'll be the true villains

copper nacelle May 1, 2021, 11:45 PM

#

based

#

why are you pinging me every reply

ornate rivet May 1, 2021, 11:46 PM

#

copper nacelle why are you pinging me every reply

why not?

steel badger May 1, 2021, 11:47 PM

#

copper nacelle why are you pinging me every reply

Idk tbh

fair rampart May 2, 2021, 12:07 AM

#

shut falcon that looks amazing

thanks laceblush

#

anyway what's the fastest way i can test birthplace cutscene for a customknight multiple times (this is just some intermediate testing, it's incomplete)

copper nacelle May 2, 2021, 12:14 AM

#

get a savestate

#

or set a dgate with debug

fair rampart May 2, 2021, 12:14 AM

#

how to get savestate

#

wait actually i can just save edit

#

i have a throwaway save with not a lot of abilities

fair rampart May 2, 2021, 1:36 AM

#

bruh the sprite position

#

i'm not done with the knight, in this customknight you basically play as the hollow knight

#

so like new storyline (inspired by lazycat's mod), hollow knight realised what it needed to do to destroy the radiance and save hallownest, and it was given another chance

#

the birthplace cutscene is basically its regret

#

so like there weren't 2 young hks present in the scene, it's just thk reliving its regret of what went wrong

#

but the sprite position be like shermaU
this is already my 3rd attempt

copper nacelle May 2, 2021, 1:41 AM

#

you know there's like a thing which like cuts it into individual images yeah?

fair rampart May 2, 2021, 1:41 AM

#

wait legit

#

where

deep wave May 2, 2021, 1:42 AM

#

#modding-discussion pins iirc

fair rampart May 2, 2021, 1:42 AM

#

thanks

copper nacelle May 2, 2021, 1:43 AM

#

the skin stuff is modding-discussion usually

#

this is more for like code

fair rampart May 2, 2021, 1:44 AM

#

thanks

midnight narwhal May 2, 2021, 5:29 AM

#

to preload flukmarm, would i want it to be ("Waterways_12", "Fluke Mother") or ("Waterways_12_boss", "Fluke Mother")

#

(its gameobject dump was in Waterways_12_boss.txt)

midnight narwhal May 2, 2021, 6:52 AM

#

((it was "Waterways_12_boss"))

worn eagle May 2, 2021, 7:23 AM

#

heh

cedar hemlock May 2, 2021, 7:27 AM

#

heh

midnight narwhal May 2, 2021, 7:32 AM

#

trolled

jolly jungle May 2, 2021, 7:41 AM

#

worn eagle heh

Aw this is beatiful

copper nacelle May 2, 2021, 7:58 AM

#

worn eagle heh

jolly jungle May 2, 2021, 7:59 AM

#

Hahaa

#

Yessss

cedar hemlock May 2, 2021, 7:59 AM

#

heh

jolly jungle May 2, 2021, 8:00 AM

#

For me the first time I watched it it froze right at the kill

#

Perfectly cut

light zodiac May 2, 2021, 8:38 AM

#

how would i make both of them "FALSE"

steady comet May 2, 2021, 8:40 AM

#

Maybe something like myAction.trueEvent.Value = myAction.falseEvent.Value ?

#

Or just make the transition for TRUE be the same as the transition for FALSE, if that doesn't mess with the rest of the state

#

Or replace the action with your own action that just goes to the target of the FALSE transition

#

Probably at least one of those will work, not sure what the best stylistically is though

light zodiac May 2, 2021, 8:46 AM

#

steady comet Maybe something like myAction.trueEvent.Value = myAction.falseEvent.Value ?

true event doesnt have a value

steady comet May 2, 2021, 8:51 AM

#

You might just be able to yeet the .Values so it's just .trueEvent = .falseEvent

jolly jungle May 2, 2021, 8:56 AM

#

light zodiac how would i make both of them "FALSE"

Just remove the transition from TRUE

#

It should work (based on this #archived-modding-development message)

cedar hemlock May 2, 2021, 8:58 AM

#

do <> around the link

#

<link>

steady comet May 2, 2021, 8:59 AM

#

jolly jungle Just remove the transition from TRUE

As I understand it Mulhima wants it to move to the false transition on true, rather than staying on the current state (I could be wrong tho)

#

I guess you could do that and then add a transition on FINISHED instead of TRUE if you prefer

jolly jungle May 2, 2021, 9:00 AM

#

steady comet As I understand it Mulhima wants it to move to the false transition on true, rat...

So change transition, I guess tamershrug

light zodiac May 2, 2021, 9:08 AM

#

steady comet As I understand it Mulhima wants it to move to the false transition on true, rat...

i basically dont want the "TRUE" transision to happen

jolly jungle May 2, 2021, 9:09 AM

#

But will it do the FALSE transition or do nothing?

#

Or is there only TRUE and FALSE palehmm

#

In which case you should just rewire TRUE to do the same as FALSE

light zodiac May 2, 2021, 9:17 AM

#

so i would use fsm.ChangeTransition?

steady comet May 2, 2021, 9:22 AM

#

Is that an extension method? It might depend on if you're using an FSM extension library or not

light zodiac May 2, 2021, 9:22 AM

#

also, how do i preload

#

the scene was GG_Hollow_Knight so i did ("GG_Hollow_Knight", "Dream Entry")

#

but then my mod failed to load

#

where would i find the full name for "Dream Entry"

steady comet May 2, 2021, 9:28 AM

#

Maybe in here? #archived-modding-development message

light zodiac May 2, 2021, 9:36 AM

#

Thank you

potent dirge May 2, 2021, 11:44 AM

#

what're you trying to do btw, mulhima? just from a glance I want to guess skip the dream entry standing up animation?

#

but honestly Ive barely a clue what I'm even doing myself 🥴

jolly oriole May 2, 2021, 12:03 PM

#

Input
[{
    "name": "mod2",
    "deps": []
},
{
    "name": "mod3",
    "deps": [ "mod2" ]
},
{
    "name": "mod1",
    "deps": [ "mod2", "mod3" ]
}]

Output
{
    "mod2": 0,
    "mod3": 1,
    "mod1": 2
}

now to just make this in c# for the mapi and there is no need anymore for the library/mod check

deep wave May 2, 2021, 12:13 PM

#

would this theoretically eliminate the need to dictate load order?

jolly oriole May 2, 2021, 12:17 PM

#

deep wave would this theoretically eliminate the need to dictate load order?

current load order is dictated by a library/mod check, then with the getloadorder int (+ aplhabetical order)
this would replace the library/mod check, in the groups (0, 1, 2 in the example), i'd continue to use the getloadorder int

light zodiac May 2, 2021, 12:33 PM

#

potent dirge what're you trying to do btw, mulhima? just from a glance I want to guess skip t...

Yes that is what I wanted to do. It caused a wierd interaction where the player was in the dream entry animation but the hitbox could move

steady comet May 2, 2021, 3:01 PM

#

Is there a good way to undo my changes to an FSM? I'm thinking for the unload method of an IToggleableMod

jolly oriole May 2, 2021, 3:04 PM

#

steady comet Is there a good way to undo my changes to an FSM? I'm thinking for the unload me...

either the fsm has a template, in which case i think you can call pfsm.Init or something to reset the fsm,
or you save the orig fsm in your mod and restore that state in unload

#

or you make your mod not toggleable

steady comet May 2, 2021, 3:04 PM

#

The third option seems better than the second for sure, I'll see if the init one works tho

jolly oriole May 2, 2021, 3:05 PM

#

the first thing i'd say first check if the fsm has a template though, there's like 5 total that have a template

#

i know of like 2 or 3

steady comet May 2, 2021, 3:05 PM

#

Oh how do I check that?

jolly oriole May 2, 2021, 3:06 PM

#

let me open dnspy and i can check

#

if (pfsm.FsmTemplate != null)

steady comet May 2, 2021, 3:07 PM

#

Oh I see

#

I'll test that, thanls

steady comet May 2, 2021, 3:27 PM

#

BTW Option 3 won

jolly oriole May 2, 2021, 3:29 PM

#

👍

solar fern May 2, 2021, 3:58 PM

#

Are we allowed to post an idea of a mod for someone else to make

merry lotus May 2, 2021, 3:59 PM

#

solar fern Are we allowed to post an idea of a mod for someone else to make

That's a large part of what
#modding-discussion is for.

Although if you have a good idea, it might be a good place to start learning how to make them yourself :)

solar fern May 2, 2021, 4:00 PM

#

ok

jolly jungle May 2, 2021, 6:41 PM

#

Any idea why this changes Launch?

#

I don't even have any transition to "State2" yet

copper nacelle May 2, 2021, 6:45 PM

#

.x is probably an fsmfloat then

jolly jungle May 2, 2021, 6:46 PM

#

Nah, it's just a part of the action

#

And isn't in the float list

copper nacelle May 2, 2021, 6:48 PM

#

uh huh

jolly jungle May 2, 2021, 6:48 PM

#

Oh I see what you meant now

jolly oriole May 2, 2021, 6:48 PM

#

jolly jungle May 2, 2021, 6:49 PM

#

?

#

Wait

#

Are the x,y pointers to that thing there

#

or to something anyways

jolly oriole May 2, 2021, 6:50 PM

#

the Value = thing directly edited the value of the fsmfloat (also the one in variables, as that is the same fsmfloat)

#

yes

jolly jungle May 2, 2021, 6:50 PM

#

Welp

#

What solutions are there?

#

Will using a blank state work?

jolly oriole May 2, 2021, 6:52 PM

#

you could .x = 5, though idk if that also just changes the value itself

jolly jungle May 2, 2021, 6:54 PM

#

But x is an fsmfloat, not a float palehmm

#

No?

#

Or can you use a float in there directly?

jolly oriole May 2, 2021, 6:55 PM

#

you can just directly assign a float, but idk if it's shorthand to just adjust the value

copper nacelle May 2, 2021, 6:55 PM

#

no it's an implicit new

#

#

it's static it can't affect an instance in the first place

jolly oriole May 2, 2021, 6:55 PM

#

nice

copper nacelle May 2, 2021, 6:55 PM

#

i mean it technically could if you had a shit global but that'd be awful

jolly jungle May 2, 2021, 7:01 PM

#

copper nacelle no it's an implicit new

I don't know what it means confuzz

#

But ok

jolly oriole May 2, 2021, 7:08 PM

#

assinging a float creates a new FsmFloat instead of changing the value of the existing fsmfloat

jolly jungle May 2, 2021, 7:12 PM

#

Ohhh I see

#

Well, it worked, anyways

#

Thanks mylajoy

jolly jungle May 2, 2021, 7:52 PM

#

Nothing is working

#

Entirely unrelated to that, I'm done for today with this

fair rampart May 2, 2021, 8:54 PM

#

any way to open .assets file without unity?

jolly oriole May 2, 2021, 8:55 PM

#

UABE or assetsview can open them

#

UABE: https://github.com/DerPopo/UABE/releases/latest
AssetsView: https://github.com/nesrak1/AssetsTools.NET/releases/tag/v16

vocal spire May 2, 2021, 10:26 PM

#

🤔

normal patio May 2, 2021, 10:35 PM

#

So, someone is making a OneShot skin pack, and wants make the soul yellow. But when they looked at the sprites, they couldn't find any way to make the soul gauge yellow. they're talking about making the soul inside of the gauge yellow, not just the full meter

arctic dragon May 2, 2021, 10:40 PM

#

afaik there’s no known way to do this? i certainly haven’t seen any other customknight do it

copper nacelle May 2, 2021, 10:45 PM

#

Not using CustomKnight no

#

You could mod it in yourself fairly easily I think

normal patio May 2, 2021, 10:51 PM

#

okay I'll pass the info along. thank you grublove

#

is there an sheet or png that shows the order of the knight sprites in knight.png?

vocal spire May 2, 2021, 11:04 PM

#

Use godump

midnight narwhal May 3, 2021, 12:41 AM

#

https://paste.mod.gg/ajalecabam.cs anyone know why this just randomly crashes the game without warning and no errors appear in modlog.txt?

copper nacelle May 3, 2021, 12:48 AM

#

Infinite recursion

#

Is what I'd guess

midnight narwhal May 3, 2021, 12:50 AM

#

so should i stop the coroutine before starting it again?

copper nacelle May 3, 2021, 12:51 AM

#

idk why you're not just looping

midnight narwhal May 3, 2021, 12:52 AM

#

ah

#

that could work

#

it still crashes

copper nacelle May 3, 2021, 12:59 AM

#

hmm

#

is it invoking the coroutine which crashes the game

midnight narwhal May 3, 2021, 1:00 AM

#

wdym

#

it crashes after a bit

#

the coroutine runs for a bit and everything is fine

#

then it freezes after a bit

copper nacelle May 3, 2021, 1:08 AM

#

if you don't run the coroutine I assume it never crashes?

midnight narwhal May 3, 2021, 1:11 AM

#

yeah

#

the coroutine also seems to drop my frames

#

i think

#

although that may just be because of the 6 marmus at once

light zodiac May 3, 2021, 1:21 AM

#

midnight narwhal although that may just be because of the 6 marmus at once

To test that out you could try with only 1/2 marmus

midnight narwhal May 3, 2021, 1:25 AM

#

i can confirm it gradually drops my frames from around 260 to about 150 after all 6 marmus are spawned

#

and then crashes

#

it incrementally drops after frame spikes

light zodiac May 3, 2021, 1:26 AM

#

What's your code with the loop?

copper nacelle May 3, 2021, 1:29 AM

#

did you check output log

midnight narwhal May 3, 2021, 1:31 AM

#

(fps drop example)

charred topaz May 3, 2021, 1:31 AM

#

The times where I had a coroutine freeze the game is usually because it never runs a yield statement

midnight narwhal May 3, 2021, 1:32 AM

#

copper nacelle did you check output log

no i should probably

#

what should i be looking for

copper nacelle May 3, 2021, 1:33 AM

#

I mean if the game crashes there's gonna be something at the end of it

midnight narwhal May 3, 2021, 1:34 AM

#

the only mention of the marmus is

FSM not Preprocessed: MiniMarmu : Control
 
(Filename: C:\buildslave\unity\build\artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

#

(that occurs 6 times right at the end

#

)

copper nacelle May 3, 2021, 1:36 AM

#

is that all

#

with the game having crashed

midnight narwhal May 3, 2021, 1:37 AM

#

yeah i think

copper nacelle May 3, 2021, 1:40 AM

#

I think x5fiftM

midnight narwhal May 3, 2021, 1:40 AM

#

ill crash it again

copper nacelle May 3, 2021, 1:40 AM

#

do me a favor and add a log with the count before the if

midnight narwhal May 3, 2021, 1:40 AM

#

ok

#

(btw i changed the counting thing to var objects = Resources.FindObjectsOfTypeAll<GameObject>().Where(obj => obj.name == "MiniMarmu");)

copper nacelle May 3, 2021, 1:42 AM

#

Oh god why

#

You went from slow to even slower

midnight narwhal May 3, 2021, 1:42 AM

#

should i change it back

copper nacelle May 3, 2021, 1:42 AM

#

Just tag it and find objects with tag

midnight narwhal May 3, 2021, 1:42 AM

#

ah

#

how do i add a tag

#

or more specifically define a tag

copper nacelle May 3, 2021, 1:55 AM

#

it's just a string

#

you just do marmu.tag = "MMarmu" or whatever

light zodiac May 3, 2021, 1:55 AM

#

marmu.tag = "tag"?

midnight narwhal May 3, 2021, 2:12 AM

#

but just doing that gives me the error

[ERROR]:[UNITY] - UnityException: Tag: FlukemarmuSpawn is not defined.
[ERROR]:[UNITY] - Flukemarmu.FlukemarmuControl+<SpawnMiniMarmus>d__11.MoveNext ()
[ERROR]:[UNITY] - UnityEngine.SetupCoroutine.InvokeMoveNext (IEnumerator enumerator, IntPtr returnValueAddress)
[ERROR]:[UNITY] -

light zodiac May 3, 2021, 2:13 AM

#

how are you searching for the tag?

midnight narwhal May 3, 2021, 2:15 AM

#

GameObject[] marmus = GameObject.FindGameObjectsWithTag("FlukemarmuSpawn");

copper nacelle May 3, 2021, 2:20 AM

#

It appears you cannot create tags at runtime

#

Fun

#

Could use a list or something

midnight narwhal May 3, 2021, 2:28 AM

#

yeah

#

well my fps no longer drops but it still crashes

light zodiac May 3, 2021, 2:42 AM

#

What's your code?

midnight narwhal May 3, 2021, 2:43 AM

#

https://paste.mod.gg/liviyifaze.cpp

#

MarmuOnDeath() is just

private void MarmuOnDeath()
        {
            marmuCount--;
        }

light zodiac May 3, 2021, 2:48 AM

#

Did you do StartCouroutine( SpawnMiniMarmus()) or
Gamemanager.instance.StartCouroutine( SpawnMiniMarmus())

midnight narwhal May 3, 2021, 2:54 AM

#

im currently doing the first

#

should i be doing the second?

light zodiac May 3, 2021, 2:56 AM

#

If you do the first, the wait seconds will make the whole game wait

copper nacelle May 3, 2021, 2:56 AM

#

what

light zodiac May 3, 2021, 2:56 AM

#

I tried it out

copper nacelle May 3, 2021, 2:56 AM

#

lost it

#

no

#

what the fuck

midnight narwhal May 3, 2021, 2:57 AM

#

that didnt happen to me

#

(also it still crashes with the gamemanger StartCoroutine)

worn eagle May 3, 2021, 6:16 AM

#

runic wind May 3, 2021, 7:18 AM

#

Nice job, I hate it

vocal spire May 3, 2021, 7:54 AM

#

worn eagle

I like it, ~~time to make it for every npc~~

rough pulsar May 3, 2021, 9:48 AM

#

worn eagle

NONOONONONOONONONOONONONONONONOO

#

is it ok if i post it in #hk-discussion

#

ima do it

ornate rivet May 3, 2021, 10:10 AM

#

it's beautiful

arctic dragon May 3, 2021, 10:29 AM

#

GUB NO

primal latch May 3, 2021, 11:07 AM

#

How would I go about setting the knight’s default speed to the same speed as dashmaster?

arctic dragon May 3, 2021, 11:27 AM

#

you mean sprintmaster? iirc dashmaster doesn’t increase regular run speed

primal latch May 3, 2021, 11:31 AM

#

arctic dragon you mean sprintmaster? iirc dashmaster doesn’t increase regular run speed

Yes

arctic dragon May 3, 2021, 11:33 AM

#

i’m not that much of a coder but my best guess is finding something named or tagged with speed, and mess with the value
probably something like varBaseSpeed for the well, base speed, and check wherever the charm stuff is stored on the speed value sprintmaster uses

steady comet May 3, 2021, 11:40 AM

#

Just ctrl+f for "equippedCharm_37" in the HeroController file in DnSpy to see what you need to hook

light zodiac May 3, 2021, 11:41 AM

#

primal latch How would I go about setting the knight’s default speed to the same speed as das...

Herocontroller.RUN_SPEED = Herocontroller.RUN_SPEED_CH_COMBO for dashmaster + sprint master. if only sprint master then only RUN_SPEED_CH

primal latch May 3, 2021, 12:13 PM

#

light zodiac `Herocontroller.RUN_SPEED = Herocontroller.RUN_SPEED_CH_COMBO` for dashmaster + ...

Where? Because I can imagine that the gam also changes the speed

light zodiac May 3, 2021, 12:17 PM

#

idk heroupdatehook?

primal latch May 3, 2021, 12:17 PM

#

Ok

light zodiac May 3, 2021, 12:18 PM

#

nvm, this is what the game doescs this.rb2d.velocity = new Vector2(move_direction * this.RUN_SPEED, this.rb2d.velocity.y);

#

so it doesnt need to be in a update hook

arctic dragon May 3, 2021, 12:19 PM

#

looks like spaghetti to me but it functions

primal latch May 3, 2021, 12:19 PM

#

light zodiac so it doesnt need to be in a update hook

But I mean: they do change the variable right?

light zodiac May 3, 2021, 12:19 PM

#

no

primal latch May 3, 2021, 12:20 PM

#

light zodiac no

Is there no case where that variable is changed?

light zodiac May 3, 2021, 12:20 PM

#

primal latch May 3, 2021, 12:20 PM

#

light zodiac

Not necessarily in that function

#

Ah. Like that.

#

Ok. Thanks.

#

What is the difference between runspeed and walkspeed?

light zodiac May 3, 2021, 12:21 PM

#

walk speed is like dirthmouth. run speed is normal speed

primal latch May 3, 2021, 12:22 PM

#

Ok.

worn eagle May 3, 2021, 1:59 PM

#

Any reason why ExtraDamageable works w spore cloud but not w crest's passive?

vocal spire May 3, 2021, 1:59 PM

#

I think crest has a different extra damage type

#

Might change something

#

Been a while since I checked

jolly oriole May 3, 2021, 2:48 PM

#

I'd look at how crystal guardian gets damaged

worn eagle May 3, 2021, 3:12 PM

#

it's weird cause OnTriggerEnter2D isn't registering a trigger w a Knight Dung Trail go

jolly oriole May 3, 2021, 3:13 PM

#

probably layer shenenigans then

worn eagle May 3, 2021, 3:13 PM

#

my extradamageable is on 11

jolly oriole May 3, 2021, 3:38 PM

#

hm, layer 11 should work fine

#

in theory

worn eagle May 3, 2021, 3:55 PM

#

would Fungus2_15_boss: Mantis Lord be a good candidate for a fast preload for uninfected stuff?

#

ideally I would have no preloads but I'm not about to recreate 8 prefabs from scratch

jolly oriole May 3, 2021, 3:58 PM

#

initially i'd say yes because it's only a boss, but seeing this maybe there's a better one, but for now i'd still go with it
(these are dependencies of the scene)

bitter fern May 3, 2021, 6:25 PM

#

Italy why grubsad

cedar hemlock May 3, 2021, 6:31 PM

#

lol

jolly jungle May 3, 2021, 6:37 PM

#

vocal spire I like it, ~~time to make it for every npc~~

Hahahaha no. Don't steal my plans.

#

Anyways beautiful work Italy

jolly oriole May 4, 2021, 12:51 AM

#

gonna leave this here: https://github.com/HollowKnight-Modding/HollowKnight.Modding/pull/43

copper nacelle May 4, 2021, 12:52 AM

#

i will look at when i do not have 4 projects and 2 ap exams

jolly oriole May 4, 2021, 12:53 AM

#

valid

runic wind May 4, 2021, 2:39 AM

#

ChaseObjectV2 and Wait are effectively commented out, right?

#

at this point it feels like TC actively tried to make their code nonsensical

rose cedar May 4, 2021, 2:46 AM

#

really now

runic wind May 4, 2021, 2:47 AM

#

how does this ^ work? ChaseObject and ChaseObjectV2 both have onFixedUpdates that set the rb2d's velocity. Which one is overwriting the other?

steady comet May 4, 2021, 4:56 AM

#

runic wind how does this ^ work? ChaseObject and ChaseObjectV2 both have onFixedUpdates tha...

If you haven’t figured it out yet, you could try adding an extra action that logs the object’s speed every frame and see what happens?

runic wind May 4, 2021, 5:09 AM

#

I realized I actually don't need to figure out how it works to fix it

#

Also is it known how they (follies) move while you're paused?

#

if not I'll try to figure it out

jolly jungle May 4, 2021, 6:27 AM

#

runic wind ChaseObjectV2 and Wait are effectively commented out, right?

Wait there's actually a thing called "chase object"?

#

What fsm is this?

runic wind May 4, 2021, 7:29 AM

#

this is the follies fsm

#

it's also used in vengeflys though

jolly oriole May 4, 2021, 10:31 AM

#

runic wind ChaseObjectV2 and Wait are effectively commented out, right?

Tbh i think that the lower part is from.an older version and this is how tc made it not be executed

balmy sphinx May 4, 2021, 4:21 PM

#

Anyone has any news on the pale court mod?

jolly oriole May 4, 2021, 5:08 PM

#

it's pulling a silksong

balmy sphinx May 4, 2021, 5:23 PM

#

jolly oriole it's pulling a silksong

At least we got SOME news since its trailer came out

#

For now i found NOTHING except the trailer of the mod

jolly oriole May 4, 2021, 5:24 PM

#

yea, sounds about right

amber loom May 5, 2021, 2:32 PM

#

Hey, I've an issue regarding TASing tool for HK

#

I would like to trace calls to UnityEngine.Random.Range() from the game, but I'm not sure what is the best method

#

I want to know the returned values

vocal spire May 5, 2021, 2:37 PM

#

amber loom I want to know the returned values

You would probably need to patch UnityEngine.dll(I think this is right) and from there log the values and maybe have some way of logging what called it too

#

It might be UnityEngine.CoreModule.dll

amber loom May 5, 2021, 2:38 PM

#

UnityEngine.dll only shows the interface for the critical methods (Range(), but also InitState()), I don't know if I can insert code there

#

(using dnspy, I forgot)

vocal spire May 5, 2021, 2:39 PM

#

Ah, I don’t know then

jolly oriole May 5, 2021, 2:43 PM

#

there may be a possibility with 'interesting' Reflection, though idk if it really works

stone elm May 5, 2021, 2:50 PM

#

Harmony patch it

copper nacelle May 5, 2021, 2:53 PM

#

amber loom (using dnspy, I forgot)

could probably do a patch-time thing where you dllimport and then call the dllimport'd function

#

There's also the option of NativeDetour

#

I believe Katie had some code which just overwrote the asm for a native function too

primal latch May 5, 2021, 3:57 PM

#

amber loom `UnityEngine.dll` only shows the interface for the critical methods (`Range()`, ...

Well. It is a function in UnityEngine.CoreModule.dll. Wierdly, it calls another function named RandomRangeInt, but it doesn't have a declaration. This is wierd since it has [MethodImpl(MethodImplOptions.InternalCall)] right above it which means that it should be declared inside this library

#

copper nacelle May 5, 2021, 4:09 PM

#

InternalCall is for the jit/clr to handle

primal latch May 5, 2021, 4:12 PM

#

Wdym?

copper nacelle May 5, 2021, 4:14 PM

#

it's implemented in c++

#

https://stackoverflow.com/a/8870593/17034

Stack Overflow

How is Math.Pow() implemented in .NET Framework?

I was looking for an efficient approach for calculating ab (say a = 2 and b = 50). To start things up, I decided to take a look at the implementation of Math.Pow() function. But in .NET Reflector, ...

#

meme

worn eagle May 5, 2021, 6:48 PM

#

pfsm moment

copper nacelle May 5, 2021, 6:51 PM

#

yo sick

vocal spire May 5, 2021, 7:06 PM

#

Awesome!

jolly oriole May 5, 2021, 7:27 PM

#

did you make the pfsm in unity? (i can't get playmaker to work so i'd do it pepega-style in code lol)

ornate rivet May 5, 2021, 7:29 PM

#

That looks so coool

#

the idle movements should be slowed down a little but other than that I love it!

worn eagle May 5, 2021, 7:32 PM

#

jolly oriole did you make the pfsm in unity? (i can't get playmaker to work so i'd do it pepe...

yeah, unity 2018.4.19f

vocal spire May 5, 2021, 8:15 PM

#

I’ll try making a pfsm for hk in unity at some point, it seems really fun, plus I already have playmaker

jolly oriole May 5, 2021, 8:17 PM

#

worn eagle yeah, unity 2018.4.19f

may be why i didn't get it to work 🥴 2017.4.10f1 isn't apparently quite the right version

vocal spire May 5, 2021, 8:17 PM

#

I thought I tried that one, and it worked, but idk, prob remembering wrong

worn eagle May 5, 2021, 8:19 PM

#

there's stuff I don't remember I had to do to fix compiler errors, maybe I could create a sort of "template project"

jolly oriole May 5, 2021, 8:20 PM

#

*_*

rough pulsar May 5, 2021, 9:05 PM

#

What framework version was 1.5 using again

jolly oriole May 5, 2021, 9:06 PM

#

472

rough pulsar May 5, 2021, 9:06 PM

#

Excellent

#

Im waiting for its full release

#

No more suffering after that

worn eagle May 5, 2021, 11:42 PM

#

is RecordJournalEntry in FrogCore causing hollow knight to die a known issue

merry lotus May 6, 2021, 12:08 AM

#

worn eagle pfsm moment

That looks amazing!
If these are replacing the shrumal warriors, are they still going to waa? waa

worn eagle May 6, 2021, 12:40 AM

#

📎 ShrumalKnight.dll

cedar hemlock May 6, 2021, 8:15 AM

#

rough pulsar Im waiting for its full release

you can also already start working at it bc iirc thers already a api for the beta?

jolly jungle May 6, 2021, 11:52 AM

#

runic wind this is the follies fsm

Interesting, thanks

#

I don't think it's what I need but I'll take a look at it

#

I should look at Mistakes too, actually, they're more similar

jolly jungle May 6, 2021, 11:53 AM

#

worn eagle pfsm moment

Looks wonderful!

#

Who made the graphics and can you help me get them to help me

#

Also I'd love to look at how you made this

worn eagle May 6, 2021, 11:57 AM

#

I made them

jolly jungle May 6, 2021, 11:58 AM

#

Ah, nice

#

How long did it take

#

Also how does the process of making a new enemy actually work

worn eagle May 6, 2021, 12:00 PM

#

Took me a day to draw 39 sprites and about a day and a half to implement them in unity/mod them into the game

#

I used the same tools that tc used, playmaker and tk2d, to create most of the behaviors and visuals, then I assetbundled them and loaded that into a mod to apply game specific attributes like HealthManager, EnenyDeathEffects, etc.

#

I'm working on a totally legal template Unity project with pfsm and tk2d integrated already; not sure if it'll work on other systems

fair rampart May 6, 2021, 12:19 PM

#

how do you replace white palace spike sprites

#

where to find

vocal spire May 6, 2021, 12:27 PM

#

worn eagle is RecordJournalEntry in FrogCore causing hollow knight to die a known issue

Last I checked the mod installer version was very outdated and that had some problems. I’ll see if I can update it soon, working on a large update

#

Once I update it I’ll probably take uuwuu down from the installer since it has problems with the frogcore update, the update I’m making for uuwuu is far from done though

vocal spire May 6, 2021, 12:44 PM

#

worn eagle I'm working on a totally legal template Unity project with pfsm and tk2d integra...

Nice

#

I already bought playmaker

jolly oriole May 6, 2021, 4:17 PM

#

bruh, can't replace the unityengine.random.range methods

worn eagle May 6, 2021, 5:32 PM

#

let's see if this works

📎 CustomEnemyTemplate.7z

floral blade May 6, 2021, 5:54 PM

#

Can anybody update a mod on modinstaller by raising a PR ? Or does it need to be the mod author ? thkshadeidk

jolly oriole May 6, 2021, 6:00 PM

#

floral blade Can anybody update a mod on modinstaller by raising a PR ? Or does it need to be...

people can do this for others

floral blade May 6, 2021, 6:03 PM

#

But I assume it's verified before being merged ?

copper nacelle May 6, 2021, 6:05 PM

#

yeah

#

i look at it

#

and then i press the green button

floral blade May 6, 2021, 6:05 PM

#

Like for the scenario where a dll is added and it "claims" to be a dll of a certain mod, but is not submitted by its author, or like it's an update to an existing mod

copper nacelle May 6, 2021, 6:05 PM

#

what

#

if someone has made a legit update and the orig author is ok with it i'll update it

floral blade May 6, 2021, 6:07 PM

#

Right, so if the original author is not really super active but they give their go ahead anyone can put out a legit update. Makes sense.

jolly oriole May 6, 2021, 6:17 PM

#

yea

steady comet May 7, 2021, 7:06 AM

#

C sharp question - is there a good reason why structs shouldn't have methods in them?

primal latch May 7, 2021, 7:25 AM

#

steady comet C sharp question - is there a good reason why structs shouldn't have methods in ...

Because they are structs?

jolly oriole May 7, 2021, 7:42 AM

#

i mean, i don't really care if you have methods in your struct, it's just that IMO structs only represent structures (duh) and therefore don't have methods, but that is basically just C-level. in c# it is nearly irrelevant if you use structs or classes

rough pulsar May 7, 2021, 9:58 AM

#

structs are structs shroompog

stone elm May 7, 2021, 12:23 PM

#

steady comet C sharp question - is there a good reason why structs shouldn't have methods in ...

Not really any reason not to, but you'll probably want the methods to be idempotent and the structs to be immutable just for sanity's sake.

copper nacelle May 7, 2021, 12:25 PM

#

structs vs classes are plenty relevant

#

classes are reference types

steady comet May 7, 2021, 12:26 PM

#

stone elm Not really any reason not to, but you'll probably want the methods to be idempot...

As an example, it would be something like

struct Point
{
    public int x;
    public int y;

    public int squareDistance => x^2 + y^2;
}

stone elm May 7, 2021, 12:26 PM

#

That's fine

#

As long as you get the semantics of the type, it doesn't matter much. Like 56 said, classes are reference types and structs are value types. That's why I suggested you keep your structs immutable if possible. (Your example isn't, but I figured it's just an example.)

steady comet May 7, 2021, 12:30 PM

#

When you say keep the struct immutable, does that just mean to replace

    public int x;

with something like

    private readonly int _x;
    public int x => _x;

or something like that?

#

(Or could you just say public readonly int x;?)

stone elm May 7, 2021, 12:40 PM

#

Just put readonly in on the public fields.

jolly oriole May 7, 2021, 6:57 PM

#

oh my goodness, first thing to do is clean up the layout

jolly oriole May 7, 2021, 7:53 PM

#

🤔

copper nacelle May 7, 2021, 7:54 PM

#

true

charred topaz May 7, 2021, 7:56 PM

#

Yeah, it was either that or using a whole bunch of /n characters to properly format it in the settings menu

jolly oriole May 7, 2021, 7:57 PM

#

don't have the json online, but this is how i work around the \n while still having it look nice: https://github.com/SFGrenade/TestOfTeamwork/blob/master/Consts/LanguageStrings.cs#L61

charred topaz May 7, 2021, 7:58 PM

#

@copper nacelle Would you be able to put the new mods on the Installer? This google drive folder should have all the relevant mods and READMEs
https://drive.google.com/drive/folders/1vXD7R-eTj4s9phM2s_JdT5Z7XHpkNcso?usp=sharing

copper nacelle May 7, 2021, 7:58 PM

#

yeah

#

is the release on gh too

charred topaz May 7, 2021, 7:59 PM

#

yeah, I can link you those too

copper nacelle May 7, 2021, 7:59 PM

#

the gh links are nicer because gdrive doesn't send content sizes so the progress is indeterminate

jolly oriole May 7, 2021, 7:59 PM

#

not the zip, only the direct dll is on github

charred topaz May 7, 2021, 8:00 PM

#

https://github.com/nickc01/WeaverCore/releases
https://github.com/nickc01/Inferno-King-Grimm/releases
https://github.com/nickc01/Corrupted-Kin/releases

copper nacelle May 7, 2021, 8:06 PM

#

Sick

#

does ikg have an update then

#

or is that just github links

jolly oriole May 7, 2021, 8:08 PM

#

ikg appears to have had an update

charred topaz May 7, 2021, 8:08 PM

#

All three mods have updates to them

copper nacelle May 7, 2021, 8:08 PM

#

alright cool

#

fwiw you can pr the modinstaller to add entries but I can add it

copper nacelle May 7, 2021, 8:51 PM

#

is there any chance you have a zip

#

modinstaller1 just kinda hates raw dlls

#

I can put the dlls up but the old installer will have a fit

#

questionable

charred topaz May 7, 2021, 8:56 PM

#

I can do that, just give me a moment

#

Does the zip need to contain the dll and README?

jolly oriole May 7, 2021, 8:57 PM

#

yes

copper nacelle May 7, 2021, 8:57 PM

#

yeah

#

if you want short desc text lmk what it is

charred topaz May 7, 2021, 8:59 PM

#

Pretty sure for a quick summary it can be "Corrupted Kin : Turns Lost Kin into a two phase boss fight and makes it harder. Requires WeaverCore"

copper nacelle May 7, 2021, 8:59 PM

#

alright

charred topaz May 7, 2021, 9:05 PM

#

Alright, this should be it, each zip contains the mod dll and the README for the mod
https://drive.google.com/drive/folders/1Fx95VFLtrsHZKjM6Jgco3zCcHHUixUzU?usp=sharing

jolly oriole May 7, 2021, 9:06 PM

#

i think it would be great to also have them part of the github releases (yes, you can just edit the zips in), is not prone to be suddenly deleted (unless github deletes the entire repo for whatever reason)

charred topaz May 7, 2021, 9:30 PM

#

It seems like attempting to install WeaverCore is crashing the installer. The other two mods don't seem to have this problem, I could install them just fine

copper nacelle May 7, 2021, 9:31 PM

#

nice

#

put the zip on gh

charred topaz May 7, 2021, 9:33 PM

#

should I just modify the release page for WeaverCore and put it there?

copper nacelle May 7, 2021, 9:33 PM

#

yeah

charred topaz May 7, 2021, 9:34 PM

#

WeaverCore.zip is in the releases page:
https://github.com/nickc01/WeaverCore/releases/tag/v0.3.0.0-beta

copper nacelle May 7, 2021, 9:35 PM

#

should work now

charred topaz May 7, 2021, 9:38 PM

#

The installer did crash when starting it up, but after removing IKG and Corrupted Kin manually, it looks like it working now

fair rampart May 8, 2021, 12:19 AM

#

how to change prologue text
the elegy for hallownest one

#

(pls ping me I'll be away)

ornate rivet May 8, 2021, 12:44 AM

#

ok

#

@fair rampart

runic wind May 8, 2021, 4:44 AM

#

(I know nothing about the intro cutscenes but) are they even stored as text? there's some chance it's just a video file

fair rampart May 8, 2021, 11:10 AM

#

runic wind (I know nothing about the intro cutscenes but) are they even stored as text? the...

since poorly translated mod changes it it should be editable

deep wave May 8, 2021, 11:11 AM

#

it's likely doable through a language get hook, just check the key for the text and replace that key

jolly oriole May 8, 2021, 11:13 AM

#

I'd guess a language key like "PROLOGUE_TEXT"

light zodiac May 8, 2021, 11:25 AM

#

fair rampart since poorly translated mod changes it it should be editable

If you wanna do it for yourself this would be an easier way
https://github.com/TheMulhima/HollowKnight-ChangeIngameTextMod/blob/main/README.md

jolly oriole May 8, 2021, 11:28 AM

#

PROLOGUE_EXCERPT_01 to PROLOGUE_EXCERPT_04 and PROLOGUE_EXCERPT_AUTHOR

cedar hemlock May 8, 2021, 11:29 AM

#

why not use language support

#

oh nvm then you need to give the users a zip and a new dependecy

jolly oriole May 8, 2021, 11:30 AM

#

language support doesn't overwrite existing text afaik

#

neat

fair rampart May 8, 2021, 12:18 PM

#

light zodiac If you wanna do it for yourself this would be an easier way <https://github.com/...

thanks, how can i make a mod with a few text changes?

vocal spire May 8, 2021, 12:21 PM

#

fair rampart thanks, how can i make a mod with a few text changes?

Do you already know how to make a mod

fair rampart May 8, 2021, 12:25 PM

#

not really that's why i'm asking

vocal spire May 8, 2021, 12:25 PM

#

Ok

#

Do you want to code one or make a settings file for the mod Mulhima made

fair rampart May 8, 2021, 12:26 PM

#

doesn't make a difference

#

as long as it works

cedar hemlock May 8, 2021, 12:27 PM

#

imma just send this to be safe: https://radiance.host/apidocs

vocal spire May 8, 2021, 12:27 PM

#

Extremely big difference zote

fair rampart May 8, 2021, 12:29 PM

#

what?

fair rampart May 8, 2021, 12:29 PM

#

cedar hemlock imma just send this to be safe: <https://radiance.host/apidocs>

thanks hollowknice

vocal spire May 8, 2021, 12:30 PM

#

You should probably decide, code a mod, or edit a text file for Mulhima’s mod

fair rampart May 8, 2021, 12:31 PM

#

if i wanna make it public is coding a mod worth it for changing the prologue alone

vocal spire May 8, 2021, 12:31 PM

#

Idk

fair rampart May 8, 2021, 12:31 PM

#

as an add-on to my customknight (upcoming) project

cedar hemlock May 8, 2021, 12:31 PM

#

if you make it public, code

vocal spire May 8, 2021, 12:31 PM

#

Your choice

fair rampart May 8, 2021, 12:31 PM

#

i shall look into the code

vocal spire May 8, 2021, 12:32 PM

#

cedar hemlock if you make it public, code

Why not just provide the text file and say you need to get this mod

cedar hemlock May 8, 2021, 12:32 PM

#

it isn't easy to tell people they need to download and place there and there...

#

hmm maybe it doesnt matter much as the skin works without the text

fair rampart May 8, 2021, 12:33 PM

#

yeah it's a free additional thing, i'll probably tell them to get it if they want but it's not necessary for the skin alone

#

btw can cutscenes be changed

vocal spire May 8, 2021, 12:34 PM

#

Yes

#

But you need your own mod for that

fair rampart May 8, 2021, 12:34 PM

#

i know, which type of mod can do that

vocal spire May 8, 2021, 12:35 PM

#

Wdym which type of mod

cedar hemlock May 8, 2021, 12:35 PM

#

"type"?

#

what Someone means is that you need to code your own mod for that

fair rampart May 8, 2021, 12:35 PM

#

in this
https://radiance.host/apidocs/index.html

#

under which section does that kind of mod go under

vocal spire May 8, 2021, 12:36 PM

#

There aren’t types of mods....

#

It isn’t explained there

fair rampart May 8, 2021, 12:36 PM

#

so i can quickly get into figuring out how to make it

cedar hemlock May 8, 2021, 12:36 PM

#

its a guide

#

but yeah it doesnt cover cutscenes

vocal spire May 8, 2021, 12:36 PM

#

It’s documents on how modding works and a guide to getting a basic mod format down

#

But you’ll need some prior knowledge of c# for that

fair rampart May 8, 2021, 12:38 PM

#

vocal spire It isn’t explained there

then what do i need? do i need unity knowledge

vocal spire May 8, 2021, 12:38 PM

#

A bit

#

You need c# knowledge, some unity knowledge, ~~and then you need to remember that stack overflow is key to success and go there every 5 minutes~~

fair rampart May 8, 2021, 12:40 PM

#

lmao i do some coding but not c#

vocal spire May 8, 2021, 12:40 PM

#

If you want an example of how to do it, redwing does it

fair rampart May 8, 2021, 12:41 PM

#

i have a mod sample

#

but what is redwing

vocal spire May 8, 2021, 12:41 PM

#

A mod

cedar hemlock May 8, 2021, 12:42 PM

#

https://github.com/natis1/redwing

fair rampart May 8, 2021, 12:43 PM

#

thanks

elder radish May 8, 2021, 4:14 PM

#

I'm using a particle system in one of my scenes. It should be effected from the slash but it seems like the collision does not work.

#

AttackLayer(17)

#

Has anyone experienced something similar?

jolly oriole May 8, 2021, 4:16 PM

#

i have no clue what you're trying to achieve, but if you want things to collide, the pins have a layer collision matrix, maybe that can help

#

oh, you probably want the particles to be flung around by the slash?

#

that won't work as the slash hitbox

is a trigger
doesn't move (just gets activated and deactivated)

#

so you'd need to make the 'particles' have scripts that react to nailswings and fly accordingly

#

possibly, haven't tested such a thing yet

elder radish May 8, 2021, 4:20 PM

#

oh you say the slash does not collide it just triggers oncollision

jolly oriole May 8, 2021, 4:20 PM

#

yes

elder radish May 8, 2021, 4:20 PM

#

this is probably the reason :/

#

thanks a lot

jolly oriole May 8, 2021, 4:49 PM

#

sadly things like this aren't easily possible with just a particle system 😔

light zodiac May 8, 2021, 5:02 PM

#

Is there a modding api for 1424?

vocal spire May 8, 2021, 5:27 PM

#

light zodiac Is there a modding api for 1424?

Yes, check the mod drive

jolly oriole May 8, 2021, 5:40 PM

#

though idk why one would need it

light zodiac May 8, 2021, 5:43 PM

#

i have my reasons

worn eagle May 8, 2021, 5:53 PM

#

So I built the beta api on windows and it worked fine but on Linux I get float whenever I use a nail art

vocal spire May 8, 2021, 5:55 PM

#

light zodiac i have my reasons

🤔

jolly oriole May 8, 2021, 5:55 PM

#

https://github.com/HollowKnight-Modding/HollowKnight.Modding/commit/26d8e1bc30c2795f6442240481d914129523c08d i thought this PR wasn't merged

jolly oriole May 8, 2021, 5:57 PM

#

worn eagle So I built the beta api on windows and it worked fine but on Linux I get float w...

this is weird

copper nacelle May 8, 2021, 6:16 PM

#

worn eagle So I built the beta api on windows and it worked fine but on Linux I get float w...

slow fall with great slash?

worn eagle May 8, 2021, 6:19 PM

#

yep

copper nacelle May 8, 2021, 6:22 PM

#

that's what happens when the fsm gets interrupted

#

very easy to do with like map but it's fucked that it's happening by itself

jolly oriole May 8, 2021, 6:23 PM

#

and considering everything nailart is handled by FSMs idk what the mapi does to kill the fsm

jolly oriole May 8, 2021, 6:27 PM

#

worn eagle yep

is there an exception in modlog or player.log?

jolly oriole May 8, 2021, 8:36 PM

#

custom 'particle' system

ornate rivet May 8, 2021, 9:18 PM

#

this is not pale court zaliant smh

jolly oriole May 8, 2021, 9:19 PM

#

no, this is a washing machine

#

old vid of it in action

#

wait, this is way better

floral blade May 9, 2021, 5:40 AM

#

This is not strictly a mod development discussion but, I've been thinking of possible ways to give players some control over their skins and while something like a vessel maker for actual in game sprites would be amazing, it's a herculean task to undertake (especially with limited art skills ). But even with just some masking and blending we can allow players some level of customisation to remix cloak colors & try different effects / knight combinations, linked is the POC of that concept.

https://prashantmohta.github.io/HollowKnight.SkinRemixer/

perhaps with more detailed masks for horns/eyes for example, we could reach closer to the goal of anybody being able to customise their own skins.

would like any thoughts/ suggestions on the concept.

pale crest May 9, 2021, 6:25 AM

#

making your own skin requires making custom sprites

#

requires a bit of BTS knowledge

floral blade May 9, 2021, 11:10 AM

#

pale crest making your own skin requires making custom sprites

Yes, this would require existing skins and blend them together

Like horns from skin 1 but cloak from skin 2 and eyes from skin 3 & attack effects from skin 4

#

That's the concept anyways

#

At the very least it makes recoloring default sprite super easy

#

#

For example I could recolour this on my phone

slender osprey May 9, 2021, 1:00 PM

#

Hi ! Sorry, noob question : I'm trying to compile the api (https://github.com/HollowKnight-Modding/HollowKnight.Modding), I followed the instructions up to step 4, but there's an error in the compile step : warning MSB3245: Could not resolve this reference. Could not locate the assembly "UnityEngine.InputLegacyModule, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null".
with Visual Studio 2019.

I have also tried using Rider which (after updating the C# version) gives me a different, more specific error in ModLoader.cs, ligne 305 on the "in":
ModLoader.cs(305, 66): [CS1061] 'KeyValuePair<string, List<string>>' does not contain a definition for 'Deconstruct' and no accessible extension method 'Deconstruct' accepting a first argument of type 'KeyValuePair<string, List<string>>' could be found (are you missing a using directive or an assembly reference?).

Do you have leads on either of these ?

#

(I can confirm I copied the Managed dir contents into a Vanilla directory from the last, up-to-date version)

worn eagle May 9, 2021, 1:02 PM

#

I ran into the latter issue and solved it by changing the deconstructed params to KeyValuePairs and then getting the params using .Key and .Value

slender osprey May 9, 2021, 1:03 PM

#

oh so this is a code issue ? I should probably open an issue on Github then

copper nacelle May 9, 2021, 1:11 PM

#

Are you compiling against the beta

vocal spire May 9, 2021, 1:11 PM

#

slender osprey Hi ! Sorry, noob question : I'm trying to compile the api (https://github.com/Ho...

Add a reference to that assembly in the hollow knight installation also why are you trying to compile it, finally where did you get the code

slender osprey May 9, 2021, 1:11 PM

#

oh I have a lead : according to this https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.keyvaluepair-2.deconstruct?view=netcore-2.0, the Deconstruct method is implemented in .Net 5.0

KeyValuePair.Deconstruct(TKey, TValue) Method (System.Collections.G...

Deconstructs the current KeyValuePair.

vocal spire May 9, 2021, 1:11 PM

#

If you got the code from 56’s repo then you have the code for the hk beta

#

It needs to be compiled with the beta

#

The opposite is also true

copper nacelle May 9, 2021, 1:12 PM

#

the main repo is literally ahead of my fork

slender osprey May 9, 2021, 1:13 PM

#

vocal spire Add a reference to that assembly in the hollow knight installation also why are ...

I followed the links in the sticky posts from this channel
I cloned it
I followed the README instructions

#

Don't I have to compile it ?